{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/35513280","id":35513280,"diff_hunk":"@@ -698,6 +698,57 @@ bool WsWuInfo::legacyHasSubGraphTimings()\n     return false;\n }\n \n+void WsWuInfo::getGraphs(WUGraphType graphType, IArrayOf<IEspECLGraph>& graphs)\n+{\n+    SCMStringBuffer runningGraph;\n+    WUGraphIDType id;\n+\n+    WUState st = cw->getState();\n+    bool running = (!(st==WUStateFailed || st==WUStateAborted || st==WUStateCompleted) && cw->getRunningGraph(runningGraph,id));\n+\n+    Owned<IConstWUGraphMetaIterator> it = &cw->getGraphsMeta(GraphTypeAny);","path":"esp/services/ws_workunits/ws_workunitsHelpers.cpp","position":12,"original_position":12,"commit_id":"3f608a71f21c33ef657db757f604dc961ea2cdee","original_commit_id":"3f608a71f21c33ef657db757f604dc961ea2cdee","user":{"login":"richardkchapman","id":900820,"avatar_url":"https://avatars.githubusercontent.com/u/900820?v=3","gravatar_id":"","url":"https://api.github.com/users/richardkchapman","html_url":"https://github.com/richardkchapman","followers_url":"https://api.github.com/users/richardkchapman/followers","following_url":"https://api.github.com/users/richardkchapman/following{/other_user}","gists_url":"https://api.github.com/users/richardkchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/richardkchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardkchapman/subscriptions","organizations_url":"https://api.github.com/users/richardkchapman/orgs","repos_url":"https://api.github.com/users/richardkchapman/repos","events_url":"https://api.github.com/users/richardkchapman/events{/privacy}","received_events_url":"https://api.github.com/users/richardkchapman/received_events","type":"User","site_admin":false},"body":"Why are you fetching all graphs then filtering yourself, rather than passing the type to getGraphsMeta? ","created_at":"2015-07-27T08:11:34Z","updated_at":"2015-07-27T08:11:34Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7610#discussion_r35513280","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7610","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/35513280"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/7610#discussion_r35513280"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7610"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7610","id":40788170,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7610","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7610.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7610.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7610","number":7610,"state":"open","locked":false,"title":"HPCC-13939 Add WsWorkunits.WUGraphQuery for graph list","user":{"login":"wangkx","id":903406,"avatar_url":"https://avatars.githubusercontent.com/u/903406?v=3","gravatar_id":"","url":"https://api.github.com/users/wangkx","html_url":"https://github.com/wangkx","followers_url":"https://api.github.com/users/wangkx/followers","following_url":"https://api.github.com/users/wangkx/following{/other_user}","gists_url":"https://api.github.com/users/wangkx/gists{/gist_id}","starred_url":"https://api.github.com/users/wangkx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangkx/subscriptions","organizations_url":"https://api.github.com/users/wangkx/orgs","repos_url":"https://api.github.com/users/wangkx/repos","events_url":"https://api.github.com/users/wangkx/events{/privacy}","received_events_url":"https://api.github.com/users/wangkx/received_events","type":"User","site_admin":false},"body":"This is a new API method which returns a list of graphs in\r\nan ECL workunit. The method has an option to say what kind\r\nof graphs you want listed.\r\n\r\nAlso modified the existing getGraphInfo() to share the\r\nsame code.\r\n\r\nSigned-off-by: wangkx <kevin.wang@lexisnexis.com>","created_at":"2015-07-24T15:45:11Z","updated_at":"2015-07-27T08:11:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e064c6910e433ebd41b38ca89ec4797e4fbfeee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7610/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7610/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7610/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/3f608a71f21c33ef657db757f604dc961ea2cdee","head":{"label":"wangkx:h13939","ref":"h13939","sha":"3f608a71f21c33ef657db757f604dc961ea2cdee","user":{"login":"wangkx","id":903406,"avatar_url":"https://avatars.githubusercontent.com/u/903406?v=3","gravatar_id":"","url":"https://api.github.com/users/wangkx","html_url":"https://github.com/wangkx","followers_url":"https://api.github.com/users/wangkx/followers","following_url":"https://api.github.com/users/wangkx/following{/other_user}","gists_url":"https://api.github.com/users/wangkx/gists{/gist_id}","starred_url":"https://api.github.com/users/wangkx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangkx/subscriptions","organizations_url":"https://api.github.com/users/wangkx/orgs","repos_url":"https://api.github.com/users/wangkx/repos","events_url":"https://api.github.com/users/wangkx/events{/privacy}","received_events_url":"https://api.github.com/users/wangkx/received_events","type":"User","site_admin":false},"repo":{"id":2199076,"name":"HPCC-Platform","full_name":"wangkx/HPCC-Platform","owner":{"login":"wangkx","id":903406,"avatar_url":"https://avatars.githubusercontent.com/u/903406?v=3","gravatar_id":"","url":"https://api.github.com/users/wangkx","html_url":"https://github.com/wangkx","followers_url":"https://api.github.com/users/wangkx/followers","following_url":"https://api.github.com/users/wangkx/following{/other_user}","gists_url":"https://api.github.com/users/wangkx/gists{/gist_id}","starred_url":"https://api.github.com/users/wangkx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangkx/subscriptions","organizations_url":"https://api.github.com/users/wangkx/orgs","repos_url":"https://api.github.com/users/wangkx/repos","events_url":"https://api.github.com/users/wangkx/events{/privacy}","received_events_url":"https://api.github.com/users/wangkx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wangkx/HPCC-Platform","description":"HPCC Systems big data solution, community edition","fork":true,"url":"https://api.github.com/repos/wangkx/HPCC-Platform","forks_url":"https://api.github.com/repos/wangkx/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/wangkx/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wangkx/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wangkx/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/wangkx/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/wangkx/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/wangkx/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/wangkx/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/wangkx/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/wangkx/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/wangkx/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wangkx/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wangkx/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/wangkx/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wangkx/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/wangkx/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/wangkx/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/wangkx/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/wangkx/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/wangkx/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/wangkx/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/wangkx/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/wangkx/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/wangkx/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/wangkx/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/wangkx/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wangkx/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/wangkx/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wangkx/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/wangkx/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/wangkx/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/wangkx/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/wangkx/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wangkx/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/wangkx/HPCC-Platform/releases{/id}","created_at":"2011-08-12T20:36:10Z","updated_at":"2015-03-02T20:07:00Z","pushed_at":"2015-07-25T20:52:45Z","git_url":"git://github.com/wangkx/HPCC-Platform.git","ssh_url":"git@github.com:wangkx/HPCC-Platform.git","clone_url":"https://github.com/wangkx/HPCC-Platform.git","svn_url":"https://github.com/wangkx/HPCC-Platform","homepage":"www.hpccsystems.com","size":153422,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"hpcc-systems:master","ref":"master","sha":"5514b01febd09ee26dd8e359d8411279dfa5cb4b","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","created_at":"2011-07-11T14:29:51Z","updated_at":"2015-07-21T10:02:19Z","pushed_at":"2015-07-27T08:09:26Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"track.hpccsystems.com","size":340120,"stargazers_count":253,"watchers_count":253,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"open_issues_count":426,"forks":118,"open_issues":426,"watchers":253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7610"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/7610"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7610"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7610/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7610/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7610/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/3f608a71f21c33ef657db757f604dc961ea2cdee"}}}}