{"action":"created","issue":{"url":"https://api.github.com/repos/lattice/quda/issues/234","labels_url":"https://api.github.com/repos/lattice/quda/issues/234/labels{/name}","comments_url":"https://api.github.com/repos/lattice/quda/issues/234/comments","events_url":"https://api.github.com/repos/lattice/quda/issues/234/events","html_url":"https://github.com/lattice/quda/issues/234","id":73704408,"number":234,"title":"Compile with warnings enabled and fix them","user":{"login":"mathiaswagner","id":4508207,"avatar_url":"https://avatars.githubusercontent.com/u/4508207?v=3","gravatar_id":"","url":"https://api.github.com/users/mathiaswagner","html_url":"https://github.com/mathiaswagner","followers_url":"https://api.github.com/users/mathiaswagner/followers","following_url":"https://api.github.com/users/mathiaswagner/following{/other_user}","gists_url":"https://api.github.com/users/mathiaswagner/gists{/gist_id}","starred_url":"https://api.github.com/users/mathiaswagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathiaswagner/subscriptions","organizations_url":"https://api.github.com/users/mathiaswagner/orgs","repos_url":"https://api.github.com/users/mathiaswagner/repos","events_url":"https://api.github.com/users/mathiaswagner/events{/privacy}","received_events_url":"https://api.github.com/users/mathiaswagner/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/lattice/quda/labels/clean-up","name":"clean-up","color":"9d45e6"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-06T18:44:08Z","updated_at":"2015-05-06T19:01:14Z","closed_at":null,"body":"By default we pass `-w` to nvcc which disables all warnings. While that might be a reasonable choice for the shipped version we should not use it during development.\r\n\r\nIt hides warning like\r\n\r\n```\r\n../include/gauge_field_order.h:237: warning: passing ‘double’ for argument 4 to ‘void quda::accumulateConjugateProduct(Float*, const Float*, const Float*, int) [with Float = double]’\r\n\r\ndslash_core/wilson_dslash_gt200_core.h(433): warning: subscript out of range\r\n          detected during:\r\n            instantiation of \"void quda::wilson::dslash18XpayKernel<kernel_type>(short4 *, float *, const short4 *, const short4 *, const short4 *, const float *, const short4 *, const float *, float, quda::wilson::DslashParam) [with kernel_type=quda::wilson::INTERIOR_KERNEL]\" \r\ndslash_wilson.cu(101): here\r\n            instantiation of \"void quda::WilsonDslashCuda<sFloat, gFloat>::apply(const cudaStream_t &) [with sFloat=short4, gFloat=short4]\" \r\ndslash_wilson.cu(90): here\r\n            instantiation of \"quda::WilsonDslashCuda<sFloat, gFloat>::WilsonDslashCuda(quda::cudaColorSpinorField *, const gFloat *, const gFloat *, QudaReconstructType, const quda::cudaColorSpinorField *, const quda::cudaColorSpinorField *, double, int) [with sFloat=short4, gFloat=short4]\" \r\ndslash_wilson.cu(149): here\r\n\r\n...\r\n\r\nWe also get a lot of warnings about variables not being used (probably depending on various configure options) but addressing some of the warnings does certainly not decrease code quality.\r\n"},"comment":{"url":"https://api.github.com/repos/lattice/quda/issues/comments/99574620","html_url":"https://github.com/lattice/quda/issues/234#issuecomment-99574620","issue_url":"https://api.github.com/repos/lattice/quda/issues/234","id":99574620,"user":{"login":"mathiaswagner","id":4508207,"avatar_url":"https://avatars.githubusercontent.com/u/4508207?v=3","gravatar_id":"","url":"https://api.github.com/users/mathiaswagner","html_url":"https://github.com/mathiaswagner","followers_url":"https://api.github.com/users/mathiaswagner/followers","following_url":"https://api.github.com/users/mathiaswagner/following{/other_user}","gists_url":"https://api.github.com/users/mathiaswagner/gists{/gist_id}","starred_url":"https://api.github.com/users/mathiaswagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathiaswagner/subscriptions","organizations_url":"https://api.github.com/users/mathiaswagner/orgs","repos_url":"https://api.github.com/users/mathiaswagner/repos","events_url":"https://api.github.com/users/mathiaswagner/events{/privacy}","received_events_url":"https://api.github.com/users/mathiaswagner/received_events","type":"User","site_admin":false},"created_at":"2015-05-06T19:01:14Z","updated_at":"2015-05-06T19:01:14Z","body":"```\r\ngit rev-list `git describe --abbrev=0`..  | wc -l\r\n```\r\nmight work with a check for being zero to disable warnings."}}