{"action":"created","comment":{"url":"https://api.github.com/repos/krico/jas/pulls/comments/38686702","id":38686702,"diff_hunk":"@@ -317,11 +318,9 @@ public Subscription addSubscription(User caller, @Named(\"userId\") Key userId, @N\n             HistoryHelper.addSubscriptionCreated(subscription.getId());\n             return subscription;\n         } catch (EntityNotFoundException e) {\n-            log.error(\"Failed to subscribe User={} to Activity={}\", userId, activityId); // TODO: Replace with event recorder","path":"schedule/schedule-appengine/src/main/java/com/jasify/schedule/appengine/spi/ActivityEndpoint.java","position":12,"original_position":12,"commit_id":"a819d18ec8851ae2f954b9f70eaa507c6cc5038b","original_commit_id":"a819d18ec8851ae2f954b9f70eaa507c6cc5038b","user":{"login":"krico","id":6952185,"avatar_url":"https://avatars.githubusercontent.com/u/6952185?v=3","gravatar_id":"","url":"https://api.github.com/users/krico","html_url":"https://github.com/krico","followers_url":"https://api.github.com/users/krico/followers","following_url":"https://api.github.com/users/krico/following{/other_user}","gists_url":"https://api.github.com/users/krico/gists{/gist_id}","starred_url":"https://api.github.com/users/krico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krico/subscriptions","organizations_url":"https://api.github.com/users/krico/orgs","repos_url":"https://api.github.com/users/krico/repos","events_url":"https://api.github.com/users/krico/events{/privacy}","received_events_url":"https://api.github.com/users/krico/received_events","type":"User","site_admin":false},"body":" 1. No history for this case?  \r\n 2. If we remove the logs, we will be blind...","created_at":"2015-09-03T19:31:43Z","updated_at":"2015-09-03T19:31:43Z","html_url":"https://github.com/krico/jas/pull/682#discussion_r38686702","pull_request_url":"https://api.github.com/repos/krico/jas/pulls/682","_links":{"self":{"href":"https://api.github.com/repos/krico/jas/pulls/comments/38686702"},"html":{"href":"https://github.com/krico/jas/pull/682#discussion_r38686702"},"pull_request":{"href":"https://api.github.com/repos/krico/jas/pulls/682"}}},"pull_request":{"url":"https://api.github.com/repos/krico/jas/pulls/682","id":44052192,"html_url":"https://github.com/krico/jas/pull/682","diff_url":"https://github.com/krico/jas/pull/682.diff","patch_url":"https://github.com/krico/jas/pull/682.patch","issue_url":"https://api.github.com/repos/krico/jas/issues/682","number":682,"state":"open","locked":false,"title":"Subscription history","user":{"login":"wszarmach","id":9398950,"avatar_url":"https://avatars.githubusercontent.com/u/9398950?v=3","gravatar_id":"","url":"https://api.github.com/users/wszarmach","html_url":"https://github.com/wszarmach","followers_url":"https://api.github.com/users/wszarmach/followers","following_url":"https://api.github.com/users/wszarmach/following{/other_user}","gists_url":"https://api.github.com/users/wszarmach/gists{/gist_id}","starred_url":"https://api.github.com/users/wszarmach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wszarmach/subscriptions","organizations_url":"https://api.github.com/users/wszarmach/orgs","repos_url":"https://api.github.com/users/wszarmach/repos","events_url":"https://api.github.com/users/wszarmach/events{/privacy}","received_events_url":"https://api.github.com/users/wszarmach/received_events","type":"User","site_admin":false},"body":"Changes based on feedback from previous PR.\r\n* SubscriptionCancelled history added via \"tactical\" solution :stuck_out_tongue_winking_eye:\r\n* Fixed bug where FieldValueException was not being handled correctly\r\n* Changed SubscriptionHistory to contain Subscription model rather than subscriptionId\r\n* Added subscription Created/Cancelled via payment workflow","created_at":"2015-09-02T22:49:20Z","updated_at":"2015-09-03T19:31:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"592fa82e4befd169cc8fcb0c83b4e94666c32605","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/krico/jas/pulls/682/commits","review_comments_url":"https://api.github.com/repos/krico/jas/pulls/682/comments","review_comment_url":"https://api.github.com/repos/krico/jas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/krico/jas/issues/682/comments","statuses_url":"https://api.github.com/repos/krico/jas/statuses/a819d18ec8851ae2f954b9f70eaa507c6cc5038b","head":{"label":"krico:SubscriptionHistory","ref":"SubscriptionHistory","sha":"a819d18ec8851ae2f954b9f70eaa507c6cc5038b","user":{"login":"krico","id":6952185,"avatar_url":"https://avatars.githubusercontent.com/u/6952185?v=3","gravatar_id":"","url":"https://api.github.com/users/krico","html_url":"https://github.com/krico","followers_url":"https://api.github.com/users/krico/followers","following_url":"https://api.github.com/users/krico/following{/other_user}","gists_url":"https://api.github.com/users/krico/gists{/gist_id}","starred_url":"https://api.github.com/users/krico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krico/subscriptions","organizations_url":"https://api.github.com/users/krico/orgs","repos_url":"https://api.github.com/users/krico/repos","events_url":"https://api.github.com/users/krico/events{/privacy}","received_events_url":"https://api.github.com/users/krico/received_events","type":"User","site_admin":false},"repo":{"id":25744696,"name":"jas","full_name":"krico/jas","owner":{"login":"krico","id":6952185,"avatar_url":"https://avatars.githubusercontent.com/u/6952185?v=3","gravatar_id":"","url":"https://api.github.com/users/krico","html_url":"https://github.com/krico","followers_url":"https://api.github.com/users/krico/followers","following_url":"https://api.github.com/users/krico/following{/other_user}","gists_url":"https://api.github.com/users/krico/gists{/gist_id}","starred_url":"https://api.github.com/users/krico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krico/subscriptions","organizations_url":"https://api.github.com/users/krico/orgs","repos_url":"https://api.github.com/users/krico/repos","events_url":"https://api.github.com/users/krico/events{/privacy}","received_events_url":"https://api.github.com/users/krico/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krico/jas","description":"Janes Asmussen Szarmach","fork":false,"url":"https://api.github.com/repos/krico/jas","forks_url":"https://api.github.com/repos/krico/jas/forks","keys_url":"https://api.github.com/repos/krico/jas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krico/jas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krico/jas/teams","hooks_url":"https://api.github.com/repos/krico/jas/hooks","issue_events_url":"https://api.github.com/repos/krico/jas/issues/events{/number}","events_url":"https://api.github.com/repos/krico/jas/events","assignees_url":"https://api.github.com/repos/krico/jas/assignees{/user}","branches_url":"https://api.github.com/repos/krico/jas/branches{/branch}","tags_url":"https://api.github.com/repos/krico/jas/tags","blobs_url":"https://api.github.com/repos/krico/jas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krico/jas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krico/jas/git/refs{/sha}","trees_url":"https://api.github.com/repos/krico/jas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krico/jas/statuses/{sha}","languages_url":"https://api.github.com/repos/krico/jas/languages","stargazers_url":"https://api.github.com/repos/krico/jas/stargazers","contributors_url":"https://api.github.com/repos/krico/jas/contributors","subscribers_url":"https://api.github.com/repos/krico/jas/subscribers","subscription_url":"https://api.github.com/repos/krico/jas/subscription","commits_url":"https://api.github.com/repos/krico/jas/commits{/sha}","git_commits_url":"https://api.github.com/repos/krico/jas/git/commits{/sha}","comments_url":"https://api.github.com/repos/krico/jas/comments{/number}","issue_comment_url":"https://api.github.com/repos/krico/jas/issues/comments{/number}","contents_url":"https://api.github.com/repos/krico/jas/contents/{+path}","compare_url":"https://api.github.com/repos/krico/jas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krico/jas/merges","archive_url":"https://api.github.com/repos/krico/jas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krico/jas/downloads","issues_url":"https://api.github.com/repos/krico/jas/issues{/number}","pulls_url":"https://api.github.com/repos/krico/jas/pulls{/number}","milestones_url":"https://api.github.com/repos/krico/jas/milestones{/number}","notifications_url":"https://api.github.com/repos/krico/jas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krico/jas/labels{/name}","releases_url":"https://api.github.com/repos/krico/jas/releases{/id}","created_at":"2014-10-25T20:01:46Z","updated_at":"2015-09-02T12:26:00Z","pushed_at":"2015-09-02T22:49:20Z","git_url":"git://github.com/krico/jas.git","ssh_url":"git@github.com:krico/jas.git","clone_url":"https://github.com/krico/jas.git","svn_url":"https://github.com/krico/jas","homepage":null,"size":14753,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":161,"forks":0,"open_issues":161,"watchers":3,"default_branch":"master"}},"base":{"label":"krico:master","ref":"master","sha":"4512c5359a4f15b212ad438c9341405e9b0e0507","user":{"login":"krico","id":6952185,"avatar_url":"https://avatars.githubusercontent.com/u/6952185?v=3","gravatar_id":"","url":"https://api.github.com/users/krico","html_url":"https://github.com/krico","followers_url":"https://api.github.com/users/krico/followers","following_url":"https://api.github.com/users/krico/following{/other_user}","gists_url":"https://api.github.com/users/krico/gists{/gist_id}","starred_url":"https://api.github.com/users/krico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krico/subscriptions","organizations_url":"https://api.github.com/users/krico/orgs","repos_url":"https://api.github.com/users/krico/repos","events_url":"https://api.github.com/users/krico/events{/privacy}","received_events_url":"https://api.github.com/users/krico/received_events","type":"User","site_admin":false},"repo":{"id":25744696,"name":"jas","full_name":"krico/jas","owner":{"login":"krico","id":6952185,"avatar_url":"https://avatars.githubusercontent.com/u/6952185?v=3","gravatar_id":"","url":"https://api.github.com/users/krico","html_url":"https://github.com/krico","followers_url":"https://api.github.com/users/krico/followers","following_url":"https://api.github.com/users/krico/following{/other_user}","gists_url":"https://api.github.com/users/krico/gists{/gist_id}","starred_url":"https://api.github.com/users/krico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krico/subscriptions","organizations_url":"https://api.github.com/users/krico/orgs","repos_url":"https://api.github.com/users/krico/repos","events_url":"https://api.github.com/users/krico/events{/privacy}","received_events_url":"https://api.github.com/users/krico/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krico/jas","description":"Janes Asmussen Szarmach","fork":false,"url":"https://api.github.com/repos/krico/jas","forks_url":"https://api.github.com/repos/krico/jas/forks","keys_url":"https://api.github.com/repos/krico/jas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krico/jas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krico/jas/teams","hooks_url":"https://api.github.com/repos/krico/jas/hooks","issue_events_url":"https://api.github.com/repos/krico/jas/issues/events{/number}","events_url":"https://api.github.com/repos/krico/jas/events","assignees_url":"https://api.github.com/repos/krico/jas/assignees{/user}","branches_url":"https://api.github.com/repos/krico/jas/branches{/branch}","tags_url":"https://api.github.com/repos/krico/jas/tags","blobs_url":"https://api.github.com/repos/krico/jas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krico/jas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krico/jas/git/refs{/sha}","trees_url":"https://api.github.com/repos/krico/jas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krico/jas/statuses/{sha}","languages_url":"https://api.github.com/repos/krico/jas/languages","stargazers_url":"https://api.github.com/repos/krico/jas/stargazers","contributors_url":"https://api.github.com/repos/krico/jas/contributors","subscribers_url":"https://api.github.com/repos/krico/jas/subscribers","subscription_url":"https://api.github.com/repos/krico/jas/subscription","commits_url":"https://api.github.com/repos/krico/jas/commits{/sha}","git_commits_url":"https://api.github.com/repos/krico/jas/git/commits{/sha}","comments_url":"https://api.github.com/repos/krico/jas/comments{/number}","issue_comment_url":"https://api.github.com/repos/krico/jas/issues/comments{/number}","contents_url":"https://api.github.com/repos/krico/jas/contents/{+path}","compare_url":"https://api.github.com/repos/krico/jas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krico/jas/merges","archive_url":"https://api.github.com/repos/krico/jas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krico/jas/downloads","issues_url":"https://api.github.com/repos/krico/jas/issues{/number}","pulls_url":"https://api.github.com/repos/krico/jas/pulls{/number}","milestones_url":"https://api.github.com/repos/krico/jas/milestones{/number}","notifications_url":"https://api.github.com/repos/krico/jas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krico/jas/labels{/name}","releases_url":"https://api.github.com/repos/krico/jas/releases{/id}","created_at":"2014-10-25T20:01:46Z","updated_at":"2015-09-02T12:26:00Z","pushed_at":"2015-09-02T22:49:20Z","git_url":"git://github.com/krico/jas.git","ssh_url":"git@github.com:krico/jas.git","clone_url":"https://github.com/krico/jas.git","svn_url":"https://github.com/krico/jas","homepage":null,"size":14753,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":161,"forks":0,"open_issues":161,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/krico/jas/pulls/682"},"html":{"href":"https://github.com/krico/jas/pull/682"},"issue":{"href":"https://api.github.com/repos/krico/jas/issues/682"},"comments":{"href":"https://api.github.com/repos/krico/jas/issues/682/comments"},"review_comments":{"href":"https://api.github.com/repos/krico/jas/pulls/682/comments"},"review_comment":{"href":"https://api.github.com/repos/krico/jas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/krico/jas/pulls/682/commits"},"statuses":{"href":"https://api.github.com/repos/krico/jas/statuses/a819d18ec8851ae2f954b9f70eaa507c6cc5038b"}}}}