{"action":"opened","number":54,"pull_request":{"url":"https://api.github.com/repos/mitsuhiko/redis-rs/pulls/54","id":40545640,"html_url":"https://github.com/mitsuhiko/redis-rs/pull/54","diff_url":"https://github.com/mitsuhiko/redis-rs/pull/54.diff","patch_url":"https://github.com/mitsuhiko/redis-rs/pull/54.patch","issue_url":"https://api.github.com/repos/mitsuhiko/redis-rs/issues/54","number":54,"state":"open","locked":false,"title":"Return early if there are no items to process","user":{"login":"badboy","id":2129,"avatar_url":"https://avatars.githubusercontent.com/u/2129?v=3","gravatar_id":"","url":"https://api.github.com/users/badboy","html_url":"https://github.com/badboy","followers_url":"https://api.github.com/users/badboy/followers","following_url":"https://api.github.com/users/badboy/following{/other_user}","gists_url":"https://api.github.com/users/badboy/gists{/gist_id}","starred_url":"https://api.github.com/users/badboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badboy/subscriptions","organizations_url":"https://api.github.com/users/badboy/orgs","repos_url":"https://api.github.com/users/badboy/repos","events_url":"https://api.github.com/users/badboy/events{/privacy}","received_events_url":"https://api.github.com/users/badboy/received_events","type":"User","site_admin":false},"body":"The result decoding will fail for empty return values where it expected an array.\r\n\r\nExample:\r\n\r\n```rust\r\n let zset : Vec<(String,u32)> = try!(con.zrangebyscore_withscores(\"non-existent-set\", 0, 3));\r\n```\r\n\r\nwill fail with:\r\n\r\n```\r\nthread '<main>' panicked at 'arithmetic operation overflowed', /home/badboy/.multirust/toolchains/stable/cargo/git/checkouts/redis-rs-44dbe34b2682f27b/master/src/types.rs:832\r\n```\r\n\r\nIt does not fail for a simple `Vec<String>`\r\nReturning early when we are sure there is nothing to parse will prevent this and return a useful empty vector.","created_at":"2015-07-22T09:26:14Z","updated_at":"2015-07-22T09:26:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mitsuhiko/redis-rs/pulls/54/commits","review_comments_url":"https://api.github.com/repos/mitsuhiko/redis-rs/pulls/54/comments","review_comment_url":"https://api.github.com/repos/mitsuhiko/redis-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mitsuhiko/redis-rs/issues/54/comments","statuses_url":"https://api.github.com/repos/mitsuhiko/redis-rs/statuses/45460719e4f0a922347c34544446c40a6f2f564f","head":{"label":"badboy:arith-overflow-fix","ref":"arith-overflow-fix","sha":"45460719e4f0a922347c34544446c40a6f2f564f","user":{"login":"badboy","id":2129,"avatar_url":"https://avatars.githubusercontent.com/u/2129?v=3","gravatar_id":"","url":"https://api.github.com/users/badboy","html_url":"https://github.com/badboy","followers_url":"https://api.github.com/users/badboy/followers","following_url":"https://api.github.com/users/badboy/following{/other_user}","gists_url":"https://api.github.com/users/badboy/gists{/gist_id}","starred_url":"https://api.github.com/users/badboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badboy/subscriptions","organizations_url":"https://api.github.com/users/badboy/orgs","repos_url":"https://api.github.com/users/badboy/repos","events_url":"https://api.github.com/users/badboy/events{/privacy}","received_events_url":"https://api.github.com/users/badboy/received_events","type":"User","site_admin":false},"repo":{"id":24674807,"name":"redis-rs","full_name":"badboy/redis-rs","owner":{"login":"badboy","id":2129,"avatar_url":"https://avatars.githubusercontent.com/u/2129?v=3","gravatar_id":"","url":"https://api.github.com/users/badboy","html_url":"https://github.com/badboy","followers_url":"https://api.github.com/users/badboy/followers","following_url":"https://api.github.com/users/badboy/following{/other_user}","gists_url":"https://api.github.com/users/badboy/gists{/gist_id}","starred_url":"https://api.github.com/users/badboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badboy/subscriptions","organizations_url":"https://api.github.com/users/badboy/orgs","repos_url":"https://api.github.com/users/badboy/repos","events_url":"https://api.github.com/users/badboy/events{/privacy}","received_events_url":"https://api.github.com/users/badboy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/badboy/redis-rs","description":"Redis library for rust","fork":true,"url":"https://api.github.com/repos/badboy/redis-rs","forks_url":"https://api.github.com/repos/badboy/redis-rs/forks","keys_url":"https://api.github.com/repos/badboy/redis-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/badboy/redis-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/badboy/redis-rs/teams","hooks_url":"https://api.github.com/repos/badboy/redis-rs/hooks","issue_events_url":"https://api.github.com/repos/badboy/redis-rs/issues/events{/number}","events_url":"https://api.github.com/repos/badboy/redis-rs/events","assignees_url":"https://api.github.com/repos/badboy/redis-rs/assignees{/user}","branches_url":"https://api.github.com/repos/badboy/redis-rs/branches{/branch}","tags_url":"https://api.github.com/repos/badboy/redis-rs/tags","blobs_url":"https://api.github.com/repos/badboy/redis-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/badboy/redis-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/badboy/redis-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/badboy/redis-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/badboy/redis-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/badboy/redis-rs/languages","stargazers_url":"https://api.github.com/repos/badboy/redis-rs/stargazers","contributors_url":"https://api.github.com/repos/badboy/redis-rs/contributors","subscribers_url":"https://api.github.com/repos/badboy/redis-rs/subscribers","subscription_url":"https://api.github.com/repos/badboy/redis-rs/subscription","commits_url":"https://api.github.com/repos/badboy/redis-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/badboy/redis-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/badboy/redis-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/badboy/redis-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/badboy/redis-rs/contents/{+path}","compare_url":"https://api.github.com/repos/badboy/redis-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/badboy/redis-rs/merges","archive_url":"https://api.github.com/repos/badboy/redis-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/badboy/redis-rs/downloads","issues_url":"https://api.github.com/repos/badboy/redis-rs/issues{/number}","pulls_url":"https://api.github.com/repos/badboy/redis-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/badboy/redis-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/badboy/redis-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/badboy/redis-rs/labels{/name}","releases_url":"https://api.github.com/repos/badboy/redis-rs/releases{/id}","created_at":"2014-10-01T10:45:05Z","updated_at":"2015-02-27T20:09:34Z","pushed_at":"2015-07-22T09:21:56Z","git_url":"git://github.com/badboy/redis-rs.git","ssh_url":"git@github.com:badboy/redis-rs.git","clone_url":"https://github.com/badboy/redis-rs.git","svn_url":"https://github.com/badboy/redis-rs","homepage":"http://mitsuhiko.github.io/redis-rs/","size":1087,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mitsuhiko:master","ref":"master","sha":"b437ee69f77e2cc6d7e3b80b08b7493c59f7522f","user":{"login":"mitsuhiko","id":7396,"avatar_url":"https://avatars.githubusercontent.com/u/7396?v=3","gravatar_id":"","url":"https://api.github.com/users/mitsuhiko","html_url":"https://github.com/mitsuhiko","followers_url":"https://api.github.com/users/mitsuhiko/followers","following_url":"https://api.github.com/users/mitsuhiko/following{/other_user}","gists_url":"https://api.github.com/users/mitsuhiko/gists{/gist_id}","starred_url":"https://api.github.com/users/mitsuhiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitsuhiko/subscriptions","organizations_url":"https://api.github.com/users/mitsuhiko/orgs","repos_url":"https://api.github.com/users/mitsuhiko/repos","events_url":"https://api.github.com/users/mitsuhiko/events{/privacy}","received_events_url":"https://api.github.com/users/mitsuhiko/received_events","type":"User","site_admin":false},"repo":{"id":15510677,"name":"redis-rs","full_name":"mitsuhiko/redis-rs","owner":{"login":"mitsuhiko","id":7396,"avatar_url":"https://avatars.githubusercontent.com/u/7396?v=3","gravatar_id":"","url":"https://api.github.com/users/mitsuhiko","html_url":"https://github.com/mitsuhiko","followers_url":"https://api.github.com/users/mitsuhiko/followers","following_url":"https://api.github.com/users/mitsuhiko/following{/other_user}","gists_url":"https://api.github.com/users/mitsuhiko/gists{/gist_id}","starred_url":"https://api.github.com/users/mitsuhiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitsuhiko/subscriptions","organizations_url":"https://api.github.com/users/mitsuhiko/orgs","repos_url":"https://api.github.com/users/mitsuhiko/repos","events_url":"https://api.github.com/users/mitsuhiko/events{/privacy}","received_events_url":"https://api.github.com/users/mitsuhiko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitsuhiko/redis-rs","description":"Redis library for rust","fork":false,"url":"https://api.github.com/repos/mitsuhiko/redis-rs","forks_url":"https://api.github.com/repos/mitsuhiko/redis-rs/forks","keys_url":"https://api.github.com/repos/mitsuhiko/redis-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitsuhiko/redis-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitsuhiko/redis-rs/teams","hooks_url":"https://api.github.com/repos/mitsuhiko/redis-rs/hooks","issue_events_url":"https://api.github.com/repos/mitsuhiko/redis-rs/issues/events{/number}","events_url":"https://api.github.com/repos/mitsuhiko/redis-rs/events","assignees_url":"https://api.github.com/repos/mitsuhiko/redis-rs/assignees{/user}","branches_url":"https://api.github.com/repos/mitsuhiko/redis-rs/branches{/branch}","tags_url":"https://api.github.com/repos/mitsuhiko/redis-rs/tags","blobs_url":"https://api.github.com/repos/mitsuhiko/redis-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitsuhiko/redis-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitsuhiko/redis-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitsuhiko/redis-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitsuhiko/redis-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/mitsuhiko/redis-rs/languages","stargazers_url":"https://api.github.com/repos/mitsuhiko/redis-rs/stargazers","contributors_url":"https://api.github.com/repos/mitsuhiko/redis-rs/contributors","subscribers_url":"https://api.github.com/repos/mitsuhiko/redis-rs/subscribers","subscription_url":"https://api.github.com/repos/mitsuhiko/redis-rs/subscription","commits_url":"https://api.github.com/repos/mitsuhiko/redis-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitsuhiko/redis-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitsuhiko/redis-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitsuhiko/redis-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitsuhiko/redis-rs/contents/{+path}","compare_url":"https://api.github.com/repos/mitsuhiko/redis-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitsuhiko/redis-rs/merges","archive_url":"https://api.github.com/repos/mitsuhiko/redis-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitsuhiko/redis-rs/downloads","issues_url":"https://api.github.com/repos/mitsuhiko/redis-rs/issues{/number}","pulls_url":"https://api.github.com/repos/mitsuhiko/redis-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/mitsuhiko/redis-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/mitsuhiko/redis-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitsuhiko/redis-rs/labels{/name}","releases_url":"https://api.github.com/repos/mitsuhiko/redis-rs/releases{/id}","created_at":"2013-12-29T15:46:50Z","updated_at":"2015-07-21T08:36:38Z","pushed_at":"2015-07-22T09:26:14Z","git_url":"git://github.com/mitsuhiko/redis-rs.git","ssh_url":"git@github.com:mitsuhiko/redis-rs.git","clone_url":"https://github.com/mitsuhiko/redis-rs.git","svn_url":"https://github.com/mitsuhiko/redis-rs","homepage":"http://mitsuhiko.github.io/redis-rs/","size":2090,"stargazers_count":289,"watchers_count":289,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":46,"mirror_url":null,"open_issues_count":13,"forks":46,"open_issues":13,"watchers":289,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mitsuhiko/redis-rs/pulls/54"},"html":{"href":"https://github.com/mitsuhiko/redis-rs/pull/54"},"issue":{"href":"https://api.github.com/repos/mitsuhiko/redis-rs/issues/54"},"comments":{"href":"https://api.github.com/repos/mitsuhiko/redis-rs/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/mitsuhiko/redis-rs/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/mitsuhiko/redis-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mitsuhiko/redis-rs/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/mitsuhiko/redis-rs/statuses/45460719e4f0a922347c34544446c40a6f2f564f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":0,"changed_files":1}}