{"action":"created","issue":{"url":"https://api.github.com/repos/cylc/cylc/issues/1401","labels_url":"https://api.github.com/repos/cylc/cylc/issues/1401/labels{/name}","comments_url":"https://api.github.com/repos/cylc/cylc/issues/1401/comments","events_url":"https://api.github.com/repos/cylc/cylc/issues/1401/events","html_url":"https://github.com/cylc/cylc/pull/1401","id":65810435,"number":1401,"title":"Edit run - confirmation prompts","user":{"login":"hjoliver","id":2362137,"avatar_url":"https://avatars.githubusercontent.com/u/2362137?v=3","gravatar_id":"","url":"https://api.github.com/users/hjoliver","html_url":"https://github.com/hjoliver","followers_url":"https://api.github.com/users/hjoliver/followers","following_url":"https://api.github.com/users/hjoliver/following{/other_user}","gists_url":"https://api.github.com/users/hjoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/hjoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjoliver/subscriptions","organizations_url":"https://api.github.com/users/hjoliver/orgs","repos_url":"https://api.github.com/users/hjoliver/repos","events_url":"https://api.github.com/users/hjoliver/events{/privacy}","received_events_url":"https://api.github.com/users/hjoliver/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"matthewrmshin","id":908613,"avatar_url":"https://avatars.githubusercontent.com/u/908613?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewrmshin","html_url":"https://github.com/matthewrmshin","followers_url":"https://api.github.com/users/matthewrmshin/followers","following_url":"https://api.github.com/users/matthewrmshin/following{/other_user}","gists_url":"https://api.github.com/users/matthewrmshin/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewrmshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewrmshin/subscriptions","organizations_url":"https://api.github.com/users/matthewrmshin/orgs","repos_url":"https://api.github.com/users/matthewrmshin/repos","events_url":"https://api.github.com/users/matthewrmshin/events{/privacy}","received_events_url":"https://api.github.com/users/matthewrmshin/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/cylc/cylc/milestones/36","html_url":"https://github.com/cylc/cylc/milestones/next-release","labels_url":"https://api.github.com/repos/cylc/cylc/milestones/36/labels","id":992714,"number":36,"title":"next-release","description":"","creator":{"login":"benfitzpatrick","id":1138333,"avatar_url":"https://avatars.githubusercontent.com/u/1138333?v=3","gravatar_id":"","url":"https://api.github.com/users/benfitzpatrick","html_url":"https://github.com/benfitzpatrick","followers_url":"https://api.github.com/users/benfitzpatrick/followers","following_url":"https://api.github.com/users/benfitzpatrick/following{/other_user}","gists_url":"https://api.github.com/users/benfitzpatrick/gists{/gist_id}","starred_url":"https://api.github.com/users/benfitzpatrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfitzpatrick/subscriptions","organizations_url":"https://api.github.com/users/benfitzpatrick/orgs","repos_url":"https://api.github.com/users/benfitzpatrick/repos","events_url":"https://api.github.com/users/benfitzpatrick/events{/privacy}","received_events_url":"https://api.github.com/users/benfitzpatrick/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":53,"state":"open","created_at":"2015-02-24T09:48:16Z","updated_at":"2015-04-08T09:57:26Z","due_on":"2015-04-07T12:00:00Z","closed_at":null},"comments":8,"created_at":"2015-04-02T01:13:59Z","updated_at":"2015-04-08T11:36:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cylc/cylc/pulls/1401","html_url":"https://github.com/cylc/cylc/pull/1401","diff_url":"https://github.com/cylc/cylc/pull/1401.diff","patch_url":"https://github.com/cylc/cylc/pull/1401.patch"},"body":"This adds a post-edit confirmation prompt (CLI and GUI) to the new edit run feature, which allows users to back out if they think they have screwed up the edit (another one for BoM).\r\n\r\nIt also fixes a number of bugs identified while implementing this:\r\n * edit runs failed on tasks that hadn't run yet, and those that had run prior to a suite restart, because the job file path hadn't been computed in the task proxy yet.\r\n * if interactive command prompts were turned on in global config, the GUI prompts would always return False (abort the command).  Presumably no one uses interactive prompting\r\n * removed unused --notify-completion command options\r\n * a few command args were still not undergoing cycle point standardisation (i.e. conversion to the suite's cycle point format) in the daemon, so the command would fail if you used a different format\r\n "},"comment":{"url":"https://api.github.com/repos/cylc/cylc/issues/comments/90887023","html_url":"https://github.com/cylc/cylc/pull/1401#issuecomment-90887023","issue_url":"https://api.github.com/repos/cylc/cylc/issues/1401","id":90887023,"user":{"login":"hjoliver","id":2362137,"avatar_url":"https://avatars.githubusercontent.com/u/2362137?v=3","gravatar_id":"","url":"https://api.github.com/users/hjoliver","html_url":"https://github.com/hjoliver","followers_url":"https://api.github.com/users/hjoliver/followers","following_url":"https://api.github.com/users/hjoliver/following{/other_user}","gists_url":"https://api.github.com/users/hjoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/hjoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjoliver/subscriptions","organizations_url":"https://api.github.com/users/hjoliver/orgs","repos_url":"https://api.github.com/users/hjoliver/repos","events_url":"https://api.github.com/users/hjoliver/events{/privacy}","received_events_url":"https://api.github.com/users/hjoliver/received_events","type":"User","site_admin":false},"created_at":"2015-04-08T11:36:07Z","updated_at":"2015-04-08T11:36:07Z","body":"@arjclark - the last commit writes \"This edit run was aborted\" to ```job.out``` and ```job.err``` in the job log dir, if the edit run is aborted.  Maybe it would be preferable to get the suite daemon to back off the task proxy's submit numbe, delete the new job log directory, and redo the ```NN``` symlink - as if the edit run was never initiated at all - but I think that is arguable as well as harder to achieve."}}