{"action":"created","issue":{"url":"https://api.github.com/repos/mkdocs/mkdocs/issues/729","labels_url":"https://api.github.com/repos/mkdocs/mkdocs/issues/729/labels{/name}","comments_url":"https://api.github.com/repos/mkdocs/mkdocs/issues/729/comments","events_url":"https://api.github.com/repos/mkdocs/mkdocs/issues/729/events","html_url":"https://github.com/mkdocs/mkdocs/pull/729","id":107770264,"number":729,"title":"correct site_url in sitemap","user":{"login":"samuelcolvin","id":4039449,"avatar_url":"https://avatars.githubusercontent.com/u/4039449?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelcolvin","html_url":"https://github.com/samuelcolvin","followers_url":"https://api.github.com/users/samuelcolvin/followers","following_url":"https://api.github.com/users/samuelcolvin/following{/other_user}","gists_url":"https://api.github.com/users/samuelcolvin/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelcolvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelcolvin/subscriptions","organizations_url":"https://api.github.com/users/samuelcolvin/orgs","repos_url":"https://api.github.com/users/samuelcolvin/repos","events_url":"https://api.github.com/users/samuelcolvin/events{/privacy}","received_events_url":"https://api.github.com/users/samuelcolvin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-22T18:16:56Z","updated_at":"2015-09-22T18:33:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mkdocs/mkdocs/pulls/729","html_url":"https://github.com/mkdocs/mkdocs/pull/729","diff_url":"https://github.com/mkdocs/mkdocs/pull/729.diff","patch_url":"https://github.com/mkdocs/mkdocs/pull/729.patch"},"body":"I'm currently getting `<loc>None/</loc>` in my sitemap, see http://help.tutorcruncher.com/sitemap.xml\r\n\r\nI believe this should fix it however we should probably add a test, where would be the best place for the test to go?\r\n\r\nI can see that the real solution is to set `site_url`, either mkdocs should deal better with no `site_url` or it should be required."},"comment":{"url":"https://api.github.com/repos/mkdocs/mkdocs/issues/comments/142375608","html_url":"https://github.com/mkdocs/mkdocs/pull/729#issuecomment-142375608","issue_url":"https://api.github.com/repos/mkdocs/mkdocs/issues/729","id":142375608,"user":{"login":"waylan","id":78846,"avatar_url":"https://avatars.githubusercontent.com/u/78846?v=3","gravatar_id":"","url":"https://api.github.com/users/waylan","html_url":"https://github.com/waylan","followers_url":"https://api.github.com/users/waylan/followers","following_url":"https://api.github.com/users/waylan/following{/other_user}","gists_url":"https://api.github.com/users/waylan/gists{/gist_id}","starred_url":"https://api.github.com/users/waylan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waylan/subscriptions","organizations_url":"https://api.github.com/users/waylan/orgs","repos_url":"https://api.github.com/users/waylan/repos","events_url":"https://api.github.com/users/waylan/events{/privacy}","received_events_url":"https://api.github.com/users/waylan/received_events","type":"User","site_admin":false},"created_at":"2015-09-22T18:33:39Z","updated_at":"2015-09-22T18:33:39Z","body":"I wonder if a better fix would be to set the default to an empty string (`''`) rather than `None`. Change [`mkdocs/config/defaults.py L27`][1] as follows:\r\n\r\n```diff\r\n- ('site_url', config_options.URL()),\r\n+ ('site_url', config_options.URL(default='')),\r\n```\r\n\r\nMy only hesitation is that perhaps somewhere the code is relying on the `None` value for behavior. Hopefully the tests would catch that. Unfortunately, I'm not able to check into it right now.\r\n\r\n[1]: https://github.com/mkdocs/mkdocs/blob/master/mkdocs/config/defaults.py#L27"}}