{"action":"closed","number":35,"pull_request":{"url":"https://api.github.com/repos/Microsoft/tfs-cli/pulls/35","id":44689214,"html_url":"https://github.com/Microsoft/tfs-cli/pull/35","diff_url":"https://github.com/Microsoft/tfs-cli/pull/35.diff","patch_url":"https://github.com/Microsoft/tfs-cli/pull/35.patch","issue_url":"https://api.github.com/repos/Microsoft/tfs-cli/issues/35","number":35,"state":"closed","locked":false,"title":"Build improvements","user":{"login":"joaomoreno","id":22350,"avatar_url":"https://avatars.githubusercontent.com/u/22350?v=3","gravatar_id":"","url":"https://api.github.com/users/joaomoreno","html_url":"https://github.com/joaomoreno","followers_url":"https://api.github.com/users/joaomoreno/followers","following_url":"https://api.github.com/users/joaomoreno/following{/other_user}","gists_url":"https://api.github.com/users/joaomoreno/gists{/gist_id}","starred_url":"https://api.github.com/users/joaomoreno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaomoreno/subscriptions","organizations_url":"https://api.github.com/users/joaomoreno/orgs","repos_url":"https://api.github.com/users/joaomoreno/repos","events_url":"https://api.github.com/users/joaomoreno/events{/privacy}","received_events_url":"https://api.github.com/users/joaomoreno/received_events","type":"User","site_admin":false},"body":"This PR does a few improvements around the building:\r\n\r\n* **Use [`gulp-tsb`](https://www.npmjs.com/package/gulp-tsb)**. It's simply a better approach at using TypeScript with gulp. We use it to develop VSCode.\r\n* **Add `tsconfig.json`**. This serves both as a configuration for the compiler used in gulp, as well as a configuration for VS Code (and other tools), when editing the project. This enables dropping the nasty `/// <reference...` snippets.\r\n* **Simplify the gulp tasks**. Instead of having multiple, interdependent tasks, just have one that does the build all at once. Gulp streams here help us out in a very nice way.\r\n* **Fix `npm link`**. Currently it is not possible to run `npm link` because `package.json` points to `./tfx-cli.js`, which never exists at development time, since `package.json` is copied to the `_build` directory as part of the build step.\r\n* **Add `.npmignore`**. So we can take away all the cruft from the node module, once it's published to npm.\r\n* **Add `prepublish` step to `package.json`**. So `gulp build` gets run everything someone runs `npm link` or `npm publish`.","created_at":"2015-09-10T16:27:20Z","updated_at":"2015-09-10T20:50:59Z","closed_at":"2015-09-10T20:50:59Z","merged_at":"2015-09-10T20:50:59Z","merge_commit_sha":"94a87fc284bbf0275f5afcd6dca3b0bb5d0ead5e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/tfs-cli/pulls/35/commits","review_comments_url":"https://api.github.com/repos/Microsoft/tfs-cli/pulls/35/comments","review_comment_url":"https://api.github.com/repos/Microsoft/tfs-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/tfs-cli/issues/35/comments","statuses_url":"https://api.github.com/repos/Microsoft/tfs-cli/statuses/d1de8f725bda29b9b392720472292e8a0176704a","head":{"label":"joaomoreno:build","ref":"build","sha":"d1de8f725bda29b9b392720472292e8a0176704a","user":{"login":"joaomoreno","id":22350,"avatar_url":"https://avatars.githubusercontent.com/u/22350?v=3","gravatar_id":"","url":"https://api.github.com/users/joaomoreno","html_url":"https://github.com/joaomoreno","followers_url":"https://api.github.com/users/joaomoreno/followers","following_url":"https://api.github.com/users/joaomoreno/following{/other_user}","gists_url":"https://api.github.com/users/joaomoreno/gists{/gist_id}","starred_url":"https://api.github.com/users/joaomoreno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaomoreno/subscriptions","organizations_url":"https://api.github.com/users/joaomoreno/orgs","repos_url":"https://api.github.com/users/joaomoreno/repos","events_url":"https://api.github.com/users/joaomoreno/events{/privacy}","received_events_url":"https://api.github.com/users/joaomoreno/received_events","type":"User","site_admin":false},"repo":{"id":42254036,"name":"tfs-cli","full_name":"joaomoreno/tfs-cli","owner":{"login":"joaomoreno","id":22350,"avatar_url":"https://avatars.githubusercontent.com/u/22350?v=3","gravatar_id":"","url":"https://api.github.com/users/joaomoreno","html_url":"https://github.com/joaomoreno","followers_url":"https://api.github.com/users/joaomoreno/followers","following_url":"https://api.github.com/users/joaomoreno/following{/other_user}","gists_url":"https://api.github.com/users/joaomoreno/gists{/gist_id}","starred_url":"https://api.github.com/users/joaomoreno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaomoreno/subscriptions","organizations_url":"https://api.github.com/users/joaomoreno/orgs","repos_url":"https://api.github.com/users/joaomoreno/repos","events_url":"https://api.github.com/users/joaomoreno/events{/privacy}","received_events_url":"https://api.github.com/users/joaomoreno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joaomoreno/tfs-cli","description":"TFS Cross Platform Command Line","fork":true,"url":"https://api.github.com/repos/joaomoreno/tfs-cli","forks_url":"https://api.github.com/repos/joaomoreno/tfs-cli/forks","keys_url":"https://api.github.com/repos/joaomoreno/tfs-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joaomoreno/tfs-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joaomoreno/tfs-cli/teams","hooks_url":"https://api.github.com/repos/joaomoreno/tfs-cli/hooks","issue_events_url":"https://api.github.com/repos/joaomoreno/tfs-cli/issues/events{/number}","events_url":"https://api.github.com/repos/joaomoreno/tfs-cli/events","assignees_url":"https://api.github.com/repos/joaomoreno/tfs-cli/assignees{/user}","branches_url":"https://api.github.com/repos/joaomoreno/tfs-cli/branches{/branch}","tags_url":"https://api.github.com/repos/joaomoreno/tfs-cli/tags","blobs_url":"https://api.github.com/repos/joaomoreno/tfs-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joaomoreno/tfs-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joaomoreno/tfs-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/joaomoreno/tfs-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joaomoreno/tfs-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/joaomoreno/tfs-cli/languages","stargazers_url":"https://api.github.com/repos/joaomoreno/tfs-cli/stargazers","contributors_url":"https://api.github.com/repos/joaomoreno/tfs-cli/contributors","subscribers_url":"https://api.github.com/repos/joaomoreno/tfs-cli/subscribers","subscription_url":"https://api.github.com/repos/joaomoreno/tfs-cli/subscription","commits_url":"https://api.github.com/repos/joaomoreno/tfs-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/joaomoreno/tfs-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/joaomoreno/tfs-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/joaomoreno/tfs-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/joaomoreno/tfs-cli/contents/{+path}","compare_url":"https://api.github.com/repos/joaomoreno/tfs-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joaomoreno/tfs-cli/merges","archive_url":"https://api.github.com/repos/joaomoreno/tfs-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joaomoreno/tfs-cli/downloads","issues_url":"https://api.github.com/repos/joaomoreno/tfs-cli/issues{/number}","pulls_url":"https://api.github.com/repos/joaomoreno/tfs-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/joaomoreno/tfs-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/joaomoreno/tfs-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joaomoreno/tfs-cli/labels{/name}","releases_url":"https://api.github.com/repos/joaomoreno/tfs-cli/releases{/id}","created_at":"2015-09-10T15:42:17Z","updated_at":"2015-09-10T15:42:18Z","pushed_at":"2015-09-10T16:23:55Z","git_url":"git://github.com/joaomoreno/tfs-cli.git","ssh_url":"git@github.com:joaomoreno/tfs-cli.git","clone_url":"https://github.com/joaomoreno/tfs-cli.git","svn_url":"https://github.com/joaomoreno/tfs-cli","homepage":null,"size":1414,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"2e3b724e1356129c0dfadd315076bad6a73684b8","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":39497254,"name":"tfs-cli","full_name":"Microsoft/tfs-cli","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/tfs-cli","description":"TFS Cross Platform Command Line","fork":false,"url":"https://api.github.com/repos/Microsoft/tfs-cli","forks_url":"https://api.github.com/repos/Microsoft/tfs-cli/forks","keys_url":"https://api.github.com/repos/Microsoft/tfs-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/tfs-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/tfs-cli/teams","hooks_url":"https://api.github.com/repos/Microsoft/tfs-cli/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/tfs-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/tfs-cli/events","assignees_url":"https://api.github.com/repos/Microsoft/tfs-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/tfs-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/tfs-cli/tags","blobs_url":"https://api.github.com/repos/Microsoft/tfs-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/tfs-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/tfs-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/tfs-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/tfs-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/tfs-cli/languages","stargazers_url":"https://api.github.com/repos/Microsoft/tfs-cli/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/tfs-cli/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/tfs-cli/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/tfs-cli/subscription","commits_url":"https://api.github.com/repos/Microsoft/tfs-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/tfs-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/tfs-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/tfs-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/tfs-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/tfs-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/tfs-cli/merges","archive_url":"https://api.github.com/repos/Microsoft/tfs-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/tfs-cli/downloads","issues_url":"https://api.github.com/repos/Microsoft/tfs-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/tfs-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/tfs-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/tfs-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/tfs-cli/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/tfs-cli/releases{/id}","created_at":"2015-07-22T09:23:42Z","updated_at":"2015-09-10T16:31:06Z","pushed_at":"2015-09-10T20:50:59Z","git_url":"git://github.com/Microsoft/tfs-cli.git","ssh_url":"git@github.com:Microsoft/tfs-cli.git","clone_url":"https://github.com/Microsoft/tfs-cli.git","svn_url":"https://github.com/Microsoft/tfs-cli","homepage":null,"size":1414,"stargazers_count":22,"watchers_count":22,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":6,"forks":7,"open_issues":6,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/tfs-cli/pulls/35"},"html":{"href":"https://github.com/Microsoft/tfs-cli/pull/35"},"issue":{"href":"https://api.github.com/repos/Microsoft/tfs-cli/issues/35"},"comments":{"href":"https://api.github.com/repos/Microsoft/tfs-cli/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/tfs-cli/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/tfs-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/tfs-cli/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/tfs-cli/statuses/d1de8f725bda29b9b392720472292e8a0176704a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"trevorsg","id":397836,"avatar_url":"https://avatars.githubusercontent.com/u/397836?v=3","gravatar_id":"","url":"https://api.github.com/users/trevorsg","html_url":"https://github.com/trevorsg","followers_url":"https://api.github.com/users/trevorsg/followers","following_url":"https://api.github.com/users/trevorsg/following{/other_user}","gists_url":"https://api.github.com/users/trevorsg/gists{/gist_id}","starred_url":"https://api.github.com/users/trevorsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevorsg/subscriptions","organizations_url":"https://api.github.com/users/trevorsg/orgs","repos_url":"https://api.github.com/users/trevorsg/repos","events_url":"https://api.github.com/users/trevorsg/events{/privacy}","received_events_url":"https://api.github.com/users/trevorsg/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":3,"additions":40,"deletions":67,"changed_files":13}}