{"action":"closed","number":3036,"pull_request":{"url":"https://api.github.com/repos/emberjs/data/pulls/3036","id":34593038,"html_url":"https://github.com/emberjs/data/pull/3036","diff_url":"https://github.com/emberjs/data/pull/3036.diff","patch_url":"https://github.com/emberjs/data/pull/3036.patch","issue_url":"https://api.github.com/repos/emberjs/data/issues/3036","number":3036,"state":"closed","locked":false,"title":"Remove logic for camelCase-ing error keys in ActiveModelAdapter","user":{"login":"pangratz","id":341877,"avatar_url":"https://avatars.githubusercontent.com/u/341877?v=3","gravatar_id":"","url":"https://api.github.com/users/pangratz","html_url":"https://github.com/pangratz","followers_url":"https://api.github.com/users/pangratz/followers","following_url":"https://api.github.com/users/pangratz/following{/other_user}","gists_url":"https://api.github.com/users/pangratz/gists{/gist_id}","starred_url":"https://api.github.com/users/pangratz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pangratz/subscriptions","organizations_url":"https://api.github.com/users/pangratz/orgs","repos_url":"https://api.github.com/users/pangratz/repos","events_url":"https://api.github.com/users/pangratz/events{/privacy}","received_events_url":"https://api.github.com/users/pangratz/received_events","type":"User","site_admin":false},"body":"This addresses my comment made in https://github.com/emberjs/data/pull/3030#issuecomment-98396379, where I stated that the made changes of camelCase-ing the error keys are a serializer concern:\r\n\r\nSince c947e25 (introduced in #3030) the keys of the error object are camelCased in the adapter, which is actually a serializer concern. The JSONSerializer, from which the ActiveModelSerializer extends, does a normalization of the errors object in the `extractErrors` hook (see http://git.io/vJ0A6 & http://git.io/vJ0AS) and this hook gets called by the store when the adapter rejects (see http://git.io/vJ0AI), the camelCase can be removed from inside the adapter.\r\n\r\ncc @fivetanley @bdvholmes","created_at":"2015-05-02T22:38:18Z","updated_at":"2015-05-04T10:39:48Z","closed_at":"2015-05-04T10:39:48Z","merged_at":"2015-05-04T10:39:48Z","merge_commit_sha":"c4b884c07d8d79c52367a96940e20252cdcd27c7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/data/pulls/3036/commits","review_comments_url":"https://api.github.com/repos/emberjs/data/pulls/3036/comments","review_comment_url":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/data/issues/3036/comments","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/8fd4718d115bc3ee6ca1e0053abe5e6508f645c2","head":{"label":"pangratz:cleanup_camelisation_of_active_model_errors","ref":"cleanup_camelisation_of_active_model_errors","sha":"8fd4718d115bc3ee6ca1e0053abe5e6508f645c2","user":{"login":"pangratz","id":341877,"avatar_url":"https://avatars.githubusercontent.com/u/341877?v=3","gravatar_id":"","url":"https://api.github.com/users/pangratz","html_url":"https://github.com/pangratz","followers_url":"https://api.github.com/users/pangratz/followers","following_url":"https://api.github.com/users/pangratz/following{/other_user}","gists_url":"https://api.github.com/users/pangratz/gists{/gist_id}","starred_url":"https://api.github.com/users/pangratz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pangratz/subscriptions","organizations_url":"https://api.github.com/users/pangratz/orgs","repos_url":"https://api.github.com/users/pangratz/repos","events_url":"https://api.github.com/users/pangratz/events{/privacy}","received_events_url":"https://api.github.com/users/pangratz/received_events","type":"User","site_admin":false},"repo":{"id":3021258,"name":"data","full_name":"pangratz/data","owner":{"login":"pangratz","id":341877,"avatar_url":"https://avatars.githubusercontent.com/u/341877?v=3","gravatar_id":"","url":"https://api.github.com/users/pangratz","html_url":"https://github.com/pangratz","followers_url":"https://api.github.com/users/pangratz/followers","following_url":"https://api.github.com/users/pangratz/following{/other_user}","gists_url":"https://api.github.com/users/pangratz/gists{/gist_id}","starred_url":"https://api.github.com/users/pangratz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pangratz/subscriptions","organizations_url":"https://api.github.com/users/pangratz/orgs","repos_url":"https://api.github.com/users/pangratz/repos","events_url":"https://api.github.com/users/pangratz/events{/privacy}","received_events_url":"https://api.github.com/users/pangratz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pangratz/data","description":"A data persistence library for Ember.js.","fork":true,"url":"https://api.github.com/repos/pangratz/data","forks_url":"https://api.github.com/repos/pangratz/data/forks","keys_url":"https://api.github.com/repos/pangratz/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pangratz/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pangratz/data/teams","hooks_url":"https://api.github.com/repos/pangratz/data/hooks","issue_events_url":"https://api.github.com/repos/pangratz/data/issues/events{/number}","events_url":"https://api.github.com/repos/pangratz/data/events","assignees_url":"https://api.github.com/repos/pangratz/data/assignees{/user}","branches_url":"https://api.github.com/repos/pangratz/data/branches{/branch}","tags_url":"https://api.github.com/repos/pangratz/data/tags","blobs_url":"https://api.github.com/repos/pangratz/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pangratz/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pangratz/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/pangratz/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pangratz/data/statuses/{sha}","languages_url":"https://api.github.com/repos/pangratz/data/languages","stargazers_url":"https://api.github.com/repos/pangratz/data/stargazers","contributors_url":"https://api.github.com/repos/pangratz/data/contributors","subscribers_url":"https://api.github.com/repos/pangratz/data/subscribers","subscription_url":"https://api.github.com/repos/pangratz/data/subscription","commits_url":"https://api.github.com/repos/pangratz/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/pangratz/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/pangratz/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/pangratz/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/pangratz/data/contents/{+path}","compare_url":"https://api.github.com/repos/pangratz/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pangratz/data/merges","archive_url":"https://api.github.com/repos/pangratz/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pangratz/data/downloads","issues_url":"https://api.github.com/repos/pangratz/data/issues{/number}","pulls_url":"https://api.github.com/repos/pangratz/data/pulls{/number}","milestones_url":"https://api.github.com/repos/pangratz/data/milestones{/number}","notifications_url":"https://api.github.com/repos/pangratz/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pangratz/data/labels{/name}","releases_url":"https://api.github.com/repos/pangratz/data/releases{/id}","created_at":"2011-12-20T17:39:07Z","updated_at":"2015-05-04T09:45:22Z","pushed_at":"2015-05-04T09:53:56Z","git_url":"git://github.com/pangratz/data.git","ssh_url":"git@github.com:pangratz/data.git","clone_url":"https://github.com/pangratz/data.git","svn_url":"https://github.com/pangratz/data","homepage":"","size":6843,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"f129656cb0bc0e7a37b303bf7de4d58d76fbeb95","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":3016562,"name":"data","full_name":"emberjs/data","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/data","description":"A data persistence library for Ember.js.","fork":false,"url":"https://api.github.com/repos/emberjs/data","forks_url":"https://api.github.com/repos/emberjs/data/forks","keys_url":"https://api.github.com/repos/emberjs/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/data/teams","hooks_url":"https://api.github.com/repos/emberjs/data/hooks","issue_events_url":"https://api.github.com/repos/emberjs/data/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/data/events","assignees_url":"https://api.github.com/repos/emberjs/data/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/data/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/data/tags","blobs_url":"https://api.github.com/repos/emberjs/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/data/languages","stargazers_url":"https://api.github.com/repos/emberjs/data/stargazers","contributors_url":"https://api.github.com/repos/emberjs/data/contributors","subscribers_url":"https://api.github.com/repos/emberjs/data/subscribers","subscription_url":"https://api.github.com/repos/emberjs/data/subscription","commits_url":"https://api.github.com/repos/emberjs/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/data/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/data/merges","archive_url":"https://api.github.com/repos/emberjs/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/data/downloads","issues_url":"https://api.github.com/repos/emberjs/data/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/data/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/data/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/data/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/data/releases{/id}","created_at":"2011-12-20T01:50:40Z","updated_at":"2015-05-04T09:44:49Z","pushed_at":"2015-05-04T10:39:48Z","git_url":"git://github.com/emberjs/data.git","ssh_url":"git@github.com:emberjs/data.git","clone_url":"https://github.com/emberjs/data.git","svn_url":"https://github.com/emberjs/data","homepage":"","size":26879,"stargazers_count":2344,"watchers_count":2344,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":893,"mirror_url":null,"open_issues_count":272,"forks":893,"open_issues":272,"watchers":2344,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/3036"},"html":{"href":"https://github.com/emberjs/data/pull/3036"},"issue":{"href":"https://api.github.com/repos/emberjs/data/issues/3036"},"comments":{"href":"https://api.github.com/repos/emberjs/data/issues/3036/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/data/pulls/3036/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/data/pulls/3036/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/data/statuses/8fd4718d115bc3ee6ca1e0053abe5e6508f645c2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"igorT","id":715175,"avatar_url":"https://avatars.githubusercontent.com/u/715175?v=3","gravatar_id":"","url":"https://api.github.com/users/igorT","html_url":"https://github.com/igorT","followers_url":"https://api.github.com/users/igorT/followers","following_url":"https://api.github.com/users/igorT/following{/other_user}","gists_url":"https://api.github.com/users/igorT/gists{/gist_id}","starred_url":"https://api.github.com/users/igorT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorT/subscriptions","organizations_url":"https://api.github.com/users/igorT/orgs","repos_url":"https://api.github.com/users/igorT/repos","events_url":"https://api.github.com/users/igorT/events{/privacy}","received_events_url":"https://api.github.com/users/igorT/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":2,"additions":43,"deletions":21,"changed_files":4}}