{"action":"created","issue":{"url":"https://api.github.com/repos/JimmXinu/FanFicFare/issues/102","labels_url":"https://api.github.com/repos/JimmXinu/FanFicFare/issues/102/labels{/name}","comments_url":"https://api.github.com/repos/JimmXinu/FanFicFare/issues/102/comments","events_url":"https://api.github.com/repos/JimmXinu/FanFicFare/issues/102/events","html_url":"https://github.com/JimmXinu/FanFicFare/pull/102","id":82815942,"number":102,"title":"Prevent duplicated story URLs even without normalization","user":{"login":"cryzed","id":1429103,"avatar_url":"https://avatars.githubusercontent.com/u/1429103?v=3","gravatar_id":"","url":"https://api.github.com/users/cryzed","html_url":"https://github.com/cryzed","followers_url":"https://api.github.com/users/cryzed/followers","following_url":"https://api.github.com/users/cryzed/following{/other_user}","gists_url":"https://api.github.com/users/cryzed/gists{/gist_id}","starred_url":"https://api.github.com/users/cryzed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryzed/subscriptions","organizations_url":"https://api.github.com/users/cryzed/orgs","repos_url":"https://api.github.com/users/cryzed/repos","events_url":"https://api.github.com/users/cryzed/events{/privacy}","received_events_url":"https://api.github.com/users/cryzed/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-30T13:39:02Z","updated_at":"2015-05-30T21:24:24Z","closed_at":"2015-05-30T15:29:13Z","pull_request":{"url":"https://api.github.com/repos/JimmXinu/FanFicFare/pulls/102","html_url":"https://github.com/JimmXinu/FanFicFare/pull/102","diff_url":"https://github.com/JimmXinu/FanFicFare/pull/102.diff","patch_url":"https://github.com/JimmXinu/FanFicFare/pull/102.patch"},"body":"A friend of mine really liked to see the metadata contained in the URLs (such as title, chapter number etc.) when stories were fetched via the \"Get Story URLs from Email\"-feature, which allowed him to immediately see which stories were updated. This feature has gone missing since the latest update, due to the hard coded normalization in the `get_urls_from_imap` function.\r\n\r\nThis fork removes the forced normalization while still preventing duplicated story URLs. For each story the longest URL is chosen under the assumption that it contains the most metadata, which probably isn't always guaranteed but a pretty good guess nonetheless.\r\n\r\nPlease consider merging this if you like the changes.\r\n\r\nGreetings,\r\nChris"},"comment":{"url":"https://api.github.com/repos/JimmXinu/FanFicFare/issues/comments/107087452","html_url":"https://github.com/JimmXinu/FanFicFare/pull/102#issuecomment-107087452","issue_url":"https://api.github.com/repos/JimmXinu/FanFicFare/issues/102","id":107087452,"user":{"login":"JimmXinu","id":11446969,"avatar_url":"https://avatars.githubusercontent.com/u/11446969?v=3","gravatar_id":"","url":"https://api.github.com/users/JimmXinu","html_url":"https://github.com/JimmXinu","followers_url":"https://api.github.com/users/JimmXinu/followers","following_url":"https://api.github.com/users/JimmXinu/following{/other_user}","gists_url":"https://api.github.com/users/JimmXinu/gists{/gist_id}","starred_url":"https://api.github.com/users/JimmXinu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimmXinu/subscriptions","organizations_url":"https://api.github.com/users/JimmXinu/orgs","repos_url":"https://api.github.com/users/JimmXinu/repos","events_url":"https://api.github.com/users/JimmXinu/events{/privacy}","received_events_url":"https://api.github.com/users/JimmXinu/received_events","type":"User","site_admin":false},"created_at":"2015-05-30T21:24:24Z","updated_at":"2015-05-30T21:24:24Z","body":"Ugh.  I just realized that this breaks auto_reject_from_email -- Reject List stores normalized URLs.\r\n\r\nThe least complex way I can think of to handle it is to normalize again in fff_plugin.py before checking against reject list.  That's wasteful of cycles, because it ends up normalizing the same URLs again, but saves on API complexity by not passing back both normalized and non-normalized URLs.  \r\n\r\nI pushed a change to do that."}}