{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/24043091","id":24043091,"diff_hunk":"@@ -125,7 +119,7 @@ bool PaymentRequestPlus::getMerchant(X509_STORE* certStore, QString& merchant) c\n     // The first cert is the signing cert, the rest are untrusted certs that chain\n     // to a valid root authority. OpenSSL needs them separately.\n     STACK_OF(X509) *chain = sk_X509_new_null();\n-    for (int i = certs.size()-1; i > 0; i--) {\n+    for (size_t i = certs.size() - 1; i > 0; i--) {","path":"src/qt/paymentrequestplus.cpp","position":18,"original_position":18,"commit_id":"01693de113d0ab4626caebd5c276c2e23cac21d1","original_commit_id":"b1e4965da4cf972cdc5698b78ec0e1ac469101d6","user":{"login":"Diapolo","id":1419649,"avatar_url":"https://avatars.githubusercontent.com/u/1419649?v=3","gravatar_id":"","url":"https://api.github.com/users/Diapolo","html_url":"https://github.com/Diapolo","followers_url":"https://api.github.com/users/Diapolo/followers","following_url":"https://api.github.com/users/Diapolo/following{/other_user}","gists_url":"https://api.github.com/users/Diapolo/gists{/gist_id}","starred_url":"https://api.github.com/users/Diapolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diapolo/subscriptions","organizations_url":"https://api.github.com/users/Diapolo/orgs","repos_url":"https://api.github.com/users/Diapolo/repos","events_url":"https://api.github.com/users/Diapolo/events{/privacy}","received_events_url":"https://api.github.com/users/Diapolo/received_events","type":"User","site_admin":false},"body":"Alright, will revert this change here.","created_at":"2015-02-03T21:49:06Z","updated_at":"2015-02-03T21:49:06Z","html_url":"https://github.com/bitcoin/bitcoin/pull/5467#discussion_r24043091","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5467","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/24043091"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/5467#discussion_r24043091"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5467"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5467","id":25960770,"html_url":"https://github.com/bitcoin/bitcoin/pull/5467","diff_url":"https://github.com/bitcoin/bitcoin/pull/5467.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/5467.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5467","number":5467,"state":"open","locked":false,"title":"[Qt] payment request / server work - part 2","user":{"login":"Diapolo","id":1419649,"avatar_url":"https://avatars.githubusercontent.com/u/1419649?v=3","gravatar_id":"","url":"https://api.github.com/users/Diapolo","html_url":"https://github.com/Diapolo","followers_url":"https://api.github.com/users/Diapolo/followers","following_url":"https://api.github.com/users/Diapolo/following{/other_user}","gists_url":"https://api.github.com/users/Diapolo/gists{/gist_id}","starred_url":"https://api.github.com/users/Diapolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diapolo/subscriptions","organizations_url":"https://api.github.com/users/Diapolo/orgs","repos_url":"https://api.github.com/users/Diapolo/repos","events_url":"https://api.github.com/users/Diapolo/events{/privacy}","received_events_url":"https://api.github.com/users/Diapolo/received_events","type":"User","site_admin":false},"body":"This continues my work on the payment request / server part of our BIP70 implementation.\r\nPlease see individual commits for detailed descriptions.","created_at":"2014-12-12T09:23:36Z","updated_at":"2015-02-03T21:49:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55175c66952c9c54d1f643f0bc15f78259a38ead","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5467/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5467/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5467/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/01693de113d0ab4626caebd5c276c2e23cac21d1","head":{"label":"Diapolo:paymentserver_2","ref":"paymentserver_2","sha":"01693de113d0ab4626caebd5c276c2e23cac21d1","user":{"login":"Diapolo","id":1419649,"avatar_url":"https://avatars.githubusercontent.com/u/1419649?v=3","gravatar_id":"","url":"https://api.github.com/users/Diapolo","html_url":"https://github.com/Diapolo","followers_url":"https://api.github.com/users/Diapolo/followers","following_url":"https://api.github.com/users/Diapolo/following{/other_user}","gists_url":"https://api.github.com/users/Diapolo/gists{/gist_id}","starred_url":"https://api.github.com/users/Diapolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diapolo/subscriptions","organizations_url":"https://api.github.com/users/Diapolo/orgs","repos_url":"https://api.github.com/users/Diapolo/repos","events_url":"https://api.github.com/users/Diapolo/events{/privacy}","received_events_url":"https://api.github.com/users/Diapolo/received_events","type":"User","site_admin":false},"repo":{"id":3744138,"name":"bitcoin","full_name":"Diapolo/bitcoin","owner":{"login":"Diapolo","id":1419649,"avatar_url":"https://avatars.githubusercontent.com/u/1419649?v=3","gravatar_id":"","url":"https://api.github.com/users/Diapolo","html_url":"https://github.com/Diapolo","followers_url":"https://api.github.com/users/Diapolo/followers","following_url":"https://api.github.com/users/Diapolo/following{/other_user}","gists_url":"https://api.github.com/users/Diapolo/gists{/gist_id}","starred_url":"https://api.github.com/users/Diapolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diapolo/subscriptions","organizations_url":"https://api.github.com/users/Diapolo/orgs","repos_url":"https://api.github.com/users/Diapolo/repos","events_url":"https://api.github.com/users/Diapolo/events{/privacy}","received_events_url":"https://api.github.com/users/Diapolo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Diapolo/bitcoin","description":"Bitcoin integration/staging tree","fork":true,"url":"https://api.github.com/repos/Diapolo/bitcoin","forks_url":"https://api.github.com/repos/Diapolo/bitcoin/forks","keys_url":"https://api.github.com/repos/Diapolo/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Diapolo/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Diapolo/bitcoin/teams","hooks_url":"https://api.github.com/repos/Diapolo/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/Diapolo/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/Diapolo/bitcoin/events","assignees_url":"https://api.github.com/repos/Diapolo/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/Diapolo/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/Diapolo/bitcoin/tags","blobs_url":"https://api.github.com/repos/Diapolo/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Diapolo/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Diapolo/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Diapolo/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Diapolo/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/Diapolo/bitcoin/languages","stargazers_url":"https://api.github.com/repos/Diapolo/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/Diapolo/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/Diapolo/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/Diapolo/bitcoin/subscription","commits_url":"https://api.github.com/repos/Diapolo/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Diapolo/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Diapolo/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Diapolo/bitcoin/issues/comments/{number}","contents_url":"https://api.github.com/repos/Diapolo/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/Diapolo/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Diapolo/bitcoin/merges","archive_url":"https://api.github.com/repos/Diapolo/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Diapolo/bitcoin/downloads","issues_url":"https://api.github.com/repos/Diapolo/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/Diapolo/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/Diapolo/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/Diapolo/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Diapolo/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/Diapolo/bitcoin/releases{/id}","created_at":"2012-03-16T23:43:46Z","updated_at":"2015-02-03T21:04:58Z","pushed_at":"2015-02-03T21:46:08Z","git_url":"git://github.com/Diapolo/bitcoin.git","ssh_url":"git@github.com:Diapolo/bitcoin.git","clone_url":"https://github.com/Diapolo/bitcoin.git","svn_url":"https://github.com/Diapolo/bitcoin","homepage":"http://www.bitcoin.org","size":45194,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"fcf646c9b08e7f846d6c99314f937ace50809d7a","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/{number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","created_at":"2010-12-19T15:16:43Z","updated_at":"2015-02-03T12:12:46Z","pushed_at":"2015-02-03T12:12:46Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":107429,"stargazers_count":6415,"watchers_count":6415,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4524,"mirror_url":null,"open_issues_count":439,"forks":4524,"open_issues":439,"watchers":6415,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5467"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/5467"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/5467"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/5467/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5467/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5467/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/01693de113d0ab4626caebd5c276c2e23cac21d1"}}}}