{"action":"created","comment":{"url":"https://api.github.com/repos/lugensa/scorched/pulls/comments/41802422","id":41802422,"diff_hunk":"@@ -286,9 +282,7 @@ def _prepare_docs(self, docs):\n                 # fields\n                 if value is None:\n                     continue\n-                if name in self._datefields:","path":"scorched/connection.py","position":30,"original_position":30,"commit_id":"41808150dc7c4b09a0ff1e00814d5ab2554c8693","original_commit_id":"41808150dc7c4b09a0ff1e00814d5ab2554c8693","user":{"login":"delijati","id":769969,"avatar_url":"https://avatars.githubusercontent.com/u/769969?v=3","gravatar_id":"","url":"https://api.github.com/users/delijati","html_url":"https://github.com/delijati","followers_url":"https://api.github.com/users/delijati/followers","following_url":"https://api.github.com/users/delijati/following{/other_user}","gists_url":"https://api.github.com/users/delijati/gists{/gist_id}","starred_url":"https://api.github.com/users/delijati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delijati/subscriptions","organizations_url":"https://api.github.com/users/delijati/orgs","repos_url":"https://api.github.com/users/delijati/repos","events_url":"https://api.github.com/users/delijati/events{/privacy}","received_events_url":"https://api.github.com/users/delijati/received_events","type":"User","site_admin":false},"body":"This should be still in. If a `name` is in `self._datefields` we already know its type `date`","created_at":"2015-10-12T21:18:49Z","updated_at":"2015-10-12T21:18:49Z","html_url":"https://github.com/lugensa/scorched/pull/16#discussion_r41802422","pull_request_url":"https://api.github.com/repos/lugensa/scorched/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/lugensa/scorched/pulls/comments/41802422"},"html":{"href":"https://github.com/lugensa/scorched/pull/16#discussion_r41802422"},"pull_request":{"href":"https://api.github.com/repos/lugensa/scorched/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/lugensa/scorched/pulls/16","id":43122864,"html_url":"https://github.com/lugensa/scorched/pull/16","diff_url":"https://github.com/lugensa/scorched/pull/16.diff","patch_url":"https://github.com/lugensa/scorched/pull/16.patch","issue_url":"https://api.github.com/repos/lugensa/scorched/issues/16","number":16,"state":"open","locked":false,"title":"better check datetime dynamicfields","user":{"login":"mamico","id":182599,"avatar_url":"https://avatars.githubusercontent.com/u/182599?v=3","gravatar_id":"","url":"https://api.github.com/users/mamico","html_url":"https://github.com/mamico","followers_url":"https://api.github.com/users/mamico/followers","following_url":"https://api.github.com/users/mamico/following{/other_user}","gists_url":"https://api.github.com/users/mamico/gists{/gist_id}","starred_url":"https://api.github.com/users/mamico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamico/subscriptions","organizations_url":"https://api.github.com/users/mamico/orgs","repos_url":"https://api.github.com/users/mamico/repos","events_url":"https://api.github.com/users/mamico/events{/privacy}","received_events_url":"https://api.github.com/users/mamico/received_events","type":"User","site_admin":false},"body":"A different implementation for better guessing datetime dynamicfields.\r\n\r\nWith previous method (endswith) I had problem when a textfield name is something like \"candidate\" and a datetime field as name \"date\".","created_at":"2015-08-23T15:15:36Z","updated_at":"2015-10-12T21:18:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"335578b6bb64d2f022fa554e2b2056339d3c0d5a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lugensa/scorched/pulls/16/commits","review_comments_url":"https://api.github.com/repos/lugensa/scorched/pulls/16/comments","review_comment_url":"https://api.github.com/repos/lugensa/scorched/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lugensa/scorched/issues/16/comments","statuses_url":"https://api.github.com/repos/lugensa/scorched/statuses/41808150dc7c4b09a0ff1e00814d5ab2554c8693","head":{"label":"mamico:patch05","ref":"patch05","sha":"41808150dc7c4b09a0ff1e00814d5ab2554c8693","user":{"login":"mamico","id":182599,"avatar_url":"https://avatars.githubusercontent.com/u/182599?v=3","gravatar_id":"","url":"https://api.github.com/users/mamico","html_url":"https://github.com/mamico","followers_url":"https://api.github.com/users/mamico/followers","following_url":"https://api.github.com/users/mamico/following{/other_user}","gists_url":"https://api.github.com/users/mamico/gists{/gist_id}","starred_url":"https://api.github.com/users/mamico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamico/subscriptions","organizations_url":"https://api.github.com/users/mamico/orgs","repos_url":"https://api.github.com/users/mamico/repos","events_url":"https://api.github.com/users/mamico/events{/privacy}","received_events_url":"https://api.github.com/users/mamico/received_events","type":"User","site_admin":false},"repo":{"id":39577951,"name":"scorched","full_name":"mamico/scorched","owner":{"login":"mamico","id":182599,"avatar_url":"https://avatars.githubusercontent.com/u/182599?v=3","gravatar_id":"","url":"https://api.github.com/users/mamico","html_url":"https://github.com/mamico","followers_url":"https://api.github.com/users/mamico/followers","following_url":"https://api.github.com/users/mamico/following{/other_user}","gists_url":"https://api.github.com/users/mamico/gists{/gist_id}","starred_url":"https://api.github.com/users/mamico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamico/subscriptions","organizations_url":"https://api.github.com/users/mamico/orgs","repos_url":"https://api.github.com/users/mamico/repos","events_url":"https://api.github.com/users/mamico/events{/privacy}","received_events_url":"https://api.github.com/users/mamico/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mamico/scorched","description":"Sunburnt offspring solr client","fork":true,"url":"https://api.github.com/repos/mamico/scorched","forks_url":"https://api.github.com/repos/mamico/scorched/forks","keys_url":"https://api.github.com/repos/mamico/scorched/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mamico/scorched/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mamico/scorched/teams","hooks_url":"https://api.github.com/repos/mamico/scorched/hooks","issue_events_url":"https://api.github.com/repos/mamico/scorched/issues/events{/number}","events_url":"https://api.github.com/repos/mamico/scorched/events","assignees_url":"https://api.github.com/repos/mamico/scorched/assignees{/user}","branches_url":"https://api.github.com/repos/mamico/scorched/branches{/branch}","tags_url":"https://api.github.com/repos/mamico/scorched/tags","blobs_url":"https://api.github.com/repos/mamico/scorched/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mamico/scorched/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mamico/scorched/git/refs{/sha}","trees_url":"https://api.github.com/repos/mamico/scorched/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mamico/scorched/statuses/{sha}","languages_url":"https://api.github.com/repos/mamico/scorched/languages","stargazers_url":"https://api.github.com/repos/mamico/scorched/stargazers","contributors_url":"https://api.github.com/repos/mamico/scorched/contributors","subscribers_url":"https://api.github.com/repos/mamico/scorched/subscribers","subscription_url":"https://api.github.com/repos/mamico/scorched/subscription","commits_url":"https://api.github.com/repos/mamico/scorched/commits{/sha}","git_commits_url":"https://api.github.com/repos/mamico/scorched/git/commits{/sha}","comments_url":"https://api.github.com/repos/mamico/scorched/comments{/number}","issue_comment_url":"https://api.github.com/repos/mamico/scorched/issues/comments{/number}","contents_url":"https://api.github.com/repos/mamico/scorched/contents/{+path}","compare_url":"https://api.github.com/repos/mamico/scorched/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mamico/scorched/merges","archive_url":"https://api.github.com/repos/mamico/scorched/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mamico/scorched/downloads","issues_url":"https://api.github.com/repos/mamico/scorched/issues{/number}","pulls_url":"https://api.github.com/repos/mamico/scorched/pulls{/number}","milestones_url":"https://api.github.com/repos/mamico/scorched/milestones{/number}","notifications_url":"https://api.github.com/repos/mamico/scorched/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mamico/scorched/labels{/name}","releases_url":"https://api.github.com/repos/mamico/scorched/releases{/id}","created_at":"2015-07-23T16:17:46Z","updated_at":"2015-07-23T16:17:47Z","pushed_at":"2015-10-12T20:43:38Z","git_url":"git://github.com/mamico/scorched.git","ssh_url":"git@github.com:mamico/scorched.git","clone_url":"https://github.com/mamico/scorched.git","svn_url":"https://github.com/mamico/scorched","homepage":"","size":276,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lugensa:master","ref":"master","sha":"2dead6c0d609f30acbdf46ff7237ded5004f46ca","user":{"login":"lugensa","id":1321819,"avatar_url":"https://avatars.githubusercontent.com/u/1321819?v=3","gravatar_id":"","url":"https://api.github.com/users/lugensa","html_url":"https://github.com/lugensa","followers_url":"https://api.github.com/users/lugensa/followers","following_url":"https://api.github.com/users/lugensa/following{/other_user}","gists_url":"https://api.github.com/users/lugensa/gists{/gist_id}","starred_url":"https://api.github.com/users/lugensa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lugensa/subscriptions","organizations_url":"https://api.github.com/users/lugensa/orgs","repos_url":"https://api.github.com/users/lugensa/repos","events_url":"https://api.github.com/users/lugensa/events{/privacy}","received_events_url":"https://api.github.com/users/lugensa/received_events","type":"User","site_admin":false},"repo":{"id":17622819,"name":"scorched","full_name":"lugensa/scorched","owner":{"login":"lugensa","id":1321819,"avatar_url":"https://avatars.githubusercontent.com/u/1321819?v=3","gravatar_id":"","url":"https://api.github.com/users/lugensa","html_url":"https://github.com/lugensa","followers_url":"https://api.github.com/users/lugensa/followers","following_url":"https://api.github.com/users/lugensa/following{/other_user}","gists_url":"https://api.github.com/users/lugensa/gists{/gist_id}","starred_url":"https://api.github.com/users/lugensa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lugensa/subscriptions","organizations_url":"https://api.github.com/users/lugensa/orgs","repos_url":"https://api.github.com/users/lugensa/repos","events_url":"https://api.github.com/users/lugensa/events{/privacy}","received_events_url":"https://api.github.com/users/lugensa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lugensa/scorched","description":"Sunburnt offspring solr client","fork":false,"url":"https://api.github.com/repos/lugensa/scorched","forks_url":"https://api.github.com/repos/lugensa/scorched/forks","keys_url":"https://api.github.com/repos/lugensa/scorched/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lugensa/scorched/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lugensa/scorched/teams","hooks_url":"https://api.github.com/repos/lugensa/scorched/hooks","issue_events_url":"https://api.github.com/repos/lugensa/scorched/issues/events{/number}","events_url":"https://api.github.com/repos/lugensa/scorched/events","assignees_url":"https://api.github.com/repos/lugensa/scorched/assignees{/user}","branches_url":"https://api.github.com/repos/lugensa/scorched/branches{/branch}","tags_url":"https://api.github.com/repos/lugensa/scorched/tags","blobs_url":"https://api.github.com/repos/lugensa/scorched/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lugensa/scorched/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lugensa/scorched/git/refs{/sha}","trees_url":"https://api.github.com/repos/lugensa/scorched/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lugensa/scorched/statuses/{sha}","languages_url":"https://api.github.com/repos/lugensa/scorched/languages","stargazers_url":"https://api.github.com/repos/lugensa/scorched/stargazers","contributors_url":"https://api.github.com/repos/lugensa/scorched/contributors","subscribers_url":"https://api.github.com/repos/lugensa/scorched/subscribers","subscription_url":"https://api.github.com/repos/lugensa/scorched/subscription","commits_url":"https://api.github.com/repos/lugensa/scorched/commits{/sha}","git_commits_url":"https://api.github.com/repos/lugensa/scorched/git/commits{/sha}","comments_url":"https://api.github.com/repos/lugensa/scorched/comments{/number}","issue_comment_url":"https://api.github.com/repos/lugensa/scorched/issues/comments{/number}","contents_url":"https://api.github.com/repos/lugensa/scorched/contents/{+path}","compare_url":"https://api.github.com/repos/lugensa/scorched/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lugensa/scorched/merges","archive_url":"https://api.github.com/repos/lugensa/scorched/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lugensa/scorched/downloads","issues_url":"https://api.github.com/repos/lugensa/scorched/issues{/number}","pulls_url":"https://api.github.com/repos/lugensa/scorched/pulls{/number}","milestones_url":"https://api.github.com/repos/lugensa/scorched/milestones{/number}","notifications_url":"https://api.github.com/repos/lugensa/scorched/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lugensa/scorched/labels{/name}","releases_url":"https://api.github.com/repos/lugensa/scorched/releases{/id}","created_at":"2014-03-11T08:09:34Z","updated_at":"2015-08-30T10:41:22Z","pushed_at":"2015-09-28T14:35:04Z","git_url":"git://github.com/lugensa/scorched.git","ssh_url":"git@github.com:lugensa/scorched.git","clone_url":"https://github.com/lugensa/scorched.git","svn_url":"https://github.com/lugensa/scorched","homepage":"","size":764,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":9,"forks":9,"open_issues":9,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lugensa/scorched/pulls/16"},"html":{"href":"https://github.com/lugensa/scorched/pull/16"},"issue":{"href":"https://api.github.com/repos/lugensa/scorched/issues/16"},"comments":{"href":"https://api.github.com/repos/lugensa/scorched/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/lugensa/scorched/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/lugensa/scorched/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lugensa/scorched/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/lugensa/scorched/statuses/41808150dc7c4b09a0ff1e00814d5ab2554c8693"}}}}