{"action":"created","comment":{"url":"https://api.github.com/repos/tastejs/todomvc/pulls/comments/46925767","id":46925767,"diff_hunk":"@@ -339,6 +396,20 @@ class AppView extends Backbone.View {\n \t\tTodos.each(this.addOne);\n \t}\n \n+\t// Filter out completed/remaining tasks\n+\tfilter(criteria: string) {\n+\t\ttaskFilter = criteria;","path":"examples/typescript-backbone/js/app.ts","position":169,"original_position":169,"commit_id":"095a39ddc7117dd4de098991dca5e0988f0a284b","original_commit_id":"095a39ddc7117dd4de098991dca5e0988f0a284b","user":{"login":"samccone","id":883126,"avatar_url":"https://avatars.githubusercontent.com/u/883126?v=3","gravatar_id":"","url":"https://api.github.com/users/samccone","html_url":"https://github.com/samccone","followers_url":"https://api.github.com/users/samccone/followers","following_url":"https://api.github.com/users/samccone/following{/other_user}","gists_url":"https://api.github.com/users/samccone/gists{/gist_id}","starred_url":"https://api.github.com/users/samccone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samccone/subscriptions","organizations_url":"https://api.github.com/users/samccone/orgs","repos_url":"https://api.github.com/users/samccone/repos","events_url":"https://api.github.com/users/samccone/events{/privacy}","received_events_url":"https://api.github.com/users/samccone/received_events","type":"User","site_admin":false},"body":"After thinking about this a bit more, instead of a global var, how would you feel about attaching this \"State\" to the router and when we need to get the current state of the filter just ask the router via a getter* method?\r\n\r\n","created_at":"2015-12-08T08:25:40Z","updated_at":"2015-12-08T08:25:40Z","html_url":"https://github.com/tastejs/todomvc/pull/1544#discussion_r46925767","pull_request_url":"https://api.github.com/repos/tastejs/todomvc/pulls/1544","_links":{"self":{"href":"https://api.github.com/repos/tastejs/todomvc/pulls/comments/46925767"},"html":{"href":"https://github.com/tastejs/todomvc/pull/1544#discussion_r46925767"},"pull_request":{"href":"https://api.github.com/repos/tastejs/todomvc/pulls/1544"}}},"pull_request":{"url":"https://api.github.com/repos/tastejs/todomvc/pulls/1544","id":52732367,"html_url":"https://github.com/tastejs/todomvc/pull/1544","diff_url":"https://github.com/tastejs/todomvc/pull/1544.diff","patch_url":"https://github.com/tastejs/todomvc/pull/1544.patch","issue_url":"https://api.github.com/repos/tastejs/todomvc/issues/1544","number":1544,"state":"open","locked":false,"title":"typescript-backbone: Add routing","user":{"login":"dmethvin","id":157858,"avatar_url":"https://avatars.githubusercontent.com/u/157858?v=3","gravatar_id":"","url":"https://api.github.com/users/dmethvin","html_url":"https://github.com/dmethvin","followers_url":"https://api.github.com/users/dmethvin/followers","following_url":"https://api.github.com/users/dmethvin/following{/other_user}","gists_url":"https://api.github.com/users/dmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmethvin/subscriptions","organizations_url":"https://api.github.com/users/dmethvin/orgs","repos_url":"https://api.github.com/users/dmethvin/repos","events_url":"https://api.github.com/users/dmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/dmethvin/received_events","type":"User","site_admin":false},"body":"Fixes #1487 \r\n\r\nSeems to be passing unit tests and jscs (thanks to the .jscsrc exclusions on `examples/typescript-*`) but not jshint on the generated .js of course.\r\n\r\nI felt dirty for introducing a global for the routing filter criteria but `examples/backbone` does it the same way so ¯\\\\_(ツ)_/¯.\r\n\r\nIt really seemed to me that the naming should be `backbone-typescript` to keep all the variants of one MVC framework together in the folder, but I don't know if it's too late for that kind of reorg. ","created_at":"2015-12-04T22:54:48Z","updated_at":"2015-12-08T08:25:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edf917bc59017e91d81bd4534f710d1dc0ea34b1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tastejs/todomvc/pulls/1544/commits","review_comments_url":"https://api.github.com/repos/tastejs/todomvc/pulls/1544/comments","review_comment_url":"https://api.github.com/repos/tastejs/todomvc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tastejs/todomvc/issues/1544/comments","statuses_url":"https://api.github.com/repos/tastejs/todomvc/statuses/095a39ddc7117dd4de098991dca5e0988f0a284b","head":{"label":"dmethvin:1487-ts-backbone","ref":"1487-ts-backbone","sha":"095a39ddc7117dd4de098991dca5e0988f0a284b","user":{"login":"dmethvin","id":157858,"avatar_url":"https://avatars.githubusercontent.com/u/157858?v=3","gravatar_id":"","url":"https://api.github.com/users/dmethvin","html_url":"https://github.com/dmethvin","followers_url":"https://api.github.com/users/dmethvin/followers","following_url":"https://api.github.com/users/dmethvin/following{/other_user}","gists_url":"https://api.github.com/users/dmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmethvin/subscriptions","organizations_url":"https://api.github.com/users/dmethvin/orgs","repos_url":"https://api.github.com/users/dmethvin/repos","events_url":"https://api.github.com/users/dmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/dmethvin/received_events","type":"User","site_admin":false},"repo":{"id":46625996,"name":"todomvc","full_name":"dmethvin/todomvc","owner":{"login":"dmethvin","id":157858,"avatar_url":"https://avatars.githubusercontent.com/u/157858?v=3","gravatar_id":"","url":"https://api.github.com/users/dmethvin","html_url":"https://github.com/dmethvin","followers_url":"https://api.github.com/users/dmethvin/followers","following_url":"https://api.github.com/users/dmethvin/following{/other_user}","gists_url":"https://api.github.com/users/dmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmethvin/subscriptions","organizations_url":"https://api.github.com/users/dmethvin/orgs","repos_url":"https://api.github.com/users/dmethvin/repos","events_url":"https://api.github.com/users/dmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/dmethvin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmethvin/todomvc","description":"Helping you select an MV* framework - Todo apps for Backbone.js, Ember.js, AngularJS, and many more","fork":true,"url":"https://api.github.com/repos/dmethvin/todomvc","forks_url":"https://api.github.com/repos/dmethvin/todomvc/forks","keys_url":"https://api.github.com/repos/dmethvin/todomvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmethvin/todomvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmethvin/todomvc/teams","hooks_url":"https://api.github.com/repos/dmethvin/todomvc/hooks","issue_events_url":"https://api.github.com/repos/dmethvin/todomvc/issues/events{/number}","events_url":"https://api.github.com/repos/dmethvin/todomvc/events","assignees_url":"https://api.github.com/repos/dmethvin/todomvc/assignees{/user}","branches_url":"https://api.github.com/repos/dmethvin/todomvc/branches{/branch}","tags_url":"https://api.github.com/repos/dmethvin/todomvc/tags","blobs_url":"https://api.github.com/repos/dmethvin/todomvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmethvin/todomvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmethvin/todomvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmethvin/todomvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmethvin/todomvc/statuses/{sha}","languages_url":"https://api.github.com/repos/dmethvin/todomvc/languages","stargazers_url":"https://api.github.com/repos/dmethvin/todomvc/stargazers","contributors_url":"https://api.github.com/repos/dmethvin/todomvc/contributors","subscribers_url":"https://api.github.com/repos/dmethvin/todomvc/subscribers","subscription_url":"https://api.github.com/repos/dmethvin/todomvc/subscription","commits_url":"https://api.github.com/repos/dmethvin/todomvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmethvin/todomvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmethvin/todomvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmethvin/todomvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmethvin/todomvc/contents/{+path}","compare_url":"https://api.github.com/repos/dmethvin/todomvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmethvin/todomvc/merges","archive_url":"https://api.github.com/repos/dmethvin/todomvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmethvin/todomvc/downloads","issues_url":"https://api.github.com/repos/dmethvin/todomvc/issues{/number}","pulls_url":"https://api.github.com/repos/dmethvin/todomvc/pulls{/number}","milestones_url":"https://api.github.com/repos/dmethvin/todomvc/milestones{/number}","notifications_url":"https://api.github.com/repos/dmethvin/todomvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmethvin/todomvc/labels{/name}","releases_url":"https://api.github.com/repos/dmethvin/todomvc/releases{/id}","created_at":"2015-11-21T17:37:30Z","updated_at":"2015-11-21T17:37:35Z","pushed_at":"2015-12-08T08:03:32Z","git_url":"git://github.com/dmethvin/todomvc.git","ssh_url":"git@github.com:dmethvin/todomvc.git","clone_url":"https://github.com/dmethvin/todomvc.git","svn_url":"https://github.com/dmethvin/todomvc","homepage":"http://todomvc.com","size":52693,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tastejs:master","ref":"master","sha":"e5b9f664c3112f8863abbb4b80f36cace70f93ec","user":{"login":"tastejs","id":1733746,"avatar_url":"https://avatars.githubusercontent.com/u/1733746?v=3","gravatar_id":"","url":"https://api.github.com/users/tastejs","html_url":"https://github.com/tastejs","followers_url":"https://api.github.com/users/tastejs/followers","following_url":"https://api.github.com/users/tastejs/following{/other_user}","gists_url":"https://api.github.com/users/tastejs/gists{/gist_id}","starred_url":"https://api.github.com/users/tastejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tastejs/subscriptions","organizations_url":"https://api.github.com/users/tastejs/orgs","repos_url":"https://api.github.com/users/tastejs/repos","events_url":"https://api.github.com/users/tastejs/events{/privacy}","received_events_url":"https://api.github.com/users/tastejs/received_events","type":"Organization","site_admin":false},"repo":{"id":1844251,"name":"todomvc","full_name":"tastejs/todomvc","owner":{"login":"tastejs","id":1733746,"avatar_url":"https://avatars.githubusercontent.com/u/1733746?v=3","gravatar_id":"","url":"https://api.github.com/users/tastejs","html_url":"https://github.com/tastejs","followers_url":"https://api.github.com/users/tastejs/followers","following_url":"https://api.github.com/users/tastejs/following{/other_user}","gists_url":"https://api.github.com/users/tastejs/gists{/gist_id}","starred_url":"https://api.github.com/users/tastejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tastejs/subscriptions","organizations_url":"https://api.github.com/users/tastejs/orgs","repos_url":"https://api.github.com/users/tastejs/repos","events_url":"https://api.github.com/users/tastejs/events{/privacy}","received_events_url":"https://api.github.com/users/tastejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tastejs/todomvc","description":"Helping you select an MV* framework - Todo apps for Backbone.js, Ember.js, AngularJS, and many more","fork":false,"url":"https://api.github.com/repos/tastejs/todomvc","forks_url":"https://api.github.com/repos/tastejs/todomvc/forks","keys_url":"https://api.github.com/repos/tastejs/todomvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tastejs/todomvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tastejs/todomvc/teams","hooks_url":"https://api.github.com/repos/tastejs/todomvc/hooks","issue_events_url":"https://api.github.com/repos/tastejs/todomvc/issues/events{/number}","events_url":"https://api.github.com/repos/tastejs/todomvc/events","assignees_url":"https://api.github.com/repos/tastejs/todomvc/assignees{/user}","branches_url":"https://api.github.com/repos/tastejs/todomvc/branches{/branch}","tags_url":"https://api.github.com/repos/tastejs/todomvc/tags","blobs_url":"https://api.github.com/repos/tastejs/todomvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tastejs/todomvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tastejs/todomvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/tastejs/todomvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tastejs/todomvc/statuses/{sha}","languages_url":"https://api.github.com/repos/tastejs/todomvc/languages","stargazers_url":"https://api.github.com/repos/tastejs/todomvc/stargazers","contributors_url":"https://api.github.com/repos/tastejs/todomvc/contributors","subscribers_url":"https://api.github.com/repos/tastejs/todomvc/subscribers","subscription_url":"https://api.github.com/repos/tastejs/todomvc/subscription","commits_url":"https://api.github.com/repos/tastejs/todomvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/tastejs/todomvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/tastejs/todomvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/tastejs/todomvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/tastejs/todomvc/contents/{+path}","compare_url":"https://api.github.com/repos/tastejs/todomvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tastejs/todomvc/merges","archive_url":"https://api.github.com/repos/tastejs/todomvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tastejs/todomvc/downloads","issues_url":"https://api.github.com/repos/tastejs/todomvc/issues{/number}","pulls_url":"https://api.github.com/repos/tastejs/todomvc/pulls{/number}","milestones_url":"https://api.github.com/repos/tastejs/todomvc/milestones{/number}","notifications_url":"https://api.github.com/repos/tastejs/todomvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tastejs/todomvc/labels{/name}","releases_url":"https://api.github.com/repos/tastejs/todomvc/releases{/id}","created_at":"2011-06-03T19:56:33Z","updated_at":"2015-12-08T07:49:22Z","pushed_at":"2015-12-08T08:03:50Z","git_url":"git://github.com/tastejs/todomvc.git","ssh_url":"git@github.com:tastejs/todomvc.git","clone_url":"https://github.com/tastejs/todomvc.git","svn_url":"https://github.com/tastejs/todomvc","homepage":"http://todomvc.com","size":91039,"stargazers_count":15022,"watchers_count":15022,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8446,"mirror_url":null,"open_issues_count":77,"forks":8446,"open_issues":77,"watchers":15022,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tastejs/todomvc/pulls/1544"},"html":{"href":"https://github.com/tastejs/todomvc/pull/1544"},"issue":{"href":"https://api.github.com/repos/tastejs/todomvc/issues/1544"},"comments":{"href":"https://api.github.com/repos/tastejs/todomvc/issues/1544/comments"},"review_comments":{"href":"https://api.github.com/repos/tastejs/todomvc/pulls/1544/comments"},"review_comment":{"href":"https://api.github.com/repos/tastejs/todomvc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tastejs/todomvc/pulls/1544/commits"},"statuses":{"href":"https://api.github.com/repos/tastejs/todomvc/statuses/095a39ddc7117dd4de098991dca5e0988f0a284b"}}}}