{"action":"created","issue":{"url":"https://api.github.com/repos/nature/shunter/issues/68","labels_url":"https://api.github.com/repos/nature/shunter/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/nature/shunter/issues/68/comments","events_url":"https://api.github.com/repos/nature/shunter/issues/68/events","html_url":"https://github.com/nature/shunter/issues/68","id":113604805,"number":68,"title":"Make error when no client tests are defined","user":{"login":"joseluisbolos","id":1792637,"avatar_url":"https://avatars.githubusercontent.com/u/1792637?v=3","gravatar_id":"","url":"https://api.github.com/users/joseluisbolos","html_url":"https://github.com/joseluisbolos","followers_url":"https://api.github.com/users/joseluisbolos/followers","following_url":"https://api.github.com/users/joseluisbolos/following{/other_user}","gists_url":"https://api.github.com/users/joseluisbolos/gists{/gist_id}","starred_url":"https://api.github.com/users/joseluisbolos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseluisbolos/subscriptions","organizations_url":"https://api.github.com/users/joseluisbolos/orgs","repos_url":"https://api.github.com/users/joseluisbolos/repos","events_url":"https://api.github.com/users/joseluisbolos/events{/privacy}","received_events_url":"https://api.github.com/users/joseluisbolos/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nature/shunter/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"debugwand","id":996106,"avatar_url":"https://avatars.githubusercontent.com/u/996106?v=3","gravatar_id":"","url":"https://api.github.com/users/debugwand","html_url":"https://github.com/debugwand","followers_url":"https://api.github.com/users/debugwand/followers","following_url":"https://api.github.com/users/debugwand/following{/other_user}","gists_url":"https://api.github.com/users/debugwand/gists{/gist_id}","starred_url":"https://api.github.com/users/debugwand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debugwand/subscriptions","organizations_url":"https://api.github.com/users/debugwand/orgs","repos_url":"https://api.github.com/users/debugwand/repos","events_url":"https://api.github.com/users/debugwand/events{/privacy}","received_events_url":"https://api.github.com/users/debugwand/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-10-27T15:01:32Z","updated_at":"2015-10-27T15:18:01Z","closed_at":null,"body":"A Shunter app with no client-side tests (for example, as a result of following the [Getting starting](../docs/getting-started.md) guide) will fail after executing `make ci` or `make test` with the following error:\r\n\r\n```\r\n$ make test\r\n> running server-side unit tests\r\n\r\n\r\n  0 passing (4ms)\r\n\r\n> running client-side unit tests\r\n\r\nmocha.run() was called with no tests\r\nError loading resource https://ajax.googleapis.com/ajax/libs/webfont/1.5.18/webfont.js (5). Details: Operation canceled\r\n\r\nFinished 1 failures\r\nmake: *** [test-client] Error 1\r\n```\r\n\r\nIt looks like we need to add something so the Makefile doesn't fail so abruptly when there are no tests defined."},"comment":{"url":"https://api.github.com/repos/nature/shunter/issues/comments/151537552","html_url":"https://github.com/nature/shunter/issues/68#issuecomment-151537552","issue_url":"https://api.github.com/repos/nature/shunter/issues/68","id":151537552,"user":{"login":"rowanmanning","id":138944,"avatar_url":"https://avatars.githubusercontent.com/u/138944?v=3","gravatar_id":"","url":"https://api.github.com/users/rowanmanning","html_url":"https://github.com/rowanmanning","followers_url":"https://api.github.com/users/rowanmanning/followers","following_url":"https://api.github.com/users/rowanmanning/following{/other_user}","gists_url":"https://api.github.com/users/rowanmanning/gists{/gist_id}","starred_url":"https://api.github.com/users/rowanmanning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rowanmanning/subscriptions","organizations_url":"https://api.github.com/users/rowanmanning/orgs","repos_url":"https://api.github.com/users/rowanmanning/repos","events_url":"https://api.github.com/users/rowanmanning/events{/privacy}","received_events_url":"https://api.github.com/users/rowanmanning/received_events","type":"User","site_admin":false},"created_at":"2015-10-27T15:18:01Z","updated_at":"2015-10-27T15:18:01Z","body":"FYI it's not the Makefile that's causing this – that's project-specific. I think `test-client` is what needs to be updated; it needs to exit with a code of `0` if there are no tests to run."}}