{"action":"created","comment":{"url":"https://api.github.com/repos/ocsigen/js_of_ocaml/pulls/comments/28339834","id":28339834,"diff_hunk":"@@ -454,6 +454,8 @@ function caml_float_of_string(s) {\n     res = +s.substring(0,pidx);\n     return res * Math.pow(2,exp);\n   }\n+  if(/^[+]?inf/i.test(s)) return Infinity;\n+  if(/-inf/i.test(s)) return -Infinity;","path":"runtime/stdlib.js","position":5,"original_position":5,"commit_id":"4a68d0cc4abd2402c8e821bb914191e74cdba023","original_commit_id":"4a68d0cc4abd2402c8e821bb914191e74cdba023","user":{"login":"hhugo","id":835209,"avatar_url":"https://avatars.githubusercontent.com/u/835209?v=3","gravatar_id":"","url":"https://api.github.com/users/hhugo","html_url":"https://github.com/hhugo","followers_url":"https://api.github.com/users/hhugo/followers","following_url":"https://api.github.com/users/hhugo/following{/other_user}","gists_url":"https://api.github.com/users/hhugo/gists{/gist_id}","starred_url":"https://api.github.com/users/hhugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhugo/subscriptions","organizations_url":"https://api.github.com/users/hhugo/orgs","repos_url":"https://api.github.com/users/hhugo/repos","events_url":"https://api.github.com/users/hhugo/events{/privacy}","received_events_url":"https://api.github.com/users/hhugo/received_events","type":"User","site_admin":false},"body":"should probably `/^-inf/`","created_at":"2015-04-14T15:49:11Z","updated_at":"2015-04-14T15:49:11Z","html_url":"https://github.com/ocsigen/js_of_ocaml/pull/271#discussion_r28339834","pull_request_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/pulls/271","_links":{"self":{"href":"https://api.github.com/repos/ocsigen/js_of_ocaml/pulls/comments/28339834"},"html":{"href":"https://github.com/ocsigen/js_of_ocaml/pull/271#discussion_r28339834"},"pull_request":{"href":"https://api.github.com/repos/ocsigen/js_of_ocaml/pulls/271"}}},"pull_request":{"url":"https://api.github.com/repos/ocsigen/js_of_ocaml/pulls/271","id":33244414,"html_url":"https://github.com/ocsigen/js_of_ocaml/pull/271","diff_url":"https://github.com/ocsigen/js_of_ocaml/pull/271.diff","patch_url":"https://github.com/ocsigen/js_of_ocaml/pull/271.patch","issue_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/issues/271","number":271,"state":"open","locked":false,"title":"Bring float_of_string more in line with the OCaml implementation.","user":{"login":"jonludlam","id":210963,"avatar_url":"https://avatars.githubusercontent.com/u/210963?v=3","gravatar_id":"","url":"https://api.github.com/users/jonludlam","html_url":"https://github.com/jonludlam","followers_url":"https://api.github.com/users/jonludlam/followers","following_url":"https://api.github.com/users/jonludlam/following{/other_user}","gists_url":"https://api.github.com/users/jonludlam/gists{/gist_id}","starred_url":"https://api.github.com/users/jonludlam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonludlam/subscriptions","organizations_url":"https://api.github.com/users/jonludlam/orgs","repos_url":"https://api.github.com/users/jonludlam/repos","events_url":"https://api.github.com/users/jonludlam/events{/privacy}","received_events_url":"https://api.github.com/users/jonludlam/received_events","type":"User","site_admin":false},"body":"This adds the ability to parse infinities of various capitalisation\r\nand sign. The following now works in the JS toplevel:\r\n\r\n    float_of_string (string_of_float infinity)\r\n\r\nIt's more permissive than standard ocaml, accepting, for example,\r\n\"infini\" whereas that would be rejected by the normal toplevel.\r\n\r\nSigned-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>","created_at":"2015-04-14T10:26:56Z","updated_at":"2015-04-14T15:49:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f174825c1ee8b0419d408ab17d7c20eb3f52420d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/pulls/271/commits","review_comments_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/pulls/271/comments","review_comment_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/issues/271/comments","statuses_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/statuses/4a68d0cc4abd2402c8e821bb914191e74cdba023","head":{"label":"jonludlam:parse_float","ref":"parse_float","sha":"4a68d0cc4abd2402c8e821bb914191e74cdba023","user":{"login":"jonludlam","id":210963,"avatar_url":"https://avatars.githubusercontent.com/u/210963?v=3","gravatar_id":"","url":"https://api.github.com/users/jonludlam","html_url":"https://github.com/jonludlam","followers_url":"https://api.github.com/users/jonludlam/followers","following_url":"https://api.github.com/users/jonludlam/following{/other_user}","gists_url":"https://api.github.com/users/jonludlam/gists{/gist_id}","starred_url":"https://api.github.com/users/jonludlam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonludlam/subscriptions","organizations_url":"https://api.github.com/users/jonludlam/orgs","repos_url":"https://api.github.com/users/jonludlam/repos","events_url":"https://api.github.com/users/jonludlam/events{/privacy}","received_events_url":"https://api.github.com/users/jonludlam/received_events","type":"User","site_admin":false},"repo":{"id":33925437,"name":"js_of_ocaml","full_name":"jonludlam/js_of_ocaml","owner":{"login":"jonludlam","id":210963,"avatar_url":"https://avatars.githubusercontent.com/u/210963?v=3","gravatar_id":"","url":"https://api.github.com/users/jonludlam","html_url":"https://github.com/jonludlam","followers_url":"https://api.github.com/users/jonludlam/followers","following_url":"https://api.github.com/users/jonludlam/following{/other_user}","gists_url":"https://api.github.com/users/jonludlam/gists{/gist_id}","starred_url":"https://api.github.com/users/jonludlam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonludlam/subscriptions","organizations_url":"https://api.github.com/users/jonludlam/orgs","repos_url":"https://api.github.com/users/jonludlam/repos","events_url":"https://api.github.com/users/jonludlam/events{/privacy}","received_events_url":"https://api.github.com/users/jonludlam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonludlam/js_of_ocaml","description":"Compiler from OCaml to Javascript.","fork":true,"url":"https://api.github.com/repos/jonludlam/js_of_ocaml","forks_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/forks","keys_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/teams","hooks_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/hooks","issue_events_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/events","assignees_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/tags","blobs_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/languages","stargazers_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/stargazers","contributors_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/contributors","subscribers_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/subscribers","subscription_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/subscription","commits_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/merges","archive_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/downloads","issues_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/labels{/name}","releases_url":"https://api.github.com/repos/jonludlam/js_of_ocaml/releases{/id}","created_at":"2015-04-14T10:24:52Z","updated_at":"2015-04-14T10:24:53Z","pushed_at":"2015-04-14T10:25:09Z","git_url":"git://github.com/jonludlam/js_of_ocaml.git","ssh_url":"git@github.com:jonludlam/js_of_ocaml.git","clone_url":"https://github.com/jonludlam/js_of_ocaml.git","svn_url":"https://github.com/jonludlam/js_of_ocaml","homepage":"http://ocsigen.org/js_of_ocaml/","size":47842,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ocsigen:master","ref":"master","sha":"237a9de61fa663f2ec17638eeb06ffda5b117518","user":{"login":"ocsigen","id":4729424,"avatar_url":"https://avatars.githubusercontent.com/u/4729424?v=3","gravatar_id":"","url":"https://api.github.com/users/ocsigen","html_url":"https://github.com/ocsigen","followers_url":"https://api.github.com/users/ocsigen/followers","following_url":"https://api.github.com/users/ocsigen/following{/other_user}","gists_url":"https://api.github.com/users/ocsigen/gists{/gist_id}","starred_url":"https://api.github.com/users/ocsigen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocsigen/subscriptions","organizations_url":"https://api.github.com/users/ocsigen/orgs","repos_url":"https://api.github.com/users/ocsigen/repos","events_url":"https://api.github.com/users/ocsigen/events{/privacy}","received_events_url":"https://api.github.com/users/ocsigen/received_events","type":"Organization","site_admin":false},"repo":{"id":11749064,"name":"js_of_ocaml","full_name":"ocsigen/js_of_ocaml","owner":{"login":"ocsigen","id":4729424,"avatar_url":"https://avatars.githubusercontent.com/u/4729424?v=3","gravatar_id":"","url":"https://api.github.com/users/ocsigen","html_url":"https://github.com/ocsigen","followers_url":"https://api.github.com/users/ocsigen/followers","following_url":"https://api.github.com/users/ocsigen/following{/other_user}","gists_url":"https://api.github.com/users/ocsigen/gists{/gist_id}","starred_url":"https://api.github.com/users/ocsigen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocsigen/subscriptions","organizations_url":"https://api.github.com/users/ocsigen/orgs","repos_url":"https://api.github.com/users/ocsigen/repos","events_url":"https://api.github.com/users/ocsigen/events{/privacy}","received_events_url":"https://api.github.com/users/ocsigen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocsigen/js_of_ocaml","description":"Compiler from OCaml to Javascript.","fork":false,"url":"https://api.github.com/repos/ocsigen/js_of_ocaml","forks_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/forks","keys_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/teams","hooks_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/hooks","issue_events_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/events","assignees_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/tags","blobs_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/languages","stargazers_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/stargazers","contributors_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/contributors","subscribers_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/subscribers","subscription_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/subscription","commits_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/merges","archive_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/downloads","issues_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/labels{/name}","releases_url":"https://api.github.com/repos/ocsigen/js_of_ocaml/releases{/id}","created_at":"2013-07-29T20:28:11Z","updated_at":"2015-04-08T12:03:50Z","pushed_at":"2015-04-14T10:26:57Z","git_url":"git://github.com/ocsigen/js_of_ocaml.git","ssh_url":"git@github.com:ocsigen/js_of_ocaml.git","clone_url":"https://github.com/ocsigen/js_of_ocaml.git","svn_url":"https://github.com/ocsigen/js_of_ocaml","homepage":"http://ocsigen.org/js_of_ocaml/","size":47842,"stargazers_count":132,"watchers_count":132,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":35,"mirror_url":null,"open_issues_count":27,"forks":35,"open_issues":27,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocsigen/js_of_ocaml/pulls/271"},"html":{"href":"https://github.com/ocsigen/js_of_ocaml/pull/271"},"issue":{"href":"https://api.github.com/repos/ocsigen/js_of_ocaml/issues/271"},"comments":{"href":"https://api.github.com/repos/ocsigen/js_of_ocaml/issues/271/comments"},"review_comments":{"href":"https://api.github.com/repos/ocsigen/js_of_ocaml/pulls/271/comments"},"review_comment":{"href":"https://api.github.com/repos/ocsigen/js_of_ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocsigen/js_of_ocaml/pulls/271/commits"},"statuses":{"href":"https://api.github.com/repos/ocsigen/js_of_ocaml/statuses/4a68d0cc4abd2402c8e821bb914191e74cdba023"}}}}