{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/comments/28695756","id":28695756,"diff_hunk":"@@ -30,13 +30,16 @@ import (\n \n \tclientmodel \"github.com/prometheus/client_golang/model\"\n \n+\t\"github.com/prometheus/prometheus/config\"\n \t\"github.com/prometheus/prometheus/storage\"\n \t\"github.com/prometheus/prometheus/utility\"\n )\n \n const (\n-\t// InstanceLabel is the label value used for the instance label.\n+\t// InstanceLabel is the label name used for the instance label.\n \tInstanceLabel clientmodel.LabelName = \"instance\"\n+\t// HostLabel is internal label name used for host information.\n+\tHostLabel clientmodel.LabelName = \"__host__\"","path":"retrieval/target.go","position":14,"original_position":14,"commit_id":"9e94b2bbaeb939e506d5ea30a8ddd7902a095da8","original_commit_id":"9e94b2bbaeb939e506d5ea30a8ddd7902a095da8","user":{"login":"fabxc","id":4948210,"avatar_url":"https://avatars.githubusercontent.com/u/4948210?v=3","gravatar_id":"","url":"https://api.github.com/users/fabxc","html_url":"https://github.com/fabxc","followers_url":"https://api.github.com/users/fabxc/followers","following_url":"https://api.github.com/users/fabxc/following{/other_user}","gists_url":"https://api.github.com/users/fabxc/gists{/gist_id}","starred_url":"https://api.github.com/users/fabxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabxc/subscriptions","organizations_url":"https://api.github.com/users/fabxc/orgs","repos_url":"https://api.github.com/users/fabxc/repos","events_url":"https://api.github.com/users/fabxc/events{/privacy}","received_events_url":"https://api.github.com/users/fabxc/received_events","type":"User","site_admin":false},"body":"So the way to go would be to add it to the the vendored `client_golang` of this branch until both changes are in the respective master branches?","created_at":"2015-04-20T14:57:14Z","updated_at":"2015-04-20T14:57:14Z","html_url":"https://github.com/prometheus/prometheus/pull/645#discussion_r28695756","pull_request_url":"https://api.github.com/repos/prometheus/prometheus/pulls/645","_links":{"self":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/comments/28695756"},"html":{"href":"https://github.com/prometheus/prometheus/pull/645#discussion_r28695756"},"pull_request":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/645"}}},"pull_request":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/645","id":33653849,"html_url":"https://github.com/prometheus/prometheus/pull/645","diff_url":"https://github.com/prometheus/prometheus/pull/645.diff","patch_url":"https://github.com/prometheus/prometheus/pull/645.patch","issue_url":"https://api.github.com/repos/prometheus/prometheus/issues/645","number":645,"state":"open","locked":false,"title":"[WIP] Make target manager source based.","user":{"login":"fabxc","id":4948210,"avatar_url":"https://avatars.githubusercontent.com/u/4948210?v=3","gravatar_id":"","url":"https://api.github.com/users/fabxc","html_url":"https://github.com/fabxc","followers_url":"https://api.github.com/users/fabxc/followers","following_url":"https://api.github.com/users/fabxc/following{/other_user}","gists_url":"https://api.github.com/users/fabxc/gists{/gist_id}","starred_url":"https://api.github.com/users/fabxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabxc/subscriptions","organizations_url":"https://api.github.com/users/fabxc/orgs","repos_url":"https://api.github.com/users/fabxc/repos","events_url":"https://api.github.com/users/fabxc/events{/privacy}","received_events_url":"https://api.github.com/users/fabxc/received_events","type":"User","site_admin":false},"body":"This commit shifts responsibility for maintaining targets from providers and\r\npools (removed) to the target manager. Target groups have a source name that identifies\r\nthem for updates.\r\n\r\nWIP as  I would add a few more tests if there is no flaw in the general concept.\r\nThe relabeling will be applied before creating/updating the targets.\r\nWith this the retrieval part should be ready for config-reloads.","created_at":"2015-04-20T10:44:48Z","updated_at":"2015-04-20T14:57:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bd4d1860541f96967357bc9f58a085603d4b6c3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/prometheus/pulls/645/commits","review_comments_url":"https://api.github.com/repos/prometheus/prometheus/pulls/645/comments","review_comment_url":"https://api.github.com/repos/prometheus/prometheus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/prometheus/issues/645/comments","statuses_url":"https://api.github.com/repos/prometheus/prometheus/statuses/9e94b2bbaeb939e506d5ea30a8ddd7902a095da8","head":{"label":"fabxc:fabxc/sd","ref":"fabxc/sd","sha":"9e94b2bbaeb939e506d5ea30a8ddd7902a095da8","user":{"login":"fabxc","id":4948210,"avatar_url":"https://avatars.githubusercontent.com/u/4948210?v=3","gravatar_id":"","url":"https://api.github.com/users/fabxc","html_url":"https://github.com/fabxc","followers_url":"https://api.github.com/users/fabxc/followers","following_url":"https://api.github.com/users/fabxc/following{/other_user}","gists_url":"https://api.github.com/users/fabxc/gists{/gist_id}","starred_url":"https://api.github.com/users/fabxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabxc/subscriptions","organizations_url":"https://api.github.com/users/fabxc/orgs","repos_url":"https://api.github.com/users/fabxc/repos","events_url":"https://api.github.com/users/fabxc/events{/privacy}","received_events_url":"https://api.github.com/users/fabxc/received_events","type":"User","site_admin":false},"repo":{"id":30128367,"name":"prometheus","full_name":"fabxc/prometheus","owner":{"login":"fabxc","id":4948210,"avatar_url":"https://avatars.githubusercontent.com/u/4948210?v=3","gravatar_id":"","url":"https://api.github.com/users/fabxc","html_url":"https://github.com/fabxc","followers_url":"https://api.github.com/users/fabxc/followers","following_url":"https://api.github.com/users/fabxc/following{/other_user}","gists_url":"https://api.github.com/users/fabxc/gists{/gist_id}","starred_url":"https://api.github.com/users/fabxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabxc/subscriptions","organizations_url":"https://api.github.com/users/fabxc/orgs","repos_url":"https://api.github.com/users/fabxc/repos","events_url":"https://api.github.com/users/fabxc/events{/privacy}","received_events_url":"https://api.github.com/users/fabxc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabxc/prometheus","description":"The Prometheus monitoring system and time series database.","fork":true,"url":"https://api.github.com/repos/fabxc/prometheus","forks_url":"https://api.github.com/repos/fabxc/prometheus/forks","keys_url":"https://api.github.com/repos/fabxc/prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabxc/prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabxc/prometheus/teams","hooks_url":"https://api.github.com/repos/fabxc/prometheus/hooks","issue_events_url":"https://api.github.com/repos/fabxc/prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/fabxc/prometheus/events","assignees_url":"https://api.github.com/repos/fabxc/prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/fabxc/prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/fabxc/prometheus/tags","blobs_url":"https://api.github.com/repos/fabxc/prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabxc/prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabxc/prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabxc/prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabxc/prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/fabxc/prometheus/languages","stargazers_url":"https://api.github.com/repos/fabxc/prometheus/stargazers","contributors_url":"https://api.github.com/repos/fabxc/prometheus/contributors","subscribers_url":"https://api.github.com/repos/fabxc/prometheus/subscribers","subscription_url":"https://api.github.com/repos/fabxc/prometheus/subscription","commits_url":"https://api.github.com/repos/fabxc/prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabxc/prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabxc/prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabxc/prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabxc/prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/fabxc/prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabxc/prometheus/merges","archive_url":"https://api.github.com/repos/fabxc/prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabxc/prometheus/downloads","issues_url":"https://api.github.com/repos/fabxc/prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/fabxc/prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/fabxc/prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/fabxc/prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabxc/prometheus/labels{/name}","releases_url":"https://api.github.com/repos/fabxc/prometheus/releases{/id}","created_at":"2015-01-31T22:16:31Z","updated_at":"2015-04-20T07:46:36Z","pushed_at":"2015-04-20T11:55:28Z","git_url":"git://github.com/fabxc/prometheus.git","ssh_url":"git@github.com:fabxc/prometheus.git","clone_url":"https://github.com/fabxc/prometheus.git","svn_url":"https://github.com/fabxc/prometheus","homepage":"http://prometheus.io/","size":7323,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prometheus:fabxc/servdisc","ref":"fabxc/servdisc","sha":"9042b4f0813a7f7e71fec21e0f8ff786af3e5bbf","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":6838921,"name":"prometheus","full_name":"prometheus/prometheus","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/prometheus","description":"The Prometheus monitoring system and time series database.","fork":false,"url":"https://api.github.com/repos/prometheus/prometheus","forks_url":"https://api.github.com/repos/prometheus/prometheus/forks","keys_url":"https://api.github.com/repos/prometheus/prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/prometheus/teams","hooks_url":"https://api.github.com/repos/prometheus/prometheus/hooks","issue_events_url":"https://api.github.com/repos/prometheus/prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/prometheus/events","assignees_url":"https://api.github.com/repos/prometheus/prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/prometheus/tags","blobs_url":"https://api.github.com/repos/prometheus/prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/prometheus/languages","stargazers_url":"https://api.github.com/repos/prometheus/prometheus/stargazers","contributors_url":"https://api.github.com/repos/prometheus/prometheus/contributors","subscribers_url":"https://api.github.com/repos/prometheus/prometheus/subscribers","subscription_url":"https://api.github.com/repos/prometheus/prometheus/subscription","commits_url":"https://api.github.com/repos/prometheus/prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/prometheus/merges","archive_url":"https://api.github.com/repos/prometheus/prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/prometheus/downloads","issues_url":"https://api.github.com/repos/prometheus/prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/prometheus/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/prometheus/releases{/id}","created_at":"2012-11-24T11:14:12Z","updated_at":"2015-04-20T12:37:56Z","pushed_at":"2015-04-20T11:55:28Z","git_url":"git://github.com/prometheus/prometheus.git","ssh_url":"git@github.com:prometheus/prometheus.git","clone_url":"https://github.com/prometheus/prometheus.git","svn_url":"https://github.com/prometheus/prometheus","homepage":"http://prometheus.io/","size":16206,"stargazers_count":1980,"watchers_count":1980,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":104,"mirror_url":null,"open_issues_count":81,"forks":104,"open_issues":81,"watchers":1980,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/645"},"html":{"href":"https://github.com/prometheus/prometheus/pull/645"},"issue":{"href":"https://api.github.com/repos/prometheus/prometheus/issues/645"},"comments":{"href":"https://api.github.com/repos/prometheus/prometheus/issues/645/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/645/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/645/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/prometheus/statuses/9e94b2bbaeb939e506d5ea30a8ddd7902a095da8"}}}}