{"action":"created","issue":{"url":"https://api.github.com/repos/cogneco/ooc-kean/issues/475","labels_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/475/labels{/name}","comments_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/475/comments","events_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/475/events","html_url":"https://github.com/cogneco/ooc-kean/issues/475","id":109069877,"number":475,"title":"\"empty\" as a function or property name","user":{"login":"davidhesselbom","id":4319680,"avatar_url":"https://avatars.githubusercontent.com/u/4319680?v=3","gravatar_id":"","url":"https://api.github.com/users/davidhesselbom","html_url":"https://github.com/davidhesselbom","followers_url":"https://api.github.com/users/davidhesselbom/followers","following_url":"https://api.github.com/users/davidhesselbom/following{/other_user}","gists_url":"https://api.github.com/users/davidhesselbom/gists{/gist_id}","starred_url":"https://api.github.com/users/davidhesselbom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidhesselbom/subscriptions","organizations_url":"https://api.github.com/users/davidhesselbom/orgs","repos_url":"https://api.github.com/users/davidhesselbom/repos","events_url":"https://api.github.com/users/davidhesselbom/events{/privacy}","received_events_url":"https://api.github.com/users/davidhesselbom/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cogneco/ooc-kean/labels/code%20quality","name":"code quality","color":"fad8c7"},{"url":"https://api.github.com/repos/cogneco/ooc-kean/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-30T11:41:29Z","updated_at":"2015-10-09T08:01:27Z","closed_at":null,"body":"It is generally considered a bad idea to use words like \"empty\" for function/property names, because it's not clear whether it's a verb or an adjective. There are many places in our codebase where `empty` is a property that returns a `Bool`. Should those be changed into `isEmpty`? Or should it be obvious that\r\n1. `This empty` returns an \"empty\" instance of something,\r\n2. `this empty` returns a bool stating whether an instance is \"empty\", and\r\n3. `this empty()` \"empties\" an instance?"},"comment":{"url":"https://api.github.com/repos/cogneco/ooc-kean/issues/comments/146790383","html_url":"https://github.com/cogneco/ooc-kean/issues/475#issuecomment-146790383","issue_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/475","id":146790383,"user":{"login":"marcusnaslund","id":14308896,"avatar_url":"https://avatars.githubusercontent.com/u/14308896?v=3","gravatar_id":"","url":"https://api.github.com/users/marcusnaslund","html_url":"https://github.com/marcusnaslund","followers_url":"https://api.github.com/users/marcusnaslund/followers","following_url":"https://api.github.com/users/marcusnaslund/following{/other_user}","gists_url":"https://api.github.com/users/marcusnaslund/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusnaslund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusnaslund/subscriptions","organizations_url":"https://api.github.com/users/marcusnaslund/orgs","repos_url":"https://api.github.com/users/marcusnaslund/repos","events_url":"https://api.github.com/users/marcusnaslund/events{/privacy}","received_events_url":"https://api.github.com/users/marcusnaslund/received_events","type":"User","site_admin":false},"created_at":"2015-10-09T08:01:27Z","updated_at":"2015-10-09T08:01:27Z","body":"There are a lot of `empty` properties in math, so maybe before #491 it would be nice to have consensus on number 2."}}