{"action":"created","issue":{"url":"https://api.github.com/repos/hypothesis/h/issues/2661","labels_url":"https://api.github.com/repos/hypothesis/h/issues/2661/labels{/name}","comments_url":"https://api.github.com/repos/hypothesis/h/issues/2661/comments","events_url":"https://api.github.com/repos/hypothesis/h/issues/2661/events","html_url":"https://github.com/hypothesis/h/pull/2661","id":112838259,"number":2661,"title":"Disable caching for features/ AJAX responses","user":{"login":"robertknight","id":2458,"avatar_url":"https://avatars.githubusercontent.com/u/2458?v=3","gravatar_id":"","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hypothesis/h/labels/WIP","name":"WIP","color":"bfd4f2"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-10-22T16:13:35Z","updated_at":"2015-10-26T09:51:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hypothesis/h/pulls/2661","html_url":"https://github.com/hypothesis/h/pull/2661","diff_url":"https://github.com/hypothesis/h/pull/2661.diff","patch_url":"https://github.com/hypothesis/h/pull/2661.patch"},"body":"This fixes an issue where the response for /app/features would\r\nbe cached by IE 10, 11 resulting in the groups features not\r\nappearing after signing in to a groups-enabled account\r\nand refreshing the page.\r\n\r\nI've verified that this fixes the problem I saw but haven't evaluated where other calls might be affected in the same way yet and if so, is there a more generic configuration to disable caching for AJAX responses.\r\n\r\nFixes #2658"},"comment":{"url":"https://api.github.com/repos/hypothesis/h/issues/comments/151084456","html_url":"https://github.com/hypothesis/h/pull/2661#issuecomment-151084456","issue_url":"https://api.github.com/repos/hypothesis/h/issues/2661","id":151084456,"user":{"login":"robertknight","id":2458,"avatar_url":"https://avatars.githubusercontent.com/u/2458?v=3","gravatar_id":"","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false},"created_at":"2015-10-26T09:51:49Z","updated_at":"2015-10-26T09:51:49Z","body":"> Almost all calls to /api URLs made by the client will include an Authorization header, which should mean that IE won't cache them.\r\n\r\nSo loading up H at the moment, when signed in, I see the following requests:\r\n\r\n`/api` - No Authorization header in request, no cache control headers in response\r\n`GET /app/features` - No Authorization header in request, no cache control headers in response (without this PR)\r\n`GET /app` - No Authorization header in request, Cache-Control \"max-age=0, must-revalidate, no-cache, no-store\" in response\r\n`GET /api/token` - No Auth header in request (obviously), no cache-control in response\r\n`GET /api/search` - Auth header in request, no cache-control in response (not needed)\r\n\r\nI'm going to check which of those IE is apparently caching atm."}}