{"action":"closed","number":29,"pull_request":{"url":"https://api.github.com/repos/juxt/yada/pulls/29","id":49809732,"html_url":"https://github.com/juxt/yada/pull/29","diff_url":"https://github.com/juxt/yada/pull/29.diff","patch_url":"https://github.com/juxt/yada/pull/29.patch","issue_url":"https://api.github.com/repos/juxt/yada/issues/29","number":29,"state":"closed","locked":false,"title":"Allow for header schema verification and coercion","user":{"login":"stijnopheide","id":1864762,"avatar_url":"https://avatars.githubusercontent.com/u/1864762?v=3","gravatar_id":"","url":"https://api.github.com/users/stijnopheide","html_url":"https://github.com/stijnopheide","followers_url":"https://api.github.com/users/stijnopheide/followers","following_url":"https://api.github.com/users/stijnopheide/following{/other_user}","gists_url":"https://api.github.com/users/stijnopheide/gists{/gist_id}","starred_url":"https://api.github.com/users/stijnopheide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stijnopheide/subscriptions","organizations_url":"https://api.github.com/users/stijnopheide/orgs","repos_url":"https://api.github.com/users/stijnopheide/repos","events_url":"https://api.github.com/users/stijnopheide/events{/privacy}","received_events_url":"https://api.github.com/users/stijnopheide/received_events","type":"User","site_admin":false},"body":"Specifying a :header schema didn't work as intended\r\n\r\n1. Specifying keywords (mandatory) resulted in required value not found because header keys are parsed as strings\r\n2. Specifying (s/optional-key ...) or (s/required-key ...) is not compatible with select-keys\r\n\r\ne.g. \r\n\r\n```clojure\r\n{:header {(s/optional-key \"x-user-id\") s/Uuid}}\r\n```\r\n\r\nThe solution works partially:\r\n\r\n1. It coerces values properly\r\n2. It allows for additional headers and they will be parsed to a String value (as before)\r\n\r\nIt does not:\r\n\r\n1. Coerce keys. They will remain Strings.\r\n\r\n","created_at":"2015-11-05T11:06:02Z","updated_at":"2015-11-06T10:33:40Z","closed_at":"2015-11-06T10:33:40Z","merged_at":"2015-11-06T10:33:40Z","merge_commit_sha":"7b820c143518e0fb934ae4bdcc883b7845eb6943","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juxt/yada/pulls/29/commits","review_comments_url":"https://api.github.com/repos/juxt/yada/pulls/29/comments","review_comment_url":"https://api.github.com/repos/juxt/yada/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juxt/yada/issues/29/comments","statuses_url":"https://api.github.com/repos/juxt/yada/statuses/ce53d046e0f34773491ecd0885a5a268983bf2aa","head":{"label":"stijnopheide:coerce-headers","ref":"coerce-headers","sha":"ce53d046e0f34773491ecd0885a5a268983bf2aa","user":{"login":"stijnopheide","id":1864762,"avatar_url":"https://avatars.githubusercontent.com/u/1864762?v=3","gravatar_id":"","url":"https://api.github.com/users/stijnopheide","html_url":"https://github.com/stijnopheide","followers_url":"https://api.github.com/users/stijnopheide/followers","following_url":"https://api.github.com/users/stijnopheide/following{/other_user}","gists_url":"https://api.github.com/users/stijnopheide/gists{/gist_id}","starred_url":"https://api.github.com/users/stijnopheide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stijnopheide/subscriptions","organizations_url":"https://api.github.com/users/stijnopheide/orgs","repos_url":"https://api.github.com/users/stijnopheide/repos","events_url":"https://api.github.com/users/stijnopheide/events{/privacy}","received_events_url":"https://api.github.com/users/stijnopheide/received_events","type":"User","site_admin":false},"repo":{"id":43886583,"name":"yada","full_name":"stijnopheide/yada","owner":{"login":"stijnopheide","id":1864762,"avatar_url":"https://avatars.githubusercontent.com/u/1864762?v=3","gravatar_id":"","url":"https://api.github.com/users/stijnopheide","html_url":"https://github.com/stijnopheide","followers_url":"https://api.github.com/users/stijnopheide/followers","following_url":"https://api.github.com/users/stijnopheide/following{/other_user}","gists_url":"https://api.github.com/users/stijnopheide/gists{/gist_id}","starred_url":"https://api.github.com/users/stijnopheide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stijnopheide/subscriptions","organizations_url":"https://api.github.com/users/stijnopheide/orgs","repos_url":"https://api.github.com/users/stijnopheide/repos","events_url":"https://api.github.com/users/stijnopheide/events{/privacy}","received_events_url":"https://api.github.com/users/stijnopheide/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stijnopheide/yada","description":"A powerful Clojure web library, full HTTP, full async","fork":true,"url":"https://api.github.com/repos/stijnopheide/yada","forks_url":"https://api.github.com/repos/stijnopheide/yada/forks","keys_url":"https://api.github.com/repos/stijnopheide/yada/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stijnopheide/yada/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stijnopheide/yada/teams","hooks_url":"https://api.github.com/repos/stijnopheide/yada/hooks","issue_events_url":"https://api.github.com/repos/stijnopheide/yada/issues/events{/number}","events_url":"https://api.github.com/repos/stijnopheide/yada/events","assignees_url":"https://api.github.com/repos/stijnopheide/yada/assignees{/user}","branches_url":"https://api.github.com/repos/stijnopheide/yada/branches{/branch}","tags_url":"https://api.github.com/repos/stijnopheide/yada/tags","blobs_url":"https://api.github.com/repos/stijnopheide/yada/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stijnopheide/yada/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stijnopheide/yada/git/refs{/sha}","trees_url":"https://api.github.com/repos/stijnopheide/yada/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stijnopheide/yada/statuses/{sha}","languages_url":"https://api.github.com/repos/stijnopheide/yada/languages","stargazers_url":"https://api.github.com/repos/stijnopheide/yada/stargazers","contributors_url":"https://api.github.com/repos/stijnopheide/yada/contributors","subscribers_url":"https://api.github.com/repos/stijnopheide/yada/subscribers","subscription_url":"https://api.github.com/repos/stijnopheide/yada/subscription","commits_url":"https://api.github.com/repos/stijnopheide/yada/commits{/sha}","git_commits_url":"https://api.github.com/repos/stijnopheide/yada/git/commits{/sha}","comments_url":"https://api.github.com/repos/stijnopheide/yada/comments{/number}","issue_comment_url":"https://api.github.com/repos/stijnopheide/yada/issues/comments{/number}","contents_url":"https://api.github.com/repos/stijnopheide/yada/contents/{+path}","compare_url":"https://api.github.com/repos/stijnopheide/yada/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stijnopheide/yada/merges","archive_url":"https://api.github.com/repos/stijnopheide/yada/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stijnopheide/yada/downloads","issues_url":"https://api.github.com/repos/stijnopheide/yada/issues{/number}","pulls_url":"https://api.github.com/repos/stijnopheide/yada/pulls{/number}","milestones_url":"https://api.github.com/repos/stijnopheide/yada/milestones{/number}","notifications_url":"https://api.github.com/repos/stijnopheide/yada/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stijnopheide/yada/labels{/name}","releases_url":"https://api.github.com/repos/stijnopheide/yada/releases{/id}","created_at":"2015-10-08T12:23:48Z","updated_at":"2015-10-08T12:23:49Z","pushed_at":"2015-11-05T11:13:50Z","git_url":"git://github.com/stijnopheide/yada.git","ssh_url":"git@github.com:stijnopheide/yada.git","clone_url":"https://github.com/stijnopheide/yada.git","svn_url":"https://github.com/stijnopheide/yada","homepage":"","size":4286,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juxt:master","ref":"master","sha":"857c820afce1234c77f2bda208809066c20b34bd","user":{"login":"juxt","id":2892228,"avatar_url":"https://avatars.githubusercontent.com/u/2892228?v=3","gravatar_id":"","url":"https://api.github.com/users/juxt","html_url":"https://github.com/juxt","followers_url":"https://api.github.com/users/juxt/followers","following_url":"https://api.github.com/users/juxt/following{/other_user}","gists_url":"https://api.github.com/users/juxt/gists{/gist_id}","starred_url":"https://api.github.com/users/juxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juxt/subscriptions","organizations_url":"https://api.github.com/users/juxt/orgs","repos_url":"https://api.github.com/users/juxt/repos","events_url":"https://api.github.com/users/juxt/events{/privacy}","received_events_url":"https://api.github.com/users/juxt/received_events","type":"Organization","site_admin":false},"repo":{"id":28669611,"name":"yada","full_name":"juxt/yada","owner":{"login":"juxt","id":2892228,"avatar_url":"https://avatars.githubusercontent.com/u/2892228?v=3","gravatar_id":"","url":"https://api.github.com/users/juxt","html_url":"https://github.com/juxt","followers_url":"https://api.github.com/users/juxt/followers","following_url":"https://api.github.com/users/juxt/following{/other_user}","gists_url":"https://api.github.com/users/juxt/gists{/gist_id}","starred_url":"https://api.github.com/users/juxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juxt/subscriptions","organizations_url":"https://api.github.com/users/juxt/orgs","repos_url":"https://api.github.com/users/juxt/repos","events_url":"https://api.github.com/users/juxt/events{/privacy}","received_events_url":"https://api.github.com/users/juxt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juxt/yada","description":"A powerful Clojure web library, full HTTP, full async","fork":false,"url":"https://api.github.com/repos/juxt/yada","forks_url":"https://api.github.com/repos/juxt/yada/forks","keys_url":"https://api.github.com/repos/juxt/yada/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juxt/yada/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juxt/yada/teams","hooks_url":"https://api.github.com/repos/juxt/yada/hooks","issue_events_url":"https://api.github.com/repos/juxt/yada/issues/events{/number}","events_url":"https://api.github.com/repos/juxt/yada/events","assignees_url":"https://api.github.com/repos/juxt/yada/assignees{/user}","branches_url":"https://api.github.com/repos/juxt/yada/branches{/branch}","tags_url":"https://api.github.com/repos/juxt/yada/tags","blobs_url":"https://api.github.com/repos/juxt/yada/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juxt/yada/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juxt/yada/git/refs{/sha}","trees_url":"https://api.github.com/repos/juxt/yada/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juxt/yada/statuses/{sha}","languages_url":"https://api.github.com/repos/juxt/yada/languages","stargazers_url":"https://api.github.com/repos/juxt/yada/stargazers","contributors_url":"https://api.github.com/repos/juxt/yada/contributors","subscribers_url":"https://api.github.com/repos/juxt/yada/subscribers","subscription_url":"https://api.github.com/repos/juxt/yada/subscription","commits_url":"https://api.github.com/repos/juxt/yada/commits{/sha}","git_commits_url":"https://api.github.com/repos/juxt/yada/git/commits{/sha}","comments_url":"https://api.github.com/repos/juxt/yada/comments{/number}","issue_comment_url":"https://api.github.com/repos/juxt/yada/issues/comments{/number}","contents_url":"https://api.github.com/repos/juxt/yada/contents/{+path}","compare_url":"https://api.github.com/repos/juxt/yada/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juxt/yada/merges","archive_url":"https://api.github.com/repos/juxt/yada/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juxt/yada/downloads","issues_url":"https://api.github.com/repos/juxt/yada/issues{/number}","pulls_url":"https://api.github.com/repos/juxt/yada/pulls{/number}","milestones_url":"https://api.github.com/repos/juxt/yada/milestones{/number}","notifications_url":"https://api.github.com/repos/juxt/yada/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juxt/yada/labels{/name}","releases_url":"https://api.github.com/repos/juxt/yada/releases{/id}","created_at":"2014-12-31T16:05:53Z","updated_at":"2015-11-05T11:17:59Z","pushed_at":"2015-11-06T10:33:40Z","git_url":"git://github.com/juxt/yada.git","ssh_url":"git@github.com:juxt/yada.git","clone_url":"https://github.com/juxt/yada.git","svn_url":"https://github.com/juxt/yada","homepage":"","size":4894,"stargazers_count":129,"watchers_count":129,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":18,"forks":12,"open_issues":18,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juxt/yada/pulls/29"},"html":{"href":"https://github.com/juxt/yada/pull/29"},"issue":{"href":"https://api.github.com/repos/juxt/yada/issues/29"},"comments":{"href":"https://api.github.com/repos/juxt/yada/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/juxt/yada/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/juxt/yada/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juxt/yada/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/juxt/yada/statuses/ce53d046e0f34773491ecd0885a5a268983bf2aa"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"malcolmsparks","id":163131,"avatar_url":"https://avatars.githubusercontent.com/u/163131?v=3","gravatar_id":"","url":"https://api.github.com/users/malcolmsparks","html_url":"https://github.com/malcolmsparks","followers_url":"https://api.github.com/users/malcolmsparks/followers","following_url":"https://api.github.com/users/malcolmsparks/following{/other_user}","gists_url":"https://api.github.com/users/malcolmsparks/gists{/gist_id}","starred_url":"https://api.github.com/users/malcolmsparks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malcolmsparks/subscriptions","organizations_url":"https://api.github.com/users/malcolmsparks/orgs","repos_url":"https://api.github.com/users/malcolmsparks/repos","events_url":"https://api.github.com/users/malcolmsparks/events{/privacy}","received_events_url":"https://api.github.com/users/malcolmsparks/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}