{"action":"created","comment":{"url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/comments/38707711","id":38707711,"diff_hunk":"@@ -202,6 +209,17 @@ def update_creative(link, az_advertiser):\n     return az_creative\n \n \n+def update_trackers(campaign, az_cfmap):\n+    if (not getattr(campaign, \"adserver_click_url\", False) or\n+        not getattr(campaign, \"adserver_impression_url\", False)):\n+\n+        pixels = az_cfmap._get_pixel()\n+\n+        campaign.adserver_click_url = pixels['StaticClickUrl']","path":"reddit_adzerk/adzerkpromote.py","position":31,"original_position":31,"commit_id":"1f88d6be25e4276404172b81977d24c208249b85","original_commit_id":"1f88d6be25e4276404172b81977d24c208249b85","user":{"login":"zeantsoi","id":339024,"avatar_url":"https://avatars.githubusercontent.com/u/339024?v=3","gravatar_id":"","url":"https://api.github.com/users/zeantsoi","html_url":"https://github.com/zeantsoi","followers_url":"https://api.github.com/users/zeantsoi/followers","following_url":"https://api.github.com/users/zeantsoi/following{/other_user}","gists_url":"https://api.github.com/users/zeantsoi/gists{/gist_id}","starred_url":"https://api.github.com/users/zeantsoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeantsoi/subscriptions","organizations_url":"https://api.github.com/users/zeantsoi/orgs","repos_url":"https://api.github.com/users/zeantsoi/repos","events_url":"https://api.github.com/users/zeantsoi/events{/privacy}","received_events_url":"https://api.github.com/users/zeantsoi/received_events","type":"User","site_admin":false},"body":"Do we want/need to set defaults for `adserver_click_url` and `adserver_impression_url` on `PromoCampaign`?","created_at":"2015-09-03T23:17:51Z","updated_at":"2015-09-03T23:17:51Z","html_url":"https://github.com/reddit/reddit-plugin-adzerk/pull/91#discussion_r38707711","pull_request_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/91","_links":{"self":{"href":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/comments/38707711"},"html":{"href":"https://github.com/reddit/reddit-plugin-adzerk/pull/91#discussion_r38707711"},"pull_request":{"href":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/91"}}},"pull_request":{"url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/91","id":44168340,"html_url":"https://github.com/reddit/reddit-plugin-adzerk/pull/91","diff_url":"https://github.com/reddit/reddit-plugin-adzerk/pull/91.diff","patch_url":"https://github.com/reddit/reddit-plugin-adzerk/pull/91.patch","issue_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/issues/91","number":91,"state":"open","locked":false,"title":"Click tracking","user":{"login":"dwick","id":823747,"avatar_url":"https://avatars.githubusercontent.com/u/823747?v=3","gravatar_id":"","url":"https://api.github.com/users/dwick","html_url":"https://github.com/dwick","followers_url":"https://api.github.com/users/dwick/followers","following_url":"https://api.github.com/users/dwick/following{/other_user}","gists_url":"https://api.github.com/users/dwick/gists{/gist_id}","starred_url":"https://api.github.com/users/dwick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwick/subscriptions","organizations_url":"https://api.github.com/users/dwick/orgs","repos_url":"https://api.github.com/users/dwick/repos","events_url":"https://api.github.com/users/dwick/events{/privacy}","received_events_url":"https://api.github.com/users/dwick/received_events","type":"User","site_admin":false},"body":":eyeglasses: @zeantsoi @bsimpson63 \r\n\r\nrelated: https://github.com/reddit/reddit-public/pull/4130","created_at":"2015-09-03T23:10:02Z","updated_at":"2015-09-03T23:17:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b37deaa93df8bde3f4237646f98b28dee38a4b18","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/91/commits","review_comments_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/91/comments","review_comment_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/issues/91/comments","statuses_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/statuses/1f88d6be25e4276404172b81977d24c208249b85","head":{"label":"dwick:click-tracking-2","ref":"click-tracking-2","sha":"1f88d6be25e4276404172b81977d24c208249b85","user":{"login":"dwick","id":823747,"avatar_url":"https://avatars.githubusercontent.com/u/823747?v=3","gravatar_id":"","url":"https://api.github.com/users/dwick","html_url":"https://github.com/dwick","followers_url":"https://api.github.com/users/dwick/followers","following_url":"https://api.github.com/users/dwick/following{/other_user}","gists_url":"https://api.github.com/users/dwick/gists{/gist_id}","starred_url":"https://api.github.com/users/dwick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwick/subscriptions","organizations_url":"https://api.github.com/users/dwick/orgs","repos_url":"https://api.github.com/users/dwick/repos","events_url":"https://api.github.com/users/dwick/events{/privacy}","received_events_url":"https://api.github.com/users/dwick/received_events","type":"User","site_admin":false},"repo":{"id":30618338,"name":"reddit-plugin-adzerk","full_name":"dwick/reddit-plugin-adzerk","owner":{"login":"dwick","id":823747,"avatar_url":"https://avatars.githubusercontent.com/u/823747?v=3","gravatar_id":"","url":"https://api.github.com/users/dwick","html_url":"https://github.com/dwick","followers_url":"https://api.github.com/users/dwick/followers","following_url":"https://api.github.com/users/dwick/following{/other_user}","gists_url":"https://api.github.com/users/dwick/gists{/gist_id}","starred_url":"https://api.github.com/users/dwick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwick/subscriptions","organizations_url":"https://api.github.com/users/dwick/orgs","repos_url":"https://api.github.com/users/dwick/repos","events_url":"https://api.github.com/users/dwick/events{/privacy}","received_events_url":"https://api.github.com/users/dwick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dwick/reddit-plugin-adzerk","description":"reddit plugin for adzerk-hosted adverts","fork":true,"url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk","forks_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/forks","keys_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/teams","hooks_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/hooks","issue_events_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/issues/events{/number}","events_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/events","assignees_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/assignees{/user}","branches_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/branches{/branch}","tags_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/tags","blobs_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/statuses/{sha}","languages_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/languages","stargazers_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/stargazers","contributors_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/contributors","subscribers_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/subscribers","subscription_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/subscription","commits_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/contents/{+path}","compare_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/merges","archive_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/downloads","issues_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/issues{/number}","pulls_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/pulls{/number}","milestones_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/milestones{/number}","notifications_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/labels{/name}","releases_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/releases{/id}","created_at":"2015-02-10T22:37:08Z","updated_at":"2015-02-10T22:37:09Z","pushed_at":"2015-09-03T23:05:00Z","git_url":"git://github.com/dwick/reddit-plugin-adzerk.git","ssh_url":"git@github.com:dwick/reddit-plugin-adzerk.git","clone_url":"https://github.com/dwick/reddit-plugin-adzerk.git","svn_url":"https://github.com/dwick/reddit-plugin-adzerk","homepage":"","size":326,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reddit:master","ref":"master","sha":"a14014eae61a8f9cd28577bca843cf48da8c0bd4","user":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"repo":{"id":7122209,"name":"reddit-plugin-adzerk","full_name":"reddit/reddit-plugin-adzerk","owner":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reddit/reddit-plugin-adzerk","description":"reddit plugin for adzerk-hosted adverts","fork":false,"url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk","forks_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/forks","keys_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/teams","hooks_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/hooks","issue_events_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/issues/events{/number}","events_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/events","assignees_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/assignees{/user}","branches_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/branches{/branch}","tags_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/tags","blobs_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/git/refs{/sha}","trees_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/statuses/{sha}","languages_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/languages","stargazers_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/stargazers","contributors_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/contributors","subscribers_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/subscribers","subscription_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/subscription","commits_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/commits{/sha}","git_commits_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/git/commits{/sha}","comments_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/comments{/number}","issue_comment_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/issues/comments{/number}","contents_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/contents/{+path}","compare_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/merges","archive_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/downloads","issues_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/issues{/number}","pulls_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls{/number}","milestones_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/milestones{/number}","notifications_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/labels{/name}","releases_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/releases{/id}","created_at":"2012-12-12T00:59:20Z","updated_at":"2015-04-30T21:19:46Z","pushed_at":"2015-09-03T23:10:02Z","git_url":"git://github.com/reddit/reddit-plugin-adzerk.git","ssh_url":"git@github.com:reddit/reddit-plugin-adzerk.git","clone_url":"https://github.com/reddit/reddit-plugin-adzerk.git","svn_url":"https://github.com/reddit/reddit-plugin-adzerk","homepage":"","size":1369,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":5,"forks":12,"open_issues":5,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/91"},"html":{"href":"https://github.com/reddit/reddit-plugin-adzerk/pull/91"},"issue":{"href":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/issues/91"},"comments":{"href":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/statuses/1f88d6be25e4276404172b81977d24c208249b85"}}}}