{"action":"created","issue":{"url":"https://api.github.com/repos/ubuntu-core/snappy/issues/238","labels_url":"https://api.github.com/repos/ubuntu-core/snappy/issues/238/labels{/name}","comments_url":"https://api.github.com/repos/ubuntu-core/snappy/issues/238/comments","events_url":"https://api.github.com/repos/ubuntu-core/snappy/issues/238/events","html_url":"https://github.com/ubuntu-core/snappy/pull/238","id":121026062,"number":238,"title":"Bugfix/remove store icon download","user":{"login":"mvo5","id":914418,"avatar_url":"https://avatars.githubusercontent.com/u/914418?v=3","gravatar_id":"","url":"https://api.github.com/users/mvo5","html_url":"https://github.com/mvo5","followers_url":"https://api.github.com/users/mvo5/followers","following_url":"https://api.github.com/users/mvo5/following{/other_user}","gists_url":"https://api.github.com/users/mvo5/gists{/gist_id}","starred_url":"https://api.github.com/users/mvo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvo5/subscriptions","organizations_url":"https://api.github.com/users/mvo5/orgs","repos_url":"https://api.github.com/users/mvo5/repos","events_url":"https://api.github.com/users/mvo5/events{/privacy}","received_events_url":"https://api.github.com/users/mvo5/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-08T15:05:59Z","updated_at":"2015-12-09T13:18:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ubuntu-core/snappy/pulls/238","html_url":"https://github.com/ubuntu-core/snappy/pull/238","diff_url":"https://github.com/ubuntu-core/snappy/pull/238.diff","patch_url":"https://github.com/ubuntu-core/snappy/pull/238.patch"},"body":"As discussed during the sprint we do not want to download icons from the store anymore. The snaps themself are always the source of the icon. This branch removes the icon downloading from the store.\r\n\r\nA careful look at the daemon/ part by @chipaca is welcome, I'm not sure I fully understood the code. I.e. I don't know why we have /icons/[icon] instead of just /icons/[name]/icon. I assume we use that so that the json for \"list\" can just return \"icon: my-crazy-icon-name.png\" (?) but even then we could just normalize that in list and only use a single /icons/[name]/icon call. I'm probably missing something here :)"},"comment":{"url":"https://api.github.com/repos/ubuntu-core/snappy/issues/comments/163228781","html_url":"https://github.com/ubuntu-core/snappy/pull/238#issuecomment-163228781","issue_url":"https://api.github.com/repos/ubuntu-core/snappy/issues/238","id":163228781,"user":{"login":"sergiusens","id":1146853,"avatar_url":"https://avatars.githubusercontent.com/u/1146853?v=3","gravatar_id":"","url":"https://api.github.com/users/sergiusens","html_url":"https://github.com/sergiusens","followers_url":"https://api.github.com/users/sergiusens/followers","following_url":"https://api.github.com/users/sergiusens/following{/other_user}","gists_url":"https://api.github.com/users/sergiusens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiusens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiusens/subscriptions","organizations_url":"https://api.github.com/users/sergiusens/orgs","repos_url":"https://api.github.com/users/sergiusens/repos","events_url":"https://api.github.com/users/sergiusens/events{/privacy}","received_events_url":"https://api.github.com/users/sergiusens/received_events","type":"User","site_admin":false},"created_at":"2015-12-09T13:18:59Z","updated_at":"2015-12-09T13:18:59Z","body":"On Wed, Dec 9, 2015 at 7:38 AM, Michael Vogt <notifications@github.com>\nwrote:\n\n> If package.yaml does not specify an icon is it the job of snappy to\n> provide the alternative url? Or should the frontend (webdm?) just deal with\n> \"icon: \" and show whatever stock icon it deems fit?\n>\n\nPersonally I think it is snapd's responsibility. The store can provide the\nlink to the default icon in the icon keyword.\n"}}