{"action":"created","comment":{"url":"https://api.github.com/repos/ros2/design/pulls/comments/36560711","id":36560711,"diff_hunk":"@@ -116,5 +130,10 @@ The generated code is split across multiple files the same way as message are.\n \n ### Request and response messages\n \n-For the request as well as the response part messages are being generated which have the same name as the service with a suffix being either `_Request` or `_Response`.\n-These messages are still defined in the `srv` sub namespace.\n+The request and response messages are generated with the service name and a suffix of `Request` or `Response`.\n+\n+These messages are still defined in the `srv` sub-namespace.\n+\n+<div class=\"alert alert-warning\" markdown=\"1\">\n+  **Note:** That is not consistent with ROS 1 usage.\n+</div>","path":"articles/112_generated_interfaces_cpp.md","position":58,"original_position":58,"commit_id":"9ca5126657a09f8289b47b9309e0b3c682f92a68","original_commit_id":"9ca5126657a09f8289b47b9309e0b3c682f92a68","user":{"login":"jack-oquin","id":1471375,"avatar_url":"https://avatars.githubusercontent.com/u/1471375?v=3","gravatar_id":"","url":"https://api.github.com/users/jack-oquin","html_url":"https://github.com/jack-oquin","followers_url":"https://api.github.com/users/jack-oquin/followers","following_url":"https://api.github.com/users/jack-oquin/following{/other_user}","gists_url":"https://api.github.com/users/jack-oquin/gists{/gist_id}","starred_url":"https://api.github.com/users/jack-oquin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jack-oquin/subscriptions","organizations_url":"https://api.github.com/users/jack-oquin/orgs","repos_url":"https://api.github.com/users/jack-oquin/repos","events_url":"https://api.github.com/users/jack-oquin/events{/privacy}","received_events_url":"https://api.github.com/users/jack-oquin/received_events","type":"User","site_admin":false},"body":"As mentioned above, I recommend removing the `srv` sub-namespace.","created_at":"2015-08-07T20:59:22Z","updated_at":"2015-08-07T20:59:22Z","html_url":"https://github.com/ros2/design/pull/50#discussion_r36560711","pull_request_url":"https://api.github.com/repos/ros2/design/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/ros2/design/pulls/comments/36560711"},"html":{"href":"https://github.com/ros2/design/pull/50#discussion_r36560711"},"pull_request":{"href":"https://api.github.com/repos/ros2/design/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/ros2/design/pulls/50","id":41928464,"html_url":"https://github.com/ros2/design/pull/50","diff_url":"https://github.com/ros2/design/pull/50.diff","patch_url":"https://github.com/ros2/design/pull/50.patch","issue_url":"https://api.github.com/repos/ros2/design/issues/50","number":50,"state":"open","locked":false,"title":"Review comments for \"Generated C++ interfaces\"","user":{"login":"jack-oquin","id":1471375,"avatar_url":"https://avatars.githubusercontent.com/u/1471375?v=3","gravatar_id":"","url":"https://api.github.com/users/jack-oquin","html_url":"https://github.com/jack-oquin","followers_url":"https://api.github.com/users/jack-oquin/followers","following_url":"https://api.github.com/users/jack-oquin/following{/other_user}","gists_url":"https://api.github.com/users/jack-oquin/gists{/gist_id}","starred_url":"https://api.github.com/users/jack-oquin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jack-oquin/subscriptions","organizations_url":"https://api.github.com/users/jack-oquin/orgs","repos_url":"https://api.github.com/users/jack-oquin/repos","events_url":"https://api.github.com/users/jack-oquin/events{/privacy}","received_events_url":"https://api.github.com/users/jack-oquin/received_events","type":"User","site_admin":false},"body":"This pull request is for reviewing the referenced ROS 2 design document:\r\n\r\n* http://design.ros2.org/articles/interface_definition.html\r\n* https://github.com/jack-oquin/design/blob/gh-pages/articles/112_generated_interfaces_cpp.md\r\n\r\nRelevant discussions:\r\n\r\n* #48 \r\n* https://groups.google.com/forum/#!topic/ros-sig-ng-ros/RaA617pJZtU\r\n* https://groups.google.com/forum/#!topic/ros-sig-ng-ros/61C8GUaBfKE\r\n* https://groups.google.com/forum/#!topic/ros-sig-ng-ros/wP__Hu9O8kM","created_at":"2015-08-07T20:08:16Z","updated_at":"2015-08-07T20:59:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"231c5a7dffd2cc887544b4a9ba334b778524f4e5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ros2/design/pulls/50/commits","review_comments_url":"https://api.github.com/repos/ros2/design/pulls/50/comments","review_comment_url":"https://api.github.com/repos/ros2/design/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros2/design/issues/50/comments","statuses_url":"https://api.github.com/repos/ros2/design/statuses/9ca5126657a09f8289b47b9309e0b3c682f92a68","head":{"label":"jack-oquin:gh-pages","ref":"gh-pages","sha":"9ca5126657a09f8289b47b9309e0b3c682f92a68","user":{"login":"jack-oquin","id":1471375,"avatar_url":"https://avatars.githubusercontent.com/u/1471375?v=3","gravatar_id":"","url":"https://api.github.com/users/jack-oquin","html_url":"https://github.com/jack-oquin","followers_url":"https://api.github.com/users/jack-oquin/followers","following_url":"https://api.github.com/users/jack-oquin/following{/other_user}","gists_url":"https://api.github.com/users/jack-oquin/gists{/gist_id}","starred_url":"https://api.github.com/users/jack-oquin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jack-oquin/subscriptions","organizations_url":"https://api.github.com/users/jack-oquin/orgs","repos_url":"https://api.github.com/users/jack-oquin/repos","events_url":"https://api.github.com/users/jack-oquin/events{/privacy}","received_events_url":"https://api.github.com/users/jack-oquin/received_events","type":"User","site_admin":false},"repo":{"id":39838650,"name":"design","full_name":"jack-oquin/design","owner":{"login":"jack-oquin","id":1471375,"avatar_url":"https://avatars.githubusercontent.com/u/1471375?v=3","gravatar_id":"","url":"https://api.github.com/users/jack-oquin","html_url":"https://github.com/jack-oquin","followers_url":"https://api.github.com/users/jack-oquin/followers","following_url":"https://api.github.com/users/jack-oquin/following{/other_user}","gists_url":"https://api.github.com/users/jack-oquin/gists{/gist_id}","starred_url":"https://api.github.com/users/jack-oquin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jack-oquin/subscriptions","organizations_url":"https://api.github.com/users/jack-oquin/orgs","repos_url":"https://api.github.com/users/jack-oquin/repos","events_url":"https://api.github.com/users/jack-oquin/events{/privacy}","received_events_url":"https://api.github.com/users/jack-oquin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jack-oquin/design","description":"Design documentation for ROS 2.0 effort","fork":true,"url":"https://api.github.com/repos/jack-oquin/design","forks_url":"https://api.github.com/repos/jack-oquin/design/forks","keys_url":"https://api.github.com/repos/jack-oquin/design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jack-oquin/design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jack-oquin/design/teams","hooks_url":"https://api.github.com/repos/jack-oquin/design/hooks","issue_events_url":"https://api.github.com/repos/jack-oquin/design/issues/events{/number}","events_url":"https://api.github.com/repos/jack-oquin/design/events","assignees_url":"https://api.github.com/repos/jack-oquin/design/assignees{/user}","branches_url":"https://api.github.com/repos/jack-oquin/design/branches{/branch}","tags_url":"https://api.github.com/repos/jack-oquin/design/tags","blobs_url":"https://api.github.com/repos/jack-oquin/design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jack-oquin/design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jack-oquin/design/git/refs{/sha}","trees_url":"https://api.github.com/repos/jack-oquin/design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jack-oquin/design/statuses/{sha}","languages_url":"https://api.github.com/repos/jack-oquin/design/languages","stargazers_url":"https://api.github.com/repos/jack-oquin/design/stargazers","contributors_url":"https://api.github.com/repos/jack-oquin/design/contributors","subscribers_url":"https://api.github.com/repos/jack-oquin/design/subscribers","subscription_url":"https://api.github.com/repos/jack-oquin/design/subscription","commits_url":"https://api.github.com/repos/jack-oquin/design/commits{/sha}","git_commits_url":"https://api.github.com/repos/jack-oquin/design/git/commits{/sha}","comments_url":"https://api.github.com/repos/jack-oquin/design/comments{/number}","issue_comment_url":"https://api.github.com/repos/jack-oquin/design/issues/comments{/number}","contents_url":"https://api.github.com/repos/jack-oquin/design/contents/{+path}","compare_url":"https://api.github.com/repos/jack-oquin/design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jack-oquin/design/merges","archive_url":"https://api.github.com/repos/jack-oquin/design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jack-oquin/design/downloads","issues_url":"https://api.github.com/repos/jack-oquin/design/issues{/number}","pulls_url":"https://api.github.com/repos/jack-oquin/design/pulls{/number}","milestones_url":"https://api.github.com/repos/jack-oquin/design/milestones{/number}","notifications_url":"https://api.github.com/repos/jack-oquin/design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jack-oquin/design/labels{/name}","releases_url":"https://api.github.com/repos/jack-oquin/design/releases{/id}","created_at":"2015-07-28T14:27:30Z","updated_at":"2015-07-28T14:27:30Z","pushed_at":"2015-08-07T19:43:31Z","git_url":"git://github.com/jack-oquin/design.git","ssh_url":"git@github.com:jack-oquin/design.git","clone_url":"https://github.com/jack-oquin/design.git","svn_url":"https://github.com/jack-oquin/design","homepage":"http://design.ros2.org/","size":2079,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"gh-pages"}},"base":{"label":"ros2:gh-pages","ref":"gh-pages","sha":"abc280c4ab9e908fe559e8de0cb9ce1f40805db4","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":14241623,"name":"design","full_name":"ros2/design","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/design","description":"Design documentation for ROS 2.0 effort","fork":false,"url":"https://api.github.com/repos/ros2/design","forks_url":"https://api.github.com/repos/ros2/design/forks","keys_url":"https://api.github.com/repos/ros2/design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/design/teams","hooks_url":"https://api.github.com/repos/ros2/design/hooks","issue_events_url":"https://api.github.com/repos/ros2/design/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/design/events","assignees_url":"https://api.github.com/repos/ros2/design/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/design/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/design/tags","blobs_url":"https://api.github.com/repos/ros2/design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/design/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/design/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/design/languages","stargazers_url":"https://api.github.com/repos/ros2/design/stargazers","contributors_url":"https://api.github.com/repos/ros2/design/contributors","subscribers_url":"https://api.github.com/repos/ros2/design/subscribers","subscription_url":"https://api.github.com/repos/ros2/design/subscription","commits_url":"https://api.github.com/repos/ros2/design/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/design/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/design/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/design/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/design/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/design/merges","archive_url":"https://api.github.com/repos/ros2/design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/design/downloads","issues_url":"https://api.github.com/repos/ros2/design/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/design/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/design/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/design/labels{/name}","releases_url":"https://api.github.com/repos/ros2/design/releases{/id}","created_at":"2013-11-08T18:56:29Z","updated_at":"2015-08-06T07:32:37Z","pushed_at":"2015-08-07T20:08:17Z","git_url":"git://github.com/ros2/design.git","ssh_url":"git@github.com:ros2/design.git","clone_url":"https://github.com/ros2/design.git","svn_url":"https://github.com/ros2/design","homepage":"http://design.ros2.org/","size":2179,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"open_issues_count":9,"forks":21,"open_issues":9,"watchers":16,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/ros2/design/pulls/50"},"html":{"href":"https://github.com/ros2/design/pull/50"},"issue":{"href":"https://api.github.com/repos/ros2/design/issues/50"},"comments":{"href":"https://api.github.com/repos/ros2/design/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/ros2/design/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/ros2/design/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros2/design/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/ros2/design/statuses/9ca5126657a09f8289b47b9309e0b3c682f92a68"}}}}