{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/2572","labels_url":"https://api.github.com/repos/facebook/react-native/issues/2572/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/2572/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/2572/events","html_url":"https://github.com/facebook/react-native/pull/2572","id":105112097,"number":2572,"title":"[CLI] bundle arguments consistency / improvements","user":{"login":"nsimmons","id":3313263,"avatar_url":"https://avatars.githubusercontent.com/u/3313263?v=3","gravatar_id":"","url":"https://api.github.com/users/nsimmons","html_url":"https://github.com/nsimmons","followers_url":"https://api.github.com/users/nsimmons/followers","following_url":"https://api.github.com/users/nsimmons/following{/other_user}","gists_url":"https://api.github.com/users/nsimmons/gists{/gist_id}","starred_url":"https://api.github.com/users/nsimmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsimmons/subscriptions","organizations_url":"https://api.github.com/users/nsimmons/orgs","repos_url":"https://api.github.com/users/nsimmons/repos","events_url":"https://api.github.com/users/nsimmons/events{/privacy}","received_events_url":"https://api.github.com/users/nsimmons/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"},{"url":"https://api.github.com/repos/facebook/react-native/labels/packager","name":"packager","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"frantic","id":192222,"avatar_url":"https://avatars.githubusercontent.com/u/192222?v=3","gravatar_id":"","url":"https://api.github.com/users/frantic","html_url":"https://github.com/frantic","followers_url":"https://api.github.com/users/frantic/followers","following_url":"https://api.github.com/users/frantic/following{/other_user}","gists_url":"https://api.github.com/users/frantic/gists{/gist_id}","starred_url":"https://api.github.com/users/frantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frantic/subscriptions","organizations_url":"https://api.github.com/users/frantic/orgs","repos_url":"https://api.github.com/users/frantic/repos","events_url":"https://api.github.com/users/frantic/events{/privacy}","received_events_url":"https://api.github.com/users/frantic/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-09-06T19:14:43Z","updated_at":"2015-09-10T15:26:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/2572","html_url":"https://github.com/facebook/react-native/pull/2572","diff_url":"https://github.com/facebook/react-native/pull/2572.diff","patch_url":"https://github.com/facebook/react-native/pull/2572.patch"},"body":"I was digging through the CLI the other day and noticed that the bundle command arguments were not well documented on the website. I also noticed some inconsistencies and misleading argument names.\r\n\r\nThis PR tries to bring the bundle command on CLI to a better place. \r\n\r\n- RunningOnDevice docs now mention what the help command is to list additional options (I had to look at the code to figure out if a help command existed, and what the exact syntax was).\r\n- Packager Readme was updated with better copy (up to your discretion if it is in fact better) for the options.\r\n- Updated the descriptions of some of the arguments when calling `react-native bundle help` to be more clear (also up to your discretion if they are actually better)\r\n- Replaced `--root` with `--roots` to allow a comma separated list of paths to be passed in, similar to `--assetRoots`. I saw no good reason to only allow a single additional root path but multiple asset paths.\r\n- Replace `--url` with `--appModule`. The bundle cli code converts the specified JS file into its url representation that is passed to `ReactPackager`, but this is an implementation detail. When I was trying to figure out what I needed to pass in for the `url` argument on a project where I did not have the default file name for my root app component I had to look at the code. I think `appModule` and the new help description for this argument is much more descriptive now. \r\n\r\nPlease review and consider my proposed changes. Thanks!"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/139280160","html_url":"https://github.com/facebook/react-native/pull/2572#issuecomment-139280160","issue_url":"https://api.github.com/repos/facebook/react-native/issues/2572","id":139280160,"user":{"login":"frantic","id":192222,"avatar_url":"https://avatars.githubusercontent.com/u/192222?v=3","gravatar_id":"","url":"https://api.github.com/users/frantic","html_url":"https://github.com/frantic","followers_url":"https://api.github.com/users/frantic/followers","following_url":"https://api.github.com/users/frantic/following{/other_user}","gists_url":"https://api.github.com/users/frantic/gists{/gist_id}","starred_url":"https://api.github.com/users/frantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frantic/subscriptions","organizations_url":"https://api.github.com/users/frantic/orgs","repos_url":"https://api.github.com/users/frantic/repos","events_url":"https://api.github.com/users/frantic/events{/privacy}","received_events_url":"https://api.github.com/users/frantic/received_events","type":"User","site_admin":false},"created_at":"2015-09-10T15:26:36Z","updated_at":"2015-09-10T15:26:36Z","body":"@martinbigio can you take a look at this one?"}}