{"action":"created","issue":{"url":"https://api.github.com/repos/dimitar-asenov/Envision/issues/188","labels_url":"https://api.github.com/repos/dimitar-asenov/Envision/issues/188/labels{/name}","comments_url":"https://api.github.com/repos/dimitar-asenov/Envision/issues/188/comments","events_url":"https://api.github.com/repos/dimitar-asenov/Envision/issues/188/events","html_url":"https://github.com/dimitar-asenov/Envision/pull/188","id":113152955,"number":188,"title":"Minor fixes after clang --analyze run","user":{"login":"lukedirtwalker","id":3530769,"avatar_url":"https://avatars.githubusercontent.com/u/3530769?v=3","gravatar_id":"","url":"https://api.github.com/users/lukedirtwalker","html_url":"https://github.com/lukedirtwalker","followers_url":"https://api.github.com/users/lukedirtwalker/followers","following_url":"https://api.github.com/users/lukedirtwalker/following{/other_user}","gists_url":"https://api.github.com/users/lukedirtwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/lukedirtwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukedirtwalker/subscriptions","organizations_url":"https://api.github.com/users/lukedirtwalker/orgs","repos_url":"https://api.github.com/users/lukedirtwalker/repos","events_url":"https://api.github.com/users/lukedirtwalker/events{/privacy}","received_events_url":"https://api.github.com/users/lukedirtwalker/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-10-24T11:35:57Z","updated_at":"2015-10-24T13:31:57Z","closed_at":"2015-10-24T13:27:17Z","pull_request":{"url":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/188","html_url":"https://github.com/dimitar-asenov/Envision/pull/188","diff_url":"https://github.com/dimitar-asenov/Envision/pull/188.diff","patch_url":"https://github.com/dimitar-asenov/Envision/pull/188.patch"},"body":"-We shouldn't call delete on new[] allocated stuff, thus we replace\r\nSAFE_DELETE with actual delete[] calls.\r\n-Consistenly check the error with checkError, before there were some\r\nerrorCode write locations which were never read.\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/dimitar-asenov/Envision/pull/188%23issuecomment-150811759%22%2C%20%22https%3A//github.com/dimitar-asenov/Envision/pull/188%23issuecomment-150811815%22%2C%20%22https%3A//github.com/dimitar-asenov/Envision/pull/188%23issuecomment-150811857%22%2C%20%22https%3A//github.com/dimitar-asenov/Envision/pull/188%23issuecomment-150811894%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov/Envision/pull/188%23issuecomment-150811759%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Sweet%21%20thanks.%20Didn%27t%20clang%20analyze%20find%20a%20ton%20of%20other%20issues%3F%22%2C%20%22created_at%22%3A%20%222015-10-24T13%3A27%3A15Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1152976%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov%22%7D%7D%2C%20%7B%22body%22%3A%20%22Not%20a%20ton%20but%20many.%20But%20most%20are%20false%20positives%20I%20think.%22%2C%20%22created_at%22%3A%20%222015-10-24T13%3A28%3A31Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/3530769%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/lukedirtwalker%22%7D%7D%2C%20%7B%22body%22%3A%20%22I%27d%20be%20curious%20to%20have%20a%20look%2C%20but%20maybe%20next%20week%20at%20ETH.%20My%20schedule%20is%20quite%20full%20this%20weekend.%22%2C%20%22created_at%22%3A%20%222015-10-24T13%3A29%3A38Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1152976%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov%22%7D%7D%2C%20%7B%22body%22%3A%20%22Sure%2C%20there%20are%20some%20which%20could%20be%20interesting%20to%20look%20at.%20Have%20a%20nice%20weekend.%22%2C%20%22created_at%22%3A%20%222015-10-24T13%3A30%3A36Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/3530769%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/lukedirtwalker%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/dimitar-asenov/Envision/pull/188#issuecomment-150811759'>General Comment</a></b>\n- <a href='https://github.com/dimitar-asenov'><img border=0 src='https://avatars.githubusercontent.com/u/1152976?v=3' height=16 width=16'></a> Sweet! thanks. Didn't clang analyze find a ton of other issues?\n- <a href='https://github.com/lukedirtwalker'><img border=0 src='https://avatars.githubusercontent.com/u/3530769?v=3' height=16 width=16'></a> Not a ton but many. But most are false positives I think.\n- <a href='https://github.com/dimitar-asenov'><img border=0 src='https://avatars.githubusercontent.com/u/1152976?v=3' height=16 width=16'></a> I'd be curious to have a look, but maybe next week at ETH. My schedule is quite full this weekend.\n- <a href='https://github.com/lukedirtwalker'><img border=0 src='https://avatars.githubusercontent.com/u/3530769?v=3' height=16 width=16'></a> Sure, there are some which could be interesting to look at. Have a nice weekend.\n\n\n<a href='https://www.codereviewhub.com/dimitar-asenov/Envision/pull/188?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/dimitar-asenov/Envision/pull/188?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/dimitar-asenov/Envision/pull/188'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>"},"comment":{"url":"https://api.github.com/repos/dimitar-asenov/Envision/issues/comments/150811958","html_url":"https://github.com/dimitar-asenov/Envision/pull/188#issuecomment-150811958","issue_url":"https://api.github.com/repos/dimitar-asenov/Envision/issues/188","id":150811958,"user":{"login":"dimitar-asenov","id":1152976,"avatar_url":"https://avatars.githubusercontent.com/u/1152976?v=3","gravatar_id":"","url":"https://api.github.com/users/dimitar-asenov","html_url":"https://github.com/dimitar-asenov","followers_url":"https://api.github.com/users/dimitar-asenov/followers","following_url":"https://api.github.com/users/dimitar-asenov/following{/other_user}","gists_url":"https://api.github.com/users/dimitar-asenov/gists{/gist_id}","starred_url":"https://api.github.com/users/dimitar-asenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimitar-asenov/subscriptions","organizations_url":"https://api.github.com/users/dimitar-asenov/orgs","repos_url":"https://api.github.com/users/dimitar-asenov/repos","events_url":"https://api.github.com/users/dimitar-asenov/events{/privacy}","received_events_url":"https://api.github.com/users/dimitar-asenov/received_events","type":"User","site_admin":false},"created_at":"2015-10-24T13:31:57Z","updated_at":"2015-10-24T13:31:57Z","body":"Thanks, you too."}}