{"action":"created","comment":{"url":"https://api.github.com/repos/PistonDevelopers/hematite/pulls/comments/30177823","id":30177823,"diff_hunk":"@@ -395,16 +395,17 @@ impl<R: gfx::Resources, D: gfx::Device<Resources=R> + gfx::Factory<R>> BlockStat\n     }\n }\n \n-pub fn fill_buffer<R: gfx::Resources, D: gfx::Device<Resources=R> + gfx::Factory<R>>(block_states: &BlockStates<D>,\n+pub fn fill_buffer<R: gfx::Resources>(block_states: &BlockStates<R>,\n                    biomes: &Biomes, buffer: &mut Vec<Vertex>,\n                    coords: [i32; 3], chunks: [[[&Chunk; 3]; 3]; 3],\n                    column_biomes: [[Option<&[[BiomeId; 16]; 16]>; 3]; 3]) {\n     let chunk_xyz = coords.map(|x| x as f32 * 16.0);\n-    for y in range(0, 16) {\n-        for z in range(0, 16) {\n-            for x in range(0, 16) {\n+    for y in 0..16 {\n+        for z in 0..16 {\n+            for x in 0..16 {\n                 let at = |dir: [i32; 3]| {\n                     let [dx, dy, dz] = dir.map(|x| x as usize);\n+                    let [x, y, z] = [x, y, z].map(|x| x as usize);","path":"src/minecraft/block_state.rs","position":133,"original_position":133,"commit_id":"7a39997a9b86f35f34bfdfaafc7ff9c1afa385d5","original_commit_id":"7a39997a9b86f35f34bfdfaafc7ff9c1afa385d5","user":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"body":"Huh, why is this necessary? Type inference failure? Use `0..16_usize` for the ranges, if so.","created_at":"2015-05-12T20:41:20Z","updated_at":"2015-05-12T20:41:20Z","html_url":"https://github.com/PistonDevelopers/hematite/pull/216#discussion_r30177823","pull_request_url":"https://api.github.com/repos/PistonDevelopers/hematite/pulls/216","_links":{"self":{"href":"https://api.github.com/repos/PistonDevelopers/hematite/pulls/comments/30177823"},"html":{"href":"https://github.com/PistonDevelopers/hematite/pull/216#discussion_r30177823"},"pull_request":{"href":"https://api.github.com/repos/PistonDevelopers/hematite/pulls/216"}}},"pull_request":{"url":"https://api.github.com/repos/PistonDevelopers/hematite/pulls/216","id":35188715,"html_url":"https://github.com/PistonDevelopers/hematite/pull/216","diff_url":"https://github.com/PistonDevelopers/hematite/pull/216.diff","patch_url":"https://github.com/PistonDevelopers/hematite/pull/216.patch","issue_url":"https://api.github.com/repos/PistonDevelopers/hematite/issues/216","number":216,"state":"open","locked":false,"title":"[WIP] Fix #215 - Remove quack library usage","user":{"login":"mattico","id":853158,"avatar_url":"https://avatars.githubusercontent.com/u/853158?v=3","gravatar_id":"","url":"https://api.github.com/users/mattico","html_url":"https://github.com/mattico","followers_url":"https://api.github.com/users/mattico/followers","following_url":"https://api.github.com/users/mattico/following{/other_user}","gists_url":"https://api.github.com/users/mattico/gists{/gist_id}","starred_url":"https://api.github.com/users/mattico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattico/subscriptions","organizations_url":"https://api.github.com/users/mattico/orgs","repos_url":"https://api.github.com/users/mattico/repos","events_url":"https://api.github.com/users/mattico/events{/privacy}","received_events_url":"https://api.github.com/users/mattico/received_events","type":"User","site_admin":false},"body":"Not currently working, but progress has been made:\r\n* `cargo update`\r\n* `flate` -> `flate2` (crates.io)\r\n* `os::MemoryMap` -> `mmap`\r\n* `rustc-serialize` `0.2.8` -> `0.3.x`\r\n* `range(a, b)` -> `a..b`\r\n* `old_io` -> `io`\r\n* Other misc changes.\r\n\r\nMost of the grunt work has been done to update hematite for rust nightly/beta, and the ever-changing gfx-rs and piston. Currently, what's left to be done is to disentangle the Renderer type from Device/Factory in `shader.rs`, and `block_state.rs` (or some other solution) to finish removing quack. In fact, if you know what you're doing, it might be easier to start with the `shader.rs` from master and work from there since the one in the PR was committed in the middle of me trying to understand the web of inheritance going on there.\r\n\r\nA potential papercut to note: I didn't notice at the time but the mmap crate from crates.io might not work on Windows right now (PR Pending ?).","created_at":"2015-05-12T02:41:45Z","updated_at":"2015-05-12T20:41:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbe9c9fbd2c8979d4fc15be1a815f0dc33d44071","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PistonDevelopers/hematite/pulls/216/commits","review_comments_url":"https://api.github.com/repos/PistonDevelopers/hematite/pulls/216/comments","review_comment_url":"https://api.github.com/repos/PistonDevelopers/hematite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PistonDevelopers/hematite/issues/216/comments","statuses_url":"https://api.github.com/repos/PistonDevelopers/hematite/statuses/7a39997a9b86f35f34bfdfaafc7ff9c1afa385d5","head":{"label":"mattico:remove-quack","ref":"remove-quack","sha":"7a39997a9b86f35f34bfdfaafc7ff9c1afa385d5","user":{"login":"mattico","id":853158,"avatar_url":"https://avatars.githubusercontent.com/u/853158?v=3","gravatar_id":"","url":"https://api.github.com/users/mattico","html_url":"https://github.com/mattico","followers_url":"https://api.github.com/users/mattico/followers","following_url":"https://api.github.com/users/mattico/following{/other_user}","gists_url":"https://api.github.com/users/mattico/gists{/gist_id}","starred_url":"https://api.github.com/users/mattico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattico/subscriptions","organizations_url":"https://api.github.com/users/mattico/orgs","repos_url":"https://api.github.com/users/mattico/repos","events_url":"https://api.github.com/users/mattico/events{/privacy}","received_events_url":"https://api.github.com/users/mattico/received_events","type":"User","site_admin":false},"repo":{"id":35383711,"name":"hematite","full_name":"mattico/hematite","owner":{"login":"mattico","id":853158,"avatar_url":"https://avatars.githubusercontent.com/u/853158?v=3","gravatar_id":"","url":"https://api.github.com/users/mattico","html_url":"https://github.com/mattico","followers_url":"https://api.github.com/users/mattico/followers","following_url":"https://api.github.com/users/mattico/following{/other_user}","gists_url":"https://api.github.com/users/mattico/gists{/gist_id}","starred_url":"https://api.github.com/users/mattico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattico/subscriptions","organizations_url":"https://api.github.com/users/mattico/orgs","repos_url":"https://api.github.com/users/mattico/repos","events_url":"https://api.github.com/users/mattico/events{/privacy}","received_events_url":"https://api.github.com/users/mattico/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattico/hematite","description":"A simple Minecraft written in Rust with the Piston game engine","fork":true,"url":"https://api.github.com/repos/mattico/hematite","forks_url":"https://api.github.com/repos/mattico/hematite/forks","keys_url":"https://api.github.com/repos/mattico/hematite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattico/hematite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattico/hematite/teams","hooks_url":"https://api.github.com/repos/mattico/hematite/hooks","issue_events_url":"https://api.github.com/repos/mattico/hematite/issues/events{/number}","events_url":"https://api.github.com/repos/mattico/hematite/events","assignees_url":"https://api.github.com/repos/mattico/hematite/assignees{/user}","branches_url":"https://api.github.com/repos/mattico/hematite/branches{/branch}","tags_url":"https://api.github.com/repos/mattico/hematite/tags","blobs_url":"https://api.github.com/repos/mattico/hematite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattico/hematite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattico/hematite/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattico/hematite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattico/hematite/statuses/{sha}","languages_url":"https://api.github.com/repos/mattico/hematite/languages","stargazers_url":"https://api.github.com/repos/mattico/hematite/stargazers","contributors_url":"https://api.github.com/repos/mattico/hematite/contributors","subscribers_url":"https://api.github.com/repos/mattico/hematite/subscribers","subscription_url":"https://api.github.com/repos/mattico/hematite/subscription","commits_url":"https://api.github.com/repos/mattico/hematite/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattico/hematite/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattico/hematite/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattico/hematite/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattico/hematite/contents/{+path}","compare_url":"https://api.github.com/repos/mattico/hematite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattico/hematite/merges","archive_url":"https://api.github.com/repos/mattico/hematite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattico/hematite/downloads","issues_url":"https://api.github.com/repos/mattico/hematite/issues{/number}","pulls_url":"https://api.github.com/repos/mattico/hematite/pulls{/number}","milestones_url":"https://api.github.com/repos/mattico/hematite/milestones{/number}","notifications_url":"https://api.github.com/repos/mattico/hematite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattico/hematite/labels{/name}","releases_url":"https://api.github.com/repos/mattico/hematite/releases{/id}","created_at":"2015-05-10T18:56:28Z","updated_at":"2015-05-10T18:56:29Z","pushed_at":"2015-05-12T20:27:01Z","git_url":"git://github.com/mattico/hematite.git","ssh_url":"git@github.com:mattico/hematite.git","clone_url":"https://github.com/mattico/hematite.git","svn_url":"https://github.com/mattico/hematite","homepage":"http://hematite.piston.rs/","size":975,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PistonDevelopers:master","ref":"master","sha":"bb70aa93f0e8fb7bb17ed7aaae57d4a2d9e4b583","user":{"login":"PistonDevelopers","id":7623406,"avatar_url":"https://avatars.githubusercontent.com/u/7623406?v=3","gravatar_id":"","url":"https://api.github.com/users/PistonDevelopers","html_url":"https://github.com/PistonDevelopers","followers_url":"https://api.github.com/users/PistonDevelopers/followers","following_url":"https://api.github.com/users/PistonDevelopers/following{/other_user}","gists_url":"https://api.github.com/users/PistonDevelopers/gists{/gist_id}","starred_url":"https://api.github.com/users/PistonDevelopers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PistonDevelopers/subscriptions","organizations_url":"https://api.github.com/users/PistonDevelopers/orgs","repos_url":"https://api.github.com/users/PistonDevelopers/repos","events_url":"https://api.github.com/users/PistonDevelopers/events{/privacy}","received_events_url":"https://api.github.com/users/PistonDevelopers/received_events","type":"Organization","site_admin":false},"repo":{"id":21311275,"name":"hematite","full_name":"PistonDevelopers/hematite","owner":{"login":"PistonDevelopers","id":7623406,"avatar_url":"https://avatars.githubusercontent.com/u/7623406?v=3","gravatar_id":"","url":"https://api.github.com/users/PistonDevelopers","html_url":"https://github.com/PistonDevelopers","followers_url":"https://api.github.com/users/PistonDevelopers/followers","following_url":"https://api.github.com/users/PistonDevelopers/following{/other_user}","gists_url":"https://api.github.com/users/PistonDevelopers/gists{/gist_id}","starred_url":"https://api.github.com/users/PistonDevelopers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PistonDevelopers/subscriptions","organizations_url":"https://api.github.com/users/PistonDevelopers/orgs","repos_url":"https://api.github.com/users/PistonDevelopers/repos","events_url":"https://api.github.com/users/PistonDevelopers/events{/privacy}","received_events_url":"https://api.github.com/users/PistonDevelopers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PistonDevelopers/hematite","description":"A simple Minecraft written in Rust with the Piston game engine","fork":false,"url":"https://api.github.com/repos/PistonDevelopers/hematite","forks_url":"https://api.github.com/repos/PistonDevelopers/hematite/forks","keys_url":"https://api.github.com/repos/PistonDevelopers/hematite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PistonDevelopers/hematite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PistonDevelopers/hematite/teams","hooks_url":"https://api.github.com/repos/PistonDevelopers/hematite/hooks","issue_events_url":"https://api.github.com/repos/PistonDevelopers/hematite/issues/events{/number}","events_url":"https://api.github.com/repos/PistonDevelopers/hematite/events","assignees_url":"https://api.github.com/repos/PistonDevelopers/hematite/assignees{/user}","branches_url":"https://api.github.com/repos/PistonDevelopers/hematite/branches{/branch}","tags_url":"https://api.github.com/repos/PistonDevelopers/hematite/tags","blobs_url":"https://api.github.com/repos/PistonDevelopers/hematite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PistonDevelopers/hematite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PistonDevelopers/hematite/git/refs{/sha}","trees_url":"https://api.github.com/repos/PistonDevelopers/hematite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PistonDevelopers/hematite/statuses/{sha}","languages_url":"https://api.github.com/repos/PistonDevelopers/hematite/languages","stargazers_url":"https://api.github.com/repos/PistonDevelopers/hematite/stargazers","contributors_url":"https://api.github.com/repos/PistonDevelopers/hematite/contributors","subscribers_url":"https://api.github.com/repos/PistonDevelopers/hematite/subscribers","subscription_url":"https://api.github.com/repos/PistonDevelopers/hematite/subscription","commits_url":"https://api.github.com/repos/PistonDevelopers/hematite/commits{/sha}","git_commits_url":"https://api.github.com/repos/PistonDevelopers/hematite/git/commits{/sha}","comments_url":"https://api.github.com/repos/PistonDevelopers/hematite/comments{/number}","issue_comment_url":"https://api.github.com/repos/PistonDevelopers/hematite/issues/comments{/number}","contents_url":"https://api.github.com/repos/PistonDevelopers/hematite/contents/{+path}","compare_url":"https://api.github.com/repos/PistonDevelopers/hematite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PistonDevelopers/hematite/merges","archive_url":"https://api.github.com/repos/PistonDevelopers/hematite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PistonDevelopers/hematite/downloads","issues_url":"https://api.github.com/repos/PistonDevelopers/hematite/issues{/number}","pulls_url":"https://api.github.com/repos/PistonDevelopers/hematite/pulls{/number}","milestones_url":"https://api.github.com/repos/PistonDevelopers/hematite/milestones{/number}","notifications_url":"https://api.github.com/repos/PistonDevelopers/hematite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PistonDevelopers/hematite/labels{/name}","releases_url":"https://api.github.com/repos/PistonDevelopers/hematite/releases{/id}","created_at":"2014-06-28T21:22:28Z","updated_at":"2015-05-10T01:28:53Z","pushed_at":"2015-05-12T20:27:02Z","git_url":"git://github.com/PistonDevelopers/hematite.git","ssh_url":"git@github.com:PistonDevelopers/hematite.git","clone_url":"https://github.com/PistonDevelopers/hematite.git","svn_url":"https://github.com/PistonDevelopers/hematite","homepage":"http://hematite.piston.rs/","size":1868,"stargazers_count":563,"watchers_count":563,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":20,"forks":56,"open_issues":20,"watchers":563,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PistonDevelopers/hematite/pulls/216"},"html":{"href":"https://github.com/PistonDevelopers/hematite/pull/216"},"issue":{"href":"https://api.github.com/repos/PistonDevelopers/hematite/issues/216"},"comments":{"href":"https://api.github.com/repos/PistonDevelopers/hematite/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/PistonDevelopers/hematite/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/PistonDevelopers/hematite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PistonDevelopers/hematite/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/PistonDevelopers/hematite/statuses/7a39997a9b86f35f34bfdfaafc7ff9c1afa385d5"}}}}