{"action":"created","issue":{"url":"https://api.github.com/repos/stan-dev/stan/issues/1482","labels_url":"https://api.github.com/repos/stan-dev/stan/issues/1482/labels{/name}","comments_url":"https://api.github.com/repos/stan-dev/stan/issues/1482/comments","events_url":"https://api.github.com/repos/stan-dev/stan/issues/1482/events","html_url":"https://github.com/stan-dev/stan/pull/1482","id":85235450,"number":1482,"title":"Bugfix/issue 1198 missing fvar derivs","user":{"login":"rtrangucci","id":3925639,"avatar_url":"https://avatars.githubusercontent.com/u/3925639?v=3","gravatar_id":"","url":"https://api.github.com/users/rtrangucci","html_url":"https://github.com/rtrangucci","followers_url":"https://api.github.com/users/rtrangucci/followers","following_url":"https://api.github.com/users/rtrangucci/following{/other_user}","gists_url":"https://api.github.com/users/rtrangucci/gists{/gist_id}","starred_url":"https://api.github.com/users/rtrangucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtrangucci/subscriptions","organizations_url":"https://api.github.com/users/rtrangucci/orgs","repos_url":"https://api.github.com/users/rtrangucci/repos","events_url":"https://api.github.com/users/rtrangucci/events{/privacy}","received_events_url":"https://api.github.com/users/rtrangucci/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-06-04T19:11:32Z","updated_at":"2015-06-10T18:46:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stan-dev/stan/pulls/1482","html_url":"https://github.com/stan-dev/stan/pull/1482","diff_url":"https://github.com/stan-dev/stan/pull/1482.diff","patch_url":"https://github.com/stan-dev/stan/pull/1482.patch"},"body":"#### Summary:\r\n\r\nFixed tangent calculations for `fvar<T> operator*=()` and `fvar<T> operator/=()` \r\n`fvar<T> operator*()` and `fvar<T> operator/()` are less general\r\n\r\n#### Intended Effect:\r\n\r\nOperators return correct derivatives.\r\n\r\n#### How to Verify:\r\n\r\n./runTests.py src/test/unit/math/fwd/core/operator_multiply_test.cpp\r\n./runTests.py src/test/unit/math/mix/core/operator_multiply_test.cpp\r\n./runTests.py src/test/unit/math/fwd/core/operator_divide_test.cpp\r\n./runTests.py src/test/unit/math/mix/core/operator_divide_test.cpp\r\n./runTests.py src/test/unit/math/fwd/core/operator_multiply_equal_test.cpp\r\n./runTests.py src/test/unit/math/fwd/core/operator_divide_equal_test.cpp\r\n./runTests.py src/test/unit/math/mix/core/operator_multiply_equal_test.cpp\r\n./runTests.py src/test/unit/math/mix/core/operator_divide_equal_test.cpp\r\n\r\n#### Side Effects:\r\n\r\nNone.  \r\n\r\n#### Documentation:\r\n\r\nNone.\r\n\r\n#### Reviewer Suggestions: \r\n\r\nDaniel or Bob.\r\n"},"comment":{"url":"https://api.github.com/repos/stan-dev/stan/issues/comments/110874416","html_url":"https://github.com/stan-dev/stan/pull/1482#issuecomment-110874416","issue_url":"https://api.github.com/repos/stan-dev/stan/issues/1482","id":110874416,"user":{"login":"bob-carpenter","id":3383807,"avatar_url":"https://avatars.githubusercontent.com/u/3383807?v=3","gravatar_id":"","url":"https://api.github.com/users/bob-carpenter","html_url":"https://github.com/bob-carpenter","followers_url":"https://api.github.com/users/bob-carpenter/followers","following_url":"https://api.github.com/users/bob-carpenter/following{/other_user}","gists_url":"https://api.github.com/users/bob-carpenter/gists{/gist_id}","starred_url":"https://api.github.com/users/bob-carpenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bob-carpenter/subscriptions","organizations_url":"https://api.github.com/users/bob-carpenter/orgs","repos_url":"https://api.github.com/users/bob-carpenter/repos","events_url":"https://api.github.com/users/bob-carpenter/events{/privacy}","received_events_url":"https://api.github.com/users/bob-carpenter/received_events","type":"User","site_admin":false},"created_at":"2015-06-10T18:46:11Z","updated_at":"2015-06-10T18:46:11Z","body":"Looks good to me.  We probably want to follow the Google code guide and instead of writing\r\n\r\n```\r\ninline\r\nfoo\r\nbar(baz x) {\r\n  ...\r\n```\r\n\r\nto\r\n\r\n```\r\ninline foo bar(baz x) { \r\n  ...\r\n```\r\n\r\nbut it's not necessary for this pull request."}}