{"action":"created","issue":{"url":"https://api.github.com/repos/backdrop/backdrop-issues/issues/240","labels_url":"https://api.github.com/repos/backdrop/backdrop-issues/issues/240/labels{/name}","comments_url":"https://api.github.com/repos/backdrop/backdrop-issues/issues/240/comments","events_url":"https://api.github.com/repos/backdrop/backdrop-issues/issues/240/events","html_url":"https://github.com/backdrop/backdrop-issues/issues/240","id":33725140,"number":240,"title":"Add link (field) module to core","user":{"login":"jenlampton","id":397895,"avatar_url":"https://avatars.githubusercontent.com/u/397895?v=3","gravatar_id":"","url":"https://api.github.com/users/jenlampton","html_url":"https://github.com/jenlampton","followers_url":"https://api.github.com/users/jenlampton/followers","following_url":"https://api.github.com/users/jenlampton/following{/other_user}","gists_url":"https://api.github.com/users/jenlampton/gists{/gist_id}","starred_url":"https://api.github.com/users/jenlampton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenlampton/subscriptions","organizations_url":"https://api.github.com/users/jenlampton/orgs","repos_url":"https://api.github.com/users/jenlampton/repos","events_url":"https://api.github.com/users/jenlampton/events{/privacy}","received_events_url":"https://api.github.com/users/jenlampton/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/backdrop/backdrop-issues/labels/type%20-%20feature%20request","name":"type - feature request","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/backdrop/backdrop-issues/milestones/7","html_url":"https://github.com/backdrop/backdrop-issues/milestones/1.2.0","labels_url":"https://api.github.com/repos/backdrop/backdrop-issues/milestones/7/labels","id":940017,"number":7,"title":"1.2.0","description":"New features for the 1.2.x branch","creator":{"login":"jenlampton","id":397895,"avatar_url":"https://avatars.githubusercontent.com/u/397895?v=3","gravatar_id":"","url":"https://api.github.com/users/jenlampton","html_url":"https://github.com/jenlampton","followers_url":"https://api.github.com/users/jenlampton/followers","following_url":"https://api.github.com/users/jenlampton/following{/other_user}","gists_url":"https://api.github.com/users/jenlampton/gists{/gist_id}","starred_url":"https://api.github.com/users/jenlampton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenlampton/subscriptions","organizations_url":"https://api.github.com/users/jenlampton/orgs","repos_url":"https://api.github.com/users/jenlampton/repos","events_url":"https://api.github.com/users/jenlampton/events{/privacy}","received_events_url":"https://api.github.com/users/jenlampton/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":3,"state":"open","created_at":"2015-01-17T20:27:48Z","updated_at":"2015-06-12T22:24:11Z","due_on":"2015-09-15T07:00:00Z","closed_at":null},"comments":7,"created_at":"2014-05-17T06:55:05Z","updated_at":"2015-07-28T18:38:49Z","closed_at":null,"body":"Instead of leaving this as a stand-alone module, it should be added as a field type to field module.\r\n(form field types should be updated to use the HTML5 url element too)"},"comment":{"url":"https://api.github.com/repos/backdrop/backdrop-issues/issues/comments/125708179","html_url":"https://github.com/backdrop/backdrop-issues/issues/240#issuecomment-125708179","issue_url":"https://api.github.com/repos/backdrop/backdrop-issues/issues/240","id":125708179,"user":{"login":"docwilmot","id":1042283,"avatar_url":"https://avatars.githubusercontent.com/u/1042283?v=3","gravatar_id":"","url":"https://api.github.com/users/docwilmot","html_url":"https://github.com/docwilmot","followers_url":"https://api.github.com/users/docwilmot/followers","following_url":"https://api.github.com/users/docwilmot/following{/other_user}","gists_url":"https://api.github.com/users/docwilmot/gists{/gist_id}","starred_url":"https://api.github.com/users/docwilmot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docwilmot/subscriptions","organizations_url":"https://api.github.com/users/docwilmot/orgs","repos_url":"https://api.github.com/users/docwilmot/repos","events_url":"https://api.github.com/users/docwilmot/events{/privacy}","received_events_url":"https://api.github.com/users/docwilmot/received_events","type":"User","site_admin":false},"created_at":"2015-07-28T18:38:49Z","updated_at":"2015-07-28T18:38:49Z","body":"@serundeputy, had a look, but not sure how to contribute my changes, submit a new PR? A patch? The GitHub process is still fuzzy sometimes. Anyway, meanwhile, I'm pushing a new PR with still some failing tests, but closer to green, and:\r\n- I think the link entity_tokens tests dont really apply, since there is no exposure of token UI on the add field pages, which is what the test tests. Should that test be removed then?\r\n- the misbehaving `$instances = field_info_instances('node', 'page');` is because of a static variable set in `_field_info_collate_fields`. If you replpace the `_field_info_collate_fields(TRUE);` lines with `backdrop_static_reset();` it works.\r\n- fixed a few 'drupal' strings left over. \r\n- link.validate.test is failing on a `variable_get()` leftover which needs converting to config. I should have fixed that but havent, sorry. \r\n\r\n"}}