{"action":"created","issue":{"url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/issues/492","labels_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/issues/492/labels{/name}","comments_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/issues/492/comments","events_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/issues/492/events","html_url":"https://github.com/WikiEducationFoundation/WikiEduDashboard/pull/492","id":118912337,"number":492,"title":"Upgrade react and router","user":{"login":"thenickcox","id":702327,"avatar_url":"https://avatars.githubusercontent.com/u/702327?v=3","gravatar_id":"","url":"https://api.github.com/users/thenickcox","html_url":"https://github.com/thenickcox","followers_url":"https://api.github.com/users/thenickcox/followers","following_url":"https://api.github.com/users/thenickcox/following{/other_user}","gists_url":"https://api.github.com/users/thenickcox/gists{/gist_id}","starred_url":"https://api.github.com/users/thenickcox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thenickcox/subscriptions","organizations_url":"https://api.github.com/users/thenickcox/orgs","repos_url":"https://api.github.com/users/thenickcox/repos","events_url":"https://api.github.com/users/thenickcox/events{/privacy}","received_events_url":"https://api.github.com/users/thenickcox/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-25T19:58:18Z","updated_at":"2015-11-25T20:51:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/pulls/492","html_url":"https://github.com/WikiEducationFoundation/WikiEduDashboard/pull/492","diff_url":"https://github.com/WikiEducationFoundation/WikiEduDashboard/pull/492.diff","patch_url":"https://github.com/WikiEducationFoundation/WikiEduDashboard/pull/492.patch"},"body":"[Tests are passing](https://travis-ci.org/WikiEducationFoundation/WikiEduDashboard/builds/93222377) :tada: :tada: :tada: \r\n\r\nLots of commits here. And lots of changes. Perhaps this is just a good way to acquaint you with what doesn't work in React & Router anymore. Couple big ones:\r\n\r\n* `<RouteHandler />` (meaning rendering a component into another) [has become](https://github.com/WikiEducationFoundation/WikiEduDashboard/compare/master...upgrade_react_and_router?expand=1#diff-db06c3242d889159716403a51173145aL26) `{@props.children}`\r\n* No more named routes, unfortunately, e.g., `<Link to=\"timeline\" props={{ foo: bar }}`. It has to be an actual route `<Link to={\"/courses/#{course.id}/timeline\" />`\r\n* `transitionTo` [has become](https://github.com/WikiEducationFoundation/WikiEduDashboard/compare/master...upgrade_react_and_router?expand=1#diff-967f9bc48a90e925d8d696031abb8d23L61) `history`.\r\n* In Mocha tests, rendered DOM components [have to be composite components](https://github.com/WikiEducationFoundation/WikiEduDashboard/compare/master...upgrade_react_and_router?expand=1#diff-755c790f76288e5de404b8a70f6e1534R8) for some stupid reason (i.e., a component nested inside another component)\r\n\r\nRead over this and definitely ask about anything that's not clear.\r\n\r\n## Edit\r\n\r\nApparently those links to line numbers don't work. "},"comment":{"url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/issues/comments/159728729","html_url":"https://github.com/WikiEducationFoundation/WikiEduDashboard/pull/492#issuecomment-159728729","issue_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/issues/492","id":159728729,"user":{"login":"ragesoss","id":848483,"avatar_url":"https://avatars.githubusercontent.com/u/848483?v=3","gravatar_id":"","url":"https://api.github.com/users/ragesoss","html_url":"https://github.com/ragesoss","followers_url":"https://api.github.com/users/ragesoss/followers","following_url":"https://api.github.com/users/ragesoss/following{/other_user}","gists_url":"https://api.github.com/users/ragesoss/gists{/gist_id}","starred_url":"https://api.github.com/users/ragesoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragesoss/subscriptions","organizations_url":"https://api.github.com/users/ragesoss/orgs","repos_url":"https://api.github.com/users/ragesoss/repos","events_url":"https://api.github.com/users/ragesoss/events{/privacy}","received_events_url":"https://api.github.com/users/ragesoss/received_events","type":"User","site_admin":false},"created_at":"2015-11-25T20:51:08Z","updated_at":"2015-11-25T20:51:08Z","body":"@thenickcox I think you're misremembering. Those components are both working in production:\r\n\r\nhttps://dashboard.wikiedu.org/recent-activity/recent-edits\r\nhttps://dashboard.wikiedu.org/recent-activity/plagiarism\r\n\r\n(And, we're seeing actual hits from the plagiarism feed for the first time!)"}}