{"action":"created","comment":{"url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/pulls/comments/36069964","id":36069964,"diff_hunk":"@@ -77,11 +78,14 @@ def create_port_postcommit(self, context):\n \n     def update_port_precommit(self, context):\n         \"\"\"update_port_precommit.\"\"\"\n-        if not self._is_port_of_interest(context):\n+        vnic_type = self._get_vnic_type(context)\n+        if vnic_type != portbindings.VNIC_BAREMETAL:\n             return\n-        port_dict = self._construct_port(context, False)\n-        LOG.debug(\"update_port_precommit  port dict %s(port_dict)\",\n-                  {'port_dict': port_dict})\n+        profile = self._get_binding_profile(context)\n+        port_dict = self._construct_port(context)\n+        bind_requested = profile.get('bind_requested')","path":"baremetal_network_provisioning/ml2/mechanism_hp.py","position":22,"original_position":21,"commit_id":"6f7f536d65210102e2b74dcfe4d504a57706faf4","original_commit_id":"1280e81146cb3ca980f3ad8afd2c8126f1c8d545","user":{"login":"selvakumars2","id":13130814,"avatar_url":"https://avatars.githubusercontent.com/u/13130814?v=3","gravatar_id":"","url":"https://api.github.com/users/selvakumars2","html_url":"https://github.com/selvakumars2","followers_url":"https://api.github.com/users/selvakumars2/followers","following_url":"https://api.github.com/users/selvakumars2/following{/other_user}","gists_url":"https://api.github.com/users/selvakumars2/gists{/gist_id}","starred_url":"https://api.github.com/users/selvakumars2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selvakumars2/subscriptions","organizations_url":"https://api.github.com/users/selvakumars2/orgs","repos_url":"https://api.github.com/users/selvakumars2/repos","events_url":"https://api.github.com/users/selvakumars2/events{/privacy}","received_events_url":"https://api.github.com/users/selvakumars2/received_events","type":"User","site_admin":false},"body":"1. Addressed the if binding_profile\r\n2. 2nd comment I will test and again post ","created_at":"2015-08-03T09:41:46Z","updated_at":"2015-08-03T09:41:46Z","html_url":"https://github.com/hp-networking/baremetal-network-provisioning/pull/15#discussion_r36069964","pull_request_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/pulls/comments/36069964"},"html":{"href":"https://github.com/hp-networking/baremetal-network-provisioning/pull/15#discussion_r36069964"},"pull_request":{"href":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/pulls/15","id":41100389,"html_url":"https://github.com/hp-networking/baremetal-network-provisioning/pull/15","diff_url":"https://github.com/hp-networking/baremetal-network-provisioning/pull/15.diff","patch_url":"https://github.com/hp-networking/baremetal-network-provisioning/pull/15.patch","issue_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/issues/15","number":15,"state":"open","locked":false,"title":"update & delete port support in mechanism driver","user":{"login":"selvakumars2","id":13130814,"avatar_url":"https://avatars.githubusercontent.com/u/13130814?v=3","gravatar_id":"","url":"https://api.github.com/users/selvakumars2","html_url":"https://github.com/selvakumars2","followers_url":"https://api.github.com/users/selvakumars2/followers","following_url":"https://api.github.com/users/selvakumars2/following{/other_user}","gists_url":"https://api.github.com/users/selvakumars2/gists{/gist_id}","starred_url":"https://api.github.com/users/selvakumars2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selvakumars2/subscriptions","organizations_url":"https://api.github.com/users/selvakumars2/orgs","repos_url":"https://api.github.com/users/selvakumars2/repos","events_url":"https://api.github.com/users/selvakumars2/events{/privacy}","received_events_url":"https://api.github.com/users/selvakumars2/received_events","type":"User","site_admin":false},"body":"This change supports\r\n1. update port support\r\n2. delete port support with REST request\r\n3. bind port modified to accomodate SDN controller URI\r\n4. Enhanced test cases for the above support","created_at":"2015-07-29T08:56:16Z","updated_at":"2015-08-03T09:41:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97869bf0a337ed9601ccf9194ef459d23d37346c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/pulls/15/commits","review_comments_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/pulls/15/comments","review_comment_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/issues/15/comments","statuses_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/statuses/6f7f536d65210102e2b74dcfe4d504a57706faf4","head":{"label":"selvakumars2:master","ref":"master","sha":"6f7f536d65210102e2b74dcfe4d504a57706faf4","user":{"login":"selvakumars2","id":13130814,"avatar_url":"https://avatars.githubusercontent.com/u/13130814?v=3","gravatar_id":"","url":"https://api.github.com/users/selvakumars2","html_url":"https://github.com/selvakumars2","followers_url":"https://api.github.com/users/selvakumars2/followers","following_url":"https://api.github.com/users/selvakumars2/following{/other_user}","gists_url":"https://api.github.com/users/selvakumars2/gists{/gist_id}","starred_url":"https://api.github.com/users/selvakumars2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selvakumars2/subscriptions","organizations_url":"https://api.github.com/users/selvakumars2/orgs","repos_url":"https://api.github.com/users/selvakumars2/repos","events_url":"https://api.github.com/users/selvakumars2/events{/privacy}","received_events_url":"https://api.github.com/users/selvakumars2/received_events","type":"User","site_admin":false},"repo":{"id":38355350,"name":"baremetal-network-provisioning","full_name":"selvakumars2/baremetal-network-provisioning","owner":{"login":"selvakumars2","id":13130814,"avatar_url":"https://avatars.githubusercontent.com/u/13130814?v=3","gravatar_id":"","url":"https://api.github.com/users/selvakumars2","html_url":"https://github.com/selvakumars2","followers_url":"https://api.github.com/users/selvakumars2/followers","following_url":"https://api.github.com/users/selvakumars2/following{/other_user}","gists_url":"https://api.github.com/users/selvakumars2/gists{/gist_id}","starred_url":"https://api.github.com/users/selvakumars2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selvakumars2/subscriptions","organizations_url":"https://api.github.com/users/selvakumars2/orgs","repos_url":"https://api.github.com/users/selvakumars2/repos","events_url":"https://api.github.com/users/selvakumars2/events{/privacy}","received_events_url":"https://api.github.com/users/selvakumars2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/selvakumars2/baremetal-network-provisioning","description":"This repository contains Openstack Neutron based ML2 drivers that will enable provisioning networks for Openstack Ironic managed baremetal servers.","fork":true,"url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning","forks_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/forks","keys_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/teams","hooks_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/hooks","issue_events_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/issues/events{/number}","events_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/events","assignees_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/assignees{/user}","branches_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/branches{/branch}","tags_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/tags","blobs_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/git/refs{/sha}","trees_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/statuses/{sha}","languages_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/languages","stargazers_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/stargazers","contributors_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/contributors","subscribers_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/subscribers","subscription_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/subscription","commits_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/commits{/sha}","git_commits_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/git/commits{/sha}","comments_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/comments{/number}","issue_comment_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/issues/comments{/number}","contents_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/contents/{+path}","compare_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/merges","archive_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/downloads","issues_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/issues{/number}","pulls_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/pulls{/number}","milestones_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/milestones{/number}","notifications_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/labels{/name}","releases_url":"https://api.github.com/repos/selvakumars2/baremetal-network-provisioning/releases{/id}","created_at":"2015-07-01T07:02:22Z","updated_at":"2015-07-15T08:31:11Z","pushed_at":"2015-08-03T09:39:57Z","git_url":"git://github.com/selvakumars2/baremetal-network-provisioning.git","ssh_url":"git@github.com:selvakumars2/baremetal-network-provisioning.git","clone_url":"https://github.com/selvakumars2/baremetal-network-provisioning.git","svn_url":"https://github.com/selvakumars2/baremetal-network-provisioning","homepage":null,"size":195,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hp-networking:master","ref":"master","sha":"e525e4eedb60af0d75962c106b886d8b97b3b728","user":{"login":"hp-networking","id":10058468,"avatar_url":"https://avatars.githubusercontent.com/u/10058468?v=3","gravatar_id":"","url":"https://api.github.com/users/hp-networking","html_url":"https://github.com/hp-networking","followers_url":"https://api.github.com/users/hp-networking/followers","following_url":"https://api.github.com/users/hp-networking/following{/other_user}","gists_url":"https://api.github.com/users/hp-networking/gists{/gist_id}","starred_url":"https://api.github.com/users/hp-networking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hp-networking/subscriptions","organizations_url":"https://api.github.com/users/hp-networking/orgs","repos_url":"https://api.github.com/users/hp-networking/repos","events_url":"https://api.github.com/users/hp-networking/events{/privacy}","received_events_url":"https://api.github.com/users/hp-networking/received_events","type":"User","site_admin":false},"repo":{"id":38354313,"name":"baremetal-network-provisioning","full_name":"hp-networking/baremetal-network-provisioning","owner":{"login":"hp-networking","id":10058468,"avatar_url":"https://avatars.githubusercontent.com/u/10058468?v=3","gravatar_id":"","url":"https://api.github.com/users/hp-networking","html_url":"https://github.com/hp-networking","followers_url":"https://api.github.com/users/hp-networking/followers","following_url":"https://api.github.com/users/hp-networking/following{/other_user}","gists_url":"https://api.github.com/users/hp-networking/gists{/gist_id}","starred_url":"https://api.github.com/users/hp-networking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hp-networking/subscriptions","organizations_url":"https://api.github.com/users/hp-networking/orgs","repos_url":"https://api.github.com/users/hp-networking/repos","events_url":"https://api.github.com/users/hp-networking/events{/privacy}","received_events_url":"https://api.github.com/users/hp-networking/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hp-networking/baremetal-network-provisioning","description":"This repository contains Openstack Neutron based ML2 drivers that will enable provisioning networks for Openstack Ironic managed baremetal servers.","fork":false,"url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning","forks_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/forks","keys_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/teams","hooks_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/hooks","issue_events_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/issues/events{/number}","events_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/events","assignees_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/assignees{/user}","branches_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/branches{/branch}","tags_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/tags","blobs_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/git/refs{/sha}","trees_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/statuses/{sha}","languages_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/languages","stargazers_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/stargazers","contributors_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/contributors","subscribers_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/subscribers","subscription_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/subscription","commits_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/commits{/sha}","git_commits_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/git/commits{/sha}","comments_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/comments{/number}","issue_comment_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/issues/comments{/number}","contents_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/contents/{+path}","compare_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/merges","archive_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/downloads","issues_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/issues{/number}","pulls_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/pulls{/number}","milestones_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/milestones{/number}","notifications_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/labels{/name}","releases_url":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/releases{/id}","created_at":"2015-07-01T06:39:03Z","updated_at":"2015-07-15T06:52:47Z","pushed_at":"2015-08-03T09:39:57Z","git_url":"git://github.com/hp-networking/baremetal-network-provisioning.git","ssh_url":"git@github.com:hp-networking/baremetal-network-provisioning.git","clone_url":"https://github.com/hp-networking/baremetal-network-provisioning.git","svn_url":"https://github.com/hp-networking/baremetal-network-provisioning","homepage":null,"size":329,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/pulls/15"},"html":{"href":"https://github.com/hp-networking/baremetal-network-provisioning/pull/15"},"issue":{"href":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/issues/15"},"comments":{"href":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/hp-networking/baremetal-network-provisioning/statuses/6f7f536d65210102e2b74dcfe4d504a57706faf4"}}}}