{"action":"created","issue":{"url":"https://api.github.com/repos/nodegit/nodegit/issues/776","labels_url":"https://api.github.com/repos/nodegit/nodegit/issues/776/labels{/name}","comments_url":"https://api.github.com/repos/nodegit/nodegit/issues/776/comments","events_url":"https://api.github.com/repos/nodegit/nodegit/issues/776/events","html_url":"https://github.com/nodegit/nodegit/pull/776","id":115559733,"number":776,"title":"Ignore undefined options in normalizeOptions.","user":{"login":"kenprice","id":8813522,"avatar_url":"https://avatars.githubusercontent.com/u/8813522?v=3","gravatar_id":"","url":"https://api.github.com/users/kenprice","html_url":"https://github.com/kenprice","followers_url":"https://api.github.com/users/kenprice/followers","following_url":"https://api.github.com/users/kenprice/following{/other_user}","gists_url":"https://api.github.com/users/kenprice/gists{/gist_id}","starred_url":"https://api.github.com/users/kenprice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenprice/subscriptions","organizations_url":"https://api.github.com/users/kenprice/orgs","repos_url":"https://api.github.com/users/kenprice/repos","events_url":"https://api.github.com/users/kenprice/events{/privacy}","received_events_url":"https://api.github.com/users/kenprice/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-06T18:20:24Z","updated_at":"2015-11-06T18:35:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodegit/nodegit/pulls/776","html_url":"https://github.com/nodegit/nodegit/pull/776","diff_url":"https://github.com/nodegit/nodegit/pull/776.diff","patch_url":"https://github.com/nodegit/nodegit/pull/776.patch"},"body":"It's possible to have some options (DiffOptions, for example) where `options[key]` is undefined. There's no reason why undefined options should be passed to any of nodegit's class methods. Let's check for them in `normalizeOptions`, and prevent these undefined options from being copied.\r\n\r\nI didn't check for `null`, since for some options, `null` is ok."},"comment":{"url":"https://api.github.com/repos/nodegit/nodegit/issues/comments/154495125","html_url":"https://github.com/nodegit/nodegit/pull/776#issuecomment-154495125","issue_url":"https://api.github.com/repos/nodegit/nodegit/issues/776","id":154495125,"user":{"login":"tbranyen","id":181635,"avatar_url":"https://avatars.githubusercontent.com/u/181635?v=3","gravatar_id":"","url":"https://api.github.com/users/tbranyen","html_url":"https://github.com/tbranyen","followers_url":"https://api.github.com/users/tbranyen/followers","following_url":"https://api.github.com/users/tbranyen/following{/other_user}","gists_url":"https://api.github.com/users/tbranyen/gists{/gist_id}","starred_url":"https://api.github.com/users/tbranyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbranyen/subscriptions","organizations_url":"https://api.github.com/users/tbranyen/orgs","repos_url":"https://api.github.com/users/tbranyen/repos","events_url":"https://api.github.com/users/tbranyen/events{/privacy}","received_events_url":"https://api.github.com/users/tbranyen/received_events","type":"User","site_admin":false},"created_at":"2015-11-06T18:35:49Z","updated_at":"2015-11-06T18:35:49Z","body":"Does this fix a problem? There are few cases where undefined values should matter."}}