{"action":"opened","number":153,"pull_request":{"url":"https://api.github.com/repos/dongri/OAuthSwift/pulls/153","id":52271304,"html_url":"https://github.com/dongri/OAuthSwift/pull/153","diff_url":"https://github.com/dongri/OAuthSwift/pull/153.diff","patch_url":"https://github.com/dongri/OAuthSwift/pull/153.patch","issue_url":"https://api.github.com/repos/dongri/OAuthSwift/issues/153","number":153,"state":"open","locked":false,"title":"SafariURLHandler: missing \"public\" access for externally configurable variables","user":{"login":"itchingpixels","id":5416288,"avatar_url":"https://avatars.githubusercontent.com/u/5416288?v=3","gravatar_id":"","url":"https://api.github.com/users/itchingpixels","html_url":"https://github.com/itchingpixels","followers_url":"https://api.github.com/users/itchingpixels/followers","following_url":"https://api.github.com/users/itchingpixels/following{/other_user}","gists_url":"https://api.github.com/users/itchingpixels/gists{/gist_id}","starred_url":"https://api.github.com/users/itchingpixels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itchingpixels/subscriptions","organizations_url":"https://api.github.com/users/itchingpixels/orgs","repos_url":"https://api.github.com/users/itchingpixels/repos","events_url":"https://api.github.com/users/itchingpixels/events{/privacy}","received_events_url":"https://api.github.com/users/itchingpixels/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nThanks for the great work of making this happen - it helped us not to reinvent the wheel big time!\r\n\r\nI came across the issue where the following variables on SafariURLHandler weren't accessible from outside of the framework (missing public annotiation):\r\n\r\n        var animated: Bool = true\r\n        var delegate: SFSafariViewControllerDelegate?\r\n        var presentCompletion: (() -> Void)?\r\n        var dismissCompletion: (() -> Void)?\r\n\r\nSince I needed to customise the behaviour of this class I needed to set these - and at the same time I thought these were probably intended to be externally configurable originally. (otherwise these are not used inside the framework, so there's no point of their existence:)\r\n\r\nCheers,\r\n\r\nMark","created_at":"2015-12-01T15:24:45Z","updated_at":"2015-12-01T15:24:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0abaf5cc4427fba02cc5581a03e8a6a9403f2aa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dongri/OAuthSwift/pulls/153/commits","review_comments_url":"https://api.github.com/repos/dongri/OAuthSwift/pulls/153/comments","review_comment_url":"https://api.github.com/repos/dongri/OAuthSwift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dongri/OAuthSwift/issues/153/comments","statuses_url":"https://api.github.com/repos/dongri/OAuthSwift/statuses/b8faedcb8044b821f6231e28bc7c1e9b88be66fd","head":{"label":"itchingpixels:safariurlhandler-delegate-public-access","ref":"safariurlhandler-delegate-public-access","sha":"b8faedcb8044b821f6231e28bc7c1e9b88be66fd","user":{"login":"itchingpixels","id":5416288,"avatar_url":"https://avatars.githubusercontent.com/u/5416288?v=3","gravatar_id":"","url":"https://api.github.com/users/itchingpixels","html_url":"https://github.com/itchingpixels","followers_url":"https://api.github.com/users/itchingpixels/followers","following_url":"https://api.github.com/users/itchingpixels/following{/other_user}","gists_url":"https://api.github.com/users/itchingpixels/gists{/gist_id}","starred_url":"https://api.github.com/users/itchingpixels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itchingpixels/subscriptions","organizations_url":"https://api.github.com/users/itchingpixels/orgs","repos_url":"https://api.github.com/users/itchingpixels/repos","events_url":"https://api.github.com/users/itchingpixels/events{/privacy}","received_events_url":"https://api.github.com/users/itchingpixels/received_events","type":"User","site_admin":false},"repo":{"id":47197208,"name":"OAuthSwift","full_name":"itchingpixels/OAuthSwift","owner":{"login":"itchingpixels","id":5416288,"avatar_url":"https://avatars.githubusercontent.com/u/5416288?v=3","gravatar_id":"","url":"https://api.github.com/users/itchingpixels","html_url":"https://github.com/itchingpixels","followers_url":"https://api.github.com/users/itchingpixels/followers","following_url":"https://api.github.com/users/itchingpixels/following{/other_user}","gists_url":"https://api.github.com/users/itchingpixels/gists{/gist_id}","starred_url":"https://api.github.com/users/itchingpixels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itchingpixels/subscriptions","organizations_url":"https://api.github.com/users/itchingpixels/orgs","repos_url":"https://api.github.com/users/itchingpixels/repos","events_url":"https://api.github.com/users/itchingpixels/events{/privacy}","received_events_url":"https://api.github.com/users/itchingpixels/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/itchingpixels/OAuthSwift","description":"Swift based OAuth library for iOS","fork":true,"url":"https://api.github.com/repos/itchingpixels/OAuthSwift","forks_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/forks","keys_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/teams","hooks_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/hooks","issue_events_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/issues/events{/number}","events_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/events","assignees_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/assignees{/user}","branches_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/branches{/branch}","tags_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/tags","blobs_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/git/refs{/sha}","trees_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/statuses/{sha}","languages_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/languages","stargazers_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/stargazers","contributors_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/contributors","subscribers_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/subscribers","subscription_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/subscription","commits_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/commits{/sha}","git_commits_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/git/commits{/sha}","comments_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/comments{/number}","issue_comment_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/issues/comments{/number}","contents_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/contents/{+path}","compare_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/merges","archive_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/downloads","issues_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/issues{/number}","pulls_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/pulls{/number}","milestones_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/milestones{/number}","notifications_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/labels{/name}","releases_url":"https://api.github.com/repos/itchingpixels/OAuthSwift/releases{/id}","created_at":"2015-12-01T15:09:59Z","updated_at":"2015-12-01T15:10:00Z","pushed_at":"2015-12-01T15:18:41Z","git_url":"git://github.com/itchingpixels/OAuthSwift.git","ssh_url":"git@github.com:itchingpixels/OAuthSwift.git","clone_url":"https://github.com/itchingpixels/OAuthSwift.git","svn_url":"https://github.com/itchingpixels/OAuthSwift","homepage":"","size":2634,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dongri:master","ref":"master","sha":"e6af90e0edd5c5f070ea4ae6761a4871fb95c6aa","user":{"login":"dongri","id":878993,"avatar_url":"https://avatars.githubusercontent.com/u/878993?v=3","gravatar_id":"","url":"https://api.github.com/users/dongri","html_url":"https://github.com/dongri","followers_url":"https://api.github.com/users/dongri/followers","following_url":"https://api.github.com/users/dongri/following{/other_user}","gists_url":"https://api.github.com/users/dongri/gists{/gist_id}","starred_url":"https://api.github.com/users/dongri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongri/subscriptions","organizations_url":"https://api.github.com/users/dongri/orgs","repos_url":"https://api.github.com/users/dongri/repos","events_url":"https://api.github.com/users/dongri/events{/privacy}","received_events_url":"https://api.github.com/users/dongri/received_events","type":"User","site_admin":false},"repo":{"id":21315049,"name":"OAuthSwift","full_name":"dongri/OAuthSwift","owner":{"login":"dongri","id":878993,"avatar_url":"https://avatars.githubusercontent.com/u/878993?v=3","gravatar_id":"","url":"https://api.github.com/users/dongri","html_url":"https://github.com/dongri","followers_url":"https://api.github.com/users/dongri/followers","following_url":"https://api.github.com/users/dongri/following{/other_user}","gists_url":"https://api.github.com/users/dongri/gists{/gist_id}","starred_url":"https://api.github.com/users/dongri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongri/subscriptions","organizations_url":"https://api.github.com/users/dongri/orgs","repos_url":"https://api.github.com/users/dongri/repos","events_url":"https://api.github.com/users/dongri/events{/privacy}","received_events_url":"https://api.github.com/users/dongri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dongri/OAuthSwift","description":"Swift based OAuth library for iOS","fork":false,"url":"https://api.github.com/repos/dongri/OAuthSwift","forks_url":"https://api.github.com/repos/dongri/OAuthSwift/forks","keys_url":"https://api.github.com/repos/dongri/OAuthSwift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dongri/OAuthSwift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dongri/OAuthSwift/teams","hooks_url":"https://api.github.com/repos/dongri/OAuthSwift/hooks","issue_events_url":"https://api.github.com/repos/dongri/OAuthSwift/issues/events{/number}","events_url":"https://api.github.com/repos/dongri/OAuthSwift/events","assignees_url":"https://api.github.com/repos/dongri/OAuthSwift/assignees{/user}","branches_url":"https://api.github.com/repos/dongri/OAuthSwift/branches{/branch}","tags_url":"https://api.github.com/repos/dongri/OAuthSwift/tags","blobs_url":"https://api.github.com/repos/dongri/OAuthSwift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dongri/OAuthSwift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dongri/OAuthSwift/git/refs{/sha}","trees_url":"https://api.github.com/repos/dongri/OAuthSwift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dongri/OAuthSwift/statuses/{sha}","languages_url":"https://api.github.com/repos/dongri/OAuthSwift/languages","stargazers_url":"https://api.github.com/repos/dongri/OAuthSwift/stargazers","contributors_url":"https://api.github.com/repos/dongri/OAuthSwift/contributors","subscribers_url":"https://api.github.com/repos/dongri/OAuthSwift/subscribers","subscription_url":"https://api.github.com/repos/dongri/OAuthSwift/subscription","commits_url":"https://api.github.com/repos/dongri/OAuthSwift/commits{/sha}","git_commits_url":"https://api.github.com/repos/dongri/OAuthSwift/git/commits{/sha}","comments_url":"https://api.github.com/repos/dongri/OAuthSwift/comments{/number}","issue_comment_url":"https://api.github.com/repos/dongri/OAuthSwift/issues/comments{/number}","contents_url":"https://api.github.com/repos/dongri/OAuthSwift/contents/{+path}","compare_url":"https://api.github.com/repos/dongri/OAuthSwift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dongri/OAuthSwift/merges","archive_url":"https://api.github.com/repos/dongri/OAuthSwift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dongri/OAuthSwift/downloads","issues_url":"https://api.github.com/repos/dongri/OAuthSwift/issues{/number}","pulls_url":"https://api.github.com/repos/dongri/OAuthSwift/pulls{/number}","milestones_url":"https://api.github.com/repos/dongri/OAuthSwift/milestones{/number}","notifications_url":"https://api.github.com/repos/dongri/OAuthSwift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dongri/OAuthSwift/labels{/name}","releases_url":"https://api.github.com/repos/dongri/OAuthSwift/releases{/id}","created_at":"2014-06-29T02:27:16Z","updated_at":"2015-12-01T12:47:50Z","pushed_at":"2015-12-01T15:24:46Z","git_url":"git://github.com/dongri/OAuthSwift.git","ssh_url":"git@github.com:dongri/OAuthSwift.git","clone_url":"https://github.com/dongri/OAuthSwift.git","svn_url":"https://github.com/dongri/OAuthSwift","homepage":"","size":2788,"stargazers_count":758,"watchers_count":758,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":142,"mirror_url":null,"open_issues_count":6,"forks":142,"open_issues":6,"watchers":758,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dongri/OAuthSwift/pulls/153"},"html":{"href":"https://github.com/dongri/OAuthSwift/pull/153"},"issue":{"href":"https://api.github.com/repos/dongri/OAuthSwift/issues/153"},"comments":{"href":"https://api.github.com/repos/dongri/OAuthSwift/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/dongri/OAuthSwift/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/dongri/OAuthSwift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dongri/OAuthSwift/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/dongri/OAuthSwift/statuses/b8faedcb8044b821f6231e28bc7c1e9b88be66fd"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":4,"changed_files":1}}