{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/autorest/pulls/comments/32330255","id":32330255,"diff_hunk":"@@ -8,34 +8,48 @@ var Constants = require('./constants');\n var ProxyFilter = require('./filters/proxyfilter');\n var RedirectFilter = require('./filters/redirectfilter');\n var SigningFilter = require('./filters/signingfilter');\n+var ExponentialRetryPolicyFilter = require('./filters/exponentialretrypolicyfilter');\n var requestPipeline = require('./requestPipeline');\n var utils = require('./utils');\n \n /**\n-   * @class\n-   * Initializes a new instance of the ServiceClient class.\n-   * @constructor\n-   * \n-   * @param {object} credentials - BasicAuthenticationCredentials or \n-   * TokenCredentials object used for authentication.  \n-   * \n-   * @param {Array} filters\n-   */\n-function ServiceClient(credentials, filters) {\n-  if (!filters) {\n-    filters = [];\n+ * @class\n+ * Initializes a new instance of the ServiceClient class.\n+ * @constructor\n+ * @param {object} options The parameter options\n+ * \n+ * @param {object} [options.credentials]    - BasicAuthenticationCredentials or \n+ * TokenCredentials object used for authentication.  ","path":"ClientRuntimes/NodeJS/lib/serviceClient.js","position":27,"original_position":27,"commit_id":"3e7c7b11423d7829c47958acb97c0b7d7f4a8287","original_commit_id":"3e7c7b11423d7829c47958acb97c0b7d7f4a8287","user":{"login":"yugangw-msft","id":6014209,"avatar_url":"https://avatars.githubusercontent.com/u/6014209?v=3","gravatar_id":"","url":"https://api.github.com/users/yugangw-msft","html_url":"https://github.com/yugangw-msft","followers_url":"https://api.github.com/users/yugangw-msft/followers","following_url":"https://api.github.com/users/yugangw-msft/following{/other_user}","gists_url":"https://api.github.com/users/yugangw-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/yugangw-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yugangw-msft/subscriptions","organizations_url":"https://api.github.com/users/yugangw-msft/orgs","repos_url":"https://api.github.com/users/yugangw-msft/repos","events_url":"https://api.github.com/users/yugangw-msft/events{/privacy}","received_events_url":"https://api.github.com/users/yugangw-msft/received_events","type":"User","site_admin":false},"body":"my suggestion is to drop the specific derived type names. Because in near future if we support new type, or for any reason to rename, likely. This comment will become invalid without notice. Updating common is always not cheap, as we need refresh all dependents downstream.","created_at":"2015-06-12T16:18:13Z","updated_at":"2015-06-12T16:18:13Z","html_url":"https://github.com/Azure/autorest/pull/102#discussion_r32330255","pull_request_url":"https://api.github.com/repos/Azure/autorest/pulls/102","_links":{"self":{"href":"https://api.github.com/repos/Azure/autorest/pulls/comments/32330255"},"html":{"href":"https://github.com/Azure/autorest/pull/102#discussion_r32330255"},"pull_request":{"href":"https://api.github.com/repos/Azure/autorest/pulls/102"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/autorest/pulls/102","id":37530371,"html_url":"https://github.com/Azure/autorest/pull/102","diff_url":"https://github.com/Azure/autorest/pull/102.diff","patch_url":"https://github.com/Azure/autorest/pull/102.patch","issue_url":"https://api.github.com/repos/Azure/autorest/issues/102","number":102,"state":"open","locked":false,"title":"added retry policy and modifief redirect filter, optimized the serviceClient constructor","user":{"login":"amarzavery","id":4521223,"avatar_url":"https://avatars.githubusercontent.com/u/4521223?v=3","gravatar_id":"","url":"https://api.github.com/users/amarzavery","html_url":"https://github.com/amarzavery","followers_url":"https://api.github.com/users/amarzavery/followers","following_url":"https://api.github.com/users/amarzavery/following{/other_user}","gists_url":"https://api.github.com/users/amarzavery/gists{/gist_id}","starred_url":"https://api.github.com/users/amarzavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amarzavery/subscriptions","organizations_url":"https://api.github.com/users/amarzavery/orgs","repos_url":"https://api.github.com/users/amarzavery/repos","events_url":"https://api.github.com/users/amarzavery/events{/privacy}","received_events_url":"https://api.github.com/users/amarzavery/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-12T04:05:04Z","updated_at":"2015-06-12T16:18:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7858164a063f5c0f1b602f53bad4e3b3a15f37ad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Azure/autorest/pulls/102/commits","review_comments_url":"https://api.github.com/repos/Azure/autorest/pulls/102/comments","review_comment_url":"https://api.github.com/repos/Azure/autorest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/autorest/issues/102/comments","statuses_url":"https://api.github.com/repos/Azure/autorest/statuses/3e7c7b11423d7829c47958acb97c0b7d7f4a8287","head":{"label":"amarzavery:node2","ref":"node2","sha":"3e7c7b11423d7829c47958acb97c0b7d7f4a8287","user":{"login":"amarzavery","id":4521223,"avatar_url":"https://avatars.githubusercontent.com/u/4521223?v=3","gravatar_id":"","url":"https://api.github.com/users/amarzavery","html_url":"https://github.com/amarzavery","followers_url":"https://api.github.com/users/amarzavery/followers","following_url":"https://api.github.com/users/amarzavery/following{/other_user}","gists_url":"https://api.github.com/users/amarzavery/gists{/gist_id}","starred_url":"https://api.github.com/users/amarzavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amarzavery/subscriptions","organizations_url":"https://api.github.com/users/amarzavery/orgs","repos_url":"https://api.github.com/users/amarzavery/repos","events_url":"https://api.github.com/users/amarzavery/events{/privacy}","received_events_url":"https://api.github.com/users/amarzavery/received_events","type":"User","site_admin":false},"repo":{"id":33558663,"name":"AutoRest","full_name":"amarzavery/AutoRest","owner":{"login":"amarzavery","id":4521223,"avatar_url":"https://avatars.githubusercontent.com/u/4521223?v=3","gravatar_id":"","url":"https://api.github.com/users/amarzavery","html_url":"https://github.com/amarzavery","followers_url":"https://api.github.com/users/amarzavery/followers","following_url":"https://api.github.com/users/amarzavery/following{/other_user}","gists_url":"https://api.github.com/users/amarzavery/gists{/gist_id}","starred_url":"https://api.github.com/users/amarzavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amarzavery/subscriptions","organizations_url":"https://api.github.com/users/amarzavery/orgs","repos_url":"https://api.github.com/users/amarzavery/repos","events_url":"https://api.github.com/users/amarzavery/events{/privacy}","received_events_url":"https://api.github.com/users/amarzavery/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amarzavery/AutoRest","description":"AutoRest","fork":true,"url":"https://api.github.com/repos/amarzavery/AutoRest","forks_url":"https://api.github.com/repos/amarzavery/AutoRest/forks","keys_url":"https://api.github.com/repos/amarzavery/AutoRest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amarzavery/AutoRest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amarzavery/AutoRest/teams","hooks_url":"https://api.github.com/repos/amarzavery/AutoRest/hooks","issue_events_url":"https://api.github.com/repos/amarzavery/AutoRest/issues/events{/number}","events_url":"https://api.github.com/repos/amarzavery/AutoRest/events","assignees_url":"https://api.github.com/repos/amarzavery/AutoRest/assignees{/user}","branches_url":"https://api.github.com/repos/amarzavery/AutoRest/branches{/branch}","tags_url":"https://api.github.com/repos/amarzavery/AutoRest/tags","blobs_url":"https://api.github.com/repos/amarzavery/AutoRest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amarzavery/AutoRest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amarzavery/AutoRest/git/refs{/sha}","trees_url":"https://api.github.com/repos/amarzavery/AutoRest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amarzavery/AutoRest/statuses/{sha}","languages_url":"https://api.github.com/repos/amarzavery/AutoRest/languages","stargazers_url":"https://api.github.com/repos/amarzavery/AutoRest/stargazers","contributors_url":"https://api.github.com/repos/amarzavery/AutoRest/contributors","subscribers_url":"https://api.github.com/repos/amarzavery/AutoRest/subscribers","subscription_url":"https://api.github.com/repos/amarzavery/AutoRest/subscription","commits_url":"https://api.github.com/repos/amarzavery/AutoRest/commits{/sha}","git_commits_url":"https://api.github.com/repos/amarzavery/AutoRest/git/commits{/sha}","comments_url":"https://api.github.com/repos/amarzavery/AutoRest/comments{/number}","issue_comment_url":"https://api.github.com/repos/amarzavery/AutoRest/issues/comments{/number}","contents_url":"https://api.github.com/repos/amarzavery/AutoRest/contents/{+path}","compare_url":"https://api.github.com/repos/amarzavery/AutoRest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amarzavery/AutoRest/merges","archive_url":"https://api.github.com/repos/amarzavery/AutoRest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amarzavery/AutoRest/downloads","issues_url":"https://api.github.com/repos/amarzavery/AutoRest/issues{/number}","pulls_url":"https://api.github.com/repos/amarzavery/AutoRest/pulls{/number}","milestones_url":"https://api.github.com/repos/amarzavery/AutoRest/milestones{/number}","notifications_url":"https://api.github.com/repos/amarzavery/AutoRest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amarzavery/AutoRest/labels{/name}","releases_url":"https://api.github.com/repos/amarzavery/AutoRest/releases{/id}","created_at":"2015-04-07T17:44:45Z","updated_at":"2015-04-07T17:44:53Z","pushed_at":"2015-06-12T04:37:56Z","git_url":"git://github.com/amarzavery/AutoRest.git","ssh_url":"git@github.com:amarzavery/AutoRest.git","clone_url":"https://github.com/amarzavery/AutoRest.git","svn_url":"https://github.com/amarzavery/AutoRest","homepage":"","size":1949,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:dev","ref":"dev","sha":"b485256e4e5342dee244eecf3d5002cbe8e5b631","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":31089461,"name":"autorest","full_name":"Azure/autorest","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/autorest","description":"","fork":false,"url":"https://api.github.com/repos/Azure/autorest","forks_url":"https://api.github.com/repos/Azure/autorest/forks","keys_url":"https://api.github.com/repos/Azure/autorest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/autorest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/autorest/teams","hooks_url":"https://api.github.com/repos/Azure/autorest/hooks","issue_events_url":"https://api.github.com/repos/Azure/autorest/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/autorest/events","assignees_url":"https://api.github.com/repos/Azure/autorest/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/autorest/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/autorest/tags","blobs_url":"https://api.github.com/repos/Azure/autorest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/autorest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/autorest/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/autorest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/autorest/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/autorest/languages","stargazers_url":"https://api.github.com/repos/Azure/autorest/stargazers","contributors_url":"https://api.github.com/repos/Azure/autorest/contributors","subscribers_url":"https://api.github.com/repos/Azure/autorest/subscribers","subscription_url":"https://api.github.com/repos/Azure/autorest/subscription","commits_url":"https://api.github.com/repos/Azure/autorest/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/autorest/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/autorest/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/autorest/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/autorest/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/autorest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/autorest/merges","archive_url":"https://api.github.com/repos/Azure/autorest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/autorest/downloads","issues_url":"https://api.github.com/repos/Azure/autorest/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/autorest/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/autorest/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/autorest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/autorest/labels{/name}","releases_url":"https://api.github.com/repos/Azure/autorest/releases{/id}","created_at":"2015-02-20T23:02:54Z","updated_at":"2015-06-05T18:10:48Z","pushed_at":"2015-06-12T04:37:58Z","git_url":"git://github.com/Azure/autorest.git","ssh_url":"git@github.com:Azure/autorest.git","clone_url":"https://github.com/Azure/autorest.git","svn_url":"https://github.com/Azure/autorest","homepage":null,"size":2672,"stargazers_count":82,"watchers_count":82,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":11,"forks":18,"open_issues":11,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/autorest/pulls/102"},"html":{"href":"https://github.com/Azure/autorest/pull/102"},"issue":{"href":"https://api.github.com/repos/Azure/autorest/issues/102"},"comments":{"href":"https://api.github.com/repos/Azure/autorest/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/autorest/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/autorest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/autorest/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/autorest/statuses/3e7c7b11423d7829c47958acb97c0b7d7f4a8287"}}}}