{"action":"opened","number":613,"pull_request":{"url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/613","id":49416952,"html_url":"https://github.com/KeepSafe/aiohttp/pull/613","diff_url":"https://github.com/KeepSafe/aiohttp/pull/613.diff","patch_url":"https://github.com/KeepSafe/aiohttp/pull/613.patch","issue_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/613","number":613,"state":"open","locked":false,"title":"Avoid sending cookie attributes in Cookie header","user":{"login":"neumond","id":3260024,"avatar_url":"https://avatars.githubusercontent.com/u/3260024?v=3","gravatar_id":"","url":"https://api.github.com/users/neumond","html_url":"https://github.com/neumond","followers_url":"https://api.github.com/users/neumond/followers","following_url":"https://api.github.com/users/neumond/following{/other_user}","gists_url":"https://api.github.com/users/neumond/gists{/gist_id}","starred_url":"https://api.github.com/users/neumond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neumond/subscriptions","organizations_url":"https://api.github.com/users/neumond/orgs","repos_url":"https://api.github.com/users/neumond/repos","events_url":"https://api.github.com/users/neumond/events{/privacy}","received_events_url":"https://api.github.com/users/neumond/received_events","type":"User","site_admin":false},"body":"Current implementation sends attributes of every cookie key-value pair in Cookie HTTP header:\r\n\r\nkey=value;\r\nhttponly;\r\nPath=/;\r\nsecure;\r\nkey=value;\r\nhttponly;\r\nPath=/;\r\nsecure;\r\nkey=value;\r\nhttponly;\r\nPath=/;\r\nexpires=Sun, 31-Jan-2016 11:00:00 GMT;\r\nDomain=.example.net.;\r\n\r\nThis behaviour is wrong, you can inspect specs to see that attributes must exist only in incoming Set-Cookie header and affect only cookie storage logic in decisions whether to send particular pair or not.\r\n\r\nhttps://tools.ietf.org/html/rfc6265#section-3.1","created_at":"2015-11-02T10:44:17Z","updated_at":"2015-11-02T10:44:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/613/commits","review_comments_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/613/comments","review_comment_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/613/comments","statuses_url":"https://api.github.com/repos/KeepSafe/aiohttp/statuses/71f0acce57388623191bf4ad0d6094f6e1edf02c","head":{"label":"neumond:master","ref":"master","sha":"71f0acce57388623191bf4ad0d6094f6e1edf02c","user":{"login":"neumond","id":3260024,"avatar_url":"https://avatars.githubusercontent.com/u/3260024?v=3","gravatar_id":"","url":"https://api.github.com/users/neumond","html_url":"https://github.com/neumond","followers_url":"https://api.github.com/users/neumond/followers","following_url":"https://api.github.com/users/neumond/following{/other_user}","gists_url":"https://api.github.com/users/neumond/gists{/gist_id}","starred_url":"https://api.github.com/users/neumond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neumond/subscriptions","organizations_url":"https://api.github.com/users/neumond/orgs","repos_url":"https://api.github.com/users/neumond/repos","events_url":"https://api.github.com/users/neumond/events{/privacy}","received_events_url":"https://api.github.com/users/neumond/received_events","type":"User","site_admin":false},"repo":{"id":45387478,"name":"aiohttp","full_name":"neumond/aiohttp","owner":{"login":"neumond","id":3260024,"avatar_url":"https://avatars.githubusercontent.com/u/3260024?v=3","gravatar_id":"","url":"https://api.github.com/users/neumond","html_url":"https://github.com/neumond","followers_url":"https://api.github.com/users/neumond/followers","following_url":"https://api.github.com/users/neumond/following{/other_user}","gists_url":"https://api.github.com/users/neumond/gists{/gist_id}","starred_url":"https://api.github.com/users/neumond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neumond/subscriptions","organizations_url":"https://api.github.com/users/neumond/orgs","repos_url":"https://api.github.com/users/neumond/repos","events_url":"https://api.github.com/users/neumond/events{/privacy}","received_events_url":"https://api.github.com/users/neumond/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neumond/aiohttp","description":"http client/server for asyncio (PEP-3156)","fork":true,"url":"https://api.github.com/repos/neumond/aiohttp","forks_url":"https://api.github.com/repos/neumond/aiohttp/forks","keys_url":"https://api.github.com/repos/neumond/aiohttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neumond/aiohttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neumond/aiohttp/teams","hooks_url":"https://api.github.com/repos/neumond/aiohttp/hooks","issue_events_url":"https://api.github.com/repos/neumond/aiohttp/issues/events{/number}","events_url":"https://api.github.com/repos/neumond/aiohttp/events","assignees_url":"https://api.github.com/repos/neumond/aiohttp/assignees{/user}","branches_url":"https://api.github.com/repos/neumond/aiohttp/branches{/branch}","tags_url":"https://api.github.com/repos/neumond/aiohttp/tags","blobs_url":"https://api.github.com/repos/neumond/aiohttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neumond/aiohttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neumond/aiohttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/neumond/aiohttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neumond/aiohttp/statuses/{sha}","languages_url":"https://api.github.com/repos/neumond/aiohttp/languages","stargazers_url":"https://api.github.com/repos/neumond/aiohttp/stargazers","contributors_url":"https://api.github.com/repos/neumond/aiohttp/contributors","subscribers_url":"https://api.github.com/repos/neumond/aiohttp/subscribers","subscription_url":"https://api.github.com/repos/neumond/aiohttp/subscription","commits_url":"https://api.github.com/repos/neumond/aiohttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/neumond/aiohttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/neumond/aiohttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/neumond/aiohttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/neumond/aiohttp/contents/{+path}","compare_url":"https://api.github.com/repos/neumond/aiohttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neumond/aiohttp/merges","archive_url":"https://api.github.com/repos/neumond/aiohttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neumond/aiohttp/downloads","issues_url":"https://api.github.com/repos/neumond/aiohttp/issues{/number}","pulls_url":"https://api.github.com/repos/neumond/aiohttp/pulls{/number}","milestones_url":"https://api.github.com/repos/neumond/aiohttp/milestones{/number}","notifications_url":"https://api.github.com/repos/neumond/aiohttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neumond/aiohttp/labels{/name}","releases_url":"https://api.github.com/repos/neumond/aiohttp/releases{/id}","created_at":"2015-11-02T10:23:25Z","updated_at":"2015-11-02T10:23:26Z","pushed_at":"2015-11-02T10:39:02Z","git_url":"git://github.com/neumond/aiohttp.git","ssh_url":"git@github.com:neumond/aiohttp.git","clone_url":"https://github.com/neumond/aiohttp.git","svn_url":"https://github.com/neumond/aiohttp","homepage":"http://aiohttp.readthedocs.org","size":10629,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KeepSafe:master","ref":"master","sha":"5cf79eda1fdd53cf124e6ce6d4f070483b4effeb","user":{"login":"KeepSafe","id":1377248,"avatar_url":"https://avatars.githubusercontent.com/u/1377248?v=3","gravatar_id":"","url":"https://api.github.com/users/KeepSafe","html_url":"https://github.com/KeepSafe","followers_url":"https://api.github.com/users/KeepSafe/followers","following_url":"https://api.github.com/users/KeepSafe/following{/other_user}","gists_url":"https://api.github.com/users/KeepSafe/gists{/gist_id}","starred_url":"https://api.github.com/users/KeepSafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KeepSafe/subscriptions","organizations_url":"https://api.github.com/users/KeepSafe/orgs","repos_url":"https://api.github.com/users/KeepSafe/repos","events_url":"https://api.github.com/users/KeepSafe/events{/privacy}","received_events_url":"https://api.github.com/users/KeepSafe/received_events","type":"Organization","site_admin":false},"repo":{"id":13258039,"name":"aiohttp","full_name":"KeepSafe/aiohttp","owner":{"login":"KeepSafe","id":1377248,"avatar_url":"https://avatars.githubusercontent.com/u/1377248?v=3","gravatar_id":"","url":"https://api.github.com/users/KeepSafe","html_url":"https://github.com/KeepSafe","followers_url":"https://api.github.com/users/KeepSafe/followers","following_url":"https://api.github.com/users/KeepSafe/following{/other_user}","gists_url":"https://api.github.com/users/KeepSafe/gists{/gist_id}","starred_url":"https://api.github.com/users/KeepSafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KeepSafe/subscriptions","organizations_url":"https://api.github.com/users/KeepSafe/orgs","repos_url":"https://api.github.com/users/KeepSafe/repos","events_url":"https://api.github.com/users/KeepSafe/events{/privacy}","received_events_url":"https://api.github.com/users/KeepSafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KeepSafe/aiohttp","description":"http client/server for asyncio (PEP-3156)","fork":false,"url":"https://api.github.com/repos/KeepSafe/aiohttp","forks_url":"https://api.github.com/repos/KeepSafe/aiohttp/forks","keys_url":"https://api.github.com/repos/KeepSafe/aiohttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KeepSafe/aiohttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KeepSafe/aiohttp/teams","hooks_url":"https://api.github.com/repos/KeepSafe/aiohttp/hooks","issue_events_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/events{/number}","events_url":"https://api.github.com/repos/KeepSafe/aiohttp/events","assignees_url":"https://api.github.com/repos/KeepSafe/aiohttp/assignees{/user}","branches_url":"https://api.github.com/repos/KeepSafe/aiohttp/branches{/branch}","tags_url":"https://api.github.com/repos/KeepSafe/aiohttp/tags","blobs_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KeepSafe/aiohttp/statuses/{sha}","languages_url":"https://api.github.com/repos/KeepSafe/aiohttp/languages","stargazers_url":"https://api.github.com/repos/KeepSafe/aiohttp/stargazers","contributors_url":"https://api.github.com/repos/KeepSafe/aiohttp/contributors","subscribers_url":"https://api.github.com/repos/KeepSafe/aiohttp/subscribers","subscription_url":"https://api.github.com/repos/KeepSafe/aiohttp/subscription","commits_url":"https://api.github.com/repos/KeepSafe/aiohttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/KeepSafe/aiohttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/KeepSafe/aiohttp/contents/{+path}","compare_url":"https://api.github.com/repos/KeepSafe/aiohttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KeepSafe/aiohttp/merges","archive_url":"https://api.github.com/repos/KeepSafe/aiohttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KeepSafe/aiohttp/downloads","issues_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues{/number}","pulls_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls{/number}","milestones_url":"https://api.github.com/repos/KeepSafe/aiohttp/milestones{/number}","notifications_url":"https://api.github.com/repos/KeepSafe/aiohttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KeepSafe/aiohttp/labels{/name}","releases_url":"https://api.github.com/repos/KeepSafe/aiohttp/releases{/id}","created_at":"2013-10-01T23:04:01Z","updated_at":"2015-11-02T08:58:10Z","pushed_at":"2015-11-02T10:44:17Z","git_url":"git://github.com/KeepSafe/aiohttp.git","ssh_url":"git@github.com:KeepSafe/aiohttp.git","clone_url":"https://github.com/KeepSafe/aiohttp.git","svn_url":"https://github.com/KeepSafe/aiohttp","homepage":"http://aiohttp.readthedocs.org","size":10629,"stargazers_count":1188,"watchers_count":1188,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":205,"mirror_url":null,"open_issues_count":57,"forks":205,"open_issues":57,"watchers":1188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/613"},"html":{"href":"https://github.com/KeepSafe/aiohttp/pull/613"},"issue":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/issues/613"},"comments":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/issues/613/comments"},"review_comments":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/613/comments"},"review_comment":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/613/commits"},"statuses":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/statuses/71f0acce57388623191bf4ad0d6094f6e1edf02c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":2,"changed_files":1}}