{"action":"created","issue":{"url":"https://api.github.com/repos/attendease/attendease-js/issues/9","labels_url":"https://api.github.com/repos/attendease/attendease-js/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/attendease/attendease-js/issues/9/comments","events_url":"https://api.github.com/repos/attendease/attendease-js/issues/9/events","html_url":"https://github.com/attendease/attendease-js/pull/9","id":90220987,"number":9,"title":"Add initial test suite scaffold, using karma + jasmine.","user":{"login":"mikeric","id":36068,"avatar_url":"https://avatars.githubusercontent.com/u/36068?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeric","html_url":"https://github.com/mikeric","followers_url":"https://api.github.com/users/mikeric/followers","following_url":"https://api.github.com/users/mikeric/following{/other_user}","gists_url":"https://api.github.com/users/mikeric/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeric/subscriptions","organizations_url":"https://api.github.com/users/mikeric/orgs","repos_url":"https://api.github.com/users/mikeric/repos","events_url":"https://api.github.com/users/mikeric/events{/privacy}","received_events_url":"https://api.github.com/users/mikeric/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/attendease/attendease-js/labels/[Status]%20In%20Progress","name":"[Status] In Progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"mikeric","id":36068,"avatar_url":"https://avatars.githubusercontent.com/u/36068?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeric","html_url":"https://github.com/mikeric","followers_url":"https://api.github.com/users/mikeric/followers","following_url":"https://api.github.com/users/mikeric/following{/other_user}","gists_url":"https://api.github.com/users/mikeric/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeric/subscriptions","organizations_url":"https://api.github.com/users/mikeric/orgs","repos_url":"https://api.github.com/users/mikeric/repos","events_url":"https://api.github.com/users/mikeric/events{/privacy}","received_events_url":"https://api.github.com/users/mikeric/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-06-22T21:46:40Z","updated_at":"2015-06-25T21:25:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/attendease/attendease-js/pulls/9","html_url":"https://github.com/attendease/attendease-js/pull/9","diff_url":"https://github.com/attendease/attendease-js/pull/9.diff","patch_url":"https://github.com/attendease/attendease-js/pull/9.patch"},"body":"## Changes\r\n\r\n- Added karma + jasmine testing setup.\r\n\r\n- Added initial tests for `Client#apiRoot`, `Client#login`, `Client#logout`.\r\n\r\n## Running\r\n\r\nTo run the test suite, first `npm install` if you haven't and then run:\r\n\r\n```\r\nnpm test\r\n```\r\n\r\nConnected to #5"},"comment":{"url":"https://api.github.com/repos/attendease/attendease-js/issues/comments/115403381","html_url":"https://github.com/attendease/attendease-js/pull/9#issuecomment-115403381","issue_url":"https://api.github.com/repos/attendease/attendease-js/issues/9","id":115403381,"user":{"login":"AntoineInsa","id":603985,"avatar_url":"https://avatars.githubusercontent.com/u/603985?v=3","gravatar_id":"","url":"https://api.github.com/users/AntoineInsa","html_url":"https://github.com/AntoineInsa","followers_url":"https://api.github.com/users/AntoineInsa/followers","following_url":"https://api.github.com/users/AntoineInsa/following{/other_user}","gists_url":"https://api.github.com/users/AntoineInsa/gists{/gist_id}","starred_url":"https://api.github.com/users/AntoineInsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntoineInsa/subscriptions","organizations_url":"https://api.github.com/users/AntoineInsa/orgs","repos_url":"https://api.github.com/users/AntoineInsa/repos","events_url":"https://api.github.com/users/AntoineInsa/events{/privacy}","received_events_url":"https://api.github.com/users/AntoineInsa/received_events","type":"User","site_admin":false},"created_at":"2015-06-25T21:25:03Z","updated_at":"2015-06-25T21:25:03Z","body":"Code review: looks good!\r\n\r\nTest suite running but failing for me:\r\n```\r\n/attendease-js(initial-test-suite-setup) antoine$ npm test\r\n\r\n> attendease@0.5.0 test /Users/antoine/Sites/attendease-js\r\n> karma start\r\n\r\nINFO [karma]: Karma v0.12.37 server started at http://localhost:9876/\r\nINFO [launcher]: Starting browser PhantomJS\r\nINFO [PhantomJS 1.9.8 (Mac OS X 0.0.0)]: Connected on socket zSKkn4XBakY-gcsgkq0A with id 88099148\r\n.\r\nPhantomJS 1.9.8 (Mac OS X 0.0.0) Client #login() POSTs to api/authenticate with credentials FAILED\r\n        ReferenceError: Can't find variable: $\r\n            at /Users/antoine/Sites/attendease-js/tests.webpack.js:225\r\n            at /Users/antoine/Sites/attendease-js/tests.webpack.js:207\r\n            at /Users/antoine/Sites/attendease-js/tests.webpack.js:102\r\n        TypeError: 'undefined' is not an object (evaluating 'request.url')\r\n            at /Users/antoine/Sites/attendease-js/tests.webpack.js:114\r\nPhantomJS 1.9.8 (Mac OS X 0.0.0) Client #login() Stores the user and credentials in localStorage FAILED\r\n        ReferenceError: Can't find variable: $\r\n            at /Users/antoine/Sites/attendease-js/tests.webpack.js:225\r\n            at /Users/antoine/Sites/attendease-js/tests.webpack.js:207\r\n            at /Users/antoine/Sites/attendease-js/tests.webpack.js:102\r\n        Expected undefined to be '{\"email\":\"hello@attendease.com\",\"access_token\":\"a\"}'.\r\n            at /Users/antoine/Sites/attendease-js/tests.webpack.js:123\r\n        Expected undefined to be '{\"attendee_token\":\"a\"}'.\r\n            at /Users/antoine/Sites/attendease-js/tests.webpack.js:124\r\nPhantomJS 1.9.8 (Mac OS X 0.0.0) Client #logout() Clears localstorage so user / credentials are no longer stored FAILED\r\n        ReferenceError: Can't find variable: $\r\n            at /Users/antoine/Sites/attendease-js/tests.webpack.js:225\r\n            at /Users/antoine/Sites/attendease-js/tests.webpack.js:207\r\n            at /Users/antoine/Sites/attendease-js/tests.webpack.js:132\r\nPhantomJS 1.9.8 (Mac OS X 0.0.0): Executed 4 of 4 (3 FAILED) (0.002 secs / 0.004 secs)\r\nnpm ERR! Test failed.  See above for more details.\r\nnpm ERR! not ok code 0\r\n```"}}