{"action":"created","comment":{"url":"https://api.github.com/repos/ylatuya/longomatch/pulls/comments/46545002","id":46545002,"diff_hunk":"@@ -93,8 +94,18 @@ internal static void FillObject (IStorable storable, Database db)\n \t\t\tLog.Debug (\"Filling object \" + storable);\n \t\t\tSerializationContext context = new SerializationContext (db, storable.GetType ());\n \t\t\tDocument doc = db.GetExistingDocument (storable.DocumentID);\n-\t\t\tJsonSerializer serializer = GetSerializer (storable.GetType (), context, doc.CurrentRevision);\n+\t\t\tJsonSerializerSettings settings = GetSerializerSettings (storable.GetType (), context, doc.CurrentRevision);\n+\n+\t\t\t// FIXME: for projects we add the MediaFileSet object already deserialized to the cache so the TimelineEvent\n+\t\t\t// reuse the same object instance. This should be done in a more generic way, using the objects parser\n+\t\t\t// to read IStorable children and add them to the cache. But to prevent slowing down deserialization\n+\t\t\t// we use this temporal hack for projects.","path":"LongoMatch.DB/DocumentsSerializer.cs","position":18,"original_position":18,"commit_id":"1bc9618c64891a93b351cdcf5cef93d1efc131d7","original_commit_id":"1bc9618c64891a93b351cdcf5cef93d1efc131d7","user":{"login":"vguzmanp","id":1254383,"avatar_url":"https://avatars.githubusercontent.com/u/1254383?v=3","gravatar_id":"","url":"https://api.github.com/users/vguzmanp","html_url":"https://github.com/vguzmanp","followers_url":"https://api.github.com/users/vguzmanp/followers","following_url":"https://api.github.com/users/vguzmanp/following{/other_user}","gists_url":"https://api.github.com/users/vguzmanp/gists{/gist_id}","starred_url":"https://api.github.com/users/vguzmanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vguzmanp/subscriptions","organizations_url":"https://api.github.com/users/vguzmanp/orgs","repos_url":"https://api.github.com/users/vguzmanp/repos","events_url":"https://api.github.com/users/vguzmanp/events{/privacy}","received_events_url":"https://api.github.com/users/vguzmanp/received_events","type":"User","site_admin":false},"body":"How temporal is this? When should we fix it?","created_at":"2015-12-03T12:25:07Z","updated_at":"2015-12-03T12:25:07Z","html_url":"https://github.com/ylatuya/longomatch/pull/11#discussion_r46545002","pull_request_url":"https://api.github.com/repos/ylatuya/longomatch/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/ylatuya/longomatch/pulls/comments/46545002"},"html":{"href":"https://github.com/ylatuya/longomatch/pull/11#discussion_r46545002"},"pull_request":{"href":"https://api.github.com/repos/ylatuya/longomatch/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/ylatuya/longomatch/pulls/11","id":52247519,"html_url":"https://github.com/ylatuya/longomatch/pull/11","diff_url":"https://github.com/ylatuya/longomatch/pull/11.diff","patch_url":"https://github.com/ylatuya/longomatch/pull/11.patch","issue_url":"https://api.github.com/repos/ylatuya/longomatch/issues/11","number":11,"state":"open","locked":false,"title":"Lon 39","user":{"login":"ylatuya","id":111134,"avatar_url":"https://avatars.githubusercontent.com/u/111134?v=3","gravatar_id":"","url":"https://api.github.com/users/ylatuya","html_url":"https://github.com/ylatuya","followers_url":"https://api.github.com/users/ylatuya/followers","following_url":"https://api.github.com/users/ylatuya/following{/other_user}","gists_url":"https://api.github.com/users/ylatuya/gists{/gist_id}","starred_url":"https://api.github.com/users/ylatuya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylatuya/subscriptions","organizations_url":"https://api.github.com/users/ylatuya/orgs","repos_url":"https://api.github.com/users/ylatuya/repos","events_url":"https://api.github.com/users/ylatuya/events{/privacy}","received_events_url":"https://api.github.com/users/ylatuya/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-01T11:41:51Z","updated_at":"2015-12-03T12:25:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8f59cceb8fa1b90aba9e2693f2c93c9cb5cd904","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ylatuya/longomatch/pulls/11/commits","review_comments_url":"https://api.github.com/repos/ylatuya/longomatch/pulls/11/comments","review_comment_url":"https://api.github.com/repos/ylatuya/longomatch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ylatuya/longomatch/issues/11/comments","statuses_url":"https://api.github.com/repos/ylatuya/longomatch/statuses/1bc9618c64891a93b351cdcf5cef93d1efc131d7","head":{"label":"ylatuya:LON-39","ref":"LON-39","sha":"1bc9618c64891a93b351cdcf5cef93d1efc131d7","user":{"login":"ylatuya","id":111134,"avatar_url":"https://avatars.githubusercontent.com/u/111134?v=3","gravatar_id":"","url":"https://api.github.com/users/ylatuya","html_url":"https://github.com/ylatuya","followers_url":"https://api.github.com/users/ylatuya/followers","following_url":"https://api.github.com/users/ylatuya/following{/other_user}","gists_url":"https://api.github.com/users/ylatuya/gists{/gist_id}","starred_url":"https://api.github.com/users/ylatuya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylatuya/subscriptions","organizations_url":"https://api.github.com/users/ylatuya/orgs","repos_url":"https://api.github.com/users/ylatuya/repos","events_url":"https://api.github.com/users/ylatuya/events{/privacy}","received_events_url":"https://api.github.com/users/ylatuya/received_events","type":"User","site_admin":false},"repo":{"id":2885436,"name":"longomatch","full_name":"ylatuya/longomatch","owner":{"login":"ylatuya","id":111134,"avatar_url":"https://avatars.githubusercontent.com/u/111134?v=3","gravatar_id":"","url":"https://api.github.com/users/ylatuya","html_url":"https://github.com/ylatuya","followers_url":"https://api.github.com/users/ylatuya/followers","following_url":"https://api.github.com/users/ylatuya/following{/other_user}","gists_url":"https://api.github.com/users/ylatuya/gists{/gist_id}","starred_url":"https://api.github.com/users/ylatuya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylatuya/subscriptions","organizations_url":"https://api.github.com/users/ylatuya/orgs","repos_url":"https://api.github.com/users/ylatuya/repos","events_url":"https://api.github.com/users/ylatuya/events{/privacy}","received_events_url":"https://api.github.com/users/ylatuya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ylatuya/longomatch","description":"","fork":false,"url":"https://api.github.com/repos/ylatuya/longomatch","forks_url":"https://api.github.com/repos/ylatuya/longomatch/forks","keys_url":"https://api.github.com/repos/ylatuya/longomatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ylatuya/longomatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ylatuya/longomatch/teams","hooks_url":"https://api.github.com/repos/ylatuya/longomatch/hooks","issue_events_url":"https://api.github.com/repos/ylatuya/longomatch/issues/events{/number}","events_url":"https://api.github.com/repos/ylatuya/longomatch/events","assignees_url":"https://api.github.com/repos/ylatuya/longomatch/assignees{/user}","branches_url":"https://api.github.com/repos/ylatuya/longomatch/branches{/branch}","tags_url":"https://api.github.com/repos/ylatuya/longomatch/tags","blobs_url":"https://api.github.com/repos/ylatuya/longomatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ylatuya/longomatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ylatuya/longomatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/ylatuya/longomatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ylatuya/longomatch/statuses/{sha}","languages_url":"https://api.github.com/repos/ylatuya/longomatch/languages","stargazers_url":"https://api.github.com/repos/ylatuya/longomatch/stargazers","contributors_url":"https://api.github.com/repos/ylatuya/longomatch/contributors","subscribers_url":"https://api.github.com/repos/ylatuya/longomatch/subscribers","subscription_url":"https://api.github.com/repos/ylatuya/longomatch/subscription","commits_url":"https://api.github.com/repos/ylatuya/longomatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/ylatuya/longomatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/ylatuya/longomatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/ylatuya/longomatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/ylatuya/longomatch/contents/{+path}","compare_url":"https://api.github.com/repos/ylatuya/longomatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ylatuya/longomatch/merges","archive_url":"https://api.github.com/repos/ylatuya/longomatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ylatuya/longomatch/downloads","issues_url":"https://api.github.com/repos/ylatuya/longomatch/issues{/number}","pulls_url":"https://api.github.com/repos/ylatuya/longomatch/pulls{/number}","milestones_url":"https://api.github.com/repos/ylatuya/longomatch/milestones{/number}","notifications_url":"https://api.github.com/repos/ylatuya/longomatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ylatuya/longomatch/labels{/name}","releases_url":"https://api.github.com/repos/ylatuya/longomatch/releases{/id}","created_at":"2011-11-30T18:49:28Z","updated_at":"2015-05-08T18:27:45Z","pushed_at":"2015-12-03T11:21:25Z","git_url":"git://github.com/ylatuya/longomatch.git","ssh_url":"git@github.com:ylatuya/longomatch.git","clone_url":"https://github.com/ylatuya/longomatch.git","svn_url":"https://github.com/ylatuya/longomatch","homepage":"","size":158861,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"ylatuya:master","ref":"master","sha":"3dbe9ab864d04e4fa8fc477dc6619ffb98d8a380","user":{"login":"ylatuya","id":111134,"avatar_url":"https://avatars.githubusercontent.com/u/111134?v=3","gravatar_id":"","url":"https://api.github.com/users/ylatuya","html_url":"https://github.com/ylatuya","followers_url":"https://api.github.com/users/ylatuya/followers","following_url":"https://api.github.com/users/ylatuya/following{/other_user}","gists_url":"https://api.github.com/users/ylatuya/gists{/gist_id}","starred_url":"https://api.github.com/users/ylatuya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylatuya/subscriptions","organizations_url":"https://api.github.com/users/ylatuya/orgs","repos_url":"https://api.github.com/users/ylatuya/repos","events_url":"https://api.github.com/users/ylatuya/events{/privacy}","received_events_url":"https://api.github.com/users/ylatuya/received_events","type":"User","site_admin":false},"repo":{"id":2885436,"name":"longomatch","full_name":"ylatuya/longomatch","owner":{"login":"ylatuya","id":111134,"avatar_url":"https://avatars.githubusercontent.com/u/111134?v=3","gravatar_id":"","url":"https://api.github.com/users/ylatuya","html_url":"https://github.com/ylatuya","followers_url":"https://api.github.com/users/ylatuya/followers","following_url":"https://api.github.com/users/ylatuya/following{/other_user}","gists_url":"https://api.github.com/users/ylatuya/gists{/gist_id}","starred_url":"https://api.github.com/users/ylatuya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylatuya/subscriptions","organizations_url":"https://api.github.com/users/ylatuya/orgs","repos_url":"https://api.github.com/users/ylatuya/repos","events_url":"https://api.github.com/users/ylatuya/events{/privacy}","received_events_url":"https://api.github.com/users/ylatuya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ylatuya/longomatch","description":"","fork":false,"url":"https://api.github.com/repos/ylatuya/longomatch","forks_url":"https://api.github.com/repos/ylatuya/longomatch/forks","keys_url":"https://api.github.com/repos/ylatuya/longomatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ylatuya/longomatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ylatuya/longomatch/teams","hooks_url":"https://api.github.com/repos/ylatuya/longomatch/hooks","issue_events_url":"https://api.github.com/repos/ylatuya/longomatch/issues/events{/number}","events_url":"https://api.github.com/repos/ylatuya/longomatch/events","assignees_url":"https://api.github.com/repos/ylatuya/longomatch/assignees{/user}","branches_url":"https://api.github.com/repos/ylatuya/longomatch/branches{/branch}","tags_url":"https://api.github.com/repos/ylatuya/longomatch/tags","blobs_url":"https://api.github.com/repos/ylatuya/longomatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ylatuya/longomatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ylatuya/longomatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/ylatuya/longomatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ylatuya/longomatch/statuses/{sha}","languages_url":"https://api.github.com/repos/ylatuya/longomatch/languages","stargazers_url":"https://api.github.com/repos/ylatuya/longomatch/stargazers","contributors_url":"https://api.github.com/repos/ylatuya/longomatch/contributors","subscribers_url":"https://api.github.com/repos/ylatuya/longomatch/subscribers","subscription_url":"https://api.github.com/repos/ylatuya/longomatch/subscription","commits_url":"https://api.github.com/repos/ylatuya/longomatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/ylatuya/longomatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/ylatuya/longomatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/ylatuya/longomatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/ylatuya/longomatch/contents/{+path}","compare_url":"https://api.github.com/repos/ylatuya/longomatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ylatuya/longomatch/merges","archive_url":"https://api.github.com/repos/ylatuya/longomatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ylatuya/longomatch/downloads","issues_url":"https://api.github.com/repos/ylatuya/longomatch/issues{/number}","pulls_url":"https://api.github.com/repos/ylatuya/longomatch/pulls{/number}","milestones_url":"https://api.github.com/repos/ylatuya/longomatch/milestones{/number}","notifications_url":"https://api.github.com/repos/ylatuya/longomatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ylatuya/longomatch/labels{/name}","releases_url":"https://api.github.com/repos/ylatuya/longomatch/releases{/id}","created_at":"2011-11-30T18:49:28Z","updated_at":"2015-05-08T18:27:45Z","pushed_at":"2015-12-03T11:21:25Z","git_url":"git://github.com/ylatuya/longomatch.git","ssh_url":"git@github.com:ylatuya/longomatch.git","clone_url":"https://github.com/ylatuya/longomatch.git","svn_url":"https://github.com/ylatuya/longomatch","homepage":"","size":158861,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ylatuya/longomatch/pulls/11"},"html":{"href":"https://github.com/ylatuya/longomatch/pull/11"},"issue":{"href":"https://api.github.com/repos/ylatuya/longomatch/issues/11"},"comments":{"href":"https://api.github.com/repos/ylatuya/longomatch/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/ylatuya/longomatch/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/ylatuya/longomatch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ylatuya/longomatch/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/ylatuya/longomatch/statuses/1bc9618c64891a93b351cdcf5cef93d1efc131d7"}}}}