{"action":"created","issue":{"url":"https://api.github.com/repos/makomweb/Emkay.S3/issues/14","labels_url":"https://api.github.com/repos/makomweb/Emkay.S3/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/makomweb/Emkay.S3/issues/14/comments","events_url":"https://api.github.com/repos/makomweb/Emkay.S3/issues/14/events","html_url":"https://github.com/makomweb/Emkay.S3/pull/14","id":65588026,"number":14,"title":"Consolidate all publish task into single PublishFiles task","user":{"login":"gregmac","id":1216375,"avatar_url":"https://avatars.githubusercontent.com/u/1216375?v=3","gravatar_id":"","url":"https://api.github.com/users/gregmac","html_url":"https://github.com/gregmac","followers_url":"https://api.github.com/users/gregmac/followers","following_url":"https://api.github.com/users/gregmac/following{/other_user}","gists_url":"https://api.github.com/users/gregmac/gists{/gist_id}","starred_url":"https://api.github.com/users/gregmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregmac/subscriptions","organizations_url":"https://api.github.com/users/gregmac/orgs","repos_url":"https://api.github.com/users/gregmac/repos","events_url":"https://api.github.com/users/gregmac/events{/privacy}","received_events_url":"https://api.github.com/users/gregmac/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-01T02:31:31Z","updated_at":"2015-04-21T09:33:20Z","closed_at":"2015-04-21T09:33:05Z","pull_request":{"url":"https://api.github.com/repos/makomweb/Emkay.S3/pulls/14","html_url":"https://github.com/makomweb/Emkay.S3/pull/14","diff_url":"https://github.com/makomweb/Emkay.S3/pull/14.diff","patch_url":"https://github.com/makomweb/Emkay.S3/pull/14.patch"},"body":"Implements #9 .. but breaks backwards compatibility by completely removing `PublishFolder` and `PublishFolderWithHeaders`\r\n\r\nI was going to initially have PublishFolder simply call the same codepath as PublishFiles, however there are two issues I ran into:\r\n\r\n* I want to add support to recursively upload (instead of flatting files into a single folder), but to make `PublishFolder` do that would require revamping its entire code path right up to the AmazonS3Client object. At the same time, it's quite easy to call `PublishFiles` using an ItemGroup natively in msbuild and get this functionality quite easily (I think it will be easy to support recursive directories there).\r\n* `PublishFolderWithHeaders` uses a property `SourceFolders` while `PublishFolder` uses `SourceFolder` which is not only painful as a user, but to preserve backwards compatibility means the task code MUST be duplicated with no changes (or another pointless abstraction layer must be added)\r\n\r\nIt's not a big deal to switch, plus it's much more powerful to use ItemGroups to upload a folder as you can exclude file types, specify headers on certain files, etc. So I decided the lower friction path is just to remove it entirely. \r\n\r\nI updated the README to show the new usage. \r\n\r\nI realize this is probably a contentious change, because it's breaking backwards compat, but ultimately it's for the better. I'll revisit after recursive support, and maybe there will be a way to provide a new PublishFolder task that I just don't see now.\r\n"},"comment":{"url":"https://api.github.com/repos/makomweb/Emkay.S3/issues/comments/94721034","html_url":"https://github.com/makomweb/Emkay.S3/pull/14#issuecomment-94721034","issue_url":"https://api.github.com/repos/makomweb/Emkay.S3/issues/14","id":94721034,"user":{"login":"makomweb","id":1567373,"avatar_url":"https://avatars.githubusercontent.com/u/1567373?v=3","gravatar_id":"","url":"https://api.github.com/users/makomweb","html_url":"https://github.com/makomweb","followers_url":"https://api.github.com/users/makomweb/followers","following_url":"https://api.github.com/users/makomweb/following{/other_user}","gists_url":"https://api.github.com/users/makomweb/gists{/gist_id}","starred_url":"https://api.github.com/users/makomweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makomweb/subscriptions","organizations_url":"https://api.github.com/users/makomweb/orgs","repos_url":"https://api.github.com/users/makomweb/repos","events_url":"https://api.github.com/users/makomweb/events{/privacy}","received_events_url":"https://api.github.com/users/makomweb/received_events","type":"User","site_admin":false},"created_at":"2015-04-21T09:33:20Z","updated_at":"2015-04-21T09:33:20Z","body":"Thanks @gregmac "}}