{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments/38648384","id":38648384,"diff_hunk":"@@ -80,48 +80,67 @@\n     HTML.prototype.render = function (callback) {\n         if (this.ddlUrl() === \"\" || (this.ddlUrl() === this._prev_ddlUrl && this.databomb() === this._prev_databomb)) {\n             return Tabbed.prototype.render.apply(this, arguments);\n+        } else if (this._prev_ddlUrl && this._prev_ddlUrl !== this.ddlUrl()) {\n+            //  DDL has actually changed (not just a deserialization)\n+            this\n+                .clearTabs()\n+            ;\n         }\n         this._prev_ddlUrl = this.ddlUrl();\n         this._prev_databomb = this.databomb();\n \n-        this.marshaller = new HipieDDL.Marshaller().proxyMappings(this.proxyMappings());\n+        //  Gather existing widgets for reuse  ---\n+        var tabContent = [];\n+        this.widgets().forEach(function (d) {\n+            tabContent = tabContent.concat(d.widget().content());","path":"src/marshaller/HTML.js","position":26,"original_position":26,"commit_id":"e1ac60f2efb9c81e499bc81004fe408c322bcf11","original_commit_id":"e1ac60f2efb9c81e499bc81004fe408c322bcf11","user":{"login":"mlzummo","id":1057527,"avatar_url":"https://avatars.githubusercontent.com/u/1057527?v=3","gravatar_id":"","url":"https://api.github.com/users/mlzummo","html_url":"https://github.com/mlzummo","followers_url":"https://api.github.com/users/mlzummo/followers","following_url":"https://api.github.com/users/mlzummo/following{/other_user}","gists_url":"https://api.github.com/users/mlzummo/gists{/gist_id}","starred_url":"https://api.github.com/users/mlzummo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlzummo/subscriptions","organizations_url":"https://api.github.com/users/mlzummo/orgs","repos_url":"https://api.github.com/users/mlzummo/repos","events_url":"https://api.github.com/users/mlzummo/events{/privacy}","received_events_url":"https://api.github.com/users/mlzummo/received_events","type":"User","site_admin":false},"body":"@GordonSmith Uncaught TypeError: d.widget(...).content is not a function (for DSP opening second dashboard)","created_at":"2015-09-03T14:01:57Z","updated_at":"2015-09-03T14:01:57Z","html_url":"https://github.com/hpcc-systems/Visualization/pull/858#discussion_r38648384","pull_request_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/858","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments/38648384"},"html":{"href":"https://github.com/hpcc-systems/Visualization/pull/858#discussion_r38648384"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/858"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/858","id":44073238,"html_url":"https://github.com/hpcc-systems/Visualization/pull/858","diff_url":"https://github.com/hpcc-systems/Visualization/pull/858.diff","patch_url":"https://github.com/hpcc-systems/Visualization/pull/858.patch","issue_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/858","number":858,"state":"open","locked":false,"title":"GH-854 Deserializing a marshaller event issues","user":{"login":"GordonSmith","id":966863,"avatar_url":"https://avatars.githubusercontent.com/u/966863?v=3","gravatar_id":"","url":"https://api.github.com/users/GordonSmith","html_url":"https://github.com/GordonSmith","followers_url":"https://api.github.com/users/GordonSmith/followers","following_url":"https://api.github.com/users/GordonSmith/following{/other_user}","gists_url":"https://api.github.com/users/GordonSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonSmith/subscriptions","organizations_url":"https://api.github.com/users/GordonSmith/orgs","repos_url":"https://api.github.com/users/GordonSmith/repos","events_url":"https://api.github.com/users/GordonSmith/events{/privacy}","received_events_url":"https://api.github.com/users/GordonSmith/received_events","type":"User","site_admin":false},"body":"@mlzummo Please Review\r\n","created_at":"2015-09-03T06:32:12Z","updated_at":"2015-09-03T14:01:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb1240d2e5c4fc488bd5471ca5233445f14cfcf1","assignee":null,"milestone":{"url":"https://api.github.com/repos/hpcc-systems/Visualization/milestones/18","html_url":"https://github.com/hpcc-systems/Visualization/milestones/1.6.2","labels_url":"https://api.github.com/repos/hpcc-systems/Visualization/milestones/18/labels","id":1279990,"number":18,"title":"1.6.2","description":"","creator":{"login":"GordonSmith","id":966863,"avatar_url":"https://avatars.githubusercontent.com/u/966863?v=3","gravatar_id":"","url":"https://api.github.com/users/GordonSmith","html_url":"https://github.com/GordonSmith","followers_url":"https://api.github.com/users/GordonSmith/followers","following_url":"https://api.github.com/users/GordonSmith/following{/other_user}","gists_url":"https://api.github.com/users/GordonSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonSmith/subscriptions","organizations_url":"https://api.github.com/users/GordonSmith/orgs","repos_url":"https://api.github.com/users/GordonSmith/repos","events_url":"https://api.github.com/users/GordonSmith/events{/privacy}","received_events_url":"https://api.github.com/users/GordonSmith/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":8,"state":"open","created_at":"2015-08-30T08:32:37Z","updated_at":"2015-09-03T13:03:05Z","due_on":"2015-09-03T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/858/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/858/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/858/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/Visualization/statuses/e1ac60f2efb9c81e499bc81004fe408c322bcf11","head":{"label":"GordonSmith:GH-854","ref":"GH-854","sha":"e1ac60f2efb9c81e499bc81004fe408c322bcf11","user":{"login":"GordonSmith","id":966863,"avatar_url":"https://avatars.githubusercontent.com/u/966863?v=3","gravatar_id":"","url":"https://api.github.com/users/GordonSmith","html_url":"https://github.com/GordonSmith","followers_url":"https://api.github.com/users/GordonSmith/followers","following_url":"https://api.github.com/users/GordonSmith/following{/other_user}","gists_url":"https://api.github.com/users/GordonSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonSmith/subscriptions","organizations_url":"https://api.github.com/users/GordonSmith/orgs","repos_url":"https://api.github.com/users/GordonSmith/repos","events_url":"https://api.github.com/users/GordonSmith/events{/privacy}","received_events_url":"https://api.github.com/users/GordonSmith/received_events","type":"User","site_admin":false},"repo":{"id":22138152,"name":"Visualization","full_name":"GordonSmith/Visualization","owner":{"login":"GordonSmith","id":966863,"avatar_url":"https://avatars.githubusercontent.com/u/966863?v=3","gravatar_id":"","url":"https://api.github.com/users/GordonSmith","html_url":"https://github.com/GordonSmith","followers_url":"https://api.github.com/users/GordonSmith/followers","following_url":"https://api.github.com/users/GordonSmith/following{/other_user}","gists_url":"https://api.github.com/users/GordonSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonSmith/subscriptions","organizations_url":"https://api.github.com/users/GordonSmith/orgs","repos_url":"https://api.github.com/users/GordonSmith/repos","events_url":"https://api.github.com/users/GordonSmith/events{/privacy}","received_events_url":"https://api.github.com/users/GordonSmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GordonSmith/Visualization","description":"","fork":true,"url":"https://api.github.com/repos/GordonSmith/Visualization","forks_url":"https://api.github.com/repos/GordonSmith/Visualization/forks","keys_url":"https://api.github.com/repos/GordonSmith/Visualization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GordonSmith/Visualization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GordonSmith/Visualization/teams","hooks_url":"https://api.github.com/repos/GordonSmith/Visualization/hooks","issue_events_url":"https://api.github.com/repos/GordonSmith/Visualization/issues/events{/number}","events_url":"https://api.github.com/repos/GordonSmith/Visualization/events","assignees_url":"https://api.github.com/repos/GordonSmith/Visualization/assignees{/user}","branches_url":"https://api.github.com/repos/GordonSmith/Visualization/branches{/branch}","tags_url":"https://api.github.com/repos/GordonSmith/Visualization/tags","blobs_url":"https://api.github.com/repos/GordonSmith/Visualization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GordonSmith/Visualization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GordonSmith/Visualization/git/refs{/sha}","trees_url":"https://api.github.com/repos/GordonSmith/Visualization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GordonSmith/Visualization/statuses/{sha}","languages_url":"https://api.github.com/repos/GordonSmith/Visualization/languages","stargazers_url":"https://api.github.com/repos/GordonSmith/Visualization/stargazers","contributors_url":"https://api.github.com/repos/GordonSmith/Visualization/contributors","subscribers_url":"https://api.github.com/repos/GordonSmith/Visualization/subscribers","subscription_url":"https://api.github.com/repos/GordonSmith/Visualization/subscription","commits_url":"https://api.github.com/repos/GordonSmith/Visualization/commits{/sha}","git_commits_url":"https://api.github.com/repos/GordonSmith/Visualization/git/commits{/sha}","comments_url":"https://api.github.com/repos/GordonSmith/Visualization/comments{/number}","issue_comment_url":"https://api.github.com/repos/GordonSmith/Visualization/issues/comments{/number}","contents_url":"https://api.github.com/repos/GordonSmith/Visualization/contents/{+path}","compare_url":"https://api.github.com/repos/GordonSmith/Visualization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GordonSmith/Visualization/merges","archive_url":"https://api.github.com/repos/GordonSmith/Visualization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GordonSmith/Visualization/downloads","issues_url":"https://api.github.com/repos/GordonSmith/Visualization/issues{/number}","pulls_url":"https://api.github.com/repos/GordonSmith/Visualization/pulls{/number}","milestones_url":"https://api.github.com/repos/GordonSmith/Visualization/milestones{/number}","notifications_url":"https://api.github.com/repos/GordonSmith/Visualization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GordonSmith/Visualization/labels{/name}","releases_url":"https://api.github.com/repos/GordonSmith/Visualization/releases{/id}","created_at":"2014-07-23T08:23:34Z","updated_at":"2015-05-08T12:23:51Z","pushed_at":"2015-09-03T13:00:38Z","git_url":"git://github.com/GordonSmith/Visualization.git","ssh_url":"git@github.com:GordonSmith/Visualization.git","clone_url":"https://github.com/GordonSmith/Visualization.git","svn_url":"https://github.com/GordonSmith/Visualization","homepage":null,"size":10265,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcc-systems:candidate-1.6.2","ref":"candidate-1.6.2","sha":"96007889198305250211e8970ccf6d3712c944c3","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":22117259,"name":"Visualization","full_name":"hpcc-systems/Visualization","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/Visualization","description":"Common Visualization Components","fork":false,"url":"https://api.github.com/repos/hpcc-systems/Visualization","forks_url":"https://api.github.com/repos/hpcc-systems/Visualization/forks","keys_url":"https://api.github.com/repos/hpcc-systems/Visualization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/Visualization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/Visualization/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/Visualization/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/Visualization/events","assignees_url":"https://api.github.com/repos/hpcc-systems/Visualization/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/Visualization/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/Visualization/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/Visualization/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/Visualization/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/Visualization/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/Visualization/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/Visualization/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/Visualization/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/Visualization/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/Visualization/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/Visualization/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/Visualization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/Visualization/merges","archive_url":"https://api.github.com/repos/hpcc-systems/Visualization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/Visualization/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/Visualization/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/Visualization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/Visualization/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/Visualization/releases{/id}","created_at":"2014-07-22T19:13:04Z","updated_at":"2015-08-18T22:08:14Z","pushed_at":"2015-09-03T13:49:54Z","git_url":"git://github.com/hpcc-systems/Visualization.git","ssh_url":"git@github.com:hpcc-systems/Visualization.git","clone_url":"https://github.com/hpcc-systems/Visualization.git","svn_url":"https://github.com/hpcc-systems/Visualization","homepage":"","size":19484,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":89,"forks":21,"open_issues":89,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/858"},"html":{"href":"https://github.com/hpcc-systems/Visualization/pull/858"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/issues/858"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/issues/858/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/858/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/858/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/statuses/e1ac60f2efb9c81e499bc81004fe408c322bcf11"}}}}