{"comment":{"url":"https://api.github.com/repos/educpop1/shine/comments/14138495","html_url":"https://github.com/educpop1/shine/commit/779261ad78012ae1fa16b23de0e9cd0bf3a65265#commitcomment-14138495","id":14138495,"user":{"login":"jacobdfriedmann","id":5315170,"avatar_url":"https://avatars.githubusercontent.com/u/5315170?v=3","gravatar_id":"","url":"https://api.github.com/users/jacobdfriedmann","html_url":"https://github.com/jacobdfriedmann","followers_url":"https://api.github.com/users/jacobdfriedmann/followers","following_url":"https://api.github.com/users/jacobdfriedmann/following{/other_user}","gists_url":"https://api.github.com/users/jacobdfriedmann/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobdfriedmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobdfriedmann/subscriptions","organizations_url":"https://api.github.com/users/jacobdfriedmann/orgs","repos_url":"https://api.github.com/users/jacobdfriedmann/repos","events_url":"https://api.github.com/users/jacobdfriedmann/events{/privacy}","received_events_url":"https://api.github.com/users/jacobdfriedmann/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"779261ad78012ae1fa16b23de0e9cd0bf3a65265","created_at":"2015-11-02T21:10:25Z","updated_at":"2015-11-02T21:10:25Z","body":"Overall really nice work Tim - the site looks good on mobile! A couple pieces of feedback to help you out going forward:\r\n\r\n1. All of your content fits nicely in a mobile view except your images. The reason for this is your images are allowed to spill out of their container unless they are given a `width` or `max-width`. You might consider adding a `max-width: 100%` at least in your mobile (small screen) styles.\r\n\r\n2. Nice use of `em` font sizing. The approach we generally take when using `em` font-sizing is to add the `em` sizes _outside_ of the media queries, so that we only have to change _one_ font in the media query itself. This saves us a lot of key strokes. Let me know if you still have questions about how this works.\r\n\r\nOther than that, great work! Let me know if you have any other questions.\r\n\r\n#FEWD Week #4 Project: Responsive Design\r\n\r\n---\r\n\r\n\r\n###Description\r\n\r\n\r\nRelaxr's user count has grown, and the number of users accessing the site from a mobile device has surprised everyone, even by today's standards. The product managers at Relaxr have asked you to return to the project and make their site responsive so it renders nicely on mobile devices. They had one of their internal developers make a few tweaks to your source code, and they have given you the new HTML / CSS files to work from. Using these starter files, build out the mobile layouts for the landing page and blog.\r\n\r\nStudent: Tim Weedon\r\n\r\n|                                                                                               |                                |                        |                          |\r\n|-----------------------------------------------------------------------------------------------|--------------------------------|------------------------|--------------------------|\r\n| Technical Requirements                                                                        | Does Not Meet Expectations (0) | Meets Expectations (1) | Exceeds Expectations (2) |\r\n| Use media queries at a 768px breakpoint                                                       |                                |                        |              X            |\r\n| Content remains in appropriate ```divs```                                                     |                                |                        |             X             |\r\n| Content remains visible to the user                                                           |                                |            X            |                          |\r\n| Fonts change size appropriately                                                               |                                |                        |              X            |\r\n| Margins and padding change size appropriately                                                 |                                |                        |             X             |\r\n| Content does not overlap                                                                      |                                |                        | X                         |\r\n| In the blog section, the two-column layout changes to a single-column layout when appropriate |                                |                        |             X             |\r\n| TOTAL: *13*/14                                                                              |                                |                        |                          |"}}