{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/39672547","id":39672547,"diff_hunk":"@@ -0,0 +1,31 @@\n+'use strict';\n+\n+const common = require('../common');\n+const assert = require('assert');\n+const spawn = require('child_process').spawn;\n+const node = process.execPath;\n+\n+if (process.argv[2] === 'child') {\n+  throw new Error('child error');\n+} else {\n+  run('', null);\n+  run('--abort-on-uncaught-exception', 'SIGABRT');","path":"test/parallel/test-abort-uncaught-exception.js","position":12,"original_position":12,"commit_id":"4cadbe4b46720f25bf3efecc5cdd4a95785defce","original_commit_id":"4cadbe4b46720f25bf3efecc5cdd4a95785defce","user":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=3","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"body":"@bnoordhuis will this generate core files that stick around every time tests run?","created_at":"2015-09-16T19:12:33Z","updated_at":"2015-09-16T19:12:33Z","html_url":"https://github.com/nodejs/node/pull/2776#discussion_r39672547","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/2776","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/39672547"},"html":{"href":"https://github.com/nodejs/node/pull/2776#discussion_r39672547"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/2776"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/2776","id":44573648,"html_url":"https://github.com/nodejs/node/pull/2776","diff_url":"https://github.com/nodejs/node/pull/2776.diff","patch_url":"https://github.com/nodejs/node/pull/2776.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/2776","number":2776,"state":"open","locked":false,"title":"src: honor --abort_on_uncaught_exception flag","user":{"login":"evanlucas","id":677994,"avatar_url":"https://avatars.githubusercontent.com/u/677994?v=3","gravatar_id":"","url":"https://api.github.com/users/evanlucas","html_url":"https://github.com/evanlucas","followers_url":"https://api.github.com/users/evanlucas/followers","following_url":"https://api.github.com/users/evanlucas/following{/other_user}","gists_url":"https://api.github.com/users/evanlucas/gists{/gist_id}","starred_url":"https://api.github.com/users/evanlucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanlucas/subscriptions","organizations_url":"https://api.github.com/users/evanlucas/orgs","repos_url":"https://api.github.com/users/evanlucas/repos","events_url":"https://api.github.com/users/evanlucas/events{/privacy}","received_events_url":"https://api.github.com/users/evanlucas/received_events","type":"User","site_admin":false},"body":"Fix regression introduced in 0af4c9ea7434e4f505dbe071357e4bc3b4ab2a8a\r\nthat ignores the --abort-on-uncaught-exception flag. Prior to that\r\ncommit, the flag was passed through to v8. After that commit, the\r\nprocess just calls exit(1).\r\n\r\nThe tests added in https://github.com/nodejs/node/commit/0af4c9ea7434e4f505dbe071357e4bc3b4ab2a8a all are still passing. \r\n\r\nThere probably is a better way of doing this, but this is working for me, so...","created_at":"2015-09-09T16:47:03Z","updated_at":"2015-09-16T19:12:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be1fcffa230b8b2e84b8e7410049a0fa61ee2494","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/2776/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/2776/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/2776/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/4cadbe4b46720f25bf3efecc5cdd4a95785defce","head":{"label":"evanlucas:fixabrt","ref":"fixabrt","sha":"4cadbe4b46720f25bf3efecc5cdd4a95785defce","user":{"login":"evanlucas","id":677994,"avatar_url":"https://avatars.githubusercontent.com/u/677994?v=3","gravatar_id":"","url":"https://api.github.com/users/evanlucas","html_url":"https://github.com/evanlucas","followers_url":"https://api.github.com/users/evanlucas/followers","following_url":"https://api.github.com/users/evanlucas/following{/other_user}","gists_url":"https://api.github.com/users/evanlucas/gists{/gist_id}","starred_url":"https://api.github.com/users/evanlucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanlucas/subscriptions","organizations_url":"https://api.github.com/users/evanlucas/orgs","repos_url":"https://api.github.com/users/evanlucas/repos","events_url":"https://api.github.com/users/evanlucas/events{/privacy}","received_events_url":"https://api.github.com/users/evanlucas/received_events","type":"User","site_admin":false},"repo":{"id":27466639,"name":"io.js","full_name":"evanlucas/io.js","owner":{"login":"evanlucas","id":677994,"avatar_url":"https://avatars.githubusercontent.com/u/677994?v=3","gravatar_id":"","url":"https://api.github.com/users/evanlucas","html_url":"https://github.com/evanlucas","followers_url":"https://api.github.com/users/evanlucas/followers","following_url":"https://api.github.com/users/evanlucas/following{/other_user}","gists_url":"https://api.github.com/users/evanlucas/gists{/gist_id}","starred_url":"https://api.github.com/users/evanlucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanlucas/subscriptions","organizations_url":"https://api.github.com/users/evanlucas/orgs","repos_url":"https://api.github.com/users/evanlucas/repos","events_url":"https://api.github.com/users/evanlucas/events{/privacy}","received_events_url":"https://api.github.com/users/evanlucas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evanlucas/io.js","description":"Evented IO for V8 JavaScript","fork":true,"url":"https://api.github.com/repos/evanlucas/io.js","forks_url":"https://api.github.com/repos/evanlucas/io.js/forks","keys_url":"https://api.github.com/repos/evanlucas/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evanlucas/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evanlucas/io.js/teams","hooks_url":"https://api.github.com/repos/evanlucas/io.js/hooks","issue_events_url":"https://api.github.com/repos/evanlucas/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/evanlucas/io.js/events","assignees_url":"https://api.github.com/repos/evanlucas/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/evanlucas/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/evanlucas/io.js/tags","blobs_url":"https://api.github.com/repos/evanlucas/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evanlucas/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evanlucas/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/evanlucas/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evanlucas/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/evanlucas/io.js/languages","stargazers_url":"https://api.github.com/repos/evanlucas/io.js/stargazers","contributors_url":"https://api.github.com/repos/evanlucas/io.js/contributors","subscribers_url":"https://api.github.com/repos/evanlucas/io.js/subscribers","subscription_url":"https://api.github.com/repos/evanlucas/io.js/subscription","commits_url":"https://api.github.com/repos/evanlucas/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/evanlucas/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/evanlucas/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/evanlucas/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/evanlucas/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/evanlucas/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evanlucas/io.js/merges","archive_url":"https://api.github.com/repos/evanlucas/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evanlucas/io.js/downloads","issues_url":"https://api.github.com/repos/evanlucas/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/evanlucas/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/evanlucas/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/evanlucas/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evanlucas/io.js/labels{/name}","releases_url":"https://api.github.com/repos/evanlucas/io.js/releases{/id}","created_at":"2014-12-03T03:07:41Z","updated_at":"2014-12-20T01:04:31Z","pushed_at":"2015-09-16T19:05:10Z","git_url":"git://github.com/evanlucas/io.js.git","ssh_url":"git@github.com:evanlucas/io.js.git","clone_url":"https://github.com/evanlucas/io.js.git","svn_url":"https://github.com/evanlucas/io.js","homepage":null,"size":144054,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"3b78b85426d1b8347a5c10219a86d38763593e01","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"✨Node.js  ✨","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-09-16T18:20:26Z","pushed_at":"2015-09-16T19:10:58Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":331785,"stargazers_count":14994,"watchers_count":14994,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1299,"mirror_url":null,"open_issues_count":422,"forks":1299,"open_issues":422,"watchers":14994,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/2776"},"html":{"href":"https://github.com/nodejs/node/pull/2776"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/2776"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/2776/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/2776/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/2776/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/4cadbe4b46720f25bf3efecc5cdd4a95785defce"}}}}