{"action":"created","comment":{"url":"https://api.github.com/repos/junit-team/junit/pulls/comments/37132093","id":37132093,"diff_hunk":"@@ -40,7 +40,10 @@ protected JUnit3Builder junit3Builder() {\n     }\n \n     protected AnnotatedBuilder annotatedBuilder() {\n-        return new AnnotatedBuilder(this);\n+        // For compatibility with Request#classes(...) and the Suite runner,\n+        // deeper nesting levels always need to support suite() methods:\n+        RunnerBuilder suiteBuilder = canUseSuiteMethod ? this : new AllDefaultPossibilitiesBuilder(true);","path":"src/main/java/org/junit/internal/builders/AllDefaultPossibilitiesBuilder.java","position":7,"original_position":7,"commit_id":"085fab1fd50ec4994a6a1647c8fb99529fc03445","original_commit_id":"085fab1fd50ec4994a6a1647c8fb99529fc03445","user":{"login":"kcooney","id":478190,"avatar_url":"https://avatars.githubusercontent.com/u/478190?v=3","gravatar_id":"","url":"https://api.github.com/users/kcooney","html_url":"https://github.com/kcooney","followers_url":"https://api.github.com/users/kcooney/followers","following_url":"https://api.github.com/users/kcooney/following{/other_user}","gists_url":"https://api.github.com/users/kcooney/gists{/gist_id}","starred_url":"https://api.github.com/users/kcooney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcooney/subscriptions","organizations_url":"https://api.github.com/users/kcooney/orgs","repos_url":"https://api.github.com/users/kcooney/repos","events_url":"https://api.github.com/users/kcooney/events{/privacy}","received_events_url":"https://api.github.com/users/kcooney/received_events","type":"User","site_admin":false},"body":"As far as I can tell, the only way `canUseSuiteMethod` can be false is if you either explicitly created `AllDefaultPossibilitiesBuilder` and passed in false, or if you used `Request.classWithoutSuiteMethod()`. In either case, not using the suite method sounds like expected behavior.\r\n\r\nAm I missing something","created_at":"2015-08-15T02:29:49Z","updated_at":"2015-08-15T02:29:49Z","html_url":"https://github.com/junit-team/junit/pull/1190#discussion_r37132093","pull_request_url":"https://api.github.com/repos/junit-team/junit/pulls/1190","_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit/pulls/comments/37132093"},"html":{"href":"https://github.com/junit-team/junit/pull/1190#discussion_r37132093"},"pull_request":{"href":"https://api.github.com/repos/junit-team/junit/pulls/1190"}}},"pull_request":{"url":"https://api.github.com/repos/junit-team/junit/pulls/1190","id":42248167,"html_url":"https://github.com/junit-team/junit/pull/1190","diff_url":"https://github.com/junit-team/junit/pull/1190.diff","patch_url":"https://github.com/junit-team/junit/pull/1190.patch","issue_url":"https://api.github.com/repos/junit-team/junit/issues/1190","number":1190,"state":"open","locked":false,"title":"Fixes #1189: JUnit4TestAdapter blocks JUnit-3-style suites that are included via @RunWith(Suite.class)","user":{"login":"mkeller","id":154496,"avatar_url":"https://avatars.githubusercontent.com/u/154496?v=3","gravatar_id":"","url":"https://api.github.com/users/mkeller","html_url":"https://github.com/mkeller","followers_url":"https://api.github.com/users/mkeller/followers","following_url":"https://api.github.com/users/mkeller/following{/other_user}","gists_url":"https://api.github.com/users/mkeller/gists{/gist_id}","starred_url":"https://api.github.com/users/mkeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkeller/subscriptions","organizations_url":"https://api.github.com/users/mkeller/orgs","repos_url":"https://api.github.com/users/mkeller/repos","events_url":"https://api.github.com/users/mkeller/events{/privacy}","received_events_url":"https://api.github.com/users/mkeller/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-12T14:48:55Z","updated_at":"2015-08-15T02:29:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb67d03e9eec28e28c7047de3b3abfe6765fbcd4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/junit-team/junit/pulls/1190/commits","review_comments_url":"https://api.github.com/repos/junit-team/junit/pulls/1190/comments","review_comment_url":"https://api.github.com/repos/junit-team/junit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/junit-team/junit/issues/1190/comments","statuses_url":"https://api.github.com/repos/junit-team/junit/statuses/085fab1fd50ec4994a6a1647c8fb99529fc03445","head":{"label":"mkeller:issue1189","ref":"issue1189","sha":"085fab1fd50ec4994a6a1647c8fb99529fc03445","user":{"login":"mkeller","id":154496,"avatar_url":"https://avatars.githubusercontent.com/u/154496?v=3","gravatar_id":"","url":"https://api.github.com/users/mkeller","html_url":"https://github.com/mkeller","followers_url":"https://api.github.com/users/mkeller/followers","following_url":"https://api.github.com/users/mkeller/following{/other_user}","gists_url":"https://api.github.com/users/mkeller/gists{/gist_id}","starred_url":"https://api.github.com/users/mkeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkeller/subscriptions","organizations_url":"https://api.github.com/users/mkeller/orgs","repos_url":"https://api.github.com/users/mkeller/repos","events_url":"https://api.github.com/users/mkeller/events{/privacy}","received_events_url":"https://api.github.com/users/mkeller/received_events","type":"User","site_admin":false},"repo":{"id":40606038,"name":"junit","full_name":"mkeller/junit","owner":{"login":"mkeller","id":154496,"avatar_url":"https://avatars.githubusercontent.com/u/154496?v=3","gravatar_id":"","url":"https://api.github.com/users/mkeller","html_url":"https://github.com/mkeller","followers_url":"https://api.github.com/users/mkeller/followers","following_url":"https://api.github.com/users/mkeller/following{/other_user}","gists_url":"https://api.github.com/users/mkeller/gists{/gist_id}","starred_url":"https://api.github.com/users/mkeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkeller/subscriptions","organizations_url":"https://api.github.com/users/mkeller/orgs","repos_url":"https://api.github.com/users/mkeller/repos","events_url":"https://api.github.com/users/mkeller/events{/privacy}","received_events_url":"https://api.github.com/users/mkeller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkeller/junit","description":"A programmer-oriented testing framework for Java.","fork":true,"url":"https://api.github.com/repos/mkeller/junit","forks_url":"https://api.github.com/repos/mkeller/junit/forks","keys_url":"https://api.github.com/repos/mkeller/junit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkeller/junit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkeller/junit/teams","hooks_url":"https://api.github.com/repos/mkeller/junit/hooks","issue_events_url":"https://api.github.com/repos/mkeller/junit/issues/events{/number}","events_url":"https://api.github.com/repos/mkeller/junit/events","assignees_url":"https://api.github.com/repos/mkeller/junit/assignees{/user}","branches_url":"https://api.github.com/repos/mkeller/junit/branches{/branch}","tags_url":"https://api.github.com/repos/mkeller/junit/tags","blobs_url":"https://api.github.com/repos/mkeller/junit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkeller/junit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkeller/junit/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkeller/junit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkeller/junit/statuses/{sha}","languages_url":"https://api.github.com/repos/mkeller/junit/languages","stargazers_url":"https://api.github.com/repos/mkeller/junit/stargazers","contributors_url":"https://api.github.com/repos/mkeller/junit/contributors","subscribers_url":"https://api.github.com/repos/mkeller/junit/subscribers","subscription_url":"https://api.github.com/repos/mkeller/junit/subscription","commits_url":"https://api.github.com/repos/mkeller/junit/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkeller/junit/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkeller/junit/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkeller/junit/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkeller/junit/contents/{+path}","compare_url":"https://api.github.com/repos/mkeller/junit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkeller/junit/merges","archive_url":"https://api.github.com/repos/mkeller/junit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkeller/junit/downloads","issues_url":"https://api.github.com/repos/mkeller/junit/issues{/number}","pulls_url":"https://api.github.com/repos/mkeller/junit/pulls{/number}","milestones_url":"https://api.github.com/repos/mkeller/junit/milestones{/number}","notifications_url":"https://api.github.com/repos/mkeller/junit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkeller/junit/labels{/name}","releases_url":"https://api.github.com/repos/mkeller/junit/releases{/id}","created_at":"2015-08-12T14:45:19Z","updated_at":"2015-08-12T14:45:20Z","pushed_at":"2015-08-14T11:46:55Z","git_url":"git://github.com/mkeller/junit.git","ssh_url":"git@github.com:mkeller/junit.git","clone_url":"https://github.com/mkeller/junit.git","svn_url":"https://github.com/mkeller/junit","homepage":"","size":28652,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"junit-team:master","ref":"master","sha":"3e43555e1f4df95b0a239f453af6d3226a8fef6e","user":{"login":"junit-team","id":874086,"avatar_url":"https://avatars.githubusercontent.com/u/874086?v=3","gravatar_id":"","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"repo":{"id":106310,"name":"junit","full_name":"junit-team/junit","owner":{"login":"junit-team","id":874086,"avatar_url":"https://avatars.githubusercontent.com/u/874086?v=3","gravatar_id":"","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/junit-team/junit","description":"A programmer-oriented testing framework for Java.","fork":false,"url":"https://api.github.com/repos/junit-team/junit","forks_url":"https://api.github.com/repos/junit-team/junit/forks","keys_url":"https://api.github.com/repos/junit-team/junit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junit-team/junit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junit-team/junit/teams","hooks_url":"https://api.github.com/repos/junit-team/junit/hooks","issue_events_url":"https://api.github.com/repos/junit-team/junit/issues/events{/number}","events_url":"https://api.github.com/repos/junit-team/junit/events","assignees_url":"https://api.github.com/repos/junit-team/junit/assignees{/user}","branches_url":"https://api.github.com/repos/junit-team/junit/branches{/branch}","tags_url":"https://api.github.com/repos/junit-team/junit/tags","blobs_url":"https://api.github.com/repos/junit-team/junit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junit-team/junit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junit-team/junit/git/refs{/sha}","trees_url":"https://api.github.com/repos/junit-team/junit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junit-team/junit/statuses/{sha}","languages_url":"https://api.github.com/repos/junit-team/junit/languages","stargazers_url":"https://api.github.com/repos/junit-team/junit/stargazers","contributors_url":"https://api.github.com/repos/junit-team/junit/contributors","subscribers_url":"https://api.github.com/repos/junit-team/junit/subscribers","subscription_url":"https://api.github.com/repos/junit-team/junit/subscription","commits_url":"https://api.github.com/repos/junit-team/junit/commits{/sha}","git_commits_url":"https://api.github.com/repos/junit-team/junit/git/commits{/sha}","comments_url":"https://api.github.com/repos/junit-team/junit/comments{/number}","issue_comment_url":"https://api.github.com/repos/junit-team/junit/issues/comments{/number}","contents_url":"https://api.github.com/repos/junit-team/junit/contents/{+path}","compare_url":"https://api.github.com/repos/junit-team/junit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junit-team/junit/merges","archive_url":"https://api.github.com/repos/junit-team/junit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junit-team/junit/downloads","issues_url":"https://api.github.com/repos/junit-team/junit/issues{/number}","pulls_url":"https://api.github.com/repos/junit-team/junit/pulls{/number}","milestones_url":"https://api.github.com/repos/junit-team/junit/milestones{/number}","notifications_url":"https://api.github.com/repos/junit-team/junit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junit-team/junit/labels{/name}","releases_url":"https://api.github.com/repos/junit-team/junit/releases{/id}","created_at":"2009-01-13T03:41:26Z","updated_at":"2015-08-15T00:00:00Z","pushed_at":"2015-08-14T11:46:58Z","git_url":"git://github.com/junit-team/junit.git","ssh_url":"git@github.com:junit-team/junit.git","clone_url":"https://github.com/junit-team/junit.git","svn_url":"https://github.com/junit-team/junit","homepage":"","size":28652,"stargazers_count":3810,"watchers_count":3810,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1540,"mirror_url":null,"open_issues_count":145,"forks":1540,"open_issues":145,"watchers":3810,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit/pulls/1190"},"html":{"href":"https://github.com/junit-team/junit/pull/1190"},"issue":{"href":"https://api.github.com/repos/junit-team/junit/issues/1190"},"comments":{"href":"https://api.github.com/repos/junit-team/junit/issues/1190/comments"},"review_comments":{"href":"https://api.github.com/repos/junit-team/junit/pulls/1190/comments"},"review_comment":{"href":"https://api.github.com/repos/junit-team/junit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/junit-team/junit/pulls/1190/commits"},"statuses":{"href":"https://api.github.com/repos/junit-team/junit/statuses/085fab1fd50ec4994a6a1647c8fb99529fc03445"}}}}