{"action":"created","issue":{"url":"https://api.github.com/repos/aurelia/event-aggregator/issues/13","labels_url":"https://api.github.com/repos/aurelia/event-aggregator/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/aurelia/event-aggregator/issues/13/comments","events_url":"https://api.github.com/repos/aurelia/event-aggregator/issues/13/events","html_url":"https://github.com/aurelia/event-aggregator/pull/13","id":106376590,"number":13,"title":"Add typescript version of event aggregator","user":{"login":"ctoran","id":10962393,"avatar_url":"https://avatars.githubusercontent.com/u/10962393?v=3","gravatar_id":"","url":"https://api.github.com/users/ctoran","html_url":"https://github.com/ctoran","followers_url":"https://api.github.com/users/ctoran/followers","following_url":"https://api.github.com/users/ctoran/following{/other_user}","gists_url":"https://api.github.com/users/ctoran/gists{/gist_id}","starred_url":"https://api.github.com/users/ctoran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctoran/subscriptions","organizations_url":"https://api.github.com/users/ctoran/orgs","repos_url":"https://api.github.com/users/ctoran/repos","events_url":"https://api.github.com/users/ctoran/events{/privacy}","received_events_url":"https://api.github.com/users/ctoran/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":31,"created_at":"2015-09-14T16:16:17Z","updated_at":"2015-11-13T07:37:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aurelia/event-aggregator/pulls/13","html_url":"https://github.com/aurelia/event-aggregator/pull/13","diff_url":"https://github.com/aurelia/event-aggregator/pull/13.diff","patch_url":"https://github.com/aurelia/event-aggregator/pull/13.patch"},"body":"Generates more precise type declarations including:\r\n  - overloads for pub/sub methods\r\n  - type inference of the message using generics\r\n  - hides private class members\r\n \r\nBuild it with `gulp build`\r\n\r\nThis PR replaces the original ES6 event aggregator with the equivalent TypeScript code. The TS code is first compiled to ES6 using typescript and then to ES5 using babel for each module type. Also SourceMap is generated in outputs so you can step-through the source TS code in debugger while running an ES5 compilation.\r\n\r\nTo make it easier to review the change, just diff `index.ts` with the old `index.js` ([see here](https://github.com/ctoran/event-aggregator/commit/e2c435277206c999d8377cca99d578f6697f2c27#diff-f41e9d04a45c83f3b6f6e630f10117fe))."},"comment":{"url":"https://api.github.com/repos/aurelia/event-aggregator/issues/comments/156354642","html_url":"https://github.com/aurelia/event-aggregator/pull/13#issuecomment-156354642","issue_url":"https://api.github.com/repos/aurelia/event-aggregator/issues/13","id":156354642,"user":{"login":"atsu85","id":1206512,"avatar_url":"https://avatars.githubusercontent.com/u/1206512?v=3","gravatar_id":"","url":"https://api.github.com/users/atsu85","html_url":"https://github.com/atsu85","followers_url":"https://api.github.com/users/atsu85/followers","following_url":"https://api.github.com/users/atsu85/following{/other_user}","gists_url":"https://api.github.com/users/atsu85/gists{/gist_id}","starred_url":"https://api.github.com/users/atsu85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atsu85/subscriptions","organizations_url":"https://api.github.com/users/atsu85/orgs","repos_url":"https://api.github.com/users/atsu85/repos","events_url":"https://api.github.com/users/atsu85/events{/privacy}","received_events_url":"https://api.github.com/users/atsu85/received_events","type":"User","site_admin":false},"created_at":"2015-11-13T07:37:14Z","updated_at":"2015-11-13T07:37:14Z","body":"> FYI We aren't going to put this in to the Beta because that is only a few days away...\r\n\r\nmakes sense. \r\n\r\n@EisenbergEffect so by \"this\" You meant @ctoran's version (this pull request), not @Lakerfield's version, that also gained a lot attention in this pull request discussion? I'd expect @ctoran and @Lakerfield to review each-others changes and come up with the best solution they can collectively think of - probably both solutions could be improved, so as tempting as it seems to start using TS ASAP, it makes sense not to rush with it before beta."}}