{"action":"created","issue":{"url":"https://api.github.com/repos/mobify/pikabu/issues/47","labels_url":"https://api.github.com/repos/mobify/pikabu/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/mobify/pikabu/issues/47/comments","events_url":"https://api.github.com/repos/mobify/pikabu/issues/47/events","html_url":"https://github.com/mobify/pikabu/pull/47","id":60173634,"number":47,"title":"Handle device orientationchange event","user":{"login":"fractaltheory","id":1211726,"avatar_url":"https://avatars.githubusercontent.com/u/1211726?v=3","gravatar_id":"","url":"https://api.github.com/users/fractaltheory","html_url":"https://github.com/fractaltheory","followers_url":"https://api.github.com/users/fractaltheory/followers","following_url":"https://api.github.com/users/fractaltheory/following{/other_user}","gists_url":"https://api.github.com/users/fractaltheory/gists{/gist_id}","starred_url":"https://api.github.com/users/fractaltheory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fractaltheory/subscriptions","organizations_url":"https://api.github.com/users/fractaltheory/orgs","repos_url":"https://api.github.com/users/fractaltheory/repos","events_url":"https://api.github.com/users/fractaltheory/events{/privacy}","received_events_url":"https://api.github.com/users/fractaltheory/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-06T23:22:05Z","updated_at":"2015-03-06T23:51:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mobify/pikabu/pulls/47","html_url":"https://github.com/mobify/pikabu/pull/47","diff_url":"https://github.com/mobify/pikabu/pull/47.diff","patch_url":"https://github.com/mobify/pikabu/pull/47.patch"},"body":"When the device is rotated, the transform applied to .pikabu__container is not updated to reflect this.\r\n\r\nStatus: **Opened for visibility**\r\nReviewers: @kpeatt @scalvert\r\n\r\n## Changes\r\n- _buildEvents is updated with a new variable _this, to provide appropriate context for the orientationchange callback function\r\n- We check whether pikabu is currently open\r\n- Grab .pikabu's width, which is how much we'll be translating .pikabu__container\r\n- Apply the new translateX value to .pikabu__container\r\n\r\n## Notes\r\n- Not super happy about applying both transform and -webkit-transform --- open to suggestions there\r\n- Currently needed for JTV Mobile, where we're using Pikabu 2.0\r\n- Tested only on iOS Sim at the moment"},"comment":{"url":"https://api.github.com/repos/mobify/pikabu/issues/comments/77657649","html_url":"https://github.com/mobify/pikabu/pull/47#issuecomment-77657649","issue_url":"https://api.github.com/repos/mobify/pikabu/issues/47","id":77657649,"user":{"login":"kpeatt","id":447683,"avatar_url":"https://avatars.githubusercontent.com/u/447683?v=3","gravatar_id":"","url":"https://api.github.com/users/kpeatt","html_url":"https://github.com/kpeatt","followers_url":"https://api.github.com/users/kpeatt/followers","following_url":"https://api.github.com/users/kpeatt/following{/other_user}","gists_url":"https://api.github.com/users/kpeatt/gists{/gist_id}","starred_url":"https://api.github.com/users/kpeatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpeatt/subscriptions","organizations_url":"https://api.github.com/users/kpeatt/orgs","repos_url":"https://api.github.com/users/kpeatt/repos","events_url":"https://api.github.com/users/kpeatt/events{/privacy}","received_events_url":"https://api.github.com/users/kpeatt/received_events","type":"User","site_admin":false},"created_at":"2015-03-06T23:51:07Z","updated_at":"2015-03-06T23:51:07Z","body":"Just a note after our IRL conversation re: this bug. The issue is actually that we're setting a width on the main container and translate is working based off that width. This width is wrong on orientation change."}}