{"action":"created","comment":{"url":"https://api.github.com/repos/mperham/sidekiq/pulls/comments/46648459","id":46648459,"diff_hunk":"@@ -57,7 +57,7 @@ def perform_async(*args)\n       def perform_in(interval, *args)\n         int = interval.to_f\n         now = Time.now\n-        ts = (int < 1_000_000_000 ? (now + interval).to_f : int)\n+        ts = (int < 1_000_000_000 ? ((interval.is_a? String) ? now + int : now + interval).to_f : int)","path":"lib/sidekiq/worker.rb","position":5,"original_position":5,"commit_id":"c297391a843de25ed7dd3c185e38dbb1a89b14de","original_commit_id":"c297391a843de25ed7dd3c185e38dbb1a89b14de","user":{"login":"davydovanton","id":1147484,"avatar_url":"https://avatars.githubusercontent.com/u/1147484?v=3","gravatar_id":"","url":"https://api.github.com/users/davydovanton","html_url":"https://github.com/davydovanton","followers_url":"https://api.github.com/users/davydovanton/followers","following_url":"https://api.github.com/users/davydovanton/following{/other_user}","gists_url":"https://api.github.com/users/davydovanton/gists{/gist_id}","starred_url":"https://api.github.com/users/davydovanton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davydovanton/subscriptions","organizations_url":"https://api.github.com/users/davydovanton/orgs","repos_url":"https://api.github.com/users/davydovanton/repos","events_url":"https://api.github.com/users/davydovanton/events{/privacy}","received_events_url":"https://api.github.com/users/davydovanton/received_events","type":"User","site_admin":false},"body":"Maybe replace first ternary operator to separate variable for improving code  readability, what do you think? ","created_at":"2015-12-04T04:32:52Z","updated_at":"2015-12-04T04:32:52Z","html_url":"https://github.com/mperham/sidekiq/pull/2692#discussion_r46648459","pull_request_url":"https://api.github.com/repos/mperham/sidekiq/pulls/2692","_links":{"self":{"href":"https://api.github.com/repos/mperham/sidekiq/pulls/comments/46648459"},"html":{"href":"https://github.com/mperham/sidekiq/pull/2692#discussion_r46648459"},"pull_request":{"href":"https://api.github.com/repos/mperham/sidekiq/pulls/2692"}}},"pull_request":{"url":"https://api.github.com/repos/mperham/sidekiq/pulls/2692","id":52628793,"html_url":"https://github.com/mperham/sidekiq/pull/2692","diff_url":"https://github.com/mperham/sidekiq/pull/2692.diff","patch_url":"https://github.com/mperham/sidekiq/pull/2692.patch","issue_url":"https://api.github.com/repos/mperham/sidekiq/issues/2692","number":2692,"state":"open","locked":false,"title":"perform_in accepts strings for the interval","user":{"login":"selenetelenav","id":4967788,"avatar_url":"https://avatars.githubusercontent.com/u/4967788?v=3","gravatar_id":"","url":"https://api.github.com/users/selenetelenav","html_url":"https://github.com/selenetelenav","followers_url":"https://api.github.com/users/selenetelenav/followers","following_url":"https://api.github.com/users/selenetelenav/following{/other_user}","gists_url":"https://api.github.com/users/selenetelenav/gists{/gist_id}","starred_url":"https://api.github.com/users/selenetelenav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selenetelenav/subscriptions","organizations_url":"https://api.github.com/users/selenetelenav/orgs","repos_url":"https://api.github.com/users/selenetelenav/repos","events_url":"https://api.github.com/users/selenetelenav/events{/privacy}","received_events_url":"https://api.github.com/users/selenetelenav/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/mperham/sidekiq/issues/2691","created_at":"2015-12-04T04:25:43Z","updated_at":"2015-12-04T04:32:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3078c061fa317d2b88ed11b4416d3db94bbc82a6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mperham/sidekiq/pulls/2692/commits","review_comments_url":"https://api.github.com/repos/mperham/sidekiq/pulls/2692/comments","review_comment_url":"https://api.github.com/repos/mperham/sidekiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mperham/sidekiq/issues/2692/comments","statuses_url":"https://api.github.com/repos/mperham/sidekiq/statuses/c297391a843de25ed7dd3c185e38dbb1a89b14de","head":{"label":"selenetelenav:fix_perform_in_string","ref":"fix_perform_in_string","sha":"c297391a843de25ed7dd3c185e38dbb1a89b14de","user":{"login":"selenetelenav","id":4967788,"avatar_url":"https://avatars.githubusercontent.com/u/4967788?v=3","gravatar_id":"","url":"https://api.github.com/users/selenetelenav","html_url":"https://github.com/selenetelenav","followers_url":"https://api.github.com/users/selenetelenav/followers","following_url":"https://api.github.com/users/selenetelenav/following{/other_user}","gists_url":"https://api.github.com/users/selenetelenav/gists{/gist_id}","starred_url":"https://api.github.com/users/selenetelenav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selenetelenav/subscriptions","organizations_url":"https://api.github.com/users/selenetelenav/orgs","repos_url":"https://api.github.com/users/selenetelenav/repos","events_url":"https://api.github.com/users/selenetelenav/events{/privacy}","received_events_url":"https://api.github.com/users/selenetelenav/received_events","type":"User","site_admin":false},"repo":{"id":47379854,"name":"sidekiq","full_name":"selenetelenav/sidekiq","owner":{"login":"selenetelenav","id":4967788,"avatar_url":"https://avatars.githubusercontent.com/u/4967788?v=3","gravatar_id":"","url":"https://api.github.com/users/selenetelenav","html_url":"https://github.com/selenetelenav","followers_url":"https://api.github.com/users/selenetelenav/followers","following_url":"https://api.github.com/users/selenetelenav/following{/other_user}","gists_url":"https://api.github.com/users/selenetelenav/gists{/gist_id}","starred_url":"https://api.github.com/users/selenetelenav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selenetelenav/subscriptions","organizations_url":"https://api.github.com/users/selenetelenav/orgs","repos_url":"https://api.github.com/users/selenetelenav/repos","events_url":"https://api.github.com/users/selenetelenav/events{/privacy}","received_events_url":"https://api.github.com/users/selenetelenav/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/selenetelenav/sidekiq","description":"Simple, efficient background processing for Ruby","fork":true,"url":"https://api.github.com/repos/selenetelenav/sidekiq","forks_url":"https://api.github.com/repos/selenetelenav/sidekiq/forks","keys_url":"https://api.github.com/repos/selenetelenav/sidekiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/selenetelenav/sidekiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/selenetelenav/sidekiq/teams","hooks_url":"https://api.github.com/repos/selenetelenav/sidekiq/hooks","issue_events_url":"https://api.github.com/repos/selenetelenav/sidekiq/issues/events{/number}","events_url":"https://api.github.com/repos/selenetelenav/sidekiq/events","assignees_url":"https://api.github.com/repos/selenetelenav/sidekiq/assignees{/user}","branches_url":"https://api.github.com/repos/selenetelenav/sidekiq/branches{/branch}","tags_url":"https://api.github.com/repos/selenetelenav/sidekiq/tags","blobs_url":"https://api.github.com/repos/selenetelenav/sidekiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/selenetelenav/sidekiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/selenetelenav/sidekiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/selenetelenav/sidekiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/selenetelenav/sidekiq/statuses/{sha}","languages_url":"https://api.github.com/repos/selenetelenav/sidekiq/languages","stargazers_url":"https://api.github.com/repos/selenetelenav/sidekiq/stargazers","contributors_url":"https://api.github.com/repos/selenetelenav/sidekiq/contributors","subscribers_url":"https://api.github.com/repos/selenetelenav/sidekiq/subscribers","subscription_url":"https://api.github.com/repos/selenetelenav/sidekiq/subscription","commits_url":"https://api.github.com/repos/selenetelenav/sidekiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/selenetelenav/sidekiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/selenetelenav/sidekiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/selenetelenav/sidekiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/selenetelenav/sidekiq/contents/{+path}","compare_url":"https://api.github.com/repos/selenetelenav/sidekiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/selenetelenav/sidekiq/merges","archive_url":"https://api.github.com/repos/selenetelenav/sidekiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/selenetelenav/sidekiq/downloads","issues_url":"https://api.github.com/repos/selenetelenav/sidekiq/issues{/number}","pulls_url":"https://api.github.com/repos/selenetelenav/sidekiq/pulls{/number}","milestones_url":"https://api.github.com/repos/selenetelenav/sidekiq/milestones{/number}","notifications_url":"https://api.github.com/repos/selenetelenav/sidekiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/selenetelenav/sidekiq/labels{/name}","releases_url":"https://api.github.com/repos/selenetelenav/sidekiq/releases{/id}","created_at":"2015-12-04T03:55:47Z","updated_at":"2015-12-04T03:55:49Z","pushed_at":"2015-12-04T04:25:21Z","git_url":"git://github.com/selenetelenav/sidekiq.git","ssh_url":"git@github.com:selenetelenav/sidekiq.git","clone_url":"https://github.com/selenetelenav/sidekiq.git","svn_url":"https://github.com/selenetelenav/sidekiq","homepage":"http://sidekiq.org","size":8238,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mperham:master","ref":"master","sha":"98aa23e4aeb5cb073308c17114271124598d3524","user":{"login":"mperham","id":2911,"avatar_url":"https://avatars.githubusercontent.com/u/2911?v=3","gravatar_id":"","url":"https://api.github.com/users/mperham","html_url":"https://github.com/mperham","followers_url":"https://api.github.com/users/mperham/followers","following_url":"https://api.github.com/users/mperham/following{/other_user}","gists_url":"https://api.github.com/users/mperham/gists{/gist_id}","starred_url":"https://api.github.com/users/mperham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mperham/subscriptions","organizations_url":"https://api.github.com/users/mperham/orgs","repos_url":"https://api.github.com/users/mperham/repos","events_url":"https://api.github.com/users/mperham/events{/privacy}","received_events_url":"https://api.github.com/users/mperham/received_events","type":"User","site_admin":false},"repo":{"id":3195124,"name":"sidekiq","full_name":"mperham/sidekiq","owner":{"login":"mperham","id":2911,"avatar_url":"https://avatars.githubusercontent.com/u/2911?v=3","gravatar_id":"","url":"https://api.github.com/users/mperham","html_url":"https://github.com/mperham","followers_url":"https://api.github.com/users/mperham/followers","following_url":"https://api.github.com/users/mperham/following{/other_user}","gists_url":"https://api.github.com/users/mperham/gists{/gist_id}","starred_url":"https://api.github.com/users/mperham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mperham/subscriptions","organizations_url":"https://api.github.com/users/mperham/orgs","repos_url":"https://api.github.com/users/mperham/repos","events_url":"https://api.github.com/users/mperham/events{/privacy}","received_events_url":"https://api.github.com/users/mperham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mperham/sidekiq","description":"Simple, efficient background processing for Ruby","fork":false,"url":"https://api.github.com/repos/mperham/sidekiq","forks_url":"https://api.github.com/repos/mperham/sidekiq/forks","keys_url":"https://api.github.com/repos/mperham/sidekiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mperham/sidekiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mperham/sidekiq/teams","hooks_url":"https://api.github.com/repos/mperham/sidekiq/hooks","issue_events_url":"https://api.github.com/repos/mperham/sidekiq/issues/events{/number}","events_url":"https://api.github.com/repos/mperham/sidekiq/events","assignees_url":"https://api.github.com/repos/mperham/sidekiq/assignees{/user}","branches_url":"https://api.github.com/repos/mperham/sidekiq/branches{/branch}","tags_url":"https://api.github.com/repos/mperham/sidekiq/tags","blobs_url":"https://api.github.com/repos/mperham/sidekiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mperham/sidekiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mperham/sidekiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/mperham/sidekiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mperham/sidekiq/statuses/{sha}","languages_url":"https://api.github.com/repos/mperham/sidekiq/languages","stargazers_url":"https://api.github.com/repos/mperham/sidekiq/stargazers","contributors_url":"https://api.github.com/repos/mperham/sidekiq/contributors","subscribers_url":"https://api.github.com/repos/mperham/sidekiq/subscribers","subscription_url":"https://api.github.com/repos/mperham/sidekiq/subscription","commits_url":"https://api.github.com/repos/mperham/sidekiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/mperham/sidekiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/mperham/sidekiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/mperham/sidekiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/mperham/sidekiq/contents/{+path}","compare_url":"https://api.github.com/repos/mperham/sidekiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mperham/sidekiq/merges","archive_url":"https://api.github.com/repos/mperham/sidekiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mperham/sidekiq/downloads","issues_url":"https://api.github.com/repos/mperham/sidekiq/issues{/number}","pulls_url":"https://api.github.com/repos/mperham/sidekiq/pulls{/number}","milestones_url":"https://api.github.com/repos/mperham/sidekiq/milestones{/number}","notifications_url":"https://api.github.com/repos/mperham/sidekiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mperham/sidekiq/labels{/name}","releases_url":"https://api.github.com/repos/mperham/sidekiq/releases{/id}","created_at":"2012-01-16T23:17:27Z","updated_at":"2015-12-03T12:45:51Z","pushed_at":"2015-12-04T04:25:43Z","git_url":"git://github.com/mperham/sidekiq.git","ssh_url":"git@github.com:mperham/sidekiq.git","clone_url":"https://github.com/mperham/sidekiq.git","svn_url":"https://github.com/mperham/sidekiq","homepage":"http://sidekiq.org","size":9496,"stargazers_count":5760,"watchers_count":5760,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":982,"mirror_url":null,"open_issues_count":24,"forks":982,"open_issues":24,"watchers":5760,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mperham/sidekiq/pulls/2692"},"html":{"href":"https://github.com/mperham/sidekiq/pull/2692"},"issue":{"href":"https://api.github.com/repos/mperham/sidekiq/issues/2692"},"comments":{"href":"https://api.github.com/repos/mperham/sidekiq/issues/2692/comments"},"review_comments":{"href":"https://api.github.com/repos/mperham/sidekiq/pulls/2692/comments"},"review_comment":{"href":"https://api.github.com/repos/mperham/sidekiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mperham/sidekiq/pulls/2692/commits"},"statuses":{"href":"https://api.github.com/repos/mperham/sidekiq/statuses/c297391a843de25ed7dd3c185e38dbb1a89b14de"}}}}