{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/25623715","id":25623715,"diff_hunk":"@@ -27,7 +27,9 @@ def openstack_handle(options = {})\n       raise \"no credentials defined\" if self.missing_credentials?(options[:auth_type])\n \n       username = options[:user] || self.authentication_userid(options[:auth_type])\n-      password = options[:pass] || self.authentication_password(options[:auth_type])\n+\n+      # the |\"\" is here to prevent an unhelpful ArgumentError from OpenStackHandle::Handle#connect\n+      password = options[:pass] || self.authentication_password(options[:auth_type]) || \"\"","path":"vmdb/app/models/mixins/ems_openstack_mixin.rb","position":7,"original_position":7,"commit_id":"104e06b6744572534219981ea584c8cccfb14482","original_commit_id":"104e06b6744572534219981ea584c8cccfb14482","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"body":"Although @blomquisg I think @Fryguy @roliveri did something with amazon with authentication classes for kinds that don't need userid.  I think this is in the same area of what we're saying here.  \r\n\r\nEither way, I think the provider should say what type of authentication they need (requires userid and password, only userid, some other value) and authentications should support those types...\r\n\r\nI think?  I still don't know what to do with code that did .blank? since password is blank for both \"\" and nil.\r\n\r\nwhat do you think?","created_at":"2015-03-02T18:32:02Z","updated_at":"2015-03-02T18:32:02Z","html_url":"https://github.com/ManageIQ/manageiq/pull/1937#discussion_r25623715","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1937","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/25623715"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/1937#discussion_r25623715"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1937"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1937","id":30287630,"html_url":"https://github.com/ManageIQ/manageiq/pull/1937","diff_url":"https://github.com/ManageIQ/manageiq/pull/1937.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/1937.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1937","number":1937,"state":"open","locked":false,"title":"Fix unhelpful \"Unexpected response\" toast when verifying new cloud provider and password empty","user":{"login":"himdel","id":289743,"avatar_url":"https://avatars.githubusercontent.com/u/289743?v=3","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"body":"Only affects the cloud providers (and openstack in infra), the rest of infra providers pass on the actual exception message\r\n\r\nFor Amazon, there's a MissingCredentials exception so we're explicitly catching that one\r\n\r\nFor OpenStack, OpenStackHandle::Handle#connect throws a rather unhelpful ArgumentError when the password is nil, but not when empty, so ||ing an empty string\r\n\r\nAlso added a Timeout rescue for OpenStack\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1083773","created_at":"2015-03-02T14:36:42Z","updated_at":"2015-03-02T18:32:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c33558dd0a280bf28d018c4a7249198ed87b6a6e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1937/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1937/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1937/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/104e06b6744572534219981ea584c8cccfb14482","head":{"label":"himdel:bz1083773","ref":"bz1083773","sha":"104e06b6744572534219981ea584c8cccfb14482","user":{"login":"himdel","id":289743,"avatar_url":"https://avatars.githubusercontent.com/u/289743?v=3","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"repo":{"id":30235491,"name":"manageiq","full_name":"himdel/manageiq","owner":{"login":"himdel","id":289743,"avatar_url":"https://avatars.githubusercontent.com/u/289743?v=3","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/himdel/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/himdel/manageiq","forks_url":"https://api.github.com/repos/himdel/manageiq/forks","keys_url":"https://api.github.com/repos/himdel/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/himdel/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/himdel/manageiq/teams","hooks_url":"https://api.github.com/repos/himdel/manageiq/hooks","issue_events_url":"https://api.github.com/repos/himdel/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/himdel/manageiq/events","assignees_url":"https://api.github.com/repos/himdel/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/himdel/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/himdel/manageiq/tags","blobs_url":"https://api.github.com/repos/himdel/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/himdel/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/himdel/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/himdel/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/himdel/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/himdel/manageiq/languages","stargazers_url":"https://api.github.com/repos/himdel/manageiq/stargazers","contributors_url":"https://api.github.com/repos/himdel/manageiq/contributors","subscribers_url":"https://api.github.com/repos/himdel/manageiq/subscribers","subscription_url":"https://api.github.com/repos/himdel/manageiq/subscription","commits_url":"https://api.github.com/repos/himdel/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/himdel/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/himdel/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/himdel/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/himdel/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/himdel/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/himdel/manageiq/merges","archive_url":"https://api.github.com/repos/himdel/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/himdel/manageiq/downloads","issues_url":"https://api.github.com/repos/himdel/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/himdel/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/himdel/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/himdel/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/himdel/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/himdel/manageiq/releases{/id}","created_at":"2015-02-03T09:36:54Z","updated_at":"2015-03-02T10:54:37Z","pushed_at":"2015-03-02T14:35:43Z","git_url":"git://github.com/himdel/manageiq.git","ssh_url":"git@github.com:himdel/manageiq.git","clone_url":"https://github.com/himdel/manageiq.git","svn_url":"https://github.com/himdel/manageiq","homepage":"manageiq.org","size":64381,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"9a5230be77e0982b6995cef8f5749da5c159bfa9","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-03-02T18:01:15Z","pushed_at":"2015-03-02T18:01:14Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":102527,"stargazers_count":92,"watchers_count":92,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":90,"mirror_url":null,"open_issues_count":272,"forks":90,"open_issues":272,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1937"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/1937"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/1937"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/1937/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1937/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1937/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/104e06b6744572534219981ea584c8cccfb14482"}}}}