{"action":"created","issue":{"url":"https://api.github.com/repos/darcymason/pydicom/issues/125","labels_url":"https://api.github.com/repos/darcymason/pydicom/issues/125/labels{/name}","comments_url":"https://api.github.com/repos/darcymason/pydicom/issues/125/comments","events_url":"https://api.github.com/repos/darcymason/pydicom/issues/125/events","html_url":"https://github.com/darcymason/pydicom/issues/125","id":50244052,"number":125,"title":"UID from dicom.UID.generate_uid() may not be unique if called twice in rapid succession","user":{"login":"darcymason","id":61110,"avatar_url":"https://avatars.githubusercontent.com/u/61110?v=3","gravatar_id":"","url":"https://api.github.com/users/darcymason","html_url":"https://github.com/darcymason","followers_url":"https://api.github.com/users/darcymason/followers","following_url":"https://api.github.com/users/darcymason/following{/other_user}","gists_url":"https://api.github.com/users/darcymason/gists{/gist_id}","starred_url":"https://api.github.com/users/darcymason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darcymason/subscriptions","organizations_url":"https://api.github.com/users/darcymason/orgs","repos_url":"https://api.github.com/users/darcymason/repos","events_url":"https://api.github.com/users/darcymason/events{/privacy}","received_events_url":"https://api.github.com/users/darcymason/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/darcymason/pydicom/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/darcymason/pydicom/labels/Difficulty-Medium","name":"Difficulty-Medium","color":"FFFFFF"},{"url":"https://api.github.com/repos/darcymason/pydicom/labels/imported","name":"imported","color":"FFFFFF"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2014-11-27T01:13:17Z","updated_at":"2015-02-10T02:53:32Z","closed_at":null,"body":"_From [jog...@gmail.com](https://code.google.com/u/115363881082924836416/) on April 02, 2013 09:25:43_\n\nWhat steps will reproduce the problem? 1. Call dicom.UID.generate_uid() twice in two subsequent calls What is the expected output? What do you see instead? - I expect that uids are different. What I see, is that the UIDs may actually be identical. What version of the product are you using? - pydicom 0.9.8 ***NOTE***: any text or attached files posted with the issue can be viewed by anyone. You are solely responsible to ensure that they contain no confidential information of any kind. Please provide any additional information below. - The dicom.UID.generate_uid() should include some kind of counter that is incremented between successive calls.\n\n_Original issue: http://code.google.com/p/pydicom/issues/detail?id=124_"},"comment":{"url":"https://api.github.com/repos/darcymason/pydicom/issues/comments/73635719","html_url":"https://github.com/darcymason/pydicom/issues/125#issuecomment-73635719","issue_url":"https://api.github.com/repos/darcymason/pydicom/issues/125","id":73635719,"user":{"login":"cancan101","id":51059,"avatar_url":"https://avatars.githubusercontent.com/u/51059?v=3","gravatar_id":"","url":"https://api.github.com/users/cancan101","html_url":"https://github.com/cancan101","followers_url":"https://api.github.com/users/cancan101/followers","following_url":"https://api.github.com/users/cancan101/following{/other_user}","gists_url":"https://api.github.com/users/cancan101/gists{/gist_id}","starred_url":"https://api.github.com/users/cancan101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cancan101/subscriptions","organizations_url":"https://api.github.com/users/cancan101/orgs","repos_url":"https://api.github.com/users/cancan101/repos","events_url":"https://api.github.com/users/cancan101/events{/privacy}","received_events_url":"https://api.github.com/users/cancan101/received_events","type":"User","site_admin":false},"created_at":"2015-02-10T02:53:32Z","updated_at":"2015-02-10T02:53:32Z","body":"The approach is overly complicated for no apparent benefit.\r\n\r\nOn one hand you are talking about counting bits of entropy and then on the other saying \"we don't need our randomness to be cryptographically secure\".\r\n\r\nYou should NOT be using `random.random` to generate `uuids`. At most it has `53-bit` of entropy but in reality it has `0`. \r\n\r\nThere are exiting libraries in place to effectively generate UUIDs. Why create your own?"}}