{"action":"created","issue":{"url":"https://api.github.com/repos/systemjs/builder/issues/193","labels_url":"https://api.github.com/repos/systemjs/builder/issues/193/labels{/name}","comments_url":"https://api.github.com/repos/systemjs/builder/issues/193/comments","events_url":"https://api.github.com/repos/systemjs/builder/issues/193/events","html_url":"https://github.com/systemjs/builder/pull/193","id":86776195,"number":193,"title":"extract concatOutputs from compileOutputs and export this and compileLoad.","user":{"login":"ohjames","id":97685,"avatar_url":"https://avatars.githubusercontent.com/u/97685?v=3","gravatar_id":"","url":"https://api.github.com/users/ohjames","html_url":"https://github.com/ohjames","followers_url":"https://api.github.com/users/ohjames/followers","following_url":"https://api.github.com/users/ohjames/following{/other_user}","gists_url":"https://api.github.com/users/ohjames/gists{/gist_id}","starred_url":"https://api.github.com/users/ohjames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohjames/subscriptions","organizations_url":"https://api.github.com/users/ohjames/orgs","repos_url":"https://api.github.com/users/ohjames/repos","events_url":"https://api.github.com/users/ohjames/events{/privacy}","received_events_url":"https://api.github.com/users/ohjames/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-10T00:03:27Z","updated_at":"2015-06-10T09:50:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/systemjs/builder/pulls/193","html_url":"https://github.com/systemjs/builder/pull/193","diff_url":"https://github.com/systemjs/builder/pull/193.diff","patch_url":"https://github.com/systemjs/builder/pull/193.patch"},"body":"As you suggested in https://github.com/systemjs/builder/issues/163 took a while to implement as Splatoon was really good.\r\n\r\nWould be good to get some feedback. The test commands weren't working for me, you can see I tried to fix it in the second commit. The pages loaded in the browser didn't seem to be working though (with the untouched master), unless I'm supposed to be looking at one blank page and one blank page with a title. I made sure the `test/output/sfx.js` didn't differ from the unmodified code though."},"comment":{"url":"https://api.github.com/repos/systemjs/builder/issues/comments/110675590","html_url":"https://github.com/systemjs/builder/pull/193#issuecomment-110675590","issue_url":"https://api.github.com/repos/systemjs/builder/issues/193","id":110675590,"user":{"login":"guybedford","id":598730,"avatar_url":"https://avatars.githubusercontent.com/u/598730?v=3","gravatar_id":"","url":"https://api.github.com/users/guybedford","html_url":"https://github.com/guybedford","followers_url":"https://api.github.com/users/guybedford/followers","following_url":"https://api.github.com/users/guybedford/following{/other_user}","gists_url":"https://api.github.com/users/guybedford/gists{/gist_id}","starred_url":"https://api.github.com/users/guybedford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guybedford/subscriptions","organizations_url":"https://api.github.com/users/guybedford/orgs","repos_url":"https://api.github.com/users/guybedford/repos","events_url":"https://api.github.com/users/guybedford/events{/privacy}","received_events_url":"https://api.github.com/users/guybedford/received_events","type":"User","site_admin":false},"created_at":"2015-06-10T09:50:51Z","updated_at":"2015-06-10T09:50:51Z","body":"Yes the tests do need some love. Thanks for the attempt here!\r\n\r\n* sfxEntryPoints and plugins don't need to be inputs to compileLoad\r\n* Also compileLoad only creates a single output object, so we shouldn't need to loop and form any ouputs array, it should just be as simple as looking up the format and using that compiler."}}