{"action":"created","issue":{"url":"https://api.github.com/repos/hummingbird-me/hummingbird/issues/385","labels_url":"https://api.github.com/repos/hummingbird-me/hummingbird/issues/385/labels{/name}","comments_url":"https://api.github.com/repos/hummingbird-me/hummingbird/issues/385/comments","events_url":"https://api.github.com/repos/hummingbird-me/hummingbird/issues/385/events","html_url":"https://github.com/hummingbird-me/hummingbird/issues/385","id":54982971,"number":385,"title":"Refactor global instant search","user":{"login":"cybrox","id":2383736,"avatar_url":"https://avatars.githubusercontent.com/u/2383736?v=3","gravatar_id":"","url":"https://api.github.com/users/cybrox","html_url":"https://github.com/cybrox","followers_url":"https://api.github.com/users/cybrox/followers","following_url":"https://api.github.com/users/cybrox/following{/other_user}","gists_url":"https://api.github.com/users/cybrox/gists{/gist_id}","starred_url":"https://api.github.com/users/cybrox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cybrox/subscriptions","organizations_url":"https://api.github.com/users/cybrox/orgs","repos_url":"https://api.github.com/users/cybrox/repos","events_url":"https://api.github.com/users/cybrox/events{/privacy}","received_events_url":"https://api.github.com/users/cybrox/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hummingbird-me/hummingbird/labels/medium%21","name":"medium!","color":"eb6420"},{"url":"https://api.github.com/repos/hummingbird-me/hummingbird/labels/refactoring","name":"refactoring","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-21T06:31:53Z","updated_at":"2015-01-21T06:35:23Z","closed_at":null,"body":"We have multiple components that implement the instant search in different form, that is `favorite-search`, that will filter after a certain list, `instant-search` for the header that implements the form focus/blur event and one in the search controller.\r\n\r\nI did not want to take on refactoring all of these out when building the new favorite system, so I just created the favorite-search component but the instant search itself should definitely be refactored before it's used in other places (feed tagging for example)\r\n\r\nKeeping favorite-search or instant-search (header-search) in a component per-se is not a problem, since this is the best way to go but we need to **break out the actual instant seach in a new parameterized component**.\r\n\r\nArguments include:\r\n- Favorite endpoint (we need to add a search endpoint that works the same for all media types!)\r\n- Entries limit (optionally page param for the api)\r\n- The given search term\r\n\r\nComponent will trigger\r\n- *listUpdate* event after Bloodhound fetched the new results with an array of data"},"comment":{"url":"https://api.github.com/repos/hummingbird-me/hummingbird/issues/comments/70791166","html_url":"https://github.com/hummingbird-me/hummingbird/issues/385#issuecomment-70791166","issue_url":"https://api.github.com/repos/hummingbird-me/hummingbird/issues/385","id":70791166,"user":{"login":"NuckChorris","id":430411,"avatar_url":"https://avatars.githubusercontent.com/u/430411?v=3","gravatar_id":"","url":"https://api.github.com/users/NuckChorris","html_url":"https://github.com/NuckChorris","followers_url":"https://api.github.com/users/NuckChorris/followers","following_url":"https://api.github.com/users/NuckChorris/following{/other_user}","gists_url":"https://api.github.com/users/NuckChorris/gists{/gist_id}","starred_url":"https://api.github.com/users/NuckChorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuckChorris/subscriptions","organizations_url":"https://api.github.com/users/NuckChorris/orgs","repos_url":"https://api.github.com/users/NuckChorris/repos","events_url":"https://api.github.com/users/NuckChorris/events{/privacy}","received_events_url":"https://api.github.com/users/NuckChorris/received_events","type":"User","site_admin":false},"created_at":"2015-01-21T06:35:23Z","updated_at":"2015-01-21T06:35:23Z","body":"Also relevant is the search for waifu\r\n\r\nOn Tue, Jan 20, 2015 at 10:31 PM, Sven Gehring <notifications@github.com>\r\nwrote:\r\n\r\n> We have multiple components that implement the instant search in different form, that is `favorite-search`, that will filter after a certain list, `instant-search` for the header that implements the form focus/blur event and one in the search controller.\r\n> I did not want to take on refactoring all of these out when building the new favorite system, so I just created the favorite-search component but the instant search itself should definitely be refactored before it's used in other places (feed tagging for example)\r\n> Keeping favorite-search or instant-search (header-search) in a component per-se is not a problem, since this is the best way to go but we need to **break out the actual instant seach in a new parameterized component**.\r\n> Arguments include:\r\n> - Favorite endpoint (we need to add a search endpoint that works the same for all media types!)\r\n> - Entries limit (optionally page param for the api)\r\n> - The given search term\r\n> Component will trigger\r\n> - *listUpdate* event after Bloodhound fetched the new results with an array of data\r\n> ---\r\n> Reply to this email directly or view it on GitHub:\r\n> https://github.com/hummingbird-me/hummingbird/issues/385"}}