{"action":"created","comment":{"url":"https://api.github.com/repos/projectcalico/libcalico/pulls/comments/36567484","id":36567484,"diff_hunk":"@@ -112,12 +117,17 @@ def unassign_address(self, pool, address):\n         Unassign an IP from a pool.\n \n         :param IPPool or IPNetwork pool: The pool that the assignment is from.\n+        If the pool is None, get the pool from datastore\n         :param IPAddress address: The address to unassign.\n-\n         :return: True if the address was unassigned, false otherwise. An\n         exception is thrown for any error conditions.\n         :rtype: bool\n         \"\"\"\n+        pool = pool or self.get_pool(address)","path":"calico_containers/pycalico/ipam.py","position":30,"original_position":30,"commit_id":"53c5f33a93f7b2c50aa2d114eb017edba5f7f978","original_commit_id":"53c5f33a93f7b2c50aa2d114eb017edba5f7f978","user":{"login":"spikecurtis","id":5375600,"avatar_url":"https://avatars.githubusercontent.com/u/5375600?v=3","gravatar_id":"","url":"https://api.github.com/users/spikecurtis","html_url":"https://github.com/spikecurtis","followers_url":"https://api.github.com/users/spikecurtis/followers","following_url":"https://api.github.com/users/spikecurtis/following{/other_user}","gists_url":"https://api.github.com/users/spikecurtis/gists{/gist_id}","starred_url":"https://api.github.com/users/spikecurtis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spikecurtis/subscriptions","organizations_url":"https://api.github.com/users/spikecurtis/orgs","repos_url":"https://api.github.com/users/spikecurtis/repos","events_url":"https://api.github.com/users/spikecurtis/events{/privacy}","received_events_url":"https://api.github.com/users/spikecurtis/received_events","type":"User","site_admin":false},"body":"I'm reworking all this stuff so that we won't have overlapping pools.","created_at":"2015-08-07T22:37:10Z","updated_at":"2015-08-07T22:37:10Z","html_url":"https://github.com/projectcalico/libcalico/pull/8#discussion_r36567484","pull_request_url":"https://api.github.com/repos/projectcalico/libcalico/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/projectcalico/libcalico/pulls/comments/36567484"},"html":{"href":"https://github.com/projectcalico/libcalico/pull/8#discussion_r36567484"},"pull_request":{"href":"https://api.github.com/repos/projectcalico/libcalico/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/projectcalico/libcalico/pulls/8","id":41848570,"html_url":"https://github.com/projectcalico/libcalico/pull/8","diff_url":"https://github.com/projectcalico/libcalico/pull/8.diff","patch_url":"https://github.com/projectcalico/libcalico/pull/8.patch","issue_url":"https://api.github.com/repos/projectcalico/libcalico/issues/8","number":8,"state":"open","locked":false,"title":"Add methods used by container_add/container_remove","user":{"login":"L-MA","id":9704719,"avatar_url":"https://avatars.githubusercontent.com/u/9704719?v=3","gravatar_id":"","url":"https://api.github.com/users/L-MA","html_url":"https://github.com/L-MA","followers_url":"https://api.github.com/users/L-MA/followers","following_url":"https://api.github.com/users/L-MA/following{/other_user}","gists_url":"https://api.github.com/users/L-MA/gists{/gist_id}","starred_url":"https://api.github.com/users/L-MA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/L-MA/subscriptions","organizations_url":"https://api.github.com/users/L-MA/orgs","repos_url":"https://api.github.com/users/L-MA/repos","events_url":"https://api.github.com/users/L-MA/events{/privacy}","received_events_url":"https://api.github.com/users/L-MA/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-07T00:10:23Z","updated_at":"2015-08-07T22:37:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2547d6b1e4540e2f8d434bfb0836d98a9e62e5f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projectcalico/libcalico/pulls/8/commits","review_comments_url":"https://api.github.com/repos/projectcalico/libcalico/pulls/8/comments","review_comment_url":"https://api.github.com/repos/projectcalico/libcalico/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectcalico/libcalico/issues/8/comments","statuses_url":"https://api.github.com/repos/projectcalico/libcalico/statuses/53c5f33a93f7b2c50aa2d114eb017edba5f7f978","head":{"label":"L-MA:lma-methods-for-container-add","ref":"lma-methods-for-container-add","sha":"53c5f33a93f7b2c50aa2d114eb017edba5f7f978","user":{"login":"L-MA","id":9704719,"avatar_url":"https://avatars.githubusercontent.com/u/9704719?v=3","gravatar_id":"","url":"https://api.github.com/users/L-MA","html_url":"https://github.com/L-MA","followers_url":"https://api.github.com/users/L-MA/followers","following_url":"https://api.github.com/users/L-MA/following{/other_user}","gists_url":"https://api.github.com/users/L-MA/gists{/gist_id}","starred_url":"https://api.github.com/users/L-MA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/L-MA/subscriptions","organizations_url":"https://api.github.com/users/L-MA/orgs","repos_url":"https://api.github.com/users/L-MA/repos","events_url":"https://api.github.com/users/L-MA/events{/privacy}","received_events_url":"https://api.github.com/users/L-MA/received_events","type":"User","site_admin":false},"repo":{"id":40022882,"name":"libcalico","full_name":"L-MA/libcalico","owner":{"login":"L-MA","id":9704719,"avatar_url":"https://avatars.githubusercontent.com/u/9704719?v=3","gravatar_id":"","url":"https://api.github.com/users/L-MA","html_url":"https://github.com/L-MA","followers_url":"https://api.github.com/users/L-MA/followers","following_url":"https://api.github.com/users/L-MA/following{/other_user}","gists_url":"https://api.github.com/users/L-MA/gists{/gist_id}","starred_url":"https://api.github.com/users/L-MA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/L-MA/subscriptions","organizations_url":"https://api.github.com/users/L-MA/orgs","repos_url":"https://api.github.com/users/L-MA/repos","events_url":"https://api.github.com/users/L-MA/events{/privacy}","received_events_url":"https://api.github.com/users/L-MA/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/L-MA/libcalico","description":"","fork":true,"url":"https://api.github.com/repos/L-MA/libcalico","forks_url":"https://api.github.com/repos/L-MA/libcalico/forks","keys_url":"https://api.github.com/repos/L-MA/libcalico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/L-MA/libcalico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/L-MA/libcalico/teams","hooks_url":"https://api.github.com/repos/L-MA/libcalico/hooks","issue_events_url":"https://api.github.com/repos/L-MA/libcalico/issues/events{/number}","events_url":"https://api.github.com/repos/L-MA/libcalico/events","assignees_url":"https://api.github.com/repos/L-MA/libcalico/assignees{/user}","branches_url":"https://api.github.com/repos/L-MA/libcalico/branches{/branch}","tags_url":"https://api.github.com/repos/L-MA/libcalico/tags","blobs_url":"https://api.github.com/repos/L-MA/libcalico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/L-MA/libcalico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/L-MA/libcalico/git/refs{/sha}","trees_url":"https://api.github.com/repos/L-MA/libcalico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/L-MA/libcalico/statuses/{sha}","languages_url":"https://api.github.com/repos/L-MA/libcalico/languages","stargazers_url":"https://api.github.com/repos/L-MA/libcalico/stargazers","contributors_url":"https://api.github.com/repos/L-MA/libcalico/contributors","subscribers_url":"https://api.github.com/repos/L-MA/libcalico/subscribers","subscription_url":"https://api.github.com/repos/L-MA/libcalico/subscription","commits_url":"https://api.github.com/repos/L-MA/libcalico/commits{/sha}","git_commits_url":"https://api.github.com/repos/L-MA/libcalico/git/commits{/sha}","comments_url":"https://api.github.com/repos/L-MA/libcalico/comments{/number}","issue_comment_url":"https://api.github.com/repos/L-MA/libcalico/issues/comments{/number}","contents_url":"https://api.github.com/repos/L-MA/libcalico/contents/{+path}","compare_url":"https://api.github.com/repos/L-MA/libcalico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/L-MA/libcalico/merges","archive_url":"https://api.github.com/repos/L-MA/libcalico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/L-MA/libcalico/downloads","issues_url":"https://api.github.com/repos/L-MA/libcalico/issues{/number}","pulls_url":"https://api.github.com/repos/L-MA/libcalico/pulls{/number}","milestones_url":"https://api.github.com/repos/L-MA/libcalico/milestones{/number}","notifications_url":"https://api.github.com/repos/L-MA/libcalico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/L-MA/libcalico/labels{/name}","releases_url":"https://api.github.com/repos/L-MA/libcalico/releases{/id}","created_at":"2015-07-31T20:07:34Z","updated_at":"2015-07-31T20:07:34Z","pushed_at":"2015-08-07T17:18:52Z","git_url":"git://github.com/L-MA/libcalico.git","ssh_url":"git@github.com:L-MA/libcalico.git","clone_url":"https://github.com/L-MA/libcalico.git","svn_url":"https://github.com/L-MA/libcalico","homepage":"http://www.projectcalico.org/","size":1576,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectcalico:master","ref":"master","sha":"d5b7cf7dca5f072aa2d66628e78fcc8048eb7f38","user":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"repo":{"id":39856396,"name":"libcalico","full_name":"projectcalico/libcalico","owner":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectcalico/libcalico","description":"","fork":false,"url":"https://api.github.com/repos/projectcalico/libcalico","forks_url":"https://api.github.com/repos/projectcalico/libcalico/forks","keys_url":"https://api.github.com/repos/projectcalico/libcalico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcalico/libcalico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcalico/libcalico/teams","hooks_url":"https://api.github.com/repos/projectcalico/libcalico/hooks","issue_events_url":"https://api.github.com/repos/projectcalico/libcalico/issues/events{/number}","events_url":"https://api.github.com/repos/projectcalico/libcalico/events","assignees_url":"https://api.github.com/repos/projectcalico/libcalico/assignees{/user}","branches_url":"https://api.github.com/repos/projectcalico/libcalico/branches{/branch}","tags_url":"https://api.github.com/repos/projectcalico/libcalico/tags","blobs_url":"https://api.github.com/repos/projectcalico/libcalico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcalico/libcalico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcalico/libcalico/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcalico/libcalico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcalico/libcalico/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcalico/libcalico/languages","stargazers_url":"https://api.github.com/repos/projectcalico/libcalico/stargazers","contributors_url":"https://api.github.com/repos/projectcalico/libcalico/contributors","subscribers_url":"https://api.github.com/repos/projectcalico/libcalico/subscribers","subscription_url":"https://api.github.com/repos/projectcalico/libcalico/subscription","commits_url":"https://api.github.com/repos/projectcalico/libcalico/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcalico/libcalico/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcalico/libcalico/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcalico/libcalico/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcalico/libcalico/contents/{+path}","compare_url":"https://api.github.com/repos/projectcalico/libcalico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcalico/libcalico/merges","archive_url":"https://api.github.com/repos/projectcalico/libcalico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcalico/libcalico/downloads","issues_url":"https://api.github.com/repos/projectcalico/libcalico/issues{/number}","pulls_url":"https://api.github.com/repos/projectcalico/libcalico/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcalico/libcalico/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcalico/libcalico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcalico/libcalico/labels{/name}","releases_url":"https://api.github.com/repos/projectcalico/libcalico/releases{/id}","created_at":"2015-07-28T20:33:51Z","updated_at":"2015-07-31T00:39:12Z","pushed_at":"2015-08-07T20:30:03Z","git_url":"git://github.com/projectcalico/libcalico.git","ssh_url":"git@github.com:projectcalico/libcalico.git","clone_url":"https://github.com/projectcalico/libcalico.git","svn_url":"https://github.com/projectcalico/libcalico","homepage":"http://www.projectcalico.org/","size":13128,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectcalico/libcalico/pulls/8"},"html":{"href":"https://github.com/projectcalico/libcalico/pull/8"},"issue":{"href":"https://api.github.com/repos/projectcalico/libcalico/issues/8"},"comments":{"href":"https://api.github.com/repos/projectcalico/libcalico/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/projectcalico/libcalico/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/projectcalico/libcalico/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectcalico/libcalico/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/projectcalico/libcalico/statuses/53c5f33a93f7b2c50aa2d114eb017edba5f7f978"}}}}