{"action":"created","comment":{"url":"https://api.github.com/repos/cleanflight/cleanflight/pulls/comments/31755912","id":31755912,"diff_hunk":"@@ -97,6 +97,8 @@ typedef struct servoParam_t {\n     int16_t max;                            // servo max\n     int16_t middle;                         // servo middle\n     int8_t rate;                            // range [-100;+100] ; can be used to ajust a rate 0-100% and a direction\n+    int8_t minLimit;                        // range [-90;90] ; can be used to adjust a rate 0-100% and a direction\n+    int8_t maxLimit;                        // range [-90;90] ; can be used to adjust a rate 0-100% and a direction","path":"src/main/flight/mixer.h","position":5,"original_position":5,"commit_id":"2d3e5d75dd23ec52ffedacb6689ff2d62c3b3721","original_commit_id":"2d3e5d75dd23ec52ffedacb6689ff2d62c3b3721","user":{"login":"hydra","id":57075,"avatar_url":"https://avatars.githubusercontent.com/u/57075?v=3","gravatar_id":"","url":"https://api.github.com/users/hydra","html_url":"https://github.com/hydra","followers_url":"https://api.github.com/users/hydra/followers","following_url":"https://api.github.com/users/hydra/following{/other_user}","gists_url":"https://api.github.com/users/hydra/gists{/gist_id}","starred_url":"https://api.github.com/users/hydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hydra/subscriptions","organizations_url":"https://api.github.com/users/hydra/orgs","repos_url":"https://api.github.com/users/hydra/repos","events_url":"https://api.github.com/users/hydra/events{/privacy}","received_events_url":"https://api.github.com/users/hydra/received_events","type":"User","site_admin":false},"body":"also, i think using uint8_t and making sure they are always positive numbers would be better, since the 'rate' can be used to reverse the direction.","created_at":"2015-06-04T19:24:51Z","updated_at":"2015-06-04T19:24:51Z","html_url":"https://github.com/cleanflight/cleanflight/pull/928#discussion_r31755912","pull_request_url":"https://api.github.com/repos/cleanflight/cleanflight/pulls/928","_links":{"self":{"href":"https://api.github.com/repos/cleanflight/cleanflight/pulls/comments/31755912"},"html":{"href":"https://github.com/cleanflight/cleanflight/pull/928#discussion_r31755912"},"pull_request":{"href":"https://api.github.com/repos/cleanflight/cleanflight/pulls/928"}}},"pull_request":{"url":"https://api.github.com/repos/cleanflight/cleanflight/pulls/928","id":35831070,"html_url":"https://github.com/cleanflight/cleanflight/pull/928","diff_url":"https://github.com/cleanflight/cleanflight/pull/928.diff","patch_url":"https://github.com/cleanflight/cleanflight/pull/928.patch","issue_url":"https://api.github.com/repos/cleanflight/cleanflight/issues/928","number":928,"state":"open","locked":false,"title":"IO - Estimated servo angles","user":{"login":"MauroMombelli","id":6372561,"avatar_url":"https://avatars.githubusercontent.com/u/6372561?v=3","gravatar_id":"","url":"https://api.github.com/users/MauroMombelli","html_url":"https://github.com/MauroMombelli","followers_url":"https://api.github.com/users/MauroMombelli/followers","following_url":"https://api.github.com/users/MauroMombelli/following{/other_user}","gists_url":"https://api.github.com/users/MauroMombelli/gists{/gist_id}","starred_url":"https://api.github.com/users/MauroMombelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MauroMombelli/subscriptions","organizations_url":"https://api.github.com/users/MauroMombelli/orgs","repos_url":"https://api.github.com/users/MauroMombelli/repos","events_url":"https://api.github.com/users/MauroMombelli/events{/privacy}","received_events_url":"https://api.github.com/users/MauroMombelli/received_events","type":"User","site_admin":false},"body":"as in issue #925 we want in min and max the PWM value for a full 180°, and then minLimit and maxLimit are the physical limit (in degree) of movement.\r\n\r\nNote: the limit use as 0° the center point of the servo","created_at":"2015-05-20T13:26:28Z","updated_at":"2015-06-04T19:24:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cadc6212d2479ecfa42bf74de5f54f4a67707a43","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cleanflight/cleanflight/pulls/928/commits","review_comments_url":"https://api.github.com/repos/cleanflight/cleanflight/pulls/928/comments","review_comment_url":"https://api.github.com/repos/cleanflight/cleanflight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cleanflight/cleanflight/issues/928/comments","statuses_url":"https://api.github.com/repos/cleanflight/cleanflight/statuses/2d3e5d75dd23ec52ffedacb6689ff2d62c3b3721","head":{"label":"inkonova:SmartServo","ref":"SmartServo","sha":"2d3e5d75dd23ec52ffedacb6689ff2d62c3b3721","user":{"login":"inkonova","id":12050328,"avatar_url":"https://avatars.githubusercontent.com/u/12050328?v=3","gravatar_id":"","url":"https://api.github.com/users/inkonova","html_url":"https://github.com/inkonova","followers_url":"https://api.github.com/users/inkonova/followers","following_url":"https://api.github.com/users/inkonova/following{/other_user}","gists_url":"https://api.github.com/users/inkonova/gists{/gist_id}","starred_url":"https://api.github.com/users/inkonova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inkonova/subscriptions","organizations_url":"https://api.github.com/users/inkonova/orgs","repos_url":"https://api.github.com/users/inkonova/repos","events_url":"https://api.github.com/users/inkonova/events{/privacy}","received_events_url":"https://api.github.com/users/inkonova/received_events","type":"Organization","site_admin":false},"repo":{"id":34325834,"name":"cleanflight","full_name":"inkonova/cleanflight","owner":{"login":"inkonova","id":12050328,"avatar_url":"https://avatars.githubusercontent.com/u/12050328?v=3","gravatar_id":"","url":"https://api.github.com/users/inkonova","html_url":"https://github.com/inkonova","followers_url":"https://api.github.com/users/inkonova/followers","following_url":"https://api.github.com/users/inkonova/following{/other_user}","gists_url":"https://api.github.com/users/inkonova/gists{/gist_id}","starred_url":"https://api.github.com/users/inkonova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inkonova/subscriptions","organizations_url":"https://api.github.com/users/inkonova/orgs","repos_url":"https://api.github.com/users/inkonova/repos","events_url":"https://api.github.com/users/inkonova/events{/privacy}","received_events_url":"https://api.github.com/users/inkonova/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inkonova/cleanflight","description":"Clean-code version of the baseflight flight controller firmware","fork":true,"url":"https://api.github.com/repos/inkonova/cleanflight","forks_url":"https://api.github.com/repos/inkonova/cleanflight/forks","keys_url":"https://api.github.com/repos/inkonova/cleanflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inkonova/cleanflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inkonova/cleanflight/teams","hooks_url":"https://api.github.com/repos/inkonova/cleanflight/hooks","issue_events_url":"https://api.github.com/repos/inkonova/cleanflight/issues/events{/number}","events_url":"https://api.github.com/repos/inkonova/cleanflight/events","assignees_url":"https://api.github.com/repos/inkonova/cleanflight/assignees{/user}","branches_url":"https://api.github.com/repos/inkonova/cleanflight/branches{/branch}","tags_url":"https://api.github.com/repos/inkonova/cleanflight/tags","blobs_url":"https://api.github.com/repos/inkonova/cleanflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inkonova/cleanflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inkonova/cleanflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/inkonova/cleanflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inkonova/cleanflight/statuses/{sha}","languages_url":"https://api.github.com/repos/inkonova/cleanflight/languages","stargazers_url":"https://api.github.com/repos/inkonova/cleanflight/stargazers","contributors_url":"https://api.github.com/repos/inkonova/cleanflight/contributors","subscribers_url":"https://api.github.com/repos/inkonova/cleanflight/subscribers","subscription_url":"https://api.github.com/repos/inkonova/cleanflight/subscription","commits_url":"https://api.github.com/repos/inkonova/cleanflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/inkonova/cleanflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/inkonova/cleanflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/inkonova/cleanflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/inkonova/cleanflight/contents/{+path}","compare_url":"https://api.github.com/repos/inkonova/cleanflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inkonova/cleanflight/merges","archive_url":"https://api.github.com/repos/inkonova/cleanflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inkonova/cleanflight/downloads","issues_url":"https://api.github.com/repos/inkonova/cleanflight/issues{/number}","pulls_url":"https://api.github.com/repos/inkonova/cleanflight/pulls{/number}","milestones_url":"https://api.github.com/repos/inkonova/cleanflight/milestones{/number}","notifications_url":"https://api.github.com/repos/inkonova/cleanflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inkonova/cleanflight/labels{/name}","releases_url":"https://api.github.com/repos/inkonova/cleanflight/releases{/id}","created_at":"2015-04-21T12:34:01Z","updated_at":"2015-05-07T07:20:37Z","pushed_at":"2015-06-04T13:00:25Z","git_url":"git://github.com/inkonova/cleanflight.git","ssh_url":"git@github.com:inkonova/cleanflight.git","clone_url":"https://github.com/inkonova/cleanflight.git","svn_url":"https://github.com/inkonova/cleanflight","homepage":"http://cleanflight.com","size":32695,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"cleanflight:master","ref":"master","sha":"adf0ca9fcf1b6c5095aad0632af0b429fe3b13b3","user":{"login":"cleanflight","id":8776523,"avatar_url":"https://avatars.githubusercontent.com/u/8776523?v=3","gravatar_id":"","url":"https://api.github.com/users/cleanflight","html_url":"https://github.com/cleanflight","followers_url":"https://api.github.com/users/cleanflight/followers","following_url":"https://api.github.com/users/cleanflight/following{/other_user}","gists_url":"https://api.github.com/users/cleanflight/gists{/gist_id}","starred_url":"https://api.github.com/users/cleanflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleanflight/subscriptions","organizations_url":"https://api.github.com/users/cleanflight/orgs","repos_url":"https://api.github.com/users/cleanflight/repos","events_url":"https://api.github.com/users/cleanflight/events{/privacy}","received_events_url":"https://api.github.com/users/cleanflight/received_events","type":"Organization","site_admin":false},"repo":{"id":9066347,"name":"cleanflight","full_name":"cleanflight/cleanflight","owner":{"login":"cleanflight","id":8776523,"avatar_url":"https://avatars.githubusercontent.com/u/8776523?v=3","gravatar_id":"","url":"https://api.github.com/users/cleanflight","html_url":"https://github.com/cleanflight","followers_url":"https://api.github.com/users/cleanflight/followers","following_url":"https://api.github.com/users/cleanflight/following{/other_user}","gists_url":"https://api.github.com/users/cleanflight/gists{/gist_id}","starred_url":"https://api.github.com/users/cleanflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleanflight/subscriptions","organizations_url":"https://api.github.com/users/cleanflight/orgs","repos_url":"https://api.github.com/users/cleanflight/repos","events_url":"https://api.github.com/users/cleanflight/events{/privacy}","received_events_url":"https://api.github.com/users/cleanflight/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cleanflight/cleanflight","description":"Clean-code version of the baseflight flight controller firmware","fork":false,"url":"https://api.github.com/repos/cleanflight/cleanflight","forks_url":"https://api.github.com/repos/cleanflight/cleanflight/forks","keys_url":"https://api.github.com/repos/cleanflight/cleanflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cleanflight/cleanflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cleanflight/cleanflight/teams","hooks_url":"https://api.github.com/repos/cleanflight/cleanflight/hooks","issue_events_url":"https://api.github.com/repos/cleanflight/cleanflight/issues/events{/number}","events_url":"https://api.github.com/repos/cleanflight/cleanflight/events","assignees_url":"https://api.github.com/repos/cleanflight/cleanflight/assignees{/user}","branches_url":"https://api.github.com/repos/cleanflight/cleanflight/branches{/branch}","tags_url":"https://api.github.com/repos/cleanflight/cleanflight/tags","blobs_url":"https://api.github.com/repos/cleanflight/cleanflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cleanflight/cleanflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cleanflight/cleanflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/cleanflight/cleanflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cleanflight/cleanflight/statuses/{sha}","languages_url":"https://api.github.com/repos/cleanflight/cleanflight/languages","stargazers_url":"https://api.github.com/repos/cleanflight/cleanflight/stargazers","contributors_url":"https://api.github.com/repos/cleanflight/cleanflight/contributors","subscribers_url":"https://api.github.com/repos/cleanflight/cleanflight/subscribers","subscription_url":"https://api.github.com/repos/cleanflight/cleanflight/subscription","commits_url":"https://api.github.com/repos/cleanflight/cleanflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/cleanflight/cleanflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/cleanflight/cleanflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/cleanflight/cleanflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/cleanflight/cleanflight/contents/{+path}","compare_url":"https://api.github.com/repos/cleanflight/cleanflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cleanflight/cleanflight/merges","archive_url":"https://api.github.com/repos/cleanflight/cleanflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cleanflight/cleanflight/downloads","issues_url":"https://api.github.com/repos/cleanflight/cleanflight/issues{/number}","pulls_url":"https://api.github.com/repos/cleanflight/cleanflight/pulls{/number}","milestones_url":"https://api.github.com/repos/cleanflight/cleanflight/milestones{/number}","notifications_url":"https://api.github.com/repos/cleanflight/cleanflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cleanflight/cleanflight/labels{/name}","releases_url":"https://api.github.com/repos/cleanflight/cleanflight/releases{/id}","created_at":"2013-03-27T23:49:19Z","updated_at":"2015-06-04T16:02:03Z","pushed_at":"2015-06-04T16:26:02Z","git_url":"git://github.com/cleanflight/cleanflight.git","ssh_url":"git@github.com:cleanflight/cleanflight.git","clone_url":"https://github.com/cleanflight/cleanflight.git","svn_url":"https://github.com/cleanflight/cleanflight","homepage":"http://cleanflight.com","size":64084,"stargazers_count":349,"watchers_count":349,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":290,"mirror_url":null,"open_issues_count":219,"forks":290,"open_issues":219,"watchers":349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cleanflight/cleanflight/pulls/928"},"html":{"href":"https://github.com/cleanflight/cleanflight/pull/928"},"issue":{"href":"https://api.github.com/repos/cleanflight/cleanflight/issues/928"},"comments":{"href":"https://api.github.com/repos/cleanflight/cleanflight/issues/928/comments"},"review_comments":{"href":"https://api.github.com/repos/cleanflight/cleanflight/pulls/928/comments"},"review_comment":{"href":"https://api.github.com/repos/cleanflight/cleanflight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cleanflight/cleanflight/pulls/928/commits"},"statuses":{"href":"https://api.github.com/repos/cleanflight/cleanflight/statuses/2d3e5d75dd23ec52ffedacb6689ff2d62c3b3721"}}}}