{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments/48279074","id":48279074,"diff_hunk":"@@ -0,0 +1,40 @@\n+/* Copyright 2015 Mozilla Foundation\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+/* globals PDFJS, require, module */\n+\n+// included from api.js for GENERIC build\n+\n+'use strict';\n+\n+var useRequireEnsure = false;\n+if (typeof module !== 'undefined' && module.require) {","path":"src/frameworks.js","position":22,"original_position":22,"commit_id":"79c2f69c3288494c5ce2809182c896484bf4be5c","original_commit_id":"79c2f69c3288494c5ce2809182c896484bf4be5c","user":{"login":"Vanuan","id":361985,"avatar_url":"https://avatars.githubusercontent.com/u/361985?v=3","gravatar_id":"","url":"https://api.github.com/users/Vanuan","html_url":"https://github.com/Vanuan","followers_url":"https://api.github.com/users/Vanuan/followers","following_url":"https://api.github.com/users/Vanuan/following{/other_user}","gists_url":"https://api.github.com/users/Vanuan/gists{/gist_id}","starred_url":"https://api.github.com/users/Vanuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vanuan/subscriptions","organizations_url":"https://api.github.com/users/Vanuan/orgs","repos_url":"https://api.github.com/users/Vanuan/repos","events_url":"https://api.github.com/users/Vanuan/events{/privacy}","received_events_url":"https://api.github.com/users/Vanuan/received_events","type":"User","site_admin":false},"body":"Hm... maybe it's better to use `System.import` polyfill instead of `require.ensure`?\r\nhttps://github.com/ModuleLoader/es6-module-loader\r\nI believe, pdf.js is used more on browser side, so using ES6 modules seems more logical.","created_at":"2015-12-22T17:54:43Z","updated_at":"2015-12-22T17:54:43Z","html_url":"https://github.com/mozilla/pdf.js/pull/6785#discussion_r48279074","pull_request_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/6785","_links":{"self":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments/48279074"},"html":{"href":"https://github.com/mozilla/pdf.js/pull/6785#discussion_r48279074"},"pull_request":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/6785"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/6785","id":54200943,"html_url":"https://github.com/mozilla/pdf.js/pull/6785","diff_url":"https://github.com/mozilla/pdf.js/pull/6785.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/6785.patch","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6785","number":6785,"state":"closed","locked":false,"title":"Adds/modifies examples for node.js and webpack.","user":{"login":"yurydelendik","id":1523410,"avatar_url":"https://avatars.githubusercontent.com/u/1523410?v=3","gravatar_id":"","url":"https://api.github.com/users/yurydelendik","html_url":"https://github.com/yurydelendik","followers_url":"https://api.github.com/users/yurydelendik/followers","following_url":"https://api.github.com/users/yurydelendik/following{/other_user}","gists_url":"https://api.github.com/users/yurydelendik/gists{/gist_id}","starred_url":"https://api.github.com/users/yurydelendik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurydelendik/subscriptions","organizations_url":"https://api.github.com/users/yurydelendik/orgs","repos_url":"https://api.github.com/users/yurydelendik/repos","events_url":"https://api.github.com/users/yurydelendik/events{/privacy}","received_events_url":"https://api.github.com/users/yurydelendik/received_events","type":"User","site_admin":false},"body":"Modifies and cleans up node.js examples to use pdfjs-dist bundle instead of pdf.combined.js\r\n\r\nIntroduces webpack example to demonstrate proper way to disconnect worker part from display modules. See examples/webpack/README.md for details.\r\n\r\n","created_at":"2015-12-20T14:54:43Z","updated_at":"2015-12-22T17:54:43Z","closed_at":"2015-12-21T21:44:58Z","merged_at":"2015-12-21T21:44:58Z","merge_commit_sha":"562750cc5e31f3dc15bb535d5f71d939717487c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/6785/commits","review_comments_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/6785/comments","review_comment_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6785/comments","statuses_url":"https://api.github.com/repos/mozilla/pdf.js/statuses/79c2f69c3288494c5ce2809182c896484bf4be5c","head":{"label":"yurydelendik:frameworks","ref":"frameworks","sha":"79c2f69c3288494c5ce2809182c896484bf4be5c","user":{"login":"yurydelendik","id":1523410,"avatar_url":"https://avatars.githubusercontent.com/u/1523410?v=3","gravatar_id":"","url":"https://api.github.com/users/yurydelendik","html_url":"https://github.com/yurydelendik","followers_url":"https://api.github.com/users/yurydelendik/followers","following_url":"https://api.github.com/users/yurydelendik/following{/other_user}","gists_url":"https://api.github.com/users/yurydelendik/gists{/gist_id}","starred_url":"https://api.github.com/users/yurydelendik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurydelendik/subscriptions","organizations_url":"https://api.github.com/users/yurydelendik/orgs","repos_url":"https://api.github.com/users/yurydelendik/repos","events_url":"https://api.github.com/users/yurydelendik/events{/privacy}","received_events_url":"https://api.github.com/users/yurydelendik/received_events","type":"User","site_admin":false},"repo":{"id":3910637,"name":"pdf.js","full_name":"yurydelendik/pdf.js","owner":{"login":"yurydelendik","id":1523410,"avatar_url":"https://avatars.githubusercontent.com/u/1523410?v=3","gravatar_id":"","url":"https://api.github.com/users/yurydelendik","html_url":"https://github.com/yurydelendik","followers_url":"https://api.github.com/users/yurydelendik/followers","following_url":"https://api.github.com/users/yurydelendik/following{/other_user}","gists_url":"https://api.github.com/users/yurydelendik/gists{/gist_id}","starred_url":"https://api.github.com/users/yurydelendik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurydelendik/subscriptions","organizations_url":"https://api.github.com/users/yurydelendik/orgs","repos_url":"https://api.github.com/users/yurydelendik/repos","events_url":"https://api.github.com/users/yurydelendik/events{/privacy}","received_events_url":"https://api.github.com/users/yurydelendik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yurydelendik/pdf.js","description":"PDF Reader in JavaScript","fork":true,"url":"https://api.github.com/repos/yurydelendik/pdf.js","forks_url":"https://api.github.com/repos/yurydelendik/pdf.js/forks","keys_url":"https://api.github.com/repos/yurydelendik/pdf.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yurydelendik/pdf.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yurydelendik/pdf.js/teams","hooks_url":"https://api.github.com/repos/yurydelendik/pdf.js/hooks","issue_events_url":"https://api.github.com/repos/yurydelendik/pdf.js/issues/events{/number}","events_url":"https://api.github.com/repos/yurydelendik/pdf.js/events","assignees_url":"https://api.github.com/repos/yurydelendik/pdf.js/assignees{/user}","branches_url":"https://api.github.com/repos/yurydelendik/pdf.js/branches{/branch}","tags_url":"https://api.github.com/repos/yurydelendik/pdf.js/tags","blobs_url":"https://api.github.com/repos/yurydelendik/pdf.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yurydelendik/pdf.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yurydelendik/pdf.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/yurydelendik/pdf.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yurydelendik/pdf.js/statuses/{sha}","languages_url":"https://api.github.com/repos/yurydelendik/pdf.js/languages","stargazers_url":"https://api.github.com/repos/yurydelendik/pdf.js/stargazers","contributors_url":"https://api.github.com/repos/yurydelendik/pdf.js/contributors","subscribers_url":"https://api.github.com/repos/yurydelendik/pdf.js/subscribers","subscription_url":"https://api.github.com/repos/yurydelendik/pdf.js/subscription","commits_url":"https://api.github.com/repos/yurydelendik/pdf.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/yurydelendik/pdf.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/yurydelendik/pdf.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/yurydelendik/pdf.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/yurydelendik/pdf.js/contents/{+path}","compare_url":"https://api.github.com/repos/yurydelendik/pdf.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yurydelendik/pdf.js/merges","archive_url":"https://api.github.com/repos/yurydelendik/pdf.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yurydelendik/pdf.js/downloads","issues_url":"https://api.github.com/repos/yurydelendik/pdf.js/issues{/number}","pulls_url":"https://api.github.com/repos/yurydelendik/pdf.js/pulls{/number}","milestones_url":"https://api.github.com/repos/yurydelendik/pdf.js/milestones{/number}","notifications_url":"https://api.github.com/repos/yurydelendik/pdf.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yurydelendik/pdf.js/labels{/name}","releases_url":"https://api.github.com/repos/yurydelendik/pdf.js/releases{/id}","created_at":"2012-04-02T19:26:16Z","updated_at":"2015-07-02T19:39:39Z","pushed_at":"2015-12-22T17:45:27Z","git_url":"git://github.com/yurydelendik/pdf.js.git","ssh_url":"git@github.com:yurydelendik/pdf.js.git","clone_url":"https://github.com/yurydelendik/pdf.js.git","svn_url":"https://github.com/yurydelendik/pdf.js","homepage":"","size":50778,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"eb557d200f1216b4ae157eb2e1302eea69999b65","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1663468,"name":"pdf.js","full_name":"mozilla/pdf.js","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/pdf.js","description":"PDF Reader in JavaScript","fork":false,"url":"https://api.github.com/repos/mozilla/pdf.js","forks_url":"https://api.github.com/repos/mozilla/pdf.js/forks","keys_url":"https://api.github.com/repos/mozilla/pdf.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/pdf.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/pdf.js/teams","hooks_url":"https://api.github.com/repos/mozilla/pdf.js/hooks","issue_events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/pdf.js/events","assignees_url":"https://api.github.com/repos/mozilla/pdf.js/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/pdf.js/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/pdf.js/tags","blobs_url":"https://api.github.com/repos/mozilla/pdf.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/pdf.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/pdf.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/pdf.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/pdf.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/pdf.js/languages","stargazers_url":"https://api.github.com/repos/mozilla/pdf.js/stargazers","contributors_url":"https://api.github.com/repos/mozilla/pdf.js/contributors","subscribers_url":"https://api.github.com/repos/mozilla/pdf.js/subscribers","subscription_url":"https://api.github.com/repos/mozilla/pdf.js/subscription","commits_url":"https://api.github.com/repos/mozilla/pdf.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/pdf.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/pdf.js/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/pdf.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/pdf.js/merges","archive_url":"https://api.github.com/repos/mozilla/pdf.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/pdf.js/downloads","issues_url":"https://api.github.com/repos/mozilla/pdf.js/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/pdf.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/pdf.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/pdf.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/pdf.js/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/pdf.js/releases{/id}","created_at":"2011-04-26T06:32:03Z","updated_at":"2015-12-22T16:49:30Z","pushed_at":"2015-12-22T14:51:19Z","git_url":"git://github.com/mozilla/pdf.js.git","ssh_url":"git@github.com:mozilla/pdf.js.git","clone_url":"https://github.com/mozilla/pdf.js.git","svn_url":"https://github.com/mozilla/pdf.js","homepage":"","size":104393,"stargazers_count":13218,"watchers_count":13218,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3101,"mirror_url":null,"open_issues_count":571,"forks":3101,"open_issues":571,"watchers":13218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/6785"},"html":{"href":"https://github.com/mozilla/pdf.js/pull/6785"},"issue":{"href":"https://api.github.com/repos/mozilla/pdf.js/issues/6785"},"comments":{"href":"https://api.github.com/repos/mozilla/pdf.js/issues/6785/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/6785/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/6785/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/pdf.js/statuses/79c2f69c3288494c5ce2809182c896484bf4be5c"}}}}