{"action":"closed","number":1859,"pull_request":{"url":"https://api.github.com/repos/sbt/sbt/pulls/1859","id":29329546,"html_url":"https://github.com/sbt/sbt/pull/1859","diff_url":"https://github.com/sbt/sbt/pull/1859.diff","patch_url":"https://github.com/sbt/sbt/pull/1859.patch","issue_url":"https://api.github.com/repos/sbt/sbt/issues/1859","number":1859,"state":"closed","locked":false,"title":"Fix nightly publishing location by demoting publish-status to ThisBuild","user":{"login":"eed3si9n","id":184683,"avatar_url":"https://avatars.githubusercontent.com/u/184683?v=3","gravatar_id":"","url":"https://api.github.com/users/eed3si9n","html_url":"https://github.com/eed3si9n","followers_url":"https://api.github.com/users/eed3si9n/followers","following_url":"https://api.github.com/users/eed3si9n/following{/other_user}","gists_url":"https://api.github.com/users/eed3si9n/gists{/gist_id}","starred_url":"https://api.github.com/users/eed3si9n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eed3si9n/subscriptions","organizations_url":"https://api.github.com/users/eed3si9n/orgs","repos_url":"https://api.github.com/users/eed3si9n/repos","events_url":"https://api.github.com/users/eed3si9n/events{/privacy}","received_events_url":"https://api.github.com/users/eed3si9n/received_events","type":"User","site_admin":false},"body":"`stamp-version` is a command used to substitute `-SNAPSHOT` with the current timestamp. This is called by Jenkins job for the nightlies.\r\n\r\n## steps\r\n\r\n1. run `stamp-version` from sbt shell\r\n2. run `publishStatus` from sbt shell\r\n\r\n## problem\r\n\r\n`publishStatus` currently returns \"releases\", causing nightly releases to get published on the wrong repository by the Jenkins job.\r\n\r\n## expectations\r\n\r\n`publishStatus` returns \"snapshots\".\r\n\r\n## analysis\r\n\r\nNightlies broke in general when I migrated the build in #1784 so we didn't notice this for a while.\r\nAnother thing I broke there was promoting `publishStatus` setting from build level to project level in\r\nhttps://github.com/sbt/sbt/pull/1784/files#diff-fdc3abdfd754eeb24090dbd90aeec2ceR27.\r\nThis overrides `(publishStatus in ThisBuild := status)`, which is part of the `stamp-version` command.\r\nA few days ago #1842 was merged, making the nightlies to build again, and now this bug is surfaced.\r\n\r\nThe fix is to demote `publishStatus` back as a build-level setting by making it an auto plugin.\r\n\r\n/review @jsuereth, @havocp \r\n\r\n\r\n\r\n\r\n","created_at":"2015-02-15T03:43:05Z","updated_at":"2015-02-18T18:16:04Z","closed_at":"2015-02-18T18:16:04Z","merged_at":"2015-02-18T18:16:04Z","merge_commit_sha":"f41c500e89c8425650422a52ae4743858e6de0c3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sbt/sbt/pulls/1859/commits","review_comments_url":"https://api.github.com/repos/sbt/sbt/pulls/1859/comments","review_comment_url":"https://api.github.com/repos/sbt/sbt/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sbt/sbt/issues/1859/comments","statuses_url":"https://api.github.com/repos/sbt/sbt/statuses/2c82d339d7b0d6150885b34a614f1033fb388f06","head":{"label":"sbt:wip/publish-status-fix","ref":"wip/publish-status-fix","sha":"2c82d339d7b0d6150885b34a614f1033fb388f06","user":{"login":"sbt","id":1158012,"avatar_url":"https://avatars.githubusercontent.com/u/1158012?v=3","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"repo":{"id":279553,"name":"sbt","full_name":"sbt/sbt","owner":{"login":"sbt","id":1158012,"avatar_url":"https://avatars.githubusercontent.com/u/1158012?v=3","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sbt/sbt","description":"sbt, a build tool for Scala","fork":false,"url":"https://api.github.com/repos/sbt/sbt","forks_url":"https://api.github.com/repos/sbt/sbt/forks","keys_url":"https://api.github.com/repos/sbt/sbt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbt/sbt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbt/sbt/teams","hooks_url":"https://api.github.com/repos/sbt/sbt/hooks","issue_events_url":"https://api.github.com/repos/sbt/sbt/issues/events{/number}","events_url":"https://api.github.com/repos/sbt/sbt/events","assignees_url":"https://api.github.com/repos/sbt/sbt/assignees{/user}","branches_url":"https://api.github.com/repos/sbt/sbt/branches{/branch}","tags_url":"https://api.github.com/repos/sbt/sbt/tags","blobs_url":"https://api.github.com/repos/sbt/sbt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbt/sbt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbt/sbt/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbt/sbt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbt/sbt/statuses/{sha}","languages_url":"https://api.github.com/repos/sbt/sbt/languages","stargazers_url":"https://api.github.com/repos/sbt/sbt/stargazers","contributors_url":"https://api.github.com/repos/sbt/sbt/contributors","subscribers_url":"https://api.github.com/repos/sbt/sbt/subscribers","subscription_url":"https://api.github.com/repos/sbt/sbt/subscription","commits_url":"https://api.github.com/repos/sbt/sbt/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbt/sbt/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbt/sbt/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbt/sbt/issues/comments/{number}","contents_url":"https://api.github.com/repos/sbt/sbt/contents/{+path}","compare_url":"https://api.github.com/repos/sbt/sbt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbt/sbt/merges","archive_url":"https://api.github.com/repos/sbt/sbt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbt/sbt/downloads","issues_url":"https://api.github.com/repos/sbt/sbt/issues{/number}","pulls_url":"https://api.github.com/repos/sbt/sbt/pulls{/number}","milestones_url":"https://api.github.com/repos/sbt/sbt/milestones{/number}","notifications_url":"https://api.github.com/repos/sbt/sbt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbt/sbt/labels{/name}","releases_url":"https://api.github.com/repos/sbt/sbt/releases{/id}","created_at":"2009-08-17T00:31:14Z","updated_at":"2015-02-18T18:16:04Z","pushed_at":"2015-02-18T18:16:04Z","git_url":"git://github.com/sbt/sbt.git","ssh_url":"git@github.com:sbt/sbt.git","clone_url":"https://github.com/sbt/sbt.git","svn_url":"https://github.com/sbt/sbt","homepage":"scala-sbt.org","size":48326,"stargazers_count":2092,"watchers_count":2092,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":398,"mirror_url":null,"open_issues_count":288,"forks":398,"open_issues":288,"watchers":2092,"default_branch":"0.13"}},"base":{"label":"sbt:0.13","ref":"0.13","sha":"a17dd3de74c26d0a0e9f8942423860b86813e664","user":{"login":"sbt","id":1158012,"avatar_url":"https://avatars.githubusercontent.com/u/1158012?v=3","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"repo":{"id":279553,"name":"sbt","full_name":"sbt/sbt","owner":{"login":"sbt","id":1158012,"avatar_url":"https://avatars.githubusercontent.com/u/1158012?v=3","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sbt/sbt","description":"sbt, a build tool for Scala","fork":false,"url":"https://api.github.com/repos/sbt/sbt","forks_url":"https://api.github.com/repos/sbt/sbt/forks","keys_url":"https://api.github.com/repos/sbt/sbt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbt/sbt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbt/sbt/teams","hooks_url":"https://api.github.com/repos/sbt/sbt/hooks","issue_events_url":"https://api.github.com/repos/sbt/sbt/issues/events{/number}","events_url":"https://api.github.com/repos/sbt/sbt/events","assignees_url":"https://api.github.com/repos/sbt/sbt/assignees{/user}","branches_url":"https://api.github.com/repos/sbt/sbt/branches{/branch}","tags_url":"https://api.github.com/repos/sbt/sbt/tags","blobs_url":"https://api.github.com/repos/sbt/sbt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbt/sbt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbt/sbt/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbt/sbt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbt/sbt/statuses/{sha}","languages_url":"https://api.github.com/repos/sbt/sbt/languages","stargazers_url":"https://api.github.com/repos/sbt/sbt/stargazers","contributors_url":"https://api.github.com/repos/sbt/sbt/contributors","subscribers_url":"https://api.github.com/repos/sbt/sbt/subscribers","subscription_url":"https://api.github.com/repos/sbt/sbt/subscription","commits_url":"https://api.github.com/repos/sbt/sbt/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbt/sbt/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbt/sbt/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbt/sbt/issues/comments/{number}","contents_url":"https://api.github.com/repos/sbt/sbt/contents/{+path}","compare_url":"https://api.github.com/repos/sbt/sbt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbt/sbt/merges","archive_url":"https://api.github.com/repos/sbt/sbt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbt/sbt/downloads","issues_url":"https://api.github.com/repos/sbt/sbt/issues{/number}","pulls_url":"https://api.github.com/repos/sbt/sbt/pulls{/number}","milestones_url":"https://api.github.com/repos/sbt/sbt/milestones{/number}","notifications_url":"https://api.github.com/repos/sbt/sbt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbt/sbt/labels{/name}","releases_url":"https://api.github.com/repos/sbt/sbt/releases{/id}","created_at":"2009-08-17T00:31:14Z","updated_at":"2015-02-18T18:16:04Z","pushed_at":"2015-02-18T18:16:04Z","git_url":"git://github.com/sbt/sbt.git","ssh_url":"git@github.com:sbt/sbt.git","clone_url":"https://github.com/sbt/sbt.git","svn_url":"https://github.com/sbt/sbt","homepage":"scala-sbt.org","size":48326,"stargazers_count":2092,"watchers_count":2092,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":398,"mirror_url":null,"open_issues_count":288,"forks":398,"open_issues":288,"watchers":2092,"default_branch":"0.13"}},"_links":{"self":{"href":"https://api.github.com/repos/sbt/sbt/pulls/1859"},"html":{"href":"https://github.com/sbt/sbt/pull/1859"},"issue":{"href":"https://api.github.com/repos/sbt/sbt/issues/1859"},"comments":{"href":"https://api.github.com/repos/sbt/sbt/issues/1859/comments"},"review_comments":{"href":"https://api.github.com/repos/sbt/sbt/pulls/1859/comments"},"review_comment":{"href":"https://api.github.com/repos/sbt/sbt/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sbt/sbt/pulls/1859/commits"},"statuses":{"href":"https://api.github.com/repos/sbt/sbt/statuses/2c82d339d7b0d6150885b34a614f1033fb388f06"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"eed3si9n","id":184683,"avatar_url":"https://avatars.githubusercontent.com/u/184683?v=3","gravatar_id":"","url":"https://api.github.com/users/eed3si9n","html_url":"https://github.com/eed3si9n","followers_url":"https://api.github.com/users/eed3si9n/followers","following_url":"https://api.github.com/users/eed3si9n/following{/other_user}","gists_url":"https://api.github.com/users/eed3si9n/gists{/gist_id}","starred_url":"https://api.github.com/users/eed3si9n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eed3si9n/subscriptions","organizations_url":"https://api.github.com/users/eed3si9n/orgs","repos_url":"https://api.github.com/users/eed3si9n/repos","events_url":"https://api.github.com/users/eed3si9n/events{/privacy}","received_events_url":"https://api.github.com/users/eed3si9n/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":14,"deletions":7,"changed_files":4}}