{"action":"created","comment":{"url":"https://api.github.com/repos/iojs/io.js/pulls/comments/28843028","id":28843028,"diff_hunk":"@@ -383,13 +395,6 @@ TLSSocket.prototype._init = function(socket, wrap) {\n   if (options.handshakeTimeout > 0)\n     this.setTimeout(options.handshakeTimeout, this._handleTimeout);\n \n-  // Socket already has some buffered data - emulate receiving it\n-  if (socket && socket._readableState && socket._readableState.length) {\n-    var buf;\n-    while ((buf = socket.read()) !== null)\n-      ssl.receive(buf);\n-  }\n-","path":"lib/_tls_wrap.js","position":31,"original_position":31,"commit_id":"e6739f0eecbe03486a6b496289af19be3f306dcf","original_commit_id":"e6739f0eecbe03486a6b496289af19be3f306dcf","user":{"login":"chrisdickinson","id":37303,"avatar_url":"https://avatars.githubusercontent.com/u/37303?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisdickinson","html_url":"https://github.com/chrisdickinson","followers_url":"https://api.github.com/users/chrisdickinson/followers","following_url":"https://api.github.com/users/chrisdickinson/following{/other_user}","gists_url":"https://api.github.com/users/chrisdickinson/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdickinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdickinson/subscriptions","organizations_url":"https://api.github.com/users/chrisdickinson/orgs","repos_url":"https://api.github.com/users/chrisdickinson/repos","events_url":"https://api.github.com/users/chrisdickinson/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdickinson/received_events","type":"User","site_admin":false},"body":"Why move this out of `_init` into the constructor?","created_at":"2015-04-22T04:03:37Z","updated_at":"2015-04-22T04:03:37Z","html_url":"https://github.com/iojs/io.js/pull/1496#discussion_r28843028","pull_request_url":"https://api.github.com/repos/iojs/io.js/pulls/1496","_links":{"self":{"href":"https://api.github.com/repos/iojs/io.js/pulls/comments/28843028"},"html":{"href":"https://github.com/iojs/io.js/pull/1496#discussion_r28843028"},"pull_request":{"href":"https://api.github.com/repos/iojs/io.js/pulls/1496"}}},"pull_request":{"url":"https://api.github.com/repos/iojs/io.js/pulls/1496","id":33817928,"html_url":"https://github.com/iojs/io.js/pull/1496","diff_url":"https://github.com/iojs/io.js/pull/1496.diff","patch_url":"https://github.com/iojs/io.js/pull/1496.patch","issue_url":"https://api.github.com/repos/iojs/io.js/issues/1496","number":1496,"state":"open","locked":false,"title":"Net: Defer reading until callbacks could be added","user":{"login":"fastest963","id":112555,"avatar_url":"https://avatars.githubusercontent.com/u/112555?v=3","gravatar_id":"","url":"https://api.github.com/users/fastest963","html_url":"https://github.com/fastest963","followers_url":"https://api.github.com/users/fastest963/followers","following_url":"https://api.github.com/users/fastest963/following{/other_user}","gists_url":"https://api.github.com/users/fastest963/gists{/gist_id}","starred_url":"https://api.github.com/users/fastest963/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastest963/subscriptions","organizations_url":"https://api.github.com/users/fastest963/orgs","repos_url":"https://api.github.com/users/fastest963/repos","events_url":"https://api.github.com/users/fastest963/events{/privacy}","received_events_url":"https://api.github.com/users/fastest963/received_events","type":"User","site_admin":false},"body":"Defer reading until user-land has a chance to add callbacks. This\r\nallows the TLS wrapper to listen for _tlsError and trigger a\r\nclientError event if the socket already has data that could trigger.\r\n\r\nFixes #1114","created_at":"2015-04-22T01:05:04Z","updated_at":"2015-04-22T04:03:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7df7da932352aba3cfeafd694092ef0d0a0c3a31","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iojs/io.js/pulls/1496/commits","review_comments_url":"https://api.github.com/repos/iojs/io.js/pulls/1496/comments","review_comment_url":"https://api.github.com/repos/iojs/io.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iojs/io.js/issues/1496/comments","statuses_url":"https://api.github.com/repos/iojs/io.js/statuses/e6739f0eecbe03486a6b496289af19be3f306dcf","head":{"label":"fastest963:tlsDefer","ref":"tlsDefer","sha":"e6739f0eecbe03486a6b496289af19be3f306dcf","user":{"login":"fastest963","id":112555,"avatar_url":"https://avatars.githubusercontent.com/u/112555?v=3","gravatar_id":"","url":"https://api.github.com/users/fastest963","html_url":"https://github.com/fastest963","followers_url":"https://api.github.com/users/fastest963/followers","following_url":"https://api.github.com/users/fastest963/following{/other_user}","gists_url":"https://api.github.com/users/fastest963/gists{/gist_id}","starred_url":"https://api.github.com/users/fastest963/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastest963/subscriptions","organizations_url":"https://api.github.com/users/fastest963/orgs","repos_url":"https://api.github.com/users/fastest963/repos","events_url":"https://api.github.com/users/fastest963/events{/privacy}","received_events_url":"https://api.github.com/users/fastest963/received_events","type":"User","site_admin":false},"repo":{"id":34294437,"name":"io.js","full_name":"fastest963/io.js","owner":{"login":"fastest963","id":112555,"avatar_url":"https://avatars.githubusercontent.com/u/112555?v=3","gravatar_id":"","url":"https://api.github.com/users/fastest963","html_url":"https://github.com/fastest963","followers_url":"https://api.github.com/users/fastest963/followers","following_url":"https://api.github.com/users/fastest963/following{/other_user}","gists_url":"https://api.github.com/users/fastest963/gists{/gist_id}","starred_url":"https://api.github.com/users/fastest963/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastest963/subscriptions","organizations_url":"https://api.github.com/users/fastest963/orgs","repos_url":"https://api.github.com/users/fastest963/repos","events_url":"https://api.github.com/users/fastest963/events{/privacy}","received_events_url":"https://api.github.com/users/fastest963/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fastest963/io.js","description":"A friendly fork of Node.js with an open governance model","fork":true,"url":"https://api.github.com/repos/fastest963/io.js","forks_url":"https://api.github.com/repos/fastest963/io.js/forks","keys_url":"https://api.github.com/repos/fastest963/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastest963/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastest963/io.js/teams","hooks_url":"https://api.github.com/repos/fastest963/io.js/hooks","issue_events_url":"https://api.github.com/repos/fastest963/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/fastest963/io.js/events","assignees_url":"https://api.github.com/repos/fastest963/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/fastest963/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/fastest963/io.js/tags","blobs_url":"https://api.github.com/repos/fastest963/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastest963/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastest963/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastest963/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastest963/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/fastest963/io.js/languages","stargazers_url":"https://api.github.com/repos/fastest963/io.js/stargazers","contributors_url":"https://api.github.com/repos/fastest963/io.js/contributors","subscribers_url":"https://api.github.com/repos/fastest963/io.js/subscribers","subscription_url":"https://api.github.com/repos/fastest963/io.js/subscription","commits_url":"https://api.github.com/repos/fastest963/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastest963/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastest963/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastest963/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastest963/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/fastest963/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastest963/io.js/merges","archive_url":"https://api.github.com/repos/fastest963/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastest963/io.js/downloads","issues_url":"https://api.github.com/repos/fastest963/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/fastest963/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/fastest963/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/fastest963/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastest963/io.js/labels{/name}","releases_url":"https://api.github.com/repos/fastest963/io.js/releases{/id}","created_at":"2015-04-21T00:30:50Z","updated_at":"2015-04-21T00:30:53Z","pushed_at":"2015-04-22T01:03:37Z","git_url":"git://github.com/fastest963/io.js.git","ssh_url":"git@github.com:fastest963/io.js.git","clone_url":"https://github.com/fastest963/io.js.git","svn_url":"https://github.com/fastest963/io.js","homepage":"https://iojs.org","size":173234,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iojs:master","ref":"master","sha":"26327757f8b342eb91df71f1fdf34a855e29aa71","user":{"login":"iojs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/iojs","html_url":"https://github.com/iojs","followers_url":"https://api.github.com/users/iojs/followers","following_url":"https://api.github.com/users/iojs/following{/other_user}","gists_url":"https://api.github.com/users/iojs/gists{/gist_id}","starred_url":"https://api.github.com/users/iojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojs/subscriptions","organizations_url":"https://api.github.com/users/iojs/orgs","repos_url":"https://api.github.com/users/iojs/repos","events_url":"https://api.github.com/users/iojs/events{/privacy}","received_events_url":"https://api.github.com/users/iojs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"io.js","full_name":"iojs/io.js","owner":{"login":"iojs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/iojs","html_url":"https://github.com/iojs","followers_url":"https://api.github.com/users/iojs/followers","following_url":"https://api.github.com/users/iojs/following{/other_user}","gists_url":"https://api.github.com/users/iojs/gists{/gist_id}","starred_url":"https://api.github.com/users/iojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojs/subscriptions","organizations_url":"https://api.github.com/users/iojs/orgs","repos_url":"https://api.github.com/users/iojs/repos","events_url":"https://api.github.com/users/iojs/events{/privacy}","received_events_url":"https://api.github.com/users/iojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iojs/io.js","description":"A friendly fork of Node.js with an open governance model","fork":false,"url":"https://api.github.com/repos/iojs/io.js","forks_url":"https://api.github.com/repos/iojs/io.js/forks","keys_url":"https://api.github.com/repos/iojs/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iojs/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iojs/io.js/teams","hooks_url":"https://api.github.com/repos/iojs/io.js/hooks","issue_events_url":"https://api.github.com/repos/iojs/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/iojs/io.js/events","assignees_url":"https://api.github.com/repos/iojs/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/iojs/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/iojs/io.js/tags","blobs_url":"https://api.github.com/repos/iojs/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iojs/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iojs/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/iojs/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iojs/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/iojs/io.js/languages","stargazers_url":"https://api.github.com/repos/iojs/io.js/stargazers","contributors_url":"https://api.github.com/repos/iojs/io.js/contributors","subscribers_url":"https://api.github.com/repos/iojs/io.js/subscribers","subscription_url":"https://api.github.com/repos/iojs/io.js/subscription","commits_url":"https://api.github.com/repos/iojs/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/iojs/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/iojs/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/iojs/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/iojs/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/iojs/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iojs/io.js/merges","archive_url":"https://api.github.com/repos/iojs/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iojs/io.js/downloads","issues_url":"https://api.github.com/repos/iojs/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/iojs/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/iojs/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/iojs/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iojs/io.js/labels{/name}","releases_url":"https://api.github.com/repos/iojs/io.js/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-04-22T01:12:27Z","pushed_at":"2015-04-22T02:50:02Z","git_url":"git://github.com/iojs/io.js.git","ssh_url":"git@github.com:iojs/io.js.git","clone_url":"https://github.com/iojs/io.js.git","svn_url":"https://github.com/iojs/io.js","homepage":"https://iojs.org","size":173234,"stargazers_count":11773,"watchers_count":11773,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":838,"mirror_url":null,"open_issues_count":243,"forks":838,"open_issues":243,"watchers":11773,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iojs/io.js/pulls/1496"},"html":{"href":"https://github.com/iojs/io.js/pull/1496"},"issue":{"href":"https://api.github.com/repos/iojs/io.js/issues/1496"},"comments":{"href":"https://api.github.com/repos/iojs/io.js/issues/1496/comments"},"review_comments":{"href":"https://api.github.com/repos/iojs/io.js/pulls/1496/comments"},"review_comment":{"href":"https://api.github.com/repos/iojs/io.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iojs/io.js/pulls/1496/commits"},"statuses":{"href":"https://api.github.com/repos/iojs/io.js/statuses/e6739f0eecbe03486a6b496289af19be3f306dcf"}}}}