{"action":"created","issue":{"url":"https://api.github.com/repos/arduino/Arduino/issues/3757","labels_url":"https://api.github.com/repos/arduino/Arduino/issues/3757/labels{/name}","comments_url":"https://api.github.com/repos/arduino/Arduino/issues/3757/comments","events_url":"https://api.github.com/repos/arduino/Arduino/issues/3757/events","html_url":"https://github.com/arduino/Arduino/pull/3757","id":104309921,"number":3757,"title":"Include sketchbook folder and LibrarySettings.h","user":{"login":"NicoHood","id":6888294,"avatar_url":"https://avatars.githubusercontent.com/u/6888294?v=3","gravatar_id":"","url":"https://api.github.com/users/NicoHood","html_url":"https://github.com/NicoHood","followers_url":"https://api.github.com/users/NicoHood/followers","following_url":"https://api.github.com/users/NicoHood/following{/other_user}","gists_url":"https://api.github.com/users/NicoHood/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoHood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoHood/subscriptions","organizations_url":"https://api.github.com/users/NicoHood/orgs","repos_url":"https://api.github.com/users/NicoHood/repos","events_url":"https://api.github.com/users/NicoHood/events{/privacy}","received_events_url":"https://api.github.com/users/NicoHood/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-01T16:52:37Z","updated_at":"2015-09-02T07:40:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/arduino/Arduino/pulls/3757","html_url":"https://github.com/arduino/Arduino/pull/3757","diff_url":"https://github.com/arduino/Arduino/pull/3757.diff","patch_url":"https://github.com/arduino/Arduino/pull/3757.patch"},"body":"Test to improve https://github.com/arduino/Arduino/pull/3717\r\n\r\nSome notes to this PR:\r\n* It (basically) does the same (idea) as the linked PR above\r\n* You do not need to save the file before it is used for compiling\r\n* A Global \"LibrarySetting.h\" filename is used for custom Library settings\r\n* If it does not exists in the sketch folder it will be created emty\r\n* You can still overwrite this empty file in the IDE again\r\n* If you create and delete the file this wont be noticed\r\n* The try catch may be improved, I am not a java pro.\r\n\r\nThis way you can place custom settings in this file. You can also add something like\r\n`#define LIBCONFIG_EXISTS` to use custom settings or `#ifndef SETTING`. The reason why a specific filename is used is, that it will compile fine even if the file was not created by the user.\r\n\r\nYou can also create custom settings like `MylibSetting.h` and include it from the library. This makes the file required to exist. If not it will throw a compile error. If the file also exists in the library, the library file will be preferred (so you should use the Librarysettings.h instead for this usecase).\r\n\r\n### Independent Issue found:\r\n\r\nThe deletion seems to be a general IDE issue. If you create a file and compile the sketch the file is copied to the build folder. If you delete the file again it wont be noticed and the sketchfolder still has this file. (The core has the same error, [which is ignored](https://github.com/arduino/Arduino/blob/master/arduino-core/src/processing/app/debug/Compiler.java#L1146-L1151)).\r\n\r\nI tried to delete the file after each compile. That worked fine till the point when LibrarySettings.h causes a compile error. The file wont be deleted then (in the build folder). If you delete it (in the IDE) its still in the build folder.\r\n\r\nSo this is a general, separate bug. Should I open a ticket for this?\r\n\r\n### May anyone build this to test it?"},"comment":{"url":"https://api.github.com/repos/arduino/Arduino/issues/comments/136963128","html_url":"https://github.com/arduino/Arduino/pull/3757#issuecomment-136963128","issue_url":"https://api.github.com/repos/arduino/Arduino/issues/3757","id":136963128,"user":{"login":"ArduinoBot","id":4233897,"avatar_url":"https://avatars.githubusercontent.com/u/4233897?v=3","gravatar_id":"","url":"https://api.github.com/users/ArduinoBot","html_url":"https://github.com/ArduinoBot","followers_url":"https://api.github.com/users/ArduinoBot/followers","following_url":"https://api.github.com/users/ArduinoBot/following{/other_user}","gists_url":"https://api.github.com/users/ArduinoBot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduinoBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduinoBot/subscriptions","organizations_url":"https://api.github.com/users/ArduinoBot/orgs","repos_url":"https://api.github.com/users/ArduinoBot/repos","events_url":"https://api.github.com/users/ArduinoBot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduinoBot/received_events","type":"User","site_admin":false},"created_at":"2015-09-02T07:40:49Z","updated_at":"2015-09-02T07:40:49Z","body":"Build successful. Please test this code using one of the following:\nhttp://downloads.arduino.cc/javaide/pull_requests/arduino-PR-3757-BUILD-389-linux32.tar.xz\nhttp://downloads.arduino.cc/javaide/pull_requests/arduino-PR-3757-BUILD-389-linux64.tar.xz\nhttp://downloads.arduino.cc/javaide/pull_requests/arduino-PR-3757-BUILD-389-windows.zip\nhttp://downloads.arduino.cc/javaide/pull_requests/arduino-PR-3757-BUILD-389-macosx.zip"}}