{"action":"created","issue":{"url":"https://api.github.com/repos/luxflux/puppet-openvpn/issues/176","labels_url":"https://api.github.com/repos/luxflux/puppet-openvpn/issues/176/labels{/name}","comments_url":"https://api.github.com/repos/luxflux/puppet-openvpn/issues/176/comments","events_url":"https://api.github.com/repos/luxflux/puppet-openvpn/issues/176/events","html_url":"https://github.com/luxflux/puppet-openvpn/pull/176","id":107821877,"number":176,"title":"Use concat for ovpn generation.","user":{"login":"jkroepke","id":1560587,"avatar_url":"https://avatars.githubusercontent.com/u/1560587?v=3","gravatar_id":"","url":"https://api.github.com/users/jkroepke","html_url":"https://github.com/jkroepke","followers_url":"https://api.github.com/users/jkroepke/followers","following_url":"https://api.github.com/users/jkroepke/following{/other_user}","gists_url":"https://api.github.com/users/jkroepke/gists{/gist_id}","starred_url":"https://api.github.com/users/jkroepke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkroepke/subscriptions","organizations_url":"https://api.github.com/users/jkroepke/orgs","repos_url":"https://api.github.com/users/jkroepke/repos","events_url":"https://api.github.com/users/jkroepke/events{/privacy}","received_events_url":"https://api.github.com/users/jkroepke/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/luxflux/puppet-openvpn/labels/waiting%20for%20OP","name":"waiting for OP","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-09-22T23:18:46Z","updated_at":"2015-10-18T21:31:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/luxflux/puppet-openvpn/pulls/176","html_url":"https://github.com/luxflux/puppet-openvpn/pull/176","diff_url":"https://github.com/luxflux/puppet-openvpn/pull/176.diff","patch_url":"https://github.com/luxflux/puppet-openvpn/pull/176.patch"},"body":"Hi,\r\n\r\nI refactor the generation of the ovpn file. Its support inline tls-auth now (see https://github.com/luxflux/puppet-openvpn/issues/175).\r\n\r\nConcat Module is already required in metdata.json\r\n\r\nTested on Ubuntu 14.04 w/ puppet 3.8.2 and OpenVPN 2.3.7 for Windows (VPN client).\r\n\r\nAlso, the concat files are located in /var/lib/puppet/concat, which only read read by puppet group and root.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/luxflux/puppet-openvpn/issues/comments/149048922","html_url":"https://github.com/luxflux/puppet-openvpn/pull/176#issuecomment-149048922","issue_url":"https://api.github.com/repos/luxflux/puppet-openvpn/issues/176","id":149048922,"user":{"login":"jkroepke","id":1560587,"avatar_url":"https://avatars.githubusercontent.com/u/1560587?v=3","gravatar_id":"","url":"https://api.github.com/users/jkroepke","html_url":"https://github.com/jkroepke","followers_url":"https://api.github.com/users/jkroepke/followers","following_url":"https://api.github.com/users/jkroepke/following{/other_user}","gists_url":"https://api.github.com/users/jkroepke/gists{/gist_id}","starred_url":"https://api.github.com/users/jkroepke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkroepke/subscriptions","organizations_url":"https://api.github.com/users/jkroepke/orgs","repos_url":"https://api.github.com/users/jkroepke/repos","events_url":"https://api.github.com/users/jkroepke/events{/privacy}","received_events_url":"https://api.github.com/users/jkroepke/received_events","type":"User","site_admin":false},"created_at":"2015-10-18T21:31:35Z","updated_at":"2015-10-18T21:31:35Z","body":"While i'm trying this, I got some dependency cycles.\r\n\r\nFor example, the tblk file are require the ovpn file must be run before the tar command.\r\n\r\nI think one complex class is good enough, Refactoring can be later, not?"}}