{"action":"created","comment":{"url":"https://api.github.com/repos/MACSIFS/IFS/pulls/comments/45709869","id":45709869,"diff_hunk":"@@ -1,6 +1,6 @@\n <form data-ng-submit=\"commentForm.submitComment()\">\n     <div class=\"input-group\">\n-      <input type=\"text\" class=\"form-control\" placeholder=\"Comment...\" data-ng-model=\"commentForm.comment\">\n+      <input type=\"text\" class=\"form-control\" placeholder=\"Comment...\" data-ng-model=\"commentForm.comment\" maxlength=\"500\">","path":"client/student/app/lecture/comment.form.html","position":4,"original_position":4,"commit_id":"cf5f86f5b5ae9cc56a96bd1e3e876da4901c61ea","original_commit_id":"cf5f86f5b5ae9cc56a96bd1e3e876da4901c61ea","user":{"login":"Gachapen","id":564740,"avatar_url":"https://avatars.githubusercontent.com/u/564740?v=3","gravatar_id":"","url":"https://api.github.com/users/Gachapen","html_url":"https://github.com/Gachapen","followers_url":"https://api.github.com/users/Gachapen/followers","following_url":"https://api.github.com/users/Gachapen/following{/other_user}","gists_url":"https://api.github.com/users/Gachapen/gists{/gist_id}","starred_url":"https://api.github.com/users/Gachapen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gachapen/subscriptions","organizations_url":"https://api.github.com/users/Gachapen/orgs","repos_url":"https://api.github.com/users/Gachapen/repos","events_url":"https://api.github.com/users/Gachapen/events{/privacy}","received_events_url":"https://api.github.com/users/Gachapen/received_events","type":"User","site_admin":false},"body":"I think we should prefix our directives with \"ifs\". I.e. maxlength would be ifs-maxlength. This is to avoid future conflicts:\r\n\r\n\"Best Practice: In order to avoid collisions with some future standard, it's best to prefix your own directive names. For instance, if you created a <carousel> directive, it would be problematic if HTML7 introduced the same element. A two or three letter prefix (e.g. btfCarousel) works well. Similarly, do not prefix your own directives with ng or they might conflict with directives included in a future version of Angular.\"\r\n\r\nhttps://docs.angularjs.org/guide/directive","created_at":"2015-11-24T09:04:25Z","updated_at":"2015-11-24T09:04:25Z","html_url":"https://github.com/MACSIFS/IFS/pull/58#discussion_r45709869","pull_request_url":"https://api.github.com/repos/MACSIFS/IFS/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/MACSIFS/IFS/pulls/comments/45709869"},"html":{"href":"https://github.com/MACSIFS/IFS/pull/58#discussion_r45709869"},"pull_request":{"href":"https://api.github.com/repos/MACSIFS/IFS/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/MACSIFS/IFS/pulls/58","id":51594835,"html_url":"https://github.com/MACSIFS/IFS/pull/58","diff_url":"https://github.com/MACSIFS/IFS/pull/58.diff","patch_url":"https://github.com/MACSIFS/IFS/pull/58.patch","issue_url":"https://api.github.com/repos/MACSIFS/IFS/issues/58","number":58,"state":"open","locked":false,"title":"IFS - 94: Added new directive for handling max length on comments.","user":{"login":"JGH153","id":2571495,"avatar_url":"https://avatars.githubusercontent.com/u/2571495?v=3","gravatar_id":"","url":"https://api.github.com/users/JGH153","html_url":"https://github.com/JGH153","followers_url":"https://api.github.com/users/JGH153/followers","following_url":"https://api.github.com/users/JGH153/following{/other_user}","gists_url":"https://api.github.com/users/JGH153/gists{/gist_id}","starred_url":"https://api.github.com/users/JGH153/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JGH153/subscriptions","organizations_url":"https://api.github.com/users/JGH153/orgs","repos_url":"https://api.github.com/users/JGH153/repos","events_url":"https://api.github.com/users/JGH153/events{/privacy}","received_events_url":"https://api.github.com/users/JGH153/received_events","type":"User","site_admin":false},"body":"Solved it by adding a new directive and preventing more input rather than just warning user that they have entered too much. ","created_at":"2015-11-23T23:13:07Z","updated_at":"2015-11-24T09:04:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fceb188def2df4ab260cde482c88bd5ef1241ae3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MACSIFS/IFS/pulls/58/commits","review_comments_url":"https://api.github.com/repos/MACSIFS/IFS/pulls/58/comments","review_comment_url":"https://api.github.com/repos/MACSIFS/IFS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MACSIFS/IFS/issues/58/comments","statuses_url":"https://api.github.com/repos/MACSIFS/IFS/statuses/cf5f86f5b5ae9cc56a96bd1e3e876da4901c61ea","head":{"label":"MACSIFS:feature/IFS-94","ref":"feature/IFS-94","sha":"cf5f86f5b5ae9cc56a96bd1e3e876da4901c61ea","user":{"login":"MACSIFS","id":14109764,"avatar_url":"https://avatars.githubusercontent.com/u/14109764?v=3","gravatar_id":"","url":"https://api.github.com/users/MACSIFS","html_url":"https://github.com/MACSIFS","followers_url":"https://api.github.com/users/MACSIFS/followers","following_url":"https://api.github.com/users/MACSIFS/following{/other_user}","gists_url":"https://api.github.com/users/MACSIFS/gists{/gist_id}","starred_url":"https://api.github.com/users/MACSIFS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MACSIFS/subscriptions","organizations_url":"https://api.github.com/users/MACSIFS/orgs","repos_url":"https://api.github.com/users/MACSIFS/repos","events_url":"https://api.github.com/users/MACSIFS/events{/privacy}","received_events_url":"https://api.github.com/users/MACSIFS/received_events","type":"Organization","site_admin":false},"repo":{"id":41859937,"name":"IFS","full_name":"MACSIFS/IFS","owner":{"login":"MACSIFS","id":14109764,"avatar_url":"https://avatars.githubusercontent.com/u/14109764?v=3","gravatar_id":"","url":"https://api.github.com/users/MACSIFS","html_url":"https://github.com/MACSIFS","followers_url":"https://api.github.com/users/MACSIFS/followers","following_url":"https://api.github.com/users/MACSIFS/following{/other_user}","gists_url":"https://api.github.com/users/MACSIFS/gists{/gist_id}","starred_url":"https://api.github.com/users/MACSIFS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MACSIFS/subscriptions","organizations_url":"https://api.github.com/users/MACSIFS/orgs","repos_url":"https://api.github.com/users/MACSIFS/repos","events_url":"https://api.github.com/users/MACSIFS/events{/privacy}","received_events_url":"https://api.github.com/users/MACSIFS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MACSIFS/IFS","description":"Interactive Feedback System","fork":false,"url":"https://api.github.com/repos/MACSIFS/IFS","forks_url":"https://api.github.com/repos/MACSIFS/IFS/forks","keys_url":"https://api.github.com/repos/MACSIFS/IFS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MACSIFS/IFS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MACSIFS/IFS/teams","hooks_url":"https://api.github.com/repos/MACSIFS/IFS/hooks","issue_events_url":"https://api.github.com/repos/MACSIFS/IFS/issues/events{/number}","events_url":"https://api.github.com/repos/MACSIFS/IFS/events","assignees_url":"https://api.github.com/repos/MACSIFS/IFS/assignees{/user}","branches_url":"https://api.github.com/repos/MACSIFS/IFS/branches{/branch}","tags_url":"https://api.github.com/repos/MACSIFS/IFS/tags","blobs_url":"https://api.github.com/repos/MACSIFS/IFS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MACSIFS/IFS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MACSIFS/IFS/git/refs{/sha}","trees_url":"https://api.github.com/repos/MACSIFS/IFS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MACSIFS/IFS/statuses/{sha}","languages_url":"https://api.github.com/repos/MACSIFS/IFS/languages","stargazers_url":"https://api.github.com/repos/MACSIFS/IFS/stargazers","contributors_url":"https://api.github.com/repos/MACSIFS/IFS/contributors","subscribers_url":"https://api.github.com/repos/MACSIFS/IFS/subscribers","subscription_url":"https://api.github.com/repos/MACSIFS/IFS/subscription","commits_url":"https://api.github.com/repos/MACSIFS/IFS/commits{/sha}","git_commits_url":"https://api.github.com/repos/MACSIFS/IFS/git/commits{/sha}","comments_url":"https://api.github.com/repos/MACSIFS/IFS/comments{/number}","issue_comment_url":"https://api.github.com/repos/MACSIFS/IFS/issues/comments{/number}","contents_url":"https://api.github.com/repos/MACSIFS/IFS/contents/{+path}","compare_url":"https://api.github.com/repos/MACSIFS/IFS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MACSIFS/IFS/merges","archive_url":"https://api.github.com/repos/MACSIFS/IFS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MACSIFS/IFS/downloads","issues_url":"https://api.github.com/repos/MACSIFS/IFS/issues{/number}","pulls_url":"https://api.github.com/repos/MACSIFS/IFS/pulls{/number}","milestones_url":"https://api.github.com/repos/MACSIFS/IFS/milestones{/number}","notifications_url":"https://api.github.com/repos/MACSIFS/IFS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MACSIFS/IFS/labels{/name}","releases_url":"https://api.github.com/repos/MACSIFS/IFS/releases{/id}","created_at":"2015-09-03T13:01:12Z","updated_at":"2015-11-03T09:18:02Z","pushed_at":"2015-11-24T08:59:08Z","git_url":"git://github.com/MACSIFS/IFS.git","ssh_url":"git@github.com:MACSIFS/IFS.git","clone_url":"https://github.com/MACSIFS/IFS.git","svn_url":"https://github.com/MACSIFS/IFS","homepage":"","size":929,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":2,"default_branch":"develop"}},"base":{"label":"MACSIFS:develop","ref":"develop","sha":"24abb12c6d39f2fa71b7b540fbc4b52733a21d7e","user":{"login":"MACSIFS","id":14109764,"avatar_url":"https://avatars.githubusercontent.com/u/14109764?v=3","gravatar_id":"","url":"https://api.github.com/users/MACSIFS","html_url":"https://github.com/MACSIFS","followers_url":"https://api.github.com/users/MACSIFS/followers","following_url":"https://api.github.com/users/MACSIFS/following{/other_user}","gists_url":"https://api.github.com/users/MACSIFS/gists{/gist_id}","starred_url":"https://api.github.com/users/MACSIFS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MACSIFS/subscriptions","organizations_url":"https://api.github.com/users/MACSIFS/orgs","repos_url":"https://api.github.com/users/MACSIFS/repos","events_url":"https://api.github.com/users/MACSIFS/events{/privacy}","received_events_url":"https://api.github.com/users/MACSIFS/received_events","type":"Organization","site_admin":false},"repo":{"id":41859937,"name":"IFS","full_name":"MACSIFS/IFS","owner":{"login":"MACSIFS","id":14109764,"avatar_url":"https://avatars.githubusercontent.com/u/14109764?v=3","gravatar_id":"","url":"https://api.github.com/users/MACSIFS","html_url":"https://github.com/MACSIFS","followers_url":"https://api.github.com/users/MACSIFS/followers","following_url":"https://api.github.com/users/MACSIFS/following{/other_user}","gists_url":"https://api.github.com/users/MACSIFS/gists{/gist_id}","starred_url":"https://api.github.com/users/MACSIFS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MACSIFS/subscriptions","organizations_url":"https://api.github.com/users/MACSIFS/orgs","repos_url":"https://api.github.com/users/MACSIFS/repos","events_url":"https://api.github.com/users/MACSIFS/events{/privacy}","received_events_url":"https://api.github.com/users/MACSIFS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MACSIFS/IFS","description":"Interactive Feedback System","fork":false,"url":"https://api.github.com/repos/MACSIFS/IFS","forks_url":"https://api.github.com/repos/MACSIFS/IFS/forks","keys_url":"https://api.github.com/repos/MACSIFS/IFS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MACSIFS/IFS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MACSIFS/IFS/teams","hooks_url":"https://api.github.com/repos/MACSIFS/IFS/hooks","issue_events_url":"https://api.github.com/repos/MACSIFS/IFS/issues/events{/number}","events_url":"https://api.github.com/repos/MACSIFS/IFS/events","assignees_url":"https://api.github.com/repos/MACSIFS/IFS/assignees{/user}","branches_url":"https://api.github.com/repos/MACSIFS/IFS/branches{/branch}","tags_url":"https://api.github.com/repos/MACSIFS/IFS/tags","blobs_url":"https://api.github.com/repos/MACSIFS/IFS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MACSIFS/IFS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MACSIFS/IFS/git/refs{/sha}","trees_url":"https://api.github.com/repos/MACSIFS/IFS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MACSIFS/IFS/statuses/{sha}","languages_url":"https://api.github.com/repos/MACSIFS/IFS/languages","stargazers_url":"https://api.github.com/repos/MACSIFS/IFS/stargazers","contributors_url":"https://api.github.com/repos/MACSIFS/IFS/contributors","subscribers_url":"https://api.github.com/repos/MACSIFS/IFS/subscribers","subscription_url":"https://api.github.com/repos/MACSIFS/IFS/subscription","commits_url":"https://api.github.com/repos/MACSIFS/IFS/commits{/sha}","git_commits_url":"https://api.github.com/repos/MACSIFS/IFS/git/commits{/sha}","comments_url":"https://api.github.com/repos/MACSIFS/IFS/comments{/number}","issue_comment_url":"https://api.github.com/repos/MACSIFS/IFS/issues/comments{/number}","contents_url":"https://api.github.com/repos/MACSIFS/IFS/contents/{+path}","compare_url":"https://api.github.com/repos/MACSIFS/IFS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MACSIFS/IFS/merges","archive_url":"https://api.github.com/repos/MACSIFS/IFS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MACSIFS/IFS/downloads","issues_url":"https://api.github.com/repos/MACSIFS/IFS/issues{/number}","pulls_url":"https://api.github.com/repos/MACSIFS/IFS/pulls{/number}","milestones_url":"https://api.github.com/repos/MACSIFS/IFS/milestones{/number}","notifications_url":"https://api.github.com/repos/MACSIFS/IFS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MACSIFS/IFS/labels{/name}","releases_url":"https://api.github.com/repos/MACSIFS/IFS/releases{/id}","created_at":"2015-09-03T13:01:12Z","updated_at":"2015-11-03T09:18:02Z","pushed_at":"2015-11-24T08:59:08Z","git_url":"git://github.com/MACSIFS/IFS.git","ssh_url":"git@github.com:MACSIFS/IFS.git","clone_url":"https://github.com/MACSIFS/IFS.git","svn_url":"https://github.com/MACSIFS/IFS","homepage":"","size":929,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/MACSIFS/IFS/pulls/58"},"html":{"href":"https://github.com/MACSIFS/IFS/pull/58"},"issue":{"href":"https://api.github.com/repos/MACSIFS/IFS/issues/58"},"comments":{"href":"https://api.github.com/repos/MACSIFS/IFS/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/MACSIFS/IFS/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/MACSIFS/IFS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MACSIFS/IFS/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/MACSIFS/IFS/statuses/cf5f86f5b5ae9cc56a96bd1e3e876da4901c61ea"}}}}