{"action":"created","issue":{"url":"https://api.github.com/repos/yhat/ggplot/issues/360","labels_url":"https://api.github.com/repos/yhat/ggplot/issues/360/labels{/name}","comments_url":"https://api.github.com/repos/yhat/ggplot/issues/360/comments","events_url":"https://api.github.com/repos/yhat/ggplot/issues/360/events","html_url":"https://github.com/yhat/ggplot/pull/360","id":40447787,"number":360,"title":"WIP: Proper scales","user":{"login":"has2k1","id":780341,"avatar_url":"https://avatars.githubusercontent.com/u/780341?v=3","gravatar_id":"","url":"https://api.github.com/users/has2k1","html_url":"https://github.com/has2k1","followers_url":"https://api.github.com/users/has2k1/followers","following_url":"https://api.github.com/users/has2k1/following{/other_user}","gists_url":"https://api.github.com/users/has2k1/gists{/gist_id}","starred_url":"https://api.github.com/users/has2k1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/has2k1/subscriptions","organizations_url":"https://api.github.com/users/has2k1/orgs","repos_url":"https://api.github.com/users/has2k1/repos","events_url":"https://api.github.com/users/has2k1/events{/privacy}","received_events_url":"https://api.github.com/users/has2k1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2014-08-18T00:40:51Z","updated_at":"2015-04-21T11:49:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/yhat/ggplot/pulls/360","html_url":"https://github.com/yhat/ggplot/pull/360","diff_url":"https://github.com/yhat/ggplot/pull/360.diff","patch_url":"https://github.com/yhat/ggplot/pull/360.patch"},"body":"Covers #283 and touches on stuff discussed in #259 and #221.\r\n\r\nThis is a complete rewrite of ~~the plotting pipeline~~ nearly everything so as to not to violate the [layered-grammar](http://vita.had.co.nz/papers/layered-grammar.pdf). As such there is a close adherence to the ggplot2 ~~plot building pipeline~~ code base.\r\n\r\nIt is far from being done, the following need to be addressed:\r\n- [x] scale transformations e.g. `log10, sqrt` (concerns in #283)\r\n- [x] matplotlib subplotting stuff\r\n- [x] Legend\r\n- [ ] Theme all elements of the plot\r\n- [ ] Rebase and apply changes\r\n- [ ] Comprehensive tests\r\n- [ ] Code profiling\r\n- [ ] pep8"},"comment":{"url":"https://api.github.com/repos/yhat/ggplot/issues/comments/94758784","html_url":"https://github.com/yhat/ggplot/pull/360#issuecomment-94758784","issue_url":"https://api.github.com/repos/yhat/ggplot/issues/360","id":94758784,"user":{"login":"JanSchulz","id":890156,"avatar_url":"https://avatars.githubusercontent.com/u/890156?v=3","gravatar_id":"","url":"https://api.github.com/users/JanSchulz","html_url":"https://github.com/JanSchulz","followers_url":"https://api.github.com/users/JanSchulz/followers","following_url":"https://api.github.com/users/JanSchulz/following{/other_user}","gists_url":"https://api.github.com/users/JanSchulz/gists{/gist_id}","starred_url":"https://api.github.com/users/JanSchulz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanSchulz/subscriptions","organizations_url":"https://api.github.com/users/JanSchulz/orgs","repos_url":"https://api.github.com/users/JanSchulz/repos","events_url":"https://api.github.com/users/JanSchulz/events{/privacy}","received_events_url":"https://api.github.com/users/JanSchulz/received_events","type":"User","site_admin":false},"created_at":"2015-04-21T11:49:00Z","updated_at":"2015-04-21T11:49:00Z","body":"@has2k1 Can you do a rebase so that travis can do it's work again? This PR is quite big and I fear that merging it will be quite hard, so makeing it any easier would be good\r\n\r\n-> rebase (and maybe squash together into more logical units), so that one can see the difference and also get travis running again?\r\n-> enable the unittests so that one can be sure that this doesn't break (too much)\r\n-> build more unittests?\r\n\r\nIt would probably also be good to get this into a branch in the default repo, so that others can try it more easily -> @glamp, what do you say?"}}