{"action":"opened","number":7,"pull_request":{"url":"https://api.github.com/repos/nurkiewicz/async-retry/pulls/7","id":36066760,"html_url":"https://github.com/nurkiewicz/async-retry/pull/7","diff_url":"https://github.com/nurkiewicz/async-retry/pull/7.diff","patch_url":"https://github.com/nurkiewicz/async-retry/pull/7.patch","issue_url":"https://api.github.com/repos/nurkiewicz/async-retry/issues/7","number":7,"state":"open","locked":false,"title":"Errors from predicates are silently ignored","user":{"login":"chaptastic","id":24507,"avatar_url":"https://avatars.githubusercontent.com/u/24507?v=3","gravatar_id":"","url":"https://api.github.com/users/chaptastic","html_url":"https://github.com/chaptastic","followers_url":"https://api.github.com/users/chaptastic/followers","following_url":"https://api.github.com/users/chaptastic/following{/other_user}","gists_url":"https://api.github.com/users/chaptastic/gists{/gist_id}","starred_url":"https://api.github.com/users/chaptastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaptastic/subscriptions","organizations_url":"https://api.github.com/users/chaptastic/orgs","repos_url":"https://api.github.com/users/chaptastic/repos","events_url":"https://api.github.com/users/chaptastic/events{/privacy}","received_events_url":"https://api.github.com/users/chaptastic/received_events","type":"User","site_admin":false},"body":"I ran into an issue with a predicate that was throwing an NPE causing the future to never complete or be retried. This patch catches any errors thrown while testing a caught Throwable and logs them then completes the future with the original Throwable.","created_at":"2015-05-22T20:36:39Z","updated_at":"2015-05-22T20:36:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nurkiewicz/async-retry/pulls/7/commits","review_comments_url":"https://api.github.com/repos/nurkiewicz/async-retry/pulls/7/comments","review_comment_url":"https://api.github.com/repos/nurkiewicz/async-retry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nurkiewicz/async-retry/issues/7/comments","statuses_url":"https://api.github.com/repos/nurkiewicz/async-retry/statuses/9724cbc60374c772ccb4f295cccaabcbc8dc1f67","head":{"label":"chaptastic:predicate-throws","ref":"predicate-throws","sha":"9724cbc60374c772ccb4f295cccaabcbc8dc1f67","user":{"login":"chaptastic","id":24507,"avatar_url":"https://avatars.githubusercontent.com/u/24507?v=3","gravatar_id":"","url":"https://api.github.com/users/chaptastic","html_url":"https://github.com/chaptastic","followers_url":"https://api.github.com/users/chaptastic/followers","following_url":"https://api.github.com/users/chaptastic/following{/other_user}","gists_url":"https://api.github.com/users/chaptastic/gists{/gist_id}","starred_url":"https://api.github.com/users/chaptastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaptastic/subscriptions","organizations_url":"https://api.github.com/users/chaptastic/orgs","repos_url":"https://api.github.com/users/chaptastic/repos","events_url":"https://api.github.com/users/chaptastic/events{/privacy}","received_events_url":"https://api.github.com/users/chaptastic/received_events","type":"User","site_admin":false},"repo":{"id":36073004,"name":"async-retry","full_name":"chaptastic/async-retry","owner":{"login":"chaptastic","id":24507,"avatar_url":"https://avatars.githubusercontent.com/u/24507?v=3","gravatar_id":"","url":"https://api.github.com/users/chaptastic","html_url":"https://github.com/chaptastic","followers_url":"https://api.github.com/users/chaptastic/followers","following_url":"https://api.github.com/users/chaptastic/following{/other_user}","gists_url":"https://api.github.com/users/chaptastic/gists{/gist_id}","starred_url":"https://api.github.com/users/chaptastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaptastic/subscriptions","organizations_url":"https://api.github.com/users/chaptastic/orgs","repos_url":"https://api.github.com/users/chaptastic/repos","events_url":"https://api.github.com/users/chaptastic/events{/privacy}","received_events_url":"https://api.github.com/users/chaptastic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chaptastic/async-retry","description":"Asynchronous retrying for Java 7/8","fork":true,"url":"https://api.github.com/repos/chaptastic/async-retry","forks_url":"https://api.github.com/repos/chaptastic/async-retry/forks","keys_url":"https://api.github.com/repos/chaptastic/async-retry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chaptastic/async-retry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chaptastic/async-retry/teams","hooks_url":"https://api.github.com/repos/chaptastic/async-retry/hooks","issue_events_url":"https://api.github.com/repos/chaptastic/async-retry/issues/events{/number}","events_url":"https://api.github.com/repos/chaptastic/async-retry/events","assignees_url":"https://api.github.com/repos/chaptastic/async-retry/assignees{/user}","branches_url":"https://api.github.com/repos/chaptastic/async-retry/branches{/branch}","tags_url":"https://api.github.com/repos/chaptastic/async-retry/tags","blobs_url":"https://api.github.com/repos/chaptastic/async-retry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chaptastic/async-retry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chaptastic/async-retry/git/refs{/sha}","trees_url":"https://api.github.com/repos/chaptastic/async-retry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chaptastic/async-retry/statuses/{sha}","languages_url":"https://api.github.com/repos/chaptastic/async-retry/languages","stargazers_url":"https://api.github.com/repos/chaptastic/async-retry/stargazers","contributors_url":"https://api.github.com/repos/chaptastic/async-retry/contributors","subscribers_url":"https://api.github.com/repos/chaptastic/async-retry/subscribers","subscription_url":"https://api.github.com/repos/chaptastic/async-retry/subscription","commits_url":"https://api.github.com/repos/chaptastic/async-retry/commits{/sha}","git_commits_url":"https://api.github.com/repos/chaptastic/async-retry/git/commits{/sha}","comments_url":"https://api.github.com/repos/chaptastic/async-retry/comments{/number}","issue_comment_url":"https://api.github.com/repos/chaptastic/async-retry/issues/comments{/number}","contents_url":"https://api.github.com/repos/chaptastic/async-retry/contents/{+path}","compare_url":"https://api.github.com/repos/chaptastic/async-retry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chaptastic/async-retry/merges","archive_url":"https://api.github.com/repos/chaptastic/async-retry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chaptastic/async-retry/downloads","issues_url":"https://api.github.com/repos/chaptastic/async-retry/issues{/number}","pulls_url":"https://api.github.com/repos/chaptastic/async-retry/pulls{/number}","milestones_url":"https://api.github.com/repos/chaptastic/async-retry/milestones{/number}","notifications_url":"https://api.github.com/repos/chaptastic/async-retry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chaptastic/async-retry/labels{/name}","releases_url":"https://api.github.com/repos/chaptastic/async-retry/releases{/id}","created_at":"2015-05-22T13:12:21Z","updated_at":"2015-05-22T13:12:21Z","pushed_at":"2015-05-22T20:35:28Z","git_url":"git://github.com/chaptastic/async-retry.git","ssh_url":"git@github.com:chaptastic/async-retry.git","clone_url":"https://github.com/chaptastic/async-retry.git","svn_url":"https://github.com/chaptastic/async-retry","homepage":"http://nurkiewicz.blogspot.com/2013/07/asynchronous-retry-pattern.html","size":266,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nurkiewicz:master","ref":"master","sha":"47d9f67b5ffed7508b13ca93c515c59393a0b516","user":{"login":"nurkiewicz","id":164045,"avatar_url":"https://avatars.githubusercontent.com/u/164045?v=3","gravatar_id":"","url":"https://api.github.com/users/nurkiewicz","html_url":"https://github.com/nurkiewicz","followers_url":"https://api.github.com/users/nurkiewicz/followers","following_url":"https://api.github.com/users/nurkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/nurkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/nurkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nurkiewicz/subscriptions","organizations_url":"https://api.github.com/users/nurkiewicz/orgs","repos_url":"https://api.github.com/users/nurkiewicz/repos","events_url":"https://api.github.com/users/nurkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/nurkiewicz/received_events","type":"User","site_admin":false},"repo":{"id":11551617,"name":"async-retry","full_name":"nurkiewicz/async-retry","owner":{"login":"nurkiewicz","id":164045,"avatar_url":"https://avatars.githubusercontent.com/u/164045?v=3","gravatar_id":"","url":"https://api.github.com/users/nurkiewicz","html_url":"https://github.com/nurkiewicz","followers_url":"https://api.github.com/users/nurkiewicz/followers","following_url":"https://api.github.com/users/nurkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/nurkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/nurkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nurkiewicz/subscriptions","organizations_url":"https://api.github.com/users/nurkiewicz/orgs","repos_url":"https://api.github.com/users/nurkiewicz/repos","events_url":"https://api.github.com/users/nurkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/nurkiewicz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nurkiewicz/async-retry","description":"Asynchronous retrying for Java 7/8","fork":false,"url":"https://api.github.com/repos/nurkiewicz/async-retry","forks_url":"https://api.github.com/repos/nurkiewicz/async-retry/forks","keys_url":"https://api.github.com/repos/nurkiewicz/async-retry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nurkiewicz/async-retry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nurkiewicz/async-retry/teams","hooks_url":"https://api.github.com/repos/nurkiewicz/async-retry/hooks","issue_events_url":"https://api.github.com/repos/nurkiewicz/async-retry/issues/events{/number}","events_url":"https://api.github.com/repos/nurkiewicz/async-retry/events","assignees_url":"https://api.github.com/repos/nurkiewicz/async-retry/assignees{/user}","branches_url":"https://api.github.com/repos/nurkiewicz/async-retry/branches{/branch}","tags_url":"https://api.github.com/repos/nurkiewicz/async-retry/tags","blobs_url":"https://api.github.com/repos/nurkiewicz/async-retry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nurkiewicz/async-retry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nurkiewicz/async-retry/git/refs{/sha}","trees_url":"https://api.github.com/repos/nurkiewicz/async-retry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nurkiewicz/async-retry/statuses/{sha}","languages_url":"https://api.github.com/repos/nurkiewicz/async-retry/languages","stargazers_url":"https://api.github.com/repos/nurkiewicz/async-retry/stargazers","contributors_url":"https://api.github.com/repos/nurkiewicz/async-retry/contributors","subscribers_url":"https://api.github.com/repos/nurkiewicz/async-retry/subscribers","subscription_url":"https://api.github.com/repos/nurkiewicz/async-retry/subscription","commits_url":"https://api.github.com/repos/nurkiewicz/async-retry/commits{/sha}","git_commits_url":"https://api.github.com/repos/nurkiewicz/async-retry/git/commits{/sha}","comments_url":"https://api.github.com/repos/nurkiewicz/async-retry/comments{/number}","issue_comment_url":"https://api.github.com/repos/nurkiewicz/async-retry/issues/comments{/number}","contents_url":"https://api.github.com/repos/nurkiewicz/async-retry/contents/{+path}","compare_url":"https://api.github.com/repos/nurkiewicz/async-retry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nurkiewicz/async-retry/merges","archive_url":"https://api.github.com/repos/nurkiewicz/async-retry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nurkiewicz/async-retry/downloads","issues_url":"https://api.github.com/repos/nurkiewicz/async-retry/issues{/number}","pulls_url":"https://api.github.com/repos/nurkiewicz/async-retry/pulls{/number}","milestones_url":"https://api.github.com/repos/nurkiewicz/async-retry/milestones{/number}","notifications_url":"https://api.github.com/repos/nurkiewicz/async-retry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nurkiewicz/async-retry/labels{/name}","releases_url":"https://api.github.com/repos/nurkiewicz/async-retry/releases{/id}","created_at":"2013-07-20T19:00:12Z","updated_at":"2015-05-20T21:15:51Z","pushed_at":"2014-12-21T17:51:46Z","git_url":"git://github.com/nurkiewicz/async-retry.git","ssh_url":"git@github.com:nurkiewicz/async-retry.git","clone_url":"https://github.com/nurkiewicz/async-retry.git","svn_url":"https://github.com/nurkiewicz/async-retry","homepage":"http://nurkiewicz.blogspot.com/2013/07/asynchronous-retry-pattern.html","size":558,"stargazers_count":133,"watchers_count":133,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":3,"forks":13,"open_issues":3,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nurkiewicz/async-retry/pulls/7"},"html":{"href":"https://github.com/nurkiewicz/async-retry/pull/7"},"issue":{"href":"https://api.github.com/repos/nurkiewicz/async-retry/issues/7"},"comments":{"href":"https://api.github.com/repos/nurkiewicz/async-retry/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/nurkiewicz/async-retry/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/nurkiewicz/async-retry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nurkiewicz/async-retry/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/nurkiewicz/async-retry/statuses/9724cbc60374c772ccb4f295cccaabcbc8dc1f67"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":40,"deletions":5,"changed_files":2}}