{"action":"opened","number":111,"pull_request":{"url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/pulls/111","id":50024689,"html_url":"https://github.com/Reactive-Extensions/rx.angular.js/pull/111","diff_url":"https://github.com/Reactive-Extensions/rx.angular.js/pull/111.diff","patch_url":"https://github.com/Reactive-Extensions/rx.angular.js/pull/111.patch","issue_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/issues/111","number":111,"state":"open","locked":false,"title":"fix safeApply when scope is destroyed","user":{"login":"PaulGiletich","id":1554577,"avatar_url":"https://avatars.githubusercontent.com/u/1554577?v=3","gravatar_id":"","url":"https://api.github.com/users/PaulGiletich","html_url":"https://github.com/PaulGiletich","followers_url":"https://api.github.com/users/PaulGiletich/followers","following_url":"https://api.github.com/users/PaulGiletich/following{/other_user}","gists_url":"https://api.github.com/users/PaulGiletich/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulGiletich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulGiletich/subscriptions","organizations_url":"https://api.github.com/users/PaulGiletich/orgs","repos_url":"https://api.github.com/users/PaulGiletich/repos","events_url":"https://api.github.com/users/PaulGiletich/events{/privacy}","received_events_url":"https://api.github.com/users/PaulGiletich/received_events","type":"User","site_admin":false},"body":"When $scope is destroyed, its $root sets to null and safeApply throws\r\n`Uncaught TypeError: Cannot read property '$$phase' of undefined.`\r\n\r\nMy proposition is to dispose safeApply observable when $scope is '$$destroyed' as there is no much sense in updating destroyed scope","created_at":"2015-11-07T01:43:25Z","updated_at":"2015-11-07T01:43:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/pulls/111/commits","review_comments_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/pulls/111/comments","review_comment_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/issues/111/comments","statuses_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/statuses/30647a5cbd163a88982ed94bc4a7ea4d52b0ab3b","head":{"label":"PaulGiletich:master","ref":"master","sha":"30647a5cbd163a88982ed94bc4a7ea4d52b0ab3b","user":{"login":"PaulGiletich","id":1554577,"avatar_url":"https://avatars.githubusercontent.com/u/1554577?v=3","gravatar_id":"","url":"https://api.github.com/users/PaulGiletich","html_url":"https://github.com/PaulGiletich","followers_url":"https://api.github.com/users/PaulGiletich/followers","following_url":"https://api.github.com/users/PaulGiletich/following{/other_user}","gists_url":"https://api.github.com/users/PaulGiletich/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulGiletich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulGiletich/subscriptions","organizations_url":"https://api.github.com/users/PaulGiletich/orgs","repos_url":"https://api.github.com/users/PaulGiletich/repos","events_url":"https://api.github.com/users/PaulGiletich/events{/privacy}","received_events_url":"https://api.github.com/users/PaulGiletich/received_events","type":"User","site_admin":false},"repo":{"id":45716544,"name":"rx.angular.js","full_name":"PaulGiletich/rx.angular.js","owner":{"login":"PaulGiletich","id":1554577,"avatar_url":"https://avatars.githubusercontent.com/u/1554577?v=3","gravatar_id":"","url":"https://api.github.com/users/PaulGiletich","html_url":"https://github.com/PaulGiletich","followers_url":"https://api.github.com/users/PaulGiletich/followers","following_url":"https://api.github.com/users/PaulGiletich/following{/other_user}","gists_url":"https://api.github.com/users/PaulGiletich/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulGiletich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulGiletich/subscriptions","organizations_url":"https://api.github.com/users/PaulGiletich/orgs","repos_url":"https://api.github.com/users/PaulGiletich/repos","events_url":"https://api.github.com/users/PaulGiletich/events{/privacy}","received_events_url":"https://api.github.com/users/PaulGiletich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PaulGiletich/rx.angular.js","description":"AngularJS Bindings for RxJS","fork":true,"url":"https://api.github.com/repos/PaulGiletich/rx.angular.js","forks_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/forks","keys_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/teams","hooks_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/hooks","issue_events_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/events","assignees_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/tags","blobs_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/languages","stargazers_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/stargazers","contributors_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/contributors","subscribers_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/subscribers","subscription_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/subscription","commits_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/merges","archive_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/downloads","issues_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/labels{/name}","releases_url":"https://api.github.com/repos/PaulGiletich/rx.angular.js/releases{/id}","created_at":"2015-11-07T00:54:13Z","updated_at":"2015-11-07T00:54:14Z","pushed_at":"2015-11-07T01:08:32Z","git_url":"git://github.com/PaulGiletich/rx.angular.js.git","ssh_url":"git@github.com:PaulGiletich/rx.angular.js.git","clone_url":"https://github.com/PaulGiletich/rx.angular.js.git","svn_url":"https://github.com/PaulGiletich/rx.angular.js","homepage":null,"size":773,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Reactive-Extensions:master","ref":"master","sha":"a5e295028a11e07833389fd2070f1afbb1516d78","user":{"login":"Reactive-Extensions","id":984368,"avatar_url":"https://avatars.githubusercontent.com/u/984368?v=3","gravatar_id":"","url":"https://api.github.com/users/Reactive-Extensions","html_url":"https://github.com/Reactive-Extensions","followers_url":"https://api.github.com/users/Reactive-Extensions/followers","following_url":"https://api.github.com/users/Reactive-Extensions/following{/other_user}","gists_url":"https://api.github.com/users/Reactive-Extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/Reactive-Extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reactive-Extensions/subscriptions","organizations_url":"https://api.github.com/users/Reactive-Extensions/orgs","repos_url":"https://api.github.com/users/Reactive-Extensions/repos","events_url":"https://api.github.com/users/Reactive-Extensions/events{/privacy}","received_events_url":"https://api.github.com/users/Reactive-Extensions/received_events","type":"Organization","site_admin":false},"repo":{"id":14647739,"name":"rx.angular.js","full_name":"Reactive-Extensions/rx.angular.js","owner":{"login":"Reactive-Extensions","id":984368,"avatar_url":"https://avatars.githubusercontent.com/u/984368?v=3","gravatar_id":"","url":"https://api.github.com/users/Reactive-Extensions","html_url":"https://github.com/Reactive-Extensions","followers_url":"https://api.github.com/users/Reactive-Extensions/followers","following_url":"https://api.github.com/users/Reactive-Extensions/following{/other_user}","gists_url":"https://api.github.com/users/Reactive-Extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/Reactive-Extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reactive-Extensions/subscriptions","organizations_url":"https://api.github.com/users/Reactive-Extensions/orgs","repos_url":"https://api.github.com/users/Reactive-Extensions/repos","events_url":"https://api.github.com/users/Reactive-Extensions/events{/privacy}","received_events_url":"https://api.github.com/users/Reactive-Extensions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Reactive-Extensions/rx.angular.js","description":"AngularJS Bindings for RxJS","fork":false,"url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js","forks_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/forks","keys_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/teams","hooks_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/hooks","issue_events_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/events","assignees_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/tags","blobs_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/languages","stargazers_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/stargazers","contributors_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/contributors","subscribers_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/subscribers","subscription_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/subscription","commits_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/merges","archive_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/downloads","issues_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/labels{/name}","releases_url":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/releases{/id}","created_at":"2013-11-23T18:15:55Z","updated_at":"2015-11-06T23:23:56Z","pushed_at":"2015-11-07T01:43:25Z","git_url":"git://github.com/Reactive-Extensions/rx.angular.js.git","ssh_url":"git@github.com:Reactive-Extensions/rx.angular.js.git","clone_url":"https://github.com/Reactive-Extensions/rx.angular.js.git","svn_url":"https://github.com/Reactive-Extensions/rx.angular.js","homepage":null,"size":1291,"stargazers_count":436,"watchers_count":436,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":12,"forks":45,"open_issues":12,"watchers":436,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/pulls/111"},"html":{"href":"https://github.com/Reactive-Extensions/rx.angular.js/pull/111"},"issue":{"href":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/issues/111"},"comments":{"href":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/Reactive-Extensions/rx.angular.js/statuses/30647a5cbd163a88982ed94bc4a7ea4d52b0ab3b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":16,"deletions":8,"changed_files":2}}