{"action":"created","issue":{"url":"https://api.github.com/repos/bblimke/webmock/issues/505","labels_url":"https://api.github.com/repos/bblimke/webmock/issues/505/labels{/name}","comments_url":"https://api.github.com/repos/bblimke/webmock/issues/505/comments","events_url":"https://api.github.com/repos/bblimke/webmock/issues/505/events","html_url":"https://github.com/bblimke/webmock/pull/505","id":102430233,"number":505,"title":"Add manticore adapter","user":{"login":"mikeknep","id":2057981,"avatar_url":"https://avatars.githubusercontent.com/u/2057981?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeknep","html_url":"https://github.com/mikeknep","followers_url":"https://api.github.com/users/mikeknep/followers","following_url":"https://api.github.com/users/mikeknep/following{/other_user}","gists_url":"https://api.github.com/users/mikeknep/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeknep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeknep/subscriptions","organizations_url":"https://api.github.com/users/mikeknep/orgs","repos_url":"https://api.github.com/users/mikeknep/repos","events_url":"https://api.github.com/users/mikeknep/events{/privacy}","received_events_url":"https://api.github.com/users/mikeknep/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-21T17:46:25Z","updated_at":"2015-08-21T22:12:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bblimke/webmock/pulls/505","html_url":"https://github.com/bblimke/webmock/pull/505","diff_url":"https://github.com/bblimke/webmock/pull/505.diff","patch_url":"https://github.com/bblimke/webmock/pull/505.patch"},"body":"Adds an adapter for [Manticore](https://github.com/cheald/manticore), addressing #454.\r\n\r\nI don't know if there is any functionality unique to Manticore that warrants additional tests beyond the shared \"with WebMock\" suite. @cheald, any thoughts?\r\n\r\nManticore specs pass locally on JRuby 1.7.8 and JRuby 9.0.0.0. Running the full suite on both JRuby versions yields 36 failing http_rb_adapter specs (this is also the case on master branch).\r\n\r\nI noticed that each adapter's spec_helper is handling array values in headers in unique but similar ways. I think a helper could be added to `WebMock::Util::Headers` to address this duplication. However, rather than add that and refactor across libraries now, I figured it'd be better to keep this PR focused exclusively on Manticore. (I bring this up because this PR adds duplicate `join_array_values` methods in the adapter and spec_helper.)"},"comment":{"url":"https://api.github.com/repos/bblimke/webmock/issues/comments/133577625","html_url":"https://github.com/bblimke/webmock/pull/505#issuecomment-133577625","issue_url":"https://api.github.com/repos/bblimke/webmock/issues/505","id":133577625,"user":{"login":"cheald","id":9830,"avatar_url":"https://avatars.githubusercontent.com/u/9830?v=3","gravatar_id":"","url":"https://api.github.com/users/cheald","html_url":"https://github.com/cheald","followers_url":"https://api.github.com/users/cheald/followers","following_url":"https://api.github.com/users/cheald/following{/other_user}","gists_url":"https://api.github.com/users/cheald/gists{/gist_id}","starred_url":"https://api.github.com/users/cheald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheald/subscriptions","organizations_url":"https://api.github.com/users/cheald/orgs","repos_url":"https://api.github.com/users/cheald/repos","events_url":"https://api.github.com/users/cheald/events{/privacy}","received_events_url":"https://api.github.com/users/cheald/received_events","type":"User","site_admin":false},"created_at":"2015-08-21T22:12:38Z","updated_at":"2015-08-21T22:12:38Z","body":"To be honest I'm probably the wrong person to evaluate the feature coverage; I haven't used WebMock since the early Rails 2 days :)\r\n\r\nManticore does expose an awful lot of functionality, though, but it tries to have a relatively sane and compact (read: testable) interface. I'm happy to advise on specific examples if the WebMock maintainers can enumerate some potentially questionable cases."}}