{"action":"created","issue":{"url":"https://api.github.com/repos/adrianlopezroche/fdupes/issues/11","labels_url":"https://api.github.com/repos/adrianlopezroche/fdupes/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/adrianlopezroche/fdupes/issues/11/comments","events_url":"https://api.github.com/repos/adrianlopezroche/fdupes/issues/11/events","html_url":"https://github.com/adrianlopezroche/fdupes/pull/11","id":54726991,"number":11,"title":"optimize for speed","user":{"login":"ivan-dives","id":740718,"avatar_url":"https://avatars.githubusercontent.com/u/740718?v=3","gravatar_id":"","url":"https://api.github.com/users/ivan-dives","html_url":"https://github.com/ivan-dives","followers_url":"https://api.github.com/users/ivan-dives/followers","following_url":"https://api.github.com/users/ivan-dives/following{/other_user}","gists_url":"https://api.github.com/users/ivan-dives/gists{/gist_id}","starred_url":"https://api.github.com/users/ivan-dives/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivan-dives/subscriptions","organizations_url":"https://api.github.com/users/ivan-dives/orgs","repos_url":"https://api.github.com/users/ivan-dives/repos","events_url":"https://api.github.com/users/ivan-dives/events{/privacy}","received_events_url":"https://api.github.com/users/ivan-dives/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-01-19T05:14:25Z","updated_at":"2015-01-19T15:22:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/adrianlopezroche/fdupes/pulls/11","html_url":"https://github.com/adrianlopezroche/fdupes/pull/11","diff_url":"https://github.com/adrianlopezroche/fdupes/pull/11.diff","patch_url":"https://github.com/adrianlopezroche/fdupes/pull/11.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/adrianlopezroche/fdupes/issues/comments/70510680","html_url":"https://github.com/adrianlopezroche/fdupes/pull/11#issuecomment-70510680","issue_url":"https://api.github.com/repos/adrianlopezroche/fdupes/issues/11","id":70510680,"user":{"login":"adrianlopezroche","id":6228477,"avatar_url":"https://avatars.githubusercontent.com/u/6228477?v=3","gravatar_id":"","url":"https://api.github.com/users/adrianlopezroche","html_url":"https://github.com/adrianlopezroche","followers_url":"https://api.github.com/users/adrianlopezroche/followers","following_url":"https://api.github.com/users/adrianlopezroche/following{/other_user}","gists_url":"https://api.github.com/users/adrianlopezroche/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianlopezroche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianlopezroche/subscriptions","organizations_url":"https://api.github.com/users/adrianlopezroche/orgs","repos_url":"https://api.github.com/users/adrianlopezroche/repos","events_url":"https://api.github.com/users/adrianlopezroche/events{/privacy}","received_events_url":"https://api.github.com/users/adrianlopezroche/received_events","type":"User","site_admin":false},"created_at":"2015-01-19T15:22:53Z","updated_at":"2015-01-19T15:22:53Z","body":"Yes, but have you tested what happens when it does a byte-for-byte\r\ncomparison and that comparison returns a value indicating the files are\r\ndifferent?\r\nOn Jan 19, 2015 11:19 AM, \"Jody Lee Bruchon\" <notifications@github.com>\r\nwrote:\r\n\r\n> Hash collisions cause false duplicate matching. Since files are always\r\n> compared 1:1 after any hash matches, hash collisions will trigger an\r\n> unnecessary full comparison but the final duplicate list never has false\r\n> positives. The hash matching is used to avoid 1:1 comparisons only. It's\r\n> essentially nothing more than an algorithm optimization.\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/adrianlopezroche/fdupes/pull/11#issuecomment-70510113>\r\n> .\r\n>"}}