{"action":"opened","number":14350,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/14350","id":53267765,"html_url":"https://github.com/JuliaLang/julia/pull/14350","diff_url":"https://github.com/JuliaLang/julia/pull/14350.diff","patch_url":"https://github.com/JuliaLang/julia/pull/14350.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/14350","number":14350,"state":"open","locked":false,"title":"Don't locally and incorrectly declare jl_error","user":{"login":"drepper","id":2918631,"avatar_url":"https://avatars.githubusercontent.com/u/2918631?v=3","gravatar_id":"","url":"https://api.github.com/users/drepper","html_url":"https://github.com/drepper","followers_url":"https://api.github.com/users/drepper/followers","following_url":"https://api.github.com/users/drepper/following{/other_user}","gists_url":"https://api.github.com/users/drepper/gists{/gist_id}","starred_url":"https://api.github.com/users/drepper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drepper/subscriptions","organizations_url":"https://api.github.com/users/drepper/orgs","repos_url":"https://api.github.com/users/drepper/repos","events_url":"https://api.github.com/users/drepper/events{/privacy}","received_events_url":"https://api.github.com/users/drepper/received_events","type":"User","site_admin":false},"body":"The local declaration misses the JL_NORETURN attribute.  Trying to add this attribute to the declaration results in requiring the actual definition of JL_NORETURN.\r\n\r\nThis then raises the question why the correct declaration from julia.h isn't used.  I found no reason.  The code compiles and tests OK as before after I added the #include and removed the local declaration.","created_at":"2015-12-10T14:51:11Z","updated_at":"2015-12-10T14:51:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/14350/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/14350/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/14350/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/51f9b70b0c76e24b4b96103e80f343188d8388ec","head":{"label":"drepper:master","ref":"master","sha":"51f9b70b0c76e24b4b96103e80f343188d8388ec","user":{"login":"drepper","id":2918631,"avatar_url":"https://avatars.githubusercontent.com/u/2918631?v=3","gravatar_id":"","url":"https://api.github.com/users/drepper","html_url":"https://github.com/drepper","followers_url":"https://api.github.com/users/drepper/followers","following_url":"https://api.github.com/users/drepper/following{/other_user}","gists_url":"https://api.github.com/users/drepper/gists{/gist_id}","starred_url":"https://api.github.com/users/drepper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drepper/subscriptions","organizations_url":"https://api.github.com/users/drepper/orgs","repos_url":"https://api.github.com/users/drepper/repos","events_url":"https://api.github.com/users/drepper/events{/privacy}","received_events_url":"https://api.github.com/users/drepper/received_events","type":"User","site_admin":false},"repo":{"id":29106017,"name":"julia","full_name":"drepper/julia","owner":{"login":"drepper","id":2918631,"avatar_url":"https://avatars.githubusercontent.com/u/2918631?v=3","gravatar_id":"","url":"https://api.github.com/users/drepper","html_url":"https://github.com/drepper","followers_url":"https://api.github.com/users/drepper/followers","following_url":"https://api.github.com/users/drepper/following{/other_user}","gists_url":"https://api.github.com/users/drepper/gists{/gist_id}","starred_url":"https://api.github.com/users/drepper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drepper/subscriptions","organizations_url":"https://api.github.com/users/drepper/orgs","repos_url":"https://api.github.com/users/drepper/repos","events_url":"https://api.github.com/users/drepper/events{/privacy}","received_events_url":"https://api.github.com/users/drepper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drepper/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/drepper/julia","forks_url":"https://api.github.com/repos/drepper/julia/forks","keys_url":"https://api.github.com/repos/drepper/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drepper/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drepper/julia/teams","hooks_url":"https://api.github.com/repos/drepper/julia/hooks","issue_events_url":"https://api.github.com/repos/drepper/julia/issues/events{/number}","events_url":"https://api.github.com/repos/drepper/julia/events","assignees_url":"https://api.github.com/repos/drepper/julia/assignees{/user}","branches_url":"https://api.github.com/repos/drepper/julia/branches{/branch}","tags_url":"https://api.github.com/repos/drepper/julia/tags","blobs_url":"https://api.github.com/repos/drepper/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drepper/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drepper/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/drepper/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drepper/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/drepper/julia/languages","stargazers_url":"https://api.github.com/repos/drepper/julia/stargazers","contributors_url":"https://api.github.com/repos/drepper/julia/contributors","subscribers_url":"https://api.github.com/repos/drepper/julia/subscribers","subscription_url":"https://api.github.com/repos/drepper/julia/subscription","commits_url":"https://api.github.com/repos/drepper/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/drepper/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/drepper/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/drepper/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/drepper/julia/contents/{+path}","compare_url":"https://api.github.com/repos/drepper/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drepper/julia/merges","archive_url":"https://api.github.com/repos/drepper/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drepper/julia/downloads","issues_url":"https://api.github.com/repos/drepper/julia/issues{/number}","pulls_url":"https://api.github.com/repos/drepper/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/drepper/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/drepper/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drepper/julia/labels{/name}","releases_url":"https://api.github.com/repos/drepper/julia/releases{/id}","created_at":"2015-01-11T21:04:34Z","updated_at":"2015-04-26T23:22:34Z","pushed_at":"2015-12-10T14:47:33Z","git_url":"git://github.com/drepper/julia.git","ssh_url":"git@github.com:drepper/julia.git","clone_url":"https://github.com/drepper/julia.git","svn_url":"https://github.com/drepper/julia","homepage":"http://julialang.org/","size":89457,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"5f7d7d080e62906a1ac9fe6163e1380570c923e9","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","created_at":"2011-04-21T07:01:50Z","updated_at":"2015-12-10T14:50:12Z","pushed_at":"2015-12-10T14:47:11Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":116308,"stargazers_count":6446,"watchers_count":6446,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1438,"mirror_url":null,"open_issues_count":1537,"forks":1438,"open_issues":1537,"watchers":6446,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/14350"},"html":{"href":"https://github.com/JuliaLang/julia/pull/14350"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/14350"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/14350/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/14350/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/14350/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/51f9b70b0c76e24b4b96103e80f343188d8388ec"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}