{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/37488685","id":37488685,"diff_hunk":"@@ -3970,10 +3996,36 @@ for (trsen, tgsen, elty) in\n     end\n end\n \n-for (trsen, tgsen, elty) in\n-    ((:ztrsen_, :ztgsen_, :Complex128),\n-     (:ctrsen_, :ctgsen_, :Complex64))\n+for (trexc, trsen, tgsen, elty) in\n+    ((:ztrexc_, :ztrsen_, :ztgsen_, :Complex128),\n+     (:ctrexc_, :ctrsen_, :ctgsen_, :Complex64))\n     @eval begin\n+        function trexc!(ifst::BlasInt, ilst::BlasInt, T::StridedMatrix{$elty}, Q::StridedMatrix{$elty})\n+# *     .. Scalar Arguments ..\n+#       CHARACTER          COMPQ\n+#       INTEGER            IFST, ILST, INFO, LDQ, LDT, N\n+# *     ..\n+# *     .. Array Arguments ..\n+#       DOUBLE PRECISION   Q( LDQ, * ), T( LDT, * ), WORK( * )\n+            chkstride1(T, Q)\n+            n = chksquare(T)\n+            ldt = max(1, stride(T, 2))\n+            ldq = max(1, stride(Q, 2))\n+            work = Array($elty, 1)","path":"base/linalg/lapack.jl","position":62,"original_position":62,"commit_id":"684dfbfe6fa58f926d39699c6b5d1bd3e138d133","original_commit_id":"684dfbfe6fa58f926d39699c6b5d1bd3e138d133","user":{"login":"andreasnoack","id":505001,"avatar_url":"https://avatars.githubusercontent.com/u/505001?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasnoack","html_url":"https://github.com/andreasnoack","followers_url":"https://api.github.com/users/andreasnoack/followers","following_url":"https://api.github.com/users/andreasnoack/following{/other_user}","gists_url":"https://api.github.com/users/andreasnoack/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasnoack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasnoack/subscriptions","organizations_url":"https://api.github.com/users/andreasnoack/orgs","repos_url":"https://api.github.com/users/andreasnoack/repos","events_url":"https://api.github.com/users/andreasnoack/events{/privacy}","received_events_url":"https://api.github.com/users/andreasnoack/received_events","type":"User","site_admin":false},"body":"The complex versions don't seem to have a `work` argument. See http://www.netlib.org/lapack/explore-html/dd/ddd/ztrexc_8f.html#a470b89b631cac16cac631539465ae014","created_at":"2015-08-20T01:49:09Z","updated_at":"2015-08-20T01:49:09Z","html_url":"https://github.com/JuliaLang/julia/pull/12659#discussion_r37488685","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/12659","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/37488685"},"html":{"href":"https://github.com/JuliaLang/julia/pull/12659#discussion_r37488685"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/12659"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/12659","id":42582873,"html_url":"https://github.com/JuliaLang/julia/pull/12659","diff_url":"https://github.com/JuliaLang/julia/pull/12659.diff","patch_url":"https://github.com/JuliaLang/julia/pull/12659.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/12659","number":12659,"state":"open","locked":false,"title":"Add wrapper for LAPACK _trexc methods (reordering of the Schur form)","user":{"login":"mfasi","id":1710735,"avatar_url":"https://avatars.githubusercontent.com/u/1710735?v=3","gravatar_id":"","url":"https://api.github.com/users/mfasi","html_url":"https://github.com/mfasi","followers_url":"https://api.github.com/users/mfasi/followers","following_url":"https://api.github.com/users/mfasi/following{/other_user}","gists_url":"https://api.github.com/users/mfasi/gists{/gist_id}","starred_url":"https://api.github.com/users/mfasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfasi/subscriptions","organizations_url":"https://api.github.com/users/mfasi/orgs","repos_url":"https://api.github.com/users/mfasi/repos","events_url":"https://api.github.com/users/mfasi/events{/privacy}","received_events_url":"https://api.github.com/users/mfasi/received_events","type":"User","site_admin":false},"body":"I need this wrapper to implement some of the points of #5840 (I'm sure I need it for `funm` and `unwm`). I'd be glad to add a few tests, but I have no idea how to test such an operation. Suggestions are welcome.","created_at":"2015-08-17T12:33:33Z","updated_at":"2015-08-20T01:49:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84e9ad368baf36017a3352bdcea3866e8cda5fbc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/12659/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/12659/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/12659/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/684dfbfe6fa58f926d39699c6b5d1bd3e138d133","head":{"label":"mfasi:lapack_trexc","ref":"lapack_trexc","sha":"684dfbfe6fa58f926d39699c6b5d1bd3e138d133","user":{"login":"mfasi","id":1710735,"avatar_url":"https://avatars.githubusercontent.com/u/1710735?v=3","gravatar_id":"","url":"https://api.github.com/users/mfasi","html_url":"https://github.com/mfasi","followers_url":"https://api.github.com/users/mfasi/followers","following_url":"https://api.github.com/users/mfasi/following{/other_user}","gists_url":"https://api.github.com/users/mfasi/gists{/gist_id}","starred_url":"https://api.github.com/users/mfasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfasi/subscriptions","organizations_url":"https://api.github.com/users/mfasi/orgs","repos_url":"https://api.github.com/users/mfasi/repos","events_url":"https://api.github.com/users/mfasi/events{/privacy}","received_events_url":"https://api.github.com/users/mfasi/received_events","type":"User","site_admin":false},"repo":{"id":34784874,"name":"julia","full_name":"mfasi/julia","owner":{"login":"mfasi","id":1710735,"avatar_url":"https://avatars.githubusercontent.com/u/1710735?v=3","gravatar_id":"","url":"https://api.github.com/users/mfasi","html_url":"https://github.com/mfasi","followers_url":"https://api.github.com/users/mfasi/followers","following_url":"https://api.github.com/users/mfasi/following{/other_user}","gists_url":"https://api.github.com/users/mfasi/gists{/gist_id}","starred_url":"https://api.github.com/users/mfasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfasi/subscriptions","organizations_url":"https://api.github.com/users/mfasi/orgs","repos_url":"https://api.github.com/users/mfasi/repos","events_url":"https://api.github.com/users/mfasi/events{/privacy}","received_events_url":"https://api.github.com/users/mfasi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfasi/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/mfasi/julia","forks_url":"https://api.github.com/repos/mfasi/julia/forks","keys_url":"https://api.github.com/repos/mfasi/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfasi/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfasi/julia/teams","hooks_url":"https://api.github.com/repos/mfasi/julia/hooks","issue_events_url":"https://api.github.com/repos/mfasi/julia/issues/events{/number}","events_url":"https://api.github.com/repos/mfasi/julia/events","assignees_url":"https://api.github.com/repos/mfasi/julia/assignees{/user}","branches_url":"https://api.github.com/repos/mfasi/julia/branches{/branch}","tags_url":"https://api.github.com/repos/mfasi/julia/tags","blobs_url":"https://api.github.com/repos/mfasi/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfasi/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfasi/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfasi/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfasi/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/mfasi/julia/languages","stargazers_url":"https://api.github.com/repos/mfasi/julia/stargazers","contributors_url":"https://api.github.com/repos/mfasi/julia/contributors","subscribers_url":"https://api.github.com/repos/mfasi/julia/subscribers","subscription_url":"https://api.github.com/repos/mfasi/julia/subscription","commits_url":"https://api.github.com/repos/mfasi/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfasi/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfasi/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfasi/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfasi/julia/contents/{+path}","compare_url":"https://api.github.com/repos/mfasi/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfasi/julia/merges","archive_url":"https://api.github.com/repos/mfasi/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfasi/julia/downloads","issues_url":"https://api.github.com/repos/mfasi/julia/issues{/number}","pulls_url":"https://api.github.com/repos/mfasi/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/mfasi/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/mfasi/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfasi/julia/labels{/name}","releases_url":"https://api.github.com/repos/mfasi/julia/releases{/id}","created_at":"2015-04-29T09:28:23Z","updated_at":"2015-04-29T09:28:34Z","pushed_at":"2015-08-18T17:28:30Z","git_url":"git://github.com/mfasi/julia.git","ssh_url":"git@github.com:mfasi/julia.git","clone_url":"https://github.com/mfasi/julia.git","svn_url":"https://github.com/mfasi/julia","homepage":"http://julialang.org/","size":81031,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"f3217a8d123e51f534fffb01c244b4cad887cacf","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","created_at":"2011-04-21T07:01:50Z","updated_at":"2015-08-19T22:24:24Z","pushed_at":"2015-08-20T01:41:40Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":214620,"stargazers_count":5883,"watchers_count":5883,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1277,"mirror_url":null,"open_issues_count":1330,"forks":1277,"open_issues":1330,"watchers":5883,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/12659"},"html":{"href":"https://github.com/JuliaLang/julia/pull/12659"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/12659"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/12659/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/12659/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/12659/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/684dfbfe6fa58f926d39699c6b5d1bd3e138d133"}}}}