{"action":"opened","number":296,"pull_request":{"url":"https://api.github.com/repos/choderalab/openpathsampling/pulls/296","id":39097425,"html_url":"https://github.com/choderalab/openpathsampling/pull/296","diff_url":"https://github.com/choderalab/openpathsampling/pull/296.diff","patch_url":"https://github.com/choderalab/openpathsampling/pull/296.patch","issue_url":"https://api.github.com/repos/choderalab/openpathsampling/issues/296","number":296,"state":"open","locked":false,"title":"Move scheme cleanup","user":{"login":"dwhswenson","id":8178546,"avatar_url":"https://avatars.githubusercontent.com/u/8178546?v=3","gravatar_id":"","url":"https://api.github.com/users/dwhswenson","html_url":"https://github.com/dwhswenson","followers_url":"https://api.github.com/users/dwhswenson/followers","following_url":"https://api.github.com/users/dwhswenson/following{/other_user}","gists_url":"https://api.github.com/users/dwhswenson/gists{/gist_id}","starred_url":"https://api.github.com/users/dwhswenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwhswenson/subscriptions","organizations_url":"https://api.github.com/users/dwhswenson/orgs","repos_url":"https://api.github.com/users/dwhswenson/repos","events_url":"https://api.github.com/users/dwhswenson/events{/privacy}","received_events_url":"https://api.github.com/users/dwhswenson/received_events","type":"User","site_admin":false},"body":"Cleaning up a few things in `MoveStrategy` and `MoveScheme`. First, cleaning up poorly considered redundancies about networks as input. Second, adding a few general functions which might be useful.\r\n\r\n- [x] Remove `.network` from `MoveStrategy` (only belongs in `MoveScheme`)\r\n- [ ] Add `MoveScheme.sanity_check()`: check sampling ensembles not unused; check choice_probability adds up; check for duplicated movers\r\n- [ ] Function to check how many total MC steps expected to get N trials of a given mover\r\n\r\nThat last one will be particularly useful: we define an MC step as *any* single move. But maybe you'd rather count in terms of shooting moves per ensemble -- this is a better measure of computational cost, because the number of MC moves required for this to be the same is very different in all-replica exchange and in nearest-neighbor exchange. (The best measure is number of MD steps taken, but we can't predict that until we've already sampled the ensembles.)\r\n\r\nSo if you're setting up your calculation interactively in IPython, using this function will help you figure out how many MC steps to do.\r\n\r\nIncludes #289, so merge after that.","created_at":"2015-07-02T15:51:38Z","updated_at":"2015-07-02T15:51:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"dwhswenson","id":8178546,"avatar_url":"https://avatars.githubusercontent.com/u/8178546?v=3","gravatar_id":"","url":"https://api.github.com/users/dwhswenson","html_url":"https://github.com/dwhswenson","followers_url":"https://api.github.com/users/dwhswenson/followers","following_url":"https://api.github.com/users/dwhswenson/following{/other_user}","gists_url":"https://api.github.com/users/dwhswenson/gists{/gist_id}","starred_url":"https://api.github.com/users/dwhswenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwhswenson/subscriptions","organizations_url":"https://api.github.com/users/dwhswenson/orgs","repos_url":"https://api.github.com/users/dwhswenson/repos","events_url":"https://api.github.com/users/dwhswenson/events{/privacy}","received_events_url":"https://api.github.com/users/dwhswenson/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/choderalab/openpathsampling/pulls/296/commits","review_comments_url":"https://api.github.com/repos/choderalab/openpathsampling/pulls/296/comments","review_comment_url":"https://api.github.com/repos/choderalab/openpathsampling/pulls/comments{/number}","comments_url":"https://api.github.com/repos/choderalab/openpathsampling/issues/296/comments","statuses_url":"https://api.github.com/repos/choderalab/openpathsampling/statuses/d0616b014ecfed7934e426e44c76cac3fb1d84be","head":{"label":"dwhswenson:move_scheme_cleanup","ref":"move_scheme_cleanup","sha":"d0616b014ecfed7934e426e44c76cac3fb1d84be","user":{"login":"dwhswenson","id":8178546,"avatar_url":"https://avatars.githubusercontent.com/u/8178546?v=3","gravatar_id":"","url":"https://api.github.com/users/dwhswenson","html_url":"https://github.com/dwhswenson","followers_url":"https://api.github.com/users/dwhswenson/followers","following_url":"https://api.github.com/users/dwhswenson/following{/other_user}","gists_url":"https://api.github.com/users/dwhswenson/gists{/gist_id}","starred_url":"https://api.github.com/users/dwhswenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwhswenson/subscriptions","organizations_url":"https://api.github.com/users/dwhswenson/orgs","repos_url":"https://api.github.com/users/dwhswenson/repos","events_url":"https://api.github.com/users/dwhswenson/events{/privacy}","received_events_url":"https://api.github.com/users/dwhswenson/received_events","type":"User","site_admin":false},"repo":{"id":23991437,"name":"openpathsampling","full_name":"dwhswenson/openpathsampling","owner":{"login":"dwhswenson","id":8178546,"avatar_url":"https://avatars.githubusercontent.com/u/8178546?v=3","gravatar_id":"","url":"https://api.github.com/users/dwhswenson","html_url":"https://github.com/dwhswenson","followers_url":"https://api.github.com/users/dwhswenson/followers","following_url":"https://api.github.com/users/dwhswenson/following{/other_user}","gists_url":"https://api.github.com/users/dwhswenson/gists{/gist_id}","starred_url":"https://api.github.com/users/dwhswenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwhswenson/subscriptions","organizations_url":"https://api.github.com/users/dwhswenson/orgs","repos_url":"https://api.github.com/users/dwhswenson/repos","events_url":"https://api.github.com/users/dwhswenson/events{/privacy}","received_events_url":"https://api.github.com/users/dwhswenson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dwhswenson/openpathsampling","description":"A flexible, open framework for path sampling calculations","fork":true,"url":"https://api.github.com/repos/dwhswenson/openpathsampling","forks_url":"https://api.github.com/repos/dwhswenson/openpathsampling/forks","keys_url":"https://api.github.com/repos/dwhswenson/openpathsampling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwhswenson/openpathsampling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwhswenson/openpathsampling/teams","hooks_url":"https://api.github.com/repos/dwhswenson/openpathsampling/hooks","issue_events_url":"https://api.github.com/repos/dwhswenson/openpathsampling/issues/events{/number}","events_url":"https://api.github.com/repos/dwhswenson/openpathsampling/events","assignees_url":"https://api.github.com/repos/dwhswenson/openpathsampling/assignees{/user}","branches_url":"https://api.github.com/repos/dwhswenson/openpathsampling/branches{/branch}","tags_url":"https://api.github.com/repos/dwhswenson/openpathsampling/tags","blobs_url":"https://api.github.com/repos/dwhswenson/openpathsampling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwhswenson/openpathsampling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwhswenson/openpathsampling/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwhswenson/openpathsampling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwhswenson/openpathsampling/statuses/{sha}","languages_url":"https://api.github.com/repos/dwhswenson/openpathsampling/languages","stargazers_url":"https://api.github.com/repos/dwhswenson/openpathsampling/stargazers","contributors_url":"https://api.github.com/repos/dwhswenson/openpathsampling/contributors","subscribers_url":"https://api.github.com/repos/dwhswenson/openpathsampling/subscribers","subscription_url":"https://api.github.com/repos/dwhswenson/openpathsampling/subscription","commits_url":"https://api.github.com/repos/dwhswenson/openpathsampling/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwhswenson/openpathsampling/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwhswenson/openpathsampling/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwhswenson/openpathsampling/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwhswenson/openpathsampling/contents/{+path}","compare_url":"https://api.github.com/repos/dwhswenson/openpathsampling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwhswenson/openpathsampling/merges","archive_url":"https://api.github.com/repos/dwhswenson/openpathsampling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwhswenson/openpathsampling/downloads","issues_url":"https://api.github.com/repos/dwhswenson/openpathsampling/issues{/number}","pulls_url":"https://api.github.com/repos/dwhswenson/openpathsampling/pulls{/number}","milestones_url":"https://api.github.com/repos/dwhswenson/openpathsampling/milestones{/number}","notifications_url":"https://api.github.com/repos/dwhswenson/openpathsampling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwhswenson/openpathsampling/labels{/name}","releases_url":"https://api.github.com/repos/dwhswenson/openpathsampling/releases{/id}","created_at":"2014-09-13T10:15:43Z","updated_at":"2015-05-07T17:33:05Z","pushed_at":"2015-07-02T15:45:15Z","git_url":"git://github.com/dwhswenson/openpathsampling.git","ssh_url":"git@github.com:dwhswenson/openpathsampling.git","clone_url":"https://github.com/dwhswenson/openpathsampling.git","svn_url":"https://github.com/dwhswenson/openpathsampling","homepage":"","size":159652,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"choderalab:master","ref":"master","sha":"78732f144727b37da912bf3eec28b0121b4f172f","user":{"login":"choderalab","id":4217481,"avatar_url":"https://avatars.githubusercontent.com/u/4217481?v=3","gravatar_id":"","url":"https://api.github.com/users/choderalab","html_url":"https://github.com/choderalab","followers_url":"https://api.github.com/users/choderalab/followers","following_url":"https://api.github.com/users/choderalab/following{/other_user}","gists_url":"https://api.github.com/users/choderalab/gists{/gist_id}","starred_url":"https://api.github.com/users/choderalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choderalab/subscriptions","organizations_url":"https://api.github.com/users/choderalab/orgs","repos_url":"https://api.github.com/users/choderalab/repos","events_url":"https://api.github.com/users/choderalab/events{/privacy}","received_events_url":"https://api.github.com/users/choderalab/received_events","type":"Organization","site_admin":false},"repo":{"id":12592267,"name":"openpathsampling","full_name":"choderalab/openpathsampling","owner":{"login":"choderalab","id":4217481,"avatar_url":"https://avatars.githubusercontent.com/u/4217481?v=3","gravatar_id":"","url":"https://api.github.com/users/choderalab","html_url":"https://github.com/choderalab","followers_url":"https://api.github.com/users/choderalab/followers","following_url":"https://api.github.com/users/choderalab/following{/other_user}","gists_url":"https://api.github.com/users/choderalab/gists{/gist_id}","starred_url":"https://api.github.com/users/choderalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choderalab/subscriptions","organizations_url":"https://api.github.com/users/choderalab/orgs","repos_url":"https://api.github.com/users/choderalab/repos","events_url":"https://api.github.com/users/choderalab/events{/privacy}","received_events_url":"https://api.github.com/users/choderalab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/choderalab/openpathsampling","description":"An open source Python framework for transition interface and path sampling calculations.","fork":false,"url":"https://api.github.com/repos/choderalab/openpathsampling","forks_url":"https://api.github.com/repos/choderalab/openpathsampling/forks","keys_url":"https://api.github.com/repos/choderalab/openpathsampling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/choderalab/openpathsampling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/choderalab/openpathsampling/teams","hooks_url":"https://api.github.com/repos/choderalab/openpathsampling/hooks","issue_events_url":"https://api.github.com/repos/choderalab/openpathsampling/issues/events{/number}","events_url":"https://api.github.com/repos/choderalab/openpathsampling/events","assignees_url":"https://api.github.com/repos/choderalab/openpathsampling/assignees{/user}","branches_url":"https://api.github.com/repos/choderalab/openpathsampling/branches{/branch}","tags_url":"https://api.github.com/repos/choderalab/openpathsampling/tags","blobs_url":"https://api.github.com/repos/choderalab/openpathsampling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/choderalab/openpathsampling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/choderalab/openpathsampling/git/refs{/sha}","trees_url":"https://api.github.com/repos/choderalab/openpathsampling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/choderalab/openpathsampling/statuses/{sha}","languages_url":"https://api.github.com/repos/choderalab/openpathsampling/languages","stargazers_url":"https://api.github.com/repos/choderalab/openpathsampling/stargazers","contributors_url":"https://api.github.com/repos/choderalab/openpathsampling/contributors","subscribers_url":"https://api.github.com/repos/choderalab/openpathsampling/subscribers","subscription_url":"https://api.github.com/repos/choderalab/openpathsampling/subscription","commits_url":"https://api.github.com/repos/choderalab/openpathsampling/commits{/sha}","git_commits_url":"https://api.github.com/repos/choderalab/openpathsampling/git/commits{/sha}","comments_url":"https://api.github.com/repos/choderalab/openpathsampling/comments{/number}","issue_comment_url":"https://api.github.com/repos/choderalab/openpathsampling/issues/comments{/number}","contents_url":"https://api.github.com/repos/choderalab/openpathsampling/contents/{+path}","compare_url":"https://api.github.com/repos/choderalab/openpathsampling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/choderalab/openpathsampling/merges","archive_url":"https://api.github.com/repos/choderalab/openpathsampling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/choderalab/openpathsampling/downloads","issues_url":"https://api.github.com/repos/choderalab/openpathsampling/issues{/number}","pulls_url":"https://api.github.com/repos/choderalab/openpathsampling/pulls{/number}","milestones_url":"https://api.github.com/repos/choderalab/openpathsampling/milestones{/number}","notifications_url":"https://api.github.com/repos/choderalab/openpathsampling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/choderalab/openpathsampling/labels{/name}","releases_url":"https://api.github.com/repos/choderalab/openpathsampling/releases{/id}","created_at":"2013-09-04T14:06:28Z","updated_at":"2015-06-28T19:11:06Z","pushed_at":"2015-07-01T14:15:15Z","git_url":"git://github.com/choderalab/openpathsampling.git","ssh_url":"git@github.com:choderalab/openpathsampling.git","clone_url":"https://github.com/choderalab/openpathsampling.git","svn_url":"https://github.com/choderalab/openpathsampling","homepage":"","size":164541,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":45,"forks":4,"open_issues":45,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/choderalab/openpathsampling/pulls/296"},"html":{"href":"https://github.com/choderalab/openpathsampling/pull/296"},"issue":{"href":"https://api.github.com/repos/choderalab/openpathsampling/issues/296"},"comments":{"href":"https://api.github.com/repos/choderalab/openpathsampling/issues/296/comments"},"review_comments":{"href":"https://api.github.com/repos/choderalab/openpathsampling/pulls/296/comments"},"review_comment":{"href":"https://api.github.com/repos/choderalab/openpathsampling/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/choderalab/openpathsampling/pulls/296/commits"},"statuses":{"href":"https://api.github.com/repos/choderalab/openpathsampling/statuses/d0616b014ecfed7934e426e44c76cac3fb1d84be"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":30,"additions":672,"deletions":105,"changed_files":5}}