{"action":"created","comment":{"url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/comments/45023700","id":45023700,"diff_hunk":"@@ -1,34 +1,32 @@\n package akka.persistence.cassandra.journal\n \n-import java.lang.{ Long => JLong }\n+import java.lang.{Long => JLong}\n import java.nio.ByteBuffer\n \n-import com.datastax.driver.core.policies.{LoggingRetryPolicy, RetryPolicy}\n-import com.datastax.driver.core.policies.RetryPolicy.RetryDecision\n-\n-import scala.concurrent._\n-import scala.collection.immutable.Seq\n-import scala.collection.JavaConversions._\n-import scala.math.min\n-import scala.util.{Success, Failure, Try}\n-\n-import akka.persistence.journal.AsyncWriteJournal\n import akka.persistence._\n import akka.persistence.cassandra._\n+import akka.persistence.journal.AsyncWriteJournal\n import akka.serialization.SerializationExtension\n-\n import com.datastax.driver.core._\n+import com.datastax.driver.core.policies.RetryPolicy.RetryDecision\n+import com.datastax.driver.core.policies.{LoggingRetryPolicy, RetryPolicy}\n import com.datastax.driver.core.utils.Bytes\n+import com.typesafe.config.Config\n+\n+import scala.collection.immutable.Seq\n+import scala.concurrent._\n+import scala.math.min\n+import scala.util.{Failure, Success, Try}\n \n-class CassandraJournal extends AsyncWriteJournal with CassandraRecovery with CassandraConfigChecker with CassandraStatements {\n+class CassandraJournal(cfg: Config) extends AsyncWriteJournal with CassandraRecovery with CassandraConfigChecker with CassandraStatements {\n \n-  val config = new CassandraJournalConfig(context.system.settings.config.getConfig(\"cassandra-journal\"))\n+  val config = new CassandraJournalConfig(cfg)\n   val serialization = SerializationExtension(context.system)\n \n   import config._\n \n-  val cluster = clusterBuilder.build\n-  val session = cluster.connect()\n+  lazy val cluster = clusterBuilder.build\n+  lazy val session = cluster.connect()","path":"src/main/scala/akka/persistence/cassandra/journal/CassandraJournal.scala","position":45,"original_position":45,"commit_id":"6357d756da41db83fdee4e983b68baebfa016adc","original_commit_id":"6357d756da41db83fdee4e983b68baebfa016adc","user":{"login":"matlockx","id":936786,"avatar_url":"https://avatars.githubusercontent.com/u/936786?v=3","gravatar_id":"","url":"https://api.github.com/users/matlockx","html_url":"https://github.com/matlockx","followers_url":"https://api.github.com/users/matlockx/followers","following_url":"https://api.github.com/users/matlockx/following{/other_user}","gists_url":"https://api.github.com/users/matlockx/gists{/gist_id}","starred_url":"https://api.github.com/users/matlockx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matlockx/subscriptions","organizations_url":"https://api.github.com/users/matlockx/orgs","repos_url":"https://api.github.com/users/matlockx/repos","events_url":"https://api.github.com/users/matlockx/events{/privacy}","received_events_url":"https://api.github.com/users/matlockx/received_events","type":"User","site_admin":false},"body":"After having a short look I would like to put that into another pr. It's not really related to the config change. I create another one. \r\nBesides that, someone has an idea how to fix the Travis build without messing around with a \"sleep\"? I still think it's a concurrency problem while creating the schema","created_at":"2015-11-17T05:29:23Z","updated_at":"2015-11-17T05:29:23Z","html_url":"https://github.com/krasserm/akka-persistence-cassandra/pull/116#discussion_r45023700","pull_request_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/116","_links":{"self":{"href":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/comments/45023700"},"html":{"href":"https://github.com/krasserm/akka-persistence-cassandra/pull/116#discussion_r45023700"},"pull_request":{"href":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/116","id":50785547,"html_url":"https://github.com/krasserm/akka-persistence-cassandra/pull/116","diff_url":"https://github.com/krasserm/akka-persistence-cassandra/pull/116.diff","patch_url":"https://github.com/krasserm/akka-persistence-cassandra/pull/116.patch","issue_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/issues/116","number":116,"state":"open","locked":false,"title":"#115 Config constructor parameter","user":{"login":"matlockx","id":936786,"avatar_url":"https://avatars.githubusercontent.com/u/936786?v=3","gravatar_id":"","url":"https://api.github.com/users/matlockx","html_url":"https://github.com/matlockx","followers_url":"https://api.github.com/users/matlockx/followers","following_url":"https://api.github.com/users/matlockx/following{/other_user}","gists_url":"https://api.github.com/users/matlockx/gists{/gist_id}","starred_url":"https://api.github.com/users/matlockx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matlockx/subscriptions","organizations_url":"https://api.github.com/users/matlockx/orgs","repos_url":"https://api.github.com/users/matlockx/repos","events_url":"https://api.github.com/users/matlockx/events{/privacy}","received_events_url":"https://api.github.com/users/matlockx/received_events","type":"User","site_admin":false},"body":"Added parameter to journal and snapshot constructor. Also added a test which tests the usage of different configs for a journal and a snapshot store with the same persistence id.","created_at":"2015-11-16T09:09:57Z","updated_at":"2015-11-17T05:29:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"146c3499989ae059648adce878ff82d086798bd0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/116/commits","review_comments_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/116/comments","review_comment_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/issues/116/comments","statuses_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/statuses/6357d756da41db83fdee4e983b68baebfa016adc","head":{"label":"matlockx:master","ref":"master","sha":"6357d756da41db83fdee4e983b68baebfa016adc","user":{"login":"matlockx","id":936786,"avatar_url":"https://avatars.githubusercontent.com/u/936786?v=3","gravatar_id":"","url":"https://api.github.com/users/matlockx","html_url":"https://github.com/matlockx","followers_url":"https://api.github.com/users/matlockx/followers","following_url":"https://api.github.com/users/matlockx/following{/other_user}","gists_url":"https://api.github.com/users/matlockx/gists{/gist_id}","starred_url":"https://api.github.com/users/matlockx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matlockx/subscriptions","organizations_url":"https://api.github.com/users/matlockx/orgs","repos_url":"https://api.github.com/users/matlockx/repos","events_url":"https://api.github.com/users/matlockx/events{/privacy}","received_events_url":"https://api.github.com/users/matlockx/received_events","type":"User","site_admin":false},"repo":{"id":24557316,"name":"akka-persistence-cassandra","full_name":"matlockx/akka-persistence-cassandra","owner":{"login":"matlockx","id":936786,"avatar_url":"https://avatars.githubusercontent.com/u/936786?v=3","gravatar_id":"","url":"https://api.github.com/users/matlockx","html_url":"https://github.com/matlockx","followers_url":"https://api.github.com/users/matlockx/followers","following_url":"https://api.github.com/users/matlockx/following{/other_user}","gists_url":"https://api.github.com/users/matlockx/gists{/gist_id}","starred_url":"https://api.github.com/users/matlockx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matlockx/subscriptions","organizations_url":"https://api.github.com/users/matlockx/orgs","repos_url":"https://api.github.com/users/matlockx/repos","events_url":"https://api.github.com/users/matlockx/events{/privacy}","received_events_url":"https://api.github.com/users/matlockx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matlockx/akka-persistence-cassandra","description":"A replicated Akka Persistence journal backed by Apache Cassandra","fork":true,"url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra","forks_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/forks","keys_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/teams","hooks_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/hooks","issue_events_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/issues/events{/number}","events_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/events","assignees_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/assignees{/user}","branches_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/branches{/branch}","tags_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/tags","blobs_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/git/refs{/sha}","trees_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/statuses/{sha}","languages_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/languages","stargazers_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/stargazers","contributors_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/contributors","subscribers_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/subscribers","subscription_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/subscription","commits_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/commits{/sha}","git_commits_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/git/commits{/sha}","comments_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/comments{/number}","issue_comment_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/issues/comments{/number}","contents_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/contents/{+path}","compare_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/merges","archive_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/downloads","issues_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/issues{/number}","pulls_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/pulls{/number}","milestones_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/milestones{/number}","notifications_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/labels{/name}","releases_url":"https://api.github.com/repos/matlockx/akka-persistence-cassandra/releases{/id}","created_at":"2014-09-28T10:51:51Z","updated_at":"2015-04-26T15:58:58Z","pushed_at":"2015-11-16T10:38:27Z","git_url":"git://github.com/matlockx/akka-persistence-cassandra.git","ssh_url":"git@github.com:matlockx/akka-persistence-cassandra.git","clone_url":"https://github.com/matlockx/akka-persistence-cassandra.git","svn_url":"https://github.com/matlockx/akka-persistence-cassandra","homepage":"","size":356,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"krasserm:master","ref":"master","sha":"78c8f595b3624ac5d1574240dcc08fbe6265ee7f","user":{"login":"krasserm","id":202907,"avatar_url":"https://avatars.githubusercontent.com/u/202907?v=3","gravatar_id":"","url":"https://api.github.com/users/krasserm","html_url":"https://github.com/krasserm","followers_url":"https://api.github.com/users/krasserm/followers","following_url":"https://api.github.com/users/krasserm/following{/other_user}","gists_url":"https://api.github.com/users/krasserm/gists{/gist_id}","starred_url":"https://api.github.com/users/krasserm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krasserm/subscriptions","organizations_url":"https://api.github.com/users/krasserm/orgs","repos_url":"https://api.github.com/users/krasserm/repos","events_url":"https://api.github.com/users/krasserm/events{/privacy}","received_events_url":"https://api.github.com/users/krasserm/received_events","type":"User","site_admin":false},"repo":{"id":15447419,"name":"akka-persistence-cassandra","full_name":"krasserm/akka-persistence-cassandra","owner":{"login":"krasserm","id":202907,"avatar_url":"https://avatars.githubusercontent.com/u/202907?v=3","gravatar_id":"","url":"https://api.github.com/users/krasserm","html_url":"https://github.com/krasserm","followers_url":"https://api.github.com/users/krasserm/followers","following_url":"https://api.github.com/users/krasserm/following{/other_user}","gists_url":"https://api.github.com/users/krasserm/gists{/gist_id}","starred_url":"https://api.github.com/users/krasserm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krasserm/subscriptions","organizations_url":"https://api.github.com/users/krasserm/orgs","repos_url":"https://api.github.com/users/krasserm/repos","events_url":"https://api.github.com/users/krasserm/events{/privacy}","received_events_url":"https://api.github.com/users/krasserm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krasserm/akka-persistence-cassandra","description":"A replicated Akka Persistence journal backed by Apache Cassandra","fork":false,"url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra","forks_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/forks","keys_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/teams","hooks_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/hooks","issue_events_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/issues/events{/number}","events_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/events","assignees_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/assignees{/user}","branches_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/branches{/branch}","tags_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/tags","blobs_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/git/refs{/sha}","trees_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/statuses/{sha}","languages_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/languages","stargazers_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/stargazers","contributors_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/contributors","subscribers_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/subscribers","subscription_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/subscription","commits_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/commits{/sha}","git_commits_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/git/commits{/sha}","comments_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/comments{/number}","issue_comment_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/issues/comments{/number}","contents_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/contents/{+path}","compare_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/merges","archive_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/downloads","issues_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/issues{/number}","pulls_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls{/number}","milestones_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/milestones{/number}","notifications_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/labels{/name}","releases_url":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/releases{/id}","created_at":"2013-12-26T06:47:08Z","updated_at":"2015-11-11T13:08:56Z","pushed_at":"2015-11-17T05:18:59Z","git_url":"git://github.com/krasserm/akka-persistence-cassandra.git","ssh_url":"git@github.com:krasserm/akka-persistence-cassandra.git","clone_url":"https://github.com/krasserm/akka-persistence-cassandra.git","svn_url":"https://github.com/krasserm/akka-persistence-cassandra","homepage":"","size":353,"stargazers_count":169,"watchers_count":169,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":20,"forks":58,"open_issues":20,"watchers":169,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/116"},"html":{"href":"https://github.com/krasserm/akka-persistence-cassandra/pull/116"},"issue":{"href":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/issues/116"},"comments":{"href":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/krasserm/akka-persistence-cassandra/statuses/6357d756da41db83fdee4e983b68baebfa016adc"}}}}