{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments/36792910","id":36792910,"diff_hunk":"@@ -0,0 +1,53 @@\n+/* This Source Code Form is subject to the terms of the Mozilla Public\n+ * License, v. 2.0. If a copy of the MPL was not distributed with this\n+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */\n+\n+define([\n+  'lib/promise',\n+  'lib/runtime-require'\n+], function (p, runtimeRequire) {\n+  'use strict';\n+\n+  var PasswordStrengthMixin = {\n+    _getPasswordStrengthChecker: function () {\n+      // returns a promise","path":"app/scripts/views/mixins/password-strength-mixin.js","position":13,"original_position":13,"commit_id":"8edb113fec2ee49d29a619ce7630528aa738d7b3","original_commit_id":"8edb113fec2ee49d29a619ce7630528aa738d7b3","user":{"login":"shane-tomlinson","id":848085,"avatar_url":"https://avatars.githubusercontent.com/u/848085?v=3","gravatar_id":"","url":"https://api.github.com/users/shane-tomlinson","html_url":"https://github.com/shane-tomlinson","followers_url":"https://api.github.com/users/shane-tomlinson/followers","following_url":"https://api.github.com/users/shane-tomlinson/following{/other_user}","gists_url":"https://api.github.com/users/shane-tomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/shane-tomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shane-tomlinson/subscriptions","organizations_url":"https://api.github.com/users/shane-tomlinson/orgs","repos_url":"https://api.github.com/users/shane-tomlinson/repos","events_url":"https://api.github.com/users/shane-tomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/shane-tomlinson/received_events","type":"User","site_admin":false},"body":"Update this comment about why we return a promise and what the promise resolves to.","created_at":"2015-08-11T20:15:34Z","updated_at":"2015-08-11T20:15:34Z","html_url":"https://github.com/mozilla/fxa-content-server/pull/2810#discussion_r36792910","pull_request_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/2810","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments/36792910"},"html":{"href":"https://github.com/mozilla/fxa-content-server/pull/2810#discussion_r36792910"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/2810"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/2810","id":40631713,"html_url":"https://github.com/mozilla/fxa-content-server/pull/2810","diff_url":"https://github.com/mozilla/fxa-content-server/pull/2810.diff","patch_url":"https://github.com/mozilla/fxa-content-server/pull/2810.patch","issue_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/2810","number":2810,"state":"open","locked":false,"title":"feat(client): Password Strength Checker","user":{"login":"TDA","id":432707,"avatar_url":"https://avatars.githubusercontent.com/u/432707?v=3","gravatar_id":"","url":"https://api.github.com/users/TDA","html_url":"https://github.com/TDA","followers_url":"https://api.github.com/users/TDA/followers","following_url":"https://api.github.com/users/TDA/following{/other_user}","gists_url":"https://api.github.com/users/TDA/gists{/gist_id}","starred_url":"https://api.github.com/users/TDA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TDA/subscriptions","organizations_url":"https://api.github.com/users/TDA/orgs","repos_url":"https://api.github.com/users/TDA/repos","events_url":"https://api.github.com/users/TDA/events{/privacy}","received_events_url":"https://api.github.com/users/TDA/received_events","type":"User","site_admin":false},"body":"use bloom filter to check strength of password\r\nlog error messages\r\nFixes #111 \r\nShould be good once it turns green\r\nFinalllly ready!\r\nWill need to change SHA after the other repo is ready.\r\n@shane-tomlinson \r\n@vladikoff \r\n@pdehaan ","created_at":"2015-07-23T02:29:01Z","updated_at":"2015-08-11T20:15:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1b600584118edb789abdae807aa4d459ed70f34","assignee":{"login":"TDA","id":432707,"avatar_url":"https://avatars.githubusercontent.com/u/432707?v=3","gravatar_id":"","url":"https://api.github.com/users/TDA","html_url":"https://github.com/TDA","followers_url":"https://api.github.com/users/TDA/followers","following_url":"https://api.github.com/users/TDA/following{/other_user}","gists_url":"https://api.github.com/users/TDA/gists{/gist_id}","starred_url":"https://api.github.com/users/TDA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TDA/subscriptions","organizations_url":"https://api.github.com/users/TDA/orgs","repos_url":"https://api.github.com/users/TDA/repos","events_url":"https://api.github.com/users/TDA/events{/privacy}","received_events_url":"https://api.github.com/users/TDA/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/2810/commits","review_comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/2810/comments","review_comment_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/2810/comments","statuses_url":"https://api.github.com/repos/mozilla/fxa-content-server/statuses/8edb113fec2ee49d29a619ce7630528aa738d7b3","head":{"label":"TDA:feature-password-strength-checker","ref":"feature-password-strength-checker","sha":"8edb113fec2ee49d29a619ce7630528aa738d7b3","user":{"login":"TDA","id":432707,"avatar_url":"https://avatars.githubusercontent.com/u/432707?v=3","gravatar_id":"","url":"https://api.github.com/users/TDA","html_url":"https://github.com/TDA","followers_url":"https://api.github.com/users/TDA/followers","following_url":"https://api.github.com/users/TDA/following{/other_user}","gists_url":"https://api.github.com/users/TDA/gists{/gist_id}","starred_url":"https://api.github.com/users/TDA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TDA/subscriptions","organizations_url":"https://api.github.com/users/TDA/orgs","repos_url":"https://api.github.com/users/TDA/repos","events_url":"https://api.github.com/users/TDA/events{/privacy}","received_events_url":"https://api.github.com/users/TDA/received_events","type":"User","site_admin":false},"repo":{"id":36767755,"name":"fxa-content-server","full_name":"TDA/fxa-content-server","owner":{"login":"TDA","id":432707,"avatar_url":"https://avatars.githubusercontent.com/u/432707?v=3","gravatar_id":"","url":"https://api.github.com/users/TDA","html_url":"https://github.com/TDA","followers_url":"https://api.github.com/users/TDA/followers","following_url":"https://api.github.com/users/TDA/following{/other_user}","gists_url":"https://api.github.com/users/TDA/gists{/gist_id}","starred_url":"https://api.github.com/users/TDA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TDA/subscriptions","organizations_url":"https://api.github.com/users/TDA/orgs","repos_url":"https://api.github.com/users/TDA/repos","events_url":"https://api.github.com/users/TDA/events{/privacy}","received_events_url":"https://api.github.com/users/TDA/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TDA/fxa-content-server","description":"Firefox Accounts Content Server","fork":true,"url":"https://api.github.com/repos/TDA/fxa-content-server","forks_url":"https://api.github.com/repos/TDA/fxa-content-server/forks","keys_url":"https://api.github.com/repos/TDA/fxa-content-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TDA/fxa-content-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TDA/fxa-content-server/teams","hooks_url":"https://api.github.com/repos/TDA/fxa-content-server/hooks","issue_events_url":"https://api.github.com/repos/TDA/fxa-content-server/issues/events{/number}","events_url":"https://api.github.com/repos/TDA/fxa-content-server/events","assignees_url":"https://api.github.com/repos/TDA/fxa-content-server/assignees{/user}","branches_url":"https://api.github.com/repos/TDA/fxa-content-server/branches{/branch}","tags_url":"https://api.github.com/repos/TDA/fxa-content-server/tags","blobs_url":"https://api.github.com/repos/TDA/fxa-content-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TDA/fxa-content-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TDA/fxa-content-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/TDA/fxa-content-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TDA/fxa-content-server/statuses/{sha}","languages_url":"https://api.github.com/repos/TDA/fxa-content-server/languages","stargazers_url":"https://api.github.com/repos/TDA/fxa-content-server/stargazers","contributors_url":"https://api.github.com/repos/TDA/fxa-content-server/contributors","subscribers_url":"https://api.github.com/repos/TDA/fxa-content-server/subscribers","subscription_url":"https://api.github.com/repos/TDA/fxa-content-server/subscription","commits_url":"https://api.github.com/repos/TDA/fxa-content-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/TDA/fxa-content-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/TDA/fxa-content-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/TDA/fxa-content-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/TDA/fxa-content-server/contents/{+path}","compare_url":"https://api.github.com/repos/TDA/fxa-content-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TDA/fxa-content-server/merges","archive_url":"https://api.github.com/repos/TDA/fxa-content-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TDA/fxa-content-server/downloads","issues_url":"https://api.github.com/repos/TDA/fxa-content-server/issues{/number}","pulls_url":"https://api.github.com/repos/TDA/fxa-content-server/pulls{/number}","milestones_url":"https://api.github.com/repos/TDA/fxa-content-server/milestones{/number}","notifications_url":"https://api.github.com/repos/TDA/fxa-content-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TDA/fxa-content-server/labels{/name}","releases_url":"https://api.github.com/repos/TDA/fxa-content-server/releases{/id}","created_at":"2015-06-02T23:27:37Z","updated_at":"2015-06-02T23:27:39Z","pushed_at":"2015-08-11T19:29:01Z","git_url":"git://github.com/TDA/fxa-content-server.git","ssh_url":"git@github.com:TDA/fxa-content-server.git","clone_url":"https://github.com/TDA/fxa-content-server.git","svn_url":"https://github.com/TDA/fxa-content-server","homepage":"","size":9151,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"deb41d0b1bf317246bd49be14b312d1924f211c2","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":11778024,"name":"fxa-content-server","full_name":"mozilla/fxa-content-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-content-server","description":"Firefox Accounts Content Server","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-content-server","forks_url":"https://api.github.com/repos/mozilla/fxa-content-server/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-content-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-content-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-content-server/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-content-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-content-server/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-content-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-content-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-content-server/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-content-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-content-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-content-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-content-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-content-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-content-server/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-content-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-content-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-content-server/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-content-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-content-server/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-content-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-content-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-content-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-content-server/releases{/id}","created_at":"2013-07-30T23:35:35Z","updated_at":"2015-08-11T12:43:13Z","pushed_at":"2015-08-11T19:29:01Z","git_url":"git://github.com/mozilla/fxa-content-server.git","ssh_url":"git@github.com:mozilla/fxa-content-server.git","clone_url":"https://github.com/mozilla/fxa-content-server.git","svn_url":"https://github.com/mozilla/fxa-content-server","homepage":"","size":27182,"stargazers_count":70,"watchers_count":70,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":178,"forks":45,"open_issues":178,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/2810"},"html":{"href":"https://github.com/mozilla/fxa-content-server/pull/2810"},"issue":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/issues/2810"},"comments":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/issues/2810/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/2810/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/2810/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/statuses/8edb113fec2ee49d29a619ce7630528aa738d7b3"}}}}