{"comment":{"url":"https://api.github.com/repos/nirenjan/x52pro-linux/comments/14761233","html_url":"https://github.com/nirenjan/x52pro-linux/commit/5d0684a154c7e797c4201974d2f5427374440634#commitcomment-14761233","id":14761233,"user":{"login":"rogerxxxx","id":12102230,"avatar_url":"https://avatars.githubusercontent.com/u/12102230?v=3","gravatar_id":"","url":"https://api.github.com/users/rogerxxxx","html_url":"https://github.com/rogerxxxx","followers_url":"https://api.github.com/users/rogerxxxx/followers","following_url":"https://api.github.com/users/rogerxxxx/following{/other_user}","gists_url":"https://api.github.com/users/rogerxxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/rogerxxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogerxxxx/subscriptions","organizations_url":"https://api.github.com/users/rogerxxxx/orgs","repos_url":"https://api.github.com/users/rogerxxxx/repos","events_url":"https://api.github.com/users/rogerxxxx/events{/privacy}","received_events_url":"https://api.github.com/users/rogerxxxx/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"5d0684a154c7e797c4201974d2f5427374440634","created_at":"2015-12-03T13:06:22Z","updated_at":"2015-12-03T13:06:22Z","body":"I understand the x52cli using libUSB, and not the kernel driver.\r\n\r\nI like x52_test, as this tests all the buttons and lights.  Currently I seemingly have one LED button (\"D\") on the throttle controller malfunctioning.  The x52_test cycles through the colors, including the missing yellow LED and only displays green.  During movement of the throttle controller, I can likely see one of the wires leading to this LED likely incurring tension at some point, loosening a connection to the LED yellow contact.  (Or the LED is just, overall, going bad.)  I'm not a fan of tossing out useful scripts and code, unlike some people.  I would suggest renaming the utility to x52test.  You spent some time coding the utility, with the fact that if it were never coded, it might not be missed.\r\n\r\nAlso, you have something upstream that is proven to work, besides a simple user (maybe unreliably) scripting something on their own via x52cli.  However, I can also provide good arguments at times for keeping something that should be removed!  So, it's your project, and it's your choice.  (I can understand either of your choices, if you so choose to remove the tool.)"}}