{"action":"created","issue":{"url":"https://api.github.com/repos/scummvm/scummvm/issues/636","labels_url":"https://api.github.com/repos/scummvm/scummvm/issues/636/labels{/name}","comments_url":"https://api.github.com/repos/scummvm/scummvm/issues/636/comments","events_url":"https://api.github.com/repos/scummvm/scummvm/issues/636/events","html_url":"https://github.com/scummvm/scummvm/pull/636","id":122154370,"number":636,"title":"LAB: Engine","user":{"login":"sev-","id":365188,"avatar_url":"https://avatars.githubusercontent.com/u/365188?v=3","gravatar_id":"","url":"https://api.github.com/users/sev-","html_url":"https://github.com/sev-","followers_url":"https://api.github.com/users/sev-/followers","following_url":"https://api.github.com/users/sev-/following{/other_user}","gists_url":"https://api.github.com/users/sev-/gists{/gist_id}","starred_url":"https://api.github.com/users/sev-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sev-/subscriptions","organizations_url":"https://api.github.com/users/sev-/orgs","repos_url":"https://api.github.com/users/sev-/repos","events_url":"https://api.github.com/users/sev-/events{/privacy}","received_events_url":"https://api.github.com/users/sev-/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-14T23:15:34Z","updated_at":"2015-12-19T03:33:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scummvm/scummvm/pulls/636","html_url":"https://github.com/scummvm/scummvm/pull/636","diff_url":"https://github.com/scummvm/scummvm/pull/636.diff","patch_url":"https://github.com/scummvm/scummvm/pull/636.patch"},"body":"This is a pull request for the game The Labyrinth of Time. This game is currently available on www.wyrmkeep.com and on GOG.com. The game should be completable: it was completable a month ago and we did regularly regression testing. All the work has been based on sources kindly provided by Wyrmkeep.\r\n\r\nThe DOS and the Windows versions are supported by this engine."},"comment":{"url":"https://api.github.com/repos/scummvm/scummvm/issues/comments/165940877","html_url":"https://github.com/scummvm/scummvm/pull/636#issuecomment-165940877","issue_url":"https://api.github.com/repos/scummvm/scummvm/issues/636","id":165940877,"user":{"login":"dreammaster","id":552828,"avatar_url":"https://avatars.githubusercontent.com/u/552828?v=3","gravatar_id":"","url":"https://api.github.com/users/dreammaster","html_url":"https://github.com/dreammaster","followers_url":"https://api.github.com/users/dreammaster/followers","following_url":"https://api.github.com/users/dreammaster/following{/other_user}","gists_url":"https://api.github.com/users/dreammaster/gists{/gist_id}","starred_url":"https://api.github.com/users/dreammaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreammaster/subscriptions","organizations_url":"https://api.github.com/users/dreammaster/orgs","repos_url":"https://api.github.com/users/dreammaster/repos","events_url":"https://api.github.com/users/dreammaster/events{/privacy}","received_events_url":"https://api.github.com/users/dreammaster/received_events","type":"User","site_admin":false},"created_at":"2015-12-19T03:33:58Z","updated_at":"2015-12-19T03:33:58Z","body":"I've had a chance to give a quick look-over, and it looks good. Great work :). Just a few minor comments I'd make:\r\n\r\n* Very minor formatting at the end of lab.cpp and eventman.cpp could use an extra space before the closing brace of the namespace.\r\n\r\n* As far as I'm aware, the preference for method comments is to put them all in the header files, not in the CPP files.\r\n\r\n* Looking at LabEngine::processJournal, it looks like you're doing the loop without any calls to delayMilli(). Unless it's buried inside one of the method calls and I missed it. If not, it's good practice to some kind of delay in those kinds of loops so you don't throttle the CPU.\r\n"}}