{"action":"created","issue":{"url":"https://api.github.com/repos/fisharebest/webtrees/issues/381","labels_url":"https://api.github.com/repos/fisharebest/webtrees/issues/381/labels{/name}","comments_url":"https://api.github.com/repos/fisharebest/webtrees/issues/381/comments","events_url":"https://api.github.com/repos/fisharebest/webtrees/issues/381/events","html_url":"https://github.com/fisharebest/webtrees/issues/381","id":55065338,"number":381,"title":"A few (minor) issues","user":{"login":"JustCarmen","id":5641963,"avatar_url":"https://avatars.githubusercontent.com/u/5641963?v=3","gravatar_id":"","url":"https://api.github.com/users/JustCarmen","html_url":"https://github.com/JustCarmen","followers_url":"https://api.github.com/users/JustCarmen/followers","following_url":"https://api.github.com/users/JustCarmen/following{/other_user}","gists_url":"https://api.github.com/users/JustCarmen/gists{/gist_id}","starred_url":"https://api.github.com/users/JustCarmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustCarmen/subscriptions","organizations_url":"https://api.github.com/users/JustCarmen/orgs","repos_url":"https://api.github.com/users/JustCarmen/repos","events_url":"https://api.github.com/users/JustCarmen/events{/privacy}","received_events_url":"https://api.github.com/users/JustCarmen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-01-21T19:29:15Z","updated_at":"2015-01-21T20:47:54Z","closed_at":null,"body":"Greg, first of all I would like to say that I really like the new theme system!\r\nI am almost done with the conversion of both of my themes without any problems.\r\n\r\nA few things to mention though:\r\n- The favicon is missing in the headcontents function of the BaseTheme.\r\n- In the parameters functions several images are listed which aren't referenced anywhere in the code. I think they could be removed. This counts for the following images:\r\nimage-add, image-button_family, image-remove, image-search, image-default_image_F, image-default_image_M, image-default_image_U.\r\nThe only place the equivalent images are called is from css as background-image. I can't find them anywhere else.\r\n- The version number is no longer set on the logo. I don't know if this is a deliberate change or not.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/fisharebest/webtrees/issues/comments/70918337","html_url":"https://github.com/fisharebest/webtrees/issues/381#issuecomment-70918337","issue_url":"https://api.github.com/repos/fisharebest/webtrees/issues/381","id":70918337,"user":{"login":"fisharebest","id":2306088,"avatar_url":"https://avatars.githubusercontent.com/u/2306088?v=3","gravatar_id":"","url":"https://api.github.com/users/fisharebest","html_url":"https://github.com/fisharebest","followers_url":"https://api.github.com/users/fisharebest/followers","following_url":"https://api.github.com/users/fisharebest/following{/other_user}","gists_url":"https://api.github.com/users/fisharebest/gists{/gist_id}","starred_url":"https://api.github.com/users/fisharebest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fisharebest/subscriptions","organizations_url":"https://api.github.com/users/fisharebest/orgs","repos_url":"https://api.github.com/users/fisharebest/repos","events_url":"https://api.github.com/users/fisharebest/events{/privacy}","received_events_url":"https://api.github.com/users/fisharebest/received_events","type":"User","site_admin":false},"created_at":"2015-01-21T20:47:54Z","updated_at":"2015-01-21T20:47:54Z","body":"> I am almost done with the conversion of both of my themes without any problems.\r\n\r\nIf you have any suggestions for improvement, now is the time for them!\r\n\r\nAlso, the exact functions may change a little before the release.\r\n\r\nAlso, I want to change all the classnames to use namespaces.  This will be a major change that will break every custom module/theme/etc. :-(  If there is time, I will do it for 1.7.0.  If not, then 1.8.0"}}