{"action":"created","issue":{"url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/issues/476","labels_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/issues/476/labels{/name}","comments_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/issues/476/comments","events_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/issues/476/events","html_url":"https://github.com/squizlabs/PHP_CodeSniffer/issues/476","id":56595622,"number":476,"title":"Ignore abstract sniff classes","user":{"login":"Decave","id":4442853,"avatar_url":"https://avatars.githubusercontent.com/u/4442853?v=3","gravatar_id":"","url":"https://api.github.com/users/Decave","html_url":"https://github.com/Decave","followers_url":"https://api.github.com/users/Decave/followers","following_url":"https://api.github.com/users/Decave/following{/other_user}","gists_url":"https://api.github.com/users/Decave/gists{/gist_id}","starred_url":"https://api.github.com/users/Decave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Decave/subscriptions","organizations_url":"https://api.github.com/users/Decave/orgs","repos_url":"https://api.github.com/users/Decave/repos","events_url":"https://api.github.com/users/Decave/events{/privacy}","received_events_url":"https://api.github.com/users/Decave/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/labels/Awaiting%20Feedback","name":"Awaiting Feedback","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-02-04T22:10:51Z","updated_at":"2015-02-09T02:30:24Z","closed_at":null,"body":"It appears that if you define your own coding standard, then *all* classes, including abstract classes, in the `/Sniffs` directory that end with 'Sniff' are improperly instantiated when running `phpcs`.\r\n\r\nThere should be a check for whether a class is abstract before it is instantiated, even if its name ends in 'Sniff'. This could be useful if someone wants to maintain a naming convention in that namespace, but still make a class abstract (i.e. `BaseMyStandardSniff`) rather than changing it to `BaseMyStandardHelper` or something of the sort."},"comment":{"url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/issues/comments/73449131","html_url":"https://github.com/squizlabs/PHP_CodeSniffer/issues/476#issuecomment-73449131","issue_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/issues/476","id":73449131,"user":{"login":"Decave","id":4442853,"avatar_url":"https://avatars.githubusercontent.com/u/4442853?v=3","gravatar_id":"","url":"https://api.github.com/users/Decave","html_url":"https://github.com/Decave","followers_url":"https://api.github.com/users/Decave/followers","following_url":"https://api.github.com/users/Decave/following{/other_user}","gists_url":"https://api.github.com/users/Decave/gists{/gist_id}","starred_url":"https://api.github.com/users/Decave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Decave/subscriptions","organizations_url":"https://api.github.com/users/Decave/orgs","repos_url":"https://api.github.com/users/Decave/repos","events_url":"https://api.github.com/users/Decave/events{/privacy}","received_events_url":"https://api.github.com/users/Decave/received_events","type":"User","site_admin":false},"created_at":"2015-02-09T02:30:24Z","updated_at":"2015-02-09T02:30:24Z","body":"Hi @gsherwood, where do you recommend that I put tests for this? It seems like it should go in the Core suite as it's testing the actual loading of sniffs from a standard rather than the application of a standard itself, but I'm having trouble finding where the broader functionality of registering sniffs is already tested."}}