{"action":"created","comment":{"url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/comments/37642267","id":37642267,"diff_hunk":"@@ -583,4 +585,96 @@ def test_sensor_values(self):\n         \"\"\"\n         (TP.C.1.16) Report sensor values (AR1)\n         \"\"\"\n-        pass\n+        def cmc_sensor_status():\n+            \"\"\" Check cmc sensor status \"\"\"\n+            iom = ioloop_manager.IOLoopManager()\n+            iow = resource_client.IOLoopThreadWrapper(iom.get_ioloop())\n+            iom.start()\n+            self.addCleanup(iom.stop)\n+            #roach_clients = []\n+            rc = resource_client.KATCPClientResource(\n+                dict(name='localhost', address=('localhost', '7147'),\n+                    controlled=True))\n+            rc.set_ioloop(iom.get_ioloop())\n+            rct = resource_client.ThreadSafeKATCPClientResourceWrapper(rc, iow)\n+            rct.start()\n+            rct.until_synced()\n+            #roach_clients.append(rct)\n+\n+            ## 1. Request a list of available sensors using KATCP command\n+            ## 2. Confirm the CBF replies with a number of sensor-list inform messages\n+            LOGGER.info (rct.req.sensor_list())\n+\n+            # 3. Confirm the CBF replies with \"!sensor-list ok numSensors\"\n+            #   where numSensors is the number of sensor-list informs sent.\n+            sens_val_stat, sens_val_cnt =  rct.req.sensor_value().reply.arguments\n+            sens_lst_stat, sens_lst_cnt = rct.req.sensor_list().reply.arguments\n+\n+            self.assertTrue(sens_val_cnt == sens_lst_cnt,\n+                msg='Sensors count are not the same')\n+\n+            # 3. Confirm the CBF replies with \"!sensor-list ok numSensors\" where\n+            # numSensors is the number of sensor-list informs sent.\n+            #print (str(rct.req.sensor_value().reply))\n+            LOGGER.info (str(rct.req.sensor_value().reply))","path":"mkat_fpga_tests/test_cbf.py","position":45,"original_position":45,"commit_id":"6106425b88bdfaa24a11ec28d491597077d9881f","original_commit_id":"6106425b88bdfaa24a11ec28d491597077d9881f","user":{"login":"brickZA","id":630432,"avatar_url":"https://avatars.githubusercontent.com/u/630432?v=3","gravatar_id":"","url":"https://api.github.com/users/brickZA","html_url":"https://github.com/brickZA","followers_url":"https://api.github.com/users/brickZA/followers","following_url":"https://api.github.com/users/brickZA/following{/other_user}","gists_url":"https://api.github.com/users/brickZA/gists{/gist_id}","starred_url":"https://api.github.com/users/brickZA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brickZA/subscriptions","organizations_url":"https://api.github.com/users/brickZA/orgs","repos_url":"https://api.github.com/users/brickZA/repos","events_url":"https://api.github.com/users/brickZA/events{/privacy}","received_events_url":"https://api.github.com/users/brickZA/received_events","type":"User","site_admin":false},"body":"Not actually testing here? Although I think  we fixed this at your desk?","created_at":"2015-08-21T14:56:48Z","updated_at":"2015-08-21T14:56:48Z","html_url":"https://github.com/ska-sa/mkat_fpga_tests/pull/34#discussion_r37642267","pull_request_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/comments/37642267"},"html":{"href":"https://github.com/ska-sa/mkat_fpga_tests/pull/34#discussion_r37642267"},"pull_request":{"href":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/34","id":42945314,"html_url":"https://github.com/ska-sa/mkat_fpga_tests/pull/34","diff_url":"https://github.com/ska-sa/mkat_fpga_tests/pull/34.diff","patch_url":"https://github.com/ska-sa/mkat_fpga_tests/pull/34.patch","issue_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/issues/34","number":34,"state":"open","locked":false,"title":"Sensor test","user":{"login":"mmphego","id":7910856,"avatar_url":"https://avatars.githubusercontent.com/u/7910856?v=3","gravatar_id":"","url":"https://api.github.com/users/mmphego","html_url":"https://github.com/mmphego","followers_url":"https://api.github.com/users/mmphego/followers","following_url":"https://api.github.com/users/mmphego/following{/other_user}","gists_url":"https://api.github.com/users/mmphego/gists{/gist_id}","starred_url":"https://api.github.com/users/mmphego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmphego/subscriptions","organizations_url":"https://api.github.com/users/mmphego/orgs","repos_url":"https://api.github.com/users/mmphego/repos","events_url":"https://api.github.com/users/mmphego/events{/privacy}","received_events_url":"https://api.github.com/users/mmphego/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-20T15:48:09Z","updated_at":"2015-08-21T14:56:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9233afe1984320423b39880eac6377c48fb79e7a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/34/commits","review_comments_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/34/comments","review_comment_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/issues/34/comments","statuses_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/statuses/6106425b88bdfaa24a11ec28d491597077d9881f","head":{"label":"ska-sa:sensor-test","ref":"sensor-test","sha":"6106425b88bdfaa24a11ec28d491597077d9881f","user":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":38315839,"name":"mkat_fpga_tests","full_name":"ska-sa/mkat_fpga_tests","owner":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ska-sa/mkat_fpga_tests","description":"Tests for the mkat_fpga FPGA bitstreams","fork":false,"url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests","forks_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/forks","keys_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/teams","hooks_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/events","assignees_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/tags","blobs_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/languages","stargazers_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/subscription","commits_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/merges","archive_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/downloads","issues_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/releases{/id}","created_at":"2015-06-30T15:02:05Z","updated_at":"2015-07-03T15:52:16Z","pushed_at":"2015-08-21T14:54:55Z","git_url":"git://github.com/ska-sa/mkat_fpga_tests.git","ssh_url":"git@github.com:ska-sa/mkat_fpga_tests.git","clone_url":"https://github.com/ska-sa/mkat_fpga_tests.git","svn_url":"https://github.com/ska-sa/mkat_fpga_tests","homepage":null,"size":21744,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ska-sa:devel","ref":"devel","sha":"5ebd42ac3c945bd7f2536991177719cffb8f5cbb","user":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":38315839,"name":"mkat_fpga_tests","full_name":"ska-sa/mkat_fpga_tests","owner":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ska-sa/mkat_fpga_tests","description":"Tests for the mkat_fpga FPGA bitstreams","fork":false,"url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests","forks_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/forks","keys_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/teams","hooks_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/events","assignees_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/tags","blobs_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/languages","stargazers_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/subscription","commits_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/merges","archive_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/downloads","issues_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/releases{/id}","created_at":"2015-06-30T15:02:05Z","updated_at":"2015-07-03T15:52:16Z","pushed_at":"2015-08-21T14:54:55Z","git_url":"git://github.com/ska-sa/mkat_fpga_tests.git","ssh_url":"git@github.com:ska-sa/mkat_fpga_tests.git","clone_url":"https://github.com/ska-sa/mkat_fpga_tests.git","svn_url":"https://github.com/ska-sa/mkat_fpga_tests","homepage":null,"size":21744,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/34"},"html":{"href":"https://github.com/ska-sa/mkat_fpga_tests/pull/34"},"issue":{"href":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/issues/34"},"comments":{"href":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/ska-sa/mkat_fpga_tests/statuses/6106425b88bdfaa24a11ec28d491597077d9881f"}}}}