{"action":"created","issue":{"url":"https://api.github.com/repos/philc/vimium/issues/1434","labels_url":"https://api.github.com/repos/philc/vimium/issues/1434/labels{/name}","comments_url":"https://api.github.com/repos/philc/vimium/issues/1434/comments","events_url":"https://api.github.com/repos/philc/vimium/issues/1434/events","html_url":"https://github.com/philc/vimium/pull/1434","id":54598722,"number":1434,"title":"Fix slightly wonky perform-find-in-place","user":{"login":"smblott-github","id":2641335,"avatar_url":"https://avatars.githubusercontent.com/u/2641335?v=3","gravatar_id":"","url":"https://api.github.com/users/smblott-github","html_url":"https://github.com/smblott-github","followers_url":"https://api.github.com/users/smblott-github/followers","following_url":"https://api.github.com/users/smblott-github/following{/other_user}","gists_url":"https://api.github.com/users/smblott-github/gists{/gist_id}","starred_url":"https://api.github.com/users/smblott-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smblott-github/subscriptions","organizations_url":"https://api.github.com/users/smblott-github/orgs","repos_url":"https://api.github.com/users/smblott-github/repos","events_url":"https://api.github.com/users/smblott-github/events{/privacy}","received_events_url":"https://api.github.com/users/smblott-github/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-16T17:01:41Z","updated_at":"2015-01-17T07:11:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/philc/vimium/pulls/1434","html_url":"https://github.com/philc/vimium/pull/1434","diff_url":"https://github.com/philc/vimium/pull/1434.diff","patch_url":"https://github.com/philc/vimium/pull/1434.patch"},"body":"When we use `/` for find, the selection should stay put if it continues to match the query as characters are added.  The is handled currently by first searching backwards, before beginning the real search.  This trick doesn't always work.  Here's an example: \r\n\r\n- Go [here](http://static.smblott.org/inputs.html) (my wonky-find test page).\r\n- Search: `/ooo`\r\n\r\nThe search jumps around unnecessarily. Bad UX.\r\n\r\nThis PR uses a different (simpler?) method for sticking to the existing match.  Basically, we store the initial selection, then restore it before each `performFindInPlace`.  So we're always starting from the same place.\r\n\r\n(I was hoping to get a fix for #1375; but no joy.)"},"comment":{"url":"https://api.github.com/repos/philc/vimium/issues/comments/70357755","html_url":"https://github.com/philc/vimium/pull/1434#issuecomment-70357755","issue_url":"https://api.github.com/repos/philc/vimium/issues/1434","id":70357755,"user":{"login":"philc","id":8598,"avatar_url":"https://avatars.githubusercontent.com/u/8598?v=3","gravatar_id":"","url":"https://api.github.com/users/philc","html_url":"https://github.com/philc","followers_url":"https://api.github.com/users/philc/followers","following_url":"https://api.github.com/users/philc/following{/other_user}","gists_url":"https://api.github.com/users/philc/gists{/gist_id}","starred_url":"https://api.github.com/users/philc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philc/subscriptions","organizations_url":"https://api.github.com/users/philc/orgs","repos_url":"https://api.github.com/users/philc/repos","events_url":"https://api.github.com/users/philc/events{/privacy}","received_events_url":"https://api.github.com/users/philc/received_events","type":"User","site_admin":false},"created_at":"2015-01-17T07:11:17Z","updated_at":"2015-01-17T07:11:17Z","body":"Clever =)"}}