{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/comments/46132368","id":46132368,"diff_hunk":"@@ -0,0 +1,78 @@\n+// Time-series widget, i.e. histogram of dates","path":"themes/scss/widgets/time-series.scss","position":1,"original_position":1,"commit_id":"046a5363cdb2fcaa4f7e6fe90767b1114a81c616","original_commit_id":"e587868a070622613db42e747c3d4b119cdefc11","user":{"login":"xavijam","id":132146,"avatar_url":"https://avatars.githubusercontent.com/u/132146?v=3","gravatar_id":"","url":"https://api.github.com/users/xavijam","html_url":"https://github.com/xavijam","followers_url":"https://api.github.com/users/xavijam/followers","following_url":"https://api.github.com/users/xavijam/following{/other_user}","gists_url":"https://api.github.com/users/xavijam/gists{/gist_id}","starred_url":"https://api.github.com/users/xavijam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavijam/subscriptions","organizations_url":"https://api.github.com/users/xavijam/orgs","repos_url":"https://api.github.com/users/xavijam/repos","events_url":"https://api.github.com/users/xavijam/events{/privacy}","received_events_url":"https://api.github.com/users/xavijam/received_events","type":"User","site_admin":false},"body":":joy: super! :dancer: ","created_at":"2015-11-30T11:26:10Z","updated_at":"2015-11-30T11:26:10Z","html_url":"https://github.com/CartoDB/cartodb.js/pull/879#discussion_r46132368","pull_request_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/879","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/comments/46132368"},"html":{"href":"https://github.com/CartoDB/cartodb.js/pull/879#discussion_r46132368"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/879"}}},"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/879","id":52022407,"html_url":"https://github.com/CartoDB/cartodb.js/pull/879","diff_url":"https://github.com/CartoDB/cartodb.js/pull/879.diff","patch_url":"https://github.com/CartoDB/cartodb.js/pull/879.patch","issue_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/879","number":879,"state":"open","locked":false,"title":"Implement time-series widgets styles","user":{"login":"viddo","id":978461,"avatar_url":"https://avatars.githubusercontent.com/u/978461?v=3","gravatar_id":"","url":"https://api.github.com/users/viddo","html_url":"https://github.com/viddo","followers_url":"https://api.github.com/users/viddo/followers","following_url":"https://api.github.com/users/viddo/following{/other_user}","gists_url":"https://api.github.com/users/viddo/gists{/gist_id}","starred_url":"https://api.github.com/users/viddo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viddo/subscriptions","organizations_url":"https://api.github.com/users/viddo/orgs","repos_url":"https://api.github.com/users/viddo/repos","events_url":"https://api.github.com/users/viddo/events{/privacy}","received_events_url":"https://api.github.com/users/viddo/received_events","type":"User","site_admin":false},"body":"Final waypoint to resolve #786 :tada: \r\n\r\nThis implements the missing styles for the time-series widget:\r\n\r\nStyleguide elements:\r\n<img width=\"826\" alt=\"screen shot 2015-11-27 at 21 10 00\" src=\"https://cloud.githubusercontent.com/assets/978461/11447730/8b186ea8-954b-11e5-8350-2a04ac4154c8.png\">\r\n<img width=\"1339\" alt=\"screen shot 2015-11-27 at 21 10 04\" src=\"https://cloud.githubusercontent.com/assets/978461/11447731/8b1c7e94-954b-11e5-94f1-8611ba34e57f.png\">\r\n<img width=\"953\" alt=\"screen shot 2015-11-27 at 21 10 22\" src=\"https://cloud.githubusercontent.com/assets/978461/11447732/8b225a12-954b-11e5-9440-d52551e53fe2.png\">\r\n\r\nActual usage:\r\n<img width=\"1328\" alt=\"screen shot 2015-11-27 at 21 10 39\" src=\"https://cloud.githubusercontent.com/assets/978461/11447733/8b8d1686-954b-11e5-91e2-4aec219351a0.png\">\r\n<img width=\"744\" alt=\"screen shot 2015-11-27 at 21 10 46\" src=\"https://cloud.githubusercontent.com/assets/978461/11447734/8b90de1a-954b-11e5-8a99-35cde4f3f5c2.png\">\r\n<img width=\"719\" alt=\"screen shot 2015-11-27 at 21 11 04\" src=\"https://cloud.githubusercontent.com/assets/978461/11447735/8b92142e-954b-11e5-8eb2-9b263bb617f7.png\">\r\n\r\nMoved the duplicated resize behavior to be handled internally in the histogram chart view instead of being duplicated for all usages (see code for details of how it was achieved). Also tried to follow backbone-idioms of how view is updated (i.e. utilize model state/events instead of stateful values directly on the view).\r\n\r\nAdded a new style guide file to test the `layout-loading` styles :art:\r\n\r\nWhile at it, simplified connect task, only run one server instead of 3 on different ports. Added instructions where to find different things to the grunt output, here copied:\r\n```\r\nStarted connect web server on http://localhost:9001\r\nStyleguide:\r\n - http://0.0.0.0:9001/themes/styleguide\r\n\r\nExamples:\r\n - http://0.0.0.0:9001/examples\r\n\r\nJasmine specs available at (one per bundle):\r\n - http://0.0.0.0:9001/test/SpecRunner-src.html\r\n - http://0.0.0.0:9001/test/SpecRunner-torque.html\r\n - http://0.0.0.0:9001/test/SpecRunner-odyssey.html\r\n - http://0.0.0.0:9001/test/SpecRunner-cartodb.html\r\n```\r\n\r\n@xavijam can you review please?\r\n+ @javierarce for the modifications of the chart internals","created_at":"2015-11-27T20:15:06Z","updated_at":"2015-11-30T11:26:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6347af0d9018f086aea7cf5a2798632eb0c80fb3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/879/commits","review_comments_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/879/comments","review_comment_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/879/comments","statuses_url":"https://api.github.com/repos/CartoDB/cartodb.js/statuses/046a5363cdb2fcaa4f7e6fe90767b1114a81c616","head":{"label":"CartoDB:widgets-torque-time-series-css","ref":"widgets-torque-time-series-css","sha":"046a5363cdb2fcaa4f7e6fe90767b1114a81c616","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4871551,"name":"cartodb.js","full_name":"CartoDB/cartodb.js","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb.js","description":"CartoDB javascript library","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb.js","forks_url":"https://api.github.com/repos/CartoDB/cartodb.js/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb.js/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb.js/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb.js/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb.js/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb.js/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb.js/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb.js/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb.js/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb.js/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb.js/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb.js/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb.js/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb.js/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb.js/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb.js/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb.js/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb.js/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb.js/releases{/id}","created_at":"2012-07-03T11:44:29Z","updated_at":"2015-11-13T16:28:25Z","pushed_at":"2015-11-30T11:01:38Z","git_url":"git://github.com/CartoDB/cartodb.js.git","ssh_url":"git@github.com:CartoDB/cartodb.js.git","clone_url":"https://github.com/CartoDB/cartodb.js.git","svn_url":"https://github.com/CartoDB/cartodb.js","homepage":"","size":27535,"stargazers_count":238,"watchers_count":238,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":156,"mirror_url":null,"open_issues_count":144,"forks":156,"open_issues":144,"watchers":238,"default_branch":"develop"}},"base":{"label":"CartoDB:widgets","ref":"widgets","sha":"2740771a8f722cceae01d43eb648bb9f732e8654","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4871551,"name":"cartodb.js","full_name":"CartoDB/cartodb.js","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb.js","description":"CartoDB javascript library","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb.js","forks_url":"https://api.github.com/repos/CartoDB/cartodb.js/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb.js/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb.js/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb.js/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb.js/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb.js/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb.js/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb.js/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb.js/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb.js/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb.js/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb.js/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb.js/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb.js/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb.js/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb.js/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb.js/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb.js/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb.js/releases{/id}","created_at":"2012-07-03T11:44:29Z","updated_at":"2015-11-13T16:28:25Z","pushed_at":"2015-11-30T11:01:38Z","git_url":"git://github.com/CartoDB/cartodb.js.git","ssh_url":"git@github.com:CartoDB/cartodb.js.git","clone_url":"https://github.com/CartoDB/cartodb.js.git","svn_url":"https://github.com/CartoDB/cartodb.js","homepage":"","size":27535,"stargazers_count":238,"watchers_count":238,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":156,"mirror_url":null,"open_issues_count":144,"forks":156,"open_issues":144,"watchers":238,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/879"},"html":{"href":"https://github.com/CartoDB/cartodb.js/pull/879"},"issue":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/issues/879"},"comments":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/issues/879/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/879/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/879/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/statuses/046a5363cdb2fcaa4f7e6fe90767b1114a81c616"}}}}