{"action":"created","comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments/36903818","id":36903818,"diff_hunk":"@@ -199,9 +199,11 @@ public static function process(&$form) {\n           $action = 'browse';\n         }\n \n-        $tabs[$key]['link'] = CRM_Utils_System::url(\"civicrm/event/manage/{$key}\",\n-          \"{$reset}action={$action}&id={$eventID}&component=event{$tabs[$key]['qfKey']}\"\n-        );\n+        $link = \"civicrm/event/manage/{$key}\";\n+        $query = \"{$reset}action={$action}&id={$eventID}&component=event{$tabs[$key]['qfKey']}\";\n+\n+        $tabs[$key]['link'] = (isset($value['link']) ? self::url($value['link']) :\n+          CRM_Utils_System::url($link, $query));","path":"CRM/Event/Form/ManageEvent/TabHeader.php","position":null,"original_position":11,"commit_id":"32f93260f04feddffab2d40666e78c6b7fabfc2a","original_commit_id":"6c0a137b0f1628cbdd5d24d7b74410fb8635a2bc","user":{"login":"GinkgoFJG","id":871819,"avatar_url":"https://avatars.githubusercontent.com/u/871819?v=3","gravatar_id":"","url":"https://api.github.com/users/GinkgoFJG","html_url":"https://github.com/GinkgoFJG","followers_url":"https://api.github.com/users/GinkgoFJG/followers","following_url":"https://api.github.com/users/GinkgoFJG/following{/other_user}","gists_url":"https://api.github.com/users/GinkgoFJG/gists{/gist_id}","starred_url":"https://api.github.com/users/GinkgoFJG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GinkgoFJG/subscriptions","organizations_url":"https://api.github.com/users/GinkgoFJG/orgs","repos_url":"https://api.github.com/users/GinkgoFJG/repos","events_url":"https://api.github.com/users/GinkgoFJG/events{/privacy}","received_events_url":"https://api.github.com/users/GinkgoFJG/received_events","type":"User","site_admin":false},"body":"@totten, it didn't occur to me that the link might be to a CMS page. Turns out that setting the snippet is unnecessary -- if the Angular page is being called from a tab or a modal, the snippet parameter is already set -- so we can do without CRM_Utils_System::snippetUrl(...) altogether.\r\n\r\nPerhaps I was engaging in too much extension-developer hand-holding.","created_at":"2015-08-12T19:38:10Z","updated_at":"2015-08-12T19:38:10Z","html_url":"https://github.com/civicrm/civicrm-core/pull/6457#discussion_r36903818","pull_request_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/6457","_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments/36903818"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/6457#discussion_r36903818"},"pull_request":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/6457"}}},"pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/6457","id":41986954,"html_url":"https://github.com/civicrm/civicrm-core/pull/6457","diff_url":"https://github.com/civicrm/civicrm-core/pull/6457.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/6457.patch","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/6457","number":6457,"state":"open","locked":false,"title":"Fixes for CRM-16994 and CRM-16995.","user":{"login":"GinkgoFJG","id":871819,"avatar_url":"https://avatars.githubusercontent.com/u/871819?v=3","gravatar_id":"","url":"https://api.github.com/users/GinkgoFJG","html_url":"https://github.com/GinkgoFJG","followers_url":"https://api.github.com/users/GinkgoFJG/followers","following_url":"https://api.github.com/users/GinkgoFJG/following{/other_user}","gists_url":"https://api.github.com/users/GinkgoFJG/gists{/gist_id}","starred_url":"https://api.github.com/users/GinkgoFJG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GinkgoFJG/subscriptions","organizations_url":"https://api.github.com/users/GinkgoFJG/orgs","repos_url":"https://api.github.com/users/GinkgoFJG/repos","events_url":"https://api.github.com/users/GinkgoFJG/events{/privacy}","received_events_url":"https://api.github.com/users/GinkgoFJG/received_events","type":"User","site_admin":false},"body":"Allows developers to specify a URL for an tab (CRM-16994). Allows that URL to be an Angular route (CRM-16995).\n\n---\n\n * [CRM-16994: hook_civicrm_tabset ignores passed link](https://issues.civicrm.org/jira/browse/CRM-16994)\n * [CRM-16995: Allow loading of Angular routes inside tabs](https://issues.civicrm.org/jira/browse/CRM-16995)","created_at":"2015-08-10T04:37:24Z","updated_at":"2015-08-12T19:38:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13db386e48e174ecd7b67df1d63eaaedc898ab0d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/6457/commits","review_comments_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/6457/comments","review_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/6457/comments","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/32f93260f04feddffab2d40666e78c6b7fabfc2a","head":{"label":"GinkgoFJG:angular_snippets","ref":"angular_snippets","sha":"32f93260f04feddffab2d40666e78c6b7fabfc2a","user":{"login":"GinkgoFJG","id":871819,"avatar_url":"https://avatars.githubusercontent.com/u/871819?v=3","gravatar_id":"","url":"https://api.github.com/users/GinkgoFJG","html_url":"https://github.com/GinkgoFJG","followers_url":"https://api.github.com/users/GinkgoFJG/followers","following_url":"https://api.github.com/users/GinkgoFJG/following{/other_user}","gists_url":"https://api.github.com/users/GinkgoFJG/gists{/gist_id}","starred_url":"https://api.github.com/users/GinkgoFJG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GinkgoFJG/subscriptions","organizations_url":"https://api.github.com/users/GinkgoFJG/orgs","repos_url":"https://api.github.com/users/GinkgoFJG/repos","events_url":"https://api.github.com/users/GinkgoFJG/events{/privacy}","received_events_url":"https://api.github.com/users/GinkgoFJG/received_events","type":"User","site_admin":false},"repo":{"id":11407494,"name":"civicrm-core","full_name":"GinkgoFJG/civicrm-core","owner":{"login":"GinkgoFJG","id":871819,"avatar_url":"https://avatars.githubusercontent.com/u/871819?v=3","gravatar_id":"","url":"https://api.github.com/users/GinkgoFJG","html_url":"https://github.com/GinkgoFJG","followers_url":"https://api.github.com/users/GinkgoFJG/followers","following_url":"https://api.github.com/users/GinkgoFJG/following{/other_user}","gists_url":"https://api.github.com/users/GinkgoFJG/gists{/gist_id}","starred_url":"https://api.github.com/users/GinkgoFJG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GinkgoFJG/subscriptions","organizations_url":"https://api.github.com/users/GinkgoFJG/orgs","repos_url":"https://api.github.com/users/GinkgoFJG/repos","events_url":"https://api.github.com/users/GinkgoFJG/events{/privacy}","received_events_url":"https://api.github.com/users/GinkgoFJG/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GinkgoFJG/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":true,"url":"https://api.github.com/repos/GinkgoFJG/civicrm-core","forks_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/forks","keys_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/teams","hooks_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/events","assignees_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/tags","blobs_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/subscription","commits_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/merges","archive_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/downloads","issues_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/GinkgoFJG/civicrm-core/releases{/id}","created_at":"2013-07-14T18:47:17Z","updated_at":"2014-07-16T21:58:10Z","pushed_at":"2015-08-12T19:21:59Z","git_url":"git://github.com/GinkgoFJG/civicrm-core.git","ssh_url":"git@github.com:GinkgoFJG/civicrm-core.git","clone_url":"https://github.com/GinkgoFJG/civicrm-core.git","svn_url":"https://github.com/GinkgoFJG/civicrm-core","homepage":null,"size":93323,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"civicrm:master","ref":"master","sha":"3a33f2846bfd908a19b7c275209cca298a1de984","user":{"login":"civicrm","id":136373,"avatar_url":"https://avatars.githubusercontent.com/u/136373?v=3","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"repo":{"id":8495499,"name":"civicrm-core","full_name":"civicrm/civicrm-core","owner":{"login":"civicrm","id":136373,"avatar_url":"https://avatars.githubusercontent.com/u/136373?v=3","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/civicrm/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":false,"url":"https://api.github.com/repos/civicrm/civicrm-core","forks_url":"https://api.github.com/repos/civicrm/civicrm-core/forks","keys_url":"https://api.github.com/repos/civicrm/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/civicrm/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/civicrm/civicrm-core/teams","hooks_url":"https://api.github.com/repos/civicrm/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/civicrm/civicrm-core/events","assignees_url":"https://api.github.com/repos/civicrm/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/civicrm/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/civicrm/civicrm-core/tags","blobs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/civicrm/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/civicrm/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/civicrm/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/civicrm/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/civicrm/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/civicrm/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/civicrm/civicrm-core/subscription","commits_url":"https://api.github.com/repos/civicrm/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/civicrm/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/civicrm/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/civicrm/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/civicrm/civicrm-core/merges","archive_url":"https://api.github.com/repos/civicrm/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/civicrm/civicrm-core/downloads","issues_url":"https://api.github.com/repos/civicrm/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/civicrm/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/civicrm/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/civicrm/civicrm-core/releases{/id}","created_at":"2013-03-01T06:11:56Z","updated_at":"2015-08-08T05:32:39Z","pushed_at":"2015-08-12T19:22:01Z","git_url":"git://github.com/civicrm/civicrm-core.git","ssh_url":"git@github.com:civicrm/civicrm-core.git","clone_url":"https://github.com/civicrm/civicrm-core.git","svn_url":"https://github.com/civicrm/civicrm-core","homepage":null,"size":139691,"stargazers_count":117,"watchers_count":117,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":311,"mirror_url":null,"open_issues_count":90,"forks":311,"open_issues":90,"watchers":117,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/6457"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/6457"},"issue":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/6457"},"comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/6457/comments"},"review_comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/6457/comments"},"review_comment":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/6457/commits"},"statuses":{"href":"https://api.github.com/repos/civicrm/civicrm-core/statuses/32f93260f04feddffab2d40666e78c6b7fabfc2a"}}}}