{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/34107250","id":34107250,"diff_hunk":"@@ -61,179 +94,253 @@ This release retires all api versions before v4 and promotes v4 to be\n the stable API. The following changes have been made since the last\n stable release of PuppetDB, which included an experimental v4 API.\n \n-* Retire all previously deprecated commands ([PDB-840](https://tickets.puppetlabs.com/browse/PDB-840))\n+* Versions 2 and 3 of the query API are now retired. There are also significant differences between the current stable v4 and the previously experimental v4.\n+\n+    Full documentation outlining this change is available [in the API upgrading guide][upgrading].\n+\n+* We've retired some previously deprecated commands ([PDB-840](https://tickets.puppetlabs.com/browse/PDB-840))\n \n     The currently supported commands and versions are now:\n \n     * replace catalog, v6\n     * replace facts, v4\n-    * deactivate node, v2\n+    * deactivate node, v3\n     * store report, v5\n \n-* All API commands and responses now use underscores, instead of dashes.  ([PDB-698](https://tickets.puppetlabs.com/browse/PDB-698))\n+    Older versions of the commands on your queue will still be\n+    processed by PuppetDB so you won't lose the data from messages\n+    still being processed by PuppetDB before an upgrade.\n+\n+* All API commands and responses now use underscores, instead of dashes. ([PDB-698](https://tickets.puppetlabs.com/browse/PDB-698))\n \n     This patch changes our API commands and responses to use underscores instead of\n     dashes, which will make it easier to interface with PDB using languages like\n-    javascript and python.\n-\n-* Split the `/v3/commands` endpoint into its own API served at `/pdb/cmd/v1`.\n+    javascript and python. Consult the various API endpoints for the exact new","path":"documentation/release_notes.markdown","position":133,"original_position":133,"commit_id":"20e9d6242afc79f16d1028be46647b59251c448f","original_commit_id":"20e9d6242afc79f16d1028be46647b59251c448f","user":{"login":"wkalt","id":4952091,"avatar_url":"https://avatars.githubusercontent.com/u/4952091?v=3","gravatar_id":"","url":"https://api.github.com/users/wkalt","html_url":"https://github.com/wkalt","followers_url":"https://api.github.com/users/wkalt/followers","following_url":"https://api.github.com/users/wkalt/following{/other_user}","gists_url":"https://api.github.com/users/wkalt/gists{/gist_id}","starred_url":"https://api.github.com/users/wkalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkalt/subscriptions","organizations_url":"https://api.github.com/users/wkalt/orgs","repos_url":"https://api.github.com/users/wkalt/repos","events_url":"https://api.github.com/users/wkalt/events{/privacy}","received_events_url":"https://api.github.com/users/wkalt/received_events","type":"User","site_admin":false},"body":"\"commands\" is overloaded, and inaccurate in the context of space-separated PDB commands.\r\n\r\nThis patch changes our query fields and parameters to use underscores instead of dashes. Consult the documentation on the various API endpoints for specific information.","created_at":"2015-07-08T00:42:59Z","updated_at":"2015-07-08T00:42:59Z","html_url":"https://github.com/puppetlabs/puppetdb/pull/1518#discussion_r34107250","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1518","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/34107250"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1518#discussion_r34107250"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1518"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1518","id":39379238,"html_url":"https://github.com/puppetlabs/puppetdb/pull/1518","diff_url":"https://github.com/puppetlabs/puppetdb/pull/1518.diff","patch_url":"https://github.com/puppetlabs/puppetdb/pull/1518.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1518","number":1518,"state":"open","locked":false,"title":"(PDB-1157) Cleanup release notes for 3.0.0","user":{"login":"senior","id":215910,"avatar_url":"https://avatars.githubusercontent.com/u/215910?v=3","gravatar_id":"","url":"https://api.github.com/users/senior","html_url":"https://github.com/senior","followers_url":"https://api.github.com/users/senior/followers","following_url":"https://api.github.com/users/senior/following{/other_user}","gists_url":"https://api.github.com/users/senior/gists{/gist_id}","starred_url":"https://api.github.com/users/senior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senior/subscriptions","organizations_url":"https://api.github.com/users/senior/orgs","repos_url":"https://api.github.com/users/senior/repos","events_url":"https://api.github.com/users/senior/events{/privacy}","received_events_url":"https://api.github.com/users/senior/received_events","type":"User","site_admin":false},"body":"Folding in the feedback from Ken's PR here: https://github.com/puppetlabs/puppetdb/pull/1513. I have put all my changes in a separate commit so that it can be reviewed separately. I'll collapse the two commits once review is done.","created_at":"2015-07-07T14:56:46Z","updated_at":"2015-07-08T00:42:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73ccd32c4243cdc3b58c78c1394674e44b702550","assignee":null,"milestone":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/milestones/2","html_url":"https://github.com/puppetlabs/puppetdb/milestones/3.0.0%20(stable)","labels_url":"https://api.github.com/repos/puppetlabs/puppetdb/milestones/2/labels","id":1187038,"number":2,"title":"3.0.0 (stable)","description":"","creator":{"login":"kbarber","id":80595,"avatar_url":"https://avatars.githubusercontent.com/u/80595?v=3","gravatar_id":"","url":"https://api.github.com/users/kbarber","html_url":"https://github.com/kbarber","followers_url":"https://api.github.com/users/kbarber/followers","following_url":"https://api.github.com/users/kbarber/following{/other_user}","gists_url":"https://api.github.com/users/kbarber/gists{/gist_id}","starred_url":"https://api.github.com/users/kbarber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbarber/subscriptions","organizations_url":"https://api.github.com/users/kbarber/orgs","repos_url":"https://api.github.com/users/kbarber/repos","events_url":"https://api.github.com/users/kbarber/events{/privacy}","received_events_url":"https://api.github.com/users/kbarber/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":12,"state":"open","created_at":"2015-06-30T12:56:52Z","updated_at":"2015-07-08T00:26:57Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1518/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1518/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1518/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/20e9d6242afc79f16d1028be46647b59251c448f","head":{"label":"senior:ticket/stable/pdb-1157-release-notes-update-for-300","ref":"ticket/stable/pdb-1157-release-notes-update-for-300","sha":"20e9d6242afc79f16d1028be46647b59251c448f","user":{"login":"senior","id":215910,"avatar_url":"https://avatars.githubusercontent.com/u/215910?v=3","gravatar_id":"","url":"https://api.github.com/users/senior","html_url":"https://github.com/senior","followers_url":"https://api.github.com/users/senior/followers","following_url":"https://api.github.com/users/senior/following{/other_user}","gists_url":"https://api.github.com/users/senior/gists{/gist_id}","starred_url":"https://api.github.com/users/senior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senior/subscriptions","organizations_url":"https://api.github.com/users/senior/orgs","repos_url":"https://api.github.com/users/senior/repos","events_url":"https://api.github.com/users/senior/events{/privacy}","received_events_url":"https://api.github.com/users/senior/received_events","type":"User","site_admin":false},"repo":{"id":13152306,"name":"puppetdb","full_name":"senior/puppetdb","owner":{"login":"senior","id":215910,"avatar_url":"https://avatars.githubusercontent.com/u/215910?v=3","gravatar_id":"","url":"https://api.github.com/users/senior","html_url":"https://github.com/senior","followers_url":"https://api.github.com/users/senior/followers","following_url":"https://api.github.com/users/senior/following{/other_user}","gists_url":"https://api.github.com/users/senior/gists{/gist_id}","starred_url":"https://api.github.com/users/senior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senior/subscriptions","organizations_url":"https://api.github.com/users/senior/orgs","repos_url":"https://api.github.com/users/senior/repos","events_url":"https://api.github.com/users/senior/events{/privacy}","received_events_url":"https://api.github.com/users/senior/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/senior/puppetdb","description":"Centralized Puppet Storage","fork":true,"url":"https://api.github.com/repos/senior/puppetdb","forks_url":"https://api.github.com/repos/senior/puppetdb/forks","keys_url":"https://api.github.com/repos/senior/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/senior/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/senior/puppetdb/teams","hooks_url":"https://api.github.com/repos/senior/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/senior/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/senior/puppetdb/events","assignees_url":"https://api.github.com/repos/senior/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/senior/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/senior/puppetdb/tags","blobs_url":"https://api.github.com/repos/senior/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/senior/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/senior/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/senior/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/senior/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/senior/puppetdb/languages","stargazers_url":"https://api.github.com/repos/senior/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/senior/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/senior/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/senior/puppetdb/subscription","commits_url":"https://api.github.com/repos/senior/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/senior/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/senior/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/senior/puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/senior/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/senior/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/senior/puppetdb/merges","archive_url":"https://api.github.com/repos/senior/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/senior/puppetdb/downloads","issues_url":"https://api.github.com/repos/senior/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/senior/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/senior/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/senior/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/senior/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/senior/puppetdb/releases{/id}","created_at":"2013-09-27T14:18:50Z","updated_at":"2014-06-21T06:15:55Z","pushed_at":"2015-07-07T14:53:29Z","git_url":"git://github.com/senior/puppetdb.git","ssh_url":"git@github.com:senior/puppetdb.git","clone_url":"https://github.com/senior/puppetdb.git","svn_url":"https://github.com/senior/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":14970,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:stable","ref":"stable","sha":"68c445ddd39cdb62eb84c9c8f4bfba0344078461","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2193032,"name":"puppetdb","full_name":"puppetlabs/puppetdb","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetdb","description":"Centralized Puppet Storage","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetdb","forks_url":"https://api.github.com/repos/puppetlabs/puppetdb/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetdb/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetdb/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetdb/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetdb/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetdb/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetdb/releases{/id}","created_at":"2011-08-11T18:54:46Z","updated_at":"2015-06-24T10:48:49Z","pushed_at":"2015-07-08T00:26:57Z","git_url":"git://github.com/puppetlabs/puppetdb.git","ssh_url":"git@github.com:puppetlabs/puppetdb.git","clone_url":"https://github.com/puppetlabs/puppetdb.git","svn_url":"https://github.com/puppetlabs/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":22007,"stargazers_count":164,"watchers_count":164,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":131,"mirror_url":null,"open_issues_count":4,"forks":131,"open_issues":4,"watchers":164,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1518"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1518"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1518"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1518/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1518/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1518/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/20e9d6242afc79f16d1028be46647b59251c448f"}}}}