{"action":"created","issue":{"url":"https://api.github.com/repos/realm/realm-cocoa/issues/2057","labels_url":"https://api.github.com/repos/realm/realm-cocoa/issues/2057/labels{/name}","comments_url":"https://api.github.com/repos/realm/realm-cocoa/issues/2057/comments","events_url":"https://api.github.com/repos/realm/realm-cocoa/issues/2057/events","html_url":"https://github.com/realm/realm-cocoa/pull/2057","id":85632495,"number":2057,"title":"Refactor common object store code to c++","user":{"login":"alazier","id":250144,"avatar_url":"https://avatars.githubusercontent.com/u/250144?v=3","gravatar_id":"","url":"https://api.github.com/users/alazier","html_url":"https://github.com/alazier","followers_url":"https://api.github.com/users/alazier/followers","following_url":"https://api.github.com/users/alazier/following{/other_user}","gists_url":"https://api.github.com/users/alazier/gists{/gist_id}","starred_url":"https://api.github.com/users/alazier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alazier/subscriptions","organizations_url":"https://api.github.com/users/alazier/orgs","repos_url":"https://api.github.com/users/alazier/repos","events_url":"https://api.github.com/users/alazier/events{/privacy}","received_events_url":"https://api.github.com/users/alazier/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/realm/realm-cocoa/labels/pr","name":"pr","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-06-05T21:03:15Z","updated_at":"2015-06-10T22:11:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/realm/realm-cocoa/pulls/2057","html_url":"https://github.com/realm/realm-cocoa/pull/2057","diff_url":"https://github.com/realm/realm-cocoa/pull/2057.diff","patch_url":"https://github.com/realm/realm-cocoa/pull/2057.patch"},"body":"First pass at creation a common code base that can be shared across bindings. Functionally not much has changed, but there are few small differences from previous behaviors:\r\n- `isIndexed` is now ignored for primary key properties - primary key properties will always have an index created\r\n- manually running a migration returns any issues encountered as an NSError as the return value. Before we threw exceptions even though the `performMigration` returns an error.\r\n\r\n@tgoyne @jpsim @bdash "},"comment":{"url":"https://api.github.com/repos/realm/realm-cocoa/issues/comments/110933298","html_url":"https://github.com/realm/realm-cocoa/pull/2057#issuecomment-110933298","issue_url":"https://api.github.com/repos/realm/realm-cocoa/issues/2057","id":110933298,"user":{"login":"alazier","id":250144,"avatar_url":"https://avatars.githubusercontent.com/u/250144?v=3","gravatar_id":"","url":"https://api.github.com/users/alazier","html_url":"https://github.com/alazier","followers_url":"https://api.github.com/users/alazier/followers","following_url":"https://api.github.com/users/alazier/following{/other_user}","gists_url":"https://api.github.com/users/alazier/gists{/gist_id}","starred_url":"https://api.github.com/users/alazier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alazier/subscriptions","organizations_url":"https://api.github.com/users/alazier/orgs","repos_url":"https://api.github.com/users/alazier/repos","events_url":"https://api.github.com/users/alazier/events{/privacy}","received_events_url":"https://api.github.com/users/alazier/received_events","type":"User","site_admin":false},"created_at":"2015-06-10T22:11:50Z","updated_at":"2015-06-10T22:11:50Z","body":"@tgoyne I think I have addressed all of your comments other than implementing `what()` for the exception classes. The issue there is that we really want to return a formatted string, so we need to allocate memory to store each message in the exception. If this is acceptable I will make this change, otherwise will simply not derive from std::exception."}}