{"action":"created","comment":{"url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/pulls/comments/43137659","id":43137659,"diff_hunk":"@@ -195,6 +195,98 @@\n       \"section\": \"Directory Structure\",            \n       \"accept\": \"src/test/java/${connector_package}/automation/system/$\",\n       \"assert\": \"src/test/java/${connector_package}/automation/system\"   \n-    }          \n+    },\n+    \n+    \n+    \n+    {\n+      \"type\": \"source.pom\",\n+      \"id\": \"mule_dependencies_provided\",\n+      \"severity\": \"critical\",\n+      \"brief\": \"Mule dependencies should be <scope>provided</scope>\",\n+      \"description\": \"Mule dependencies should be <scope>provided</scope>\",\n+      \"section\": \"Develop Best Practices\",\n+      \"accept\": \"/pom:project/pom:dependencies/pom:dependency/pom:groupId[text()='org.mule.modules']\",\n+      \"assert\": \"/pom:project/pom:dependencies/pom:dependency/pom:scope[text()='provided']\"\n+    },    \n+    {\n+      \"type\": \"structure\",\n+      \"id\": \"icons\",\n+      \"severity\": \"critical\",     \n+      \"brief\": \"There must be a folder that contains icons for the connector.\",\n+      \"description\": \"There must be a folder that contains icons for the connector.\",      \n+      \"section\": \"Directory Structure\",           \n+      \"accept\": \"icons/$\",\n+      \"assert\": \"icons\"   \n+    },\t\t\t\n+   {\n+      \"type\": \"structure\",\n+      \"id\": \"demo\",\n+      \"severity\": \"critical\",\n+      \"brief\": \"There must be a demo folder that contains one or more demos.\",\n+      \"description\": \"There must be a demo folder that contains one or more demos.\",\n+      \"section\": \"Directory Structure\",        \n+      \"accept\": \"demo/$\",\n+      \"assert\": \"demo\"     \n+    },\n+    \n+    {\n+      \"type\": \"structure\",\n+      \"id\": \"doc\",\n+      \"severity\": \"critical\",\n+      \"brief\": \"There must be a doc folder.\",\n+      \"description\": \"There must be a doc folder.\",\n+      \"section\": \"Directory Structure\",        \n+      \"accept\": \"doc/$\",\n+      \"assert\": \"doc\"     \n+    },    \n+    {\n+      \"type\": \"structure\",\n+      \"id\": \"doc user-manual.adoc\",\n+      \"severity\": \"critical\",\n+      \"brief\": \"There must be a doc folder that contains the files: user-manual.adoc\",\n+      \"description\": \"There must be a doc folder that contains the files: user-manual.adoc.\",\n+      \"section\": \"Directory Structure\",     \n+      \"accept\": \"doc/$\",\n+      \"assert\": \"doc/user-manual.adoc\"\n+    },\n+    {\n+      \"type\": \"structure\",\n+      \"id\": \"doc release-notes.adoc\",\n+      \"severity\": \"critical\",\n+      \"brief\": \"There must be a doc folder that contains the file: release-notes.adoc.\",\n+      \"description\": \"There must be a doc folder that contains the file: release-notes.adoc.\",\n+      \"section\": \"Directory Structure\",     \n+      \"accept\": \"doc/$\",\n+      \"assert\": \"doc/release-notes.adoc\"\n+    },    \n+    {\n+      \"type\": \"structure\",\n+      \"id\": \"doc/images\",\n+      \"severity\": \"critical\",\n+      \"brief\": \"/doc should contain /images for documentation images\",\n+      \"description\": \"/doc should contain /images for documentation images\",\n+      \"section\": \"Directory Structure\",     \n+      \"accept\": \"doc/images/$\",\n+      \"assert\": \"doc/images\"","path":"src/main/resources/rules.json","position":78,"original_position":78,"commit_id":"ba42d0a30a2a4c86daec8defe5951eb7387fbf0d","original_commit_id":"ba42d0a30a2a4c86daec8defe5951eb7387fbf0d","user":{"login":"marianogoldman","id":959563,"avatar_url":"https://avatars.githubusercontent.com/u/959563?v=3","gravatar_id":"","url":"https://api.github.com/users/marianogoldman","html_url":"https://github.com/marianogoldman","followers_url":"https://api.github.com/users/marianogoldman/followers","following_url":"https://api.github.com/users/marianogoldman/following{/other_user}","gists_url":"https://api.github.com/users/marianogoldman/gists{/gist_id}","starred_url":"https://api.github.com/users/marianogoldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marianogoldman/subscriptions","organizations_url":"https://api.github.com/users/marianogoldman/orgs","repos_url":"https://api.github.com/users/marianogoldman/repos","events_url":"https://api.github.com/users/marianogoldman/events{/privacy}","received_events_url":"https://api.github.com/users/marianogoldman/received_events","type":"User","site_admin":false},"body":"I think some connectors have been recently moved to using \"doc/_images\" (note the underscore). Not sure which one is the right one. Let's investigate and fix (either connectors or rules).","created_at":"2015-10-27T15:28:16Z","updated_at":"2015-10-27T15:28:16Z","html_url":"https://github.com/mulesoft-labs/connector-certification-tools/pull/6#discussion_r43137659","pull_request_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/pulls/comments/43137659"},"html":{"href":"https://github.com/mulesoft-labs/connector-certification-tools/pull/6#discussion_r43137659"},"pull_request":{"href":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/pulls/6","id":48764778,"html_url":"https://github.com/mulesoft-labs/connector-certification-tools/pull/6","diff_url":"https://github.com/mulesoft-labs/connector-certification-tools/pull/6.diff","patch_url":"https://github.com/mulesoft-labs/connector-certification-tools/pull/6.patch","issue_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/issues/6","number":6,"state":"open","locked":false,"title":"added rules for directory/structure validations","user":{"login":"josejuradoibanez","id":13328418,"avatar_url":"https://avatars.githubusercontent.com/u/13328418?v=3","gravatar_id":"","url":"https://api.github.com/users/josejuradoibanez","html_url":"https://github.com/josejuradoibanez","followers_url":"https://api.github.com/users/josejuradoibanez/followers","following_url":"https://api.github.com/users/josejuradoibanez/following{/other_user}","gists_url":"https://api.github.com/users/josejuradoibanez/gists{/gist_id}","starred_url":"https://api.github.com/users/josejuradoibanez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josejuradoibanez/subscriptions","organizations_url":"https://api.github.com/users/josejuradoibanez/orgs","repos_url":"https://api.github.com/users/josejuradoibanez/repos","events_url":"https://api.github.com/users/josejuradoibanez/events{/privacy}","received_events_url":"https://api.github.com/users/josejuradoibanez/received_events","type":"User","site_admin":false},"body":"Added rules for the following validations:\r\n - Mule dependencies should be <scope>provided</scope>\r\n - /demo should exist\r\n - /doc should exist\r\n - /doc should contain user_manual.adoc and releaseNotes.adoc\r\n - user_maunal and releaseNotes should be in .adoc format\r\n - /doc should contain /images for documentation images\r\n - /icons should exist\r\n - LICENSE_HEADER.txt should exist\r\n - LICENSE.md should exist","created_at":"2015-10-26T16:44:49Z","updated_at":"2015-10-27T15:28:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21dc3cd6e18dcff3baf3074f234c20015705a088","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/pulls/6/commits","review_comments_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/pulls/6/comments","review_comment_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/issues/6/comments","statuses_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/statuses/ba42d0a30a2a4c86daec8defe5951eb7387fbf0d","head":{"label":"josejuradoibanez:master","ref":"master","sha":"ba42d0a30a2a4c86daec8defe5951eb7387fbf0d","user":{"login":"josejuradoibanez","id":13328418,"avatar_url":"https://avatars.githubusercontent.com/u/13328418?v=3","gravatar_id":"","url":"https://api.github.com/users/josejuradoibanez","html_url":"https://github.com/josejuradoibanez","followers_url":"https://api.github.com/users/josejuradoibanez/followers","following_url":"https://api.github.com/users/josejuradoibanez/following{/other_user}","gists_url":"https://api.github.com/users/josejuradoibanez/gists{/gist_id}","starred_url":"https://api.github.com/users/josejuradoibanez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josejuradoibanez/subscriptions","organizations_url":"https://api.github.com/users/josejuradoibanez/orgs","repos_url":"https://api.github.com/users/josejuradoibanez/repos","events_url":"https://api.github.com/users/josejuradoibanez/events{/privacy}","received_events_url":"https://api.github.com/users/josejuradoibanez/received_events","type":"User","site_admin":false},"repo":{"id":44819038,"name":"connectors-certification-tools","full_name":"josejuradoibanez/connectors-certification-tools","owner":{"login":"josejuradoibanez","id":13328418,"avatar_url":"https://avatars.githubusercontent.com/u/13328418?v=3","gravatar_id":"","url":"https://api.github.com/users/josejuradoibanez","html_url":"https://github.com/josejuradoibanez","followers_url":"https://api.github.com/users/josejuradoibanez/followers","following_url":"https://api.github.com/users/josejuradoibanez/following{/other_user}","gists_url":"https://api.github.com/users/josejuradoibanez/gists{/gist_id}","starred_url":"https://api.github.com/users/josejuradoibanez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josejuradoibanez/subscriptions","organizations_url":"https://api.github.com/users/josejuradoibanez/orgs","repos_url":"https://api.github.com/users/josejuradoibanez/repos","events_url":"https://api.github.com/users/josejuradoibanez/events{/privacy}","received_events_url":"https://api.github.com/users/josejuradoibanez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/josejuradoibanez/connectors-certification-tools","description":"","fork":true,"url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools","forks_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/forks","keys_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/teams","hooks_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/hooks","issue_events_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/issues/events{/number}","events_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/events","assignees_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/assignees{/user}","branches_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/branches{/branch}","tags_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/tags","blobs_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/languages","stargazers_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/stargazers","contributors_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/contributors","subscribers_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/subscribers","subscription_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/subscription","commits_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/contents/{+path}","compare_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/merges","archive_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/downloads","issues_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/issues{/number}","pulls_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/labels{/name}","releases_url":"https://api.github.com/repos/josejuradoibanez/connectors-certification-tools/releases{/id}","created_at":"2015-10-23T14:43:56Z","updated_at":"2015-10-23T14:43:57Z","pushed_at":"2015-10-26T16:37:19Z","git_url":"git://github.com/josejuradoibanez/connectors-certification-tools.git","ssh_url":"git@github.com:josejuradoibanez/connectors-certification-tools.git","clone_url":"https://github.com/josejuradoibanez/connectors-certification-tools.git","svn_url":"https://github.com/josejuradoibanez/connectors-certification-tools","homepage":null,"size":388,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mulesoft-labs:master","ref":"master","sha":"ba7d8703e15fc3603db3f789463cc8bd12253aeb","user":{"login":"mulesoft-labs","id":7331513,"avatar_url":"https://avatars.githubusercontent.com/u/7331513?v=3","gravatar_id":"","url":"https://api.github.com/users/mulesoft-labs","html_url":"https://github.com/mulesoft-labs","followers_url":"https://api.github.com/users/mulesoft-labs/followers","following_url":"https://api.github.com/users/mulesoft-labs/following{/other_user}","gists_url":"https://api.github.com/users/mulesoft-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/mulesoft-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulesoft-labs/subscriptions","organizations_url":"https://api.github.com/users/mulesoft-labs/orgs","repos_url":"https://api.github.com/users/mulesoft-labs/repos","events_url":"https://api.github.com/users/mulesoft-labs/events{/privacy}","received_events_url":"https://api.github.com/users/mulesoft-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":39948039,"name":"connector-certification-tools","full_name":"mulesoft-labs/connector-certification-tools","owner":{"login":"mulesoft-labs","id":7331513,"avatar_url":"https://avatars.githubusercontent.com/u/7331513?v=3","gravatar_id":"","url":"https://api.github.com/users/mulesoft-labs","html_url":"https://github.com/mulesoft-labs","followers_url":"https://api.github.com/users/mulesoft-labs/followers","following_url":"https://api.github.com/users/mulesoft-labs/following{/other_user}","gists_url":"https://api.github.com/users/mulesoft-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/mulesoft-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulesoft-labs/subscriptions","organizations_url":"https://api.github.com/users/mulesoft-labs/orgs","repos_url":"https://api.github.com/users/mulesoft-labs/repos","events_url":"https://api.github.com/users/mulesoft-labs/events{/privacy}","received_events_url":"https://api.github.com/users/mulesoft-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mulesoft-labs/connector-certification-tools","description":"","fork":false,"url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools","forks_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/forks","keys_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/teams","hooks_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/hooks","issue_events_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/issues/events{/number}","events_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/events","assignees_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/assignees{/user}","branches_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/branches{/branch}","tags_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/tags","blobs_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/languages","stargazers_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/stargazers","contributors_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/contributors","subscribers_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/subscribers","subscription_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/subscription","commits_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/contents/{+path}","compare_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/merges","archive_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/downloads","issues_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/issues{/number}","pulls_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/labels{/name}","releases_url":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/releases{/id}","created_at":"2015-07-30T11:54:02Z","updated_at":"2015-10-24T01:41:55Z","pushed_at":"2015-10-27T15:15:58Z","git_url":"git://github.com/mulesoft-labs/connector-certification-tools.git","ssh_url":"git@github.com:mulesoft-labs/connector-certification-tools.git","clone_url":"https://github.com/mulesoft-labs/connector-certification-tools.git","svn_url":"https://github.com/mulesoft-labs/connector-certification-tools","homepage":null,"size":388,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/pulls/6"},"html":{"href":"https://github.com/mulesoft-labs/connector-certification-tools/pull/6"},"issue":{"href":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/issues/6"},"comments":{"href":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/mulesoft-labs/connector-certification-tools/statuses/ba42d0a30a2a4c86daec8defe5951eb7387fbf0d"}}}}