{"action":"created","comment":{"url":"https://api.github.com/repos/druid-io/druid/pulls/comments/33173043","id":33173043,"diff_hunk":"@@ -41,9 +42,9 @@ public IntervalLoadRule(\n       @JsonProperty(\"tieredReplicants\") Map<String, Integer> tieredReplicants\n   )\n   {\n-    validateTieredReplicants(tieredReplicants);\n+    this.tieredReplicants = tieredReplicants == null ? ImmutableMap.<String, Integer>of() : tieredReplicants;","path":"server/src/main/java/io/druid/server/coordinator/rules/IntervalLoadRule.java","position":13,"original_position":13,"commit_id":"4285f7bb4f59c5a9a316147b050d8b81ab26c6fc","original_commit_id":"4285f7bb4f59c5a9a316147b050d8b81ab26c6fc","user":{"login":"drcrallen","id":8213081,"avatar_url":"https://avatars.githubusercontent.com/u/8213081?v=3","gravatar_id":"","url":"https://api.github.com/users/drcrallen","html_url":"https://github.com/drcrallen","followers_url":"https://api.github.com/users/drcrallen/followers","following_url":"https://api.github.com/users/drcrallen/following{/other_user}","gists_url":"https://api.github.com/users/drcrallen/gists{/gist_id}","starred_url":"https://api.github.com/users/drcrallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drcrallen/subscriptions","organizations_url":"https://api.github.com/users/drcrallen/orgs","repos_url":"https://api.github.com/users/drcrallen/repos","events_url":"https://api.github.com/users/drcrallen/events{/privacy}","received_events_url":"https://api.github.com/users/drcrallen/received_events","type":"User","site_admin":false},"body":"That's a good call","created_at":"2015-06-24T17:31:20Z","updated_at":"2015-06-24T17:31:20Z","html_url":"https://github.com/druid-io/druid/pull/1462#discussion_r33173043","pull_request_url":"https://api.github.com/repos/druid-io/druid/pulls/1462","_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments/33173043"},"html":{"href":"https://github.com/druid-io/druid/pull/1462#discussion_r33173043"},"pull_request":{"href":"https://api.github.com/repos/druid-io/druid/pulls/1462"}}},"pull_request":{"url":"https://api.github.com/repos/druid-io/druid/pulls/1462","id":38456794,"html_url":"https://github.com/druid-io/druid/pull/1462","diff_url":"https://github.com/druid-io/druid/pull/1462.diff","patch_url":"https://github.com/druid-io/druid/pull/1462.patch","issue_url":"https://api.github.com/repos/druid-io/druid/issues/1462","number":1462,"state":"open","locked":false,"title":"tieredReplicants can be null","user":{"login":"pjain1","id":11787983,"avatar_url":"https://avatars.githubusercontent.com/u/11787983?v=3","gravatar_id":"","url":"https://api.github.com/users/pjain1","html_url":"https://github.com/pjain1","followers_url":"https://api.github.com/users/pjain1/followers","following_url":"https://api.github.com/users/pjain1/following{/other_user}","gists_url":"https://api.github.com/users/pjain1/gists{/gist_id}","starred_url":"https://api.github.com/users/pjain1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjain1/subscriptions","organizations_url":"https://api.github.com/users/pjain1/orgs","repos_url":"https://api.github.com/users/pjain1/repos","events_url":"https://api.github.com/users/pjain1/events{/privacy}","received_events_url":"https://api.github.com/users/pjain1/received_events","type":"User","site_admin":false},"body":"- Setting tieredReplicants to be an empty Map if it is null so that getNumReplicants method does not throws NPE.\r\n- Added serde test for when it is null","created_at":"2015-06-24T15:48:35Z","updated_at":"2015-06-24T17:31:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"648d3663f9c51d84101e6ce5ad9c20233829a95f","assignee":null,"milestone":{"url":"https://api.github.com/repos/druid-io/druid/milestones/11","html_url":"https://github.com/druid-io/druid/milestones/0.8.0","labels_url":"https://api.github.com/repos/druid-io/druid/milestones/11/labels","id":977939,"number":11,"title":"0.8.0","description":"","creator":{"login":"xvrl","id":815147,"avatar_url":"https://avatars.githubusercontent.com/u/815147?v=3","gravatar_id":"","url":"https://api.github.com/users/xvrl","html_url":"https://github.com/xvrl","followers_url":"https://api.github.com/users/xvrl/followers","following_url":"https://api.github.com/users/xvrl/following{/other_user}","gists_url":"https://api.github.com/users/xvrl/gists{/gist_id}","starred_url":"https://api.github.com/users/xvrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xvrl/subscriptions","organizations_url":"https://api.github.com/users/xvrl/orgs","repos_url":"https://api.github.com/users/xvrl/repos","events_url":"https://api.github.com/users/xvrl/events{/privacy}","received_events_url":"https://api.github.com/users/xvrl/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":11,"state":"open","created_at":"2015-02-13T04:47:46Z","updated_at":"2015-06-24T15:59:17Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/druid-io/druid/pulls/1462/commits","review_comments_url":"https://api.github.com/repos/druid-io/druid/pulls/1462/comments","review_comment_url":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druid-io/druid/issues/1462/comments","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/4285f7bb4f59c5a9a316147b050d8b81ab26c6fc","head":{"label":"pjain1:validate_rules","ref":"validate_rules","sha":"4285f7bb4f59c5a9a316147b050d8b81ab26c6fc","user":{"login":"pjain1","id":11787983,"avatar_url":"https://avatars.githubusercontent.com/u/11787983?v=3","gravatar_id":"","url":"https://api.github.com/users/pjain1","html_url":"https://github.com/pjain1","followers_url":"https://api.github.com/users/pjain1/followers","following_url":"https://api.github.com/users/pjain1/following{/other_user}","gists_url":"https://api.github.com/users/pjain1/gists{/gist_id}","starred_url":"https://api.github.com/users/pjain1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjain1/subscriptions","organizations_url":"https://api.github.com/users/pjain1/orgs","repos_url":"https://api.github.com/users/pjain1/repos","events_url":"https://api.github.com/users/pjain1/events{/privacy}","received_events_url":"https://api.github.com/users/pjain1/received_events","type":"User","site_admin":false},"repo":{"id":33489992,"name":"druid","full_name":"pjain1/druid","owner":{"login":"pjain1","id":11787983,"avatar_url":"https://avatars.githubusercontent.com/u/11787983?v=3","gravatar_id":"","url":"https://api.github.com/users/pjain1","html_url":"https://github.com/pjain1","followers_url":"https://api.github.com/users/pjain1/followers","following_url":"https://api.github.com/users/pjain1/following{/other_user}","gists_url":"https://api.github.com/users/pjain1/gists{/gist_id}","starred_url":"https://api.github.com/users/pjain1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjain1/subscriptions","organizations_url":"https://api.github.com/users/pjain1/orgs","repos_url":"https://api.github.com/users/pjain1/repos","events_url":"https://api.github.com/users/pjain1/events{/privacy}","received_events_url":"https://api.github.com/users/pjain1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pjain1/druid","description":"Real²time Exploratory Analytics on Large Datasets","fork":true,"url":"https://api.github.com/repos/pjain1/druid","forks_url":"https://api.github.com/repos/pjain1/druid/forks","keys_url":"https://api.github.com/repos/pjain1/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pjain1/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pjain1/druid/teams","hooks_url":"https://api.github.com/repos/pjain1/druid/hooks","issue_events_url":"https://api.github.com/repos/pjain1/druid/issues/events{/number}","events_url":"https://api.github.com/repos/pjain1/druid/events","assignees_url":"https://api.github.com/repos/pjain1/druid/assignees{/user}","branches_url":"https://api.github.com/repos/pjain1/druid/branches{/branch}","tags_url":"https://api.github.com/repos/pjain1/druid/tags","blobs_url":"https://api.github.com/repos/pjain1/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pjain1/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pjain1/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/pjain1/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pjain1/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/pjain1/druid/languages","stargazers_url":"https://api.github.com/repos/pjain1/druid/stargazers","contributors_url":"https://api.github.com/repos/pjain1/druid/contributors","subscribers_url":"https://api.github.com/repos/pjain1/druid/subscribers","subscription_url":"https://api.github.com/repos/pjain1/druid/subscription","commits_url":"https://api.github.com/repos/pjain1/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/pjain1/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/pjain1/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/pjain1/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/pjain1/druid/contents/{+path}","compare_url":"https://api.github.com/repos/pjain1/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pjain1/druid/merges","archive_url":"https://api.github.com/repos/pjain1/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pjain1/druid/downloads","issues_url":"https://api.github.com/repos/pjain1/druid/issues{/number}","pulls_url":"https://api.github.com/repos/pjain1/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/pjain1/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/pjain1/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pjain1/druid/labels{/name}","releases_url":"https://api.github.com/repos/pjain1/druid/releases{/id}","created_at":"2015-04-06T15:44:13Z","updated_at":"2015-05-06T21:31:13Z","pushed_at":"2015-06-24T17:07:23Z","git_url":"git://github.com/pjain1/druid.git","ssh_url":"git@github.com:pjain1/druid.git","clone_url":"https://github.com/pjain1/druid.git","svn_url":"https://github.com/pjain1/druid","homepage":"http://druid.io","size":94617,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"druid-io:master","ref":"master","sha":"9104d08a6aa24e667e11ec658c7e9a1968a7ac1f","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"name":"druid","full_name":"druid-io/druid","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/druid","description":"Real²time Exploratory Analytics on Large Datasets","fork":false,"url":"https://api.github.com/repos/druid-io/druid","forks_url":"https://api.github.com/repos/druid-io/druid/forks","keys_url":"https://api.github.com/repos/druid-io/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/druid/teams","hooks_url":"https://api.github.com/repos/druid-io/druid/hooks","issue_events_url":"https://api.github.com/repos/druid-io/druid/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/druid/events","assignees_url":"https://api.github.com/repos/druid-io/druid/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/druid/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/druid/tags","blobs_url":"https://api.github.com/repos/druid-io/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/druid/languages","stargazers_url":"https://api.github.com/repos/druid-io/druid/stargazers","contributors_url":"https://api.github.com/repos/druid-io/druid/contributors","subscribers_url":"https://api.github.com/repos/druid-io/druid/subscribers","subscription_url":"https://api.github.com/repos/druid-io/druid/subscription","commits_url":"https://api.github.com/repos/druid-io/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/druid-io/druid/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/druid/merges","archive_url":"https://api.github.com/repos/druid-io/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/druid/downloads","issues_url":"https://api.github.com/repos/druid-io/druid/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/druid/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/druid/releases{/id}","created_at":"2012-10-23T19:08:07Z","updated_at":"2015-06-23T17:38:44Z","pushed_at":"2015-06-24T17:07:26Z","git_url":"git://github.com/druid-io/druid.git","ssh_url":"git@github.com:druid-io/druid.git","clone_url":"https://github.com/druid-io/druid.git","svn_url":"https://github.com/druid-io/druid","homepage":"http://druid.io","size":171660,"stargazers_count":1836,"watchers_count":1836,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":393,"mirror_url":null,"open_issues_count":125,"forks":393,"open_issues":125,"watchers":1836,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/1462"},"html":{"href":"https://github.com/druid-io/druid/pull/1462"},"issue":{"href":"https://api.github.com/repos/druid-io/druid/issues/1462"},"comments":{"href":"https://api.github.com/repos/druid-io/druid/issues/1462/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/druid/pulls/1462/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druid-io/druid/pulls/1462/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/druid/statuses/4285f7bb4f59c5a9a316147b050d8b81ab26c6fc"}}}}