{"action":"closed","number":782,"pull_request":{"url":"https://api.github.com/repos/IRATI/stack/pulls/782","id":49449875,"html_url":"https://github.com/IRATI/stack/pull/782","diff_url":"https://github.com/IRATI/stack/pull/782.diff","patch_url":"https://github.com/IRATI/stack/pull/782.patch","issue_url":"https://api.github.com/repos/IRATI/stack/issues/782","number":782,"state":"closed","locked":false,"title":"Pristine 1.4 rmtwf clean","user":{"login":"lbergesio","id":1797884,"avatar_url":"https://avatars.githubusercontent.com/u/1797884?v=3","gravatar_id":"","url":"https://api.github.com/users/lbergesio","html_url":"https://github.com/lbergesio","followers_url":"https://api.github.com/users/lbergesio/followers","following_url":"https://api.github.com/users/lbergesio/following{/other_user}","gists_url":"https://api.github.com/users/lbergesio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbergesio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbergesio/subscriptions","organizations_url":"https://api.github.com/users/lbergesio/orgs","repos_url":"https://api.github.com/users/lbergesio/repos","events_url":"https://api.github.com/users/lbergesio/events{/privacy}","received_events_url":"https://api.github.com/users/lbergesio/received_events","type":"User","site_admin":false},"body":"This PR depends on #781 of pristine-1.3.\r\n\r\nThe set of policies for the RMT's PS has been changed according to experience in\r\nRecent experience developing diffrent RMT's PSs (cherish/urgency, red, jain) has\r\nshown that the current set of policies for the RMT were wrong. Most of them were\r\nnever used and many times accommodating to them made the code more complicated.\r\n\r\nThe new api contemplates the following policies:\r\n```\r\n\tstruct pdu *(*rmt_dequeue_policy)(struct rmt_ps *,\r\n\t\t\t\t\t  struct rmt_n1_port *);\r\n\tint (*rmt_enqueue_policy)(struct rmt_ps *,\r\n\t\t\t\t  struct rmt_n1_port *,\r\n\t\t\t\t  struct pdu *);\r\n\tint (*rmt_q_create_policy)(struct rmt_ps *,\r\n\t\t\t\t   struct rmt_n1_port *);\r\n\tint (*rmt_q_destroy_policy)(struct rmt_ps *,\r\n\t\t\t\t    struct rmt_n1_port *);\r\n\tint (*rmt_needs_sched_policy(struct rmt_ps *,\r\n\t\t\t\t     struct rmt_n1_port *);\r\n```\r\nThe rmt_enqueue_policy policy return code is the following:\r\n- ```RMT_PS_ENQ_SCHED```:\tPDU was enqueued properly, RMT mechanism must schedule\r\n\t\t\t(currently set a tasklet).\r\n- ```RMT_PS_ENQ_DSEND```:\tNo need to schedule, ownership of PDU by policy is\r\n\t\t\trejected, it must be directly sent by the RMT mechanism.\r\n- ```RMT_PS_ENQ_DROP```: \tN-1 Port's queue's full or for some other reason PDU has\r\n\t\t\tbeen dropped.\r\n- ```RMT_PS_ENQ_ERR```:\tSomething went wrong.\r\n\r\nLocking in the RMT was also fixed and improved following a reference counting approach to safely delete elements (n1_ports, etc).\r\n\r\nMaintainers:\r\n@lbergesio; ==> @edugrasa, @miqueltarzan for my part\r\nF: linux/net/rina/efcp.c\r\nF: plugins/cong_avoidance/rmt-ps-cas.c\r\nF: plugins/dummy/rmt-ps-dummy.c\r\nF: plugins/red/rmt-ps-red.c\r\n\r\n@miqueltarzan \r\nF: linux/net/rina/ipcps/normal-ipcp.c\r\nF: linux/net/rina/rmt-ps-default.c\r\nF: linux/net/rina/rmt-ps-default.h\r\nF: linux/net/rina/rmt-ps.h\r\nF: linux/net/rina/rmt.c\r\nF: linux/net/rina/rmt.h\r\n\r\n@vmaffione \r\nF: linux/net/rina/pci.c","created_at":"2015-11-02T16:07:05Z","updated_at":"2015-11-10T16:21:19Z","closed_at":"2015-11-10T16:21:19Z","merged_at":"2015-11-10T16:21:19Z","merge_commit_sha":"d2cf88ba537759ed7d241e0cf0cf87393e1b95fb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/IRATI/stack/pulls/782/commits","review_comments_url":"https://api.github.com/repos/IRATI/stack/pulls/782/comments","review_comment_url":"https://api.github.com/repos/IRATI/stack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IRATI/stack/issues/782/comments","statuses_url":"https://api.github.com/repos/IRATI/stack/statuses/102d417f1a8108d92f49ac22a7c997bf7218af0e","head":{"label":"lbergesio:pristine-1.4-rmtwf-clean","ref":"pristine-1.4-rmtwf-clean","sha":"102d417f1a8108d92f49ac22a7c997bf7218af0e","user":{"login":"lbergesio","id":1797884,"avatar_url":"https://avatars.githubusercontent.com/u/1797884?v=3","gravatar_id":"","url":"https://api.github.com/users/lbergesio","html_url":"https://github.com/lbergesio","followers_url":"https://api.github.com/users/lbergesio/followers","following_url":"https://api.github.com/users/lbergesio/following{/other_user}","gists_url":"https://api.github.com/users/lbergesio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbergesio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbergesio/subscriptions","organizations_url":"https://api.github.com/users/lbergesio/orgs","repos_url":"https://api.github.com/users/lbergesio/repos","events_url":"https://api.github.com/users/lbergesio/events{/privacy}","received_events_url":"https://api.github.com/users/lbergesio/received_events","type":"User","site_admin":false},"repo":{"id":31063004,"name":"stack","full_name":"lbergesio/stack","owner":{"login":"lbergesio","id":1797884,"avatar_url":"https://avatars.githubusercontent.com/u/1797884?v=3","gravatar_id":"","url":"https://api.github.com/users/lbergesio","html_url":"https://github.com/lbergesio","followers_url":"https://api.github.com/users/lbergesio/followers","following_url":"https://api.github.com/users/lbergesio/following{/other_user}","gists_url":"https://api.github.com/users/lbergesio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbergesio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbergesio/subscriptions","organizations_url":"https://api.github.com/users/lbergesio/orgs","repos_url":"https://api.github.com/users/lbergesio/repos","events_url":"https://api.github.com/users/lbergesio/events{/privacy}","received_events_url":"https://api.github.com/users/lbergesio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lbergesio/stack","description":"RINA implementation for OS/Linux","fork":true,"url":"https://api.github.com/repos/lbergesio/stack","forks_url":"https://api.github.com/repos/lbergesio/stack/forks","keys_url":"https://api.github.com/repos/lbergesio/stack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lbergesio/stack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lbergesio/stack/teams","hooks_url":"https://api.github.com/repos/lbergesio/stack/hooks","issue_events_url":"https://api.github.com/repos/lbergesio/stack/issues/events{/number}","events_url":"https://api.github.com/repos/lbergesio/stack/events","assignees_url":"https://api.github.com/repos/lbergesio/stack/assignees{/user}","branches_url":"https://api.github.com/repos/lbergesio/stack/branches{/branch}","tags_url":"https://api.github.com/repos/lbergesio/stack/tags","blobs_url":"https://api.github.com/repos/lbergesio/stack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lbergesio/stack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lbergesio/stack/git/refs{/sha}","trees_url":"https://api.github.com/repos/lbergesio/stack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lbergesio/stack/statuses/{sha}","languages_url":"https://api.github.com/repos/lbergesio/stack/languages","stargazers_url":"https://api.github.com/repos/lbergesio/stack/stargazers","contributors_url":"https://api.github.com/repos/lbergesio/stack/contributors","subscribers_url":"https://api.github.com/repos/lbergesio/stack/subscribers","subscription_url":"https://api.github.com/repos/lbergesio/stack/subscription","commits_url":"https://api.github.com/repos/lbergesio/stack/commits{/sha}","git_commits_url":"https://api.github.com/repos/lbergesio/stack/git/commits{/sha}","comments_url":"https://api.github.com/repos/lbergesio/stack/comments{/number}","issue_comment_url":"https://api.github.com/repos/lbergesio/stack/issues/comments{/number}","contents_url":"https://api.github.com/repos/lbergesio/stack/contents/{+path}","compare_url":"https://api.github.com/repos/lbergesio/stack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lbergesio/stack/merges","archive_url":"https://api.github.com/repos/lbergesio/stack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lbergesio/stack/downloads","issues_url":"https://api.github.com/repos/lbergesio/stack/issues{/number}","pulls_url":"https://api.github.com/repos/lbergesio/stack/pulls{/number}","milestones_url":"https://api.github.com/repos/lbergesio/stack/milestones{/number}","notifications_url":"https://api.github.com/repos/lbergesio/stack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lbergesio/stack/labels{/name}","releases_url":"https://api.github.com/repos/lbergesio/stack/releases{/id}","created_at":"2015-02-20T11:58:13Z","updated_at":"2015-02-20T12:02:05Z","pushed_at":"2015-11-10T14:27:50Z","git_url":"git://github.com/lbergesio/stack.git","ssh_url":"git@github.com:lbergesio/stack.git","clone_url":"https://github.com/lbergesio/stack.git","svn_url":"https://github.com/lbergesio/stack","homepage":"http://irati.github.io/stack","size":249328,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IRATI:pristine-1.4","ref":"pristine-1.4","sha":"dc494d12226a33576338e12cc9cc732c26aecbb9","user":{"login":"IRATI","id":9579648,"avatar_url":"https://avatars.githubusercontent.com/u/9579648?v=3","gravatar_id":"","url":"https://api.github.com/users/IRATI","html_url":"https://github.com/IRATI","followers_url":"https://api.github.com/users/IRATI/followers","following_url":"https://api.github.com/users/IRATI/following{/other_user}","gists_url":"https://api.github.com/users/IRATI/gists{/gist_id}","starred_url":"https://api.github.com/users/IRATI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IRATI/subscriptions","organizations_url":"https://api.github.com/users/IRATI/orgs","repos_url":"https://api.github.com/users/IRATI/repos","events_url":"https://api.github.com/users/IRATI/events{/privacy}","received_events_url":"https://api.github.com/users/IRATI/received_events","type":"Organization","site_admin":false},"repo":{"id":26241846,"name":"stack","full_name":"IRATI/stack","owner":{"login":"IRATI","id":9579648,"avatar_url":"https://avatars.githubusercontent.com/u/9579648?v=3","gravatar_id":"","url":"https://api.github.com/users/IRATI","html_url":"https://github.com/IRATI","followers_url":"https://api.github.com/users/IRATI/followers","following_url":"https://api.github.com/users/IRATI/following{/other_user}","gists_url":"https://api.github.com/users/IRATI/gists{/gist_id}","starred_url":"https://api.github.com/users/IRATI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IRATI/subscriptions","organizations_url":"https://api.github.com/users/IRATI/orgs","repos_url":"https://api.github.com/users/IRATI/repos","events_url":"https://api.github.com/users/IRATI/events{/privacy}","received_events_url":"https://api.github.com/users/IRATI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IRATI/stack","description":"RINA implementation for OS/Linux","fork":false,"url":"https://api.github.com/repos/IRATI/stack","forks_url":"https://api.github.com/repos/IRATI/stack/forks","keys_url":"https://api.github.com/repos/IRATI/stack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IRATI/stack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IRATI/stack/teams","hooks_url":"https://api.github.com/repos/IRATI/stack/hooks","issue_events_url":"https://api.github.com/repos/IRATI/stack/issues/events{/number}","events_url":"https://api.github.com/repos/IRATI/stack/events","assignees_url":"https://api.github.com/repos/IRATI/stack/assignees{/user}","branches_url":"https://api.github.com/repos/IRATI/stack/branches{/branch}","tags_url":"https://api.github.com/repos/IRATI/stack/tags","blobs_url":"https://api.github.com/repos/IRATI/stack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IRATI/stack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IRATI/stack/git/refs{/sha}","trees_url":"https://api.github.com/repos/IRATI/stack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IRATI/stack/statuses/{sha}","languages_url":"https://api.github.com/repos/IRATI/stack/languages","stargazers_url":"https://api.github.com/repos/IRATI/stack/stargazers","contributors_url":"https://api.github.com/repos/IRATI/stack/contributors","subscribers_url":"https://api.github.com/repos/IRATI/stack/subscribers","subscription_url":"https://api.github.com/repos/IRATI/stack/subscription","commits_url":"https://api.github.com/repos/IRATI/stack/commits{/sha}","git_commits_url":"https://api.github.com/repos/IRATI/stack/git/commits{/sha}","comments_url":"https://api.github.com/repos/IRATI/stack/comments{/number}","issue_comment_url":"https://api.github.com/repos/IRATI/stack/issues/comments{/number}","contents_url":"https://api.github.com/repos/IRATI/stack/contents/{+path}","compare_url":"https://api.github.com/repos/IRATI/stack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IRATI/stack/merges","archive_url":"https://api.github.com/repos/IRATI/stack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IRATI/stack/downloads","issues_url":"https://api.github.com/repos/IRATI/stack/issues{/number}","pulls_url":"https://api.github.com/repos/IRATI/stack/pulls{/number}","milestones_url":"https://api.github.com/repos/IRATI/stack/milestones{/number}","notifications_url":"https://api.github.com/repos/IRATI/stack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IRATI/stack/labels{/name}","releases_url":"https://api.github.com/repos/IRATI/stack/releases{/id}","created_at":"2014-11-05T22:04:17Z","updated_at":"2015-10-28T17:32:35Z","pushed_at":"2015-11-10T16:21:19Z","git_url":"git://github.com/IRATI/stack.git","ssh_url":"git@github.com:IRATI/stack.git","clone_url":"https://github.com/IRATI/stack.git","svn_url":"https://github.com/IRATI/stack","homepage":"http://irati.github.io/stack","size":252651,"stargazers_count":15,"watchers_count":15,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":25,"mirror_url":null,"open_issues_count":76,"forks":25,"open_issues":76,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IRATI/stack/pulls/782"},"html":{"href":"https://github.com/IRATI/stack/pull/782"},"issue":{"href":"https://api.github.com/repos/IRATI/stack/issues/782"},"comments":{"href":"https://api.github.com/repos/IRATI/stack/issues/782/comments"},"review_comments":{"href":"https://api.github.com/repos/IRATI/stack/pulls/782/comments"},"review_comment":{"href":"https://api.github.com/repos/IRATI/stack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IRATI/stack/pulls/782/commits"},"statuses":{"href":"https://api.github.com/repos/IRATI/stack/statuses/102d417f1a8108d92f49ac22a7c997bf7218af0e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"edugrasa","id":325005,"avatar_url":"https://avatars.githubusercontent.com/u/325005?v=3","gravatar_id":"","url":"https://api.github.com/users/edugrasa","html_url":"https://github.com/edugrasa","followers_url":"https://api.github.com/users/edugrasa/followers","following_url":"https://api.github.com/users/edugrasa/following{/other_user}","gists_url":"https://api.github.com/users/edugrasa/gists{/gist_id}","starred_url":"https://api.github.com/users/edugrasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edugrasa/subscriptions","organizations_url":"https://api.github.com/users/edugrasa/orgs","repos_url":"https://api.github.com/users/edugrasa/repos","events_url":"https://api.github.com/users/edugrasa/events{/privacy}","received_events_url":"https://api.github.com/users/edugrasa/received_events","type":"User","site_admin":false},"comments":11,"review_comments":0,"commits":8,"additions":655,"deletions":607,"changed_files":10}}