{"action":"created","issue":{"url":"https://api.github.com/repos/janbar/pvr.mythtv/issues/8","labels_url":"https://api.github.com/repos/janbar/pvr.mythtv/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/janbar/pvr.mythtv/issues/8/comments","events_url":"https://api.github.com/repos/janbar/pvr.mythtv/issues/8/events","html_url":"https://github.com/janbar/pvr.mythtv/pull/8","id":99833008,"number":8,"title":"Introduce UpdateFromTimer function","user":{"login":"metaron-uk","id":12870817,"avatar_url":"https://avatars.githubusercontent.com/u/12870817?v=3","gravatar_id":"","url":"https://api.github.com/users/metaron-uk","html_url":"https://github.com/metaron-uk","followers_url":"https://api.github.com/users/metaron-uk/followers","following_url":"https://api.github.com/users/metaron-uk/following{/other_user}","gists_url":"https://api.github.com/users/metaron-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/metaron-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metaron-uk/subscriptions","organizations_url":"https://api.github.com/users/metaron-uk/orgs","repos_url":"https://api.github.com/users/metaron-uk/repos","events_url":"https://api.github.com/users/metaron-uk/events{/privacy}","received_events_url":"https://api.github.com/users/metaron-uk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-08-08T20:55:31Z","updated_at":"2015-08-09T21:43:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/janbar/pvr.mythtv/pulls/8","html_url":"https://github.com/janbar/pvr.mythtv/pull/8","diff_url":"https://github.com/janbar/pvr.mythtv/pull/8.diff","patch_url":"https://github.com/janbar/pvr.mythtv/pull/8.patch"},"body":"@janbar This introduces only the new function as you requested.\r\nNow it will only modify settings allowed by MythScheduleManager::UpdateRecordingRule\r\n\r\nThe code can also change other settings (selected channel, 'any channel', 'any time', search type, rule type etc...), but other parts of code need fixing first (see Part 1 and Part 2 of my proposed changes).\r\nYou will get extra debug statements showing you what would have changed.\r\n\r\nIf you like this, I will prepare these fixes/changes, one commit for each setting I enable.\r\n\r\nTo really work properly I also need to do parts 1, 2, 6 and part of 4 (without the API 3.0.0 change). (see http://forum.kodi.tv/showthread.php?tid=230145&pid=2074228#pid2074228 )"},"comment":{"url":"https://api.github.com/repos/janbar/pvr.mythtv/issues/comments/129244084","html_url":"https://github.com/janbar/pvr.mythtv/pull/8#issuecomment-129244084","issue_url":"https://api.github.com/repos/janbar/pvr.mythtv/issues/8","id":129244084,"user":{"login":"metaron-uk","id":12870817,"avatar_url":"https://avatars.githubusercontent.com/u/12870817?v=3","gravatar_id":"","url":"https://api.github.com/users/metaron-uk","html_url":"https://github.com/metaron-uk","followers_url":"https://api.github.com/users/metaron-uk/followers","following_url":"https://api.github.com/users/metaron-uk/following{/other_user}","gists_url":"https://api.github.com/users/metaron-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/metaron-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metaron-uk/subscriptions","organizations_url":"https://api.github.com/users/metaron-uk/orgs","repos_url":"https://api.github.com/users/metaron-uk/repos","events_url":"https://api.github.com/users/metaron-uk/events{/privacy}","received_events_url":"https://api.github.com/users/metaron-uk/received_events","type":"User","site_admin":false},"created_at":"2015-08-09T21:43:07Z","updated_at":"2015-08-09T21:43:07Z","body":"Probably it is best to use a switch on timer type. An upcoming will always have a parent rule, but a rule will not always have an upcoming, so we can't use the same method for both.\r\nI noticed mythweb doesn't set parent ID correctly for over-rides as well. Makes it difficult to delete them when the parent is deleted....\r\n\r\nWe need to remember that UpdateRecordingRule uses 'create/delete over-ride' methods to deal with changes to upcoming, so spending effort here to get the parent rule may be wasted (I think this is why the current code appears to work). I will investigate."}}