{"action":"created","issue":{"url":"https://api.github.com/repos/ericclemmons/bookshelf-manager/issues/7","labels_url":"https://api.github.com/repos/ericclemmons/bookshelf-manager/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/ericclemmons/bookshelf-manager/issues/7/comments","events_url":"https://api.github.com/repos/ericclemmons/bookshelf-manager/issues/7/events","html_url":"https://github.com/ericclemmons/bookshelf-manager/pull/7","id":91386261,"number":7,"title":"Reimplement as a plugin for Bookshelf/Knex 0.8.x ","user":{"login":"blah238","id":538730,"avatar_url":"https://avatars.githubusercontent.com/u/538730?v=3","gravatar_id":"","url":"https://api.github.com/users/blah238","html_url":"https://github.com/blah238","followers_url":"https://api.github.com/users/blah238/followers","following_url":"https://api.github.com/users/blah238/following{/other_user}","gists_url":"https://api.github.com/users/blah238/gists{/gist_id}","starred_url":"https://api.github.com/users/blah238/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blah238/subscriptions","organizations_url":"https://api.github.com/users/blah238/orgs","repos_url":"https://api.github.com/users/blah238/repos","events_url":"https://api.github.com/users/blah238/events{/privacy}","received_events_url":"https://api.github.com/users/blah238/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-06-26T23:35:42Z","updated_at":"2015-06-29T21:17:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ericclemmons/bookshelf-manager/pulls/7","html_url":"https://github.com/ericclemmons/bookshelf-manager/pull/7","diff_url":"https://github.com/ericclemmons/bookshelf-manager/pull/7.diff","patch_url":"https://github.com/ericclemmons/bookshelf-manager/pull/7.patch"},"body":"I've rewritten much of this library to work with the current Bookshelf/Knex versions and added several other improvements and simplifications. I think it's a great library that just needed a bit of an update. See the updated `README.md` for usage as a plugin.\r\n\r\n  - Changed constructor signature to require Bookshelf instance as first argument, and made `root` an optional property of the second `options` argument\r\n  - Added `Manager.plugin()` method to be used with `Bookshelf.plugin()` (exported on main `index.js` module)\r\n  - Exposes self as `manager` property on Bookshelf instance when instantiated\r\n  - Replaced `Manager.manage()` and `Manager.manages()` with `manager.register()` to improve compatibility with [Bookshelf Registry](https://github.com/tgriesser/bookshelf/wiki/Plugin:-Model-Registry) plugin\r\n  - Removed `hooker` dependency and `manager.debug()` method\r\n  - Use NPM `devDependencies` and `peerDependencies` instead of `dependencies` since it is intended to be used as a plugin now\r\n  - Changed test database from MySQL to SQLite for easier testing setup\r\n  - Updated `README.md`\r\n  - Bumped version to 0.1.0 (not fully backwards-compatible)\r\n  - Add JSHint/JSCS configs\r\n\r\nPlease let me know if anyone has any questions. Otherwise I'd love to get this merged!"},"comment":{"url":"https://api.github.com/repos/ericclemmons/bookshelf-manager/issues/comments/116849034","html_url":"https://github.com/ericclemmons/bookshelf-manager/pull/7#issuecomment-116849034","issue_url":"https://api.github.com/repos/ericclemmons/bookshelf-manager/issues/7","id":116849034,"user":{"login":"blah238","id":538730,"avatar_url":"https://avatars.githubusercontent.com/u/538730?v=3","gravatar_id":"","url":"https://api.github.com/users/blah238","html_url":"https://github.com/blah238","followers_url":"https://api.github.com/users/blah238/followers","following_url":"https://api.github.com/users/blah238/following{/other_user}","gists_url":"https://api.github.com/users/blah238/gists{/gist_id}","starred_url":"https://api.github.com/users/blah238/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blah238/subscriptions","organizations_url":"https://api.github.com/users/blah238/orgs","repos_url":"https://api.github.com/users/blah238/repos","events_url":"https://api.github.com/users/blah238/events{/privacy}","received_events_url":"https://api.github.com/users/blah238/received_events","type":"User","site_admin":false},"created_at":"2015-06-29T21:17:35Z","updated_at":"2015-06-29T21:17:35Z","body":"[Added transaction support](https://github.com/blah238/bookshelf-manager/commit/fef9e99ecfd1a0a12b90c989c8917b71539eb06e) (yippee!) -- I think this was sorely needed since a lot can go wrong during one of those complex nested saves, and rolling back on error is the only surefire way to ensure data consistency. Note this is completely optional."}}