{"action":"closed","number":1769,"pull_request":{"url":"https://api.github.com/repos/mitchellh/packer/pulls/1769","id":26126249,"html_url":"https://github.com/mitchellh/packer/pull/1769","diff_url":"https://github.com/mitchellh/packer/pull/1769.diff","patch_url":"https://github.com/mitchellh/packer/pull/1769.patch","issue_url":"https://api.github.com/repos/mitchellh/packer/issues/1769","number":1769,"state":"closed","locked":false,"title":"Address go vet reports","user":{"login":"ceh","id":248952,"avatar_url":"https://avatars.githubusercontent.com/u/248952?v=3","gravatar_id":"","url":"https://api.github.com/users/ceh","html_url":"https://github.com/ceh","followers_url":"https://api.github.com/users/ceh/followers","following_url":"https://api.github.com/users/ceh/following{/other_user}","gists_url":"https://api.github.com/users/ceh/gists{/gist_id}","starred_url":"https://api.github.com/users/ceh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceh/subscriptions","organizations_url":"https://api.github.com/users/ceh/orgs","repos_url":"https://api.github.com/users/ceh/repos","events_url":"https://api.github.com/users/ceh/events{/privacy}","received_events_url":"https://api.github.com/users/ceh/received_events","type":"User","site_admin":false},"body":"This PR adds a vet target to the Makefile, just like for [Terraform](https://github.com/hashicorp/terraform/pull/828) and [Consul](https://github.com/hashicorp/consul/pull/614), and fixes the following vet reports:\r\n\r\n```\r\nbuilder/amazon/common/step_ami_region_copy.go:81: arg target for printf verb %s of wrong type: github.com/mitchellh/goamz/aws.Region\r\nbuilder/amazon/common/step_ami_region_copy.go:93: arg target for printf verb %s of wrong type: github.com/mitchellh/goamz/aws.Region\r\n\r\nbuilder/amazon/ebs/step_create_ami.go:90: arg resp.Return for printf verb %s of wrong type: bool\r\n\r\nbuilder/digitalocean/builder_test.go:267: arg b.config.SSHUsername for printf verb %d of wrong type: string\r\nbuilder/digitalocean/builder_test.go:300: arg b.config.RawSSHTimeout for printf verb %d of wrong type: string\r\nbuilder/digitalocean/builder_test.go:341: arg b.config.RawStateTimeout for printf verb %d of wrong type: string\r\nbuilder/digitalocean/builder_test.go:382: arg b.config.PrivateNetworking for printf verb %s of wrong type: bool\r\nbuilder/digitalocean/builder_test.go:397: arg b.config.PrivateNetworking for printf verb %s of wrong type: bool\r\n\r\nbuilder/googlecompute/step_create_instance_test.go:42: possible formatting directive in Fatal call\r\nbuilder/googlecompute/step_teardown_instance_test.go:29: possible formatting directive in Fatal call\r\nbuilder/googlecompute/step_teardown_instance_test.go:39: possible formatting directive in Fatal call\r\n\r\nbuilder/openstack/artifact.go:44: arg a.ImageId for printf verb %d of wrong type: string\r\nbuilder/openstack/step_wait_for_rackconnect.go:24: arg server for printf verb %s of wrong type: *github.com/mitchellh/gophercloud-fork-40444fb.Server\r\n\r\nbuilder/parallels/iso/builder_test.go:78: arg b.config.DiskSize for printf verb %s of wrong type: uint\r\n\r\nbuilder/qemu/builder_test.go:163: arg b.config.DiskSize for printf verb %s of wrong type: uint\r\n\r\nbuilder/virtualbox/iso/builder_test.go:86: arg b.config.DiskSize for printf verb %s of wrong type: uint\r\n\r\nbuilder/vmware/common/step_shutdown_test.go:130: missing argument for Fatalf(\"%s\"): format reads arg 1, have only 0 args\r\n\r\nbuilder/vmware/iso/builder_test.go:178: arg b.config.DiskSize for printf verb %s of wrong type: uint\r\n\r\ncommon/step_create_floppy_test.go:79: possible formatting directive in Fatal call\r\ncommon/step_create_floppy_test.go:89: possible formatting directive in Fatal call\r\ncommon/step_create_floppy_test.go:180: possible formatting directive in Fatal call\r\ncommon/step_create_floppy_test.go:190: possible formatting directive in Fatal call\r\n\r\ncommunicator/ssh/communicator_test.go:88: range variable newChannel captured by func literal\r\n\r\npacker/template_test.go:496: possible formatting directive in Fatal call\r\npacker/template_test.go:528: possible formatting directive in Fatal call\r\n\r\npost-processor/vagrant/post-processor_test.go:135: possible formatting directive in Fatal call\r\n\r\npost-processor/vagrant-cloud/client.go:81: arg resp for printf verb %s of wrong type: *net/http.Response\r\npost-processor/vagrant-cloud/client.go:99: arg resp for printf verb %s of wrong type: *net/http.Response\r\npost-processor/vagrant-cloud/client.go:131: arg resp for printf verb %s of wrong type: *net/http.Response\r\npost-processor/vagrant-cloud/client.go:156: arg resp for printf verb %s of wrong type: *net/http.Response\r\npost-processor/vagrant-cloud/client.go:175: arg resp for printf verb %s of wrong type: *net/http.Response\r\n\r\nprovisioner/puppet-masterless/provisioner.go:196: missing argument for Errorf(\"%d\"): format reads arg 1, have only 0 args\r\n\r\nprovisioner/salt-masterless/provisioner.go:119: arg cmd for printf verb %s of wrong type: *github.com/mitchellh/packer/packer.RemoteCmd\r\nprovisioner/salt-masterless/provisioner.go:121: arg err for printf verb %d of wrong type: error\r\nprovisioner/salt-masterless/provisioner.go:142: arg err for printf verb %d of wrong type: error\r\nprovisioner/salt-masterless/provisioner.go:157: arg err for printf verb %d of wrong type: error\r\nprovisioner/salt-masterless/provisioner.go:172: arg err for printf verb %d of wrong type: error\r\nprovisioner/salt-masterless/provisioner.go:216: arg err for printf verb %d of wrong type: error\r\n```","created_at":"2014-12-16T06:49:44Z","updated_at":"2015-02-25T05:12:51Z","closed_at":"2015-02-25T05:12:51Z","merged_at":"2015-02-25T05:12:51Z","merge_commit_sha":"1d0dd1c202030621752ab8a554efb11f9bef894f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mitchellh/packer/pulls/1769/commits","review_comments_url":"https://api.github.com/repos/mitchellh/packer/pulls/1769/comments","review_comment_url":"https://api.github.com/repos/mitchellh/packer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mitchellh/packer/issues/1769/comments","statuses_url":"https://api.github.com/repos/mitchellh/packer/statuses/ffd570fe3c6fe4dab412a7384f18f94025734c52","head":{"label":"ceh:vet-fixes","ref":"vet-fixes","sha":"ffd570fe3c6fe4dab412a7384f18f94025734c52","user":{"login":"ceh","id":248952,"avatar_url":"https://avatars.githubusercontent.com/u/248952?v=3","gravatar_id":"","url":"https://api.github.com/users/ceh","html_url":"https://github.com/ceh","followers_url":"https://api.github.com/users/ceh/followers","following_url":"https://api.github.com/users/ceh/following{/other_user}","gists_url":"https://api.github.com/users/ceh/gists{/gist_id}","starred_url":"https://api.github.com/users/ceh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceh/subscriptions","organizations_url":"https://api.github.com/users/ceh/orgs","repos_url":"https://api.github.com/users/ceh/repos","events_url":"https://api.github.com/users/ceh/events{/privacy}","received_events_url":"https://api.github.com/users/ceh/received_events","type":"User","site_admin":false},"repo":{"id":27098787,"name":"packer","full_name":"ceh/packer","owner":{"login":"ceh","id":248952,"avatar_url":"https://avatars.githubusercontent.com/u/248952?v=3","gravatar_id":"","url":"https://api.github.com/users/ceh","html_url":"https://github.com/ceh","followers_url":"https://api.github.com/users/ceh/followers","following_url":"https://api.github.com/users/ceh/following{/other_user}","gists_url":"https://api.github.com/users/ceh/gists{/gist_id}","starred_url":"https://api.github.com/users/ceh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceh/subscriptions","organizations_url":"https://api.github.com/users/ceh/orgs","repos_url":"https://api.github.com/users/ceh/repos","events_url":"https://api.github.com/users/ceh/events{/privacy}","received_events_url":"https://api.github.com/users/ceh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ceh/packer","description":"Packer is a tool for creating identical machine images for multiple platforms from a single source configuration.","fork":true,"url":"https://api.github.com/repos/ceh/packer","forks_url":"https://api.github.com/repos/ceh/packer/forks","keys_url":"https://api.github.com/repos/ceh/packer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceh/packer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceh/packer/teams","hooks_url":"https://api.github.com/repos/ceh/packer/hooks","issue_events_url":"https://api.github.com/repos/ceh/packer/issues/events{/number}","events_url":"https://api.github.com/repos/ceh/packer/events","assignees_url":"https://api.github.com/repos/ceh/packer/assignees{/user}","branches_url":"https://api.github.com/repos/ceh/packer/branches{/branch}","tags_url":"https://api.github.com/repos/ceh/packer/tags","blobs_url":"https://api.github.com/repos/ceh/packer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceh/packer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceh/packer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceh/packer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceh/packer/statuses/{sha}","languages_url":"https://api.github.com/repos/ceh/packer/languages","stargazers_url":"https://api.github.com/repos/ceh/packer/stargazers","contributors_url":"https://api.github.com/repos/ceh/packer/contributors","subscribers_url":"https://api.github.com/repos/ceh/packer/subscribers","subscription_url":"https://api.github.com/repos/ceh/packer/subscription","commits_url":"https://api.github.com/repos/ceh/packer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceh/packer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceh/packer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceh/packer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceh/packer/contents/{+path}","compare_url":"https://api.github.com/repos/ceh/packer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceh/packer/merges","archive_url":"https://api.github.com/repos/ceh/packer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceh/packer/downloads","issues_url":"https://api.github.com/repos/ceh/packer/issues{/number}","pulls_url":"https://api.github.com/repos/ceh/packer/pulls{/number}","milestones_url":"https://api.github.com/repos/ceh/packer/milestones{/number}","notifications_url":"https://api.github.com/repos/ceh/packer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceh/packer/labels{/name}","releases_url":"https://api.github.com/repos/ceh/packer/releases{/id}","created_at":"2014-11-24T22:47:14Z","updated_at":"2015-02-21T08:27:21Z","pushed_at":"2015-02-25T04:43:38Z","git_url":"git://github.com/ceh/packer.git","ssh_url":"git@github.com:ceh/packer.git","clone_url":"https://github.com/ceh/packer.git","svn_url":"https://github.com/ceh/packer","homepage":"http://www.packer.io","size":7996,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mitchellh:master","ref":"master","sha":"8c36684e980bddc694bb626d0225391fb74bf0eb","user":{"login":"mitchellh","id":1299,"avatar_url":"https://avatars.githubusercontent.com/u/1299?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellh","html_url":"https://github.com/mitchellh","followers_url":"https://api.github.com/users/mitchellh/followers","following_url":"https://api.github.com/users/mitchellh/following{/other_user}","gists_url":"https://api.github.com/users/mitchellh/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellh/subscriptions","organizations_url":"https://api.github.com/users/mitchellh/orgs","repos_url":"https://api.github.com/users/mitchellh/repos","events_url":"https://api.github.com/users/mitchellh/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellh/received_events","type":"User","site_admin":false},"repo":{"id":8966356,"name":"packer","full_name":"mitchellh/packer","owner":{"login":"mitchellh","id":1299,"avatar_url":"https://avatars.githubusercontent.com/u/1299?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellh","html_url":"https://github.com/mitchellh","followers_url":"https://api.github.com/users/mitchellh/followers","following_url":"https://api.github.com/users/mitchellh/following{/other_user}","gists_url":"https://api.github.com/users/mitchellh/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellh/subscriptions","organizations_url":"https://api.github.com/users/mitchellh/orgs","repos_url":"https://api.github.com/users/mitchellh/repos","events_url":"https://api.github.com/users/mitchellh/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitchellh/packer","description":"Packer is a tool for creating identical machine images for multiple platforms from a single source configuration.","fork":false,"url":"https://api.github.com/repos/mitchellh/packer","forks_url":"https://api.github.com/repos/mitchellh/packer/forks","keys_url":"https://api.github.com/repos/mitchellh/packer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitchellh/packer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitchellh/packer/teams","hooks_url":"https://api.github.com/repos/mitchellh/packer/hooks","issue_events_url":"https://api.github.com/repos/mitchellh/packer/issues/events{/number}","events_url":"https://api.github.com/repos/mitchellh/packer/events","assignees_url":"https://api.github.com/repos/mitchellh/packer/assignees{/user}","branches_url":"https://api.github.com/repos/mitchellh/packer/branches{/branch}","tags_url":"https://api.github.com/repos/mitchellh/packer/tags","blobs_url":"https://api.github.com/repos/mitchellh/packer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitchellh/packer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitchellh/packer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitchellh/packer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitchellh/packer/statuses/{sha}","languages_url":"https://api.github.com/repos/mitchellh/packer/languages","stargazers_url":"https://api.github.com/repos/mitchellh/packer/stargazers","contributors_url":"https://api.github.com/repos/mitchellh/packer/contributors","subscribers_url":"https://api.github.com/repos/mitchellh/packer/subscribers","subscription_url":"https://api.github.com/repos/mitchellh/packer/subscription","commits_url":"https://api.github.com/repos/mitchellh/packer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitchellh/packer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitchellh/packer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitchellh/packer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitchellh/packer/contents/{+path}","compare_url":"https://api.github.com/repos/mitchellh/packer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitchellh/packer/merges","archive_url":"https://api.github.com/repos/mitchellh/packer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitchellh/packer/downloads","issues_url":"https://api.github.com/repos/mitchellh/packer/issues{/number}","pulls_url":"https://api.github.com/repos/mitchellh/packer/pulls{/number}","milestones_url":"https://api.github.com/repos/mitchellh/packer/milestones{/number}","notifications_url":"https://api.github.com/repos/mitchellh/packer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitchellh/packer/labels{/name}","releases_url":"https://api.github.com/repos/mitchellh/packer/releases{/id}","created_at":"2013-03-23T05:43:03Z","updated_at":"2015-02-25T01:42:14Z","pushed_at":"2015-02-25T05:12:51Z","git_url":"git://github.com/mitchellh/packer.git","ssh_url":"git@github.com:mitchellh/packer.git","clone_url":"https://github.com/mitchellh/packer.git","svn_url":"https://github.com/mitchellh/packer","homepage":"http://www.packer.io","size":19739,"stargazers_count":3637,"watchers_count":3637,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":698,"mirror_url":null,"open_issues_count":243,"forks":698,"open_issues":243,"watchers":3637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mitchellh/packer/pulls/1769"},"html":{"href":"https://github.com/mitchellh/packer/pull/1769"},"issue":{"href":"https://api.github.com/repos/mitchellh/packer/issues/1769"},"comments":{"href":"https://api.github.com/repos/mitchellh/packer/issues/1769/comments"},"review_comments":{"href":"https://api.github.com/repos/mitchellh/packer/pulls/1769/comments"},"review_comment":{"href":"https://api.github.com/repos/mitchellh/packer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mitchellh/packer/pulls/1769/commits"},"statuses":{"href":"https://api.github.com/repos/mitchellh/packer/statuses/ffd570fe3c6fe4dab412a7384f18f94025734c52"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sethvargo","id":408570,"avatar_url":"https://avatars.githubusercontent.com/u/408570?v=3","gravatar_id":"","url":"https://api.github.com/users/sethvargo","html_url":"https://github.com/sethvargo","followers_url":"https://api.github.com/users/sethvargo/followers","following_url":"https://api.github.com/users/sethvargo/following{/other_user}","gists_url":"https://api.github.com/users/sethvargo/gists{/gist_id}","starred_url":"https://api.github.com/users/sethvargo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethvargo/subscriptions","organizations_url":"https://api.github.com/users/sethvargo/orgs","repos_url":"https://api.github.com/users/sethvargo/repos","events_url":"https://api.github.com/users/sethvargo/events{/privacy}","received_events_url":"https://api.github.com/users/sethvargo/received_events","type":"User","site_admin":false},"comments":3,"review_comments":1,"commits":18,"additions":54,"deletions":42,"changed_files":20}}