{"action":"closed","number":4228,"pull_request":{"url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/4228","id":34405725,"html_url":"https://github.com/borisyankov/DefinitelyTyped/pull/4228","diff_url":"https://github.com/borisyankov/DefinitelyTyped/pull/4228.diff","patch_url":"https://github.com/borisyankov/DefinitelyTyped/pull/4228.patch","issue_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/4228","number":4228,"state":"closed","locked":false,"title":"socket.io: Add \"in\" method to SocketIO.Namespace, \"handshake\" property to SocketIO.Socket","user":{"login":"elisee","id":446986,"avatar_url":"https://avatars.githubusercontent.com/u/446986?v=3","gravatar_id":"","url":"https://api.github.com/users/elisee","html_url":"https://github.com/elisee","followers_url":"https://api.github.com/users/elisee/followers","following_url":"https://api.github.com/users/elisee/following{/other_user}","gists_url":"https://api.github.com/users/elisee/gists{/gist_id}","starred_url":"https://api.github.com/users/elisee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elisee/subscriptions","organizations_url":"https://api.github.com/users/elisee/orgs","repos_url":"https://api.github.com/users/elisee/repos","events_url":"https://api.github.com/users/elisee/events{/privacy}","received_events_url":"https://api.github.com/users/elisee/received_events","type":"User","site_admin":false},"body":"This should be valid:\r\n\r\n```\r\nimport * as sio from \"socket.io\";\r\nlet io = sio(\"\");\r\nlet nsp = io.of(\"myNamespace\");\r\nnsp.in(\"someRoom\").emit(\"...\");\r\n```\r\n\r\nBut the current definition is lacking the `in` method on `SocketIO.Namespace` so I added it.\r\n\r\nAlso added [`SocketIO.Socket.handshake`](https://github.com/Automattic/socket.io/blob/3f72dd3322bcefff07b5976ab817766e421d237b/lib/socket.js#L107) which is [not currently documented on the website](https://github.com/Automattic/socket.io-website/issues/21).","created_at":"2015-04-29T21:02:29Z","updated_at":"2015-05-01T04:09:39Z","closed_at":"2015-05-01T04:09:39Z","merged_at":"2015-05-01T04:09:39Z","merge_commit_sha":"5a5bc4d6e487477a4ef14ebf70ed4bf1f5515296","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/4228/commits","review_comments_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/4228/comments","review_comment_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/4228/comments","statuses_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/statuses/c3a1f48983487c1d1bb6ddb35973931e7bb320af","head":{"label":"elisee:patch-2","ref":"patch-2","sha":"c3a1f48983487c1d1bb6ddb35973931e7bb320af","user":{"login":"elisee","id":446986,"avatar_url":"https://avatars.githubusercontent.com/u/446986?v=3","gravatar_id":"","url":"https://api.github.com/users/elisee","html_url":"https://github.com/elisee","followers_url":"https://api.github.com/users/elisee/followers","following_url":"https://api.github.com/users/elisee/following{/other_user}","gists_url":"https://api.github.com/users/elisee/gists{/gist_id}","starred_url":"https://api.github.com/users/elisee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elisee/subscriptions","organizations_url":"https://api.github.com/users/elisee/orgs","repos_url":"https://api.github.com/users/elisee/repos","events_url":"https://api.github.com/users/elisee/events{/privacy}","received_events_url":"https://api.github.com/users/elisee/received_events","type":"User","site_admin":false},"repo":{"id":32035518,"name":"DefinitelyTyped","full_name":"elisee/DefinitelyTyped","owner":{"login":"elisee","id":446986,"avatar_url":"https://avatars.githubusercontent.com/u/446986?v=3","gravatar_id":"","url":"https://api.github.com/users/elisee","html_url":"https://github.com/elisee","followers_url":"https://api.github.com/users/elisee/followers","following_url":"https://api.github.com/users/elisee/following{/other_user}","gists_url":"https://api.github.com/users/elisee/gists{/gist_id}","starred_url":"https://api.github.com/users/elisee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elisee/subscriptions","organizations_url":"https://api.github.com/users/elisee/orgs","repos_url":"https://api.github.com/users/elisee/repos","events_url":"https://api.github.com/users/elisee/events{/privacy}","received_events_url":"https://api.github.com/users/elisee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elisee/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/elisee/DefinitelyTyped","forks_url":"https://api.github.com/repos/elisee/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/elisee/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elisee/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elisee/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/elisee/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/elisee/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/elisee/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/elisee/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/elisee/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/elisee/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/elisee/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elisee/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elisee/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/elisee/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elisee/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/elisee/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/elisee/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/elisee/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/elisee/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/elisee/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/elisee/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/elisee/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/elisee/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/elisee/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/elisee/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/elisee/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elisee/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/elisee/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elisee/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/elisee/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/elisee/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/elisee/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/elisee/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elisee/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/elisee/DefinitelyTyped/releases{/id}","created_at":"2015-03-11T18:57:51Z","updated_at":"2015-04-30T02:33:50Z","pushed_at":"2015-04-30T04:12:43Z","git_url":"git://github.com/elisee/DefinitelyTyped.git","ssh_url":"git@github.com:elisee/DefinitelyTyped.git","clone_url":"https://github.com/elisee/DefinitelyTyped.git","svn_url":"https://github.com/elisee/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":59019,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"borisyankov:master","ref":"master","sha":"a61199a4684d70334795302f09fb2a6b8ca016db","user":{"login":"borisyankov","id":867242,"avatar_url":"https://avatars.githubusercontent.com/u/867242?v=3","gravatar_id":"","url":"https://api.github.com/users/borisyankov","html_url":"https://github.com/borisyankov","followers_url":"https://api.github.com/users/borisyankov/followers","following_url":"https://api.github.com/users/borisyankov/following{/other_user}","gists_url":"https://api.github.com/users/borisyankov/gists{/gist_id}","starred_url":"https://api.github.com/users/borisyankov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisyankov/subscriptions","organizations_url":"https://api.github.com/users/borisyankov/orgs","repos_url":"https://api.github.com/users/borisyankov/repos","events_url":"https://api.github.com/users/borisyankov/events{/privacy}","received_events_url":"https://api.github.com/users/borisyankov/received_events","type":"User","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"borisyankov/DefinitelyTyped","owner":{"login":"borisyankov","id":867242,"avatar_url":"https://avatars.githubusercontent.com/u/867242?v=3","gravatar_id":"","url":"https://api.github.com/users/borisyankov","html_url":"https://github.com/borisyankov","followers_url":"https://api.github.com/users/borisyankov/followers","following_url":"https://api.github.com/users/borisyankov/following{/other_user}","gists_url":"https://api.github.com/users/borisyankov/gists{/gist_id}","starred_url":"https://api.github.com/users/borisyankov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisyankov/subscriptions","organizations_url":"https://api.github.com/users/borisyankov/orgs","repos_url":"https://api.github.com/users/borisyankov/repos","events_url":"https://api.github.com/users/borisyankov/events{/privacy}","received_events_url":"https://api.github.com/users/borisyankov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/borisyankov/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/borisyankov/DefinitelyTyped","forks_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/releases{/id}","created_at":"2012-10-05T16:39:45Z","updated_at":"2015-05-01T04:07:46Z","pushed_at":"2015-05-01T04:09:39Z","git_url":"git://github.com/borisyankov/DefinitelyTyped.git","ssh_url":"git@github.com:borisyankov/DefinitelyTyped.git","clone_url":"https://github.com/borisyankov/DefinitelyTyped.git","svn_url":"https://github.com/borisyankov/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":93591,"stargazers_count":3770,"watchers_count":3770,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2329,"mirror_url":null,"open_issues_count":507,"forks":2329,"open_issues":507,"watchers":3770,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/4228"},"html":{"href":"https://github.com/borisyankov/DefinitelyTyped/pull/4228"},"issue":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/4228"},"comments":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/4228/comments"},"review_comments":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/4228/comments"},"review_comment":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/4228/commits"},"statuses":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/statuses/c3a1f48983487c1d1bb6ddb35973931e7bb320af"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"vvakame","id":125332,"avatar_url":"https://avatars.githubusercontent.com/u/125332?v=3","gravatar_id":"","url":"https://api.github.com/users/vvakame","html_url":"https://github.com/vvakame","followers_url":"https://api.github.com/users/vvakame/followers","following_url":"https://api.github.com/users/vvakame/following{/other_user}","gists_url":"https://api.github.com/users/vvakame/gists{/gist_id}","starred_url":"https://api.github.com/users/vvakame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvakame/subscriptions","organizations_url":"https://api.github.com/users/vvakame/orgs","repos_url":"https://api.github.com/users/vvakame/repos","events_url":"https://api.github.com/users/vvakame/events{/privacy}","received_events_url":"https://api.github.com/users/vvakame/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":12,"deletions":0,"changed_files":1}}