{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/35938486","id":35938486,"diff_hunk":"@@ -0,0 +1,156 @@\n+/*\n+Copyright 2015 The Kubernetes Authors All rights reserved.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+// openid implements the authenticator.Token interface using the OpenID protocol.\n+package openid\n+\n+import (\n+\t\"crypto/tls\"\n+\t\"crypto/x509\"\n+\t\"fmt\"\n+\t\"net\"\n+\t\"net/http\"\n+\t\"net/url\"\n+\t\"time\"\n+\n+\t\"github.com/GoogleCloudPlatform/kubernetes/pkg/auth/user\"\n+\t\"github.com/GoogleCloudPlatform/kubernetes/pkg/util\"\n+\t\"github.com/coreos/go-oidc/jose\"\n+\t\"github.com/coreos/go-oidc/oidc\"\n+\t\"github.com/golang/glog\"\n+)\n+\n+var (\n+\tmaxRetries   = 5\n+\tretryBackoff = time.Second * 3\n+)\n+\n+var errNoKeyEndpoint = fmt.Errorf(\"OpenID provider must provide 'jwks_uri' for public key discovery\")\n+\n+type OpenIDAuthenticator struct {\n+\tclient *oidc.Client\n+}\n+\n+// NewOpenID creates a new OpenID client with the given clientID and discovery URL.","path":"plugin/pkg/auth/authenticator/token/openid/openid.go","position":47,"original_position":47,"commit_id":"712c275bb676db063b08de9fb3788babc4b0d333","original_commit_id":"712c275bb676db063b08de9fb3788babc4b0d333","user":{"login":"jboeuf","id":6262765,"avatar_url":"https://avatars.githubusercontent.com/u/6262765?v=3","gravatar_id":"","url":"https://api.github.com/users/jboeuf","html_url":"https://github.com/jboeuf","followers_url":"https://api.github.com/users/jboeuf/followers","following_url":"https://api.github.com/users/jboeuf/following{/other_user}","gists_url":"https://api.github.com/users/jboeuf/gists{/gist_id}","starred_url":"https://api.github.com/users/jboeuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboeuf/subscriptions","organizations_url":"https://api.github.com/users/jboeuf/orgs","repos_url":"https://api.github.com/users/jboeuf/repos","events_url":"https://api.github.com/users/jboeuf/events{/privacy}","received_events_url":"https://api.github.com/users/jboeuf/received_events","type":"User","site_admin":false},"body":"Thanks. So do you plan to change it or not? After the exchange below regarding http vs https, I think that it is actually important.","created_at":"2015-07-31T01:00:49Z","updated_at":"2015-07-31T01:00:49Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10957#discussion_r35938486","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10957","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/35938486"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10957#discussion_r35938486"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10957"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10957","id":39533117,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10957","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10957.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10957.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/10957","number":10957,"state":"open","locked":false,"title":"plugin/pkg/auth: add openid token authenticator","user":{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"body":"This PR implements the token authenticator interface for the OpenID protocols. It also adds two flags (\"--openid-endpoint\", \"--openid-client-id\") for apiserver\r\nto enable openid authentication.\r\n\r\nIt mainly uses [go-oidc packages](https://github.com/coreos/go-oidc). It uses the [oidc client](http://godoc.org/github.com/coreos/go-oidc/oidc#Client) to sync and cache the pub keys automatically. Also it will verify the token using the pub keys.\r\n\r\n/cc @erictune @liggitt @smarterclayton","created_at":"2015-07-08T23:04:59Z","updated_at":"2015-07-31T01:00:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"463db82e6bedeaabbf854d93aafb386a6b10d021","assignee":{"login":"erictune","id":8105590,"avatar_url":"https://avatars.githubusercontent.com/u/8105590?v=3","gravatar_id":"","url":"https://api.github.com/users/erictune","html_url":"https://github.com/erictune","followers_url":"https://api.github.com/users/erictune/followers","following_url":"https://api.github.com/users/erictune/following{/other_user}","gists_url":"https://api.github.com/users/erictune/gists{/gist_id}","starred_url":"https://api.github.com/users/erictune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erictune/subscriptions","organizations_url":"https://api.github.com/users/erictune/orgs","repos_url":"https://api.github.com/users/erictune/repos","events_url":"https://api.github.com/users/erictune/events{/privacy}","received_events_url":"https://api.github.com/users/erictune/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10957/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10957/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/10957/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/712c275bb676db063b08de9fb3788babc4b0d333","head":{"label":"yifan-gu:oidc","ref":"oidc","sha":"712c275bb676db063b08de9fb3788babc4b0d333","user":{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"repo":{"id":21830645,"name":"kubernetes","full_name":"yifan-gu/kubernetes","owner":{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yifan-gu/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/yifan-gu/kubernetes","forks_url":"https://api.github.com/repos/yifan-gu/kubernetes/forks","keys_url":"https://api.github.com/repos/yifan-gu/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yifan-gu/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yifan-gu/kubernetes/teams","hooks_url":"https://api.github.com/repos/yifan-gu/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/yifan-gu/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/yifan-gu/kubernetes/events","assignees_url":"https://api.github.com/repos/yifan-gu/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/yifan-gu/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/yifan-gu/kubernetes/tags","blobs_url":"https://api.github.com/repos/yifan-gu/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yifan-gu/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yifan-gu/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/yifan-gu/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yifan-gu/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/yifan-gu/kubernetes/languages","stargazers_url":"https://api.github.com/repos/yifan-gu/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/yifan-gu/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/yifan-gu/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/yifan-gu/kubernetes/subscription","commits_url":"https://api.github.com/repos/yifan-gu/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/yifan-gu/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/yifan-gu/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/yifan-gu/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/yifan-gu/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/yifan-gu/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yifan-gu/kubernetes/merges","archive_url":"https://api.github.com/repos/yifan-gu/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yifan-gu/kubernetes/downloads","issues_url":"https://api.github.com/repos/yifan-gu/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/yifan-gu/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/yifan-gu/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/yifan-gu/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yifan-gu/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/yifan-gu/kubernetes/releases{/id}","created_at":"2014-07-14T18:29:14Z","updated_at":"2015-04-03T18:28:44Z","pushed_at":"2015-07-30T01:05:12Z","git_url":"git://github.com/yifan-gu/kubernetes.git","ssh_url":"git@github.com:yifan-gu/kubernetes.git","clone_url":"https://github.com/yifan-gu/kubernetes.git","svn_url":"https://github.com/yifan-gu/kubernetes","homepage":null,"size":95073,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"1367076d2e4e3b4e581923edf0c7bc69c004b70a","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-07-31T00:49:55Z","pushed_at":"2015-07-31T00:56:41Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":334438,"stargazers_count":9466,"watchers_count":9466,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2194,"mirror_url":null,"open_issues_count":1664,"forks":2194,"open_issues":1664,"watchers":9466,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10957"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10957"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/10957"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/10957/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10957/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10957/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/712c275bb676db063b08de9fb3788babc4b0d333"}}}}