{"action":"closed","number":2802,"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/2802","id":36046462,"html_url":"https://github.com/CenterForOpenScience/osf.io/pull/2802","diff_url":"https://github.com/CenterForOpenScience/osf.io/pull/2802.diff","patch_url":"https://github.com/CenterForOpenScience/osf.io/pull/2802.patch","issue_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/2802","number":2802,"state":"closed","locked":false,"title":"[Feature Fix] IE search bar placeholder not visible ","user":{"login":"haoyuchen1992","id":5420789,"avatar_url":"https://avatars.githubusercontent.com/u/5420789?v=3","gravatar_id":"","url":"https://api.github.com/users/haoyuchen1992","html_url":"https://github.com/haoyuchen1992","followers_url":"https://api.github.com/users/haoyuchen1992/followers","following_url":"https://api.github.com/users/haoyuchen1992/following{/other_user}","gists_url":"https://api.github.com/users/haoyuchen1992/gists{/gist_id}","starred_url":"https://api.github.com/users/haoyuchen1992/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haoyuchen1992/subscriptions","organizations_url":"https://api.github.com/users/haoyuchen1992/orgs","repos_url":"https://api.github.com/users/haoyuchen1992/repos","events_url":"https://api.github.com/users/haoyuchen1992/events{/privacy}","received_events_url":"https://api.github.com/users/haoyuchen1992/received_events","type":"User","site_admin":false},"body":"**Purpose**\r\nCurrently, the search bar place holder in IE can't not be shown. Because the default setting for IE is that when input is focused, then it will clear all the place holder. Resolves the #2248 .\r\n\r\n**Changes**\r\nI consulted other mainstream websites and found most of them had the same problem. But dropbox's sign-in page doesn't have this issue because it doesn't use placeholder from HTML5. Instead, it uses label tag to achieve the same goal.\r\n\r\nSo borrowing the same idea, I apply label tag and add the corresponding javascript and css code. \r\n1. Add search-label-placeholder class into site.css\r\n2. Add label tag at the end of search input tag and assign unique ids to search input and label tags.\r\n3. Add control javascript at the end of search_bar.mako\r\n\r\n**Side Effects**\r\nThe same placeholder problem also happens in other pages. But since it is a javascript-based solution, Caner suggested me to only apply this solution to the search bar. \r\n\r\nAnother question is that I put my javascript code in the mako file. Because it need to be applied every time search bar is loaded. But I am not sure weather this is the standardized  way to do it.\r\n\r\n","created_at":"2015-05-22T16:18:27Z","updated_at":"2015-06-01T03:34:42Z","closed_at":"2015-06-01T03:34:42Z","merged_at":"2015-06-01T03:34:42Z","merge_commit_sha":"5b937a80615c53b3756f0a150bec1bb199c2c7bf","assignee":null,"milestone":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/milestones/35","html_url":"https://github.com/CenterForOpenScience/osf.io/milestones/0.38.0","labels_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/milestones/35/labels","id":1134921,"number":35,"title":"0.38.0","description":"","creator":{"login":"sloria","id":2379650,"avatar_url":"https://avatars.githubusercontent.com/u/2379650?v=3","gravatar_id":"","url":"https://api.github.com/users/sloria","html_url":"https://github.com/sloria","followers_url":"https://api.github.com/users/sloria/followers","following_url":"https://api.github.com/users/sloria/following{/other_user}","gists_url":"https://api.github.com/users/sloria/gists{/gist_id}","starred_url":"https://api.github.com/users/sloria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloria/subscriptions","organizations_url":"https://api.github.com/users/sloria/orgs","repos_url":"https://api.github.com/users/sloria/repos","events_url":"https://api.github.com/users/sloria/events{/privacy}","received_events_url":"https://api.github.com/users/sloria/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":14,"state":"open","created_at":"2015-05-26T23:26:37Z","updated_at":"2015-06-01T03:34:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/2802/commits","review_comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/2802/comments","review_comment_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/2802/comments","statuses_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/bf5d437002f4bd8a361101ad18f7fcad23804d0d","head":{"label":"haoyuchen1992:Fix-IE-SearchBarPlaceHolder-2248","ref":"Fix-IE-SearchBarPlaceHolder-2248","sha":"bf5d437002f4bd8a361101ad18f7fcad23804d0d","user":{"login":"haoyuchen1992","id":5420789,"avatar_url":"https://avatars.githubusercontent.com/u/5420789?v=3","gravatar_id":"","url":"https://api.github.com/users/haoyuchen1992","html_url":"https://github.com/haoyuchen1992","followers_url":"https://api.github.com/users/haoyuchen1992/followers","following_url":"https://api.github.com/users/haoyuchen1992/following{/other_user}","gists_url":"https://api.github.com/users/haoyuchen1992/gists{/gist_id}","starred_url":"https://api.github.com/users/haoyuchen1992/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haoyuchen1992/subscriptions","organizations_url":"https://api.github.com/users/haoyuchen1992/orgs","repos_url":"https://api.github.com/users/haoyuchen1992/repos","events_url":"https://api.github.com/users/haoyuchen1992/events{/privacy}","received_events_url":"https://api.github.com/users/haoyuchen1992/received_events","type":"User","site_admin":false},"repo":{"id":35887412,"name":"osf.io","full_name":"haoyuchen1992/osf.io","owner":{"login":"haoyuchen1992","id":5420789,"avatar_url":"https://avatars.githubusercontent.com/u/5420789?v=3","gravatar_id":"","url":"https://api.github.com/users/haoyuchen1992","html_url":"https://github.com/haoyuchen1992","followers_url":"https://api.github.com/users/haoyuchen1992/followers","following_url":"https://api.github.com/users/haoyuchen1992/following{/other_user}","gists_url":"https://api.github.com/users/haoyuchen1992/gists{/gist_id}","starred_url":"https://api.github.com/users/haoyuchen1992/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haoyuchen1992/subscriptions","organizations_url":"https://api.github.com/users/haoyuchen1992/orgs","repos_url":"https://api.github.com/users/haoyuchen1992/repos","events_url":"https://api.github.com/users/haoyuchen1992/events{/privacy}","received_events_url":"https://api.github.com/users/haoyuchen1992/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/haoyuchen1992/osf.io","description":"Facilitating Open Science","fork":true,"url":"https://api.github.com/repos/haoyuchen1992/osf.io","forks_url":"https://api.github.com/repos/haoyuchen1992/osf.io/forks","keys_url":"https://api.github.com/repos/haoyuchen1992/osf.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haoyuchen1992/osf.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haoyuchen1992/osf.io/teams","hooks_url":"https://api.github.com/repos/haoyuchen1992/osf.io/hooks","issue_events_url":"https://api.github.com/repos/haoyuchen1992/osf.io/issues/events{/number}","events_url":"https://api.github.com/repos/haoyuchen1992/osf.io/events","assignees_url":"https://api.github.com/repos/haoyuchen1992/osf.io/assignees{/user}","branches_url":"https://api.github.com/repos/haoyuchen1992/osf.io/branches{/branch}","tags_url":"https://api.github.com/repos/haoyuchen1992/osf.io/tags","blobs_url":"https://api.github.com/repos/haoyuchen1992/osf.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haoyuchen1992/osf.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haoyuchen1992/osf.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/haoyuchen1992/osf.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haoyuchen1992/osf.io/statuses/{sha}","languages_url":"https://api.github.com/repos/haoyuchen1992/osf.io/languages","stargazers_url":"https://api.github.com/repos/haoyuchen1992/osf.io/stargazers","contributors_url":"https://api.github.com/repos/haoyuchen1992/osf.io/contributors","subscribers_url":"https://api.github.com/repos/haoyuchen1992/osf.io/subscribers","subscription_url":"https://api.github.com/repos/haoyuchen1992/osf.io/subscription","commits_url":"https://api.github.com/repos/haoyuchen1992/osf.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/haoyuchen1992/osf.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/haoyuchen1992/osf.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/haoyuchen1992/osf.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/haoyuchen1992/osf.io/contents/{+path}","compare_url":"https://api.github.com/repos/haoyuchen1992/osf.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haoyuchen1992/osf.io/merges","archive_url":"https://api.github.com/repos/haoyuchen1992/osf.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haoyuchen1992/osf.io/downloads","issues_url":"https://api.github.com/repos/haoyuchen1992/osf.io/issues{/number}","pulls_url":"https://api.github.com/repos/haoyuchen1992/osf.io/pulls{/number}","milestones_url":"https://api.github.com/repos/haoyuchen1992/osf.io/milestones{/number}","notifications_url":"https://api.github.com/repos/haoyuchen1992/osf.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haoyuchen1992/osf.io/labels{/name}","releases_url":"https://api.github.com/repos/haoyuchen1992/osf.io/releases{/id}","created_at":"2015-05-19T14:29:46Z","updated_at":"2015-05-19T14:29:49Z","pushed_at":"2015-05-29T15:14:57Z","git_url":"git://github.com/haoyuchen1992/osf.io.git","ssh_url":"git@github.com:haoyuchen1992/osf.io.git","clone_url":"https://github.com/haoyuchen1992/osf.io.git","svn_url":"https://github.com/haoyuchen1992/osf.io","homepage":"http://osf.io","size":87795,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CenterForOpenScience:develop","ref":"develop","sha":"fbeaaa273cb7f97cab73aafec39afb4a73a779f2","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":10199599,"name":"osf.io","full_name":"CenterForOpenScience/osf.io","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/osf.io","description":"Facilitating Open Science","fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/osf.io","forks_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/releases{/id}","created_at":"2013-05-21T15:53:37Z","updated_at":"2015-05-26T14:58:41Z","pushed_at":"2015-06-01T03:34:42Z","git_url":"git://github.com/CenterForOpenScience/osf.io.git","ssh_url":"git@github.com:CenterForOpenScience/osf.io.git","clone_url":"https://github.com/CenterForOpenScience/osf.io.git","svn_url":"https://github.com/CenterForOpenScience/osf.io","homepage":"http://osf.io","size":212799,"stargazers_count":106,"watchers_count":106,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"open_issues_count":426,"forks":91,"open_issues":426,"watchers":106,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/2802"},"html":{"href":"https://github.com/CenterForOpenScience/osf.io/pull/2802"},"issue":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/2802"},"comments":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/2802/comments"},"review_comments":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/2802/comments"},"review_comment":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/2802/commits"},"statuses":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/bf5d437002f4bd8a361101ad18f7fcad23804d0d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sloria","id":2379650,"avatar_url":"https://avatars.githubusercontent.com/u/2379650?v=3","gravatar_id":"","url":"https://api.github.com/users/sloria","html_url":"https://github.com/sloria","followers_url":"https://api.github.com/users/sloria/followers","following_url":"https://api.github.com/users/sloria/following{/other_user}","gists_url":"https://api.github.com/users/sloria/gists{/gist_id}","starred_url":"https://api.github.com/users/sloria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloria/subscriptions","organizations_url":"https://api.github.com/users/sloria/orgs","repos_url":"https://api.github.com/users/sloria/repos","events_url":"https://api.github.com/users/sloria/events{/privacy}","received_events_url":"https://api.github.com/users/sloria/received_events","type":"User","site_admin":false},"comments":10,"review_comments":3,"commits":6,"additions":54,"deletions":1,"changed_files":3}}