{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/9974","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/9974/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/9974/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/9974/events","html_url":"https://github.com/edx/edx-platform/pull/9974","id":109098519,"number":9974,"title":"Video player (1 of 2): refreshing the UI","user":{"login":"clrux","id":2112024,"avatar_url":"https://avatars.githubusercontent.com/u/2112024?v=3","gravatar_id":"","url":"https://api.github.com/users/clrux","html_url":"https://github.com/clrux","followers_url":"https://api.github.com/users/clrux/followers","following_url":"https://api.github.com/users/clrux/following{/other_user}","gists_url":"https://api.github.com/users/clrux/gists{/gist_id}","starred_url":"https://api.github.com/users/clrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clrux/subscriptions","organizations_url":"https://api.github.com/users/clrux/orgs","repos_url":"https://api.github.com/users/clrux/repos","events_url":"https://api.github.com/users/clrux/events{/privacy}","received_events_url":"https://api.github.com/users/clrux/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"clrux","id":2112024,"avatar_url":"https://avatars.githubusercontent.com/u/2112024?v=3","gravatar_id":"","url":"https://api.github.com/users/clrux","html_url":"https://github.com/clrux","followers_url":"https://api.github.com/users/clrux/followers","following_url":"https://api.github.com/users/clrux/following{/other_user}","gists_url":"https://api.github.com/users/clrux/gists{/gist_id}","starred_url":"https://api.github.com/users/clrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clrux/subscriptions","organizations_url":"https://api.github.com/users/clrux/orgs","repos_url":"https://api.github.com/users/clrux/repos","events_url":"https://api.github.com/users/clrux/events{/privacy}","received_events_url":"https://api.github.com/users/clrux/received_events","type":"User","site_admin":false},"milestone":null,"comments":28,"created_at":"2015-09-30T14:06:49Z","updated_at":"2015-11-12T21:32:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/9974","html_url":"https://github.com/edx/edx-platform/pull/9974","diff_url":"https://github.com/edx/edx-platform/pull/9974.diff","patch_url":"https://github.com/edx/edx-platform/pull/9974.patch"},"body":"This pull request is one part of two and provides visual and semantic updates to our video player. It is part of [AC-187](https://openedx.atlassian.net/browse/AC-187).\r\n\r\n## Notable changes\r\n\r\n* included a custom [Modernizr](http://modernizr.com) and [A Font Garde](https://github.com/filamentgroup/a-font-garde) for fully accessible icon fonts\r\n* converted the player controls from `a` to `button` for better semantics\r\n* updated the icon font markup to utilize required markup from A Font Garde\r\n* refreshed the overall UI to utilize palettes and practices from our [Pattern Library](http://ux.edx.org)\r\n* added a new grouped control, added a language `button` (which now controls the language menu, if available), and moved the transcripts control into it\r\n* provided keyboard behaviors for the newly added language menu control\r\n* many of the Sass changes are RTL-ing, removing specific elements, and other various cleanup\r\n\r\n### Implications on tests\r\n\r\nMany tests were looking for specific ARIA roles on the `a` controls, such as `role=\"button\"` and `title`. Since I've converted these \"buttons\" to real buttons, both of these attributes are invalid and have been removed.\r\n\r\n## Browsers\r\n\r\nThis has been tested in the following browsers:\r\n\r\n| Platform | Browser | Version | Passed |\r\n|----------|---------|---------|--------|\r\n| Mac  | Chrome | 45  | Yes  |\r\n|          | Safari | 8  | Yes |\r\n|          | Firefox | 40 | Yes |\r\n| Windows | Chrome  | 45 | Yes |\r\n|          | Firefox | 40 | Yes |\r\n|          | IE | 10 | Yes |\r\n|          | IE | 11 | Yes |\r\n\r\n## Sandbox\r\n\r\n_Video with only a single language (no menu)_\r\nhttp://clrux-ac-187.sandbox.edx.org/courses/course-v1:edX+DemoX+Demo_Course/courseware/d8a6192ade314473a78242dfeedfbf5b/edx_introduction/\r\n\r\n_Video with multiple languages (menu)_\r\nhttp://clrux-ac-187.sandbox.edx.org/courses/course-v1:HarvardX+TEST_101+2015_T3/courseware/C_01/lecture_01/\r\n\r\n## Reviewers\r\n\r\n- [x] @frrrances (Sass)\r\n- [x] @andy-armstrong @clytwynec @cahrens (JS and Tests)\r\n- [ ] @cptvitamin (Accessibility)"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/156242428","html_url":"https://github.com/edx/edx-platform/pull/9974#issuecomment-156242428","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/9974","id":156242428,"user":{"login":"cptvitamin","id":444368,"avatar_url":"https://avatars.githubusercontent.com/u/444368?v=3","gravatar_id":"","url":"https://api.github.com/users/cptvitamin","html_url":"https://github.com/cptvitamin","followers_url":"https://api.github.com/users/cptvitamin/followers","following_url":"https://api.github.com/users/cptvitamin/following{/other_user}","gists_url":"https://api.github.com/users/cptvitamin/gists{/gist_id}","starred_url":"https://api.github.com/users/cptvitamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cptvitamin/subscriptions","organizations_url":"https://api.github.com/users/cptvitamin/orgs","repos_url":"https://api.github.com/users/cptvitamin/repos","events_url":"https://api.github.com/users/cptvitamin/events{/privacy}","received_events_url":"https://api.github.com/users/cptvitamin/received_events","type":"User","site_admin":false},"created_at":"2015-11-12T21:32:00Z","updated_at":"2015-11-12T21:32:00Z","body":":+1:   this looks good.  It has been very tricky to test.  I think we have covered a reasonable number of environment and AT combos and have as consistent a set of features and behaviors as we can hope for.  Nice work."}}