{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/43618096","id":43618096,"diff_hunk":"@@ -897,8 +896,8 @@ func (p *pod) getApps() (schema.AppList, error) {\n \tif err != nil {\n \t\treturn nil, err\n \t}\n-\tvar pm *schema.PodManifest\n-\tif err = json.Unmarshal(pmb, &pm); err != nil {\n+\tpm := new(schema.PodManifest)\n+\tif err = pm.UnmarshalJSON(pmb); err != nil {","path":"rkt/pods.go","position":24,"original_position":24,"commit_id":"47eacff551194e9d4dc1df816275c3c1d5cd486c","original_commit_id":"47eacff551194e9d4dc1df816275c3c1d5cd486c","user":{"login":"blixtra","id":115075,"avatar_url":"https://avatars.githubusercontent.com/u/115075?v=3","gravatar_id":"","url":"https://api.github.com/users/blixtra","html_url":"https://github.com/blixtra","followers_url":"https://api.github.com/users/blixtra/followers","following_url":"https://api.github.com/users/blixtra/following{/other_user}","gists_url":"https://api.github.com/users/blixtra/gists{/gist_id}","starred_url":"https://api.github.com/users/blixtra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blixtra/subscriptions","organizations_url":"https://api.github.com/users/blixtra/orgs","repos_url":"https://api.github.com/users/blixtra/repos","events_url":"https://api.github.com/users/blixtra/events{/privacy}","received_events_url":"https://api.github.com/users/blixtra/received_events","type":"User","site_admin":false},"body":"I changed this because earlier in the file, in `getApps` it was doing it this way so I want to make it perform the same task the same way. But your comment got me looking at it a bit closer and I've now removed the body of `getAppCount` completely and reuse `getApps.` Thanks!","created_at":"2015-11-02T11:15:44Z","updated_at":"2015-11-02T11:15:44Z","html_url":"https://github.com/coreos/rkt/pull/1701#discussion_r43618096","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/1701","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/43618096"},"html":{"href":"https://github.com/coreos/rkt/pull/1701#discussion_r43618096"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1701"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/1701","id":49295879,"html_url":"https://github.com/coreos/rkt/pull/1701","diff_url":"https://github.com/coreos/rkt/pull/1701.diff","patch_url":"https://github.com/coreos/rkt/pull/1701.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/1701","number":1701,"state":"open","locked":false,"title":"rkt: get name from ImageManifest","user":{"login":"blixtra","id":115075,"avatar_url":"https://avatars.githubusercontent.com/u/115075?v=3","gravatar_id":"","url":"https://api.github.com/users/blixtra","html_url":"https://github.com/blixtra","followers_url":"https://api.github.com/users/blixtra/followers","following_url":"https://api.github.com/users/blixtra/following{/other_user}","gists_url":"https://api.github.com/users/blixtra/gists{/gist_id}","starred_url":"https://api.github.com/users/blixtra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blixtra/subscriptions","organizations_url":"https://api.github.com/users/blixtra/orgs","repos_url":"https://api.github.com/users/blixtra/repos","events_url":"https://api.github.com/users/blixtra/events{/privacy}","received_events_url":"https://api.github.com/users/blixtra/received_events","type":"User","site_admin":false},"body":"Currently we are relying on an optional field in the PodManifest to get\r\nthe images name and version when running `rkt list` because, since one\r\nhas been able to remove referenced images, there was no guarantee that\r\nthe ImageManifest in the cas would be available.\r\n\r\nHowever, little did we know, there is a copy of the ImageManifest of the\r\npod in the pod's appinfo directory. This commit makes use of that.\r\n\r\nShould close #1659.","created_at":"2015-10-30T17:05:54Z","updated_at":"2015-11-02T11:15:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a09b57ac1e1814ccaa63b3a17fd8199aa09dab7f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/1701/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/1701/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/1701/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/47eacff551194e9d4dc1df816275c3c1d5cd486c","head":{"label":"kinvolk:blixtra/rkt-get-name-from-imagemanifest","ref":"blixtra/rkt-get-name-from-imagemanifest","sha":"47eacff551194e9d4dc1df816275c3c1d5cd486c","user":{"login":"kinvolk","id":14073052,"avatar_url":"https://avatars.githubusercontent.com/u/14073052?v=3","gravatar_id":"","url":"https://api.github.com/users/kinvolk","html_url":"https://github.com/kinvolk","followers_url":"https://api.github.com/users/kinvolk/followers","following_url":"https://api.github.com/users/kinvolk/following{/other_user}","gists_url":"https://api.github.com/users/kinvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvolk/subscriptions","organizations_url":"https://api.github.com/users/kinvolk/orgs","repos_url":"https://api.github.com/users/kinvolk/repos","events_url":"https://api.github.com/users/kinvolk/events{/privacy}","received_events_url":"https://api.github.com/users/kinvolk/received_events","type":"Organization","site_admin":false},"repo":{"id":45149715,"name":"rkt","full_name":"kinvolk/rkt","owner":{"login":"kinvolk","id":14073052,"avatar_url":"https://avatars.githubusercontent.com/u/14073052?v=3","gravatar_id":"","url":"https://api.github.com/users/kinvolk","html_url":"https://github.com/kinvolk","followers_url":"https://api.github.com/users/kinvolk/followers","following_url":"https://api.github.com/users/kinvolk/following{/other_user}","gists_url":"https://api.github.com/users/kinvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvolk/subscriptions","organizations_url":"https://api.github.com/users/kinvolk/orgs","repos_url":"https://api.github.com/users/kinvolk/repos","events_url":"https://api.github.com/users/kinvolk/events{/privacy}","received_events_url":"https://api.github.com/users/kinvolk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kinvolk/rkt","description":"rkt is an App Container runtime for Linux","fork":true,"url":"https://api.github.com/repos/kinvolk/rkt","forks_url":"https://api.github.com/repos/kinvolk/rkt/forks","keys_url":"https://api.github.com/repos/kinvolk/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinvolk/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinvolk/rkt/teams","hooks_url":"https://api.github.com/repos/kinvolk/rkt/hooks","issue_events_url":"https://api.github.com/repos/kinvolk/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/kinvolk/rkt/events","assignees_url":"https://api.github.com/repos/kinvolk/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/kinvolk/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/kinvolk/rkt/tags","blobs_url":"https://api.github.com/repos/kinvolk/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinvolk/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinvolk/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinvolk/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinvolk/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/kinvolk/rkt/languages","stargazers_url":"https://api.github.com/repos/kinvolk/rkt/stargazers","contributors_url":"https://api.github.com/repos/kinvolk/rkt/contributors","subscribers_url":"https://api.github.com/repos/kinvolk/rkt/subscribers","subscription_url":"https://api.github.com/repos/kinvolk/rkt/subscription","commits_url":"https://api.github.com/repos/kinvolk/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinvolk/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinvolk/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinvolk/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinvolk/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/kinvolk/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinvolk/rkt/merges","archive_url":"https://api.github.com/repos/kinvolk/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinvolk/rkt/downloads","issues_url":"https://api.github.com/repos/kinvolk/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/kinvolk/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/kinvolk/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/kinvolk/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinvolk/rkt/labels{/name}","releases_url":"https://api.github.com/repos/kinvolk/rkt/releases{/id}","created_at":"2015-10-29T00:17:06Z","updated_at":"2015-10-29T00:17:09Z","pushed_at":"2015-10-30T18:45:45Z","git_url":"git://github.com/kinvolk/rkt.git","ssh_url":"git@github.com:kinvolk/rkt.git","clone_url":"https://github.com/kinvolk/rkt.git","svn_url":"https://github.com/kinvolk/rkt","homepage":"","size":17020,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"21fd43a0f862d96d6a9e4b6c37974de63e270f23","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is an App Container runtime for Linux","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","created_at":"2014-11-11T23:13:18Z","updated_at":"2015-11-01T09:30:11Z","pushed_at":"2015-11-02T10:40:24Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":28295,"stargazers_count":4788,"watchers_count":4788,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":408,"mirror_url":null,"open_issues_count":190,"forks":408,"open_issues":190,"watchers":4788,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1701"},"html":{"href":"https://github.com/coreos/rkt/pull/1701"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/1701"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/1701/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1701/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1701/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/47eacff551194e9d4dc1df816275c3c1d5cd486c"}}}}