{"action":"created","comment":{"url":"https://api.github.com/repos/xenserver/xenadmin/pulls/comments/25270562","id":25270562,"diff_hunk":"@@ -564,22 +565,23 @@ public void CheckDockerContainersBatchChange()\n         }\r\n \r\n         private bool dockerContainersChanged = false;\r\n-        public void UpdateDockerContainersForVM(IEnumerable<DockerContainer> containers, VM vm)\r\n+        public void UpdateDockerContainersForVM(IList<DockerContainer> containers, VM vm)\r\n         {\r\n-            dockerContainersChanged = true;\r\n-         \r\n+            Trace.Assert(vm != null);\r\n+\r\n             //updating existing, adding new containers\r\n+            dockerContainersChanged = dockerContainersChanged || containers.Count > 0;\r","path":"XenModel/Network/Cache.cs","position":20,"original_position":20,"commit_id":"d364d976c223a6231edf008a49da337113b4c1f3","original_commit_id":"d364d976c223a6231edf008a49da337113b4c1f3","user":{"login":"GaborApatiNagy","id":6017976,"avatar_url":"https://avatars.githubusercontent.com/u/6017976?v=3","gravatar_id":"","url":"https://api.github.com/users/GaborApatiNagy","html_url":"https://github.com/GaborApatiNagy","followers_url":"https://api.github.com/users/GaborApatiNagy/followers","following_url":"https://api.github.com/users/GaborApatiNagy/following{/other_user}","gists_url":"https://api.github.com/users/GaborApatiNagy/gists{/gist_id}","starred_url":"https://api.github.com/users/GaborApatiNagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaborApatiNagy/subscriptions","organizations_url":"https://api.github.com/users/GaborApatiNagy/orgs","repos_url":"https://api.github.com/users/GaborApatiNagy/repos","events_url":"https://api.github.com/users/GaborApatiNagy/events{/privacy}","received_events_url":"https://api.github.com/users/GaborApatiNagy/received_events","type":"User","site_admin":false},"body":"It definitely would, but it is not there in C#. \r\nI was not sure, so did a bit of research and it seems the bitwise operator |= could be used instead, although that one is not short circuiting as || is, so I would say I would leave it as is.","created_at":"2015-02-24T17:11:08Z","updated_at":"2015-02-24T17:11:08Z","html_url":"https://github.com/xenserver/xenadmin/pull/345#discussion_r25270562","pull_request_url":"https://api.github.com/repos/xenserver/xenadmin/pulls/345","_links":{"self":{"href":"https://api.github.com/repos/xenserver/xenadmin/pulls/comments/25270562"},"html":{"href":"https://github.com/xenserver/xenadmin/pull/345#discussion_r25270562"},"pull_request":{"href":"https://api.github.com/repos/xenserver/xenadmin/pulls/345"}}},"pull_request":{"url":"https://api.github.com/repos/xenserver/xenadmin/pulls/345","id":29825873,"html_url":"https://github.com/xenserver/xenadmin/pull/345","diff_url":"https://github.com/xenserver/xenadmin/pull/345.diff","patch_url":"https://github.com/xenserver/xenadmin/pull/345.patch","issue_url":"https://api.github.com/repos/xenserver/xenadmin/issues/345","number":345,"state":"open","locked":false,"title":"CA-160996: XenCenter: Subscribe to fewer events in DockerContainers","user":{"login":"GaborApatiNagy","id":6017976,"avatar_url":"https://avatars.githubusercontent.com/u/6017976?v=3","gravatar_id":"","url":"https://api.github.com/users/GaborApatiNagy","html_url":"https://github.com/GaborApatiNagy","followers_url":"https://api.github.com/users/GaborApatiNagy/followers","following_url":"https://api.github.com/users/GaborApatiNagy/following{/other_user}","gists_url":"https://api.github.com/users/GaborApatiNagy/gists{/gist_id}","starred_url":"https://api.github.com/users/GaborApatiNagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaborApatiNagy/subscriptions","organizations_url":"https://api.github.com/users/GaborApatiNagy/orgs","repos_url":"https://api.github.com/users/GaborApatiNagy/repos","events_url":"https://api.github.com/users/GaborApatiNagy/events{/privacy}","received_events_url":"https://api.github.com/users/GaborApatiNagy/received_events","type":"User","site_admin":false},"body":"-ServerXenObject-PropertyChanged eventhandler now returns immediately for a non-VM sender\r\n-Changed IXenObject to VM wherever possible to explicitly state that those methods are expecting VMs\r\n-The UpdateDockerContainersForVM method sets the dockerContainersChanged flag only if there are changes\r\n\r\nSigned-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>","created_at":"2015-02-23T17:05:21Z","updated_at":"2015-02-24T17:11:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1813a739398e3dcea4590c097ece0254fa06738b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xenserver/xenadmin/pulls/345/commits","review_comments_url":"https://api.github.com/repos/xenserver/xenadmin/pulls/345/comments","review_comment_url":"https://api.github.com/repos/xenserver/xenadmin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xenserver/xenadmin/issues/345/comments","statuses_url":"https://api.github.com/repos/xenserver/xenadmin/statuses/d364d976c223a6231edf008a49da337113b4c1f3","head":{"label":"GaborApatiNagy:CA-160996","ref":"CA-160996","sha":"d364d976c223a6231edf008a49da337113b4c1f3","user":{"login":"GaborApatiNagy","id":6017976,"avatar_url":"https://avatars.githubusercontent.com/u/6017976?v=3","gravatar_id":"","url":"https://api.github.com/users/GaborApatiNagy","html_url":"https://github.com/GaborApatiNagy","followers_url":"https://api.github.com/users/GaborApatiNagy/followers","following_url":"https://api.github.com/users/GaborApatiNagy/following{/other_user}","gists_url":"https://api.github.com/users/GaborApatiNagy/gists{/gist_id}","starred_url":"https://api.github.com/users/GaborApatiNagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaborApatiNagy/subscriptions","organizations_url":"https://api.github.com/users/GaborApatiNagy/orgs","repos_url":"https://api.github.com/users/GaborApatiNagy/repos","events_url":"https://api.github.com/users/GaborApatiNagy/events{/privacy}","received_events_url":"https://api.github.com/users/GaborApatiNagy/received_events","type":"User","site_admin":false},"repo":{"id":15899182,"name":"xenadmin","full_name":"GaborApatiNagy/xenadmin","owner":{"login":"GaborApatiNagy","id":6017976,"avatar_url":"https://avatars.githubusercontent.com/u/6017976?v=3","gravatar_id":"","url":"https://api.github.com/users/GaborApatiNagy","html_url":"https://github.com/GaborApatiNagy","followers_url":"https://api.github.com/users/GaborApatiNagy/followers","following_url":"https://api.github.com/users/GaborApatiNagy/following{/other_user}","gists_url":"https://api.github.com/users/GaborApatiNagy/gists{/gist_id}","starred_url":"https://api.github.com/users/GaborApatiNagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaborApatiNagy/subscriptions","organizations_url":"https://api.github.com/users/GaborApatiNagy/orgs","repos_url":"https://api.github.com/users/GaborApatiNagy/repos","events_url":"https://api.github.com/users/GaborApatiNagy/events{/privacy}","received_events_url":"https://api.github.com/users/GaborApatiNagy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GaborApatiNagy/xenadmin","description":"XenCenter, the Windows management console for XenServer","fork":true,"url":"https://api.github.com/repos/GaborApatiNagy/xenadmin","forks_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/forks","keys_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/teams","hooks_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/hooks","issue_events_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/issues/events{/number}","events_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/events","assignees_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/assignees{/user}","branches_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/branches{/branch}","tags_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/tags","blobs_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/languages","stargazers_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/stargazers","contributors_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/contributors","subscribers_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/subscribers","subscription_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/subscription","commits_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/contents/{+path}","compare_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/merges","archive_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/downloads","issues_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/issues{/number}","pulls_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/labels{/name}","releases_url":"https://api.github.com/repos/GaborApatiNagy/xenadmin/releases{/id}","created_at":"2014-01-14T10:41:45Z","updated_at":"2015-01-15T13:47:30Z","pushed_at":"2015-02-24T13:20:38Z","git_url":"git://github.com/GaborApatiNagy/xenadmin.git","ssh_url":"git@github.com:GaborApatiNagy/xenadmin.git","clone_url":"https://github.com/GaborApatiNagy/xenadmin.git","svn_url":"https://github.com/GaborApatiNagy/xenadmin","homepage":"","size":64565,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xenserver:master","ref":"master","sha":"4c03d4133737ca733833d9457abb3069f572faf4","user":{"login":"xenserver","id":4669806,"avatar_url":"https://avatars.githubusercontent.com/u/4669806?v=3","gravatar_id":"","url":"https://api.github.com/users/xenserver","html_url":"https://github.com/xenserver","followers_url":"https://api.github.com/users/xenserver/followers","following_url":"https://api.github.com/users/xenserver/following{/other_user}","gists_url":"https://api.github.com/users/xenserver/gists{/gist_id}","starred_url":"https://api.github.com/users/xenserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xenserver/subscriptions","organizations_url":"https://api.github.com/users/xenserver/orgs","repos_url":"https://api.github.com/users/xenserver/repos","events_url":"https://api.github.com/users/xenserver/events{/privacy}","received_events_url":"https://api.github.com/users/xenserver/received_events","type":"Organization","site_admin":false},"repo":{"id":10915984,"name":"xenadmin","full_name":"xenserver/xenadmin","owner":{"login":"xenserver","id":4669806,"avatar_url":"https://avatars.githubusercontent.com/u/4669806?v=3","gravatar_id":"","url":"https://api.github.com/users/xenserver","html_url":"https://github.com/xenserver","followers_url":"https://api.github.com/users/xenserver/followers","following_url":"https://api.github.com/users/xenserver/following{/other_user}","gists_url":"https://api.github.com/users/xenserver/gists{/gist_id}","starred_url":"https://api.github.com/users/xenserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xenserver/subscriptions","organizations_url":"https://api.github.com/users/xenserver/orgs","repos_url":"https://api.github.com/users/xenserver/repos","events_url":"https://api.github.com/users/xenserver/events{/privacy}","received_events_url":"https://api.github.com/users/xenserver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xenserver/xenadmin","description":"XenCenter, the Windows management console for XenServer","fork":false,"url":"https://api.github.com/repos/xenserver/xenadmin","forks_url":"https://api.github.com/repos/xenserver/xenadmin/forks","keys_url":"https://api.github.com/repos/xenserver/xenadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xenserver/xenadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xenserver/xenadmin/teams","hooks_url":"https://api.github.com/repos/xenserver/xenadmin/hooks","issue_events_url":"https://api.github.com/repos/xenserver/xenadmin/issues/events{/number}","events_url":"https://api.github.com/repos/xenserver/xenadmin/events","assignees_url":"https://api.github.com/repos/xenserver/xenadmin/assignees{/user}","branches_url":"https://api.github.com/repos/xenserver/xenadmin/branches{/branch}","tags_url":"https://api.github.com/repos/xenserver/xenadmin/tags","blobs_url":"https://api.github.com/repos/xenserver/xenadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xenserver/xenadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xenserver/xenadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/xenserver/xenadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xenserver/xenadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/xenserver/xenadmin/languages","stargazers_url":"https://api.github.com/repos/xenserver/xenadmin/stargazers","contributors_url":"https://api.github.com/repos/xenserver/xenadmin/contributors","subscribers_url":"https://api.github.com/repos/xenserver/xenadmin/subscribers","subscription_url":"https://api.github.com/repos/xenserver/xenadmin/subscription","commits_url":"https://api.github.com/repos/xenserver/xenadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/xenserver/xenadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/xenserver/xenadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/xenserver/xenadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/xenserver/xenadmin/contents/{+path}","compare_url":"https://api.github.com/repos/xenserver/xenadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xenserver/xenadmin/merges","archive_url":"https://api.github.com/repos/xenserver/xenadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xenserver/xenadmin/downloads","issues_url":"https://api.github.com/repos/xenserver/xenadmin/issues{/number}","pulls_url":"https://api.github.com/repos/xenserver/xenadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/xenserver/xenadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/xenserver/xenadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xenserver/xenadmin/labels{/name}","releases_url":"https://api.github.com/repos/xenserver/xenadmin/releases{/id}","created_at":"2013-06-24T18:10:24Z","updated_at":"2015-02-24T16:31:21Z","pushed_at":"2015-02-24T16:31:21Z","git_url":"git://github.com/xenserver/xenadmin.git","ssh_url":"git@github.com:xenserver/xenadmin.git","clone_url":"https://github.com/xenserver/xenadmin.git","svn_url":"https://github.com/xenserver/xenadmin","homepage":"","size":69382,"stargazers_count":79,"watchers_count":79,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":8,"forks":51,"open_issues":8,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xenserver/xenadmin/pulls/345"},"html":{"href":"https://github.com/xenserver/xenadmin/pull/345"},"issue":{"href":"https://api.github.com/repos/xenserver/xenadmin/issues/345"},"comments":{"href":"https://api.github.com/repos/xenserver/xenadmin/issues/345/comments"},"review_comments":{"href":"https://api.github.com/repos/xenserver/xenadmin/pulls/345/comments"},"review_comment":{"href":"https://api.github.com/repos/xenserver/xenadmin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xenserver/xenadmin/pulls/345/commits"},"statuses":{"href":"https://api.github.com/repos/xenserver/xenadmin/statuses/d364d976c223a6231edf008a49da337113b4c1f3"}}}}