{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular/issues/4784","labels_url":"https://api.github.com/repos/angular/angular/issues/4784/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular/issues/4784/comments","events_url":"https://api.github.com/repos/angular/angular/issues/4784/events","html_url":"https://github.com/angular/angular/pull/4784","id":111805381,"number":4784,"title":"feat(upgrade): support bindToController with binding definitions","user":{"login":"PascalPrecht","id":445106,"avatar_url":"https://avatars.githubusercontent.com/u/445106?v=3","gravatar_id":"","url":"https://api.github.com/users/PascalPrecht","html_url":"https://github.com/PascalPrecht","followers_url":"https://api.github.com/users/PascalPrecht/followers","following_url":"https://api.github.com/users/PascalPrecht/following{/other_user}","gists_url":"https://api.github.com/users/PascalPrecht/gists{/gist_id}","starred_url":"https://api.github.com/users/PascalPrecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PascalPrecht/subscriptions","organizations_url":"https://api.github.com/users/PascalPrecht/orgs","repos_url":"https://api.github.com/users/PascalPrecht/repos","events_url":"https://api.github.com/users/PascalPrecht/events{/privacy}","received_events_url":"https://api.github.com/users/PascalPrecht/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800"},{"url":"https://api.github.com/repos/angular/angular/labels/pr_action:%20merge","name":"pr_action: merge","color":"99ff66"},{"url":"https://api.github.com/repos/angular/angular/labels/pr_state:%20LGTM","name":"pr_state: LGTM","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"mhevery","id":111951,"avatar_url":"https://avatars.githubusercontent.com/u/111951?v=3","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/angular/angular/milestones/49","html_url":"https://github.com/angular/angular/milestones/beta-00","labels_url":"https://api.github.com/repos/angular/angular/milestones/49/labels","id":1339148,"number":49,"title":"beta-00","description":"Issues which must close before we declare beta.","creator":{"login":"naomiblack","id":2286589,"avatar_url":"https://avatars.githubusercontent.com/u/2286589?v=3","gravatar_id":"","url":"https://api.github.com/users/naomiblack","html_url":"https://github.com/naomiblack","followers_url":"https://api.github.com/users/naomiblack/followers","following_url":"https://api.github.com/users/naomiblack/following{/other_user}","gists_url":"https://api.github.com/users/naomiblack/gists{/gist_id}","starred_url":"https://api.github.com/users/naomiblack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naomiblack/subscriptions","organizations_url":"https://api.github.com/users/naomiblack/orgs","repos_url":"https://api.github.com/users/naomiblack/repos","events_url":"https://api.github.com/users/naomiblack/events{/privacy}","received_events_url":"https://api.github.com/users/naomiblack/received_events","type":"User","site_admin":false},"open_issues":71,"closed_issues":71,"state":"open","created_at":"2015-10-05T21:32:20Z","updated_at":"2015-11-18T07:10:37Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2015-10-16T10:36:34Z","updated_at":"2015-11-18T18:37:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/4784","html_url":"https://github.com/angular/angular/pull/4784","diff_url":"https://github.com/angular/angular/pull/4784.diff","patch_url":"https://github.com/angular/angular/pull/4784.patch"},"body":"Since angular `1.4` we can also pass controller bindings directly to `bindToController`, making this syntax more convenient\r\n\r\nThis needs to be implemented I just added a test for it now.\r\n\r\n/cc @mhevery "},"comment":{"url":"https://api.github.com/repos/angular/angular/issues/comments/157813907","html_url":"https://github.com/angular/angular/pull/4784#issuecomment-157813907","issue_url":"https://api.github.com/repos/angular/angular/issues/4784","id":157813907,"user":{"login":"mhevery","id":111951,"avatar_url":"https://avatars.githubusercontent.com/u/111951?v=3","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"created_at":"2015-11-18T18:37:39Z","updated_at":"2015-11-18T18:37:39Z","body":"@PascalPrecht I don't think `ngUpgrade` will ever support / mimic the Angular 1 exactly. (For example we don't and can't support ng1 replace feature) So in this case I think we should just check for this corner case and if this is what the user has requested throw a descriptive error."}}