{"action":"opened","number":539,"pull_request":{"url":"https://api.github.com/repos/btcsuite/btcd/pulls/539","id":49842894,"html_url":"https://github.com/btcsuite/btcd/pull/539","diff_url":"https://github.com/btcsuite/btcd/pull/539.diff","patch_url":"https://github.com/btcsuite/btcd/pull/539.patch","issue_url":"https://api.github.com/repos/btcsuite/btcd/issues/539","number":539,"state":"open","locked":false,"title":"Fix mempool transactions disappearing if a parent tx is confirmed.","user":{"login":"Dirbaio","id":1247578,"avatar_url":"https://avatars.githubusercontent.com/u/1247578?v=3","gravatar_id":"","url":"https://api.github.com/users/Dirbaio","html_url":"https://github.com/Dirbaio","followers_url":"https://api.github.com/users/Dirbaio/followers","following_url":"https://api.github.com/users/Dirbaio/following{/other_user}","gists_url":"https://api.github.com/users/Dirbaio/gists{/gist_id}","starred_url":"https://api.github.com/users/Dirbaio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dirbaio/subscriptions","organizations_url":"https://api.github.com/users/Dirbaio/orgs","repos_url":"https://api.github.com/users/Dirbaio/repos","events_url":"https://api.github.com/users/Dirbaio/events{/privacy}","received_events_url":"https://api.github.com/users/Dirbaio/received_events","type":"User","site_admin":false},"body":"There's a bug in the logic that processes new blocks that causes txs to be unnecessarily dropped from mempool.\r\n\r\nBasically:\r\n\r\nThere are two txs A and B in mempool. Tx B uses an output from A.\r\nA new block is received that contains A but not B. \r\n\r\nRemoveTransaction(A) will be called on the mempool, which will recursively remove B. However, B should not be removed because it's not orphan, its parent is now on the blockchain.\r\n\r\nThis fixes the bug by not recursively removing depending transactions when processing blocks.","created_at":"2015-11-05T16:03:10Z","updated_at":"2015-11-05T16:03:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/btcsuite/btcd/pulls/539/commits","review_comments_url":"https://api.github.com/repos/btcsuite/btcd/pulls/539/comments","review_comment_url":"https://api.github.com/repos/btcsuite/btcd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/btcsuite/btcd/issues/539/comments","statuses_url":"https://api.github.com/repos/btcsuite/btcd/statuses/2d6a2e985df561d821483b9c8ed981689e7723be","head":{"label":"Dirbaio:fix-mempool-drop","ref":"fix-mempool-drop","sha":"2d6a2e985df561d821483b9c8ed981689e7723be","user":{"login":"Dirbaio","id":1247578,"avatar_url":"https://avatars.githubusercontent.com/u/1247578?v=3","gravatar_id":"","url":"https://api.github.com/users/Dirbaio","html_url":"https://github.com/Dirbaio","followers_url":"https://api.github.com/users/Dirbaio/followers","following_url":"https://api.github.com/users/Dirbaio/following{/other_user}","gists_url":"https://api.github.com/users/Dirbaio/gists{/gist_id}","starred_url":"https://api.github.com/users/Dirbaio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dirbaio/subscriptions","organizations_url":"https://api.github.com/users/Dirbaio/orgs","repos_url":"https://api.github.com/users/Dirbaio/repos","events_url":"https://api.github.com/users/Dirbaio/events{/privacy}","received_events_url":"https://api.github.com/users/Dirbaio/received_events","type":"User","site_admin":false},"repo":{"id":41160721,"name":"btcd","full_name":"Dirbaio/btcd","owner":{"login":"Dirbaio","id":1247578,"avatar_url":"https://avatars.githubusercontent.com/u/1247578?v=3","gravatar_id":"","url":"https://api.github.com/users/Dirbaio","html_url":"https://github.com/Dirbaio","followers_url":"https://api.github.com/users/Dirbaio/followers","following_url":"https://api.github.com/users/Dirbaio/following{/other_user}","gists_url":"https://api.github.com/users/Dirbaio/gists{/gist_id}","starred_url":"https://api.github.com/users/Dirbaio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dirbaio/subscriptions","organizations_url":"https://api.github.com/users/Dirbaio/orgs","repos_url":"https://api.github.com/users/Dirbaio/repos","events_url":"https://api.github.com/users/Dirbaio/events{/privacy}","received_events_url":"https://api.github.com/users/Dirbaio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dirbaio/btcd","description":"An alternative full node bitcoin implementation written in Go (golang)","fork":true,"url":"https://api.github.com/repos/Dirbaio/btcd","forks_url":"https://api.github.com/repos/Dirbaio/btcd/forks","keys_url":"https://api.github.com/repos/Dirbaio/btcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dirbaio/btcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dirbaio/btcd/teams","hooks_url":"https://api.github.com/repos/Dirbaio/btcd/hooks","issue_events_url":"https://api.github.com/repos/Dirbaio/btcd/issues/events{/number}","events_url":"https://api.github.com/repos/Dirbaio/btcd/events","assignees_url":"https://api.github.com/repos/Dirbaio/btcd/assignees{/user}","branches_url":"https://api.github.com/repos/Dirbaio/btcd/branches{/branch}","tags_url":"https://api.github.com/repos/Dirbaio/btcd/tags","blobs_url":"https://api.github.com/repos/Dirbaio/btcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dirbaio/btcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dirbaio/btcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dirbaio/btcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dirbaio/btcd/statuses/{sha}","languages_url":"https://api.github.com/repos/Dirbaio/btcd/languages","stargazers_url":"https://api.github.com/repos/Dirbaio/btcd/stargazers","contributors_url":"https://api.github.com/repos/Dirbaio/btcd/contributors","subscribers_url":"https://api.github.com/repos/Dirbaio/btcd/subscribers","subscription_url":"https://api.github.com/repos/Dirbaio/btcd/subscription","commits_url":"https://api.github.com/repos/Dirbaio/btcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dirbaio/btcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dirbaio/btcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dirbaio/btcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dirbaio/btcd/contents/{+path}","compare_url":"https://api.github.com/repos/Dirbaio/btcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dirbaio/btcd/merges","archive_url":"https://api.github.com/repos/Dirbaio/btcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dirbaio/btcd/downloads","issues_url":"https://api.github.com/repos/Dirbaio/btcd/issues{/number}","pulls_url":"https://api.github.com/repos/Dirbaio/btcd/pulls{/number}","milestones_url":"https://api.github.com/repos/Dirbaio/btcd/milestones{/number}","notifications_url":"https://api.github.com/repos/Dirbaio/btcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dirbaio/btcd/labels{/name}","releases_url":"https://api.github.com/repos/Dirbaio/btcd/releases{/id}","created_at":"2015-08-21T14:38:04Z","updated_at":"2015-08-21T14:38:05Z","pushed_at":"2015-11-05T16:00:20Z","git_url":"git://github.com/Dirbaio/btcd.git","ssh_url":"git@github.com:Dirbaio/btcd.git","clone_url":"https://github.com/Dirbaio/btcd.git","svn_url":"https://github.com/Dirbaio/btcd","homepage":"https://github.com/btcsuite/btcd/blob/master/docs/README.md","size":8826,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"btcsuite:master","ref":"master","sha":"4b7206b54fd3df7a9a254f22dec5c37ce72625c4","user":{"login":"btcsuite","id":10235229,"avatar_url":"https://avatars.githubusercontent.com/u/10235229?v=3","gravatar_id":"","url":"https://api.github.com/users/btcsuite","html_url":"https://github.com/btcsuite","followers_url":"https://api.github.com/users/btcsuite/followers","following_url":"https://api.github.com/users/btcsuite/following{/other_user}","gists_url":"https://api.github.com/users/btcsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/btcsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btcsuite/subscriptions","organizations_url":"https://api.github.com/users/btcsuite/orgs","repos_url":"https://api.github.com/users/btcsuite/repos","events_url":"https://api.github.com/users/btcsuite/events{/privacy}","received_events_url":"https://api.github.com/users/btcsuite/received_events","type":"Organization","site_admin":false},"repo":{"id":11931032,"name":"btcd","full_name":"btcsuite/btcd","owner":{"login":"btcsuite","id":10235229,"avatar_url":"https://avatars.githubusercontent.com/u/10235229?v=3","gravatar_id":"","url":"https://api.github.com/users/btcsuite","html_url":"https://github.com/btcsuite","followers_url":"https://api.github.com/users/btcsuite/followers","following_url":"https://api.github.com/users/btcsuite/following{/other_user}","gists_url":"https://api.github.com/users/btcsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/btcsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btcsuite/subscriptions","organizations_url":"https://api.github.com/users/btcsuite/orgs","repos_url":"https://api.github.com/users/btcsuite/repos","events_url":"https://api.github.com/users/btcsuite/events{/privacy}","received_events_url":"https://api.github.com/users/btcsuite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/btcsuite/btcd","description":"An alternative full node bitcoin implementation written in Go (golang)","fork":false,"url":"https://api.github.com/repos/btcsuite/btcd","forks_url":"https://api.github.com/repos/btcsuite/btcd/forks","keys_url":"https://api.github.com/repos/btcsuite/btcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/btcsuite/btcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/btcsuite/btcd/teams","hooks_url":"https://api.github.com/repos/btcsuite/btcd/hooks","issue_events_url":"https://api.github.com/repos/btcsuite/btcd/issues/events{/number}","events_url":"https://api.github.com/repos/btcsuite/btcd/events","assignees_url":"https://api.github.com/repos/btcsuite/btcd/assignees{/user}","branches_url":"https://api.github.com/repos/btcsuite/btcd/branches{/branch}","tags_url":"https://api.github.com/repos/btcsuite/btcd/tags","blobs_url":"https://api.github.com/repos/btcsuite/btcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/btcsuite/btcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/btcsuite/btcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/btcsuite/btcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/btcsuite/btcd/statuses/{sha}","languages_url":"https://api.github.com/repos/btcsuite/btcd/languages","stargazers_url":"https://api.github.com/repos/btcsuite/btcd/stargazers","contributors_url":"https://api.github.com/repos/btcsuite/btcd/contributors","subscribers_url":"https://api.github.com/repos/btcsuite/btcd/subscribers","subscription_url":"https://api.github.com/repos/btcsuite/btcd/subscription","commits_url":"https://api.github.com/repos/btcsuite/btcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/btcsuite/btcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/btcsuite/btcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/btcsuite/btcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/btcsuite/btcd/contents/{+path}","compare_url":"https://api.github.com/repos/btcsuite/btcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/btcsuite/btcd/merges","archive_url":"https://api.github.com/repos/btcsuite/btcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/btcsuite/btcd/downloads","issues_url":"https://api.github.com/repos/btcsuite/btcd/issues{/number}","pulls_url":"https://api.github.com/repos/btcsuite/btcd/pulls{/number}","milestones_url":"https://api.github.com/repos/btcsuite/btcd/milestones{/number}","notifications_url":"https://api.github.com/repos/btcsuite/btcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/btcsuite/btcd/labels{/name}","releases_url":"https://api.github.com/repos/btcsuite/btcd/releases{/id}","created_at":"2013-08-06T18:10:52Z","updated_at":"2015-11-05T10:56:24Z","pushed_at":"2015-11-04T16:08:20Z","git_url":"git://github.com/btcsuite/btcd.git","ssh_url":"git@github.com:btcsuite/btcd.git","clone_url":"https://github.com/btcsuite/btcd.git","svn_url":"https://github.com/btcsuite/btcd","homepage":"https://github.com/btcsuite/btcd/blob/master/docs/README.md","size":20075,"stargazers_count":701,"watchers_count":701,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":153,"mirror_url":null,"open_issues_count":41,"forks":153,"open_issues":41,"watchers":701,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/btcsuite/btcd/pulls/539"},"html":{"href":"https://github.com/btcsuite/btcd/pull/539"},"issue":{"href":"https://api.github.com/repos/btcsuite/btcd/issues/539"},"comments":{"href":"https://api.github.com/repos/btcsuite/btcd/issues/539/comments"},"review_comments":{"href":"https://api.github.com/repos/btcsuite/btcd/pulls/539/comments"},"review_comment":{"href":"https://api.github.com/repos/btcsuite/btcd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/btcsuite/btcd/pulls/539/commits"},"statuses":{"href":"https://api.github.com/repos/btcsuite/btcd/statuses/2d6a2e985df561d821483b9c8ed981689e7723be"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":27,"deletions":12,"changed_files":2}}