{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls/comments/27340969","id":27340969,"diff_hunk":"@@ -17,51 +17,75 @@\n # Recipe:: ceph\n #\n \n-glance_servers = search(:node, \"roles:glance-server\")\n-if glance_servers.length > 0\n-  glance_pool = glance_servers[0][:glance][:rbd][:store_pool]\n-else   \n-  glance_pool = nil\n-end\n+ceph_clients = {}\n+ceph_keyrings = {}\n \n node[:cinder][:volumes].each_with_index do |volume, volid|\n-  if volume['backend_driver'] == \"rbd\"\n+  unless volume[:backend_driver] == \"rbd\"\n+    next\n+  else\n+\n+    ceph_conf = volume[:rbd][:config_file]\n+    admin_keyring = volume[:rbd][:admin_keyring]","path":"chef/cookbooks/cinder/recipes/ceph.rb","position":20,"original_position":20,"commit_id":"72042e40ce2919c25baa72ce951edb7a5218701b","original_commit_id":"18de29c4b865e57af12ed0242e54baed087cf4f2","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"body":"For the record, like for the glance barclamp, I think that we should not use the attributes but hard-coded values when `volume['rbd']['use_crowbar']` is true.","created_at":"2015-03-28T01:19:30Z","updated_at":"2015-03-28T01:19:30Z","html_url":"https://github.com/crowbar/barclamp-cinder/pull/246#discussion_r27340969","pull_request_url":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls/246","_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls/comments/27340969"},"html":{"href":"https://github.com/crowbar/barclamp-cinder/pull/246#discussion_r27340969"},"pull_request":{"href":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls/246"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls/246","id":31541788,"html_url":"https://github.com/crowbar/barclamp-cinder/pull/246","diff_url":"https://github.com/crowbar/barclamp-cinder/pull/246.diff","patch_url":"https://github.com/crowbar/barclamp-cinder/pull/246.patch","issue_url":"https://api.github.com/repos/crowbar/barclamp-cinder/issues/246","number":246,"state":"open","locked":false,"title":"Rbd loops","user":{"login":"mjura","id":4455471,"avatar_url":"https://avatars.githubusercontent.com/u/4455471?v=3","gravatar_id":"","url":"https://api.github.com/users/mjura","html_url":"https://github.com/mjura","followers_url":"https://api.github.com/users/mjura/followers","following_url":"https://api.github.com/users/mjura/following{/other_user}","gists_url":"https://api.github.com/users/mjura/gists{/gist_id}","starred_url":"https://api.github.com/users/mjura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjura/subscriptions","organizations_url":"https://api.github.com/users/mjura/orgs","repos_url":"https://api.github.com/users/mjura/repos","events_url":"https://api.github.com/users/mjura/events{/privacy}","received_events_url":"https://api.github.com/users/mjura/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-19T16:41:56Z","updated_at":"2015-03-28T01:19:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6b5478f068f79845f43deb89daf0d14daa325f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls/246/commits","review_comments_url":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls/246/comments","review_comment_url":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/barclamp-cinder/issues/246/comments","statuses_url":"https://api.github.com/repos/crowbar/barclamp-cinder/statuses/72042e40ce2919c25baa72ce951edb7a5218701b","head":{"label":"mjura:rbd_loops","ref":"rbd_loops","sha":"72042e40ce2919c25baa72ce951edb7a5218701b","user":{"login":"mjura","id":4455471,"avatar_url":"https://avatars.githubusercontent.com/u/4455471?v=3","gravatar_id":"","url":"https://api.github.com/users/mjura","html_url":"https://github.com/mjura","followers_url":"https://api.github.com/users/mjura/followers","following_url":"https://api.github.com/users/mjura/following{/other_user}","gists_url":"https://api.github.com/users/mjura/gists{/gist_id}","starred_url":"https://api.github.com/users/mjura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjura/subscriptions","organizations_url":"https://api.github.com/users/mjura/orgs","repos_url":"https://api.github.com/users/mjura/repos","events_url":"https://api.github.com/users/mjura/events{/privacy}","received_events_url":"https://api.github.com/users/mjura/received_events","type":"User","site_admin":false},"repo":{"id":13346424,"name":"barclamp-cinder","full_name":"mjura/barclamp-cinder","owner":{"login":"mjura","id":4455471,"avatar_url":"https://avatars.githubusercontent.com/u/4455471?v=3","gravatar_id":"","url":"https://api.github.com/users/mjura","html_url":"https://github.com/mjura","followers_url":"https://api.github.com/users/mjura/followers","following_url":"https://api.github.com/users/mjura/following{/other_user}","gists_url":"https://api.github.com/users/mjura/gists{/gist_id}","starred_url":"https://api.github.com/users/mjura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjura/subscriptions","organizations_url":"https://api.github.com/users/mjura/orgs","repos_url":"https://api.github.com/users/mjura/repos","events_url":"https://api.github.com/users/mjura/events{/privacy}","received_events_url":"https://api.github.com/users/mjura/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjura/barclamp-cinder","description":"OpenStack Block Storage","fork":true,"url":"https://api.github.com/repos/mjura/barclamp-cinder","forks_url":"https://api.github.com/repos/mjura/barclamp-cinder/forks","keys_url":"https://api.github.com/repos/mjura/barclamp-cinder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjura/barclamp-cinder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjura/barclamp-cinder/teams","hooks_url":"https://api.github.com/repos/mjura/barclamp-cinder/hooks","issue_events_url":"https://api.github.com/repos/mjura/barclamp-cinder/issues/events{/number}","events_url":"https://api.github.com/repos/mjura/barclamp-cinder/events","assignees_url":"https://api.github.com/repos/mjura/barclamp-cinder/assignees{/user}","branches_url":"https://api.github.com/repos/mjura/barclamp-cinder/branches{/branch}","tags_url":"https://api.github.com/repos/mjura/barclamp-cinder/tags","blobs_url":"https://api.github.com/repos/mjura/barclamp-cinder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjura/barclamp-cinder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjura/barclamp-cinder/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjura/barclamp-cinder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjura/barclamp-cinder/statuses/{sha}","languages_url":"https://api.github.com/repos/mjura/barclamp-cinder/languages","stargazers_url":"https://api.github.com/repos/mjura/barclamp-cinder/stargazers","contributors_url":"https://api.github.com/repos/mjura/barclamp-cinder/contributors","subscribers_url":"https://api.github.com/repos/mjura/barclamp-cinder/subscribers","subscription_url":"https://api.github.com/repos/mjura/barclamp-cinder/subscription","commits_url":"https://api.github.com/repos/mjura/barclamp-cinder/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjura/barclamp-cinder/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjura/barclamp-cinder/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjura/barclamp-cinder/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjura/barclamp-cinder/contents/{+path}","compare_url":"https://api.github.com/repos/mjura/barclamp-cinder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjura/barclamp-cinder/merges","archive_url":"https://api.github.com/repos/mjura/barclamp-cinder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjura/barclamp-cinder/downloads","issues_url":"https://api.github.com/repos/mjura/barclamp-cinder/issues{/number}","pulls_url":"https://api.github.com/repos/mjura/barclamp-cinder/pulls{/number}","milestones_url":"https://api.github.com/repos/mjura/barclamp-cinder/milestones{/number}","notifications_url":"https://api.github.com/repos/mjura/barclamp-cinder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjura/barclamp-cinder/labels{/name}","releases_url":"https://api.github.com/repos/mjura/barclamp-cinder/releases{/id}","created_at":"2013-10-05T14:27:24Z","updated_at":"2014-06-16T14:01:16Z","pushed_at":"2015-03-27T12:52:02Z","git_url":"git://github.com/mjura/barclamp-cinder.git","ssh_url":"git@github.com:mjura/barclamp-cinder.git","clone_url":"https://github.com/mjura/barclamp-cinder.git","svn_url":"https://github.com/mjura/barclamp-cinder","homepage":"crowbar.github.io","size":1124,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"716524c4d37bb2b6cc327b42227bbf1c0e44d9e9","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":6161327,"name":"barclamp-cinder","full_name":"crowbar/barclamp-cinder","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/barclamp-cinder","description":"OpenStack Cinder: Block Storage component","fork":true,"url":"https://api.github.com/repos/crowbar/barclamp-cinder","forks_url":"https://api.github.com/repos/crowbar/barclamp-cinder/forks","keys_url":"https://api.github.com/repos/crowbar/barclamp-cinder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/barclamp-cinder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/barclamp-cinder/teams","hooks_url":"https://api.github.com/repos/crowbar/barclamp-cinder/hooks","issue_events_url":"https://api.github.com/repos/crowbar/barclamp-cinder/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/barclamp-cinder/events","assignees_url":"https://api.github.com/repos/crowbar/barclamp-cinder/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/barclamp-cinder/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/barclamp-cinder/tags","blobs_url":"https://api.github.com/repos/crowbar/barclamp-cinder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/barclamp-cinder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/barclamp-cinder/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/barclamp-cinder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/barclamp-cinder/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/barclamp-cinder/languages","stargazers_url":"https://api.github.com/repos/crowbar/barclamp-cinder/stargazers","contributors_url":"https://api.github.com/repos/crowbar/barclamp-cinder/contributors","subscribers_url":"https://api.github.com/repos/crowbar/barclamp-cinder/subscribers","subscription_url":"https://api.github.com/repos/crowbar/barclamp-cinder/subscription","commits_url":"https://api.github.com/repos/crowbar/barclamp-cinder/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/barclamp-cinder/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/barclamp-cinder/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/barclamp-cinder/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/barclamp-cinder/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/barclamp-cinder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/barclamp-cinder/merges","archive_url":"https://api.github.com/repos/crowbar/barclamp-cinder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/barclamp-cinder/downloads","issues_url":"https://api.github.com/repos/crowbar/barclamp-cinder/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/barclamp-cinder/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/barclamp-cinder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/barclamp-cinder/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/barclamp-cinder/releases{/id}","created_at":"2012-10-10T17:32:14Z","updated_at":"2015-03-23T14:03:18Z","pushed_at":"2015-03-28T00:50:33Z","git_url":"git://github.com/crowbar/barclamp-cinder.git","ssh_url":"git@github.com:crowbar/barclamp-cinder.git","clone_url":"https://github.com/crowbar/barclamp-cinder.git","svn_url":"https://github.com/crowbar/barclamp-cinder","homepage":"https://github.com/crowbar/crowbar","size":2768,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":146,"mirror_url":null,"open_issues_count":4,"forks":146,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls/246"},"html":{"href":"https://github.com/crowbar/barclamp-cinder/pull/246"},"issue":{"href":"https://api.github.com/repos/crowbar/barclamp-cinder/issues/246"},"comments":{"href":"https://api.github.com/repos/crowbar/barclamp-cinder/issues/246/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls/246/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls/246/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/barclamp-cinder/statuses/72042e40ce2919c25baa72ce951edb7a5218701b"}}}}