{"action":"opened","number":400,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/400","id":33292273,"html_url":"https://github.com/ansible/ansible-modules-extras/pull/400","diff_url":"https://github.com/ansible/ansible-modules-extras/pull/400.diff","patch_url":"https://github.com/ansible/ansible-modules-extras/pull/400.patch","issue_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/400","number":400,"state":"open","locked":false,"title":"Fix possible values for zfs sync property","user":{"login":"benalbrecht","id":3979281,"avatar_url":"https://avatars.githubusercontent.com/u/3979281?v=3","gravatar_id":"","url":"https://api.github.com/users/benalbrecht","html_url":"https://github.com/benalbrecht","followers_url":"https://api.github.com/users/benalbrecht/followers","following_url":"https://api.github.com/users/benalbrecht/following{/other_user}","gists_url":"https://api.github.com/users/benalbrecht/gists{/gist_id}","starred_url":"https://api.github.com/users/benalbrecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benalbrecht/subscriptions","organizations_url":"https://api.github.com/users/benalbrecht/orgs","repos_url":"https://api.github.com/users/benalbrecht/repos","events_url":"https://api.github.com/users/benalbrecht/events{/privacy}","received_events_url":"https://api.github.com/users/benalbrecht/received_events","type":"User","site_admin":false},"body":"##### Issue Type: \r\nBugfix Pull Request\r\n##### Ansible Version: \r\nansible 1.9.0.1\r\n##### Environment: \r\nDebian Jessie, FreeBSD\r\n##### Summary:\r\n\r\nThe permitted values for the ZFS Module  \"sync' property are not correct.\r\n\r\nfrom http://www.freebsd.org/cgi/man.cgi?zfs(8)\r\n```\r\n     sync=standard | always | disabled\r\n\t Controls the behavior of synchronous requests (e.g.  fsync(2),\r\n\t O_DSYNC). This\tproperty accepts the following values:\r\n\r\n\t     standard  This is the POSIX specified behavior of ensuring\tall\r\n\t\t       synchronous requests are\twritten\tto stable storage and\r\n\t\t       all devices are flushed to ensure data is not cached by\r\n\t\t       device controllers (this\tis the default).\r\n\r\n\t     always    All file\tsystem transactions are\twritten\tand flushed\r\n\t\t       before their system calls return. This has a large per-\r\n\t\t       formance\tpenalty.\r\n\r\n\t     disabled  Disables\tsynchronous requests. File system transactions\r\n\t\t       are only\tcommitted to stable storage periodically. This\r\n\t\t       option will give\tthe highest performance.  However, it\r\n\t\t       is very dangerous as ZFS\twould be ignoring the synchro-\r\n\t\t       nous transaction\tdemands\tof applications\tsuch as\tdata-\r\n\t\t       bases or\tNFS.  Administrators should only use this\r\n\t\t       option when the risks are understood.\r\n```\r\n##### Steps To Reproduce:\r\nRun the following task:\r\n```\r\n    - zfs: name='rpool/tmp' state=present sync='disabled'\r\n```\r\n##### Expected Results:\r\nThe 'sync' property of the ZFS filesystem should be set as 'disabled'.\r\n\r\n##### Actual Results:\r\nwhen setting 'sync' to 'disabled', there is an error message from ansible:\r\n```\r\nmsg: value of sync must be one of: on,off, got: disabled\r\n```\r\nwhen setting 'sync' to 'off', there is an error message from zfs:\r\n```\r\nmsg: cannot set property for 'rpool/tmp': 'sync' must be one of 'standard | always | disabled'\r\n```","created_at":"2015-04-14T19:40:31Z","updated_at":"2015-04-14T19:40:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/400/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/400/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/400/comments","statuses_url":"https://api.github.com/repos/ansible/ansible-modules-extras/statuses/658e7300ad966c16c1440da498d945c7d15539c8","head":{"label":"benalbrecht:devel","ref":"devel","sha":"658e7300ad966c16c1440da498d945c7d15539c8","user":{"login":"benalbrecht","id":3979281,"avatar_url":"https://avatars.githubusercontent.com/u/3979281?v=3","gravatar_id":"","url":"https://api.github.com/users/benalbrecht","html_url":"https://github.com/benalbrecht","followers_url":"https://api.github.com/users/benalbrecht/followers","following_url":"https://api.github.com/users/benalbrecht/following{/other_user}","gists_url":"https://api.github.com/users/benalbrecht/gists{/gist_id}","starred_url":"https://api.github.com/users/benalbrecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benalbrecht/subscriptions","organizations_url":"https://api.github.com/users/benalbrecht/orgs","repos_url":"https://api.github.com/users/benalbrecht/repos","events_url":"https://api.github.com/users/benalbrecht/events{/privacy}","received_events_url":"https://api.github.com/users/benalbrecht/received_events","type":"User","site_admin":false},"repo":{"id":33950542,"name":"ansible-modules-extras","full_name":"benalbrecht/ansible-modules-extras","owner":{"login":"benalbrecht","id":3979281,"avatar_url":"https://avatars.githubusercontent.com/u/3979281?v=3","gravatar_id":"","url":"https://api.github.com/users/benalbrecht","html_url":"https://github.com/benalbrecht","followers_url":"https://api.github.com/users/benalbrecht/followers","following_url":"https://api.github.com/users/benalbrecht/following{/other_user}","gists_url":"https://api.github.com/users/benalbrecht/gists{/gist_id}","starred_url":"https://api.github.com/users/benalbrecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benalbrecht/subscriptions","organizations_url":"https://api.github.com/users/benalbrecht/orgs","repos_url":"https://api.github.com/users/benalbrecht/repos","events_url":"https://api.github.com/users/benalbrecht/events{/privacy}","received_events_url":"https://api.github.com/users/benalbrecht/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benalbrecht/ansible-modules-extras","description":"Ansible extra modules - these modules ship with ansible","fork":true,"url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras","forks_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/forks","keys_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/teams","hooks_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/hooks","issue_events_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/issues/events{/number}","events_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/events","assignees_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/assignees{/user}","branches_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/branches{/branch}","tags_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/tags","blobs_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/languages","stargazers_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/stargazers","contributors_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/contributors","subscribers_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/subscribers","subscription_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/subscription","commits_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/contents/{+path}","compare_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/merges","archive_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/downloads","issues_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/issues{/number}","pulls_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/labels{/name}","releases_url":"https://api.github.com/repos/benalbrecht/ansible-modules-extras/releases{/id}","created_at":"2015-04-14T18:50:49Z","updated_at":"2015-04-14T19:24:12Z","pushed_at":"2015-04-14T19:24:12Z","git_url":"git://github.com/benalbrecht/ansible-modules-extras.git","ssh_url":"git@github.com:benalbrecht/ansible-modules-extras.git","clone_url":"https://github.com/benalbrecht/ansible-modules-extras.git","svn_url":"https://github.com/benalbrecht/ansible-modules-extras","homepage":"","size":15906,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"21c8266ebd45e4512ced84773129c6a017257e37","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":24474138,"name":"ansible-modules-extras","full_name":"ansible/ansible-modules-extras","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible-modules-extras","description":"Ansible extra modules - these modules ship with ansible","fork":false,"url":"https://api.github.com/repos/ansible/ansible-modules-extras","forks_url":"https://api.github.com/repos/ansible/ansible-modules-extras/forks","keys_url":"https://api.github.com/repos/ansible/ansible-modules-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible-modules-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible-modules-extras/teams","hooks_url":"https://api.github.com/repos/ansible/ansible-modules-extras/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible-modules-extras/events","assignees_url":"https://api.github.com/repos/ansible/ansible-modules-extras/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible-modules-extras/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible-modules-extras/tags","blobs_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible-modules-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible-modules-extras/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible-modules-extras/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible-modules-extras/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible-modules-extras/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible-modules-extras/subscription","commits_url":"https://api.github.com/repos/ansible/ansible-modules-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible-modules-extras/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible-modules-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible-modules-extras/merges","archive_url":"https://api.github.com/repos/ansible/ansible-modules-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible-modules-extras/downloads","issues_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible-modules-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible-modules-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible-modules-extras/releases{/id}","created_at":"2014-09-25T20:28:42Z","updated_at":"2015-04-14T18:03:49Z","pushed_at":"2015-04-14T17:18:55Z","git_url":"git://github.com/ansible/ansible-modules-extras.git","ssh_url":"git@github.com:ansible/ansible-modules-extras.git","clone_url":"https://github.com/ansible/ansible-modules-extras.git","svn_url":"https://github.com/ansible/ansible-modules-extras","homepage":"","size":15906,"stargazers_count":168,"watchers_count":168,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":374,"mirror_url":null,"open_issues_count":167,"forks":374,"open_issues":167,"watchers":168,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/400"},"html":{"href":"https://github.com/ansible/ansible-modules-extras/pull/400"},"issue":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/400"},"comments":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/400/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/400/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/400/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/statuses/658e7300ad966c16c1440da498d945c7d15539c8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}