{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/40113447","id":40113447,"diff_hunk":"@@ -134,6 +134,22 @@ in\n \n   config = {\n \n+    assertions = [\n+      { assertion =\n+          builtins.any (fs: [] != intersectLists (splitString \",\" fs.options)","path":"nixos/modules/tasks/filesystems.nix","position":null,"original_position":6,"commit_id":"5b3f0bef520056ac7a895bc751f65ff614428652","original_commit_id":"8b02e6226811ed2548b05ff6e5940a04100a9db6","user":{"login":"khumba","id":788813,"avatar_url":"https://avatars.githubusercontent.com/u/788813?v=3","gravatar_id":"","url":"https://api.github.com/users/khumba","html_url":"https://github.com/khumba","followers_url":"https://api.github.com/users/khumba/followers","following_url":"https://api.github.com/users/khumba/following{/other_user}","gists_url":"https://api.github.com/users/khumba/gists{/gist_id}","starred_url":"https://api.github.com/users/khumba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khumba/subscriptions","organizations_url":"https://api.github.com/users/khumba/orgs","repos_url":"https://api.github.com/users/khumba/repos","events_url":"https://api.github.com/users/khumba/events{/privacy}","received_events_url":"https://api.github.com/users/khumba/received_events","type":"User","site_admin":false},"body":"Oh right, because of the `with lib`.  Done.\n","created_at":"2015-09-22T17:09:04Z","updated_at":"2015-09-22T17:09:04Z","html_url":"https://github.com/NixOS/nixpkgs/pull/9998#discussion_r40113447","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/9998","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/40113447"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/9998#discussion_r40113447"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/9998"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/9998","id":45629175,"html_url":"https://github.com/NixOS/nixpkgs/pull/9998","diff_url":"https://github.com/NixOS/nixpkgs/pull/9998.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/9998.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/9998","number":9998,"state":"open","locked":false,"title":"nixos: make fstab owner/user/users mount options assert setuid mount/umount","user":{"login":"khumba","id":788813,"avatar_url":"https://avatars.githubusercontent.com/u/788813?v=3","gravatar_id":"","url":"https://api.github.com/users/khumba","html_url":"https://github.com/khumba","followers_url":"https://api.github.com/users/khumba/followers","following_url":"https://api.github.com/users/khumba/following{/other_user}","gists_url":"https://api.github.com/users/khumba/gists{/gist_id}","starred_url":"https://api.github.com/users/khumba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khumba/subscriptions","organizations_url":"https://api.github.com/users/khumba/orgs","repos_url":"https://api.github.com/users/khumba/repos","events_url":"https://api.github.com/users/khumba/events{/privacy}","received_events_url":"https://api.github.com/users/khumba/received_events","type":"User","site_admin":false},"body":"Otherwise, the fstab flags will be present, but the mounting abilities\r\nwon't be granted to non-root users.  Fixes #9848.","created_at":"2015-09-22T05:59:24Z","updated_at":"2015-09-22T17:09:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4430874f77f8852ff5160aaa566a04ea70e9eb17","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/9998/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/9998/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/9998/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/5b3f0bef520056ac7a895bc751f65ff614428652","head":{"label":"khumba:fstab-user-setuid-check","ref":"fstab-user-setuid-check","sha":"5b3f0bef520056ac7a895bc751f65ff614428652","user":{"login":"khumba","id":788813,"avatar_url":"https://avatars.githubusercontent.com/u/788813?v=3","gravatar_id":"","url":"https://api.github.com/users/khumba","html_url":"https://github.com/khumba","followers_url":"https://api.github.com/users/khumba/followers","following_url":"https://api.github.com/users/khumba/following{/other_user}","gists_url":"https://api.github.com/users/khumba/gists{/gist_id}","starred_url":"https://api.github.com/users/khumba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khumba/subscriptions","organizations_url":"https://api.github.com/users/khumba/orgs","repos_url":"https://api.github.com/users/khumba/repos","events_url":"https://api.github.com/users/khumba/events{/privacy}","received_events_url":"https://api.github.com/users/khumba/received_events","type":"User","site_admin":false},"repo":{"id":41442419,"name":"nixpkgs","full_name":"khumba/nixpkgs","owner":{"login":"khumba","id":788813,"avatar_url":"https://avatars.githubusercontent.com/u/788813?v=3","gravatar_id":"","url":"https://api.github.com/users/khumba","html_url":"https://github.com/khumba","followers_url":"https://api.github.com/users/khumba/followers","following_url":"https://api.github.com/users/khumba/following{/other_user}","gists_url":"https://api.github.com/users/khumba/gists{/gist_id}","starred_url":"https://api.github.com/users/khumba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khumba/subscriptions","organizations_url":"https://api.github.com/users/khumba/orgs","repos_url":"https://api.github.com/users/khumba/repos","events_url":"https://api.github.com/users/khumba/events{/privacy}","received_events_url":"https://api.github.com/users/khumba/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/khumba/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/khumba/nixpkgs","forks_url":"https://api.github.com/repos/khumba/nixpkgs/forks","keys_url":"https://api.github.com/repos/khumba/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khumba/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khumba/nixpkgs/teams","hooks_url":"https://api.github.com/repos/khumba/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/khumba/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/khumba/nixpkgs/events","assignees_url":"https://api.github.com/repos/khumba/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/khumba/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/khumba/nixpkgs/tags","blobs_url":"https://api.github.com/repos/khumba/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khumba/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khumba/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/khumba/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khumba/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/khumba/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/khumba/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/khumba/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/khumba/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/khumba/nixpkgs/subscription","commits_url":"https://api.github.com/repos/khumba/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/khumba/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/khumba/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/khumba/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/khumba/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/khumba/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khumba/nixpkgs/merges","archive_url":"https://api.github.com/repos/khumba/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khumba/nixpkgs/downloads","issues_url":"https://api.github.com/repos/khumba/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/khumba/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/khumba/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/khumba/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khumba/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/khumba/nixpkgs/releases{/id}","created_at":"2015-08-26T18:22:15Z","updated_at":"2015-08-26T18:22:33Z","pushed_at":"2015-09-22T17:08:52Z","git_url":"git://github.com/khumba/nixpkgs.git","ssh_url":"git@github.com:khumba/nixpkgs.git","clone_url":"https://github.com/khumba/nixpkgs.git","svn_url":"https://github.com/khumba/nixpkgs","homepage":null,"size":230613,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"2a574cb526a6f4daf750b914d4469092d7a6c3e4","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","created_at":"2012-06-04T02:49:46Z","updated_at":"2015-09-22T10:12:06Z","pushed_at":"2015-09-22T17:08:53Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":465181,"stargazers_count":787,"watchers_count":787,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":986,"mirror_url":null,"open_issues_count":950,"forks":986,"open_issues":950,"watchers":787,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/9998"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/9998"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/9998"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/9998/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/9998/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/9998/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/5b3f0bef520056ac7a895bc751f65ff614428652"}}}}