{"action":"created","comment":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/22772851","id":22772851,"diff_hunk":"@@ -92,6 +92,8 @@ has [qw(forwardedFor guestNodeMac)] => ( is => 'rw', );\n sub ACCEPT_CONTEXT {\n     my ( $self, $c, @args ) = @_;\n     my $class = ref $self || $self;\n+    my $previous_model = $c->session->{$class};\n+    return $previous_model if(defined($previous_model) && $previous_model->{options}->{in_uri_portal});","path":"html/captive-portal/lib/captiveportal/PacketFence/Model/Portal/Session.pm","position":5,"original_position":5,"commit_id":"b418a35baff8e38e43355a2f8631e804727b3c79","original_commit_id":"b418a35baff8e38e43355a2f8631e804727b3c79","user":{"login":"cgx","id":1088448,"avatar_url":"https://avatars.githubusercontent.com/u/1088448?v=3","gravatar_id":"","url":"https://api.github.com/users/cgx","html_url":"https://github.com/cgx","followers_url":"https://api.github.com/users/cgx/followers","following_url":"https://api.github.com/users/cgx/following{/other_user}","gists_url":"https://api.github.com/users/cgx/gists{/gist_id}","starred_url":"https://api.github.com/users/cgx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgx/subscriptions","organizations_url":"https://api.github.com/users/cgx/orgs","repos_url":"https://api.github.com/users/cgx/repos","events_url":"https://api.github.com/users/cgx/events{/privacy}","received_events_url":"https://api.github.com/users/cgx/received_events","type":"User","site_admin":false},"body":"How about simply testing for the existence of `last_uri` in `$previous_model->{options}` instead of adding another value to the _options_ hash?","created_at":"2015-01-12T01:18:43Z","updated_at":"2015-01-12T01:18:43Z","html_url":"https://github.com/inverse-inc/packetfence/pull/301#discussion_r22772851","pull_request_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/301","_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/22772851"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/301#discussion_r22772851"},"pull_request":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/301"}}},"pull_request":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/301","id":27120371,"html_url":"https://github.com/inverse-inc/packetfence/pull/301","diff_url":"https://github.com/inverse-inc/packetfence/pull/301.diff","patch_url":"https://github.com/inverse-inc/packetfence/pull/301.patch","issue_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/301","number":301,"state":"open","locked":false,"title":"fix portal uri profiles","user":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"body":"Once approved and merged, should hit the maintenance branch.\r\n\r\nDescription\r\n-----------\r\nFixes the URI portal profiles by caching the portal profile only when using a uri based portal profile.\r\nSwitching between two profiles is still working except when using the URI based filter\r\n\r\nImpacts\r\n-------\r\nFixes the URI portals. Doesn't break the current behavior\r\n\r\nDelete branch after merge\r\n-------------------------\r\nYes.","created_at":"2015-01-09T18:51:39Z","updated_at":"2015-01-12T01:18:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d338e326de8821170324ebfb209864e42f2e86c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/301/commits","review_comments_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/301/comments","review_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/{number}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/301/comments","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/b418a35baff8e38e43355a2f8631e804727b3c79","head":{"label":"julsemaan:fix/portal-uri","ref":"fix/portal-uri","sha":"b418a35baff8e38e43355a2f8631e804727b3c79","user":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"repo":{"id":9198603,"name":"packetfence","full_name":"julsemaan/packetfence","owner":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/julsemaan/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful guest management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":true,"url":"https://api.github.com/repos/julsemaan/packetfence","forks_url":"https://api.github.com/repos/julsemaan/packetfence/forks","keys_url":"https://api.github.com/repos/julsemaan/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julsemaan/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julsemaan/packetfence/teams","hooks_url":"https://api.github.com/repos/julsemaan/packetfence/hooks","issue_events_url":"https://api.github.com/repos/julsemaan/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/julsemaan/packetfence/events","assignees_url":"https://api.github.com/repos/julsemaan/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/julsemaan/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/julsemaan/packetfence/tags","blobs_url":"https://api.github.com/repos/julsemaan/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julsemaan/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julsemaan/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/julsemaan/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julsemaan/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/julsemaan/packetfence/languages","stargazers_url":"https://api.github.com/repos/julsemaan/packetfence/stargazers","contributors_url":"https://api.github.com/repos/julsemaan/packetfence/contributors","subscribers_url":"https://api.github.com/repos/julsemaan/packetfence/subscribers","subscription_url":"https://api.github.com/repos/julsemaan/packetfence/subscription","commits_url":"https://api.github.com/repos/julsemaan/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/julsemaan/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/julsemaan/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/julsemaan/packetfence/issues/comments/{number}","contents_url":"https://api.github.com/repos/julsemaan/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/julsemaan/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julsemaan/packetfence/merges","archive_url":"https://api.github.com/repos/julsemaan/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julsemaan/packetfence/downloads","issues_url":"https://api.github.com/repos/julsemaan/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/julsemaan/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/julsemaan/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/julsemaan/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julsemaan/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/julsemaan/packetfence/releases{/id}","created_at":"2013-04-03T15:52:51Z","updated_at":"2014-06-17T14:56:13Z","pushed_at":"2015-01-09T17:26:28Z","git_url":"git://github.com/julsemaan/packetfence.git","ssh_url":"git@github.com:julsemaan/packetfence.git","clone_url":"https://github.com/julsemaan/packetfence.git","svn_url":"https://github.com/julsemaan/packetfence","homepage":"http://www.packetfence.org","size":87331,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"stable"}},"base":{"label":"inverse-inc:devel","ref":"devel","sha":"e01d315976fb79aec407122efb5826d336e8e079","user":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":3595658,"name":"packetfence","full_name":"inverse-inc/packetfence","owner":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inverse-inc/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful guest management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":false,"url":"https://api.github.com/repos/inverse-inc/packetfence","forks_url":"https://api.github.com/repos/inverse-inc/packetfence/forks","keys_url":"https://api.github.com/repos/inverse-inc/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inverse-inc/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inverse-inc/packetfence/teams","hooks_url":"https://api.github.com/repos/inverse-inc/packetfence/hooks","issue_events_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/inverse-inc/packetfence/events","assignees_url":"https://api.github.com/repos/inverse-inc/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/inverse-inc/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/inverse-inc/packetfence/tags","blobs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inverse-inc/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/inverse-inc/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/inverse-inc/packetfence/languages","stargazers_url":"https://api.github.com/repos/inverse-inc/packetfence/stargazers","contributors_url":"https://api.github.com/repos/inverse-inc/packetfence/contributors","subscribers_url":"https://api.github.com/repos/inverse-inc/packetfence/subscribers","subscription_url":"https://api.github.com/repos/inverse-inc/packetfence/subscription","commits_url":"https://api.github.com/repos/inverse-inc/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/inverse-inc/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/comments/{number}","contents_url":"https://api.github.com/repos/inverse-inc/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/inverse-inc/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inverse-inc/packetfence/merges","archive_url":"https://api.github.com/repos/inverse-inc/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inverse-inc/packetfence/downloads","issues_url":"https://api.github.com/repos/inverse-inc/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/inverse-inc/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/inverse-inc/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inverse-inc/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/inverse-inc/packetfence/releases{/id}","created_at":"2012-03-01T20:21:13Z","updated_at":"2015-01-11T16:34:43Z","pushed_at":"2015-01-11T23:09:34Z","git_url":"git://github.com/inverse-inc/packetfence.git","ssh_url":"git@github.com:inverse-inc/packetfence.git","clone_url":"https://github.com/inverse-inc/packetfence.git","svn_url":"https://github.com/inverse-inc/packetfence","homepage":"http://www.packetfence.org","size":103732,"stargazers_count":99,"watchers_count":99,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":27,"forks":54,"open_issues":27,"watchers":99,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/301"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/301"},"issue":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/301"},"comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/301/comments"},"review_comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/301/comments"},"review_comment":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/301/commits"},"statuses":{"href":"https://api.github.com/repos/inverse-inc/packetfence/statuses/b418a35baff8e38e43355a2f8631e804727b3c79"}}}}