{"action":"opened","number":13,"pull_request":{"url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/pulls/13","id":34387072,"html_url":"https://github.com/mtlynch/mlab-ns-staging/pull/13","diff_url":"https://github.com/mtlynch/mlab-ns-staging/pull/13.diff","patch_url":"https://github.com/mtlynch/mlab-ns-staging/pull/13.patch","issue_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/issues/13","number":13,"state":"open","locked":false,"title":"Rewrite of test_lookup_query and slight refactoring of LookupQuery.","user":{"login":"mtlynch","id":7783288,"avatar_url":"https://avatars.githubusercontent.com/u/7783288?v=3","gravatar_id":"","url":"https://api.github.com/users/mtlynch","html_url":"https://github.com/mtlynch","followers_url":"https://api.github.com/users/mtlynch/followers","following_url":"https://api.github.com/users/mtlynch/following{/other_user}","gists_url":"https://api.github.com/users/mtlynch/gists{/gist_id}","starred_url":"https://api.github.com/users/mtlynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtlynch/subscriptions","organizations_url":"https://api.github.com/users/mtlynch/orgs","repos_url":"https://api.github.com/users/mtlynch/repos","events_url":"https://api.github.com/users/mtlynch/events{/privacy}","received_events_url":"https://api.github.com/users/mtlynch/received_events","type":"User","site_admin":false},"body":"This change refactors LookupQuery to make private the methods and\r\nproperties that are not referenced outside of the class itself (or the\r\ntest code). LookupQuery only needs to expose\r\ninitialize_from_http_request, so the rest of its methods are now\r\nprivate.\r\n\r\nThis change includes a complete rewrite of test_lookup_query so that\r\nit's only testing LookupQuery's public interface instead of its private\r\nmethods.\r\n\r\nIn the process of rewriting the test suite, I identified some bugs in\r\nLookupQuery and also reduced some of the logging messages, because it\r\nwas firing warnings when optional fields were not set (the warnings\r\nshould only fire for non-optional fields or when an invalid option is\r\nspecified). I fixed a couple small bugs in this CL, but I left a few\r\nTODOs in the test code for additional fixes I plan to make in a\r\nsubsequent CL.","created_at":"2015-04-29T17:38:17Z","updated_at":"2015-04-29T17:38:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/pulls/13/commits","review_comments_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/pulls/13/comments","review_comment_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/issues/13/comments","statuses_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/statuses/70429a122f852c32fabf4e391e5e89d780a0f862","head":{"label":"mtlynch:encapsulate-lookup-query","ref":"encapsulate-lookup-query","sha":"70429a122f852c32fabf4e391e5e89d780a0f862","user":{"login":"mtlynch","id":7783288,"avatar_url":"https://avatars.githubusercontent.com/u/7783288?v=3","gravatar_id":"","url":"https://api.github.com/users/mtlynch","html_url":"https://github.com/mtlynch","followers_url":"https://api.github.com/users/mtlynch/followers","following_url":"https://api.github.com/users/mtlynch/following{/other_user}","gists_url":"https://api.github.com/users/mtlynch/gists{/gist_id}","starred_url":"https://api.github.com/users/mtlynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtlynch/subscriptions","organizations_url":"https://api.github.com/users/mtlynch/orgs","repos_url":"https://api.github.com/users/mtlynch/repos","events_url":"https://api.github.com/users/mtlynch/events{/privacy}","received_events_url":"https://api.github.com/users/mtlynch/received_events","type":"User","site_admin":false},"repo":{"id":34268803,"name":"mlab-ns-staging","full_name":"mtlynch/mlab-ns-staging","owner":{"login":"mtlynch","id":7783288,"avatar_url":"https://avatars.githubusercontent.com/u/7783288?v=3","gravatar_id":"","url":"https://api.github.com/users/mtlynch","html_url":"https://github.com/mtlynch","followers_url":"https://api.github.com/users/mtlynch/followers","following_url":"https://api.github.com/users/mtlynch/following{/other_user}","gists_url":"https://api.github.com/users/mtlynch/gists{/gist_id}","starred_url":"https://api.github.com/users/mtlynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtlynch/subscriptions","organizations_url":"https://api.github.com/users/mtlynch/orgs","repos_url":"https://api.github.com/users/mtlynch/repos","events_url":"https://api.github.com/users/mtlynch/events{/privacy}","received_events_url":"https://api.github.com/users/mtlynch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mtlynch/mlab-ns-staging","description":"","fork":false,"url":"https://api.github.com/repos/mtlynch/mlab-ns-staging","forks_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/forks","keys_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/teams","hooks_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/hooks","issue_events_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/issues/events{/number}","events_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/events","assignees_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/assignees{/user}","branches_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/branches{/branch}","tags_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/tags","blobs_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/statuses/{sha}","languages_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/languages","stargazers_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/stargazers","contributors_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/contributors","subscribers_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/subscribers","subscription_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/subscription","commits_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/issues/comments{/number}","contents_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/contents/{+path}","compare_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/merges","archive_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/downloads","issues_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/issues{/number}","pulls_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/pulls{/number}","milestones_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/milestones{/number}","notifications_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/labels{/name}","releases_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/releases{/id}","created_at":"2015-04-20T15:28:25Z","updated_at":"2015-04-28T20:28:39Z","pushed_at":"2015-04-29T17:36:12Z","git_url":"git://github.com/mtlynch/mlab-ns-staging.git","ssh_url":"git@github.com:mtlynch/mlab-ns-staging.git","clone_url":"https://github.com/mtlynch/mlab-ns-staging.git","svn_url":"https://github.com/mtlynch/mlab-ns-staging","homepage":null,"size":24768,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mtlynch:master","ref":"master","sha":"e0d53ab43ce0d0a77db2c28064abf2010d5c07a7","user":{"login":"mtlynch","id":7783288,"avatar_url":"https://avatars.githubusercontent.com/u/7783288?v=3","gravatar_id":"","url":"https://api.github.com/users/mtlynch","html_url":"https://github.com/mtlynch","followers_url":"https://api.github.com/users/mtlynch/followers","following_url":"https://api.github.com/users/mtlynch/following{/other_user}","gists_url":"https://api.github.com/users/mtlynch/gists{/gist_id}","starred_url":"https://api.github.com/users/mtlynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtlynch/subscriptions","organizations_url":"https://api.github.com/users/mtlynch/orgs","repos_url":"https://api.github.com/users/mtlynch/repos","events_url":"https://api.github.com/users/mtlynch/events{/privacy}","received_events_url":"https://api.github.com/users/mtlynch/received_events","type":"User","site_admin":false},"repo":{"id":34268803,"name":"mlab-ns-staging","full_name":"mtlynch/mlab-ns-staging","owner":{"login":"mtlynch","id":7783288,"avatar_url":"https://avatars.githubusercontent.com/u/7783288?v=3","gravatar_id":"","url":"https://api.github.com/users/mtlynch","html_url":"https://github.com/mtlynch","followers_url":"https://api.github.com/users/mtlynch/followers","following_url":"https://api.github.com/users/mtlynch/following{/other_user}","gists_url":"https://api.github.com/users/mtlynch/gists{/gist_id}","starred_url":"https://api.github.com/users/mtlynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtlynch/subscriptions","organizations_url":"https://api.github.com/users/mtlynch/orgs","repos_url":"https://api.github.com/users/mtlynch/repos","events_url":"https://api.github.com/users/mtlynch/events{/privacy}","received_events_url":"https://api.github.com/users/mtlynch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mtlynch/mlab-ns-staging","description":"","fork":false,"url":"https://api.github.com/repos/mtlynch/mlab-ns-staging","forks_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/forks","keys_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/teams","hooks_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/hooks","issue_events_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/issues/events{/number}","events_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/events","assignees_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/assignees{/user}","branches_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/branches{/branch}","tags_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/tags","blobs_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/statuses/{sha}","languages_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/languages","stargazers_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/stargazers","contributors_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/contributors","subscribers_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/subscribers","subscription_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/subscription","commits_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/issues/comments{/number}","contents_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/contents/{+path}","compare_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/merges","archive_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/downloads","issues_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/issues{/number}","pulls_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/pulls{/number}","milestones_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/milestones{/number}","notifications_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/labels{/name}","releases_url":"https://api.github.com/repos/mtlynch/mlab-ns-staging/releases{/id}","created_at":"2015-04-20T15:28:25Z","updated_at":"2015-04-28T20:28:39Z","pushed_at":"2015-04-29T17:36:12Z","git_url":"git://github.com/mtlynch/mlab-ns-staging.git","ssh_url":"git@github.com:mtlynch/mlab-ns-staging.git","clone_url":"https://github.com/mtlynch/mlab-ns-staging.git","svn_url":"https://github.com/mtlynch/mlab-ns-staging","homepage":null,"size":24768,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mtlynch/mlab-ns-staging/pulls/13"},"html":{"href":"https://github.com/mtlynch/mlab-ns-staging/pull/13"},"issue":{"href":"https://api.github.com/repos/mtlynch/mlab-ns-staging/issues/13"},"comments":{"href":"https://api.github.com/repos/mtlynch/mlab-ns-staging/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/mtlynch/mlab-ns-staging/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/mtlynch/mlab-ns-staging/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mtlynch/mlab-ns-staging/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/mtlynch/mlab-ns-staging/statuses/70429a122f852c32fabf4e391e5e89d780a0f862"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":471,"deletions":602,"changed_files":4}}