{"action":"closed","number":92,"pull_request":{"url":"https://api.github.com/repos/airbnb/synapse/pulls/92","id":20766201,"html_url":"https://github.com/airbnb/synapse/pull/92","diff_url":"https://github.com/airbnb/synapse/pull/92.diff","patch_url":"https://github.com/airbnb/synapse/pull/92.patch","issue_url":"https://api.github.com/repos/airbnb/synapse/issues/92","number":92,"state":"closed","locked":false,"title":"Filter out containers with unmapped ports","user":{"login":"cap10morgan","id":59748,"avatar_url":"https://avatars.githubusercontent.com/u/59748?v=3","gravatar_id":"","url":"https://api.github.com/users/cap10morgan","html_url":"https://github.com/cap10morgan","followers_url":"https://api.github.com/users/cap10morgan/followers","following_url":"https://api.github.com/users/cap10morgan/following{/other_user}","gists_url":"https://api.github.com/users/cap10morgan/gists{/gist_id}","starred_url":"https://api.github.com/users/cap10morgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cap10morgan/subscriptions","organizations_url":"https://api.github.com/users/cap10morgan/orgs","repos_url":"https://api.github.com/users/cap10morgan/repos","events_url":"https://api.github.com/users/cap10morgan/events{/privacy}","received_events_url":"https://api.github.com/users/cap10morgan/received_events","type":"User","site_admin":false},"body":"This bit us when running one-off containers on our docker hosts (to run scripts, debug problems, etc.). Synapse would pick up the container because the image name and the private port matched, but the missing public port would cause it to generate an invalid haproxy config file and crash.\r\n\r\nThis fixes that by adding a simple check that the public port is present when deciding which containers to consider adding as backends.\r\n\r\nIt only does this for new-style port mappings because I can't find any docs on what the old-style port mappings looked like in this situation, nor is it clear that you could even prevent an exposed port from being mapped back when that version of the remote API was in use.","created_at":"2014-09-04T19:18:31Z","updated_at":"2015-11-30T18:25:53Z","closed_at":"2015-11-30T18:25:53Z","merged_at":"2015-11-30T18:25:53Z","merge_commit_sha":"ab55dab5b23a66830f25f159604b735f4e8d17cf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/airbnb/synapse/pulls/92/commits","review_comments_url":"https://api.github.com/repos/airbnb/synapse/pulls/92/comments","review_comment_url":"https://api.github.com/repos/airbnb/synapse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airbnb/synapse/issues/92/comments","statuses_url":"https://api.github.com/repos/airbnb/synapse/statuses/5ef97f0d05d1c860cc38791d6c2780644619a445","head":{"label":"democracyworks:filter-out-containers-with-unmapped-ports","ref":"filter-out-containers-with-unmapped-ports","sha":"5ef97f0d05d1c860cc38791d6c2780644619a445","user":{"login":"democracyworks","id":1373557,"avatar_url":"https://avatars.githubusercontent.com/u/1373557?v=3","gravatar_id":"","url":"https://api.github.com/users/democracyworks","html_url":"https://github.com/democracyworks","followers_url":"https://api.github.com/users/democracyworks/followers","following_url":"https://api.github.com/users/democracyworks/following{/other_user}","gists_url":"https://api.github.com/users/democracyworks/gists{/gist_id}","starred_url":"https://api.github.com/users/democracyworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/democracyworks/subscriptions","organizations_url":"https://api.github.com/users/democracyworks/orgs","repos_url":"https://api.github.com/users/democracyworks/repos","events_url":"https://api.github.com/users/democracyworks/events{/privacy}","received_events_url":"https://api.github.com/users/democracyworks/received_events","type":"Organization","site_admin":false},"repo":{"id":17756131,"name":"synapse","full_name":"democracyworks/synapse","owner":{"login":"democracyworks","id":1373557,"avatar_url":"https://avatars.githubusercontent.com/u/1373557?v=3","gravatar_id":"","url":"https://api.github.com/users/democracyworks","html_url":"https://github.com/democracyworks","followers_url":"https://api.github.com/users/democracyworks/followers","following_url":"https://api.github.com/users/democracyworks/following{/other_user}","gists_url":"https://api.github.com/users/democracyworks/gists{/gist_id}","starred_url":"https://api.github.com/users/democracyworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/democracyworks/subscriptions","organizations_url":"https://api.github.com/users/democracyworks/orgs","repos_url":"https://api.github.com/users/democracyworks/repos","events_url":"https://api.github.com/users/democracyworks/events{/privacy}","received_events_url":"https://api.github.com/users/democracyworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/democracyworks/synapse","description":"A transparent service discovery framework for connecting an SOA","fork":true,"url":"https://api.github.com/repos/democracyworks/synapse","forks_url":"https://api.github.com/repos/democracyworks/synapse/forks","keys_url":"https://api.github.com/repos/democracyworks/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/democracyworks/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/democracyworks/synapse/teams","hooks_url":"https://api.github.com/repos/democracyworks/synapse/hooks","issue_events_url":"https://api.github.com/repos/democracyworks/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/democracyworks/synapse/events","assignees_url":"https://api.github.com/repos/democracyworks/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/democracyworks/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/democracyworks/synapse/tags","blobs_url":"https://api.github.com/repos/democracyworks/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/democracyworks/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/democracyworks/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/democracyworks/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/democracyworks/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/democracyworks/synapse/languages","stargazers_url":"https://api.github.com/repos/democracyworks/synapse/stargazers","contributors_url":"https://api.github.com/repos/democracyworks/synapse/contributors","subscribers_url":"https://api.github.com/repos/democracyworks/synapse/subscribers","subscription_url":"https://api.github.com/repos/democracyworks/synapse/subscription","commits_url":"https://api.github.com/repos/democracyworks/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/democracyworks/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/democracyworks/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/democracyworks/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/democracyworks/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/democracyworks/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/democracyworks/synapse/merges","archive_url":"https://api.github.com/repos/democracyworks/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/democracyworks/synapse/downloads","issues_url":"https://api.github.com/repos/democracyworks/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/democracyworks/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/democracyworks/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/democracyworks/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/democracyworks/synapse/labels{/name}","releases_url":"https://api.github.com/repos/democracyworks/synapse/releases{/id}","created_at":"2014-03-14T18:34:38Z","updated_at":"2014-08-22T15:26:12Z","pushed_at":"2015-11-30T18:20:47Z","git_url":"git://github.com/democracyworks/synapse.git","ssh_url":"git@github.com:democracyworks/synapse.git","clone_url":"https://github.com/democracyworks/synapse.git","svn_url":"https://github.com/democracyworks/synapse","homepage":"","size":354,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"airbnb:master","ref":"master","sha":"a1cfd34916388ba1baa7d35e5fd40bde15aa20f7","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":6607851,"name":"synapse","full_name":"airbnb/synapse","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/synapse","description":"A transparent service discovery framework for connecting an SOA","fork":false,"url":"https://api.github.com/repos/airbnb/synapse","forks_url":"https://api.github.com/repos/airbnb/synapse/forks","keys_url":"https://api.github.com/repos/airbnb/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/synapse/teams","hooks_url":"https://api.github.com/repos/airbnb/synapse/hooks","issue_events_url":"https://api.github.com/repos/airbnb/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/synapse/events","assignees_url":"https://api.github.com/repos/airbnb/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/synapse/tags","blobs_url":"https://api.github.com/repos/airbnb/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/synapse/languages","stargazers_url":"https://api.github.com/repos/airbnb/synapse/stargazers","contributors_url":"https://api.github.com/repos/airbnb/synapse/contributors","subscribers_url":"https://api.github.com/repos/airbnb/synapse/subscribers","subscription_url":"https://api.github.com/repos/airbnb/synapse/subscription","commits_url":"https://api.github.com/repos/airbnb/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/synapse/merges","archive_url":"https://api.github.com/repos/airbnb/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/synapse/downloads","issues_url":"https://api.github.com/repos/airbnb/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/synapse/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/synapse/releases{/id}","created_at":"2012-11-09T03:03:06Z","updated_at":"2015-11-29T01:55:31Z","pushed_at":"2015-11-30T18:25:54Z","git_url":"git://github.com/airbnb/synapse.git","ssh_url":"git@github.com:airbnb/synapse.git","clone_url":"https://github.com/airbnb/synapse.git","svn_url":"https://github.com/airbnb/synapse","homepage":"","size":585,"stargazers_count":1172,"watchers_count":1172,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"open_issues_count":34,"forks":150,"open_issues":34,"watchers":1172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airbnb/synapse/pulls/92"},"html":{"href":"https://github.com/airbnb/synapse/pull/92"},"issue":{"href":"https://api.github.com/repos/airbnb/synapse/issues/92"},"comments":{"href":"https://api.github.com/repos/airbnb/synapse/issues/92/comments"},"review_comments":{"href":"https://api.github.com/repos/airbnb/synapse/pulls/92/comments"},"review_comment":{"href":"https://api.github.com/repos/airbnb/synapse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airbnb/synapse/pulls/92/commits"},"statuses":{"href":"https://api.github.com/repos/airbnb/synapse/statuses/5ef97f0d05d1c860cc38791d6c2780644619a445"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jolynch","id":1420460,"avatar_url":"https://avatars.githubusercontent.com/u/1420460?v=3","gravatar_id":"","url":"https://api.github.com/users/jolynch","html_url":"https://github.com/jolynch","followers_url":"https://api.github.com/users/jolynch/followers","following_url":"https://api.github.com/users/jolynch/following{/other_user}","gists_url":"https://api.github.com/users/jolynch/gists{/gist_id}","starred_url":"https://api.github.com/users/jolynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolynch/subscriptions","organizations_url":"https://api.github.com/users/jolynch/orgs","repos_url":"https://api.github.com/users/jolynch/repos","events_url":"https://api.github.com/users/jolynch/events{/privacy}","received_events_url":"https://api.github.com/users/jolynch/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":11,"deletions":5,"changed_files":2}}