{"action":"created","comment":{"url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/pulls/comments/25997864","id":25997864,"diff_hunk":"@@ -194,10 +258,6 @@ protected void onActivityResult(int requestCode, int resultCode, Intent data) {\n   protected void onResume() {\n     super.onResume();\n \n-    mAdvStatus = (TextView) findViewById(R.id.textView_advertisingStatus);","path":"app/src/main/java/io/github/webbluetoothcg/bletestperipheral/Peripherals.java","position":99,"original_position":99,"commit_id":"ec509f9c37e0db6799d8bb2205530071010455f9","original_commit_id":"ec509f9c37e0db6799d8bb2205530071010455f9","user":{"login":"g-ortuno","id":3117611,"avatar_url":"https://avatars.githubusercontent.com/u/3117611?v=3","gravatar_id":"","url":"https://api.github.com/users/g-ortuno","html_url":"https://github.com/g-ortuno","followers_url":"https://api.github.com/users/g-ortuno/followers","following_url":"https://api.github.com/users/g-ortuno/following{/other_user}","gists_url":"https://api.github.com/users/g-ortuno/gists{/gist_id}","starred_url":"https://api.github.com/users/g-ortuno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-ortuno/subscriptions","organizations_url":"https://api.github.com/users/g-ortuno/orgs","repos_url":"https://api.github.com/users/g-ortuno/repos","events_url":"https://api.github.com/users/g-ortuno/events{/privacy}","received_events_url":"https://api.github.com/users/g-ortuno/received_events","type":"User","site_admin":false},"body":"`onResume()` calls `startGattServer()` which calls `createBatteryService()` which [updates the UI](https://github.com/WebBluetoothCG/ble-test-peripheral-android/pull/11/files#diff-c85779f88d71c930bc74f9e899df15ffR330). But I admit that this flow is not clear at all. I have a couple of ideas that will clean this up in the next CL which will be a refactor CL.","created_at":"2015-03-07T17:55:47Z","updated_at":"2015-03-07T17:55:47Z","html_url":"https://github.com/WebBluetoothCG/ble-test-peripheral-android/pull/11#discussion_r25997864","pull_request_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/pulls/comments/25997864"},"html":{"href":"https://github.com/WebBluetoothCG/ble-test-peripheral-android/pull/11#discussion_r25997864"},"pull_request":{"href":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/pulls/11","id":30696157,"html_url":"https://github.com/WebBluetoothCG/ble-test-peripheral-android/pull/11","diff_url":"https://github.com/WebBluetoothCG/ble-test-peripheral-android/pull/11.diff","patch_url":"https://github.com/WebBluetoothCG/ble-test-peripheral-android/pull/11.patch","issue_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/issues/11","number":11,"state":"open","locked":false,"title":"Backend for Battery Level","user":{"login":"g-ortuno","id":3117611,"avatar_url":"https://avatars.githubusercontent.com/u/3117611?v=3","gravatar_id":"","url":"https://api.github.com/users/g-ortuno","html_url":"https://github.com/g-ortuno","followers_url":"https://api.github.com/users/g-ortuno/followers","following_url":"https://api.github.com/users/g-ortuno/following{/other_user}","gists_url":"https://api.github.com/users/g-ortuno/gists{/gist_id}","starred_url":"https://api.github.com/users/g-ortuno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-ortuno/subscriptions","organizations_url":"https://api.github.com/users/g-ortuno/orgs","repos_url":"https://api.github.com/users/g-ortuno/repos","events_url":"https://api.github.com/users/g-ortuno/events{/privacy}","received_events_url":"https://api.github.com/users/g-ortuno/received_events","type":"User","site_admin":false},"body":"Please review @jyasskin @scheib \r\n\r\n![demo](https://cloud.githubusercontent.com/assets/3117611/6539799/f156db76-c433-11e4-853a-f45c32fc1c4e.gif)\r\n","created_at":"2015-03-07T03:08:20Z","updated_at":"2015-03-07T17:55:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f14420d23d7f839d2526db197a18525711401bbc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/pulls/11/commits","review_comments_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/pulls/11/comments","review_comment_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/issues/11/comments","statuses_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/statuses/ec509f9c37e0db6799d8bb2205530071010455f9","head":{"label":"g-ortuno:battery-level-backend","ref":"battery-level-backend","sha":"ec509f9c37e0db6799d8bb2205530071010455f9","user":{"login":"g-ortuno","id":3117611,"avatar_url":"https://avatars.githubusercontent.com/u/3117611?v=3","gravatar_id":"","url":"https://api.github.com/users/g-ortuno","html_url":"https://github.com/g-ortuno","followers_url":"https://api.github.com/users/g-ortuno/followers","following_url":"https://api.github.com/users/g-ortuno/following{/other_user}","gists_url":"https://api.github.com/users/g-ortuno/gists{/gist_id}","starred_url":"https://api.github.com/users/g-ortuno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-ortuno/subscriptions","organizations_url":"https://api.github.com/users/g-ortuno/orgs","repos_url":"https://api.github.com/users/g-ortuno/repos","events_url":"https://api.github.com/users/g-ortuno/events{/privacy}","received_events_url":"https://api.github.com/users/g-ortuno/received_events","type":"User","site_admin":false},"repo":{"id":31574255,"name":"ble-test-peripheral-android","full_name":"g-ortuno/ble-test-peripheral-android","owner":{"login":"g-ortuno","id":3117611,"avatar_url":"https://avatars.githubusercontent.com/u/3117611?v=3","gravatar_id":"","url":"https://api.github.com/users/g-ortuno","html_url":"https://github.com/g-ortuno","followers_url":"https://api.github.com/users/g-ortuno/followers","following_url":"https://api.github.com/users/g-ortuno/following{/other_user}","gists_url":"https://api.github.com/users/g-ortuno/gists{/gist_id}","starred_url":"https://api.github.com/users/g-ortuno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-ortuno/subscriptions","organizations_url":"https://api.github.com/users/g-ortuno/orgs","repos_url":"https://api.github.com/users/g-ortuno/repos","events_url":"https://api.github.com/users/g-ortuno/events{/privacy}","received_events_url":"https://api.github.com/users/g-ortuno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/g-ortuno/ble-test-peripheral-android","description":"","fork":true,"url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android","forks_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/forks","keys_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/teams","hooks_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/hooks","issue_events_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/issues/events{/number}","events_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/events","assignees_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/assignees{/user}","branches_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/branches{/branch}","tags_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/tags","blobs_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/statuses/{sha}","languages_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/languages","stargazers_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/stargazers","contributors_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/contributors","subscribers_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/subscribers","subscription_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/subscription","commits_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/contents/{+path}","compare_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/merges","archive_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/downloads","issues_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/issues{/number}","pulls_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/pulls{/number}","milestones_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/milestones{/number}","notifications_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/labels{/name}","releases_url":"https://api.github.com/repos/g-ortuno/ble-test-peripheral-android/releases{/id}","created_at":"2015-03-03T02:01:48Z","updated_at":"2015-03-06T00:37:05Z","pushed_at":"2015-03-07T02:59:22Z","git_url":"git://github.com/g-ortuno/ble-test-peripheral-android.git","ssh_url":"git@github.com:g-ortuno/ble-test-peripheral-android.git","clone_url":"https://github.com/g-ortuno/ble-test-peripheral-android.git","svn_url":"https://github.com/g-ortuno/ble-test-peripheral-android","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WebBluetoothCG:master","ref":"master","sha":"132cd6e2df3952fa7eda0964243b60cde899afe6","user":{"login":"WebBluetoothCG","id":8389284,"avatar_url":"https://avatars.githubusercontent.com/u/8389284?v=3","gravatar_id":"","url":"https://api.github.com/users/WebBluetoothCG","html_url":"https://github.com/WebBluetoothCG","followers_url":"https://api.github.com/users/WebBluetoothCG/followers","following_url":"https://api.github.com/users/WebBluetoothCG/following{/other_user}","gists_url":"https://api.github.com/users/WebBluetoothCG/gists{/gist_id}","starred_url":"https://api.github.com/users/WebBluetoothCG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebBluetoothCG/subscriptions","organizations_url":"https://api.github.com/users/WebBluetoothCG/orgs","repos_url":"https://api.github.com/users/WebBluetoothCG/repos","events_url":"https://api.github.com/users/WebBluetoothCG/events{/privacy}","received_events_url":"https://api.github.com/users/WebBluetoothCG/received_events","type":"Organization","site_admin":false},"repo":{"id":31573151,"name":"ble-test-peripheral-android","full_name":"WebBluetoothCG/ble-test-peripheral-android","owner":{"login":"WebBluetoothCG","id":8389284,"avatar_url":"https://avatars.githubusercontent.com/u/8389284?v=3","gravatar_id":"","url":"https://api.github.com/users/WebBluetoothCG","html_url":"https://github.com/WebBluetoothCG","followers_url":"https://api.github.com/users/WebBluetoothCG/followers","following_url":"https://api.github.com/users/WebBluetoothCG/following{/other_user}","gists_url":"https://api.github.com/users/WebBluetoothCG/gists{/gist_id}","starred_url":"https://api.github.com/users/WebBluetoothCG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebBluetoothCG/subscriptions","organizations_url":"https://api.github.com/users/WebBluetoothCG/orgs","repos_url":"https://api.github.com/users/WebBluetoothCG/repos","events_url":"https://api.github.com/users/WebBluetoothCG/events{/privacy}","received_events_url":"https://api.github.com/users/WebBluetoothCG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebBluetoothCG/ble-test-peripheral-android","description":"","fork":false,"url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android","forks_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/forks","keys_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/teams","hooks_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/hooks","issue_events_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/issues/events{/number}","events_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/events","assignees_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/assignees{/user}","branches_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/branches{/branch}","tags_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/tags","blobs_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/statuses/{sha}","languages_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/languages","stargazers_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/stargazers","contributors_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/contributors","subscribers_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/subscribers","subscription_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/subscription","commits_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/contents/{+path}","compare_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/merges","archive_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/downloads","issues_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/issues{/number}","pulls_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/pulls{/number}","milestones_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/milestones{/number}","notifications_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/labels{/name}","releases_url":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/releases{/id}","created_at":"2015-03-03T01:30:48Z","updated_at":"2015-03-07T00:32:21Z","pushed_at":"2015-03-07T00:32:21Z","git_url":"git://github.com/WebBluetoothCG/ble-test-peripheral-android.git","ssh_url":"git@github.com:WebBluetoothCG/ble-test-peripheral-android.git","clone_url":"https://github.com/WebBluetoothCG/ble-test-peripheral-android.git","svn_url":"https://github.com/WebBluetoothCG/ble-test-peripheral-android","homepage":null,"size":0,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/pulls/11"},"html":{"href":"https://github.com/WebBluetoothCG/ble-test-peripheral-android/pull/11"},"issue":{"href":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/issues/11"},"comments":{"href":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/WebBluetoothCG/ble-test-peripheral-android/statuses/ec509f9c37e0db6799d8bb2205530071010455f9"}}}}