{"action":"created","issue":{"url":"https://api.github.com/repos/twitter/finagle/issues/352","labels_url":"https://api.github.com/repos/twitter/finagle/issues/352/labels{/name}","comments_url":"https://api.github.com/repos/twitter/finagle/issues/352/comments","events_url":"https://api.github.com/repos/twitter/finagle/issues/352/events","html_url":"https://github.com/twitter/finagle/pull/352","id":63503303,"number":352,"title":"Made RetryingFilter extendable.","user":{"login":"spockz","id":54579,"avatar_url":"https://avatars.githubusercontent.com/u/54579?v=3","gravatar_id":"","url":"https://api.github.com/users/spockz","html_url":"https://github.com/spockz","followers_url":"https://api.github.com/users/spockz/followers","following_url":"https://api.github.com/users/spockz/following{/other_user}","gists_url":"https://api.github.com/users/spockz/gists{/gist_id}","starred_url":"https://api.github.com/users/spockz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spockz/subscriptions","organizations_url":"https://api.github.com/users/spockz/orgs","repos_url":"https://api.github.com/users/spockz/repos","events_url":"https://api.github.com/users/spockz/events{/privacy}","received_events_url":"https://api.github.com/users/spockz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-22T07:35:03Z","updated_at":"2015-03-22T19:17:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/twitter/finagle/pulls/352","html_url":"https://github.com/twitter/finagle/pull/352","diff_url":"https://github.com/twitter/finagle/pull/352.diff","patch_url":"https://github.com/twitter/finagle/pull/352.patch"},"body":"Problem\r\n\r\nThe main logic of the RetryingFilter is good enough for me, however it does not\r\npass the request to the policy. In my case I always want to retry GET requests.\r\nTherefore, I want to extend the RetryingFilter such that the new apply() method\r\ncan use the request to create a new policy. In the current situation that is not\r\npossible because the dispatch method is private. Consequently, the\r\nRetryingFilter is not extendable.\r\n\r\nSolution\r\n\r\nChanged the access modifier from private to protected.\r\n\r\nResult\r\n\r\nClasses that extend the RetryingFilter can now call dispatch."},"comment":{"url":"https://api.github.com/repos/twitter/finagle/issues/comments/84681700","html_url":"https://github.com/twitter/finagle/pull/352#issuecomment-84681700","issue_url":"https://api.github.com/repos/twitter/finagle/issues/352","id":84681700,"user":{"login":"travisbrown","id":316049,"avatar_url":"https://avatars.githubusercontent.com/u/316049?v=3","gravatar_id":"","url":"https://api.github.com/users/travisbrown","html_url":"https://github.com/travisbrown","followers_url":"https://api.github.com/users/travisbrown/followers","following_url":"https://api.github.com/users/travisbrown/following{/other_user}","gists_url":"https://api.github.com/users/travisbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/travisbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisbrown/subscriptions","organizations_url":"https://api.github.com/users/travisbrown/orgs","repos_url":"https://api.github.com/users/travisbrown/repos","events_url":"https://api.github.com/users/travisbrown/events{/privacy}","received_events_url":"https://api.github.com/users/travisbrown/received_events","type":"User","site_admin":false},"created_at":"2015-03-22T19:17:17Z","updated_at":"2015-03-22T19:17:17Z","body":"(Note that in general it's best to submit pull requests against the `develop` branch, but in this case it's not a big deal.)"}}