{"action":"created","issue":{"url":"https://api.github.com/repos/GovLab/noi2/issues/209","labels_url":"https://api.github.com/repos/GovLab/noi2/issues/209/labels{/name}","comments_url":"https://api.github.com/repos/GovLab/noi2/issues/209/comments","events_url":"https://api.github.com/repos/GovLab/noi2/issues/209/events","html_url":"https://github.com/GovLab/noi2/pull/209","id":113465631,"number":209,"title":"Set max-width of desktop to 1080px","user":{"login":"toolness","id":124687,"avatar_url":"https://avatars.githubusercontent.com/u/124687?v=3","gravatar_id":"","url":"https://api.github.com/users/toolness","html_url":"https://github.com/toolness","followers_url":"https://api.github.com/users/toolness/followers","following_url":"https://api.github.com/users/toolness/following{/other_user}","gists_url":"https://api.github.com/users/toolness/gists{/gist_id}","starred_url":"https://api.github.com/users/toolness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolness/subscriptions","organizations_url":"https://api.github.com/users/toolness/orgs","repos_url":"https://api.github.com/users/toolness/repos","events_url":"https://api.github.com/users/toolness/events{/privacy}","received_events_url":"https://api.github.com/users/toolness/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"claudioccm","id":1649373,"avatar_url":"https://avatars.githubusercontent.com/u/1649373?v=3","gravatar_id":"","url":"https://api.github.com/users/claudioccm","html_url":"https://github.com/claudioccm","followers_url":"https://api.github.com/users/claudioccm/followers","following_url":"https://api.github.com/users/claudioccm/following{/other_user}","gists_url":"https://api.github.com/users/claudioccm/gists{/gist_id}","starred_url":"https://api.github.com/users/claudioccm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudioccm/subscriptions","organizations_url":"https://api.github.com/users/claudioccm/orgs","repos_url":"https://api.github.com/users/claudioccm/repos","events_url":"https://api.github.com/users/claudioccm/events{/privacy}","received_events_url":"https://api.github.com/users/claudioccm/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/GovLab/noi2/milestones/1","html_url":"https://github.com/GovLab/noi2/milestones/OGP%20Launch","labels_url":"https://api.github.com/repos/GovLab/noi2/milestones/1/labels","id":1365162,"number":1,"title":"OGP Launch","description":"We'd like to have this ready to launch at [OGP 2015](http://www.opengovpartnership.org/2015Summit).","creator":{"login":"toolness","id":124687,"avatar_url":"https://avatars.githubusercontent.com/u/124687?v=3","gravatar_id":"","url":"https://api.github.com/users/toolness","html_url":"https://github.com/toolness","followers_url":"https://api.github.com/users/toolness/followers","following_url":"https://api.github.com/users/toolness/following{/other_user}","gists_url":"https://api.github.com/users/toolness/gists{/gist_id}","starred_url":"https://api.github.com/users/toolness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolness/subscriptions","organizations_url":"https://api.github.com/users/toolness/orgs","repos_url":"https://api.github.com/users/toolness/repos","events_url":"https://api.github.com/users/toolness/events{/privacy}","received_events_url":"https://api.github.com/users/toolness/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":41,"state":"open","created_at":"2015-10-20T00:07:36Z","updated_at":"2015-10-27T08:57:38Z","due_on":"2015-10-26T04:00:00Z","closed_at":null},"comments":1,"created_at":"2015-10-26T22:34:11Z","updated_at":"2015-10-27T08:57:38Z","closed_at":"2015-10-27T08:57:38Z","pull_request":{"url":"https://api.github.com/repos/GovLab/noi2/pulls/209","html_url":"https://github.com/GovLab/noi2/pull/209","diff_url":"https://github.com/GovLab/noi2/pull/209.diff","patch_url":"https://github.com/GovLab/noi2/pull/209.patch"},"body":"This is just a suggestion--basically it sets the max desktop width to 1080px (which is also the desktop \"breakpoint\" at which this max-width rule is enabled) instead of the 500px it's currently set to.\r\n\r\nReasons for this change:\r\n* I think it's a bit weird to have the width of the actual content become *smaller* as one widens the window, which is currently what happens: if one wants their content to be as wide as possible, they're best off setting the width of their browser window to 1079px instead of anything greater!\r\n* Scrolling on the tab nav is especially painful to use on desktop, or any device on which users can't easily scroll horizontally (such as a mouse with a vertical-only scroll wheel):\r\n\r\n  ![2015-10-26_18-28-48](https://cloud.githubusercontent.com/assets/124687/10744320/6ca20b28-7c0f-11e5-8a32-657e858cea79.png)\r\n\r\n  The screenshot above is taken with max-width set to 500px, which means that in order to see more tabs, a desktop user with a mousewheel actually needs to use the scrollbar, which is terrible due to [Fitts's Law](https://en.wikipedia.org/wiki/Fitts's_law). Setting the max-width to 1080px, on the other hand, makes all tabs on the site visible without requiring scrolling, thereby making this a much less stressful experience for desktop users."},"comment":{"url":"https://api.github.com/repos/GovLab/noi2/issues/comments/151418370","html_url":"https://github.com/GovLab/noi2/pull/209#issuecomment-151418370","issue_url":"https://api.github.com/repos/GovLab/noi2/issues/209","id":151418370,"user":{"login":"toolness","id":124687,"avatar_url":"https://avatars.githubusercontent.com/u/124687?v=3","gravatar_id":"","url":"https://api.github.com/users/toolness","html_url":"https://github.com/toolness","followers_url":"https://api.github.com/users/toolness/followers","following_url":"https://api.github.com/users/toolness/following{/other_user}","gists_url":"https://api.github.com/users/toolness/gists{/gist_id}","starred_url":"https://api.github.com/users/toolness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolness/subscriptions","organizations_url":"https://api.github.com/users/toolness/orgs","repos_url":"https://api.github.com/users/toolness/repos","events_url":"https://api.github.com/users/toolness/events{/privacy}","received_events_url":"https://api.github.com/users/toolness/received_events","type":"User","site_admin":false},"created_at":"2015-10-27T08:57:38Z","updated_at":"2015-10-27T08:57:38Z","body":"We discussed this on Slack and won't be implementing it, so I'm closing the PR."}}