{"action":"opened","number":53,"pull_request":{"url":"https://api.github.com/repos/cloudfoundry/bosh-agent/pulls/53","id":53790398,"html_url":"https://github.com/cloudfoundry/bosh-agent/pull/53","diff_url":"https://github.com/cloudfoundry/bosh-agent/pull/53.diff","patch_url":"https://github.com/cloudfoundry/bosh-agent/pull/53.patch","issue_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/issues/53","number":53,"state":"open","locked":false,"title":"Get unit tests (almost) all passing on Windows","user":{"login":"benmoss","id":239754,"avatar_url":"https://avatars.githubusercontent.com/u/239754?v=3","gravatar_id":"","url":"https://api.github.com/users/benmoss","html_url":"https://github.com/benmoss","followers_url":"https://api.github.com/users/benmoss/followers","following_url":"https://api.github.com/users/benmoss/following{/other_user}","gists_url":"https://api.github.com/users/benmoss/gists{/gist_id}","starred_url":"https://api.github.com/users/benmoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benmoss/subscriptions","organizations_url":"https://api.github.com/users/benmoss/orgs","repos_url":"https://api.github.com/users/benmoss/repos","events_url":"https://api.github.com/users/benmoss/events{/privacy}","received_events_url":"https://api.github.com/users/benmoss/received_events","type":"User","site_admin":false},"body":"This fixes the project so that the unit tests almost all pass when run on a Windows machine. The main issue, as you can see from the changes made, is that the `filepath` package will insert OS-specific path separators, ie `/` on unix-likes and `\\` on Windows. We will ideally be able to move all of the OS specific filepath manipulation into the OsFileSystem.\r\n\r\nRight now the tests pass because we use the FakeFileSystem in almost all our tests. The only exception is the app_test, which uses the OsFileSystem and also starts up a real go-sigar goroutine which panics currently on Windows.\r\n\r\nI was thinking we could merge this now rather than keeping it on the Windows branch just to avoid having to resolve conflicts from it, and since it shouldn't effect behavior on other platforms.","created_at":"2015-12-16T02:08:28Z","updated_at":"2015-12-16T02:08:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/pulls/53/commits","review_comments_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/pulls/53/comments","review_comment_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/issues/53/comments","statuses_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/statuses/55d21443bea053b7c2b908f4451987e8a71983f3","head":{"label":"cloudfoundry:windows-develop","ref":"windows-develop","sha":"55d21443bea053b7c2b908f4451987e8a71983f3","user":{"login":"cloudfoundry","id":621746,"avatar_url":"https://avatars.githubusercontent.com/u/621746?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry","html_url":"https://github.com/cloudfoundry","followers_url":"https://api.github.com/users/cloudfoundry/followers","following_url":"https://api.github.com/users/cloudfoundry/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry/orgs","repos_url":"https://api.github.com/users/cloudfoundry/repos","events_url":"https://api.github.com/users/cloudfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry/received_events","type":"Organization","site_admin":false},"repo":{"id":22126185,"name":"bosh-agent","full_name":"cloudfoundry/bosh-agent","owner":{"login":"cloudfoundry","id":621746,"avatar_url":"https://avatars.githubusercontent.com/u/621746?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry","html_url":"https://github.com/cloudfoundry","followers_url":"https://api.github.com/users/cloudfoundry/followers","following_url":"https://api.github.com/users/cloudfoundry/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry/orgs","repos_url":"https://api.github.com/users/cloudfoundry/repos","events_url":"https://api.github.com/users/cloudfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudfoundry/bosh-agent","description":"BOSH Agent runs on each BOSH deployed VM","fork":false,"url":"https://api.github.com/repos/cloudfoundry/bosh-agent","forks_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/forks","keys_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/teams","hooks_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/hooks","issue_events_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/issues/events{/number}","events_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/events","assignees_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/assignees{/user}","branches_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/branches{/branch}","tags_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/tags","blobs_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/languages","stargazers_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/stargazers","contributors_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/contributors","subscribers_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/subscribers","subscription_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/subscription","commits_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/contents/{+path}","compare_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/merges","archive_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/downloads","issues_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/issues{/number}","pulls_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/labels{/name}","releases_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/releases{/id}","created_at":"2014-07-23T00:38:56Z","updated_at":"2015-12-09T19:45:52Z","pushed_at":"2015-12-16T01:54:15Z","git_url":"git://github.com/cloudfoundry/bosh-agent.git","ssh_url":"git@github.com:cloudfoundry/bosh-agent.git","clone_url":"https://github.com/cloudfoundry/bosh-agent.git","svn_url":"https://github.com/cloudfoundry/bosh-agent","homepage":"","size":12766,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":13,"forks":40,"open_issues":13,"watchers":14,"default_branch":"master"}},"base":{"label":"cloudfoundry:master","ref":"master","sha":"2e0bb27cc0c552e831ce741cfd745298d691dabc","user":{"login":"cloudfoundry","id":621746,"avatar_url":"https://avatars.githubusercontent.com/u/621746?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry","html_url":"https://github.com/cloudfoundry","followers_url":"https://api.github.com/users/cloudfoundry/followers","following_url":"https://api.github.com/users/cloudfoundry/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry/orgs","repos_url":"https://api.github.com/users/cloudfoundry/repos","events_url":"https://api.github.com/users/cloudfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry/received_events","type":"Organization","site_admin":false},"repo":{"id":22126185,"name":"bosh-agent","full_name":"cloudfoundry/bosh-agent","owner":{"login":"cloudfoundry","id":621746,"avatar_url":"https://avatars.githubusercontent.com/u/621746?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry","html_url":"https://github.com/cloudfoundry","followers_url":"https://api.github.com/users/cloudfoundry/followers","following_url":"https://api.github.com/users/cloudfoundry/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry/orgs","repos_url":"https://api.github.com/users/cloudfoundry/repos","events_url":"https://api.github.com/users/cloudfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudfoundry/bosh-agent","description":"BOSH Agent runs on each BOSH deployed VM","fork":false,"url":"https://api.github.com/repos/cloudfoundry/bosh-agent","forks_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/forks","keys_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/teams","hooks_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/hooks","issue_events_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/issues/events{/number}","events_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/events","assignees_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/assignees{/user}","branches_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/branches{/branch}","tags_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/tags","blobs_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/languages","stargazers_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/stargazers","contributors_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/contributors","subscribers_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/subscribers","subscription_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/subscription","commits_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/contents/{+path}","compare_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/merges","archive_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/downloads","issues_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/issues{/number}","pulls_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/labels{/name}","releases_url":"https://api.github.com/repos/cloudfoundry/bosh-agent/releases{/id}","created_at":"2014-07-23T00:38:56Z","updated_at":"2015-12-09T19:45:52Z","pushed_at":"2015-12-16T01:54:15Z","git_url":"git://github.com/cloudfoundry/bosh-agent.git","ssh_url":"git@github.com:cloudfoundry/bosh-agent.git","clone_url":"https://github.com/cloudfoundry/bosh-agent.git","svn_url":"https://github.com/cloudfoundry/bosh-agent","homepage":"","size":12766,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":13,"forks":40,"open_issues":13,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry/bosh-agent/pulls/53"},"html":{"href":"https://github.com/cloudfoundry/bosh-agent/pull/53"},"issue":{"href":"https://api.github.com/repos/cloudfoundry/bosh-agent/issues/53"},"comments":{"href":"https://api.github.com/repos/cloudfoundry/bosh-agent/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudfoundry/bosh-agent/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudfoundry/bosh-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudfoundry/bosh-agent/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/cloudfoundry/bosh-agent/statuses/55d21443bea053b7c2b908f4451987e8a71983f3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":1368,"deletions":665,"changed_files":69}}