{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/issues/117","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/issues/117/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/issues/117/comments","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/issues/117/events","html_url":"https://github.com/puppetlabs/puppetlabs-aws/pull/117","id":62649663,"number":117,"title":"(DO NOT MERGE)(CLOUD-184, CLOUD-205) Make the region param and ENV var interchangable","user":{"login":"garethr","id":2029,"avatar_url":"https://avatars.githubusercontent.com/u/2029?v=3","gravatar_id":"","url":"https://api.github.com/users/garethr","html_url":"https://github.com/garethr","followers_url":"https://api.github.com/users/garethr/followers","following_url":"https://api.github.com/users/garethr/following{/other_user}","gists_url":"https://api.github.com/users/garethr/gists{/gist_id}","starred_url":"https://api.github.com/users/garethr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethr/subscriptions","organizations_url":"https://api.github.com/users/garethr/orgs","repos_url":"https://api.github.com/users/garethr/repos","events_url":"https://api.github.com/users/garethr/events{/privacy}","received_events_url":"https://api.github.com/users/garethr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-03-18T10:15:12Z","updated_at":"2015-03-24T09:52:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/pulls/117","html_url":"https://github.com/puppetlabs/puppetlabs-aws/pull/117","diff_url":"https://github.com/puppetlabs/puppetlabs-aws/pull/117.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-aws/pull/117.patch"},"body":"(Note that I've put this up just applying to security groups so as to get feedback on whether we should do some/all/none this as much as the implementation)\r\n\r\nThis allows for creating and deleting resources from puppet resource by\r\npassing the environment variable (which is already used for scoping).\r\n\r\nPrior to this change you would have to pass the information twice. If\r\nyou do pass both we maintain the same approach as previous, giving the\r\nparam a higher precedence.\r\n\r\nThis also allows for not specifying the region in the DSL, and instead\r\nusing the AWS_REGION variable. This matches the standard behaviour of\r\nother AWS tools, and means in the case of not providing anything the\r\ncorrect error bubbles through."},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/issues/comments/85426976","html_url":"https://github.com/puppetlabs/puppetlabs-aws/pull/117#issuecomment-85426976","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/issues/117","id":85426976,"user":{"login":"garethr","id":2029,"avatar_url":"https://avatars.githubusercontent.com/u/2029?v=3","gravatar_id":"","url":"https://api.github.com/users/garethr","html_url":"https://github.com/garethr","followers_url":"https://api.github.com/users/garethr/followers","following_url":"https://api.github.com/users/garethr/following{/other_user}","gists_url":"https://api.github.com/users/garethr/gists{/gist_id}","starred_url":"https://api.github.com/users/garethr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethr/subscriptions","organizations_url":"https://api.github.com/users/garethr/orgs","repos_url":"https://api.github.com/users/garethr/repos","events_url":"https://api.github.com/users/garethr/events{/privacy}","received_events_url":"https://api.github.com/users/garethr/received_events","type":"User","site_admin":false},"created_at":"2015-03-24T09:52:42Z","updated_at":"2015-03-24T09:52:42Z","body":"I've extracted the region type and made a separate PR for just the blocking behaviour https://github.com/puppetlabs/puppetlabs-aws/pull/132"}}