{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/574","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/574/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/574/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/574/events","html_url":"https://github.com/Automattic/wp-calypso/issues/574","id":118480435,"number":574,"title":"Editor: Sharing connection monitoring is fragile","user":{"login":"nylen","id":227022,"avatar_url":"https://avatars.githubusercontent.com/u/227022?v=3","gravatar_id":"","url":"https://api.github.com/users/nylen","html_url":"https://github.com/nylen","followers_url":"https://api.github.com/users/nylen/followers","following_url":"https://api.github.com/users/nylen/following{/other_user}","gists_url":"https://api.github.com/users/nylen/gists{/gist_id}","starred_url":"https://api.github.com/users/nylen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylen/subscriptions","organizations_url":"https://api.github.com/users/nylen/orgs","repos_url":"https://api.github.com/users/nylen/repos","events_url":"https://api.github.com/users/nylen/events{/privacy}","received_events_url":"https://api.github.com/users/nylen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Editor","name":"Editor","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Sharing","name":"Sharing","color":"006b75"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-23T21:50:15Z","updated_at":"2015-11-23T22:23:04Z","closed_at":null,"body":"Since the editor opens a popup window to connect a new sharing service, then only monitors that specific window for changes when it is closed, this flow is a bit fragile.  For example:\r\n\r\n- Open the sharing popup and connect a new service\r\n- Refresh the editor page; the connected service appears\r\n- In the same sharing popup, disconnect the service.\r\n- Close the popup and note that the sharing accordion is not immediately refreshed (because the connection between the editor and the popup window has been broken).\r\n\r\nPerhaps rather than waiting for a specific window to close, it would be better to use `postMessage` to do live monitoring of changes here."},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/159086297","html_url":"https://github.com/Automattic/wp-calypso/issues/574#issuecomment-159086297","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/574","id":159086297,"user":{"login":"nylen","id":227022,"avatar_url":"https://avatars.githubusercontent.com/u/227022?v=3","gravatar_id":"","url":"https://api.github.com/users/nylen","html_url":"https://github.com/nylen","followers_url":"https://api.github.com/users/nylen/followers","following_url":"https://api.github.com/users/nylen/following{/other_user}","gists_url":"https://api.github.com/users/nylen/gists{/gist_id}","starred_url":"https://api.github.com/users/nylen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylen/subscriptions","organizations_url":"https://api.github.com/users/nylen/orgs","repos_url":"https://api.github.com/users/nylen/repos","events_url":"https://api.github.com/users/nylen/events{/privacy}","received_events_url":"https://api.github.com/users/nylen/received_events","type":"User","site_admin":false},"created_at":"2015-11-23T22:23:04Z","updated_at":"2015-11-23T22:23:04Z","body":"FWIW I find that shorthand for GitHub links pretty annoying.  It's pretty obvious to anyone reading it what it means, so there are no advantages to using it, and it has the disadvantage of requiring extra steps for people with access to the private repos to view it.  This is better for us, and not any worse for public readers and contributors:  Automattic/calypso-pre-oss#12550"}}