{"action":"created","comment":{"url":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/comments/31589062","id":31589062,"diff_hunk":"@@ -0,0 +1,23 @@\n+package com.yahoo.ycsb.generator;\n+\n+import org.testng.annotations.Test;\n+import static org.testng.AssertJUnit.assertTrue;\n+\n+public class TestZipfianGenerator {\n+    @Test\n+    public void testMinParameter() {\n+        long min = 5;\n+        long max = 100;\n+        Boolean gr_max = true;\n+\n+        ZipfianGenerator zipfian = new ZipfianGenerator(min, max);\n+\n+        for (int i = 0; i < 1000; i++) {\n+            long rnd = zipfian.nextLong();\n+            // System.out.println(rnd);","path":"core/src/test/java/com/yahoo/ycsb/generator/TestZipfianGenerator.java","position":17,"original_position":17,"commit_id":"149ea82959276c1151902158f3f9b376188dc8be","original_commit_id":"149ea82959276c1151902158f3f9b376188dc8be","user":{"login":"busbey","id":44891,"avatar_url":"https://avatars.githubusercontent.com/u/44891?v=3","gravatar_id":"","url":"https://api.github.com/users/busbey","html_url":"https://github.com/busbey","followers_url":"https://api.github.com/users/busbey/followers","following_url":"https://api.github.com/users/busbey/following{/other_user}","gists_url":"https://api.github.com/users/busbey/gists{/gist_id}","starred_url":"https://api.github.com/users/busbey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/busbey/subscriptions","organizations_url":"https://api.github.com/users/busbey/orgs","repos_url":"https://api.github.com/users/busbey/repos","events_url":"https://api.github.com/users/busbey/events{/privacy}","received_events_url":"https://api.github.com/users/busbey/received_events","type":"User","site_admin":false},"body":"just leave out the commented out bit.","created_at":"2015-06-03T02:07:10Z","updated_at":"2015-06-03T02:07:10Z","html_url":"https://github.com/brianfrankcooper/YCSB/pull/275#discussion_r31589062","pull_request_url":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/275","_links":{"self":{"href":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/comments/31589062"},"html":{"href":"https://github.com/brianfrankcooper/YCSB/pull/275#discussion_r31589062"},"pull_request":{"href":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/275"}}},"pull_request":{"url":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/275","id":36769440,"html_url":"https://github.com/brianfrankcooper/YCSB/pull/275","diff_url":"https://github.com/brianfrankcooper/YCSB/pull/275.diff","patch_url":"https://github.com/brianfrankcooper/YCSB/pull/275.patch","issue_url":"https://api.github.com/repos/brianfrankcooper/YCSB/issues/275","number":275,"state":"open","locked":false,"title":"Given the min and max parameter the ZipfianGenerator should not return *0*…","user":{"login":"steffenfriedrich","id":12714881,"avatar_url":"https://avatars.githubusercontent.com/u/12714881?v=3","gravatar_id":"","url":"https://api.github.com/users/steffenfriedrich","html_url":"https://github.com/steffenfriedrich","followers_url":"https://api.github.com/users/steffenfriedrich/followers","following_url":"https://api.github.com/users/steffenfriedrich/following{/other_user}","gists_url":"https://api.github.com/users/steffenfriedrich/gists{/gist_id}","starred_url":"https://api.github.com/users/steffenfriedrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steffenfriedrich/subscriptions","organizations_url":"https://api.github.com/users/steffenfriedrich/orgs","repos_url":"https://api.github.com/users/steffenfriedrich/repos","events_url":"https://api.github.com/users/steffenfriedrich/events{/privacy}","received_events_url":"https://api.github.com/users/steffenfriedrich/received_events","type":"User","site_admin":false},"body":"… `if (uz < 1)` nor **1** `if (uz<1.0+Math.pow(0.5,theta))`. The pseudo code in <cite>[1]</cite> (referenced by ycsb) assumes that only values between 1 and N are drawn from the distribution, but given a min parameter the min value should be returned `if (uz < 1)`, resp. min + 1 `if (uz<1.0+Math.pow(0.5,theta))`.\r\n\r\n[1]  J. Gray et al. Quickly generating billion-record synthetic databases. In SIGMOD, 1994.","created_at":"2015-06-02T20:17:55Z","updated_at":"2015-06-03T02:07:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"061c004a3b4543bdd5fd16790cd666bffeb4fe42","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/275/commits","review_comments_url":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/275/comments","review_comment_url":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brianfrankcooper/YCSB/issues/275/comments","statuses_url":"https://api.github.com/repos/brianfrankcooper/YCSB/statuses/149ea82959276c1151902158f3f9b376188dc8be","head":{"label":"steffenfriedrich:zipfianfix","ref":"zipfianfix","sha":"149ea82959276c1151902158f3f9b376188dc8be","user":{"login":"steffenfriedrich","id":12714881,"avatar_url":"https://avatars.githubusercontent.com/u/12714881?v=3","gravatar_id":"","url":"https://api.github.com/users/steffenfriedrich","html_url":"https://github.com/steffenfriedrich","followers_url":"https://api.github.com/users/steffenfriedrich/followers","following_url":"https://api.github.com/users/steffenfriedrich/following{/other_user}","gists_url":"https://api.github.com/users/steffenfriedrich/gists{/gist_id}","starred_url":"https://api.github.com/users/steffenfriedrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steffenfriedrich/subscriptions","organizations_url":"https://api.github.com/users/steffenfriedrich/orgs","repos_url":"https://api.github.com/users/steffenfriedrich/repos","events_url":"https://api.github.com/users/steffenfriedrich/events{/privacy}","received_events_url":"https://api.github.com/users/steffenfriedrich/received_events","type":"User","site_admin":false},"repo":{"id":36740898,"name":"YCSB","full_name":"steffenfriedrich/YCSB","owner":{"login":"steffenfriedrich","id":12714881,"avatar_url":"https://avatars.githubusercontent.com/u/12714881?v=3","gravatar_id":"","url":"https://api.github.com/users/steffenfriedrich","html_url":"https://github.com/steffenfriedrich","followers_url":"https://api.github.com/users/steffenfriedrich/followers","following_url":"https://api.github.com/users/steffenfriedrich/following{/other_user}","gists_url":"https://api.github.com/users/steffenfriedrich/gists{/gist_id}","starred_url":"https://api.github.com/users/steffenfriedrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steffenfriedrich/subscriptions","organizations_url":"https://api.github.com/users/steffenfriedrich/orgs","repos_url":"https://api.github.com/users/steffenfriedrich/repos","events_url":"https://api.github.com/users/steffenfriedrich/events{/privacy}","received_events_url":"https://api.github.com/users/steffenfriedrich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steffenfriedrich/YCSB","description":"Yahoo! Cloud Serving Benchmark","fork":true,"url":"https://api.github.com/repos/steffenfriedrich/YCSB","forks_url":"https://api.github.com/repos/steffenfriedrich/YCSB/forks","keys_url":"https://api.github.com/repos/steffenfriedrich/YCSB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steffenfriedrich/YCSB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steffenfriedrich/YCSB/teams","hooks_url":"https://api.github.com/repos/steffenfriedrich/YCSB/hooks","issue_events_url":"https://api.github.com/repos/steffenfriedrich/YCSB/issues/events{/number}","events_url":"https://api.github.com/repos/steffenfriedrich/YCSB/events","assignees_url":"https://api.github.com/repos/steffenfriedrich/YCSB/assignees{/user}","branches_url":"https://api.github.com/repos/steffenfriedrich/YCSB/branches{/branch}","tags_url":"https://api.github.com/repos/steffenfriedrich/YCSB/tags","blobs_url":"https://api.github.com/repos/steffenfriedrich/YCSB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steffenfriedrich/YCSB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steffenfriedrich/YCSB/git/refs{/sha}","trees_url":"https://api.github.com/repos/steffenfriedrich/YCSB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steffenfriedrich/YCSB/statuses/{sha}","languages_url":"https://api.github.com/repos/steffenfriedrich/YCSB/languages","stargazers_url":"https://api.github.com/repos/steffenfriedrich/YCSB/stargazers","contributors_url":"https://api.github.com/repos/steffenfriedrich/YCSB/contributors","subscribers_url":"https://api.github.com/repos/steffenfriedrich/YCSB/subscribers","subscription_url":"https://api.github.com/repos/steffenfriedrich/YCSB/subscription","commits_url":"https://api.github.com/repos/steffenfriedrich/YCSB/commits{/sha}","git_commits_url":"https://api.github.com/repos/steffenfriedrich/YCSB/git/commits{/sha}","comments_url":"https://api.github.com/repos/steffenfriedrich/YCSB/comments{/number}","issue_comment_url":"https://api.github.com/repos/steffenfriedrich/YCSB/issues/comments{/number}","contents_url":"https://api.github.com/repos/steffenfriedrich/YCSB/contents/{+path}","compare_url":"https://api.github.com/repos/steffenfriedrich/YCSB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steffenfriedrich/YCSB/merges","archive_url":"https://api.github.com/repos/steffenfriedrich/YCSB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steffenfriedrich/YCSB/downloads","issues_url":"https://api.github.com/repos/steffenfriedrich/YCSB/issues{/number}","pulls_url":"https://api.github.com/repos/steffenfriedrich/YCSB/pulls{/number}","milestones_url":"https://api.github.com/repos/steffenfriedrich/YCSB/milestones{/number}","notifications_url":"https://api.github.com/repos/steffenfriedrich/YCSB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steffenfriedrich/YCSB/labels{/name}","releases_url":"https://api.github.com/repos/steffenfriedrich/YCSB/releases{/id}","created_at":"2015-06-02T15:01:35Z","updated_at":"2015-06-02T15:01:35Z","pushed_at":"2015-06-02T19:51:20Z","git_url":"git://github.com/steffenfriedrich/YCSB.git","ssh_url":"git@github.com:steffenfriedrich/YCSB.git","clone_url":"https://github.com/steffenfriedrich/YCSB.git","svn_url":"https://github.com/steffenfriedrich/YCSB","homepage":"http://research.yahoo.com/Web_Information_Management/YCSB","size":176100,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brianfrankcooper:master","ref":"master","sha":"9c1c40faa4c2ba32e6beeafd174ad25f51a12717","user":{"login":"brianfrankcooper","id":247619,"avatar_url":"https://avatars.githubusercontent.com/u/247619?v=3","gravatar_id":"","url":"https://api.github.com/users/brianfrankcooper","html_url":"https://github.com/brianfrankcooper","followers_url":"https://api.github.com/users/brianfrankcooper/followers","following_url":"https://api.github.com/users/brianfrankcooper/following{/other_user}","gists_url":"https://api.github.com/users/brianfrankcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/brianfrankcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianfrankcooper/subscriptions","organizations_url":"https://api.github.com/users/brianfrankcooper/orgs","repos_url":"https://api.github.com/users/brianfrankcooper/repos","events_url":"https://api.github.com/users/brianfrankcooper/events{/privacy}","received_events_url":"https://api.github.com/users/brianfrankcooper/received_events","type":"User","site_admin":false},"repo":{"id":618492,"name":"YCSB","full_name":"brianfrankcooper/YCSB","owner":{"login":"brianfrankcooper","id":247619,"avatar_url":"https://avatars.githubusercontent.com/u/247619?v=3","gravatar_id":"","url":"https://api.github.com/users/brianfrankcooper","html_url":"https://github.com/brianfrankcooper","followers_url":"https://api.github.com/users/brianfrankcooper/followers","following_url":"https://api.github.com/users/brianfrankcooper/following{/other_user}","gists_url":"https://api.github.com/users/brianfrankcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/brianfrankcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianfrankcooper/subscriptions","organizations_url":"https://api.github.com/users/brianfrankcooper/orgs","repos_url":"https://api.github.com/users/brianfrankcooper/repos","events_url":"https://api.github.com/users/brianfrankcooper/events{/privacy}","received_events_url":"https://api.github.com/users/brianfrankcooper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brianfrankcooper/YCSB","description":"Yahoo! Cloud Serving Benchmark","fork":false,"url":"https://api.github.com/repos/brianfrankcooper/YCSB","forks_url":"https://api.github.com/repos/brianfrankcooper/YCSB/forks","keys_url":"https://api.github.com/repos/brianfrankcooper/YCSB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianfrankcooper/YCSB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianfrankcooper/YCSB/teams","hooks_url":"https://api.github.com/repos/brianfrankcooper/YCSB/hooks","issue_events_url":"https://api.github.com/repos/brianfrankcooper/YCSB/issues/events{/number}","events_url":"https://api.github.com/repos/brianfrankcooper/YCSB/events","assignees_url":"https://api.github.com/repos/brianfrankcooper/YCSB/assignees{/user}","branches_url":"https://api.github.com/repos/brianfrankcooper/YCSB/branches{/branch}","tags_url":"https://api.github.com/repos/brianfrankcooper/YCSB/tags","blobs_url":"https://api.github.com/repos/brianfrankcooper/YCSB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianfrankcooper/YCSB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianfrankcooper/YCSB/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianfrankcooper/YCSB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianfrankcooper/YCSB/statuses/{sha}","languages_url":"https://api.github.com/repos/brianfrankcooper/YCSB/languages","stargazers_url":"https://api.github.com/repos/brianfrankcooper/YCSB/stargazers","contributors_url":"https://api.github.com/repos/brianfrankcooper/YCSB/contributors","subscribers_url":"https://api.github.com/repos/brianfrankcooper/YCSB/subscribers","subscription_url":"https://api.github.com/repos/brianfrankcooper/YCSB/subscription","commits_url":"https://api.github.com/repos/brianfrankcooper/YCSB/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianfrankcooper/YCSB/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianfrankcooper/YCSB/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianfrankcooper/YCSB/issues/comments{/number}","contents_url":"https://api.github.com/repos/brianfrankcooper/YCSB/contents/{+path}","compare_url":"https://api.github.com/repos/brianfrankcooper/YCSB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianfrankcooper/YCSB/merges","archive_url":"https://api.github.com/repos/brianfrankcooper/YCSB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianfrankcooper/YCSB/downloads","issues_url":"https://api.github.com/repos/brianfrankcooper/YCSB/issues{/number}","pulls_url":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls{/number}","milestones_url":"https://api.github.com/repos/brianfrankcooper/YCSB/milestones{/number}","notifications_url":"https://api.github.com/repos/brianfrankcooper/YCSB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianfrankcooper/YCSB/labels{/name}","releases_url":"https://api.github.com/repos/brianfrankcooper/YCSB/releases{/id}","created_at":"2010-04-19T20:52:11Z","updated_at":"2015-06-02T18:21:49Z","pushed_at":"2015-06-02T20:17:55Z","git_url":"git://github.com/brianfrankcooper/YCSB.git","ssh_url":"git@github.com:brianfrankcooper/YCSB.git","clone_url":"https://github.com/brianfrankcooper/YCSB.git","svn_url":"https://github.com/brianfrankcooper/YCSB","homepage":"http://research.yahoo.com/Web_Information_Management/YCSB","size":176100,"stargazers_count":850,"watchers_count":850,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":603,"mirror_url":null,"open_issues_count":100,"forks":603,"open_issues":100,"watchers":850,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/275"},"html":{"href":"https://github.com/brianfrankcooper/YCSB/pull/275"},"issue":{"href":"https://api.github.com/repos/brianfrankcooper/YCSB/issues/275"},"comments":{"href":"https://api.github.com/repos/brianfrankcooper/YCSB/issues/275/comments"},"review_comments":{"href":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/275/comments"},"review_comment":{"href":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brianfrankcooper/YCSB/pulls/275/commits"},"statuses":{"href":"https://api.github.com/repos/brianfrankcooper/YCSB/statuses/149ea82959276c1151902158f3f9b376188dc8be"}}}}