{"action":"created","issue":{"url":"https://api.github.com/repos/acrmp/foodcritic/issues/309","labels_url":"https://api.github.com/repos/acrmp/foodcritic/issues/309/labels{/name}","comments_url":"https://api.github.com/repos/acrmp/foodcritic/issues/309/comments","events_url":"https://api.github.com/repos/acrmp/foodcritic/issues/309/events","html_url":"https://github.com/acrmp/foodcritic/pull/309","id":63118184,"number":309,"title":"add warnings for use of recommends/suggests","user":{"login":"lamont-granquist","id":454857,"avatar_url":"https://avatars.githubusercontent.com/u/454857?v=3","gravatar_id":"","url":"https://api.github.com/users/lamont-granquist","html_url":"https://github.com/lamont-granquist","followers_url":"https://api.github.com/users/lamont-granquist/followers","following_url":"https://api.github.com/users/lamont-granquist/following{/other_user}","gists_url":"https://api.github.com/users/lamont-granquist/gists{/gist_id}","starred_url":"https://api.github.com/users/lamont-granquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamont-granquist/subscriptions","organizations_url":"https://api.github.com/users/lamont-granquist/orgs","repos_url":"https://api.github.com/users/lamont-granquist/repos","events_url":"https://api.github.com/users/lamont-granquist/events{/privacy}","received_events_url":"https://api.github.com/users/lamont-granquist/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-19T23:44:46Z","updated_at":"2015-03-20T01:16:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/acrmp/foodcritic/pulls/309","html_url":"https://github.com/acrmp/foodcritic/pull/309","diff_url":"https://github.com/acrmp/foodcritic/pull/309.diff","patch_url":"https://github.com/acrmp/foodcritic/pull/309.patch"},"body":"These are unimplemented metadata keywords and their use is currently a\r\nsort of no-op.  However, this can cause bugs with different tooling:\r\n\r\nhttps://github.com/berkshelf/berkshelf/issues/1404\r\n\r\nIt also is likely that whatever the user thinks the semantics should be\r\neventually that some subset of users will guess incorrectly and get\r\nsurprising behavior if we ever do implement these keywords.  The proper\r\napproach to documenting optional cookbooks is currently via text in the\r\nREADME.md or a comment in the metadata.rb.\r\n\r\nThe correct course of action in the future is that an RFC should be\r\nsubmitted to https://github.com/chef/chef-rfc to decide what the suggests\r\nand recommends semantics are, and to actually implement those semantics.\r\nUntil then, users should avoid the use of these keywords (essentially\r\nthey are 'reserved for future use' -- which means \"do not use them now\")."},"comment":{"url":"https://api.github.com/repos/acrmp/foodcritic/issues/comments/83836304","html_url":"https://github.com/acrmp/foodcritic/pull/309#issuecomment-83836304","issue_url":"https://api.github.com/repos/acrmp/foodcritic/issues/309","id":83836304,"user":{"login":"lamont-granquist","id":454857,"avatar_url":"https://avatars.githubusercontent.com/u/454857?v=3","gravatar_id":"","url":"https://api.github.com/users/lamont-granquist","html_url":"https://github.com/lamont-granquist","followers_url":"https://api.github.com/users/lamont-granquist/followers","following_url":"https://api.github.com/users/lamont-granquist/following{/other_user}","gists_url":"https://api.github.com/users/lamont-granquist/gists{/gist_id}","starred_url":"https://api.github.com/users/lamont-granquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamont-granquist/subscriptions","organizations_url":"https://api.github.com/users/lamont-granquist/orgs","repos_url":"https://api.github.com/users/lamont-granquist/repos","events_url":"https://api.github.com/users/lamont-granquist/events{/privacy}","received_events_url":"https://api.github.com/users/lamont-granquist/received_events","type":"User","site_admin":false},"created_at":"2015-03-20T01:16:37Z","updated_at":"2015-03-20T01:16:37Z","body":"Yeah, my thoughts on two rules is that we might implement one of them before the other.  I think I looked at implementing `recommends` but didn't have any idea of what to do with `suggests` at one time.  And with two rules we could globally disable one or the other independently."}}