{"action":"closed","number":22,"pull_request":{"url":"https://api.github.com/repos/plone/plone.protect/pulls/22","id":46928146,"html_url":"https://github.com/plone/plone.protect/pull/22","diff_url":"https://github.com/plone/plone.protect/pull/22.diff","patch_url":"https://github.com/plone/plone.protect/pull/22.patch","issue_url":"https://api.github.com/repos/plone/plone.protect/issues/22","number":22,"state":"closed","locked":false,"title":"don't worry about writes to session objects in the temporary storage","user":{"login":"davisagli","id":49014,"avatar_url":"https://avatars.githubusercontent.com/u/49014?v=3","gravatar_id":"","url":"https://api.github.com/users/davisagli","html_url":"https://github.com/davisagli","followers_url":"https://api.github.com/users/davisagli/followers","following_url":"https://api.github.com/users/davisagli/following{/other_user}","gists_url":"https://api.github.com/users/davisagli/gists{/gist_id}","starred_url":"https://api.github.com/users/davisagli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davisagli/subscriptions","organizations_url":"https://api.github.com/users/davisagli/orgs","repos_url":"https://api.github.com/users/davisagli/repos","events_url":"https://api.github.com/users/davisagli/events{/privacy}","received_events_url":"https://api.github.com/users/davisagli/received_events","type":"User","site_admin":false},"body":"This isn't ideal, but Zope sessions write all the time so flagging those writes for CSRF checks hoses the entire site.","created_at":"2015-10-06T16:48:21Z","updated_at":"2015-10-06T18:13:20Z","closed_at":"2015-10-06T18:13:20Z","merged_at":"2015-10-06T18:13:20Z","merge_commit_sha":"61d11f36b04e1e22815fb77deac890f77d81b04a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/plone/plone.protect/pulls/22/commits","review_comments_url":"https://api.github.com/repos/plone/plone.protect/pulls/22/comments","review_comment_url":"https://api.github.com/repos/plone/plone.protect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plone/plone.protect/issues/22/comments","statuses_url":"https://api.github.com/repos/plone/plone.protect/statuses/ed5b3b8453850f84d0a7efe602c1a96c88585f2b","head":{"label":"plone:davisagli-session-writes","ref":"davisagli-session-writes","sha":"ed5b3b8453850f84d0a7efe602c1a96c88585f2b","user":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"repo":{"id":2432541,"name":"plone.protect","full_name":"plone/plone.protect","owner":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plone/plone.protect","description":"HTTP protection utilities for the Plone CMS","fork":false,"url":"https://api.github.com/repos/plone/plone.protect","forks_url":"https://api.github.com/repos/plone/plone.protect/forks","keys_url":"https://api.github.com/repos/plone/plone.protect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plone/plone.protect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plone/plone.protect/teams","hooks_url":"https://api.github.com/repos/plone/plone.protect/hooks","issue_events_url":"https://api.github.com/repos/plone/plone.protect/issues/events{/number}","events_url":"https://api.github.com/repos/plone/plone.protect/events","assignees_url":"https://api.github.com/repos/plone/plone.protect/assignees{/user}","branches_url":"https://api.github.com/repos/plone/plone.protect/branches{/branch}","tags_url":"https://api.github.com/repos/plone/plone.protect/tags","blobs_url":"https://api.github.com/repos/plone/plone.protect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plone/plone.protect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plone/plone.protect/git/refs{/sha}","trees_url":"https://api.github.com/repos/plone/plone.protect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plone/plone.protect/statuses/{sha}","languages_url":"https://api.github.com/repos/plone/plone.protect/languages","stargazers_url":"https://api.github.com/repos/plone/plone.protect/stargazers","contributors_url":"https://api.github.com/repos/plone/plone.protect/contributors","subscribers_url":"https://api.github.com/repos/plone/plone.protect/subscribers","subscription_url":"https://api.github.com/repos/plone/plone.protect/subscription","commits_url":"https://api.github.com/repos/plone/plone.protect/commits{/sha}","git_commits_url":"https://api.github.com/repos/plone/plone.protect/git/commits{/sha}","comments_url":"https://api.github.com/repos/plone/plone.protect/comments{/number}","issue_comment_url":"https://api.github.com/repos/plone/plone.protect/issues/comments{/number}","contents_url":"https://api.github.com/repos/plone/plone.protect/contents/{+path}","compare_url":"https://api.github.com/repos/plone/plone.protect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plone/plone.protect/merges","archive_url":"https://api.github.com/repos/plone/plone.protect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plone/plone.protect/downloads","issues_url":"https://api.github.com/repos/plone/plone.protect/issues{/number}","pulls_url":"https://api.github.com/repos/plone/plone.protect/pulls{/number}","milestones_url":"https://api.github.com/repos/plone/plone.protect/milestones{/number}","notifications_url":"https://api.github.com/repos/plone/plone.protect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plone/plone.protect/labels{/name}","releases_url":"https://api.github.com/repos/plone/plone.protect/releases{/id}","created_at":"2011-09-21T20:17:50Z","updated_at":"2015-10-06T15:42:57Z","pushed_at":"2015-10-06T18:13:20Z","git_url":"git://github.com/plone/plone.protect.git","ssh_url":"git@github.com:plone/plone.protect.git","clone_url":"https://github.com/plone/plone.protect.git","svn_url":"https://github.com/plone/plone.protect","homepage":"https://pypi.python.org/pypi/plone.protect","size":560,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"plone:master","ref":"master","sha":"029aba45638d143f6cd0d10ff198c5db5c1ce5c4","user":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"repo":{"id":2432541,"name":"plone.protect","full_name":"plone/plone.protect","owner":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plone/plone.protect","description":"HTTP protection utilities for the Plone CMS","fork":false,"url":"https://api.github.com/repos/plone/plone.protect","forks_url":"https://api.github.com/repos/plone/plone.protect/forks","keys_url":"https://api.github.com/repos/plone/plone.protect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plone/plone.protect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plone/plone.protect/teams","hooks_url":"https://api.github.com/repos/plone/plone.protect/hooks","issue_events_url":"https://api.github.com/repos/plone/plone.protect/issues/events{/number}","events_url":"https://api.github.com/repos/plone/plone.protect/events","assignees_url":"https://api.github.com/repos/plone/plone.protect/assignees{/user}","branches_url":"https://api.github.com/repos/plone/plone.protect/branches{/branch}","tags_url":"https://api.github.com/repos/plone/plone.protect/tags","blobs_url":"https://api.github.com/repos/plone/plone.protect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plone/plone.protect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plone/plone.protect/git/refs{/sha}","trees_url":"https://api.github.com/repos/plone/plone.protect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plone/plone.protect/statuses/{sha}","languages_url":"https://api.github.com/repos/plone/plone.protect/languages","stargazers_url":"https://api.github.com/repos/plone/plone.protect/stargazers","contributors_url":"https://api.github.com/repos/plone/plone.protect/contributors","subscribers_url":"https://api.github.com/repos/plone/plone.protect/subscribers","subscription_url":"https://api.github.com/repos/plone/plone.protect/subscription","commits_url":"https://api.github.com/repos/plone/plone.protect/commits{/sha}","git_commits_url":"https://api.github.com/repos/plone/plone.protect/git/commits{/sha}","comments_url":"https://api.github.com/repos/plone/plone.protect/comments{/number}","issue_comment_url":"https://api.github.com/repos/plone/plone.protect/issues/comments{/number}","contents_url":"https://api.github.com/repos/plone/plone.protect/contents/{+path}","compare_url":"https://api.github.com/repos/plone/plone.protect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plone/plone.protect/merges","archive_url":"https://api.github.com/repos/plone/plone.protect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plone/plone.protect/downloads","issues_url":"https://api.github.com/repos/plone/plone.protect/issues{/number}","pulls_url":"https://api.github.com/repos/plone/plone.protect/pulls{/number}","milestones_url":"https://api.github.com/repos/plone/plone.protect/milestones{/number}","notifications_url":"https://api.github.com/repos/plone/plone.protect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plone/plone.protect/labels{/name}","releases_url":"https://api.github.com/repos/plone/plone.protect/releases{/id}","created_at":"2011-09-21T20:17:50Z","updated_at":"2015-10-06T15:42:57Z","pushed_at":"2015-10-06T18:13:20Z","git_url":"git://github.com/plone/plone.protect.git","ssh_url":"git@github.com:plone/plone.protect.git","clone_url":"https://github.com/plone/plone.protect.git","svn_url":"https://github.com/plone/plone.protect","homepage":"https://pypi.python.org/pypi/plone.protect","size":560,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plone/plone.protect/pulls/22"},"html":{"href":"https://github.com/plone/plone.protect/pull/22"},"issue":{"href":"https://api.github.com/repos/plone/plone.protect/issues/22"},"comments":{"href":"https://api.github.com/repos/plone/plone.protect/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/plone/plone.protect/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/plone/plone.protect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plone/plone.protect/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/plone/plone.protect/statuses/ed5b3b8453850f84d0a7efe602c1a96c88585f2b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"vangheem","id":524413,"avatar_url":"https://avatars.githubusercontent.com/u/524413?v=3","gravatar_id":"","url":"https://api.github.com/users/vangheem","html_url":"https://github.com/vangheem","followers_url":"https://api.github.com/users/vangheem/followers","following_url":"https://api.github.com/users/vangheem/following{/other_user}","gists_url":"https://api.github.com/users/vangheem/gists{/gist_id}","starred_url":"https://api.github.com/users/vangheem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vangheem/subscriptions","organizations_url":"https://api.github.com/users/vangheem/orgs","repos_url":"https://api.github.com/users/vangheem/repos","events_url":"https://api.github.com/users/vangheem/events{/privacy}","received_events_url":"https://api.github.com/users/vangheem/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":4,"deletions":2,"changed_files":1}}