{"action":"created","issue":{"url":"https://api.github.com/repos/slact/nginx_http_push_module/issues/97","labels_url":"https://api.github.com/repos/slact/nginx_http_push_module/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/slact/nginx_http_push_module/issues/97/comments","events_url":"https://api.github.com/repos/slact/nginx_http_push_module/issues/97/events","html_url":"https://github.com/slact/nginx_http_push_module/issues/97","id":57715101,"number":97,"title":"`push_min_message_recipients` not formally documented","user":{"login":"mkonecny","id":813453,"avatar_url":"https://avatars.githubusercontent.com/u/813453?v=3","gravatar_id":"","url":"https://api.github.com/users/mkonecny","html_url":"https://github.com/mkonecny","followers_url":"https://api.github.com/users/mkonecny/followers","following_url":"https://api.github.com/users/mkonecny/following{/other_user}","gists_url":"https://api.github.com/users/mkonecny/gists{/gist_id}","starred_url":"https://api.github.com/users/mkonecny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkonecny/subscriptions","organizations_url":"https://api.github.com/users/mkonecny/orgs","repos_url":"https://api.github.com/users/mkonecny/repos","events_url":"https://api.github.com/users/mkonecny/events{/privacy}","received_events_url":"https://api.github.com/users/mkonecny/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-02-15T02:40:16Z","updated_at":"2015-02-16T00:32:00Z","closed_at":null,"body":"It is seen in the example config, however it is missing from the list of available commands."},"comment":{"url":"https://api.github.com/repos/slact/nginx_http_push_module/issues/comments/74446228","html_url":"https://github.com/slact/nginx_http_push_module/issues/97#issuecomment-74446228","issue_url":"https://api.github.com/repos/slact/nginx_http_push_module/issues/97","id":74446228,"user":{"login":"slact","id":5745,"avatar_url":"https://avatars.githubusercontent.com/u/5745?v=3","gravatar_id":"","url":"https://api.github.com/users/slact","html_url":"https://github.com/slact","followers_url":"https://api.github.com/users/slact/followers","following_url":"https://api.github.com/users/slact/following{/other_user}","gists_url":"https://api.github.com/users/slact/gists{/gist_id}","starred_url":"https://api.github.com/users/slact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slact/subscriptions","organizations_url":"https://api.github.com/users/slact/orgs","repos_url":"https://api.github.com/users/slact/repos","events_url":"https://api.github.com/users/slact/events{/privacy}","received_events_url":"https://api.github.com/users/slact/received_events","type":"User","site_admin":false},"created_at":"2015-02-16T00:32:00Z","updated_at":"2015-02-16T00:32:00Z","body":"Like I said, you've got an eye for consistency : )\r\n\r\nYes, *push_delete_oldest_received_message* will be deprecated as well. And yes, this is going to violate backwards compatibility, but I don't think it'll break anything serious. Using this option is not recommended in the documentation (and I'll be officially deprecating it), and besides the functionality of preserving a full queue of unseen messages could be used as a denial-of-service attack by forcing the server to never clear messages on a private channel and having it run out of memory. \r\n\r\nOnce a message expires, it should be up for deletion, regardless of whether it was consumed. Once a channel queues too many messages, the oldest beyond max. queue length should be deleted, also unconditionally.\r\n\r\n*push_delete_oldest_received_message*  and *push_min_message_recipients* are my design errors in the message storage system. I've kept both around because it wasn't worth breaking backwards compatibility, but the upcoming release is going to have a lot more features to warrant this break from history. I'll also be deprecating a few other options, but they're just going to be reconceptualizations with equivalent functionality made available from a more orthogonal set of config parameters. For example, the concurrency (broadcast/first-in/last-in) is out, but will be replaced by max_clients_per_channel or some such.\r\n\r\nFor the Debian/Ubuntu users, there will be plenty of warning, and I hope the upcoming feature set will far outweigh the hassle of transition."}}