{"action":"created","comment":{"url":"https://api.github.com/repos/BrightcovePS/FordPlayer/pulls/comments/32777758","id":32777758,"diff_hunk":"@@ -122,21 +126,62 @@ TODO: remove instrinsic ratio implementation from index.html and it to the plugi\n             $modal.addClass(\"no-transition\");\n             $modal.width(modalWidth);\n             $modal.height(modalHeight);\n-            $(\".bcc-detail-left\").width(modalWidth-padding*2-$(\".bcc-detail-right\").width()-buffer);\n+            sizeTitle();\n             $(\"#player\").height(videoHeight);\n             $modal.removeClass(\"no-transition\");\n         },\n         \n         /**\n+         * Sizes title based on other elements.\n+         */\n+        sizeTitle = function() {\n+            if ($filmstripCounter.is(\":visible\")) {\n+                $(\".bcc-detail-left\").width($filmstripCounter.position().left-padding-buffer);\n+            } else {","path":"lib/bcgs_ford_modal.js","position":50,"original_position":50,"commit_id":"ebb6dbb1a78fcd0d6de0f2b17b0da5e27e2119ca","original_commit_id":"ebb6dbb1a78fcd0d6de0f2b17b0da5e27e2119ca","user":{"login":"bceacuna","id":1122841,"avatar_url":"https://avatars.githubusercontent.com/u/1122841?v=3","gravatar_id":"","url":"https://api.github.com/users/bceacuna","html_url":"https://github.com/bceacuna","followers_url":"https://api.github.com/users/bceacuna/followers","following_url":"https://api.github.com/users/bceacuna/following{/other_user}","gists_url":"https://api.github.com/users/bceacuna/gists{/gist_id}","starred_url":"https://api.github.com/users/bceacuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bceacuna/subscriptions","organizations_url":"https://api.github.com/users/bceacuna/orgs","repos_url":"https://api.github.com/users/bceacuna/repos","events_url":"https://api.github.com/users/bceacuna/events{/privacy}","received_events_url":"https://api.github.com/users/bceacuna/received_events","type":"User","site_admin":false},"body":"Is padding-buffer a variable? personally I prefer space around operators. for me it makes the code much more readable. ","created_at":"2015-06-18T20:59:20Z","updated_at":"2015-06-18T20:59:20Z","html_url":"https://github.com/BrightcovePS/FordPlayer/pull/14#discussion_r32777758","pull_request_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/BrightcovePS/FordPlayer/pulls/comments/32777758"},"html":{"href":"https://github.com/BrightcovePS/FordPlayer/pull/14#discussion_r32777758"},"pull_request":{"href":"https://api.github.com/repos/BrightcovePS/FordPlayer/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/BrightcovePS/FordPlayer/pulls/14","id":38025152,"html_url":"https://github.com/BrightcovePS/FordPlayer/pull/14","diff_url":"https://github.com/BrightcovePS/FordPlayer/pull/14.diff","patch_url":"https://github.com/BrightcovePS/FordPlayer/pull/14.patch","issue_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/issues/14","number":14,"state":"open","locked":false,"title":"adding filmstrip counter","user":{"login":"tyard","id":1273020,"avatar_url":"https://avatars.githubusercontent.com/u/1273020?v=3","gravatar_id":"","url":"https://api.github.com/users/tyard","html_url":"https://github.com/tyard","followers_url":"https://api.github.com/users/tyard/followers","following_url":"https://api.github.com/users/tyard/following{/other_user}","gists_url":"https://api.github.com/users/tyard/gists{/gist_id}","starred_url":"https://api.github.com/users/tyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyard/subscriptions","organizations_url":"https://api.github.com/users/tyard/orgs","repos_url":"https://api.github.com/users/tyard/repos","events_url":"https://api.github.com/users/tyard/events{/privacy}","received_events_url":"https://api.github.com/users/tyard/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-18T16:19:40Z","updated_at":"2015-06-18T20:59:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b587dd05ed8fd372191ee882ae96555cf85c8b65","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/pulls/14/commits","review_comments_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/pulls/14/comments","review_comment_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/issues/14/comments","statuses_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/statuses/ebb6dbb1a78fcd0d6de0f2b17b0da5e27e2119ca","head":{"label":"BrightcovePS:feature/playlist-counter","ref":"feature/playlist-counter","sha":"ebb6dbb1a78fcd0d6de0f2b17b0da5e27e2119ca","user":{"login":"BrightcovePS","id":552419,"avatar_url":"https://avatars.githubusercontent.com/u/552419?v=3","gravatar_id":"","url":"https://api.github.com/users/BrightcovePS","html_url":"https://github.com/BrightcovePS","followers_url":"https://api.github.com/users/BrightcovePS/followers","following_url":"https://api.github.com/users/BrightcovePS/following{/other_user}","gists_url":"https://api.github.com/users/BrightcovePS/gists{/gist_id}","starred_url":"https://api.github.com/users/BrightcovePS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrightcovePS/subscriptions","organizations_url":"https://api.github.com/users/BrightcovePS/orgs","repos_url":"https://api.github.com/users/BrightcovePS/repos","events_url":"https://api.github.com/users/BrightcovePS/events{/privacy}","received_events_url":"https://api.github.com/users/BrightcovePS/received_events","type":"Organization","site_admin":false},"repo":{"id":36770895,"name":"FordPlayer","full_name":"BrightcovePS/FordPlayer","owner":{"login":"BrightcovePS","id":552419,"avatar_url":"https://avatars.githubusercontent.com/u/552419?v=3","gravatar_id":"","url":"https://api.github.com/users/BrightcovePS","html_url":"https://github.com/BrightcovePS","followers_url":"https://api.github.com/users/BrightcovePS/followers","following_url":"https://api.github.com/users/BrightcovePS/following{/other_user}","gists_url":"https://api.github.com/users/BrightcovePS/gists{/gist_id}","starred_url":"https://api.github.com/users/BrightcovePS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrightcovePS/subscriptions","organizations_url":"https://api.github.com/users/BrightcovePS/orgs","repos_url":"https://api.github.com/users/BrightcovePS/repos","events_url":"https://api.github.com/users/BrightcovePS/events{/privacy}","received_events_url":"https://api.github.com/users/BrightcovePS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BrightcovePS/FordPlayer","description":"Ford / Team Detroit custom player","fork":false,"url":"https://api.github.com/repos/BrightcovePS/FordPlayer","forks_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/forks","keys_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/teams","hooks_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/hooks","issue_events_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/issues/events{/number}","events_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/events","assignees_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/assignees{/user}","branches_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/branches{/branch}","tags_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/tags","blobs_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/statuses/{sha}","languages_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/languages","stargazers_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/stargazers","contributors_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/contributors","subscribers_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/subscribers","subscription_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/subscription","commits_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/contents/{+path}","compare_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/merges","archive_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/downloads","issues_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/issues{/number}","pulls_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/pulls{/number}","milestones_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/milestones{/number}","notifications_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/labels{/name}","releases_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/releases{/id}","created_at":"2015-06-03T00:57:35Z","updated_at":"2015-06-03T00:57:35Z","pushed_at":"2015-06-18T20:17:08Z","git_url":"git://github.com/BrightcovePS/FordPlayer.git","ssh_url":"git@github.com:BrightcovePS/FordPlayer.git","clone_url":"https://github.com/BrightcovePS/FordPlayer.git","svn_url":"https://github.com/BrightcovePS/FordPlayer","homepage":null,"size":2040,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"BrightcovePS:dev","ref":"dev","sha":"efdc02253df9b4d6842112f7dc0e147b35cc95fa","user":{"login":"BrightcovePS","id":552419,"avatar_url":"https://avatars.githubusercontent.com/u/552419?v=3","gravatar_id":"","url":"https://api.github.com/users/BrightcovePS","html_url":"https://github.com/BrightcovePS","followers_url":"https://api.github.com/users/BrightcovePS/followers","following_url":"https://api.github.com/users/BrightcovePS/following{/other_user}","gists_url":"https://api.github.com/users/BrightcovePS/gists{/gist_id}","starred_url":"https://api.github.com/users/BrightcovePS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrightcovePS/subscriptions","organizations_url":"https://api.github.com/users/BrightcovePS/orgs","repos_url":"https://api.github.com/users/BrightcovePS/repos","events_url":"https://api.github.com/users/BrightcovePS/events{/privacy}","received_events_url":"https://api.github.com/users/BrightcovePS/received_events","type":"Organization","site_admin":false},"repo":{"id":36770895,"name":"FordPlayer","full_name":"BrightcovePS/FordPlayer","owner":{"login":"BrightcovePS","id":552419,"avatar_url":"https://avatars.githubusercontent.com/u/552419?v=3","gravatar_id":"","url":"https://api.github.com/users/BrightcovePS","html_url":"https://github.com/BrightcovePS","followers_url":"https://api.github.com/users/BrightcovePS/followers","following_url":"https://api.github.com/users/BrightcovePS/following{/other_user}","gists_url":"https://api.github.com/users/BrightcovePS/gists{/gist_id}","starred_url":"https://api.github.com/users/BrightcovePS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrightcovePS/subscriptions","organizations_url":"https://api.github.com/users/BrightcovePS/orgs","repos_url":"https://api.github.com/users/BrightcovePS/repos","events_url":"https://api.github.com/users/BrightcovePS/events{/privacy}","received_events_url":"https://api.github.com/users/BrightcovePS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BrightcovePS/FordPlayer","description":"Ford / Team Detroit custom player","fork":false,"url":"https://api.github.com/repos/BrightcovePS/FordPlayer","forks_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/forks","keys_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/teams","hooks_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/hooks","issue_events_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/issues/events{/number}","events_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/events","assignees_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/assignees{/user}","branches_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/branches{/branch}","tags_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/tags","blobs_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/statuses/{sha}","languages_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/languages","stargazers_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/stargazers","contributors_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/contributors","subscribers_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/subscribers","subscription_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/subscription","commits_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/contents/{+path}","compare_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/merges","archive_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/downloads","issues_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/issues{/number}","pulls_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/pulls{/number}","milestones_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/milestones{/number}","notifications_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/labels{/name}","releases_url":"https://api.github.com/repos/BrightcovePS/FordPlayer/releases{/id}","created_at":"2015-06-03T00:57:35Z","updated_at":"2015-06-03T00:57:35Z","pushed_at":"2015-06-18T20:17:08Z","git_url":"git://github.com/BrightcovePS/FordPlayer.git","ssh_url":"git@github.com:BrightcovePS/FordPlayer.git","clone_url":"https://github.com/BrightcovePS/FordPlayer.git","svn_url":"https://github.com/BrightcovePS/FordPlayer","homepage":null,"size":2040,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BrightcovePS/FordPlayer/pulls/14"},"html":{"href":"https://github.com/BrightcovePS/FordPlayer/pull/14"},"issue":{"href":"https://api.github.com/repos/BrightcovePS/FordPlayer/issues/14"},"comments":{"href":"https://api.github.com/repos/BrightcovePS/FordPlayer/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/BrightcovePS/FordPlayer/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/BrightcovePS/FordPlayer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BrightcovePS/FordPlayer/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/BrightcovePS/FordPlayer/statuses/ebb6dbb1a78fcd0d6de0f2b17b0da5e27e2119ca"}}}}