{"action":"closed","number":779,"pull_request":{"url":"https://api.github.com/repos/weaveworks/weave/pulls/779","id":36418747,"html_url":"https://github.com/weaveworks/weave/pull/779","diff_url":"https://github.com/weaveworks/weave/pull/779.diff","patch_url":"https://github.com/weaveworks/weave/pull/779.patch","issue_url":"https://api.github.com/repos/weaveworks/weave/issues/779","number":779,"state":"closed","locked":false,"title":"[ipam] Fix race conditions in unit tests","user":{"login":"bboreham","id":8125524,"avatar_url":"https://avatars.githubusercontent.com/u/8125524?v=3","gravatar_id":"","url":"https://api.github.com/users/bboreham","html_url":"https://github.com/bboreham","followers_url":"https://api.github.com/users/bboreham/followers","following_url":"https://api.github.com/users/bboreham/following{/other_user}","gists_url":"https://api.github.com/users/bboreham/gists{/gist_id}","starred_url":"https://api.github.com/users/bboreham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboreham/subscriptions","organizations_url":"https://api.github.com/users/bboreham/orgs","repos_url":"https://api.github.com/users/bboreham/repos","events_url":"https://api.github.com/users/bboreham/events{/privacy}","received_events_url":"https://api.github.com/users/bboreham/received_events","type":"User","site_admin":false},"body":"`go test -race` found a couple of race conditions in the ipam unit tests\r\n\r\nNote the race conditions arise purely from short-cuts in the unit tests, not from the deployed code.","created_at":"2015-05-28T15:26:05Z","updated_at":"2015-05-29T09:47:27Z","closed_at":"2015-05-29T09:47:27Z","merged_at":null,"merge_commit_sha":"847703fdf80005a2d472fa0ad721049256135681","assignee":{"login":"tomwilkie","id":444037,"avatar_url":"https://avatars.githubusercontent.com/u/444037?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwilkie","html_url":"https://github.com/tomwilkie","followers_url":"https://api.github.com/users/tomwilkie/followers","following_url":"https://api.github.com/users/tomwilkie/following{/other_user}","gists_url":"https://api.github.com/users/tomwilkie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwilkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwilkie/subscriptions","organizations_url":"https://api.github.com/users/tomwilkie/orgs","repos_url":"https://api.github.com/users/tomwilkie/repos","events_url":"https://api.github.com/users/tomwilkie/events{/privacy}","received_events_url":"https://api.github.com/users/tomwilkie/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/weaveworks/weave/pulls/779/commits","review_comments_url":"https://api.github.com/repos/weaveworks/weave/pulls/779/comments","review_comment_url":"https://api.github.com/repos/weaveworks/weave/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weaveworks/weave/issues/779/comments","statuses_url":"https://api.github.com/repos/weaveworks/weave/statuses/508951978fdda1c97938285fa0a40de10da6db23","head":{"label":"bboreham:ipam-panic-space","ref":"ipam-panic-space","sha":"508951978fdda1c97938285fa0a40de10da6db23","user":{"login":"bboreham","id":8125524,"avatar_url":"https://avatars.githubusercontent.com/u/8125524?v=3","gravatar_id":"","url":"https://api.github.com/users/bboreham","html_url":"https://github.com/bboreham","followers_url":"https://api.github.com/users/bboreham/followers","following_url":"https://api.github.com/users/bboreham/following{/other_user}","gists_url":"https://api.github.com/users/bboreham/gists{/gist_id}","starred_url":"https://api.github.com/users/bboreham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboreham/subscriptions","organizations_url":"https://api.github.com/users/bboreham/orgs","repos_url":"https://api.github.com/users/bboreham/repos","events_url":"https://api.github.com/users/bboreham/events{/privacy}","received_events_url":"https://api.github.com/users/bboreham/received_events","type":"User","site_admin":false},"repo":{"id":23360369,"name":"weave","full_name":"bboreham/weave","owner":{"login":"bboreham","id":8125524,"avatar_url":"https://avatars.githubusercontent.com/u/8125524?v=3","gravatar_id":"","url":"https://api.github.com/users/bboreham","html_url":"https://github.com/bboreham","followers_url":"https://api.github.com/users/bboreham/followers","following_url":"https://api.github.com/users/bboreham/following{/other_user}","gists_url":"https://api.github.com/users/bboreham/gists{/gist_id}","starred_url":"https://api.github.com/users/bboreham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboreham/subscriptions","organizations_url":"https://api.github.com/users/bboreham/orgs","repos_url":"https://api.github.com/users/bboreham/repos","events_url":"https://api.github.com/users/bboreham/events{/privacy}","received_events_url":"https://api.github.com/users/bboreham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bboreham/weave","description":"The Docker Network","fork":true,"url":"https://api.github.com/repos/bboreham/weave","forks_url":"https://api.github.com/repos/bboreham/weave/forks","keys_url":"https://api.github.com/repos/bboreham/weave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bboreham/weave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bboreham/weave/teams","hooks_url":"https://api.github.com/repos/bboreham/weave/hooks","issue_events_url":"https://api.github.com/repos/bboreham/weave/issues/events{/number}","events_url":"https://api.github.com/repos/bboreham/weave/events","assignees_url":"https://api.github.com/repos/bboreham/weave/assignees{/user}","branches_url":"https://api.github.com/repos/bboreham/weave/branches{/branch}","tags_url":"https://api.github.com/repos/bboreham/weave/tags","blobs_url":"https://api.github.com/repos/bboreham/weave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bboreham/weave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bboreham/weave/git/refs{/sha}","trees_url":"https://api.github.com/repos/bboreham/weave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bboreham/weave/statuses/{sha}","languages_url":"https://api.github.com/repos/bboreham/weave/languages","stargazers_url":"https://api.github.com/repos/bboreham/weave/stargazers","contributors_url":"https://api.github.com/repos/bboreham/weave/contributors","subscribers_url":"https://api.github.com/repos/bboreham/weave/subscribers","subscription_url":"https://api.github.com/repos/bboreham/weave/subscription","commits_url":"https://api.github.com/repos/bboreham/weave/commits{/sha}","git_commits_url":"https://api.github.com/repos/bboreham/weave/git/commits{/sha}","comments_url":"https://api.github.com/repos/bboreham/weave/comments{/number}","issue_comment_url":"https://api.github.com/repos/bboreham/weave/issues/comments{/number}","contents_url":"https://api.github.com/repos/bboreham/weave/contents/{+path}","compare_url":"https://api.github.com/repos/bboreham/weave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bboreham/weave/merges","archive_url":"https://api.github.com/repos/bboreham/weave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bboreham/weave/downloads","issues_url":"https://api.github.com/repos/bboreham/weave/issues{/number}","pulls_url":"https://api.github.com/repos/bboreham/weave/pulls{/number}","milestones_url":"https://api.github.com/repos/bboreham/weave/milestones{/number}","notifications_url":"https://api.github.com/repos/bboreham/weave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bboreham/weave/labels{/name}","releases_url":"https://api.github.com/repos/bboreham/weave/releases{/id}","created_at":"2014-08-26T17:24:12Z","updated_at":"2015-04-17T10:04:44Z","pushed_at":"2015-05-29T09:44:17Z","git_url":"git://github.com/bboreham/weave.git","ssh_url":"git@github.com:bboreham/weave.git","clone_url":"https://github.com/bboreham/weave.git","svn_url":"https://github.com/bboreham/weave","homepage":"","size":8100,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"weaveworks:master","ref":"master","sha":"ed133dfe0d231ad9aab70e8e9dc58bbba0638bb7","user":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":23059575,"name":"weave","full_name":"weaveworks/weave","owner":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weaveworks/weave","description":"The Docker Network","fork":false,"url":"https://api.github.com/repos/weaveworks/weave","forks_url":"https://api.github.com/repos/weaveworks/weave/forks","keys_url":"https://api.github.com/repos/weaveworks/weave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/weave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/weave/teams","hooks_url":"https://api.github.com/repos/weaveworks/weave/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/weave/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/weave/events","assignees_url":"https://api.github.com/repos/weaveworks/weave/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/weave/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/weave/tags","blobs_url":"https://api.github.com/repos/weaveworks/weave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/weave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/weave/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/weave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/weave/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/weave/languages","stargazers_url":"https://api.github.com/repos/weaveworks/weave/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/weave/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/weave/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/weave/subscription","commits_url":"https://api.github.com/repos/weaveworks/weave/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/weave/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/weave/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/weave/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/weave/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/weave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/weave/merges","archive_url":"https://api.github.com/repos/weaveworks/weave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/weave/downloads","issues_url":"https://api.github.com/repos/weaveworks/weave/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/weave/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/weave/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/weave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/weave/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/weave/releases{/id}","created_at":"2014-08-18T05:19:07Z","updated_at":"2015-05-29T08:45:46Z","pushed_at":"2015-05-29T09:47:16Z","git_url":"git://github.com/weaveworks/weave.git","ssh_url":"git@github.com:weaveworks/weave.git","clone_url":"https://github.com/weaveworks/weave.git","svn_url":"https://github.com/weaveworks/weave","homepage":"http://weave.works","size":12908,"stargazers_count":3346,"watchers_count":3346,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":184,"mirror_url":null,"open_issues_count":137,"forks":184,"open_issues":137,"watchers":3346,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/779"},"html":{"href":"https://github.com/weaveworks/weave/pull/779"},"issue":{"href":"https://api.github.com/repos/weaveworks/weave/issues/779"},"comments":{"href":"https://api.github.com/repos/weaveworks/weave/issues/779/comments"},"review_comments":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/779/comments"},"review_comment":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/779/commits"},"statuses":{"href":"https://api.github.com/repos/weaveworks/weave/statuses/508951978fdda1c97938285fa0a40de10da6db23"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":5,"additions":66,"deletions":8,"changed_files":4}}