{"action":"opened","number":222,"pull_request":{"url":"https://api.github.com/repos/ZipArchive/ZipArchive/pulls/222","id":54259156,"html_url":"https://github.com/ZipArchive/ZipArchive/pull/222","diff_url":"https://github.com/ZipArchive/ZipArchive/pull/222.diff","patch_url":"https://github.com/ZipArchive/ZipArchive/pull/222.patch","issue_url":"https://api.github.com/repos/ZipArchive/ZipArchive/issues/222","number":222,"state":"open","locked":false,"title":"Fix Carthage support","user":{"login":"GWStuartClift","id":1006684,"avatar_url":"https://avatars.githubusercontent.com/u/1006684?v=3","gravatar_id":"","url":"https://api.github.com/users/GWStuartClift","html_url":"https://github.com/GWStuartClift","followers_url":"https://api.github.com/users/GWStuartClift/followers","following_url":"https://api.github.com/users/GWStuartClift/following{/other_user}","gists_url":"https://api.github.com/users/GWStuartClift/gists{/gist_id}","starred_url":"https://api.github.com/users/GWStuartClift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GWStuartClift/subscriptions","organizations_url":"https://api.github.com/users/GWStuartClift/orgs","repos_url":"https://api.github.com/users/GWStuartClift/repos","events_url":"https://api.github.com/users/GWStuartClift/events{/privacy}","received_events_url":"https://api.github.com/users/GWStuartClift/received_events","type":"User","site_admin":false},"body":"### Example Project\r\n\r\n#### Carthage Support \r\n\r\nI've added Carthage to a new target on the example project. Carthage does not support building from local files the same way cocoapods does. So in order to test carthage is building before merging this PR you must make one of the following changes:\r\n\r\n##### Option 1 Cartfile for the example to point to this branch\r\n\r\n```\r\ngithub \"GWStuartClift/ZipArchive\" \"carthage-support\"\r\n```\r\n\r\n##### Option 2 build from parent directory\r\n\r\n1. Navigate to the root directory\r\n2. Run `carthage build --no-skip-current --platform ios`\r\n3. Open the SwiftExample and using the `SwiftExampleCarthage` target; remove current framework and re-link with the framework at `../Carthage/Build/iOS/ZipArchive.framework`\r\n4. Go to the *run script* phase and change the path of the input file to `$(SRCROOT)/../Carthage/Build/iOS/ZipArchive.framework`\r\n\r\n#### Module Name Issues\r\n\r\nThe module name for this project is `ZipArchive` however, the pod spec is listed as `SSZipArchive`. This presents a different `import` statement to those using Cocoapods/Carthage.\r\n\r\nWe should consider **either** \r\n- [Specifying the module name](https://guides.cocoapods.org/syntax/podspec.html#tab_module_name) Coaopods should use in the pod spec as `ZipArchive`, **this will require code changes for all framework users but**.\r\n  - This is my personal preference as it can be aligned with a release and makes everything consistent going forward.\r\n- Change the project build setting to make the module name `SSZipArchive`. This is inconsistent with the repo/framework's name making it harder to find and/or confusing to declare a dependency on `ZipArchive/ZipArchive` then `import SSZipArchive`.\r\n\r\nFixes #203 \r\n\r\nFeedback welcome.\r\n\r\n","created_at":"2015-12-21T14:02:24Z","updated_at":"2015-12-21T14:02:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ZipArchive/ZipArchive/pulls/222/commits","review_comments_url":"https://api.github.com/repos/ZipArchive/ZipArchive/pulls/222/comments","review_comment_url":"https://api.github.com/repos/ZipArchive/ZipArchive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ZipArchive/ZipArchive/issues/222/comments","statuses_url":"https://api.github.com/repos/ZipArchive/ZipArchive/statuses/5d7b8d8158562dbf36c89d8cf730b07342c83d90","head":{"label":"GWStuartClift:carthage-support","ref":"carthage-support","sha":"5d7b8d8158562dbf36c89d8cf730b07342c83d90","user":{"login":"GWStuartClift","id":1006684,"avatar_url":"https://avatars.githubusercontent.com/u/1006684?v=3","gravatar_id":"","url":"https://api.github.com/users/GWStuartClift","html_url":"https://github.com/GWStuartClift","followers_url":"https://api.github.com/users/GWStuartClift/followers","following_url":"https://api.github.com/users/GWStuartClift/following{/other_user}","gists_url":"https://api.github.com/users/GWStuartClift/gists{/gist_id}","starred_url":"https://api.github.com/users/GWStuartClift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GWStuartClift/subscriptions","organizations_url":"https://api.github.com/users/GWStuartClift/orgs","repos_url":"https://api.github.com/users/GWStuartClift/repos","events_url":"https://api.github.com/users/GWStuartClift/events{/privacy}","received_events_url":"https://api.github.com/users/GWStuartClift/received_events","type":"User","site_admin":false},"repo":{"id":48094435,"name":"ZipArchive","full_name":"GWStuartClift/ZipArchive","owner":{"login":"GWStuartClift","id":1006684,"avatar_url":"https://avatars.githubusercontent.com/u/1006684?v=3","gravatar_id":"","url":"https://api.github.com/users/GWStuartClift","html_url":"https://github.com/GWStuartClift","followers_url":"https://api.github.com/users/GWStuartClift/followers","following_url":"https://api.github.com/users/GWStuartClift/following{/other_user}","gists_url":"https://api.github.com/users/GWStuartClift/gists{/gist_id}","starred_url":"https://api.github.com/users/GWStuartClift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GWStuartClift/subscriptions","organizations_url":"https://api.github.com/users/GWStuartClift/orgs","repos_url":"https://api.github.com/users/GWStuartClift/repos","events_url":"https://api.github.com/users/GWStuartClift/events{/privacy}","received_events_url":"https://api.github.com/users/GWStuartClift/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GWStuartClift/ZipArchive","description":"ZipArchive is a simple utility class for zipping and unzipping files on iOS and Mac.","fork":true,"url":"https://api.github.com/repos/GWStuartClift/ZipArchive","forks_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/forks","keys_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/teams","hooks_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/hooks","issue_events_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/issues/events{/number}","events_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/events","assignees_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/assignees{/user}","branches_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/branches{/branch}","tags_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/tags","blobs_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/git/refs{/sha}","trees_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/statuses/{sha}","languages_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/languages","stargazers_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/stargazers","contributors_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/contributors","subscribers_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/subscribers","subscription_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/subscription","commits_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/commits{/sha}","git_commits_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/git/commits{/sha}","comments_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/comments{/number}","issue_comment_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/issues/comments{/number}","contents_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/contents/{+path}","compare_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/merges","archive_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/downloads","issues_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/issues{/number}","pulls_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/pulls{/number}","milestones_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/milestones{/number}","notifications_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/labels{/name}","releases_url":"https://api.github.com/repos/GWStuartClift/ZipArchive/releases{/id}","created_at":"2015-12-16T07:23:33Z","updated_at":"2015-12-16T07:23:35Z","pushed_at":"2015-12-21T13:44:24Z","git_url":"git://github.com/GWStuartClift/ZipArchive.git","ssh_url":"git@github.com:GWStuartClift/ZipArchive.git","clone_url":"https://github.com/GWStuartClift/ZipArchive.git","svn_url":"https://github.com/GWStuartClift/ZipArchive","homepage":"","size":2349,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ZipArchive:master","ref":"master","sha":"2b751f36d9b0b4eaab04ceff1effcaf3e6def8ec","user":{"login":"ZipArchive","id":11828824,"avatar_url":"https://avatars.githubusercontent.com/u/11828824?v=3","gravatar_id":"","url":"https://api.github.com/users/ZipArchive","html_url":"https://github.com/ZipArchive","followers_url":"https://api.github.com/users/ZipArchive/followers","following_url":"https://api.github.com/users/ZipArchive/following{/other_user}","gists_url":"https://api.github.com/users/ZipArchive/gists{/gist_id}","starred_url":"https://api.github.com/users/ZipArchive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZipArchive/subscriptions","organizations_url":"https://api.github.com/users/ZipArchive/orgs","repos_url":"https://api.github.com/users/ZipArchive/repos","events_url":"https://api.github.com/users/ZipArchive/events{/privacy}","received_events_url":"https://api.github.com/users/ZipArchive/received_events","type":"Organization","site_admin":false},"repo":{"id":849692,"name":"ZipArchive","full_name":"ZipArchive/ZipArchive","owner":{"login":"ZipArchive","id":11828824,"avatar_url":"https://avatars.githubusercontent.com/u/11828824?v=3","gravatar_id":"","url":"https://api.github.com/users/ZipArchive","html_url":"https://github.com/ZipArchive","followers_url":"https://api.github.com/users/ZipArchive/followers","following_url":"https://api.github.com/users/ZipArchive/following{/other_user}","gists_url":"https://api.github.com/users/ZipArchive/gists{/gist_id}","starred_url":"https://api.github.com/users/ZipArchive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZipArchive/subscriptions","organizations_url":"https://api.github.com/users/ZipArchive/orgs","repos_url":"https://api.github.com/users/ZipArchive/repos","events_url":"https://api.github.com/users/ZipArchive/events{/privacy}","received_events_url":"https://api.github.com/users/ZipArchive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ZipArchive/ZipArchive","description":"ZipArchive is a simple utility class for zipping and unzipping files on iOS and Mac.","fork":false,"url":"https://api.github.com/repos/ZipArchive/ZipArchive","forks_url":"https://api.github.com/repos/ZipArchive/ZipArchive/forks","keys_url":"https://api.github.com/repos/ZipArchive/ZipArchive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZipArchive/ZipArchive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZipArchive/ZipArchive/teams","hooks_url":"https://api.github.com/repos/ZipArchive/ZipArchive/hooks","issue_events_url":"https://api.github.com/repos/ZipArchive/ZipArchive/issues/events{/number}","events_url":"https://api.github.com/repos/ZipArchive/ZipArchive/events","assignees_url":"https://api.github.com/repos/ZipArchive/ZipArchive/assignees{/user}","branches_url":"https://api.github.com/repos/ZipArchive/ZipArchive/branches{/branch}","tags_url":"https://api.github.com/repos/ZipArchive/ZipArchive/tags","blobs_url":"https://api.github.com/repos/ZipArchive/ZipArchive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZipArchive/ZipArchive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZipArchive/ZipArchive/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZipArchive/ZipArchive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZipArchive/ZipArchive/statuses/{sha}","languages_url":"https://api.github.com/repos/ZipArchive/ZipArchive/languages","stargazers_url":"https://api.github.com/repos/ZipArchive/ZipArchive/stargazers","contributors_url":"https://api.github.com/repos/ZipArchive/ZipArchive/contributors","subscribers_url":"https://api.github.com/repos/ZipArchive/ZipArchive/subscribers","subscription_url":"https://api.github.com/repos/ZipArchive/ZipArchive/subscription","commits_url":"https://api.github.com/repos/ZipArchive/ZipArchive/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZipArchive/ZipArchive/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZipArchive/ZipArchive/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZipArchive/ZipArchive/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZipArchive/ZipArchive/contents/{+path}","compare_url":"https://api.github.com/repos/ZipArchive/ZipArchive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZipArchive/ZipArchive/merges","archive_url":"https://api.github.com/repos/ZipArchive/ZipArchive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZipArchive/ZipArchive/downloads","issues_url":"https://api.github.com/repos/ZipArchive/ZipArchive/issues{/number}","pulls_url":"https://api.github.com/repos/ZipArchive/ZipArchive/pulls{/number}","milestones_url":"https://api.github.com/repos/ZipArchive/ZipArchive/milestones{/number}","notifications_url":"https://api.github.com/repos/ZipArchive/ZipArchive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZipArchive/ZipArchive/labels{/name}","releases_url":"https://api.github.com/repos/ZipArchive/ZipArchive/releases{/id}","created_at":"2010-08-19T20:28:21Z","updated_at":"2015-12-21T08:40:07Z","pushed_at":"2015-12-15T17:34:08Z","git_url":"git://github.com/ZipArchive/ZipArchive.git","ssh_url":"git@github.com:ZipArchive/ZipArchive.git","clone_url":"https://github.com/ZipArchive/ZipArchive.git","svn_url":"https://github.com/ZipArchive/ZipArchive","homepage":"","size":2536,"stargazers_count":1493,"watchers_count":1493,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":478,"mirror_url":null,"open_issues_count":21,"forks":478,"open_issues":21,"watchers":1493,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ZipArchive/ZipArchive/pulls/222"},"html":{"href":"https://github.com/ZipArchive/ZipArchive/pull/222"},"issue":{"href":"https://api.github.com/repos/ZipArchive/ZipArchive/issues/222"},"comments":{"href":"https://api.github.com/repos/ZipArchive/ZipArchive/issues/222/comments"},"review_comments":{"href":"https://api.github.com/repos/ZipArchive/ZipArchive/pulls/222/comments"},"review_comment":{"href":"https://api.github.com/repos/ZipArchive/ZipArchive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ZipArchive/ZipArchive/pulls/222/commits"},"statuses":{"href":"https://api.github.com/repos/ZipArchive/ZipArchive/statuses/5d7b8d8158562dbf36c89d8cf730b07342c83d90"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":131,"deletions":4,"changed_files":6}}