{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/18312","labels_url":"https://api.github.com/repos/docker/docker/issues/18312/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/18312/comments","events_url":"https://api.github.com/repos/docker/docker/issues/18312/events","html_url":"https://github.com/docker/docker/pull/18312","id":119521787,"number":18312,"title":"Add list of containers to docker volume ls command","user":{"login":"brahmaroutu","id":5403596,"avatar_url":"https://avatars.githubusercontent.com/u/5403596?v=3","gravatar_id":"","url":"https://api.github.com/users/brahmaroutu","html_url":"https://github.com/brahmaroutu","followers_url":"https://api.github.com/users/brahmaroutu/followers","following_url":"https://api.github.com/users/brahmaroutu/following{/other_user}","gists_url":"https://api.github.com/users/brahmaroutu/gists{/gist_id}","starred_url":"https://api.github.com/users/brahmaroutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brahmaroutu/subscriptions","organizations_url":"https://api.github.com/users/brahmaroutu/orgs","repos_url":"https://api.github.com/users/brahmaroutu/repos","events_url":"https://api.github.com/users/brahmaroutu/events{/privacy}","received_events_url":"https://api.github.com/users/brahmaroutu/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/1-design-review","name":"status/1-design-review","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2015-11-30T16:00:28Z","updated_at":"2015-12-29T17:57:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/18312","html_url":"https://github.com/docker/docker/pull/18312","diff_url":"https://github.com/docker/docker/pull/18312.diff","patch_url":"https://github.com/docker/docker/pull/18312.patch"},"body":"Signed-off-by: Srini Brahmaroutu <srbrahma@us.ibm.com>\r\n\r\n\r\nThis PR is to list containers that are using the volumes. \r\nping @cpuguy83."},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/167843972","html_url":"https://github.com/docker/docker/pull/18312#issuecomment-167843972","issue_url":"https://api.github.com/repos/docker/docker/issues/18312","id":167843972,"user":{"login":"calavera","id":1050,"avatar_url":"https://avatars.githubusercontent.com/u/1050?v=3","gravatar_id":"","url":"https://api.github.com/users/calavera","html_url":"https://github.com/calavera","followers_url":"https://api.github.com/users/calavera/followers","following_url":"https://api.github.com/users/calavera/following{/other_user}","gists_url":"https://api.github.com/users/calavera/gists{/gist_id}","starred_url":"https://api.github.com/users/calavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calavera/subscriptions","organizations_url":"https://api.github.com/users/calavera/orgs","repos_url":"https://api.github.com/users/calavera/repos","events_url":"https://api.github.com/users/calavera/events{/privacy}","received_events_url":"https://api.github.com/users/calavera/received_events","type":"User","site_admin":false},"created_at":"2015-12-29T17:57:13Z","updated_at":"2015-12-29T17:57:13Z","body":"Sorry, but I still don't like this change :pensive:\r\n\r\nWe already have the information about volumes attached to containers in the container payload. There is no need to duplicate it. That information would be more useful for everyone if we exposed it in `docker ps`, like I suggested in the beginning.\r\n\r\n> But we need a data model change to capture this association either through some notification model into container framework to signal attach/detach of volumes, etc and maintain that list as part of volume or seperately.\r\n\r\nAs I said, that information is stored with each container.\r\n\r\n> For now this is the best approach I can think of. Please let me know if you have any ideas that I can explore.\r\n\r\nThis change is very inconsistent. Why would people use `docker ps` to get all kind of information about containers but `docker volume ls` to get information about volumes attached to containers? `docker ps` should be the source of truth to any information related to containers, and volumes attached to containers is part of that information. `docker volume ls` is the command to list volumes in the system, attached to containers or not, it's not its responsibility to know which volumes are attached to containers.\r\n\r\nThis change does NOT LGTM."}}