{"action":"created","issue":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/2211","labels_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2211/labels{/name}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2211/comments","events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2211/events","html_url":"https://github.com/mne-tools/mne-python/pull/2211","id":88863324,"number":2211,"title":"MRG: Refactor Epochs classes","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/mne-tools/mne-python/milestones/6","html_url":"https://github.com/mne-tools/mne-python/milestones/0.10","labels_url":"https://api.github.com/repos/mne-tools/mne-python/milestones/6/labels","id":1074222,"number":6,"title":"0.10","description":"","creator":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"open_issues":33,"closed_issues":23,"state":"open","created_at":"2015-04-19T22:04:00Z","updated_at":"2015-06-24T07:46:20Z","due_on":"2015-09-30T07:00:00Z","closed_at":null},"comments":56,"created_at":"2015-06-16T23:08:11Z","updated_at":"2015-06-24T19:06:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2211","html_url":"https://github.com/mne-tools/mne-python/pull/2211","diff_url":"https://github.com/mne-tools/mne-python/pull/2211.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/2211.patch"},"body":"Not working yet. I hope to keep this more red than green. To-do list:\r\n\r\n* [x] Move methods to `_BaseEpochs`\r\n* [x] Make `EpochsArray` subclass `_BaseEpochs` instead of `Epochs`\r\n* [x] Refactor how projection is done (move to `_BaseEpochs` constructor; #2200)\r\n* [x] Refactor how decimation is done (add method, call it in constructor; #2178)\r\n* [x] Refactor how rejection/dropping is done (add method; #1893)\r\n* [x] Get EpochsArray working again\r\n* [x] Fix RtEpochs\r\n* [x] Fix EpochsKit, make it subclass `_BaseEpochs` instead of `EpochsArray` (which in turn had been subclassing `Epochs`)\r\n* [x] Add stronger docstring note about raw resampling / epoch decimation.\r\n* [x] Add test of proj (#2200)\r\n* [x] Add tests of EpochsArray mentioned in #1963\r\n* [x] Add tests of repeated decimation (#2178)\r\n* [x] Add tests of repeated dropping (#1893)\r\n\r\nCloses #2225.\r\nCloses #2200.\r\nCloses #2178.\r\nCloses #1982.\r\nCloses #1893."},"comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments/114982815","html_url":"https://github.com/mne-tools/mne-python/pull/2211#issuecomment-114982815","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2211","id":114982815,"user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"created_at":"2015-06-24T19:06:55Z","updated_at":"2015-06-24T19:06:55Z","body":"Thanks @mainakjas I'll try to fix it today"}}