{"action":"created","issue":{"url":"https://api.github.com/repos/LMMS/lmms/issues/1888","labels_url":"https://api.github.com/repos/LMMS/lmms/issues/1888/labels{/name}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/1888/comments","events_url":"https://api.github.com/repos/LMMS/lmms/issues/1888/events","html_url":"https://github.com/LMMS/lmms/pull/1888","id":63080273,"number":1888,"title":"Multiband EQ Adjusted windowing to remove distortion.","user":{"login":"curlymorphic","id":7412852,"avatar_url":"https://avatars.githubusercontent.com/u/7412852?v=3","gravatar_id":"","url":"https://api.github.com/users/curlymorphic","html_url":"https://github.com/curlymorphic","followers_url":"https://api.github.com/users/curlymorphic/followers","following_url":"https://api.github.com/users/curlymorphic/following{/other_user}","gists_url":"https://api.github.com/users/curlymorphic/gists{/gist_id}","starred_url":"https://api.github.com/users/curlymorphic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curlymorphic/subscriptions","organizations_url":"https://api.github.com/users/curlymorphic/orgs","repos_url":"https://api.github.com/users/curlymorphic/repos","events_url":"https://api.github.com/users/curlymorphic/events{/privacy}","received_events_url":"https://api.github.com/users/curlymorphic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-03-19T20:09:05Z","updated_at":"2015-03-19T20:32:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/1888","html_url":"https://github.com/LMMS/lmms/pull/1888","diff_url":"https://github.com/LMMS/lmms/pull/1888.diff","patch_url":"https://github.com/LMMS/lmms/pull/1888.patch"},"body":"Removed the incorrectly applied windowing to the input of the FFT.\r\n\r\nfixes #1885 "},"comment":{"url":"https://api.github.com/repos/LMMS/lmms/issues/comments/83753327","html_url":"https://github.com/LMMS/lmms/pull/1888#issuecomment-83753327","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/1888","id":83753327,"user":{"login":"geedubess","id":10860202,"avatar_url":"https://avatars.githubusercontent.com/u/10860202?v=3","gravatar_id":"","url":"https://api.github.com/users/geedubess","html_url":"https://github.com/geedubess","followers_url":"https://api.github.com/users/geedubess/followers","following_url":"https://api.github.com/users/geedubess/following{/other_user}","gists_url":"https://api.github.com/users/geedubess/gists{/gist_id}","starred_url":"https://api.github.com/users/geedubess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geedubess/subscriptions","organizations_url":"https://api.github.com/users/geedubess/orgs","repos_url":"https://api.github.com/users/geedubess/repos","events_url":"https://api.github.com/users/geedubess/events{/privacy}","received_events_url":"https://api.github.com/users/geedubess/received_events","type":"User","site_admin":false},"created_at":"2015-03-19T20:32:11Z","updated_at":"2015-03-19T20:32:11Z","body":"/delurk*\n\n$.02 - if you're no longer applying the window there, perhaps an\nupdate to the comment above (\"// Window input FIFO\") is needed as well?\n\nI'm trying to remember my DSP. I see the windowing being applied in the\noutput buffer post-FFT, but isn't the idea to apply a windowing function\n*before* FFT to reduce the spectral leakage of a discontinuous input?\n\ncheers,\nGreg\n\n* Trying to learn and figure out where I may be able to contribute to LMMS.\n\n"}}