{"action":"created","issue":{"url":"https://api.github.com/repos/sabdesoto/Sab_Final_Project/issues/3","labels_url":"https://api.github.com/repos/sabdesoto/Sab_Final_Project/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/sabdesoto/Sab_Final_Project/issues/3/comments","events_url":"https://api.github.com/repos/sabdesoto/Sab_Final_Project/issues/3/events","html_url":"https://github.com/sabdesoto/Sab_Final_Project/pull/3","id":116174085,"number":3,"title":" Added my comments on Sabrina's code","user":{"login":"Jhanelle","id":15349801,"avatar_url":"https://avatars.githubusercontent.com/u/15349801?v=3","gravatar_id":"","url":"https://api.github.com/users/Jhanelle","html_url":"https://github.com/Jhanelle","followers_url":"https://api.github.com/users/Jhanelle/followers","following_url":"https://api.github.com/users/Jhanelle/following{/other_user}","gists_url":"https://api.github.com/users/Jhanelle/gists{/gist_id}","starred_url":"https://api.github.com/users/Jhanelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jhanelle/subscriptions","organizations_url":"https://api.github.com/users/Jhanelle/orgs","repos_url":"https://api.github.com/users/Jhanelle/repos","events_url":"https://api.github.com/users/Jhanelle/events{/privacy}","received_events_url":"https://api.github.com/users/Jhanelle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-10T18:43:04Z","updated_at":"2015-11-12T19:20:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sabdesoto/Sab_Final_Project/pulls/3","html_url":"https://github.com/sabdesoto/Sab_Final_Project/pull/3","diff_url":"https://github.com/sabdesoto/Sab_Final_Project/pull/3.diff","patch_url":"https://github.com/sabdesoto/Sab_Final_Project/pull/3.patch"},"body":"Summary of edits to code\r\n\r\nThus far your codes are easily readable and your functions are clearly defined with good variable names. \r\n\r\nYou mentioned that you needed to include statistics in your report, as such in the second cell in the python document I recommended a few statistical tools which could be used for your data depending on whether it follows a normal distribution.  I also included the stats library needed to complete such analysis.  In addition to these statistical tools, I provided you with a template for these codes that can be applied to your data. \r\n\r\nI also included a group by function that can be used to organize your data seeing that you are considering set groups to run your analysis.\r\n\r\nWhen loading your data, it would have been more helpful if you only showed the head of your data seeing that you have such a large data set. \r\nThere were a few spelling errors in your comments, however I did not change these as I assumed that seeing that this is a draft for your codes your are less concerned about the spelling errors and more about the accuracy of your code. \r\n\r\n\r\n\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/sabdesoto/Sab_Final_Project/issues/comments/156207021","html_url":"https://github.com/sabdesoto/Sab_Final_Project/pull/3#issuecomment-156207021","issue_url":"https://api.github.com/repos/sabdesoto/Sab_Final_Project/issues/3","id":156207021,"user":{"login":"Jhanelle","id":15349801,"avatar_url":"https://avatars.githubusercontent.com/u/15349801?v=3","gravatar_id":"","url":"https://api.github.com/users/Jhanelle","html_url":"https://github.com/Jhanelle","followers_url":"https://api.github.com/users/Jhanelle/followers","following_url":"https://api.github.com/users/Jhanelle/following{/other_user}","gists_url":"https://api.github.com/users/Jhanelle/gists{/gist_id}","starred_url":"https://api.github.com/users/Jhanelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jhanelle/subscriptions","organizations_url":"https://api.github.com/users/Jhanelle/orgs","repos_url":"https://api.github.com/users/Jhanelle/repos","events_url":"https://api.github.com/users/Jhanelle/events{/privacy}","received_events_url":"https://api.github.com/users/Jhanelle/received_events","type":"User","site_admin":false},"created_at":"2015-11-12T19:20:28Z","updated_at":"2015-11-12T19:20:28Z","body":"\r\nYour 10 mins plan was relatively clear, I will not focus mainly on that seeing that it was mentioned in the last code review. It is good that you chose to load your data using panda seeing that it can load large data and complete other functions. I would suggest having a matplotlib.pyplot as plt seeing that you will need it for graphs. It is good that you only showed the head of the data. \r\n\r\nAll your codes worked except: group1=pd.read_table('sabrina.dat', sep='\\s+'). There was a tokenizing error so I made the necessary changes in the following row which worked. \r\n\r\nIn the section where you tried looping the data in, this was a similar error. My comments can be found in the ipython notebook.\r\n\r\nGeneral Comments- It is good that you are attempting to load your data in as a loop seeing that makes your code reusable and efficient. Additionally your functions are simple and clear."}}