{"action":"created","comment":{"url":"https://api.github.com/repos/opencomputeproject/onie/pulls/comments/42882957","id":42882957,"diff_hunk":"@@ -68,6 +69,7 @@ do_start() {\n             install_remain_sticky_arch || {\n                 echo \"Error: problems making install boot mode sticky\" > /dev/console\n             }\n+            sync;sync","path":"rootconf/default/etc/init.d/discover.sh","position":12,"original_position":12,"commit_id":"54c005eb5ae2c93b94d055be4172c192f64a2ccc","original_commit_id":"b4ad7a54adde110ae232cd72b6565906a57bfa34","user":{"login":"cbrune","id":344659,"avatar_url":"https://avatars.githubusercontent.com/u/344659?v=3","gravatar_id":"","url":"https://api.github.com/users/cbrune","html_url":"https://github.com/cbrune","followers_url":"https://api.github.com/users/cbrune/followers","following_url":"https://api.github.com/users/cbrune/following{/other_user}","gists_url":"https://api.github.com/users/cbrune/gists{/gist_id}","starred_url":"https://api.github.com/users/cbrune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbrune/subscriptions","organizations_url":"https://api.github.com/users/cbrune/orgs","repos_url":"https://api.github.com/users/cbrune/repos","events_url":"https://api.github.com/users/cbrune/events{/privacy}","received_events_url":"https://api.github.com/users/cbrune/received_events","type":"User","site_admin":false},"body":"I don't think so.  u-boot env variables are kept in a mtd device, not a mtdblock device.  sync applies to *filesystems*.  There is no filesystem on a mtd device.","created_at":"2015-10-23T16:07:27Z","updated_at":"2015-10-23T16:07:27Z","html_url":"https://github.com/opencomputeproject/onie/pull/281#discussion_r42882957","pull_request_url":"https://api.github.com/repos/opencomputeproject/onie/pulls/281","_links":{"self":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/comments/42882957"},"html":{"href":"https://github.com/opencomputeproject/onie/pull/281#discussion_r42882957"},"pull_request":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/281"}}},"pull_request":{"url":"https://api.github.com/repos/opencomputeproject/onie/pulls/281","id":48445501,"html_url":"https://github.com/opencomputeproject/onie/pull/281","diff_url":"https://github.com/opencomputeproject/onie/pull/281.diff","patch_url":"https://github.com/opencomputeproject/onie/pull/281.patch","issue_url":"https://api.github.com/repos/opencomputeproject/onie/issues/281","number":281,"state":"open","locked":false,"title":"install mode: sync data to storage after making install boot mode sticky","user":{"login":"david56","id":8021507,"avatar_url":"https://avatars.githubusercontent.com/u/8021507?v=3","gravatar_id":"","url":"https://api.github.com/users/david56","html_url":"https://github.com/david56","followers_url":"https://api.github.com/users/david56/followers","following_url":"https://api.github.com/users/david56/following{/other_user}","gists_url":"https://api.github.com/users/david56/gists{/gist_id}","starred_url":"https://api.github.com/users/david56/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david56/subscriptions","organizations_url":"https://api.github.com/users/david56/orgs","repos_url":"https://api.github.com/users/david56/repos","events_url":"https://api.github.com/users/david56/events{/privacy}","received_events_url":"https://api.github.com/users/david56/received_events","type":"User","site_admin":false},"body":"Force to write data to storage after making install boot mode sticky.\r\nIt will prevent grub to be invalid after entering linux shell and power\r\noff suddenly.\r\n\r\nThe issue was reported in\r\nhttps://github.com/opencomputeproject/onie/issues/250\r\n\r\nThis patch has been tested in Accton AS5512_54X.","created_at":"2015-10-22T11:20:31Z","updated_at":"2015-10-23T16:07:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc9cb82e67173da47f81ef0dd00e1829e65718a0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opencomputeproject/onie/pulls/281/commits","review_comments_url":"https://api.github.com/repos/opencomputeproject/onie/pulls/281/comments","review_comment_url":"https://api.github.com/repos/opencomputeproject/onie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencomputeproject/onie/issues/281/comments","statuses_url":"https://api.github.com/repos/opencomputeproject/onie/statuses/54c005eb5ae2c93b94d055be4172c192f64a2ccc","head":{"label":"david56:install-mode-sticky-sync","ref":"install-mode-sticky-sync","sha":"54c005eb5ae2c93b94d055be4172c192f64a2ccc","user":{"login":"david56","id":8021507,"avatar_url":"https://avatars.githubusercontent.com/u/8021507?v=3","gravatar_id":"","url":"https://api.github.com/users/david56","html_url":"https://github.com/david56","followers_url":"https://api.github.com/users/david56/followers","following_url":"https://api.github.com/users/david56/following{/other_user}","gists_url":"https://api.github.com/users/david56/gists{/gist_id}","starred_url":"https://api.github.com/users/david56/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david56/subscriptions","organizations_url":"https://api.github.com/users/david56/orgs","repos_url":"https://api.github.com/users/david56/repos","events_url":"https://api.github.com/users/david56/events{/privacy}","received_events_url":"https://api.github.com/users/david56/received_events","type":"User","site_admin":false},"repo":{"id":21339446,"name":"onie","full_name":"david56/onie","owner":{"login":"david56","id":8021507,"avatar_url":"https://avatars.githubusercontent.com/u/8021507?v=3","gravatar_id":"","url":"https://api.github.com/users/david56","html_url":"https://github.com/david56","followers_url":"https://api.github.com/users/david56/followers","following_url":"https://api.github.com/users/david56/following{/other_user}","gists_url":"https://api.github.com/users/david56/gists{/gist_id}","starred_url":"https://api.github.com/users/david56/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david56/subscriptions","organizations_url":"https://api.github.com/users/david56/orgs","repos_url":"https://api.github.com/users/david56/repos","events_url":"https://api.github.com/users/david56/events{/privacy}","received_events_url":"https://api.github.com/users/david56/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/david56/onie","description":"This is the code repository for ONIE.","fork":true,"url":"https://api.github.com/repos/david56/onie","forks_url":"https://api.github.com/repos/david56/onie/forks","keys_url":"https://api.github.com/repos/david56/onie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/david56/onie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/david56/onie/teams","hooks_url":"https://api.github.com/repos/david56/onie/hooks","issue_events_url":"https://api.github.com/repos/david56/onie/issues/events{/number}","events_url":"https://api.github.com/repos/david56/onie/events","assignees_url":"https://api.github.com/repos/david56/onie/assignees{/user}","branches_url":"https://api.github.com/repos/david56/onie/branches{/branch}","tags_url":"https://api.github.com/repos/david56/onie/tags","blobs_url":"https://api.github.com/repos/david56/onie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/david56/onie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/david56/onie/git/refs{/sha}","trees_url":"https://api.github.com/repos/david56/onie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/david56/onie/statuses/{sha}","languages_url":"https://api.github.com/repos/david56/onie/languages","stargazers_url":"https://api.github.com/repos/david56/onie/stargazers","contributors_url":"https://api.github.com/repos/david56/onie/contributors","subscribers_url":"https://api.github.com/repos/david56/onie/subscribers","subscription_url":"https://api.github.com/repos/david56/onie/subscription","commits_url":"https://api.github.com/repos/david56/onie/commits{/sha}","git_commits_url":"https://api.github.com/repos/david56/onie/git/commits{/sha}","comments_url":"https://api.github.com/repos/david56/onie/comments{/number}","issue_comment_url":"https://api.github.com/repos/david56/onie/issues/comments{/number}","contents_url":"https://api.github.com/repos/david56/onie/contents/{+path}","compare_url":"https://api.github.com/repos/david56/onie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/david56/onie/merges","archive_url":"https://api.github.com/repos/david56/onie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/david56/onie/downloads","issues_url":"https://api.github.com/repos/david56/onie/issues{/number}","pulls_url":"https://api.github.com/repos/david56/onie/pulls{/number}","milestones_url":"https://api.github.com/repos/david56/onie/milestones{/number}","notifications_url":"https://api.github.com/repos/david56/onie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/david56/onie/labels{/name}","releases_url":"https://api.github.com/repos/david56/onie/releases{/id}","created_at":"2014-06-30T04:22:12Z","updated_at":"2015-05-08T00:49:05Z","pushed_at":"2015-10-23T09:26:46Z","git_url":"git://github.com/david56/onie.git","ssh_url":"git@github.com:david56/onie.git","clone_url":"https://github.com/david56/onie.git","svn_url":"https://github.com/david56/onie","homepage":null,"size":91524,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencomputeproject:master","ref":"master","sha":"b80f52ba5b6069eaa2beacdac4a06a29c67df8a4","user":{"login":"opencomputeproject","id":4722382,"avatar_url":"https://avatars.githubusercontent.com/u/4722382?v=3","gravatar_id":"","url":"https://api.github.com/users/opencomputeproject","html_url":"https://github.com/opencomputeproject","followers_url":"https://api.github.com/users/opencomputeproject/followers","following_url":"https://api.github.com/users/opencomputeproject/following{/other_user}","gists_url":"https://api.github.com/users/opencomputeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/opencomputeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencomputeproject/subscriptions","organizations_url":"https://api.github.com/users/opencomputeproject/orgs","repos_url":"https://api.github.com/users/opencomputeproject/repos","events_url":"https://api.github.com/users/opencomputeproject/events{/privacy}","received_events_url":"https://api.github.com/users/opencomputeproject/received_events","type":"User","site_admin":false},"repo":{"id":21219871,"name":"onie","full_name":"opencomputeproject/onie","owner":{"login":"opencomputeproject","id":4722382,"avatar_url":"https://avatars.githubusercontent.com/u/4722382?v=3","gravatar_id":"","url":"https://api.github.com/users/opencomputeproject","html_url":"https://github.com/opencomputeproject","followers_url":"https://api.github.com/users/opencomputeproject/followers","following_url":"https://api.github.com/users/opencomputeproject/following{/other_user}","gists_url":"https://api.github.com/users/opencomputeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/opencomputeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencomputeproject/subscriptions","organizations_url":"https://api.github.com/users/opencomputeproject/orgs","repos_url":"https://api.github.com/users/opencomputeproject/repos","events_url":"https://api.github.com/users/opencomputeproject/events{/privacy}","received_events_url":"https://api.github.com/users/opencomputeproject/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/opencomputeproject/onie","description":"This is the code repository for ONIE.","fork":false,"url":"https://api.github.com/repos/opencomputeproject/onie","forks_url":"https://api.github.com/repos/opencomputeproject/onie/forks","keys_url":"https://api.github.com/repos/opencomputeproject/onie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencomputeproject/onie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencomputeproject/onie/teams","hooks_url":"https://api.github.com/repos/opencomputeproject/onie/hooks","issue_events_url":"https://api.github.com/repos/opencomputeproject/onie/issues/events{/number}","events_url":"https://api.github.com/repos/opencomputeproject/onie/events","assignees_url":"https://api.github.com/repos/opencomputeproject/onie/assignees{/user}","branches_url":"https://api.github.com/repos/opencomputeproject/onie/branches{/branch}","tags_url":"https://api.github.com/repos/opencomputeproject/onie/tags","blobs_url":"https://api.github.com/repos/opencomputeproject/onie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencomputeproject/onie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencomputeproject/onie/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencomputeproject/onie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencomputeproject/onie/statuses/{sha}","languages_url":"https://api.github.com/repos/opencomputeproject/onie/languages","stargazers_url":"https://api.github.com/repos/opencomputeproject/onie/stargazers","contributors_url":"https://api.github.com/repos/opencomputeproject/onie/contributors","subscribers_url":"https://api.github.com/repos/opencomputeproject/onie/subscribers","subscription_url":"https://api.github.com/repos/opencomputeproject/onie/subscription","commits_url":"https://api.github.com/repos/opencomputeproject/onie/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencomputeproject/onie/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencomputeproject/onie/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencomputeproject/onie/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencomputeproject/onie/contents/{+path}","compare_url":"https://api.github.com/repos/opencomputeproject/onie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencomputeproject/onie/merges","archive_url":"https://api.github.com/repos/opencomputeproject/onie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencomputeproject/onie/downloads","issues_url":"https://api.github.com/repos/opencomputeproject/onie/issues{/number}","pulls_url":"https://api.github.com/repos/opencomputeproject/onie/pulls{/number}","milestones_url":"https://api.github.com/repos/opencomputeproject/onie/milestones{/number}","notifications_url":"https://api.github.com/repos/opencomputeproject/onie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencomputeproject/onie/labels{/name}","releases_url":"https://api.github.com/repos/opencomputeproject/onie/releases{/id}","created_at":"2014-06-25T21:52:35Z","updated_at":"2015-10-21T00:17:03Z","pushed_at":"2015-10-23T09:26:46Z","git_url":"git://github.com/opencomputeproject/onie.git","ssh_url":"git@github.com:opencomputeproject/onie.git","clone_url":"https://github.com/opencomputeproject/onie.git","svn_url":"https://github.com/opencomputeproject/onie","homepage":null,"size":96758,"stargazers_count":85,"watchers_count":85,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":65,"mirror_url":null,"open_issues_count":18,"forks":65,"open_issues":18,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/281"},"html":{"href":"https://github.com/opencomputeproject/onie/pull/281"},"issue":{"href":"https://api.github.com/repos/opencomputeproject/onie/issues/281"},"comments":{"href":"https://api.github.com/repos/opencomputeproject/onie/issues/281/comments"},"review_comments":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/281/comments"},"review_comment":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/281/commits"},"statuses":{"href":"https://api.github.com/repos/opencomputeproject/onie/statuses/54c005eb5ae2c93b94d055be4172c192f64a2ccc"}}}}