{"action":"created","comment":{"url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/comments/46355516","id":46355516,"diff_hunk":"@@ -425,7 +425,8 @@ require(\"../html5-common/js/utils/utils.js\");\n           //displaying it, so just notify AMC that we are showing an overlay.\n           else\n           {\n-            _amc.notifyNonlinearAdStarted(this.currentAMCAdPod.id);\n+            // raise WILL_PLAY_NONLINEAR_AD event and notify nonlinear ad started\n+            _amc.sendURLToLoadAndPlayNonLinearAd(this.currentAMCAdPod, this.currentAMCAdPod.id, this.currentAMCAdPod.ad.tag_url);","path":"js/google_ima.js","position":6,"original_position":6,"commit_id":"2297c1f5017915296958c32c209c8a30500634d5","original_commit_id":"2297c1f5017915296958c32c209c8a30500634d5","user":{"login":"dchauOoyala","id":15880169,"avatar_url":"https://avatars.githubusercontent.com/u/15880169?v=3","gravatar_id":"","url":"https://api.github.com/users/dchauOoyala","html_url":"https://github.com/dchauOoyala","followers_url":"https://api.github.com/users/dchauOoyala/followers","following_url":"https://api.github.com/users/dchauOoyala/following{/other_user}","gists_url":"https://api.github.com/users/dchauOoyala/gists{/gist_id}","starred_url":"https://api.github.com/users/dchauOoyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchauOoyala/subscriptions","organizations_url":"https://api.github.com/users/dchauOoyala/orgs","repos_url":"https://api.github.com/users/dchauOoyala/repos","events_url":"https://api.github.com/users/dchauOoyala/events{/privacy}","received_events_url":"https://api.github.com/users/dchauOoyala/received_events","type":"User","site_admin":false},"body":"In regards to the url, I was not aware of its implications. I saw that in\nvast, the streamurl was passed into the sendURL function. Can you guys tell\nme what the difference is?\n\nAnd yes, sendURL does have the notify fun toon within it so the sendURL\ndoes replace it.\nOn Dec 1, 2015 3:14 PM, \"gfrankOoyala\" <notifications@github.com> wrote:\n\n> In js/google_ima.js\n> <https://github.com/ooyala/html5-ad-plugins/pull/16#discussion_r46354703>:\n>\n> > @@ -425,7 +425,8 @@ require(\"../html5-common/js/utils/utils.js\");\n> >            //displaying it, so just notify AMC that we are showing an overlay.\n> >            else\n> >            {\n> > -            _amc.notifyNonlinearAdStarted(this.currentAMCAdPod.id);\n> > +            // raise WILL_PLAY_NONLINEAR_AD event and notify nonlinear ad started\n> > +            _amc.sendURLToLoadAndPlayNonLinearAd(this.currentAMCAdPod, this.currentAMCAdPod.id, this.currentAMCAdPod.ad.tag_url);\n>\n> That is called by sendURL, I just double checked.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/ooyala/html5-ad-plugins/pull/16/files#r46354703>.\n>\n","created_at":"2015-12-01T23:22:15Z","updated_at":"2015-12-01T23:22:15Z","html_url":"https://github.com/ooyala/html5-ad-plugins/pull/16#discussion_r46355516","pull_request_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/comments/46355516"},"html":{"href":"https://github.com/ooyala/html5-ad-plugins/pull/16#discussion_r46355516"},"pull_request":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/16","id":52325035,"html_url":"https://github.com/ooyala/html5-ad-plugins/pull/16","diff_url":"https://github.com/ooyala/html5-ad-plugins/pull/16.diff","patch_url":"https://github.com/ooyala/html5-ad-plugins/pull/16.patch","issue_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/16","number":16,"state":"open","locked":false,"title":"[PBI-1191] Call function to raise WILL_PLAY_NONLINEAR_AD event in Google IMA and Freewheel","user":{"login":"dchauOoyala","id":15880169,"avatar_url":"https://avatars.githubusercontent.com/u/15880169?v=3","gravatar_id":"","url":"https://api.github.com/users/dchauOoyala","html_url":"https://github.com/dchauOoyala","followers_url":"https://api.github.com/users/dchauOoyala/followers","following_url":"https://api.github.com/users/dchauOoyala/following{/other_user}","gists_url":"https://api.github.com/users/dchauOoyala/gists{/gist_id}","starred_url":"https://api.github.com/users/dchauOoyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchauOoyala/subscriptions","organizations_url":"https://api.github.com/users/dchauOoyala/orgs","repos_url":"https://api.github.com/users/dchauOoyala/repos","events_url":"https://api.github.com/users/dchauOoyala/events{/privacy}","received_events_url":"https://api.github.com/users/dchauOoyala/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-01T22:21:15Z","updated_at":"2015-12-01T23:22:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce9cabb4849c02176c5fe13f7adac1c915f64b30","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/16/commits","review_comments_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/16/comments","review_comment_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/16/comments","statuses_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/statuses/2297c1f5017915296958c32c209c8a30500634d5","head":{"label":"ooyala:PBI-1191","ref":"PBI-1191","sha":"2297c1f5017915296958c32c209c8a30500634d5","user":{"login":"ooyala","id":365274,"avatar_url":"https://avatars.githubusercontent.com/u/365274?v=3","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"repo":{"id":33886489,"name":"html5-ad-plugins","full_name":"ooyala/html5-ad-plugins","owner":{"login":"ooyala","id":365274,"avatar_url":"https://avatars.githubusercontent.com/u/365274?v=3","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ooyala/html5-ad-plugins","description":"","fork":false,"url":"https://api.github.com/repos/ooyala/html5-ad-plugins","forks_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/forks","keys_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/teams","hooks_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/hooks","issue_events_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/events","assignees_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/tags","blobs_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/languages","stargazers_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/stargazers","contributors_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/contributors","subscribers_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/subscribers","subscription_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/subscription","commits_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/merges","archive_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/downloads","issues_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/labels{/name}","releases_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/releases{/id}","created_at":"2015-04-13T18:37:19Z","updated_at":"2015-10-28T04:39:17Z","pushed_at":"2015-12-01T23:04:50Z","git_url":"git://github.com/ooyala/html5-ad-plugins.git","ssh_url":"git@github.com:ooyala/html5-ad-plugins.git","clone_url":"https://github.com/ooyala/html5-ad-plugins.git","svn_url":"https://github.com/ooyala/html5-ad-plugins","homepage":null,"size":167,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"ooyala:master","ref":"master","sha":"16573536c1e25d7c4f02acb86406e81fa41f594f","user":{"login":"ooyala","id":365274,"avatar_url":"https://avatars.githubusercontent.com/u/365274?v=3","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"repo":{"id":33886489,"name":"html5-ad-plugins","full_name":"ooyala/html5-ad-plugins","owner":{"login":"ooyala","id":365274,"avatar_url":"https://avatars.githubusercontent.com/u/365274?v=3","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ooyala/html5-ad-plugins","description":"","fork":false,"url":"https://api.github.com/repos/ooyala/html5-ad-plugins","forks_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/forks","keys_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/teams","hooks_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/hooks","issue_events_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/events","assignees_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/tags","blobs_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/languages","stargazers_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/stargazers","contributors_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/contributors","subscribers_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/subscribers","subscription_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/subscription","commits_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/merges","archive_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/downloads","issues_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/labels{/name}","releases_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/releases{/id}","created_at":"2015-04-13T18:37:19Z","updated_at":"2015-10-28T04:39:17Z","pushed_at":"2015-12-01T23:04:50Z","git_url":"git://github.com/ooyala/html5-ad-plugins.git","ssh_url":"git@github.com:ooyala/html5-ad-plugins.git","clone_url":"https://github.com/ooyala/html5-ad-plugins.git","svn_url":"https://github.com/ooyala/html5-ad-plugins","homepage":null,"size":167,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/16"},"html":{"href":"https://github.com/ooyala/html5-ad-plugins/pull/16"},"issue":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/16"},"comments":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/statuses/2297c1f5017915296958c32c209c8a30500634d5"}}}}