{"action":"closed","number":179,"pull_request":{"url":"https://api.github.com/repos/liamja/Prebake/pulls/179","id":47364434,"html_url":"https://github.com/liamja/Prebake/pull/179","diff_url":"https://github.com/liamja/Prebake/pull/179.diff","patch_url":"https://github.com/liamja/Prebake/pull/179.patch","issue_url":"https://api.github.com/repos/liamja/Prebake/issues/179","number":179,"state":"closed","locked":false,"title":"Fix/optimize rules","user":{"login":"fhemberger","id":153481,"avatar_url":"https://avatars.githubusercontent.com/u/153481?v=3","gravatar_id":"","url":"https://api.github.com/users/fhemberger","html_url":"https://github.com/fhemberger","followers_url":"https://api.github.com/users/fhemberger/followers","following_url":"https://api.github.com/users/fhemberger/following{/other_user}","gists_url":"https://api.github.com/users/fhemberger/gists{/gist_id}","starred_url":"https://api.github.com/users/fhemberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhemberger/subscriptions","organizations_url":"https://api.github.com/users/fhemberger/orgs","repos_url":"https://api.github.com/users/fhemberger/repos","events_url":"https://api.github.com/users/fhemberger/events{/privacy}","received_events_url":"https://api.github.com/users/fhemberger/received_events","type":"User","site_admin":false},"body":"**To be merged after #177.**\r\n\r\nI extracted the IDs/class names of all rules we had so far and sorted them alphabetically. Afterwards, I extracted those appearing multiple times, which also had a clear relation to cookie messages (so no arbitrary rules like `.content` or `.popup` were touched.\r\n\r\nUsing https://arestwo.org/famlam/redundantRuleChecker.html, I removed all the specific site rules that were also covered by the more generic rules, removing 374 duplicates.\r\n\r\nThis should block cookie messages on way more sites while also minimizing possible false positives.","created_at":"2015-10-11T10:52:53Z","updated_at":"2015-10-12T05:01:51Z","closed_at":"2015-10-12T05:01:51Z","merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/liamja/Prebake/pulls/179/commits","review_comments_url":"https://api.github.com/repos/liamja/Prebake/pulls/179/comments","review_comment_url":"https://api.github.com/repos/liamja/Prebake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/liamja/Prebake/issues/179/comments","statuses_url":"https://api.github.com/repos/liamja/Prebake/statuses/927afb265e33a988ff7d797b8c1bf6cd100af05a","head":{"label":"liamja:fix/optimize-rules","ref":"fix/optimize-rules","sha":"927afb265e33a988ff7d797b8c1bf6cd100af05a","user":{"login":"liamja","id":962914,"avatar_url":"https://avatars.githubusercontent.com/u/962914?v=3","gravatar_id":"","url":"https://api.github.com/users/liamja","html_url":"https://github.com/liamja","followers_url":"https://api.github.com/users/liamja/followers","following_url":"https://api.github.com/users/liamja/following{/other_user}","gists_url":"https://api.github.com/users/liamja/gists{/gist_id}","starred_url":"https://api.github.com/users/liamja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liamja/subscriptions","organizations_url":"https://api.github.com/users/liamja/orgs","repos_url":"https://api.github.com/users/liamja/repos","events_url":"https://api.github.com/users/liamja/events{/privacy}","received_events_url":"https://api.github.com/users/liamja/received_events","type":"User","site_admin":false},"repo":{"id":6750220,"name":"Prebake","full_name":"liamja/Prebake","owner":{"login":"liamja","id":962914,"avatar_url":"https://avatars.githubusercontent.com/u/962914?v=3","gravatar_id":"","url":"https://api.github.com/users/liamja","html_url":"https://github.com/liamja","followers_url":"https://api.github.com/users/liamja/followers","following_url":"https://api.github.com/users/liamja/following{/other_user}","gists_url":"https://api.github.com/users/liamja/gists{/gist_id}","starred_url":"https://api.github.com/users/liamja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liamja/subscriptions","organizations_url":"https://api.github.com/users/liamja/orgs","repos_url":"https://api.github.com/users/liamja/repos","events_url":"https://api.github.com/users/liamja/events{/privacy}","received_events_url":"https://api.github.com/users/liamja/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liamja/Prebake","description":"A set of Adblock filters to block obtrusive EU cookie law notices.","fork":false,"url":"https://api.github.com/repos/liamja/Prebake","forks_url":"https://api.github.com/repos/liamja/Prebake/forks","keys_url":"https://api.github.com/repos/liamja/Prebake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liamja/Prebake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liamja/Prebake/teams","hooks_url":"https://api.github.com/repos/liamja/Prebake/hooks","issue_events_url":"https://api.github.com/repos/liamja/Prebake/issues/events{/number}","events_url":"https://api.github.com/repos/liamja/Prebake/events","assignees_url":"https://api.github.com/repos/liamja/Prebake/assignees{/user}","branches_url":"https://api.github.com/repos/liamja/Prebake/branches{/branch}","tags_url":"https://api.github.com/repos/liamja/Prebake/tags","blobs_url":"https://api.github.com/repos/liamja/Prebake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liamja/Prebake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liamja/Prebake/git/refs{/sha}","trees_url":"https://api.github.com/repos/liamja/Prebake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liamja/Prebake/statuses/{sha}","languages_url":"https://api.github.com/repos/liamja/Prebake/languages","stargazers_url":"https://api.github.com/repos/liamja/Prebake/stargazers","contributors_url":"https://api.github.com/repos/liamja/Prebake/contributors","subscribers_url":"https://api.github.com/repos/liamja/Prebake/subscribers","subscription_url":"https://api.github.com/repos/liamja/Prebake/subscription","commits_url":"https://api.github.com/repos/liamja/Prebake/commits{/sha}","git_commits_url":"https://api.github.com/repos/liamja/Prebake/git/commits{/sha}","comments_url":"https://api.github.com/repos/liamja/Prebake/comments{/number}","issue_comment_url":"https://api.github.com/repos/liamja/Prebake/issues/comments{/number}","contents_url":"https://api.github.com/repos/liamja/Prebake/contents/{+path}","compare_url":"https://api.github.com/repos/liamja/Prebake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liamja/Prebake/merges","archive_url":"https://api.github.com/repos/liamja/Prebake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liamja/Prebake/downloads","issues_url":"https://api.github.com/repos/liamja/Prebake/issues{/number}","pulls_url":"https://api.github.com/repos/liamja/Prebake/pulls{/number}","milestones_url":"https://api.github.com/repos/liamja/Prebake/milestones{/number}","notifications_url":"https://api.github.com/repos/liamja/Prebake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liamja/Prebake/labels{/name}","releases_url":"https://api.github.com/repos/liamja/Prebake/releases{/id}","created_at":"2012-11-18T19:18:51Z","updated_at":"2015-10-11T00:06:03Z","pushed_at":"2015-10-12T05:01:51Z","git_url":"git://github.com/liamja/Prebake.git","ssh_url":"git@github.com:liamja/Prebake.git","clone_url":"https://github.com/liamja/Prebake.git","svn_url":"https://github.com/liamja/Prebake","homepage":"http://prebake.eu","size":2373,"stargazers_count":94,"watchers_count":94,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":41,"mirror_url":null,"open_issues_count":10,"forks":41,"open_issues":10,"watchers":94,"default_branch":"master"}},"base":{"label":"liamja:master","ref":"master","sha":"fc737f41313e613c016125633e9cc0600e764330","user":{"login":"liamja","id":962914,"avatar_url":"https://avatars.githubusercontent.com/u/962914?v=3","gravatar_id":"","url":"https://api.github.com/users/liamja","html_url":"https://github.com/liamja","followers_url":"https://api.github.com/users/liamja/followers","following_url":"https://api.github.com/users/liamja/following{/other_user}","gists_url":"https://api.github.com/users/liamja/gists{/gist_id}","starred_url":"https://api.github.com/users/liamja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liamja/subscriptions","organizations_url":"https://api.github.com/users/liamja/orgs","repos_url":"https://api.github.com/users/liamja/repos","events_url":"https://api.github.com/users/liamja/events{/privacy}","received_events_url":"https://api.github.com/users/liamja/received_events","type":"User","site_admin":false},"repo":{"id":6750220,"name":"Prebake","full_name":"liamja/Prebake","owner":{"login":"liamja","id":962914,"avatar_url":"https://avatars.githubusercontent.com/u/962914?v=3","gravatar_id":"","url":"https://api.github.com/users/liamja","html_url":"https://github.com/liamja","followers_url":"https://api.github.com/users/liamja/followers","following_url":"https://api.github.com/users/liamja/following{/other_user}","gists_url":"https://api.github.com/users/liamja/gists{/gist_id}","starred_url":"https://api.github.com/users/liamja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liamja/subscriptions","organizations_url":"https://api.github.com/users/liamja/orgs","repos_url":"https://api.github.com/users/liamja/repos","events_url":"https://api.github.com/users/liamja/events{/privacy}","received_events_url":"https://api.github.com/users/liamja/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liamja/Prebake","description":"A set of Adblock filters to block obtrusive EU cookie law notices.","fork":false,"url":"https://api.github.com/repos/liamja/Prebake","forks_url":"https://api.github.com/repos/liamja/Prebake/forks","keys_url":"https://api.github.com/repos/liamja/Prebake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liamja/Prebake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liamja/Prebake/teams","hooks_url":"https://api.github.com/repos/liamja/Prebake/hooks","issue_events_url":"https://api.github.com/repos/liamja/Prebake/issues/events{/number}","events_url":"https://api.github.com/repos/liamja/Prebake/events","assignees_url":"https://api.github.com/repos/liamja/Prebake/assignees{/user}","branches_url":"https://api.github.com/repos/liamja/Prebake/branches{/branch}","tags_url":"https://api.github.com/repos/liamja/Prebake/tags","blobs_url":"https://api.github.com/repos/liamja/Prebake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liamja/Prebake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liamja/Prebake/git/refs{/sha}","trees_url":"https://api.github.com/repos/liamja/Prebake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liamja/Prebake/statuses/{sha}","languages_url":"https://api.github.com/repos/liamja/Prebake/languages","stargazers_url":"https://api.github.com/repos/liamja/Prebake/stargazers","contributors_url":"https://api.github.com/repos/liamja/Prebake/contributors","subscribers_url":"https://api.github.com/repos/liamja/Prebake/subscribers","subscription_url":"https://api.github.com/repos/liamja/Prebake/subscription","commits_url":"https://api.github.com/repos/liamja/Prebake/commits{/sha}","git_commits_url":"https://api.github.com/repos/liamja/Prebake/git/commits{/sha}","comments_url":"https://api.github.com/repos/liamja/Prebake/comments{/number}","issue_comment_url":"https://api.github.com/repos/liamja/Prebake/issues/comments{/number}","contents_url":"https://api.github.com/repos/liamja/Prebake/contents/{+path}","compare_url":"https://api.github.com/repos/liamja/Prebake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liamja/Prebake/merges","archive_url":"https://api.github.com/repos/liamja/Prebake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liamja/Prebake/downloads","issues_url":"https://api.github.com/repos/liamja/Prebake/issues{/number}","pulls_url":"https://api.github.com/repos/liamja/Prebake/pulls{/number}","milestones_url":"https://api.github.com/repos/liamja/Prebake/milestones{/number}","notifications_url":"https://api.github.com/repos/liamja/Prebake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liamja/Prebake/labels{/name}","releases_url":"https://api.github.com/repos/liamja/Prebake/releases{/id}","created_at":"2012-11-18T19:18:51Z","updated_at":"2015-10-11T00:06:03Z","pushed_at":"2015-10-12T05:01:51Z","git_url":"git://github.com/liamja/Prebake.git","ssh_url":"git@github.com:liamja/Prebake.git","clone_url":"https://github.com/liamja/Prebake.git","svn_url":"https://github.com/liamja/Prebake","homepage":"http://prebake.eu","size":2373,"stargazers_count":94,"watchers_count":94,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":41,"mirror_url":null,"open_issues_count":10,"forks":41,"open_issues":10,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/liamja/Prebake/pulls/179"},"html":{"href":"https://github.com/liamja/Prebake/pull/179"},"issue":{"href":"https://api.github.com/repos/liamja/Prebake/issues/179"},"comments":{"href":"https://api.github.com/repos/liamja/Prebake/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/liamja/Prebake/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/liamja/Prebake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/liamja/Prebake/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/liamja/Prebake/statuses/927afb265e33a988ff7d797b8c1bf6cd100af05a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"commits":2,"additions":125,"deletions":408,"changed_files":1}}