{"action":"closed","number":96,"pull_request":{"url":"https://api.github.com/repos/saltstack-formulas/users-formula/pulls/96","id":45554483,"html_url":"https://github.com/saltstack-formulas/users-formula/pull/96","diff_url":"https://github.com/saltstack-formulas/users-formula/pull/96.diff","patch_url":"https://github.com/saltstack-formulas/users-formula/pull/96.patch","issue_url":"https://api.github.com/repos/saltstack-formulas/users-formula/issues/96","number":96,"state":"closed","locked":false,"title":"changing visudo checking to avoid wrong reporting when launched in a test mode","user":{"login":"skandyla","id":5349238,"avatar_url":"https://avatars.githubusercontent.com/u/5349238?v=3","gravatar_id":"","url":"https://api.github.com/users/skandyla","html_url":"https://github.com/skandyla","followers_url":"https://api.github.com/users/skandyla/followers","following_url":"https://api.github.com/users/skandyla/following{/other_user}","gists_url":"https://api.github.com/users/skandyla/gists{/gist_id}","starred_url":"https://api.github.com/users/skandyla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skandyla/subscriptions","organizations_url":"https://api.github.com/users/skandyla/orgs","repos_url":"https://api.github.com/users/skandyla/repos","events_url":"https://api.github.com/users/skandyla/events{/privacy}","received_events_url":"https://api.github.com/users/skandyla/received_events","type":"User","site_admin":false},"body":"When running  ```state.highstate test=true```  users-formula reports changes when no changes are required.\r\n```\r\nsalt-ssh testhost state.highstate test=true\r\ntesthost:\r\n  Name: visudo -cf - <<<\"$rule\" | { read output; if [[ $output != \"stdin: parsed OK\" ]] ; then echo $output ; fi } - Function: cmd.run - Result: Differs\r\n```\r\n\r\nThis commit introduces new logic for verifying sudo rules. So I just commented out old logic-block.\r\n\r\nMore details:\r\nhttps://github.com/saltstack-formulas/users-formula/issues/95","created_at":"2015-09-21T14:23:42Z","updated_at":"2015-09-21T17:36:37Z","closed_at":"2015-09-21T17:36:37Z","merged_at":"2015-09-21T17:36:37Z","merge_commit_sha":"e2c0281e860c530824cf251417bcbf6432e59344","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack-formulas/users-formula/pulls/96/commits","review_comments_url":"https://api.github.com/repos/saltstack-formulas/users-formula/pulls/96/comments","review_comment_url":"https://api.github.com/repos/saltstack-formulas/users-formula/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack-formulas/users-formula/issues/96/comments","statuses_url":"https://api.github.com/repos/saltstack-formulas/users-formula/statuses/819d73a5969d8316805f963f6331141c96015188","head":{"label":"skandyla:master","ref":"master","sha":"819d73a5969d8316805f963f6331141c96015188","user":{"login":"skandyla","id":5349238,"avatar_url":"https://avatars.githubusercontent.com/u/5349238?v=3","gravatar_id":"","url":"https://api.github.com/users/skandyla","html_url":"https://github.com/skandyla","followers_url":"https://api.github.com/users/skandyla/followers","following_url":"https://api.github.com/users/skandyla/following{/other_user}","gists_url":"https://api.github.com/users/skandyla/gists{/gist_id}","starred_url":"https://api.github.com/users/skandyla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skandyla/subscriptions","organizations_url":"https://api.github.com/users/skandyla/orgs","repos_url":"https://api.github.com/users/skandyla/repos","events_url":"https://api.github.com/users/skandyla/events{/privacy}","received_events_url":"https://api.github.com/users/skandyla/received_events","type":"User","site_admin":false},"repo":{"id":42812886,"name":"users-formula","full_name":"skandyla/users-formula","owner":{"login":"skandyla","id":5349238,"avatar_url":"https://avatars.githubusercontent.com/u/5349238?v=3","gravatar_id":"","url":"https://api.github.com/users/skandyla","html_url":"https://github.com/skandyla","followers_url":"https://api.github.com/users/skandyla/followers","following_url":"https://api.github.com/users/skandyla/following{/other_user}","gists_url":"https://api.github.com/users/skandyla/gists{/gist_id}","starred_url":"https://api.github.com/users/skandyla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skandyla/subscriptions","organizations_url":"https://api.github.com/users/skandyla/orgs","repos_url":"https://api.github.com/users/skandyla/repos","events_url":"https://api.github.com/users/skandyla/events{/privacy}","received_events_url":"https://api.github.com/users/skandyla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skandyla/users-formula","description":"Configure users via pillar","fork":true,"url":"https://api.github.com/repos/skandyla/users-formula","forks_url":"https://api.github.com/repos/skandyla/users-formula/forks","keys_url":"https://api.github.com/repos/skandyla/users-formula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skandyla/users-formula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skandyla/users-formula/teams","hooks_url":"https://api.github.com/repos/skandyla/users-formula/hooks","issue_events_url":"https://api.github.com/repos/skandyla/users-formula/issues/events{/number}","events_url":"https://api.github.com/repos/skandyla/users-formula/events","assignees_url":"https://api.github.com/repos/skandyla/users-formula/assignees{/user}","branches_url":"https://api.github.com/repos/skandyla/users-formula/branches{/branch}","tags_url":"https://api.github.com/repos/skandyla/users-formula/tags","blobs_url":"https://api.github.com/repos/skandyla/users-formula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skandyla/users-formula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skandyla/users-formula/git/refs{/sha}","trees_url":"https://api.github.com/repos/skandyla/users-formula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skandyla/users-formula/statuses/{sha}","languages_url":"https://api.github.com/repos/skandyla/users-formula/languages","stargazers_url":"https://api.github.com/repos/skandyla/users-formula/stargazers","contributors_url":"https://api.github.com/repos/skandyla/users-formula/contributors","subscribers_url":"https://api.github.com/repos/skandyla/users-formula/subscribers","subscription_url":"https://api.github.com/repos/skandyla/users-formula/subscription","commits_url":"https://api.github.com/repos/skandyla/users-formula/commits{/sha}","git_commits_url":"https://api.github.com/repos/skandyla/users-formula/git/commits{/sha}","comments_url":"https://api.github.com/repos/skandyla/users-formula/comments{/number}","issue_comment_url":"https://api.github.com/repos/skandyla/users-formula/issues/comments{/number}","contents_url":"https://api.github.com/repos/skandyla/users-formula/contents/{+path}","compare_url":"https://api.github.com/repos/skandyla/users-formula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skandyla/users-formula/merges","archive_url":"https://api.github.com/repos/skandyla/users-formula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skandyla/users-formula/downloads","issues_url":"https://api.github.com/repos/skandyla/users-formula/issues{/number}","pulls_url":"https://api.github.com/repos/skandyla/users-formula/pulls{/number}","milestones_url":"https://api.github.com/repos/skandyla/users-formula/milestones{/number}","notifications_url":"https://api.github.com/repos/skandyla/users-formula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skandyla/users-formula/labels{/name}","releases_url":"https://api.github.com/repos/skandyla/users-formula/releases{/id}","created_at":"2015-09-20T12:54:15Z","updated_at":"2015-09-20T12:54:16Z","pushed_at":"2015-09-20T13:22:03Z","git_url":"git://github.com/skandyla/users-formula.git","ssh_url":"git@github.com:skandyla/users-formula.git","clone_url":"https://github.com/skandyla/users-formula.git","svn_url":"https://github.com/skandyla/users-formula","homepage":"http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html","size":584,"stargazers_count":0,"watchers_count":0,"language":"SaltStack","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"saltstack-formulas:master","ref":"master","sha":"7b0b86f01f3d7326190b94f64d3c5a94f5c048ca","user":{"login":"saltstack-formulas","id":4683350,"avatar_url":"https://avatars.githubusercontent.com/u/4683350?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack-formulas","html_url":"https://github.com/saltstack-formulas","followers_url":"https://api.github.com/users/saltstack-formulas/followers","following_url":"https://api.github.com/users/saltstack-formulas/following{/other_user}","gists_url":"https://api.github.com/users/saltstack-formulas/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack-formulas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack-formulas/subscriptions","organizations_url":"https://api.github.com/users/saltstack-formulas/orgs","repos_url":"https://api.github.com/users/saltstack-formulas/repos","events_url":"https://api.github.com/users/saltstack-formulas/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack-formulas/received_events","type":"Organization","site_admin":false},"repo":{"id":10804700,"name":"users-formula","full_name":"saltstack-formulas/users-formula","owner":{"login":"saltstack-formulas","id":4683350,"avatar_url":"https://avatars.githubusercontent.com/u/4683350?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack-formulas","html_url":"https://github.com/saltstack-formulas","followers_url":"https://api.github.com/users/saltstack-formulas/followers","following_url":"https://api.github.com/users/saltstack-formulas/following{/other_user}","gists_url":"https://api.github.com/users/saltstack-formulas/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack-formulas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack-formulas/subscriptions","organizations_url":"https://api.github.com/users/saltstack-formulas/orgs","repos_url":"https://api.github.com/users/saltstack-formulas/repos","events_url":"https://api.github.com/users/saltstack-formulas/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack-formulas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack-formulas/users-formula","description":"Configure users via pillar","fork":false,"url":"https://api.github.com/repos/saltstack-formulas/users-formula","forks_url":"https://api.github.com/repos/saltstack-formulas/users-formula/forks","keys_url":"https://api.github.com/repos/saltstack-formulas/users-formula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack-formulas/users-formula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack-formulas/users-formula/teams","hooks_url":"https://api.github.com/repos/saltstack-formulas/users-formula/hooks","issue_events_url":"https://api.github.com/repos/saltstack-formulas/users-formula/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack-formulas/users-formula/events","assignees_url":"https://api.github.com/repos/saltstack-formulas/users-formula/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack-formulas/users-formula/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack-formulas/users-formula/tags","blobs_url":"https://api.github.com/repos/saltstack-formulas/users-formula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack-formulas/users-formula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack-formulas/users-formula/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack-formulas/users-formula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack-formulas/users-formula/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack-formulas/users-formula/languages","stargazers_url":"https://api.github.com/repos/saltstack-formulas/users-formula/stargazers","contributors_url":"https://api.github.com/repos/saltstack-formulas/users-formula/contributors","subscribers_url":"https://api.github.com/repos/saltstack-formulas/users-formula/subscribers","subscription_url":"https://api.github.com/repos/saltstack-formulas/users-formula/subscription","commits_url":"https://api.github.com/repos/saltstack-formulas/users-formula/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack-formulas/users-formula/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack-formulas/users-formula/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack-formulas/users-formula/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack-formulas/users-formula/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack-formulas/users-formula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack-formulas/users-formula/merges","archive_url":"https://api.github.com/repos/saltstack-formulas/users-formula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack-formulas/users-formula/downloads","issues_url":"https://api.github.com/repos/saltstack-formulas/users-formula/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack-formulas/users-formula/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack-formulas/users-formula/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack-formulas/users-formula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack-formulas/users-formula/labels{/name}","releases_url":"https://api.github.com/repos/saltstack-formulas/users-formula/releases{/id}","created_at":"2013-06-19T19:49:28Z","updated_at":"2015-09-14T03:37:05Z","pushed_at":"2015-09-21T17:36:37Z","git_url":"git://github.com/saltstack-formulas/users-formula.git","ssh_url":"git@github.com:saltstack-formulas/users-formula.git","clone_url":"https://github.com/saltstack-formulas/users-formula.git","svn_url":"https://github.com/saltstack-formulas/users-formula","homepage":"http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html","size":584,"stargazers_count":29,"watchers_count":29,"language":"SaltStack","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":152,"mirror_url":null,"open_issues_count":11,"forks":152,"open_issues":11,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack-formulas/users-formula/pulls/96"},"html":{"href":"https://github.com/saltstack-formulas/users-formula/pull/96"},"issue":{"href":"https://api.github.com/repos/saltstack-formulas/users-formula/issues/96"},"comments":{"href":"https://api.github.com/repos/saltstack-formulas/users-formula/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack-formulas/users-formula/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack-formulas/users-formula/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack-formulas/users-formula/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack-formulas/users-formula/statuses/819d73a5969d8316805f963f6331141c96015188"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gravyboat","id":1396878,"avatar_url":"https://avatars.githubusercontent.com/u/1396878?v=3","gravatar_id":"","url":"https://api.github.com/users/gravyboat","html_url":"https://github.com/gravyboat","followers_url":"https://api.github.com/users/gravyboat/followers","following_url":"https://api.github.com/users/gravyboat/following{/other_user}","gists_url":"https://api.github.com/users/gravyboat/gists{/gist_id}","starred_url":"https://api.github.com/users/gravyboat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravyboat/subscriptions","organizations_url":"https://api.github.com/users/gravyboat/orgs","repos_url":"https://api.github.com/users/gravyboat/repos","events_url":"https://api.github.com/users/gravyboat/events{/privacy}","received_events_url":"https://api.github.com/users/gravyboat/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":6,"deletions":0,"changed_files":1}}