{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/openshift-docs/issues/878","labels_url":"https://api.github.com/repos/openshift/openshift-docs/issues/878/labels{/name}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/issues/878/comments","events_url":"https://api.github.com/repos/openshift/openshift-docs/issues/878/events","html_url":"https://github.com/openshift/openshift-docs/pull/878","id":100695211,"number":878,"title":"[peer review] BZ#1243740: Working with HTTP proxies","user":{"login":"bfallonf","id":5474938,"avatar_url":"https://avatars.githubusercontent.com/u/5474938?v=3","gravatar_id":"","url":"https://api.github.com/users/bfallonf","html_url":"https://github.com/bfallonf","followers_url":"https://api.github.com/users/bfallonf/followers","following_url":"https://api.github.com/users/bfallonf/following{/other_user}","gists_url":"https://api.github.com/users/bfallonf/gists{/gist_id}","starred_url":"https://api.github.com/users/bfallonf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfallonf/subscriptions","organizations_url":"https://api.github.com/users/bfallonf/orgs","repos_url":"https://api.github.com/users/bfallonf/repos","events_url":"https://api.github.com/users/bfallonf/events{/privacy}","received_events_url":"https://api.github.com/users/bfallonf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2015-08-13T05:49:26Z","updated_at":"2015-10-07T03:42:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/878","html_url":"https://github.com/openshift/openshift-docs/pull/878","diff_url":"https://github.com/openshift/openshift-docs/pull/878.diff","patch_url":"https://github.com/openshift/openshift-docs/pull/878.patch"},"body":"PR in regards to https://bugzilla.redhat.com/show_bug.cgi?id=1243740\r\n\r\n@thoraxe as this is based on info from your training docs, can I use you for some questions?\r\n\r\n1. Is the file that the reader is modifying the buildconfig? \r\n2. Also, why does this differ from the procedure in the dev_guide/builds section? https://docs.openshift.org/latest/dev_guide/builds.html#using-a-proxy-for-git-cloning\r\nIt seems to be doing the same thing... Am I wrong?\r\n3. A lot of these are talking about both http and https. Do we have to add parameters for both? Or do you only add the parameter that's relevant to your setup?\r\n\r\nI think that's all. \r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/openshift/openshift-docs/issues/comments/146070238","html_url":"https://github.com/openshift/openshift-docs/pull/878#issuecomment-146070238","issue_url":"https://api.github.com/repos/openshift/openshift-docs/issues/878","id":146070238,"user":{"login":"bfallonf","id":5474938,"avatar_url":"https://avatars.githubusercontent.com/u/5474938?v=3","gravatar_id":"","url":"https://api.github.com/users/bfallonf","html_url":"https://github.com/bfallonf","followers_url":"https://api.github.com/users/bfallonf/followers","following_url":"https://api.github.com/users/bfallonf/following{/other_user}","gists_url":"https://api.github.com/users/bfallonf/gists{/gist_id}","starred_url":"https://api.github.com/users/bfallonf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfallonf/subscriptions","organizations_url":"https://api.github.com/users/bfallonf/orgs","repos_url":"https://api.github.com/users/bfallonf/repos","events_url":"https://api.github.com/users/bfallonf/events{/privacy}","received_events_url":"https://api.github.com/users/bfallonf/received_events","type":"User","site_admin":false},"created_at":"2015-10-07T03:42:52Z","updated_at":"2015-10-07T03:42:52Z","body":"@tnguyen-rh Thanks for that. I've done edits as suggested. \r\n\r\nAs for the YAML v JSON thing, this PR was made before we made that decision, so I didn't think of that. If it's as simple as editing the JSON bits to look like YAML this shouldn't be hard."}}