{"action":"closed","number":689,"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/689","id":35636330,"html_url":"https://github.com/apache/flink/pull/689","diff_url":"https://github.com/apache/flink/pull/689.diff","patch_url":"https://github.com/apache/flink/pull/689.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/689","number":689,"state":"closed","locked":false,"title":"[FLINK-1920] Properly pass command line arguments with spaces to Flink","user":{"login":"rmetzger","id":89049,"avatar_url":"https://avatars.githubusercontent.com/u/89049?v=3","gravatar_id":"","url":"https://api.github.com/users/rmetzger","html_url":"https://github.com/rmetzger","followers_url":"https://api.github.com/users/rmetzger/followers","following_url":"https://api.github.com/users/rmetzger/following{/other_user}","gists_url":"https://api.github.com/users/rmetzger/gists{/gist_id}","starred_url":"https://api.github.com/users/rmetzger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmetzger/subscriptions","organizations_url":"https://api.github.com/users/rmetzger/orgs","repos_url":"https://api.github.com/users/rmetzger/repos","events_url":"https://api.github.com/users/rmetzger/events{/privacy}","received_events_url":"https://api.github.com/users/rmetzger/received_events","type":"User","site_admin":false},"body":"The actual issue was that we were using `$*` to pass the command line arguments from the scripts to the JVM. It seems that we have to use `\"$@` so that arguments with spaces are passed properly.\r\nI've tested this change with `./bin/yarn-session.sh -n 2 -D \"akka.ask.timeout=5 min\"` (note the space in the configuration value.","created_at":"2015-05-18T14:04:06Z","updated_at":"2015-05-26T11:57:50Z","closed_at":"2015-05-26T11:57:50Z","merged_at":null,"merge_commit_sha":"61e1e5bc2051444b75e06f953555f8082b455d6a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/689/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/689/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/689/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/26113f9f2ff6faf91cb213659fefef12cf3e9155","head":{"label":"rmetzger:flink1920","ref":"flink1920","sha":"26113f9f2ff6faf91cb213659fefef12cf3e9155","user":{"login":"rmetzger","id":89049,"avatar_url":"https://avatars.githubusercontent.com/u/89049?v=3","gravatar_id":"","url":"https://api.github.com/users/rmetzger","html_url":"https://github.com/rmetzger","followers_url":"https://api.github.com/users/rmetzger/followers","following_url":"https://api.github.com/users/rmetzger/following{/other_user}","gists_url":"https://api.github.com/users/rmetzger/gists{/gist_id}","starred_url":"https://api.github.com/users/rmetzger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmetzger/subscriptions","organizations_url":"https://api.github.com/users/rmetzger/orgs","repos_url":"https://api.github.com/users/rmetzger/repos","events_url":"https://api.github.com/users/rmetzger/events{/privacy}","received_events_url":"https://api.github.com/users/rmetzger/received_events","type":"User","site_admin":false},"repo":{"id":20618957,"name":"flink","full_name":"rmetzger/flink","owner":{"login":"rmetzger","id":89049,"avatar_url":"https://avatars.githubusercontent.com/u/89049?v=3","gravatar_id":"","url":"https://api.github.com/users/rmetzger","html_url":"https://github.com/rmetzger","followers_url":"https://api.github.com/users/rmetzger/followers","following_url":"https://api.github.com/users/rmetzger/following{/other_user}","gists_url":"https://api.github.com/users/rmetzger/gists{/gist_id}","starred_url":"https://api.github.com/users/rmetzger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmetzger/subscriptions","organizations_url":"https://api.github.com/users/rmetzger/orgs","repos_url":"https://api.github.com/users/rmetzger/repos","events_url":"https://api.github.com/users/rmetzger/events{/privacy}","received_events_url":"https://api.github.com/users/rmetzger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rmetzger/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/rmetzger/flink","forks_url":"https://api.github.com/repos/rmetzger/flink/forks","keys_url":"https://api.github.com/repos/rmetzger/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rmetzger/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rmetzger/flink/teams","hooks_url":"https://api.github.com/repos/rmetzger/flink/hooks","issue_events_url":"https://api.github.com/repos/rmetzger/flink/issues/events{/number}","events_url":"https://api.github.com/repos/rmetzger/flink/events","assignees_url":"https://api.github.com/repos/rmetzger/flink/assignees{/user}","branches_url":"https://api.github.com/repos/rmetzger/flink/branches{/branch}","tags_url":"https://api.github.com/repos/rmetzger/flink/tags","blobs_url":"https://api.github.com/repos/rmetzger/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rmetzger/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rmetzger/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/rmetzger/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rmetzger/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/rmetzger/flink/languages","stargazers_url":"https://api.github.com/repos/rmetzger/flink/stargazers","contributors_url":"https://api.github.com/repos/rmetzger/flink/contributors","subscribers_url":"https://api.github.com/repos/rmetzger/flink/subscribers","subscription_url":"https://api.github.com/repos/rmetzger/flink/subscription","commits_url":"https://api.github.com/repos/rmetzger/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/rmetzger/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/rmetzger/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/rmetzger/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/rmetzger/flink/contents/{+path}","compare_url":"https://api.github.com/repos/rmetzger/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rmetzger/flink/merges","archive_url":"https://api.github.com/repos/rmetzger/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rmetzger/flink/downloads","issues_url":"https://api.github.com/repos/rmetzger/flink/issues{/number}","pulls_url":"https://api.github.com/repos/rmetzger/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/rmetzger/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/rmetzger/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rmetzger/flink/labels{/name}","releases_url":"https://api.github.com/repos/rmetzger/flink/releases{/id}","created_at":"2014-06-08T14:58:57Z","updated_at":"2015-04-21T08:05:13Z","pushed_at":"2015-05-26T11:40:53Z","git_url":"git://github.com/rmetzger/flink.git","ssh_url":"git@github.com:rmetzger/flink.git","clone_url":"https://github.com/rmetzger/flink.git","svn_url":"https://github.com/rmetzger/flink","homepage":null,"size":54217,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"fdac963d5ccdb0397cc069d701bccd6bd04eae5e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","created_at":"2014-06-07T07:00:10Z","updated_at":"2015-05-26T11:16:36Z","pushed_at":"2015-05-26T11:57:45Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":3296070,"stargazers_count":423,"watchers_count":423,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":265,"mirror_url":"git://git.apache.org/incubator-flink.git","open_issues_count":48,"forks":265,"open_issues":48,"watchers":423,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/689"},"html":{"href":"https://github.com/apache/flink/pull/689"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/689"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/689/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/689/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/689/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/26113f9f2ff6faf91cb213659fefef12cf3e9155"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":3,"review_comments":0,"commits":10,"additions":2086,"deletions":424,"changed_files":59}}