{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/28448568","id":28448568,"diff_hunk":"@@ -22,20 +22,16 @@ func New(quiet bool) *SysInfo {\n \tsysInfo := &SysInfo{}\n \tif cgroupMemoryMountpoint, err := cgroups.FindCgroupMountpoint(\"memory\"); err != nil {\n \t\tif !quiet {\n-\t\t\tlogrus.Warnf(\"%s\", err)\n+\t\t\tlogrus.Warnf(\"Your kernel does not support memory limit: %v\", err)\n \t\t}\n \t} else {\n-\t\t_, err1 := ioutil.ReadFile(path.Join(cgroupMemoryMountpoint, \"memory.limit_in_bytes\"))\n-\t\t_, err2 := ioutil.ReadFile(path.Join(cgroupMemoryMountpoint, \"memory.soft_limit_in_bytes\"))\n-\t\tsysInfo.MemoryLimit = err1 == nil && err2 == nil\n-\t\tif !sysInfo.MemoryLimit && !quiet {\n-\t\t\tlogrus.Warnf(\"Your kernel does not support cgroup memory limit.\")\n-\t\t}\n+\t\t// If memory cgroup is mounted, MemoryLimit is always enabled.\n+\t\tsysInfo.MemoryLimit = true\n \n \t\t_, err = ioutil.ReadFile(path.Join(cgroupMemoryMountpoint, \"memory.memsw.limit_in_bytes\"))\n \t\tsysInfo.SwapLimit = err == nil","path":"pkg/sysinfo/sysinfo.go","position":18,"original_position":18,"commit_id":"db8d888b10fef308f6d5192e4997d97b696c765a","original_commit_id":"db8d888b10fef308f6d5192e4997d97b696c765a","user":{"login":"LK4D4","id":101445,"avatar_url":"https://avatars.githubusercontent.com/u/101445?v=3","gravatar_id":"","url":"https://api.github.com/users/LK4D4","html_url":"https://github.com/LK4D4","followers_url":"https://api.github.com/users/LK4D4/followers","following_url":"https://api.github.com/users/LK4D4/following{/other_user}","gists_url":"https://api.github.com/users/LK4D4/gists{/gist_id}","starred_url":"https://api.github.com/users/LK4D4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LK4D4/subscriptions","organizations_url":"https://api.github.com/users/LK4D4/orgs","repos_url":"https://api.github.com/users/LK4D4/repos","events_url":"https://api.github.com/users/LK4D4/events{/privacy}","received_events_url":"https://api.github.com/users/LK4D4/received_events","type":"User","site_admin":false},"body":"here it is always true.","created_at":"2015-04-15T18:33:02Z","updated_at":"2015-04-15T18:33:02Z","html_url":"https://github.com/docker/docker/pull/11882#discussion_r28448568","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/11882","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/28448568"},"html":{"href":"https://github.com/docker/docker/pull/11882#discussion_r28448568"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/11882"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/11882","id":32162021,"html_url":"https://github.com/docker/docker/pull/11882","diff_url":"https://github.com/docker/docker/pull/11882.diff","patch_url":"https://github.com/docker/docker/pull/11882.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/11882","number":11882,"state":"open","locked":false,"title":"add devices cgroup check as hard requirement","user":{"login":"hqhq","id":6415670,"avatar_url":"https://avatars.githubusercontent.com/u/6415670?v=3","gravatar_id":"","url":"https://api.github.com/users/hqhq","html_url":"https://github.com/hqhq","followers_url":"https://api.github.com/users/hqhq/followers","following_url":"https://api.github.com/users/hqhq/following{/other_user}","gists_url":"https://api.github.com/users/hqhq/gists{/gist_id}","starred_url":"https://api.github.com/users/hqhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqhq/subscriptions","organizations_url":"https://api.github.com/users/hqhq/orgs","repos_url":"https://api.github.com/users/hqhq/repos","events_url":"https://api.github.com/users/hqhq/events{/privacy}","received_events_url":"https://api.github.com/users/hqhq/received_events","type":"User","site_admin":false},"body":"Devices cgroup is required for container security,  because without it a container will have unrestricted access to device nodes, libcontainer will take that as a hard requirement, we should warn users if they happen to have this umounted.","created_at":"2015-03-28T09:39:37Z","updated_at":"2015-04-15T18:33:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86de161191f9d7b683567e41c314e4cb45b6379d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/11882/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/11882/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/11882/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/db8d888b10fef308f6d5192e4997d97b696c765a","head":{"label":"hqhq:hq_warn_device_cg","ref":"hq_warn_device_cg","sha":"db8d888b10fef308f6d5192e4997d97b696c765a","user":{"login":"hqhq","id":6415670,"avatar_url":"https://avatars.githubusercontent.com/u/6415670?v=3","gravatar_id":"","url":"https://api.github.com/users/hqhq","html_url":"https://github.com/hqhq","followers_url":"https://api.github.com/users/hqhq/followers","following_url":"https://api.github.com/users/hqhq/following{/other_user}","gists_url":"https://api.github.com/users/hqhq/gists{/gist_id}","starred_url":"https://api.github.com/users/hqhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqhq/subscriptions","organizations_url":"https://api.github.com/users/hqhq/orgs","repos_url":"https://api.github.com/users/hqhq/repos","events_url":"https://api.github.com/users/hqhq/events{/privacy}","received_events_url":"https://api.github.com/users/hqhq/received_events","type":"User","site_admin":false},"repo":{"id":23826530,"name":"docker","full_name":"hqhq/docker","owner":{"login":"hqhq","id":6415670,"avatar_url":"https://avatars.githubusercontent.com/u/6415670?v=3","gravatar_id":"","url":"https://api.github.com/users/hqhq","html_url":"https://github.com/hqhq","followers_url":"https://api.github.com/users/hqhq/followers","following_url":"https://api.github.com/users/hqhq/following{/other_user}","gists_url":"https://api.github.com/users/hqhq/gists{/gist_id}","starred_url":"https://api.github.com/users/hqhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqhq/subscriptions","organizations_url":"https://api.github.com/users/hqhq/orgs","repos_url":"https://api.github.com/users/hqhq/repos","events_url":"https://api.github.com/users/hqhq/events{/privacy}","received_events_url":"https://api.github.com/users/hqhq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hqhq/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/hqhq/docker","forks_url":"https://api.github.com/repos/hqhq/docker/forks","keys_url":"https://api.github.com/repos/hqhq/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hqhq/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hqhq/docker/teams","hooks_url":"https://api.github.com/repos/hqhq/docker/hooks","issue_events_url":"https://api.github.com/repos/hqhq/docker/issues/events{/number}","events_url":"https://api.github.com/repos/hqhq/docker/events","assignees_url":"https://api.github.com/repos/hqhq/docker/assignees{/user}","branches_url":"https://api.github.com/repos/hqhq/docker/branches{/branch}","tags_url":"https://api.github.com/repos/hqhq/docker/tags","blobs_url":"https://api.github.com/repos/hqhq/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hqhq/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hqhq/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/hqhq/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hqhq/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/hqhq/docker/languages","stargazers_url":"https://api.github.com/repos/hqhq/docker/stargazers","contributors_url":"https://api.github.com/repos/hqhq/docker/contributors","subscribers_url":"https://api.github.com/repos/hqhq/docker/subscribers","subscription_url":"https://api.github.com/repos/hqhq/docker/subscription","commits_url":"https://api.github.com/repos/hqhq/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/hqhq/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/hqhq/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/hqhq/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/hqhq/docker/contents/{+path}","compare_url":"https://api.github.com/repos/hqhq/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hqhq/docker/merges","archive_url":"https://api.github.com/repos/hqhq/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hqhq/docker/downloads","issues_url":"https://api.github.com/repos/hqhq/docker/issues{/number}","pulls_url":"https://api.github.com/repos/hqhq/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/hqhq/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/hqhq/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hqhq/docker/labels{/name}","releases_url":"https://api.github.com/repos/hqhq/docker/releases{/id}","created_at":"2014-09-09T09:03:12Z","updated_at":"2015-04-15T02:33:35Z","pushed_at":"2015-04-15T07:14:12Z","git_url":"git://github.com/hqhq/docker.git","ssh_url":"git@github.com:hqhq/docker.git","clone_url":"https://github.com/hqhq/docker.git","svn_url":"https://github.com/hqhq/docker","homepage":"http://www.docker.com","size":49418,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"da697dbed6143761f585b3b2a35c6ef0b501dea8","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-04-15T18:28:40Z","pushed_at":"2015-04-15T18:28:40Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":176310,"stargazers_count":20844,"watchers_count":20844,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4764,"mirror_url":null,"open_issues_count":891,"forks":4764,"open_issues":891,"watchers":20844,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/11882"},"html":{"href":"https://github.com/docker/docker/pull/11882"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/11882"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/11882/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/11882/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/11882/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/db8d888b10fef308f6d5192e4997d97b696c765a"}}}}