{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/greenish/react-mount/pulls/2","id":35601964,"html_url":"https://github.com/greenish/react-mount/pull/2","diff_url":"https://github.com/greenish/react-mount/pull/2.diff","patch_url":"https://github.com/greenish/react-mount/pull/2.patch","issue_url":"https://api.github.com/repos/greenish/react-mount/issues/2","number":2,"state":"closed","locked":false,"title":"Minor Webpack related tweak for mount function registration ","user":{"login":"crafterm","id":397,"avatar_url":"https://avatars.githubusercontent.com/u/397?v=3","gravatar_id":"","url":"https://api.github.com/users/crafterm","html_url":"https://github.com/crafterm","followers_url":"https://api.github.com/users/crafterm/followers","following_url":"https://api.github.com/users/crafterm/following{/other_user}","gists_url":"https://api.github.com/users/crafterm/gists{/gist_id}","starred_url":"https://api.github.com/users/crafterm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crafterm/subscriptions","organizations_url":"https://api.github.com/users/crafterm/orgs","repos_url":"https://api.github.com/users/crafterm/repos","events_url":"https://api.github.com/users/crafterm/events{/privacy}","received_events_url":"https://api.github.com/users/crafterm/received_events","type":"User","site_admin":false},"body":"Hi Philip,\r\n\r\nThanks heaps for your help with web pack support and 0.1.3 - I had to make the following change in this PR to get it all working, otherwise the mount function was not being registered/defined properly.\r\n\r\nAlso, in my case too I had to use:\r\n\r\n    <react-component></react-component>\r\n\r\nrather than just:\r\n\r\n    <react-component />\r\n\r\notherwise the markup was getting quite confused - not sure about that one but perhaps you might have some insights as to why this might be the case?\r\n\r\nHope you agree with the changes, please let me know if it needs to be done a different way, happy to help.\r\n\r\nCheers,\r\n\r\nMarcus\r\n","created_at":"2015-05-18T04:25:59Z","updated_at":"2015-05-23T22:44:57Z","closed_at":"2015-05-23T22:44:57Z","merged_at":null,"merge_commit_sha":"9590b1a2fd635ed7c9922e14d4f310ed687c70cb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/greenish/react-mount/pulls/2/commits","review_comments_url":"https://api.github.com/repos/greenish/react-mount/pulls/2/comments","review_comment_url":"https://api.github.com/repos/greenish/react-mount/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenish/react-mount/issues/2/comments","statuses_url":"https://api.github.com/repos/greenish/react-mount/statuses/3cfe79b95fb3ff994e925c08c24adcaa76434df6","head":{"label":"crafterm:master","ref":"master","sha":"3cfe79b95fb3ff994e925c08c24adcaa76434df6","user":{"login":"crafterm","id":397,"avatar_url":"https://avatars.githubusercontent.com/u/397?v=3","gravatar_id":"","url":"https://api.github.com/users/crafterm","html_url":"https://github.com/crafterm","followers_url":"https://api.github.com/users/crafterm/followers","following_url":"https://api.github.com/users/crafterm/following{/other_user}","gists_url":"https://api.github.com/users/crafterm/gists{/gist_id}","starred_url":"https://api.github.com/users/crafterm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crafterm/subscriptions","organizations_url":"https://api.github.com/users/crafterm/orgs","repos_url":"https://api.github.com/users/crafterm/repos","events_url":"https://api.github.com/users/crafterm/events{/privacy}","received_events_url":"https://api.github.com/users/crafterm/received_events","type":"User","site_admin":false},"repo":{"id":35796378,"name":"react-mount","full_name":"crafterm/react-mount","owner":{"login":"crafterm","id":397,"avatar_url":"https://avatars.githubusercontent.com/u/397?v=3","gravatar_id":"","url":"https://api.github.com/users/crafterm","html_url":"https://github.com/crafterm","followers_url":"https://api.github.com/users/crafterm/followers","following_url":"https://api.github.com/users/crafterm/following{/other_user}","gists_url":"https://api.github.com/users/crafterm/gists{/gist_id}","starred_url":"https://api.github.com/users/crafterm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crafterm/subscriptions","organizations_url":"https://api.github.com/users/crafterm/orgs","repos_url":"https://api.github.com/users/crafterm/repos","events_url":"https://api.github.com/users/crafterm/events{/privacy}","received_events_url":"https://api.github.com/users/crafterm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crafterm/react-mount","description":"React goes web component – Use custom tags to place react components directly in html.","fork":true,"url":"https://api.github.com/repos/crafterm/react-mount","forks_url":"https://api.github.com/repos/crafterm/react-mount/forks","keys_url":"https://api.github.com/repos/crafterm/react-mount/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crafterm/react-mount/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crafterm/react-mount/teams","hooks_url":"https://api.github.com/repos/crafterm/react-mount/hooks","issue_events_url":"https://api.github.com/repos/crafterm/react-mount/issues/events{/number}","events_url":"https://api.github.com/repos/crafterm/react-mount/events","assignees_url":"https://api.github.com/repos/crafterm/react-mount/assignees{/user}","branches_url":"https://api.github.com/repos/crafterm/react-mount/branches{/branch}","tags_url":"https://api.github.com/repos/crafterm/react-mount/tags","blobs_url":"https://api.github.com/repos/crafterm/react-mount/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crafterm/react-mount/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crafterm/react-mount/git/refs{/sha}","trees_url":"https://api.github.com/repos/crafterm/react-mount/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crafterm/react-mount/statuses/{sha}","languages_url":"https://api.github.com/repos/crafterm/react-mount/languages","stargazers_url":"https://api.github.com/repos/crafterm/react-mount/stargazers","contributors_url":"https://api.github.com/repos/crafterm/react-mount/contributors","subscribers_url":"https://api.github.com/repos/crafterm/react-mount/subscribers","subscription_url":"https://api.github.com/repos/crafterm/react-mount/subscription","commits_url":"https://api.github.com/repos/crafterm/react-mount/commits{/sha}","git_commits_url":"https://api.github.com/repos/crafterm/react-mount/git/commits{/sha}","comments_url":"https://api.github.com/repos/crafterm/react-mount/comments{/number}","issue_comment_url":"https://api.github.com/repos/crafterm/react-mount/issues/comments{/number}","contents_url":"https://api.github.com/repos/crafterm/react-mount/contents/{+path}","compare_url":"https://api.github.com/repos/crafterm/react-mount/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crafterm/react-mount/merges","archive_url":"https://api.github.com/repos/crafterm/react-mount/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crafterm/react-mount/downloads","issues_url":"https://api.github.com/repos/crafterm/react-mount/issues{/number}","pulls_url":"https://api.github.com/repos/crafterm/react-mount/pulls{/number}","milestones_url":"https://api.github.com/repos/crafterm/react-mount/milestones{/number}","notifications_url":"https://api.github.com/repos/crafterm/react-mount/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crafterm/react-mount/labels{/name}","releases_url":"https://api.github.com/repos/crafterm/react-mount/releases{/id}","created_at":"2015-05-18T04:19:10Z","updated_at":"2015-05-19T01:31:46Z","pushed_at":"2015-05-19T01:31:45Z","git_url":"git://github.com/crafterm/react-mount.git","ssh_url":"git@github.com:crafterm/react-mount.git","clone_url":"https://github.com/crafterm/react-mount.git","svn_url":"https://github.com/crafterm/react-mount","homepage":"","size":8057,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenish:master","ref":"master","sha":"0179f8501ed0f74a71087a7eaa158d3610b00e22","user":{"login":"greenish","id":580992,"avatar_url":"https://avatars.githubusercontent.com/u/580992?v=3","gravatar_id":"","url":"https://api.github.com/users/greenish","html_url":"https://github.com/greenish","followers_url":"https://api.github.com/users/greenish/followers","following_url":"https://api.github.com/users/greenish/following{/other_user}","gists_url":"https://api.github.com/users/greenish/gists{/gist_id}","starred_url":"https://api.github.com/users/greenish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenish/subscriptions","organizations_url":"https://api.github.com/users/greenish/orgs","repos_url":"https://api.github.com/users/greenish/repos","events_url":"https://api.github.com/users/greenish/events{/privacy}","received_events_url":"https://api.github.com/users/greenish/received_events","type":"User","site_admin":false},"repo":{"id":33265057,"name":"react-mount","full_name":"greenish/react-mount","owner":{"login":"greenish","id":580992,"avatar_url":"https://avatars.githubusercontent.com/u/580992?v=3","gravatar_id":"","url":"https://api.github.com/users/greenish","html_url":"https://github.com/greenish","followers_url":"https://api.github.com/users/greenish/followers","following_url":"https://api.github.com/users/greenish/following{/other_user}","gists_url":"https://api.github.com/users/greenish/gists{/gist_id}","starred_url":"https://api.github.com/users/greenish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenish/subscriptions","organizations_url":"https://api.github.com/users/greenish/orgs","repos_url":"https://api.github.com/users/greenish/repos","events_url":"https://api.github.com/users/greenish/events{/privacy}","received_events_url":"https://api.github.com/users/greenish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/greenish/react-mount","description":"React goes web component – Use custom tags to place react components directly in html.","fork":false,"url":"https://api.github.com/repos/greenish/react-mount","forks_url":"https://api.github.com/repos/greenish/react-mount/forks","keys_url":"https://api.github.com/repos/greenish/react-mount/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenish/react-mount/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenish/react-mount/teams","hooks_url":"https://api.github.com/repos/greenish/react-mount/hooks","issue_events_url":"https://api.github.com/repos/greenish/react-mount/issues/events{/number}","events_url":"https://api.github.com/repos/greenish/react-mount/events","assignees_url":"https://api.github.com/repos/greenish/react-mount/assignees{/user}","branches_url":"https://api.github.com/repos/greenish/react-mount/branches{/branch}","tags_url":"https://api.github.com/repos/greenish/react-mount/tags","blobs_url":"https://api.github.com/repos/greenish/react-mount/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenish/react-mount/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenish/react-mount/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenish/react-mount/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenish/react-mount/statuses/{sha}","languages_url":"https://api.github.com/repos/greenish/react-mount/languages","stargazers_url":"https://api.github.com/repos/greenish/react-mount/stargazers","contributors_url":"https://api.github.com/repos/greenish/react-mount/contributors","subscribers_url":"https://api.github.com/repos/greenish/react-mount/subscribers","subscription_url":"https://api.github.com/repos/greenish/react-mount/subscription","commits_url":"https://api.github.com/repos/greenish/react-mount/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenish/react-mount/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenish/react-mount/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenish/react-mount/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenish/react-mount/contents/{+path}","compare_url":"https://api.github.com/repos/greenish/react-mount/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenish/react-mount/merges","archive_url":"https://api.github.com/repos/greenish/react-mount/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenish/react-mount/downloads","issues_url":"https://api.github.com/repos/greenish/react-mount/issues{/number}","pulls_url":"https://api.github.com/repos/greenish/react-mount/pulls{/number}","milestones_url":"https://api.github.com/repos/greenish/react-mount/milestones{/number}","notifications_url":"https://api.github.com/repos/greenish/react-mount/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenish/react-mount/labels{/name}","releases_url":"https://api.github.com/repos/greenish/react-mount/releases{/id}","created_at":"2015-04-01T18:29:49Z","updated_at":"2015-05-22T10:01:51Z","pushed_at":"2015-05-19T01:31:46Z","git_url":"git://github.com/greenish/react-mount.git","ssh_url":"git@github.com:greenish/react-mount.git","clone_url":"https://github.com/greenish/react-mount.git","svn_url":"https://github.com/greenish/react-mount","homepage":"","size":8596,"stargazers_count":102,"watchers_count":102,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenish/react-mount/pulls/2"},"html":{"href":"https://github.com/greenish/react-mount/pull/2"},"issue":{"href":"https://api.github.com/repos/greenish/react-mount/issues/2"},"comments":{"href":"https://api.github.com/repos/greenish/react-mount/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/greenish/react-mount/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/greenish/react-mount/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenish/react-mount/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/greenish/react-mount/statuses/3cfe79b95fb3ff994e925c08c24adcaa76434df6"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":0,"commits":2,"additions":36699,"deletions":3,"changed_files":8}}