{"action":"created","comment":{"url":"https://api.github.com/repos/youtube/vitess/pulls/comments/29620789","id":29620789,"diff_hunk":"@@ -564,7 +564,7 @@ func (wr *Wrangler) applySqlShard(ctx context.Context, tabletInfo *topo.TabletIn\n \tctx, cancel := context.WithTimeout(ctx, 30*time.Second)\n \tdefer cancel()\n \t// Need to make sure that we enable binlog, since we're only applying the statement on masters.\n-\t_, err = wr.tmc.ExecuteFetchAsDba(ctx, tabletInfo, filledChange, 0, false, false)\n+\t_, err = wr.tmc.ExecuteFetchAsDba(ctx, tabletInfo, filledChange, 0, false, false, true)","path":"go/vt/wrangler/schema.go","position":5,"original_position":5,"commit_id":"cae24651dbd9cab773e7fe905f8da1922450d275","original_commit_id":"cae24651dbd9cab773e7fe905f8da1922450d275","user":{"login":"yaoshengzhe","id":626280,"avatar_url":"https://avatars.githubusercontent.com/u/626280?v=3","gravatar_id":"","url":"https://api.github.com/users/yaoshengzhe","html_url":"https://github.com/yaoshengzhe","followers_url":"https://api.github.com/users/yaoshengzhe/followers","following_url":"https://api.github.com/users/yaoshengzhe/following{/other_user}","gists_url":"https://api.github.com/users/yaoshengzhe/gists{/gist_id}","starred_url":"https://api.github.com/users/yaoshengzhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaoshengzhe/subscriptions","organizations_url":"https://api.github.com/users/yaoshengzhe/orgs","repos_url":"https://api.github.com/users/yaoshengzhe/repos","events_url":"https://api.github.com/users/yaoshengzhe/events{/privacy}","received_events_url":"https://api.github.com/users/yaoshengzhe/received_events","type":"User","site_admin":false},"body":"Cood catch! ","created_at":"2015-05-04T20:34:35Z","updated_at":"2015-05-04T20:34:35Z","html_url":"https://github.com/youtube/vitess/pull/658#discussion_r29620789","pull_request_url":"https://api.github.com/repos/youtube/vitess/pulls/658","_links":{"self":{"href":"https://api.github.com/repos/youtube/vitess/pulls/comments/29620789"},"html":{"href":"https://github.com/youtube/vitess/pull/658#discussion_r29620789"},"pull_request":{"href":"https://api.github.com/repos/youtube/vitess/pulls/658"}}},"pull_request":{"url":"https://api.github.com/repos/youtube/vitess/pulls/658","id":34664203,"html_url":"https://github.com/youtube/vitess/pull/658","diff_url":"https://github.com/youtube/vitess/pull/658.diff","patch_url":"https://github.com/youtube/vitess/pull/658.patch","issue_url":"https://api.github.com/repos/youtube/vitess/issues/658","number":658,"state":"open","locked":false,"title":"add enableReloadSchema flag to ExecuteFetchAsDba in tabletmanager","user":{"login":"yaoshengzhe","id":626280,"avatar_url":"https://avatars.githubusercontent.com/u/626280?v=3","gravatar_id":"","url":"https://api.github.com/users/yaoshengzhe","html_url":"https://github.com/yaoshengzhe","followers_url":"https://api.github.com/users/yaoshengzhe/followers","following_url":"https://api.github.com/users/yaoshengzhe/following{/other_user}","gists_url":"https://api.github.com/users/yaoshengzhe/gists{/gist_id}","starred_url":"https://api.github.com/users/yaoshengzhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaoshengzhe/subscriptions","organizations_url":"https://api.github.com/users/yaoshengzhe/orgs","repos_url":"https://api.github.com/users/yaoshengzhe/repos","events_url":"https://api.github.com/users/yaoshengzhe/events{/privacy}","received_events_url":"https://api.github.com/users/yaoshengzhe/received_events","type":"User","site_admin":false},"body":"enableReloadSchema is false by default. If it is set to be true, ExecuteFetchAsDba\r\nwill reload tablet schema once it finishes successfully. In addition, this change\r\nalso make CopySchemaShard trigger schema reload.","created_at":"2015-05-04T19:00:40Z","updated_at":"2015-05-04T20:34:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ced7328969a5f022122e948a0407ae77c8582ca0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/youtube/vitess/pulls/658/commits","review_comments_url":"https://api.github.com/repos/youtube/vitess/pulls/658/comments","review_comment_url":"https://api.github.com/repos/youtube/vitess/pulls/comments{/number}","comments_url":"https://api.github.com/repos/youtube/vitess/issues/658/comments","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/cae24651dbd9cab773e7fe905f8da1922450d275","head":{"label":"yaoshengzhe:fix_add_reload_schema_flag","ref":"fix_add_reload_schema_flag","sha":"cae24651dbd9cab773e7fe905f8da1922450d275","user":{"login":"yaoshengzhe","id":626280,"avatar_url":"https://avatars.githubusercontent.com/u/626280?v=3","gravatar_id":"","url":"https://api.github.com/users/yaoshengzhe","html_url":"https://github.com/yaoshengzhe","followers_url":"https://api.github.com/users/yaoshengzhe/followers","following_url":"https://api.github.com/users/yaoshengzhe/following{/other_user}","gists_url":"https://api.github.com/users/yaoshengzhe/gists{/gist_id}","starred_url":"https://api.github.com/users/yaoshengzhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaoshengzhe/subscriptions","organizations_url":"https://api.github.com/users/yaoshengzhe/orgs","repos_url":"https://api.github.com/users/yaoshengzhe/repos","events_url":"https://api.github.com/users/yaoshengzhe/events{/privacy}","received_events_url":"https://api.github.com/users/yaoshengzhe/received_events","type":"User","site_admin":false},"repo":{"id":27459467,"name":"vitess","full_name":"yaoshengzhe/vitess","owner":{"login":"yaoshengzhe","id":626280,"avatar_url":"https://avatars.githubusercontent.com/u/626280?v=3","gravatar_id":"","url":"https://api.github.com/users/yaoshengzhe","html_url":"https://github.com/yaoshengzhe","followers_url":"https://api.github.com/users/yaoshengzhe/followers","following_url":"https://api.github.com/users/yaoshengzhe/following{/other_user}","gists_url":"https://api.github.com/users/yaoshengzhe/gists{/gist_id}","starred_url":"https://api.github.com/users/yaoshengzhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaoshengzhe/subscriptions","organizations_url":"https://api.github.com/users/yaoshengzhe/orgs","repos_url":"https://api.github.com/users/yaoshengzhe/repos","events_url":"https://api.github.com/users/yaoshengzhe/events{/privacy}","received_events_url":"https://api.github.com/users/yaoshengzhe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yaoshengzhe/vitess","description":"vitess provides servers and tools which facilitate scaling of MySQL databases for large scale web services.","fork":true,"url":"https://api.github.com/repos/yaoshengzhe/vitess","forks_url":"https://api.github.com/repos/yaoshengzhe/vitess/forks","keys_url":"https://api.github.com/repos/yaoshengzhe/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yaoshengzhe/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yaoshengzhe/vitess/teams","hooks_url":"https://api.github.com/repos/yaoshengzhe/vitess/hooks","issue_events_url":"https://api.github.com/repos/yaoshengzhe/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/yaoshengzhe/vitess/events","assignees_url":"https://api.github.com/repos/yaoshengzhe/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/yaoshengzhe/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/yaoshengzhe/vitess/tags","blobs_url":"https://api.github.com/repos/yaoshengzhe/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yaoshengzhe/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yaoshengzhe/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/yaoshengzhe/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yaoshengzhe/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/yaoshengzhe/vitess/languages","stargazers_url":"https://api.github.com/repos/yaoshengzhe/vitess/stargazers","contributors_url":"https://api.github.com/repos/yaoshengzhe/vitess/contributors","subscribers_url":"https://api.github.com/repos/yaoshengzhe/vitess/subscribers","subscription_url":"https://api.github.com/repos/yaoshengzhe/vitess/subscription","commits_url":"https://api.github.com/repos/yaoshengzhe/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/yaoshengzhe/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/yaoshengzhe/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/yaoshengzhe/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/yaoshengzhe/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/yaoshengzhe/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yaoshengzhe/vitess/merges","archive_url":"https://api.github.com/repos/yaoshengzhe/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yaoshengzhe/vitess/downloads","issues_url":"https://api.github.com/repos/yaoshengzhe/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/yaoshengzhe/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/yaoshengzhe/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/yaoshengzhe/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yaoshengzhe/vitess/labels{/name}","releases_url":"https://api.github.com/repos/yaoshengzhe/vitess/releases{/id}","created_at":"2014-12-02T23:45:03Z","updated_at":"2015-05-04T18:24:39Z","pushed_at":"2015-05-04T18:58:18Z","git_url":"git://github.com/yaoshengzhe/vitess.git","ssh_url":"git@github.com:yaoshengzhe/vitess.git","clone_url":"https://github.com/yaoshengzhe/vitess.git","svn_url":"https://github.com/yaoshengzhe/vitess","homepage":null,"size":45199,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"youtube:master","ref":"master","sha":"6805ec712c4d3f5465b9c36497b2a63642bda0b1","user":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"repo":{"id":11008207,"name":"vitess","full_name":"youtube/vitess","owner":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/youtube/vitess","description":"vitess provides servers and tools which facilitate scaling of MySQL databases for large scale web services.","fork":false,"url":"https://api.github.com/repos/youtube/vitess","forks_url":"https://api.github.com/repos/youtube/vitess/forks","keys_url":"https://api.github.com/repos/youtube/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/youtube/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/youtube/vitess/teams","hooks_url":"https://api.github.com/repos/youtube/vitess/hooks","issue_events_url":"https://api.github.com/repos/youtube/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/youtube/vitess/events","assignees_url":"https://api.github.com/repos/youtube/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/youtube/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/youtube/vitess/tags","blobs_url":"https://api.github.com/repos/youtube/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/youtube/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/youtube/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/youtube/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/youtube/vitess/languages","stargazers_url":"https://api.github.com/repos/youtube/vitess/stargazers","contributors_url":"https://api.github.com/repos/youtube/vitess/contributors","subscribers_url":"https://api.github.com/repos/youtube/vitess/subscribers","subscription_url":"https://api.github.com/repos/youtube/vitess/subscription","commits_url":"https://api.github.com/repos/youtube/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/youtube/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/youtube/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/youtube/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/youtube/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/youtube/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/youtube/vitess/merges","archive_url":"https://api.github.com/repos/youtube/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/youtube/vitess/downloads","issues_url":"https://api.github.com/repos/youtube/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/youtube/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/youtube/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/youtube/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/youtube/vitess/labels{/name}","releases_url":"https://api.github.com/repos/youtube/vitess/releases{/id}","created_at":"2013-06-27T21:20:28Z","updated_at":"2015-05-04T17:32:03Z","pushed_at":"2015-05-04T19:00:40Z","git_url":"git://github.com/youtube/vitess.git","ssh_url":"git@github.com:youtube/vitess.git","clone_url":"https://github.com/youtube/vitess.git","svn_url":"https://github.com/youtube/vitess","homepage":null,"size":69042,"stargazers_count":2493,"watchers_count":2493,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":292,"mirror_url":null,"open_issues_count":26,"forks":292,"open_issues":26,"watchers":2493,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/youtube/vitess/pulls/658"},"html":{"href":"https://github.com/youtube/vitess/pull/658"},"issue":{"href":"https://api.github.com/repos/youtube/vitess/issues/658"},"comments":{"href":"https://api.github.com/repos/youtube/vitess/issues/658/comments"},"review_comments":{"href":"https://api.github.com/repos/youtube/vitess/pulls/658/comments"},"review_comment":{"href":"https://api.github.com/repos/youtube/vitess/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/youtube/vitess/pulls/658/commits"},"statuses":{"href":"https://api.github.com/repos/youtube/vitess/statuses/cae24651dbd9cab773e7fe905f8da1922450d275"}}}}