{"action":"created","issue":{"url":"https://api.github.com/repos/feelpp/feelpp/issues/670","labels_url":"https://api.github.com/repos/feelpp/feelpp/issues/670/labels{/name}","comments_url":"https://api.github.com/repos/feelpp/feelpp/issues/670/comments","events_url":"https://api.github.com/repos/feelpp/feelpp/issues/670/events","html_url":"https://github.com/feelpp/feelpp/pull/670","id":111643210,"number":670,"title":"Feature/findfeelpp (Issue #479)","user":{"login":"aancel","id":5362942,"avatar_url":"https://avatars.githubusercontent.com/u/5362942?v=3","gravatar_id":"","url":"https://api.github.com/users/aancel","html_url":"https://github.com/aancel","followers_url":"https://api.github.com/users/aancel/followers","following_url":"https://api.github.com/users/aancel/following{/other_user}","gists_url":"https://api.github.com/users/aancel/gists{/gist_id}","starred_url":"https://api.github.com/users/aancel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aancel/subscriptions","organizations_url":"https://api.github.com/users/aancel/orgs","repos_url":"https://api.github.com/users/aancel/repos","events_url":"https://api.github.com/users/aancel/events{/privacy}","received_events_url":"https://api.github.com/users/aancel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"aancel","id":5362942,"avatar_url":"https://avatars.githubusercontent.com/u/5362942?v=3","gravatar_id":"","url":"https://api.github.com/users/aancel","html_url":"https://github.com/aancel","followers_url":"https://api.github.com/users/aancel/followers","following_url":"https://api.github.com/users/aancel/following{/other_user}","gists_url":"https://api.github.com/users/aancel/gists{/gist_id}","starred_url":"https://api.github.com/users/aancel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aancel/subscriptions","organizations_url":"https://api.github.com/users/aancel/orgs","repos_url":"https://api.github.com/users/aancel/repos","events_url":"https://api.github.com/users/aancel/events{/privacy}","received_events_url":"https://api.github.com/users/aancel/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/feelpp/feelpp/milestones/15","html_url":"https://github.com/feelpp/feelpp/milestones/v0.100.0","labels_url":"https://api.github.com/repos/feelpp/feelpp/milestones/15/labels","id":781434,"number":15,"title":"v0.100.0","description":"","creator":{"login":"prudhomm","id":151693,"avatar_url":"https://avatars.githubusercontent.com/u/151693?v=3","gravatar_id":"","url":"https://api.github.com/users/prudhomm","html_url":"https://github.com/prudhomm","followers_url":"https://api.github.com/users/prudhomm/followers","following_url":"https://api.github.com/users/prudhomm/following{/other_user}","gists_url":"https://api.github.com/users/prudhomm/gists{/gist_id}","starred_url":"https://api.github.com/users/prudhomm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prudhomm/subscriptions","organizations_url":"https://api.github.com/users/prudhomm/orgs","repos_url":"https://api.github.com/users/prudhomm/repos","events_url":"https://api.github.com/users/prudhomm/events{/privacy}","received_events_url":"https://api.github.com/users/prudhomm/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":76,"state":"open","created_at":"2014-09-07T22:40:27Z","updated_at":"2015-10-16T04:26:05Z","due_on":"2015-07-30T22:00:00Z","closed_at":null},"comments":3,"created_at":"2015-10-15T15:30:52Z","updated_at":"2015-10-16T07:30:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/feelpp/feelpp/pulls/670","html_url":"https://github.com/feelpp/feelpp/pull/670","diff_url":"https://github.com/feelpp/feelpp/pull/670.diff","patch_url":"https://github.com/feelpp/feelpp/pull/670.patch"},"body":"Proposition for reworked FindFeel++.cmake:\r\n- Move dependency checking into feelpp.dependencies.cmake\r\n- Make FindFeel++.cmake a simple library finder \r\n- Add Feel++Config.cmake for project configuration (cf. [here](https://cmake.org/Wiki/CMake/Tutorials/How_to_create_a_ProjectConfig.cmake_file))\r\n- External projects using the Feel++ library won't have to go through Feel++ dependency checking anymore as they are all bundled in the Feel++Config.cmake file"},"comment":{"url":"https://api.github.com/repos/feelpp/feelpp/issues/comments/148637242","html_url":"https://github.com/feelpp/feelpp/pull/670#issuecomment-148637242","issue_url":"https://api.github.com/repos/feelpp/feelpp/issues/670","id":148637242,"user":{"login":"aancel","id":5362942,"avatar_url":"https://avatars.githubusercontent.com/u/5362942?v=3","gravatar_id":"","url":"https://api.github.com/users/aancel","html_url":"https://github.com/aancel","followers_url":"https://api.github.com/users/aancel/followers","following_url":"https://api.github.com/users/aancel/following{/other_user}","gists_url":"https://api.github.com/users/aancel/gists{/gist_id}","starred_url":"https://api.github.com/users/aancel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aancel/subscriptions","organizations_url":"https://api.github.com/users/aancel/orgs","repos_url":"https://api.github.com/users/aancel/repos","events_url":"https://api.github.com/users/aancel/events{/privacy}","received_events_url":"https://api.github.com/users/aancel/received_events","type":"User","site_admin":false},"created_at":"2015-10-16T07:30:59Z","updated_at":"2015-10-16T07:30:59Z","body":"Yep, everything recompiles as before. The only change I made for the library is moving all the code from FindFeel++.cmake to feelpp.dependencies.cmake and including it back in the main CMakeLists.txt.\r\nI'll be checking with subprojects and on other platform to ensure that it works as before.\r\nTravis builds seem to be ok apparently."}}