{"action":"created","issue":{"url":"https://api.github.com/repos/reactjs/react-rails/issues/332","labels_url":"https://api.github.com/repos/reactjs/react-rails/issues/332/labels{/name}","comments_url":"https://api.github.com/repos/reactjs/react-rails/issues/332/comments","events_url":"https://api.github.com/repos/reactjs/react-rails/issues/332/events","html_url":"https://github.com/reactjs/react-rails/pull/332","id":99830873,"number":332,"title":"Add es6 option to generator","user":{"login":"borisrorsvort","id":39081,"avatar_url":"https://avatars.githubusercontent.com/u/39081?v=3","gravatar_id":"","url":"https://api.github.com/users/borisrorsvort","html_url":"https://github.com/borisrorsvort","followers_url":"https://api.github.com/users/borisrorsvort/followers","following_url":"https://api.github.com/users/borisrorsvort/following{/other_user}","gists_url":"https://api.github.com/users/borisrorsvort/gists{/gist_id}","starred_url":"https://api.github.com/users/borisrorsvort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisrorsvort/subscriptions","organizations_url":"https://api.github.com/users/borisrorsvort/orgs","repos_url":"https://api.github.com/users/borisrorsvort/repos","events_url":"https://api.github.com/users/borisrorsvort/events{/privacy}","received_events_url":"https://api.github.com/users/borisrorsvort/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/reactjs/react-rails/labels/CLA%20signed","name":"CLA signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-08-08T19:56:32Z","updated_at":"2015-08-17T20:09:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/reactjs/react-rails/pulls/332","html_url":"https://github.com/reactjs/react-rails/pull/332","diff_url":"https://github.com/reactjs/react-rails/pull/332.diff","patch_url":"https://github.com/reactjs/react-rails/pull/332.patch"},"body":"Here you go #316\r\n\r\nI wanted to add some tests but basically it's just rerunning the same with another option. Should I dedupe the current one just for es6 or something else?"},"comment":{"url":"https://api.github.com/repos/reactjs/react-rails/issues/comments/131946058","html_url":"https://github.com/reactjs/react-rails/pull/332#issuecomment-131946058","issue_url":"https://api.github.com/repos/reactjs/react-rails/issues/332","id":131946058,"user":{"login":"rmosolgo","id":2231765,"avatar_url":"https://avatars.githubusercontent.com/u/2231765?v=3","gravatar_id":"","url":"https://api.github.com/users/rmosolgo","html_url":"https://github.com/rmosolgo","followers_url":"https://api.github.com/users/rmosolgo/followers","following_url":"https://api.github.com/users/rmosolgo/following{/other_user}","gists_url":"https://api.github.com/users/rmosolgo/gists{/gist_id}","starred_url":"https://api.github.com/users/rmosolgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmosolgo/subscriptions","organizations_url":"https://api.github.com/users/rmosolgo/orgs","repos_url":"https://api.github.com/users/rmosolgo/repos","events_url":"https://api.github.com/users/rmosolgo/events{/privacy}","received_events_url":"https://api.github.com/users/rmosolgo/received_events","type":"User","site_admin":false},"created_at":"2015-08-17T20:09:24Z","updated_at":"2015-08-17T20:09:24Z","body":"Sorry, I guess I should have been more specific. I think it's important to add tests for _new_ behaviors, but not important to test shared, pre-existing behaviors. In this case, it would be good to test: \r\n\r\n- The resulting file uses ES6 syntax (eg, checking for the `class ... extends` syntax in the result)\r\n- The resulting file assigns propTypes after defining the class (eg, checking for `{className}.propTypes = `)\r\n- The resulting file compiles successfully (I think `test \"generates working jsx\"` is sufficient for that). \r\n\r\nIn my opinion, it's not important to repeat the tests for filename, `render` function, and `propType` since those behaviors are unchanged by the `--es6` option. \r\n\r\nHow does that sound?"}}