{"action":"created","issue":{"url":"https://api.github.com/repos/godotengine/godot/issues/3012","labels_url":"https://api.github.com/repos/godotengine/godot/issues/3012/labels{/name}","comments_url":"https://api.github.com/repos/godotengine/godot/issues/3012/comments","events_url":"https://api.github.com/repos/godotengine/godot/issues/3012/events","html_url":"https://github.com/godotengine/godot/issues/3012","id":120922249,"number":3012,"title":"define BACK_TO_TABLES in aes256.cpp?","user":{"login":"romulox-x","id":7547356,"avatar_url":"https://avatars.githubusercontent.com/u/7547356?v=3","gravatar_id":"","url":"https://api.github.com/users/romulox-x","html_url":"https://github.com/romulox-x","followers_url":"https://api.github.com/users/romulox-x/followers","following_url":"https://api.github.com/users/romulox-x/following{/other_user}","gists_url":"https://api.github.com/users/romulox-x/gists{/gist_id}","starred_url":"https://api.github.com/users/romulox-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romulox-x/subscriptions","organizations_url":"https://api.github.com/users/romulox-x/orgs","repos_url":"https://api.github.com/users/romulox-x/repos","events_url":"https://api.github.com/users/romulox-x/events{/privacy}","received_events_url":"https://api.github.com/users/romulox-x/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/godotengine/godot/labels/enhancement","name":"enhancement","color":"44bbff"},{"url":"https://api.github.com/repos/godotengine/godot/labels/topic:core","name":"topic:core","color":"ffdd44"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-12-08T03:28:14Z","updated_at":"2015-12-08T16:06:01Z","closed_at":null,"body":"Is there a reason the line\r\n#define BACK_TO_TABLES\r\nis commented out at the top of core/io/aes256.cpp?  From what I can gather, the current code skips the use of lookup tables, and instead calculates the needed data on the fly.  In my roughly measured experiments where I enabled encryption of my scripts, this gives me load times 3-4 times longer than the unencrypted scripts.  If I uncomment this line, so that it uses the lookup tables, I can no longer distinguish between the encrypted and unencrypted load times, which is great.  But I wonder if this is too good to be true, and using the lookup tables is a bad choice for some reason.  I was able to export my scripts encrypted using a slow, non-lookup table built binary, then load that data using the fast lookup table version, so it seems they both work correctly.\r\n\r\nShall I make a PR for this, enabling the lookup tables?  Does anyone know enough about this to comment on whether this is a good idea?  I should be able to do this through scons build scripts myself, but if this is an acceptable change, I see no reason to keep doing it the slow way by default."},"comment":{"url":"https://api.github.com/repos/godotengine/godot/issues/comments/162929695","html_url":"https://github.com/godotengine/godot/issues/3012#issuecomment-162929695","issue_url":"https://api.github.com/repos/godotengine/godot/issues/3012","id":162929695,"user":{"login":"reduz","id":6265307,"avatar_url":"https://avatars.githubusercontent.com/u/6265307?v=3","gravatar_id":"","url":"https://api.github.com/users/reduz","html_url":"https://github.com/reduz","followers_url":"https://api.github.com/users/reduz/followers","following_url":"https://api.github.com/users/reduz/following{/other_user}","gists_url":"https://api.github.com/users/reduz/gists{/gist_id}","starred_url":"https://api.github.com/users/reduz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reduz/subscriptions","organizations_url":"https://api.github.com/users/reduz/orgs","repos_url":"https://api.github.com/users/reduz/repos","events_url":"https://api.github.com/users/reduz/events{/privacy}","received_events_url":"https://api.github.com/users/reduz/received_events","type":"User","site_admin":false},"created_at":"2015-12-08T16:06:01Z","updated_at":"2015-12-08T16:06:01Z","body":"if it's faster feel free to do a PR and merge it"}}