{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/30834950","id":30834950,"diff_hunk":"@@ -143,7 +146,8 @@ func buildContainer(hook *deployapi.ExecNewPodHook, deployment *kapi.Replication\n \t\t\t\t\tResources:  resources,\n \t\t\t\t},\n \t\t\t},\n-\t\t\tRestartPolicy: kapi.RestartPolicyNever,\n+\t\t\tActiveDeadlineSeconds: &maxDeploymentDurationSeconds,","path":"pkg/deploy/strategy/support/lifecycle.go","position":15,"original_position":15,"commit_id":"20cf8b90b2f01358ac506002437e4409e1a63f82","original_commit_id":"f2b905e8da4a184618f098b0260b9df4e77cbf59","user":{"login":"abhgupta","id":1211613,"avatar_url":"https://avatars.githubusercontent.com/u/1211613?v=3","gravatar_id":"","url":"https://api.github.com/users/abhgupta","html_url":"https://github.com/abhgupta","followers_url":"https://api.github.com/users/abhgupta/followers","following_url":"https://api.github.com/users/abhgupta/following{/other_user}","gists_url":"https://api.github.com/users/abhgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/abhgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhgupta/subscriptions","organizations_url":"https://api.github.com/users/abhgupta/orgs","repos_url":"https://api.github.com/users/abhgupta/repos","events_url":"https://api.github.com/users/abhgupta/events{/privacy}","received_events_url":"https://api.github.com/users/abhgupta/received_events","type":"User","site_admin":false},"body":"Added","created_at":"2015-05-21T18:55:52Z","updated_at":"2015-05-21T18:55:52Z","html_url":"https://github.com/openshift/origin/pull/2402#discussion_r30834950","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/2402","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/30834950"},"html":{"href":"https://github.com/openshift/origin/pull/2402#discussion_r30834950"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/2402"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/2402","id":35874971,"html_url":"https://github.com/openshift/origin/pull/2402","diff_url":"https://github.com/openshift/origin/pull/2402.diff","patch_url":"https://github.com/openshift/origin/pull/2402.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/2402","number":2402,"state":"open","locked":false,"title":"Setting max/default ActiveDeadlineSeconds on the deployer pod","user":{"login":"abhgupta","id":1211613,"avatar_url":"https://avatars.githubusercontent.com/u/1211613?v=3","gravatar_id":"","url":"https://api.github.com/users/abhgupta","html_url":"https://github.com/abhgupta","followers_url":"https://api.github.com/users/abhgupta/followers","following_url":"https://api.github.com/users/abhgupta/following{/other_user}","gists_url":"https://api.github.com/users/abhgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/abhgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhgupta/subscriptions","organizations_url":"https://api.github.com/users/abhgupta/orgs","repos_url":"https://api.github.com/users/abhgupta/repos","events_url":"https://api.github.com/users/abhgupta/events{/privacy}","received_events_url":"https://api.github.com/users/abhgupta/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-20T20:54:17Z","updated_at":"2015-05-21T18:55:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2a87caf011ebaddf0ae5914db7404b72a25469b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/2402/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/2402/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/2402/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/20cf8b90b2f01358ac506002437e4409e1a63f82","head":{"label":"abhgupta:trello_card_739","ref":"trello_card_739","sha":"20cf8b90b2f01358ac506002437e4409e1a63f82","user":{"login":"abhgupta","id":1211613,"avatar_url":"https://avatars.githubusercontent.com/u/1211613?v=3","gravatar_id":"","url":"https://api.github.com/users/abhgupta","html_url":"https://github.com/abhgupta","followers_url":"https://api.github.com/users/abhgupta/followers","following_url":"https://api.github.com/users/abhgupta/following{/other_user}","gists_url":"https://api.github.com/users/abhgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/abhgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhgupta/subscriptions","organizations_url":"https://api.github.com/users/abhgupta/orgs","repos_url":"https://api.github.com/users/abhgupta/repos","events_url":"https://api.github.com/users/abhgupta/events{/privacy}","received_events_url":"https://api.github.com/users/abhgupta/received_events","type":"User","site_admin":false},"repo":{"id":23977841,"name":"origin","full_name":"abhgupta/origin","owner":{"login":"abhgupta","id":1211613,"avatar_url":"https://avatars.githubusercontent.com/u/1211613?v=3","gravatar_id":"","url":"https://api.github.com/users/abhgupta","html_url":"https://github.com/abhgupta","followers_url":"https://api.github.com/users/abhgupta/followers","following_url":"https://api.github.com/users/abhgupta/following{/other_user}","gists_url":"https://api.github.com/users/abhgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/abhgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhgupta/subscriptions","organizations_url":"https://api.github.com/users/abhgupta/orgs","repos_url":"https://api.github.com/users/abhgupta/repos","events_url":"https://api.github.com/users/abhgupta/events{/privacy}","received_events_url":"https://api.github.com/users/abhgupta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abhgupta/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/abhgupta/origin","forks_url":"https://api.github.com/repos/abhgupta/origin/forks","keys_url":"https://api.github.com/repos/abhgupta/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abhgupta/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abhgupta/origin/teams","hooks_url":"https://api.github.com/repos/abhgupta/origin/hooks","issue_events_url":"https://api.github.com/repos/abhgupta/origin/issues/events{/number}","events_url":"https://api.github.com/repos/abhgupta/origin/events","assignees_url":"https://api.github.com/repos/abhgupta/origin/assignees{/user}","branches_url":"https://api.github.com/repos/abhgupta/origin/branches{/branch}","tags_url":"https://api.github.com/repos/abhgupta/origin/tags","blobs_url":"https://api.github.com/repos/abhgupta/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abhgupta/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abhgupta/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/abhgupta/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abhgupta/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/abhgupta/origin/languages","stargazers_url":"https://api.github.com/repos/abhgupta/origin/stargazers","contributors_url":"https://api.github.com/repos/abhgupta/origin/contributors","subscribers_url":"https://api.github.com/repos/abhgupta/origin/subscribers","subscription_url":"https://api.github.com/repos/abhgupta/origin/subscription","commits_url":"https://api.github.com/repos/abhgupta/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/abhgupta/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/abhgupta/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/abhgupta/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/abhgupta/origin/contents/{+path}","compare_url":"https://api.github.com/repos/abhgupta/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abhgupta/origin/merges","archive_url":"https://api.github.com/repos/abhgupta/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abhgupta/origin/downloads","issues_url":"https://api.github.com/repos/abhgupta/origin/issues{/number}","pulls_url":"https://api.github.com/repos/abhgupta/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/abhgupta/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/abhgupta/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abhgupta/origin/labels{/name}","releases_url":"https://api.github.com/repos/abhgupta/origin/releases{/id}","created_at":"2014-09-12T21:38:33Z","updated_at":"2015-05-08T20:42:26Z","pushed_at":"2015-05-21T18:55:33Z","git_url":"git://github.com/abhgupta/origin.git","ssh_url":"git@github.com:abhgupta/origin.git","clone_url":"https://github.com/abhgupta/origin.git","svn_url":"https://github.com/abhgupta/origin","homepage":"https://openshift.github.io","size":106104,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"42878a840bb17b7b9c4c86742174e16b457b06b7","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-05-21T05:41:01Z","pushed_at":"2015-05-21T18:55:33Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":181635,"stargazers_count":428,"watchers_count":428,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":211,"mirror_url":null,"open_issues_count":223,"forks":211,"open_issues":223,"watchers":428,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/2402"},"html":{"href":"https://github.com/openshift/origin/pull/2402"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/2402"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/2402/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/2402/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/2402/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/20cf8b90b2f01358ac506002437e4409e1a63f82"}}}}