{"action":"created","comment":{"url":"https://api.github.com/repos/GameAnalytics/current/pulls/comments/33152028","id":33152028,"diff_hunk":"@@ -326,9 +359,14 @@ do_query({UserRequest}, Acc, Opts) ->\n             {error, Reason}\n     end.\n \n-\n-\n-\n+get_accumulate_fun(true) ->","path":"src/current.erl","position":180,"original_position":183,"commit_id":"93b3c3b36dfbe9dc0acea4511698a5313effb1c6","original_commit_id":"3df7ab00ac4f6f208f965ec0852afa10b1d7ce0c","user":{"login":"wmalik","id":92498,"avatar_url":"https://avatars.githubusercontent.com/u/92498?v=3","gravatar_id":"","url":"https://api.github.com/users/wmalik","html_url":"https://github.com/wmalik","followers_url":"https://api.github.com/users/wmalik/followers","following_url":"https://api.github.com/users/wmalik/following{/other_user}","gists_url":"https://api.github.com/users/wmalik/gists{/gist_id}","starred_url":"https://api.github.com/users/wmalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmalik/subscriptions","organizations_url":"https://api.github.com/users/wmalik/orgs","repos_url":"https://api.github.com/users/wmalik/repos","events_url":"https://api.github.com/users/wmalik/events{/privacy}","received_events_url":"https://api.github.com/users/wmalik/received_events","type":"User","site_admin":false},"body":"Can we name the argument like this (to make it obvious what it is)?\r\n\r\n```erlang\r\nget_accumulate_fun(_IsCount = true) ->\r\n```\r\n\r\nSame on line 366.","created_at":"2015-06-24T14:23:47Z","updated_at":"2015-06-24T14:23:47Z","html_url":"https://github.com/GameAnalytics/current/pull/16#discussion_r33152028","pull_request_url":"https://api.github.com/repos/GameAnalytics/current/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/GameAnalytics/current/pulls/comments/33152028"},"html":{"href":"https://github.com/GameAnalytics/current/pull/16#discussion_r33152028"},"pull_request":{"href":"https://api.github.com/repos/GameAnalytics/current/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/GameAnalytics/current/pulls/16","id":37231397,"html_url":"https://github.com/GameAnalytics/current/pull/16","diff_url":"https://github.com/GameAnalytics/current/pull/16.diff","patch_url":"https://github.com/GameAnalytics/current/pull/16.patch","issue_url":"https://api.github.com/repos/GameAnalytics/current/issues/16","number":16,"state":"open","locked":false,"title":"Configurable HTTP client","user":{"login":"tgrk","id":27620,"avatar_url":"https://avatars.githubusercontent.com/u/27620?v=3","gravatar_id":"","url":"https://api.github.com/users/tgrk","html_url":"https://github.com/tgrk","followers_url":"https://api.github.com/users/tgrk/followers","following_url":"https://api.github.com/users/tgrk/following{/other_user}","gists_url":"https://api.github.com/users/tgrk/gists{/gist_id}","starred_url":"https://api.github.com/users/tgrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgrk/subscriptions","organizations_url":"https://api.github.com/users/tgrk/orgs","repos_url":"https://api.github.com/users/tgrk/repos","events_url":"https://api.github.com/users/tgrk/events{/privacy}","received_events_url":"https://api.github.com/users/tgrk/received_events","type":"User","site_admin":false},"body":"https://gameanalytics.atlassian.net/browse/GAME-1811\r\n\r\nIt tries to hide HTTP client specifics behind single API.","created_at":"2015-06-09T08:48:46Z","updated_at":"2015-06-24T14:23:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7555903eb59a1834907e6179b64f92bf87d47bb1","assignee":{"login":"wmalik","id":92498,"avatar_url":"https://avatars.githubusercontent.com/u/92498?v=3","gravatar_id":"","url":"https://api.github.com/users/wmalik","html_url":"https://github.com/wmalik","followers_url":"https://api.github.com/users/wmalik/followers","following_url":"https://api.github.com/users/wmalik/following{/other_user}","gists_url":"https://api.github.com/users/wmalik/gists{/gist_id}","starred_url":"https://api.github.com/users/wmalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmalik/subscriptions","organizations_url":"https://api.github.com/users/wmalik/orgs","repos_url":"https://api.github.com/users/wmalik/repos","events_url":"https://api.github.com/users/wmalik/events{/privacy}","received_events_url":"https://api.github.com/users/wmalik/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GameAnalytics/current/pulls/16/commits","review_comments_url":"https://api.github.com/repos/GameAnalytics/current/pulls/16/comments","review_comment_url":"https://api.github.com/repos/GameAnalytics/current/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GameAnalytics/current/issues/16/comments","statuses_url":"https://api.github.com/repos/GameAnalytics/current/statuses/93b3c3b36dfbe9dc0acea4511698a5313effb1c6","head":{"label":"GameAnalytics:configurable_http","ref":"configurable_http","sha":"93b3c3b36dfbe9dc0acea4511698a5313effb1c6","user":{"login":"GameAnalytics","id":1216299,"avatar_url":"https://avatars.githubusercontent.com/u/1216299?v=3","gravatar_id":"","url":"https://api.github.com/users/GameAnalytics","html_url":"https://github.com/GameAnalytics","followers_url":"https://api.github.com/users/GameAnalytics/followers","following_url":"https://api.github.com/users/GameAnalytics/following{/other_user}","gists_url":"https://api.github.com/users/GameAnalytics/gists{/gist_id}","starred_url":"https://api.github.com/users/GameAnalytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GameAnalytics/subscriptions","organizations_url":"https://api.github.com/users/GameAnalytics/orgs","repos_url":"https://api.github.com/users/GameAnalytics/repos","events_url":"https://api.github.com/users/GameAnalytics/events{/privacy}","received_events_url":"https://api.github.com/users/GameAnalytics/received_events","type":"Organization","site_admin":false},"repo":{"id":14116135,"name":"current","full_name":"GameAnalytics/current","owner":{"login":"GameAnalytics","id":1216299,"avatar_url":"https://avatars.githubusercontent.com/u/1216299?v=3","gravatar_id":"","url":"https://api.github.com/users/GameAnalytics","html_url":"https://github.com/GameAnalytics","followers_url":"https://api.github.com/users/GameAnalytics/followers","following_url":"https://api.github.com/users/GameAnalytics/following{/other_user}","gists_url":"https://api.github.com/users/GameAnalytics/gists{/gist_id}","starred_url":"https://api.github.com/users/GameAnalytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GameAnalytics/subscriptions","organizations_url":"https://api.github.com/users/GameAnalytics/orgs","repos_url":"https://api.github.com/users/GameAnalytics/repos","events_url":"https://api.github.com/users/GameAnalytics/events{/privacy}","received_events_url":"https://api.github.com/users/GameAnalytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GameAnalytics/current","description":"Erlang client for DynamoDB","fork":false,"url":"https://api.github.com/repos/GameAnalytics/current","forks_url":"https://api.github.com/repos/GameAnalytics/current/forks","keys_url":"https://api.github.com/repos/GameAnalytics/current/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GameAnalytics/current/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GameAnalytics/current/teams","hooks_url":"https://api.github.com/repos/GameAnalytics/current/hooks","issue_events_url":"https://api.github.com/repos/GameAnalytics/current/issues/events{/number}","events_url":"https://api.github.com/repos/GameAnalytics/current/events","assignees_url":"https://api.github.com/repos/GameAnalytics/current/assignees{/user}","branches_url":"https://api.github.com/repos/GameAnalytics/current/branches{/branch}","tags_url":"https://api.github.com/repos/GameAnalytics/current/tags","blobs_url":"https://api.github.com/repos/GameAnalytics/current/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GameAnalytics/current/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GameAnalytics/current/git/refs{/sha}","trees_url":"https://api.github.com/repos/GameAnalytics/current/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GameAnalytics/current/statuses/{sha}","languages_url":"https://api.github.com/repos/GameAnalytics/current/languages","stargazers_url":"https://api.github.com/repos/GameAnalytics/current/stargazers","contributors_url":"https://api.github.com/repos/GameAnalytics/current/contributors","subscribers_url":"https://api.github.com/repos/GameAnalytics/current/subscribers","subscription_url":"https://api.github.com/repos/GameAnalytics/current/subscription","commits_url":"https://api.github.com/repos/GameAnalytics/current/commits{/sha}","git_commits_url":"https://api.github.com/repos/GameAnalytics/current/git/commits{/sha}","comments_url":"https://api.github.com/repos/GameAnalytics/current/comments{/number}","issue_comment_url":"https://api.github.com/repos/GameAnalytics/current/issues/comments{/number}","contents_url":"https://api.github.com/repos/GameAnalytics/current/contents/{+path}","compare_url":"https://api.github.com/repos/GameAnalytics/current/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GameAnalytics/current/merges","archive_url":"https://api.github.com/repos/GameAnalytics/current/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GameAnalytics/current/downloads","issues_url":"https://api.github.com/repos/GameAnalytics/current/issues{/number}","pulls_url":"https://api.github.com/repos/GameAnalytics/current/pulls{/number}","milestones_url":"https://api.github.com/repos/GameAnalytics/current/milestones{/number}","notifications_url":"https://api.github.com/repos/GameAnalytics/current/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GameAnalytics/current/labels{/name}","releases_url":"https://api.github.com/repos/GameAnalytics/current/releases{/id}","created_at":"2013-11-04T16:23:36Z","updated_at":"2015-05-05T09:02:24Z","pushed_at":"2015-06-24T14:23:22Z","git_url":"git://github.com/GameAnalytics/current.git","ssh_url":"git@github.com:GameAnalytics/current.git","clone_url":"https://github.com/GameAnalytics/current.git","svn_url":"https://github.com/GameAnalytics/current","homepage":null,"size":677,"stargazers_count":7,"watchers_count":7,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":7,"default_branch":"master"}},"base":{"label":"GameAnalytics:master","ref":"master","sha":"993c2e1e6c5d39fc726fcd1a2a03202a68f9efd1","user":{"login":"GameAnalytics","id":1216299,"avatar_url":"https://avatars.githubusercontent.com/u/1216299?v=3","gravatar_id":"","url":"https://api.github.com/users/GameAnalytics","html_url":"https://github.com/GameAnalytics","followers_url":"https://api.github.com/users/GameAnalytics/followers","following_url":"https://api.github.com/users/GameAnalytics/following{/other_user}","gists_url":"https://api.github.com/users/GameAnalytics/gists{/gist_id}","starred_url":"https://api.github.com/users/GameAnalytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GameAnalytics/subscriptions","organizations_url":"https://api.github.com/users/GameAnalytics/orgs","repos_url":"https://api.github.com/users/GameAnalytics/repos","events_url":"https://api.github.com/users/GameAnalytics/events{/privacy}","received_events_url":"https://api.github.com/users/GameAnalytics/received_events","type":"Organization","site_admin":false},"repo":{"id":14116135,"name":"current","full_name":"GameAnalytics/current","owner":{"login":"GameAnalytics","id":1216299,"avatar_url":"https://avatars.githubusercontent.com/u/1216299?v=3","gravatar_id":"","url":"https://api.github.com/users/GameAnalytics","html_url":"https://github.com/GameAnalytics","followers_url":"https://api.github.com/users/GameAnalytics/followers","following_url":"https://api.github.com/users/GameAnalytics/following{/other_user}","gists_url":"https://api.github.com/users/GameAnalytics/gists{/gist_id}","starred_url":"https://api.github.com/users/GameAnalytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GameAnalytics/subscriptions","organizations_url":"https://api.github.com/users/GameAnalytics/orgs","repos_url":"https://api.github.com/users/GameAnalytics/repos","events_url":"https://api.github.com/users/GameAnalytics/events{/privacy}","received_events_url":"https://api.github.com/users/GameAnalytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GameAnalytics/current","description":"Erlang client for DynamoDB","fork":false,"url":"https://api.github.com/repos/GameAnalytics/current","forks_url":"https://api.github.com/repos/GameAnalytics/current/forks","keys_url":"https://api.github.com/repos/GameAnalytics/current/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GameAnalytics/current/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GameAnalytics/current/teams","hooks_url":"https://api.github.com/repos/GameAnalytics/current/hooks","issue_events_url":"https://api.github.com/repos/GameAnalytics/current/issues/events{/number}","events_url":"https://api.github.com/repos/GameAnalytics/current/events","assignees_url":"https://api.github.com/repos/GameAnalytics/current/assignees{/user}","branches_url":"https://api.github.com/repos/GameAnalytics/current/branches{/branch}","tags_url":"https://api.github.com/repos/GameAnalytics/current/tags","blobs_url":"https://api.github.com/repos/GameAnalytics/current/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GameAnalytics/current/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GameAnalytics/current/git/refs{/sha}","trees_url":"https://api.github.com/repos/GameAnalytics/current/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GameAnalytics/current/statuses/{sha}","languages_url":"https://api.github.com/repos/GameAnalytics/current/languages","stargazers_url":"https://api.github.com/repos/GameAnalytics/current/stargazers","contributors_url":"https://api.github.com/repos/GameAnalytics/current/contributors","subscribers_url":"https://api.github.com/repos/GameAnalytics/current/subscribers","subscription_url":"https://api.github.com/repos/GameAnalytics/current/subscription","commits_url":"https://api.github.com/repos/GameAnalytics/current/commits{/sha}","git_commits_url":"https://api.github.com/repos/GameAnalytics/current/git/commits{/sha}","comments_url":"https://api.github.com/repos/GameAnalytics/current/comments{/number}","issue_comment_url":"https://api.github.com/repos/GameAnalytics/current/issues/comments{/number}","contents_url":"https://api.github.com/repos/GameAnalytics/current/contents/{+path}","compare_url":"https://api.github.com/repos/GameAnalytics/current/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GameAnalytics/current/merges","archive_url":"https://api.github.com/repos/GameAnalytics/current/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GameAnalytics/current/downloads","issues_url":"https://api.github.com/repos/GameAnalytics/current/issues{/number}","pulls_url":"https://api.github.com/repos/GameAnalytics/current/pulls{/number}","milestones_url":"https://api.github.com/repos/GameAnalytics/current/milestones{/number}","notifications_url":"https://api.github.com/repos/GameAnalytics/current/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GameAnalytics/current/labels{/name}","releases_url":"https://api.github.com/repos/GameAnalytics/current/releases{/id}","created_at":"2013-11-04T16:23:36Z","updated_at":"2015-05-05T09:02:24Z","pushed_at":"2015-06-24T14:23:22Z","git_url":"git://github.com/GameAnalytics/current.git","ssh_url":"git@github.com:GameAnalytics/current.git","clone_url":"https://github.com/GameAnalytics/current.git","svn_url":"https://github.com/GameAnalytics/current","homepage":null,"size":677,"stargazers_count":7,"watchers_count":7,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GameAnalytics/current/pulls/16"},"html":{"href":"https://github.com/GameAnalytics/current/pull/16"},"issue":{"href":"https://api.github.com/repos/GameAnalytics/current/issues/16"},"comments":{"href":"https://api.github.com/repos/GameAnalytics/current/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/GameAnalytics/current/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/GameAnalytics/current/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GameAnalytics/current/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/GameAnalytics/current/statuses/93b3c3b36dfbe9dc0acea4511698a5313effb1c6"}}}}