{"comment":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/comments/9637149","html_url":"https://github.com/magnumripper/JohnTheRipper/commit/7a9d98e9c8ebc2b1d48c96a38b3cd7ed3cca481a#commitcomment-9637149","id":9637149,"user":{"login":"magnumripper","id":1268598,"avatar_url":"https://avatars.githubusercontent.com/u/1268598?v=3","gravatar_id":"","url":"https://api.github.com/users/magnumripper","html_url":"https://github.com/magnumripper","followers_url":"https://api.github.com/users/magnumripper/followers","following_url":"https://api.github.com/users/magnumripper/following{/other_user}","gists_url":"https://api.github.com/users/magnumripper/gists{/gist_id}","starred_url":"https://api.github.com/users/magnumripper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnumripper/subscriptions","organizations_url":"https://api.github.com/users/magnumripper/orgs","repos_url":"https://api.github.com/users/magnumripper/repos","events_url":"https://api.github.com/users/magnumripper/events{/privacy}","received_events_url":"https://api.github.com/users/magnumripper/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"7a9d98e9c8ebc2b1d48c96a38b3cd7ed3cca481a","created_at":"2015-02-07T16:01:04Z","updated_at":"2015-02-07T16:01:04Z","body":"You should do the same in recovery.c and cracker.c. The different lock functions are supposedly compatible with each other but I wouldn't trust that. I will try using this code w/ Linux later.\r\n\r\nAlso I think you should change the `#if __CYGWIN__` to `#if JTR_LOCK_FCNTL` or something like that, and have AC set that for Cygwin. That's a no-op change but it means we can later pick this for use by some/many other OS's just changing configure."}}