{"action":"opened","number":212,"pull_request":{"url":"https://api.github.com/repos/japgolly/scalajs-react/pulls/212","id":48709974,"html_url":"https://github.com/japgolly/scalajs-react/pull/212","diff_url":"https://github.com/japgolly/scalajs-react/pull/212.diff","patch_url":"https://github.com/japgolly/scalajs-react/pull/212.patch","issue_url":"https://api.github.com/repos/japgolly/scalajs-react/issues/212","number":212,"state":"open","locked":false,"title":"Basic Component without Tests and Reuseability Part","user":{"login":"xsistens","id":2904380,"avatar_url":"https://avatars.githubusercontent.com/u/2904380?v=3","gravatar_id":"","url":"https://api.github.com/users/xsistens","html_url":"https://github.com/xsistens","followers_url":"https://api.github.com/users/xsistens/followers","following_url":"https://api.github.com/users/xsistens/following{/other_user}","gists_url":"https://api.github.com/users/xsistens/gists{/gist_id}","starred_url":"https://api.github.com/users/xsistens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xsistens/subscriptions","organizations_url":"https://api.github.com/users/xsistens/orgs","repos_url":"https://api.github.com/users/xsistens/repos","events_url":"https://api.github.com/users/xsistens/events{/privacy}","received_events_url":"https://api.github.com/users/xsistens/received_events","type":"User","site_admin":false},"body":"Here is my first PR for the es6 topic branch. Everything written here is working so far. I also added some basic tests to the ```CoreTest```s file, but even the unmodified tests gave me some errors. Probably because of my phantomjs setup or something like this, had not enough time to investigate into this. In the ghpages project are some examples on how es6 components can be used with ```ReactComponentB``` components. \r\n\r\nOne thing that bothers me a bit and i'm not really sure how to handle it is the type parameter ```N <: TopNode``` for the reason of the DOM dependency. I think if we can get rid of this in some way, this branch could also be used from @chandu0101 as a base for his sri project. I think there has to be a solution for it, at the latest when you start separating the projects into the core and dom projects like facebook was doing it. Maybe you can pull out something in this regard :) ","created_at":"2015-10-26T07:54:42Z","updated_at":"2015-10-26T07:54:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/japgolly/scalajs-react/pulls/212/commits","review_comments_url":"https://api.github.com/repos/japgolly/scalajs-react/pulls/212/comments","review_comment_url":"https://api.github.com/repos/japgolly/scalajs-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/japgolly/scalajs-react/issues/212/comments","statuses_url":"https://api.github.com/repos/japgolly/scalajs-react/statuses/22e0672f85e6f7bfa1107eed961eb3edf7da2ab5","head":{"label":"xsistens:topic/es6","ref":"topic/es6","sha":"22e0672f85e6f7bfa1107eed961eb3edf7da2ab5","user":{"login":"xsistens","id":2904380,"avatar_url":"https://avatars.githubusercontent.com/u/2904380?v=3","gravatar_id":"","url":"https://api.github.com/users/xsistens","html_url":"https://github.com/xsistens","followers_url":"https://api.github.com/users/xsistens/followers","following_url":"https://api.github.com/users/xsistens/following{/other_user}","gists_url":"https://api.github.com/users/xsistens/gists{/gist_id}","starred_url":"https://api.github.com/users/xsistens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xsistens/subscriptions","organizations_url":"https://api.github.com/users/xsistens/orgs","repos_url":"https://api.github.com/users/xsistens/repos","events_url":"https://api.github.com/users/xsistens/events{/privacy}","received_events_url":"https://api.github.com/users/xsistens/received_events","type":"User","site_admin":false},"repo":{"id":44236737,"name":"scalajs-react","full_name":"xsistens/scalajs-react","owner":{"login":"xsistens","id":2904380,"avatar_url":"https://avatars.githubusercontent.com/u/2904380?v=3","gravatar_id":"","url":"https://api.github.com/users/xsistens","html_url":"https://github.com/xsistens","followers_url":"https://api.github.com/users/xsistens/followers","following_url":"https://api.github.com/users/xsistens/following{/other_user}","gists_url":"https://api.github.com/users/xsistens/gists{/gist_id}","starred_url":"https://api.github.com/users/xsistens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xsistens/subscriptions","organizations_url":"https://api.github.com/users/xsistens/orgs","repos_url":"https://api.github.com/users/xsistens/repos","events_url":"https://api.github.com/users/xsistens/events{/privacy}","received_events_url":"https://api.github.com/users/xsistens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xsistens/scalajs-react","description":"Facebook's React on Scala.js","fork":true,"url":"https://api.github.com/repos/xsistens/scalajs-react","forks_url":"https://api.github.com/repos/xsistens/scalajs-react/forks","keys_url":"https://api.github.com/repos/xsistens/scalajs-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xsistens/scalajs-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xsistens/scalajs-react/teams","hooks_url":"https://api.github.com/repos/xsistens/scalajs-react/hooks","issue_events_url":"https://api.github.com/repos/xsistens/scalajs-react/issues/events{/number}","events_url":"https://api.github.com/repos/xsistens/scalajs-react/events","assignees_url":"https://api.github.com/repos/xsistens/scalajs-react/assignees{/user}","branches_url":"https://api.github.com/repos/xsistens/scalajs-react/branches{/branch}","tags_url":"https://api.github.com/repos/xsistens/scalajs-react/tags","blobs_url":"https://api.github.com/repos/xsistens/scalajs-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xsistens/scalajs-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xsistens/scalajs-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/xsistens/scalajs-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xsistens/scalajs-react/statuses/{sha}","languages_url":"https://api.github.com/repos/xsistens/scalajs-react/languages","stargazers_url":"https://api.github.com/repos/xsistens/scalajs-react/stargazers","contributors_url":"https://api.github.com/repos/xsistens/scalajs-react/contributors","subscribers_url":"https://api.github.com/repos/xsistens/scalajs-react/subscribers","subscription_url":"https://api.github.com/repos/xsistens/scalajs-react/subscription","commits_url":"https://api.github.com/repos/xsistens/scalajs-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/xsistens/scalajs-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/xsistens/scalajs-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/xsistens/scalajs-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/xsistens/scalajs-react/contents/{+path}","compare_url":"https://api.github.com/repos/xsistens/scalajs-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xsistens/scalajs-react/merges","archive_url":"https://api.github.com/repos/xsistens/scalajs-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xsistens/scalajs-react/downloads","issues_url":"https://api.github.com/repos/xsistens/scalajs-react/issues{/number}","pulls_url":"https://api.github.com/repos/xsistens/scalajs-react/pulls{/number}","milestones_url":"https://api.github.com/repos/xsistens/scalajs-react/milestones{/number}","notifications_url":"https://api.github.com/repos/xsistens/scalajs-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xsistens/scalajs-react/labels{/name}","releases_url":"https://api.github.com/repos/xsistens/scalajs-react/releases{/id}","created_at":"2015-10-14T09:11:26Z","updated_at":"2015-10-14T09:11:28Z","pushed_at":"2015-10-26T07:31:59Z","git_url":"git://github.com/xsistens/scalajs-react.git","ssh_url":"git@github.com:xsistens/scalajs-react.git","clone_url":"https://github.com/xsistens/scalajs-react.git","svn_url":"https://github.com/xsistens/scalajs-react","homepage":"https://japgolly.github.io/scalajs-react/","size":3494,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"japgolly:topic/es6","ref":"topic/es6","sha":"f988eb52b05c1dfc0c46da3ec7e1cc99d5403596","user":{"login":"japgolly","id":202935,"avatar_url":"https://avatars.githubusercontent.com/u/202935?v=3","gravatar_id":"","url":"https://api.github.com/users/japgolly","html_url":"https://github.com/japgolly","followers_url":"https://api.github.com/users/japgolly/followers","following_url":"https://api.github.com/users/japgolly/following{/other_user}","gists_url":"https://api.github.com/users/japgolly/gists{/gist_id}","starred_url":"https://api.github.com/users/japgolly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japgolly/subscriptions","organizations_url":"https://api.github.com/users/japgolly/orgs","repos_url":"https://api.github.com/users/japgolly/repos","events_url":"https://api.github.com/users/japgolly/events{/privacy}","received_events_url":"https://api.github.com/users/japgolly/received_events","type":"User","site_admin":false},"repo":{"id":21457951,"name":"scalajs-react","full_name":"japgolly/scalajs-react","owner":{"login":"japgolly","id":202935,"avatar_url":"https://avatars.githubusercontent.com/u/202935?v=3","gravatar_id":"","url":"https://api.github.com/users/japgolly","html_url":"https://github.com/japgolly","followers_url":"https://api.github.com/users/japgolly/followers","following_url":"https://api.github.com/users/japgolly/following{/other_user}","gists_url":"https://api.github.com/users/japgolly/gists{/gist_id}","starred_url":"https://api.github.com/users/japgolly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japgolly/subscriptions","organizations_url":"https://api.github.com/users/japgolly/orgs","repos_url":"https://api.github.com/users/japgolly/repos","events_url":"https://api.github.com/users/japgolly/events{/privacy}","received_events_url":"https://api.github.com/users/japgolly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/japgolly/scalajs-react","description":"Facebook's React on Scala.js","fork":false,"url":"https://api.github.com/repos/japgolly/scalajs-react","forks_url":"https://api.github.com/repos/japgolly/scalajs-react/forks","keys_url":"https://api.github.com/repos/japgolly/scalajs-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/japgolly/scalajs-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/japgolly/scalajs-react/teams","hooks_url":"https://api.github.com/repos/japgolly/scalajs-react/hooks","issue_events_url":"https://api.github.com/repos/japgolly/scalajs-react/issues/events{/number}","events_url":"https://api.github.com/repos/japgolly/scalajs-react/events","assignees_url":"https://api.github.com/repos/japgolly/scalajs-react/assignees{/user}","branches_url":"https://api.github.com/repos/japgolly/scalajs-react/branches{/branch}","tags_url":"https://api.github.com/repos/japgolly/scalajs-react/tags","blobs_url":"https://api.github.com/repos/japgolly/scalajs-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/japgolly/scalajs-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/japgolly/scalajs-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/japgolly/scalajs-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/japgolly/scalajs-react/statuses/{sha}","languages_url":"https://api.github.com/repos/japgolly/scalajs-react/languages","stargazers_url":"https://api.github.com/repos/japgolly/scalajs-react/stargazers","contributors_url":"https://api.github.com/repos/japgolly/scalajs-react/contributors","subscribers_url":"https://api.github.com/repos/japgolly/scalajs-react/subscribers","subscription_url":"https://api.github.com/repos/japgolly/scalajs-react/subscription","commits_url":"https://api.github.com/repos/japgolly/scalajs-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/japgolly/scalajs-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/japgolly/scalajs-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/japgolly/scalajs-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/japgolly/scalajs-react/contents/{+path}","compare_url":"https://api.github.com/repos/japgolly/scalajs-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/japgolly/scalajs-react/merges","archive_url":"https://api.github.com/repos/japgolly/scalajs-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/japgolly/scalajs-react/downloads","issues_url":"https://api.github.com/repos/japgolly/scalajs-react/issues{/number}","pulls_url":"https://api.github.com/repos/japgolly/scalajs-react/pulls{/number}","milestones_url":"https://api.github.com/repos/japgolly/scalajs-react/milestones{/number}","notifications_url":"https://api.github.com/repos/japgolly/scalajs-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/japgolly/scalajs-react/labels{/name}","releases_url":"https://api.github.com/repos/japgolly/scalajs-react/releases{/id}","created_at":"2014-07-03T09:58:42Z","updated_at":"2015-10-25T23:28:24Z","pushed_at":"2015-10-26T01:08:46Z","git_url":"git://github.com/japgolly/scalajs-react.git","ssh_url":"git@github.com:japgolly/scalajs-react.git","clone_url":"https://github.com/japgolly/scalajs-react.git","svn_url":"https://github.com/japgolly/scalajs-react","homepage":"https://japgolly.github.io/scalajs-react/","size":6494,"stargazers_count":380,"watchers_count":380,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":56,"mirror_url":null,"open_issues_count":19,"forks":56,"open_issues":19,"watchers":380,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/japgolly/scalajs-react/pulls/212"},"html":{"href":"https://github.com/japgolly/scalajs-react/pull/212"},"issue":{"href":"https://api.github.com/repos/japgolly/scalajs-react/issues/212"},"comments":{"href":"https://api.github.com/repos/japgolly/scalajs-react/issues/212/comments"},"review_comments":{"href":"https://api.github.com/repos/japgolly/scalajs-react/pulls/212/comments"},"review_comment":{"href":"https://api.github.com/repos/japgolly/scalajs-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/japgolly/scalajs-react/pulls/212/commits"},"statuses":{"href":"https://api.github.com/repos/japgolly/scalajs-react/statuses/22e0672f85e6f7bfa1107eed961eb3edf7da2ab5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":7,"additions":372,"deletions":4,"changed_files":16}}