{"action":"created","comment":{"url":"https://api.github.com/repos/pezra/rspec-mode/pulls/comments/22540680","id":22540680,"diff_hunk":"@@ -567,13 +567,15 @@ file if it exists, or sensible defaults otherwise\"\n \n (defun rspec-spring-p ()\n   (and rspec-use-spring-when-possible\n-       (let ((root (rspec-project-root)))\n+       (let ((root (substring (rspec-project-root) 0 -1))\n+              (ruby-version (shell-command-to-string \"ruby -e 'print RUBY_VERSION'\")))\n          (or\n           ;; Older versions\n-          (file-exists-p (concat root \"tmp/spring/spring.pid\"))\n+          (file-exists-p (format \"/%s/tmp/spring/spring.pid\" root))\n           ;; 0.9.2+\n-          (file-exists-p (concat temporary-file-directory \"spring/\"\n-                                 (md5 (substring root 0 -1)) \".pid\"))))))\n+          (file-exists-p (format \"/%s/spring/%s.pid\" temporary-file-directory (md5 root)))\n+          ;; 1.2.0+\n+          (file-exists-p (format \"/%s/spring/%s.pid\" (getenv \"XDG_RUNTIME_DIR\") (md5 (concat ruby-version root))))))))","path":"rspec-mode.el","position":16,"original_position":16,"commit_id":"a87b072e38c5ee3e9516d64d58f7e32f3d9a8896","original_commit_id":"a87b072e38c5ee3e9516d64d58f7e32f3d9a8896","user":{"login":"dgutov","id":271877,"avatar_url":"https://avatars.githubusercontent.com/u/271877?v=3","gravatar_id":"","url":"https://api.github.com/users/dgutov","html_url":"https://github.com/dgutov","followers_url":"https://api.github.com/users/dgutov/followers","following_url":"https://api.github.com/users/dgutov/following{/other_user}","gists_url":"https://api.github.com/users/dgutov/gists{/gist_id}","starred_url":"https://api.github.com/users/dgutov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgutov/subscriptions","organizations_url":"https://api.github.com/users/dgutov/orgs","repos_url":"https://api.github.com/users/dgutov/repos","events_url":"https://api.github.com/users/dgutov/events{/privacy}","received_events_url":"https://api.github.com/users/dgutov/received_events","type":"User","site_admin":false},"body":"Won't this fail if `XDG_RUNTIME_DIR` is not set? Spring defaults to `Dir.tmpdir`, if so.","created_at":"2015-01-06T18:29:55Z","updated_at":"2015-01-06T18:29:55Z","html_url":"https://github.com/pezra/rspec-mode/pull/103#discussion_r22540680","pull_request_url":"https://api.github.com/repos/pezra/rspec-mode/pulls/103","_links":{"self":{"href":"https://api.github.com/repos/pezra/rspec-mode/pulls/comments/22540680"},"html":{"href":"https://github.com/pezra/rspec-mode/pull/103#discussion_r22540680"},"pull_request":{"href":"https://api.github.com/repos/pezra/rspec-mode/pulls/103"}}},"pull_request":{"url":"https://api.github.com/repos/pezra/rspec-mode/pulls/103","id":26887007,"html_url":"https://github.com/pezra/rspec-mode/pull/103","diff_url":"https://github.com/pezra/rspec-mode/pull/103.diff","patch_url":"https://github.com/pezra/rspec-mode/pull/103.patch","issue_url":"https://api.github.com/repos/pezra/rspec-mode/issues/103","number":103,"state":"open","locked":false,"title":"Recognize spring versions > 1.2","user":{"login":"ineu","id":24980,"avatar_url":"https://avatars.githubusercontent.com/u/24980?v=3","gravatar_id":"","url":"https://api.github.com/users/ineu","html_url":"https://github.com/ineu","followers_url":"https://api.github.com/users/ineu/followers","following_url":"https://api.github.com/users/ineu/following{/other_user}","gists_url":"https://api.github.com/users/ineu/gists{/gist_id}","starred_url":"https://api.github.com/users/ineu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ineu/subscriptions","organizations_url":"https://api.github.com/users/ineu/orgs","repos_url":"https://api.github.com/users/ineu/repos","events_url":"https://api.github.com/users/ineu/events{/privacy}","received_events_url":"https://api.github.com/users/ineu/received_events","type":"User","site_admin":false},"body":"Adapts to change in https://github.com/rails/spring/commit/7d7f33e5dfbe1ef6d170a25740f39f412562963b","created_at":"2015-01-06T12:52:00Z","updated_at":"2015-01-06T18:29:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38ce1bfad9f07b1223e3a919ad94f60249c46ff1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pezra/rspec-mode/pulls/103/commits","review_comments_url":"https://api.github.com/repos/pezra/rspec-mode/pulls/103/comments","review_comment_url":"https://api.github.com/repos/pezra/rspec-mode/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pezra/rspec-mode/issues/103/comments","statuses_url":"https://api.github.com/repos/pezra/rspec-mode/statuses/a87b072e38c5ee3e9516d64d58f7e32f3d9a8896","head":{"label":"ineu:recent-spring","ref":"recent-spring","sha":"a87b072e38c5ee3e9516d64d58f7e32f3d9a8896","user":{"login":"ineu","id":24980,"avatar_url":"https://avatars.githubusercontent.com/u/24980?v=3","gravatar_id":"","url":"https://api.github.com/users/ineu","html_url":"https://github.com/ineu","followers_url":"https://api.github.com/users/ineu/followers","following_url":"https://api.github.com/users/ineu/following{/other_user}","gists_url":"https://api.github.com/users/ineu/gists{/gist_id}","starred_url":"https://api.github.com/users/ineu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ineu/subscriptions","organizations_url":"https://api.github.com/users/ineu/orgs","repos_url":"https://api.github.com/users/ineu/repos","events_url":"https://api.github.com/users/ineu/events{/privacy}","received_events_url":"https://api.github.com/users/ineu/received_events","type":"User","site_admin":false},"repo":{"id":28851200,"name":"rspec-mode","full_name":"ineu/rspec-mode","owner":{"login":"ineu","id":24980,"avatar_url":"https://avatars.githubusercontent.com/u/24980?v=3","gravatar_id":"","url":"https://api.github.com/users/ineu","html_url":"https://github.com/ineu","followers_url":"https://api.github.com/users/ineu/followers","following_url":"https://api.github.com/users/ineu/following{/other_user}","gists_url":"https://api.github.com/users/ineu/gists{/gist_id}","starred_url":"https://api.github.com/users/ineu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ineu/subscriptions","organizations_url":"https://api.github.com/users/ineu/orgs","repos_url":"https://api.github.com/users/ineu/repos","events_url":"https://api.github.com/users/ineu/events{/privacy}","received_events_url":"https://api.github.com/users/ineu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ineu/rspec-mode","description":"An RSpec minor mode for Emacs","fork":true,"url":"https://api.github.com/repos/ineu/rspec-mode","forks_url":"https://api.github.com/repos/ineu/rspec-mode/forks","keys_url":"https://api.github.com/repos/ineu/rspec-mode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ineu/rspec-mode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ineu/rspec-mode/teams","hooks_url":"https://api.github.com/repos/ineu/rspec-mode/hooks","issue_events_url":"https://api.github.com/repos/ineu/rspec-mode/issues/events{/number}","events_url":"https://api.github.com/repos/ineu/rspec-mode/events","assignees_url":"https://api.github.com/repos/ineu/rspec-mode/assignees{/user}","branches_url":"https://api.github.com/repos/ineu/rspec-mode/branches{/branch}","tags_url":"https://api.github.com/repos/ineu/rspec-mode/tags","blobs_url":"https://api.github.com/repos/ineu/rspec-mode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ineu/rspec-mode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ineu/rspec-mode/git/refs{/sha}","trees_url":"https://api.github.com/repos/ineu/rspec-mode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ineu/rspec-mode/statuses/{sha}","languages_url":"https://api.github.com/repos/ineu/rspec-mode/languages","stargazers_url":"https://api.github.com/repos/ineu/rspec-mode/stargazers","contributors_url":"https://api.github.com/repos/ineu/rspec-mode/contributors","subscribers_url":"https://api.github.com/repos/ineu/rspec-mode/subscribers","subscription_url":"https://api.github.com/repos/ineu/rspec-mode/subscription","commits_url":"https://api.github.com/repos/ineu/rspec-mode/commits{/sha}","git_commits_url":"https://api.github.com/repos/ineu/rspec-mode/git/commits{/sha}","comments_url":"https://api.github.com/repos/ineu/rspec-mode/comments{/number}","issue_comment_url":"https://api.github.com/repos/ineu/rspec-mode/issues/comments/{number}","contents_url":"https://api.github.com/repos/ineu/rspec-mode/contents/{+path}","compare_url":"https://api.github.com/repos/ineu/rspec-mode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ineu/rspec-mode/merges","archive_url":"https://api.github.com/repos/ineu/rspec-mode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ineu/rspec-mode/downloads","issues_url":"https://api.github.com/repos/ineu/rspec-mode/issues{/number}","pulls_url":"https://api.github.com/repos/ineu/rspec-mode/pulls{/number}","milestones_url":"https://api.github.com/repos/ineu/rspec-mode/milestones{/number}","notifications_url":"https://api.github.com/repos/ineu/rspec-mode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ineu/rspec-mode/labels{/name}","releases_url":"https://api.github.com/repos/ineu/rspec-mode/releases{/id}","created_at":"2015-01-06T07:03:24Z","updated_at":"2015-01-06T07:03:24Z","pushed_at":"2015-01-06T15:04:08Z","git_url":"git://github.com/ineu/rspec-mode.git","ssh_url":"git@github.com:ineu/rspec-mode.git","clone_url":"https://github.com/ineu/rspec-mode.git","svn_url":"https://github.com/ineu/rspec-mode","homepage":"http://pezra.barelyenough.org/projects/rspec-mode","size":885,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pezra:master","ref":"master","sha":"97cfff7a7a0e279106513833b1e2400bb682b210","user":{"login":"pezra","id":4122,"avatar_url":"https://avatars.githubusercontent.com/u/4122?v=3","gravatar_id":"","url":"https://api.github.com/users/pezra","html_url":"https://github.com/pezra","followers_url":"https://api.github.com/users/pezra/followers","following_url":"https://api.github.com/users/pezra/following{/other_user}","gists_url":"https://api.github.com/users/pezra/gists{/gist_id}","starred_url":"https://api.github.com/users/pezra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pezra/subscriptions","organizations_url":"https://api.github.com/users/pezra/orgs","repos_url":"https://api.github.com/users/pezra/repos","events_url":"https://api.github.com/users/pezra/events{/privacy}","received_events_url":"https://api.github.com/users/pezra/received_events","type":"User","site_admin":false},"repo":{"id":12494,"name":"rspec-mode","full_name":"pezra/rspec-mode","owner":{"login":"pezra","id":4122,"avatar_url":"https://avatars.githubusercontent.com/u/4122?v=3","gravatar_id":"","url":"https://api.github.com/users/pezra","html_url":"https://github.com/pezra","followers_url":"https://api.github.com/users/pezra/followers","following_url":"https://api.github.com/users/pezra/following{/other_user}","gists_url":"https://api.github.com/users/pezra/gists{/gist_id}","starred_url":"https://api.github.com/users/pezra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pezra/subscriptions","organizations_url":"https://api.github.com/users/pezra/orgs","repos_url":"https://api.github.com/users/pezra/repos","events_url":"https://api.github.com/users/pezra/events{/privacy}","received_events_url":"https://api.github.com/users/pezra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pezra/rspec-mode","description":"An RSpec minor mode for Emacs","fork":false,"url":"https://api.github.com/repos/pezra/rspec-mode","forks_url":"https://api.github.com/repos/pezra/rspec-mode/forks","keys_url":"https://api.github.com/repos/pezra/rspec-mode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pezra/rspec-mode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pezra/rspec-mode/teams","hooks_url":"https://api.github.com/repos/pezra/rspec-mode/hooks","issue_events_url":"https://api.github.com/repos/pezra/rspec-mode/issues/events{/number}","events_url":"https://api.github.com/repos/pezra/rspec-mode/events","assignees_url":"https://api.github.com/repos/pezra/rspec-mode/assignees{/user}","branches_url":"https://api.github.com/repos/pezra/rspec-mode/branches{/branch}","tags_url":"https://api.github.com/repos/pezra/rspec-mode/tags","blobs_url":"https://api.github.com/repos/pezra/rspec-mode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pezra/rspec-mode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pezra/rspec-mode/git/refs{/sha}","trees_url":"https://api.github.com/repos/pezra/rspec-mode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pezra/rspec-mode/statuses/{sha}","languages_url":"https://api.github.com/repos/pezra/rspec-mode/languages","stargazers_url":"https://api.github.com/repos/pezra/rspec-mode/stargazers","contributors_url":"https://api.github.com/repos/pezra/rspec-mode/contributors","subscribers_url":"https://api.github.com/repos/pezra/rspec-mode/subscribers","subscription_url":"https://api.github.com/repos/pezra/rspec-mode/subscription","commits_url":"https://api.github.com/repos/pezra/rspec-mode/commits{/sha}","git_commits_url":"https://api.github.com/repos/pezra/rspec-mode/git/commits{/sha}","comments_url":"https://api.github.com/repos/pezra/rspec-mode/comments{/number}","issue_comment_url":"https://api.github.com/repos/pezra/rspec-mode/issues/comments/{number}","contents_url":"https://api.github.com/repos/pezra/rspec-mode/contents/{+path}","compare_url":"https://api.github.com/repos/pezra/rspec-mode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pezra/rspec-mode/merges","archive_url":"https://api.github.com/repos/pezra/rspec-mode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pezra/rspec-mode/downloads","issues_url":"https://api.github.com/repos/pezra/rspec-mode/issues{/number}","pulls_url":"https://api.github.com/repos/pezra/rspec-mode/pulls{/number}","milestones_url":"https://api.github.com/repos/pezra/rspec-mode/milestones{/number}","notifications_url":"https://api.github.com/repos/pezra/rspec-mode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pezra/rspec-mode/labels{/name}","releases_url":"https://api.github.com/repos/pezra/rspec-mode/releases{/id}","created_at":"2008-04-25T15:06:43Z","updated_at":"2015-01-04T06:16:52Z","pushed_at":"2015-01-01T12:13:21Z","git_url":"git://github.com/pezra/rspec-mode.git","ssh_url":"git@github.com:pezra/rspec-mode.git","clone_url":"https://github.com/pezra/rspec-mode.git","svn_url":"https://github.com/pezra/rspec-mode","homepage":"http://pezra.barelyenough.org/projects/rspec-mode","size":885,"stargazers_count":138,"watchers_count":138,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":6,"forks":66,"open_issues":6,"watchers":138,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pezra/rspec-mode/pulls/103"},"html":{"href":"https://github.com/pezra/rspec-mode/pull/103"},"issue":{"href":"https://api.github.com/repos/pezra/rspec-mode/issues/103"},"comments":{"href":"https://api.github.com/repos/pezra/rspec-mode/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/pezra/rspec-mode/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/pezra/rspec-mode/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pezra/rspec-mode/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/pezra/rspec-mode/statuses/a87b072e38c5ee3e9516d64d58f7e32f3d9a8896"}}}}