{"action":"created","issue":{"url":"https://api.github.com/repos/sahat/satellizer/issues/636","labels_url":"https://api.github.com/repos/sahat/satellizer/issues/636/labels{/name}","comments_url":"https://api.github.com/repos/sahat/satellizer/issues/636/comments","events_url":"https://api.github.com/repos/sahat/satellizer/issues/636/events","html_url":"https://github.com/sahat/satellizer/issues/636","id":115725511,"number":636,"title":"Facebook login window cancel button promise","user":{"login":"calvinlyc","id":1305903,"avatar_url":"https://avatars.githubusercontent.com/u/1305903?v=3","gravatar_id":"","url":"https://api.github.com/users/calvinlyc","html_url":"https://github.com/calvinlyc","followers_url":"https://api.github.com/users/calvinlyc/followers","following_url":"https://api.github.com/users/calvinlyc/following{/other_user}","gists_url":"https://api.github.com/users/calvinlyc/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinlyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinlyc/subscriptions","organizations_url":"https://api.github.com/users/calvinlyc/orgs","repos_url":"https://api.github.com/users/calvinlyc/repos","events_url":"https://api.github.com/users/calvinlyc/events{/privacy}","received_events_url":"https://api.github.com/users/calvinlyc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/sahat/satellizer/milestones/1","html_url":"https://github.com/sahat/satellizer/milestones/1.0","labels_url":"https://api.github.com/repos/sahat/satellizer/milestones/1/labels","id":1384763,"number":1,"title":"1.0","description":"Roadmap to 1.0","creator":{"login":"sahat","id":544954,"avatar_url":"https://avatars.githubusercontent.com/u/544954?v=3","gravatar_id":"","url":"https://api.github.com/users/sahat","html_url":"https://github.com/sahat","followers_url":"https://api.github.com/users/sahat/followers","following_url":"https://api.github.com/users/sahat/following{/other_user}","gists_url":"https://api.github.com/users/sahat/gists{/gist_id}","starred_url":"https://api.github.com/users/sahat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sahat/subscriptions","organizations_url":"https://api.github.com/users/sahat/orgs","repos_url":"https://api.github.com/users/sahat/repos","events_url":"https://api.github.com/users/sahat/events{/privacy}","received_events_url":"https://api.github.com/users/sahat/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":8,"state":"open","created_at":"2015-10-30T06:49:47Z","updated_at":"2015-11-09T18:40:22Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2015-11-08T11:16:24Z","updated_at":"2015-11-12T18:20:46Z","closed_at":null,"body":"Hi, I think the latest satellizer plugin does not support cancel button callback on Facebook login window at the moment.\r\n\r\nI had a look the code and realized around line ```707```\r\n\r\nThere is a if/else statement around deferred.resolve which prevent error be passed back to controller.\r\n```\r\nif (!qs.error) {\r\n     deferred.resolve(qs);\r\n}\r\n```\r\nBy removing the if/else statement here, I am able to handle the error actions (such as cancel button click)   in my controller, just wonder is there any reasons here to only resolve the positive promise?  \r\n\r\nKind regards"},"comment":{"url":"https://api.github.com/repos/sahat/satellizer/issues/comments/156190043","html_url":"https://github.com/sahat/satellizer/issues/636#issuecomment-156190043","issue_url":"https://api.github.com/repos/sahat/satellizer/issues/636","id":156190043,"user":{"login":"sahat","id":544954,"avatar_url":"https://avatars.githubusercontent.com/u/544954?v=3","gravatar_id":"","url":"https://api.github.com/users/sahat","html_url":"https://github.com/sahat","followers_url":"https://api.github.com/users/sahat/followers","following_url":"https://api.github.com/users/sahat/following{/other_user}","gists_url":"https://api.github.com/users/sahat/gists{/gist_id}","starred_url":"https://api.github.com/users/sahat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sahat/subscriptions","organizations_url":"https://api.github.com/users/sahat/orgs","repos_url":"https://api.github.com/users/sahat/repos","events_url":"https://api.github.com/users/sahat/events{/privacy}","received_events_url":"https://api.github.com/users/sahat/received_events","type":"User","site_admin":false},"created_at":"2015-11-12T18:20:46Z","updated_at":"2015-11-12T18:20:46Z","body":"Check the code on master branch. It will now return a deferred.reject() with error object when a user hits a cancel button."}}