{"push_id":892814512,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"7b64c2a40aba6739d2789e4ff0675fb64d4118d5","before":"980c5b9e26982cb2e05683f94d031cebc813e6a5","commits":[{"sha":"7b64c2a40aba6739d2789e4ff0675fb64d4118d5","author":{"email":"b30c4da323c3597f69ed507e6dae64250298ef5a@chromium.org","name":"horo"},"message":"Change SharedWorkerServiceImpl::FindSharedWorkerHost() not to return terminating SharedWorkers.\n\nIn the current implementation, SharedWorkerServiceImpl::FindSharedWorkerHost()\nmay return a SharedWorkerHost which has already sent TerminateWorkerContext\nmessage to the SharedWorker's renderer process. This is causing problem when the\nsame SharedWorker is created right after the existing SharedWorker is being\nterminated. (ex: reloading the page.)\nThis CL introduces a new flag |termination_message_sent_| and checks it in\nSharedWorkerServiceImpl::FindSharedWorkerHost() not to return the terminating\nSharedWorker.\n\nThis CL also changes SharedWorkerDevToolsManager::WorkerCreated() to check\nDevToolsAgentHostImpl::IsAttached(). SharedWorkerDevToolsAgentHost may be held\nin DevToolsTargetsUIHandler.targets_ when \"chrome://inspect\" is open. So in the\ncurrent implementation, even if the DevTools window for the SharedWorker is not\nopened, the worker will be created with pause_on_start flag. This change fixes\nthis problem.\n\nBUG=516619\n\nReview URL: https://codereview.chromium.org/1497113004\n\nCr-Commit-Position: refs/heads/master@{#363439}","distinct":true,"url":"https://api.github.com/repos/dstockwell/chromium/commits/7b64c2a40aba6739d2789e4ff0675fb64d4118d5"}]}