{"action":"created","issue":{"url":"https://api.github.com/repos/timscaffidi/ofxVideoRecorder/issues/26","labels_url":"https://api.github.com/repos/timscaffidi/ofxVideoRecorder/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/timscaffidi/ofxVideoRecorder/issues/26/comments","events_url":"https://api.github.com/repos/timscaffidi/ofxVideoRecorder/issues/26/events","html_url":"https://github.com/timscaffidi/ofxVideoRecorder/pull/26","id":101081945,"number":26,"title":"Feature addFrame methods returns now a bool value","user":{"login":"smallfly","id":157141,"avatar_url":"https://avatars.githubusercontent.com/u/157141?v=3","gravatar_id":"","url":"https://api.github.com/users/smallfly","html_url":"https://github.com/smallfly","followers_url":"https://api.github.com/users/smallfly/followers","following_url":"https://api.github.com/users/smallfly/following{/other_user}","gists_url":"https://api.github.com/users/smallfly/gists{/gist_id}","starred_url":"https://api.github.com/users/smallfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smallfly/subscriptions","organizations_url":"https://api.github.com/users/smallfly/orgs","repos_url":"https://api.github.com/users/smallfly/repos","events_url":"https://api.github.com/users/smallfly/events{/privacy}","received_events_url":"https://api.github.com/users/smallfly/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-08-14T19:04:47Z","updated_at":"2015-08-18T00:41:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/timscaffidi/ofxVideoRecorder/pulls/26","html_url":"https://github.com/timscaffidi/ofxVideoRecorder/pull/26","diff_url":"https://github.com/timscaffidi/ofxVideoRecorder/pull/26.diff","patch_url":"https://github.com/timscaffidi/ofxVideoRecorder/pull/26.patch"},"body":"Hi,\r\n\r\nThe addFrame method has now a return type. This lets the user know if adding a frame was successful or not. I also have updated the example that was in fact not compiling, renamed testApp to ofApp and updated the .gitignore file.\r\n\r\nLet me know if something is not ok.\r\n\r\nCheers."},"comment":{"url":"https://api.github.com/repos/timscaffidi/ofxVideoRecorder/issues/comments/132006031","html_url":"https://github.com/timscaffidi/ofxVideoRecorder/pull/26#issuecomment-132006031","issue_url":"https://api.github.com/repos/timscaffidi/ofxVideoRecorder/issues/26","id":132006031,"user":{"login":"smallfly","id":157141,"avatar_url":"https://avatars.githubusercontent.com/u/157141?v=3","gravatar_id":"","url":"https://api.github.com/users/smallfly","html_url":"https://github.com/smallfly","followers_url":"https://api.github.com/users/smallfly/followers","following_url":"https://api.github.com/users/smallfly/following{/other_user}","gists_url":"https://api.github.com/users/smallfly/gists{/gist_id}","starred_url":"https://api.github.com/users/smallfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smallfly/subscriptions","organizations_url":"https://api.github.com/users/smallfly/orgs","repos_url":"https://api.github.com/users/smallfly/repos","events_url":"https://api.github.com/users/smallfly/events{/privacy}","received_events_url":"https://api.github.com/users/smallfly/received_events","type":"User","site_admin":false},"created_at":"2015-08-18T00:41:51Z","updated_at":"2015-08-18T00:41:51Z","body":"You are right. I will look into this.\n\nSent from my iPhone\n\n> On Aug 17, 2015, at 6:20 PM, Timothy Scaffidi <notifications@github.com> wrote:\n> \n> Hmm, now that I think about it more, I don't know that it makes sense to have the addFrame method return an error this way. The add frame function only adds the video frame to the video frame queue, so it cannot know with certainty anything about the thread's execution on said frame.\n> \n> The error is set by the video writer thread, which may not have had time to process the frame that was just added yet. So the true/false does not pertain to the current frame being added, but more likely the previous frame that was added.\n> \n> I think a better solution would be to have separate functions that can be called to see if the video or audio writer threads have encountered an error, for example hasVideoError() / hasAudioError().\n> \n> The addFrame function could still return true/false based on if it is paused or not recording still, or any other errors that can be detected within the function.\n> \n> —\n> Reply to this email directly or view it on GitHub.\n> \n"}}