{"action":"created","issue":{"url":"https://api.github.com/repos/astroplanners/astroplan/issues/14","labels_url":"https://api.github.com/repos/astroplanners/astroplan/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/astroplanners/astroplan/issues/14/comments","events_url":"https://api.github.com/repos/astroplanners/astroplan/issues/14/events","html_url":"https://github.com/astroplanners/astroplan/pull/14","id":91523807,"number":14,"title":"Rise/set/transit time calculations and convenience methods","user":{"login":"bmorris3","id":3497584,"avatar_url":"https://avatars.githubusercontent.com/u/3497584?v=3","gravatar_id":"","url":"https://api.github.com/users/bmorris3","html_url":"https://github.com/bmorris3","followers_url":"https://api.github.com/users/bmorris3/followers","following_url":"https://api.github.com/users/bmorris3/following{/other_user}","gists_url":"https://api.github.com/users/bmorris3/gists{/gist_id}","starred_url":"https://api.github.com/users/bmorris3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmorris3/subscriptions","organizations_url":"https://api.github.com/users/bmorris3/orgs","repos_url":"https://api.github.com/users/bmorris3/repos","events_url":"https://api.github.com/users/bmorris3/events{/privacy}","received_events_url":"https://api.github.com/users/bmorris3/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":23,"created_at":"2015-06-27T22:24:13Z","updated_at":"2015-07-06T16:34:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/astroplanners/astroplan/pulls/14","html_url":"https://github.com/astroplanners/astroplan/pull/14","diff_url":"https://github.com/astroplanners/astroplan/pull/14.diff","patch_url":"https://github.com/astroplanners/astroplan/pull/14.patch"},"body":"**Before beginning a code review/discussion, I recommend you [check out my notes](https://github.com/bmorris3/astroplan/wiki/Notes#on-risingsetting-methods)** on the organization of the methods that I've implemented in this PR.\r\n\r\nI took some liberties to get things up and running, and am prepared to make plenty of changes as discussion begins. \r\n\r\nHappy Pride weekend! :rainbow: "},"comment":{"url":"https://api.github.com/repos/astroplanners/astroplan/issues/comments/118918903","html_url":"https://github.com/astroplanners/astroplan/pull/14#issuecomment-118918903","issue_url":"https://api.github.com/repos/astroplanners/astroplan/issues/14","id":118918903,"user":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"created_at":"2015-07-06T16:34:54Z","updated_at":"2015-07-06T16:34:54Z","body":"@bmorris3 – There's https://github.com/astropy/coordinates-benchmark which would be the appropriate location to implement checks against other codes  / reference values for largish grids of parameters (e.g. locations, times, ...).\r\n\r\nAs I've said before, my strong preference would be that this kind of work (root finding code to find rise / set times, extensive checks for many locations / times) is postponed to the end of GSoC. Let's get a first version of the toolbox in master first (within a week or two possible?), so that others that want to work on e.g. plotting or scheduling aren't blocked and so that there's something we can start to use and get real-world feedback on. It really doesn't matter for now if the sun sets a few minutes early or our package doesn't work for the eskimos and penguins.\r\n\r\n@bmorris3, just to be clear – this is in now way a critique of your work ... I'm very impressed at what you're doing and how fast you're exploring / implementing things. It's just that in my experience trying to get it \"right\" on the first go and be comprehensive in testing is hard and building a working prototype quickly and iterating on it is easier and leads to quicker / better results.\r\n\r\nI guess to be re-discussed tomorrow evening in the hangout ..."}}