{"action":"created","comment":{"url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/pulls/comments/24000473","id":24000473,"diff_hunk":"@@ -55,7 +55,17 @@ relayhost = <%= @main_relayhost_real %>:<%= @main_relayhost_port_real %>\n \n # setgid_group = postdrop\n setgid_group = <%= @main_setgid_group_real %>\n-<% if @main_virtual_alias_maps_real and @virtual_aliases_real -%>\n+<% if @main_virtual_alias_domains_real -%>\n+\n+virtual_alias_domains = <%= @main_virtual_alias_domains_real %>\n+<% end -%>\n+","path":"templates/main.cf.erb","position":9,"original_position":9,"commit_id":"b1af7baaa9d609f5e916115a38150a9c824f13c0","original_commit_id":"b1af7baaa9d609f5e916115a38150a9c824f13c0","user":{"login":"Phil-Friderici","id":5038125,"avatar_url":"https://avatars.githubusercontent.com/u/5038125?v=3","gravatar_id":"","url":"https://api.github.com/users/Phil-Friderici","html_url":"https://github.com/Phil-Friderici","followers_url":"https://api.github.com/users/Phil-Friderici/followers","following_url":"https://api.github.com/users/Phil-Friderici/following{/other_user}","gists_url":"https://api.github.com/users/Phil-Friderici/gists{/gist_id}","starred_url":"https://api.github.com/users/Phil-Friderici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phil-Friderici/subscriptions","organizations_url":"https://api.github.com/users/Phil-Friderici/orgs","repos_url":"https://api.github.com/users/Phil-Friderici/repos","events_url":"https://api.github.com/users/Phil-Friderici/events{/privacy}","received_events_url":"https://api.github.com/users/Phil-Friderici/received_events","type":"User","site_admin":false},"body":"please remove this","created_at":"2015-02-03T12:37:18Z","updated_at":"2015-02-03T12:37:18Z","html_url":"https://github.com/Phil-Friderici/puppet-module-postfix/pull/10#discussion_r24000473","pull_request_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/pulls/comments/24000473"},"html":{"href":"https://github.com/Phil-Friderici/puppet-module-postfix/pull/10#discussion_r24000473"},"pull_request":{"href":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/pulls/10","id":27927698,"html_url":"https://github.com/Phil-Friderici/puppet-module-postfix/pull/10","diff_url":"https://github.com/Phil-Friderici/puppet-module-postfix/pull/10.diff","patch_url":"https://github.com/Phil-Friderici/puppet-module-postfix/pull/10.patch","issue_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/issues/10","number":10,"state":"open","locked":false,"title":"Added new configuration parameters","user":{"login":"gusson","id":4476818,"avatar_url":"https://avatars.githubusercontent.com/u/4476818?v=3","gravatar_id":"","url":"https://api.github.com/users/gusson","html_url":"https://github.com/gusson","followers_url":"https://api.github.com/users/gusson/followers","following_url":"https://api.github.com/users/gusson/following{/other_user}","gists_url":"https://api.github.com/users/gusson/gists{/gist_id}","starred_url":"https://api.github.com/users/gusson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gusson/subscriptions","organizations_url":"https://api.github.com/users/gusson/orgs","repos_url":"https://api.github.com/users/gusson/repos","events_url":"https://api.github.com/users/gusson/events{/privacy}","received_events_url":"https://api.github.com/users/gusson/received_events","type":"User","site_admin":false},"body":"Ability to configure transport maps with the parameters main_transport_maps, transport_maps and transport_maps_external.\r\n\r\nAdded the virtual_aliases_external and transport_maps_external to allow alternative sources (e.g. ldap_table(5)), without having to provide information to virtual_aliases or transport_aliases. Earlier the main_virtual_alias_maps parameter would only be written to main.cf if virtual_aliases was defined.\r\n\r\nAdded virtual_alias_domains parameter to control the corresponding variable in main.cf. ","created_at":"2015-01-23T14:39:39Z","updated_at":"2015-02-03T12:37:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfe3617ae471736574d4a17313e7244ed6fe36af","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/pulls/10/commits","review_comments_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/pulls/10/comments","review_comment_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/issues/10/comments","statuses_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/statuses/b1af7baaa9d609f5e916115a38150a9c824f13c0","head":{"label":"gusson:transport_maps","ref":"transport_maps","sha":"b1af7baaa9d609f5e916115a38150a9c824f13c0","user":{"login":"gusson","id":4476818,"avatar_url":"https://avatars.githubusercontent.com/u/4476818?v=3","gravatar_id":"","url":"https://api.github.com/users/gusson","html_url":"https://github.com/gusson","followers_url":"https://api.github.com/users/gusson/followers","following_url":"https://api.github.com/users/gusson/following{/other_user}","gists_url":"https://api.github.com/users/gusson/gists{/gist_id}","starred_url":"https://api.github.com/users/gusson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gusson/subscriptions","organizations_url":"https://api.github.com/users/gusson/orgs","repos_url":"https://api.github.com/users/gusson/repos","events_url":"https://api.github.com/users/gusson/events{/privacy}","received_events_url":"https://api.github.com/users/gusson/received_events","type":"User","site_admin":false},"repo":{"id":29735985,"name":"puppet-module-postfix","full_name":"gusson/puppet-module-postfix","owner":{"login":"gusson","id":4476818,"avatar_url":"https://avatars.githubusercontent.com/u/4476818?v=3","gravatar_id":"","url":"https://api.github.com/users/gusson","html_url":"https://github.com/gusson","followers_url":"https://api.github.com/users/gusson/followers","following_url":"https://api.github.com/users/gusson/following{/other_user}","gists_url":"https://api.github.com/users/gusson/gists{/gist_id}","starred_url":"https://api.github.com/users/gusson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gusson/subscriptions","organizations_url":"https://api.github.com/users/gusson/orgs","repos_url":"https://api.github.com/users/gusson/repos","events_url":"https://api.github.com/users/gusson/events{/privacy}","received_events_url":"https://api.github.com/users/gusson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gusson/puppet-module-postfix","description":"Puppet Module to manage Postfix for mail relaying","fork":true,"url":"https://api.github.com/repos/gusson/puppet-module-postfix","forks_url":"https://api.github.com/repos/gusson/puppet-module-postfix/forks","keys_url":"https://api.github.com/repos/gusson/puppet-module-postfix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gusson/puppet-module-postfix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gusson/puppet-module-postfix/teams","hooks_url":"https://api.github.com/repos/gusson/puppet-module-postfix/hooks","issue_events_url":"https://api.github.com/repos/gusson/puppet-module-postfix/issues/events{/number}","events_url":"https://api.github.com/repos/gusson/puppet-module-postfix/events","assignees_url":"https://api.github.com/repos/gusson/puppet-module-postfix/assignees{/user}","branches_url":"https://api.github.com/repos/gusson/puppet-module-postfix/branches{/branch}","tags_url":"https://api.github.com/repos/gusson/puppet-module-postfix/tags","blobs_url":"https://api.github.com/repos/gusson/puppet-module-postfix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gusson/puppet-module-postfix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gusson/puppet-module-postfix/git/refs{/sha}","trees_url":"https://api.github.com/repos/gusson/puppet-module-postfix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gusson/puppet-module-postfix/statuses/{sha}","languages_url":"https://api.github.com/repos/gusson/puppet-module-postfix/languages","stargazers_url":"https://api.github.com/repos/gusson/puppet-module-postfix/stargazers","contributors_url":"https://api.github.com/repos/gusson/puppet-module-postfix/contributors","subscribers_url":"https://api.github.com/repos/gusson/puppet-module-postfix/subscribers","subscription_url":"https://api.github.com/repos/gusson/puppet-module-postfix/subscription","commits_url":"https://api.github.com/repos/gusson/puppet-module-postfix/commits{/sha}","git_commits_url":"https://api.github.com/repos/gusson/puppet-module-postfix/git/commits{/sha}","comments_url":"https://api.github.com/repos/gusson/puppet-module-postfix/comments{/number}","issue_comment_url":"https://api.github.com/repos/gusson/puppet-module-postfix/issues/comments/{number}","contents_url":"https://api.github.com/repos/gusson/puppet-module-postfix/contents/{+path}","compare_url":"https://api.github.com/repos/gusson/puppet-module-postfix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gusson/puppet-module-postfix/merges","archive_url":"https://api.github.com/repos/gusson/puppet-module-postfix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gusson/puppet-module-postfix/downloads","issues_url":"https://api.github.com/repos/gusson/puppet-module-postfix/issues{/number}","pulls_url":"https://api.github.com/repos/gusson/puppet-module-postfix/pulls{/number}","milestones_url":"https://api.github.com/repos/gusson/puppet-module-postfix/milestones{/number}","notifications_url":"https://api.github.com/repos/gusson/puppet-module-postfix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gusson/puppet-module-postfix/labels{/name}","releases_url":"https://api.github.com/repos/gusson/puppet-module-postfix/releases{/id}","created_at":"2015-01-23T14:27:04Z","updated_at":"2015-01-23T14:27:05Z","pushed_at":"2015-01-28T12:21:37Z","git_url":"git://github.com/gusson/puppet-module-postfix.git","ssh_url":"git@github.com:gusson/puppet-module-postfix.git","clone_url":"https://github.com/gusson/puppet-module-postfix.git","svn_url":"https://github.com/gusson/puppet-module-postfix","homepage":null,"size":168,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Phil-Friderici:master","ref":"master","sha":"5eaf013679872a0f1e6c8d574bde19d28c379304","user":{"login":"Phil-Friderici","id":5038125,"avatar_url":"https://avatars.githubusercontent.com/u/5038125?v=3","gravatar_id":"","url":"https://api.github.com/users/Phil-Friderici","html_url":"https://github.com/Phil-Friderici","followers_url":"https://api.github.com/users/Phil-Friderici/followers","following_url":"https://api.github.com/users/Phil-Friderici/following{/other_user}","gists_url":"https://api.github.com/users/Phil-Friderici/gists{/gist_id}","starred_url":"https://api.github.com/users/Phil-Friderici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phil-Friderici/subscriptions","organizations_url":"https://api.github.com/users/Phil-Friderici/orgs","repos_url":"https://api.github.com/users/Phil-Friderici/repos","events_url":"https://api.github.com/users/Phil-Friderici/events{/privacy}","received_events_url":"https://api.github.com/users/Phil-Friderici/received_events","type":"User","site_admin":false},"repo":{"id":14166779,"name":"puppet-module-postfix","full_name":"Phil-Friderici/puppet-module-postfix","owner":{"login":"Phil-Friderici","id":5038125,"avatar_url":"https://avatars.githubusercontent.com/u/5038125?v=3","gravatar_id":"","url":"https://api.github.com/users/Phil-Friderici","html_url":"https://github.com/Phil-Friderici","followers_url":"https://api.github.com/users/Phil-Friderici/followers","following_url":"https://api.github.com/users/Phil-Friderici/following{/other_user}","gists_url":"https://api.github.com/users/Phil-Friderici/gists{/gist_id}","starred_url":"https://api.github.com/users/Phil-Friderici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phil-Friderici/subscriptions","organizations_url":"https://api.github.com/users/Phil-Friderici/orgs","repos_url":"https://api.github.com/users/Phil-Friderici/repos","events_url":"https://api.github.com/users/Phil-Friderici/events{/privacy}","received_events_url":"https://api.github.com/users/Phil-Friderici/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Phil-Friderici/puppet-module-postfix","description":"Puppet Module to manage Postfix for mail relaying","fork":false,"url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix","forks_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/forks","keys_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/teams","hooks_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/hooks","issue_events_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/issues/events{/number}","events_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/events","assignees_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/assignees{/user}","branches_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/branches{/branch}","tags_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/tags","blobs_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/git/refs{/sha}","trees_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/statuses/{sha}","languages_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/languages","stargazers_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/stargazers","contributors_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/contributors","subscribers_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/subscribers","subscription_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/subscription","commits_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/commits{/sha}","git_commits_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/git/commits{/sha}","comments_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/comments{/number}","issue_comment_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/issues/comments/{number}","contents_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/contents/{+path}","compare_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/merges","archive_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/downloads","issues_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/issues{/number}","pulls_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/pulls{/number}","milestones_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/milestones{/number}","notifications_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/labels{/name}","releases_url":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/releases{/id}","created_at":"2013-11-06T08:17:39Z","updated_at":"2014-09-30T15:58:37Z","pushed_at":"2014-11-25T08:06:28Z","git_url":"git://github.com/Phil-Friderici/puppet-module-postfix.git","ssh_url":"git@github.com:Phil-Friderici/puppet-module-postfix.git","clone_url":"https://github.com/Phil-Friderici/puppet-module-postfix.git","svn_url":"https://github.com/Phil-Friderici/puppet-module-postfix","homepage":null,"size":514,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/pulls/10"},"html":{"href":"https://github.com/Phil-Friderici/puppet-module-postfix/pull/10"},"issue":{"href":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/issues/10"},"comments":{"href":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/Phil-Friderici/puppet-module-postfix/statuses/b1af7baaa9d609f5e916115a38150a9c824f13c0"}}}}