{"action":"created","issue":{"url":"https://api.github.com/repos/jeremyevans/simple_mailer/issues/1","labels_url":"https://api.github.com/repos/jeremyevans/simple_mailer/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/jeremyevans/simple_mailer/issues/1/comments","events_url":"https://api.github.com/repos/jeremyevans/simple_mailer/issues/1/events","html_url":"https://github.com/jeremyevans/simple_mailer/pull/1","id":72173306,"number":1,"title":"Accept smtp_settings","user":{"login":"janko-m","id":795488,"avatar_url":"https://avatars.githubusercontent.com/u/795488?v=3","gravatar_id":"","url":"https://api.github.com/users/janko-m","html_url":"https://github.com/janko-m","followers_url":"https://api.github.com/users/janko-m/followers","following_url":"https://api.github.com/users/janko-m/following{/other_user}","gists_url":"https://api.github.com/users/janko-m/gists{/gist_id}","starred_url":"https://api.github.com/users/janko-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janko-m/subscriptions","organizations_url":"https://api.github.com/users/janko-m/orgs","repos_url":"https://api.github.com/users/janko-m/repos","events_url":"https://api.github.com/users/janko-m/events{/privacy}","received_events_url":"https://api.github.com/users/janko-m/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-30T14:08:57Z","updated_at":"2015-04-30T22:54:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jeremyevans/simple_mailer/pulls/1","html_url":"https://github.com/jeremyevans/simple_mailer/pull/1","diff_url":"https://github.com/jeremyevans/simple_mailer/pull/1.diff","patch_url":"https://github.com/jeremyevans/simple_mailer/pull/1.patch"},"body":"I really like how thin the SimpleMailer is, and it made me realize how easy it is to actually use Net::STMP. I want to use it instead of Mail gem, because Mail gem is heavy, and I only need plain text emails for my application.\r\n\r\nI was really missing SMTP settings configuration on SimpleMailer, I don't know how you actually send emails without it. So I added almost the same one as the Mail gem (without some needless method checking, I guess for Ruby 1.8.3).\r\n\r\nI didn't really know how to test this properly, I don't know if it's necessary. I don't really know how to write RSpec tests to be compatible with all versions of RSpec, so I was thinking I could leave it to you :). I can successfully send an email with this commit."},"comment":{"url":"https://api.github.com/repos/jeremyevans/simple_mailer/issues/comments/97993653","html_url":"https://github.com/jeremyevans/simple_mailer/pull/1#issuecomment-97993653","issue_url":"https://api.github.com/repos/jeremyevans/simple_mailer/issues/1","id":97993653,"user":{"login":"jeremyevans","id":3846,"avatar_url":"https://avatars.githubusercontent.com/u/3846?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremyevans","html_url":"https://github.com/jeremyevans","followers_url":"https://api.github.com/users/jeremyevans/followers","following_url":"https://api.github.com/users/jeremyevans/following{/other_user}","gists_url":"https://api.github.com/users/jeremyevans/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyevans/subscriptions","organizations_url":"https://api.github.com/users/jeremyevans/orgs","repos_url":"https://api.github.com/users/jeremyevans/repos","events_url":"https://api.github.com/users/jeremyevans/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyevans/received_events","type":"User","site_admin":false},"created_at":"2015-04-30T22:54:35Z","updated_at":"2015-04-30T22:54:35Z","body":"I've switched the test suite to minitest/spec, hopefully that make it easier to write the specs for this."}}