{"action":"closed","number":1160,"pull_request":{"url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1160","id":29755838,"html_url":"https://github.com/PointCloudLibrary/pcl/pull/1160","diff_url":"https://github.com/PointCloudLibrary/pcl/pull/1160.diff","patch_url":"https://github.com/PointCloudLibrary/pcl/pull/1160.patch","issue_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1160","number":1160,"state":"closed","locked":false,"title":"add an if condition check for Q_HULL apps for dominant_plane_segmenation.cpp","user":{"login":"lvzhaoyang","id":3089615,"avatar_url":"https://avatars.githubusercontent.com/u/3089615?v=3","gravatar_id":"","url":"https://api.github.com/users/lvzhaoyang","html_url":"https://github.com/lvzhaoyang","followers_url":"https://api.github.com/users/lvzhaoyang/followers","following_url":"https://api.github.com/users/lvzhaoyang/following{/other_user}","gists_url":"https://api.github.com/users/lvzhaoyang/gists{/gist_id}","starred_url":"https://api.github.com/users/lvzhaoyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvzhaoyang/subscriptions","organizations_url":"https://api.github.com/users/lvzhaoyang/orgs","repos_url":"https://api.github.com/users/lvzhaoyang/repos","events_url":"https://api.github.com/users/lvzhaoyang/events{/privacy}","received_events_url":"https://api.github.com/users/lvzhaoyang/received_events","type":"User","site_admin":false},"body":"Origin Issue: compiler error when Q_HULL is OFF.\r\n\r\nThis pull request solves the issue.\r\n\r\nWhen Q_HULL is missing, the dominant_plane_segmentation application should be turned off, since it relies on the Convex_hull class which is not built. \r\n\r\nOtherwise, it will generate an compiler issue. \r\n<p><code>[ 91%] Building CXX object apps/CMakeFiles/pcl_apps.dir/src/dominant_plane_segmentation.cpp.o\r\nIn file included from /home/zhaoyang/develop/pcl-forked/apps/src/dominant_plane_segmentation.cpp:38:0:\r\n/home/zhaoyang/develop/pcl-forked/apps/include/pcl/apps/dominant_plane_segmentation.h:251:9: error: ‘ConvexHull’ in namespace ‘pcl’ does not name a type\r\n         pcl::ConvexHull<PointType> hull_;\r\n         ^\r\nIn file included from /home/zhaoyang/develop/pcl-forked/apps/src/dominant_plane_segmentation.cpp:39:0:\r\n/home/zhaoyang/develop/pcl-forked/apps/include/pcl/apps/impl/dominant_plane_segmentation.hpp: In member function ‘void pcl::apps::DominantPlaneSegmentation<PointType>::compute_table_plane()’:\r\n/home/zhaoyang/develop/pcl-forked/apps/include/pcl/apps/impl/dominant_plane_segmentation.hpp:127:3: error: ‘hull_’ was not declared in this scope\r\n   hull_.setInputCloud (table_projected_);\r\n   ^\r\n/home/zhaoyang/develop/pcl-forked/apps/include/pcl/apps/impl/dominant_plane_segmentation.hpp: In member function ‘void pcl::apps::DominantPlaneSegmentation<PointType>::compute_fast(std::vector<typename pcl::PointCloud<PointT>::Ptr>&)’:\r\n/home/zhaoyang/develop/pcl-forked/apps/include/pcl/apps/impl/dominant_plane_segmentation.hpp:257:3: error: ‘hull_’ was not declared in this scope\r\n   hull_.setInputCloud (table_projected_);\r\n   ^\r\nIn file included from /home/zhaoyang/develop/pcl-forked/apps/src/dominant_plane_segmentation.cpp:39:0:\r\n/home/zhaoyang/develop/pcl-forked/apps/include/pcl/apps/impl/dominant_plane_segmentation.hpp: In member function ‘void pcl::apps::DominantPlaneSegmentation<PointType>::compute(std::vector<typename pcl::PointCloud<PointT>::Ptr>&)’:\r\n/home/zhaoyang/develop/pcl-forked/apps/include/pcl/apps/impl/dominant_plane_segmentation.hpp:633:3: error: ‘hull_’ was not declared in this scope\r\n   hull_.setInputCloud (table_projected_);\r\n   ^\r\n/home/zhaoyang/develop/pcl-forked/apps/include/pcl/apps/impl/dominant_plane_segmentation.hpp: In member function ‘void pcl::apps::DominantPlaneSegmentation<PointType>::compute_full(std::vector<typename pcl::PointCloud<PointT>::Ptr>&)’:\r\n/home/zhaoyang/develop/pcl-forked/apps/include/pcl/apps/impl/dominant_plane_segmentation.hpp:796:3: error: ‘hull_’ was not declared in this scope\r\n   hull_.setInputCloud (table_projected_);\r\n</code></p>\r\n","created_at":"2015-02-21T16:34:52Z","updated_at":"2015-02-25T10:36:02Z","closed_at":"2015-02-25T10:36:02Z","merged_at":"2015-02-25T10:36:02Z","merge_commit_sha":"553b719931757db6b987b92bbb77782198fc4880","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1160/commits","review_comments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1160/comments","review_comment_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1160/comments","statuses_url":"https://api.github.com/repos/PointCloudLibrary/pcl/statuses/b2110d296565e22e4de1be93e4c5019f87ae6d39","head":{"label":"lvzhaoyang:hotfix/cmake_no_ConvexHull_apps","ref":"hotfix/cmake_no_ConvexHull_apps","sha":"b2110d296565e22e4de1be93e4c5019f87ae6d39","user":{"login":"lvzhaoyang","id":3089615,"avatar_url":"https://avatars.githubusercontent.com/u/3089615?v=3","gravatar_id":"","url":"https://api.github.com/users/lvzhaoyang","html_url":"https://github.com/lvzhaoyang","followers_url":"https://api.github.com/users/lvzhaoyang/followers","following_url":"https://api.github.com/users/lvzhaoyang/following{/other_user}","gists_url":"https://api.github.com/users/lvzhaoyang/gists{/gist_id}","starred_url":"https://api.github.com/users/lvzhaoyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvzhaoyang/subscriptions","organizations_url":"https://api.github.com/users/lvzhaoyang/orgs","repos_url":"https://api.github.com/users/lvzhaoyang/repos","events_url":"https://api.github.com/users/lvzhaoyang/events{/privacy}","received_events_url":"https://api.github.com/users/lvzhaoyang/received_events","type":"User","site_admin":false},"repo":{"id":10223890,"name":"pcl","full_name":"lvzhaoyang/pcl","owner":{"login":"lvzhaoyang","id":3089615,"avatar_url":"https://avatars.githubusercontent.com/u/3089615?v=3","gravatar_id":"","url":"https://api.github.com/users/lvzhaoyang","html_url":"https://github.com/lvzhaoyang","followers_url":"https://api.github.com/users/lvzhaoyang/followers","following_url":"https://api.github.com/users/lvzhaoyang/following{/other_user}","gists_url":"https://api.github.com/users/lvzhaoyang/gists{/gist_id}","starred_url":"https://api.github.com/users/lvzhaoyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvzhaoyang/subscriptions","organizations_url":"https://api.github.com/users/lvzhaoyang/orgs","repos_url":"https://api.github.com/users/lvzhaoyang/repos","events_url":"https://api.github.com/users/lvzhaoyang/events{/privacy}","received_events_url":"https://api.github.com/users/lvzhaoyang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lvzhaoyang/pcl","description":"Point Cloud Library (PCL)","fork":true,"url":"https://api.github.com/repos/lvzhaoyang/pcl","forks_url":"https://api.github.com/repos/lvzhaoyang/pcl/forks","keys_url":"https://api.github.com/repos/lvzhaoyang/pcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lvzhaoyang/pcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lvzhaoyang/pcl/teams","hooks_url":"https://api.github.com/repos/lvzhaoyang/pcl/hooks","issue_events_url":"https://api.github.com/repos/lvzhaoyang/pcl/issues/events{/number}","events_url":"https://api.github.com/repos/lvzhaoyang/pcl/events","assignees_url":"https://api.github.com/repos/lvzhaoyang/pcl/assignees{/user}","branches_url":"https://api.github.com/repos/lvzhaoyang/pcl/branches{/branch}","tags_url":"https://api.github.com/repos/lvzhaoyang/pcl/tags","blobs_url":"https://api.github.com/repos/lvzhaoyang/pcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lvzhaoyang/pcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lvzhaoyang/pcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/lvzhaoyang/pcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lvzhaoyang/pcl/statuses/{sha}","languages_url":"https://api.github.com/repos/lvzhaoyang/pcl/languages","stargazers_url":"https://api.github.com/repos/lvzhaoyang/pcl/stargazers","contributors_url":"https://api.github.com/repos/lvzhaoyang/pcl/contributors","subscribers_url":"https://api.github.com/repos/lvzhaoyang/pcl/subscribers","subscription_url":"https://api.github.com/repos/lvzhaoyang/pcl/subscription","commits_url":"https://api.github.com/repos/lvzhaoyang/pcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/lvzhaoyang/pcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/lvzhaoyang/pcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/lvzhaoyang/pcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/lvzhaoyang/pcl/contents/{+path}","compare_url":"https://api.github.com/repos/lvzhaoyang/pcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lvzhaoyang/pcl/merges","archive_url":"https://api.github.com/repos/lvzhaoyang/pcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lvzhaoyang/pcl/downloads","issues_url":"https://api.github.com/repos/lvzhaoyang/pcl/issues{/number}","pulls_url":"https://api.github.com/repos/lvzhaoyang/pcl/pulls{/number}","milestones_url":"https://api.github.com/repos/lvzhaoyang/pcl/milestones{/number}","notifications_url":"https://api.github.com/repos/lvzhaoyang/pcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lvzhaoyang/pcl/labels{/name}","releases_url":"https://api.github.com/repos/lvzhaoyang/pcl/releases{/id}","created_at":"2013-05-22T16:00:14Z","updated_at":"2015-02-23T03:49:44Z","pushed_at":"2015-02-23T04:39:18Z","git_url":"git://github.com/lvzhaoyang/pcl.git","ssh_url":"git@github.com:lvzhaoyang/pcl.git","clone_url":"https://github.com/lvzhaoyang/pcl.git","svn_url":"https://github.com/lvzhaoyang/pcl","homepage":"http://www.pointclouds.org","size":189768,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PointCloudLibrary:master","ref":"master","sha":"0c2196c398b48a14ddc3198b1bc97513d23a53cb","user":{"login":"PointCloudLibrary","id":2059451,"avatar_url":"https://avatars.githubusercontent.com/u/2059451?v=3","gravatar_id":"","url":"https://api.github.com/users/PointCloudLibrary","html_url":"https://github.com/PointCloudLibrary","followers_url":"https://api.github.com/users/PointCloudLibrary/followers","following_url":"https://api.github.com/users/PointCloudLibrary/following{/other_user}","gists_url":"https://api.github.com/users/PointCloudLibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/PointCloudLibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PointCloudLibrary/subscriptions","organizations_url":"https://api.github.com/users/PointCloudLibrary/orgs","repos_url":"https://api.github.com/users/PointCloudLibrary/repos","events_url":"https://api.github.com/users/PointCloudLibrary/events{/privacy}","received_events_url":"https://api.github.com/users/PointCloudLibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":8162615,"name":"pcl","full_name":"PointCloudLibrary/pcl","owner":{"login":"PointCloudLibrary","id":2059451,"avatar_url":"https://avatars.githubusercontent.com/u/2059451?v=3","gravatar_id":"","url":"https://api.github.com/users/PointCloudLibrary","html_url":"https://github.com/PointCloudLibrary","followers_url":"https://api.github.com/users/PointCloudLibrary/followers","following_url":"https://api.github.com/users/PointCloudLibrary/following{/other_user}","gists_url":"https://api.github.com/users/PointCloudLibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/PointCloudLibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PointCloudLibrary/subscriptions","organizations_url":"https://api.github.com/users/PointCloudLibrary/orgs","repos_url":"https://api.github.com/users/PointCloudLibrary/repos","events_url":"https://api.github.com/users/PointCloudLibrary/events{/privacy}","received_events_url":"https://api.github.com/users/PointCloudLibrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PointCloudLibrary/pcl","description":"Point Cloud Library (PCL)","fork":false,"url":"https://api.github.com/repos/PointCloudLibrary/pcl","forks_url":"https://api.github.com/repos/PointCloudLibrary/pcl/forks","keys_url":"https://api.github.com/repos/PointCloudLibrary/pcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PointCloudLibrary/pcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PointCloudLibrary/pcl/teams","hooks_url":"https://api.github.com/repos/PointCloudLibrary/pcl/hooks","issue_events_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/events{/number}","events_url":"https://api.github.com/repos/PointCloudLibrary/pcl/events","assignees_url":"https://api.github.com/repos/PointCloudLibrary/pcl/assignees{/user}","branches_url":"https://api.github.com/repos/PointCloudLibrary/pcl/branches{/branch}","tags_url":"https://api.github.com/repos/PointCloudLibrary/pcl/tags","blobs_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PointCloudLibrary/pcl/statuses/{sha}","languages_url":"https://api.github.com/repos/PointCloudLibrary/pcl/languages","stargazers_url":"https://api.github.com/repos/PointCloudLibrary/pcl/stargazers","contributors_url":"https://api.github.com/repos/PointCloudLibrary/pcl/contributors","subscribers_url":"https://api.github.com/repos/PointCloudLibrary/pcl/subscribers","subscription_url":"https://api.github.com/repos/PointCloudLibrary/pcl/subscription","commits_url":"https://api.github.com/repos/PointCloudLibrary/pcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/PointCloudLibrary/pcl/contents/{+path}","compare_url":"https://api.github.com/repos/PointCloudLibrary/pcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PointCloudLibrary/pcl/merges","archive_url":"https://api.github.com/repos/PointCloudLibrary/pcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PointCloudLibrary/pcl/downloads","issues_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues{/number}","pulls_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls{/number}","milestones_url":"https://api.github.com/repos/PointCloudLibrary/pcl/milestones{/number}","notifications_url":"https://api.github.com/repos/PointCloudLibrary/pcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PointCloudLibrary/pcl/labels{/name}","releases_url":"https://api.github.com/repos/PointCloudLibrary/pcl/releases{/id}","created_at":"2013-02-12T16:40:25Z","updated_at":"2015-02-25T10:36:02Z","pushed_at":"2015-02-25T10:36:02Z","git_url":"git://github.com/PointCloudLibrary/pcl.git","ssh_url":"git@github.com:PointCloudLibrary/pcl.git","clone_url":"https://github.com/PointCloudLibrary/pcl.git","svn_url":"https://github.com/PointCloudLibrary/pcl","homepage":"http://www.pointclouds.org","size":262351,"stargazers_count":606,"watchers_count":606,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":745,"mirror_url":null,"open_issues_count":143,"forks":745,"open_issues":143,"watchers":606,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1160"},"html":{"href":"https://github.com/PointCloudLibrary/pcl/pull/1160"},"issue":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1160"},"comments":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1160/comments"},"review_comments":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1160/comments"},"review_comment":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1160/commits"},"statuses":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/statuses/b2110d296565e22e4de1be93e4c5019f87ae6d39"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"taketwo","id":1241736,"avatar_url":"https://avatars.githubusercontent.com/u/1241736?v=3","gravatar_id":"","url":"https://api.github.com/users/taketwo","html_url":"https://github.com/taketwo","followers_url":"https://api.github.com/users/taketwo/followers","following_url":"https://api.github.com/users/taketwo/following{/other_user}","gists_url":"https://api.github.com/users/taketwo/gists{/gist_id}","starred_url":"https://api.github.com/users/taketwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taketwo/subscriptions","organizations_url":"https://api.github.com/users/taketwo/orgs","repos_url":"https://api.github.com/users/taketwo/repos","events_url":"https://api.github.com/users/taketwo/events{/privacy}","received_events_url":"https://api.github.com/users/taketwo/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":9,"deletions":7,"changed_files":1}}