{"action":"created","issue":{"url":"https://api.github.com/repos/NebulousLabs/Sia/issues/316","labels_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/316/labels{/name}","comments_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/316/comments","events_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/316/events","html_url":"https://github.com/NebulousLabs/Sia/issues/316","id":56743697,"number":316,"title":"Currency Changes","user":{"login":"DavidVorick","id":2316841,"avatar_url":"https://avatars.githubusercontent.com/u/2316841?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidVorick","html_url":"https://github.com/DavidVorick","followers_url":"https://api.github.com/users/DavidVorick/followers","following_url":"https://api.github.com/users/DavidVorick/following{/other_user}","gists_url":"https://api.github.com/users/DavidVorick/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidVorick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidVorick/subscriptions","organizations_url":"https://api.github.com/users/DavidVorick/orgs","repos_url":"https://api.github.com/users/DavidVorick/repos","events_url":"https://api.github.com/users/DavidVorick/events{/privacy}","received_events_url":"https://api.github.com/users/DavidVorick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-05T23:00:09Z","updated_at":"2015-02-08T20:15:02Z","closed_at":null,"body":"First, we need testing.\r\n\r\nBut second, the currency methods can't be pointer receivers :(\r\n\r\nMany of the objects that contain a currency are supposed to be immutable.\r\n\r\nFinally, c.of should be c.overflow, because I feel that your variable names should be fully spelled out inside of the data structures."},"comment":{"url":"https://api.github.com/repos/NebulousLabs/Sia/issues/comments/73429169","html_url":"https://github.com/NebulousLabs/Sia/issues/316#issuecomment-73429169","issue_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/316","id":73429169,"user":{"login":"DavidVorick","id":2316841,"avatar_url":"https://avatars.githubusercontent.com/u/2316841?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidVorick","html_url":"https://github.com/DavidVorick","followers_url":"https://api.github.com/users/DavidVorick/followers","following_url":"https://api.github.com/users/DavidVorick/following{/other_user}","gists_url":"https://api.github.com/users/DavidVorick/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidVorick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidVorick/subscriptions","organizations_url":"https://api.github.com/users/DavidVorick/orgs","repos_url":"https://api.github.com/users/DavidVorick/repos","events_url":"https://api.github.com/users/DavidVorick/events{/privacy}","received_events_url":"https://api.github.com/users/DavidVorick/received_events","type":"User","site_admin":false},"created_at":"2015-02-08T20:15:02Z","updated_at":"2015-02-08T20:15:02Z","body":"There's a corner case around the siafund pool. Because the siafund pool is additive and never decreases, it should be okay for the siafund pool to overflow. Which puts us in a bit of a weird place, because SiafundOutputs have the siafund pool object.\r\n\r\nSo I'm thinking that the siafund pool type needs to be a big, and we'll have a (*wince*) big.Int in one of our types...\r\n\r\n>.<\r\n\r\nMaybe we should have just made them all big.Int in the first place."}}