{"action":"created","issue":{"url":"https://api.github.com/repos/codeminus/frameworks/issues/5","labels_url":"https://api.github.com/repos/codeminus/frameworks/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/codeminus/frameworks/issues/5/comments","events_url":"https://api.github.com/repos/codeminus/frameworks/issues/5/events","html_url":"https://github.com/codeminus/frameworks/issues/5","id":59323193,"number":5,"title":"Remove traits","user":{"login":"malukenho","id":3275172,"avatar_url":"https://avatars.githubusercontent.com/u/3275172?v=3","gravatar_id":"","url":"https://api.github.com/users/malukenho","html_url":"https://github.com/malukenho","followers_url":"https://api.github.com/users/malukenho/followers","following_url":"https://api.github.com/users/malukenho/following{/other_user}","gists_url":"https://api.github.com/users/malukenho/gists{/gist_id}","starred_url":"https://api.github.com/users/malukenho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malukenho/subscriptions","organizations_url":"https://api.github.com/users/malukenho/orgs","repos_url":"https://api.github.com/users/malukenho/repos","events_url":"https://api.github.com/users/malukenho/events{/privacy}","received_events_url":"https://api.github.com/users/malukenho/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-02-28T03:35:31Z","updated_at":"2015-02-28T04:54:09Z","closed_at":"2015-02-28T04:45:41Z","body":"Hey guys, please, do not use traits.\r\nYou don't need a horizontal inheritance here.\r\n\r\nAlso, a `trait` as a singleton is terrible :-1: "},"comment":{"url":"https://api.github.com/repos/codeminus/frameworks/issues/comments/76510662","html_url":"https://github.com/codeminus/frameworks/issues/5#issuecomment-76510662","issue_url":"https://api.github.com/repos/codeminus/frameworks/issues/5","id":76510662,"user":{"login":"malukenho","id":3275172,"avatar_url":"https://avatars.githubusercontent.com/u/3275172?v=3","gravatar_id":"","url":"https://api.github.com/users/malukenho","html_url":"https://github.com/malukenho","followers_url":"https://api.github.com/users/malukenho/followers","following_url":"https://api.github.com/users/malukenho/following{/other_user}","gists_url":"https://api.github.com/users/malukenho/gists{/gist_id}","starred_url":"https://api.github.com/users/malukenho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malukenho/subscriptions","organizations_url":"https://api.github.com/users/malukenho/orgs","repos_url":"https://api.github.com/users/malukenho/repos","events_url":"https://api.github.com/users/malukenho/events{/privacy}","received_events_url":"https://api.github.com/users/malukenho/received_events","type":"User","site_admin":false},"created_at":"2015-02-28T04:54:09Z","updated_at":"2015-02-28T04:54:09Z","body":"So, the first one thing is refactor that architecture. You have some `require` inside classes, and `define` functions inside methods. Also, you autoload is inefficient and classe names is not declarative. The folder structure is weird, you have view and assets things on the same level of another things. Your have configuration inside of `*.ini` files.\r\n\r\nI will help you to refactor this things and starting to create tests too.\r\nDo you know **phpunit**?\r\n\r\nAlso, you need to push sql schema and `config files` as `main.ini` to the repository."}}