{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17024","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17024/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17024/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17024/events","html_url":"https://github.com/kubernetes/kubernetes/pull/17024","id":115943488,"number":17024,"title":"Rename minion->node for Vagrant provider for #1111","user":{"login":"eosrei","id":195061,"avatar_url":"https://avatars.githubusercontent.com/u/195061?v=3","gravatar_id":"","url":"https://api.github.com/users/eosrei","html_url":"https://github.com/eosrei","followers_url":"https://api.github.com/users/eosrei/followers","following_url":"https://api.github.com/users/eosrei/following{/other_user}","gists_url":"https://api.github.com/users/eosrei/gists{/gist_id}","starred_url":"https://api.github.com/users/eosrei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eosrei/subscriptions","organizations_url":"https://api.github.com/users/eosrei/orgs","repos_url":"https://api.github.com/users/eosrei/repos","events_url":"https://api.github.com/users/eosrei/events{/privacy}","received_events_url":"https://api.github.com/users/eosrei/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900"}],"state":"open","locked":false,"assignee":{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars.githubusercontent.com/u/6233452?v=3","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},"milestone":null,"comments":19,"created_at":"2015-11-09T19:09:32Z","updated_at":"2015-12-02T21:37:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17024","html_url":"https://github.com/kubernetes/kubernetes/pull/17024","diff_url":"https://github.com/kubernetes/kubernetes/pull/17024.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/17024.patch"},"body":"The inconsistent minion/node terminology was confusing. #1111 *Replace use of term \"Minion\"* explained the issue. I decided to bite off a chunk.\r\n\r\n~~This PR covers about 1/3 of the uses of \"minion\" in the codebase, but should be straightforward to review.~~ Primary goal was to get the Vagrant provider & related docs changed to \"node\"; ~~the environment and helper functions were logical additions/requirements.~~ The other cluster providers should probably be handled separately, plus I'm not setup to test all of them. Salt Minion comments/code are untouched, since differentiation is a reason for this change.\r\n\r\nVagrant naming the node correctly:\r\n```\r\n==> node-1: Importing base box 'kube-fedora21'...\r\n==> node-1: Matching MAC address for NAT networking...\r\n==> node-1: Setting the name of the VM: kubernetes_node-1_1447061618936_7276\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/161441566","html_url":"https://github.com/kubernetes/kubernetes/pull/17024#issuecomment-161441566","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17024","id":161441566,"user":{"login":"eosrei","id":195061,"avatar_url":"https://avatars.githubusercontent.com/u/195061?v=3","gravatar_id":"","url":"https://api.github.com/users/eosrei","html_url":"https://github.com/eosrei","followers_url":"https://api.github.com/users/eosrei/followers","following_url":"https://api.github.com/users/eosrei/following{/other_user}","gists_url":"https://api.github.com/users/eosrei/gists{/gist_id}","starred_url":"https://api.github.com/users/eosrei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eosrei/subscriptions","organizations_url":"https://api.github.com/users/eosrei/orgs","repos_url":"https://api.github.com/users/eosrei/repos","events_url":"https://api.github.com/users/eosrei/events{/privacy}","received_events_url":"https://api.github.com/users/eosrei/received_events","type":"User","site_admin":false},"created_at":"2015-12-02T21:37:23Z","updated_at":"2015-12-02T21:37:23Z","body":"@derekwaynecarr Everything looks right now, please review.\r\n"}}