{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/sv-rollout/pulls/comments/39547631","id":39547631,"diff_hunk":"@@ -52,6 +53,24 @@ func (c config) AssertValid(pattern string) {\n \t}\n }\n \n+var (\n+\t// Statsd is a globally-shared datadog client.\n+\tStatsd *dogstatsd.Client\n+)\n+\n+func configureStatsd() {\n+\tvar err error\n+\tif Statsd != nil {\n+\t\treturn\n+\t}\n+\tStatsd, err = dogstatsd.New(\"127.0.0.1:8125\", &dogstatsd.Context{\n+\t\tNamespace: \"sv-rollout.\",\n+\t})\n+\tif err != nil {\n+\t\tlog.Fatal(err)","path":"main.go","position":26,"original_position":26,"commit_id":"db0f925e9cce7a319832fad504eb074312e3ae42","original_commit_id":"db0f925e9cce7a319832fad504eb074312e3ae42","user":{"login":"burke","id":1284,"avatar_url":"https://avatars.githubusercontent.com/u/1284?v=3","gravatar_id":"","url":"https://api.github.com/users/burke","html_url":"https://github.com/burke","followers_url":"https://api.github.com/users/burke/followers","following_url":"https://api.github.com/users/burke/following{/other_user}","gists_url":"https://api.github.com/users/burke/gists{/gist_id}","starred_url":"https://api.github.com/users/burke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burke/subscriptions","organizations_url":"https://api.github.com/users/burke/orgs","repos_url":"https://api.github.com/users/burke/repos","events_url":"https://api.github.com/users/burke/events{/privacy}","received_events_url":"https://api.github.com/users/burke/received_events","type":"User","site_admin":false},"body":"I think it's okay that it aborts. It takes a pretty serious error to not be able to \"connect\" to a UDP socket ;)","created_at":"2015-09-15T18:32:55Z","updated_at":"2015-09-15T18:32:55Z","html_url":"https://github.com/Shopify/sv-rollout/pull/7#discussion_r39547631","pull_request_url":"https://api.github.com/repos/Shopify/sv-rollout/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/Shopify/sv-rollout/pulls/comments/39547631"},"html":{"href":"https://github.com/Shopify/sv-rollout/pull/7#discussion_r39547631"},"pull_request":{"href":"https://api.github.com/repos/Shopify/sv-rollout/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/sv-rollout/pulls/7","id":45080414,"html_url":"https://github.com/Shopify/sv-rollout/pull/7","diff_url":"https://github.com/Shopify/sv-rollout/pull/7.diff","patch_url":"https://github.com/Shopify/sv-rollout/pull/7.patch","issue_url":"https://api.github.com/repos/Shopify/sv-rollout/issues/7","number":7,"state":"open","locked":false,"title":"Instrument individual service restart duration","user":{"login":"byroot","id":44640,"avatar_url":"https://avatars.githubusercontent.com/u/44640?v=3","gravatar_id":"","url":"https://api.github.com/users/byroot","html_url":"https://github.com/byroot","followers_url":"https://api.github.com/users/byroot/followers","following_url":"https://api.github.com/users/byroot/following{/other_user}","gists_url":"https://api.github.com/users/byroot/gists{/gist_id}","starred_url":"https://api.github.com/users/byroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byroot/subscriptions","organizations_url":"https://api.github.com/users/byroot/orgs","repos_url":"https://api.github.com/users/byroot/repos","events_url":"https://api.github.com/users/byroot/events{/privacy}","received_events_url":"https://api.github.com/users/byroot/received_events","type":"User","site_admin":false},"body":"Context: We'd like to optimize the deploy time, in order to do that we'd like to see if some specific services are the bottleneck, and more generally having a better picture of what can be optimized or not.\r\n\r\nThis instrument individual serivce restart. Ideally I'll add Deployment instrumentation in a followup.\r\n\r\n@burke @csfrancis @graemej for review please.\r\n\r\nPS: Sorry if this is full of beginner mistakes.\r\n\r\n","created_at":"2015-09-15T17:50:07Z","updated_at":"2015-09-15T18:32:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf025cd7562f30446001f9c63db881a97f51d504","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/sv-rollout/pulls/7/commits","review_comments_url":"https://api.github.com/repos/Shopify/sv-rollout/pulls/7/comments","review_comment_url":"https://api.github.com/repos/Shopify/sv-rollout/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/sv-rollout/issues/7/comments","statuses_url":"https://api.github.com/repos/Shopify/sv-rollout/statuses/db0f925e9cce7a319832fad504eb074312e3ae42","head":{"label":"Shopify:restart-instrumentation","ref":"restart-instrumentation","sha":"db0f925e9cce7a319832fad504eb074312e3ae42","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":25880913,"name":"sv-rollout","full_name":"Shopify/sv-rollout","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/sv-rollout","description":null,"fork":false,"url":"https://api.github.com/repos/Shopify/sv-rollout","forks_url":"https://api.github.com/repos/Shopify/sv-rollout/forks","keys_url":"https://api.github.com/repos/Shopify/sv-rollout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/sv-rollout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/sv-rollout/teams","hooks_url":"https://api.github.com/repos/Shopify/sv-rollout/hooks","issue_events_url":"https://api.github.com/repos/Shopify/sv-rollout/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/sv-rollout/events","assignees_url":"https://api.github.com/repos/Shopify/sv-rollout/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/sv-rollout/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/sv-rollout/tags","blobs_url":"https://api.github.com/repos/Shopify/sv-rollout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/sv-rollout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/sv-rollout/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/sv-rollout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/sv-rollout/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/sv-rollout/languages","stargazers_url":"https://api.github.com/repos/Shopify/sv-rollout/stargazers","contributors_url":"https://api.github.com/repos/Shopify/sv-rollout/contributors","subscribers_url":"https://api.github.com/repos/Shopify/sv-rollout/subscribers","subscription_url":"https://api.github.com/repos/Shopify/sv-rollout/subscription","commits_url":"https://api.github.com/repos/Shopify/sv-rollout/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/sv-rollout/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/sv-rollout/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/sv-rollout/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/sv-rollout/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/sv-rollout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/sv-rollout/merges","archive_url":"https://api.github.com/repos/Shopify/sv-rollout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/sv-rollout/downloads","issues_url":"https://api.github.com/repos/Shopify/sv-rollout/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/sv-rollout/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/sv-rollout/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/sv-rollout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/sv-rollout/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/sv-rollout/releases{/id}","created_at":"2014-10-28T17:18:20Z","updated_at":"2015-07-15T08:30:05Z","pushed_at":"2015-09-15T18:20:07Z","git_url":"git://github.com/Shopify/sv-rollout.git","ssh_url":"git@github.com:Shopify/sv-rollout.git","clone_url":"https://github.com/Shopify/sv-rollout.git","svn_url":"https://github.com/Shopify/sv-rollout","homepage":null,"size":2597,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":6,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"7d7ef962ab615c809ea3d44204b0a1a8e075a176","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":25880913,"name":"sv-rollout","full_name":"Shopify/sv-rollout","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/sv-rollout","description":null,"fork":false,"url":"https://api.github.com/repos/Shopify/sv-rollout","forks_url":"https://api.github.com/repos/Shopify/sv-rollout/forks","keys_url":"https://api.github.com/repos/Shopify/sv-rollout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/sv-rollout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/sv-rollout/teams","hooks_url":"https://api.github.com/repos/Shopify/sv-rollout/hooks","issue_events_url":"https://api.github.com/repos/Shopify/sv-rollout/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/sv-rollout/events","assignees_url":"https://api.github.com/repos/Shopify/sv-rollout/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/sv-rollout/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/sv-rollout/tags","blobs_url":"https://api.github.com/repos/Shopify/sv-rollout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/sv-rollout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/sv-rollout/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/sv-rollout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/sv-rollout/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/sv-rollout/languages","stargazers_url":"https://api.github.com/repos/Shopify/sv-rollout/stargazers","contributors_url":"https://api.github.com/repos/Shopify/sv-rollout/contributors","subscribers_url":"https://api.github.com/repos/Shopify/sv-rollout/subscribers","subscription_url":"https://api.github.com/repos/Shopify/sv-rollout/subscription","commits_url":"https://api.github.com/repos/Shopify/sv-rollout/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/sv-rollout/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/sv-rollout/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/sv-rollout/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/sv-rollout/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/sv-rollout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/sv-rollout/merges","archive_url":"https://api.github.com/repos/Shopify/sv-rollout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/sv-rollout/downloads","issues_url":"https://api.github.com/repos/Shopify/sv-rollout/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/sv-rollout/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/sv-rollout/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/sv-rollout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/sv-rollout/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/sv-rollout/releases{/id}","created_at":"2014-10-28T17:18:20Z","updated_at":"2015-07-15T08:30:05Z","pushed_at":"2015-09-15T18:20:07Z","git_url":"git://github.com/Shopify/sv-rollout.git","ssh_url":"git@github.com:Shopify/sv-rollout.git","clone_url":"https://github.com/Shopify/sv-rollout.git","svn_url":"https://github.com/Shopify/sv-rollout","homepage":null,"size":2597,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/sv-rollout/pulls/7"},"html":{"href":"https://github.com/Shopify/sv-rollout/pull/7"},"issue":{"href":"https://api.github.com/repos/Shopify/sv-rollout/issues/7"},"comments":{"href":"https://api.github.com/repos/Shopify/sv-rollout/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/sv-rollout/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/sv-rollout/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/sv-rollout/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/sv-rollout/statuses/db0f925e9cce7a319832fad504eb074312e3ae42"}}}}