{"action":"opened","number":27,"pull_request":{"url":"https://api.github.com/repos/passcod/rsnotify/pulls/27","id":43754104,"html_url":"https://github.com/passcod/rsnotify/pull/27","diff_url":"https://github.com/passcod/rsnotify/pull/27.diff","patch_url":"https://github.com/passcod/rsnotify/pull/27.patch","issue_url":"https://api.github.com/repos/passcod/rsnotify/issues/27","number":27,"state":"open","locked":false,"title":"Tests on OSX.","user":{"login":"octplane","id":22177,"avatar_url":"https://avatars.githubusercontent.com/u/22177?v=3","gravatar_id":"","url":"https://api.github.com/users/octplane","html_url":"https://github.com/octplane","followers_url":"https://api.github.com/users/octplane/followers","following_url":"https://api.github.com/users/octplane/following{/other_user}","gists_url":"https://api.github.com/users/octplane/gists{/gist_id}","starred_url":"https://api.github.com/users/octplane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octplane/subscriptions","organizations_url":"https://api.github.com/users/octplane/orgs","repos_url":"https://api.github.com/users/octplane/repos","events_url":"https://api.github.com/users/octplane/events{/privacy}","received_events_url":"https://api.github.com/users/octplane/received_events","type":"User","site_admin":false},"body":"Tests now pass on OSX (necessary to reproduce #23 ).\r\n\r\n- add OS conditionals for full path resolving (FSEvent API does send full resolved path to its callback), code courtesy of @jakerr.\r\n- added some timeout during complex tests: FSEvent API sends *past events to its listener*, no matter what. The only solution is to wait.\r\n- use @jakerr `validate_recv` method to match results in test cases and timeout (solves #26 ).\r\n- enhance `validate_recv` to support aggregated events: `op::CREATE|op::REMOVE` will match `[op::CREATE, op::REMOVE]` (useful when your observing api can split or merge nearby events). Fixes a huge issue for OSX testing, has probably no impact on Linux.\r\n- `pollwatch` test is now broken on OSX because of this full path stuff (worth another bug ? sibling of #21 ?)\r\n- **untested** on linux. If the timeouts are too annoying, I still can refactor these to make runs faster on linux.","created_at":"2015-08-31T11:15:05Z","updated_at":"2015-08-31T11:15:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/passcod/rsnotify/pulls/27/commits","review_comments_url":"https://api.github.com/repos/passcod/rsnotify/pulls/27/comments","review_comment_url":"https://api.github.com/repos/passcod/rsnotify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/passcod/rsnotify/issues/27/comments","statuses_url":"https://api.github.com/repos/passcod/rsnotify/statuses/20cfe08dce237fc7382de2fe5e60bf9b4c7cf551","head":{"label":"octplane:fix_23_symlinks","ref":"fix_23_symlinks","sha":"20cfe08dce237fc7382de2fe5e60bf9b4c7cf551","user":{"login":"octplane","id":22177,"avatar_url":"https://avatars.githubusercontent.com/u/22177?v=3","gravatar_id":"","url":"https://api.github.com/users/octplane","html_url":"https://github.com/octplane","followers_url":"https://api.github.com/users/octplane/followers","following_url":"https://api.github.com/users/octplane/following{/other_user}","gists_url":"https://api.github.com/users/octplane/gists{/gist_id}","starred_url":"https://api.github.com/users/octplane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octplane/subscriptions","organizations_url":"https://api.github.com/users/octplane/orgs","repos_url":"https://api.github.com/users/octplane/repos","events_url":"https://api.github.com/users/octplane/events{/privacy}","received_events_url":"https://api.github.com/users/octplane/received_events","type":"User","site_admin":false},"repo":{"id":36998821,"name":"rsnotify","full_name":"octplane/rsnotify","owner":{"login":"octplane","id":22177,"avatar_url":"https://avatars.githubusercontent.com/u/22177?v=3","gravatar_id":"","url":"https://api.github.com/users/octplane","html_url":"https://github.com/octplane","followers_url":"https://api.github.com/users/octplane/followers","following_url":"https://api.github.com/users/octplane/following{/other_user}","gists_url":"https://api.github.com/users/octplane/gists{/gist_id}","starred_url":"https://api.github.com/users/octplane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octplane/subscriptions","organizations_url":"https://api.github.com/users/octplane/orgs","repos_url":"https://api.github.com/users/octplane/repos","events_url":"https://api.github.com/users/octplane/events{/privacy}","received_events_url":"https://api.github.com/users/octplane/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/octplane/rsnotify","description":"Cross-platform filesystem notification library for Rust","fork":true,"url":"https://api.github.com/repos/octplane/rsnotify","forks_url":"https://api.github.com/repos/octplane/rsnotify/forks","keys_url":"https://api.github.com/repos/octplane/rsnotify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/octplane/rsnotify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/octplane/rsnotify/teams","hooks_url":"https://api.github.com/repos/octplane/rsnotify/hooks","issue_events_url":"https://api.github.com/repos/octplane/rsnotify/issues/events{/number}","events_url":"https://api.github.com/repos/octplane/rsnotify/events","assignees_url":"https://api.github.com/repos/octplane/rsnotify/assignees{/user}","branches_url":"https://api.github.com/repos/octplane/rsnotify/branches{/branch}","tags_url":"https://api.github.com/repos/octplane/rsnotify/tags","blobs_url":"https://api.github.com/repos/octplane/rsnotify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/octplane/rsnotify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/octplane/rsnotify/git/refs{/sha}","trees_url":"https://api.github.com/repos/octplane/rsnotify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/octplane/rsnotify/statuses/{sha}","languages_url":"https://api.github.com/repos/octplane/rsnotify/languages","stargazers_url":"https://api.github.com/repos/octplane/rsnotify/stargazers","contributors_url":"https://api.github.com/repos/octplane/rsnotify/contributors","subscribers_url":"https://api.github.com/repos/octplane/rsnotify/subscribers","subscription_url":"https://api.github.com/repos/octplane/rsnotify/subscription","commits_url":"https://api.github.com/repos/octplane/rsnotify/commits{/sha}","git_commits_url":"https://api.github.com/repos/octplane/rsnotify/git/commits{/sha}","comments_url":"https://api.github.com/repos/octplane/rsnotify/comments{/number}","issue_comment_url":"https://api.github.com/repos/octplane/rsnotify/issues/comments{/number}","contents_url":"https://api.github.com/repos/octplane/rsnotify/contents/{+path}","compare_url":"https://api.github.com/repos/octplane/rsnotify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/octplane/rsnotify/merges","archive_url":"https://api.github.com/repos/octplane/rsnotify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/octplane/rsnotify/downloads","issues_url":"https://api.github.com/repos/octplane/rsnotify/issues{/number}","pulls_url":"https://api.github.com/repos/octplane/rsnotify/pulls{/number}","milestones_url":"https://api.github.com/repos/octplane/rsnotify/milestones{/number}","notifications_url":"https://api.github.com/repos/octplane/rsnotify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/octplane/rsnotify/labels{/name}","releases_url":"https://api.github.com/repos/octplane/rsnotify/releases{/id}","created_at":"2015-06-06T23:52:48Z","updated_at":"2015-06-06T23:52:49Z","pushed_at":"2015-08-31T11:05:11Z","git_url":"git://github.com/octplane/rsnotify.git","ssh_url":"git@github.com:octplane/rsnotify.git","clone_url":"https://github.com/octplane/rsnotify.git","svn_url":"https://github.com/octplane/rsnotify","homepage":"https://crates.io/crates/notify","size":157,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"passcod:master","ref":"master","sha":"cac203062dd15973cd8b77f8ca73bc46c8a55151","user":{"login":"passcod","id":155787,"avatar_url":"https://avatars.githubusercontent.com/u/155787?v=3","gravatar_id":"","url":"https://api.github.com/users/passcod","html_url":"https://github.com/passcod","followers_url":"https://api.github.com/users/passcod/followers","following_url":"https://api.github.com/users/passcod/following{/other_user}","gists_url":"https://api.github.com/users/passcod/gists{/gist_id}","starred_url":"https://api.github.com/users/passcod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/passcod/subscriptions","organizations_url":"https://api.github.com/users/passcod/orgs","repos_url":"https://api.github.com/users/passcod/repos","events_url":"https://api.github.com/users/passcod/events{/privacy}","received_events_url":"https://api.github.com/users/passcod/received_events","type":"User","site_admin":false},"repo":{"id":27861978,"name":"rsnotify","full_name":"passcod/rsnotify","owner":{"login":"passcod","id":155787,"avatar_url":"https://avatars.githubusercontent.com/u/155787?v=3","gravatar_id":"","url":"https://api.github.com/users/passcod","html_url":"https://github.com/passcod","followers_url":"https://api.github.com/users/passcod/followers","following_url":"https://api.github.com/users/passcod/following{/other_user}","gists_url":"https://api.github.com/users/passcod/gists{/gist_id}","starred_url":"https://api.github.com/users/passcod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/passcod/subscriptions","organizations_url":"https://api.github.com/users/passcod/orgs","repos_url":"https://api.github.com/users/passcod/repos","events_url":"https://api.github.com/users/passcod/events{/privacy}","received_events_url":"https://api.github.com/users/passcod/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/passcod/rsnotify","description":"Cross-platform filesystem notification library for Rust","fork":false,"url":"https://api.github.com/repos/passcod/rsnotify","forks_url":"https://api.github.com/repos/passcod/rsnotify/forks","keys_url":"https://api.github.com/repos/passcod/rsnotify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/passcod/rsnotify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/passcod/rsnotify/teams","hooks_url":"https://api.github.com/repos/passcod/rsnotify/hooks","issue_events_url":"https://api.github.com/repos/passcod/rsnotify/issues/events{/number}","events_url":"https://api.github.com/repos/passcod/rsnotify/events","assignees_url":"https://api.github.com/repos/passcod/rsnotify/assignees{/user}","branches_url":"https://api.github.com/repos/passcod/rsnotify/branches{/branch}","tags_url":"https://api.github.com/repos/passcod/rsnotify/tags","blobs_url":"https://api.github.com/repos/passcod/rsnotify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/passcod/rsnotify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/passcod/rsnotify/git/refs{/sha}","trees_url":"https://api.github.com/repos/passcod/rsnotify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/passcod/rsnotify/statuses/{sha}","languages_url":"https://api.github.com/repos/passcod/rsnotify/languages","stargazers_url":"https://api.github.com/repos/passcod/rsnotify/stargazers","contributors_url":"https://api.github.com/repos/passcod/rsnotify/contributors","subscribers_url":"https://api.github.com/repos/passcod/rsnotify/subscribers","subscription_url":"https://api.github.com/repos/passcod/rsnotify/subscription","commits_url":"https://api.github.com/repos/passcod/rsnotify/commits{/sha}","git_commits_url":"https://api.github.com/repos/passcod/rsnotify/git/commits{/sha}","comments_url":"https://api.github.com/repos/passcod/rsnotify/comments{/number}","issue_comment_url":"https://api.github.com/repos/passcod/rsnotify/issues/comments{/number}","contents_url":"https://api.github.com/repos/passcod/rsnotify/contents/{+path}","compare_url":"https://api.github.com/repos/passcod/rsnotify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/passcod/rsnotify/merges","archive_url":"https://api.github.com/repos/passcod/rsnotify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/passcod/rsnotify/downloads","issues_url":"https://api.github.com/repos/passcod/rsnotify/issues{/number}","pulls_url":"https://api.github.com/repos/passcod/rsnotify/pulls{/number}","milestones_url":"https://api.github.com/repos/passcod/rsnotify/milestones{/number}","notifications_url":"https://api.github.com/repos/passcod/rsnotify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/passcod/rsnotify/labels{/name}","releases_url":"https://api.github.com/repos/passcod/rsnotify/releases{/id}","created_at":"2014-12-11T08:43:53Z","updated_at":"2015-08-30T02:27:11Z","pushed_at":"2015-08-24T07:57:49Z","git_url":"git://github.com/passcod/rsnotify.git","ssh_url":"git@github.com:passcod/rsnotify.git","clone_url":"https://github.com/passcod/rsnotify.git","svn_url":"https://github.com/passcod/rsnotify","homepage":"https://crates.io/crates/notify","size":394,"stargazers_count":66,"watchers_count":66,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":7,"forks":14,"open_issues":7,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/passcod/rsnotify/pulls/27"},"html":{"href":"https://github.com/passcod/rsnotify/pull/27"},"issue":{"href":"https://api.github.com/repos/passcod/rsnotify/issues/27"},"comments":{"href":"https://api.github.com/repos/passcod/rsnotify/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/passcod/rsnotify/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/passcod/rsnotify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/passcod/rsnotify/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/passcod/rsnotify/statuses/20cfe08dce237fc7382de2fe5e60bf9b4c7cf551"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":80,"deletions":13,"changed_files":3}}