{"action":"created","comment":{"url":"https://api.github.com/repos/pydata/pandas/pulls/comments/44227344","id":44227344,"diff_hunk":"@@ -3096,17 +3095,16 @@ def test_join_right(self):\n         self.assertIsNone(ridx)\n \n         # non-unique\n-        \"\"\"\n-        idx = Index([1,1,2,5])\n-        idx2 = Index([1,2,5,7,9])\n+        idx = Index([1, 1, 2, 5])\n+        idx2 = Index([1, 2, 5, 7, 9])\n         res, lidx, ridx = idx.join(idx2, how='right', return_indexers=True)\n-        eres = idx2\n-        elidx = np.array([0, 2, 3, -1, -1])\n-        eridx = np.array([0, 1, 2, 3, 4])\n+        eres = Index([1, 1, 2, 5, 7, 9])  # 1 is in idx2, so it should be x2\n+        elidx = np.array([0, 1, 2, 3, -1, -1])\n+        eridx = np.array([0, 0, 1, 2, 3, 4])\n         self.assertTrue(res.equals(eres))\n         tm.assert_numpy_array_equal(lidx, elidx)\n         tm.assert_numpy_array_equal(ridx, eridx)\n-\n+        \"\"\"","path":"pandas/tests/test_index.py","position":51,"original_position":51,"commit_id":"b108a4aed67f7c54974026a1fb287a46f3981dfe","original_commit_id":"b108a4aed67f7c54974026a1fb287a46f3981dfe","user":{"login":"nbonnotte","id":9929982,"avatar_url":"https://avatars.githubusercontent.com/u/9929982?v=3","gravatar_id":"","url":"https://api.github.com/users/nbonnotte","html_url":"https://github.com/nbonnotte","followers_url":"https://api.github.com/users/nbonnotte/followers","following_url":"https://api.github.com/users/nbonnotte/following{/other_user}","gists_url":"https://api.github.com/users/nbonnotte/gists{/gist_id}","starred_url":"https://api.github.com/users/nbonnotte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbonnotte/subscriptions","organizations_url":"https://api.github.com/users/nbonnotte/orgs","repos_url":"https://api.github.com/users/nbonnotte/repos","events_url":"https://api.github.com/users/nbonnotte/events{/privacy}","received_events_url":"https://api.github.com/users/nbonnotte/received_events","type":"User","site_admin":false},"body":"I don't know. They are the remnants of some old tests that had been commented because they were not working (at least, it seems like it). I've corrected and adapted the most part, but I have no idea what the rest was intended for. \r\n\r\nI've had a conservative approach, and kept them, but sure I can do a bit of cleaning and remove them. What should I do?","created_at":"2015-11-08T17:22:22Z","updated_at":"2015-11-08T17:22:22Z","html_url":"https://github.com/pydata/pandas/pull/11545#discussion_r44227344","pull_request_url":"https://api.github.com/repos/pydata/pandas/pulls/11545","_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/44227344"},"html":{"href":"https://github.com/pydata/pandas/pull/11545#discussion_r44227344"},"pull_request":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11545"}}},"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/11545","id":50046716,"html_url":"https://github.com/pydata/pandas/pull/11545","diff_url":"https://github.com/pydata/pandas/pull/11545.diff","patch_url":"https://github.com/pydata/pandas/pull/11545.patch","issue_url":"https://api.github.com/repos/pydata/pandas/issues/11545","number":11545,"state":"open","locked":false,"title":"BUG: df.join(df2, how='right') TypeError","user":{"login":"nbonnotte","id":9929982,"avatar_url":"https://avatars.githubusercontent.com/u/9929982?v=3","gravatar_id":"","url":"https://api.github.com/users/nbonnotte","html_url":"https://github.com/nbonnotte","followers_url":"https://api.github.com/users/nbonnotte/followers","following_url":"https://api.github.com/users/nbonnotte/following{/other_user}","gists_url":"https://api.github.com/users/nbonnotte/gists{/gist_id}","starred_url":"https://api.github.com/users/nbonnotte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbonnotte/subscriptions","organizations_url":"https://api.github.com/users/nbonnotte/orgs","repos_url":"https://api.github.com/users/nbonnotte/repos","events_url":"https://api.github.com/users/nbonnotte/events{/privacy}","received_events_url":"https://api.github.com/users/nbonnotte/received_events","type":"User","site_admin":false},"body":"Issue #11519\r\n\r\nSomehow right joins had been forgotten in a previous bugfix. There were tests already written that should have seen the problem, but they had been commented out because the expected results were wrong, because of a subtlety in the way non-unique index are handled.\r\n\r\nThanks for the labels \"difficulty novice\" and \"effort low\": I'm using pandas every day, and I'm glad I could contribute that easily.","created_at":"2015-11-07T22:14:36Z","updated_at":"2015-11-08T17:22:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c914496801aa29b8d3771379e4f9376b3149705","assignee":null,"milestone":{"url":"https://api.github.com/repos/pydata/pandas/milestones/37","html_url":"https://github.com/pydata/pandas/milestones/0.17.1","labels_url":"https://api.github.com/repos/pydata/pandas/milestones/37/labels","id":1299459,"number":37,"title":"0.17.1","description":"after 0.17.0 of course!","creator":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"open_issues":72,"closed_issues":110,"state":"open","created_at":"2015-09-10T14:30:44Z","updated_at":"2015-11-08T16:40:31Z","due_on":"2015-11-14T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pydata/pandas/pulls/11545/commits","review_comments_url":"https://api.github.com/repos/pydata/pandas/pulls/11545/comments","review_comment_url":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/11545/comments","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/b108a4aed67f7c54974026a1fb287a46f3981dfe","head":{"label":"nbonnotte:bug-index-right-join","ref":"bug-index-right-join","sha":"b108a4aed67f7c54974026a1fb287a46f3981dfe","user":{"login":"nbonnotte","id":9929982,"avatar_url":"https://avatars.githubusercontent.com/u/9929982?v=3","gravatar_id":"","url":"https://api.github.com/users/nbonnotte","html_url":"https://github.com/nbonnotte","followers_url":"https://api.github.com/users/nbonnotte/followers","following_url":"https://api.github.com/users/nbonnotte/following{/other_user}","gists_url":"https://api.github.com/users/nbonnotte/gists{/gist_id}","starred_url":"https://api.github.com/users/nbonnotte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbonnotte/subscriptions","organizations_url":"https://api.github.com/users/nbonnotte/orgs","repos_url":"https://api.github.com/users/nbonnotte/repos","events_url":"https://api.github.com/users/nbonnotte/events{/privacy}","received_events_url":"https://api.github.com/users/nbonnotte/received_events","type":"User","site_admin":false},"repo":{"id":45754498,"name":"pandas","full_name":"nbonnotte/pandas","owner":{"login":"nbonnotte","id":9929982,"avatar_url":"https://avatars.githubusercontent.com/u/9929982?v=3","gravatar_id":"","url":"https://api.github.com/users/nbonnotte","html_url":"https://github.com/nbonnotte","followers_url":"https://api.github.com/users/nbonnotte/followers","following_url":"https://api.github.com/users/nbonnotte/following{/other_user}","gists_url":"https://api.github.com/users/nbonnotte/gists{/gist_id}","starred_url":"https://api.github.com/users/nbonnotte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbonnotte/subscriptions","organizations_url":"https://api.github.com/users/nbonnotte/orgs","repos_url":"https://api.github.com/users/nbonnotte/repos","events_url":"https://api.github.com/users/nbonnotte/events{/privacy}","received_events_url":"https://api.github.com/users/nbonnotte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nbonnotte/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/nbonnotte/pandas","forks_url":"https://api.github.com/repos/nbonnotte/pandas/forks","keys_url":"https://api.github.com/repos/nbonnotte/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nbonnotte/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nbonnotte/pandas/teams","hooks_url":"https://api.github.com/repos/nbonnotte/pandas/hooks","issue_events_url":"https://api.github.com/repos/nbonnotte/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/nbonnotte/pandas/events","assignees_url":"https://api.github.com/repos/nbonnotte/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/nbonnotte/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/nbonnotte/pandas/tags","blobs_url":"https://api.github.com/repos/nbonnotte/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nbonnotte/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nbonnotte/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/nbonnotte/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nbonnotte/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/nbonnotte/pandas/languages","stargazers_url":"https://api.github.com/repos/nbonnotte/pandas/stargazers","contributors_url":"https://api.github.com/repos/nbonnotte/pandas/contributors","subscribers_url":"https://api.github.com/repos/nbonnotte/pandas/subscribers","subscription_url":"https://api.github.com/repos/nbonnotte/pandas/subscription","commits_url":"https://api.github.com/repos/nbonnotte/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/nbonnotte/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/nbonnotte/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/nbonnotte/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/nbonnotte/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/nbonnotte/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nbonnotte/pandas/merges","archive_url":"https://api.github.com/repos/nbonnotte/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nbonnotte/pandas/downloads","issues_url":"https://api.github.com/repos/nbonnotte/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/nbonnotte/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/nbonnotte/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/nbonnotte/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nbonnotte/pandas/labels{/name}","releases_url":"https://api.github.com/repos/nbonnotte/pandas/releases{/id}","created_at":"2015-11-07T21:04:12Z","updated_at":"2015-11-07T21:04:25Z","pushed_at":"2015-11-08T17:09:53Z","git_url":"git://github.com/nbonnotte/pandas.git","ssh_url":"git@github.com:nbonnotte/pandas.git","clone_url":"https://github.com/nbonnotte/pandas.git","svn_url":"https://github.com/nbonnotte/pandas","homepage":"http://pandas.pydata.org","size":163038,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"8727182683543d9f953250a454b43dbcaf8ae4a8","user":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pydata/pandas","owner":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pydata/pandas","forks_url":"https://api.github.com/repos/pydata/pandas/forks","keys_url":"https://api.github.com/repos/pydata/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/pandas/teams","hooks_url":"https://api.github.com/repos/pydata/pandas/hooks","issue_events_url":"https://api.github.com/repos/pydata/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/pandas/events","assignees_url":"https://api.github.com/repos/pydata/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/pandas/tags","blobs_url":"https://api.github.com/repos/pydata/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/pandas/languages","stargazers_url":"https://api.github.com/repos/pydata/pandas/stargazers","contributors_url":"https://api.github.com/repos/pydata/pandas/contributors","subscribers_url":"https://api.github.com/repos/pydata/pandas/subscribers","subscription_url":"https://api.github.com/repos/pydata/pandas/subscription","commits_url":"https://api.github.com/repos/pydata/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydata/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/pandas/merges","archive_url":"https://api.github.com/repos/pydata/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/pandas/downloads","issues_url":"https://api.github.com/repos/pydata/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pydata/pandas/releases{/id}","created_at":"2010-08-24T01:37:33Z","updated_at":"2015-11-08T17:02:36Z","pushed_at":"2015-11-08T17:14:37Z","git_url":"git://github.com/pydata/pandas.git","ssh_url":"git@github.com:pydata/pandas.git","clone_url":"https://github.com/pydata/pandas.git","svn_url":"https://github.com/pydata/pandas","homepage":"http://pandas.pydata.org","size":163038,"stargazers_count":5236,"watchers_count":5236,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2065,"mirror_url":null,"open_issues_count":1531,"forks":2065,"open_issues":1531,"watchers":5236,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11545"},"html":{"href":"https://github.com/pydata/pandas/pull/11545"},"issue":{"href":"https://api.github.com/repos/pydata/pandas/issues/11545"},"comments":{"href":"https://api.github.com/repos/pydata/pandas/issues/11545/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11545/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11545/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/pandas/statuses/b108a4aed67f7c54974026a1fb287a46f3981dfe"}}}}