{"action":"created","issue":{"url":"https://api.github.com/repos/tass-belgium/picotcp/issues/338","labels_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/338/labels{/name}","comments_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/338/comments","events_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/338/events","html_url":"https://github.com/tass-belgium/picotcp/issues/338","id":118640116,"number":338,"title":"C89 compatibility issues in the MLD module (zero-sized arrays)","user":{"login":"mateuszviste","id":9503501,"avatar_url":"https://avatars.githubusercontent.com/u/9503501?v=3","gravatar_id":"","url":"https://api.github.com/users/mateuszviste","html_url":"https://github.com/mateuszviste","followers_url":"https://api.github.com/users/mateuszviste/followers","following_url":"https://api.github.com/users/mateuszviste/following{/other_user}","gists_url":"https://api.github.com/users/mateuszviste/gists{/gist_id}","starred_url":"https://api.github.com/users/mateuszviste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateuszviste/subscriptions","organizations_url":"https://api.github.com/users/mateuszviste/orgs","repos_url":"https://api.github.com/users/mateuszviste/repos","events_url":"https://api.github.com/users/mateuszviste/events{/privacy}","received_events_url":"https://api.github.com/users/mateuszviste/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-24T15:57:29Z","updated_at":"2015-11-24T19:23:25Z","closed_at":"2015-11-24T19:23:25Z","body":"Hello, this is a continuation of #325. Same problem: there are zero-sized arrays being used in the source code, which breaks C89 compatibility. See below my compiler's output, when building from current devel branch:\r\n\r\n```\r\nwcc -DGENERIC -DPICO_SUPPORT_DHCPC -DPICO_SUPPORT_DNS_CLIENT -DPICO_SUPPORT_ETH -DPICO_SUPPORT_ICMP4 -DPICO_SUPPORT_ICMP6 -DPICO_SUPPORT_IGMP -DPICO_SUPPORT_IPV4 -DPICO_SUPPORT_IPV4FRAG -DPICO_SUPPORT_IPV6 -DPICO_SUPPORT_IPV6FRAG -DPICO_SUPPORT_MCAST -DPICO_SUPPORT_MLD -DPICO_SUPPORT_PING -DPICO_SUPPORT_SNTP_CLIENT -DPICO_SUPPORT_TCP -DPICO_SUPPORT_TFTP -DPICO_SUPPORT_UDP -Iinclude -Imodules -wx -bt=dos -ml -DPICO_COMPILE_TIME=2015 -DARCHDOS modules/pico_mld.c\r\nOpen Watcom C16 Optimizing Compiler Version 1.9\r\nPortions Copyright (c) 1984-2002 Sybase, Inc. All Rights Reserved.\r\nmodules/pico_mld.c(49): Error! E1020: Dimension cannot be 0 or negative\r\nmodules/pico_mld.c(57): Error! E1020: Dimension cannot be 0 or negative\r\nmodules/pico_mld.c(69): Error! E1020: Dimension cannot be 0 or negative\r\nmodules/pico_mld.c: 1179 lines, included 8559, 0 warnings, 3 errors\r\nError(E42): Last command making (all) returned a bad status\r\nError(E02): Make execution terminated\r\n```"},"comment":{"url":"https://api.github.com/repos/tass-belgium/picotcp/issues/comments/159379359","html_url":"https://github.com/tass-belgium/picotcp/issues/338#issuecomment-159379359","issue_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/338","id":159379359,"user":{"login":"roel0","id":11057784,"avatar_url":"https://avatars.githubusercontent.com/u/11057784?v=3","gravatar_id":"","url":"https://api.github.com/users/roel0","html_url":"https://github.com/roel0","followers_url":"https://api.github.com/users/roel0/followers","following_url":"https://api.github.com/users/roel0/following{/other_user}","gists_url":"https://api.github.com/users/roel0/gists{/gist_id}","starred_url":"https://api.github.com/users/roel0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roel0/subscriptions","organizations_url":"https://api.github.com/users/roel0/orgs","repos_url":"https://api.github.com/users/roel0/repos","events_url":"https://api.github.com/users/roel0/events{/privacy}","received_events_url":"https://api.github.com/users/roel0/received_events","type":"User","site_admin":false},"created_at":"2015-11-24T19:23:25Z","updated_at":"2015-11-24T19:23:25Z","body":"Fixed in ada45b6ffb706c3167d4a41f5695feba5f06b09b"}}