{"action":"created","issue":{"url":"https://api.github.com/repos/richardkiss/pycoin/issues/78","labels_url":"https://api.github.com/repos/richardkiss/pycoin/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/richardkiss/pycoin/issues/78/comments","events_url":"https://api.github.com/repos/richardkiss/pycoin/issues/78/events","html_url":"https://github.com/richardkiss/pycoin/pull/78","id":56449706,"number":78,"title":"Fix #77. Add second `script` parameter to remaining `signature_for_hash_type_f` in `verify_tx_in`.","user":{"login":"mbogosian","id":222581,"avatar_url":"https://avatars.githubusercontent.com/u/222581?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogosian","html_url":"https://github.com/mbogosian","followers_url":"https://api.github.com/users/mbogosian/followers","following_url":"https://api.github.com/users/mbogosian/following{/other_user}","gists_url":"https://api.github.com/users/mbogosian/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogosian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogosian/subscriptions","organizations_url":"https://api.github.com/users/mbogosian/orgs","repos_url":"https://api.github.com/users/mbogosian/repos","events_url":"https://api.github.com/users/mbogosian/events{/privacy}","received_events_url":"https://api.github.com/users/mbogosian/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-03T22:42:10Z","updated_at":"2015-02-05T20:30:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/richardkiss/pycoin/pulls/78","html_url":"https://github.com/richardkiss/pycoin/pull/78","diff_url":"https://github.com/richardkiss/pycoin/pull/78.diff","patch_url":"https://github.com/richardkiss/pycoin/pull/78.patch"},"body":"***WARNING: THIS NEEDS REVIEW!***\r\n\r\nIt probably also needs unit tests.\r\n\r\nI'm not sure I follow all the logic that motivated the original change in c441ea75885167a809ae402d03e1066ed89d3804, so I'm probably not the best person to submit this patch. @richardkiss and @gitmarek, can you give your blessing on this? Better yet, can either of you submit a unit test that will appropriately fail with 412efbced6852b586bca8ba2f34f124c974b29c4 and/or c441ea75885167a809ae402d03e1066ed89d3804 with respect to #77?"},"comment":{"url":"https://api.github.com/repos/richardkiss/pycoin/issues/comments/73120725","html_url":"https://github.com/richardkiss/pycoin/pull/78#issuecomment-73120725","issue_url":"https://api.github.com/repos/richardkiss/pycoin/issues/78","id":73120725,"user":{"login":"gitmarek","id":9343001,"avatar_url":"https://avatars.githubusercontent.com/u/9343001?v=3","gravatar_id":"","url":"https://api.github.com/users/gitmarek","html_url":"https://github.com/gitmarek","followers_url":"https://api.github.com/users/gitmarek/followers","following_url":"https://api.github.com/users/gitmarek/following{/other_user}","gists_url":"https://api.github.com/users/gitmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/gitmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitmarek/subscriptions","organizations_url":"https://api.github.com/users/gitmarek/orgs","repos_url":"https://api.github.com/users/gitmarek/repos","events_url":"https://api.github.com/users/gitmarek/events{/privacy}","received_events_url":"https://api.github.com/users/gitmarek/received_events","type":"User","site_admin":false},"created_at":"2015-02-05T20:30:13Z","updated_at":"2015-02-05T20:30:13Z","body":"For me, your fix looks fine. Thanks for it!\r\nI've made a small change to tx_test.py that covers also verify_tx_in method.\r\nIt fails for both 412efbc and c441ea7, but passes for your fix.  Please checkout 4f0ea2c."}}