{"action":"created","issue":{"url":"https://api.github.com/repos/mdelapenya/liferay-portal/issues/458","labels_url":"https://api.github.com/repos/mdelapenya/liferay-portal/issues/458/labels{/name}","comments_url":"https://api.github.com/repos/mdelapenya/liferay-portal/issues/458/comments","events_url":"https://api.github.com/repos/mdelapenya/liferay-portal/issues/458/events","html_url":"https://github.com/mdelapenya/liferay-portal/pull/458","id":94996217,"number":458,"title":"LPS-55529 SF","user":{"login":"sergiogonzalez","id":860987,"avatar_url":"https://avatars.githubusercontent.com/u/860987?v=3","gravatar_id":"","url":"https://api.github.com/users/sergiogonzalez","html_url":"https://github.com/sergiogonzalez","followers_url":"https://api.github.com/users/sergiogonzalez/followers","following_url":"https://api.github.com/users/sergiogonzalez/following{/other_user}","gists_url":"https://api.github.com/users/sergiogonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiogonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiogonzalez/subscriptions","organizations_url":"https://api.github.com/users/sergiogonzalez/orgs","repos_url":"https://api.github.com/users/sergiogonzalez/repos","events_url":"https://api.github.com/users/sergiogonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/sergiogonzalez/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-14T17:27:22Z","updated_at":"2015-07-15T08:30:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mdelapenya/liferay-portal/pulls/458","html_url":"https://github.com/mdelapenya/liferay-portal/pull/458","diff_url":"https://github.com/mdelapenya/liferay-portal/pull/458.diff","patch_url":"https://github.com/mdelapenya/liferay-portal/pull/458.patch"},"body":"Buenas Manu,\r\n\r\nTe envío la pull de nuevo con un cambio muy simple que he hecho para que la reenviéis a quien corresponda. \r\n\r\nTengo algunas dudas con la pull:\r\n\r\n1. Entiendo que el mecanismo de portal.properties para elegir Stores ya no deberíamos de utilizarlo, así que me pregunto si convendría quitarlo eso del portal.properties (aunque sigamos manteniendo compatibilidad hacia atrás mediante el HookHotDeployListener) o bien al menos documentar en la portal.property que esto está deprecado y que debería hacerse con el nuevo mecanismo? Lo digo para que podamos eliminarlo en alguna futura versión.\r\n\r\n2. El método getConfigurationDescription en el ConvertProcess no termino de entender cuál es su uso. Parece que sólo se muestra cuando no se puede ejecutar la conversión? En ese caso no deberíamos de mostrar siempre el mismo mensaje independientemente del convertprocess?\r\n\r\nPor lo demás me parece todo perfecto (aunque siendo sincero lo he mirado muy por encima :))\r\n\r\nSergio"},"comment":{"url":"https://api.github.com/repos/mdelapenya/liferay-portal/issues/comments/121528082","html_url":"https://github.com/mdelapenya/liferay-portal/pull/458#issuecomment-121528082","issue_url":"https://api.github.com/repos/mdelapenya/liferay-portal/issues/458","id":121528082,"user":{"login":"mdelapenya","id":951580,"avatar_url":"https://avatars.githubusercontent.com/u/951580?v=3","gravatar_id":"","url":"https://api.github.com/users/mdelapenya","html_url":"https://github.com/mdelapenya","followers_url":"https://api.github.com/users/mdelapenya/followers","following_url":"https://api.github.com/users/mdelapenya/following{/other_user}","gists_url":"https://api.github.com/users/mdelapenya/gists{/gist_id}","starred_url":"https://api.github.com/users/mdelapenya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdelapenya/subscriptions","organizations_url":"https://api.github.com/users/mdelapenya/orgs","repos_url":"https://api.github.com/users/mdelapenya/repos","events_url":"https://api.github.com/users/mdelapenya/events{/privacy}","received_events_url":"https://api.github.com/users/mdelapenya/received_events","type":"User","site_admin":false},"created_at":"2015-07-15T08:30:33Z","updated_at":"2015-07-15T08:30:33Z","body":"Just started reviewing :) <br><br>:octocat: *Sent from [GH](http://nodegh.io).*"}}