{"action":"created","comment":{"url":"https://api.github.com/repos/a10networks/acos-client/pulls/comments/32277121","id":32277121,"diff_hunk":"@@ -64,7 +64,13 @@ def _set(self, name, protocol=None, lb_method=None, hm_name=None,\n             })\n         }\n \n-        health_check_disable = 1 if kwargs[\"health_check_disable\"] is True else 0\n+        health_check_disable_key = \"health_check_disable\"\n+        health_check_disable = 1\n+\n+        # If we explicitly disable health checks, ensure it happens\n+        # Else, we implicitly disable health checks if not specified.\n+        if health_check_disable_key in kwargs:\n+            health_check_disable = 1 if kwargs[health_check_disable_key] is True else 0","path":"acos_client/v30/slb/service_group.py","position":11,"original_position":11,"commit_id":"2f769bb920ed0367de9586fdb7f42cfe565c5a76","original_commit_id":"2f769bb920ed0367de9586fdb7f42cfe565c5a76","user":{"login":"dougwig","id":603553,"avatar_url":"https://avatars.githubusercontent.com/u/603553?v=3","gravatar_id":"","url":"https://api.github.com/users/dougwig","html_url":"https://github.com/dougwig","followers_url":"https://api.github.com/users/dougwig/followers","following_url":"https://api.github.com/users/dougwig/following{/other_user}","gists_url":"https://api.github.com/users/dougwig/gists{/gist_id}","starred_url":"https://api.github.com/users/dougwig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougwig/subscriptions","organizations_url":"https://api.github.com/users/dougwig/orgs","repos_url":"https://api.github.com/users/dougwig/repos","events_url":"https://api.github.com/users/dougwig/events{/privacy}","received_events_url":"https://api.github.com/users/dougwig/received_events","type":"User","site_admin":false},"body":"Ok, the whole thing above can be:\r\n\r\nhealth_check_disable = 1 if kwargs.get('health_check_disable', False) else 0\r\n","created_at":"2015-06-11T22:54:21Z","updated_at":"2015-06-11T22:54:21Z","html_url":"https://github.com/a10networks/acos-client/pull/69#discussion_r32277121","pull_request_url":"https://api.github.com/repos/a10networks/acos-client/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/a10networks/acos-client/pulls/comments/32277121"},"html":{"href":"https://github.com/a10networks/acos-client/pull/69#discussion_r32277121"},"pull_request":{"href":"https://api.github.com/repos/a10networks/acos-client/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/a10networks/acos-client/pulls/69","id":37514825,"html_url":"https://github.com/a10networks/acos-client/pull/69","diff_url":"https://github.com/a10networks/acos-client/pull/69.diff","patch_url":"https://github.com/a10networks/acos-client/pull/69.patch","issue_url":"https://api.github.com/repos/a10networks/acos-client/issues/69","number":69,"state":"open","locked":false,"title":"Check existence of kwarg before assuming it's there","user":{"login":"mdurrant-b3","id":10053740,"avatar_url":"https://avatars.githubusercontent.com/u/10053740?v=3","gravatar_id":"","url":"https://api.github.com/users/mdurrant-b3","html_url":"https://github.com/mdurrant-b3","followers_url":"https://api.github.com/users/mdurrant-b3/followers","following_url":"https://api.github.com/users/mdurrant-b3/following{/other_user}","gists_url":"https://api.github.com/users/mdurrant-b3/gists{/gist_id}","starred_url":"https://api.github.com/users/mdurrant-b3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdurrant-b3/subscriptions","organizations_url":"https://api.github.com/users/mdurrant-b3/orgs","repos_url":"https://api.github.com/users/mdurrant-b3/repos","events_url":"https://api.github.com/users/mdurrant-b3/events{/privacy}","received_events_url":"https://api.github.com/users/mdurrant-b3/received_events","type":"User","site_admin":false},"body":"... I'm embarrassed about having to open this PR.  Still have 3 failures in neutron-lbaas, one of which is a cleanup problem related to the other 2 failing tenant ID tests.","created_at":"2015-06-11T22:17:32Z","updated_at":"2015-06-11T22:54:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"505b87c5324e3b8c1160401e0396a50709ae70a6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/a10networks/acos-client/pulls/69/commits","review_comments_url":"https://api.github.com/repos/a10networks/acos-client/pulls/69/comments","review_comment_url":"https://api.github.com/repos/a10networks/acos-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/a10networks/acos-client/issues/69/comments","statuses_url":"https://api.github.com/repos/a10networks/acos-client/statuses/2f769bb920ed0367de9586fdb7f42cfe565c5a76","head":{"label":"mdurrant-b3:bonehead-code-fix","ref":"bonehead-code-fix","sha":"2f769bb920ed0367de9586fdb7f42cfe565c5a76","user":{"login":"mdurrant-b3","id":10053740,"avatar_url":"https://avatars.githubusercontent.com/u/10053740?v=3","gravatar_id":"","url":"https://api.github.com/users/mdurrant-b3","html_url":"https://github.com/mdurrant-b3","followers_url":"https://api.github.com/users/mdurrant-b3/followers","following_url":"https://api.github.com/users/mdurrant-b3/following{/other_user}","gists_url":"https://api.github.com/users/mdurrant-b3/gists{/gist_id}","starred_url":"https://api.github.com/users/mdurrant-b3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdurrant-b3/subscriptions","organizations_url":"https://api.github.com/users/mdurrant-b3/orgs","repos_url":"https://api.github.com/users/mdurrant-b3/repos","events_url":"https://api.github.com/users/mdurrant-b3/events{/privacy}","received_events_url":"https://api.github.com/users/mdurrant-b3/received_events","type":"User","site_admin":false},"repo":{"id":30319808,"name":"acos-client","full_name":"mdurrant-b3/acos-client","owner":{"login":"mdurrant-b3","id":10053740,"avatar_url":"https://avatars.githubusercontent.com/u/10053740?v=3","gravatar_id":"","url":"https://api.github.com/users/mdurrant-b3","html_url":"https://github.com/mdurrant-b3","followers_url":"https://api.github.com/users/mdurrant-b3/followers","following_url":"https://api.github.com/users/mdurrant-b3/following{/other_user}","gists_url":"https://api.github.com/users/mdurrant-b3/gists{/gist_id}","starred_url":"https://api.github.com/users/mdurrant-b3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdurrant-b3/subscriptions","organizations_url":"https://api.github.com/users/mdurrant-b3/orgs","repos_url":"https://api.github.com/users/mdurrant-b3/repos","events_url":"https://api.github.com/users/mdurrant-b3/events{/privacy}","received_events_url":"https://api.github.com/users/mdurrant-b3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdurrant-b3/acos-client","description":"ACOS API Client","fork":true,"url":"https://api.github.com/repos/mdurrant-b3/acos-client","forks_url":"https://api.github.com/repos/mdurrant-b3/acos-client/forks","keys_url":"https://api.github.com/repos/mdurrant-b3/acos-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdurrant-b3/acos-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdurrant-b3/acos-client/teams","hooks_url":"https://api.github.com/repos/mdurrant-b3/acos-client/hooks","issue_events_url":"https://api.github.com/repos/mdurrant-b3/acos-client/issues/events{/number}","events_url":"https://api.github.com/repos/mdurrant-b3/acos-client/events","assignees_url":"https://api.github.com/repos/mdurrant-b3/acos-client/assignees{/user}","branches_url":"https://api.github.com/repos/mdurrant-b3/acos-client/branches{/branch}","tags_url":"https://api.github.com/repos/mdurrant-b3/acos-client/tags","blobs_url":"https://api.github.com/repos/mdurrant-b3/acos-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdurrant-b3/acos-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdurrant-b3/acos-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdurrant-b3/acos-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdurrant-b3/acos-client/statuses/{sha}","languages_url":"https://api.github.com/repos/mdurrant-b3/acos-client/languages","stargazers_url":"https://api.github.com/repos/mdurrant-b3/acos-client/stargazers","contributors_url":"https://api.github.com/repos/mdurrant-b3/acos-client/contributors","subscribers_url":"https://api.github.com/repos/mdurrant-b3/acos-client/subscribers","subscription_url":"https://api.github.com/repos/mdurrant-b3/acos-client/subscription","commits_url":"https://api.github.com/repos/mdurrant-b3/acos-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdurrant-b3/acos-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdurrant-b3/acos-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdurrant-b3/acos-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdurrant-b3/acos-client/contents/{+path}","compare_url":"https://api.github.com/repos/mdurrant-b3/acos-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdurrant-b3/acos-client/merges","archive_url":"https://api.github.com/repos/mdurrant-b3/acos-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdurrant-b3/acos-client/downloads","issues_url":"https://api.github.com/repos/mdurrant-b3/acos-client/issues{/number}","pulls_url":"https://api.github.com/repos/mdurrant-b3/acos-client/pulls{/number}","milestones_url":"https://api.github.com/repos/mdurrant-b3/acos-client/milestones{/number}","notifications_url":"https://api.github.com/repos/mdurrant-b3/acos-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdurrant-b3/acos-client/labels{/name}","releases_url":"https://api.github.com/repos/mdurrant-b3/acos-client/releases{/id}","created_at":"2015-02-04T20:36:40Z","updated_at":"2015-05-08T19:37:51Z","pushed_at":"2015-06-11T22:11:16Z","git_url":"git://github.com/mdurrant-b3/acos-client.git","ssh_url":"git@github.com:mdurrant-b3/acos-client.git","clone_url":"https://github.com/mdurrant-b3/acos-client.git","svn_url":"https://github.com/mdurrant-b3/acos-client","homepage":null,"size":442,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"a10networks:master","ref":"master","sha":"e92b3a65f4217e19996659d98894ed6f434ba16f","user":{"login":"a10networks","id":5942705,"avatar_url":"https://avatars.githubusercontent.com/u/5942705?v=3","gravatar_id":"","url":"https://api.github.com/users/a10networks","html_url":"https://github.com/a10networks","followers_url":"https://api.github.com/users/a10networks/followers","following_url":"https://api.github.com/users/a10networks/following{/other_user}","gists_url":"https://api.github.com/users/a10networks/gists{/gist_id}","starred_url":"https://api.github.com/users/a10networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a10networks/subscriptions","organizations_url":"https://api.github.com/users/a10networks/orgs","repos_url":"https://api.github.com/users/a10networks/repos","events_url":"https://api.github.com/users/a10networks/events{/privacy}","received_events_url":"https://api.github.com/users/a10networks/received_events","type":"Organization","site_admin":false},"repo":{"id":21127286,"name":"acos-client","full_name":"a10networks/acos-client","owner":{"login":"a10networks","id":5942705,"avatar_url":"https://avatars.githubusercontent.com/u/5942705?v=3","gravatar_id":"","url":"https://api.github.com/users/a10networks","html_url":"https://github.com/a10networks","followers_url":"https://api.github.com/users/a10networks/followers","following_url":"https://api.github.com/users/a10networks/following{/other_user}","gists_url":"https://api.github.com/users/a10networks/gists{/gist_id}","starred_url":"https://api.github.com/users/a10networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a10networks/subscriptions","organizations_url":"https://api.github.com/users/a10networks/orgs","repos_url":"https://api.github.com/users/a10networks/repos","events_url":"https://api.github.com/users/a10networks/events{/privacy}","received_events_url":"https://api.github.com/users/a10networks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/a10networks/acos-client","description":"ACOS API Client","fork":false,"url":"https://api.github.com/repos/a10networks/acos-client","forks_url":"https://api.github.com/repos/a10networks/acos-client/forks","keys_url":"https://api.github.com/repos/a10networks/acos-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a10networks/acos-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a10networks/acos-client/teams","hooks_url":"https://api.github.com/repos/a10networks/acos-client/hooks","issue_events_url":"https://api.github.com/repos/a10networks/acos-client/issues/events{/number}","events_url":"https://api.github.com/repos/a10networks/acos-client/events","assignees_url":"https://api.github.com/repos/a10networks/acos-client/assignees{/user}","branches_url":"https://api.github.com/repos/a10networks/acos-client/branches{/branch}","tags_url":"https://api.github.com/repos/a10networks/acos-client/tags","blobs_url":"https://api.github.com/repos/a10networks/acos-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a10networks/acos-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a10networks/acos-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/a10networks/acos-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a10networks/acos-client/statuses/{sha}","languages_url":"https://api.github.com/repos/a10networks/acos-client/languages","stargazers_url":"https://api.github.com/repos/a10networks/acos-client/stargazers","contributors_url":"https://api.github.com/repos/a10networks/acos-client/contributors","subscribers_url":"https://api.github.com/repos/a10networks/acos-client/subscribers","subscription_url":"https://api.github.com/repos/a10networks/acos-client/subscription","commits_url":"https://api.github.com/repos/a10networks/acos-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/a10networks/acos-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/a10networks/acos-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/a10networks/acos-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/a10networks/acos-client/contents/{+path}","compare_url":"https://api.github.com/repos/a10networks/acos-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a10networks/acos-client/merges","archive_url":"https://api.github.com/repos/a10networks/acos-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a10networks/acos-client/downloads","issues_url":"https://api.github.com/repos/a10networks/acos-client/issues{/number}","pulls_url":"https://api.github.com/repos/a10networks/acos-client/pulls{/number}","milestones_url":"https://api.github.com/repos/a10networks/acos-client/milestones{/number}","notifications_url":"https://api.github.com/repos/a10networks/acos-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a10networks/acos-client/labels{/name}","releases_url":"https://api.github.com/repos/a10networks/acos-client/releases{/id}","created_at":"2014-06-23T13:31:20Z","updated_at":"2015-05-04T19:56:02Z","pushed_at":"2015-06-11T22:17:32Z","git_url":"git://github.com/a10networks/acos-client.git","ssh_url":"git@github.com:a10networks/acos-client.git","clone_url":"https://github.com/a10networks/acos-client.git","svn_url":"https://github.com/a10networks/acos-client","homepage":null,"size":1093,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":4,"forks":9,"open_issues":4,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/a10networks/acos-client/pulls/69"},"html":{"href":"https://github.com/a10networks/acos-client/pull/69"},"issue":{"href":"https://api.github.com/repos/a10networks/acos-client/issues/69"},"comments":{"href":"https://api.github.com/repos/a10networks/acos-client/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/a10networks/acos-client/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/a10networks/acos-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/a10networks/acos-client/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/a10networks/acos-client/statuses/2f769bb920ed0367de9586fdb7f42cfe565c5a76"}}}}