{"action":"created","comment":{"url":"https://api.github.com/repos/bloomberg/phabricator-tools/pulls/comments/40642123","id":40642123,"diff_hunk":"@@ -243,6 +243,11 @@ cd dev\n     echo\n     echo \"    tail -F ../arcyd/var/log/info\"\n     echo\n+    echo If there are any errors during execution of arcyd, you can see those\n+    echo like so:\n+    echo\n+    echo \"    tail -F ../arcyd/var/log/error\"\n+    echo","path":"testbed/arcyd/test_shell.sh","position":8,"original_position":8,"commit_id":"7f32ee19657afc8b272e5aedcd95acfd1431981f","original_commit_id":"7f32ee19657afc8b272e5aedcd95acfd1431981f","user":{"login":"aevri","id":1478530,"avatar_url":"https://avatars.githubusercontent.com/u/1478530?v=3","gravatar_id":"","url":"https://api.github.com/users/aevri","html_url":"https://github.com/aevri","followers_url":"https://api.github.com/users/aevri/followers","following_url":"https://api.github.com/users/aevri/following{/other_user}","gists_url":"https://api.github.com/users/aevri/gists{/gist_id}","starred_url":"https://api.github.com/users/aevri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aevri/subscriptions","organizations_url":"https://api.github.com/users/aevri/orgs","repos_url":"https://api.github.com/users/aevri/repos","events_url":"https://api.github.com/users/aevri/events{/privacy}","received_events_url":"https://api.github.com/users/aevri/received_events","type":"User","site_admin":false},"body":"Great :)","created_at":"2015-09-29T07:37:42Z","updated_at":"2015-09-29T07:37:42Z","html_url":"https://github.com/bloomberg/phabricator-tools/pull/40#discussion_r40642123","pull_request_url":"https://api.github.com/repos/bloomberg/phabricator-tools/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/bloomberg/phabricator-tools/pulls/comments/40642123"},"html":{"href":"https://github.com/bloomberg/phabricator-tools/pull/40#discussion_r40642123"},"pull_request":{"href":"https://api.github.com/repos/bloomberg/phabricator-tools/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/bloomberg/phabricator-tools/pulls/40","id":45883007,"html_url":"https://github.com/bloomberg/phabricator-tools/pull/40","diff_url":"https://github.com/bloomberg/phabricator-tools/pull/40.diff","patch_url":"https://github.com/bloomberg/phabricator-tools/pull/40.patch","issue_url":"https://api.github.com/repos/bloomberg/phabricator-tools/issues/40","number":40,"state":"open","locked":false,"title":"Arcyd: Create a separate error log stream for errors","user":{"login":"cs-shadow","id":2458024,"avatar_url":"https://avatars.githubusercontent.com/u/2458024?v=3","gravatar_id":"","url":"https://api.github.com/users/cs-shadow","html_url":"https://github.com/cs-shadow","followers_url":"https://api.github.com/users/cs-shadow/followers","following_url":"https://api.github.com/users/cs-shadow/following{/other_user}","gists_url":"https://api.github.com/users/cs-shadow/gists{/gist_id}","starred_url":"https://api.github.com/users/cs-shadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cs-shadow/subscriptions","organizations_url":"https://api.github.com/users/cs-shadow/orgs","repos_url":"https://api.github.com/users/cs-shadow/repos","events_url":"https://api.github.com/users/cs-shadow/events{/privacy}","received_events_url":"https://api.github.com/users/cs-shadow/received_events","type":"User","site_admin":false},"body":"At present, INFO+ and DEBUG+ logs are logged to different files but\r\nthere's no separate handler for errors so its difficult to find errors,\r\nif any happen. Also, when error happens this will not pollute info logs\r\nwith long error messages. This commit adds a separate error handler for\r\nERROR+ which is logged to \"var/log/error\".\r\n\r\nSince this commit introduces distinction between concise and verbose\r\nmessages, \"VERBOSE MESSAGE\" must be prepended to all verbose messages.\r\nIf an error message contains more than one or two lines, we typically\r\nconsider it as verbose.\r\n\r\nTest plan:\r\n$ ./precommit.sh\r\n\r\nFixes #31","created_at":"2015-09-24T10:50:01Z","updated_at":"2015-09-29T07:37:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c50a4b355d2f915c916ec9fc77058ec0dc11a878","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bloomberg/phabricator-tools/pulls/40/commits","review_comments_url":"https://api.github.com/repos/bloomberg/phabricator-tools/pulls/40/comments","review_comment_url":"https://api.github.com/repos/bloomberg/phabricator-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bloomberg/phabricator-tools/issues/40/comments","statuses_url":"https://api.github.com/repos/bloomberg/phabricator-tools/statuses/7f32ee19657afc8b272e5aedcd95acfd1431981f","head":{"label":"cs-shadow:separate-error-log","ref":"separate-error-log","sha":"7f32ee19657afc8b272e5aedcd95acfd1431981f","user":{"login":"cs-shadow","id":2458024,"avatar_url":"https://avatars.githubusercontent.com/u/2458024?v=3","gravatar_id":"","url":"https://api.github.com/users/cs-shadow","html_url":"https://github.com/cs-shadow","followers_url":"https://api.github.com/users/cs-shadow/followers","following_url":"https://api.github.com/users/cs-shadow/following{/other_user}","gists_url":"https://api.github.com/users/cs-shadow/gists{/gist_id}","starred_url":"https://api.github.com/users/cs-shadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cs-shadow/subscriptions","organizations_url":"https://api.github.com/users/cs-shadow/orgs","repos_url":"https://api.github.com/users/cs-shadow/repos","events_url":"https://api.github.com/users/cs-shadow/events{/privacy}","received_events_url":"https://api.github.com/users/cs-shadow/received_events","type":"User","site_admin":false},"repo":{"id":42682358,"name":"phabricator-tools","full_name":"cs-shadow/phabricator-tools","owner":{"login":"cs-shadow","id":2458024,"avatar_url":"https://avatars.githubusercontent.com/u/2458024?v=3","gravatar_id":"","url":"https://api.github.com/users/cs-shadow","html_url":"https://github.com/cs-shadow","followers_url":"https://api.github.com/users/cs-shadow/followers","following_url":"https://api.github.com/users/cs-shadow/following{/other_user}","gists_url":"https://api.github.com/users/cs-shadow/gists{/gist_id}","starred_url":"https://api.github.com/users/cs-shadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cs-shadow/subscriptions","organizations_url":"https://api.github.com/users/cs-shadow/orgs","repos_url":"https://api.github.com/users/cs-shadow/repos","events_url":"https://api.github.com/users/cs-shadow/events{/privacy}","received_events_url":"https://api.github.com/users/cs-shadow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cs-shadow/phabricator-tools","description":"Phabricator Tools","fork":true,"url":"https://api.github.com/repos/cs-shadow/phabricator-tools","forks_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/forks","keys_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/teams","hooks_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/hooks","issue_events_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/issues/events{/number}","events_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/events","assignees_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/assignees{/user}","branches_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/branches{/branch}","tags_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/tags","blobs_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/languages","stargazers_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/stargazers","contributors_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/contributors","subscribers_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/subscribers","subscription_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/subscription","commits_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/contents/{+path}","compare_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/merges","archive_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/downloads","issues_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/issues{/number}","pulls_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/labels{/name}","releases_url":"https://api.github.com/repos/cs-shadow/phabricator-tools/releases{/id}","created_at":"2015-09-17T21:15:27Z","updated_at":"2015-09-17T21:15:29Z","pushed_at":"2015-09-28T15:37:28Z","git_url":"git://github.com/cs-shadow/phabricator-tools.git","ssh_url":"git@github.com:cs-shadow/phabricator-tools.git","clone_url":"https://github.com/cs-shadow/phabricator-tools.git","svn_url":"https://github.com/cs-shadow/phabricator-tools","homepage":null,"size":3522,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bloomberg:master","ref":"master","sha":"e2433c58321aae117dc6957cdc9ac8cb40212e27","user":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=3","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"repo":{"id":8464182,"name":"phabricator-tools","full_name":"bloomberg/phabricator-tools","owner":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=3","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bloomberg/phabricator-tools","description":"Phabricator Tools","fork":false,"url":"https://api.github.com/repos/bloomberg/phabricator-tools","forks_url":"https://api.github.com/repos/bloomberg/phabricator-tools/forks","keys_url":"https://api.github.com/repos/bloomberg/phabricator-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bloomberg/phabricator-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bloomberg/phabricator-tools/teams","hooks_url":"https://api.github.com/repos/bloomberg/phabricator-tools/hooks","issue_events_url":"https://api.github.com/repos/bloomberg/phabricator-tools/issues/events{/number}","events_url":"https://api.github.com/repos/bloomberg/phabricator-tools/events","assignees_url":"https://api.github.com/repos/bloomberg/phabricator-tools/assignees{/user}","branches_url":"https://api.github.com/repos/bloomberg/phabricator-tools/branches{/branch}","tags_url":"https://api.github.com/repos/bloomberg/phabricator-tools/tags","blobs_url":"https://api.github.com/repos/bloomberg/phabricator-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bloomberg/phabricator-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bloomberg/phabricator-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/bloomberg/phabricator-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bloomberg/phabricator-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/bloomberg/phabricator-tools/languages","stargazers_url":"https://api.github.com/repos/bloomberg/phabricator-tools/stargazers","contributors_url":"https://api.github.com/repos/bloomberg/phabricator-tools/contributors","subscribers_url":"https://api.github.com/repos/bloomberg/phabricator-tools/subscribers","subscription_url":"https://api.github.com/repos/bloomberg/phabricator-tools/subscription","commits_url":"https://api.github.com/repos/bloomberg/phabricator-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/bloomberg/phabricator-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/bloomberg/phabricator-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/bloomberg/phabricator-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/bloomberg/phabricator-tools/contents/{+path}","compare_url":"https://api.github.com/repos/bloomberg/phabricator-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bloomberg/phabricator-tools/merges","archive_url":"https://api.github.com/repos/bloomberg/phabricator-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bloomberg/phabricator-tools/downloads","issues_url":"https://api.github.com/repos/bloomberg/phabricator-tools/issues{/number}","pulls_url":"https://api.github.com/repos/bloomberg/phabricator-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/bloomberg/phabricator-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/bloomberg/phabricator-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bloomberg/phabricator-tools/labels{/name}","releases_url":"https://api.github.com/repos/bloomberg/phabricator-tools/releases{/id}","created_at":"2013-02-27T20:02:50Z","updated_at":"2015-09-23T08:12:14Z","pushed_at":"2015-09-29T07:15:20Z","git_url":"git://github.com/bloomberg/phabricator-tools.git","ssh_url":"git@github.com:bloomberg/phabricator-tools.git","clone_url":"https://github.com/bloomberg/phabricator-tools.git","svn_url":"https://github.com/bloomberg/phabricator-tools","homepage":null,"size":5206,"stargazers_count":126,"watchers_count":126,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":26,"mirror_url":null,"open_issues_count":14,"forks":26,"open_issues":14,"watchers":126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bloomberg/phabricator-tools/pulls/40"},"html":{"href":"https://github.com/bloomberg/phabricator-tools/pull/40"},"issue":{"href":"https://api.github.com/repos/bloomberg/phabricator-tools/issues/40"},"comments":{"href":"https://api.github.com/repos/bloomberg/phabricator-tools/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/bloomberg/phabricator-tools/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/bloomberg/phabricator-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bloomberg/phabricator-tools/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/bloomberg/phabricator-tools/statuses/7f32ee19657afc8b272e5aedcd95acfd1431981f"}}}}