{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/32038118","id":32038118,"diff_hunk":"@@ -9,15 +9,9 @@\n \n defined('_JEXEC') or die;\n \n-$app = JFactory::getApplication();\n-$form = $displayData->getForm();\n-\n-$fieldSets = $form->getFieldsets('params');\n-\n-// For BC with versions < 3.2 we need to render the attribs too\n-$attribsFieldSet = $form->getFieldsets('attribs');","path":"layouts/joomla/edit/params.php","position":10,"original_position":10,"commit_id":"80cc1073870a80dbd37d76611f35601ca404ada5","original_commit_id":"80cc1073870a80dbd37d76611f35601ca404ada5","user":{"login":"pollen8","id":28268,"avatar_url":"https://avatars.githubusercontent.com/u/28268?v=3","gravatar_id":"","url":"https://api.github.com/users/pollen8","html_url":"https://github.com/pollen8","followers_url":"https://api.github.com/users/pollen8/followers","following_url":"https://api.github.com/users/pollen8/following{/other_user}","gists_url":"https://api.github.com/users/pollen8/gists{/gist_id}","starred_url":"https://api.github.com/users/pollen8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pollen8/subscriptions","organizations_url":"https://api.github.com/users/pollen8/orgs","repos_url":"https://api.github.com/users/pollen8/repos","events_url":"https://api.github.com/users/pollen8/events{/privacy}","received_events_url":"https://api.github.com/users/pollen8/received_events","type":"User","site_admin":false},"body":"$attribsFieldSet isn't used in the layout , so pretty sure that removing it won't change rendering","created_at":"2015-06-09T17:14:37Z","updated_at":"2015-06-09T17:14:37Z","html_url":"https://github.com/joomla/joomla-cms/pull/7126#discussion_r32038118","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/7126","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/32038118"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/7126#discussion_r32038118"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/7126"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/7126","id":37038126,"html_url":"https://github.com/joomla/joomla-cms/pull/7126","diff_url":"https://github.com/joomla/joomla-cms/pull/7126.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/7126.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7126","number":7126,"state":"open","locked":false,"title":"content plugins not able to insert custom fieldsets into core forms","user":{"login":"pollen8","id":28268,"avatar_url":"https://avatars.githubusercontent.com/u/28268?v=3","gravatar_id":"","url":"https://api.github.com/users/pollen8","html_url":"https://github.com/pollen8","followers_url":"https://api.github.com/users/pollen8/followers","following_url":"https://api.github.com/users/pollen8/following{/other_user}","gists_url":"https://api.github.com/users/pollen8/gists{/gist_id}","starred_url":"https://api.github.com/users/pollen8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pollen8/subscriptions","organizations_url":"https://api.github.com/users/pollen8/orgs","repos_url":"https://api.github.com/users/pollen8/repos","events_url":"https://api.github.com/users/pollen8/events{/privacy}","received_events_url":"https://api.github.com/users/pollen8/received_events","type":"User","site_admin":false},"body":"This is basically the work done in this previous PR\r\nhttps://github.com/joomla/joomla-cms/pull/4284\r\nWith the additions that Jean Marie asked for regarding multi lingual sites and the associations tab that is added.\r\nThe test instructions are the same as #4284\r\n\r\n-----\r\n## Background\r\nWith the implementation of using JLayout to render parameters (https://github.com/joomla/joomla-cms/pull/2162) support for rendering custom named fieldsets ceased to be supported. This is a documented feature since at least Joomla 2.5 http://docs.joomla.org/Adding_custom_fields_to_the_article_component and is also documented to be suported in 3.1 at http://docs.joomla.org/Adding_custom_fields_to_core_components_using_a_plugin. In fact, the current core user profile plugin would break if JLayout 'joomla.edit.params' was implemented for com_users.user due to the plugin using custom named fieldsets (https://github.com/joomla/joomla-cms/blob/staging/plugins/user/profile/profiles/profile.xml#L3-L4) and the current implementation of JLayout 'joomla.edit.params' being effectively hardcoded to only render fieldsets named `params` and `attribs` (https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/edit/params.php#L15-L18). \r\n\r\n## Changes\r\nThis PR changes the behavior of JLayout 'joomla.edit.params' to render all fieldsets of the form, except those designated with the `ignore_fieldsets` property.\r\n\r\nAffected by this PR are the following backend edit views:\r\n* com_categories.category\r\n* com_contact.contact\r\n* com_content.article\r\n* com_finder.filter\r\n* com_menus.item\r\n* com_modules.module\r\n* com_newsfeeds.newsfeed\r\n* com_plugins.plugin\r\n* com_tags.tag\r\n* com_templates.style\r\n* com_weblinks.weblink\r\n\r\n## Backwards Compatibility\r\nThis PR should be 100% backwards compatible while restoring this functionality.\r\n\r\n## Testing\r\nApply the patch associated with this PR and review the above views to ensure that all of the currently rendered fieldsets (as tabs in Isis) remain to be rendered. Then, install and plugin that uses a custom named fieldset and ensure that it is rendered at all of the above views as described in Joomla's documentation.\r\n\r\nA test plugin can be downloaded from https://github.com/betweenbrain/Joomla-Custom-Field-Plugin-Example/archive/test.zip","created_at":"2015-06-05T14:46:36Z","updated_at":"2015-06-09T17:14:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c43e67c1ca6d8cd16f143f6a821c7803eec50d39","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/7126/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/7126/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7126/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/80cc1073870a80dbd37d76611f35601ca404ada5","head":{"label":"pollen8:admin-content-form-plugins","ref":"admin-content-form-plugins","sha":"80cc1073870a80dbd37d76611f35601ca404ada5","user":{"login":"pollen8","id":28268,"avatar_url":"https://avatars.githubusercontent.com/u/28268?v=3","gravatar_id":"","url":"https://api.github.com/users/pollen8","html_url":"https://github.com/pollen8","followers_url":"https://api.github.com/users/pollen8/followers","following_url":"https://api.github.com/users/pollen8/following{/other_user}","gists_url":"https://api.github.com/users/pollen8/gists{/gist_id}","starred_url":"https://api.github.com/users/pollen8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pollen8/subscriptions","organizations_url":"https://api.github.com/users/pollen8/orgs","repos_url":"https://api.github.com/users/pollen8/repos","events_url":"https://api.github.com/users/pollen8/events{/privacy}","received_events_url":"https://api.github.com/users/pollen8/received_events","type":"User","site_admin":false},"repo":{"id":2505638,"name":"joomla-cms","full_name":"pollen8/joomla-cms","owner":{"login":"pollen8","id":28268,"avatar_url":"https://avatars.githubusercontent.com/u/28268?v=3","gravatar_id":"","url":"https://api.github.com/users/pollen8","html_url":"https://github.com/pollen8","followers_url":"https://api.github.com/users/pollen8/followers","following_url":"https://api.github.com/users/pollen8/following{/other_user}","gists_url":"https://api.github.com/users/pollen8/gists{/gist_id}","starred_url":"https://api.github.com/users/pollen8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pollen8/subscriptions","organizations_url":"https://api.github.com/users/pollen8/orgs","repos_url":"https://api.github.com/users/pollen8/repos","events_url":"https://api.github.com/users/pollen8/events{/privacy}","received_events_url":"https://api.github.com/users/pollen8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pollen8/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/pollen8/joomla-cms","forks_url":"https://api.github.com/repos/pollen8/joomla-cms/forks","keys_url":"https://api.github.com/repos/pollen8/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pollen8/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pollen8/joomla-cms/teams","hooks_url":"https://api.github.com/repos/pollen8/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/pollen8/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/pollen8/joomla-cms/events","assignees_url":"https://api.github.com/repos/pollen8/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/pollen8/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/pollen8/joomla-cms/tags","blobs_url":"https://api.github.com/repos/pollen8/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pollen8/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pollen8/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/pollen8/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pollen8/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/pollen8/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/pollen8/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/pollen8/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/pollen8/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/pollen8/joomla-cms/subscription","commits_url":"https://api.github.com/repos/pollen8/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/pollen8/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/pollen8/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/pollen8/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/pollen8/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/pollen8/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pollen8/joomla-cms/merges","archive_url":"https://api.github.com/repos/pollen8/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pollen8/joomla-cms/downloads","issues_url":"https://api.github.com/repos/pollen8/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/pollen8/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/pollen8/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/pollen8/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pollen8/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/pollen8/joomla-cms/releases{/id}","created_at":"2011-10-03T15:48:20Z","updated_at":"2014-03-28T09:38:50Z","pushed_at":"2015-06-05T14:41:39Z","git_url":"git://github.com/pollen8/joomla-cms.git","ssh_url":"git@github.com:pollen8/joomla-cms.git","clone_url":"https://github.com/pollen8/joomla-cms.git","svn_url":"https://github.com/pollen8/joomla-cms","homepage":"http://joomla.org","size":117351,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"joomla:staging","ref":"staging","sha":"677b82ecb6329498535f1d690d66d861574aa171","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","created_at":"2011-09-27T02:07:38Z","updated_at":"2015-06-09T16:13:40Z","pushed_at":"2015-06-09T10:25:19Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"http://joomla.org","size":326152,"stargazers_count":1562,"watchers_count":1562,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1743,"mirror_url":null,"open_issues_count":588,"forks":1743,"open_issues":588,"watchers":1562,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/7126"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/7126"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/7126"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/7126/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/7126/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/7126/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/80cc1073870a80dbd37d76611f35601ca404ada5"}}}}