{"action":"opened","number":84,"pull_request":{"url":"https://api.github.com/repos/redding/qs/pulls/84","id":36872492,"html_url":"https://github.com/redding/qs/pull/84","diff_url":"https://github.com/redding/qs/pull/84.diff","patch_url":"https://github.com/redding/qs/pull/84.patch","issue_url":"https://api.github.com/repos/redding/qs/issues/84","number":84,"state":"open","locked":false,"title":"Pass params via options when building jobs and events","user":{"login":"jcredding","id":85966,"avatar_url":"https://avatars.githubusercontent.com/u/85966?v=3","gravatar_id":"","url":"https://api.github.com/users/jcredding","html_url":"https://github.com/jcredding","followers_url":"https://api.github.com/users/jcredding/followers","following_url":"https://api.github.com/users/jcredding/following{/other_user}","gists_url":"https://api.github.com/users/jcredding/gists{/gist_id}","starred_url":"https://api.github.com/users/jcredding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcredding/subscriptions","organizations_url":"https://api.github.com/users/jcredding/orgs","repos_url":"https://api.github.com/users/jcredding/repos","events_url":"https://api.github.com/users/jcredding/events{/privacy}","received_events_url":"https://api.github.com/users/jcredding/received_events","type":"User","site_admin":false},"body":"This changes the `new` methods for jobs and events to expect their\r\nparams to be passed in an options hash instead of as an argument.\r\nThis is to avoid a double-hash at the end of the method signature.\r\n\r\nBy moving the params into the options, this makes them optional at\r\nthe `Job` and `Event` level. Previously, they were optional for\r\nthe `enqueue` and `publish` methods. This updates the `Job` and\r\nthe `Event` to default them to an empty hash and removes the\r\nprevious defaulting.\r\n\r\nThis also changes the errors thrown by `Job` and `Event` to be\r\nnested under them and renames them to invalid instead of bad. This\r\nis a better naming and lets them use the namespace of their\r\nrespective classes for identifying their role.\r\n\r\n@kellyredding - Ready for review.","created_at":"2015-06-03T20:09:12Z","updated_at":"2015-06-03T20:09:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/redding/qs/pulls/84/commits","review_comments_url":"https://api.github.com/repos/redding/qs/pulls/84/comments","review_comment_url":"https://api.github.com/repos/redding/qs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redding/qs/issues/84/comments","statuses_url":"https://api.github.com/repos/redding/qs/statuses/01ca99c57d6948fd2669ae5012bbf00f17027f4e","head":{"label":"redding:jcr-job-event-params-in-opts","ref":"jcr-job-event-params-in-opts","sha":"01ca99c57d6948fd2669ae5012bbf00f17027f4e","user":{"login":"redding","id":2427810,"avatar_url":"https://avatars.githubusercontent.com/u/2427810?v=3","gravatar_id":"","url":"https://api.github.com/users/redding","html_url":"https://github.com/redding","followers_url":"https://api.github.com/users/redding/followers","following_url":"https://api.github.com/users/redding/following{/other_user}","gists_url":"https://api.github.com/users/redding/gists{/gist_id}","starred_url":"https://api.github.com/users/redding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redding/subscriptions","organizations_url":"https://api.github.com/users/redding/orgs","repos_url":"https://api.github.com/users/redding/repos","events_url":"https://api.github.com/users/redding/events{/privacy}","received_events_url":"https://api.github.com/users/redding/received_events","type":"Organization","site_admin":false},"repo":{"id":8260201,"name":"qs","full_name":"redding/qs","owner":{"login":"redding","id":2427810,"avatar_url":"https://avatars.githubusercontent.com/u/2427810?v=3","gravatar_id":"","url":"https://api.github.com/users/redding","html_url":"https://github.com/redding","followers_url":"https://api.github.com/users/redding/followers","following_url":"https://api.github.com/users/redding/following{/other_user}","gists_url":"https://api.github.com/users/redding/gists{/gist_id}","starred_url":"https://api.github.com/users/redding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redding/subscriptions","organizations_url":"https://api.github.com/users/redding/orgs","repos_url":"https://api.github.com/users/redding/repos","events_url":"https://api.github.com/users/redding/events{/privacy}","received_events_url":"https://api.github.com/users/redding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redding/qs","description":"Handler-based background jobs and message queueing.","fork":false,"url":"https://api.github.com/repos/redding/qs","forks_url":"https://api.github.com/repos/redding/qs/forks","keys_url":"https://api.github.com/repos/redding/qs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redding/qs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redding/qs/teams","hooks_url":"https://api.github.com/repos/redding/qs/hooks","issue_events_url":"https://api.github.com/repos/redding/qs/issues/events{/number}","events_url":"https://api.github.com/repos/redding/qs/events","assignees_url":"https://api.github.com/repos/redding/qs/assignees{/user}","branches_url":"https://api.github.com/repos/redding/qs/branches{/branch}","tags_url":"https://api.github.com/repos/redding/qs/tags","blobs_url":"https://api.github.com/repos/redding/qs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redding/qs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redding/qs/git/refs{/sha}","trees_url":"https://api.github.com/repos/redding/qs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redding/qs/statuses/{sha}","languages_url":"https://api.github.com/repos/redding/qs/languages","stargazers_url":"https://api.github.com/repos/redding/qs/stargazers","contributors_url":"https://api.github.com/repos/redding/qs/contributors","subscribers_url":"https://api.github.com/repos/redding/qs/subscribers","subscription_url":"https://api.github.com/repos/redding/qs/subscription","commits_url":"https://api.github.com/repos/redding/qs/commits{/sha}","git_commits_url":"https://api.github.com/repos/redding/qs/git/commits{/sha}","comments_url":"https://api.github.com/repos/redding/qs/comments{/number}","issue_comment_url":"https://api.github.com/repos/redding/qs/issues/comments{/number}","contents_url":"https://api.github.com/repos/redding/qs/contents/{+path}","compare_url":"https://api.github.com/repos/redding/qs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redding/qs/merges","archive_url":"https://api.github.com/repos/redding/qs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redding/qs/downloads","issues_url":"https://api.github.com/repos/redding/qs/issues{/number}","pulls_url":"https://api.github.com/repos/redding/qs/pulls{/number}","milestones_url":"https://api.github.com/repos/redding/qs/milestones{/number}","notifications_url":"https://api.github.com/repos/redding/qs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redding/qs/labels{/name}","releases_url":"https://api.github.com/repos/redding/qs/releases{/id}","created_at":"2013-02-18T02:20:31Z","updated_at":"2015-05-05T21:40:07Z","pushed_at":"2015-06-03T20:08:50Z","git_url":"git://github.com/redding/qs.git","ssh_url":"git@github.com:redding/qs.git","clone_url":"https://github.com/redding/qs.git","svn_url":"https://github.com/redding/qs","homepage":"","size":2060,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"redding:master","ref":"master","sha":"aeda6e45842024587032acd67ef59d906c05e38f","user":{"login":"redding","id":2427810,"avatar_url":"https://avatars.githubusercontent.com/u/2427810?v=3","gravatar_id":"","url":"https://api.github.com/users/redding","html_url":"https://github.com/redding","followers_url":"https://api.github.com/users/redding/followers","following_url":"https://api.github.com/users/redding/following{/other_user}","gists_url":"https://api.github.com/users/redding/gists{/gist_id}","starred_url":"https://api.github.com/users/redding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redding/subscriptions","organizations_url":"https://api.github.com/users/redding/orgs","repos_url":"https://api.github.com/users/redding/repos","events_url":"https://api.github.com/users/redding/events{/privacy}","received_events_url":"https://api.github.com/users/redding/received_events","type":"Organization","site_admin":false},"repo":{"id":8260201,"name":"qs","full_name":"redding/qs","owner":{"login":"redding","id":2427810,"avatar_url":"https://avatars.githubusercontent.com/u/2427810?v=3","gravatar_id":"","url":"https://api.github.com/users/redding","html_url":"https://github.com/redding","followers_url":"https://api.github.com/users/redding/followers","following_url":"https://api.github.com/users/redding/following{/other_user}","gists_url":"https://api.github.com/users/redding/gists{/gist_id}","starred_url":"https://api.github.com/users/redding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redding/subscriptions","organizations_url":"https://api.github.com/users/redding/orgs","repos_url":"https://api.github.com/users/redding/repos","events_url":"https://api.github.com/users/redding/events{/privacy}","received_events_url":"https://api.github.com/users/redding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redding/qs","description":"Handler-based background jobs and message queueing.","fork":false,"url":"https://api.github.com/repos/redding/qs","forks_url":"https://api.github.com/repos/redding/qs/forks","keys_url":"https://api.github.com/repos/redding/qs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redding/qs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redding/qs/teams","hooks_url":"https://api.github.com/repos/redding/qs/hooks","issue_events_url":"https://api.github.com/repos/redding/qs/issues/events{/number}","events_url":"https://api.github.com/repos/redding/qs/events","assignees_url":"https://api.github.com/repos/redding/qs/assignees{/user}","branches_url":"https://api.github.com/repos/redding/qs/branches{/branch}","tags_url":"https://api.github.com/repos/redding/qs/tags","blobs_url":"https://api.github.com/repos/redding/qs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redding/qs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redding/qs/git/refs{/sha}","trees_url":"https://api.github.com/repos/redding/qs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redding/qs/statuses/{sha}","languages_url":"https://api.github.com/repos/redding/qs/languages","stargazers_url":"https://api.github.com/repos/redding/qs/stargazers","contributors_url":"https://api.github.com/repos/redding/qs/contributors","subscribers_url":"https://api.github.com/repos/redding/qs/subscribers","subscription_url":"https://api.github.com/repos/redding/qs/subscription","commits_url":"https://api.github.com/repos/redding/qs/commits{/sha}","git_commits_url":"https://api.github.com/repos/redding/qs/git/commits{/sha}","comments_url":"https://api.github.com/repos/redding/qs/comments{/number}","issue_comment_url":"https://api.github.com/repos/redding/qs/issues/comments{/number}","contents_url":"https://api.github.com/repos/redding/qs/contents/{+path}","compare_url":"https://api.github.com/repos/redding/qs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redding/qs/merges","archive_url":"https://api.github.com/repos/redding/qs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redding/qs/downloads","issues_url":"https://api.github.com/repos/redding/qs/issues{/number}","pulls_url":"https://api.github.com/repos/redding/qs/pulls{/number}","milestones_url":"https://api.github.com/repos/redding/qs/milestones{/number}","notifications_url":"https://api.github.com/repos/redding/qs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redding/qs/labels{/name}","releases_url":"https://api.github.com/repos/redding/qs/releases{/id}","created_at":"2013-02-18T02:20:31Z","updated_at":"2015-05-05T21:40:07Z","pushed_at":"2015-06-03T20:08:50Z","git_url":"git://github.com/redding/qs.git","ssh_url":"git@github.com:redding/qs.git","clone_url":"https://github.com/redding/qs.git","svn_url":"https://github.com/redding/qs","homepage":"","size":2060,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redding/qs/pulls/84"},"html":{"href":"https://github.com/redding/qs/pull/84"},"issue":{"href":"https://api.github.com/repos/redding/qs/issues/84"},"comments":{"href":"https://api.github.com/repos/redding/qs/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/redding/qs/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/redding/qs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redding/qs/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/redding/qs/statuses/01ca99c57d6948fd2669ae5012bbf00f17027f4e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":114,"deletions":131,"changed_files":12}}