{"action":"created","issue":{"url":"https://api.github.com/repos/Cal-CS-61A-Staff/ok/issues/599","labels_url":"https://api.github.com/repos/Cal-CS-61A-Staff/ok/issues/599/labels{/name}","comments_url":"https://api.github.com/repos/Cal-CS-61A-Staff/ok/issues/599/comments","events_url":"https://api.github.com/repos/Cal-CS-61A-Staff/ok/issues/599/events","html_url":"https://github.com/Cal-CS-61A-Staff/ok/pull/599","id":108441573,"number":599,"title":"Zip encoding","user":{"login":"knrafto","id":2042019,"avatar_url":"https://avatars.githubusercontent.com/u/2042019?v=3","gravatar_id":"","url":"https://api.github.com/users/knrafto","html_url":"https://github.com/knrafto","followers_url":"https://api.github.com/users/knrafto/followers","following_url":"https://api.github.com/users/knrafto/following{/other_user}","gists_url":"https://api.github.com/users/knrafto/gists{/gist_id}","starred_url":"https://api.github.com/users/knrafto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knrafto/subscriptions","organizations_url":"https://api.github.com/users/knrafto/orgs","repos_url":"https://api.github.com/users/knrafto/repos","events_url":"https://api.github.com/users/knrafto/events{/privacy}","received_events_url":"https://api.github.com/users/knrafto/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-09-26T05:24:38Z","updated_at":"2015-09-27T01:05:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Cal-CS-61A-Staff/ok/pulls/599","html_url":"https://github.com/Cal-CS-61A-Staff/ok/pull/599","diff_url":"https://github.com/Cal-CS-61A-Staff/ok/pull/599.diff","patch_url":"https://github.com/Cal-CS-61A-Staff/ok/pull/599.patch"},"body":"Fixes #597. We pass [zipfile](https://docs.python.org/3/library/zipfile.html) the Cloudstorage file stream so we don't hold all the contents in memory.\r\n\r\nTried it on Hog and successfully downloaded the zip (98M). Extracted and got some duplicate files (a lot, actually). They look like this:\r\n```\r\nreplace ****@berkeley-edu-2015-09-10_05:50:37-246979/group_members_****.json? [y]es, [n]o, [A]ll, [N]one, [r]ename: \r\n```"},"comment":{"url":"https://api.github.com/repos/Cal-CS-61A-Staff/ok/issues/comments/143508740","html_url":"https://github.com/Cal-CS-61A-Staff/ok/pull/599#issuecomment-143508740","issue_url":"https://api.github.com/repos/Cal-CS-61A-Staff/ok/issues/599","id":143508740,"user":{"login":"Sumukh","id":882381,"avatar_url":"https://avatars.githubusercontent.com/u/882381?v=3","gravatar_id":"","url":"https://api.github.com/users/Sumukh","html_url":"https://github.com/Sumukh","followers_url":"https://api.github.com/users/Sumukh/followers","following_url":"https://api.github.com/users/Sumukh/following{/other_user}","gists_url":"https://api.github.com/users/Sumukh/gists{/gist_id}","starred_url":"https://api.github.com/users/Sumukh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sumukh/subscriptions","organizations_url":"https://api.github.com/users/Sumukh/orgs","repos_url":"https://api.github.com/users/Sumukh/repos","events_url":"https://api.github.com/users/Sumukh/events{/privacy}","received_events_url":"https://api.github.com/users/Sumukh/received_events","type":"User","site_admin":false},"created_at":"2015-09-27T01:05:32Z","updated_at":"2015-09-27T01:05:32Z","body":"It failed Travis. \n\nI think you have to use ModelProxy in utils. \n\nTraceback (most recent call last):\n  File \"/home/travis/build/Cal-CS-61A-Staff/ok/server/tests/integration/test_utils.py\", line 66, in test_add_subm_to_zip\n    zipfile = utils.add_subm_to_zip(subm, result.__class__, zipfile, result)\n  File \"/home/travis/build/Cal-CS-61A-Staff/ok/server/app/utils.py\", line 567, in add_subm_to_zip\n    if isinstance(submission, FinalSubmission):\nNameError: global name 'FinalSubmission' is not defined\n\n-- \nSumukh Sridhara\n\nOn September 26, 2015 at 6:03:52 PM, Kyle Raftogianis (notifications@github.com) wrote:\n\nThanks for catching it. Can you test?\n\n—\nReply to this email directly or view it on GitHub.\n\n"}}