{"action":"created","comment":{"url":"https://api.github.com/repos/laravel/framework/pulls/comments/32113075","id":32113075,"diff_hunk":"@@ -962,6 +962,10 @@ protected function getSize($attribute, $value)\n      */\n     protected function validateIn($attribute, $value, $parameters)\n     {\n+        if (in_array('array', $this->rules[$attribute]) && is_array($value)) {","path":"src/Illuminate/Validation/Validator.php","position":4,"original_position":4,"commit_id":"2e42bb5c91f1fb93a11c2b0bcb3a9a3515e27258","original_commit_id":"2e42bb5c91f1fb93a11c2b0bcb3a9a3515e27258","user":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?v=3","gravatar_id":"","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"body":"Moving the is_array check first would be faster.\r\n\r\n```php\r\nif (is_array($value) && in_array('array', $this->rules[$attribute])) {\r\n```","created_at":"2015-06-10T12:47:43Z","updated_at":"2015-06-10T12:47:43Z","html_url":"https://github.com/laravel/framework/pull/9182#discussion_r32113075","pull_request_url":"https://api.github.com/repos/laravel/framework/pulls/9182","_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments/32113075"},"html":{"href":"https://github.com/laravel/framework/pull/9182#discussion_r32113075"},"pull_request":{"href":"https://api.github.com/repos/laravel/framework/pulls/9182"}}},"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/9182","id":37349854,"html_url":"https://github.com/laravel/framework/pull/9182","diff_url":"https://github.com/laravel/framework/pull/9182.diff","patch_url":"https://github.com/laravel/framework/pull/9182.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/9182","number":9182,"state":"open","locked":false,"title":"[5.1] Allow validateIn for type array","user":{"login":"Talean-dev","id":8143119,"avatar_url":"https://avatars.githubusercontent.com/u/8143119?v=3","gravatar_id":"","url":"https://api.github.com/users/Talean-dev","html_url":"https://github.com/Talean-dev","followers_url":"https://api.github.com/users/Talean-dev/followers","following_url":"https://api.github.com/users/Talean-dev/following{/other_user}","gists_url":"https://api.github.com/users/Talean-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/Talean-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talean-dev/subscriptions","organizations_url":"https://api.github.com/users/Talean-dev/orgs","repos_url":"https://api.github.com/users/Talean-dev/repos","events_url":"https://api.github.com/users/Talean-dev/events{/privacy}","received_events_url":"https://api.github.com/users/Talean-dev/received_events","type":"User","site_admin":false},"body":"Allow for validation:\r\n\r\n```php\r\n$inputs = [\r\n    'values' => ['one']\r\n];\r\n$rules = [\r\n    'values' => 'required|in:one,two'\r\n];\r\n$v = Validator::make($inputs, $rules);\r\nvar_dump(!$v->fails());\r\n```","created_at":"2015-06-10T11:45:24Z","updated_at":"2015-06-10T12:47:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34a85fa0a0ae994cbd77df48b4fadb490db168e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/9182/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/9182/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/9182/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/2e42bb5c91f1fb93a11c2b0bcb3a9a3515e27258","head":{"label":"Talean-dev:5.1","ref":"5.1","sha":"2e42bb5c91f1fb93a11c2b0bcb3a9a3515e27258","user":{"login":"Talean-dev","id":8143119,"avatar_url":"https://avatars.githubusercontent.com/u/8143119?v=3","gravatar_id":"","url":"https://api.github.com/users/Talean-dev","html_url":"https://github.com/Talean-dev","followers_url":"https://api.github.com/users/Talean-dev/followers","following_url":"https://api.github.com/users/Talean-dev/following{/other_user}","gists_url":"https://api.github.com/users/Talean-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/Talean-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talean-dev/subscriptions","organizations_url":"https://api.github.com/users/Talean-dev/orgs","repos_url":"https://api.github.com/users/Talean-dev/repos","events_url":"https://api.github.com/users/Talean-dev/events{/privacy}","received_events_url":"https://api.github.com/users/Talean-dev/received_events","type":"User","site_admin":false},"repo":{"id":37192312,"name":"framework","full_name":"Talean-dev/framework","owner":{"login":"Talean-dev","id":8143119,"avatar_url":"https://avatars.githubusercontent.com/u/8143119?v=3","gravatar_id":"","url":"https://api.github.com/users/Talean-dev","html_url":"https://github.com/Talean-dev","followers_url":"https://api.github.com/users/Talean-dev/followers","following_url":"https://api.github.com/users/Talean-dev/following{/other_user}","gists_url":"https://api.github.com/users/Talean-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/Talean-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talean-dev/subscriptions","organizations_url":"https://api.github.com/users/Talean-dev/orgs","repos_url":"https://api.github.com/users/Talean-dev/repos","events_url":"https://api.github.com/users/Talean-dev/events{/privacy}","received_events_url":"https://api.github.com/users/Talean-dev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Talean-dev/framework","description":"","fork":true,"url":"https://api.github.com/repos/Talean-dev/framework","forks_url":"https://api.github.com/repos/Talean-dev/framework/forks","keys_url":"https://api.github.com/repos/Talean-dev/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talean-dev/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talean-dev/framework/teams","hooks_url":"https://api.github.com/repos/Talean-dev/framework/hooks","issue_events_url":"https://api.github.com/repos/Talean-dev/framework/issues/events{/number}","events_url":"https://api.github.com/repos/Talean-dev/framework/events","assignees_url":"https://api.github.com/repos/Talean-dev/framework/assignees{/user}","branches_url":"https://api.github.com/repos/Talean-dev/framework/branches{/branch}","tags_url":"https://api.github.com/repos/Talean-dev/framework/tags","blobs_url":"https://api.github.com/repos/Talean-dev/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talean-dev/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talean-dev/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talean-dev/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talean-dev/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/Talean-dev/framework/languages","stargazers_url":"https://api.github.com/repos/Talean-dev/framework/stargazers","contributors_url":"https://api.github.com/repos/Talean-dev/framework/contributors","subscribers_url":"https://api.github.com/repos/Talean-dev/framework/subscribers","subscription_url":"https://api.github.com/repos/Talean-dev/framework/subscription","commits_url":"https://api.github.com/repos/Talean-dev/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talean-dev/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talean-dev/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talean-dev/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talean-dev/framework/contents/{+path}","compare_url":"https://api.github.com/repos/Talean-dev/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talean-dev/framework/merges","archive_url":"https://api.github.com/repos/Talean-dev/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talean-dev/framework/downloads","issues_url":"https://api.github.com/repos/Talean-dev/framework/issues{/number}","pulls_url":"https://api.github.com/repos/Talean-dev/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/Talean-dev/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/Talean-dev/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talean-dev/framework/labels{/name}","releases_url":"https://api.github.com/repos/Talean-dev/framework/releases{/id}","created_at":"2015-06-10T11:07:53Z","updated_at":"2015-06-10T11:07:58Z","pushed_at":"2015-06-10T11:53:50Z","git_url":"git://github.com/Talean-dev/framework.git","ssh_url":"git@github.com:Talean-dev/framework.git","clone_url":"https://github.com/Talean-dev/framework.git","svn_url":"https://github.com/Talean-dev/framework","homepage":"http://laravel.com","size":62552,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.1"}},"base":{"label":"laravel:5.1","ref":"5.1","sha":"3a44db7e70146dc1282b39887b5faa67c8583015","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","created_at":"2013-01-10T21:27:28Z","updated_at":"2015-06-10T11:50:32Z","pushed_at":"2015-06-10T11:53:52Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":62552,"stargazers_count":3701,"watchers_count":3701,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2046,"mirror_url":null,"open_issues_count":66,"forks":2046,"open_issues":66,"watchers":3701,"default_branch":"5.1"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/9182"},"html":{"href":"https://github.com/laravel/framework/pull/9182"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/9182"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/9182/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/9182/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/9182/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/2e42bb5c91f1fb93a11c2b0bcb3a9a3515e27258"}}}}