{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/28735295","id":28735295,"diff_hunk":"@@ -0,0 +1,214 @@\n+import {Promise, PromiseWrapper} from 'angular2/src/facade/async';\n+import {Map, MapWrapper, List, ListWrapper} from 'angular2/src/facade/collection';\n+import {isBlank} from 'angular2/src/facade/lang';\n+\n+import {RouteRegistry} from './route_registry';\n+import {noopInstruction} from './instruction';\n+import {Pipeline} from './pipeline';\n+import {Instruction} from './instruction';\n+import {OutletRef} from './outlet_ref';\n+\n+/**\n+ * # Router\n+ * The router is responsible for mapping URLs to components.\n+ *\n+ * You can see the state of the router by inspecting the read-only field `router.navigating`.\n+ * This may be useful for showing a spinner, for instance.\n+ *\n+ * @exportedAs angular2/router","path":"modules/angular2/src/router/router.js","position":18,"original_position":18,"commit_id":"ff0694f56fbc284f85ac16f13286814d165c9b40","original_commit_id":"ff0694f56fbc284f85ac16f13286814d165c9b40","user":{"login":"mhevery","id":111951,"avatar_url":"https://avatars.githubusercontent.com/u/111951?v=3","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"body":"all public API should have `@exportedAs angular2/router` I think whole bunch of classes are public, have no docs and are not marked as public.","created_at":"2015-04-20T22:19:59Z","updated_at":"2015-04-20T22:19:59Z","html_url":"https://github.com/angular/angular/pull/1281#discussion_r28735295","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/1281","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/28735295"},"html":{"href":"https://github.com/angular/angular/pull/1281#discussion_r28735295"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/1281"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/1281","id":32998906,"html_url":"https://github.com/angular/angular/pull/1281","diff_url":"https://github.com/angular/angular/pull/1281.diff","patch_url":"https://github.com/angular/angular/pull/1281.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/1281","number":1281,"state":"open","locked":false,"title":"feat: new router [do not merge (yet)]","user":{"login":"btford","id":474988,"avatar_url":"https://avatars.githubusercontent.com/u/474988?v=3","gravatar_id":"","url":"https://api.github.com/users/btford","html_url":"https://github.com/btford","followers_url":"https://api.github.com/users/btford/followers","following_url":"https://api.github.com/users/btford/following{/other_user}","gists_url":"https://api.github.com/users/btford/gists{/gist_id}","starred_url":"https://api.github.com/users/btford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btford/subscriptions","organizations_url":"https://api.github.com/users/btford/orgs","repos_url":"https://api.github.com/users/btford/repos","events_url":"https://api.github.com/users/btford/events{/privacy}","received_events_url":"https://api.github.com/users/btford/received_events","type":"User","site_admin":false},"body":"~~~This is still WIP and pends on #1261, which needs to be rebased on top of @tbosch's changes that landed last night.~~~\r\n\r\nThis is pretty much good to go. Needs some cleanup and review, but otherwise should be pretty okay.\r\n\r\nCloses #618","created_at":"2015-04-09T21:37:08Z","updated_at":"2015-04-20T22:19:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c42f1782355ff1b8f9d9ba0b346d81c0a9e455ed","assignee":null,"milestone":{"url":"https://api.github.com/repos/angular/angular/milestones/21","html_url":"https://github.com/angular/angular/milestones/M7:%20GT%20Customer%20(blocking)","labels_url":"https://api.github.com/repos/angular/angular/milestones/21/labels","id":1036683,"number":21,"title":"M7: GT Customer (blocking)","description":"","creator":{"login":"mhevery","id":111951,"avatar_url":"https://avatars.githubusercontent.com/u/111951?v=3","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":42,"state":"open","created_at":"2015-03-24T16:31:29Z","updated_at":"2015-04-18T06:12:58Z","due_on":"2015-04-11T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/angular/angular/pulls/1281/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/1281/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/1281/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/ff0694f56fbc284f85ac16f13286814d165c9b40","head":{"label":"btford:feat-new-router","ref":"feat-new-router","sha":"ff0694f56fbc284f85ac16f13286814d165c9b40","user":{"login":"btford","id":474988,"avatar_url":"https://avatars.githubusercontent.com/u/474988?v=3","gravatar_id":"","url":"https://api.github.com/users/btford","html_url":"https://github.com/btford","followers_url":"https://api.github.com/users/btford/followers","following_url":"https://api.github.com/users/btford/following{/other_user}","gists_url":"https://api.github.com/users/btford/gists{/gist_id}","starred_url":"https://api.github.com/users/btford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btford/subscriptions","organizations_url":"https://api.github.com/users/btford/orgs","repos_url":"https://api.github.com/users/btford/repos","events_url":"https://api.github.com/users/btford/events{/privacy}","received_events_url":"https://api.github.com/users/btford/received_events","type":"User","site_admin":false},"repo":{"id":28889554,"name":"angular","full_name":"btford/angular","owner":{"login":"btford","id":474988,"avatar_url":"https://avatars.githubusercontent.com/u/474988?v=3","gravatar_id":"","url":"https://api.github.com/users/btford","html_url":"https://github.com/btford","followers_url":"https://api.github.com/users/btford/followers","following_url":"https://api.github.com/users/btford/following{/other_user}","gists_url":"https://api.github.com/users/btford/gists{/gist_id}","starred_url":"https://api.github.com/users/btford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btford/subscriptions","organizations_url":"https://api.github.com/users/btford/orgs","repos_url":"https://api.github.com/users/btford/repos","events_url":"https://api.github.com/users/btford/events{/privacy}","received_events_url":"https://api.github.com/users/btford/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/btford/angular","description":"","fork":true,"url":"https://api.github.com/repos/btford/angular","forks_url":"https://api.github.com/repos/btford/angular/forks","keys_url":"https://api.github.com/repos/btford/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/btford/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/btford/angular/teams","hooks_url":"https://api.github.com/repos/btford/angular/hooks","issue_events_url":"https://api.github.com/repos/btford/angular/issues/events{/number}","events_url":"https://api.github.com/repos/btford/angular/events","assignees_url":"https://api.github.com/repos/btford/angular/assignees{/user}","branches_url":"https://api.github.com/repos/btford/angular/branches{/branch}","tags_url":"https://api.github.com/repos/btford/angular/tags","blobs_url":"https://api.github.com/repos/btford/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/btford/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/btford/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/btford/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/btford/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/btford/angular/languages","stargazers_url":"https://api.github.com/repos/btford/angular/stargazers","contributors_url":"https://api.github.com/repos/btford/angular/contributors","subscribers_url":"https://api.github.com/repos/btford/angular/subscribers","subscription_url":"https://api.github.com/repos/btford/angular/subscription","commits_url":"https://api.github.com/repos/btford/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/btford/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/btford/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/btford/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/btford/angular/contents/{+path}","compare_url":"https://api.github.com/repos/btford/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/btford/angular/merges","archive_url":"https://api.github.com/repos/btford/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/btford/angular/downloads","issues_url":"https://api.github.com/repos/btford/angular/issues{/number}","pulls_url":"https://api.github.com/repos/btford/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/btford/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/btford/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/btford/angular/labels{/name}","releases_url":"https://api.github.com/repos/btford/angular/releases{/id}","created_at":"2015-01-07T00:00:47Z","updated_at":"2015-01-07T00:00:48Z","pushed_at":"2015-04-20T08:33:10Z","git_url":"git://github.com/btford/angular.git","ssh_url":"git@github.com:btford/angular.git","clone_url":"https://github.com/btford/angular.git","svn_url":"https://github.com/btford/angular","homepage":null,"size":4463,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"56f3429cc90347081a0fd78c1bd6de44eaac23c1","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","created_at":"2014-09-18T16:12:01Z","updated_at":"2015-04-20T22:13:14Z","pushed_at":"2015-04-20T22:13:14Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":null,"size":18852,"stargazers_count":2598,"watchers_count":2598,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":642,"mirror_url":null,"open_issues_count":258,"forks":642,"open_issues":258,"watchers":2598,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/1281"},"html":{"href":"https://github.com/angular/angular/pull/1281"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/1281"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/1281/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/1281/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/1281/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/ff0694f56fbc284f85ac16f13286814d165c9b40"}}}}