{"action":"created","comment":{"url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/comments/39512653","id":39512653,"diff_hunk":"@@ -247,20 +320,18 @@ define( [\n         }\n     };\n \n-\n+    // default means you do use the special optimized full screen triangle\n+    // dubbed fakeFullscreenQuad\n+    // no need of modelView, projection, nor texcoord\n     Composer.Filter.defaultVertexShader = [\n         'attribute vec3 Vertex;',\n-        'attribute vec2 TexCoord0;',\n         'varying vec2 FragTexCoord0;',\n-        'uniform mat4 ModelViewMatrix;',\n-        'uniform mat4 ProjectionMatrix;',\n         'void main(void) {',\n-        '  gl_Position = ProjectionMatrix * ModelViewMatrix * vec4(Vertex,1.0);',\n-        '  FragTexCoord0 = TexCoord0;',\n+        '  gl_Position = vec4(Vertex*2.0 - 1.0,1.0);',","path":"sources/osgUtil/Composer.js","position":237,"original_position":237,"commit_id":"6d550968014b51b9b29ea25b083ef889520a0089","original_commit_id":"a6b7426f3931ccd181a3c205650422451daa4320","user":{"login":"Kuranes","id":128571,"avatar_url":"https://avatars.githubusercontent.com/u/128571?v=3","gravatar_id":"","url":"https://api.github.com/users/Kuranes","html_url":"https://github.com/Kuranes","followers_url":"https://api.github.com/users/Kuranes/followers","following_url":"https://api.github.com/users/Kuranes/following{/other_user}","gists_url":"https://api.github.com/users/Kuranes/gists{/gist_id}","starred_url":"https://api.github.com/users/Kuranes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kuranes/subscriptions","organizations_url":"https://api.github.com/users/Kuranes/orgs","repos_url":"https://api.github.com/users/Kuranes/repos","events_url":"https://api.github.com/users/Kuranes/events{/privacy}","received_events_url":"https://api.github.com/users/Kuranes/received_events","type":"User","site_admin":false},"body":"need a PR to export all glsl code in glsl files + a PR for splitting composer into composer.js filter.js + ilters/custom.js filters/blur.js etc","created_at":"2015-09-15T13:59:58Z","updated_at":"2015-09-15T13:59:58Z","html_url":"https://github.com/cedricpinson/osgjs/pull/410#discussion_r39512653","pull_request_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/410","_links":{"self":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/comments/39512653"},"html":{"href":"https://github.com/cedricpinson/osgjs/pull/410#discussion_r39512653"},"pull_request":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/410"}}},"pull_request":{"url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/410","id":42254313,"html_url":"https://github.com/cedricpinson/osgjs/pull/410","diff_url":"https://github.com/cedricpinson/osgjs/pull/410.diff","patch_url":"https://github.com/cedricpinson/osgjs/pull/410.patch","issue_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/410","number":410,"state":"open","locked":false,"title":"[#97603894] Feature/compiler projectionmatrix override","user":{"login":"Kuranes","id":128571,"avatar_url":"https://avatars.githubusercontent.com/u/128571?v=3","gravatar_id":"","url":"https://api.github.com/users/Kuranes","html_url":"https://github.com/Kuranes","followers_url":"https://api.github.com/users/Kuranes/followers","following_url":"https://api.github.com/users/Kuranes/following{/other_user}","gists_url":"https://api.github.com/users/Kuranes/gists{/gist_id}","starred_url":"https://api.github.com/users/Kuranes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kuranes/subscriptions","organizations_url":"https://api.github.com/users/Kuranes/orgs","repos_url":"https://api.github.com/users/Kuranes/repos","events_url":"https://api.github.com/users/Kuranes/events{/privacy}","received_events_url":"https://api.github.com/users/Kuranes/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-12T15:39:23Z","updated_at":"2015-09-15T13:59:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27052f2e1037d41359824179db43381a43fc91c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/410/commits","review_comments_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/410/comments","review_comment_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/410/comments","statuses_url":"https://api.github.com/repos/cedricpinson/osgjs/statuses/6d550968014b51b9b29ea25b083ef889520a0089","head":{"label":"cedricpinson:feature/compiler-projectionmatrix-override","ref":"feature/compiler-projectionmatrix-override","sha":"6d550968014b51b9b29ea25b083ef889520a0089","user":{"login":"cedricpinson","id":351686,"avatar_url":"https://avatars.githubusercontent.com/u/351686?v=3","gravatar_id":"","url":"https://api.github.com/users/cedricpinson","html_url":"https://github.com/cedricpinson","followers_url":"https://api.github.com/users/cedricpinson/followers","following_url":"https://api.github.com/users/cedricpinson/following{/other_user}","gists_url":"https://api.github.com/users/cedricpinson/gists{/gist_id}","starred_url":"https://api.github.com/users/cedricpinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedricpinson/subscriptions","organizations_url":"https://api.github.com/users/cedricpinson/orgs","repos_url":"https://api.github.com/users/cedricpinson/repos","events_url":"https://api.github.com/users/cedricpinson/events{/privacy}","received_events_url":"https://api.github.com/users/cedricpinson/received_events","type":"User","site_admin":false},"repo":{"id":1675632,"name":"osgjs","full_name":"cedricpinson/osgjs","owner":{"login":"cedricpinson","id":351686,"avatar_url":"https://avatars.githubusercontent.com/u/351686?v=3","gravatar_id":"","url":"https://api.github.com/users/cedricpinson","html_url":"https://github.com/cedricpinson","followers_url":"https://api.github.com/users/cedricpinson/followers","following_url":"https://api.github.com/users/cedricpinson/following{/other_user}","gists_url":"https://api.github.com/users/cedricpinson/gists{/gist_id}","starred_url":"https://api.github.com/users/cedricpinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedricpinson/subscriptions","organizations_url":"https://api.github.com/users/cedricpinson/orgs","repos_url":"https://api.github.com/users/cedricpinson/repos","events_url":"https://api.github.com/users/cedricpinson/events{/privacy}","received_events_url":"https://api.github.com/users/cedricpinson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cedricpinson/osgjs","description":"Javascript Implementation of OpenSceneGraph","fork":false,"url":"https://api.github.com/repos/cedricpinson/osgjs","forks_url":"https://api.github.com/repos/cedricpinson/osgjs/forks","keys_url":"https://api.github.com/repos/cedricpinson/osgjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cedricpinson/osgjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cedricpinson/osgjs/teams","hooks_url":"https://api.github.com/repos/cedricpinson/osgjs/hooks","issue_events_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/events{/number}","events_url":"https://api.github.com/repos/cedricpinson/osgjs/events","assignees_url":"https://api.github.com/repos/cedricpinson/osgjs/assignees{/user}","branches_url":"https://api.github.com/repos/cedricpinson/osgjs/branches{/branch}","tags_url":"https://api.github.com/repos/cedricpinson/osgjs/tags","blobs_url":"https://api.github.com/repos/cedricpinson/osgjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cedricpinson/osgjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cedricpinson/osgjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cedricpinson/osgjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cedricpinson/osgjs/statuses/{sha}","languages_url":"https://api.github.com/repos/cedricpinson/osgjs/languages","stargazers_url":"https://api.github.com/repos/cedricpinson/osgjs/stargazers","contributors_url":"https://api.github.com/repos/cedricpinson/osgjs/contributors","subscribers_url":"https://api.github.com/repos/cedricpinson/osgjs/subscribers","subscription_url":"https://api.github.com/repos/cedricpinson/osgjs/subscription","commits_url":"https://api.github.com/repos/cedricpinson/osgjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cedricpinson/osgjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cedricpinson/osgjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/cedricpinson/osgjs/contents/{+path}","compare_url":"https://api.github.com/repos/cedricpinson/osgjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cedricpinson/osgjs/merges","archive_url":"https://api.github.com/repos/cedricpinson/osgjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cedricpinson/osgjs/downloads","issues_url":"https://api.github.com/repos/cedricpinson/osgjs/issues{/number}","pulls_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls{/number}","milestones_url":"https://api.github.com/repos/cedricpinson/osgjs/milestones{/number}","notifications_url":"https://api.github.com/repos/cedricpinson/osgjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cedricpinson/osgjs/labels{/name}","releases_url":"https://api.github.com/repos/cedricpinson/osgjs/releases{/id}","created_at":"2011-04-28T12:36:33Z","updated_at":"2015-09-08T15:55:23Z","pushed_at":"2015-09-15T13:54:42Z","git_url":"git://github.com/cedricpinson/osgjs.git","ssh_url":"git@github.com:cedricpinson/osgjs.git","clone_url":"https://github.com/cedricpinson/osgjs.git","svn_url":"https://github.com/cedricpinson/osgjs","homepage":"http://osgjs.org","size":217910,"stargazers_count":234,"watchers_count":234,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":54,"mirror_url":null,"open_issues_count":24,"forks":54,"open_issues":24,"watchers":234,"default_branch":"develop"}},"base":{"label":"cedricpinson:develop","ref":"develop","sha":"760e1c3dea9be45f7feddeeee7705f90a708d350","user":{"login":"cedricpinson","id":351686,"avatar_url":"https://avatars.githubusercontent.com/u/351686?v=3","gravatar_id":"","url":"https://api.github.com/users/cedricpinson","html_url":"https://github.com/cedricpinson","followers_url":"https://api.github.com/users/cedricpinson/followers","following_url":"https://api.github.com/users/cedricpinson/following{/other_user}","gists_url":"https://api.github.com/users/cedricpinson/gists{/gist_id}","starred_url":"https://api.github.com/users/cedricpinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedricpinson/subscriptions","organizations_url":"https://api.github.com/users/cedricpinson/orgs","repos_url":"https://api.github.com/users/cedricpinson/repos","events_url":"https://api.github.com/users/cedricpinson/events{/privacy}","received_events_url":"https://api.github.com/users/cedricpinson/received_events","type":"User","site_admin":false},"repo":{"id":1675632,"name":"osgjs","full_name":"cedricpinson/osgjs","owner":{"login":"cedricpinson","id":351686,"avatar_url":"https://avatars.githubusercontent.com/u/351686?v=3","gravatar_id":"","url":"https://api.github.com/users/cedricpinson","html_url":"https://github.com/cedricpinson","followers_url":"https://api.github.com/users/cedricpinson/followers","following_url":"https://api.github.com/users/cedricpinson/following{/other_user}","gists_url":"https://api.github.com/users/cedricpinson/gists{/gist_id}","starred_url":"https://api.github.com/users/cedricpinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedricpinson/subscriptions","organizations_url":"https://api.github.com/users/cedricpinson/orgs","repos_url":"https://api.github.com/users/cedricpinson/repos","events_url":"https://api.github.com/users/cedricpinson/events{/privacy}","received_events_url":"https://api.github.com/users/cedricpinson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cedricpinson/osgjs","description":"Javascript Implementation of OpenSceneGraph","fork":false,"url":"https://api.github.com/repos/cedricpinson/osgjs","forks_url":"https://api.github.com/repos/cedricpinson/osgjs/forks","keys_url":"https://api.github.com/repos/cedricpinson/osgjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cedricpinson/osgjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cedricpinson/osgjs/teams","hooks_url":"https://api.github.com/repos/cedricpinson/osgjs/hooks","issue_events_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/events{/number}","events_url":"https://api.github.com/repos/cedricpinson/osgjs/events","assignees_url":"https://api.github.com/repos/cedricpinson/osgjs/assignees{/user}","branches_url":"https://api.github.com/repos/cedricpinson/osgjs/branches{/branch}","tags_url":"https://api.github.com/repos/cedricpinson/osgjs/tags","blobs_url":"https://api.github.com/repos/cedricpinson/osgjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cedricpinson/osgjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cedricpinson/osgjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cedricpinson/osgjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cedricpinson/osgjs/statuses/{sha}","languages_url":"https://api.github.com/repos/cedricpinson/osgjs/languages","stargazers_url":"https://api.github.com/repos/cedricpinson/osgjs/stargazers","contributors_url":"https://api.github.com/repos/cedricpinson/osgjs/contributors","subscribers_url":"https://api.github.com/repos/cedricpinson/osgjs/subscribers","subscription_url":"https://api.github.com/repos/cedricpinson/osgjs/subscription","commits_url":"https://api.github.com/repos/cedricpinson/osgjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cedricpinson/osgjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cedricpinson/osgjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/cedricpinson/osgjs/contents/{+path}","compare_url":"https://api.github.com/repos/cedricpinson/osgjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cedricpinson/osgjs/merges","archive_url":"https://api.github.com/repos/cedricpinson/osgjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cedricpinson/osgjs/downloads","issues_url":"https://api.github.com/repos/cedricpinson/osgjs/issues{/number}","pulls_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls{/number}","milestones_url":"https://api.github.com/repos/cedricpinson/osgjs/milestones{/number}","notifications_url":"https://api.github.com/repos/cedricpinson/osgjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cedricpinson/osgjs/labels{/name}","releases_url":"https://api.github.com/repos/cedricpinson/osgjs/releases{/id}","created_at":"2011-04-28T12:36:33Z","updated_at":"2015-09-08T15:55:23Z","pushed_at":"2015-09-15T13:54:42Z","git_url":"git://github.com/cedricpinson/osgjs.git","ssh_url":"git@github.com:cedricpinson/osgjs.git","clone_url":"https://github.com/cedricpinson/osgjs.git","svn_url":"https://github.com/cedricpinson/osgjs","homepage":"http://osgjs.org","size":217910,"stargazers_count":234,"watchers_count":234,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":54,"mirror_url":null,"open_issues_count":24,"forks":54,"open_issues":24,"watchers":234,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/410"},"html":{"href":"https://github.com/cedricpinson/osgjs/pull/410"},"issue":{"href":"https://api.github.com/repos/cedricpinson/osgjs/issues/410"},"comments":{"href":"https://api.github.com/repos/cedricpinson/osgjs/issues/410/comments"},"review_comments":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/410/comments"},"review_comment":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/410/commits"},"statuses":{"href":"https://api.github.com/repos/cedricpinson/osgjs/statuses/6d550968014b51b9b29ea25b083ef889520a0089"}}}}