{"action":"created","issue":{"url":"https://api.github.com/repos/sandia-minimega/minimega/issues/209","labels_url":"https://api.github.com/repos/sandia-minimega/minimega/issues/209/labels{/name}","comments_url":"https://api.github.com/repos/sandia-minimega/minimega/issues/209/comments","events_url":"https://api.github.com/repos/sandia-minimega/minimega/issues/209/events","html_url":"https://github.com/sandia-minimega/minimega/issues/209","id":77728703,"number":209,"title":"minimega: at least one dangling kvm process on entering VM_ERROR state","user":{"login":"djfritz","id":4811604,"avatar_url":"https://avatars.githubusercontent.com/u/4811604?v=3","gravatar_id":"","url":"https://api.github.com/users/djfritz","html_url":"https://github.com/djfritz","followers_url":"https://api.github.com/users/djfritz/followers","following_url":"https://api.github.com/users/djfritz/following{/other_user}","gists_url":"https://api.github.com/users/djfritz/gists{/gist_id}","starred_url":"https://api.github.com/users/djfritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djfritz/subscriptions","organizations_url":"https://api.github.com/users/djfritz/orgs","repos_url":"https://api.github.com/users/djfritz/repos","events_url":"https://api.github.com/users/djfritz/events{/privacy}","received_events_url":"https://api.github.com/users/djfritz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sandia-minimega/minimega/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/sandia-minimega/minimega/labels/help%20wanted","name":"help wanted","color":"159818"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/sandia-minimega/minimega/milestones/2","html_url":"https://github.com/sandia-minimega/minimega/milestones/2.1","labels_url":"https://api.github.com/repos/sandia-minimega/minimega/milestones/2/labels","id":1037006,"number":2,"title":"2.1","description":"","creator":{"login":"djfritz","id":4811604,"avatar_url":"https://avatars.githubusercontent.com/u/4811604?v=3","gravatar_id":"","url":"https://api.github.com/users/djfritz","html_url":"https://github.com/djfritz","followers_url":"https://api.github.com/users/djfritz/followers","following_url":"https://api.github.com/users/djfritz/following{/other_user}","gists_url":"https://api.github.com/users/djfritz/gists{/gist_id}","starred_url":"https://api.github.com/users/djfritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djfritz/subscriptions","organizations_url":"https://api.github.com/users/djfritz/orgs","repos_url":"https://api.github.com/users/djfritz/repos","events_url":"https://api.github.com/users/djfritz/events{/privacy}","received_events_url":"https://api.github.com/users/djfritz/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":16,"state":"open","created_at":"2015-03-24T19:17:30Z","updated_at":"2015-07-13T19:06:40Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-05-18T17:02:45Z","updated_at":"2015-07-13T20:51:12Z","closed_at":null,"body":"If you hit the race:\r\n\r\nvm launch foo noblock\r\nvm start foo\r\n\r\nAnd get the VM into the error state with the 'qmp not ready' error, you'll notice that qemu for that VM is still running, because vm.start() didn't kill the process after putting it in the error state. Later, vm kill won't attempt to kill it because it's in the error state.\r\n\r\nAt least two things could happen here instead:\r\n\r\n* Attempt to reissue commands on error VMs that aren't actually dead - like 'vm start'. That would require some more book keeping\r\n* Always kill VMs when they enter the error state"},"comment":{"url":"https://api.github.com/repos/sandia-minimega/minimega/issues/comments/121055033","html_url":"https://github.com/sandia-minimega/minimega/issues/209#issuecomment-121055033","issue_url":"https://api.github.com/repos/sandia-minimega/minimega/issues/209","id":121055033,"user":{"login":"djfritz","id":4811604,"avatar_url":"https://avatars.githubusercontent.com/u/4811604?v=3","gravatar_id":"","url":"https://api.github.com/users/djfritz","html_url":"https://github.com/djfritz","followers_url":"https://api.github.com/users/djfritz/followers","following_url":"https://api.github.com/users/djfritz/following{/other_user}","gists_url":"https://api.github.com/users/djfritz/gists{/gist_id}","starred_url":"https://api.github.com/users/djfritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djfritz/subscriptions","organizations_url":"https://api.github.com/users/djfritz/orgs","repos_url":"https://api.github.com/users/djfritz/repos","events_url":"https://api.github.com/users/djfritz/events{/privacy}","received_events_url":"https://api.github.com/users/djfritz/received_events","type":"User","site_admin":false},"created_at":"2015-07-13T20:51:12Z","updated_at":"2015-07-13T20:51:12Z","body":"That's an ideal solution. My VM launch code may not tolerate holding the lock in that big of a block (depending on how much of the launch code/preamble you've rewritten), so it may require a touch of refactoring. "}}