{"action":"closed","issue":{"url":"https://api.github.com/repos/dwinter/dfe/issues/4","labels_url":"https://api.github.com/repos/dwinter/dfe/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/dwinter/dfe/issues/4/comments","events_url":"https://api.github.com/repos/dwinter/dfe/issues/4/events","html_url":"https://github.com/dwinter/dfe/issues/4","id":51598069,"number":4,"title":"Consistent ordering / naming of arguments","user":{"login":"dwinter","id":103573,"avatar_url":"https://avatars.githubusercontent.com/u/103573?v=3","gravatar_id":"","url":"https://api.github.com/users/dwinter","html_url":"https://github.com/dwinter","followers_url":"https://api.github.com/users/dwinter/followers","following_url":"https://api.github.com/users/dwinter/following{/other_user}","gists_url":"https://api.github.com/users/dwinter/gists{/gist_id}","starred_url":"https://api.github.com/users/dwinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwinter/subscriptions","organizations_url":"https://api.github.com/users/dwinter/orgs","repos_url":"https://api.github.com/users/dwinter/repos","events_url":"https://api.github.com/users/dwinter/events{/privacy}","received_events_url":"https://api.github.com/users/dwinter/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dwinter/dfe/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2014-12-10T19:11:38Z","updated_at":"2015-02-02T21:56:48Z","closed_at":"2015-02-02T21:56:48Z","body":"All functions relating to` DFEs`, including the internal functions. should  have a consistent ordering of arguments, and the arugments should clear names. \r\n\r\nAt present the rate parameter of the Gamma is variously called `Beta` or `B` and the shape is called `a`. These should all be replaced by `rate` and `shape` to make their meaning clear. The  mean of the normal distribution is called `s`, which we should repalce with `mean_effect`.\r\n\r\nIn terms of odering of arguments, and idealised function would look like this:\r\n\r\n````r\r\nf <- function(n, shape, rate, Ve, Ut, [misc. args like log/verbose){\r\n    ...\r\n}\r\n```"}}