{"action":"created","issue":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/1847","labels_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/1847/labels{/name}","comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/1847/comments","events_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/1847/events","html_url":"https://github.com/syl20bnr/spacemacs/pull/1847","id":84998694,"number":1847,"title":"add option to use pytest instead of nose for python testing","user":{"login":"cpaulik","id":380927,"avatar_url":"https://avatars.githubusercontent.com/u/380927?v=3","gravatar_id":"","url":"https://api.github.com/users/cpaulik","html_url":"https://github.com/cpaulik","followers_url":"https://api.github.com/users/cpaulik/followers","following_url":"https://api.github.com/users/cpaulik/following{/other_user}","gists_url":"https://api.github.com/users/cpaulik/gists{/gist_id}","starred_url":"https://api.github.com/users/cpaulik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpaulik/subscriptions","organizations_url":"https://api.github.com/users/cpaulik/orgs","repos_url":"https://api.github.com/users/cpaulik/repos","events_url":"https://api.github.com/users/cpaulik/events{/privacy}","received_events_url":"https://api.github.com/users/cpaulik/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-04T09:17:17Z","updated_at":"2015-06-08T05:31:59Z","closed_at":"2015-06-08T05:31:59Z","pull_request":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/1847","html_url":"https://github.com/syl20bnr/spacemacs/pull/1847","diff_url":"https://github.com/syl20bnr/spacemacs/pull/1847.diff","patch_url":"https://github.com/syl20bnr/spacemacs/pull/1847.patch"},"body":"pytest became available in MELPA a few hours ago. \r\n\r\nI personally prefer it over nose and have some projects that only work with it so I thought it is time to make this an option in spacemacs.\r\n\r\nRegarding the implementation:\r\n\r\nI've seen this in a few layers now that the configuration variables should be added in `dotspacemacs/init` instead at the `:variables` keyword. Is there a preferred way?"},"comment":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/comments/109867120","html_url":"https://github.com/syl20bnr/spacemacs/pull/1847#issuecomment-109867120","issue_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/1847","id":109867120,"user":{"login":"syl20bnr","id":1243537,"avatar_url":"https://avatars.githubusercontent.com/u/1243537?v=3","gravatar_id":"","url":"https://api.github.com/users/syl20bnr","html_url":"https://github.com/syl20bnr","followers_url":"https://api.github.com/users/syl20bnr/followers","following_url":"https://api.github.com/users/syl20bnr/following{/other_user}","gists_url":"https://api.github.com/users/syl20bnr/gists{/gist_id}","starred_url":"https://api.github.com/users/syl20bnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syl20bnr/subscriptions","organizations_url":"https://api.github.com/users/syl20bnr/orgs","repos_url":"https://api.github.com/users/syl20bnr/repos","events_url":"https://api.github.com/users/syl20bnr/events{/privacy}","received_events_url":"https://api.github.com/users/syl20bnr/received_events","type":"User","site_admin":false},"created_at":"2015-06-08T05:31:59Z","updated_at":"2015-06-08T05:31:59Z","body":"Excellent PR :heart:\r\nIn general the layer variables (that is the variable we invent in spacemacs layers) are defined with the `:variables` keyword to keep them near the layer declaration.\r\nI made some modification to this PR to replace your variable by a variable named `python-test-runner` (I hope it does not clash) which takes the values `nose` or `pytest`. If `pytest` is more used than `nose` we should consider to set `pytest` as default. Related commit: https://github.com/syl20bnr/spacemacs/commit/d1ecbfa\r\n\r\nCherry-picked into `develop` branch, you can safely delete your branch."}}