{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/eigen/pulls/comments/29249937","id":29249937,"diff_hunk":"@@ -1,7 +1,9 @@\n #import \"TSMiniWebBrowser.h\"\n \n-@interface ARExternalWebBrowserViewController : TSMiniWebBrowser\n+@protocol ARWebViewControllerScrollDelegate","path":"Artsy/Classes/View Controllers/ARExternalWebBrowserViewController.h","position":4,"original_position":4,"commit_id":"135b068bcc0bdbae543115f9106a34810af6adfb","original_commit_id":"135b068bcc0bdbae543115f9106a34810af6adfb","user":{"login":"1aurabrown","id":3171662,"avatar_url":"https://avatars.githubusercontent.com/u/3171662?v=3","gravatar_id":"","url":"https://api.github.com/users/1aurabrown","html_url":"https://github.com/1aurabrown","followers_url":"https://api.github.com/users/1aurabrown/followers","following_url":"https://api.github.com/users/1aurabrown/following{/other_user}","gists_url":"https://api.github.com/users/1aurabrown/gists{/gist_id}","starred_url":"https://api.github.com/users/1aurabrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1aurabrown/subscriptions","organizations_url":"https://api.github.com/users/1aurabrown/orgs","repos_url":"https://api.github.com/users/1aurabrown/repos","events_url":"https://api.github.com/users/1aurabrown/events{/privacy}","received_events_url":"https://api.github.com/users/1aurabrown/received_events","type":"User","site_admin":false},"body":"thats basically the inverse of what i did -- that's a property on the scroll chief that gets its scrollviewdidscrol method called when the scroll chief is done handling scroll. i'm not sure exactly how that works -- the scroll chief is a singleton and can only have one object as this property at any given time. so what do we do? just keep resetting that property of the scroll chief?","created_at":"2015-04-28T14:49:21Z","updated_at":"2015-04-28T14:49:21Z","html_url":"https://github.com/artsy/eigen/pull/404#discussion_r29249937","pull_request_url":"https://api.github.com/repos/artsy/eigen/pulls/404","_links":{"self":{"href":"https://api.github.com/repos/artsy/eigen/pulls/comments/29249937"},"html":{"href":"https://github.com/artsy/eigen/pull/404#discussion_r29249937"},"pull_request":{"href":"https://api.github.com/repos/artsy/eigen/pulls/404"}}},"pull_request":{"url":"https://api.github.com/repos/artsy/eigen/pulls/404","id":34224186,"html_url":"https://github.com/artsy/eigen/pull/404","diff_url":"https://github.com/artsy/eigen/pull/404.diff","patch_url":"https://github.com/artsy/eigen/pull/404.patch","issue_url":"https://api.github.com/repos/artsy/eigen/issues/404","number":404,"state":"open","locked":false,"title":"@orta -> suppress internal webview zoom","user":{"login":"1aurabrown","id":3171662,"avatar_url":"https://avatars.githubusercontent.com/u/3171662?v=3","gravatar_id":"","url":"https://api.github.com/users/1aurabrown","html_url":"https://github.com/1aurabrown","followers_url":"https://api.github.com/users/1aurabrown/followers","following_url":"https://api.github.com/users/1aurabrown/following{/other_user}","gists_url":"https://api.github.com/users/1aurabrown/gists{/gist_id}","starred_url":"https://api.github.com/users/1aurabrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1aurabrown/subscriptions","organizations_url":"https://api.github.com/users/1aurabrown/orgs","repos_url":"https://api.github.com/users/1aurabrown/repos","events_url":"https://api.github.com/users/1aurabrown/events{/privacy}","received_events_url":"https://api.github.com/users/1aurabrown/received_events","type":"User","site_admin":false},"body":"fixes https://github.com/artsy/eigen/issues/392\r\n\r\nPreviously I thought I'd solved this problem, but I actually hadn't. we were trying to set the web view's scroll view's delegate to two different objects -- the scroll chief to handle scrolling and the vc to handle suppressing zoom.\r\n\r\nI also looked at a test that I've seen failing intermittently and re-wrote the whole spec.","created_at":"2015-04-28T00:37:31Z","updated_at":"2015-04-28T14:49:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"787ba09e1e3e25bd40726ed6a833415f114032b5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/artsy/eigen/pulls/404/commits","review_comments_url":"https://api.github.com/repos/artsy/eigen/pulls/404/comments","review_comment_url":"https://api.github.com/repos/artsy/eigen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/eigen/issues/404/comments","statuses_url":"https://api.github.com/repos/artsy/eigen/statuses/135b068bcc0bdbae543115f9106a34810af6adfb","head":{"label":"artsy:webview-zoom","ref":"webview-zoom","sha":"135b068bcc0bdbae543115f9106a34810af6adfb","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":29702213,"name":"eigen","full_name":"artsy/eigen","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/eigen","description":"The Art World in Your Pocket, Artsy's iOS app.","fork":false,"url":"https://api.github.com/repos/artsy/eigen","forks_url":"https://api.github.com/repos/artsy/eigen/forks","keys_url":"https://api.github.com/repos/artsy/eigen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/eigen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/eigen/teams","hooks_url":"https://api.github.com/repos/artsy/eigen/hooks","issue_events_url":"https://api.github.com/repos/artsy/eigen/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/eigen/events","assignees_url":"https://api.github.com/repos/artsy/eigen/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/eigen/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/eigen/tags","blobs_url":"https://api.github.com/repos/artsy/eigen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/eigen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/eigen/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/eigen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/eigen/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/eigen/languages","stargazers_url":"https://api.github.com/repos/artsy/eigen/stargazers","contributors_url":"https://api.github.com/repos/artsy/eigen/contributors","subscribers_url":"https://api.github.com/repos/artsy/eigen/subscribers","subscription_url":"https://api.github.com/repos/artsy/eigen/subscription","commits_url":"https://api.github.com/repos/artsy/eigen/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/eigen/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/eigen/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/eigen/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/eigen/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/eigen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/eigen/merges","archive_url":"https://api.github.com/repos/artsy/eigen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/eigen/downloads","issues_url":"https://api.github.com/repos/artsy/eigen/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/eigen/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/eigen/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/eigen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/eigen/labels{/name}","releases_url":"https://api.github.com/repos/artsy/eigen/releases{/id}","created_at":"2015-01-22T21:52:39Z","updated_at":"2015-04-28T13:10:23Z","pushed_at":"2015-04-28T13:32:03Z","git_url":"git://github.com/artsy/eigen.git","ssh_url":"git@github.com:artsy/eigen.git","clone_url":"https://github.com/artsy/eigen.git","svn_url":"https://github.com/artsy/eigen","homepage":"http://iphone.artsy.net","size":46271,"stargazers_count":638,"watchers_count":638,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":109,"forks":78,"open_issues":109,"watchers":638,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"8880ccaf0b79496f66358841bc9f8ee03316c78d","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":29702213,"name":"eigen","full_name":"artsy/eigen","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/eigen","description":"The Art World in Your Pocket, Artsy's iOS app.","fork":false,"url":"https://api.github.com/repos/artsy/eigen","forks_url":"https://api.github.com/repos/artsy/eigen/forks","keys_url":"https://api.github.com/repos/artsy/eigen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/eigen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/eigen/teams","hooks_url":"https://api.github.com/repos/artsy/eigen/hooks","issue_events_url":"https://api.github.com/repos/artsy/eigen/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/eigen/events","assignees_url":"https://api.github.com/repos/artsy/eigen/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/eigen/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/eigen/tags","blobs_url":"https://api.github.com/repos/artsy/eigen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/eigen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/eigen/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/eigen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/eigen/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/eigen/languages","stargazers_url":"https://api.github.com/repos/artsy/eigen/stargazers","contributors_url":"https://api.github.com/repos/artsy/eigen/contributors","subscribers_url":"https://api.github.com/repos/artsy/eigen/subscribers","subscription_url":"https://api.github.com/repos/artsy/eigen/subscription","commits_url":"https://api.github.com/repos/artsy/eigen/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/eigen/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/eigen/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/eigen/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/eigen/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/eigen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/eigen/merges","archive_url":"https://api.github.com/repos/artsy/eigen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/eigen/downloads","issues_url":"https://api.github.com/repos/artsy/eigen/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/eigen/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/eigen/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/eigen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/eigen/labels{/name}","releases_url":"https://api.github.com/repos/artsy/eigen/releases{/id}","created_at":"2015-01-22T21:52:39Z","updated_at":"2015-04-28T13:10:23Z","pushed_at":"2015-04-28T13:32:03Z","git_url":"git://github.com/artsy/eigen.git","ssh_url":"git@github.com:artsy/eigen.git","clone_url":"https://github.com/artsy/eigen.git","svn_url":"https://github.com/artsy/eigen","homepage":"http://iphone.artsy.net","size":46271,"stargazers_count":638,"watchers_count":638,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":109,"forks":78,"open_issues":109,"watchers":638,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/eigen/pulls/404"},"html":{"href":"https://github.com/artsy/eigen/pull/404"},"issue":{"href":"https://api.github.com/repos/artsy/eigen/issues/404"},"comments":{"href":"https://api.github.com/repos/artsy/eigen/issues/404/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/eigen/pulls/404/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/eigen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/eigen/pulls/404/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/eigen/statuses/135b068bcc0bdbae543115f9106a34810af6adfb"}}}}