{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/signonotron2/issues/382","labels_url":"https://api.github.com/repos/alphagov/signonotron2/issues/382/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/signonotron2/issues/382/comments","events_url":"https://api.github.com/repos/alphagov/signonotron2/issues/382/events","html_url":"https://github.com/alphagov/signonotron2/pull/382","id":97944373,"number":382,"title":"Rubocop all the things","user":{"login":"boffbowsh","id":18276,"avatar_url":"https://avatars.githubusercontent.com/u/18276?v=3","gravatar_id":"","url":"https://api.github.com/users/boffbowsh","html_url":"https://github.com/boffbowsh","followers_url":"https://api.github.com/users/boffbowsh/followers","following_url":"https://api.github.com/users/boffbowsh/following{/other_user}","gists_url":"https://api.github.com/users/boffbowsh/gists{/gist_id}","starred_url":"https://api.github.com/users/boffbowsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boffbowsh/subscriptions","organizations_url":"https://api.github.com/users/boffbowsh/orgs","repos_url":"https://api.github.com/users/boffbowsh/repos","events_url":"https://api.github.com/users/boffbowsh/events{/privacy}","received_events_url":"https://api.github.com/users/boffbowsh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-29T14:07:50Z","updated_at":"2015-07-29T15:01:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alphagov/signonotron2/pulls/382","html_url":"https://github.com/alphagov/signonotron2/pull/382","diff_url":"https://github.com/alphagov/signonotron2/pull/382.diff","patch_url":"https://github.com/alphagov/signonotron2/pull/382.patch"},"body":"As we (core formats team) are going to be giving Signon a bit of love over the next few ${unit_of_work}s, and now that it's upgraded to latest Ruby and Rails, we figure it's a good time to get it fully up to spec on the styleguide front.\r\n\r\nRubocop managed to autocorrect the vast majority of contraventions, with just a few manual changes required. They're split into separate commits for app, lib, test, config and spec directories.\r\n\r\nThis change also makes rubocop lint the whole repo in CI, rather than just the diff. This shouldn't make a difference to anything, but it's more correct to lint the whole repo every time if we're aiming for an entirely clean repo.\r\n\r\n/cc @jamiecobbett @benilovj \r\n\r\n![allthethings](http://7b482e.medialib.glogster.com/shelbzbab/thumbnails/6k/6keirkmvotmdovcmpld55d4/1381764084-source.jpg)"},"comment":{"url":"https://api.github.com/repos/alphagov/signonotron2/issues/comments/125981010","html_url":"https://github.com/alphagov/signonotron2/pull/382#issuecomment-125981010","issue_url":"https://api.github.com/repos/alphagov/signonotron2/issues/382","id":125981010,"user":{"login":"jamiecobbett","id":93739,"avatar_url":"https://avatars.githubusercontent.com/u/93739?v=3","gravatar_id":"","url":"https://api.github.com/users/jamiecobbett","html_url":"https://github.com/jamiecobbett","followers_url":"https://api.github.com/users/jamiecobbett/followers","following_url":"https://api.github.com/users/jamiecobbett/following{/other_user}","gists_url":"https://api.github.com/users/jamiecobbett/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiecobbett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiecobbett/subscriptions","organizations_url":"https://api.github.com/users/jamiecobbett/orgs","repos_url":"https://api.github.com/users/jamiecobbett/repos","events_url":"https://api.github.com/users/jamiecobbett/events{/privacy}","received_events_url":"https://api.github.com/users/jamiecobbett/received_events","type":"User","site_admin":false},"created_at":"2015-07-29T15:01:27Z","updated_at":"2015-07-29T15:01:27Z","body":":+1: for intent"}}