{"action":"closed","number":389,"pull_request":{"url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls/389","id":52280115,"html_url":"https://github.com/phonegap/phonegap-plugin-push/pull/389","diff_url":"https://github.com/phonegap/phonegap-plugin-push/pull/389.diff","patch_url":"https://github.com/phonegap/phonegap-plugin-push/pull/389.patch","issue_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/389","number":389,"state":"closed","locked":false,"title":"Uses current flavor app id","user":{"login":"CookieCookson","id":3473396,"avatar_url":"https://avatars.githubusercontent.com/u/3473396?v=3","gravatar_id":"","url":"https://api.github.com/users/CookieCookson","html_url":"https://github.com/CookieCookson","followers_url":"https://api.github.com/users/CookieCookson/followers","following_url":"https://api.github.com/users/CookieCookson/following{/other_user}","gists_url":"https://api.github.com/users/CookieCookson/gists{/gist_id}","starred_url":"https://api.github.com/users/CookieCookson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CookieCookson/subscriptions","organizations_url":"https://api.github.com/users/CookieCookson/orgs","repos_url":"https://api.github.com/users/CookieCookson/repos","events_url":"https://api.github.com/users/CookieCookson/events{/privacy}","received_events_url":"https://api.github.com/users/CookieCookson/received_events","type":"User","site_admin":false},"body":"Currently the plugin pulls the `PACKAGE_NAME`, early on in the build process. After working with Android product flavors where I am building different APKs with different applicationIds (com.test.app.alpha, com.test.app.beta, com.test.app) the permission still sticks with the core package name. These permission requests then conflict with each other when having multiple APKs on the same device, and can even stop the app from being downloaded from the Play Store if the user has an another app on the device with the same permissions.\r\n\r\nBy using `{applicationId}` it will grab the current App flavor's application ID later on so the current ID is used instead.\r\n\r\napplicationId is fairly recent, so I am unsure about backwards compatibility with this fix. I've done 'some' testing too, but nothing thorough at this stage.","created_at":"2015-12-01T16:26:02Z","updated_at":"2015-12-01T18:14:14Z","closed_at":"2015-12-01T18:14:14Z","merged_at":"2015-12-01T18:14:13Z","merge_commit_sha":"746b721c5469616553b9f0ea5c8c7f6de9ded93a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls/389/commits","review_comments_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls/389/comments","review_comment_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/389/comments","statuses_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/statuses/d88adfba443caf64d32c49fd88df2fc9103d794d","head":{"label":"CookieCookson:flavor-fix","ref":"flavor-fix","sha":"d88adfba443caf64d32c49fd88df2fc9103d794d","user":{"login":"CookieCookson","id":3473396,"avatar_url":"https://avatars.githubusercontent.com/u/3473396?v=3","gravatar_id":"","url":"https://api.github.com/users/CookieCookson","html_url":"https://github.com/CookieCookson","followers_url":"https://api.github.com/users/CookieCookson/followers","following_url":"https://api.github.com/users/CookieCookson/following{/other_user}","gists_url":"https://api.github.com/users/CookieCookson/gists{/gist_id}","starred_url":"https://api.github.com/users/CookieCookson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CookieCookson/subscriptions","organizations_url":"https://api.github.com/users/CookieCookson/orgs","repos_url":"https://api.github.com/users/CookieCookson/repos","events_url":"https://api.github.com/users/CookieCookson/events{/privacy}","received_events_url":"https://api.github.com/users/CookieCookson/received_events","type":"User","site_admin":false},"repo":{"id":47201139,"name":"phonegap-plugin-push","full_name":"CookieCookson/phonegap-plugin-push","owner":{"login":"CookieCookson","id":3473396,"avatar_url":"https://avatars.githubusercontent.com/u/3473396?v=3","gravatar_id":"","url":"https://api.github.com/users/CookieCookson","html_url":"https://github.com/CookieCookson","followers_url":"https://api.github.com/users/CookieCookson/followers","following_url":"https://api.github.com/users/CookieCookson/following{/other_user}","gists_url":"https://api.github.com/users/CookieCookson/gists{/gist_id}","starred_url":"https://api.github.com/users/CookieCookson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CookieCookson/subscriptions","organizations_url":"https://api.github.com/users/CookieCookson/orgs","repos_url":"https://api.github.com/users/CookieCookson/repos","events_url":"https://api.github.com/users/CookieCookson/events{/privacy}","received_events_url":"https://api.github.com/users/CookieCookson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CookieCookson/phonegap-plugin-push","description":"Register and receive push notifications","fork":true,"url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push","forks_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/forks","keys_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/teams","hooks_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/hooks","issue_events_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/issues/events{/number}","events_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/events","assignees_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/assignees{/user}","branches_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/branches{/branch}","tags_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/tags","blobs_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/git/refs{/sha}","trees_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/statuses/{sha}","languages_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/languages","stargazers_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/stargazers","contributors_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/contributors","subscribers_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/subscribers","subscription_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/subscription","commits_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/commits{/sha}","git_commits_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/git/commits{/sha}","comments_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/comments{/number}","issue_comment_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/issues/comments{/number}","contents_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/contents/{+path}","compare_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/merges","archive_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/downloads","issues_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/issues{/number}","pulls_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/pulls{/number}","milestones_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/milestones{/number}","notifications_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/labels{/name}","releases_url":"https://api.github.com/repos/CookieCookson/phonegap-plugin-push/releases{/id}","created_at":"2015-12-01T16:13:34Z","updated_at":"2015-12-01T16:13:35Z","pushed_at":"2015-12-01T16:24:02Z","git_url":"git://github.com/CookieCookson/phonegap-plugin-push.git","ssh_url":"git@github.com:CookieCookson/phonegap-plugin-push.git","clone_url":"https://github.com/CookieCookson/phonegap-plugin-push.git","svn_url":"https://github.com/CookieCookson/phonegap-plugin-push","homepage":null,"size":3814,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phonegap:master","ref":"master","sha":"9f686ddd620c6af2eed023ea5d534d09b4cd0c94","user":{"login":"phonegap","id":60365,"avatar_url":"https://avatars.githubusercontent.com/u/60365?v=3","gravatar_id":"","url":"https://api.github.com/users/phonegap","html_url":"https://github.com/phonegap","followers_url":"https://api.github.com/users/phonegap/followers","following_url":"https://api.github.com/users/phonegap/following{/other_user}","gists_url":"https://api.github.com/users/phonegap/gists{/gist_id}","starred_url":"https://api.github.com/users/phonegap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phonegap/subscriptions","organizations_url":"https://api.github.com/users/phonegap/orgs","repos_url":"https://api.github.com/users/phonegap/repos","events_url":"https://api.github.com/users/phonegap/events{/privacy}","received_events_url":"https://api.github.com/users/phonegap/received_events","type":"Organization","site_admin":false},"repo":{"id":33494287,"name":"phonegap-plugin-push","full_name":"phonegap/phonegap-plugin-push","owner":{"login":"phonegap","id":60365,"avatar_url":"https://avatars.githubusercontent.com/u/60365?v=3","gravatar_id":"","url":"https://api.github.com/users/phonegap","html_url":"https://github.com/phonegap","followers_url":"https://api.github.com/users/phonegap/followers","following_url":"https://api.github.com/users/phonegap/following{/other_user}","gists_url":"https://api.github.com/users/phonegap/gists{/gist_id}","starred_url":"https://api.github.com/users/phonegap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phonegap/subscriptions","organizations_url":"https://api.github.com/users/phonegap/orgs","repos_url":"https://api.github.com/users/phonegap/repos","events_url":"https://api.github.com/users/phonegap/events{/privacy}","received_events_url":"https://api.github.com/users/phonegap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phonegap/phonegap-plugin-push","description":"Register and receive push notifications","fork":false,"url":"https://api.github.com/repos/phonegap/phonegap-plugin-push","forks_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/forks","keys_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/teams","hooks_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/hooks","issue_events_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/events{/number}","events_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/events","assignees_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/assignees{/user}","branches_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/branches{/branch}","tags_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/tags","blobs_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/git/refs{/sha}","trees_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/statuses/{sha}","languages_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/languages","stargazers_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/stargazers","contributors_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/contributors","subscribers_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/subscribers","subscription_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/subscription","commits_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/commits{/sha}","git_commits_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/git/commits{/sha}","comments_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/comments{/number}","issue_comment_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/comments{/number}","contents_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/contents/{+path}","compare_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/merges","archive_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/downloads","issues_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues{/number}","pulls_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls{/number}","milestones_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/milestones{/number}","notifications_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/labels{/name}","releases_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/releases{/id}","created_at":"2015-04-06T17:13:51Z","updated_at":"2015-12-01T13:54:31Z","pushed_at":"2015-12-01T18:14:13Z","git_url":"git://github.com/phonegap/phonegap-plugin-push.git","ssh_url":"git@github.com:phonegap/phonegap-plugin-push.git","clone_url":"https://github.com/phonegap/phonegap-plugin-push.git","svn_url":"https://github.com/phonegap/phonegap-plugin-push","homepage":null,"size":12048,"stargazers_count":415,"watchers_count":415,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":179,"mirror_url":null,"open_issues_count":85,"forks":179,"open_issues":85,"watchers":415,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls/389"},"html":{"href":"https://github.com/phonegap/phonegap-plugin-push/pull/389"},"issue":{"href":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/389"},"comments":{"href":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/389/comments"},"review_comments":{"href":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls/389/comments"},"review_comment":{"href":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls/389/commits"},"statuses":{"href":"https://api.github.com/repos/phonegap/phonegap-plugin-push/statuses/d88adfba443caf64d32c49fd88df2fc9103d794d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"macdonst","id":353180,"avatar_url":"https://avatars.githubusercontent.com/u/353180?v=3","gravatar_id":"","url":"https://api.github.com/users/macdonst","html_url":"https://github.com/macdonst","followers_url":"https://api.github.com/users/macdonst/followers","following_url":"https://api.github.com/users/macdonst/following{/other_user}","gists_url":"https://api.github.com/users/macdonst/gists{/gist_id}","starred_url":"https://api.github.com/users/macdonst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macdonst/subscriptions","organizations_url":"https://api.github.com/users/macdonst/orgs","repos_url":"https://api.github.com/users/macdonst/repos","events_url":"https://api.github.com/users/macdonst/events{/privacy}","received_events_url":"https://api.github.com/users/macdonst/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":1}}