{"action":"created","comment":{"url":"https://api.github.com/repos/uProxy/uproxy/pulls/comments/42423661","id":42423661,"diff_hunk":"@@ -968,19 +968,42 @@ export class UserInterface implements ui_constants.UiApi {\n     });\n   }\n \n+\n   public logout = (networkInfo :social.SocialNetworkInfo) : Promise<void> => {\n     var network = this.model.getNetwork(networkInfo.name);\n+\n+    //If the user is connecteed to a network, do a check to see if the user is sure that they want to log out\n     if (network) {\n-      // if we know about the network, record that we expect this logout to\n-      // happen\n-      network.logoutExpected = true;\n+      var instanceIds = Object.keys(this.instancesGivingAccessTo);\n+      var confirmationMessage: string;\n+      if (instanceIds.length > 0) {\n+\n+        confirmationMessage = this.i18n_t(\"PRE_LOG_OUT\", {\n+          name: this.mapInstanceIdToUser_[instanceIds[0]].name,\n+          numOthers: (instanceIds.length - 1)\n+        });\n+      }\n+      else {","path":"src/generic_ui/scripts/ui.ts","position":22,"original_position":22,"commit_id":"7fe7e6b0e62740347a33c25ce2ff82c48f5745e1","original_commit_id":"7fe7e6b0e62740347a33c25ce2ff82c48f5745e1","user":{"login":"lucyhe","id":8723127,"avatar_url":"https://avatars.githubusercontent.com/u/8723127?v=3","gravatar_id":"","url":"https://api.github.com/users/lucyhe","html_url":"https://github.com/lucyhe","followers_url":"https://api.github.com/users/lucyhe/followers","following_url":"https://api.github.com/users/lucyhe/following{/other_user}","gists_url":"https://api.github.com/users/lucyhe/gists{/gist_id}","starred_url":"https://api.github.com/users/lucyhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucyhe/subscriptions","organizations_url":"https://api.github.com/users/lucyhe/orgs","repos_url":"https://api.github.com/users/lucyhe/repos","events_url":"https://api.github.com/users/lucyhe/events{/privacy}","received_events_url":"https://api.github.com/users/lucyhe/received_events","type":"User","site_admin":false},"body":"The else statement should be on the same line as the closing brace (combine lines 985 and 986)","created_at":"2015-10-19T20:46:56Z","updated_at":"2015-10-19T20:46:56Z","html_url":"https://github.com/uProxy/uproxy/pull/1968#discussion_r42423661","pull_request_url":"https://api.github.com/repos/uProxy/uproxy/pulls/1968","_links":{"self":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/comments/42423661"},"html":{"href":"https://github.com/uProxy/uproxy/pull/1968#discussion_r42423661"},"pull_request":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/1968"}}},"pull_request":{"url":"https://api.github.com/repos/uProxy/uproxy/pulls/1968","id":47714644,"html_url":"https://github.com/uProxy/uproxy/pull/1968","diff_url":"https://github.com/uProxy/uproxy/pull/1968.diff","patch_url":"https://github.com/uProxy/uproxy/pull/1968.patch","issue_url":"https://api.github.com/repos/uProxy/uproxy/issues/1968","number":1968,"state":"open","locked":false,"title":"Confirmation modal for log out button","user":{"login":"ghoshkaj","id":6777404,"avatar_url":"https://avatars.githubusercontent.com/u/6777404?v=3","gravatar_id":"","url":"https://api.github.com/users/ghoshkaj","html_url":"https://github.com/ghoshkaj","followers_url":"https://api.github.com/users/ghoshkaj/followers","following_url":"https://api.github.com/users/ghoshkaj/following{/other_user}","gists_url":"https://api.github.com/users/ghoshkaj/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoshkaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoshkaj/subscriptions","organizations_url":"https://api.github.com/users/ghoshkaj/orgs","repos_url":"https://api.github.com/users/ghoshkaj/repos","events_url":"https://api.github.com/users/ghoshkaj/events{/privacy}","received_events_url":"https://api.github.com/users/ghoshkaj/received_events","type":"User","site_admin":false},"body":"https://github.com/uProxy/uproxy/issues/850\r\nWith @huma-hamid\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/uproxy/uproxy/1968)\n<!-- Reviewable:end -->\n","created_at":"2015-10-14T21:03:44Z","updated_at":"2015-10-19T20:46:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f034def03641ebd5599f007a5fee9aea7d044ce7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uProxy/uproxy/pulls/1968/commits","review_comments_url":"https://api.github.com/repos/uProxy/uproxy/pulls/1968/comments","review_comment_url":"https://api.github.com/repos/uProxy/uproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uProxy/uproxy/issues/1968/comments","statuses_url":"https://api.github.com/repos/uProxy/uproxy/statuses/7fe7e6b0e62740347a33c25ce2ff82c48f5745e1","head":{"label":"ghoshkaj:dev","ref":"dev","sha":"7fe7e6b0e62740347a33c25ce2ff82c48f5745e1","user":{"login":"ghoshkaj","id":6777404,"avatar_url":"https://avatars.githubusercontent.com/u/6777404?v=3","gravatar_id":"","url":"https://api.github.com/users/ghoshkaj","html_url":"https://github.com/ghoshkaj","followers_url":"https://api.github.com/users/ghoshkaj/followers","following_url":"https://api.github.com/users/ghoshkaj/following{/other_user}","gists_url":"https://api.github.com/users/ghoshkaj/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoshkaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoshkaj/subscriptions","organizations_url":"https://api.github.com/users/ghoshkaj/orgs","repos_url":"https://api.github.com/users/ghoshkaj/repos","events_url":"https://api.github.com/users/ghoshkaj/events{/privacy}","received_events_url":"https://api.github.com/users/ghoshkaj/received_events","type":"User","site_admin":false},"repo":{"id":44263212,"name":"uproxy","full_name":"ghoshkaj/uproxy","owner":{"login":"ghoshkaj","id":6777404,"avatar_url":"https://avatars.githubusercontent.com/u/6777404?v=3","gravatar_id":"","url":"https://api.github.com/users/ghoshkaj","html_url":"https://github.com/ghoshkaj","followers_url":"https://api.github.com/users/ghoshkaj/followers","following_url":"https://api.github.com/users/ghoshkaj/following{/other_user}","gists_url":"https://api.github.com/users/ghoshkaj/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoshkaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoshkaj/subscriptions","organizations_url":"https://api.github.com/users/ghoshkaj/orgs","repos_url":"https://api.github.com/users/ghoshkaj/repos","events_url":"https://api.github.com/users/ghoshkaj/events{/privacy}","received_events_url":"https://api.github.com/users/ghoshkaj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghoshkaj/uproxy","description":"Share your pathway to the Internet","fork":true,"url":"https://api.github.com/repos/ghoshkaj/uproxy","forks_url":"https://api.github.com/repos/ghoshkaj/uproxy/forks","keys_url":"https://api.github.com/repos/ghoshkaj/uproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghoshkaj/uproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghoshkaj/uproxy/teams","hooks_url":"https://api.github.com/repos/ghoshkaj/uproxy/hooks","issue_events_url":"https://api.github.com/repos/ghoshkaj/uproxy/issues/events{/number}","events_url":"https://api.github.com/repos/ghoshkaj/uproxy/events","assignees_url":"https://api.github.com/repos/ghoshkaj/uproxy/assignees{/user}","branches_url":"https://api.github.com/repos/ghoshkaj/uproxy/branches{/branch}","tags_url":"https://api.github.com/repos/ghoshkaj/uproxy/tags","blobs_url":"https://api.github.com/repos/ghoshkaj/uproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghoshkaj/uproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghoshkaj/uproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghoshkaj/uproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghoshkaj/uproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/ghoshkaj/uproxy/languages","stargazers_url":"https://api.github.com/repos/ghoshkaj/uproxy/stargazers","contributors_url":"https://api.github.com/repos/ghoshkaj/uproxy/contributors","subscribers_url":"https://api.github.com/repos/ghoshkaj/uproxy/subscribers","subscription_url":"https://api.github.com/repos/ghoshkaj/uproxy/subscription","commits_url":"https://api.github.com/repos/ghoshkaj/uproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghoshkaj/uproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghoshkaj/uproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghoshkaj/uproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ghoshkaj/uproxy/contents/{+path}","compare_url":"https://api.github.com/repos/ghoshkaj/uproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghoshkaj/uproxy/merges","archive_url":"https://api.github.com/repos/ghoshkaj/uproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghoshkaj/uproxy/downloads","issues_url":"https://api.github.com/repos/ghoshkaj/uproxy/issues{/number}","pulls_url":"https://api.github.com/repos/ghoshkaj/uproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/ghoshkaj/uproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/ghoshkaj/uproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghoshkaj/uproxy/labels{/name}","releases_url":"https://api.github.com/repos/ghoshkaj/uproxy/releases{/id}","created_at":"2015-10-14T17:04:56Z","updated_at":"2015-10-14T17:04:58Z","pushed_at":"2015-10-14T20:59:05Z","git_url":"git://github.com/ghoshkaj/uproxy.git","ssh_url":"git@github.com:ghoshkaj/uproxy.git","clone_url":"https://github.com/ghoshkaj/uproxy.git","svn_url":"https://github.com/ghoshkaj/uproxy","homepage":"https://www.uproxy.org/","size":25386,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"uProxy:dev","ref":"dev","sha":"23681816f83a09b4b54e5b6121d05305968e0b5e","user":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"repo":{"id":18533350,"name":"uproxy","full_name":"uProxy/uproxy","owner":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uProxy/uproxy","description":"Share your pathway to the Internet","fork":false,"url":"https://api.github.com/repos/uProxy/uproxy","forks_url":"https://api.github.com/repos/uProxy/uproxy/forks","keys_url":"https://api.github.com/repos/uProxy/uproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uProxy/uproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uProxy/uproxy/teams","hooks_url":"https://api.github.com/repos/uProxy/uproxy/hooks","issue_events_url":"https://api.github.com/repos/uProxy/uproxy/issues/events{/number}","events_url":"https://api.github.com/repos/uProxy/uproxy/events","assignees_url":"https://api.github.com/repos/uProxy/uproxy/assignees{/user}","branches_url":"https://api.github.com/repos/uProxy/uproxy/branches{/branch}","tags_url":"https://api.github.com/repos/uProxy/uproxy/tags","blobs_url":"https://api.github.com/repos/uProxy/uproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uProxy/uproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uProxy/uproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/uProxy/uproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uProxy/uproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/uProxy/uproxy/languages","stargazers_url":"https://api.github.com/repos/uProxy/uproxy/stargazers","contributors_url":"https://api.github.com/repos/uProxy/uproxy/contributors","subscribers_url":"https://api.github.com/repos/uProxy/uproxy/subscribers","subscription_url":"https://api.github.com/repos/uProxy/uproxy/subscription","commits_url":"https://api.github.com/repos/uProxy/uproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/uProxy/uproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/uProxy/uproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/uProxy/uproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/uProxy/uproxy/contents/{+path}","compare_url":"https://api.github.com/repos/uProxy/uproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uProxy/uproxy/merges","archive_url":"https://api.github.com/repos/uProxy/uproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uProxy/uproxy/downloads","issues_url":"https://api.github.com/repos/uProxy/uproxy/issues{/number}","pulls_url":"https://api.github.com/repos/uProxy/uproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/uProxy/uproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/uProxy/uproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uProxy/uproxy/labels{/name}","releases_url":"https://api.github.com/repos/uProxy/uproxy/releases{/id}","created_at":"2014-04-07T20:34:40Z","updated_at":"2015-10-18T07:32:27Z","pushed_at":"2015-10-19T17:28:11Z","git_url":"git://github.com/uProxy/uproxy.git","ssh_url":"git@github.com:uProxy/uproxy.git","clone_url":"https://github.com/uProxy/uproxy.git","svn_url":"https://github.com/uProxy/uproxy","homepage":"https://www.uproxy.org/","size":25386,"stargazers_count":277,"watchers_count":277,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":72,"mirror_url":null,"open_issues_count":388,"forks":72,"open_issues":388,"watchers":277,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/1968"},"html":{"href":"https://github.com/uProxy/uproxy/pull/1968"},"issue":{"href":"https://api.github.com/repos/uProxy/uproxy/issues/1968"},"comments":{"href":"https://api.github.com/repos/uProxy/uproxy/issues/1968/comments"},"review_comments":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/1968/comments"},"review_comment":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uProxy/uproxy/pulls/1968/commits"},"statuses":{"href":"https://api.github.com/repos/uProxy/uproxy/statuses/7fe7e6b0e62740347a33c25ce2ff82c48f5745e1"}}}}