{"comment":{"url":"https://api.github.com/repos/lgray/cmssw/comments/12624231","html_url":"https://github.com/lgray/cmssw/commit/794bf67b39b5bd7c72ff35eebfd3f4e81eb43c56#commitcomment-12624231","id":12624231,"user":{"login":"Dr15Jones","id":3757616,"avatar_url":"https://avatars.githubusercontent.com/u/3757616?v=3","gravatar_id":"","url":"https://api.github.com/users/Dr15Jones","html_url":"https://github.com/Dr15Jones","followers_url":"https://api.github.com/users/Dr15Jones/followers","following_url":"https://api.github.com/users/Dr15Jones/following{/other_user}","gists_url":"https://api.github.com/users/Dr15Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/Dr15Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dr15Jones/subscriptions","organizations_url":"https://api.github.com/users/Dr15Jones/orgs","repos_url":"https://api.github.com/users/Dr15Jones/repos","events_url":"https://api.github.com/users/Dr15Jones/events{/privacy}","received_events_url":"https://api.github.com/users/Dr15Jones/received_events","type":"User","site_admin":false},"position":7,"line":196,"path":"CommonTools/Utils/src/MethodInvoker.cc","commit_id":"794bf67b39b5bd7c72ff35eebfd3f4e81eb43c56","created_at":"2015-08-10T20:16:51Z","updated_at":"2015-08-10T20:16:51Z","body":"The thread safety issue isn't the ```accessor``` it is the fact that you modify ```access``` after the insertion which means another thread may hit that exact spot, get a copy of ```access``` before the ```shared_ptr<>``` is set and then return a reference to a null object."}}