{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/46556623","id":46556623,"diff_hunk":"@@ -110,4 +110,48 @@ module MiqAeServiceSpec\n       end\n     end\n   end\n+\n+  describe MiqAeService do\n+    context \"service models\" do\n+      it \"expose all expected active_record models as service_models\" do\n+        excluded_model_names = %w(\n+          AuthToken\n+          AuthUseridPassword\n+          Category\n+          Datacenter\n+          ManageIQ::Providers::BaseManager\n+          ManageIQ::Providers::Kubernetes::ContainerManager::Scanning::Job\n+          VmServer\n+          VmSynchronize\n+        )\n+\n+        # Determine base_model for all service model files\n+        base_models = Dir.glob(MiqAeMethodService::MiqAeServiceModelBase::SERVICE_MODEL_GLOB).collect do |f|\n+          model_name = MiqAeMethodService::MiqAeServiceModelBase.model_name_from_file(f)\n+          next if model_name == \"MiqAeServiceMethods\"\n+\n+          \"MiqAeMethodService::#{model_name}\".constantize.send(:model).base_model\n+        end.compact!.uniq!","path":"spec/lib/miq_automation_engine/miq_ae_service_spec.rb","position":25,"original_position":25,"commit_id":"1eef7c20e1753d7995a78560272177fec16ce55a","original_commit_id":"1eef7c20e1753d7995a78560272177fec16ce55a","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"body":"Should this also be a method in the code somewhere?  It doesn't feel like test code.","created_at":"2015-12-03T14:28:54Z","updated_at":"2015-12-03T14:28:54Z","html_url":"https://github.com/ManageIQ/manageiq/pull/5482#discussion_r46556623","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5482","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/46556623"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/5482#discussion_r46556623"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5482"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5482","id":50965605,"html_url":"https://github.com/ManageIQ/manageiq/pull/5482","diff_url":"https://github.com/ManageIQ/manageiq/pull/5482.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/5482.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5482","number":5482,"state":"open","locked":false,"title":"Add test to detect missing automate service models","user":{"login":"gmcculloug","id":2591569,"avatar_url":"https://avatars.githubusercontent.com/u/2591569?v=3","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false},"body":"Test loads all service models and determines the base_model, then gets the descendants\r\nof all the base models and validates that service models exist, unless specified in the exclude list.\r\n\r\nTest validates \r\n1. Service Model files are named correctly\r\n2. Service Models load correctly\r\n3. Service Models exist for all descendants of sub-classed models (except when explicitly excluded)\r\n\r\nIncludes some refactoring of MiqAeServiceModelBase to reuse methods in test.","created_at":"2015-11-17T16:02:33Z","updated_at":"2015-12-03T14:28:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9fa7af724fa923133407ed06c932b0452d783c9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5482/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5482/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5482/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/1eef7c20e1753d7995a78560272177fec16ce55a","head":{"label":"gmcculloug:automate_service_model_check","ref":"automate_service_model_check","sha":"1eef7c20e1753d7995a78560272177fec16ce55a","user":{"login":"gmcculloug","id":2591569,"avatar_url":"https://avatars.githubusercontent.com/u/2591569?v=3","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false},"repo":{"id":20885993,"name":"manageiq","full_name":"gmcculloug/manageiq","owner":{"login":"gmcculloug","id":2591569,"avatar_url":"https://avatars.githubusercontent.com/u/2591569?v=3","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gmcculloug/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/gmcculloug/manageiq","forks_url":"https://api.github.com/repos/gmcculloug/manageiq/forks","keys_url":"https://api.github.com/repos/gmcculloug/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gmcculloug/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gmcculloug/manageiq/teams","hooks_url":"https://api.github.com/repos/gmcculloug/manageiq/hooks","issue_events_url":"https://api.github.com/repos/gmcculloug/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/gmcculloug/manageiq/events","assignees_url":"https://api.github.com/repos/gmcculloug/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/gmcculloug/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/gmcculloug/manageiq/tags","blobs_url":"https://api.github.com/repos/gmcculloug/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gmcculloug/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gmcculloug/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/gmcculloug/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gmcculloug/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/gmcculloug/manageiq/languages","stargazers_url":"https://api.github.com/repos/gmcculloug/manageiq/stargazers","contributors_url":"https://api.github.com/repos/gmcculloug/manageiq/contributors","subscribers_url":"https://api.github.com/repos/gmcculloug/manageiq/subscribers","subscription_url":"https://api.github.com/repos/gmcculloug/manageiq/subscription","commits_url":"https://api.github.com/repos/gmcculloug/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/gmcculloug/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/gmcculloug/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/gmcculloug/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/gmcculloug/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/gmcculloug/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gmcculloug/manageiq/merges","archive_url":"https://api.github.com/repos/gmcculloug/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gmcculloug/manageiq/downloads","issues_url":"https://api.github.com/repos/gmcculloug/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/gmcculloug/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/gmcculloug/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/gmcculloug/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gmcculloug/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/gmcculloug/manageiq/releases{/id}","created_at":"2014-06-16T13:34:52Z","updated_at":"2015-05-08T13:02:58Z","pushed_at":"2015-12-03T14:04:32Z","git_url":"git://github.com/gmcculloug/manageiq.git","ssh_url":"git@github.com:gmcculloug/manageiq.git","clone_url":"https://github.com/gmcculloug/manageiq.git","svn_url":"https://github.com/gmcculloug/manageiq","homepage":null,"size":96879,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"de1ad3ee15b7ef8fb724fb97c75207a6d8ed28fb","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-12-03T12:41:19Z","pushed_at":"2015-12-03T14:02:05Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":130921,"stargazers_count":172,"watchers_count":172,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":187,"mirror_url":null,"open_issues_count":463,"forks":187,"open_issues":463,"watchers":172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5482"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/5482"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/5482"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/5482/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5482/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5482/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/1eef7c20e1753d7995a78560272177fec16ce55a"}}}}