{"action":"created","comment":{"url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/comments/36623381","id":36623381,"diff_hunk":"@@ -34,10 +34,21 @@ module.exports = function() {};\n module.exports.prototype = {\n \n     configure: function(options) {\n-        assert(\n-            options === true,\n-            this.getOptionName() + ' option requires a true value or should be removed'\n-        );\n+        if (typeof options !== 'object') {\n+            assert(\n+                options === true,\n+                this.getOptionName() + ' option requires a true value or should be removed'","path":"lib/rules/disallow-empty-blocks.js","position":11,"original_position":11,"commit_id":"6f83df0e6be2d2594504400116df26e6d7566213","original_commit_id":"6f83df0e6be2d2594504400116df26e6d7566213","user":{"login":"markelog","id":945528,"avatar_url":"https://avatars.githubusercontent.com/u/945528?v=3","gravatar_id":"","url":"https://api.github.com/users/markelog","html_url":"https://github.com/markelog","followers_url":"https://api.github.com/users/markelog/followers","following_url":"https://api.github.com/users/markelog/following{/other_user}","gists_url":"https://api.github.com/users/markelog/gists{/gist_id}","starred_url":"https://api.github.com/users/markelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markelog/subscriptions","organizations_url":"https://api.github.com/users/markelog/orgs","repos_url":"https://api.github.com/users/markelog/repos","events_url":"https://api.github.com/users/markelog/events{/privacy}","received_events_url":"https://api.github.com/users/markelog/received_events","type":"User","site_admin":false},"body":"Hm, i guess we should change that warning now?","created_at":"2015-08-10T11:52:50Z","updated_at":"2015-08-10T11:52:50Z","html_url":"https://github.com/jscs-dev/node-jscs/pull/1650#discussion_r36623381","pull_request_url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1650","_links":{"self":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/comments/36623381"},"html":{"href":"https://github.com/jscs-dev/node-jscs/pull/1650#discussion_r36623381"},"pull_request":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1650"}}},"pull_request":{"url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1650","id":41979383,"html_url":"https://github.com/jscs-dev/node-jscs/pull/1650","diff_url":"https://github.com/jscs-dev/node-jscs/pull/1650.diff","patch_url":"https://github.com/jscs-dev/node-jscs/pull/1650.patch","issue_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/1650","number":1650,"state":"open","locked":false,"title":"disallowEmptyBlocks: allow blocks with comments","user":{"login":"faceleg","id":1000759,"avatar_url":"https://avatars.githubusercontent.com/u/1000759?v=3","gravatar_id":"","url":"https://api.github.com/users/faceleg","html_url":"https://github.com/faceleg","followers_url":"https://api.github.com/users/faceleg/followers","following_url":"https://api.github.com/users/faceleg/following{/other_user}","gists_url":"https://api.github.com/users/faceleg/gists{/gist_id}","starred_url":"https://api.github.com/users/faceleg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faceleg/subscriptions","organizations_url":"https://api.github.com/users/faceleg/orgs","repos_url":"https://api.github.com/users/faceleg/repos","events_url":"https://api.github.com/users/faceleg/events{/privacy}","received_events_url":"https://api.github.com/users/faceleg/received_events","type":"User","site_admin":false},"body":"Requires rule to be configured with `allExcept: ['comments']`\r\n\r\nFixes #1611","created_at":"2015-08-09T23:38:33Z","updated_at":"2015-08-10T11:52:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00ae1a7a91cc018e16ec7a3dfcb895a602ea18c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1650/commits","review_comments_url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1650/comments","review_comment_url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/1650/comments","statuses_url":"https://api.github.com/repos/jscs-dev/node-jscs/statuses/6f83df0e6be2d2594504400116df26e6d7566213","head":{"label":"faceleg:feature/allow-blocks-with-comments","ref":"feature/allow-blocks-with-comments","sha":"6f83df0e6be2d2594504400116df26e6d7566213","user":{"login":"faceleg","id":1000759,"avatar_url":"https://avatars.githubusercontent.com/u/1000759?v=3","gravatar_id":"","url":"https://api.github.com/users/faceleg","html_url":"https://github.com/faceleg","followers_url":"https://api.github.com/users/faceleg/followers","following_url":"https://api.github.com/users/faceleg/following{/other_user}","gists_url":"https://api.github.com/users/faceleg/gists{/gist_id}","starred_url":"https://api.github.com/users/faceleg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faceleg/subscriptions","organizations_url":"https://api.github.com/users/faceleg/orgs","repos_url":"https://api.github.com/users/faceleg/repos","events_url":"https://api.github.com/users/faceleg/events{/privacy}","received_events_url":"https://api.github.com/users/faceleg/received_events","type":"User","site_admin":false},"repo":{"id":40451813,"name":"node-jscs","full_name":"faceleg/node-jscs","owner":{"login":"faceleg","id":1000759,"avatar_url":"https://avatars.githubusercontent.com/u/1000759?v=3","gravatar_id":"","url":"https://api.github.com/users/faceleg","html_url":"https://github.com/faceleg","followers_url":"https://api.github.com/users/faceleg/followers","following_url":"https://api.github.com/users/faceleg/following{/other_user}","gists_url":"https://api.github.com/users/faceleg/gists{/gist_id}","starred_url":"https://api.github.com/users/faceleg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faceleg/subscriptions","organizations_url":"https://api.github.com/users/faceleg/orgs","repos_url":"https://api.github.com/users/faceleg/repos","events_url":"https://api.github.com/users/faceleg/events{/privacy}","received_events_url":"https://api.github.com/users/faceleg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/faceleg/node-jscs","description":"JavaScript Code Style checker","fork":true,"url":"https://api.github.com/repos/faceleg/node-jscs","forks_url":"https://api.github.com/repos/faceleg/node-jscs/forks","keys_url":"https://api.github.com/repos/faceleg/node-jscs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/faceleg/node-jscs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/faceleg/node-jscs/teams","hooks_url":"https://api.github.com/repos/faceleg/node-jscs/hooks","issue_events_url":"https://api.github.com/repos/faceleg/node-jscs/issues/events{/number}","events_url":"https://api.github.com/repos/faceleg/node-jscs/events","assignees_url":"https://api.github.com/repos/faceleg/node-jscs/assignees{/user}","branches_url":"https://api.github.com/repos/faceleg/node-jscs/branches{/branch}","tags_url":"https://api.github.com/repos/faceleg/node-jscs/tags","blobs_url":"https://api.github.com/repos/faceleg/node-jscs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/faceleg/node-jscs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/faceleg/node-jscs/git/refs{/sha}","trees_url":"https://api.github.com/repos/faceleg/node-jscs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/faceleg/node-jscs/statuses/{sha}","languages_url":"https://api.github.com/repos/faceleg/node-jscs/languages","stargazers_url":"https://api.github.com/repos/faceleg/node-jscs/stargazers","contributors_url":"https://api.github.com/repos/faceleg/node-jscs/contributors","subscribers_url":"https://api.github.com/repos/faceleg/node-jscs/subscribers","subscription_url":"https://api.github.com/repos/faceleg/node-jscs/subscription","commits_url":"https://api.github.com/repos/faceleg/node-jscs/commits{/sha}","git_commits_url":"https://api.github.com/repos/faceleg/node-jscs/git/commits{/sha}","comments_url":"https://api.github.com/repos/faceleg/node-jscs/comments{/number}","issue_comment_url":"https://api.github.com/repos/faceleg/node-jscs/issues/comments{/number}","contents_url":"https://api.github.com/repos/faceleg/node-jscs/contents/{+path}","compare_url":"https://api.github.com/repos/faceleg/node-jscs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/faceleg/node-jscs/merges","archive_url":"https://api.github.com/repos/faceleg/node-jscs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/faceleg/node-jscs/downloads","issues_url":"https://api.github.com/repos/faceleg/node-jscs/issues{/number}","pulls_url":"https://api.github.com/repos/faceleg/node-jscs/pulls{/number}","milestones_url":"https://api.github.com/repos/faceleg/node-jscs/milestones{/number}","notifications_url":"https://api.github.com/repos/faceleg/node-jscs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/faceleg/node-jscs/labels{/name}","releases_url":"https://api.github.com/repos/faceleg/node-jscs/releases{/id}","created_at":"2015-08-09T21:52:31Z","updated_at":"2015-08-09T21:52:32Z","pushed_at":"2015-08-09T23:38:20Z","git_url":"git://github.com/faceleg/node-jscs.git","ssh_url":"git@github.com:faceleg/node-jscs.git","clone_url":"https://github.com/faceleg/node-jscs.git","svn_url":"https://github.com/faceleg/node-jscs","homepage":"http://jscs.info/","size":11488,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jscs-dev:master","ref":"master","sha":"c536b21ca16b74e44081f4c7d89a38e08439e23c","user":{"login":"jscs-dev","id":8018201,"avatar_url":"https://avatars.githubusercontent.com/u/8018201?v=3","gravatar_id":"","url":"https://api.github.com/users/jscs-dev","html_url":"https://github.com/jscs-dev","followers_url":"https://api.github.com/users/jscs-dev/followers","following_url":"https://api.github.com/users/jscs-dev/following{/other_user}","gists_url":"https://api.github.com/users/jscs-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/jscs-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jscs-dev/subscriptions","organizations_url":"https://api.github.com/users/jscs-dev/orgs","repos_url":"https://api.github.com/users/jscs-dev/repos","events_url":"https://api.github.com/users/jscs-dev/events{/privacy}","received_events_url":"https://api.github.com/users/jscs-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":10697582,"name":"node-jscs","full_name":"jscs-dev/node-jscs","owner":{"login":"jscs-dev","id":8018201,"avatar_url":"https://avatars.githubusercontent.com/u/8018201?v=3","gravatar_id":"","url":"https://api.github.com/users/jscs-dev","html_url":"https://github.com/jscs-dev","followers_url":"https://api.github.com/users/jscs-dev/followers","following_url":"https://api.github.com/users/jscs-dev/following{/other_user}","gists_url":"https://api.github.com/users/jscs-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/jscs-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jscs-dev/subscriptions","organizations_url":"https://api.github.com/users/jscs-dev/orgs","repos_url":"https://api.github.com/users/jscs-dev/repos","events_url":"https://api.github.com/users/jscs-dev/events{/privacy}","received_events_url":"https://api.github.com/users/jscs-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jscs-dev/node-jscs","description":"JavaScript Code Style checker","fork":false,"url":"https://api.github.com/repos/jscs-dev/node-jscs","forks_url":"https://api.github.com/repos/jscs-dev/node-jscs/forks","keys_url":"https://api.github.com/repos/jscs-dev/node-jscs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jscs-dev/node-jscs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jscs-dev/node-jscs/teams","hooks_url":"https://api.github.com/repos/jscs-dev/node-jscs/hooks","issue_events_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/events{/number}","events_url":"https://api.github.com/repos/jscs-dev/node-jscs/events","assignees_url":"https://api.github.com/repos/jscs-dev/node-jscs/assignees{/user}","branches_url":"https://api.github.com/repos/jscs-dev/node-jscs/branches{/branch}","tags_url":"https://api.github.com/repos/jscs-dev/node-jscs/tags","blobs_url":"https://api.github.com/repos/jscs-dev/node-jscs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jscs-dev/node-jscs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jscs-dev/node-jscs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jscs-dev/node-jscs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jscs-dev/node-jscs/statuses/{sha}","languages_url":"https://api.github.com/repos/jscs-dev/node-jscs/languages","stargazers_url":"https://api.github.com/repos/jscs-dev/node-jscs/stargazers","contributors_url":"https://api.github.com/repos/jscs-dev/node-jscs/contributors","subscribers_url":"https://api.github.com/repos/jscs-dev/node-jscs/subscribers","subscription_url":"https://api.github.com/repos/jscs-dev/node-jscs/subscription","commits_url":"https://api.github.com/repos/jscs-dev/node-jscs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jscs-dev/node-jscs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jscs-dev/node-jscs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/comments{/number}","contents_url":"https://api.github.com/repos/jscs-dev/node-jscs/contents/{+path}","compare_url":"https://api.github.com/repos/jscs-dev/node-jscs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jscs-dev/node-jscs/merges","archive_url":"https://api.github.com/repos/jscs-dev/node-jscs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jscs-dev/node-jscs/downloads","issues_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues{/number}","pulls_url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls{/number}","milestones_url":"https://api.github.com/repos/jscs-dev/node-jscs/milestones{/number}","notifications_url":"https://api.github.com/repos/jscs-dev/node-jscs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jscs-dev/node-jscs/labels{/name}","releases_url":"https://api.github.com/repos/jscs-dev/node-jscs/releases{/id}","created_at":"2013-06-14T20:53:48Z","updated_at":"2015-08-10T09:10:35Z","pushed_at":"2015-08-10T11:34:22Z","git_url":"git://github.com/jscs-dev/node-jscs.git","ssh_url":"git@github.com:jscs-dev/node-jscs.git","clone_url":"https://github.com/jscs-dev/node-jscs.git","svn_url":"https://github.com/jscs-dev/node-jscs","homepage":"http://jscs.info/","size":11488,"stargazers_count":3944,"watchers_count":3944,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":394,"mirror_url":null,"open_issues_count":186,"forks":394,"open_issues":186,"watchers":3944,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1650"},"html":{"href":"https://github.com/jscs-dev/node-jscs/pull/1650"},"issue":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/issues/1650"},"comments":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/issues/1650/comments"},"review_comments":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1650/comments"},"review_comment":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1650/commits"},"statuses":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/statuses/6f83df0e6be2d2594504400116df26e6d7566213"}}}}