{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/mediacapture-record/pulls/comments/47154100","id":47154100,"diff_hunk":"@@ -182,11 +182,11 @@\n <section id=\"blob-event\">\n     <h2>Blob Event</h2>\n     <dl title='interface BlobEvent : Event' class='idl'>\n-        <dt>Constructor(DOMString type, BlobEventInit eventInit)</dt>\n+        <dt>Constructor(DOMString type, required BlobEventInit eventInitDict)</dt>","path":"MediaRecorder.html","position":5,"original_position":5,"commit_id":"52460f0c04a602c9cf8fa3c8de3f047e5096208a","original_commit_id":"52460f0c04a602c9cf8fa3c8de3f047e5096208a","user":{"login":"foolip","id":498917,"avatar_url":"https://avatars.githubusercontent.com/u/498917?v=3","gravatar_id":"","url":"https://api.github.com/users/foolip","html_url":"https://github.com/foolip","followers_url":"https://api.github.com/users/foolip/followers","following_url":"https://api.github.com/users/foolip/following{/other_user}","gists_url":"https://api.github.com/users/foolip/gists{/gist_id}","starred_url":"https://api.github.com/users/foolip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foolip/subscriptions","organizations_url":"https://api.github.com/users/foolip/orgs","repos_url":"https://api.github.com/users/foolip/repos","events_url":"https://api.github.com/users/foolip/events{/privacy}","received_events_url":"https://api.github.com/users/foolip/received_events","type":"User","site_admin":false},"body":"Actually, you can't use the required keyword here, all arguments are required unless they have the optional keyword. The required keyword is only for dictionary members, as you've done below.","created_at":"2015-12-09T21:25:58Z","updated_at":"2015-12-09T21:25:58Z","html_url":"https://github.com/w3c/mediacapture-record/pull/38#discussion_r47154100","pull_request_url":"https://api.github.com/repos/w3c/mediacapture-record/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/w3c/mediacapture-record/pulls/comments/47154100"},"html":{"href":"https://github.com/w3c/mediacapture-record/pull/38#discussion_r47154100"},"pull_request":{"href":"https://api.github.com/repos/w3c/mediacapture-record/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/mediacapture-record/pulls/38","id":53174029,"html_url":"https://github.com/w3c/mediacapture-record/pull/38","diff_url":"https://github.com/w3c/mediacapture-record/pull/38.diff","patch_url":"https://github.com/w3c/mediacapture-record/pull/38.patch","issue_url":"https://api.github.com/repos/w3c/mediacapture-record/issues/38","number":38,"state":"closed","locked":false,"title":"Add required keyword, and s/eventInit/eventInitDict/","user":{"login":"miguelao","id":2168198,"avatar_url":"https://avatars.githubusercontent.com/u/2168198?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelao","html_url":"https://github.com/miguelao","followers_url":"https://api.github.com/users/miguelao/followers","following_url":"https://api.github.com/users/miguelao/following{/other_user}","gists_url":"https://api.github.com/users/miguelao/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelao/subscriptions","organizations_url":"https://api.github.com/users/miguelao/orgs","repos_url":"https://api.github.com/users/miguelao/repos","events_url":"https://api.github.com/users/miguelao/events{/privacy}","received_events_url":"https://api.github.com/users/miguelao/received_events","type":"User","site_admin":false},"body":"Bc of https://github.com/w3c/mediacapture-record/pull/37/files#r47140210","created_at":"2015-12-09T20:35:27Z","updated_at":"2015-12-09T21:25:58Z","closed_at":"2015-12-09T20:35:48Z","merged_at":"2015-12-09T20:35:48Z","merge_commit_sha":"fc669b90130e3bc864c9d455cf034e43d0400734","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/w3c/mediacapture-record/pulls/38/commits","review_comments_url":"https://api.github.com/repos/w3c/mediacapture-record/pulls/38/comments","review_comment_url":"https://api.github.com/repos/w3c/mediacapture-record/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/mediacapture-record/issues/38/comments","statuses_url":"https://api.github.com/repos/w3c/mediacapture-record/statuses/52460f0c04a602c9cf8fa3c8de3f047e5096208a","head":{"label":"miguelao:blobdata_typos_2","ref":"blobdata_typos_2","sha":"52460f0c04a602c9cf8fa3c8de3f047e5096208a","user":{"login":"miguelao","id":2168198,"avatar_url":"https://avatars.githubusercontent.com/u/2168198?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelao","html_url":"https://github.com/miguelao","followers_url":"https://api.github.com/users/miguelao/followers","following_url":"https://api.github.com/users/miguelao/following{/other_user}","gists_url":"https://api.github.com/users/miguelao/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelao/subscriptions","organizations_url":"https://api.github.com/users/miguelao/orgs","repos_url":"https://api.github.com/users/miguelao/repos","events_url":"https://api.github.com/users/miguelao/events{/privacy}","received_events_url":"https://api.github.com/users/miguelao/received_events","type":"User","site_admin":false},"repo":{"id":43022979,"name":"mediacapture-record","full_name":"miguelao/mediacapture-record","owner":{"login":"miguelao","id":2168198,"avatar_url":"https://avatars.githubusercontent.com/u/2168198?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelao","html_url":"https://github.com/miguelao","followers_url":"https://api.github.com/users/miguelao/followers","following_url":"https://api.github.com/users/miguelao/following{/other_user}","gists_url":"https://api.github.com/users/miguelao/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelao/subscriptions","organizations_url":"https://api.github.com/users/miguelao/orgs","repos_url":"https://api.github.com/users/miguelao/repos","events_url":"https://api.github.com/users/miguelao/events{/privacy}","received_events_url":"https://api.github.com/users/miguelao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miguelao/mediacapture-record","description":"MediaStream Recording","fork":true,"url":"https://api.github.com/repos/miguelao/mediacapture-record","forks_url":"https://api.github.com/repos/miguelao/mediacapture-record/forks","keys_url":"https://api.github.com/repos/miguelao/mediacapture-record/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miguelao/mediacapture-record/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miguelao/mediacapture-record/teams","hooks_url":"https://api.github.com/repos/miguelao/mediacapture-record/hooks","issue_events_url":"https://api.github.com/repos/miguelao/mediacapture-record/issues/events{/number}","events_url":"https://api.github.com/repos/miguelao/mediacapture-record/events","assignees_url":"https://api.github.com/repos/miguelao/mediacapture-record/assignees{/user}","branches_url":"https://api.github.com/repos/miguelao/mediacapture-record/branches{/branch}","tags_url":"https://api.github.com/repos/miguelao/mediacapture-record/tags","blobs_url":"https://api.github.com/repos/miguelao/mediacapture-record/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miguelao/mediacapture-record/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miguelao/mediacapture-record/git/refs{/sha}","trees_url":"https://api.github.com/repos/miguelao/mediacapture-record/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miguelao/mediacapture-record/statuses/{sha}","languages_url":"https://api.github.com/repos/miguelao/mediacapture-record/languages","stargazers_url":"https://api.github.com/repos/miguelao/mediacapture-record/stargazers","contributors_url":"https://api.github.com/repos/miguelao/mediacapture-record/contributors","subscribers_url":"https://api.github.com/repos/miguelao/mediacapture-record/subscribers","subscription_url":"https://api.github.com/repos/miguelao/mediacapture-record/subscription","commits_url":"https://api.github.com/repos/miguelao/mediacapture-record/commits{/sha}","git_commits_url":"https://api.github.com/repos/miguelao/mediacapture-record/git/commits{/sha}","comments_url":"https://api.github.com/repos/miguelao/mediacapture-record/comments{/number}","issue_comment_url":"https://api.github.com/repos/miguelao/mediacapture-record/issues/comments{/number}","contents_url":"https://api.github.com/repos/miguelao/mediacapture-record/contents/{+path}","compare_url":"https://api.github.com/repos/miguelao/mediacapture-record/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miguelao/mediacapture-record/merges","archive_url":"https://api.github.com/repos/miguelao/mediacapture-record/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miguelao/mediacapture-record/downloads","issues_url":"https://api.github.com/repos/miguelao/mediacapture-record/issues{/number}","pulls_url":"https://api.github.com/repos/miguelao/mediacapture-record/pulls{/number}","milestones_url":"https://api.github.com/repos/miguelao/mediacapture-record/milestones{/number}","notifications_url":"https://api.github.com/repos/miguelao/mediacapture-record/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miguelao/mediacapture-record/labels{/name}","releases_url":"https://api.github.com/repos/miguelao/mediacapture-record/releases{/id}","created_at":"2015-09-23T19:45:30Z","updated_at":"2015-09-23T19:45:31Z","pushed_at":"2015-12-09T20:36:21Z","git_url":"git://github.com/miguelao/mediacapture-record.git","ssh_url":"git@github.com:miguelao/mediacapture-record.git","clone_url":"https://github.com/miguelao/mediacapture-record.git","svn_url":"https://github.com/miguelao/mediacapture-record","homepage":null,"size":12855,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"0a515c1defe0c0f49e91657c1340f743dcae15f9","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":23147164,"name":"mediacapture-record","full_name":"w3c/mediacapture-record","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/mediacapture-record","description":"MediaStream Recording","fork":false,"url":"https://api.github.com/repos/w3c/mediacapture-record","forks_url":"https://api.github.com/repos/w3c/mediacapture-record/forks","keys_url":"https://api.github.com/repos/w3c/mediacapture-record/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/mediacapture-record/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/mediacapture-record/teams","hooks_url":"https://api.github.com/repos/w3c/mediacapture-record/hooks","issue_events_url":"https://api.github.com/repos/w3c/mediacapture-record/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/mediacapture-record/events","assignees_url":"https://api.github.com/repos/w3c/mediacapture-record/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/mediacapture-record/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/mediacapture-record/tags","blobs_url":"https://api.github.com/repos/w3c/mediacapture-record/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/mediacapture-record/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/mediacapture-record/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/mediacapture-record/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/mediacapture-record/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/mediacapture-record/languages","stargazers_url":"https://api.github.com/repos/w3c/mediacapture-record/stargazers","contributors_url":"https://api.github.com/repos/w3c/mediacapture-record/contributors","subscribers_url":"https://api.github.com/repos/w3c/mediacapture-record/subscribers","subscription_url":"https://api.github.com/repos/w3c/mediacapture-record/subscription","commits_url":"https://api.github.com/repos/w3c/mediacapture-record/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/mediacapture-record/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/mediacapture-record/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/mediacapture-record/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/mediacapture-record/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/mediacapture-record/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/mediacapture-record/merges","archive_url":"https://api.github.com/repos/w3c/mediacapture-record/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/mediacapture-record/downloads","issues_url":"https://api.github.com/repos/w3c/mediacapture-record/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/mediacapture-record/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/mediacapture-record/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/mediacapture-record/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/mediacapture-record/labels{/name}","releases_url":"https://api.github.com/repos/w3c/mediacapture-record/releases{/id}","created_at":"2014-08-20T12:03:51Z","updated_at":"2015-11-21T03:40:51Z","pushed_at":"2015-12-09T20:35:48Z","git_url":"git://github.com/w3c/mediacapture-record.git","ssh_url":"git@github.com:w3c/mediacapture-record.git","clone_url":"https://github.com/w3c/mediacapture-record.git","svn_url":"https://github.com/w3c/mediacapture-record","homepage":null,"size":13260,"stargazers_count":8,"watchers_count":8,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":15,"forks":5,"open_issues":15,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/mediacapture-record/pulls/38"},"html":{"href":"https://github.com/w3c/mediacapture-record/pull/38"},"issue":{"href":"https://api.github.com/repos/w3c/mediacapture-record/issues/38"},"comments":{"href":"https://api.github.com/repos/w3c/mediacapture-record/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/mediacapture-record/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/mediacapture-record/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/mediacapture-record/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/mediacapture-record/statuses/52460f0c04a602c9cf8fa3c8de3f047e5096208a"}}}}