{"action":"created","comment":{"url":"https://api.github.com/repos/gfx-rs/gfx-rs/pulls/comments/24286050","id":24286050,"diff_hunk":"@@ -89,20 +89,11 @@ impl<D: device::Device> Graphics<D> {\n \n     /// Draw a ref batch.\n     pub fn draw<'a, T: shade::ShaderParam>(&'a mut self,\n-        batch: &'a batch::RefBatch<T>, data: &'a T, frame: &Frame) {\n+                batch: &'a batch::RefBatch<T>, data: &'a T, frame: &Frame)\n+                -> Result<(), DrawError> {\n         self.renderer.draw(&(batch, data, &self.context), frame)\n     }\n \n-    /// Draw a ref batch with instancing\n-    pub fn draw_instanced<'a, T: shade::ShaderParam>(&'a mut self,\n-                          batch: &'a batch::RefBatch<T>,\n-                          data: &'a T,\n-                          count: u32,\n-                          vertex_offset: u32,\n-                          frame: &Frame) {\n-        self.renderer.draw_instanced((batch, data, &self.context), count, vertex_offset, frame)\n-    }\n-","path":"src/gfx/lib.rs","position":28,"original_position":28,"commit_id":"9d8bad2025fdd077d572fe8b9bf0d1c13326e0d8","original_commit_id":"9d8bad2025fdd077d572fe8b9bf0d1c13326e0d8","user":{"login":"bjz","id":695077,"avatar_url":"https://avatars.githubusercontent.com/u/695077?v=3","gravatar_id":"","url":"https://api.github.com/users/bjz","html_url":"https://github.com/bjz","followers_url":"https://api.github.com/users/bjz/followers","following_url":"https://api.github.com/users/bjz/following{/other_user}","gists_url":"https://api.github.com/users/bjz/gists{/gist_id}","starred_url":"https://api.github.com/users/bjz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjz/subscriptions","organizations_url":"https://api.github.com/users/bjz/orgs","repos_url":"https://api.github.com/users/bjz/repos","events_url":"https://api.github.com/users/bjz/events{/privacy}","received_events_url":"https://api.github.com/users/bjz/received_events","type":"User","site_admin":false},"body":"Ie. not need the `Graphics` thing.","created_at":"2015-02-07T02:50:12Z","updated_at":"2015-02-07T02:50:12Z","html_url":"https://github.com/gfx-rs/gfx-rs/pull/540#discussion_r24286050","pull_request_url":"https://api.github.com/repos/gfx-rs/gfx-rs/pulls/540","_links":{"self":{"href":"https://api.github.com/repos/gfx-rs/gfx-rs/pulls/comments/24286050"},"html":{"href":"https://github.com/gfx-rs/gfx-rs/pull/540#discussion_r24286050"},"pull_request":{"href":"https://api.github.com/repos/gfx-rs/gfx-rs/pulls/540"}}},"pull_request":{"url":"https://api.github.com/repos/gfx-rs/gfx-rs/pulls/540","id":28785174,"html_url":"https://github.com/gfx-rs/gfx-rs/pull/540","diff_url":"https://github.com/gfx-rs/gfx-rs/pull/540.diff","patch_url":"https://github.com/gfx-rs/gfx-rs/pull/540.patch","issue_url":"https://api.github.com/repos/gfx-rs/gfx-rs/issues/540","number":540,"state":"open","locked":false,"title":"Added draw call errors for missing targets","user":{"login":"kvark","id":107301,"avatar_url":"https://avatars.githubusercontent.com/u/107301?v=3","gravatar_id":"","url":"https://api.github.com/users/kvark","html_url":"https://github.com/kvark","followers_url":"https://api.github.com/users/kvark/followers","following_url":"https://api.github.com/users/kvark/following{/other_user}","gists_url":"https://api.github.com/users/kvark/gists{/gist_id}","starred_url":"https://api.github.com/users/kvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvark/subscriptions","organizations_url":"https://api.github.com/users/kvark/orgs","repos_url":"https://api.github.com/users/kvark/repos","events_url":"https://api.github.com/users/kvark/events{/privacy}","received_events_url":"https://api.github.com/users/kvark/received_events","type":"User","site_admin":false},"body":"Closes #525 \r\n\r\nNote: we also check for missing colors","created_at":"2015-02-06T04:52:12Z","updated_at":"2015-02-07T02:50:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bf00a5fbab49be3b8945ed9f54249452bc92f98","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gfx-rs/gfx-rs/pulls/540/commits","review_comments_url":"https://api.github.com/repos/gfx-rs/gfx-rs/pulls/540/comments","review_comment_url":"https://api.github.com/repos/gfx-rs/gfx-rs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gfx-rs/gfx-rs/issues/540/comments","statuses_url":"https://api.github.com/repos/gfx-rs/gfx-rs/statuses/9d8bad2025fdd077d572fe8b9bf0d1c13326e0d8","head":{"label":"kvark:draw","ref":"draw","sha":"9d8bad2025fdd077d572fe8b9bf0d1c13326e0d8","user":{"login":"kvark","id":107301,"avatar_url":"https://avatars.githubusercontent.com/u/107301?v=3","gravatar_id":"","url":"https://api.github.com/users/kvark","html_url":"https://github.com/kvark","followers_url":"https://api.github.com/users/kvark/followers","following_url":"https://api.github.com/users/kvark/following{/other_user}","gists_url":"https://api.github.com/users/kvark/gists{/gist_id}","starred_url":"https://api.github.com/users/kvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvark/subscriptions","organizations_url":"https://api.github.com/users/kvark/orgs","repos_url":"https://api.github.com/users/kvark/repos","events_url":"https://api.github.com/users/kvark/events{/privacy}","received_events_url":"https://api.github.com/users/kvark/received_events","type":"User","site_admin":false},"repo":{"id":21021936,"name":"gfx-rs","full_name":"kvark/gfx-rs","owner":{"login":"kvark","id":107301,"avatar_url":"https://avatars.githubusercontent.com/u/107301?v=3","gravatar_id":"","url":"https://api.github.com/users/kvark","html_url":"https://github.com/kvark","followers_url":"https://api.github.com/users/kvark/followers","following_url":"https://api.github.com/users/kvark/following{/other_user}","gists_url":"https://api.github.com/users/kvark/gists{/gist_id}","starred_url":"https://api.github.com/users/kvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvark/subscriptions","organizations_url":"https://api.github.com/users/kvark/orgs","repos_url":"https://api.github.com/users/kvark/repos","events_url":"https://api.github.com/users/kvark/events{/privacy}","received_events_url":"https://api.github.com/users/kvark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kvark/gfx-rs","description":"A lightweight graphics device manager for Rust","fork":true,"url":"https://api.github.com/repos/kvark/gfx-rs","forks_url":"https://api.github.com/repos/kvark/gfx-rs/forks","keys_url":"https://api.github.com/repos/kvark/gfx-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kvark/gfx-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kvark/gfx-rs/teams","hooks_url":"https://api.github.com/repos/kvark/gfx-rs/hooks","issue_events_url":"https://api.github.com/repos/kvark/gfx-rs/issues/events{/number}","events_url":"https://api.github.com/repos/kvark/gfx-rs/events","assignees_url":"https://api.github.com/repos/kvark/gfx-rs/assignees{/user}","branches_url":"https://api.github.com/repos/kvark/gfx-rs/branches{/branch}","tags_url":"https://api.github.com/repos/kvark/gfx-rs/tags","blobs_url":"https://api.github.com/repos/kvark/gfx-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kvark/gfx-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kvark/gfx-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/kvark/gfx-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kvark/gfx-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/kvark/gfx-rs/languages","stargazers_url":"https://api.github.com/repos/kvark/gfx-rs/stargazers","contributors_url":"https://api.github.com/repos/kvark/gfx-rs/contributors","subscribers_url":"https://api.github.com/repos/kvark/gfx-rs/subscribers","subscription_url":"https://api.github.com/repos/kvark/gfx-rs/subscription","commits_url":"https://api.github.com/repos/kvark/gfx-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/kvark/gfx-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/kvark/gfx-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/kvark/gfx-rs/issues/comments/{number}","contents_url":"https://api.github.com/repos/kvark/gfx-rs/contents/{+path}","compare_url":"https://api.github.com/repos/kvark/gfx-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kvark/gfx-rs/merges","archive_url":"https://api.github.com/repos/kvark/gfx-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kvark/gfx-rs/downloads","issues_url":"https://api.github.com/repos/kvark/gfx-rs/issues{/number}","pulls_url":"https://api.github.com/repos/kvark/gfx-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/kvark/gfx-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/kvark/gfx-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kvark/gfx-rs/labels{/name}","releases_url":"https://api.github.com/repos/kvark/gfx-rs/releases{/id}","created_at":"2014-06-20T01:55:38Z","updated_at":"2015-02-02T05:08:29Z","pushed_at":"2015-02-06T04:51:19Z","git_url":"git://github.com/kvark/gfx-rs.git","ssh_url":"git@github.com:kvark/gfx-rs.git","clone_url":"https://github.com/kvark/gfx-rs.git","svn_url":"https://github.com/kvark/gfx-rs","homepage":"","size":2360,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gfx-rs:master","ref":"master","sha":"a8bb6ff110acdbb1a6e183af8a9246f84a4cae87","user":{"login":"gfx-rs","id":8213174,"avatar_url":"https://avatars.githubusercontent.com/u/8213174?v=3","gravatar_id":"","url":"https://api.github.com/users/gfx-rs","html_url":"https://github.com/gfx-rs","followers_url":"https://api.github.com/users/gfx-rs/followers","following_url":"https://api.github.com/users/gfx-rs/following{/other_user}","gists_url":"https://api.github.com/users/gfx-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gfx-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfx-rs/subscriptions","organizations_url":"https://api.github.com/users/gfx-rs/orgs","repos_url":"https://api.github.com/users/gfx-rs/repos","events_url":"https://api.github.com/users/gfx-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gfx-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":13847975,"name":"gfx-rs","full_name":"gfx-rs/gfx-rs","owner":{"login":"gfx-rs","id":8213174,"avatar_url":"https://avatars.githubusercontent.com/u/8213174?v=3","gravatar_id":"","url":"https://api.github.com/users/gfx-rs","html_url":"https://github.com/gfx-rs","followers_url":"https://api.github.com/users/gfx-rs/followers","following_url":"https://api.github.com/users/gfx-rs/following{/other_user}","gists_url":"https://api.github.com/users/gfx-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gfx-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfx-rs/subscriptions","organizations_url":"https://api.github.com/users/gfx-rs/orgs","repos_url":"https://api.github.com/users/gfx-rs/repos","events_url":"https://api.github.com/users/gfx-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gfx-rs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gfx-rs/gfx-rs","description":"A high-performance, bindless graphics API for Rust.","fork":false,"url":"https://api.github.com/repos/gfx-rs/gfx-rs","forks_url":"https://api.github.com/repos/gfx-rs/gfx-rs/forks","keys_url":"https://api.github.com/repos/gfx-rs/gfx-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gfx-rs/gfx-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gfx-rs/gfx-rs/teams","hooks_url":"https://api.github.com/repos/gfx-rs/gfx-rs/hooks","issue_events_url":"https://api.github.com/repos/gfx-rs/gfx-rs/issues/events{/number}","events_url":"https://api.github.com/repos/gfx-rs/gfx-rs/events","assignees_url":"https://api.github.com/repos/gfx-rs/gfx-rs/assignees{/user}","branches_url":"https://api.github.com/repos/gfx-rs/gfx-rs/branches{/branch}","tags_url":"https://api.github.com/repos/gfx-rs/gfx-rs/tags","blobs_url":"https://api.github.com/repos/gfx-rs/gfx-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gfx-rs/gfx-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gfx-rs/gfx-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gfx-rs/gfx-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gfx-rs/gfx-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/gfx-rs/gfx-rs/languages","stargazers_url":"https://api.github.com/repos/gfx-rs/gfx-rs/stargazers","contributors_url":"https://api.github.com/repos/gfx-rs/gfx-rs/contributors","subscribers_url":"https://api.github.com/repos/gfx-rs/gfx-rs/subscribers","subscription_url":"https://api.github.com/repos/gfx-rs/gfx-rs/subscription","commits_url":"https://api.github.com/repos/gfx-rs/gfx-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gfx-rs/gfx-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gfx-rs/gfx-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gfx-rs/gfx-rs/issues/comments/{number}","contents_url":"https://api.github.com/repos/gfx-rs/gfx-rs/contents/{+path}","compare_url":"https://api.github.com/repos/gfx-rs/gfx-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gfx-rs/gfx-rs/merges","archive_url":"https://api.github.com/repos/gfx-rs/gfx-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gfx-rs/gfx-rs/downloads","issues_url":"https://api.github.com/repos/gfx-rs/gfx-rs/issues{/number}","pulls_url":"https://api.github.com/repos/gfx-rs/gfx-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/gfx-rs/gfx-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/gfx-rs/gfx-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gfx-rs/gfx-rs/labels{/name}","releases_url":"https://api.github.com/repos/gfx-rs/gfx-rs/releases{/id}","created_at":"2013-10-25T00:35:35Z","updated_at":"2015-02-06T04:10:13Z","pushed_at":"2015-02-06T04:10:13Z","git_url":"git://github.com/gfx-rs/gfx-rs.git","ssh_url":"git@github.com:gfx-rs/gfx-rs.git","clone_url":"https://github.com/gfx-rs/gfx-rs.git","svn_url":"https://github.com/gfx-rs/gfx-rs","homepage":"http://gfx-rs.github.io/","size":4161,"stargazers_count":280,"watchers_count":280,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":64,"forks":62,"open_issues":64,"watchers":280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gfx-rs/gfx-rs/pulls/540"},"html":{"href":"https://github.com/gfx-rs/gfx-rs/pull/540"},"issue":{"href":"https://api.github.com/repos/gfx-rs/gfx-rs/issues/540"},"comments":{"href":"https://api.github.com/repos/gfx-rs/gfx-rs/issues/540/comments"},"review_comments":{"href":"https://api.github.com/repos/gfx-rs/gfx-rs/pulls/540/comments"},"review_comment":{"href":"https://api.github.com/repos/gfx-rs/gfx-rs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gfx-rs/gfx-rs/pulls/540/commits"},"statuses":{"href":"https://api.github.com/repos/gfx-rs/gfx-rs/statuses/9d8bad2025fdd077d572fe8b9bf0d1c13326e0d8"}}}}