{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/36728941","id":36728941,"diff_hunk":"@@ -185,4 +176,35 @@ private function getXmlErrors($internalErrors)\n \n         return $errors;\n     }\n+\n+    /**\n+     * @param \\SimpleXMLElement $noteElement\n+     * @param string            $encoding\n+     *\n+     * @return array\n+     */\n+    private function setNotesMetadata($noteElement = null, $encoding = null)","path":"src/Symfony/Component/Translation/Loader/XliffFileLoader.php","position":44,"original_position":44,"commit_id":"7d97c1b3abe5141048bd445f3277363cdf8d44f1","original_commit_id":"7d97c1b3abe5141048bd445f3277363cdf8d44f1","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"the function name is weird. It is not setting anything. It is reading attributes.\r\n\r\nAnd the ``$noteElement`` argument should be typehinted","created_at":"2015-08-11T10:00:46Z","updated_at":"2015-08-11T10:00:46Z","html_url":"https://github.com/symfony/symfony/pull/15452#discussion_r36728941","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/15452","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/36728941"},"html":{"href":"https://github.com/symfony/symfony/pull/15452#discussion_r36728941"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15452"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/15452","id":41608926,"html_url":"https://github.com/symfony/symfony/pull/15452","diff_url":"https://github.com/symfony/symfony/pull/15452.diff","patch_url":"https://github.com/symfony/symfony/pull/15452.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/15452","number":15452,"state":"open","locked":false,"title":"[Translator] [Xliff] Add support for target attributes.","user":{"login":"marcosdsanchez","id":45263,"avatar_url":"https://avatars.githubusercontent.com/u/45263?v=3","gravatar_id":"","url":"https://api.github.com/users/marcosdsanchez","html_url":"https://github.com/marcosdsanchez","followers_url":"https://api.github.com/users/marcosdsanchez/followers","following_url":"https://api.github.com/users/marcosdsanchez/following{/other_user}","gists_url":"https://api.github.com/users/marcosdsanchez/gists{/gist_id}","starred_url":"https://api.github.com/users/marcosdsanchez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcosdsanchez/subscriptions","organizations_url":"https://api.github.com/users/marcosdsanchez/orgs","repos_url":"https://api.github.com/users/marcosdsanchez/repos","events_url":"https://api.github.com/users/marcosdsanchez/events{/privacy}","received_events_url":"https://api.github.com/users/marcosdsanchez/received_events","type":"User","site_admin":false},"body":"The previous implementation ignored attributes in target nodes in xliff files\r\nso they were lost when you loaded and then dumped the same file. This change\r\nshould fix that problem.\r\n\r\n| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | N/A\r\n| License       | MIT\r\n| Doc PR        | N/A\r\n","created_at":"2015-08-04T19:41:32Z","updated_at":"2015-08-11T10:00:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e99a9e40ac5c603115f1f21ec849f792f521c1cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/15452/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/15452/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/15452/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/7d97c1b3abe5141048bd445f3277363cdf8d44f1","head":{"label":"marcosdsanchez:keep-xliff-attributes","ref":"keep-xliff-attributes","sha":"7d97c1b3abe5141048bd445f3277363cdf8d44f1","user":{"login":"marcosdsanchez","id":45263,"avatar_url":"https://avatars.githubusercontent.com/u/45263?v=3","gravatar_id":"","url":"https://api.github.com/users/marcosdsanchez","html_url":"https://github.com/marcosdsanchez","followers_url":"https://api.github.com/users/marcosdsanchez/followers","following_url":"https://api.github.com/users/marcosdsanchez/following{/other_user}","gists_url":"https://api.github.com/users/marcosdsanchez/gists{/gist_id}","starred_url":"https://api.github.com/users/marcosdsanchez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcosdsanchez/subscriptions","organizations_url":"https://api.github.com/users/marcosdsanchez/orgs","repos_url":"https://api.github.com/users/marcosdsanchez/repos","events_url":"https://api.github.com/users/marcosdsanchez/events{/privacy}","received_events_url":"https://api.github.com/users/marcosdsanchez/received_events","type":"User","site_admin":false},"repo":{"id":20976740,"name":"symfony","full_name":"marcosdsanchez/symfony","owner":{"login":"marcosdsanchez","id":45263,"avatar_url":"https://avatars.githubusercontent.com/u/45263?v=3","gravatar_id":"","url":"https://api.github.com/users/marcosdsanchez","html_url":"https://github.com/marcosdsanchez","followers_url":"https://api.github.com/users/marcosdsanchez/followers","following_url":"https://api.github.com/users/marcosdsanchez/following{/other_user}","gists_url":"https://api.github.com/users/marcosdsanchez/gists{/gist_id}","starred_url":"https://api.github.com/users/marcosdsanchez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcosdsanchez/subscriptions","organizations_url":"https://api.github.com/users/marcosdsanchez/orgs","repos_url":"https://api.github.com/users/marcosdsanchez/repos","events_url":"https://api.github.com/users/marcosdsanchez/events{/privacy}","received_events_url":"https://api.github.com/users/marcosdsanchez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcosdsanchez/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/marcosdsanchez/symfony","forks_url":"https://api.github.com/repos/marcosdsanchez/symfony/forks","keys_url":"https://api.github.com/repos/marcosdsanchez/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcosdsanchez/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcosdsanchez/symfony/teams","hooks_url":"https://api.github.com/repos/marcosdsanchez/symfony/hooks","issue_events_url":"https://api.github.com/repos/marcosdsanchez/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/marcosdsanchez/symfony/events","assignees_url":"https://api.github.com/repos/marcosdsanchez/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/marcosdsanchez/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/marcosdsanchez/symfony/tags","blobs_url":"https://api.github.com/repos/marcosdsanchez/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcosdsanchez/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcosdsanchez/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcosdsanchez/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcosdsanchez/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/marcosdsanchez/symfony/languages","stargazers_url":"https://api.github.com/repos/marcosdsanchez/symfony/stargazers","contributors_url":"https://api.github.com/repos/marcosdsanchez/symfony/contributors","subscribers_url":"https://api.github.com/repos/marcosdsanchez/symfony/subscribers","subscription_url":"https://api.github.com/repos/marcosdsanchez/symfony/subscription","commits_url":"https://api.github.com/repos/marcosdsanchez/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcosdsanchez/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcosdsanchez/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcosdsanchez/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcosdsanchez/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/marcosdsanchez/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcosdsanchez/symfony/merges","archive_url":"https://api.github.com/repos/marcosdsanchez/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcosdsanchez/symfony/downloads","issues_url":"https://api.github.com/repos/marcosdsanchez/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/marcosdsanchez/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/marcosdsanchez/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/marcosdsanchez/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcosdsanchez/symfony/labels{/name}","releases_url":"https://api.github.com/repos/marcosdsanchez/symfony/releases{/id}","created_at":"2014-06-18T20:20:19Z","updated_at":"2014-06-18T20:20:27Z","pushed_at":"2015-08-04T19:39:30Z","git_url":"git://github.com/marcosdsanchez/symfony.git","ssh_url":"git@github.com:marcosdsanchez/symfony.git","clone_url":"https://github.com/marcosdsanchez/symfony.git","svn_url":"https://github.com/marcosdsanchez/symfony","homepage":"symfony.com","size":57573,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.8","ref":"2.8","sha":"64d050769b868ca399cb0ba73f5a7ffb86280e75","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-08-11T06:12:00Z","pushed_at":"2015-08-11T09:41:39Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":234257,"stargazers_count":10608,"watchers_count":10608,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4202,"mirror_url":null,"open_issues_count":889,"forks":4202,"open_issues":889,"watchers":10608,"default_branch":"2.8"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15452"},"html":{"href":"https://github.com/symfony/symfony/pull/15452"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/15452"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/15452/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15452/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15452/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/7d97c1b3abe5141048bd445f3277363cdf8d44f1"}}}}