{"action":"closed","number":4752,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/4752","id":22916044,"html_url":"https://github.com/joomla/joomla-cms/pull/4752","diff_url":"https://github.com/joomla/joomla-cms/pull/4752.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/4752.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/4752","number":4752,"state":"closed","locked":false,"title":"Fix: PHP undefined notice in caching file storage","user":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"body":"see: http://issues.joomla.org/tracker/joomla-cms/2535 & https://github.com/joomla/joomla-cms/issues/2535\r\n\r\n#### Steps to reproduce the issue\r\n1. configure caching to be file based in configuration.php\r\n2. use callback as handler \r\n3. lock the id\r\n4. remove the cache file \r\n5. unlock the id now   \r\n\r\n#### Expected result\r\nIf the cache file has beem removed, the unlock should just return true. \r\n\r\n#### Actual result\r\nGet php undefined variable notice: \r\nNotice: Undefined variable: ret in web/libraries/joomla/cache/storage/file.php on line <i>333</i>\r\n\r\n#### System information (as much as possible)\r\nLinux, Joomla 3.2 latest.","created_at":"2014-10-17T10:32:31Z","updated_at":"2015-05-31T08:42:34Z","closed_at":"2015-05-31T08:42:34Z","merged_at":null,"merge_commit_sha":"c2f5b83554f921b9950dfafee1029c9e9d9a9012","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/4752/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/4752/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/4752/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/9d44712b60ae2f71160581950961d01bca463874","head":{"label":"zero-24:patch-3","ref":"patch-3","sha":"9d44712b60ae2f71160581950961d01bca463874","user":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"repo":{"id":9977367,"name":"joomla-cms","full_name":"zero-24/joomla-cms","owner":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zero-24/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/zero-24/joomla-cms","forks_url":"https://api.github.com/repos/zero-24/joomla-cms/forks","keys_url":"https://api.github.com/repos/zero-24/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zero-24/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zero-24/joomla-cms/teams","hooks_url":"https://api.github.com/repos/zero-24/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/zero-24/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/zero-24/joomla-cms/events","assignees_url":"https://api.github.com/repos/zero-24/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/zero-24/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/zero-24/joomla-cms/tags","blobs_url":"https://api.github.com/repos/zero-24/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zero-24/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zero-24/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/zero-24/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zero-24/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/zero-24/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/zero-24/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/zero-24/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/zero-24/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/zero-24/joomla-cms/subscription","commits_url":"https://api.github.com/repos/zero-24/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/zero-24/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/zero-24/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/zero-24/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/zero-24/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/zero-24/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zero-24/joomla-cms/merges","archive_url":"https://api.github.com/repos/zero-24/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zero-24/joomla-cms/downloads","issues_url":"https://api.github.com/repos/zero-24/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/zero-24/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/zero-24/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/zero-24/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zero-24/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/zero-24/joomla-cms/releases{/id}","created_at":"2013-05-10T08:20:03Z","updated_at":"2015-03-31T19:00:26Z","pushed_at":"2015-05-31T08:42:34Z","git_url":"git://github.com/zero-24/joomla-cms.git","ssh_url":"git@github.com:zero-24/joomla-cms.git","clone_url":"https://github.com/zero-24/joomla-cms.git","svn_url":"https://github.com/zero-24/joomla-cms","homepage":"http://joomla.org","size":135709,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"fb5d0c1f163a15df6e71774ed73a1f9f6876e735","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","created_at":"2011-09-27T02:07:38Z","updated_at":"2015-05-29T15:21:00Z","pushed_at":"2015-05-31T08:41:04Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"http://joomla.org","size":350202,"stargazers_count":1554,"watchers_count":1554,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1734,"mirror_url":null,"open_issues_count":589,"forks":1734,"open_issues":589,"watchers":1554,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/4752"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/4752"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/4752"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/4752/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/4752/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/4752/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/9d44712b60ae2f71160581950961d01bca463874"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":5,"review_comments":0,"commits":2,"additions":22,"deletions":19,"changed_files":1}}