{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/45917795","id":45917795,"diff_hunk":"@@ -19,11 +19,16 @@\n \t\t<language tag=\"en-GB\">en-GB/en-GB.plg_system_stats.sys.ini</language>\n \t</languages>\n \t<config>\n-\t\t<fields name=\"params\" addfieldpath=\"/plugins/system/stats/fields\">\n+\t\t<fields name=\"params\" addfieldpath=\"/plugins/system/stats/field\">\n \t\t\t<fieldset name=\"basic\">\n \t\t\t\t<field\n+\t\t\t\t\tname=\"data\"\n+\t\t\t\t\ttype=\"plgsystemstats.data\"","path":"plugins/system/stats/stats.xml","position":18,"original_position":18,"commit_id":"e18b20c5aebb836def320669e9643727e346debc","original_commit_id":"e18b20c5aebb836def320669e9643727e346debc","user":{"login":"roland-d","id":359377,"avatar_url":"https://avatars.githubusercontent.com/u/359377?v=3","gravatar_id":"","url":"https://api.github.com/users/roland-d","html_url":"https://github.com/roland-d","followers_url":"https://api.github.com/users/roland-d/followers","following_url":"https://api.github.com/users/roland-d/following{/other_user}","gists_url":"https://api.github.com/users/roland-d/gists{/gist_id}","starred_url":"https://api.github.com/users/roland-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roland-d/subscriptions","organizations_url":"https://api.github.com/users/roland-d/orgs","repos_url":"https://api.github.com/users/roland-d/repos","events_url":"https://api.github.com/users/roland-d/events{/privacy}","received_events_url":"https://api.github.com/users/roland-d/received_events","type":"User","site_admin":false},"body":"@phproberto Is this new, types separated by a dot? If so, we should document that somewhere.","created_at":"2015-11-25T20:53:08Z","updated_at":"2015-11-25T20:53:08Z","html_url":"https://github.com/joomla/joomla-cms/pull/8386#discussion_r45917795","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/8386","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/45917795"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/8386#discussion_r45917795"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/8386"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/8386","id":50455387,"html_url":"https://github.com/joomla/joomla-cms/pull/8386","diff_url":"https://github.com/joomla/joomla-cms/pull/8386.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/8386.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/8386","number":8386,"state":"open","locked":false,"title":"Statistics plugin improvements","user":{"login":"phproberto","id":1119272,"avatar_url":"https://avatars.githubusercontent.com/u/1119272?v=3","gravatar_id":"","url":"https://api.github.com/users/phproberto","html_url":"https://github.com/phproberto","followers_url":"https://api.github.com/users/phproberto/followers","following_url":"https://api.github.com/users/phproberto/following{/other_user}","gists_url":"https://api.github.com/users/phproberto/gists{/gist_id}","starred_url":"https://api.github.com/users/phproberto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phproberto/subscriptions","organizations_url":"https://api.github.com/users/phproberto/orgs","repos_url":"https://api.github.com/users/phproberto/repos","events_url":"https://api.github.com/users/phproberto/events{/privacy}","received_events_url":"https://api.github.com/users/phproberto/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nThis changes the JFormField to:\r\n\r\n* Make public the getRenderer() function. \r\n* Allow to easily override the layout include paths in any child field creating an override of the  `getLayoutPaths()` method.\r\n\r\nMaking getRenderer() method public allows to render layouts inside other layouts like:\r\n\r\n```php\r\n<a href=\"http://joomla.org\">Joomla</a>\r\n<?php \r\n    // Render `sample.layout` layout inside this layout\r\n    echo $field->getRenderer('sample.layout')->render($displayData);\r\n?>\r\n<p>Another paragraph</p>\r\n```\r\n\r\nYou can see below how I used it to render a common `stats` layout that is renderer in both `message` and `field.data` layouts.\r\n\r\nThis PR also improves the statistics system plugin:\r\n* Changed plugin fields prefix to plgsystemstats to avoid conflicts with any extension using `stats` prefix. Before: `type=\"stats.uniqueid\"` after: `type=\"plgsystemstats.uniqueid\"`\r\n* Remove uniqueid field getInput() method and use the fields layout system so 100% of the plugin output is overridable.\r\n* Create new field data that will be used to render the stats that are going to be sent in the plugin settings view.\r\n\r\n![stats-params-data](https://cloud.githubusercontent.com/assets/1119272/11106927/4e93abc4-88d9-11e5-90cf-1b5ad6e6ed89.png)\r\n\r\n## How to test\r\n\r\n1. This changes the field layout system so you should test that fields that are currently using layouts work as expected. The only fields using it are `JFormFieldRadio` & `JFormFieldCheckboxes` so the best way to check is to edit the codemirror plugin that includes both fields in its settings.\r\n2. Enable debug in statistics system plugin and test that the message selecting the user to configure statistics mode is shown. Also confirm that when you click in `Click here to see which information will be sent.` data is shown below.\r\n3. Go to statistics system plugin settings and confirm that when you click in `Click here to see which information will be sent.` data appears below.","created_at":"2015-11-12T00:10:50Z","updated_at":"2015-11-25T20:53:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e860f573ef5644f1b21324e3a3818139286a47c9","assignee":null,"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/7","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla!%203.5.0","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/7/labels","id":944889,"number":7,"title":"Joomla! 3.5.0","description":"","creator":{"login":"rdeutz","id":467356,"avatar_url":"https://avatars.githubusercontent.com/u/467356?v=3","gravatar_id":"","url":"https://api.github.com/users/rdeutz","html_url":"https://github.com/rdeutz","followers_url":"https://api.github.com/users/rdeutz/followers","following_url":"https://api.github.com/users/rdeutz/following{/other_user}","gists_url":"https://api.github.com/users/rdeutz/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeutz/subscriptions","organizations_url":"https://api.github.com/users/rdeutz/orgs","repos_url":"https://api.github.com/users/rdeutz/repos","events_url":"https://api.github.com/users/rdeutz/events{/privacy}","received_events_url":"https://api.github.com/users/rdeutz/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":407,"state":"open","created_at":"2015-01-21T08:12:44Z","updated_at":"2015-11-25T07:34:47Z","due_on":"2015-12-07T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/8386/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/8386/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/8386/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/e18b20c5aebb836def320669e9643727e346debc","head":{"label":"phproberto:stats","ref":"stats","sha":"e18b20c5aebb836def320669e9643727e346debc","user":{"login":"phproberto","id":1119272,"avatar_url":"https://avatars.githubusercontent.com/u/1119272?v=3","gravatar_id":"","url":"https://api.github.com/users/phproberto","html_url":"https://github.com/phproberto","followers_url":"https://api.github.com/users/phproberto/followers","following_url":"https://api.github.com/users/phproberto/following{/other_user}","gists_url":"https://api.github.com/users/phproberto/gists{/gist_id}","starred_url":"https://api.github.com/users/phproberto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phproberto/subscriptions","organizations_url":"https://api.github.com/users/phproberto/orgs","repos_url":"https://api.github.com/users/phproberto/repos","events_url":"https://api.github.com/users/phproberto/events{/privacy}","received_events_url":"https://api.github.com/users/phproberto/received_events","type":"User","site_admin":false},"repo":{"id":36571689,"name":"joomla-cms","full_name":"phproberto/joomla-cms","owner":{"login":"phproberto","id":1119272,"avatar_url":"https://avatars.githubusercontent.com/u/1119272?v=3","gravatar_id":"","url":"https://api.github.com/users/phproberto","html_url":"https://github.com/phproberto","followers_url":"https://api.github.com/users/phproberto/followers","following_url":"https://api.github.com/users/phproberto/following{/other_user}","gists_url":"https://api.github.com/users/phproberto/gists{/gist_id}","starred_url":"https://api.github.com/users/phproberto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phproberto/subscriptions","organizations_url":"https://api.github.com/users/phproberto/orgs","repos_url":"https://api.github.com/users/phproberto/repos","events_url":"https://api.github.com/users/phproberto/events{/privacy}","received_events_url":"https://api.github.com/users/phproberto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phproberto/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/phproberto/joomla-cms","forks_url":"https://api.github.com/repos/phproberto/joomla-cms/forks","keys_url":"https://api.github.com/repos/phproberto/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phproberto/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phproberto/joomla-cms/teams","hooks_url":"https://api.github.com/repos/phproberto/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/phproberto/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/phproberto/joomla-cms/events","assignees_url":"https://api.github.com/repos/phproberto/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/phproberto/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/phproberto/joomla-cms/tags","blobs_url":"https://api.github.com/repos/phproberto/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phproberto/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phproberto/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/phproberto/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phproberto/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/phproberto/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/phproberto/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/phproberto/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/phproberto/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/phproberto/joomla-cms/subscription","commits_url":"https://api.github.com/repos/phproberto/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/phproberto/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/phproberto/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/phproberto/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/phproberto/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/phproberto/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phproberto/joomla-cms/merges","archive_url":"https://api.github.com/repos/phproberto/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phproberto/joomla-cms/downloads","issues_url":"https://api.github.com/repos/phproberto/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/phproberto/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/phproberto/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/phproberto/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phproberto/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/phproberto/joomla-cms/releases{/id}","created_at":"2015-05-30T19:05:14Z","updated_at":"2015-05-30T19:05:28Z","pushed_at":"2015-11-23T11:38:48Z","git_url":"git://github.com/phproberto/joomla-cms.git","ssh_url":"git@github.com:phproberto/joomla-cms.git","clone_url":"https://github.com/phproberto/joomla-cms.git","svn_url":"https://github.com/phproberto/joomla-cms","homepage":"http://joomla.org","size":136317,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"e1fe2e4a8b02f8fc130677daf0db91c1b394a5d1","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","created_at":"2011-09-27T02:07:38Z","updated_at":"2015-11-23T18:08:19Z","pushed_at":"2015-11-25T20:26:11Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":201063,"stargazers_count":1738,"watchers_count":1738,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1963,"mirror_url":null,"open_issues_count":545,"forks":1963,"open_issues":545,"watchers":1738,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/8386"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/8386"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/8386"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/8386/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/8386/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/8386/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/e18b20c5aebb836def320669e9643727e346debc"}}}}