{"action":"created","issue":{"url":"https://api.github.com/repos/frontend-labs/flux/issues/45","labels_url":"https://api.github.com/repos/frontend-labs/flux/issues/45/labels{/name}","comments_url":"https://api.github.com/repos/frontend-labs/flux/issues/45/comments","events_url":"https://api.github.com/repos/frontend-labs/flux/issues/45/events","html_url":"https://github.com/frontend-labs/flux/pull/45","id":99683451,"number":45,"title":"feat(flux): Se desvincula la libería yOSON","user":{"login":"carloshs92","id":1372633,"avatar_url":"https://avatars.githubusercontent.com/u/1372633?v=3","gravatar_id":"","url":"https://api.github.com/users/carloshs92","html_url":"https://github.com/carloshs92","followers_url":"https://api.github.com/users/carloshs92/followers","following_url":"https://api.github.com/users/carloshs92/following{/other_user}","gists_url":"https://api.github.com/users/carloshs92/gists{/gist_id}","starred_url":"https://api.github.com/users/carloshs92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carloshs92/subscriptions","organizations_url":"https://api.github.com/users/carloshs92/orgs","repos_url":"https://api.github.com/users/carloshs92/repos","events_url":"https://api.github.com/users/carloshs92/events{/privacy}","received_events_url":"https://api.github.com/users/carloshs92/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/frontend-labs/flux/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/frontend-labs/flux/labels/refactor","name":"refactor","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"jansanchez","id":2623671,"avatar_url":"https://avatars.githubusercontent.com/u/2623671?v=3","gravatar_id":"","url":"https://api.github.com/users/jansanchez","html_url":"https://github.com/jansanchez","followers_url":"https://api.github.com/users/jansanchez/followers","following_url":"https://api.github.com/users/jansanchez/following{/other_user}","gists_url":"https://api.github.com/users/jansanchez/gists{/gist_id}","starred_url":"https://api.github.com/users/jansanchez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jansanchez/subscriptions","organizations_url":"https://api.github.com/users/jansanchez/orgs","repos_url":"https://api.github.com/users/jansanchez/repos","events_url":"https://api.github.com/users/jansanchez/events{/privacy}","received_events_url":"https://api.github.com/users/jansanchez/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2015-08-07T16:31:42Z","updated_at":"2015-08-07T17:34:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/frontend-labs/flux/pulls/45","html_url":"https://github.com/frontend-labs/flux/pull/45","diff_url":"https://github.com/frontend-labs/flux/pull/45.diff","patch_url":"https://github.com/frontend-labs/flux/pull/45.patch"},"body":"- Cambios en la estructura de carpetas en pre_css, pre_js y pre_html\r\n- Cambios en el renderizado de secciones del servidor expressjs\r\n- Se retira la dependencia que tiene flux con el yoson para la realizacion\r\nde las pruebas con mocha\n<a href='#crh-start'></a><a href='#crh-data-%7B%22approved%22%3A%20%7B%22https%3A//github.com/jansanchez%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/2623671%3Fv%3D3%22%7D%2C%20%22https%3A//github.com/lavaldi%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1221474%3Fv%3D3%22%7D%7D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/frontend-labs/flux/pull/45%23issuecomment-128764281%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3Ashipit%3A%22%2C%20%22created_at%22%3A%20%222015-08-07T16%3A55%3A46Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1221474%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/lavaldi%22%7D%7D%2C%20%7B%22body%22%3A%20%22%40jansanchez%20%20Revisa%20por%20favor%20%3Abook%3A%20%5Cr%5Cn%22%2C%20%22created_at%22%3A%20%222015-08-07T16%3A58%3A16Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1372633%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/carloshs92%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%22%2C%20%22created_at%22%3A%20%222015-08-07T17%3A16%3A14Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1372633%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/carloshs92%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3Ashipit%3A%22%2C%20%22created_at%22%3A%20%222015-08-07T17%3A22%3A02Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/2623671%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/jansanchez%22%7D%7D%2C%20%7B%22body%22%3A%20%22Info%3A%20Este%20pull%20request%20genero%204%20commits.%22%2C%20%22created_at%22%3A%20%222015-08-07T17%3A22%3A34Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/2623671%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/jansanchez%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%22%2C%20%22created_at%22%3A%20%222015-08-07T17%3A30%3A21Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/729789%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/andru255%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%2C%20%22Pull%20b4feff6827a79e89e046417a1011439ad4d1782c%20frontend/config/tasks/gulp_html.js%203%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/frontend-labs/flux/pull/45%23discussion_r36537151%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Aqu%5Cu00ed%20hay%202%20lineas%20con%20indentaci%5Cu00f3n%20fuera%20de%20lo%20com%5Cu00fan.%22%2C%20%22created_at%22%3A%20%222015-08-07T16%3A46%3A56Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/2623671%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/jansanchez%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-08-07T16%3A57%3A50Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/2623671%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/jansanchez%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20frontend/config/tasks/gulp_html.js%3AL33-40%22%7D%2C%20%22Pull%20b4feff6827a79e89e046417a1011439ad4d1782c%20frontend/source/pre_js/sections/home/inicio.coffee%202%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/frontend-labs/flux/pull/45%23discussion_r36537093%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Lo%20ideal%20seria%20no%20usar%20%5C%22SpanGlish%5C%22%2C%20menos%20si%20es%20un%20ejemplo.%5Cr%5CnAdicionalmente%20corregir%20%5C%22lenguage%5C%22.%22%2C%20%22created_at%22%3A%20%222015-08-07T16%3A46%3A18Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/2623671%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/jansanchez%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-08-07T16%3A57%3A50Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/2623671%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/jansanchez%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20frontend/source/pre_js/sections/home/inicio.coffee%3AL1-9%22%7D%2C%20%22Pull%20b4feff6827a79e89e046417a1011439ad4d1782c%20frontend/tests/mocha/sections/home/test_default.js%203%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/frontend-labs/flux/pull/45%23discussion_r36537063%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Ser%5Cu00eda%20ideal%20%2C%20no%20usar%20%5C%22Spanglish%5C%22.%5Cr%5Cn%5Cr%5CnSe%20sugiere%20que%20la%20funci%5Cu00f3n%20%5C%22saludar%5C%22%20se%20renombre%20%5C%22sayHi%5C%22%20ya%20que%20el%20c%5Cu00f3digo%20de%20ejemplo%20esta%20en%20ingl%5Cu00e9s.%5Cr%5Cn%22%2C%20%22created_at%22%3A%20%222015-08-07T16%3A45%3A56Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/2623671%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/jansanchez%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-complete%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-08-07T16%3A57%3A50Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/2623671%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/jansanchez%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20frontend/tests/mocha/sections/home/test_default.js%3AL1-16%22%7D%7D%2C%20%22processed%22%3A%20%5B%22https%3A//github.com/frontend-labs/flux/pull/45%23issuecomment-128764281%22%2C%20%22https%3A//github.com/frontend-labs/flux/pull/45%23issuecomment-128765453%22%2C%20%22https%3A//github.com/frontend-labs/flux/pull/45%23issuecomment-128770296%22%2C%20%22https%3A//github.com/frontend-labs/flux/pull/45%23issuecomment-128771493%22%2C%20%22https%3A//github.com/frontend-labs/flux/pull/45%23discussion_r36537063%22%2C%20%22https%3A//github.com/frontend-labs/flux/pull/45%23discussion_r36537093%22%2C%20%22https%3A//github.com/frontend-labs/flux/pull/45%23discussion_r36537151%22%2C%20%22https%3A//github.com/frontend-labs/flux/pull/45%23discussion_r36538083%22%2C%20%22https%3A//github.com/frontend-labs/flux/pull/45%23discussion_r36538085%22%2C%20%22https%3A//github.com/frontend-labs/flux/pull/45%23discussion_r36538086%22%2C%20%22https%3A//github.com/frontend-labs/flux/pull/45%23issuecomment-128771586%22%2C%20%22https%3A//github.com/frontend-labs/flux/pull/45%23issuecomment-128773094%22%5D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n\n<img src='http://www.codereviewhub.com/site/github-approved-avatar.png'><a href='https://github.com/jansanchez'><img src='https://avatars.githubusercontent.com/u/2623671?v=3' width=34 height=34></a><a href='https://github.com/lavaldi'><img src='https://avatars.githubusercontent.com/u/1221474?v=3' width=34 height=34></a>\n\n- [x] <a href='#crh-comment-Pull b4feff6827a79e89e046417a1011439ad4d1782c frontend/tests/mocha/sections/home/test_default.js 3'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/frontend-labs/flux/pull/45#discussion_r36537063'>File: frontend/tests/mocha/sections/home/test_default.js:L1-16</a></b>\n- <a href='https://github.com/jansanchez'><img border=0 src='https://avatars.githubusercontent.com/u/2623671?v=3' height=16 width=16'></a> Sería ideal , no usar \"Spanglish\".\nSe sugiere que la función \"saludar\" se renombre \"sayHi\" ya que el código de ejemplo esta en inglés.\n- [x] <a href='#crh-comment-Pull b4feff6827a79e89e046417a1011439ad4d1782c frontend/source/pre_js/sections/home/inicio.coffee 2'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/frontend-labs/flux/pull/45#discussion_r36537093'>File: frontend/source/pre_js/sections/home/inicio.coffee:L1-9</a></b>\n- <a href='https://github.com/jansanchez'><img border=0 src='https://avatars.githubusercontent.com/u/2623671?v=3' height=16 width=16'></a> Lo ideal seria no usar \"SpanGlish\", menos si es un ejemplo.\nAdicionalmente corregir \"lenguage\".\n- [x] <a href='#crh-comment-Pull b4feff6827a79e89e046417a1011439ad4d1782c frontend/config/tasks/gulp_html.js 3'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/frontend-labs/flux/pull/45#discussion_r36537151'>File: frontend/config/tasks/gulp_html.js:L33-40</a></b>\n- <a href='https://github.com/jansanchez'><img border=0 src='https://avatars.githubusercontent.com/u/2623671?v=3' height=16 width=16'></a> Aquí hay 2 lineas con indentación fuera de lo común.\n- [x] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/frontend-labs/flux/pull/45#issuecomment-128764281'>General Comment</a></b>\n- <a href='https://github.com/lavaldi'><img border=0 src='https://avatars.githubusercontent.com/u/1221474?v=3' height=16 width=16'></a> :shipit:\n- <a href='https://github.com/carloshs92'><img border=0 src='https://avatars.githubusercontent.com/u/1372633?v=3' height=16 width=16'></a> @jansanchez  Revisa por favor :book:\n- <a href='https://github.com/carloshs92'><img border=0 src='https://avatars.githubusercontent.com/u/1372633?v=3' height=16 width=16'></a> :+1:\n- <a href='https://github.com/jansanchez'><img border=0 src='https://avatars.githubusercontent.com/u/2623671?v=3' height=16 width=16'></a> :shipit:\n- <a href='https://github.com/jansanchez'><img border=0 src='https://avatars.githubusercontent.com/u/2623671?v=3' height=16 width=16'></a> Info: Este pull request genero 4 commits.\n\n\n<a href='https://www.codereviewhub.com/frontend-labs/flux/pull/45?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/frontend-labs/flux/pull/45?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/frontend-labs/flux/pull/45?approve=0'><img src='http://www.codereviewhub.com/site/github-undo-approve.png' height=26></a>&nbsp;<a href='https://github.com/frontend-labs/flux/pull/45'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>"},"comment":{"url":"https://api.github.com/repos/frontend-labs/flux/issues/comments/128773841","html_url":"https://github.com/frontend-labs/flux/pull/45#issuecomment-128773841","issue_url":"https://api.github.com/repos/frontend-labs/flux/issues/45","id":128773841,"user":{"login":"andru255","id":729789,"avatar_url":"https://avatars.githubusercontent.com/u/729789?v=3","gravatar_id":"","url":"https://api.github.com/users/andru255","html_url":"https://github.com/andru255","followers_url":"https://api.github.com/users/andru255/followers","following_url":"https://api.github.com/users/andru255/following{/other_user}","gists_url":"https://api.github.com/users/andru255/gists{/gist_id}","starred_url":"https://api.github.com/users/andru255/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andru255/subscriptions","organizations_url":"https://api.github.com/users/andru255/orgs","repos_url":"https://api.github.com/users/andru255/repos","events_url":"https://api.github.com/users/andru255/events{/privacy}","received_events_url":"https://api.github.com/users/andru255/received_events","type":"User","site_admin":false},"created_at":"2015-08-07T17:34:09Z","updated_at":"2015-08-07T17:34:09Z","body":":shipit:"}}