{"action":"created","issue":{"url":"https://api.github.com/repos/bkaradzic/bgfx/issues/449","labels_url":"https://api.github.com/repos/bkaradzic/bgfx/issues/449/labels{/name}","comments_url":"https://api.github.com/repos/bkaradzic/bgfx/issues/449/comments","events_url":"https://api.github.com/repos/bkaradzic/bgfx/issues/449/events","html_url":"https://github.com/bkaradzic/bgfx/pull/449","id":95205786,"number":449,"title":"Update for ImGui 1.43 with AA (NB: issues with DX9)","user":{"login":"ocornut","id":8225057,"avatar_url":"https://avatars.githubusercontent.com/u/8225057?v=3","gravatar_id":"","url":"https://api.github.com/users/ocornut","html_url":"https://github.com/ocornut","followers_url":"https://api.github.com/users/ocornut/followers","following_url":"https://api.github.com/users/ocornut/following{/other_user}","gists_url":"https://api.github.com/users/ocornut/gists{/gist_id}","starred_url":"https://api.github.com/users/ocornut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocornut/subscriptions","organizations_url":"https://api.github.com/users/ocornut/orgs","repos_url":"https://api.github.com/users/ocornut/repos","events_url":"https://api.github.com/users/ocornut/events{/privacy}","received_events_url":"https://api.github.com/users/ocornut/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-15T14:14:18Z","updated_at":"2015-07-15T16:57:45Z","closed_at":"2015-07-15T16:54:34Z","pull_request":{"url":"https://api.github.com/repos/bkaradzic/bgfx/pulls/449","html_url":"https://github.com/bkaradzic/bgfx/pull/449","diff_url":"https://github.com/bkaradzic/bgfx/pull/449.diff","patch_url":"https://github.com/bkaradzic/bgfx/pull/449.patch"},"body":"Following https://github.com/bkaradzic/imgui/commit/d21ba194961a40357fafc091fb8ad2d98992537f#commitcomment-12161853\r\n\r\nThis is the patch to apply if you update to the current Master of ImGui, the AA-branch has just been merged in.\r\n\r\n- It is still off and blurry on DX9. Your patch (adding PixelCenterOffset) fixes it for fonts but not for border. On the test window if you open a menu you'll notice the menu borders are blurry in DX9. You can also click Window Options-->Show Border, and in Style->Colors set the border color to full white with no transparency.\r\n\r\nFor comparaison, default border on menu\r\n![border](https://cloud.githubusercontent.com/assets/8225057/8700450/10f86b06-2ac9-11e5-8a77-8a2f756bf16e.PNG)\r\n\r\nBorders everywhere, max white\r\n![border1](https://cloud.githubusercontent.com/assets/8225057/8700455/18bb38fa-2ac9-11e5-827f-ea0c1c290979.PNG)\r\n\r\nI believe it should be fixed by offsetting the entire projection matrix by 0.5 and then you can remove PixelCenterOffset and get back to vanilla ImGui. Couldn't figure out how to alter the matrix, runtime didn't seem to use what I set up in bx::mtxOrtho() / bgfx::setViewTransform() but I am not familiar with bgfx architecture. It could be that the example have a small bug that wasn't visible here.\r\n\r\n- If you comment the call to AddFontFromMemoryTTF() it will load the default font which is an easy way to tell if rendering is correct.  You can also set io.MouseDrawCursor = true; rendered by ImGui as another test."},"comment":{"url":"https://api.github.com/repos/bkaradzic/bgfx/issues/comments/121679355","html_url":"https://github.com/bkaradzic/bgfx/pull/449#issuecomment-121679355","issue_url":"https://api.github.com/repos/bkaradzic/bgfx/issues/449","id":121679355,"user":{"login":"bkaradzic","id":814772,"avatar_url":"https://avatars.githubusercontent.com/u/814772?v=3","gravatar_id":"","url":"https://api.github.com/users/bkaradzic","html_url":"https://github.com/bkaradzic","followers_url":"https://api.github.com/users/bkaradzic/followers","following_url":"https://api.github.com/users/bkaradzic/following{/other_user}","gists_url":"https://api.github.com/users/bkaradzic/gists{/gist_id}","starred_url":"https://api.github.com/users/bkaradzic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkaradzic/subscriptions","organizations_url":"https://api.github.com/users/bkaradzic/orgs","repos_url":"https://api.github.com/users/bkaradzic/repos","events_url":"https://api.github.com/users/bkaradzic/events{/privacy}","received_events_url":"https://api.github.com/users/bkaradzic/received_events","type":"User","site_admin":false},"created_at":"2015-07-15T16:57:45Z","updated_at":"2015-07-15T16:57:45Z","body":"Also I fixed a few warnings:\r\nhttps://github.com/bkaradzic/imgui/commit/c17d5bf36fba5f762aa008df322b2f9071852a1d"}}