{"action":"created","comment":{"url":"https://api.github.com/repos/ClusterLabs/resource-agents/pulls/comments/23703916","id":23703916,"diff_hunk":"@@ -608,28 +656,18 @@ VirtualDomain_Migrate_To() {\n \t\tif [ -n \"${OCF_RESKEY_migration_transport}\" ]; then\n \t\t\ttransport_suffix=\"+${OCF_RESKEY_migration_transport}\"\n \t\tfi\n-\t\t# A typical migration URI via a special  migration network looks\n-\t\t# like \"tcp://bar-mig:49152\". The port would be randomly chosen\n-\t\t# by libvirt from the range 49152-49215 if omitted, at least since\n-\t\t# version 0.7.4 ...\n-\t\tif [ -n \"${OCF_RESKEY_migration_network_suffix}\" ]; then\n-\t\t\thypervisor=\"${OCF_RESKEY_hypervisor%%[+:]*}\"\n-\t\t\t# Hostname might be a FQDN\n-\t\t\tmigrate_target=$(echo ${target_node} | sed -e \"s,^\\([^.]\\+\\),\\1${OCF_RESKEY_migration_network_suffix},\")\n-\t\t\tcase $hypervisor in\n-\t\t\t\tqemu)\n-\t\t\t\t\t# For quiet ancient libvirt versions a migration port is needed\n-\t\t\t\t\t# and the URI must not contain the \"//\". Newer versions can handle\n-\t\t\t\t\t# the \"bad\" URI.\n-\t\t\t\t\tmigrateuri=\"tcp:${migrate_target}:${OCF_RESKEY_migrateport}\"\n-\t\t\t\t\t;;\n-\t\t\t\txen)\n-\t\t\t\t\tmigrateuri=\"xenmigr://${migrate_target}\"\n-\t\t\t\t\t;;\n-\t\t\t\t*)\n-\t\t\t\t\tocf_log warn \"$DOMAIN_NAME: Migration via dedicated network currently not supported for ${hypervisor}.\"\n-\t\t\t\t\t;;\n-\t\t\tesac\n+\n+\t\t# User defined migrateuri or do we make one?\n+\t\tmigrate_opts=\"$OCF_RESKEY_migrate_options\"\n+\t\tif echo \"$migrate_opts\" | fgrep -qs -- \"--migrateuri=\"; then","path":"heartbeat/VirtualDomain","position":107,"original_position":107,"commit_id":"de5e9fb034aaddc4a6f8247029ecd7a8c1ca3098","original_commit_id":"de5e9fb034aaddc4a6f8247029ecd7a8c1ca3098","user":{"login":"davidvossel","id":683713,"avatar_url":"https://avatars.githubusercontent.com/u/683713?v=3","gravatar_id":"","url":"https://api.github.com/users/davidvossel","html_url":"https://github.com/davidvossel","followers_url":"https://api.github.com/users/davidvossel/followers","following_url":"https://api.github.com/users/davidvossel/following{/other_user}","gists_url":"https://api.github.com/users/davidvossel/gists{/gist_id}","starred_url":"https://api.github.com/users/davidvossel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidvossel/subscriptions","organizations_url":"https://api.github.com/users/davidvossel/orgs","repos_url":"https://api.github.com/users/davidvossel/repos","events_url":"https://api.github.com/users/davidvossel/events{/privacy}","received_events_url":"https://api.github.com/users/davidvossel/received_events","type":"User","site_admin":false},"body":"when did --migrateuri become an option. In older versions of virsh it looks like migrate uri is expected to proceed the destination uri in the virsh command.","created_at":"2015-01-28T17:19:55Z","updated_at":"2015-01-28T17:19:55Z","html_url":"https://github.com/ClusterLabs/resource-agents/pull/558#discussion_r23703916","pull_request_url":"https://api.github.com/repos/ClusterLabs/resource-agents/pulls/558","_links":{"self":{"href":"https://api.github.com/repos/ClusterLabs/resource-agents/pulls/comments/23703916"},"html":{"href":"https://github.com/ClusterLabs/resource-agents/pull/558#discussion_r23703916"},"pull_request":{"href":"https://api.github.com/repos/ClusterLabs/resource-agents/pulls/558"}}},"pull_request":{"url":"https://api.github.com/repos/ClusterLabs/resource-agents/pulls/558","id":27995612,"html_url":"https://github.com/ClusterLabs/resource-agents/pull/558","diff_url":"https://github.com/ClusterLabs/resource-agents/pull/558.diff","patch_url":"https://github.com/ClusterLabs/resource-agents/pull/558.patch","issue_url":"https://api.github.com/repos/ClusterLabs/resource-agents/issues/558","number":558,"state":"open","locked":false,"title":"Medium: VirtualDomain: add migrate_options parameter","user":{"login":"dmuhamedagic","id":638318,"avatar_url":"https://avatars.githubusercontent.com/u/638318?v=3","gravatar_id":"","url":"https://api.github.com/users/dmuhamedagic","html_url":"https://github.com/dmuhamedagic","followers_url":"https://api.github.com/users/dmuhamedagic/followers","following_url":"https://api.github.com/users/dmuhamedagic/following{/other_user}","gists_url":"https://api.github.com/users/dmuhamedagic/gists{/gist_id}","starred_url":"https://api.github.com/users/dmuhamedagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmuhamedagic/subscriptions","organizations_url":"https://api.github.com/users/dmuhamedagic/orgs","repos_url":"https://api.github.com/users/dmuhamedagic/repos","events_url":"https://api.github.com/users/dmuhamedagic/events{/privacy}","received_events_url":"https://api.github.com/users/dmuhamedagic/received_events","type":"User","site_admin":false},"body":"The virsh migrate command has many options which may be passed\r\nwith this parameter. The other purpose is the possibility to\r\noverride the migrateuri option, in case the automatically\r\nbuilt string is not appropriate.","created_at":"2015-01-25T18:22:14Z","updated_at":"2015-01-28T17:19:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce867864a15de2f4c2f7e5600d93662eeef9486e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ClusterLabs/resource-agents/pulls/558/commits","review_comments_url":"https://api.github.com/repos/ClusterLabs/resource-agents/pulls/558/comments","review_comment_url":"https://api.github.com/repos/ClusterLabs/resource-agents/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ClusterLabs/resource-agents/issues/558/comments","statuses_url":"https://api.github.com/repos/ClusterLabs/resource-agents/statuses/de5e9fb034aaddc4a6f8247029ecd7a8c1ca3098","head":{"label":"dmuhamedagic:VirtualDomain-migrate-options","ref":"VirtualDomain-migrate-options","sha":"de5e9fb034aaddc4a6f8247029ecd7a8c1ca3098","user":{"login":"dmuhamedagic","id":638318,"avatar_url":"https://avatars.githubusercontent.com/u/638318?v=3","gravatar_id":"","url":"https://api.github.com/users/dmuhamedagic","html_url":"https://github.com/dmuhamedagic","followers_url":"https://api.github.com/users/dmuhamedagic/followers","following_url":"https://api.github.com/users/dmuhamedagic/following{/other_user}","gists_url":"https://api.github.com/users/dmuhamedagic/gists{/gist_id}","starred_url":"https://api.github.com/users/dmuhamedagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmuhamedagic/subscriptions","organizations_url":"https://api.github.com/users/dmuhamedagic/orgs","repos_url":"https://api.github.com/users/dmuhamedagic/repos","events_url":"https://api.github.com/users/dmuhamedagic/events{/privacy}","received_events_url":"https://api.github.com/users/dmuhamedagic/received_events","type":"User","site_admin":false},"repo":{"id":10354897,"name":"resource-agents","full_name":"dmuhamedagic/resource-agents","owner":{"login":"dmuhamedagic","id":638318,"avatar_url":"https://avatars.githubusercontent.com/u/638318?v=3","gravatar_id":"","url":"https://api.github.com/users/dmuhamedagic","html_url":"https://github.com/dmuhamedagic","followers_url":"https://api.github.com/users/dmuhamedagic/followers","following_url":"https://api.github.com/users/dmuhamedagic/following{/other_user}","gists_url":"https://api.github.com/users/dmuhamedagic/gists{/gist_id}","starred_url":"https://api.github.com/users/dmuhamedagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmuhamedagic/subscriptions","organizations_url":"https://api.github.com/users/dmuhamedagic/orgs","repos_url":"https://api.github.com/users/dmuhamedagic/repos","events_url":"https://api.github.com/users/dmuhamedagic/events{/privacy}","received_events_url":"https://api.github.com/users/dmuhamedagic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmuhamedagic/resource-agents","description":"Combined repository of OCF agents from the RHCS and Linux-HA projects","fork":true,"url":"https://api.github.com/repos/dmuhamedagic/resource-agents","forks_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/forks","keys_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/teams","hooks_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/hooks","issue_events_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/issues/events{/number}","events_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/events","assignees_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/assignees{/user}","branches_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/branches{/branch}","tags_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/tags","blobs_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/statuses/{sha}","languages_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/languages","stargazers_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/stargazers","contributors_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/contributors","subscribers_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/subscribers","subscription_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/subscription","commits_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/issues/comments/{number}","contents_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/contents/{+path}","compare_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/merges","archive_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/downloads","issues_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/issues{/number}","pulls_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/pulls{/number}","milestones_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/milestones{/number}","notifications_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/labels{/name}","releases_url":"https://api.github.com/repos/dmuhamedagic/resource-agents/releases{/id}","created_at":"2013-05-29T08:08:43Z","updated_at":"2015-01-28T16:50:22Z","pushed_at":"2015-01-28T16:50:22Z","git_url":"git://github.com/dmuhamedagic/resource-agents.git","ssh_url":"git@github.com:dmuhamedagic/resource-agents.git","clone_url":"https://github.com/dmuhamedagic/resource-agents.git","svn_url":"https://github.com/dmuhamedagic/resource-agents","homepage":"","size":32765,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ClusterLabs:master","ref":"master","sha":"117b46eb87dc6c6898d35bf61ed2d4230ef20804","user":{"login":"ClusterLabs","id":574912,"avatar_url":"https://avatars.githubusercontent.com/u/574912?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterLabs","html_url":"https://github.com/ClusterLabs","followers_url":"https://api.github.com/users/ClusterLabs/followers","following_url":"https://api.github.com/users/ClusterLabs/following{/other_user}","gists_url":"https://api.github.com/users/ClusterLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterLabs/subscriptions","organizations_url":"https://api.github.com/users/ClusterLabs/orgs","repos_url":"https://api.github.com/users/ClusterLabs/repos","events_url":"https://api.github.com/users/ClusterLabs/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":1316191,"name":"resource-agents","full_name":"ClusterLabs/resource-agents","owner":{"login":"ClusterLabs","id":574912,"avatar_url":"https://avatars.githubusercontent.com/u/574912?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterLabs","html_url":"https://github.com/ClusterLabs","followers_url":"https://api.github.com/users/ClusterLabs/followers","following_url":"https://api.github.com/users/ClusterLabs/following{/other_user}","gists_url":"https://api.github.com/users/ClusterLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterLabs/subscriptions","organizations_url":"https://api.github.com/users/ClusterLabs/orgs","repos_url":"https://api.github.com/users/ClusterLabs/repos","events_url":"https://api.github.com/users/ClusterLabs/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ClusterLabs/resource-agents","description":"Combined repository of OCF agents from the RHCS and Linux-HA projects","fork":false,"url":"https://api.github.com/repos/ClusterLabs/resource-agents","forks_url":"https://api.github.com/repos/ClusterLabs/resource-agents/forks","keys_url":"https://api.github.com/repos/ClusterLabs/resource-agents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ClusterLabs/resource-agents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ClusterLabs/resource-agents/teams","hooks_url":"https://api.github.com/repos/ClusterLabs/resource-agents/hooks","issue_events_url":"https://api.github.com/repos/ClusterLabs/resource-agents/issues/events{/number}","events_url":"https://api.github.com/repos/ClusterLabs/resource-agents/events","assignees_url":"https://api.github.com/repos/ClusterLabs/resource-agents/assignees{/user}","branches_url":"https://api.github.com/repos/ClusterLabs/resource-agents/branches{/branch}","tags_url":"https://api.github.com/repos/ClusterLabs/resource-agents/tags","blobs_url":"https://api.github.com/repos/ClusterLabs/resource-agents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ClusterLabs/resource-agents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ClusterLabs/resource-agents/git/refs{/sha}","trees_url":"https://api.github.com/repos/ClusterLabs/resource-agents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ClusterLabs/resource-agents/statuses/{sha}","languages_url":"https://api.github.com/repos/ClusterLabs/resource-agents/languages","stargazers_url":"https://api.github.com/repos/ClusterLabs/resource-agents/stargazers","contributors_url":"https://api.github.com/repos/ClusterLabs/resource-agents/contributors","subscribers_url":"https://api.github.com/repos/ClusterLabs/resource-agents/subscribers","subscription_url":"https://api.github.com/repos/ClusterLabs/resource-agents/subscription","commits_url":"https://api.github.com/repos/ClusterLabs/resource-agents/commits{/sha}","git_commits_url":"https://api.github.com/repos/ClusterLabs/resource-agents/git/commits{/sha}","comments_url":"https://api.github.com/repos/ClusterLabs/resource-agents/comments{/number}","issue_comment_url":"https://api.github.com/repos/ClusterLabs/resource-agents/issues/comments/{number}","contents_url":"https://api.github.com/repos/ClusterLabs/resource-agents/contents/{+path}","compare_url":"https://api.github.com/repos/ClusterLabs/resource-agents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ClusterLabs/resource-agents/merges","archive_url":"https://api.github.com/repos/ClusterLabs/resource-agents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ClusterLabs/resource-agents/downloads","issues_url":"https://api.github.com/repos/ClusterLabs/resource-agents/issues{/number}","pulls_url":"https://api.github.com/repos/ClusterLabs/resource-agents/pulls{/number}","milestones_url":"https://api.github.com/repos/ClusterLabs/resource-agents/milestones{/number}","notifications_url":"https://api.github.com/repos/ClusterLabs/resource-agents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ClusterLabs/resource-agents/labels{/name}","releases_url":"https://api.github.com/repos/ClusterLabs/resource-agents/releases{/id}","created_at":"2011-02-01T13:43:18Z","updated_at":"2015-01-28T16:46:20Z","pushed_at":"2015-01-28T16:46:20Z","git_url":"git://github.com/ClusterLabs/resource-agents.git","ssh_url":"git@github.com:ClusterLabs/resource-agents.git","clone_url":"https://github.com/ClusterLabs/resource-agents.git","svn_url":"https://github.com/ClusterLabs/resource-agents","homepage":"","size":37881,"stargazers_count":226,"watchers_count":226,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":222,"mirror_url":null,"open_issues_count":44,"forks":222,"open_issues":44,"watchers":226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ClusterLabs/resource-agents/pulls/558"},"html":{"href":"https://github.com/ClusterLabs/resource-agents/pull/558"},"issue":{"href":"https://api.github.com/repos/ClusterLabs/resource-agents/issues/558"},"comments":{"href":"https://api.github.com/repos/ClusterLabs/resource-agents/issues/558/comments"},"review_comments":{"href":"https://api.github.com/repos/ClusterLabs/resource-agents/pulls/558/comments"},"review_comment":{"href":"https://api.github.com/repos/ClusterLabs/resource-agents/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ClusterLabs/resource-agents/pulls/558/commits"},"statuses":{"href":"https://api.github.com/repos/ClusterLabs/resource-agents/statuses/de5e9fb034aaddc4a6f8247029ecd7a8c1ca3098"}}}}