{"action":"created","issue":{"url":"https://api.github.com/repos/Flipboard/bottomsheet/issues/60","labels_url":"https://api.github.com/repos/Flipboard/bottomsheet/issues/60/labels{/name}","comments_url":"https://api.github.com/repos/Flipboard/bottomsheet/issues/60/comments","events_url":"https://api.github.com/repos/Flipboard/bottomsheet/issues/60/events","html_url":"https://github.com/Flipboard/bottomsheet/pull/60","id":105511762,"number":60,"title":"RecyclerView support in MenuSheetView","user":{"login":"AKiniyalocts","id":4463117,"avatar_url":"https://avatars.githubusercontent.com/u/4463117?v=3","gravatar_id":"","url":"https://api.github.com/users/AKiniyalocts","html_url":"https://github.com/AKiniyalocts","followers_url":"https://api.github.com/users/AKiniyalocts/followers","following_url":"https://api.github.com/users/AKiniyalocts/following{/other_user}","gists_url":"https://api.github.com/users/AKiniyalocts/gists{/gist_id}","starred_url":"https://api.github.com/users/AKiniyalocts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AKiniyalocts/subscriptions","organizations_url":"https://api.github.com/users/AKiniyalocts/orgs","repos_url":"https://api.github.com/users/AKiniyalocts/repos","events_url":"https://api.github.com/users/AKiniyalocts/events{/privacy}","received_events_url":"https://api.github.com/users/AKiniyalocts/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-09T03:31:20Z","updated_at":"2015-09-13T05:13:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Flipboard/bottomsheet/pulls/60","html_url":"https://github.com/Flipboard/bottomsheet/pull/60","diff_url":"https://github.com/Flipboard/bottomsheet/pull/60.diff","patch_url":"https://github.com/Flipboard/bottomsheet/pull/60.patch"},"body":"This adds support for RecyclerView in the bottom sheet for our MenuSheetView. I've included a `WrapLinearLayoutManager` to fix the wrap_content issue for a `LinearLayoutManager`. GridLayoutManager currently <strong>does not</strong> wrap content (fills the entire screen).\r\n\r\nI've added an additional constructor for our `MenuSheetView` constructor, allowing you to pass in a `LayoutManager` for your recycler. I've also added two new `MenuType's`: `RECYCLER_LIST` and `RECYCLER_GRID`, which are also required in the `MenuSheetView` constructor when using a recycler."},"comment":{"url":"https://api.github.com/repos/Flipboard/bottomsheet/issues/comments/139845005","html_url":"https://github.com/Flipboard/bottomsheet/pull/60#issuecomment-139845005","issue_url":"https://api.github.com/repos/Flipboard/bottomsheet/issues/60","id":139845005,"user":{"login":"hzsweers","id":1361086,"avatar_url":"https://avatars.githubusercontent.com/u/1361086?v=3","gravatar_id":"","url":"https://api.github.com/users/hzsweers","html_url":"https://github.com/hzsweers","followers_url":"https://api.github.com/users/hzsweers/followers","following_url":"https://api.github.com/users/hzsweers/following{/other_user}","gists_url":"https://api.github.com/users/hzsweers/gists{/gist_id}","starred_url":"https://api.github.com/users/hzsweers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzsweers/subscriptions","organizations_url":"https://api.github.com/users/hzsweers/orgs","repos_url":"https://api.github.com/users/hzsweers/repos","events_url":"https://api.github.com/users/hzsweers/events{/privacy}","received_events_url":"https://api.github.com/users/hzsweers/received_events","type":"User","site_admin":false},"created_at":"2015-09-13T05:13:54Z","updated_at":"2015-09-13T05:13:54Z","body":"So haven't gone through the code yet, but a couple things I wanted to touch on to see if you had plans/feedback for:\r\n\r\n* I noticed this is only for SheetMenuView. We'd ideally like to have it for all the commons views.\r\n* I think we'd want to pull the trigger on just one or the other, and not supporting both AbsListView and RecyclerView\r\n\r\nDid you have plans regarding/thoughts for either of those?"}}