{"action":"created","issue":{"url":"https://api.github.com/repos/apache/thrift/issues/672","labels_url":"https://api.github.com/repos/apache/thrift/issues/672/labels{/name}","comments_url":"https://api.github.com/repos/apache/thrift/issues/672/comments","events_url":"https://api.github.com/repos/apache/thrift/issues/672/events","html_url":"https://github.com/apache/thrift/pull/672","id":114351338,"number":672,"title":"Fix package.json to include only the needed files","user":{"login":"jkrems","id":567540,"avatar_url":"https://avatars.githubusercontent.com/u/567540?v=3","gravatar_id":"","url":"https://api.github.com/users/jkrems","html_url":"https://github.com/jkrems","followers_url":"https://api.github.com/users/jkrems/followers","following_url":"https://api.github.com/users/jkrems/following{/other_user}","gists_url":"https://api.github.com/users/jkrems/gists{/gist_id}","starred_url":"https://api.github.com/users/jkrems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkrems/subscriptions","organizations_url":"https://api.github.com/users/jkrems/orgs","repos_url":"https://api.github.com/users/jkrems/repos","events_url":"https://api.github.com/users/jkrems/events{/privacy}","received_events_url":"https://api.github.com/users/jkrems/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-30T20:35:37Z","updated_at":"2015-11-03T22:37:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/thrift/pulls/672","html_url":"https://github.com/apache/thrift/pull/672","diff_url":"https://github.com/apache/thrift/pull/672.diff","patch_url":"https://github.com/apache/thrift/pull/672.patch"},"body":"Before:\r\n\r\n```\r\n> du -sh node_modules/thrift\r\n 28M\tnode_modules/thrift\r\n```\r\n\r\nAfter:\r\n\r\n```\r\n> mkdir -p /tmp/thrift-module\r\n> cp -r node_modules/thrift/lib/nodejs/{lib,README.md} /tmp/thrift-module\r\n> du -sh /tmp/thrift-module\r\n208K\t/tmp/thrift-module\r\n```\r\n\r\nReference: https://docs.npmjs.com/files/package.json#files"},"comment":{"url":"https://api.github.com/repos/apache/thrift/issues/comments/153511243","html_url":"https://github.com/apache/thrift/pull/672#issuecomment-153511243","issue_url":"https://api.github.com/repos/apache/thrift/issues/672","id":153511243,"user":{"login":"bufferoverflow","id":378909,"avatar_url":"https://avatars.githubusercontent.com/u/378909?v=3","gravatar_id":"","url":"https://api.github.com/users/bufferoverflow","html_url":"https://github.com/bufferoverflow","followers_url":"https://api.github.com/users/bufferoverflow/followers","following_url":"https://api.github.com/users/bufferoverflow/following{/other_user}","gists_url":"https://api.github.com/users/bufferoverflow/gists{/gist_id}","starred_url":"https://api.github.com/users/bufferoverflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bufferoverflow/subscriptions","organizations_url":"https://api.github.com/users/bufferoverflow/orgs","repos_url":"https://api.github.com/users/bufferoverflow/repos","events_url":"https://api.github.com/users/bufferoverflow/events{/privacy}","received_events_url":"https://api.github.com/users/bufferoverflow/received_events","type":"User","site_admin":false},"created_at":"2015-11-03T22:37:10Z","updated_at":"2015-11-03T22:37:10Z","body":"Thanks for the PR!\r\n\r\nWe need a strong YES to according to the contribution guidelines as mentioned here https://thrift.apache.org/docs/HowToContribute (generated from https://github.com/apache/thrift/blob/master/CONTRIBUTING.md)\r\n\r\nI guess CONTRIBUTING.md is displayed when creating a merge request? But there is no ack... or is pressing the create Merge Request an ACK on the contribution license?\r\n\r\nWe probably need to simplify this somehow especially for such small but essential contributions.\r\n"}}