{"action":"created","comment":{"url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/pulls/comments/30301538","id":30301538,"diff_hunk":"@@ -86,9 +86,11 @@\n \t\t\tpoll = View.parseResults(poll);\n \t\t\tfor (var i = 0, l = poll.options.length; i < l; i++) {\n \t\t\t\tvar option = poll.options[i],\n-\t\t\t\t\toptionView = pollView.find('#pollResult' + option.id);\n+\t\t\t\t    optionView = pollView.find('.poll-view-result[data-poll-result=\"'+option.id+'\"]');","path":"public/js/poll/view.js","position":14,"original_position":14,"commit_id":"6c759cf2946f578ac5c579423e9569df0694737e","original_commit_id":"6c759cf2946f578ac5c579423e9569df0694737e","user":{"login":"zetas","id":1036810,"avatar_url":"https://avatars.githubusercontent.com/u/1036810?v=3","gravatar_id":"","url":"https://api.github.com/users/zetas","html_url":"https://github.com/zetas","followers_url":"https://api.github.com/users/zetas/followers","following_url":"https://api.github.com/users/zetas/following{/other_user}","gists_url":"https://api.github.com/users/zetas/gists{/gist_id}","starred_url":"https://api.github.com/users/zetas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zetas/subscriptions","organizations_url":"https://api.github.com/users/zetas/orgs","repos_url":"https://api.github.com/users/zetas/repos","events_url":"https://api.github.com/users/zetas/events{/privacy}","received_events_url":"https://api.github.com/users/zetas/received_events","type":"User","site_admin":false},"body":"This I think is simply a 0.7.x compatibility issue but again the anchor was incorrect, ```#pollResult``` was nowhere to be found.","created_at":"2015-05-14T07:00:12Z","updated_at":"2015-05-14T07:00:12Z","html_url":"https://github.com/Schamper/nodebb-plugin-poll/pull/26#discussion_r30301538","pull_request_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/pulls/comments/30301538"},"html":{"href":"https://github.com/Schamper/nodebb-plugin-poll/pull/26#discussion_r30301538"},"pull_request":{"href":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/pulls/26","id":35398581,"html_url":"https://github.com/Schamper/nodebb-plugin-poll/pull/26","diff_url":"https://github.com/Schamper/nodebb-plugin-poll/pull/26.diff","patch_url":"https://github.com/Schamper/nodebb-plugin-poll/pull/26.patch","issue_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/issues/26","number":26,"state":"open","locked":false,"title":"Fixing the issues preventing this plugin from working with 0.7.x ","user":{"login":"zetas","id":1036810,"avatar_url":"https://avatars.githubusercontent.com/u/1036810?v=3","gravatar_id":"","url":"https://api.github.com/users/zetas","html_url":"https://github.com/zetas","followers_url":"https://api.github.com/users/zetas/followers","following_url":"https://api.github.com/users/zetas/following{/other_user}","gists_url":"https://api.github.com/users/zetas/gists{/gist_id}","starred_url":"https://api.github.com/users/zetas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zetas/subscriptions","organizations_url":"https://api.github.com/users/zetas/orgs","repos_url":"https://api.github.com/users/zetas/repos","events_url":"https://api.github.com/users/zetas/events{/privacy}","received_events_url":"https://api.github.com/users/zetas/received_events","type":"User","site_admin":false},"body":"I'm not a nodebb plugin dev, I basically went through the code looking for mismatched html anchors and fixed them. It's entirely possible these changes only work with the Persona theme for 0.7.x, not sure how different they are as far as markup is concerned. \r\n\r\nHere's the list of changes:\r\n\r\n* Fix #6 so your choice, as well as vote count/percentage is shown after you vote\r\n* Fixes issue #24, poll not being displayed at all due to bad markup identifiers\r\n* Forces the poll creation window to sit above the compose panel instead of behind\r\n* Fixes template parse error in poll/notify.tpl. The curly braces were somehow being translated into htmlcharcodes and it was breaking the JS. I couldn't figure out how to escape it so I refactored the function to accept the raw ID instead of an object.\r\n* Added missing en_US translation (copied from en_GB). This seems to be a common issue, no plugin dev seems to prepare for the admin using en_US. I guess I'm the only one that doesn't leave it on GB haha.\r\n\r\n@Schamper If you give me instructions as to what I may have done wrong or how I could do it better to fit with all themes, let me know and I'll add more to the PR.","created_at":"2015-05-14T06:56:38Z","updated_at":"2015-05-14T07:00:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1e40678af89051a27ec5f2a6e93e5458fd77e0f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/pulls/26/commits","review_comments_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/pulls/26/comments","review_comment_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/issues/26/comments","statuses_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/statuses/6c759cf2946f578ac5c579423e9569df0694737e","head":{"label":"zetas:dev-fixes","ref":"dev-fixes","sha":"6c759cf2946f578ac5c579423e9569df0694737e","user":{"login":"zetas","id":1036810,"avatar_url":"https://avatars.githubusercontent.com/u/1036810?v=3","gravatar_id":"","url":"https://api.github.com/users/zetas","html_url":"https://github.com/zetas","followers_url":"https://api.github.com/users/zetas/followers","following_url":"https://api.github.com/users/zetas/following{/other_user}","gists_url":"https://api.github.com/users/zetas/gists{/gist_id}","starred_url":"https://api.github.com/users/zetas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zetas/subscriptions","organizations_url":"https://api.github.com/users/zetas/orgs","repos_url":"https://api.github.com/users/zetas/repos","events_url":"https://api.github.com/users/zetas/events{/privacy}","received_events_url":"https://api.github.com/users/zetas/received_events","type":"User","site_admin":false},"repo":{"id":35595910,"name":"nodebb-plugin-poll","full_name":"zetas/nodebb-plugin-poll","owner":{"login":"zetas","id":1036810,"avatar_url":"https://avatars.githubusercontent.com/u/1036810?v=3","gravatar_id":"","url":"https://api.github.com/users/zetas","html_url":"https://github.com/zetas","followers_url":"https://api.github.com/users/zetas/followers","following_url":"https://api.github.com/users/zetas/following{/other_user}","gists_url":"https://api.github.com/users/zetas/gists{/gist_id}","starred_url":"https://api.github.com/users/zetas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zetas/subscriptions","organizations_url":"https://api.github.com/users/zetas/orgs","repos_url":"https://api.github.com/users/zetas/repos","events_url":"https://api.github.com/users/zetas/events{/privacy}","received_events_url":"https://api.github.com/users/zetas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zetas/nodebb-plugin-poll","description":"Poll plugin for NodeBB.","fork":true,"url":"https://api.github.com/repos/zetas/nodebb-plugin-poll","forks_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/forks","keys_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/teams","hooks_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/hooks","issue_events_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/issues/events{/number}","events_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/events","assignees_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/assignees{/user}","branches_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/branches{/branch}","tags_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/tags","blobs_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/git/refs{/sha}","trees_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/statuses/{sha}","languages_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/languages","stargazers_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/stargazers","contributors_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/contributors","subscribers_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/subscribers","subscription_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/subscription","commits_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/commits{/sha}","git_commits_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/git/commits{/sha}","comments_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/comments{/number}","issue_comment_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/issues/comments{/number}","contents_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/contents/{+path}","compare_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/merges","archive_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/downloads","issues_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/issues{/number}","pulls_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/pulls{/number}","milestones_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/milestones{/number}","notifications_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/labels{/name}","releases_url":"https://api.github.com/repos/zetas/nodebb-plugin-poll/releases{/id}","created_at":"2015-05-14T06:49:28Z","updated_at":"2015-05-14T06:49:28Z","pushed_at":"2015-05-14T06:53:58Z","git_url":"git://github.com/zetas/nodebb-plugin-poll.git","ssh_url":"git@github.com:zetas/nodebb-plugin-poll.git","clone_url":"https://github.com/zetas/nodebb-plugin-poll.git","svn_url":"https://github.com/zetas/nodebb-plugin-poll","homepage":null,"size":368,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Schamper:master","ref":"master","sha":"c2a1d881aabaf0b85edda59bab8842b075a01c5e","user":{"login":"Schamper","id":1254028,"avatar_url":"https://avatars.githubusercontent.com/u/1254028?v=3","gravatar_id":"","url":"https://api.github.com/users/Schamper","html_url":"https://github.com/Schamper","followers_url":"https://api.github.com/users/Schamper/followers","following_url":"https://api.github.com/users/Schamper/following{/other_user}","gists_url":"https://api.github.com/users/Schamper/gists{/gist_id}","starred_url":"https://api.github.com/users/Schamper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Schamper/subscriptions","organizations_url":"https://api.github.com/users/Schamper/orgs","repos_url":"https://api.github.com/users/Schamper/repos","events_url":"https://api.github.com/users/Schamper/events{/privacy}","received_events_url":"https://api.github.com/users/Schamper/received_events","type":"User","site_admin":false},"repo":{"id":19550353,"name":"nodebb-plugin-poll","full_name":"Schamper/nodebb-plugin-poll","owner":{"login":"Schamper","id":1254028,"avatar_url":"https://avatars.githubusercontent.com/u/1254028?v=3","gravatar_id":"","url":"https://api.github.com/users/Schamper","html_url":"https://github.com/Schamper","followers_url":"https://api.github.com/users/Schamper/followers","following_url":"https://api.github.com/users/Schamper/following{/other_user}","gists_url":"https://api.github.com/users/Schamper/gists{/gist_id}","starred_url":"https://api.github.com/users/Schamper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Schamper/subscriptions","organizations_url":"https://api.github.com/users/Schamper/orgs","repos_url":"https://api.github.com/users/Schamper/repos","events_url":"https://api.github.com/users/Schamper/events{/privacy}","received_events_url":"https://api.github.com/users/Schamper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Schamper/nodebb-plugin-poll","description":"Poll plugin for NodeBB.","fork":false,"url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll","forks_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/forks","keys_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/teams","hooks_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/hooks","issue_events_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/issues/events{/number}","events_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/events","assignees_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/assignees{/user}","branches_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/branches{/branch}","tags_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/tags","blobs_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/git/refs{/sha}","trees_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/statuses/{sha}","languages_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/languages","stargazers_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/stargazers","contributors_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/contributors","subscribers_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/subscribers","subscription_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/subscription","commits_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/commits{/sha}","git_commits_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/git/commits{/sha}","comments_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/comments{/number}","issue_comment_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/issues/comments{/number}","contents_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/contents/{+path}","compare_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/merges","archive_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/downloads","issues_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/issues{/number}","pulls_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/pulls{/number}","milestones_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/milestones{/number}","notifications_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/labels{/name}","releases_url":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/releases{/id}","created_at":"2014-05-07T21:06:06Z","updated_at":"2015-04-21T16:41:43Z","pushed_at":"2015-05-14T06:56:38Z","git_url":"git://github.com/Schamper/nodebb-plugin-poll.git","ssh_url":"git@github.com:Schamper/nodebb-plugin-poll.git","clone_url":"https://github.com/Schamper/nodebb-plugin-poll.git","svn_url":"https://github.com/Schamper/nodebb-plugin-poll","homepage":null,"size":368,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":11,"forks":12,"open_issues":11,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/pulls/26"},"html":{"href":"https://github.com/Schamper/nodebb-plugin-poll/pull/26"},"issue":{"href":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/issues/26"},"comments":{"href":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/Schamper/nodebb-plugin-poll/statuses/6c759cf2946f578ac5c579423e9569df0694737e"}}}}