{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/45903318","id":45903318,"diff_hunk":"@@ -746,6 +748,38 @@ func (nc *NodeController) deletePods(nodeName string) (bool, error) {\n \treturn remaining, nil\n }\n \n+// update ready status of all pods running on given node from master\n+// return true if success\n+func (nc *NodeController) updatePods(nodeName string, readyStatus api.ConditionStatus) (bool, error) {\n+\tglog.Infof(\"Update Ready Status of pods on node [%v]\", nodeName)","path":"pkg/controller/node/nodecontroller.go","position":23,"original_position":23,"commit_id":"1233aefe398423d387f088419ae9328f8f8bef06","original_commit_id":"1233aefe398423d387f088419ae9328f8f8bef06","user":{"login":"freehan","id":1332699,"avatar_url":"https://avatars.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2015-11-25T18:36:53Z","updated_at":"2015-11-25T18:36:53Z","html_url":"https://github.com/kubernetes/kubernetes/pull/17741#discussion_r45903318","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17741","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/45903318"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/17741#discussion_r45903318"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17741"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17741","id":51729399,"html_url":"https://github.com/kubernetes/kubernetes/pull/17741","diff_url":"https://github.com/kubernetes/kubernetes/pull/17741.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/17741.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17741","number":17741,"state":"open","locked":false,"title":"Update pod status once node becomes NotReady","user":{"login":"freehan","id":1332699,"avatar_url":"https://avatars.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"body":"Update pod ready status to false once its node gets into NotReady status. This is to avoid bad service endpoint due to node down. ","created_at":"2015-11-24T22:53:51Z","updated_at":"2015-11-25T18:36:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c19d38e9d04243e8205b38281912935befa69af8","assignee":{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars.githubusercontent.com/u/6233452?v=3","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17741/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17741/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17741/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/1233aefe398423d387f088419ae9328f8f8bef06","head":{"label":"freehan:nodedown","ref":"nodedown","sha":"1233aefe398423d387f088419ae9328f8f8bef06","user":{"login":"freehan","id":1332699,"avatar_url":"https://avatars.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"repo":{"id":45570688,"name":"kubernetes","full_name":"freehan/kubernetes","owner":{"login":"freehan","id":1332699,"avatar_url":"https://avatars.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/freehan/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/freehan/kubernetes","forks_url":"https://api.github.com/repos/freehan/kubernetes/forks","keys_url":"https://api.github.com/repos/freehan/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freehan/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freehan/kubernetes/teams","hooks_url":"https://api.github.com/repos/freehan/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/freehan/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/freehan/kubernetes/events","assignees_url":"https://api.github.com/repos/freehan/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/freehan/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/freehan/kubernetes/tags","blobs_url":"https://api.github.com/repos/freehan/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freehan/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freehan/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/freehan/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freehan/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/freehan/kubernetes/languages","stargazers_url":"https://api.github.com/repos/freehan/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/freehan/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/freehan/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/freehan/kubernetes/subscription","commits_url":"https://api.github.com/repos/freehan/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/freehan/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/freehan/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/freehan/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/freehan/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/freehan/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freehan/kubernetes/merges","archive_url":"https://api.github.com/repos/freehan/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freehan/kubernetes/downloads","issues_url":"https://api.github.com/repos/freehan/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/freehan/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/freehan/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/freehan/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freehan/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/freehan/kubernetes/releases{/id}","created_at":"2015-11-04T22:09:37Z","updated_at":"2015-11-04T22:09:58Z","pushed_at":"2015-11-24T23:17:19Z","git_url":"git://github.com/freehan/kubernetes.git","ssh_url":"git@github.com:freehan/kubernetes.git","clone_url":"https://github.com/freehan/kubernetes.git","svn_url":"https://github.com/freehan/kubernetes","homepage":"http://kubernetes.io","size":140715,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"0d4e0dc173a93c9c8224ac6e37faed0dc12bf4fc","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-11-25T17:36:39Z","pushed_at":"2015-11-25T18:27:48Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":290910,"stargazers_count":11454,"watchers_count":11454,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3055,"mirror_url":null,"open_issues_count":2403,"forks":3055,"open_issues":2403,"watchers":11454,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17741"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/17741"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/17741"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/17741/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17741/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17741/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/1233aefe398423d387f088419ae9328f8f8bef06"}}}}