{"action":"closed","number":70,"pull_request":{"url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/pulls/70","id":40843735,"html_url":"https://github.com/dwyl/hapi-auth-jwt2/pull/70","diff_url":"https://github.com/dwyl/hapi-auth-jwt2/pull/70.diff","patch_url":"https://github.com/dwyl/hapi-auth-jwt2/pull/70.patch","issue_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/issues/70","number":70,"state":"closed","locked":false,"title":"Cookie checks","user":{"login":"nelsonic","id":194400,"avatar_url":"https://avatars.githubusercontent.com/u/194400?v=3","gravatar_id":"","url":"https://api.github.com/users/nelsonic","html_url":"https://github.com/nelsonic","followers_url":"https://api.github.com/users/nelsonic/followers","following_url":"https://api.github.com/users/nelsonic/following{/other_user}","gists_url":"https://api.github.com/users/nelsonic/gists{/gist_id}","starred_url":"https://api.github.com/users/nelsonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelsonic/subscriptions","organizations_url":"https://api.github.com/users/nelsonic/orgs","repos_url":"https://api.github.com/users/nelsonic/repos","events_url":"https://api.github.com/users/nelsonic/events{/privacy}","received_events_url":"https://api.github.com/users/nelsonic/received_events","type":"User","site_admin":false},"body":"+ Adds regression tests for issue noted by @duro in cookies: https://github.com/dwyl/hapi-auth-jwt2/issues/65 which means people can pass in multiple cookies (e.g. tracking or advertising) and still use Auth Headers or Cookie Token without issues. \r\n+ simplifies code in `scheme` from 78 lines of code down to 36 lines by splitting out extraction of token (from Auth Header, Url Parameter or Cookie) into separate helper method. see: #67 \r\n\r\nI :heart: Test! :wink: \r\n\r\nAlso tidies `.gitignore` file to be more legible.\r\n\r\n","created_at":"2015-07-25T21:39:50Z","updated_at":"2015-07-25T22:51:29Z","closed_at":"2015-07-25T22:51:29Z","merged_at":"2015-07-25T22:51:29Z","merge_commit_sha":"67c57bee1b90f4d91b7e59726bb659e6bb122593","assignee":{"login":"iteles","id":4185328,"avatar_url":"https://avatars.githubusercontent.com/u/4185328?v=3","gravatar_id":"","url":"https://api.github.com/users/iteles","html_url":"https://github.com/iteles","followers_url":"https://api.github.com/users/iteles/followers","following_url":"https://api.github.com/users/iteles/following{/other_user}","gists_url":"https://api.github.com/users/iteles/gists{/gist_id}","starred_url":"https://api.github.com/users/iteles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iteles/subscriptions","organizations_url":"https://api.github.com/users/iteles/orgs","repos_url":"https://api.github.com/users/iteles/repos","events_url":"https://api.github.com/users/iteles/events{/privacy}","received_events_url":"https://api.github.com/users/iteles/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/pulls/70/commits","review_comments_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/pulls/70/comments","review_comment_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/issues/70/comments","statuses_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/statuses/f37a9add53d0bb341fccbca235bcb7a870735f98","head":{"label":"dwyl:cookie-checks","ref":"cookie-checks","sha":"f37a9add53d0bb341fccbca235bcb7a870735f98","user":{"login":"dwyl","id":11708465,"avatar_url":"https://avatars.githubusercontent.com/u/11708465?v=3","gravatar_id":"","url":"https://api.github.com/users/dwyl","html_url":"https://github.com/dwyl","followers_url":"https://api.github.com/users/dwyl/followers","following_url":"https://api.github.com/users/dwyl/following{/other_user}","gists_url":"https://api.github.com/users/dwyl/gists{/gist_id}","starred_url":"https://api.github.com/users/dwyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwyl/subscriptions","organizations_url":"https://api.github.com/users/dwyl/orgs","repos_url":"https://api.github.com/users/dwyl/repos","events_url":"https://api.github.com/users/dwyl/events{/privacy}","received_events_url":"https://api.github.com/users/dwyl/received_events","type":"Organization","site_admin":false},"repo":{"id":31266953,"name":"hapi-auth-jwt2","full_name":"dwyl/hapi-auth-jwt2","owner":{"login":"dwyl","id":11708465,"avatar_url":"https://avatars.githubusercontent.com/u/11708465?v=3","gravatar_id":"","url":"https://api.github.com/users/dwyl","html_url":"https://github.com/dwyl","followers_url":"https://api.github.com/users/dwyl/followers","following_url":"https://api.github.com/users/dwyl/following{/other_user}","gists_url":"https://api.github.com/users/dwyl/gists{/gist_id}","starred_url":"https://api.github.com/users/dwyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwyl/subscriptions","organizations_url":"https://api.github.com/users/dwyl/orgs","repos_url":"https://api.github.com/users/dwyl/repos","events_url":"https://api.github.com/users/dwyl/events{/privacy}","received_events_url":"https://api.github.com/users/dwyl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dwyl/hapi-auth-jwt2","description":":lock: Secure Hapi.js authentication plugin using JSON Web Tokens (JWT)","fork":false,"url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2","forks_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/forks","keys_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/teams","hooks_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/hooks","issue_events_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/issues/events{/number}","events_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/events","assignees_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/assignees{/user}","branches_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/branches{/branch}","tags_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/tags","blobs_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/statuses/{sha}","languages_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/languages","stargazers_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/stargazers","contributors_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/contributors","subscribers_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/subscribers","subscription_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/subscription","commits_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/contents/{+path}","compare_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/merges","archive_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/downloads","issues_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/issues{/number}","pulls_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/pulls{/number}","milestones_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/milestones{/number}","notifications_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/labels{/name}","releases_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/releases{/id}","created_at":"2015-02-24T15:40:11Z","updated_at":"2015-07-25T21:27:49Z","pushed_at":"2015-07-25T22:51:29Z","git_url":"git://github.com/dwyl/hapi-auth-jwt2.git","ssh_url":"git@github.com:dwyl/hapi-auth-jwt2.git","clone_url":"https://github.com/dwyl/hapi-auth-jwt2.git","svn_url":"https://github.com/dwyl/hapi-auth-jwt2","homepage":"","size":515,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":9,"forks":9,"open_issues":9,"watchers":51,"default_branch":"master"}},"base":{"label":"dwyl:master","ref":"master","sha":"8793e6d12915c555cf07b64ae4d153ea65862960","user":{"login":"dwyl","id":11708465,"avatar_url":"https://avatars.githubusercontent.com/u/11708465?v=3","gravatar_id":"","url":"https://api.github.com/users/dwyl","html_url":"https://github.com/dwyl","followers_url":"https://api.github.com/users/dwyl/followers","following_url":"https://api.github.com/users/dwyl/following{/other_user}","gists_url":"https://api.github.com/users/dwyl/gists{/gist_id}","starred_url":"https://api.github.com/users/dwyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwyl/subscriptions","organizations_url":"https://api.github.com/users/dwyl/orgs","repos_url":"https://api.github.com/users/dwyl/repos","events_url":"https://api.github.com/users/dwyl/events{/privacy}","received_events_url":"https://api.github.com/users/dwyl/received_events","type":"Organization","site_admin":false},"repo":{"id":31266953,"name":"hapi-auth-jwt2","full_name":"dwyl/hapi-auth-jwt2","owner":{"login":"dwyl","id":11708465,"avatar_url":"https://avatars.githubusercontent.com/u/11708465?v=3","gravatar_id":"","url":"https://api.github.com/users/dwyl","html_url":"https://github.com/dwyl","followers_url":"https://api.github.com/users/dwyl/followers","following_url":"https://api.github.com/users/dwyl/following{/other_user}","gists_url":"https://api.github.com/users/dwyl/gists{/gist_id}","starred_url":"https://api.github.com/users/dwyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwyl/subscriptions","organizations_url":"https://api.github.com/users/dwyl/orgs","repos_url":"https://api.github.com/users/dwyl/repos","events_url":"https://api.github.com/users/dwyl/events{/privacy}","received_events_url":"https://api.github.com/users/dwyl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dwyl/hapi-auth-jwt2","description":":lock: Secure Hapi.js authentication plugin using JSON Web Tokens (JWT)","fork":false,"url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2","forks_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/forks","keys_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/teams","hooks_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/hooks","issue_events_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/issues/events{/number}","events_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/events","assignees_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/assignees{/user}","branches_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/branches{/branch}","tags_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/tags","blobs_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/statuses/{sha}","languages_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/languages","stargazers_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/stargazers","contributors_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/contributors","subscribers_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/subscribers","subscription_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/subscription","commits_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/contents/{+path}","compare_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/merges","archive_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/downloads","issues_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/issues{/number}","pulls_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/pulls{/number}","milestones_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/milestones{/number}","notifications_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/labels{/name}","releases_url":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/releases{/id}","created_at":"2015-02-24T15:40:11Z","updated_at":"2015-07-25T21:27:49Z","pushed_at":"2015-07-25T22:51:29Z","git_url":"git://github.com/dwyl/hapi-auth-jwt2.git","ssh_url":"git@github.com:dwyl/hapi-auth-jwt2.git","clone_url":"https://github.com/dwyl/hapi-auth-jwt2.git","svn_url":"https://github.com/dwyl/hapi-auth-jwt2","homepage":"","size":515,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":9,"forks":9,"open_issues":9,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/pulls/70"},"html":{"href":"https://github.com/dwyl/hapi-auth-jwt2/pull/70"},"issue":{"href":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/issues/70"},"comments":{"href":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/dwyl/hapi-auth-jwt2/statuses/f37a9add53d0bb341fccbca235bcb7a870735f98"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"iteles","id":4185328,"avatar_url":"https://avatars.githubusercontent.com/u/4185328?v=3","gravatar_id":"","url":"https://api.github.com/users/iteles","html_url":"https://github.com/iteles","followers_url":"https://api.github.com/users/iteles/followers","following_url":"https://api.github.com/users/iteles/following{/other_user}","gists_url":"https://api.github.com/users/iteles/gists{/gist_id}","starred_url":"https://api.github.com/users/iteles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iteles/subscriptions","organizations_url":"https://api.github.com/users/iteles/orgs","repos_url":"https://api.github.com/users/iteles/repos","events_url":"https://api.github.com/users/iteles/events{/privacy}","received_events_url":"https://api.github.com/users/iteles/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":5,"additions":184,"deletions":86,"changed_files":6}}