{"action":"created","comment":{"url":"https://api.github.com/repos/translate/pootle/pulls/comments/27292597","id":27292597,"diff_hunk":"@@ -42,231 +41,6 @@\n from pootle_store.util import TRANSLATED\n \n \n-def required_depcheck():\n-    required = []\n-\n-    status, version = depcheck.test_translate()\n-    if status:\n-        text = _('Translate Toolkit version %s installed.', version)\n-        state = 'tick'\n-    else:\n-        trans_vars = {\n-            'installed': version,\n-            'required': \".\".join([str(i) for i in\n-                                  depcheck.TTK_MINIMUM_REQUIRED_VERSION]),\n-        }\n-        text = _(\"Translate Toolkit version %(installed)s installed. Pootle \"\n-                 \"requires at least version %(required)s.\", trans_vars)\n-        state = 'error'\n-\n-    required.append({\n-        'dependency': 'translate',\n-        'state': state,\n-        'text': text,\n-    })\n-\n-    status, version = depcheck.test_django()\n-    if status:\n-        text = _('Django version %s is installed.', version)\n-        state = 'tick'\n-    else:\n-        trans_vars = {\n-            'installed': version,\n-            'required': \".\".join([str(i) for i in\n-                                  depcheck.DJANGO_MINIMUM_REQUIRED_VERSION]),\n-        }\n-        text = _(\"Django version %(installed)s is installed. Pootle requires \"\n-                 \"at least version %(required)s.\", trans_vars)\n-        state = 'error'\n-\n-    required.append({\n-        'dependency': 'django',\n-        'state': state,\n-        'text': text,\n-    })\n-\n-    status, version = depcheck.test_lxml()\n-    if status:\n-        text = _('lxml version %s is installed.', version)\n-        state = 'tick'\n-    elif version is not None:\n-        trans_vars = {\n-            'installed': version,\n-            'required': \".\".join([str(i) for i in\n-                                  depcheck.LXML_MINIMUM_REQUIRED_VERSION]),\n-        }\n-        text = _(\"lxml version %(installed)s is installed. Pootle requires at \"\n-                 \"least version %(required)s.\", trans_vars)\n-        state = 'error'\n-    else:\n-        text = _('lxml is not installed. Pootle requires lxml.')\n-        state = 'error'\n-\n-    required.append({\n-        'dependency': 'lxml',\n-        'state': state,\n-        'text': text,\n-    })\n-\n-    status_redis_available, connection_settings = depcheck.test_redis_server_available()\n-    if status_redis_available:\n-        status_redis_version, version = depcheck.test_redis_server_version()\n-        if status_redis_version:\n-            text = _('Redis server accepting connections on '\n-                     '%(host)s:%(port)s.', connection_settings)\n-            state = 'tick'\n-        else:\n-            trans_vars = {\n-                'installed': version,\n-                'required': \".\".join([str(i) for i in\n-                                      depcheck.REDIS_MINIMUM_REQUIRED_SERVER_VERSION]),\n-            }\n-            text = _(\"Redis server version %(installed)s installed. Pootle \"\n-                     \"requires at least version %(required)s.\", trans_vars)\n-            state = 'error'\n-    else:\n-        text = _('Redis server is not available on %(host)s:%(port)s.',\n-                 connection_settings)\n-        state = 'error'\n-\n-    required.append({\n-        'dependency': 'redis',\n-        'state': state,\n-        'text': text,\n-    })\n-\n-    status_workers, connection_settings['num'] = depcheck.test_rq_workers_running()\n-    if status_workers:\n-            text = ungettext(\n-                    '%(num)d RQ worker running.',\n-                    '%(num)d RQ workers running.',\n-                    connection_settings['num'], connection_settings)\n-            state = 'tick'\n-    else:\n-        text = _('No RQ workers are running.')\n-        state = 'error'\n-    required.append({\n-        'dependency': 'rq',\n-        'state': state,\n-        'text': text,\n-    })\n-\n-    if depcheck.test_cache():\n-        if not depcheck.test_cache_server_connection():\n-            # Server configured but connection failing\n-            required.append({\n-                'dependency': 'cache',\n-                'state': 'error',\n-                'text': _(\"Pootle is configured to use Redis as a caching \"\n-                          \"backend, but can't connect to the cache.\")\n-            })\n-        else:\n-            required.append({\n-                'dependency': 'cache',\n-                'state': 'tick',\n-                'text': _(\"Caching configured and running.\")\n-            })\n-    else:\n-        required.append({\n-            'dependency': 'cache',\n-            'state': 'error',\n-            'text': _(\"Redis is required as the caching backend.\")\n-        })\n-\n-\n-    return required\n-\n-\n-def optional_depcheck():\n-    optional = []\n-\n-    if not depcheck.test_iso_codes():\n-        optional.append({\n-            'dependency': 'iso-codes',\n-            'text': _(\"Can't find the ISO codes package. Pootle uses ISO codes\"\n-                      \" to translate language names.\")\n-        })\n-    if not depcheck.test_levenshtein():\n-        optional.append({\n-            'dependency': 'levenshtein',\n-            'text': _(\"Can't find python-levenshtein package. Updating against\"\n-                      \" templates is faster with python-levenshtein.\")\n-        })\n-\n-    filter_name, filter_args = get_markup_filter()\n-    if filter_name is None:\n-        text = None\n-        if filter_args == 'missing':\n-            text = _(\"MARKUP_FILTER is missing. Falling back to HTML.\")\n-        elif filter_args == 'misconfigured':\n-            text = _(\"MARKUP_FILTER is misconfigured. Falling back to HTML.\")\n-        elif filter_args == 'uninstalled':\n-            text = _(\"Can't find the package which provides '%s' markup \"\n-                     \"support. Falling back to HTML.\",\n-                     settings.MARKUP_FILTER[0])\n-        elif filter_args == 'invalid':\n-            text = _(\"Invalid value '%s' in MARKUP_FILTER. Falling back to \"\n-                     \"HTML.\", settings.MARKUP_FILTER[0])\n-\n-        if text is not None:\n-            optional.append({\n-                'dependency': filter_args + '-markup',\n-                'text': text\n-            })","path":"pootle/apps/pootle_app/views/admin/dashboard.py","position":182,"original_position":182,"commit_id":"14d4e9e2c06ce2a8f4f3541399c3c4f93545ba4f","original_commit_id":"6e309dcd9e517342b21eefe45030358ee2edcc80","user":{"login":"jleclanche","id":235410,"avatar_url":"https://avatars.githubusercontent.com/u/235410?v=3","gravatar_id":"","url":"https://api.github.com/users/jleclanche","html_url":"https://github.com/jleclanche","followers_url":"https://api.github.com/users/jleclanche/followers","following_url":"https://api.github.com/users/jleclanche/following{/other_user}","gists_url":"https://api.github.com/users/jleclanche/gists{/gist_id}","starred_url":"https://api.github.com/users/jleclanche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jleclanche/subscriptions","organizations_url":"https://api.github.com/users/jleclanche/orgs","repos_url":"https://api.github.com/users/jleclanche/repos","events_url":"https://api.github.com/users/jleclanche/events{/privacy}","received_events_url":"https://api.github.com/users/jleclanche/received_events","type":"User","site_admin":false},"body":"Repeating myself here for clarity: The markup checks are extremely unclear, at least to me. I brought them up before and got no reply. We can bring them back later once we know what we want to do with them, but this is completely unproductive and they aren't blockers, so let's land without them and figure it out later.","created_at":"2015-03-27T13:02:14Z","updated_at":"2015-03-27T13:02:14Z","html_url":"https://github.com/translate/pootle/pull/3595#discussion_r27292597","pull_request_url":"https://api.github.com/repos/translate/pootle/pulls/3595","_links":{"self":{"href":"https://api.github.com/repos/translate/pootle/pulls/comments/27292597"},"html":{"href":"https://github.com/translate/pootle/pull/3595#discussion_r27292597"},"pull_request":{"href":"https://api.github.com/repos/translate/pootle/pulls/3595"}}},"pull_request":{"url":"https://api.github.com/repos/translate/pootle/pulls/3595","id":29312831,"html_url":"https://github.com/translate/pootle/pull/3595","diff_url":"https://github.com/translate/pootle/pull/3595.diff","patch_url":"https://github.com/translate/pootle/pull/3595.patch","issue_url":"https://api.github.com/repos/translate/pootle/issues/3595","number":3595,"state":"closed","locked":false,"title":"Checks: Moved several check to Django 1.7 checks framework","user":{"login":"jleclanche","id":235410,"avatar_url":"https://avatars.githubusercontent.com/u/235410?v=3","gravatar_id":"","url":"https://api.github.com/users/jleclanche","html_url":"https://github.com/jleclanche","followers_url":"https://api.github.com/users/jleclanche/followers","following_url":"https://api.github.com/users/jleclanche/following{/other_user}","gists_url":"https://api.github.com/users/jleclanche/gists{/gist_id}","starred_url":"https://api.github.com/users/jleclanche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jleclanche/subscriptions","organizations_url":"https://api.github.com/users/jleclanche/orgs","repos_url":"https://api.github.com/users/jleclanche/repos","events_url":"https://api.github.com/users/jleclanche/events{/privacy}","received_events_url":"https://api.github.com/users/jleclanche/received_events","type":"User","site_admin":false},"body":"References #3594","created_at":"2015-02-14T01:33:52Z","updated_at":"2015-03-27T13:02:14Z","closed_at":"2015-03-27T13:02:06Z","merged_at":"2015-03-27T13:02:06Z","merge_commit_sha":"d674c33c2ed27b3425e272e5a51b04ed513036c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/translate/pootle/pulls/3595/commits","review_comments_url":"https://api.github.com/repos/translate/pootle/pulls/3595/comments","review_comment_url":"https://api.github.com/repos/translate/pootle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/translate/pootle/issues/3595/comments","statuses_url":"https://api.github.com/repos/translate/pootle/statuses/14d4e9e2c06ce2a8f4f3541399c3c4f93545ba4f","head":{"label":"jleclanche:master","ref":"master","sha":"14d4e9e2c06ce2a8f4f3541399c3c4f93545ba4f","user":{"login":"jleclanche","id":235410,"avatar_url":"https://avatars.githubusercontent.com/u/235410?v=3","gravatar_id":"","url":"https://api.github.com/users/jleclanche","html_url":"https://github.com/jleclanche","followers_url":"https://api.github.com/users/jleclanche/followers","following_url":"https://api.github.com/users/jleclanche/following{/other_user}","gists_url":"https://api.github.com/users/jleclanche/gists{/gist_id}","starred_url":"https://api.github.com/users/jleclanche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jleclanche/subscriptions","organizations_url":"https://api.github.com/users/jleclanche/orgs","repos_url":"https://api.github.com/users/jleclanche/repos","events_url":"https://api.github.com/users/jleclanche/events{/privacy}","received_events_url":"https://api.github.com/users/jleclanche/received_events","type":"User","site_admin":false},"repo":{"id":16691004,"name":"pootle","full_name":"jleclanche/pootle","owner":{"login":"jleclanche","id":235410,"avatar_url":"https://avatars.githubusercontent.com/u/235410?v=3","gravatar_id":"","url":"https://api.github.com/users/jleclanche","html_url":"https://github.com/jleclanche","followers_url":"https://api.github.com/users/jleclanche/followers","following_url":"https://api.github.com/users/jleclanche/following{/other_user}","gists_url":"https://api.github.com/users/jleclanche/gists{/gist_id}","starred_url":"https://api.github.com/users/jleclanche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jleclanche/subscriptions","organizations_url":"https://api.github.com/users/jleclanche/orgs","repos_url":"https://api.github.com/users/jleclanche/repos","events_url":"https://api.github.com/users/jleclanche/events{/privacy}","received_events_url":"https://api.github.com/users/jleclanche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jleclanche/pootle","description":"Online translation tool","fork":true,"url":"https://api.github.com/repos/jleclanche/pootle","forks_url":"https://api.github.com/repos/jleclanche/pootle/forks","keys_url":"https://api.github.com/repos/jleclanche/pootle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jleclanche/pootle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jleclanche/pootle/teams","hooks_url":"https://api.github.com/repos/jleclanche/pootle/hooks","issue_events_url":"https://api.github.com/repos/jleclanche/pootle/issues/events{/number}","events_url":"https://api.github.com/repos/jleclanche/pootle/events","assignees_url":"https://api.github.com/repos/jleclanche/pootle/assignees{/user}","branches_url":"https://api.github.com/repos/jleclanche/pootle/branches{/branch}","tags_url":"https://api.github.com/repos/jleclanche/pootle/tags","blobs_url":"https://api.github.com/repos/jleclanche/pootle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jleclanche/pootle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jleclanche/pootle/git/refs{/sha}","trees_url":"https://api.github.com/repos/jleclanche/pootle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jleclanche/pootle/statuses/{sha}","languages_url":"https://api.github.com/repos/jleclanche/pootle/languages","stargazers_url":"https://api.github.com/repos/jleclanche/pootle/stargazers","contributors_url":"https://api.github.com/repos/jleclanche/pootle/contributors","subscribers_url":"https://api.github.com/repos/jleclanche/pootle/subscribers","subscription_url":"https://api.github.com/repos/jleclanche/pootle/subscription","commits_url":"https://api.github.com/repos/jleclanche/pootle/commits{/sha}","git_commits_url":"https://api.github.com/repos/jleclanche/pootle/git/commits{/sha}","comments_url":"https://api.github.com/repos/jleclanche/pootle/comments{/number}","issue_comment_url":"https://api.github.com/repos/jleclanche/pootle/issues/comments{/number}","contents_url":"https://api.github.com/repos/jleclanche/pootle/contents/{+path}","compare_url":"https://api.github.com/repos/jleclanche/pootle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jleclanche/pootle/merges","archive_url":"https://api.github.com/repos/jleclanche/pootle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jleclanche/pootle/downloads","issues_url":"https://api.github.com/repos/jleclanche/pootle/issues{/number}","pulls_url":"https://api.github.com/repos/jleclanche/pootle/pulls{/number}","milestones_url":"https://api.github.com/repos/jleclanche/pootle/milestones{/number}","notifications_url":"https://api.github.com/repos/jleclanche/pootle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jleclanche/pootle/labels{/name}","releases_url":"https://api.github.com/repos/jleclanche/pootle/releases{/id}","created_at":"2014-02-10T09:47:26Z","updated_at":"2015-03-27T13:02:01Z","pushed_at":"2015-03-27T13:02:01Z","git_url":"git://github.com/jleclanche/pootle.git","ssh_url":"git@github.com:jleclanche/pootle.git","clone_url":"https://github.com/jleclanche/pootle.git","svn_url":"https://github.com/jleclanche/pootle","homepage":"http://pootle.translatehouse.org","size":64739,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"translate:master","ref":"master","sha":"58e735c6797eaf5fe273c04efa1a8ea7b8733451","user":{"login":"translate","id":1538178,"avatar_url":"https://avatars.githubusercontent.com/u/1538178?v=3","gravatar_id":"","url":"https://api.github.com/users/translate","html_url":"https://github.com/translate","followers_url":"https://api.github.com/users/translate/followers","following_url":"https://api.github.com/users/translate/following{/other_user}","gists_url":"https://api.github.com/users/translate/gists{/gist_id}","starred_url":"https://api.github.com/users/translate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/translate/subscriptions","organizations_url":"https://api.github.com/users/translate/orgs","repos_url":"https://api.github.com/users/translate/repos","events_url":"https://api.github.com/users/translate/events{/privacy}","received_events_url":"https://api.github.com/users/translate/received_events","type":"Organization","site_admin":false},"repo":{"id":3769702,"name":"pootle","full_name":"translate/pootle","owner":{"login":"translate","id":1538178,"avatar_url":"https://avatars.githubusercontent.com/u/1538178?v=3","gravatar_id":"","url":"https://api.github.com/users/translate","html_url":"https://github.com/translate","followers_url":"https://api.github.com/users/translate/followers","following_url":"https://api.github.com/users/translate/following{/other_user}","gists_url":"https://api.github.com/users/translate/gists{/gist_id}","starred_url":"https://api.github.com/users/translate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/translate/subscriptions","organizations_url":"https://api.github.com/users/translate/orgs","repos_url":"https://api.github.com/users/translate/repos","events_url":"https://api.github.com/users/translate/events{/privacy}","received_events_url":"https://api.github.com/users/translate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/translate/pootle","description":"Online translation tool","fork":false,"url":"https://api.github.com/repos/translate/pootle","forks_url":"https://api.github.com/repos/translate/pootle/forks","keys_url":"https://api.github.com/repos/translate/pootle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/translate/pootle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/translate/pootle/teams","hooks_url":"https://api.github.com/repos/translate/pootle/hooks","issue_events_url":"https://api.github.com/repos/translate/pootle/issues/events{/number}","events_url":"https://api.github.com/repos/translate/pootle/events","assignees_url":"https://api.github.com/repos/translate/pootle/assignees{/user}","branches_url":"https://api.github.com/repos/translate/pootle/branches{/branch}","tags_url":"https://api.github.com/repos/translate/pootle/tags","blobs_url":"https://api.github.com/repos/translate/pootle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/translate/pootle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/translate/pootle/git/refs{/sha}","trees_url":"https://api.github.com/repos/translate/pootle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/translate/pootle/statuses/{sha}","languages_url":"https://api.github.com/repos/translate/pootle/languages","stargazers_url":"https://api.github.com/repos/translate/pootle/stargazers","contributors_url":"https://api.github.com/repos/translate/pootle/contributors","subscribers_url":"https://api.github.com/repos/translate/pootle/subscribers","subscription_url":"https://api.github.com/repos/translate/pootle/subscription","commits_url":"https://api.github.com/repos/translate/pootle/commits{/sha}","git_commits_url":"https://api.github.com/repos/translate/pootle/git/commits{/sha}","comments_url":"https://api.github.com/repos/translate/pootle/comments{/number}","issue_comment_url":"https://api.github.com/repos/translate/pootle/issues/comments{/number}","contents_url":"https://api.github.com/repos/translate/pootle/contents/{+path}","compare_url":"https://api.github.com/repos/translate/pootle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/translate/pootle/merges","archive_url":"https://api.github.com/repos/translate/pootle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/translate/pootle/downloads","issues_url":"https://api.github.com/repos/translate/pootle/issues{/number}","pulls_url":"https://api.github.com/repos/translate/pootle/pulls{/number}","milestones_url":"https://api.github.com/repos/translate/pootle/milestones{/number}","notifications_url":"https://api.github.com/repos/translate/pootle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/translate/pootle/labels{/name}","releases_url":"https://api.github.com/repos/translate/pootle/releases{/id}","created_at":"2012-03-19T23:06:03Z","updated_at":"2015-03-27T13:02:06Z","pushed_at":"2015-03-27T13:02:06Z","git_url":"git://github.com/translate/pootle.git","ssh_url":"git@github.com:translate/pootle.git","clone_url":"https://github.com/translate/pootle.git","svn_url":"https://github.com/translate/pootle","homepage":"http://pootle.translatehouse.org","size":75088,"stargazers_count":416,"watchers_count":416,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":129,"mirror_url":null,"open_issues_count":435,"forks":129,"open_issues":435,"watchers":416,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/translate/pootle/pulls/3595"},"html":{"href":"https://github.com/translate/pootle/pull/3595"},"issue":{"href":"https://api.github.com/repos/translate/pootle/issues/3595"},"comments":{"href":"https://api.github.com/repos/translate/pootle/issues/3595/comments"},"review_comments":{"href":"https://api.github.com/repos/translate/pootle/pulls/3595/comments"},"review_comment":{"href":"https://api.github.com/repos/translate/pootle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/translate/pootle/pulls/3595/commits"},"statuses":{"href":"https://api.github.com/repos/translate/pootle/statuses/14d4e9e2c06ce2a8f4f3541399c3c4f93545ba4f"}}}}