{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/7835","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/7835/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/7835/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/7835/events","html_url":"https://github.com/NixOS/nixpkgs/pull/7835","id":76120782,"number":7835,"title":"Fix #7272 - re-Add modulesPath and add error context on module arguments evaluation.","user":{"login":"nbp","id":1179566,"avatar_url":"https://avatars.githubusercontent.com/u/1179566?v=3","gravatar_id":"","url":"https://api.github.com/users/nbp","html_url":"https://github.com/nbp","followers_url":"https://api.github.com/users/nbp/followers","following_url":"https://api.github.com/users/nbp/following{/other_user}","gists_url":"https://api.github.com/users/nbp/gists{/gist_id}","starred_url":"https://api.github.com/users/nbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbp/subscriptions","organizations_url":"https://api.github.com/users/nbp/orgs","repos_url":"https://api.github.com/users/nbp/repos","events_url":"https://api.github.com/users/nbp/events{/privacy}","received_events_url":"https://api.github.com/users/nbp/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/needs-changelog","name":"needs-changelog","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-13T20:54:18Z","updated_at":"2015-05-13T21:42:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7835","html_url":"https://github.com/NixOS/nixpkgs/pull/7835","diff_url":"https://github.com/NixOS/nixpkgs/pull/7835.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/7835.patch"},"body":"This modification undo the modifications related to `modulesPath` and use it in the installer to ensure that we do not brake this accidentally.  As there is no module logic for the moment, which can be used to replace the `modulesPath` argument, I prefer to add it back in the mean time.\r\n\r\nIn addition, this patch add an error context which, display one extra line of information when --show-trace is used.\r\n\r\n```\r\nwhile evaluating the module argument `pkgs' in \"/home/nicolas/nixos-dev/nixpkgs/foo.nix\":\r\ninfinite recursion encountered\r\n```\r\n\r\nThis error message worked for `modulesPath` before this modification which re-enables it, and it also works for the now deprecated use of `with pkgs.lib;`.\r\n\r\n@wizeman, can you confirm if this fix your issues?"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/101824895","html_url":"https://github.com/NixOS/nixpkgs/pull/7835#issuecomment-101824895","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/7835","id":101824895,"user":{"login":"nbp","id":1179566,"avatar_url":"https://avatars.githubusercontent.com/u/1179566?v=3","gravatar_id":"","url":"https://api.github.com/users/nbp","html_url":"https://github.com/nbp","followers_url":"https://api.github.com/users/nbp/followers","following_url":"https://api.github.com/users/nbp/following{/other_user}","gists_url":"https://api.github.com/users/nbp/gists{/gist_id}","starred_url":"https://api.github.com/users/nbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbp/subscriptions","organizations_url":"https://api.github.com/users/nbp/orgs","repos_url":"https://api.github.com/users/nbp/repos","events_url":"https://api.github.com/users/nbp/events{/privacy}","received_events_url":"https://api.github.com/users/nbp/received_events","type":"User","site_admin":false},"created_at":"2015-05-13T21:42:51Z","updated_at":"2015-05-13T21:42:51Z","body":"The second patch add the `importsArgs` feature after all, to filter attributes which should not come from the module system evaluation, even if they are not present in the `extraArgs`.\r\n"}}