{"action":"closed","number":4531,"pull_request":{"url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/4531","id":36797488,"html_url":"https://github.com/borisyankov/DefinitelyTyped/pull/4531","diff_url":"https://github.com/borisyankov/DefinitelyTyped/pull/4531.diff","patch_url":"https://github.com/borisyankov/DefinitelyTyped/pull/4531.patch","issue_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/4531","number":4531,"state":"closed","locked":false,"title":"[d3] Fix some errors in the d3 definitions","user":{"login":"jtlan","id":1440449,"avatar_url":"https://avatars.githubusercontent.com/u/1440449?v=3","gravatar_id":"","url":"https://api.github.com/users/jtlan","html_url":"https://github.com/jtlan","followers_url":"https://api.github.com/users/jtlan/followers","following_url":"https://api.github.com/users/jtlan/following{/other_user}","gists_url":"https://api.github.com/users/jtlan/gists{/gist_id}","starred_url":"https://api.github.com/users/jtlan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtlan/subscriptions","organizations_url":"https://api.github.com/users/jtlan/orgs","repos_url":"https://api.github.com/users/jtlan/repos","events_url":"https://api.github.com/users/jtlan/events{/privacy}","received_events_url":"https://api.github.com/users/jtlan/received_events","type":"User","site_admin":false},"body":"I recently upgraded Plottable to the [latest version of the d3.d.ts definitions file](https://github.com/borisyankov/DefinitelyTyped/pull/4032). I found a some errors, which I've corrected here:\r\n\r\n#### `Interval.offset()`\r\nShould take a `number` not a `Date` as the second parameter:\r\n(https://github.com/mbostock/d3/wiki/Time-Intervals#interval_offset)\r\n\r\n#### `svg.area.defined()` and `svg.area.radial.defined()`\r\nIn two places the \"setter\" signature for `defined()` wasn't listed.\r\n\r\n#### `svg.symbol()`'s index parameter is optional\r\nhttps://github.com/mbostock/d3/wiki/SVG-Shapes#_symbol\r\n\r\nPlottable PR here: https://github.com/palantir/plottable/pull/2212","created_at":"2015-06-03T04:23:46Z","updated_at":"2015-06-07T14:20:51Z","closed_at":"2015-06-07T14:20:51Z","merged_at":"2015-06-07T14:20:51Z","merge_commit_sha":"7e480164c395866daf4e12cec69368d4efb044df","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/4531/commits","review_comments_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/4531/comments","review_comment_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/4531/comments","statuses_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/statuses/8ab53b38cfdf61e7dc75cf960f427a68bd996664","head":{"label":"jtlan:fixD3","ref":"fixD3","sha":"8ab53b38cfdf61e7dc75cf960f427a68bd996664","user":{"login":"jtlan","id":1440449,"avatar_url":"https://avatars.githubusercontent.com/u/1440449?v=3","gravatar_id":"","url":"https://api.github.com/users/jtlan","html_url":"https://github.com/jtlan","followers_url":"https://api.github.com/users/jtlan/followers","following_url":"https://api.github.com/users/jtlan/following{/other_user}","gists_url":"https://api.github.com/users/jtlan/gists{/gist_id}","starred_url":"https://api.github.com/users/jtlan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtlan/subscriptions","organizations_url":"https://api.github.com/users/jtlan/orgs","repos_url":"https://api.github.com/users/jtlan/repos","events_url":"https://api.github.com/users/jtlan/events{/privacy}","received_events_url":"https://api.github.com/users/jtlan/received_events","type":"User","site_admin":false},"repo":{"id":24660674,"name":"DefinitelyTyped","full_name":"jtlan/DefinitelyTyped","owner":{"login":"jtlan","id":1440449,"avatar_url":"https://avatars.githubusercontent.com/u/1440449?v=3","gravatar_id":"","url":"https://api.github.com/users/jtlan","html_url":"https://github.com/jtlan","followers_url":"https://api.github.com/users/jtlan/followers","following_url":"https://api.github.com/users/jtlan/following{/other_user}","gists_url":"https://api.github.com/users/jtlan/gists{/gist_id}","starred_url":"https://api.github.com/users/jtlan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtlan/subscriptions","organizations_url":"https://api.github.com/users/jtlan/orgs","repos_url":"https://api.github.com/users/jtlan/repos","events_url":"https://api.github.com/users/jtlan/events{/privacy}","received_events_url":"https://api.github.com/users/jtlan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jtlan/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/jtlan/DefinitelyTyped","forks_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/jtlan/DefinitelyTyped/releases{/id}","created_at":"2014-10-01T00:29:33Z","updated_at":"2015-06-01T23:44:52Z","pushed_at":"2015-06-03T04:18:21Z","git_url":"git://github.com/jtlan/DefinitelyTyped.git","ssh_url":"git@github.com:jtlan/DefinitelyTyped.git","clone_url":"https://github.com/jtlan/DefinitelyTyped.git","svn_url":"https://github.com/jtlan/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":60645,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"borisyankov:master","ref":"master","sha":"c50b111ded0a3a18b87b5abffea3150d6aca94da","user":{"login":"borisyankov","id":867242,"avatar_url":"https://avatars.githubusercontent.com/u/867242?v=3","gravatar_id":"","url":"https://api.github.com/users/borisyankov","html_url":"https://github.com/borisyankov","followers_url":"https://api.github.com/users/borisyankov/followers","following_url":"https://api.github.com/users/borisyankov/following{/other_user}","gists_url":"https://api.github.com/users/borisyankov/gists{/gist_id}","starred_url":"https://api.github.com/users/borisyankov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisyankov/subscriptions","organizations_url":"https://api.github.com/users/borisyankov/orgs","repos_url":"https://api.github.com/users/borisyankov/repos","events_url":"https://api.github.com/users/borisyankov/events{/privacy}","received_events_url":"https://api.github.com/users/borisyankov/received_events","type":"User","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"borisyankov/DefinitelyTyped","owner":{"login":"borisyankov","id":867242,"avatar_url":"https://avatars.githubusercontent.com/u/867242?v=3","gravatar_id":"","url":"https://api.github.com/users/borisyankov","html_url":"https://github.com/borisyankov","followers_url":"https://api.github.com/users/borisyankov/followers","following_url":"https://api.github.com/users/borisyankov/following{/other_user}","gists_url":"https://api.github.com/users/borisyankov/gists{/gist_id}","starred_url":"https://api.github.com/users/borisyankov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisyankov/subscriptions","organizations_url":"https://api.github.com/users/borisyankov/orgs","repos_url":"https://api.github.com/users/borisyankov/repos","events_url":"https://api.github.com/users/borisyankov/events{/privacy}","received_events_url":"https://api.github.com/users/borisyankov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/borisyankov/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/borisyankov/DefinitelyTyped","forks_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/releases{/id}","created_at":"2012-10-05T16:39:45Z","updated_at":"2015-06-07T11:41:07Z","pushed_at":"2015-06-07T14:20:51Z","git_url":"git://github.com/borisyankov/DefinitelyTyped.git","ssh_url":"git@github.com:borisyankov/DefinitelyTyped.git","clone_url":"https://github.com/borisyankov/DefinitelyTyped.git","svn_url":"https://github.com/borisyankov/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":93629,"stargazers_count":4162,"watchers_count":4162,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2535,"mirror_url":null,"open_issues_count":587,"forks":2535,"open_issues":587,"watchers":4162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/4531"},"html":{"href":"https://github.com/borisyankov/DefinitelyTyped/pull/4531"},"issue":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/4531"},"comments":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/4531/comments"},"review_comments":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/4531/comments"},"review_comment":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/4531/commits"},"statuses":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/statuses/8ab53b38cfdf61e7dc75cf960f427a68bd996664"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"vvakame","id":125332,"avatar_url":"https://avatars.githubusercontent.com/u/125332?v=3","gravatar_id":"","url":"https://api.github.com/users/vvakame","html_url":"https://github.com/vvakame","followers_url":"https://api.github.com/users/vvakame/followers","following_url":"https://api.github.com/users/vvakame/following{/other_user}","gists_url":"https://api.github.com/users/vvakame/gists{/gist_id}","starred_url":"https://api.github.com/users/vvakame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvakame/subscriptions","organizations_url":"https://api.github.com/users/vvakame/orgs","repos_url":"https://api.github.com/users/vvakame/repos","events_url":"https://api.github.com/users/vvakame/events{/privacy}","received_events_url":"https://api.github.com/users/vvakame/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":20,"deletions":18,"changed_files":1}}