{"action":"closed","number":38,"pull_request":{"url":"https://api.github.com/repos/pytest-dev/pytest-qt/pulls/38","id":33721778,"html_url":"https://github.com/pytest-dev/pytest-qt/pull/38","diff_url":"https://github.com/pytest-dev/pytest-qt/pull/38.diff","patch_url":"https://github.com/pytest-dev/pytest-qt/pull/38.patch","issue_url":"https://api.github.com/repos/pytest-dev/pytest-qt/issues/38","number":38,"state":"closed","locked":false,"title":"Fix segfault when app is garbage collected","user":{"login":"jdreaver","id":1253071,"avatar_url":"https://avatars.githubusercontent.com/u/1253071?v=3","gravatar_id":"","url":"https://api.github.com/users/jdreaver","html_url":"https://github.com/jdreaver","followers_url":"https://api.github.com/users/jdreaver/followers","following_url":"https://api.github.com/users/jdreaver/following{/other_user}","gists_url":"https://api.github.com/users/jdreaver/gists{/gist_id}","starred_url":"https://api.github.com/users/jdreaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdreaver/subscriptions","organizations_url":"https://api.github.com/users/jdreaver/orgs","repos_url":"https://api.github.com/users/jdreaver/repos","events_url":"https://api.github.com/users/jdreaver/events{/privacy}","received_events_url":"https://api.github.com/users/jdreaver/received_events","type":"User","site_admin":false},"body":"When I was using pytest-qt with a test suite I have, I was getting a segfault after all the tests passed. I realized that the `QApplication` instance in the `qapp` fixture was probably getting garbage collected too early. I just added a `deleteLater` call so the C++ `QApplication` object gets deleted before Python garbage collects the variable. This fixed my test suite at least, and doesn't seem to cause any harm.","created_at":"2015-04-21T01:25:51Z","updated_at":"2015-04-21T08:16:23Z","closed_at":"2015-04-21T08:16:23Z","merged_at":"2015-04-21T08:16:23Z","merge_commit_sha":"e9934777fe8e9ff63a91758f7ff1e996c763a53f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pytest-dev/pytest-qt/pulls/38/commits","review_comments_url":"https://api.github.com/repos/pytest-dev/pytest-qt/pulls/38/comments","review_comment_url":"https://api.github.com/repos/pytest-dev/pytest-qt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytest-dev/pytest-qt/issues/38/comments","statuses_url":"https://api.github.com/repos/pytest-dev/pytest-qt/statuses/db5f7a52e73d462b402103d45272aa3aa0abf16c","head":{"label":"jdreaver:master","ref":"master","sha":"db5f7a52e73d462b402103d45272aa3aa0abf16c","user":{"login":"jdreaver","id":1253071,"avatar_url":"https://avatars.githubusercontent.com/u/1253071?v=3","gravatar_id":"","url":"https://api.github.com/users/jdreaver","html_url":"https://github.com/jdreaver","followers_url":"https://api.github.com/users/jdreaver/followers","following_url":"https://api.github.com/users/jdreaver/following{/other_user}","gists_url":"https://api.github.com/users/jdreaver/gists{/gist_id}","starred_url":"https://api.github.com/users/jdreaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdreaver/subscriptions","organizations_url":"https://api.github.com/users/jdreaver/orgs","repos_url":"https://api.github.com/users/jdreaver/repos","events_url":"https://api.github.com/users/jdreaver/events{/privacy}","received_events_url":"https://api.github.com/users/jdreaver/received_events","type":"User","site_admin":false},"repo":{"id":34296194,"name":"pytest-qt","full_name":"jdreaver/pytest-qt","owner":{"login":"jdreaver","id":1253071,"avatar_url":"https://avatars.githubusercontent.com/u/1253071?v=3","gravatar_id":"","url":"https://api.github.com/users/jdreaver","html_url":"https://github.com/jdreaver","followers_url":"https://api.github.com/users/jdreaver/followers","following_url":"https://api.github.com/users/jdreaver/following{/other_user}","gists_url":"https://api.github.com/users/jdreaver/gists{/gist_id}","starred_url":"https://api.github.com/users/jdreaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdreaver/subscriptions","organizations_url":"https://api.github.com/users/jdreaver/orgs","repos_url":"https://api.github.com/users/jdreaver/repos","events_url":"https://api.github.com/users/jdreaver/events{/privacy}","received_events_url":"https://api.github.com/users/jdreaver/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdreaver/pytest-qt","description":"pytest plugin for Qt (PyQt and PySide) application testing","fork":true,"url":"https://api.github.com/repos/jdreaver/pytest-qt","forks_url":"https://api.github.com/repos/jdreaver/pytest-qt/forks","keys_url":"https://api.github.com/repos/jdreaver/pytest-qt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdreaver/pytest-qt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdreaver/pytest-qt/teams","hooks_url":"https://api.github.com/repos/jdreaver/pytest-qt/hooks","issue_events_url":"https://api.github.com/repos/jdreaver/pytest-qt/issues/events{/number}","events_url":"https://api.github.com/repos/jdreaver/pytest-qt/events","assignees_url":"https://api.github.com/repos/jdreaver/pytest-qt/assignees{/user}","branches_url":"https://api.github.com/repos/jdreaver/pytest-qt/branches{/branch}","tags_url":"https://api.github.com/repos/jdreaver/pytest-qt/tags","blobs_url":"https://api.github.com/repos/jdreaver/pytest-qt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdreaver/pytest-qt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdreaver/pytest-qt/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdreaver/pytest-qt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdreaver/pytest-qt/statuses/{sha}","languages_url":"https://api.github.com/repos/jdreaver/pytest-qt/languages","stargazers_url":"https://api.github.com/repos/jdreaver/pytest-qt/stargazers","contributors_url":"https://api.github.com/repos/jdreaver/pytest-qt/contributors","subscribers_url":"https://api.github.com/repos/jdreaver/pytest-qt/subscribers","subscription_url":"https://api.github.com/repos/jdreaver/pytest-qt/subscription","commits_url":"https://api.github.com/repos/jdreaver/pytest-qt/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdreaver/pytest-qt/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdreaver/pytest-qt/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdreaver/pytest-qt/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdreaver/pytest-qt/contents/{+path}","compare_url":"https://api.github.com/repos/jdreaver/pytest-qt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdreaver/pytest-qt/merges","archive_url":"https://api.github.com/repos/jdreaver/pytest-qt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdreaver/pytest-qt/downloads","issues_url":"https://api.github.com/repos/jdreaver/pytest-qt/issues{/number}","pulls_url":"https://api.github.com/repos/jdreaver/pytest-qt/pulls{/number}","milestones_url":"https://api.github.com/repos/jdreaver/pytest-qt/milestones{/number}","notifications_url":"https://api.github.com/repos/jdreaver/pytest-qt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdreaver/pytest-qt/labels{/name}","releases_url":"https://api.github.com/repos/jdreaver/pytest-qt/releases{/id}","created_at":"2015-04-21T01:19:09Z","updated_at":"2015-04-21T01:20:19Z","pushed_at":"2015-04-21T01:20:18Z","git_url":"git://github.com/jdreaver/pytest-qt.git","ssh_url":"git@github.com:jdreaver/pytest-qt.git","clone_url":"https://github.com/jdreaver/pytest-qt.git","svn_url":"https://github.com/jdreaver/pytest-qt","homepage":"","size":970,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytest-dev:master","ref":"master","sha":"62b5bdf1ed85bdafcee4a7bef7da0e3ab0cdca03","user":{"login":"pytest-dev","id":8897583,"avatar_url":"https://avatars.githubusercontent.com/u/8897583?v=3","gravatar_id":"","url":"https://api.github.com/users/pytest-dev","html_url":"https://github.com/pytest-dev","followers_url":"https://api.github.com/users/pytest-dev/followers","following_url":"https://api.github.com/users/pytest-dev/following{/other_user}","gists_url":"https://api.github.com/users/pytest-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pytest-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytest-dev/subscriptions","organizations_url":"https://api.github.com/users/pytest-dev/orgs","repos_url":"https://api.github.com/users/pytest-dev/repos","events_url":"https://api.github.com/users/pytest-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pytest-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":8444568,"name":"pytest-qt","full_name":"pytest-dev/pytest-qt","owner":{"login":"pytest-dev","id":8897583,"avatar_url":"https://avatars.githubusercontent.com/u/8897583?v=3","gravatar_id":"","url":"https://api.github.com/users/pytest-dev","html_url":"https://github.com/pytest-dev","followers_url":"https://api.github.com/users/pytest-dev/followers","following_url":"https://api.github.com/users/pytest-dev/following{/other_user}","gists_url":"https://api.github.com/users/pytest-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pytest-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytest-dev/subscriptions","organizations_url":"https://api.github.com/users/pytest-dev/orgs","repos_url":"https://api.github.com/users/pytest-dev/repos","events_url":"https://api.github.com/users/pytest-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pytest-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytest-dev/pytest-qt","description":"pytest plugin for Qt (PyQt and PySide) application testing","fork":false,"url":"https://api.github.com/repos/pytest-dev/pytest-qt","forks_url":"https://api.github.com/repos/pytest-dev/pytest-qt/forks","keys_url":"https://api.github.com/repos/pytest-dev/pytest-qt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytest-dev/pytest-qt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytest-dev/pytest-qt/teams","hooks_url":"https://api.github.com/repos/pytest-dev/pytest-qt/hooks","issue_events_url":"https://api.github.com/repos/pytest-dev/pytest-qt/issues/events{/number}","events_url":"https://api.github.com/repos/pytest-dev/pytest-qt/events","assignees_url":"https://api.github.com/repos/pytest-dev/pytest-qt/assignees{/user}","branches_url":"https://api.github.com/repos/pytest-dev/pytest-qt/branches{/branch}","tags_url":"https://api.github.com/repos/pytest-dev/pytest-qt/tags","blobs_url":"https://api.github.com/repos/pytest-dev/pytest-qt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytest-dev/pytest-qt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytest-dev/pytest-qt/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytest-dev/pytest-qt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytest-dev/pytest-qt/statuses/{sha}","languages_url":"https://api.github.com/repos/pytest-dev/pytest-qt/languages","stargazers_url":"https://api.github.com/repos/pytest-dev/pytest-qt/stargazers","contributors_url":"https://api.github.com/repos/pytest-dev/pytest-qt/contributors","subscribers_url":"https://api.github.com/repos/pytest-dev/pytest-qt/subscribers","subscription_url":"https://api.github.com/repos/pytest-dev/pytest-qt/subscription","commits_url":"https://api.github.com/repos/pytest-dev/pytest-qt/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytest-dev/pytest-qt/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytest-dev/pytest-qt/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytest-dev/pytest-qt/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytest-dev/pytest-qt/contents/{+path}","compare_url":"https://api.github.com/repos/pytest-dev/pytest-qt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytest-dev/pytest-qt/merges","archive_url":"https://api.github.com/repos/pytest-dev/pytest-qt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytest-dev/pytest-qt/downloads","issues_url":"https://api.github.com/repos/pytest-dev/pytest-qt/issues{/number}","pulls_url":"https://api.github.com/repos/pytest-dev/pytest-qt/pulls{/number}","milestones_url":"https://api.github.com/repos/pytest-dev/pytest-qt/milestones{/number}","notifications_url":"https://api.github.com/repos/pytest-dev/pytest-qt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytest-dev/pytest-qt/labels{/name}","releases_url":"https://api.github.com/repos/pytest-dev/pytest-qt/releases{/id}","created_at":"2013-02-26T23:33:46Z","updated_at":"2015-04-16T12:28:08Z","pushed_at":"2015-04-21T08:16:24Z","git_url":"git://github.com/pytest-dev/pytest-qt.git","ssh_url":"git@github.com:pytest-dev/pytest-qt.git","clone_url":"https://github.com/pytest-dev/pytest-qt.git","svn_url":"https://github.com/pytest-dev/pytest-qt","homepage":"","size":970,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytest-dev/pytest-qt/pulls/38"},"html":{"href":"https://github.com/pytest-dev/pytest-qt/pull/38"},"issue":{"href":"https://api.github.com/repos/pytest-dev/pytest-qt/issues/38"},"comments":{"href":"https://api.github.com/repos/pytest-dev/pytest-qt/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/pytest-dev/pytest-qt/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/pytest-dev/pytest-qt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytest-dev/pytest-qt/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/pytest-dev/pytest-qt/statuses/db5f7a52e73d462b402103d45272aa3aa0abf16c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nicoddemus","id":1085180,"avatar_url":"https://avatars.githubusercontent.com/u/1085180?v=3","gravatar_id":"","url":"https://api.github.com/users/nicoddemus","html_url":"https://github.com/nicoddemus","followers_url":"https://api.github.com/users/nicoddemus/followers","following_url":"https://api.github.com/users/nicoddemus/following{/other_user}","gists_url":"https://api.github.com/users/nicoddemus/gists{/gist_id}","starred_url":"https://api.github.com/users/nicoddemus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicoddemus/subscriptions","organizations_url":"https://api.github.com/users/nicoddemus/orgs","repos_url":"https://api.github.com/users/nicoddemus/repos","events_url":"https://api.github.com/users/nicoddemus/events{/privacy}","received_events_url":"https://api.github.com/users/nicoddemus/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}