{"action":"created","issue":{"url":"https://api.github.com/repos/pac4j/pac4j/issues/207","labels_url":"https://api.github.com/repos/pac4j/pac4j/issues/207/labels{/name}","comments_url":"https://api.github.com/repos/pac4j/pac4j/issues/207/comments","events_url":"https://api.github.com/repos/pac4j/pac4j/issues/207/events","html_url":"https://github.com/pac4j/pac4j/issues/207","id":97239503,"number":207,"title":"Allow for arbitrary attributes on a profile","user":{"login":"pledbrook","id":19075,"avatar_url":"https://avatars.githubusercontent.com/u/19075?v=3","gravatar_id":"","url":"https://api.github.com/users/pledbrook","html_url":"https://github.com/pledbrook","followers_url":"https://api.github.com/users/pledbrook/followers","following_url":"https://api.github.com/users/pledbrook/following{/other_user}","gists_url":"https://api.github.com/users/pledbrook/gists{/gist_id}","starred_url":"https://api.github.com/users/pledbrook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pledbrook/subscriptions","organizations_url":"https://api.github.com/users/pledbrook/orgs","repos_url":"https://api.github.com/users/pledbrook/repos","events_url":"https://api.github.com/users/pledbrook/events{/privacy}","received_events_url":"https://api.github.com/users/pledbrook/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-07-25T17:01:01Z","updated_at":"2015-07-27T09:23:05Z","closed_at":null,"body":"I'm currently working on an app that allows authentication through Twitter, Google and username/password. I want to attach any user that logs in through OAuth to a user instance in the database. My preferred way to link the two is through a custom attribute on the profile.\r\n\r\nUnfortunately, it seems I can't do this because the attribute is ignored if it's not part of the attributes definition associated with that profile. I propose that pac4j allows any attributes to be added, even if they're not part of the attributes definition. It's then up to the developer to manage them."},"comment":{"url":"https://api.github.com/repos/pac4j/pac4j/issues/comments/125140437","html_url":"https://github.com/pac4j/pac4j/issues/207#issuecomment-125140437","issue_url":"https://api.github.com/repos/pac4j/pac4j/issues/207","id":125140437,"user":{"login":"pledbrook","id":19075,"avatar_url":"https://avatars.githubusercontent.com/u/19075?v=3","gravatar_id":"","url":"https://api.github.com/users/pledbrook","html_url":"https://github.com/pledbrook","followers_url":"https://api.github.com/users/pledbrook/followers","following_url":"https://api.github.com/users/pledbrook/following{/other_user}","gists_url":"https://api.github.com/users/pledbrook/gists{/gist_id}","starred_url":"https://api.github.com/users/pledbrook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pledbrook/subscriptions","organizations_url":"https://api.github.com/users/pledbrook/orgs","repos_url":"https://api.github.com/users/pledbrook/repos","events_url":"https://api.github.com/users/pledbrook/events{/privacy}","received_events_url":"https://api.github.com/users/pledbrook/received_events","type":"User","site_admin":false},"created_at":"2015-07-27T09:23:04Z","updated_at":"2015-07-27T09:23:04Z","body":"You mention getters, but I suggested adding setters. That would mean updating existing classes like `TwitterClient` and `Google2Client` in pac4j-oauth. So do you agree with that part, i.e. adding setters?\r\n\r\nOn the test front, I take it there are no integration-style tests then?"}}