{"action":"created","comment":{"url":"https://api.github.com/repos/flycheck/flycheck/pulls/comments/26906432","id":26906432,"diff_hunk":"@@ -6330,6 +6331,118 @@ See URL `http://lesscss.org'.\"\n           line-end))\n   :modes less-css-mode)\n \n+(defconst flycheck-luacheck-std-globals-list\n+  '(\"_G\" \"lua51\" \"lua52\" \"lua52c\" \"lua53\" \"lua53c\" \"luajit\" \"min\" \"max\" \"none\")\n+  \"List of standard globals.\")\n+\n+(flycheck-def-option-var flycheck-luacheck-std-globals\n+    (nth 0 flycheck-luacheck-std-globals-list)\n+    luacheck\n+  \"Set standard globals.\n+Must be one of the members in `flycheck-luacheck-std-globals-list'.\"\n+  :type `(choice (const :tag \"Globals of the Lua interpreter\"\n+                        ,(nth 0 flycheck-luacheck-std-globals-list))\n+                 (const :tag \"Globals of Lua 5.1\"\n+                        ,(nth 1 flycheck-luacheck-std-globals-list))\n+                 (const :tag \"Globals of Lua 5.2\"\n+                        ,(nth 2 flycheck-luacheck-std-globals-list))\n+                 (const :tag \"Globals of Lua 5.2 compiled with LUA_COMPAT_ALL\"\n+                        ,(nth 3 flycheck-luacheck-std-globals-list))\n+                 (const :tag \"Globals of Lua 5.3\"\n+                        ,(nth 4 flycheck-luacheck-std-globals-list))\n+                 (const :tag \"Globals of Lua 5.3 compiled with LUA_COMPAT_ALL\"\n+                        ,(nth 5 flycheck-luacheck-std-globals-list))\n+                 (const :tag \"Globals of LuaJIT 2.0\"\n+                        ,(nth 6 flycheck-luacheck-std-globals-list))\n+                 (const :tag \"Intersection of globals of Lua 5.1, 5.2 and LuaJIT 2.0\"\n+                        ,(nth 7 flycheck-luacheck-std-globals-list))\n+                 (const :tag \"Union of globals of Lua 5.1, 5.2 and LuaJIT 2.0\"\n+                        ,(nth 8 flycheck-luacheck-std-globals-list))\n+                 (const :tag \"No standard globals\"\n+                        ,(nth 9 flycheck-luacheck-std-globals-list)))\n+  :safe (lambda (value) (member value flycheck-luacheck-std-globals-list))\n+  :package-version '(flycheck . \"0.23\"))\n+\n+(flycheck-def-option-var flycheck-luacheck-no-globals nil luacheck\n+  \"Filter out warnings related to global variables.\"\n+  :type 'boolean\n+  :safe #'booleanp\n+  :package-version '(flycheck . \"0.23\"))\n+\n+(flycheck-def-option-var flycheck-luacheck-no-unused nil luacheck\n+  \"Filter out warnings related to unused variables and values.\"\n+  :type 'boolean\n+  :safe #'booleanp\n+  :package-version '(flycheck . \"0.23\"))\n+\n+(flycheck-def-option-var flycheck-luacheck-no-redefined nil luacheck\n+  \"Filter out warnings related to redefined variables.\"\n+  :type 'boolean\n+  :safe #'booleanp\n+  :package-version '(flycheck . \"0.23\"))\n+\n+(flycheck-def-option-var flycheck-luacheck-no-unused-args nil luacheck\n+  \"Filter out warnings related to unused arguments and loop variables.\"\n+  :type 'boolean\n+  :safe #'booleanp\n+  :package-version '(flycheck . \"0.23\"))\n+\n+(flycheck-def-option-var flycheck-luacheck-no-unused-secondaries nil luacheck\n+  \"Filter out warnings related to unused variables set together\n+with used ones.\"\n+  :type 'boolean\n+  :safe #'booleanp\n+  :package-version '(flycheck . \"0.23\"))\n+\n+(flycheck-def-option-var flycheck-luacheck-no-unused-globals nil luacheck\n+  \"Filter out warnings related to set but unused global variables.\"\n+  :type 'boolean\n+  :safe #'booleanp\n+  :package-version '(flycheck . \"0.23\"))\n+\n+(flycheck-def-option-var flycheck-luacheck-globals nil luacheck\n+  \"A list of additional globals to add on top of standard ones.\"\n+  :type '(choice (const :tag \"No additional globals\" nil)\n+                 (repeat :tag \"Additional global\"\n+                         (string :tag \"Global name\")))\n+  :safe #'flycheck-string-list-p\n+  :package-version '(flycheck . \"0.23\"))\n+\n+(flycheck-def-option-var flycheck-luacheck-read-globals nil luacheck\n+  \"A list of additional globals to add on top of standard ones.\"\n+  :type '(choice (const :tag \"No additional read-only globals\" nil)\n+                 (repeat :tag \"Additional read-only global\"\n+                         (string :tag \"Global name\")))\n+  :safe #'flycheck-string-list-p\n+  :package-version '(flycheck . \"0.23\"))\n+\n+(flycheck-define-checker luacheck\n+  \"A Lua syntax checker using luacheck.\n+\n+See URL `https://github.com/mpeterv/luacheck'.\"\n+  :command (\"luacheck\"\n+            \"--no-config\"\n+            (option \"--std\" flycheck-luacheck-std-globals)\n+            (option-flag \"--no-global\" flycheck-luacheck-no-globals)\n+            (option-flag \"--no-unused\" flycheck-luacheck-no-unused)\n+            (option-flag \"--no-redefined\" flycheck-luacheck-no-redefined)\n+            (option-flag \"--no-unused-args\" flycheck-luacheck-no-unused-args)\n+            (option-flag \"--no-unused-secondaries\" flycheck-luacheck-no-unused-secondaries)\n+            (option-flag \"--no-unused-globals\" flycheck-luacheck-no-unused-globals)\n+            \"--formatter\" \"plain\"\n+            \"--codes\"","path":"flycheck.el","position":87,"original_position":111,"commit_id":"5aff2bc9dbeedb7f61281a085896675a3e1849fb","original_commit_id":"c431de1729fecabb73807aff50a5f7d39a4878a8","user":{"login":"lunaryorn","id":224922,"avatar_url":"https://avatars.githubusercontent.com/u/224922?v=3","gravatar_id":"","url":"https://api.github.com/users/lunaryorn","html_url":"https://github.com/lunaryorn","followers_url":"https://api.github.com/users/lunaryorn/followers","following_url":"https://api.github.com/users/lunaryorn/following{/other_user}","gists_url":"https://api.github.com/users/lunaryorn/gists{/gist_id}","starred_url":"https://api.github.com/users/lunaryorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunaryorn/subscriptions","organizations_url":"https://api.github.com/users/lunaryorn/orgs","repos_url":"https://api.github.com/users/lunaryorn/repos","events_url":"https://api.github.com/users/lunaryorn/events{/privacy}","received_events_url":"https://api.github.com/users/lunaryorn/received_events","type":"User","site_admin":false},"body":"@ptrv Would you mind to add a small comment that explains the use of `--codes` here?  This would make it easier for me to understand what's going on later.","created_at":"2015-03-22T19:46:03Z","updated_at":"2015-03-22T19:46:03Z","html_url":"https://github.com/flycheck/flycheck/pull/609#discussion_r26906432","pull_request_url":"https://api.github.com/repos/flycheck/flycheck/pulls/609","_links":{"self":{"href":"https://api.github.com/repos/flycheck/flycheck/pulls/comments/26906432"},"html":{"href":"https://github.com/flycheck/flycheck/pull/609#discussion_r26906432"},"pull_request":{"href":"https://api.github.com/repos/flycheck/flycheck/pulls/609"}}},"pull_request":{"url":"https://api.github.com/repos/flycheck/flycheck/pulls/609","id":31671210,"html_url":"https://github.com/flycheck/flycheck/pull/609","diff_url":"https://github.com/flycheck/flycheck/pull/609.diff","patch_url":"https://github.com/flycheck/flycheck/pull/609.patch","issue_url":"https://api.github.com/repos/flycheck/flycheck/issues/609","number":609,"state":"open","locked":false,"title":"Add luacheck syntax checker","user":{"login":"ptrv","id":49775,"avatar_url":"https://avatars.githubusercontent.com/u/49775?v=3","gravatar_id":"","url":"https://api.github.com/users/ptrv","html_url":"https://github.com/ptrv","followers_url":"https://api.github.com/users/ptrv/followers","following_url":"https://api.github.com/users/ptrv/following{/other_user}","gists_url":"https://api.github.com/users/ptrv/gists{/gist_id}","starred_url":"https://api.github.com/users/ptrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptrv/subscriptions","organizations_url":"https://api.github.com/users/ptrv/orgs","repos_url":"https://api.github.com/users/ptrv/repos","events_url":"https://api.github.com/users/ptrv/events{/privacy}","received_events_url":"https://api.github.com/users/ptrv/received_events","type":"User","site_admin":false},"body":"Adding `luackeck` to the test VM is very simple:\r\n\r\nAfter lua52 is installed you need following steps\r\n1. Download and unpack latest luacheck from https://github.com/mpeterv/luacheck/archive/0.10.0.tar.gz\r\n2. Run `sudo lua install.lua /usr/local` inside luacheck source folder\r\n\r\nNow the `luacheck` executable is in `/usr/local/bin` which is probably in `PATH`","created_at":"2015-03-21T13:25:57Z","updated_at":"2015-03-22T19:46:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5697f9b6f5e7de01404626203e169409be53368","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flycheck/flycheck/pulls/609/commits","review_comments_url":"https://api.github.com/repos/flycheck/flycheck/pulls/609/comments","review_comment_url":"https://api.github.com/repos/flycheck/flycheck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flycheck/flycheck/issues/609/comments","statuses_url":"https://api.github.com/repos/flycheck/flycheck/statuses/5aff2bc9dbeedb7f61281a085896675a3e1849fb","head":{"label":"ptrv:add-luacheck-checker","ref":"add-luacheck-checker","sha":"5aff2bc9dbeedb7f61281a085896675a3e1849fb","user":{"login":"ptrv","id":49775,"avatar_url":"https://avatars.githubusercontent.com/u/49775?v=3","gravatar_id":"","url":"https://api.github.com/users/ptrv","html_url":"https://github.com/ptrv","followers_url":"https://api.github.com/users/ptrv/followers","following_url":"https://api.github.com/users/ptrv/following{/other_user}","gists_url":"https://api.github.com/users/ptrv/gists{/gist_id}","starred_url":"https://api.github.com/users/ptrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptrv/subscriptions","organizations_url":"https://api.github.com/users/ptrv/orgs","repos_url":"https://api.github.com/users/ptrv/repos","events_url":"https://api.github.com/users/ptrv/events{/privacy}","received_events_url":"https://api.github.com/users/ptrv/received_events","type":"User","site_admin":false},"repo":{"id":7354327,"name":"flycheck","full_name":"ptrv/flycheck","owner":{"login":"ptrv","id":49775,"avatar_url":"https://avatars.githubusercontent.com/u/49775?v=3","gravatar_id":"","url":"https://api.github.com/users/ptrv","html_url":"https://github.com/ptrv","followers_url":"https://api.github.com/users/ptrv/followers","following_url":"https://api.github.com/users/ptrv/following{/other_user}","gists_url":"https://api.github.com/users/ptrv/gists{/gist_id}","starred_url":"https://api.github.com/users/ptrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptrv/subscriptions","organizations_url":"https://api.github.com/users/ptrv/orgs","repos_url":"https://api.github.com/users/ptrv/repos","events_url":"https://api.github.com/users/ptrv/events{/privacy}","received_events_url":"https://api.github.com/users/ptrv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ptrv/flycheck","description":"On the fly syntax checking for GNU Emacs (aka \"flymake done right\")","fork":true,"url":"https://api.github.com/repos/ptrv/flycheck","forks_url":"https://api.github.com/repos/ptrv/flycheck/forks","keys_url":"https://api.github.com/repos/ptrv/flycheck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ptrv/flycheck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ptrv/flycheck/teams","hooks_url":"https://api.github.com/repos/ptrv/flycheck/hooks","issue_events_url":"https://api.github.com/repos/ptrv/flycheck/issues/events{/number}","events_url":"https://api.github.com/repos/ptrv/flycheck/events","assignees_url":"https://api.github.com/repos/ptrv/flycheck/assignees{/user}","branches_url":"https://api.github.com/repos/ptrv/flycheck/branches{/branch}","tags_url":"https://api.github.com/repos/ptrv/flycheck/tags","blobs_url":"https://api.github.com/repos/ptrv/flycheck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ptrv/flycheck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ptrv/flycheck/git/refs{/sha}","trees_url":"https://api.github.com/repos/ptrv/flycheck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ptrv/flycheck/statuses/{sha}","languages_url":"https://api.github.com/repos/ptrv/flycheck/languages","stargazers_url":"https://api.github.com/repos/ptrv/flycheck/stargazers","contributors_url":"https://api.github.com/repos/ptrv/flycheck/contributors","subscribers_url":"https://api.github.com/repos/ptrv/flycheck/subscribers","subscription_url":"https://api.github.com/repos/ptrv/flycheck/subscription","commits_url":"https://api.github.com/repos/ptrv/flycheck/commits{/sha}","git_commits_url":"https://api.github.com/repos/ptrv/flycheck/git/commits{/sha}","comments_url":"https://api.github.com/repos/ptrv/flycheck/comments{/number}","issue_comment_url":"https://api.github.com/repos/ptrv/flycheck/issues/comments{/number}","contents_url":"https://api.github.com/repos/ptrv/flycheck/contents/{+path}","compare_url":"https://api.github.com/repos/ptrv/flycheck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ptrv/flycheck/merges","archive_url":"https://api.github.com/repos/ptrv/flycheck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ptrv/flycheck/downloads","issues_url":"https://api.github.com/repos/ptrv/flycheck/issues{/number}","pulls_url":"https://api.github.com/repos/ptrv/flycheck/pulls{/number}","milestones_url":"https://api.github.com/repos/ptrv/flycheck/milestones{/number}","notifications_url":"https://api.github.com/repos/ptrv/flycheck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ptrv/flycheck/labels{/name}","releases_url":"https://api.github.com/repos/ptrv/flycheck/releases{/id}","created_at":"2012-12-28T12:53:25Z","updated_at":"2013-10-13T11:07:23Z","pushed_at":"2015-03-22T19:37:44Z","git_url":"git://github.com/ptrv/flycheck.git","ssh_url":"git@github.com:ptrv/flycheck.git","clone_url":"https://github.com/ptrv/flycheck.git","svn_url":"https://github.com/ptrv/flycheck","homepage":"","size":10125,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flycheck:master","ref":"master","sha":"6625ba1ca6b8ea162bc91aee56d703f7ca60e97d","user":{"login":"flycheck","id":5254142,"avatar_url":"https://avatars.githubusercontent.com/u/5254142?v=3","gravatar_id":"","url":"https://api.github.com/users/flycheck","html_url":"https://github.com/flycheck","followers_url":"https://api.github.com/users/flycheck/followers","following_url":"https://api.github.com/users/flycheck/following{/other_user}","gists_url":"https://api.github.com/users/flycheck/gists{/gist_id}","starred_url":"https://api.github.com/users/flycheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flycheck/subscriptions","organizations_url":"https://api.github.com/users/flycheck/orgs","repos_url":"https://api.github.com/users/flycheck/repos","events_url":"https://api.github.com/users/flycheck/events{/privacy}","received_events_url":"https://api.github.com/users/flycheck/received_events","type":"Organization","site_admin":false},"repo":{"id":6158882,"name":"flycheck","full_name":"flycheck/flycheck","owner":{"login":"flycheck","id":5254142,"avatar_url":"https://avatars.githubusercontent.com/u/5254142?v=3","gravatar_id":"","url":"https://api.github.com/users/flycheck","html_url":"https://github.com/flycheck","followers_url":"https://api.github.com/users/flycheck/followers","following_url":"https://api.github.com/users/flycheck/following{/other_user}","gists_url":"https://api.github.com/users/flycheck/gists{/gist_id}","starred_url":"https://api.github.com/users/flycheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flycheck/subscriptions","organizations_url":"https://api.github.com/users/flycheck/orgs","repos_url":"https://api.github.com/users/flycheck/repos","events_url":"https://api.github.com/users/flycheck/events{/privacy}","received_events_url":"https://api.github.com/users/flycheck/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flycheck/flycheck","description":"Modern on the fly syntax checking for GNU Emacs","fork":false,"url":"https://api.github.com/repos/flycheck/flycheck","forks_url":"https://api.github.com/repos/flycheck/flycheck/forks","keys_url":"https://api.github.com/repos/flycheck/flycheck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flycheck/flycheck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flycheck/flycheck/teams","hooks_url":"https://api.github.com/repos/flycheck/flycheck/hooks","issue_events_url":"https://api.github.com/repos/flycheck/flycheck/issues/events{/number}","events_url":"https://api.github.com/repos/flycheck/flycheck/events","assignees_url":"https://api.github.com/repos/flycheck/flycheck/assignees{/user}","branches_url":"https://api.github.com/repos/flycheck/flycheck/branches{/branch}","tags_url":"https://api.github.com/repos/flycheck/flycheck/tags","blobs_url":"https://api.github.com/repos/flycheck/flycheck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flycheck/flycheck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flycheck/flycheck/git/refs{/sha}","trees_url":"https://api.github.com/repos/flycheck/flycheck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flycheck/flycheck/statuses/{sha}","languages_url":"https://api.github.com/repos/flycheck/flycheck/languages","stargazers_url":"https://api.github.com/repos/flycheck/flycheck/stargazers","contributors_url":"https://api.github.com/repos/flycheck/flycheck/contributors","subscribers_url":"https://api.github.com/repos/flycheck/flycheck/subscribers","subscription_url":"https://api.github.com/repos/flycheck/flycheck/subscription","commits_url":"https://api.github.com/repos/flycheck/flycheck/commits{/sha}","git_commits_url":"https://api.github.com/repos/flycheck/flycheck/git/commits{/sha}","comments_url":"https://api.github.com/repos/flycheck/flycheck/comments{/number}","issue_comment_url":"https://api.github.com/repos/flycheck/flycheck/issues/comments{/number}","contents_url":"https://api.github.com/repos/flycheck/flycheck/contents/{+path}","compare_url":"https://api.github.com/repos/flycheck/flycheck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flycheck/flycheck/merges","archive_url":"https://api.github.com/repos/flycheck/flycheck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flycheck/flycheck/downloads","issues_url":"https://api.github.com/repos/flycheck/flycheck/issues{/number}","pulls_url":"https://api.github.com/repos/flycheck/flycheck/pulls{/number}","milestones_url":"https://api.github.com/repos/flycheck/flycheck/milestones{/number}","notifications_url":"https://api.github.com/repos/flycheck/flycheck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flycheck/flycheck/labels{/name}","releases_url":"https://api.github.com/repos/flycheck/flycheck/releases{/id}","created_at":"2012-10-10T14:45:13Z","updated_at":"2015-03-22T02:38:10Z","pushed_at":"2015-03-22T19:41:58Z","git_url":"git://github.com/flycheck/flycheck.git","ssh_url":"git@github.com:flycheck/flycheck.git","clone_url":"https://github.com/flycheck/flycheck.git","svn_url":"https://github.com/flycheck/flycheck","homepage":"http://www.flycheck.org","size":20949,"stargazers_count":635,"watchers_count":635,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":111,"mirror_url":null,"open_issues_count":38,"forks":111,"open_issues":38,"watchers":635,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flycheck/flycheck/pulls/609"},"html":{"href":"https://github.com/flycheck/flycheck/pull/609"},"issue":{"href":"https://api.github.com/repos/flycheck/flycheck/issues/609"},"comments":{"href":"https://api.github.com/repos/flycheck/flycheck/issues/609/comments"},"review_comments":{"href":"https://api.github.com/repos/flycheck/flycheck/pulls/609/comments"},"review_comment":{"href":"https://api.github.com/repos/flycheck/flycheck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flycheck/flycheck/pulls/609/commits"},"statuses":{"href":"https://api.github.com/repos/flycheck/flycheck/statuses/5aff2bc9dbeedb7f61281a085896675a3e1849fb"}}}}