{"action":"created","issue":{"url":"https://api.github.com/repos/3rd-Eden/memcached/issues/256","labels_url":"https://api.github.com/repos/3rd-Eden/memcached/issues/256/labels{/name}","comments_url":"https://api.github.com/repos/3rd-Eden/memcached/issues/256/comments","events_url":"https://api.github.com/repos/3rd-Eden/memcached/issues/256/events","html_url":"https://github.com/3rd-Eden/memcached/pull/256","id":96632423,"number":256,"title":"Defend VERSION token parse against memcached 1.4.14 (ubuntu)","user":{"login":"mrlannigan","id":730443,"avatar_url":"https://avatars.githubusercontent.com/u/730443?v=3","gravatar_id":"","url":"https://api.github.com/users/mrlannigan","html_url":"https://github.com/mrlannigan","followers_url":"https://api.github.com/users/mrlannigan/followers","following_url":"https://api.github.com/users/mrlannigan/following{/other_user}","gists_url":"https://api.github.com/users/mrlannigan/gists{/gist_id}","starred_url":"https://api.github.com/users/mrlannigan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrlannigan/subscriptions","organizations_url":"https://api.github.com/users/mrlannigan/orgs","repos_url":"https://api.github.com/users/mrlannigan/repos","events_url":"https://api.github.com/users/mrlannigan/events{/privacy}","received_events_url":"https://api.github.com/users/mrlannigan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-22T18:21:02Z","updated_at":"2015-11-19T20:02:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/3rd-Eden/memcached/pulls/256","html_url":"https://github.com/3rd-Eden/memcached/pull/256","diff_url":"https://github.com/3rd-Eden/memcached/pull/256.diff","patch_url":"https://github.com/3rd-Eden/memcached/pull/256.patch"},"body":"We noticed that Ubuntu likes to put their name in everything.\r\n```\r\n$ echo \"version\" | nc localhost 11211\r\nVERSION 1.4.14 (Ubuntu)\r\n```\r\n\r\nThis response breaks the VERSION token parse in this library. The `(Ubuntu)` token should have never been included in the following release:\r\n\r\n```\r\n$ dpkg -l | grep ^ii | grep memcache\r\nii  memcached                           1.4.14-0ubuntu9                  amd64        A high-performance memory object caching system\r\n```\r\n\r\nThis library is right, and this version of memcached is wrong as per the spec: https://github.com/memcached/memcached/blob/master/doc/protocol.txt#L884\r\n\r\nAnd this PR helps prevent an uncaught exception for when ubuntu's memcached builds decide to violate the protocol."},"comment":{"url":"https://api.github.com/repos/3rd-Eden/memcached/issues/comments/158179931","html_url":"https://github.com/3rd-Eden/memcached/pull/256#issuecomment-158179931","issue_url":"https://api.github.com/repos/3rd-Eden/memcached/issues/256","id":158179931,"user":{"login":"Dirrk","id":431645,"avatar_url":"https://avatars.githubusercontent.com/u/431645?v=3","gravatar_id":"","url":"https://api.github.com/users/Dirrk","html_url":"https://github.com/Dirrk","followers_url":"https://api.github.com/users/Dirrk/followers","following_url":"https://api.github.com/users/Dirrk/following{/other_user}","gists_url":"https://api.github.com/users/Dirrk/gists{/gist_id}","starred_url":"https://api.github.com/users/Dirrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dirrk/subscriptions","organizations_url":"https://api.github.com/users/Dirrk/orgs","repos_url":"https://api.github.com/users/Dirrk/repos","events_url":"https://api.github.com/users/Dirrk/events{/privacy}","received_events_url":"https://api.github.com/users/Dirrk/received_events","type":"User","site_admin":false},"created_at":"2015-11-19T20:02:18Z","updated_at":"2015-11-19T20:02:18Z","body":"Also having this issue"}}