{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/35546647","id":35546647,"diff_hunk":"@@ -146,42 +172,53 @@ synchronized void acquireReadLock( Object tx ) throws DeadlockDetectedException\n     {\n         TxLockElement tle = getOrCreateLockElement( tx );\n \n+        LockRequest lockRequest = null;\n+        boolean addLockRequest = true;","path":"community/kernel/src/main/java/org/neo4j/kernel/impl/locking/community/RWLock.java","position":77,"original_position":77,"commit_id":"91d643b6e7cadb181b6433cb957399f0715aebb7","original_commit_id":"91d643b6e7cadb181b6433cb957399f0715aebb7","user":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars.githubusercontent.com/u/12656787?v=3","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"body":"Concept is still the same as with `WaitElement` except it gives more specific description what we are requesting, also completion flag introduced to be able to mark particular request as completed to avoid duplicated registration of lock that already was registered before.","created_at":"2015-07-27T15:10:50Z","updated_at":"2015-07-27T15:10:50Z","html_url":"https://github.com/neo4j/neo4j/pull/4998#discussion_r35546647","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/4998","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/35546647"},"html":{"href":"https://github.com/neo4j/neo4j/pull/4998#discussion_r35546647"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4998"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/4998","id":40307954,"html_url":"https://github.com/neo4j/neo4j/pull/4998","diff_url":"https://github.com/neo4j/neo4j/pull/4998.diff","patch_url":"https://github.com/neo4j/neo4j/pull/4998.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/4998","number":4998,"state":"open","locked":false,"title":"Missing write and read lock requests in community RWLock","user":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars.githubusercontent.com/u/12656787?v=3","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"body":"When last active resource owner release lock and detect waiting thread (reader or writer)\r\nit removes LockElement from a lock, and interrupts waiting thread.\r\nThat will cause totalReadCount or totalWriteCount to be out of sync with LockElement counters (because of LockElement was removed) as soon as waiting thread will take a resource.\r\n\r\nThis commit should fix a problem when missing write/read lock for a popular resource cause all threads to wait for a resource to be released. Test cases for missing write and read cases provided","created_at":"2015-07-19T13:10:53Z","updated_at":"2015-07-27T15:10:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cfa1048f719e63b6648c82198803bfe097011c4","assignee":{"login":"digitalstain","id":408167,"avatar_url":"https://avatars.githubusercontent.com/u/408167?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalstain","html_url":"https://github.com/digitalstain","followers_url":"https://api.github.com/users/digitalstain/followers","following_url":"https://api.github.com/users/digitalstain/following{/other_user}","gists_url":"https://api.github.com/users/digitalstain/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalstain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalstain/subscriptions","organizations_url":"https://api.github.com/users/digitalstain/orgs","repos_url":"https://api.github.com/users/digitalstain/repos","events_url":"https://api.github.com/users/digitalstain/events{/privacy}","received_events_url":"https://api.github.com/users/digitalstain/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/4998/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/4998/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/4998/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/91d643b6e7cadb181b6433cb957399f0715aebb7","head":{"label":"MishaDemianenko:2.3-community-ha","ref":"2.3-community-ha","sha":"91d643b6e7cadb181b6433cb957399f0715aebb7","user":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars.githubusercontent.com/u/12656787?v=3","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"repo":{"id":36607274,"name":"neo4j","full_name":"MishaDemianenko/neo4j","owner":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars.githubusercontent.com/u/12656787?v=3","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MishaDemianenko/neo4j","description":"Graphs for Everyone","fork":true,"url":"https://api.github.com/repos/MishaDemianenko/neo4j","forks_url":"https://api.github.com/repos/MishaDemianenko/neo4j/forks","keys_url":"https://api.github.com/repos/MishaDemianenko/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MishaDemianenko/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MishaDemianenko/neo4j/teams","hooks_url":"https://api.github.com/repos/MishaDemianenko/neo4j/hooks","issue_events_url":"https://api.github.com/repos/MishaDemianenko/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/MishaDemianenko/neo4j/events","assignees_url":"https://api.github.com/repos/MishaDemianenko/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/MishaDemianenko/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/MishaDemianenko/neo4j/tags","blobs_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MishaDemianenko/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/MishaDemianenko/neo4j/languages","stargazers_url":"https://api.github.com/repos/MishaDemianenko/neo4j/stargazers","contributors_url":"https://api.github.com/repos/MishaDemianenko/neo4j/contributors","subscribers_url":"https://api.github.com/repos/MishaDemianenko/neo4j/subscribers","subscription_url":"https://api.github.com/repos/MishaDemianenko/neo4j/subscription","commits_url":"https://api.github.com/repos/MishaDemianenko/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/MishaDemianenko/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/MishaDemianenko/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/MishaDemianenko/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/MishaDemianenko/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MishaDemianenko/neo4j/merges","archive_url":"https://api.github.com/repos/MishaDemianenko/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MishaDemianenko/neo4j/downloads","issues_url":"https://api.github.com/repos/MishaDemianenko/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/MishaDemianenko/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/MishaDemianenko/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/MishaDemianenko/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MishaDemianenko/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/MishaDemianenko/neo4j/releases{/id}","created_at":"2015-05-31T14:44:24Z","updated_at":"2015-05-31T14:44:50Z","pushed_at":"2015-07-27T13:16:57Z","git_url":"git://github.com/MishaDemianenko/neo4j.git","ssh_url":"git@github.com:MishaDemianenko/neo4j.git","clone_url":"https://github.com/MishaDemianenko/neo4j.git","svn_url":"https://github.com/MishaDemianenko/neo4j","homepage":"http://neo4j.com","size":202070,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.3"}},"base":{"label":"neo4j:2.3","ref":"2.3","sha":"056bdb0dd6308a9ac335995e648815887cbe8a73","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","created_at":"2012-11-12T08:46:15Z","updated_at":"2015-07-27T09:24:22Z","pushed_at":"2015-07-27T14:46:26Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":478861,"stargazers_count":1849,"watchers_count":1849,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":719,"mirror_url":null,"open_issues_count":466,"forks":719,"open_issues":466,"watchers":1849,"default_branch":"2.3"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4998"},"html":{"href":"https://github.com/neo4j/neo4j/pull/4998"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/4998"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/4998/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4998/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4998/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/91d643b6e7cadb181b6433cb957399f0715aebb7"}}}}