{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/plottable/issues/2765","labels_url":"https://api.github.com/repos/palantir/plottable/issues/2765/labels{/name}","comments_url":"https://api.github.com/repos/palantir/plottable/issues/2765/comments","events_url":"https://api.github.com/repos/palantir/plottable/issues/2765/events","html_url":"https://github.com/palantir/plottable/pull/2765","id":106118336,"number":2765,"title":"Refactor dispatcher tests - Pass 1","user":{"login":"aicioara","id":3248682,"avatar_url":"https://avatars.githubusercontent.com/u/3248682?v=3","gravatar_id":"","url":"https://api.github.com/users/aicioara","html_url":"https://github.com/aicioara","followers_url":"https://api.github.com/users/aicioara/followers","following_url":"https://api.github.com/users/aicioara/following{/other_user}","gists_url":"https://api.github.com/users/aicioara/gists{/gist_id}","starred_url":"https://api.github.com/users/aicioara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aicioara/subscriptions","organizations_url":"https://api.github.com/users/aicioara/orgs","repos_url":"https://api.github.com/users/aicioara/repos","events_url":"https://api.github.com/users/aicioara/events{/privacy}","received_events_url":"https://api.github.com/users/aicioara/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/palantir/plottable/labels/In%20CR","name":"In CR","color":"0052cc"},{"url":"https://api.github.com/repos/palantir/plottable/labels/NOQE","name":"NOQE","color":"000000"}],"state":"open","locked":false,"assignee":{"login":"bluong","id":1448299,"avatar_url":"https://avatars.githubusercontent.com/u/1448299?v=3","gravatar_id":"","url":"https://api.github.com/users/bluong","html_url":"https://github.com/bluong","followers_url":"https://api.github.com/users/bluong/followers","following_url":"https://api.github.com/users/bluong/following{/other_user}","gists_url":"https://api.github.com/users/bluong/gists{/gist_id}","starred_url":"https://api.github.com/users/bluong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluong/subscriptions","organizations_url":"https://api.github.com/users/bluong/orgs","repos_url":"https://api.github.com/users/bluong/repos","events_url":"https://api.github.com/users/bluong/events{/privacy}","received_events_url":"https://api.github.com/users/bluong/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/palantir/plottable/milestones/55","html_url":"https://github.com/palantir/plottable/milestones/v1.15.0","labels_url":"https://api.github.com/repos/palantir/plottable/milestones/55/labels","id":1309195,"number":55,"title":"v1.15.0","description":"","creator":{"login":"christinaforney","id":1559622,"avatar_url":"https://avatars.githubusercontent.com/u/1559622?v=3","gravatar_id":"","url":"https://api.github.com/users/christinaforney","html_url":"https://github.com/christinaforney","followers_url":"https://api.github.com/users/christinaforney/followers","following_url":"https://api.github.com/users/christinaforney/following{/other_user}","gists_url":"https://api.github.com/users/christinaforney/gists{/gist_id}","starred_url":"https://api.github.com/users/christinaforney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christinaforney/subscriptions","organizations_url":"https://api.github.com/users/christinaforney/orgs","repos_url":"https://api.github.com/users/christinaforney/repos","events_url":"https://api.github.com/users/christinaforney/events{/privacy}","received_events_url":"https://api.github.com/users/christinaforney/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":0,"state":"open","created_at":"2015-09-16T20:11:20Z","updated_at":"2015-10-03T00:54:01Z","due_on":"2015-10-09T07:00:00Z","closed_at":null},"comments":3,"created_at":"2015-09-12T01:09:15Z","updated_at":"2015-10-05T09:43:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/palantir/plottable/pulls/2765","html_url":"https://github.com/palantir/plottable/pull/2765","diff_url":"https://github.com/palantir/plottable/pull/2765.diff","patch_url":"https://github.com/palantir/plottable/pull/2765.patch"},"body":"Part of #2628\r\n\r\nI will be doing 2 passes because I will get more context (and better sense of best practices) by refactoring other files. However, please flag anything that seems unusual.\r\n\r\nAs part of this: \r\n- **Test semantics: hierarchy, naming, testing, but no coverage check**\r\n- Applied best practices from the wiki page\r\n- Factored out common code into `beforeEach()` clauses\r\n- No nested `beforeEach()`es\r\n- Cleaned the console\r\n- Remade hierarchy as shown bellow\r\n![screen shot 2015-09-11 at 6 08 33 pm](https://cloud.githubusercontent.com/assets/3248682/9829218/34d8c38a-58b0-11e5-8042-8cdd400a6729.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/palantir/plottable/issues/comments/145482257","html_url":"https://github.com/palantir/plottable/pull/2765#issuecomment-145482257","issue_url":"https://api.github.com/repos/palantir/plottable/issues/2765","id":145482257,"user":{"login":"bluong","id":1448299,"avatar_url":"https://avatars.githubusercontent.com/u/1448299?v=3","gravatar_id":"","url":"https://api.github.com/users/bluong","html_url":"https://github.com/bluong","followers_url":"https://api.github.com/users/bluong/followers","following_url":"https://api.github.com/users/bluong/following{/other_user}","gists_url":"https://api.github.com/users/bluong/gists{/gist_id}","starred_url":"https://api.github.com/users/bluong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluong/subscriptions","organizations_url":"https://api.github.com/users/bluong/orgs","repos_url":"https://api.github.com/users/bluong/repos","events_url":"https://api.github.com/users/bluong/events{/privacy}","received_events_url":"https://api.github.com/users/bluong/received_events","type":"User","site_admin":false},"created_at":"2015-10-05T09:43:07Z","updated_at":"2015-10-05T09:43:07Z","body":"We need to figure out the `Mocks` answer.  Otherwise we can iterate on this pretty quickly."}}