{"action":"created","issue":{"url":"https://api.github.com/repos/composite-primary-keys/composite_primary_keys/issues/326","labels_url":"https://api.github.com/repos/composite-primary-keys/composite_primary_keys/issues/326/labels{/name}","comments_url":"https://api.github.com/repos/composite-primary-keys/composite_primary_keys/issues/326/comments","events_url":"https://api.github.com/repos/composite-primary-keys/composite_primary_keys/issues/326/events","html_url":"https://github.com/composite-primary-keys/composite_primary_keys/pull/326","id":109698940,"number":326,"title":"Start AR4.2.4 Compatibility","user":{"login":"brgaulin","id":4007825,"avatar_url":"https://avatars.githubusercontent.com/u/4007825?v=3","gravatar_id":"","url":"https://api.github.com/users/brgaulin","html_url":"https://github.com/brgaulin","followers_url":"https://api.github.com/users/brgaulin/followers","following_url":"https://api.github.com/users/brgaulin/following{/other_user}","gists_url":"https://api.github.com/users/brgaulin/gists{/gist_id}","starred_url":"https://api.github.com/users/brgaulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brgaulin/subscriptions","organizations_url":"https://api.github.com/users/brgaulin/orgs","repos_url":"https://api.github.com/users/brgaulin/repos","events_url":"https://api.github.com/users/brgaulin/events{/privacy}","received_events_url":"https://api.github.com/users/brgaulin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-04T19:19:51Z","updated_at":"2015-10-11T16:08:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/composite-primary-keys/composite_primary_keys/pulls/326","html_url":"https://github.com/composite-primary-keys/composite_primary_keys/pull/326","diff_url":"https://github.com/composite-primary-keys/composite_primary_keys/pull/326.diff","patch_url":"https://github.com/composite-primary-keys/composite_primary_keys/pull/326.patch"},"body":"This should help #323 and some weird Rails 4.2.4 compatibility issues. For the most part I went and got the updated code from the rails 4.2.4 branch. Most of the changes were from a while ago, small bug fixes, etc. But there were a lot of them =)\r\n\r\nI am going to run a bunch of tests locally against a private project and report back if this breaks 4.2.3 or 4.2.4 integrations. If it does we may just need to lock at AR4.2.4 for the next version.\r\n\r\nAlso you may want to look at this with whitespace off. My editor tends to add newlines at the ends of files and such(if this isn't desired for some reason let me know and I will revert those) but ya, lots of nothing lines changed.\r\n\r\n/cc @cfis \r\nURL for whitespace off: https://github.com/composite-primary-keys/composite_primary_keys/pull/326/files?w=false\r\n\r\nRelevant Rails Commits\r\nhttps://github.com/rails/rails/commit/6cd9e2bd29b26e1ea781fafce18614217b7adf7b\r\nhttps://github.com/rails/rails/commit/4b534152951fe9b1af8a1d3311da766e1d42392a\r\nhttps://github.com/rails/rails/commit/9f1b5c9b4032d081f5b7d7fe9697ba24e2ae3ff8\r\nhttps://github.com/rails/rails/commit/dd8b5fb9d30f355d4eab6376b8d9e025e90b14d3\r\nhttps://github.com/rails/rails/commit/cb277485f9d78f3661c7103e7b468812cc283223\r\nhttps://github.com/rails/rails/commit/a58cafeb3a86be46849de57481b6644094fb8165"},"comment":{"url":"https://api.github.com/repos/composite-primary-keys/composite_primary_keys/issues/comments/147214130","html_url":"https://github.com/composite-primary-keys/composite_primary_keys/pull/326#issuecomment-147214130","issue_url":"https://api.github.com/repos/composite-primary-keys/composite_primary_keys/issues/326","id":147214130,"user":{"login":"brgaulin","id":4007825,"avatar_url":"https://avatars.githubusercontent.com/u/4007825?v=3","gravatar_id":"","url":"https://api.github.com/users/brgaulin","html_url":"https://github.com/brgaulin","followers_url":"https://api.github.com/users/brgaulin/followers","following_url":"https://api.github.com/users/brgaulin/following{/other_user}","gists_url":"https://api.github.com/users/brgaulin/gists{/gist_id}","starred_url":"https://api.github.com/users/brgaulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brgaulin/subscriptions","organizations_url":"https://api.github.com/users/brgaulin/orgs","repos_url":"https://api.github.com/users/brgaulin/repos","events_url":"https://api.github.com/users/brgaulin/events{/privacy}","received_events_url":"https://api.github.com/users/brgaulin/received_events","type":"User","site_admin":false},"created_at":"2015-10-11T16:08:19Z","updated_at":"2015-10-11T16:08:19Z","body":"Not sure who watches these. But I would love some feedback on this PR. Mainly around if you think I broke something, or if this is even something we want to do"}}