{"action":"created","comment":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments/31124647","id":31124647,"diff_hunk":"@@ -1378,8 +1378,7 @@ def test_validate_exists_not_abs(self, os_path):\n         os_path.expanduser.side_effect = lambda x: x\n         os_path.isfile.return_value = True\n         os_path.isabs.return_value = False\n-        with pytest.raises(configexc.ValidationError):\n-            self.t.validate('foobar')\n+        self.t.validate('foobar')","path":"tests/config/test_configtypes.py","position":6,"original_position":6,"commit_id":"4e61a6123e3bf074c122bba2de9311d14d2290b9","original_commit_id":"4e61a6123e3bf074c122bba2de9311d14d2290b9","user":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"body":"Changing this test makes sense, as relative paths work now. Could you please also rename the test to `..._rel` instead `..._not_abs` (and the comment to say `relative` instead of `not absolute`) as this is the \"normal case\" now?\r\n\r\nAlso, I think below you could add `os_path.isfile.assert_called_once_with(...)` and the same for `os_path.isabs` to make sure the paths get expanded correctly with `standarddir.config()`.","created_at":"2015-05-27T11:43:21Z","updated_at":"2015-05-27T11:43:21Z","html_url":"https://github.com/The-Compiler/qutebrowser/pull/686#discussion_r31124647","pull_request_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/686","_links":{"self":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments/31124647"},"html":{"href":"https://github.com/The-Compiler/qutebrowser/pull/686#discussion_r31124647"},"pull_request":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/686"}}},"pull_request":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/686","id":36288410,"html_url":"https://github.com/The-Compiler/qutebrowser/pull/686","diff_url":"https://github.com/The-Compiler/qutebrowser/pull/686.diff","patch_url":"https://github.com/The-Compiler/qutebrowser/pull/686.patch","issue_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/686","number":686,"state":"open","locked":false,"title":"Relative paths (issue #622)","user":{"login":"lamarpavel","id":4991168,"avatar_url":"https://avatars.githubusercontent.com/u/4991168?v=3","gravatar_id":"","url":"https://api.github.com/users/lamarpavel","html_url":"https://github.com/lamarpavel","followers_url":"https://api.github.com/users/lamarpavel/followers","following_url":"https://api.github.com/users/lamarpavel/following{/other_user}","gists_url":"https://api.github.com/users/lamarpavel/gists{/gist_id}","starred_url":"https://api.github.com/users/lamarpavel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamarpavel/subscriptions","organizations_url":"https://api.github.com/users/lamarpavel/orgs","repos_url":"https://api.github.com/users/lamarpavel/repos","events_url":"https://api.github.com/users/lamarpavel/events{/privacy}","received_events_url":"https://api.github.com/users/lamarpavel/received_events","type":"User","site_admin":false},"body":"As discussed in [issue622](https://github.com/The-Compiler/qutebrowser/issues/622) this PR adds the option to specify paths to (some) config files relative to the config-dir of qutebrowser.\r\n\r\nOne test in tests/config/test_configtypes.py needed to be modified.","created_at":"2015-05-27T10:15:12Z","updated_at":"2015-05-27T11:43:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09d9b3c6f3f7b3f66e86f3b36d57e4f6e155da09","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/686/commits","review_comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/686/comments","review_comment_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/686/comments","statuses_url":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/4e61a6123e3bf074c122bba2de9311d14d2290b9","head":{"label":"lamarpavel:relapaths","ref":"relapaths","sha":"4e61a6123e3bf074c122bba2de9311d14d2290b9","user":{"login":"lamarpavel","id":4991168,"avatar_url":"https://avatars.githubusercontent.com/u/4991168?v=3","gravatar_id":"","url":"https://api.github.com/users/lamarpavel","html_url":"https://github.com/lamarpavel","followers_url":"https://api.github.com/users/lamarpavel/followers","following_url":"https://api.github.com/users/lamarpavel/following{/other_user}","gists_url":"https://api.github.com/users/lamarpavel/gists{/gist_id}","starred_url":"https://api.github.com/users/lamarpavel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamarpavel/subscriptions","organizations_url":"https://api.github.com/users/lamarpavel/orgs","repos_url":"https://api.github.com/users/lamarpavel/repos","events_url":"https://api.github.com/users/lamarpavel/events{/privacy}","received_events_url":"https://api.github.com/users/lamarpavel/received_events","type":"User","site_admin":false},"repo":{"id":36071097,"name":"qutebrowser","full_name":"lamarpavel/qutebrowser","owner":{"login":"lamarpavel","id":4991168,"avatar_url":"https://avatars.githubusercontent.com/u/4991168?v=3","gravatar_id":"","url":"https://api.github.com/users/lamarpavel","html_url":"https://github.com/lamarpavel","followers_url":"https://api.github.com/users/lamarpavel/followers","following_url":"https://api.github.com/users/lamarpavel/following{/other_user}","gists_url":"https://api.github.com/users/lamarpavel/gists{/gist_id}","starred_url":"https://api.github.com/users/lamarpavel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamarpavel/subscriptions","organizations_url":"https://api.github.com/users/lamarpavel/orgs","repos_url":"https://api.github.com/users/lamarpavel/repos","events_url":"https://api.github.com/users/lamarpavel/events{/privacy}","received_events_url":"https://api.github.com/users/lamarpavel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lamarpavel/qutebrowser","description":"A keyboard-driven, vim-like browser based on PyQt5 and QtWebKit.","fork":true,"url":"https://api.github.com/repos/lamarpavel/qutebrowser","forks_url":"https://api.github.com/repos/lamarpavel/qutebrowser/forks","keys_url":"https://api.github.com/repos/lamarpavel/qutebrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lamarpavel/qutebrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lamarpavel/qutebrowser/teams","hooks_url":"https://api.github.com/repos/lamarpavel/qutebrowser/hooks","issue_events_url":"https://api.github.com/repos/lamarpavel/qutebrowser/issues/events{/number}","events_url":"https://api.github.com/repos/lamarpavel/qutebrowser/events","assignees_url":"https://api.github.com/repos/lamarpavel/qutebrowser/assignees{/user}","branches_url":"https://api.github.com/repos/lamarpavel/qutebrowser/branches{/branch}","tags_url":"https://api.github.com/repos/lamarpavel/qutebrowser/tags","blobs_url":"https://api.github.com/repos/lamarpavel/qutebrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lamarpavel/qutebrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lamarpavel/qutebrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/lamarpavel/qutebrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lamarpavel/qutebrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/lamarpavel/qutebrowser/languages","stargazers_url":"https://api.github.com/repos/lamarpavel/qutebrowser/stargazers","contributors_url":"https://api.github.com/repos/lamarpavel/qutebrowser/contributors","subscribers_url":"https://api.github.com/repos/lamarpavel/qutebrowser/subscribers","subscription_url":"https://api.github.com/repos/lamarpavel/qutebrowser/subscription","commits_url":"https://api.github.com/repos/lamarpavel/qutebrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/lamarpavel/qutebrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/lamarpavel/qutebrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/lamarpavel/qutebrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/lamarpavel/qutebrowser/contents/{+path}","compare_url":"https://api.github.com/repos/lamarpavel/qutebrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lamarpavel/qutebrowser/merges","archive_url":"https://api.github.com/repos/lamarpavel/qutebrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lamarpavel/qutebrowser/downloads","issues_url":"https://api.github.com/repos/lamarpavel/qutebrowser/issues{/number}","pulls_url":"https://api.github.com/repos/lamarpavel/qutebrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/lamarpavel/qutebrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/lamarpavel/qutebrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lamarpavel/qutebrowser/labels{/name}","releases_url":"https://api.github.com/repos/lamarpavel/qutebrowser/releases{/id}","created_at":"2015-05-22T12:26:57Z","updated_at":"2015-05-22T12:26:58Z","pushed_at":"2015-05-27T10:07:23Z","git_url":"git://github.com/lamarpavel/qutebrowser.git","ssh_url":"git@github.com:lamarpavel/qutebrowser.git","clone_url":"https://github.com/lamarpavel/qutebrowser.git","svn_url":"https://github.com/lamarpavel/qutebrowser","homepage":null,"size":6543,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"The-Compiler:master","ref":"master","sha":"534dbfc4c2634d2f43a379a8f5abb8fb9af112a0","user":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"repo":{"id":21244505,"name":"qutebrowser","full_name":"The-Compiler/qutebrowser","owner":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/The-Compiler/qutebrowser","description":"A keyboard-driven, vim-like browser based on PyQt5 and QtWebKit.","fork":false,"url":"https://api.github.com/repos/The-Compiler/qutebrowser","forks_url":"https://api.github.com/repos/The-Compiler/qutebrowser/forks","keys_url":"https://api.github.com/repos/The-Compiler/qutebrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/The-Compiler/qutebrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/The-Compiler/qutebrowser/teams","hooks_url":"https://api.github.com/repos/The-Compiler/qutebrowser/hooks","issue_events_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/events{/number}","events_url":"https://api.github.com/repos/The-Compiler/qutebrowser/events","assignees_url":"https://api.github.com/repos/The-Compiler/qutebrowser/assignees{/user}","branches_url":"https://api.github.com/repos/The-Compiler/qutebrowser/branches{/branch}","tags_url":"https://api.github.com/repos/The-Compiler/qutebrowser/tags","blobs_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/The-Compiler/qutebrowser/languages","stargazers_url":"https://api.github.com/repos/The-Compiler/qutebrowser/stargazers","contributors_url":"https://api.github.com/repos/The-Compiler/qutebrowser/contributors","subscribers_url":"https://api.github.com/repos/The-Compiler/qutebrowser/subscribers","subscription_url":"https://api.github.com/repos/The-Compiler/qutebrowser/subscription","commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/The-Compiler/qutebrowser/contents/{+path}","compare_url":"https://api.github.com/repos/The-Compiler/qutebrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/The-Compiler/qutebrowser/merges","archive_url":"https://api.github.com/repos/The-Compiler/qutebrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/The-Compiler/qutebrowser/downloads","issues_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues{/number}","pulls_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/The-Compiler/qutebrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/The-Compiler/qutebrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/The-Compiler/qutebrowser/labels{/name}","releases_url":"https://api.github.com/repos/The-Compiler/qutebrowser/releases{/id}","created_at":"2014-06-26T14:59:34Z","updated_at":"2015-05-26T22:11:03Z","pushed_at":"2015-05-27T10:15:12Z","git_url":"git://github.com/The-Compiler/qutebrowser.git","ssh_url":"git@github.com:The-Compiler/qutebrowser.git","clone_url":"https://github.com/The-Compiler/qutebrowser.git","svn_url":"https://github.com/The-Compiler/qutebrowser","homepage":null,"size":12123,"stargazers_count":568,"watchers_count":568,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":64,"mirror_url":null,"open_issues_count":234,"forks":64,"open_issues":234,"watchers":568,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/686"},"html":{"href":"https://github.com/The-Compiler/qutebrowser/pull/686"},"issue":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/686"},"comments":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/686/comments"},"review_comments":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/686/comments"},"review_comment":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/686/commits"},"statuses":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/4e61a6123e3bf074c122bba2de9311d14d2290b9"}}}}