{"action":"created","comment":{"url":"https://api.github.com/repos/pydata/pandas/pulls/comments/35165874","id":35165874,"diff_hunk":"@@ -894,13 +896,21 @@ def get_result(self):\n             if self.axis == 0:\n                 new_data = com._concat_compat([x.values for x in self.objs])\n                 name = com._consensus_name_attr(self.objs)\n-                return Series(new_data, index=self.new_axes[0], name=name).__finalize__(self, method='concat')\n+                if self._is_sp_series:","path":"pandas/tools/merge.py","position":23,"original_position":23,"commit_id":"1ed31edc3f561eb8f93edba88cbb977afe6da782","original_commit_id":"1ed31edc3f561eb8f93edba88cbb977afe6da782","user":{"login":"maximilianr","id":5635139,"avatar_url":"https://avatars.githubusercontent.com/u/5635139?v=3","gravatar_id":"","url":"https://api.github.com/users/maximilianr","html_url":"https://github.com/maximilianr","followers_url":"https://api.github.com/users/maximilianr/followers","following_url":"https://api.github.com/users/maximilianr/following{/other_user}","gists_url":"https://api.github.com/users/maximilianr/gists{/gist_id}","starred_url":"https://api.github.com/users/maximilianr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximilianr/subscriptions","organizations_url":"https://api.github.com/users/maximilianr/orgs","repos_url":"https://api.github.com/users/maximilianr/repos","events_url":"https://api.github.com/users/maximilianr/events{/privacy}","received_events_url":"https://api.github.com/users/maximilianr/received_events","type":"User","site_admin":false},"body":"I was a little fast on the trigger. I didn't realize that you need `._is_frame` etc elsewhere.\r\n\r\nFor this code, this is what I was originally thinking. Tell me if I'm still off, though\r\n\r\nIn `__init__`\r\n```python\r\nself.obj_constructor=sample._constructor\r\n```\r\nand then in `get_result`\r\n```python\r\nself.obj_constructor(...\r\n```","created_at":"2015-07-21T23:15:11Z","updated_at":"2015-07-21T23:15:11Z","html_url":"https://github.com/pydata/pandas/pull/10626#discussion_r35165874","pull_request_url":"https://api.github.com/repos/pydata/pandas/pulls/10626","_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/35165874"},"html":{"href":"https://github.com/pydata/pandas/pull/10626#discussion_r35165874"},"pull_request":{"href":"https://api.github.com/repos/pydata/pandas/pulls/10626"}}},"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/10626","id":40304176,"html_url":"https://github.com/pydata/pandas/pull/10626","diff_url":"https://github.com/pydata/pandas/pull/10626.diff","patch_url":"https://github.com/pydata/pandas/pull/10626.patch","issue_url":"https://api.github.com/repos/pydata/pandas/issues/10626","number":10626,"state":"open","locked":false,"title":"BUG: GH10536 in concat for SparseSeries","user":{"login":"kawochen","id":10709573,"avatar_url":"https://avatars.githubusercontent.com/u/10709573?v=3","gravatar_id":"","url":"https://api.github.com/users/kawochen","html_url":"https://github.com/kawochen","followers_url":"https://api.github.com/users/kawochen/followers","following_url":"https://api.github.com/users/kawochen/following{/other_user}","gists_url":"https://api.github.com/users/kawochen/gists{/gist_id}","starred_url":"https://api.github.com/users/kawochen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kawochen/subscriptions","organizations_url":"https://api.github.com/users/kawochen/orgs","repos_url":"https://api.github.com/users/kawochen/repos","events_url":"https://api.github.com/users/kawochen/events{/privacy}","received_events_url":"https://api.github.com/users/kawochen/received_events","type":"User","site_admin":false},"body":"To address #10536, but it's clearly not enough. What should be done for `SparseSeries` of different `kind`s and different `fill` values?\r\n","created_at":"2015-07-19T06:54:19Z","updated_at":"2015-07-21T23:15:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25b482a035476fba1b1cf19eea75a00f58aff78e","assignee":null,"milestone":{"url":"https://api.github.com/repos/pydata/pandas/milestones/34","html_url":"https://github.com/pydata/pandas/milestones/0.17.0","labels_url":"https://api.github.com/repos/pydata/pandas/milestones/34/labels","id":1033710,"number":34,"title":"0.17.0","description":"","creator":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"open_issues":182,"closed_issues":150,"state":"open","created_at":"2015-03-23T10:47:38Z","updated_at":"2015-07-21T12:59:38Z","due_on":"2015-07-31T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pydata/pandas/pulls/10626/commits","review_comments_url":"https://api.github.com/repos/pydata/pandas/pulls/10626/comments","review_comment_url":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/10626/comments","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/1ed31edc3f561eb8f93edba88cbb977afe6da782","head":{"label":"kawochen:BUG-FIX-10536","ref":"BUG-FIX-10536","sha":"1ed31edc3f561eb8f93edba88cbb977afe6da782","user":{"login":"kawochen","id":10709573,"avatar_url":"https://avatars.githubusercontent.com/u/10709573?v=3","gravatar_id":"","url":"https://api.github.com/users/kawochen","html_url":"https://github.com/kawochen","followers_url":"https://api.github.com/users/kawochen/followers","following_url":"https://api.github.com/users/kawochen/following{/other_user}","gists_url":"https://api.github.com/users/kawochen/gists{/gist_id}","starred_url":"https://api.github.com/users/kawochen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kawochen/subscriptions","organizations_url":"https://api.github.com/users/kawochen/orgs","repos_url":"https://api.github.com/users/kawochen/repos","events_url":"https://api.github.com/users/kawochen/events{/privacy}","received_events_url":"https://api.github.com/users/kawochen/received_events","type":"User","site_admin":false},"repo":{"id":36695544,"name":"pandas","full_name":"kawochen/pandas","owner":{"login":"kawochen","id":10709573,"avatar_url":"https://avatars.githubusercontent.com/u/10709573?v=3","gravatar_id":"","url":"https://api.github.com/users/kawochen","html_url":"https://github.com/kawochen","followers_url":"https://api.github.com/users/kawochen/followers","following_url":"https://api.github.com/users/kawochen/following{/other_user}","gists_url":"https://api.github.com/users/kawochen/gists{/gist_id}","starred_url":"https://api.github.com/users/kawochen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kawochen/subscriptions","organizations_url":"https://api.github.com/users/kawochen/orgs","repos_url":"https://api.github.com/users/kawochen/repos","events_url":"https://api.github.com/users/kawochen/events{/privacy}","received_events_url":"https://api.github.com/users/kawochen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kawochen/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/kawochen/pandas","forks_url":"https://api.github.com/repos/kawochen/pandas/forks","keys_url":"https://api.github.com/repos/kawochen/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kawochen/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kawochen/pandas/teams","hooks_url":"https://api.github.com/repos/kawochen/pandas/hooks","issue_events_url":"https://api.github.com/repos/kawochen/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/kawochen/pandas/events","assignees_url":"https://api.github.com/repos/kawochen/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/kawochen/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/kawochen/pandas/tags","blobs_url":"https://api.github.com/repos/kawochen/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kawochen/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kawochen/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/kawochen/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kawochen/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/kawochen/pandas/languages","stargazers_url":"https://api.github.com/repos/kawochen/pandas/stargazers","contributors_url":"https://api.github.com/repos/kawochen/pandas/contributors","subscribers_url":"https://api.github.com/repos/kawochen/pandas/subscribers","subscription_url":"https://api.github.com/repos/kawochen/pandas/subscription","commits_url":"https://api.github.com/repos/kawochen/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/kawochen/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/kawochen/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/kawochen/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/kawochen/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/kawochen/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kawochen/pandas/merges","archive_url":"https://api.github.com/repos/kawochen/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kawochen/pandas/downloads","issues_url":"https://api.github.com/repos/kawochen/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/kawochen/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/kawochen/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/kawochen/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kawochen/pandas/labels{/name}","releases_url":"https://api.github.com/repos/kawochen/pandas/releases{/id}","created_at":"2015-06-01T23:39:36Z","updated_at":"2015-06-08T14:16:34Z","pushed_at":"2015-07-21T06:15:20Z","git_url":"git://github.com/kawochen/pandas.git","ssh_url":"git@github.com:kawochen/pandas.git","clone_url":"https://github.com/kawochen/pandas.git","svn_url":"https://github.com/kawochen/pandas","homepage":"http://pandas.pydata.org","size":55482,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"5a9a9da80c1a8b3e146f579f581261257b604f66","user":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pydata/pandas","owner":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pydata/pandas","forks_url":"https://api.github.com/repos/pydata/pandas/forks","keys_url":"https://api.github.com/repos/pydata/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/pandas/teams","hooks_url":"https://api.github.com/repos/pydata/pandas/hooks","issue_events_url":"https://api.github.com/repos/pydata/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/pandas/events","assignees_url":"https://api.github.com/repos/pydata/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/pandas/tags","blobs_url":"https://api.github.com/repos/pydata/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/pandas/languages","stargazers_url":"https://api.github.com/repos/pydata/pandas/stargazers","contributors_url":"https://api.github.com/repos/pydata/pandas/contributors","subscribers_url":"https://api.github.com/repos/pydata/pandas/subscribers","subscription_url":"https://api.github.com/repos/pydata/pandas/subscription","commits_url":"https://api.github.com/repos/pydata/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydata/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/pandas/merges","archive_url":"https://api.github.com/repos/pydata/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/pandas/downloads","issues_url":"https://api.github.com/repos/pydata/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pydata/pandas/releases{/id}","created_at":"2010-08-24T01:37:33Z","updated_at":"2015-07-21T19:47:41Z","pushed_at":"2015-07-21T22:01:54Z","git_url":"git://github.com/pydata/pandas.git","ssh_url":"git@github.com:pydata/pandas.git","clone_url":"https://github.com/pydata/pandas.git","svn_url":"https://github.com/pydata/pandas","homepage":"http://pandas.pydata.org","size":147838,"stargazers_count":4680,"watchers_count":4680,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1770,"mirror_url":null,"open_issues_count":1502,"forks":1770,"open_issues":1502,"watchers":4680,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/10626"},"html":{"href":"https://github.com/pydata/pandas/pull/10626"},"issue":{"href":"https://api.github.com/repos/pydata/pandas/issues/10626"},"comments":{"href":"https://api.github.com/repos/pydata/pandas/issues/10626/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/pandas/pulls/10626/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydata/pandas/pulls/10626/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/pandas/statuses/1ed31edc3f561eb8f93edba88cbb977afe6da782"}}}}