{"action":"created","issue":{"url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/224","labels_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/224/labels{/name}","comments_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/224/comments","events_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/224/events","html_url":"https://github.com/jclouds/jclouds-labs/pull/224","id":121433571,"number":224,"title":"JCLOUDS-1047: Fix ProfitBricks compute service live tests","user":{"login":"devcsrj","id":3963900,"avatar_url":"https://avatars.githubusercontent.com/u/3963900?v=3","gravatar_id":"","url":"https://api.github.com/users/devcsrj","html_url":"https://github.com/devcsrj","followers_url":"https://api.github.com/users/devcsrj/followers","following_url":"https://api.github.com/users/devcsrj/following{/other_user}","gists_url":"https://api.github.com/users/devcsrj/gists{/gist_id}","starred_url":"https://api.github.com/users/devcsrj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devcsrj/subscriptions","organizations_url":"https://api.github.com/users/devcsrj/orgs","repos_url":"https://api.github.com/users/devcsrj/repos","events_url":"https://api.github.com/users/devcsrj/events{/privacy}","received_events_url":"https://api.github.com/users/devcsrj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-12-10T09:02:41Z","updated_at":"2015-12-17T09:25:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/224","html_url":"https://github.com/jclouds/jclouds-labs/pull/224","diff_url":"https://github.com/jclouds/jclouds-labs/pull/224.diff","patch_url":"https://github.com/jclouds/jclouds-labs/pull/224.patch"},"body":"Changes:\r\n1. Implemented `ProfitBricksTemplateBuilderImpl`, so that `Location`s used by built template will always be of scope `ZONE`. Looks for the [first found](https://github.com/jclouds/jclouds-labs/pull/224/files#diff-1500f3a9004863afdd8a7869407b390aR68) `ZONE` if `REGION` is provided. Also fixes [errors](https://gist.github.com/devcsrj/9675b0c3bb04a133fb50/86898b12fc9b494a6de31c08028fa82daa210a8e#file-jclouds-profitbricks-live-tests-log-L498) when only providing `imageId` in template.\r\n2. Deleted unused interfaces left from previous PR. (`org.jclouds.profitbricks.domain.internal.*`)\r\n3. [Added](https://github.com/jclouds/jclouds-labs/pull/224/files#diff-1a27cebd5920714ae4c207026edd5255R129) *provisionable type* as metadata, because API complains if password has [invalid characters](https://github.com/jclouds/jclouds-labs/blob/master/profitbricks/src/main/java/org/jclouds/profitbricks/util/Preconditions.java#L96).\r\n4. Incorrect [content-length](https://github.com/jclouds/jclouds-labs/pull/224/files#diff-e9ba6240d723094ed0863af75d9416a5R48).\r\n\r\nRan with:\r\n```\r\nmvn clean install -Plive -Dtest.profitbricks.identity=<identity> -Dtest.profitbricks.credential='<credential>' -Dtest.profitbricks.template=\"imageId=<snapshotId>,loginUser=<user>:<password>\"\r\n```\r\n[Live tests](https://gist.github.com/devcsrj/9675b0c3bb04a133fb50/5d1d3f6d5bc291c291679e56231d1af645041983) \r\n`Tests run: 92, Failures: 2, Errors: 0, Skipped: 0`\r\n\r\n(edit: Added description)"},"comment":{"url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/comments/165392488","html_url":"https://github.com/jclouds/jclouds-labs/pull/224#issuecomment-165392488","issue_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/224","id":165392488,"user":{"login":"nacx","id":446705,"avatar_url":"https://avatars.githubusercontent.com/u/446705?v=3","gravatar_id":"","url":"https://api.github.com/users/nacx","html_url":"https://github.com/nacx","followers_url":"https://api.github.com/users/nacx/followers","following_url":"https://api.github.com/users/nacx/following{/other_user}","gists_url":"https://api.github.com/users/nacx/gists{/gist_id}","starred_url":"https://api.github.com/users/nacx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nacx/subscriptions","organizations_url":"https://api.github.com/users/nacx/orgs","repos_url":"https://api.github.com/users/nacx/repos","events_url":"https://api.github.com/users/nacx/events{/privacy}","received_events_url":"https://api.github.com/users/nacx/received_events","type":"User","site_admin":false},"created_at":"2015-12-17T09:25:09Z","updated_at":"2015-12-17T09:25:09Z","body":"Unfortunately no. I'll try to debug the tests and see what I find. I'd like to keep this PR open to investigate this, in case you find what is going on, but I don't want to block it forever. Since the authentication works (otherwise other tests would be failing), I think we can safely merge this PR, say, early next week, as it brings a lot of improvements.\r\n\r\nCould you try creating a minimal `main` that runs a script and cancels it, to help you verify if this is actually broken or it is just something in the test workflow that is causing some kind of conflict?"}}