{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/presto/pulls/comments/23741691","id":23741691,"diff_hunk":"@@ -94,6 +99,15 @@ public PlanNode visitPlan(PlanNode node, RewriteContext<LimitContext> context)\n         @Override\n         public PlanNode visitLimit(LimitNode node, RewriteContext<LimitContext> context)\n         {\n+            // replace nodes with empty ValuesNode in case of limit 0\n+            if (node.getCount() == 0) {\n+                List<Expression> values = node.getOutputSymbols().stream().map(s -> new NullLiteral()).collect(toList());\n+                ValuesNode valuesNode = new ValuesNode(idAllocator.getNextId(),\n+                                                        node.getOutputSymbols(),\n+                                                        ImmutableList.of(values));\n+                return new LimitNode(idAllocator.getNextId(), valuesNode, node.getCount());","path":"presto-main/src/main/java/com/facebook/presto/sql/planner/optimizations/LimitPushDown.java","position":30,"original_position":30,"commit_id":"881554998021cfb3bd253c0160bad14d8bb78192","original_commit_id":"881554998021cfb3bd253c0160bad14d8bb78192","user":{"login":"zhenxiao","id":1274155,"avatar_url":"https://avatars.githubusercontent.com/u/1274155?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenxiao","html_url":"https://github.com/zhenxiao","followers_url":"https://api.github.com/users/zhenxiao/followers","following_url":"https://api.github.com/users/zhenxiao/following{/other_user}","gists_url":"https://api.github.com/users/zhenxiao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenxiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenxiao/subscriptions","organizations_url":"https://api.github.com/users/zhenxiao/orgs","repos_url":"https://api.github.com/users/zhenxiao/repos","events_url":"https://api.github.com/users/zhenxiao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenxiao/received_events","type":"User","site_admin":false},"body":"ValuesNode is checking outputSymbols length matches row values length, empty row size is zero\r\nIn ValuesNode.java:\r\nline 45 checkArgument(row.size() == outputSymbols.size(), \"Expected row to have %s values, but row has %s values\", outputSymbols.size(), row.size());","created_at":"2015-01-29T01:55:09Z","updated_at":"2015-01-29T01:55:09Z","html_url":"https://github.com/facebook/presto/pull/2290#discussion_r23741691","pull_request_url":"https://api.github.com/repos/facebook/presto/pulls/2290","_links":{"self":{"href":"https://api.github.com/repos/facebook/presto/pulls/comments/23741691"},"html":{"href":"https://github.com/facebook/presto/pull/2290#discussion_r23741691"},"pull_request":{"href":"https://api.github.com/repos/facebook/presto/pulls/2290"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/presto/pulls/2290","id":28246817,"html_url":"https://github.com/facebook/presto/pull/2290","diff_url":"https://github.com/facebook/presto/pull/2290.diff","patch_url":"https://github.com/facebook/presto/pull/2290.patch","issue_url":"https://api.github.com/repos/facebook/presto/issues/2290","number":2290,"state":"open","locked":false,"title":"Add optimizer for LIMIT 0","user":{"login":"zhenxiao","id":1274155,"avatar_url":"https://avatars.githubusercontent.com/u/1274155?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenxiao","html_url":"https://github.com/zhenxiao","followers_url":"https://api.github.com/users/zhenxiao/followers","following_url":"https://api.github.com/users/zhenxiao/following{/other_user}","gists_url":"https://api.github.com/users/zhenxiao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenxiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenxiao/subscriptions","organizations_url":"https://api.github.com/users/zhenxiao/orgs","repos_url":"https://api.github.com/users/zhenxiao/repos","events_url":"https://api.github.com/users/zhenxiao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenxiao/received_events","type":"User","site_admin":false},"body":"Fix https://github.com/facebook/presto/issues/2283","created_at":"2015-01-29T01:36:38Z","updated_at":"2015-01-29T01:55:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19bcff6479140de7e2b41114296cc9ba64335d29","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/presto/pulls/2290/commits","review_comments_url":"https://api.github.com/repos/facebook/presto/pulls/2290/comments","review_comment_url":"https://api.github.com/repos/facebook/presto/pulls/comments/{number}","comments_url":"https://api.github.com/repos/facebook/presto/issues/2290/comments","statuses_url":"https://api.github.com/repos/facebook/presto/statuses/881554998021cfb3bd253c0160bad14d8bb78192","head":{"label":"zhenxiao:limit0","ref":"limit0","sha":"881554998021cfb3bd253c0160bad14d8bb78192","user":{"login":"zhenxiao","id":1274155,"avatar_url":"https://avatars.githubusercontent.com/u/1274155?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenxiao","html_url":"https://github.com/zhenxiao","followers_url":"https://api.github.com/users/zhenxiao/followers","following_url":"https://api.github.com/users/zhenxiao/following{/other_user}","gists_url":"https://api.github.com/users/zhenxiao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenxiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenxiao/subscriptions","organizations_url":"https://api.github.com/users/zhenxiao/orgs","repos_url":"https://api.github.com/users/zhenxiao/repos","events_url":"https://api.github.com/users/zhenxiao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenxiao/received_events","type":"User","site_admin":false},"repo":{"id":17963913,"name":"presto","full_name":"zhenxiao/presto","owner":{"login":"zhenxiao","id":1274155,"avatar_url":"https://avatars.githubusercontent.com/u/1274155?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenxiao","html_url":"https://github.com/zhenxiao","followers_url":"https://api.github.com/users/zhenxiao/followers","following_url":"https://api.github.com/users/zhenxiao/following{/other_user}","gists_url":"https://api.github.com/users/zhenxiao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenxiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenxiao/subscriptions","organizations_url":"https://api.github.com/users/zhenxiao/orgs","repos_url":"https://api.github.com/users/zhenxiao/repos","events_url":"https://api.github.com/users/zhenxiao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenxiao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhenxiao/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/zhenxiao/presto","forks_url":"https://api.github.com/repos/zhenxiao/presto/forks","keys_url":"https://api.github.com/repos/zhenxiao/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhenxiao/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhenxiao/presto/teams","hooks_url":"https://api.github.com/repos/zhenxiao/presto/hooks","issue_events_url":"https://api.github.com/repos/zhenxiao/presto/issues/events{/number}","events_url":"https://api.github.com/repos/zhenxiao/presto/events","assignees_url":"https://api.github.com/repos/zhenxiao/presto/assignees{/user}","branches_url":"https://api.github.com/repos/zhenxiao/presto/branches{/branch}","tags_url":"https://api.github.com/repos/zhenxiao/presto/tags","blobs_url":"https://api.github.com/repos/zhenxiao/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhenxiao/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhenxiao/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhenxiao/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhenxiao/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/zhenxiao/presto/languages","stargazers_url":"https://api.github.com/repos/zhenxiao/presto/stargazers","contributors_url":"https://api.github.com/repos/zhenxiao/presto/contributors","subscribers_url":"https://api.github.com/repos/zhenxiao/presto/subscribers","subscription_url":"https://api.github.com/repos/zhenxiao/presto/subscription","commits_url":"https://api.github.com/repos/zhenxiao/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhenxiao/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhenxiao/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhenxiao/presto/issues/comments/{number}","contents_url":"https://api.github.com/repos/zhenxiao/presto/contents/{+path}","compare_url":"https://api.github.com/repos/zhenxiao/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhenxiao/presto/merges","archive_url":"https://api.github.com/repos/zhenxiao/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhenxiao/presto/downloads","issues_url":"https://api.github.com/repos/zhenxiao/presto/issues{/number}","pulls_url":"https://api.github.com/repos/zhenxiao/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/zhenxiao/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/zhenxiao/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhenxiao/presto/labels{/name}","releases_url":"https://api.github.com/repos/zhenxiao/presto/releases{/id}","created_at":"2014-03-21T01:03:42Z","updated_at":"2014-06-20T00:45:47Z","pushed_at":"2015-01-29T01:35:58Z","git_url":"git://github.com/zhenxiao/presto.git","ssh_url":"git@github.com:zhenxiao/presto.git","clone_url":"https://github.com/zhenxiao/presto.git","svn_url":"https://github.com/zhenxiao/presto","homepage":"http://prestodb.io/","size":34396,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"ddc382726b8ac239300b8ad45bce4134a3b09c14","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"facebook/presto","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/presto","description":"Distributed SQL query engine for running interactive analytic queries against big data sources.","fork":false,"url":"https://api.github.com/repos/facebook/presto","forks_url":"https://api.github.com/repos/facebook/presto/forks","keys_url":"https://api.github.com/repos/facebook/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/presto/teams","hooks_url":"https://api.github.com/repos/facebook/presto/hooks","issue_events_url":"https://api.github.com/repos/facebook/presto/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/presto/events","assignees_url":"https://api.github.com/repos/facebook/presto/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/presto/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/presto/tags","blobs_url":"https://api.github.com/repos/facebook/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/presto/languages","stargazers_url":"https://api.github.com/repos/facebook/presto/stargazers","contributors_url":"https://api.github.com/repos/facebook/presto/contributors","subscribers_url":"https://api.github.com/repos/facebook/presto/subscribers","subscription_url":"https://api.github.com/repos/facebook/presto/subscription","commits_url":"https://api.github.com/repos/facebook/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/presto/issues/comments/{number}","contents_url":"https://api.github.com/repos/facebook/presto/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/presto/merges","archive_url":"https://api.github.com/repos/facebook/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/presto/downloads","issues_url":"https://api.github.com/repos/facebook/presto/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/presto/labels{/name}","releases_url":"https://api.github.com/repos/facebook/presto/releases{/id}","created_at":"2012-08-09T01:03:37Z","updated_at":"2015-01-29T00:08:38Z","pushed_at":"2015-01-29T00:08:38Z","git_url":"git://github.com/facebook/presto.git","ssh_url":"git@github.com:facebook/presto.git","clone_url":"https://github.com/facebook/presto.git","svn_url":"https://github.com/facebook/presto","homepage":"http://prestodb.io/","size":67550,"stargazers_count":2935,"watchers_count":2935,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":641,"mirror_url":null,"open_issues_count":223,"forks":641,"open_issues":223,"watchers":2935,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/presto/pulls/2290"},"html":{"href":"https://github.com/facebook/presto/pull/2290"},"issue":{"href":"https://api.github.com/repos/facebook/presto/issues/2290"},"comments":{"href":"https://api.github.com/repos/facebook/presto/issues/2290/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/presto/pulls/2290/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/presto/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/facebook/presto/pulls/2290/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/presto/statuses/881554998021cfb3bd253c0160bad14d8bb78192"}}}}