{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/2434","labels_url":"https://api.github.com/repos/nodejs/node/issues/2434/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/2434/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/2434/events","html_url":"https://github.com/nodejs/node/issues/2434","id":101837142,"number":2434,"title":"Procedure for rolling out node-accept-pull-request","user":{"login":"orangemocha","id":1625870,"avatar_url":"https://avatars.githubusercontent.com/u/1625870?v=3","gravatar_id":"","url":"https://api.github.com/users/orangemocha","html_url":"https://github.com/orangemocha","followers_url":"https://api.github.com/users/orangemocha/followers","following_url":"https://api.github.com/users/orangemocha/following{/other_user}","gists_url":"https://api.github.com/users/orangemocha/gists{/gist_id}","starred_url":"https://api.github.com/users/orangemocha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orangemocha/subscriptions","organizations_url":"https://api.github.com/users/orangemocha/orgs","repos_url":"https://api.github.com/users/orangemocha/repos","events_url":"https://api.github.com/users/orangemocha/events{/privacy}","received_events_url":"https://api.github.com/users/orangemocha/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/meta","name":"meta","color":"fef2c0"},{"url":"https://api.github.com/repos/nodejs/node/labels/tsc-agenda","name":"tsc-agenda","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-08-19T08:43:17Z","updated_at":"2015-08-19T10:22:39Z","closed_at":null,"body":"nodejs/node is finally in place and we are almost ready to move v0.x branches from joyent/node to it. However we still using two different workflows for landing pull requests, with [node-accept-pull-request](https://jenkins-iojs.nodesource.com/job/node-accept-pull-request/build?delay=0sec) for v0.x and with a more [manual procedure](https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#landing-pull-requests) for everything else. \r\n\r\nI have been working on getting node-accept-pull-request available for all branches, and it will be ready for broader consumption within the next week or so. Ideally, I'd like to roll it out on a trial basis, letting collaborators try it with some flexibility for using the old procedure. However, because of the way that it is designed, it kind of requires everybody to follow the same procedure. Here's why:\r\n\r\n1. It rebases the PR onto the target branch (adding PR-URL and Reviewed-By to all the commits)\r\n2. It builds and test the changes (like node-test-pull-request)\r\n3. If all non-flaky tests pass, it does a fast-forward merge and pushes the updated branch to GitHub.\r\n\r\nSo if someone were to push manually to the same branch while a run is in progress between steps (1) and (3), the branch update at (3) would fail. This is somewhat desirable, because we want it to test the result of the rebase, and push exactly what it has tested.\r\n\r\nGiven the above, I think the best way for trying it out would be for all collaborators to start adopting it at the same time. Of course, if after some time we are all miserable because of it, we can revisit the process and even go back to the manual procedure. Before the roll-out, I will write a wiki page to document how to use it. There is also a procedure for landing other people's changes, to address a concern raised by @trevnorris.\r\n\r\nI just wanted to give the TSC a heads up and a chance to discuss this plan. Adding to tsc-agenda.\r\n\r\n@nodejs/tsc \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/132530869","html_url":"https://github.com/nodejs/node/issues/2434#issuecomment-132530869","issue_url":"https://api.github.com/repos/nodejs/node/issues/2434","id":132530869,"user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"created_at":"2015-08-19T10:22:39Z","updated_at":"2015-08-19T10:22:39Z","body":"@orangemocha Can you set the repo to nodejs?  It still points to joyent.\r\n\r\nI'm guessing it's using an old toolchain?  Pretty much all the linux bots are failing with:\r\n\r\n> cc1plus: error: unrecognised debug output level ‘line-tables-only’\r\n\r\nThe `-gline-tables-only` in common.gypi is not a recent change, it was added in ff7c68c4da47bf209a7b92d3c3b40da48a6b9630 from October last year."}}