{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/29240","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/29240/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/29240/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/29240/events","html_url":"https://github.com/rust-lang/rust/pull/29240","id":112905405,"number":29240,"title":"Add underline hints to the docs. Exclude obvious things.","user":{"login":"mdinger","id":4156987,"avatar_url":"https://avatars.githubusercontent.com/u/4156987?v=3","gravatar_id":"","url":"https://api.github.com/users/mdinger","html_url":"https://github.com/mdinger","followers_url":"https://api.github.com/users/mdinger/followers","following_url":"https://api.github.com/users/mdinger/following{/other_user}","gists_url":"https://api.github.com/users/mdinger/gists{/gist_id}","starred_url":"https://api.github.com/users/mdinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdinger/subscriptions","organizations_url":"https://api.github.com/users/mdinger/orgs","repos_url":"https://api.github.com/users/mdinger/repos","events_url":"https://api.github.com/users/mdinger/events{/privacy}","received_events_url":"https://api.github.com/users/mdinger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"steveklabnik","id":27786,"avatar_url":"https://avatars.githubusercontent.com/u/27786?v=3","gravatar_id":"","url":"https://api.github.com/users/steveklabnik","html_url":"https://github.com/steveklabnik","followers_url":"https://api.github.com/users/steveklabnik/followers","following_url":"https://api.github.com/users/steveklabnik/following{/other_user}","gists_url":"https://api.github.com/users/steveklabnik/gists{/gist_id}","starred_url":"https://api.github.com/users/steveklabnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveklabnik/subscriptions","organizations_url":"https://api.github.com/users/steveklabnik/orgs","repos_url":"https://api.github.com/users/steveklabnik/repos","events_url":"https://api.github.com/users/steveklabnik/events{/privacy}","received_events_url":"https://api.github.com/users/steveklabnik/received_events","type":"User","site_admin":false},"milestone":null,"comments":12,"created_at":"2015-10-22T22:34:44Z","updated_at":"2015-10-23T22:20:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/29240","html_url":"https://github.com/rust-lang/rust/pull/29240","diff_url":"https://github.com/rust-lang/rust/pull/29240.diff","patch_url":"https://github.com/rust-lang/rust/pull/29240.patch"},"body":"Here's a PR which fixes https://github.com/rust-lang/rust/issues/15307\r\n\r\nI hosted a version ([`std::vec`](http://mdinger.github.io/rust_std_dashed_underline/std/vec/index.html)) but I must have messed something up because they don't work perfectly (but you can still see how the line styling looks fine). I don't think jquery loaded properly but I'm not sure why.\r\n\r\nNote: I don't particularly like this as it is. Many of the links already kinda look like links. It's mainly the primitives which don't look like links because they're black.\r\n\r\nFor example, below you can probably tell the functions and the structs are links but `usize`, who knows without the underlining. The underlining also basically ignores the coloring that already exists and kinda feels inconsistent.\r\n\r\n![small](https://cloud.githubusercontent.com/assets/4156987/10679889/6c76c482-78e9-11e5-9665-f1d542e92656.png)\r\n\r\n\r\n---\r\n\r\nAs an alternative, I'd consider trying something else. If you look at this picture, the first 5 colors are the colors currently used for link highlighting (I think). I'd consider trying something like number 6 for primitives to see if it makes this issue much better as an alternative to this PR.\r\n\r\n![highlight](https://cloud.githubusercontent.com/assets/4156987/10679826/16492906-78e9-11e5-901f-5f0a396cf22b.png)\r\n\r\nNote: If I could figure out how to tell rustdoc to add a `class='primitive'` to each primitive element, this would be easy to test out but I haven't figured that out yet."},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/150705996","html_url":"https://github.com/rust-lang/rust/pull/29240#issuecomment-150705996","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/29240","id":150705996,"user":{"login":"Toby-S","id":3465139,"avatar_url":"https://avatars.githubusercontent.com/u/3465139?v=3","gravatar_id":"","url":"https://api.github.com/users/Toby-S","html_url":"https://github.com/Toby-S","followers_url":"https://api.github.com/users/Toby-S/followers","following_url":"https://api.github.com/users/Toby-S/following{/other_user}","gists_url":"https://api.github.com/users/Toby-S/gists{/gist_id}","starred_url":"https://api.github.com/users/Toby-S/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Toby-S/subscriptions","organizations_url":"https://api.github.com/users/Toby-S/orgs","repos_url":"https://api.github.com/users/Toby-S/repos","events_url":"https://api.github.com/users/Toby-S/events{/privacy}","received_events_url":"https://api.github.com/users/Toby-S/received_events","type":"User","site_admin":false},"created_at":"2015-10-23T22:20:47Z","updated_at":"2015-10-23T22:20:47Z","body":"+1 for the solid underlines."}}