{"action":"created","issue":{"url":"https://api.github.com/repos/litaio/chef-lita/issues/22","labels_url":"https://api.github.com/repos/litaio/chef-lita/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/litaio/chef-lita/issues/22/comments","events_url":"https://api.github.com/repos/litaio/chef-lita/issues/22/events","html_url":"https://github.com/litaio/chef-lita/pull/22","id":90819775,"number":22,"title":"Consolidate init recipes","user":{"login":"notnmeyer","id":672246,"avatar_url":"https://avatars.githubusercontent.com/u/672246?v=3","gravatar_id":"","url":"https://api.github.com/users/notnmeyer","html_url":"https://github.com/notnmeyer","followers_url":"https://api.github.com/users/notnmeyer/followers","following_url":"https://api.github.com/users/notnmeyer/following{/other_user}","gists_url":"https://api.github.com/users/notnmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/notnmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notnmeyer/subscriptions","organizations_url":"https://api.github.com/users/notnmeyer/orgs","repos_url":"https://api.github.com/users/notnmeyer/repos","events_url":"https://api.github.com/users/notnmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/notnmeyer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-06-25T01:11:47Z","updated_at":"2015-09-02T23:32:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/litaio/chef-lita/pulls/22","html_url":"https://github.com/litaio/chef-lita/pull/22","diff_url":"https://github.com/litaio/chef-lita/pull/22.diff","patch_url":"https://github.com/litaio/chef-lita/pull/22.patch"},"body":"Hello! There are a few small changes here:\r\n\r\n* A new attribute: `node[\"lita\"][\"daemon_group\"]`. Using a 'nobody' group is technically incorrect, even though you can get away with it sometimes. 'nogroup'' is the correct group to use with the 'nobody' user.\r\n\r\n* I threw a guard on including the apt cookbook to only include it for relevant platform families.\r\n\r\n* Lastly and the primary reason for this PR: I consolidated the SysV and Runit init recipes into a single recipe. I'm interested in adding CentOS 7 support to the cookbook, which will likely means a systemd service file for managing Lita. The `return` strategy to optionally include those recipes will get messy fast.\r\n\r\nI wanted to get your take on consolidating this before I get too deep into the CentOS stuff."},"comment":{"url":"https://api.github.com/repos/litaio/chef-lita/issues/comments/137273350","html_url":"https://github.com/litaio/chef-lita/pull/22#issuecomment-137273350","issue_url":"https://api.github.com/repos/litaio/chef-lita/issues/22","id":137273350,"user":{"login":"notnmeyer","id":672246,"avatar_url":"https://avatars.githubusercontent.com/u/672246?v=3","gravatar_id":"","url":"https://api.github.com/users/notnmeyer","html_url":"https://github.com/notnmeyer","followers_url":"https://api.github.com/users/notnmeyer/followers","following_url":"https://api.github.com/users/notnmeyer/following{/other_user}","gists_url":"https://api.github.com/users/notnmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/notnmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notnmeyer/subscriptions","organizations_url":"https://api.github.com/users/notnmeyer/orgs","repos_url":"https://api.github.com/users/notnmeyer/repos","events_url":"https://api.github.com/users/notnmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/notnmeyer/received_events","type":"User","site_admin":false},"created_at":"2015-09-02T23:32:55Z","updated_at":"2015-09-02T23:32:55Z","body":"@shortdudey123 My attention at work got pulled somewhere else and I haven't gotten back to working on CentOS support. It's still something I'm planning on getting back to but I don't have much in the way of an update unfortunately.\r\n\r\n@harlanbarnes @jimmycuadra Based on your earlier feedback:\r\n\r\n> A) we leave a version of runit_service in there that just calls init_service and as a log message with a deprecation notice \r\n\r\nI went ahead and added this. Shouldn't be a breaking change now. How are you feeling about getting this merged? "}}