{"action":"created","issue":{"url":"https://api.github.com/repos/h5p/h5p-php-library/issues/2","labels_url":"https://api.github.com/repos/h5p/h5p-php-library/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/h5p/h5p-php-library/issues/2/comments","events_url":"https://api.github.com/repos/h5p/h5p-php-library/issues/2/events","html_url":"https://github.com/h5p/h5p-php-library/issues/2","id":112182274,"number":2,"title":"xapi result.success and result.completion properties not supported","user":{"login":"garemoko","id":1363163,"avatar_url":"https://avatars.githubusercontent.com/u/1363163?v=3","gravatar_id":"","url":"https://api.github.com/users/garemoko","html_url":"https://github.com/garemoko","followers_url":"https://api.github.com/users/garemoko/followers","following_url":"https://api.github.com/users/garemoko/following{/other_user}","gists_url":"https://api.github.com/users/garemoko/gists{/gist_id}","starred_url":"https://api.github.com/users/garemoko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garemoko/subscriptions","organizations_url":"https://api.github.com/users/garemoko/orgs","repos_url":"https://api.github.com/users/garemoko/repos","events_url":"https://api.github.com/users/garemoko/events{/privacy}","received_events_url":"https://api.github.com/users/garemoko/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-10-19T16:27:32Z","updated_at":"2015-10-20T09:26:19Z","closed_at":null,"body":"H5P's tracking does not support the result.success and result.completion properties, which are important properties used by most quiz authoring tools and LRSs that report on quiz data (e.g. Watershed). \r\n\r\nIt looks like these could easily be added in as additional optional properties to [setScoredResult](https://github.com/h5p/h5p-php-library/blob/cb8640195ebd8b0f8c3903ae6a831a7bc66966a1/js/h5p-x-api-event.js#L22-L39). \r\n\r\nWould I be right in assuming that if this library is updated that this would also be reflected in the next release of the WordPress plugin? \r\n\r\nWould it be helpful for me to make a PR? "},"comment":{"url":"https://api.github.com/repos/h5p/h5p-php-library/issues/comments/149491341","html_url":"https://github.com/h5p/h5p-php-library/issues/2#issuecomment-149491341","issue_url":"https://api.github.com/repos/h5p/h5p-php-library/issues/2","id":149491341,"user":{"login":"garemoko","id":1363163,"avatar_url":"https://avatars.githubusercontent.com/u/1363163?v=3","gravatar_id":"","url":"https://api.github.com/users/garemoko","html_url":"https://github.com/garemoko","followers_url":"https://api.github.com/users/garemoko/followers","following_url":"https://api.github.com/users/garemoko/following{/other_user}","gists_url":"https://api.github.com/users/garemoko/gists{/gist_id}","starred_url":"https://api.github.com/users/garemoko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garemoko/subscriptions","organizations_url":"https://api.github.com/users/garemoko/orgs","repos_url":"https://api.github.com/users/garemoko/repos","events_url":"https://api.github.com/users/garemoko/events{/privacy}","received_events_url":"https://api.github.com/users/garemoko/received_events","type":"User","site_admin":false},"created_at":"2015-10-20T09:26:19Z","updated_at":"2015-10-20T09:26:19Z","body":"They are optional, but it's good practice to include optional properties where the data exists. The reason they are optional is not because they aren't important, but because xAPI can be used to track things other than quiz questions which may not have this data. "}}