{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/516","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/516/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/516/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/516/events","html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/516","id":110360403,"number":516,"title":"Fix the device filling behavior when testing directly against the dev…","user":{"login":"stfeng","id":10470372,"avatar_url":"https://avatars.githubusercontent.com/u/10470372?v=3","gravatar_id":"","url":"https://api.github.com/users/stfeng","html_url":"https://github.com/stfeng","followers_url":"https://api.github.com/users/stfeng/followers","following_url":"https://api.github.com/users/stfeng/following{/other_user}","gists_url":"https://api.github.com/users/stfeng/gists{/gist_id}","starred_url":"https://api.github.com/users/stfeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stfeng/subscriptions","organizations_url":"https://api.github.com/users/stfeng/orgs","repos_url":"https://api.github.com/users/stfeng/repos","events_url":"https://api.github.com/users/stfeng/events{/privacy}","received_events_url":"https://api.github.com/users/stfeng/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/labels/cla:%20yes","name":"cla: yes","color":"009800"},{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/labels/ready%20for%20review","name":"ready for review","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-08T02:28:42Z","updated_at":"2015-10-08T04:26:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/516","html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/516","diff_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/516.diff","patch_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/516.patch"},"body":"…ice. (we should always fill the device in the directly-against-device mode to ensure correctness of the test!)"},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/comments/146415949","html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/516#issuecomment-146415949","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/516","id":146415949,"user":{"login":"noahl","id":16882,"avatar_url":"https://avatars.githubusercontent.com/u/16882?v=3","gravatar_id":"","url":"https://api.github.com/users/noahl","html_url":"https://github.com/noahl","followers_url":"https://api.github.com/users/noahl/followers","following_url":"https://api.github.com/users/noahl/following{/other_user}","gists_url":"https://api.github.com/users/noahl/gists{/gist_id}","starred_url":"https://api.github.com/users/noahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noahl/subscriptions","organizations_url":"https://api.github.com/users/noahl/orgs","repos_url":"https://api.github.com/users/noahl/repos","events_url":"https://api.github.com/users/noahl/events{/privacy}","received_events_url":"https://api.github.com/users/noahl/received_events","type":"User","site_admin":false},"created_at":"2015-10-08T04:26:21Z","updated_at":"2015-10-08T04:26:21Z","body":"I think that if prefill_device is explicitly given, then it should override against_device. A check like `if FLAGS.prefill_device or (not FLAGS['prefill_device'].present and FLAGS.against_device)` should work.\r\n\r\nHowever, I don't think @voellm agrees that this should be the default behavior. We'll have to talk about it."}}