{"action":"created","issue":{"url":"https://api.github.com/repos/trayo/scavenger_hunter/issues/36","labels_url":"https://api.github.com/repos/trayo/scavenger_hunter/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/trayo/scavenger_hunter/issues/36/comments","events_url":"https://api.github.com/repos/trayo/scavenger_hunter/issues/36/events","html_url":"https://github.com/trayo/scavenger_hunter/pull/36","id":62280331,"number":36,"title":"Add simplecov increase coverage","user":{"login":"trayo","id":6809782,"avatar_url":"https://avatars.githubusercontent.com/u/6809782?v=3","gravatar_id":"","url":"https://api.github.com/users/trayo","html_url":"https://github.com/trayo","followers_url":"https://api.github.com/users/trayo/followers","following_url":"https://api.github.com/users/trayo/following{/other_user}","gists_url":"https://api.github.com/users/trayo/gists{/gist_id}","starred_url":"https://api.github.com/users/trayo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trayo/subscriptions","organizations_url":"https://api.github.com/users/trayo/orgs","repos_url":"https://api.github.com/users/trayo/repos","events_url":"https://api.github.com/users/trayo/events{/privacy}","received_events_url":"https://api.github.com/users/trayo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/trayo/scavenger_hunter/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-03-17T04:03:46Z","updated_at":"2015-03-17T17:34:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/trayo/scavenger_hunter/pulls/36","html_url":"https://github.com/trayo/scavenger_hunter/pull/36","diff_url":"https://github.com/trayo/scavenger_hunter/pull/36.diff","patch_url":"https://github.com/trayo/scavenger_hunter/pull/36.patch"},"body":"Most of what I did is in my commit messages. The only thing that remains untested is the `teams?` method in the application helper. It's functionality is a bit confusing and in the way it's being implemented.\r\n\r\nGiven that we have a table on the database called Team, a `teams?` method would say to me that it's checking if there are any actual teams, but the code of the method checks that the `request.path` is equal to `/teams` or, since it's a regex, `/team` (because \"team\" would still match). I've included the code here for reference. \r\n\r\n```\r\n  def teams?\r\n    !!(request.path =~ /teams/)\r\n  end\r\n```"},"comment":{"url":"https://api.github.com/repos/trayo/scavenger_hunter/issues/comments/82490887","html_url":"https://github.com/trayo/scavenger_hunter/pull/36#issuecomment-82490887","issue_url":"https://api.github.com/repos/trayo/scavenger_hunter/issues/36","id":82490887,"user":{"login":"Tmee","id":8226837,"avatar_url":"https://avatars.githubusercontent.com/u/8226837?v=3","gravatar_id":"","url":"https://api.github.com/users/Tmee","html_url":"https://github.com/Tmee","followers_url":"https://api.github.com/users/Tmee/followers","following_url":"https://api.github.com/users/Tmee/following{/other_user}","gists_url":"https://api.github.com/users/Tmee/gists{/gist_id}","starred_url":"https://api.github.com/users/Tmee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tmee/subscriptions","organizations_url":"https://api.github.com/users/Tmee/orgs","repos_url":"https://api.github.com/users/Tmee/repos","events_url":"https://api.github.com/users/Tmee/events{/privacy}","received_events_url":"https://api.github.com/users/Tmee/received_events","type":"User","site_admin":false},"created_at":"2015-03-17T17:34:03Z","updated_at":"2015-03-17T17:34:03Z","body":"Thanks for this input guys, super helpful. Can both of you stop commenting on this repo, please?\r\n"}}