{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/27070987","id":27070987,"diff_hunk":"@@ -176,42 +206,42 @@ public void cancelShouldSucceed() throws Exception {\n   }\n \n   @Test\n-  public void cancelBeforeStreamAssignedShouldSucceed() throws Exception {\n+  public void cancelWhileBufferedShouldSucceed() throws Exception {\n     handler.connection().local().maxStreams(0);\n     handler.write(ctx, new CreateStreamCommand(grpcHeaders, stream), promise);\n     mockContext();\n-    verify(stream, never()).id(any(Integer.class));\n-    when(stream.id()).thenReturn(null);\n-\n+    ArgumentCaptor<Integer> idCaptor = ArgumentCaptor.forClass(Integer.class);\n+    verify(stream).id(idCaptor.capture());\n+    when(stream.id()).thenReturn(idCaptor.getValue());\n     handler.write(ctx, new CancelStreamCommand(stream), promise);\n     verify(promise).setSuccess();\n     verifyNoMoreInteractions(ctx);\n   }\n \n+// TODO: Uncomment this once Netty is updated.\n   /**\n    * Although nobody is listening to an exception should it occur during cancel(), we don't want an\n    * exception to be thrown because it would negatively impact performance, and we don't want our\n    * users workarounding around such performance issues.\n    */\n-  @Test\n-  public void cancelTwiceShouldSucceed() throws Exception {\n-    createStream();\n-\n-    handler.write(ctx, new CancelStreamCommand(stream), promise);\n-\n-    ByteBuf expected = rstStreamFrame(3, (int) Http2Error.CANCEL.code());\n-    verify(ctx).write(eq(expected), eq(promise));\n-    verify(ctx).flush();\n-\n-    promise = mock(ChannelPromise.class);\n-    handler.write(ctx, new CancelStreamCommand(stream), promise);\n-    verify(promise).setSuccess();\n-  }\n+//  @Test","path":"netty/src/test/java/io/grpc/transport/netty/NettyClientHandlerTest.java","position":144,"original_position":144,"commit_id":"fc7213eeadd93a84af68a1aa34b363424ab3ccfe","original_commit_id":"fc7213eeadd93a84af68a1aa34b363424ab3ccfe","user":{"login":"buchgr","id":1388179,"avatar_url":"https://avatars.githubusercontent.com/u/1388179?v=3","gravatar_id":"","url":"https://api.github.com/users/buchgr","html_url":"https://github.com/buchgr","followers_url":"https://api.github.com/users/buchgr/followers","following_url":"https://api.github.com/users/buchgr/following{/other_user}","gists_url":"https://api.github.com/users/buchgr/gists{/gist_id}","starred_url":"https://api.github.com/users/buchgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchgr/subscriptions","organizations_url":"https://api.github.com/users/buchgr/orgs","repos_url":"https://api.github.com/users/buchgr/repos","events_url":"https://api.github.com/users/buchgr/events{/privacy}","received_events_url":"https://api.github.com/users/buchgr/received_events","type":"User","site_admin":false},"body":"Would like to get Scott's PR in before we merge https://github.com/netty/netty/pull/3528","created_at":"2015-03-24T20:45:01Z","updated_at":"2015-03-24T20:45:01Z","html_url":"https://github.com/grpc/grpc-java/pull/225#discussion_r27070987","pull_request_url":"https://api.github.com/repos/grpc/grpc-java/pulls/225","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/27070987"},"html":{"href":"https://github.com/grpc/grpc-java/pull/225#discussion_r27070987"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/225"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/225","id":31643251,"html_url":"https://github.com/grpc/grpc-java/pull/225","diff_url":"https://github.com/grpc/grpc-java/pull/225.diff","patch_url":"https://github.com/grpc/grpc-java/pull/225.patch","issue_url":"https://api.github.com/repos/grpc/grpc-java/issues/225","number":225,"state":"open","locked":false,"title":"Remove blocking on netty client stream creation.","user":{"login":"buchgr","id":1388179,"avatar_url":"https://avatars.githubusercontent.com/u/1388179?v=3","gravatar_id":"","url":"https://api.github.com/users/buchgr","html_url":"https://github.com/buchgr","followers_url":"https://api.github.com/users/buchgr/followers","following_url":"https://api.github.com/users/buchgr/following{/other_user}","gists_url":"https://api.github.com/users/buchgr/gists{/gist_id}","starred_url":"https://api.github.com/users/buchgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchgr/subscriptions","organizations_url":"https://api.github.com/users/buchgr/orgs","repos_url":"https://api.github.com/users/buchgr/repos","events_url":"https://api.github.com/users/buchgr/events{/privacy}","received_events_url":"https://api.github.com/users/buchgr/received_events","type":"User","site_admin":false},"body":"See #118 .","created_at":"2015-03-20T19:12:58Z","updated_at":"2015-03-24T20:45:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fe66bbd19652dc4fedadb047fbbf87946c6318a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-java/pulls/225/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-java/pulls/225/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-java/issues/225/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/fc7213eeadd93a84af68a1aa34b363424ab3ccfe","head":{"label":"buchgr:maxconcurrent","ref":"maxconcurrent","sha":"fc7213eeadd93a84af68a1aa34b363424ab3ccfe","user":{"login":"buchgr","id":1388179,"avatar_url":"https://avatars.githubusercontent.com/u/1388179?v=3","gravatar_id":"","url":"https://api.github.com/users/buchgr","html_url":"https://github.com/buchgr","followers_url":"https://api.github.com/users/buchgr/followers","following_url":"https://api.github.com/users/buchgr/following{/other_user}","gists_url":"https://api.github.com/users/buchgr/gists{/gist_id}","starred_url":"https://api.github.com/users/buchgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchgr/subscriptions","organizations_url":"https://api.github.com/users/buchgr/orgs","repos_url":"https://api.github.com/users/buchgr/repos","events_url":"https://api.github.com/users/buchgr/events{/privacy}","received_events_url":"https://api.github.com/users/buchgr/received_events","type":"User","site_admin":false},"repo":{"id":31381511,"name":"grpc-java","full_name":"buchgr/grpc-java","owner":{"login":"buchgr","id":1388179,"avatar_url":"https://avatars.githubusercontent.com/u/1388179?v=3","gravatar_id":"","url":"https://api.github.com/users/buchgr","html_url":"https://github.com/buchgr","followers_url":"https://api.github.com/users/buchgr/followers","following_url":"https://api.github.com/users/buchgr/following{/other_user}","gists_url":"https://api.github.com/users/buchgr/gists{/gist_id}","starred_url":"https://api.github.com/users/buchgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchgr/subscriptions","organizations_url":"https://api.github.com/users/buchgr/orgs","repos_url":"https://api.github.com/users/buchgr/repos","events_url":"https://api.github.com/users/buchgr/events{/privacy}","received_events_url":"https://api.github.com/users/buchgr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/buchgr/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/buchgr/grpc-java","forks_url":"https://api.github.com/repos/buchgr/grpc-java/forks","keys_url":"https://api.github.com/repos/buchgr/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buchgr/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buchgr/grpc-java/teams","hooks_url":"https://api.github.com/repos/buchgr/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/buchgr/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/buchgr/grpc-java/events","assignees_url":"https://api.github.com/repos/buchgr/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/buchgr/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/buchgr/grpc-java/tags","blobs_url":"https://api.github.com/repos/buchgr/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buchgr/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buchgr/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/buchgr/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buchgr/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/buchgr/grpc-java/languages","stargazers_url":"https://api.github.com/repos/buchgr/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/buchgr/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/buchgr/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/buchgr/grpc-java/subscription","commits_url":"https://api.github.com/repos/buchgr/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/buchgr/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/buchgr/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/buchgr/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/buchgr/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/buchgr/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buchgr/grpc-java/merges","archive_url":"https://api.github.com/repos/buchgr/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buchgr/grpc-java/downloads","issues_url":"https://api.github.com/repos/buchgr/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/buchgr/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/buchgr/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/buchgr/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buchgr/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/buchgr/grpc-java/releases{/id}","created_at":"2015-02-26T18:18:24Z","updated_at":"2015-03-11T21:25:43Z","pushed_at":"2015-03-24T19:45:08Z","git_url":"git://github.com/buchgr/grpc-java.git","ssh_url":"git@github.com:buchgr/grpc-java.git","clone_url":"https://github.com/buchgr/grpc-java.git","svn_url":"https://github.com/buchgr/grpc-java","homepage":"","size":1664,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"6407c185783d931db47cc5b6cb4bf99d06064d50","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729926,"name":"grpc-java","full_name":"grpc/grpc-java","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-java","forks_url":"https://api.github.com/repos/grpc/grpc-java/forks","keys_url":"https://api.github.com/repos/grpc/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-java/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-java/events","assignees_url":"https://api.github.com/repos/grpc/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-java/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-java/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-java/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-java/merges","archive_url":"https://api.github.com/repos/grpc/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-java/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-java/releases{/id}","created_at":"2014-12-08T19:00:00Z","updated_at":"2015-03-24T20:02:14Z","pushed_at":"2015-03-24T19:45:08Z","git_url":"git://github.com/grpc/grpc-java.git","ssh_url":"git@github.com:grpc/grpc-java.git","clone_url":"https://github.com/grpc/grpc-java.git","svn_url":"https://github.com/grpc/grpc-java","homepage":"","size":16448,"stargazers_count":609,"watchers_count":609,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":127,"mirror_url":null,"open_issues_count":53,"forks":127,"open_issues":53,"watchers":609,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/225"},"html":{"href":"https://github.com/grpc/grpc-java/pull/225"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/225"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-java/statuses/fc7213eeadd93a84af68a1aa34b363424ab3ccfe"}}}}