{"action":"created","comment":{"url":"https://api.github.com/repos/openchange/openchange/pulls/comments/24362798","id":24362798,"diff_hunk":"@@ -2708,8 +2757,6 @@ static enum mapistore_error mapistore_python_message_set_read_flag(void *message\n \t\treturn MAPISTORE_ERR_CONTEXT_FAILED;\n \t}\n \n-\t/* TODO Send Receipt */","path":"mapiproxy/libmapistore/mapistore_python.c","position":106,"original_position":106,"commit_id":"331ad515cd8b5c52f3801b84cd9d2927ed5c9c44","original_commit_id":"331ad515cd8b5c52f3801b84cd9d2927ed5c9c44","user":{"login":"jelmer","id":49032,"avatar_url":"https://avatars.githubusercontent.com/u/49032?v=3","gravatar_id":"","url":"https://api.github.com/users/jelmer","html_url":"https://github.com/jelmer","followers_url":"https://api.github.com/users/jelmer/followers","following_url":"https://api.github.com/users/jelmer/following{/other_user}","gists_url":"https://api.github.com/users/jelmer/gists{/gist_id}","starred_url":"https://api.github.com/users/jelmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelmer/subscriptions","organizations_url":"https://api.github.com/users/jelmer/orgs","repos_url":"https://api.github.com/users/jelmer/repos","events_url":"https://api.github.com/users/jelmer/events{/privacy}","received_events_url":"https://api.github.com/users/jelmer/received_events","type":"User","site_admin":false},"body":"You probably want to check the type of pres here, because PyLong_AsLong() will not return anything predictable otherwise.","created_at":"2015-02-09T20:35:38Z","updated_at":"2015-02-09T20:35:38Z","html_url":"https://github.com/openchange/openchange/pull/203#discussion_r24362798","pull_request_url":"https://api.github.com/repos/openchange/openchange/pulls/203","_links":{"self":{"href":"https://api.github.com/repos/openchange/openchange/pulls/comments/24362798"},"html":{"href":"https://github.com/openchange/openchange/pull/203#discussion_r24362798"},"pull_request":{"href":"https://api.github.com/repos/openchange/openchange/pulls/203"}}},"pull_request":{"url":"https://api.github.com/repos/openchange/openchange/pulls/203","id":28914505,"html_url":"https://github.com/openchange/openchange/pull/203","diff_url":"https://github.com/openchange/openchange/pull/203.diff","patch_url":"https://github.com/openchange/openchange/pull/203.patch","issue_url":"https://api.github.com/repos/openchange/openchange/issues/203","number":203,"state":"open","locked":false,"title":"Correct set_read_flag behaviour","user":{"login":"icandigitbaby","id":3977183,"avatar_url":"https://avatars.githubusercontent.com/u/3977183?v=3","gravatar_id":"","url":"https://api.github.com/users/icandigitbaby","html_url":"https://github.com/icandigitbaby","followers_url":"https://api.github.com/users/icandigitbaby/followers","following_url":"https://api.github.com/users/icandigitbaby/following{/other_user}","gists_url":"https://api.github.com/users/icandigitbaby/gists{/gist_id}","starred_url":"https://api.github.com/users/icandigitbaby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icandigitbaby/subscriptions","organizations_url":"https://api.github.com/users/icandigitbaby/orgs","repos_url":"https://api.github.com/users/icandigitbaby/repos","events_url":"https://api.github.com/users/icandigitbaby/events{/privacy}","received_events_url":"https://api.github.com/users/icandigitbaby/received_events","type":"User","site_admin":false},"body":"This PR corrects the behaviour of `mapistore_python_message_set_read_flag`.\r\n\r\n* The flags that the function takes define de behaviour of the function (set/clear read flag and send read receipt).\r\n* The `PidTagMessageFlags` property is read and not overwritten.\r\n* Read receipts are still unhandled after this PR.","created_at":"2015-02-09T11:53:07Z","updated_at":"2015-02-09T20:35:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7770c55d87043d9038fe7ebe0e401e41f28b63f0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openchange/openchange/pulls/203/commits","review_comments_url":"https://api.github.com/repos/openchange/openchange/pulls/203/comments","review_comment_url":"https://api.github.com/repos/openchange/openchange/pulls/comments/{number}","comments_url":"https://api.github.com/repos/openchange/openchange/issues/203/comments","statuses_url":"https://api.github.com/repos/openchange/openchange/statuses/331ad515cd8b5c52f3801b84cd9d2927ed5c9c44","head":{"label":"icandigitbaby:mapistore-python","ref":"mapistore-python","sha":"331ad515cd8b5c52f3801b84cd9d2927ed5c9c44","user":{"login":"icandigitbaby","id":3977183,"avatar_url":"https://avatars.githubusercontent.com/u/3977183?v=3","gravatar_id":"","url":"https://api.github.com/users/icandigitbaby","html_url":"https://github.com/icandigitbaby","followers_url":"https://api.github.com/users/icandigitbaby/followers","following_url":"https://api.github.com/users/icandigitbaby/following{/other_user}","gists_url":"https://api.github.com/users/icandigitbaby/gists{/gist_id}","starred_url":"https://api.github.com/users/icandigitbaby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icandigitbaby/subscriptions","organizations_url":"https://api.github.com/users/icandigitbaby/orgs","repos_url":"https://api.github.com/users/icandigitbaby/repos","events_url":"https://api.github.com/users/icandigitbaby/events{/privacy}","received_events_url":"https://api.github.com/users/icandigitbaby/received_events","type":"User","site_admin":false},"repo":{"id":22465700,"name":"openchange","full_name":"icandigitbaby/openchange","owner":{"login":"icandigitbaby","id":3977183,"avatar_url":"https://avatars.githubusercontent.com/u/3977183?v=3","gravatar_id":"","url":"https://api.github.com/users/icandigitbaby","html_url":"https://github.com/icandigitbaby","followers_url":"https://api.github.com/users/icandigitbaby/followers","following_url":"https://api.github.com/users/icandigitbaby/following{/other_user}","gists_url":"https://api.github.com/users/icandigitbaby/gists{/gist_id}","starred_url":"https://api.github.com/users/icandigitbaby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icandigitbaby/subscriptions","organizations_url":"https://api.github.com/users/icandigitbaby/orgs","repos_url":"https://api.github.com/users/icandigitbaby/repos","events_url":"https://api.github.com/users/icandigitbaby/events{/privacy}","received_events_url":"https://api.github.com/users/icandigitbaby/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/icandigitbaby/openchange","description":"OpenChange Project","fork":true,"url":"https://api.github.com/repos/icandigitbaby/openchange","forks_url":"https://api.github.com/repos/icandigitbaby/openchange/forks","keys_url":"https://api.github.com/repos/icandigitbaby/openchange/keys{/key_id}","collaborators_url":"https://api.github.com/repos/icandigitbaby/openchange/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/icandigitbaby/openchange/teams","hooks_url":"https://api.github.com/repos/icandigitbaby/openchange/hooks","issue_events_url":"https://api.github.com/repos/icandigitbaby/openchange/issues/events{/number}","events_url":"https://api.github.com/repos/icandigitbaby/openchange/events","assignees_url":"https://api.github.com/repos/icandigitbaby/openchange/assignees{/user}","branches_url":"https://api.github.com/repos/icandigitbaby/openchange/branches{/branch}","tags_url":"https://api.github.com/repos/icandigitbaby/openchange/tags","blobs_url":"https://api.github.com/repos/icandigitbaby/openchange/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/icandigitbaby/openchange/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/icandigitbaby/openchange/git/refs{/sha}","trees_url":"https://api.github.com/repos/icandigitbaby/openchange/git/trees{/sha}","statuses_url":"https://api.github.com/repos/icandigitbaby/openchange/statuses/{sha}","languages_url":"https://api.github.com/repos/icandigitbaby/openchange/languages","stargazers_url":"https://api.github.com/repos/icandigitbaby/openchange/stargazers","contributors_url":"https://api.github.com/repos/icandigitbaby/openchange/contributors","subscribers_url":"https://api.github.com/repos/icandigitbaby/openchange/subscribers","subscription_url":"https://api.github.com/repos/icandigitbaby/openchange/subscription","commits_url":"https://api.github.com/repos/icandigitbaby/openchange/commits{/sha}","git_commits_url":"https://api.github.com/repos/icandigitbaby/openchange/git/commits{/sha}","comments_url":"https://api.github.com/repos/icandigitbaby/openchange/comments{/number}","issue_comment_url":"https://api.github.com/repos/icandigitbaby/openchange/issues/comments/{number}","contents_url":"https://api.github.com/repos/icandigitbaby/openchange/contents/{+path}","compare_url":"https://api.github.com/repos/icandigitbaby/openchange/compare/{base}...{head}","merges_url":"https://api.github.com/repos/icandigitbaby/openchange/merges","archive_url":"https://api.github.com/repos/icandigitbaby/openchange/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/icandigitbaby/openchange/downloads","issues_url":"https://api.github.com/repos/icandigitbaby/openchange/issues{/number}","pulls_url":"https://api.github.com/repos/icandigitbaby/openchange/pulls{/number}","milestones_url":"https://api.github.com/repos/icandigitbaby/openchange/milestones{/number}","notifications_url":"https://api.github.com/repos/icandigitbaby/openchange/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/icandigitbaby/openchange/labels{/name}","releases_url":"https://api.github.com/repos/icandigitbaby/openchange/releases{/id}","created_at":"2014-07-31T10:37:39Z","updated_at":"2014-08-11T14:18:47Z","pushed_at":"2015-02-09T14:55:15Z","git_url":"git://github.com/icandigitbaby/openchange.git","ssh_url":"git@github.com:icandigitbaby/openchange.git","clone_url":"https://github.com/icandigitbaby/openchange.git","svn_url":"https://github.com/icandigitbaby/openchange","homepage":null,"size":20517,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openchange:jkerihuel/mapistore-python","ref":"jkerihuel/mapistore-python","sha":"a5af4e5fae40cda1b6162365b13f4095fe2a25ec","user":{"login":"openchange","id":5413705,"avatar_url":"https://avatars.githubusercontent.com/u/5413705?v=3","gravatar_id":"","url":"https://api.github.com/users/openchange","html_url":"https://github.com/openchange","followers_url":"https://api.github.com/users/openchange/followers","following_url":"https://api.github.com/users/openchange/following{/other_user}","gists_url":"https://api.github.com/users/openchange/gists{/gist_id}","starred_url":"https://api.github.com/users/openchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openchange/subscriptions","organizations_url":"https://api.github.com/users/openchange/orgs","repos_url":"https://api.github.com/users/openchange/repos","events_url":"https://api.github.com/users/openchange/events{/privacy}","received_events_url":"https://api.github.com/users/openchange/received_events","type":"Organization","site_admin":false},"repo":{"id":12688822,"name":"openchange","full_name":"openchange/openchange","owner":{"login":"openchange","id":5413705,"avatar_url":"https://avatars.githubusercontent.com/u/5413705?v=3","gravatar_id":"","url":"https://api.github.com/users/openchange","html_url":"https://github.com/openchange","followers_url":"https://api.github.com/users/openchange/followers","following_url":"https://api.github.com/users/openchange/following{/other_user}","gists_url":"https://api.github.com/users/openchange/gists{/gist_id}","starred_url":"https://api.github.com/users/openchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openchange/subscriptions","organizations_url":"https://api.github.com/users/openchange/orgs","repos_url":"https://api.github.com/users/openchange/repos","events_url":"https://api.github.com/users/openchange/events{/privacy}","received_events_url":"https://api.github.com/users/openchange/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openchange/openchange","description":"OpenChange Project","fork":false,"url":"https://api.github.com/repos/openchange/openchange","forks_url":"https://api.github.com/repos/openchange/openchange/forks","keys_url":"https://api.github.com/repos/openchange/openchange/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openchange/openchange/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openchange/openchange/teams","hooks_url":"https://api.github.com/repos/openchange/openchange/hooks","issue_events_url":"https://api.github.com/repos/openchange/openchange/issues/events{/number}","events_url":"https://api.github.com/repos/openchange/openchange/events","assignees_url":"https://api.github.com/repos/openchange/openchange/assignees{/user}","branches_url":"https://api.github.com/repos/openchange/openchange/branches{/branch}","tags_url":"https://api.github.com/repos/openchange/openchange/tags","blobs_url":"https://api.github.com/repos/openchange/openchange/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openchange/openchange/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openchange/openchange/git/refs{/sha}","trees_url":"https://api.github.com/repos/openchange/openchange/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openchange/openchange/statuses/{sha}","languages_url":"https://api.github.com/repos/openchange/openchange/languages","stargazers_url":"https://api.github.com/repos/openchange/openchange/stargazers","contributors_url":"https://api.github.com/repos/openchange/openchange/contributors","subscribers_url":"https://api.github.com/repos/openchange/openchange/subscribers","subscription_url":"https://api.github.com/repos/openchange/openchange/subscription","commits_url":"https://api.github.com/repos/openchange/openchange/commits{/sha}","git_commits_url":"https://api.github.com/repos/openchange/openchange/git/commits{/sha}","comments_url":"https://api.github.com/repos/openchange/openchange/comments{/number}","issue_comment_url":"https://api.github.com/repos/openchange/openchange/issues/comments/{number}","contents_url":"https://api.github.com/repos/openchange/openchange/contents/{+path}","compare_url":"https://api.github.com/repos/openchange/openchange/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openchange/openchange/merges","archive_url":"https://api.github.com/repos/openchange/openchange/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openchange/openchange/downloads","issues_url":"https://api.github.com/repos/openchange/openchange/issues{/number}","pulls_url":"https://api.github.com/repos/openchange/openchange/pulls{/number}","milestones_url":"https://api.github.com/repos/openchange/openchange/milestones{/number}","notifications_url":"https://api.github.com/repos/openchange/openchange/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openchange/openchange/labels{/name}","releases_url":"https://api.github.com/repos/openchange/openchange/releases{/id}","created_at":"2013-09-08T22:39:00Z","updated_at":"2015-02-03T00:51:32Z","pushed_at":"2015-02-09T11:51:16Z","git_url":"git://github.com/openchange/openchange.git","ssh_url":"git@github.com:openchange/openchange.git","clone_url":"https://github.com/openchange/openchange.git","svn_url":"https://github.com/openchange/openchange","homepage":null,"size":24167,"stargazers_count":42,"watchers_count":42,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":21,"forks":25,"open_issues":21,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openchange/openchange/pulls/203"},"html":{"href":"https://github.com/openchange/openchange/pull/203"},"issue":{"href":"https://api.github.com/repos/openchange/openchange/issues/203"},"comments":{"href":"https://api.github.com/repos/openchange/openchange/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/openchange/openchange/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/openchange/openchange/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/openchange/openchange/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/openchange/openchange/statuses/331ad515cd8b5c52f3801b84cd9d2927ed5c9c44"}}}}