{"action":"created","issue":{"url":"https://api.github.com/repos/Leaflet/Leaflet.draw/issues/354","labels_url":"https://api.github.com/repos/Leaflet/Leaflet.draw/issues/354/labels{/name}","comments_url":"https://api.github.com/repos/Leaflet/Leaflet.draw/issues/354/comments","events_url":"https://api.github.com/repos/Leaflet/Leaflet.draw/issues/354/events","html_url":"https://github.com/Leaflet/Leaflet.draw/pull/354","id":53429775,"number":354,"title":"Leaflet toolbar plugin","user":{"login":"manleyjster","id":1668487,"avatar_url":"https://avatars.githubusercontent.com/u/1668487?v=3","gravatar_id":"","url":"https://api.github.com/users/manleyjster","html_url":"https://github.com/manleyjster","followers_url":"https://api.github.com/users/manleyjster/followers","following_url":"https://api.github.com/users/manleyjster/following{/other_user}","gists_url":"https://api.github.com/users/manleyjster/gists{/gist_id}","starred_url":"https://api.github.com/users/manleyjster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manleyjster/subscriptions","organizations_url":"https://api.github.com/users/manleyjster/orgs","repos_url":"https://api.github.com/users/manleyjster/repos","events_url":"https://api.github.com/users/manleyjster/events{/privacy}","received_events_url":"https://api.github.com/users/manleyjster/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2015-01-05T18:57:36Z","updated_at":"2015-04-13T05:01:35Z","closed_at":"2015-04-02T01:36:08Z","pull_request":{"url":"https://api.github.com/repos/Leaflet/Leaflet.draw/pulls/354","html_url":"https://github.com/Leaflet/Leaflet.draw/pull/354","diff_url":"https://github.com/Leaflet/Leaflet.draw/pull/354.diff","patch_url":"https://github.com/Leaflet/Leaflet.draw/pull/354.patch"},"body":"This PR replaces all of the toolbars in `Leaflet.draw` with toolbars from [`Leaflet.Toolbar`](https://github.com/manleyjster/Leaflet.Toolbar) as proposed in #324.\r\n\r\nIn particular, this pull request:\r\n* Has each draw handler inherit from `L.ToolbarAction` instead of `L.Handler`. `L.ToolbarAction` is a new class from `L.Toolbar`, inheriting from `L.Handler` and including defaults for the toolbar icon and methods for building the icon and submenu.\r\n* Replaces `src/draw/DrawToolbar.js` with a control-style drawing toolbar in [`src/draw/control`](https://github.com/manleyjster/Leaflet.draw/tree/leaflet-toolbar-plugin/src/draw/control).\r\n* Replaces `src/edit/EditToolbar.js` with a control-style editing toolbar in [`src/edit/control`](https://github.com/manleyjster/Leaflet.draw/tree/leaflet-toolbar-plugin/src/edit/control).\r\n* Adds a new popup-style editing toolbar in [`src/edit/popup`](https://github.com/manleyjster/Leaflet.draw/tree/leaflet-toolbar-plugin/src/edit/popup).\r\n* Prunes `Leaflet.draw` CSS, as much of the toolbar styles can now be pulled in from `Leaflet.Toolbar`.\r\n\r\nThere are live examples of the new toolbar functionality for Leaflet.draw at:\r\nhttp://manleyjster.github.io/Leaflet.Toolbar/examples/control.html\r\nhttp://manleyjster.github.io/Leaflet.Toolbar/examples/popup.html.\r\n\r\nI also wrote a short blog post about designing Leaflet.Toolbar and porting the Leaflet.draw toolbars over to the new plugin - you can check that out here: http://justinmanley.io/blog.\r\n\r\nDocumentation for Leaflet.Toolbar is in a wiki: https://github.com/manleyjster/Leaflet.Toolbar/wiki/API-Reference.\r\n\r\nI'm excited to get a conversation started about this PR!"},"comment":{"url":"https://api.github.com/repos/Leaflet/Leaflet.draw/issues/comments/92212871","html_url":"https://github.com/Leaflet/Leaflet.draw/pull/354#issuecomment-92212871","issue_url":"https://api.github.com/repos/Leaflet/Leaflet.draw/issues/354","id":92212871,"user":{"login":"manleyjster","id":1668487,"avatar_url":"https://avatars.githubusercontent.com/u/1668487?v=3","gravatar_id":"","url":"https://api.github.com/users/manleyjster","html_url":"https://github.com/manleyjster","followers_url":"https://api.github.com/users/manleyjster/followers","following_url":"https://api.github.com/users/manleyjster/following{/other_user}","gists_url":"https://api.github.com/users/manleyjster/gists{/gist_id}","starred_url":"https://api.github.com/users/manleyjster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manleyjster/subscriptions","organizations_url":"https://api.github.com/users/manleyjster/orgs","repos_url":"https://api.github.com/users/manleyjster/repos","events_url":"https://api.github.com/users/manleyjster/events{/privacy}","received_events_url":"https://api.github.com/users/manleyjster/received_events","type":"User","site_admin":false},"created_at":"2015-04-13T05:01:34Z","updated_at":"2015-04-13T05:01:34Z","body":"@jacobtoye - I'm happy to make the changes you suggest, but I'm a bit confused...\r\n\r\nDid you actually merge this PR in? None of the changes I made are showing up on the tip of the master branch, either online, or when I `git pull` locally. Did you revert this PR after merging?"}}