{"action":"created","comment":{"url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/comments/26782195","id":26782195,"diff_hunk":"@@ -48,6 +49,8 @@ class CharmNovaCompute(CharmBase):\n     allow_multi_units = True\n     allowed_assignment_types = [AssignmentType.BareMetal,\n                                 AssignmentType.KVM]\n+    is_core = True\n+    depends = ['nova-cloud-controller', 'mysql', 'glance', 'rabbitmq']","path":"cloudinstall/charms/compute.py","position":13,"original_position":13,"commit_id":"5ddb5314d11b530671977a952ef2fc0495f7f9cb","original_commit_id":"5ddb5314d11b530671977a952ef2fc0495f7f9cb","user":{"login":"mikemccracken","id":1768106,"avatar_url":"https://avatars.githubusercontent.com/u/1768106?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemccracken","html_url":"https://github.com/mikemccracken","followers_url":"https://api.github.com/users/mikemccracken/followers","following_url":"https://api.github.com/users/mikemccracken/following{/other_user}","gists_url":"https://api.github.com/users/mikemccracken/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemccracken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemccracken/subscriptions","organizations_url":"https://api.github.com/users/mikemccracken/orgs","repos_url":"https://api.github.com/users/mikemccracken/repos","events_url":"https://api.github.com/users/mikemccracken/events{/privacy}","received_events_url":"https://api.github.com/users/mikemccracken/received_events","type":"User","site_admin":false},"body":"this and the change to controller.py raise a question - for the 'core' set of charms, we don't need to put them in each others' depends lists, since they will all be deployed together anyway.\r\nIt might be worth leaving them in as documentation, but I'd vote to leave them out since they might get out of sync because they're not really necessary, and not cause problems until further down the line.","created_at":"2015-03-19T18:13:07Z","updated_at":"2015-03-19T18:13:07Z","html_url":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer/pull/474#discussion_r26782195","pull_request_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/474","_links":{"self":{"href":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/comments/26782195"},"html":{"href":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer/pull/474#discussion_r26782195"},"pull_request":{"href":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/474"}}},"pull_request":{"url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/474","id":31466244,"html_url":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer/pull/474","diff_url":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer/pull/474.diff","patch_url":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer/pull/474.patch","issue_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/issues/474","number":474,"state":"open","locked":false,"title":"Support CharmState and depends/conflicts","user":{"login":"battlemidget","id":51892,"avatar_url":"https://avatars.githubusercontent.com/u/51892?v=3","gravatar_id":"","url":"https://api.github.com/users/battlemidget","html_url":"https://github.com/battlemidget","followers_url":"https://api.github.com/users/battlemidget/followers","following_url":"https://api.github.com/users/battlemidget/following{/other_user}","gists_url":"https://api.github.com/users/battlemidget/gists{/gist_id}","starred_url":"https://api.github.com/users/battlemidget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/battlemidget/subscriptions","organizations_url":"https://api.github.com/users/battlemidget/orgs","repos_url":"https://api.github.com/users/battlemidget/repos","events_url":"https://api.github.com/users/battlemidget/events{/privacy}","received_events_url":"https://api.github.com/users/battlemidget/received_events","type":"User","site_admin":false},"body":"CharmState class added to set REQUIRED, OPTIONAL along with\r\nacting up charms depends/conflicts definitions\r\n\r\nSigned-off-by: Adam Stokes <adam.stokes@ubuntu.com>","created_at":"2015-03-18T20:01:30Z","updated_at":"2015-03-19T18:13:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8020c8965ad4cf971f634bc6cbf60f6477ced109","assignee":{"login":"mikemccracken","id":1768106,"avatar_url":"https://avatars.githubusercontent.com/u/1768106?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemccracken","html_url":"https://github.com/mikemccracken","followers_url":"https://api.github.com/users/mikemccracken/followers","following_url":"https://api.github.com/users/mikemccracken/following{/other_user}","gists_url":"https://api.github.com/users/mikemccracken/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemccracken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemccracken/subscriptions","organizations_url":"https://api.github.com/users/mikemccracken/orgs","repos_url":"https://api.github.com/users/mikemccracken/repos","events_url":"https://api.github.com/users/mikemccracken/events{/privacy}","received_events_url":"https://api.github.com/users/mikemccracken/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/474/commits","review_comments_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/474/comments","review_comment_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/issues/474/comments","statuses_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/statuses/5ddb5314d11b530671977a952ef2fc0495f7f9cb","head":{"label":"Ubuntu-Solutions-Engineering:patch-charm-state","ref":"patch-charm-state","sha":"5ddb5314d11b530671977a952ef2fc0495f7f9cb","user":{"login":"Ubuntu-Solutions-Engineering","id":6772632,"avatar_url":"https://avatars.githubusercontent.com/u/6772632?v=3","gravatar_id":"","url":"https://api.github.com/users/Ubuntu-Solutions-Engineering","html_url":"https://github.com/Ubuntu-Solutions-Engineering","followers_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/followers","following_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/following{/other_user}","gists_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/subscriptions","organizations_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/orgs","repos_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/repos","events_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/events{/privacy}","received_events_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/received_events","type":"Organization","site_admin":false},"repo":{"id":17140192,"name":"openstack-installer","full_name":"Ubuntu-Solutions-Engineering/openstack-installer","owner":{"login":"Ubuntu-Solutions-Engineering","id":6772632,"avatar_url":"https://avatars.githubusercontent.com/u/6772632?v=3","gravatar_id":"","url":"https://api.github.com/users/Ubuntu-Solutions-Engineering","html_url":"https://github.com/Ubuntu-Solutions-Engineering","followers_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/followers","following_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/following{/other_user}","gists_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/subscriptions","organizations_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/orgs","repos_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/repos","events_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/events{/privacy}","received_events_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer","description":"Ubuntu OpenStack Installer","fork":false,"url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer","forks_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/forks","keys_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/teams","hooks_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/hooks","issue_events_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/issues/events{/number}","events_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/events","assignees_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/assignees{/user}","branches_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/branches{/branch}","tags_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/tags","blobs_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/languages","stargazers_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/stargazers","contributors_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/contributors","subscribers_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/subscribers","subscription_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/subscription","commits_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/contents/{+path}","compare_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/merges","archive_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/downloads","issues_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/issues{/number}","pulls_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/labels{/name}","releases_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/releases{/id}","created_at":"2014-02-24T15:17:19Z","updated_at":"2015-03-19T14:30:10Z","pushed_at":"2015-03-18T20:29:26Z","git_url":"git://github.com/Ubuntu-Solutions-Engineering/openstack-installer.git","ssh_url":"git@github.com:Ubuntu-Solutions-Engineering/openstack-installer.git","clone_url":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer.git","svn_url":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer","homepage":"http://j.mp/ubuntu-openstack-installer","size":8634,"stargazers_count":37,"watchers_count":37,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":37,"forks":22,"open_issues":37,"watchers":37,"default_branch":"master"}},"base":{"label":"Ubuntu-Solutions-Engineering:master","ref":"master","sha":"616e4ad54949b68b5aa187a6ca41f5bf9d359698","user":{"login":"Ubuntu-Solutions-Engineering","id":6772632,"avatar_url":"https://avatars.githubusercontent.com/u/6772632?v=3","gravatar_id":"","url":"https://api.github.com/users/Ubuntu-Solutions-Engineering","html_url":"https://github.com/Ubuntu-Solutions-Engineering","followers_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/followers","following_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/following{/other_user}","gists_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/subscriptions","organizations_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/orgs","repos_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/repos","events_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/events{/privacy}","received_events_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/received_events","type":"Organization","site_admin":false},"repo":{"id":17140192,"name":"openstack-installer","full_name":"Ubuntu-Solutions-Engineering/openstack-installer","owner":{"login":"Ubuntu-Solutions-Engineering","id":6772632,"avatar_url":"https://avatars.githubusercontent.com/u/6772632?v=3","gravatar_id":"","url":"https://api.github.com/users/Ubuntu-Solutions-Engineering","html_url":"https://github.com/Ubuntu-Solutions-Engineering","followers_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/followers","following_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/following{/other_user}","gists_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/subscriptions","organizations_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/orgs","repos_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/repos","events_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/events{/privacy}","received_events_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer","description":"Ubuntu OpenStack Installer","fork":false,"url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer","forks_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/forks","keys_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/teams","hooks_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/hooks","issue_events_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/issues/events{/number}","events_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/events","assignees_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/assignees{/user}","branches_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/branches{/branch}","tags_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/tags","blobs_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/languages","stargazers_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/stargazers","contributors_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/contributors","subscribers_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/subscribers","subscription_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/subscription","commits_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/contents/{+path}","compare_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/merges","archive_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/downloads","issues_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/issues{/number}","pulls_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/labels{/name}","releases_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/releases{/id}","created_at":"2014-02-24T15:17:19Z","updated_at":"2015-03-19T14:30:10Z","pushed_at":"2015-03-18T20:29:26Z","git_url":"git://github.com/Ubuntu-Solutions-Engineering/openstack-installer.git","ssh_url":"git@github.com:Ubuntu-Solutions-Engineering/openstack-installer.git","clone_url":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer.git","svn_url":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer","homepage":"http://j.mp/ubuntu-openstack-installer","size":8634,"stargazers_count":37,"watchers_count":37,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":37,"forks":22,"open_issues":37,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/474"},"html":{"href":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer/pull/474"},"issue":{"href":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/issues/474"},"comments":{"href":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/issues/474/comments"},"review_comments":{"href":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/474/comments"},"review_comment":{"href":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/474/commits"},"statuses":{"href":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/statuses/5ddb5314d11b530671977a952ef2fc0495f7f9cb"}}}}