{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/42734058","id":42734058,"diff_hunk":"@@ -126,31 +152,54 @@ class CharValueList\n   string m_string;\n };\n \n-class Uint32ValueList\n+class ValueListUint32\n {\n public:\n-  using TBuffer = vector<uint32_t>;\n+  using TValue = uint32_t;\n+  using TSerializer = SingleValueSerializerUint32;\n+\n+  ValueListUint32() = default;\n+\n+  void Init(vector<TValue> const & values) { m_values = values; }\n+\n+  size_t Size() const { return m_values.size(); }\n \n-  void Append(uint32_t value)\n+  bool IsEmpty() const { return m_values.empty(); }\n+\n+  template <typename TSink>\n+  void Serialize(TSink & sink, TSerializer const & /* serializer */) const\n   {\n-    m_values.push_back(value);\n+    for (auto const & value : m_values)\n+      WriteToSink(sink, value);","path":"coding/coding_tests/trie_test.cpp","position":119,"original_position":119,"commit_id":"0472359da82576067fd0620e43638701a2ae4442","original_commit_id":"0472359da82576067fd0620e43638701a2ae4442","user":{"login":"vng","id":175612,"avatar_url":"https://avatars.githubusercontent.com/u/175612?v=3","gravatar_id":"","url":"https://api.github.com/users/vng","html_url":"https://github.com/vng","followers_url":"https://api.github.com/users/vng/followers","following_url":"https://api.github.com/users/vng/following{/other_user}","gists_url":"https://api.github.com/users/vng/gists{/gist_id}","starred_url":"https://api.github.com/users/vng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vng/subscriptions","organizations_url":"https://api.github.com/users/vng/orgs","repos_url":"https://api.github.com/users/vng/repos","events_url":"https://api.github.com/users/vng/events{/privacy}","received_events_url":"https://api.github.com/users/vng/received_events","type":"User","site_admin":false},"body":"А почему мы тут пишем as-is а не как var uint ?","created_at":"2015-10-22T10:50:15Z","updated_at":"2015-10-22T10:50:15Z","html_url":"https://github.com/mapsme/omim/pull/146#discussion_r42734058","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/146","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/42734058"},"html":{"href":"https://github.com/mapsme/omim/pull/146#discussion_r42734058"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/146"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/146","id":46994782,"html_url":"https://github.com/mapsme/omim/pull/146","diff_url":"https://github.com/mapsme/omim/pull/146.diff","patch_url":"https://github.com/mapsme/omim/pull/146.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/146","number":146,"state":"open","locked":false,"title":"[search] Bit vectors are now stored in the search index.","user":{"login":"mpimenov","id":10366009,"avatar_url":"https://avatars.githubusercontent.com/u/10366009?v=3","gravatar_id":"","url":"https://api.github.com/users/mpimenov","html_url":"https://github.com/mpimenov","followers_url":"https://api.github.com/users/mpimenov/followers","following_url":"https://api.github.com/users/mpimenov/following{/other_user}","gists_url":"https://api.github.com/users/mpimenov/gists{/gist_id}","starred_url":"https://api.github.com/users/mpimenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpimenov/subscriptions","organizations_url":"https://api.github.com/users/mpimenov/orgs","repos_url":"https://api.github.com/users/mpimenov/repos","events_url":"https://api.github.com/users/mpimenov/events{/privacy}","received_events_url":"https://api.github.com/users/mpimenov/received_events","type":"User","site_admin":false},"body":"https://trello.com/c/IKZASNeR/38--","created_at":"2015-10-07T07:32:27Z","updated_at":"2015-10-22T10:50:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de777c4cfcfe6398078d3b817cb2fff8663a160f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/146/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/146/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/146/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/0472359da82576067fd0620e43638701a2ae4442","head":{"label":"mpimenov:search-index-cbv","ref":"search-index-cbv","sha":"0472359da82576067fd0620e43638701a2ae4442","user":{"login":"mpimenov","id":10366009,"avatar_url":"https://avatars.githubusercontent.com/u/10366009?v=3","gravatar_id":"","url":"https://api.github.com/users/mpimenov","html_url":"https://github.com/mpimenov","followers_url":"https://api.github.com/users/mpimenov/followers","following_url":"https://api.github.com/users/mpimenov/following{/other_user}","gists_url":"https://api.github.com/users/mpimenov/gists{/gist_id}","starred_url":"https://api.github.com/users/mpimenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpimenov/subscriptions","organizations_url":"https://api.github.com/users/mpimenov/orgs","repos_url":"https://api.github.com/users/mpimenov/repos","events_url":"https://api.github.com/users/mpimenov/events{/privacy}","received_events_url":"https://api.github.com/users/mpimenov/received_events","type":"User","site_admin":false},"repo":{"id":43427925,"name":"omim","full_name":"mpimenov/omim","owner":{"login":"mpimenov","id":10366009,"avatar_url":"https://avatars.githubusercontent.com/u/10366009?v=3","gravatar_id":"","url":"https://api.github.com/users/mpimenov","html_url":"https://github.com/mpimenov","followers_url":"https://api.github.com/users/mpimenov/followers","following_url":"https://api.github.com/users/mpimenov/following{/other_user}","gists_url":"https://api.github.com/users/mpimenov/gists{/gist_id}","starred_url":"https://api.github.com/users/mpimenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpimenov/subscriptions","organizations_url":"https://api.github.com/users/mpimenov/orgs","repos_url":"https://api.github.com/users/mpimenov/repos","events_url":"https://api.github.com/users/mpimenov/events{/privacy}","received_events_url":"https://api.github.com/users/mpimenov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpimenov/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/mpimenov/omim","forks_url":"https://api.github.com/repos/mpimenov/omim/forks","keys_url":"https://api.github.com/repos/mpimenov/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpimenov/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpimenov/omim/teams","hooks_url":"https://api.github.com/repos/mpimenov/omim/hooks","issue_events_url":"https://api.github.com/repos/mpimenov/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mpimenov/omim/events","assignees_url":"https://api.github.com/repos/mpimenov/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mpimenov/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mpimenov/omim/tags","blobs_url":"https://api.github.com/repos/mpimenov/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpimenov/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpimenov/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpimenov/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpimenov/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mpimenov/omim/languages","stargazers_url":"https://api.github.com/repos/mpimenov/omim/stargazers","contributors_url":"https://api.github.com/repos/mpimenov/omim/contributors","subscribers_url":"https://api.github.com/repos/mpimenov/omim/subscribers","subscription_url":"https://api.github.com/repos/mpimenov/omim/subscription","commits_url":"https://api.github.com/repos/mpimenov/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpimenov/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpimenov/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpimenov/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpimenov/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mpimenov/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpimenov/omim/merges","archive_url":"https://api.github.com/repos/mpimenov/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpimenov/omim/downloads","issues_url":"https://api.github.com/repos/mpimenov/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mpimenov/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mpimenov/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mpimenov/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpimenov/omim/labels{/name}","releases_url":"https://api.github.com/repos/mpimenov/omim/releases{/id}","created_at":"2015-09-30T10:55:18Z","updated_at":"2015-09-30T10:57:30Z","pushed_at":"2015-10-21T14:25:26Z","git_url":"git://github.com/mpimenov/omim.git","ssh_url":"git@github.com:mpimenov/omim.git","clone_url":"https://github.com/mpimenov/omim.git","svn_url":"https://github.com/mpimenov/omim","homepage":null,"size":1819050,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:new-search","ref":"new-search","sha":"15d0812befccc0492edfcc123dd17d96a6367328","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","created_at":"2015-09-20T02:57:13Z","updated_at":"2015-10-22T09:07:27Z","pushed_at":"2015-10-22T09:57:42Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":null,"size":1845846,"stargazers_count":1401,"watchers_count":1401,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":40,"forks":145,"open_issues":40,"watchers":1401,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/146"},"html":{"href":"https://github.com/mapsme/omim/pull/146"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/146"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/0472359da82576067fd0620e43638701a2ae4442"}}}}