{"action":"created","comment":{"url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments/44545520","id":44545520,"diff_hunk":"@@ -1113,76 +1113,23 @@ void iFlushCall(int flushtype)\n //\t}\n //}\n \n-\n-static u32 scaleBlockCycles_helper()\n+static u32 scaleblockcycles()\n {\n-\t// Note: s_nBlockCycles is 3 bit fixed point.  Divide by 8 when done!\n-\n-\t// Let's not scale blocks under 5-ish cycles.  This fixes countless \"problems\"","path":"pcsx2/x86/ix86-32/iR5900-32.cpp","position":37,"original_position":37,"commit_id":"739faac2648199890b1f8763952b70d4de918109","original_commit_id":"739faac2648199890b1f8763952b70d4de918109","user":{"login":"ssakash","id":8477408,"avatar_url":"https://avatars.githubusercontent.com/u/8477408?v=3","gravatar_id":"","url":"https://api.github.com/users/ssakash","html_url":"https://github.com/ssakash","followers_url":"https://api.github.com/users/ssakash/followers","following_url":"https://api.github.com/users/ssakash/following{/other_user}","gists_url":"https://api.github.com/users/ssakash/gists{/gist_id}","starred_url":"https://api.github.com/users/ssakash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssakash/subscriptions","organizations_url":"https://api.github.com/users/ssakash/orgs","repos_url":"https://api.github.com/users/ssakash/repos","events_url":"https://api.github.com/users/ssakash/events{/privacy}","received_events_url":"https://api.github.com/users/ssakash/received_events","type":"User","site_admin":false},"body":"yeah, that's important. I'll put it back when I get the time ","created_at":"2015-11-11T15:38:15Z","updated_at":"2015-11-11T15:38:15Z","html_url":"https://github.com/PCSX2/pcsx2/pull/947#discussion_r44545520","pull_request_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/947","_links":{"self":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments/44545520"},"html":{"href":"https://github.com/PCSX2/pcsx2/pull/947#discussion_r44545520"},"pull_request":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/947"}}},"pull_request":{"url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/947","id":49368341,"html_url":"https://github.com/PCSX2/pcsx2/pull/947","diff_url":"https://github.com/PCSX2/pcsx2/pull/947.diff","patch_url":"https://github.com/PCSX2/pcsx2/pull/947.patch","issue_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/947","number":947,"state":"open","locked":false,"title":"EE: Rework overclock and underclock function","user":{"login":"ssakash","id":8477408,"avatar_url":"https://avatars.githubusercontent.com/u/8477408?v=3","gravatar_id":"","url":"https://api.github.com/users/ssakash","html_url":"https://github.com/ssakash","followers_url":"https://api.github.com/users/ssakash/followers","following_url":"https://api.github.com/users/ssakash/following{/other_user}","gists_url":"https://api.github.com/users/ssakash/gists{/gist_id}","starred_url":"https://api.github.com/users/ssakash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssakash/subscriptions","organizations_url":"https://api.github.com/users/ssakash/orgs","repos_url":"https://api.github.com/users/ssakash/repos","events_url":"https://api.github.com/users/ssakash/events{/privacy}","received_events_url":"https://api.github.com/users/ssakash/received_events","type":"User","site_admin":false},"body":"**Summary of changes :-**\r\n\r\n- don't classify blocks and use different scaled block cycles for each specific range, rather use a constant value for all the range (having lower blocks as an exception since they're very sensitive on these stuffs)\r\n\r\n-  decrease the complexity on the code ( 71 lines -> 18 lines )\r\n\r\n- Integrate ``eeScaleBlockCycles()`` and ``scaleBlockCycles_helper()`` to a single function\r\n\r\nThe first mentioned change actually seems to make the games run a lot better on overclock and underclock scenarios thanks to the removed classification of scalar_mid & scalar_ high stuffs. which probably caused some quirks due to dynamic scalar variable toggles (maybe ? )\r\n\r\nThe following code change needs reviews from @ramapcsx2  and @refractionpcsx2 \r\n\r\nalso for future plans,\r\n\r\n- maybe move the cycle rate manipulation to some place rather than  ``iBranchTest()`` to have higher overclock range. ( higher underclock range is already possible )\r\n\r\n- invert the slider to have overclock on right side and underclock on left, lots of users were complaining about it. ( Need more users opinion before proceeding on this one) \r\n","created_at":"2015-11-01T09:07:23Z","updated_at":"2015-11-11T15:38:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d4208a91c8ae4e0ab262afeef977bb7ba57ea46","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/947/commits","review_comments_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/947/comments","review_comment_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/947/comments","statuses_url":"https://api.github.com/repos/PCSX2/pcsx2/statuses/739faac2648199890b1f8763952b70d4de918109","head":{"label":"ssakash:EE_Control_V2","ref":"EE_Control_V2","sha":"739faac2648199890b1f8763952b70d4de918109","user":{"login":"ssakash","id":8477408,"avatar_url":"https://avatars.githubusercontent.com/u/8477408?v=3","gravatar_id":"","url":"https://api.github.com/users/ssakash","html_url":"https://github.com/ssakash","followers_url":"https://api.github.com/users/ssakash/followers","following_url":"https://api.github.com/users/ssakash/following{/other_user}","gists_url":"https://api.github.com/users/ssakash/gists{/gist_id}","starred_url":"https://api.github.com/users/ssakash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssakash/subscriptions","organizations_url":"https://api.github.com/users/ssakash/orgs","repos_url":"https://api.github.com/users/ssakash/repos","events_url":"https://api.github.com/users/ssakash/events{/privacy}","received_events_url":"https://api.github.com/users/ssakash/received_events","type":"User","site_admin":false},"repo":{"id":34851284,"name":"pcsx2","full_name":"ssakash/pcsx2","owner":{"login":"ssakash","id":8477408,"avatar_url":"https://avatars.githubusercontent.com/u/8477408?v=3","gravatar_id":"","url":"https://api.github.com/users/ssakash","html_url":"https://github.com/ssakash","followers_url":"https://api.github.com/users/ssakash/followers","following_url":"https://api.github.com/users/ssakash/following{/other_user}","gists_url":"https://api.github.com/users/ssakash/gists{/gist_id}","starred_url":"https://api.github.com/users/ssakash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssakash/subscriptions","organizations_url":"https://api.github.com/users/ssakash/orgs","repos_url":"https://api.github.com/users/ssakash/repos","events_url":"https://api.github.com/users/ssakash/events{/privacy}","received_events_url":"https://api.github.com/users/ssakash/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ssakash/pcsx2","description":"PCSX2 - The Playstation 2 Emulator","fork":true,"url":"https://api.github.com/repos/ssakash/pcsx2","forks_url":"https://api.github.com/repos/ssakash/pcsx2/forks","keys_url":"https://api.github.com/repos/ssakash/pcsx2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ssakash/pcsx2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ssakash/pcsx2/teams","hooks_url":"https://api.github.com/repos/ssakash/pcsx2/hooks","issue_events_url":"https://api.github.com/repos/ssakash/pcsx2/issues/events{/number}","events_url":"https://api.github.com/repos/ssakash/pcsx2/events","assignees_url":"https://api.github.com/repos/ssakash/pcsx2/assignees{/user}","branches_url":"https://api.github.com/repos/ssakash/pcsx2/branches{/branch}","tags_url":"https://api.github.com/repos/ssakash/pcsx2/tags","blobs_url":"https://api.github.com/repos/ssakash/pcsx2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ssakash/pcsx2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ssakash/pcsx2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ssakash/pcsx2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ssakash/pcsx2/statuses/{sha}","languages_url":"https://api.github.com/repos/ssakash/pcsx2/languages","stargazers_url":"https://api.github.com/repos/ssakash/pcsx2/stargazers","contributors_url":"https://api.github.com/repos/ssakash/pcsx2/contributors","subscribers_url":"https://api.github.com/repos/ssakash/pcsx2/subscribers","subscription_url":"https://api.github.com/repos/ssakash/pcsx2/subscription","commits_url":"https://api.github.com/repos/ssakash/pcsx2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ssakash/pcsx2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ssakash/pcsx2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ssakash/pcsx2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ssakash/pcsx2/contents/{+path}","compare_url":"https://api.github.com/repos/ssakash/pcsx2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ssakash/pcsx2/merges","archive_url":"https://api.github.com/repos/ssakash/pcsx2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ssakash/pcsx2/downloads","issues_url":"https://api.github.com/repos/ssakash/pcsx2/issues{/number}","pulls_url":"https://api.github.com/repos/ssakash/pcsx2/pulls{/number}","milestones_url":"https://api.github.com/repos/ssakash/pcsx2/milestones{/number}","notifications_url":"https://api.github.com/repos/ssakash/pcsx2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ssakash/pcsx2/labels{/name}","releases_url":"https://api.github.com/repos/ssakash/pcsx2/releases{/id}","created_at":"2015-04-30T11:36:34Z","updated_at":"2015-10-23T08:25:19Z","pushed_at":"2015-11-11T14:05:20Z","git_url":"git://github.com/ssakash/pcsx2.git","ssh_url":"git@github.com:ssakash/pcsx2.git","clone_url":"https://github.com/ssakash/pcsx2.git","svn_url":"https://github.com/ssakash/pcsx2","homepage":"http://pcsx2.net/","size":71687,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"PCSX2:master","ref":"master","sha":"916c80d53ff434d5034249a13733f405d7c4bc85","user":{"login":"PCSX2","id":6278711,"avatar_url":"https://avatars.githubusercontent.com/u/6278711?v=3","gravatar_id":"","url":"https://api.github.com/users/PCSX2","html_url":"https://github.com/PCSX2","followers_url":"https://api.github.com/users/PCSX2/followers","following_url":"https://api.github.com/users/PCSX2/following{/other_user}","gists_url":"https://api.github.com/users/PCSX2/gists{/gist_id}","starred_url":"https://api.github.com/users/PCSX2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCSX2/subscriptions","organizations_url":"https://api.github.com/users/PCSX2/orgs","repos_url":"https://api.github.com/users/PCSX2/repos","events_url":"https://api.github.com/users/PCSX2/events{/privacy}","received_events_url":"https://api.github.com/users/PCSX2/received_events","type":"Organization","site_admin":false},"repo":{"id":15379620,"name":"pcsx2","full_name":"PCSX2/pcsx2","owner":{"login":"PCSX2","id":6278711,"avatar_url":"https://avatars.githubusercontent.com/u/6278711?v=3","gravatar_id":"","url":"https://api.github.com/users/PCSX2","html_url":"https://github.com/PCSX2","followers_url":"https://api.github.com/users/PCSX2/followers","following_url":"https://api.github.com/users/PCSX2/following{/other_user}","gists_url":"https://api.github.com/users/PCSX2/gists{/gist_id}","starred_url":"https://api.github.com/users/PCSX2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCSX2/subscriptions","organizations_url":"https://api.github.com/users/PCSX2/orgs","repos_url":"https://api.github.com/users/PCSX2/repos","events_url":"https://api.github.com/users/PCSX2/events{/privacy}","received_events_url":"https://api.github.com/users/PCSX2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PCSX2/pcsx2","description":"PCSX2 - The Playstation 2 Emulator","fork":false,"url":"https://api.github.com/repos/PCSX2/pcsx2","forks_url":"https://api.github.com/repos/PCSX2/pcsx2/forks","keys_url":"https://api.github.com/repos/PCSX2/pcsx2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PCSX2/pcsx2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PCSX2/pcsx2/teams","hooks_url":"https://api.github.com/repos/PCSX2/pcsx2/hooks","issue_events_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/events{/number}","events_url":"https://api.github.com/repos/PCSX2/pcsx2/events","assignees_url":"https://api.github.com/repos/PCSX2/pcsx2/assignees{/user}","branches_url":"https://api.github.com/repos/PCSX2/pcsx2/branches{/branch}","tags_url":"https://api.github.com/repos/PCSX2/pcsx2/tags","blobs_url":"https://api.github.com/repos/PCSX2/pcsx2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PCSX2/pcsx2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PCSX2/pcsx2/git/refs{/sha}","trees_url":"https://api.github.com/repos/PCSX2/pcsx2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PCSX2/pcsx2/statuses/{sha}","languages_url":"https://api.github.com/repos/PCSX2/pcsx2/languages","stargazers_url":"https://api.github.com/repos/PCSX2/pcsx2/stargazers","contributors_url":"https://api.github.com/repos/PCSX2/pcsx2/contributors","subscribers_url":"https://api.github.com/repos/PCSX2/pcsx2/subscribers","subscription_url":"https://api.github.com/repos/PCSX2/pcsx2/subscription","commits_url":"https://api.github.com/repos/PCSX2/pcsx2/commits{/sha}","git_commits_url":"https://api.github.com/repos/PCSX2/pcsx2/git/commits{/sha}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/comments{/number}","issue_comment_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/comments{/number}","contents_url":"https://api.github.com/repos/PCSX2/pcsx2/contents/{+path}","compare_url":"https://api.github.com/repos/PCSX2/pcsx2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PCSX2/pcsx2/merges","archive_url":"https://api.github.com/repos/PCSX2/pcsx2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PCSX2/pcsx2/downloads","issues_url":"https://api.github.com/repos/PCSX2/pcsx2/issues{/number}","pulls_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls{/number}","milestones_url":"https://api.github.com/repos/PCSX2/pcsx2/milestones{/number}","notifications_url":"https://api.github.com/repos/PCSX2/pcsx2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PCSX2/pcsx2/labels{/name}","releases_url":"https://api.github.com/repos/PCSX2/pcsx2/releases{/id}","created_at":"2013-12-22T17:56:48Z","updated_at":"2015-11-11T02:10:53Z","pushed_at":"2015-11-11T14:05:20Z","git_url":"git://github.com/PCSX2/pcsx2.git","ssh_url":"git@github.com:PCSX2/pcsx2.git","clone_url":"https://github.com/PCSX2/pcsx2.git","svn_url":"https://github.com/PCSX2/pcsx2","homepage":"http://pcsx2.net/","size":113541,"stargazers_count":944,"watchers_count":944,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":235,"mirror_url":null,"open_issues_count":191,"forks":235,"open_issues":191,"watchers":944,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/947"},"html":{"href":"https://github.com/PCSX2/pcsx2/pull/947"},"issue":{"href":"https://api.github.com/repos/PCSX2/pcsx2/issues/947"},"comments":{"href":"https://api.github.com/repos/PCSX2/pcsx2/issues/947/comments"},"review_comments":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/947/comments"},"review_comment":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/947/commits"},"statuses":{"href":"https://api.github.com/repos/PCSX2/pcsx2/statuses/739faac2648199890b1f8763952b70d4de918109"}}}}