{"action":"created","comment":{"url":"https://api.github.com/repos/KualiCo/kc/pulls/comments/24771102","id":24771102,"diff_hunk":"@@ -64,51 +69,44 @@\n         </property>\n         <property name=\"items\">\n             <list>\n-                <bean parent=\"Uif-InputField\" p:propertyName=\"startDate\" p:required=\"true\"\n-                      p:order=\"10\"\n-                      p:readOnly=\"@{!#isAddLine and !#ViewHelper.isBudgetLineItemEditable(#collectionGroup.bindingInfo.bindingPath,#index,editableBudgetLineItems)}\"/>\n-                <bean parent=\"Uif-InputField\" p:propertyName=\"endDate\" p:required=\"true\"\n-                      p:order=\"20\"\n-                      p:readOnly=\"@{!#isAddLine and !#ViewHelper.isBudgetLineItemEditable(#collectionGroup.bindingInfo.bindingPath,#index,editableBudgetLineItems)}\"/>\n+                <bean parent=\"Kc-InlineEdit-InputField\" p:propertyName=\"startDate\" p:required=\"true\"\n+                      p:order=\"10\" p:fieldLabel.labelText=\"Period Start[br]Date \">\n+                    <property name=\"control\">\n+                        <bean parent=\"Uif-DateControlOnFocus\" p:watermarkText=\"mm/dd/yyyy\" />\n+                    </property>\n+                </bean>\n+                <bean parent=\"Kc-InlineEdit-InputField\" p:propertyName=\"endDate\" p:required=\"true\"\n+                      p:order=\"20\">\n+                    <property name=\"control\">\n+                        <bean parent=\"Uif-DateControlOnFocus\" p:watermarkText=\"mm/dd/yyyy\" />\n+                    </property>\n+                </bean>\n                 <bean parent=\"Uif-InputField\" p:propertyName=\"numberOfMonths\" p:label=\"Months\"\n                       p:order=\"30\"\n                       p:readOnly=\"true\"/>\n                 <bean parent=\"Uif-InputField\" p:propertyName=\"totalCost\"\n                       p:order=\"40\"\n-                      p:readOnly=\"@{#line.readOnly or !#isAddLine and !#ViewHelper.isBudgetLineItemEditable(#collectionGroup.bindingInfo.bindingPath,#index,editableBudgetLineItems)}\"/>\n+                      p:readOnly=\"@{!#isAddLine}\"/>","path":"coeus-impl/src/main/resources/org/kuali/coeus/propdev/impl/budget/core/ProposalBudgetPeriodsPage.xml","position":40,"original_position":40,"commit_id":"fa41e806e893616e1786241fe738220759ca408f","original_commit_id":"fa41e806e893616e1786241fe738220759ca408f","user":{"login":"blackcathacker","id":3145921,"avatar_url":"https://avatars.githubusercontent.com/u/3145921?v=3","gravatar_id":"","url":"https://api.github.com/users/blackcathacker","html_url":"https://github.com/blackcathacker","followers_url":"https://api.github.com/users/blackcathacker/followers","following_url":"https://api.github.com/users/blackcathacker/following{/other_user}","gists_url":"https://api.github.com/users/blackcathacker/gists{/gist_id}","starred_url":"https://api.github.com/users/blackcathacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackcathacker/subscriptions","organizations_url":"https://api.github.com/users/blackcathacker/orgs","repos_url":"https://api.github.com/users/blackcathacker/repos","events_url":"https://api.github.com/users/blackcathacker/events{/privacy}","received_events_url":"https://api.github.com/users/blackcathacker/received_events","type":"User","site_admin":false},"body":"So I feel like all these fields should be inline editable as long as there aren't line items in the budget?","created_at":"2015-02-16T19:34:40Z","updated_at":"2015-02-16T19:34:40Z","html_url":"https://github.com/KualiCo/kc/pull/48#discussion_r24771102","pull_request_url":"https://api.github.com/repos/KualiCo/kc/pulls/48","_links":{"self":{"href":"https://api.github.com/repos/KualiCo/kc/pulls/comments/24771102"},"html":{"href":"https://github.com/KualiCo/kc/pull/48#discussion_r24771102"},"pull_request":{"href":"https://api.github.com/repos/KualiCo/kc/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/KualiCo/kc/pulls/48","id":29294896,"html_url":"https://github.com/KualiCo/kc/pull/48","diff_url":"https://github.com/KualiCo/kc/pull/48.diff","patch_url":"https://github.com/KualiCo/kc/pull/48.patch","issue_url":"https://api.github.com/repos/KualiCo/kc/issues/48","number":48,"state":"open","locked":false,"title":"KRACOEUS-8840: convert budget periods page to inline editing","user":{"login":"jwillia","id":7320896,"avatar_url":"https://avatars.githubusercontent.com/u/7320896?v=3","gravatar_id":"","url":"https://api.github.com/users/jwillia","html_url":"https://github.com/jwillia","followers_url":"https://api.github.com/users/jwillia/followers","following_url":"https://api.github.com/users/jwillia/following{/other_user}","gists_url":"https://api.github.com/users/jwillia/gists{/gist_id}","starred_url":"https://api.github.com/users/jwillia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwillia/subscriptions","organizations_url":"https://api.github.com/users/jwillia/orgs","repos_url":"https://api.github.com/users/jwillia/repos","events_url":"https://api.github.com/users/jwillia/events{/privacy}","received_events_url":"https://api.github.com/users/jwillia/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-02-13T20:08:07Z","updated_at":"2015-02-16T19:34:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe3dcd3f519a5157c74d00ee98b7b20826333747","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KualiCo/kc/pulls/48/commits","review_comments_url":"https://api.github.com/repos/KualiCo/kc/pulls/48/comments","review_comment_url":"https://api.github.com/repos/KualiCo/kc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/KualiCo/kc/issues/48/comments","statuses_url":"https://api.github.com/repos/KualiCo/kc/statuses/fa41e806e893616e1786241fe738220759ca408f","head":{"label":"jwillia:KRACOEUS_8840_1","ref":"KRACOEUS_8840_1","sha":"fa41e806e893616e1786241fe738220759ca408f","user":{"login":"jwillia","id":7320896,"avatar_url":"https://avatars.githubusercontent.com/u/7320896?v=3","gravatar_id":"","url":"https://api.github.com/users/jwillia","html_url":"https://github.com/jwillia","followers_url":"https://api.github.com/users/jwillia/followers","following_url":"https://api.github.com/users/jwillia/following{/other_user}","gists_url":"https://api.github.com/users/jwillia/gists{/gist_id}","starred_url":"https://api.github.com/users/jwillia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwillia/subscriptions","organizations_url":"https://api.github.com/users/jwillia/orgs","repos_url":"https://api.github.com/users/jwillia/repos","events_url":"https://api.github.com/users/jwillia/events{/privacy}","received_events_url":"https://api.github.com/users/jwillia/received_events","type":"User","site_admin":false},"repo":{"id":30763832,"name":"kc","full_name":"jwillia/kc","owner":{"login":"jwillia","id":7320896,"avatar_url":"https://avatars.githubusercontent.com/u/7320896?v=3","gravatar_id":"","url":"https://api.github.com/users/jwillia","html_url":"https://github.com/jwillia","followers_url":"https://api.github.com/users/jwillia/followers","following_url":"https://api.github.com/users/jwillia/following{/other_user}","gists_url":"https://api.github.com/users/jwillia/gists{/gist_id}","starred_url":"https://api.github.com/users/jwillia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwillia/subscriptions","organizations_url":"https://api.github.com/users/jwillia/orgs","repos_url":"https://api.github.com/users/jwillia/repos","events_url":"https://api.github.com/users/jwillia/events{/privacy}","received_events_url":"https://api.github.com/users/jwillia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jwillia/kc","description":"Kuali Coeus","fork":true,"url":"https://api.github.com/repos/jwillia/kc","forks_url":"https://api.github.com/repos/jwillia/kc/forks","keys_url":"https://api.github.com/repos/jwillia/kc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwillia/kc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwillia/kc/teams","hooks_url":"https://api.github.com/repos/jwillia/kc/hooks","issue_events_url":"https://api.github.com/repos/jwillia/kc/issues/events{/number}","events_url":"https://api.github.com/repos/jwillia/kc/events","assignees_url":"https://api.github.com/repos/jwillia/kc/assignees{/user}","branches_url":"https://api.github.com/repos/jwillia/kc/branches{/branch}","tags_url":"https://api.github.com/repos/jwillia/kc/tags","blobs_url":"https://api.github.com/repos/jwillia/kc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwillia/kc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwillia/kc/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwillia/kc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwillia/kc/statuses/{sha}","languages_url":"https://api.github.com/repos/jwillia/kc/languages","stargazers_url":"https://api.github.com/repos/jwillia/kc/stargazers","contributors_url":"https://api.github.com/repos/jwillia/kc/contributors","subscribers_url":"https://api.github.com/repos/jwillia/kc/subscribers","subscription_url":"https://api.github.com/repos/jwillia/kc/subscription","commits_url":"https://api.github.com/repos/jwillia/kc/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwillia/kc/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwillia/kc/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwillia/kc/issues/comments/{number}","contents_url":"https://api.github.com/repos/jwillia/kc/contents/{+path}","compare_url":"https://api.github.com/repos/jwillia/kc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwillia/kc/merges","archive_url":"https://api.github.com/repos/jwillia/kc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwillia/kc/downloads","issues_url":"https://api.github.com/repos/jwillia/kc/issues{/number}","pulls_url":"https://api.github.com/repos/jwillia/kc/pulls{/number}","milestones_url":"https://api.github.com/repos/jwillia/kc/milestones{/number}","notifications_url":"https://api.github.com/repos/jwillia/kc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwillia/kc/labels{/name}","releases_url":"https://api.github.com/repos/jwillia/kc/releases{/id}","created_at":"2015-02-13T16:05:36Z","updated_at":"2015-02-13T16:30:46Z","pushed_at":"2015-02-16T15:26:12Z","git_url":"git://github.com/jwillia/kc.git","ssh_url":"git@github.com:jwillia/kc.git","clone_url":"https://github.com/jwillia/kc.git","svn_url":"https://github.com/jwillia/kc","homepage":"http://www.kuali.org/kc","size":387710,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KualiCo:master","ref":"master","sha":"f42892cb7d4f01b3cd6ceba97b2f56b6364aeb02","user":{"login":"KualiCo","id":8756237,"avatar_url":"https://avatars.githubusercontent.com/u/8756237?v=3","gravatar_id":"","url":"https://api.github.com/users/KualiCo","html_url":"https://github.com/KualiCo","followers_url":"https://api.github.com/users/KualiCo/followers","following_url":"https://api.github.com/users/KualiCo/following{/other_user}","gists_url":"https://api.github.com/users/KualiCo/gists{/gist_id}","starred_url":"https://api.github.com/users/KualiCo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KualiCo/subscriptions","organizations_url":"https://api.github.com/users/KualiCo/orgs","repos_url":"https://api.github.com/users/KualiCo/repos","events_url":"https://api.github.com/users/KualiCo/events{/privacy}","received_events_url":"https://api.github.com/users/KualiCo/received_events","type":"Organization","site_admin":false},"repo":{"id":30315971,"name":"kc","full_name":"KualiCo/kc","owner":{"login":"KualiCo","id":8756237,"avatar_url":"https://avatars.githubusercontent.com/u/8756237?v=3","gravatar_id":"","url":"https://api.github.com/users/KualiCo","html_url":"https://github.com/KualiCo","followers_url":"https://api.github.com/users/KualiCo/followers","following_url":"https://api.github.com/users/KualiCo/following{/other_user}","gists_url":"https://api.github.com/users/KualiCo/gists{/gist_id}","starred_url":"https://api.github.com/users/KualiCo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KualiCo/subscriptions","organizations_url":"https://api.github.com/users/KualiCo/orgs","repos_url":"https://api.github.com/users/KualiCo/repos","events_url":"https://api.github.com/users/KualiCo/events{/privacy}","received_events_url":"https://api.github.com/users/KualiCo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KualiCo/kc","description":"Kuali Coeus","fork":false,"url":"https://api.github.com/repos/KualiCo/kc","forks_url":"https://api.github.com/repos/KualiCo/kc/forks","keys_url":"https://api.github.com/repos/KualiCo/kc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KualiCo/kc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KualiCo/kc/teams","hooks_url":"https://api.github.com/repos/KualiCo/kc/hooks","issue_events_url":"https://api.github.com/repos/KualiCo/kc/issues/events{/number}","events_url":"https://api.github.com/repos/KualiCo/kc/events","assignees_url":"https://api.github.com/repos/KualiCo/kc/assignees{/user}","branches_url":"https://api.github.com/repos/KualiCo/kc/branches{/branch}","tags_url":"https://api.github.com/repos/KualiCo/kc/tags","blobs_url":"https://api.github.com/repos/KualiCo/kc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KualiCo/kc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KualiCo/kc/git/refs{/sha}","trees_url":"https://api.github.com/repos/KualiCo/kc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KualiCo/kc/statuses/{sha}","languages_url":"https://api.github.com/repos/KualiCo/kc/languages","stargazers_url":"https://api.github.com/repos/KualiCo/kc/stargazers","contributors_url":"https://api.github.com/repos/KualiCo/kc/contributors","subscribers_url":"https://api.github.com/repos/KualiCo/kc/subscribers","subscription_url":"https://api.github.com/repos/KualiCo/kc/subscription","commits_url":"https://api.github.com/repos/KualiCo/kc/commits{/sha}","git_commits_url":"https://api.github.com/repos/KualiCo/kc/git/commits{/sha}","comments_url":"https://api.github.com/repos/KualiCo/kc/comments{/number}","issue_comment_url":"https://api.github.com/repos/KualiCo/kc/issues/comments/{number}","contents_url":"https://api.github.com/repos/KualiCo/kc/contents/{+path}","compare_url":"https://api.github.com/repos/KualiCo/kc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KualiCo/kc/merges","archive_url":"https://api.github.com/repos/KualiCo/kc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KualiCo/kc/downloads","issues_url":"https://api.github.com/repos/KualiCo/kc/issues{/number}","pulls_url":"https://api.github.com/repos/KualiCo/kc/pulls{/number}","milestones_url":"https://api.github.com/repos/KualiCo/kc/milestones{/number}","notifications_url":"https://api.github.com/repos/KualiCo/kc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KualiCo/kc/labels{/name}","releases_url":"https://api.github.com/repos/KualiCo/kc/releases{/id}","created_at":"2015-02-04T19:11:49Z","updated_at":"2015-02-16T19:32:55Z","pushed_at":"2015-02-16T19:32:55Z","git_url":"git://github.com/KualiCo/kc.git","ssh_url":"git@github.com:KualiCo/kc.git","clone_url":"https://github.com/KualiCo/kc.git","svn_url":"https://github.com/KualiCo/kc","homepage":"http://www.kuali.org/kc","size":387710,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":6,"forks":4,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KualiCo/kc/pulls/48"},"html":{"href":"https://github.com/KualiCo/kc/pull/48"},"issue":{"href":"https://api.github.com/repos/KualiCo/kc/issues/48"},"comments":{"href":"https://api.github.com/repos/KualiCo/kc/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/KualiCo/kc/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/KualiCo/kc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/KualiCo/kc/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/KualiCo/kc/statuses/fa41e806e893616e1786241fe738220759ca408f"}}}}