{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/pulls/comments/39278774","id":39278774,"diff_hunk":"@@ -152,6 +152,13 @@ def self.title_patterns\n         ]\n       ],\n       [\n+        /^(.*):([a-z]:(\\/|\\\\).*)$/i,","path":"lib/puppet/type/java_ks.rb","position":4,"original_position":4,"commit_id":"fb36fe10b33c693367de4335c37071d8632fc30c","original_commit_id":"fb36fe10b33c693367de4335c37071d8632fc30c","user":{"login":"DavidS","id":27712,"avatar_url":"https://avatars.githubusercontent.com/u/27712?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidS","html_url":"https://github.com/DavidS","followers_url":"https://api.github.com/users/DavidS/followers","following_url":"https://api.github.com/users/DavidS/following{/other_user}","gists_url":"https://api.github.com/users/DavidS/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidS/subscriptions","organizations_url":"https://api.github.com/users/DavidS/orgs","repos_url":"https://api.github.com/users/DavidS/repos","events_url":"https://api.github.com/users/DavidS/events{/privacy}","received_events_url":"https://api.github.com/users/DavidS/received_events","type":"User","site_admin":false},"body":"wouldn't it be enough to have `/^(.)/` or `(.?)` if the letter is really optional?","created_at":"2015-09-11T14:51:56Z","updated_at":"2015-09-11T14:51:56Z","html_url":"https://github.com/puppetlabs/puppetlabs-java_ks/pull/131#discussion_r39278774","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/pulls/131","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/pulls/comments/39278774"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-java_ks/pull/131#discussion_r39278774"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/pulls/131"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/pulls/131","id":44749974,"html_url":"https://github.com/puppetlabs/puppetlabs-java_ks/pull/131","diff_url":"https://github.com/puppetlabs/puppetlabs-java_ks/pull/131.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-java_ks/pull/131.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/issues/131","number":131,"state":"open","locked":false,"title":"(MODULES-2561) resolve title properly when on windows","user":{"login":"cyberious","id":1703710,"avatar_url":"https://avatars.githubusercontent.com/u/1703710?v=3","gravatar_id":"","url":"https://api.github.com/users/cyberious","html_url":"https://github.com/cyberious","followers_url":"https://api.github.com/users/cyberious/followers","following_url":"https://api.github.com/users/cyberious/following{/other_user}","gists_url":"https://api.github.com/users/cyberious/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberious/subscriptions","organizations_url":"https://api.github.com/users/cyberious/orgs","repos_url":"https://api.github.com/users/cyberious/repos","events_url":"https://api.github.com/users/cyberious/events{/privacy}","received_events_url":"https://api.github.com/users/cyberious/received_events","type":"User","site_admin":false},"body":"- Lambda expression match was not restrictive enough to\n  match properly for windows and was splitting on second ':'\n  and not the first, this addes a new pattern match for windows\n  that expects a letter based path in the title i.e. 'C:\\tmp'","created_at":"2015-09-11T06:22:05Z","updated_at":"2015-09-11T14:51:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"671b00099acfe2bd659ed0f813bed530a03946a4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/pulls/131/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/pulls/131/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/issues/131/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/statuses/fb36fe10b33c693367de4335c37071d8632fc30c","head":{"label":"cyberious:master","ref":"master","sha":"fb36fe10b33c693367de4335c37071d8632fc30c","user":{"login":"cyberious","id":1703710,"avatar_url":"https://avatars.githubusercontent.com/u/1703710?v=3","gravatar_id":"","url":"https://api.github.com/users/cyberious","html_url":"https://github.com/cyberious","followers_url":"https://api.github.com/users/cyberious/followers","following_url":"https://api.github.com/users/cyberious/following{/other_user}","gists_url":"https://api.github.com/users/cyberious/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberious/subscriptions","organizations_url":"https://api.github.com/users/cyberious/orgs","repos_url":"https://api.github.com/users/cyberious/repos","events_url":"https://api.github.com/users/cyberious/events{/privacy}","received_events_url":"https://api.github.com/users/cyberious/received_events","type":"User","site_admin":false},"repo":{"id":21838065,"name":"puppetlabs-java_ks","full_name":"cyberious/puppetlabs-java_ks","owner":{"login":"cyberious","id":1703710,"avatar_url":"https://avatars.githubusercontent.com/u/1703710?v=3","gravatar_id":"","url":"https://api.github.com/users/cyberious","html_url":"https://github.com/cyberious","followers_url":"https://api.github.com/users/cyberious/followers","following_url":"https://api.github.com/users/cyberious/following{/other_user}","gists_url":"https://api.github.com/users/cyberious/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberious/subscriptions","organizations_url":"https://api.github.com/users/cyberious/orgs","repos_url":"https://api.github.com/users/cyberious/repos","events_url":"https://api.github.com/users/cyberious/events{/privacy}","received_events_url":"https://api.github.com/users/cyberious/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cyberious/puppetlabs-java_ks","description":"","fork":true,"url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks","forks_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/forks","keys_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/teams","hooks_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/hooks","issue_events_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/issues/events{/number}","events_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/events","assignees_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/assignees{/user}","branches_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/branches{/branch}","tags_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/tags","blobs_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/statuses/{sha}","languages_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/languages","stargazers_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/stargazers","contributors_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/contributors","subscribers_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/subscribers","subscription_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/subscription","commits_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/contents/{+path}","compare_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/merges","archive_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/downloads","issues_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/issues{/number}","pulls_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/pulls{/number}","milestones_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/milestones{/number}","notifications_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/labels{/name}","releases_url":"https://api.github.com/repos/cyberious/puppetlabs-java_ks/releases{/id}","created_at":"2014-07-14T22:33:43Z","updated_at":"2015-07-20T16:53:01Z","pushed_at":"2015-09-11T06:21:56Z","git_url":"git://github.com/cyberious/puppetlabs-java_ks.git","ssh_url":"git@github.com:cyberious/puppetlabs-java_ks.git","clone_url":"https://github.com/cyberious/puppetlabs-java_ks.git","svn_url":"https://github.com/cyberious/puppetlabs-java_ks","homepage":null,"size":379,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"3323cf62cde4ecee8bf360787ee2b11e8ae18140","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":4138213,"name":"puppetlabs-java_ks","full_name":"puppetlabs/puppetlabs-java_ks","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-java_ks","description":"","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/releases{/id}","created_at":"2012-04-25T15:40:34Z","updated_at":"2015-05-07T21:09:29Z","pushed_at":"2015-09-11T06:22:06Z","git_url":"git://github.com/puppetlabs/puppetlabs-java_ks.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-java_ks.git","clone_url":"https://github.com/puppetlabs/puppetlabs-java_ks.git","svn_url":"https://github.com/puppetlabs/puppetlabs-java_ks","homepage":null,"size":1089,"stargazers_count":20,"watchers_count":20,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":7,"forks":45,"open_issues":7,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/pulls/131"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-java_ks/pull/131"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/issues/131"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-java_ks/statuses/fb36fe10b33c693367de4335c37071d8632fc30c"}}}}