{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rfcs/issues/1102","labels_url":"https://api.github.com/repos/rust-lang/rfcs/issues/1102/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rfcs/issues/1102/comments","events_url":"https://api.github.com/repos/rust-lang/rfcs/issues/1102/events","html_url":"https://github.com/rust-lang/rfcs/pull/1102","id":72629615,"number":1102,"title":"Rename connect to join","user":{"login":"barosl","id":573768,"avatar_url":"https://avatars.githubusercontent.com/u/573768?v=3","gravatar_id":"","url":"https://api.github.com/users/barosl","html_url":"https://github.com/barosl","followers_url":"https://api.github.com/users/barosl/followers","following_url":"https://api.github.com/users/barosl/following{/other_user}","gists_url":"https://api.github.com/users/barosl/gists{/gist_id}","starred_url":"https://api.github.com/users/barosl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barosl/subscriptions","organizations_url":"https://api.github.com/users/barosl/orgs","repos_url":"https://api.github.com/users/barosl/repos","events_url":"https://api.github.com/users/barosl/events{/privacy}","received_events_url":"https://api.github.com/users/barosl/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rust-lang/rfcs/labels/final-comment-period","name":"final-comment-period","color":"207de5"},{"url":"https://api.github.com/repos/rust-lang/rfcs/labels/T-libs","name":"T-libs","color":"bfd4f2"}],"state":"open","locked":false,"assignee":{"login":"aturon","id":709807,"avatar_url":"https://avatars.githubusercontent.com/u/709807?v=3","gravatar_id":"","url":"https://api.github.com/users/aturon","html_url":"https://github.com/aturon","followers_url":"https://api.github.com/users/aturon/followers","following_url":"https://api.github.com/users/aturon/following{/other_user}","gists_url":"https://api.github.com/users/aturon/gists{/gist_id}","starred_url":"https://api.github.com/users/aturon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aturon/subscriptions","organizations_url":"https://api.github.com/users/aturon/orgs","repos_url":"https://api.github.com/users/aturon/repos","events_url":"https://api.github.com/users/aturon/events{/privacy}","received_events_url":"https://api.github.com/users/aturon/received_events","type":"User","site_admin":false},"milestone":null,"comments":33,"created_at":"2015-05-02T10:51:16Z","updated_at":"2015-06-21T23:45:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rfcs/pulls/1102","html_url":"https://github.com/rust-lang/rfcs/pull/1102","diff_url":"https://github.com/rust-lang/rfcs/pull/1102.diff","patch_url":"https://github.com/rust-lang/rfcs/pull/1102.patch"},"body":"[Kawaii version](https://github.com/barosl/rust-rfcs/blob/rename-connect-to-join/text/0000-rename-connect-to-join.md)\r\n\r\nRelated Rust issue: rust-lang/rust#24645"},"comment":{"url":"https://api.github.com/repos/rust-lang/rfcs/issues/comments/113969329","html_url":"https://github.com/rust-lang/rfcs/pull/1102#issuecomment-113969329","issue_url":"https://api.github.com/repos/rust-lang/rfcs/issues/1102","id":113969329,"user":{"login":"bluss","id":3209739,"avatar_url":"https://avatars.githubusercontent.com/u/3209739?v=3","gravatar_id":"","url":"https://api.github.com/users/bluss","html_url":"https://github.com/bluss","followers_url":"https://api.github.com/users/bluss/followers","following_url":"https://api.github.com/users/bluss/following{/other_user}","gists_url":"https://api.github.com/users/bluss/gists{/gist_id}","starred_url":"https://api.github.com/users/bluss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluss/subscriptions","organizations_url":"https://api.github.com/users/bluss/orgs","repos_url":"https://api.github.com/users/bluss/repos","events_url":"https://api.github.com/users/bluss/events{/privacy}","received_events_url":"https://api.github.com/users/bluss/received_events","type":"User","site_admin":false},"created_at":"2015-06-21T23:45:23Z","updated_at":"2015-06-21T23:45:23Z","body":"@sfackler When slices already are present, it's a great advantage to use that, because the implementations walk them twice, once to compute the exact space needed and once to do the concatenation.\r\n\r\nWhen the slice is already present this is much superior, and it might even be more performant even when including a collect, depending on the number and length of the strings.\r\n\r\nSo that's the benefit of slices, that doesn't preclude a method on iterators too. We absolutely should opt for consistency though — I'm in favour of .connect() on an iterator if that's the name that stays."}}