{"action":"created","issue":{"url":"https://api.github.com/repos/addyosmani/critical/issues/53","labels_url":"https://api.github.com/repos/addyosmani/critical/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/addyosmani/critical/issues/53/comments","events_url":"https://api.github.com/repos/addyosmani/critical/issues/53/events","html_url":"https://github.com/addyosmani/critical/issues/53","id":51202546,"number":53,"title":"simplify usage of critical","user":{"login":"bezoerb","id":1697800,"avatar_url":"https://avatars.githubusercontent.com/u/1697800?v=3","gravatar_id":"","url":"https://api.github.com/users/bezoerb","html_url":"https://github.com/bezoerb","followers_url":"https://api.github.com/users/bezoerb/followers","following_url":"https://api.github.com/users/bezoerb/following{/other_user}","gists_url":"https://api.github.com/users/bezoerb/gists{/gist_id}","starred_url":"https://api.github.com/users/bezoerb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bezoerb/subscriptions","organizations_url":"https://api.github.com/users/bezoerb/orgs","repos_url":"https://api.github.com/users/bezoerb/repos","events_url":"https://api.github.com/users/bezoerb/events{/privacy}","received_events_url":"https://api.github.com/users/bezoerb/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/addyosmani/critical/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2014-12-07T00:41:24Z","updated_at":"2015-04-19T22:15:56Z","closed_at":null,"body":"@addyosmani \r\nWhile implementing some tests for the CLI i've stumbled across parameter inconsistence between `generate` and `generateInline`. For `generateInline`we use `styleTarget` and `htmlTarget` and for `generate`we only use `dest`. This could be a bit confusing.\r\nMaybe we should consider deprecating the options `styleTarget` and `htmlTarget` in favor of just using `dest` and and select the right task based upon the filetype\r\n* html: generateInline\r\n* css: generate\r\n\r\nWith this is mind we could also strip down `generate`and `generateInline` because then only one public method is needed for either generate and inline to produce html or for just generating the critical css. What do you think? "},"comment":{"url":"https://api.github.com/repos/addyosmani/critical/issues/comments/94319172","html_url":"https://github.com/addyosmani/critical/issues/53#issuecomment-94319172","issue_url":"https://api.github.com/repos/addyosmani/critical/issues/53","id":94319172,"user":{"login":"bezoerb","id":1697800,"avatar_url":"https://avatars.githubusercontent.com/u/1697800?v=3","gravatar_id":"","url":"https://api.github.com/users/bezoerb","html_url":"https://github.com/bezoerb","followers_url":"https://api.github.com/users/bezoerb/followers","following_url":"https://api.github.com/users/bezoerb/following{/other_user}","gists_url":"https://api.github.com/users/bezoerb/gists{/gist_id}","starred_url":"https://api.github.com/users/bezoerb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bezoerb/subscriptions","organizations_url":"https://api.github.com/users/bezoerb/orgs","repos_url":"https://api.github.com/users/bezoerb/repos","events_url":"https://api.github.com/users/bezoerb/events{/privacy}","received_events_url":"https://api.github.com/users/bezoerb/received_events","type":"User","site_admin":false},"created_at":"2015-04-19T22:15:56Z","updated_at":"2015-04-19T22:15:56Z","body":"What about adding `inline` as an option for `generate`, deprecate `generateInline` and leave only the `dest` option.\r\nSo we would only expose the `generate` method and do inlining when the `inline` option is set.\r\n"}}