{"action":"opened","number":1080,"pull_request":{"url":"https://api.github.com/repos/yihui/knitr/pulls/1080","id":40785924,"html_url":"https://github.com/yihui/knitr/pull/1080","diff_url":"https://github.com/yihui/knitr/pull/1080.diff","patch_url":"https://github.com/yihui/knitr/pull/1080.patch","issue_url":"https://api.github.com/repos/yihui/knitr/issues/1080","number":1080,"state":"open","locked":false,"title":"cleanup expr handling","user":{"login":"aronatkins","id":362187,"avatar_url":"https://avatars.githubusercontent.com/u/362187?v=3","gravatar_id":"","url":"https://api.github.com/users/aronatkins","html_url":"https://github.com/aronatkins","followers_url":"https://api.github.com/users/aronatkins/followers","following_url":"https://api.github.com/users/aronatkins/following{/other_user}","gists_url":"https://api.github.com/users/aronatkins/gists{/gist_id}","starred_url":"https://api.github.com/users/aronatkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aronatkins/subscriptions","organizations_url":"https://api.github.com/users/aronatkins/orgs","repos_url":"https://api.github.com/users/aronatkins/repos","events_url":"https://api.github.com/users/aronatkins/events{/privacy}","received_events_url":"https://api.github.com/users/aronatkins/received_events","type":"User","site_admin":false},"body":"This fixes a problem where we were incorrectly calling `unlist` on values produced by expressions.\r\n\r\nHere is the old behavior:\r\n\r\n```\r\n> y <- yaml::yaml.load('k: !r strptime(\"2015-01-01\", format = \"%Y-%m-%d\")\\n', handlers = knitr:::knit_params_handlers(evaluate = TRUE))\r\n> r <- knitr:::resolve_params(y)\r\n> r$k$value\r\n   sec    min   hour   mday    mon   year   wday   yday  isdst   zone gmtoff \r\n   \"0\"    \"0\"    \"0\"    \"1\"    \"0\"  \"115\"    \"4\"    \"0\"    \"0\"  \"EST\"     NA \r\n> class(r$k$value)\r\n[1] \"character\"\r\n```\r\n\r\nAnd the new:\r\n\r\n```\r\n> y <- yaml::yaml.load('k: !r strptime(\"2015-01-01\", format = \"%Y-%m-%d\")\\n', handlers = knitr:::knit_params_handlers(evaluate = TRUE))\r\n> r <- knitr:::resolve_params(y)\r\n> r$k$value\r\n[1] \"2015-01-01 EST\"\r\n> class(r$k$value)\r\n[1] \"POSIXlt\" \"POSIXt\" \r\n```","created_at":"2015-07-24T15:22:39Z","updated_at":"2015-07-24T15:22:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c36c19cc2d346b6219ff76b3f55365b54dbf7f1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yihui/knitr/pulls/1080/commits","review_comments_url":"https://api.github.com/repos/yihui/knitr/pulls/1080/comments","review_comment_url":"https://api.github.com/repos/yihui/knitr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yihui/knitr/issues/1080/comments","statuses_url":"https://api.github.com/repos/yihui/knitr/statuses/3e7800952d68e2c22f89854548bedec7eb7eefad","head":{"label":"aronatkins:aron/cleanup-expr-handling","ref":"aron/cleanup-expr-handling","sha":"3e7800952d68e2c22f89854548bedec7eb7eefad","user":{"login":"aronatkins","id":362187,"avatar_url":"https://avatars.githubusercontent.com/u/362187?v=3","gravatar_id":"","url":"https://api.github.com/users/aronatkins","html_url":"https://github.com/aronatkins","followers_url":"https://api.github.com/users/aronatkins/followers","following_url":"https://api.github.com/users/aronatkins/following{/other_user}","gists_url":"https://api.github.com/users/aronatkins/gists{/gist_id}","starred_url":"https://api.github.com/users/aronatkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aronatkins/subscriptions","organizations_url":"https://api.github.com/users/aronatkins/orgs","repos_url":"https://api.github.com/users/aronatkins/repos","events_url":"https://api.github.com/users/aronatkins/events{/privacy}","received_events_url":"https://api.github.com/users/aronatkins/received_events","type":"User","site_admin":false},"repo":{"id":39510115,"name":"knitr","full_name":"aronatkins/knitr","owner":{"login":"aronatkins","id":362187,"avatar_url":"https://avatars.githubusercontent.com/u/362187?v=3","gravatar_id":"","url":"https://api.github.com/users/aronatkins","html_url":"https://github.com/aronatkins","followers_url":"https://api.github.com/users/aronatkins/followers","following_url":"https://api.github.com/users/aronatkins/following{/other_user}","gists_url":"https://api.github.com/users/aronatkins/gists{/gist_id}","starred_url":"https://api.github.com/users/aronatkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aronatkins/subscriptions","organizations_url":"https://api.github.com/users/aronatkins/orgs","repos_url":"https://api.github.com/users/aronatkins/repos","events_url":"https://api.github.com/users/aronatkins/events{/privacy}","received_events_url":"https://api.github.com/users/aronatkins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aronatkins/knitr","description":"A general-purpose tool for dynamic report generation in R","fork":true,"url":"https://api.github.com/repos/aronatkins/knitr","forks_url":"https://api.github.com/repos/aronatkins/knitr/forks","keys_url":"https://api.github.com/repos/aronatkins/knitr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aronatkins/knitr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aronatkins/knitr/teams","hooks_url":"https://api.github.com/repos/aronatkins/knitr/hooks","issue_events_url":"https://api.github.com/repos/aronatkins/knitr/issues/events{/number}","events_url":"https://api.github.com/repos/aronatkins/knitr/events","assignees_url":"https://api.github.com/repos/aronatkins/knitr/assignees{/user}","branches_url":"https://api.github.com/repos/aronatkins/knitr/branches{/branch}","tags_url":"https://api.github.com/repos/aronatkins/knitr/tags","blobs_url":"https://api.github.com/repos/aronatkins/knitr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aronatkins/knitr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aronatkins/knitr/git/refs{/sha}","trees_url":"https://api.github.com/repos/aronatkins/knitr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aronatkins/knitr/statuses/{sha}","languages_url":"https://api.github.com/repos/aronatkins/knitr/languages","stargazers_url":"https://api.github.com/repos/aronatkins/knitr/stargazers","contributors_url":"https://api.github.com/repos/aronatkins/knitr/contributors","subscribers_url":"https://api.github.com/repos/aronatkins/knitr/subscribers","subscription_url":"https://api.github.com/repos/aronatkins/knitr/subscription","commits_url":"https://api.github.com/repos/aronatkins/knitr/commits{/sha}","git_commits_url":"https://api.github.com/repos/aronatkins/knitr/git/commits{/sha}","comments_url":"https://api.github.com/repos/aronatkins/knitr/comments{/number}","issue_comment_url":"https://api.github.com/repos/aronatkins/knitr/issues/comments{/number}","contents_url":"https://api.github.com/repos/aronatkins/knitr/contents/{+path}","compare_url":"https://api.github.com/repos/aronatkins/knitr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aronatkins/knitr/merges","archive_url":"https://api.github.com/repos/aronatkins/knitr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aronatkins/knitr/downloads","issues_url":"https://api.github.com/repos/aronatkins/knitr/issues{/number}","pulls_url":"https://api.github.com/repos/aronatkins/knitr/pulls{/number}","milestones_url":"https://api.github.com/repos/aronatkins/knitr/milestones{/number}","notifications_url":"https://api.github.com/repos/aronatkins/knitr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aronatkins/knitr/labels{/name}","releases_url":"https://api.github.com/repos/aronatkins/knitr/releases{/id}","created_at":"2015-07-22T14:14:56Z","updated_at":"2015-07-22T14:14:57Z","pushed_at":"2015-07-24T15:18:41Z","git_url":"git://github.com/aronatkins/knitr.git","ssh_url":"git@github.com:aronatkins/knitr.git","clone_url":"https://github.com/aronatkins/knitr.git","svn_url":"https://github.com/aronatkins/knitr","homepage":"http://yihui.name/knitr","size":10721,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yihui:master","ref":"master","sha":"560c398f33ff98fc4a86ac2f55d5147950b63a9f","user":{"login":"yihui","id":163582,"avatar_url":"https://avatars.githubusercontent.com/u/163582?v=3","gravatar_id":"","url":"https://api.github.com/users/yihui","html_url":"https://github.com/yihui","followers_url":"https://api.github.com/users/yihui/followers","following_url":"https://api.github.com/users/yihui/following{/other_user}","gists_url":"https://api.github.com/users/yihui/gists{/gist_id}","starred_url":"https://api.github.com/users/yihui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yihui/subscriptions","organizations_url":"https://api.github.com/users/yihui/orgs","repos_url":"https://api.github.com/users/yihui/repos","events_url":"https://api.github.com/users/yihui/events{/privacy}","received_events_url":"https://api.github.com/users/yihui/received_events","type":"User","site_admin":false},"repo":{"id":2594513,"name":"knitr","full_name":"yihui/knitr","owner":{"login":"yihui","id":163582,"avatar_url":"https://avatars.githubusercontent.com/u/163582?v=3","gravatar_id":"","url":"https://api.github.com/users/yihui","html_url":"https://github.com/yihui","followers_url":"https://api.github.com/users/yihui/followers","following_url":"https://api.github.com/users/yihui/following{/other_user}","gists_url":"https://api.github.com/users/yihui/gists{/gist_id}","starred_url":"https://api.github.com/users/yihui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yihui/subscriptions","organizations_url":"https://api.github.com/users/yihui/orgs","repos_url":"https://api.github.com/users/yihui/repos","events_url":"https://api.github.com/users/yihui/events{/privacy}","received_events_url":"https://api.github.com/users/yihui/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yihui/knitr","description":"A general-purpose tool for dynamic report generation in R","fork":false,"url":"https://api.github.com/repos/yihui/knitr","forks_url":"https://api.github.com/repos/yihui/knitr/forks","keys_url":"https://api.github.com/repos/yihui/knitr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yihui/knitr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yihui/knitr/teams","hooks_url":"https://api.github.com/repos/yihui/knitr/hooks","issue_events_url":"https://api.github.com/repos/yihui/knitr/issues/events{/number}","events_url":"https://api.github.com/repos/yihui/knitr/events","assignees_url":"https://api.github.com/repos/yihui/knitr/assignees{/user}","branches_url":"https://api.github.com/repos/yihui/knitr/branches{/branch}","tags_url":"https://api.github.com/repos/yihui/knitr/tags","blobs_url":"https://api.github.com/repos/yihui/knitr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yihui/knitr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yihui/knitr/git/refs{/sha}","trees_url":"https://api.github.com/repos/yihui/knitr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yihui/knitr/statuses/{sha}","languages_url":"https://api.github.com/repos/yihui/knitr/languages","stargazers_url":"https://api.github.com/repos/yihui/knitr/stargazers","contributors_url":"https://api.github.com/repos/yihui/knitr/contributors","subscribers_url":"https://api.github.com/repos/yihui/knitr/subscribers","subscription_url":"https://api.github.com/repos/yihui/knitr/subscription","commits_url":"https://api.github.com/repos/yihui/knitr/commits{/sha}","git_commits_url":"https://api.github.com/repos/yihui/knitr/git/commits{/sha}","comments_url":"https://api.github.com/repos/yihui/knitr/comments{/number}","issue_comment_url":"https://api.github.com/repos/yihui/knitr/issues/comments{/number}","contents_url":"https://api.github.com/repos/yihui/knitr/contents/{+path}","compare_url":"https://api.github.com/repos/yihui/knitr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yihui/knitr/merges","archive_url":"https://api.github.com/repos/yihui/knitr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yihui/knitr/downloads","issues_url":"https://api.github.com/repos/yihui/knitr/issues{/number}","pulls_url":"https://api.github.com/repos/yihui/knitr/pulls{/number}","milestones_url":"https://api.github.com/repos/yihui/knitr/milestones{/number}","notifications_url":"https://api.github.com/repos/yihui/knitr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yihui/knitr/labels{/name}","releases_url":"https://api.github.com/repos/yihui/knitr/releases{/id}","created_at":"2011-10-17T20:09:04Z","updated_at":"2015-07-24T06:21:45Z","pushed_at":"2015-07-24T15:22:39Z","git_url":"git://github.com/yihui/knitr.git","ssh_url":"git@github.com:yihui/knitr.git","clone_url":"https://github.com/yihui/knitr.git","svn_url":"https://github.com/yihui/knitr","homepage":"http://yihui.name/knitr","size":10721,"stargazers_count":966,"watchers_count":966,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":430,"mirror_url":null,"open_issues_count":22,"forks":430,"open_issues":22,"watchers":966,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yihui/knitr/pulls/1080"},"html":{"href":"https://github.com/yihui/knitr/pull/1080"},"issue":{"href":"https://api.github.com/repos/yihui/knitr/issues/1080"},"comments":{"href":"https://api.github.com/repos/yihui/knitr/issues/1080/comments"},"review_comments":{"href":"https://api.github.com/repos/yihui/knitr/pulls/1080/comments"},"review_comment":{"href":"https://api.github.com/repos/yihui/knitr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yihui/knitr/pulls/1080/commits"},"statuses":{"href":"https://api.github.com/repos/yihui/knitr/statuses/3e7800952d68e2c22f89854548bedec7eb7eefad"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":33,"deletions":38,"changed_files":2}}