{"action":"created","comment":{"url":"https://api.github.com/repos/balderdashy/sails/pulls/comments/27348211","id":27348211,"diff_hunk":"@@ -86,8 +86,9 @@ describe('CORS and CSRF ::', function() {\n             url: 'test',\n           }, function(err, response) {\n             if (err) return done(new Error(err));\n+            body = response.body.split(',').sort().join(',');\n             assert.equal(response.statusCode, 200);\n-            assert.equal(response.body, \"GET,POST,PUT,HEAD,DELETE,TRACE,COPY,LOCK,MKCOL,MOVE,PURGE,PROPFIND,PROPPATCH,UNLOCK,REPORT,MKACTIVITY,CHECKOUT,MERGE,M-SEARCH,NOTIFY,SUBSCRIBE,UNSUBSCRIBE,PATCH,SEARCH,CONNECT\", require('util').format('Unexpected HTTP methods:  \"%s\"', response.body));\n+            assert.equal(body, 'CHECKOUT,CONNECT,COPY,DELETE,GET,HEAD,LOCK,M-SEARCH,MERGE,MKACTIVITY,MKCOL,MOVE,NOTIFY,PATCH,POST,PROPFIND,PROPPATCH,PURGE,PUT,REPORT,SEARCH,SUBSCRIBE,TRACE,UNLOCK,UNSUBSCRIBE', require('util').format('Unexpected HTTP methods:  \"%s\"', response.body));\n             done();","path":"test/integration/hook.cors_csrf.test.js","position":8,"original_position":8,"commit_id":"34df2277af50a4b2013ca8cd055000024af15ca1","original_commit_id":"34df2277af50a4b2013ca8cd055000024af15ca1","user":{"login":"tjwebb","id":1009114,"avatar_url":"https://avatars.githubusercontent.com/u/1009114?v=3","gravatar_id":"","url":"https://api.github.com/users/tjwebb","html_url":"https://github.com/tjwebb","followers_url":"https://api.github.com/users/tjwebb/followers","following_url":"https://api.github.com/users/tjwebb/following{/other_user}","gists_url":"https://api.github.com/users/tjwebb/gists{/gist_id}","starred_url":"https://api.github.com/users/tjwebb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjwebb/subscriptions","organizations_url":"https://api.github.com/users/tjwebb/orgs","repos_url":"https://api.github.com/users/tjwebb/repos","events_url":"https://api.github.com/users/tjwebb/events{/privacy}","received_events_url":"https://api.github.com/users/tjwebb/received_events","type":"User","site_admin":false},"body":"Even better would be to use `_.contains`. Now won't it fail for pre-iojs versions?","created_at":"2015-03-28T20:31:41Z","updated_at":"2015-03-28T20:31:41Z","html_url":"https://github.com/balderdashy/sails/pull/2792#discussion_r27348211","pull_request_url":"https://api.github.com/repos/balderdashy/sails/pulls/2792","_links":{"self":{"href":"https://api.github.com/repos/balderdashy/sails/pulls/comments/27348211"},"html":{"href":"https://github.com/balderdashy/sails/pull/2792#discussion_r27348211"},"pull_request":{"href":"https://api.github.com/repos/balderdashy/sails/pulls/2792"}}},"pull_request":{"url":"https://api.github.com/repos/balderdashy/sails/pulls/2792","id":32170607,"html_url":"https://github.com/balderdashy/sails/pull/2792","diff_url":"https://github.com/balderdashy/sails/pull/2792.diff","patch_url":"https://github.com/balderdashy/sails/pull/2792.patch","issue_url":"https://api.github.com/repos/balderdashy/sails/issues/2792","number":2792,"state":"open","locked":false,"title":"Make sails compilable under io.js and pass the current test suite","user":{"login":"serjrd","id":4756825,"avatar_url":"https://avatars.githubusercontent.com/u/4756825?v=3","gravatar_id":"","url":"https://api.github.com/users/serjrd","html_url":"https://github.com/serjrd","followers_url":"https://api.github.com/users/serjrd/followers","following_url":"https://api.github.com/users/serjrd/following{/other_user}","gists_url":"https://api.github.com/users/serjrd/gists{/gist_id}","starred_url":"https://api.github.com/users/serjrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serjrd/subscriptions","organizations_url":"https://api.github.com/users/serjrd/orgs","repos_url":"https://api.github.com/users/serjrd/repos","events_url":"https://api.github.com/users/serjrd/events{/privacy}","received_events_url":"https://api.github.com/users/serjrd/received_events","type":"User","site_admin":false},"body":"Today I decided to give io.js (v1.6.2) a try.\r\n\r\nMy project seems to be working fine, so I decided to run an `npm test` to test sails.\r\nThe issues I found were really very minor:\r\n\r\n- microtime devDep v0.6.0 didn't compile right under io.js, so I updated it to the latest version, which uses the same API\r\n- the HTTP OPTIONS string seems to be alphabetically sorted now, so I updated the tests accordingly (the supertest one could be done better though)\r\n\r\nHope this will be at least a minor help/thank you for making such a great project :)\r\n\r\nP.S.: Congratulations on getting 10000 stars! :)","created_at":"2015-03-28T20:24:40Z","updated_at":"2015-03-28T20:31:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39240a6f173b8ec9353400cdfa0cbb33c8230264","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/balderdashy/sails/pulls/2792/commits","review_comments_url":"https://api.github.com/repos/balderdashy/sails/pulls/2792/comments","review_comment_url":"https://api.github.com/repos/balderdashy/sails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/balderdashy/sails/issues/2792/comments","statuses_url":"https://api.github.com/repos/balderdashy/sails/statuses/34df2277af50a4b2013ca8cd055000024af15ca1","head":{"label":"serjrd:master","ref":"master","sha":"34df2277af50a4b2013ca8cd055000024af15ca1","user":{"login":"serjrd","id":4756825,"avatar_url":"https://avatars.githubusercontent.com/u/4756825?v=3","gravatar_id":"","url":"https://api.github.com/users/serjrd","html_url":"https://github.com/serjrd","followers_url":"https://api.github.com/users/serjrd/followers","following_url":"https://api.github.com/users/serjrd/following{/other_user}","gists_url":"https://api.github.com/users/serjrd/gists{/gist_id}","starred_url":"https://api.github.com/users/serjrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serjrd/subscriptions","organizations_url":"https://api.github.com/users/serjrd/orgs","repos_url":"https://api.github.com/users/serjrd/repos","events_url":"https://api.github.com/users/serjrd/events{/privacy}","received_events_url":"https://api.github.com/users/serjrd/received_events","type":"User","site_admin":false},"repo":{"id":33047876,"name":"sails","full_name":"serjrd/sails","owner":{"login":"serjrd","id":4756825,"avatar_url":"https://avatars.githubusercontent.com/u/4756825?v=3","gravatar_id":"","url":"https://api.github.com/users/serjrd","html_url":"https://github.com/serjrd","followers_url":"https://api.github.com/users/serjrd/followers","following_url":"https://api.github.com/users/serjrd/following{/other_user}","gists_url":"https://api.github.com/users/serjrd/gists{/gist_id}","starred_url":"https://api.github.com/users/serjrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serjrd/subscriptions","organizations_url":"https://api.github.com/users/serjrd/orgs","repos_url":"https://api.github.com/users/serjrd/repos","events_url":"https://api.github.com/users/serjrd/events{/privacy}","received_events_url":"https://api.github.com/users/serjrd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/serjrd/sails","description":"Realtime MVC Framework for Node.js","fork":true,"url":"https://api.github.com/repos/serjrd/sails","forks_url":"https://api.github.com/repos/serjrd/sails/forks","keys_url":"https://api.github.com/repos/serjrd/sails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serjrd/sails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serjrd/sails/teams","hooks_url":"https://api.github.com/repos/serjrd/sails/hooks","issue_events_url":"https://api.github.com/repos/serjrd/sails/issues/events{/number}","events_url":"https://api.github.com/repos/serjrd/sails/events","assignees_url":"https://api.github.com/repos/serjrd/sails/assignees{/user}","branches_url":"https://api.github.com/repos/serjrd/sails/branches{/branch}","tags_url":"https://api.github.com/repos/serjrd/sails/tags","blobs_url":"https://api.github.com/repos/serjrd/sails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serjrd/sails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serjrd/sails/git/refs{/sha}","trees_url":"https://api.github.com/repos/serjrd/sails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serjrd/sails/statuses/{sha}","languages_url":"https://api.github.com/repos/serjrd/sails/languages","stargazers_url":"https://api.github.com/repos/serjrd/sails/stargazers","contributors_url":"https://api.github.com/repos/serjrd/sails/contributors","subscribers_url":"https://api.github.com/repos/serjrd/sails/subscribers","subscription_url":"https://api.github.com/repos/serjrd/sails/subscription","commits_url":"https://api.github.com/repos/serjrd/sails/commits{/sha}","git_commits_url":"https://api.github.com/repos/serjrd/sails/git/commits{/sha}","comments_url":"https://api.github.com/repos/serjrd/sails/comments{/number}","issue_comment_url":"https://api.github.com/repos/serjrd/sails/issues/comments{/number}","contents_url":"https://api.github.com/repos/serjrd/sails/contents/{+path}","compare_url":"https://api.github.com/repos/serjrd/sails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serjrd/sails/merges","archive_url":"https://api.github.com/repos/serjrd/sails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serjrd/sails/downloads","issues_url":"https://api.github.com/repos/serjrd/sails/issues{/number}","pulls_url":"https://api.github.com/repos/serjrd/sails/pulls{/number}","milestones_url":"https://api.github.com/repos/serjrd/sails/milestones{/number}","notifications_url":"https://api.github.com/repos/serjrd/sails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serjrd/sails/labels{/name}","releases_url":"https://api.github.com/repos/serjrd/sails/releases{/id}","created_at":"2015-03-28T19:52:06Z","updated_at":"2015-03-28T20:02:47Z","pushed_at":"2015-03-28T20:02:46Z","git_url":"git://github.com/serjrd/sails.git","ssh_url":"git@github.com:serjrd/sails.git","clone_url":"https://github.com/serjrd/sails.git","svn_url":"https://github.com/serjrd/sails","homepage":"http://sailsjs.org","size":23869,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"balderdashy:master","ref":"master","sha":"92d7f345b74eb30e16b0f8d2142bcd251778e491","user":{"login":"balderdashy","id":1445252,"avatar_url":"https://avatars.githubusercontent.com/u/1445252?v=3","gravatar_id":"","url":"https://api.github.com/users/balderdashy","html_url":"https://github.com/balderdashy","followers_url":"https://api.github.com/users/balderdashy/followers","following_url":"https://api.github.com/users/balderdashy/following{/other_user}","gists_url":"https://api.github.com/users/balderdashy/gists{/gist_id}","starred_url":"https://api.github.com/users/balderdashy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balderdashy/subscriptions","organizations_url":"https://api.github.com/users/balderdashy/orgs","repos_url":"https://api.github.com/users/balderdashy/repos","events_url":"https://api.github.com/users/balderdashy/events{/privacy}","received_events_url":"https://api.github.com/users/balderdashy/received_events","type":"Organization","site_admin":false},"repo":{"id":3757512,"name":"sails","full_name":"balderdashy/sails","owner":{"login":"balderdashy","id":1445252,"avatar_url":"https://avatars.githubusercontent.com/u/1445252?v=3","gravatar_id":"","url":"https://api.github.com/users/balderdashy","html_url":"https://github.com/balderdashy","followers_url":"https://api.github.com/users/balderdashy/followers","following_url":"https://api.github.com/users/balderdashy/following{/other_user}","gists_url":"https://api.github.com/users/balderdashy/gists{/gist_id}","starred_url":"https://api.github.com/users/balderdashy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balderdashy/subscriptions","organizations_url":"https://api.github.com/users/balderdashy/orgs","repos_url":"https://api.github.com/users/balderdashy/repos","events_url":"https://api.github.com/users/balderdashy/events{/privacy}","received_events_url":"https://api.github.com/users/balderdashy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/balderdashy/sails","description":"Realtime MVC Framework for Node.js","fork":false,"url":"https://api.github.com/repos/balderdashy/sails","forks_url":"https://api.github.com/repos/balderdashy/sails/forks","keys_url":"https://api.github.com/repos/balderdashy/sails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/balderdashy/sails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/balderdashy/sails/teams","hooks_url":"https://api.github.com/repos/balderdashy/sails/hooks","issue_events_url":"https://api.github.com/repos/balderdashy/sails/issues/events{/number}","events_url":"https://api.github.com/repos/balderdashy/sails/events","assignees_url":"https://api.github.com/repos/balderdashy/sails/assignees{/user}","branches_url":"https://api.github.com/repos/balderdashy/sails/branches{/branch}","tags_url":"https://api.github.com/repos/balderdashy/sails/tags","blobs_url":"https://api.github.com/repos/balderdashy/sails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/balderdashy/sails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/balderdashy/sails/git/refs{/sha}","trees_url":"https://api.github.com/repos/balderdashy/sails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/balderdashy/sails/statuses/{sha}","languages_url":"https://api.github.com/repos/balderdashy/sails/languages","stargazers_url":"https://api.github.com/repos/balderdashy/sails/stargazers","contributors_url":"https://api.github.com/repos/balderdashy/sails/contributors","subscribers_url":"https://api.github.com/repos/balderdashy/sails/subscribers","subscription_url":"https://api.github.com/repos/balderdashy/sails/subscription","commits_url":"https://api.github.com/repos/balderdashy/sails/commits{/sha}","git_commits_url":"https://api.github.com/repos/balderdashy/sails/git/commits{/sha}","comments_url":"https://api.github.com/repos/balderdashy/sails/comments{/number}","issue_comment_url":"https://api.github.com/repos/balderdashy/sails/issues/comments{/number}","contents_url":"https://api.github.com/repos/balderdashy/sails/contents/{+path}","compare_url":"https://api.github.com/repos/balderdashy/sails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/balderdashy/sails/merges","archive_url":"https://api.github.com/repos/balderdashy/sails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/balderdashy/sails/downloads","issues_url":"https://api.github.com/repos/balderdashy/sails/issues{/number}","pulls_url":"https://api.github.com/repos/balderdashy/sails/pulls{/number}","milestones_url":"https://api.github.com/repos/balderdashy/sails/milestones{/number}","notifications_url":"https://api.github.com/repos/balderdashy/sails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/balderdashy/sails/labels{/name}","releases_url":"https://api.github.com/repos/balderdashy/sails/releases{/id}","created_at":"2012-03-18T19:46:15Z","updated_at":"2015-03-28T19:41:58Z","pushed_at":"2015-03-28T20:24:40Z","git_url":"git://github.com/balderdashy/sails.git","ssh_url":"git@github.com:balderdashy/sails.git","clone_url":"https://github.com/balderdashy/sails.git","svn_url":"https://github.com/balderdashy/sails","homepage":"http://sailsjs.org","size":23869,"stargazers_count":10000,"watchers_count":10000,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1081,"mirror_url":null,"open_issues_count":284,"forks":1081,"open_issues":284,"watchers":10000,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/balderdashy/sails/pulls/2792"},"html":{"href":"https://github.com/balderdashy/sails/pull/2792"},"issue":{"href":"https://api.github.com/repos/balderdashy/sails/issues/2792"},"comments":{"href":"https://api.github.com/repos/balderdashy/sails/issues/2792/comments"},"review_comments":{"href":"https://api.github.com/repos/balderdashy/sails/pulls/2792/comments"},"review_comment":{"href":"https://api.github.com/repos/balderdashy/sails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/balderdashy/sails/pulls/2792/commits"},"statuses":{"href":"https://api.github.com/repos/balderdashy/sails/statuses/34df2277af50a4b2013ca8cd055000024af15ca1"}}}}