{"action":"closed","number":11,"pull_request":{"url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/pulls/11","id":45982790,"html_url":"https://github.com/diasdavid/node-libp2p-swarm/pull/11","diff_url":"https://github.com/diasdavid/node-libp2p-swarm/pull/11.diff","patch_url":"https://github.com/diasdavid/node-libp2p-swarm/pull/11.patch","issue_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/issues/11","number":11,"state":"closed","locked":false,"title":"Protect from peers without supported transports","user":{"login":"masylum","id":28248,"avatar_url":"https://avatars.githubusercontent.com/u/28248?v=3","gravatar_id":"","url":"https://api.github.com/users/masylum","html_url":"https://github.com/masylum","followers_url":"https://api.github.com/users/masylum/followers","following_url":"https://api.github.com/users/masylum/following{/other_user}","gists_url":"https://api.github.com/users/masylum/gists{/gist_id}","starred_url":"https://api.github.com/users/masylum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masylum/subscriptions","organizations_url":"https://api.github.com/users/masylum/orgs","repos_url":"https://api.github.com/users/masylum/repos","events_url":"https://api.github.com/users/masylum/events{/privacy}","received_events_url":"https://api.github.com/users/masylum/received_events","type":"User","site_admin":false},"body":"# What\r\n\r\nTrying to run compliance tests from the kad router module. I've tried to port the new swarm API but forgot to add a transport. The tests ended up blowing up instead of failing gracefully.\r\n\r\n# How to test\r\n\r\n```js\r\npeerOne = new Peer(Id.create(), [multiaddr('/ip4/127.0.0.1/tcp/8090')])\r\npeerTwo = new Peer(Id.create(), [multiaddr('/ip4/127.0.0.1/tcp/8091')])\r\nswarm = new Swarm(peerOne)\r\nswarm.dial(peerTwo, {}, function (err) {\r\n  console.log(err);\r\n});\r\n```\r\n\r\nThis just work and display the error.","created_at":"2015-09-25T07:08:21Z","updated_at":"2015-09-28T15:11:56Z","closed_at":"2015-09-28T15:11:56Z","merged_at":"2015-09-28T15:11:56Z","merge_commit_sha":"ed741ba395603daef68b83d4d162cd2ba88caf99","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/pulls/11/commits","review_comments_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/pulls/11/comments","review_comment_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/issues/11/comments","statuses_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/statuses/8dc46da80f2e158106238b9ad7e6687f221ee466","head":{"label":"masylum:patch-1","ref":"patch-1","sha":"8dc46da80f2e158106238b9ad7e6687f221ee466","user":{"login":"masylum","id":28248,"avatar_url":"https://avatars.githubusercontent.com/u/28248?v=3","gravatar_id":"","url":"https://api.github.com/users/masylum","html_url":"https://github.com/masylum","followers_url":"https://api.github.com/users/masylum/followers","following_url":"https://api.github.com/users/masylum/following{/other_user}","gists_url":"https://api.github.com/users/masylum/gists{/gist_id}","starred_url":"https://api.github.com/users/masylum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masylum/subscriptions","organizations_url":"https://api.github.com/users/masylum/orgs","repos_url":"https://api.github.com/users/masylum/repos","events_url":"https://api.github.com/users/masylum/events{/privacy}","received_events_url":"https://api.github.com/users/masylum/received_events","type":"User","site_admin":false},"repo":{"id":43114751,"name":"node-libp2p-swarm","full_name":"masylum/node-libp2p-swarm","owner":{"login":"masylum","id":28248,"avatar_url":"https://avatars.githubusercontent.com/u/28248?v=3","gravatar_id":"","url":"https://api.github.com/users/masylum","html_url":"https://github.com/masylum","followers_url":"https://api.github.com/users/masylum/followers","following_url":"https://api.github.com/users/masylum/following{/other_user}","gists_url":"https://api.github.com/users/masylum/gists{/gist_id}","starred_url":"https://api.github.com/users/masylum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masylum/subscriptions","organizations_url":"https://api.github.com/users/masylum/orgs","repos_url":"https://api.github.com/users/masylum/repos","events_url":"https://api.github.com/users/masylum/events{/privacy}","received_events_url":"https://api.github.com/users/masylum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/masylum/node-libp2p-swarm","description":"IPFS swarm implementation in Node.js","fork":true,"url":"https://api.github.com/repos/masylum/node-libp2p-swarm","forks_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/forks","keys_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/teams","hooks_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/hooks","issue_events_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/issues/events{/number}","events_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/events","assignees_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/assignees{/user}","branches_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/branches{/branch}","tags_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/tags","blobs_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/git/refs{/sha}","trees_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/statuses/{sha}","languages_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/languages","stargazers_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/stargazers","contributors_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/contributors","subscribers_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/subscribers","subscription_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/subscription","commits_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/commits{/sha}","git_commits_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/git/commits{/sha}","comments_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/comments{/number}","issue_comment_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/issues/comments{/number}","contents_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/contents/{+path}","compare_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/merges","archive_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/downloads","issues_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/issues{/number}","pulls_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/pulls{/number}","milestones_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/milestones{/number}","notifications_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/labels{/name}","releases_url":"https://api.github.com/repos/masylum/node-libp2p-swarm/releases{/id}","created_at":"2015-09-25T06:57:55Z","updated_at":"2015-09-25T06:57:56Z","pushed_at":"2015-09-28T07:47:21Z","git_url":"git://github.com/masylum/node-libp2p-swarm.git","ssh_url":"git@github.com:masylum/node-libp2p-swarm.git","clone_url":"https://github.com/masylum/node-libp2p-swarm.git","svn_url":"https://github.com/masylum/node-libp2p-swarm","homepage":null,"size":209,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"diasdavid:master","ref":"master","sha":"cd5334444119bd63d219e083b1437265823d2a40","user":{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars.githubusercontent.com/u/1211152?v=3","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},"repo":{"id":38784511,"name":"node-libp2p-swarm","full_name":"diasdavid/node-libp2p-swarm","owner":{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars.githubusercontent.com/u/1211152?v=3","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diasdavid/node-libp2p-swarm","description":"IPFS swarm implementation in Node.js","fork":false,"url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm","forks_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/forks","keys_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/teams","hooks_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/hooks","issue_events_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/issues/events{/number}","events_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/events","assignees_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/assignees{/user}","branches_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/branches{/branch}","tags_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/tags","blobs_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/git/refs{/sha}","trees_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/statuses/{sha}","languages_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/languages","stargazers_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/stargazers","contributors_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/contributors","subscribers_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/subscribers","subscription_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/subscription","commits_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/commits{/sha}","git_commits_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/git/commits{/sha}","comments_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/comments{/number}","issue_comment_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/issues/comments{/number}","contents_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/contents/{+path}","compare_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/merges","archive_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/downloads","issues_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/issues{/number}","pulls_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/pulls{/number}","milestones_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/milestones{/number}","notifications_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/labels{/name}","releases_url":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/releases{/id}","created_at":"2015-07-08T22:59:25Z","updated_at":"2015-09-23T22:10:11Z","pushed_at":"2015-09-28T15:11:56Z","git_url":"git://github.com/diasdavid/node-libp2p-swarm.git","ssh_url":"git@github.com:diasdavid/node-libp2p-swarm.git","clone_url":"https://github.com/diasdavid/node-libp2p-swarm.git","svn_url":"https://github.com/diasdavid/node-libp2p-swarm","homepage":null,"size":387,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/pulls/11"},"html":{"href":"https://github.com/diasdavid/node-libp2p-swarm/pull/11"},"issue":{"href":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/issues/11"},"comments":{"href":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/diasdavid/node-libp2p-swarm/statuses/8dc46da80f2e158106238b9ad7e6687f221ee466"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars.githubusercontent.com/u/1211152?v=3","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"commits":1,"additions":32,"deletions":8,"changed_files":3}}