{"action":"created","comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/pulls/comments/28769949","id":28769949,"diff_hunk":"@@ -1,86 +1,49 @@\n require_relative '../spec_helper'\n \n-describe LogStash::Outputs::Graphite do\n-\n-  let(:port) { 4939 }\n-  let(:config) do <<-CONFIG\n-     input {\n-        generator {\n-          message => \"foo=fancy bar=42\"\n-          count => 1\n-          type => \"generator\"\n-        }\n-      }\n-\n-      filter {\n-        kv { }\n-      }\n-\n-      output {\n-        graphite {\n-          host => \"localhost\"\n-          port => #{port}\n-          metrics => [ \"hurray.%{foo}\", \"%{bar}\" ]\n-        }\n-      }\n-  CONFIG\n+class LogStash::Outputs::Graphite","path":"spec/outputs/graphite_spec.rb","position":27,"original_position":27,"commit_id":"e34d2a772ebfdc45642037b7cc4f6386f4f40d83","original_commit_id":"e34d2a772ebfdc45642037b7cc4f6386f4f40d83","user":{"login":"purbon","id":68540,"avatar_url":"https://avatars.githubusercontent.com/u/68540?v=3","gravatar_id":"","url":"https://api.github.com/users/purbon","html_url":"https://github.com/purbon","followers_url":"https://api.github.com/users/purbon/followers","following_url":"https://api.github.com/users/purbon/following{/other_user}","gists_url":"https://api.github.com/users/purbon/gists{/gist_id}","starred_url":"https://api.github.com/users/purbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purbon/subscriptions","organizations_url":"https://api.github.com/users/purbon/orgs","repos_url":"https://api.github.com/users/purbon/repos","events_url":"https://api.github.com/users/purbon/events{/privacy}","received_events_url":"https://api.github.com/users/purbon/received_events","type":"User","site_admin":false},"body":"might be to his own particular file? so the change is clear. What do you think?","created_at":"2015-04-21T11:39:42Z","updated_at":"2015-04-21T11:39:42Z","html_url":"https://github.com/logstash-plugins/logstash-output-graphite/pull/12#discussion_r28769949","pull_request_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/pulls/comments/28769949"},"html":{"href":"https://github.com/logstash-plugins/logstash-output-graphite/pull/12#discussion_r28769949"},"pull_request":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/pulls/12","id":32445760,"html_url":"https://github.com/logstash-plugins/logstash-output-graphite/pull/12","diff_url":"https://github.com/logstash-plugins/logstash-output-graphite/pull/12.diff","patch_url":"https://github.com/logstash-plugins/logstash-output-graphite/pull/12.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/issues/12","number":12,"state":"open","locked":false,"title":"ensure mock server replies recently written messages","user":{"login":"jsvd","id":31809,"avatar_url":"https://avatars.githubusercontent.com/u/31809?v=3","gravatar_id":"","url":"https://api.github.com/users/jsvd","html_url":"https://github.com/jsvd","followers_url":"https://api.github.com/users/jsvd/followers","following_url":"https://api.github.com/users/jsvd/following{/other_user}","gists_url":"https://api.github.com/users/jsvd/gists{/gist_id}","starred_url":"https://api.github.com/users/jsvd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsvd/subscriptions","organizations_url":"https://api.github.com/users/jsvd/orgs","repos_url":"https://api.github.com/users/jsvd/repos","events_url":"https://api.github.com/users/jsvd/events{/privacy}","received_events_url":"https://api.github.com/users/jsvd/received_events","type":"User","site_admin":false},"body":"some tests were failing because the test flow is:\r\n\r\n1. start mock server\r\n2. start graphite output\r\n3. write message to output.receive\r\n4. read messages from mock server\r\n\r\nSometimes output.receive will return faster than mock server is able to pull the message from the socket and push it into its internal queue. This PR introduces a delay for all read operations on the @queue object.","created_at":"2015-04-01T18:22:10Z","updated_at":"2015-04-21T11:39:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a4c3e419bfda7a7d1ea97534935671ef196690e","assignee":{"login":"jsvd","id":31809,"avatar_url":"https://avatars.githubusercontent.com/u/31809?v=3","gravatar_id":"","url":"https://api.github.com/users/jsvd","html_url":"https://github.com/jsvd","followers_url":"https://api.github.com/users/jsvd/followers","following_url":"https://api.github.com/users/jsvd/following{/other_user}","gists_url":"https://api.github.com/users/jsvd/gists{/gist_id}","starred_url":"https://api.github.com/users/jsvd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsvd/subscriptions","organizations_url":"https://api.github.com/users/jsvd/orgs","repos_url":"https://api.github.com/users/jsvd/repos","events_url":"https://api.github.com/users/jsvd/events{/privacy}","received_events_url":"https://api.github.com/users/jsvd/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/pulls/12/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/pulls/12/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/issues/12/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/statuses/e34d2a772ebfdc45642037b7cc4f6386f4f40d83","head":{"label":"jsvd:fix_specs_concurrency","ref":"fix_specs_concurrency","sha":"e34d2a772ebfdc45642037b7cc4f6386f4f40d83","user":{"login":"jsvd","id":31809,"avatar_url":"https://avatars.githubusercontent.com/u/31809?v=3","gravatar_id":"","url":"https://api.github.com/users/jsvd","html_url":"https://github.com/jsvd","followers_url":"https://api.github.com/users/jsvd/followers","following_url":"https://api.github.com/users/jsvd/following{/other_user}","gists_url":"https://api.github.com/users/jsvd/gists{/gist_id}","starred_url":"https://api.github.com/users/jsvd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsvd/subscriptions","organizations_url":"https://api.github.com/users/jsvd/orgs","repos_url":"https://api.github.com/users/jsvd/repos","events_url":"https://api.github.com/users/jsvd/events{/privacy}","received_events_url":"https://api.github.com/users/jsvd/received_events","type":"User","site_admin":false},"repo":{"id":29137016,"name":"logstash-output-graphite","full_name":"jsvd/logstash-output-graphite","owner":{"login":"jsvd","id":31809,"avatar_url":"https://avatars.githubusercontent.com/u/31809?v=3","gravatar_id":"","url":"https://api.github.com/users/jsvd","html_url":"https://github.com/jsvd","followers_url":"https://api.github.com/users/jsvd/followers","following_url":"https://api.github.com/users/jsvd/following{/other_user}","gists_url":"https://api.github.com/users/jsvd/gists{/gist_id}","starred_url":"https://api.github.com/users/jsvd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsvd/subscriptions","organizations_url":"https://api.github.com/users/jsvd/orgs","repos_url":"https://api.github.com/users/jsvd/repos","events_url":"https://api.github.com/users/jsvd/events{/privacy}","received_events_url":"https://api.github.com/users/jsvd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsvd/logstash-output-graphite","description":null,"fork":true,"url":"https://api.github.com/repos/jsvd/logstash-output-graphite","forks_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/forks","keys_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/teams","hooks_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/hooks","issue_events_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/issues/events{/number}","events_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/events","assignees_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/assignees{/user}","branches_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/branches{/branch}","tags_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/tags","blobs_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/statuses/{sha}","languages_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/languages","stargazers_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/stargazers","contributors_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/contributors","subscribers_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/subscribers","subscription_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/subscription","commits_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/contents/{+path}","compare_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/merges","archive_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/downloads","issues_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/issues{/number}","pulls_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/pulls{/number}","milestones_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/milestones{/number}","notifications_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/labels{/name}","releases_url":"https://api.github.com/repos/jsvd/logstash-output-graphite/releases{/id}","created_at":"2015-01-12T13:38:11Z","updated_at":"2015-01-12T13:38:12Z","pushed_at":"2015-04-20T11:36:39Z","git_url":"git://github.com/jsvd/logstash-output-graphite.git","ssh_url":"git@github.com:jsvd/logstash-output-graphite.git","clone_url":"https://github.com/jsvd/logstash-output-graphite.git","svn_url":"https://github.com/jsvd/logstash-output-graphite","homepage":null,"size":107,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"0d5fcf43862053fb3681f77e73218d74ab633eef","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":25471103,"name":"logstash-output-graphite","full_name":"logstash-plugins/logstash-output-graphite","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-output-graphite","description":null,"fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/releases{/id}","created_at":"2014-10-20T14:49:16Z","updated_at":"2015-04-20T14:00:28Z","pushed_at":"2015-04-20T19:08:15Z","git_url":"git://github.com/logstash-plugins/logstash-output-graphite.git","ssh_url":"git@github.com:logstash-plugins/logstash-output-graphite.git","clone_url":"https://github.com/logstash-plugins/logstash-output-graphite.git","svn_url":"https://github.com/logstash-plugins/logstash-output-graphite","homepage":null,"size":447,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/pulls/12"},"html":{"href":"https://github.com/logstash-plugins/logstash-output-graphite/pull/12"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/issues/12"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-graphite/statuses/e34d2a772ebfdc45642037b7cc4f6386f4f40d83"}}}}