{"action":"opened","number":1881,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/1881","id":36582268,"html_url":"https://github.com/dotnet/corefx/pull/1881","diff_url":"https://github.com/dotnet/corefx/pull/1881.diff","patch_url":"https://github.com/dotnet/corefx/pull/1881.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/1881","number":1881,"state":"open","locked":false,"title":"Update System.Text.Encoding.CodePage tests.","user":{"login":"Clockwork-Muse","id":5569508,"avatar_url":"https://avatars.githubusercontent.com/u/5569508?v=3","gravatar_id":"","url":"https://api.github.com/users/Clockwork-Muse","html_url":"https://github.com/Clockwork-Muse","followers_url":"https://api.github.com/users/Clockwork-Muse/followers","following_url":"https://api.github.com/users/Clockwork-Muse/following{/other_user}","gists_url":"https://api.github.com/users/Clockwork-Muse/gists{/gist_id}","starred_url":"https://api.github.com/users/Clockwork-Muse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clockwork-Muse/subscriptions","organizations_url":"https://api.github.com/users/Clockwork-Muse/orgs","repos_url":"https://api.github.com/users/Clockwork-Muse/repos","events_url":"https://api.github.com/users/Clockwork-Muse/events{/privacy}","received_events_url":"https://api.github.com/users/Clockwork-Muse/received_events","type":"User","site_admin":false},"body":"Updated (existant) tests for System.Text.Encoding.CodePage, in response to #1872 .\r\nTests no longer require a specific run order, and should be safer to run in multiple threads (one other test had potential race conditions as a result of conversion...)\r\n\r\nAll tests passing on Windows.  An attempt was made to fix one of the tests failing in Unix (due to issue #846 ), but I have no way to verify this myself (`ActiveIssue` attribute left on).\r\n\r\nThere also appeared to be some entries missing for retrieving a 'WebName' from a given encoding (Europa, code page 29001).  The encoding could be retrieved, and even used to perform encodings, but attempting to call `WebName` would complain that such did not exist.  Given:\r\n 1. The encoders existence and working implementation\r\n 2. A returned value in the current implementation.\r\n 3. An entry on the relevant MSDN page.\r\n\r\n... this was judged to be a bug, and corrected accordingly. \r\n\r\n<hr />\r\nSquashed commits:\r\n\r\nRemove `EnsureInitialization` and pre-existing-encodings tests.\r\nAsk CodePagesEncodingProvider directly for encodings.\r\n\r\nMove encoding mapping data into member in prep for adding Theory attribute.\r\n\r\nAdd missing Europa (code page 29001) strings.\r\nNo obvious way to test \"English\" strings (unused!), leaving in for now.\r\n\r\nTest for existence of all available default encodings.\r\nTest replacement/supplementary behavior with addition of code-page mapping.\r\nAttempt to add Unix-specific test (but not able to personally test, due to being on windows...).\r\n\r\nUpdate TestCodepageEncoding to use Theory/MemberData.\r\nExpand range of characters round-tripped (potentially more can be added, but additional tests for exceptions should be added).\r\nBring in code-page->webname mapping tests.\r\n\r\nRemove existence test for Eudc encoding (part of testing data).\r\n\r\nUpdate TestEncodingDisplayNames to use Theory/MemberData.\r\nRaise lower bound of acceptable characters to only printable, and not solely whitespace.\r\nExternalize culture setup to class load-time (in-method not thread safe!)\r\n\r\nMove test classes out of default namespace.\r\n\r\nUpdate TestSpecificCodepageEncodings\r\nExtract test data to member.\r\nLoft tests to method, use more idiomatic xUnit.\r\n\r\nUpdate multibyte encoding tests.\r\nExtract data to member.\r\nCondense test methods into one.","created_at":"2015-05-31T13:32:31Z","updated_at":"2015-05-31T13:32:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/1881/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/1881/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/1881/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/e0101a0f9439c5c0e75cee61f4146789947ed845","head":{"label":"Clockwork-Muse:1872_System.Text.Encoding.CodePages_TestExecutionOrder","ref":"1872_System.Text.Encoding.CodePages_TestExecutionOrder","sha":"e0101a0f9439c5c0e75cee61f4146789947ed845","user":{"login":"Clockwork-Muse","id":5569508,"avatar_url":"https://avatars.githubusercontent.com/u/5569508?v=3","gravatar_id":"","url":"https://api.github.com/users/Clockwork-Muse","html_url":"https://github.com/Clockwork-Muse","followers_url":"https://api.github.com/users/Clockwork-Muse/followers","following_url":"https://api.github.com/users/Clockwork-Muse/following{/other_user}","gists_url":"https://api.github.com/users/Clockwork-Muse/gists{/gist_id}","starred_url":"https://api.github.com/users/Clockwork-Muse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clockwork-Muse/subscriptions","organizations_url":"https://api.github.com/users/Clockwork-Muse/orgs","repos_url":"https://api.github.com/users/Clockwork-Muse/repos","events_url":"https://api.github.com/users/Clockwork-Muse/events{/privacy}","received_events_url":"https://api.github.com/users/Clockwork-Muse/received_events","type":"User","site_admin":false},"repo":{"id":29805465,"name":"corefx","full_name":"Clockwork-Muse/corefx","owner":{"login":"Clockwork-Muse","id":5569508,"avatar_url":"https://avatars.githubusercontent.com/u/5569508?v=3","gravatar_id":"","url":"https://api.github.com/users/Clockwork-Muse","html_url":"https://github.com/Clockwork-Muse","followers_url":"https://api.github.com/users/Clockwork-Muse/followers","following_url":"https://api.github.com/users/Clockwork-Muse/following{/other_user}","gists_url":"https://api.github.com/users/Clockwork-Muse/gists{/gist_id}","starred_url":"https://api.github.com/users/Clockwork-Muse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clockwork-Muse/subscriptions","organizations_url":"https://api.github.com/users/Clockwork-Muse/orgs","repos_url":"https://api.github.com/users/Clockwork-Muse/repos","events_url":"https://api.github.com/users/Clockwork-Muse/events{/privacy}","received_events_url":"https://api.github.com/users/Clockwork-Muse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Clockwork-Muse/corefx","description":"Branch for issue #516.  WARNING - will be rebased often.","fork":true,"url":"https://api.github.com/repos/Clockwork-Muse/corefx","forks_url":"https://api.github.com/repos/Clockwork-Muse/corefx/forks","keys_url":"https://api.github.com/repos/Clockwork-Muse/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Clockwork-Muse/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Clockwork-Muse/corefx/teams","hooks_url":"https://api.github.com/repos/Clockwork-Muse/corefx/hooks","issue_events_url":"https://api.github.com/repos/Clockwork-Muse/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/Clockwork-Muse/corefx/events","assignees_url":"https://api.github.com/repos/Clockwork-Muse/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/Clockwork-Muse/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/Clockwork-Muse/corefx/tags","blobs_url":"https://api.github.com/repos/Clockwork-Muse/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Clockwork-Muse/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Clockwork-Muse/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/Clockwork-Muse/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Clockwork-Muse/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/Clockwork-Muse/corefx/languages","stargazers_url":"https://api.github.com/repos/Clockwork-Muse/corefx/stargazers","contributors_url":"https://api.github.com/repos/Clockwork-Muse/corefx/contributors","subscribers_url":"https://api.github.com/repos/Clockwork-Muse/corefx/subscribers","subscription_url":"https://api.github.com/repos/Clockwork-Muse/corefx/subscription","commits_url":"https://api.github.com/repos/Clockwork-Muse/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/Clockwork-Muse/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/Clockwork-Muse/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/Clockwork-Muse/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/Clockwork-Muse/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/Clockwork-Muse/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Clockwork-Muse/corefx/merges","archive_url":"https://api.github.com/repos/Clockwork-Muse/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Clockwork-Muse/corefx/downloads","issues_url":"https://api.github.com/repos/Clockwork-Muse/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/Clockwork-Muse/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/Clockwork-Muse/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/Clockwork-Muse/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Clockwork-Muse/corefx/labels{/name}","releases_url":"https://api.github.com/repos/Clockwork-Muse/corefx/releases{/id}","created_at":"2015-01-25T06:35:53Z","updated_at":"2015-04-30T10:08:57Z","pushed_at":"2015-05-31T13:15:50Z","git_url":"git://github.com/Clockwork-Muse/corefx.git","ssh_url":"git@github.com:Clockwork-Muse/corefx.git","clone_url":"https://github.com/Clockwork-Muse/corefx.git","svn_url":"https://github.com/Clockwork-Muse/corefx","homepage":"","size":20416,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"5037193ea7721245f9e009822c8573f269dd69cd","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-05-31T08:36:08Z","pushed_at":"2015-05-31T05:50:23Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"","size":47763,"stargazers_count":7854,"watchers_count":7854,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1583,"mirror_url":null,"open_issues_count":405,"forks":1583,"open_issues":405,"watchers":7854,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1881"},"html":{"href":"https://github.com/dotnet/corefx/pull/1881"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/1881"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/1881/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1881/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1881/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/e0101a0f9439c5c0e75cee61f4146789947ed845"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":577,"deletions":892,"changed_files":2}}