{"action":"created","issue":{"url":"https://api.github.com/repos/gnuradio/gnuradio-wg-grc/issues/16","labels_url":"https://api.github.com/repos/gnuradio/gnuradio-wg-grc/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/gnuradio/gnuradio-wg-grc/issues/16/comments","events_url":"https://api.github.com/repos/gnuradio/gnuradio-wg-grc/issues/16/events","html_url":"https://github.com/gnuradio/gnuradio-wg-grc/pull/16","id":98458021,"number":16,"title":"Bypass/Virtual sink fix","user":{"login":"sdh11","id":6745143,"avatar_url":"https://avatars.githubusercontent.com/u/6745143?v=3","gravatar_id":"","url":"https://api.github.com/users/sdh11","html_url":"https://github.com/sdh11","followers_url":"https://api.github.com/users/sdh11/followers","following_url":"https://api.github.com/users/sdh11/following{/other_user}","gists_url":"https://api.github.com/users/sdh11/gists{/gist_id}","starred_url":"https://api.github.com/users/sdh11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdh11/subscriptions","organizations_url":"https://api.github.com/users/sdh11/orgs","repos_url":"https://api.github.com/users/sdh11/repos","events_url":"https://api.github.com/users/sdh11/events{/privacy}","received_events_url":"https://api.github.com/users/sdh11/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-07-31T19:42:32Z","updated_at":"2015-08-04T18:01:14Z","closed_at":"2015-08-04T09:12:55Z","pull_request":{"url":"https://api.github.com/repos/gnuradio/gnuradio-wg-grc/pulls/16","html_url":"https://github.com/gnuradio/gnuradio-wg-grc/pull/16","diff_url":"https://github.com/gnuradio/gnuradio-wg-grc/pull/16.diff","patch_url":"https://github.com/gnuradio/gnuradio-wg-grc/pull/16.patch"},"body":"Fixed bug where the flowgraph errors if the bypassed block is connected to a virtual sink."},"comment":{"url":"https://api.github.com/repos/gnuradio/gnuradio-wg-grc/issues/comments/127693415","html_url":"https://github.com/gnuradio/gnuradio-wg-grc/pull/16#issuecomment-127693415","issue_url":"https://api.github.com/repos/gnuradio/gnuradio-wg-grc/issues/16","id":127693415,"user":{"login":"jmcorgan","id":1492956,"avatar_url":"https://avatars.githubusercontent.com/u/1492956?v=3","gravatar_id":"","url":"https://api.github.com/users/jmcorgan","html_url":"https://github.com/jmcorgan","followers_url":"https://api.github.com/users/jmcorgan/followers","following_url":"https://api.github.com/users/jmcorgan/following{/other_user}","gists_url":"https://api.github.com/users/jmcorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcorgan/subscriptions","organizations_url":"https://api.github.com/users/jmcorgan/orgs","repos_url":"https://api.github.com/users/jmcorgan/repos","events_url":"https://api.github.com/users/jmcorgan/events{/privacy}","received_events_url":"https://api.github.com/users/jmcorgan/received_events","type":"User","site_admin":false},"created_at":"2015-08-04T18:01:14Z","updated_at":"2015-08-04T18:01:14Z","body":"To be accurate, my original statement, that instantiated but unconnected blocks could make the topology check fail, was incorrect.  The GNU Radio scheduler will prune (but not uninstantiate) unconnected blocks during the flattening of the flowgraph before doing the final topology check.  Any unconnected blocks will not have their check_topology() method called.\r\n\r\nHowever, what @mbr0wn says above is still completely valid, and for that reason alone the current way is correct."}}