{"action":"closed","number":20885,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/20885","id":29747423,"html_url":"https://github.com/saltstack/salt/pull/20885","diff_url":"https://github.com/saltstack/salt/pull/20885.diff","patch_url":"https://github.com/saltstack/salt/pull/20885.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/20885","number":20885,"state":"closed","locked":false,"title":"Trim the env base off the dest file path in the s3fs fileserver","user":{"login":"joehoyle","id":161683,"avatar_url":"https://avatars.githubusercontent.com/u/161683?v=3","gravatar_id":"","url":"https://api.github.com/users/joehoyle","html_url":"https://github.com/joehoyle","followers_url":"https://api.github.com/users/joehoyle/followers","following_url":"https://api.github.com/users/joehoyle/following{/other_user}","gists_url":"https://api.github.com/users/joehoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/joehoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joehoyle/subscriptions","organizations_url":"https://api.github.com/users/joehoyle/orgs","repos_url":"https://api.github.com/users/joehoyle/repos","events_url":"https://api.github.com/users/joehoyle/events{/privacy}","received_events_url":"https://api.github.com/users/joehoyle/received_events","type":"User","site_admin":false},"body":"Currently custom modules/grains are broken if using s3fs. This seems to be because the `s3fs` fileserver returns the `dest` in `serve_file()` includes the env base. This is then appended to the cache dir via `RemoteClient.get_file()` which is already set with the environment in mind. This causes a path like: '/var/cache/salt/minion/files/base/base/_modules' which in turn screws up the copying into the modules dir.\r\n\r\nThe attached patch removed the environment off the beginning off path if using the \"environments in bucket\" option.","created_at":"2015-02-21T02:46:33Z","updated_at":"2015-02-21T05:00:24Z","closed_at":"2015-02-21T05:00:24Z","merged_at":"2015-02-21T05:00:24Z","merge_commit_sha":"beddba4d7367a69ee0bfd1f35e76285ea03a497b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/20885/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/20885/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments/{number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/20885/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/5d8ba4aac2615092d07bf223ee9cfc9382344e4f","head":{"label":"joehoyle:fix-s3fs-dest","ref":"fix-s3fs-dest","sha":"5d8ba4aac2615092d07bf223ee9cfc9382344e4f","user":{"login":"joehoyle","id":161683,"avatar_url":"https://avatars.githubusercontent.com/u/161683?v=3","gravatar_id":"","url":"https://api.github.com/users/joehoyle","html_url":"https://github.com/joehoyle","followers_url":"https://api.github.com/users/joehoyle/followers","following_url":"https://api.github.com/users/joehoyle/following{/other_user}","gists_url":"https://api.github.com/users/joehoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/joehoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joehoyle/subscriptions","organizations_url":"https://api.github.com/users/joehoyle/orgs","repos_url":"https://api.github.com/users/joehoyle/repos","events_url":"https://api.github.com/users/joehoyle/events{/privacy}","received_events_url":"https://api.github.com/users/joehoyle/received_events","type":"User","site_admin":false},"repo":{"id":31113046,"name":"salt","full_name":"joehoyle/salt","owner":{"login":"joehoyle","id":161683,"avatar_url":"https://avatars.githubusercontent.com/u/161683?v=3","gravatar_id":"","url":"https://api.github.com/users/joehoyle","html_url":"https://github.com/joehoyle","followers_url":"https://api.github.com/users/joehoyle/followers","following_url":"https://api.github.com/users/joehoyle/following{/other_user}","gists_url":"https://api.github.com/users/joehoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/joehoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joehoyle/subscriptions","organizations_url":"https://api.github.com/users/joehoyle/orgs","repos_url":"https://api.github.com/users/joehoyle/repos","events_url":"https://api.github.com/users/joehoyle/events{/privacy}","received_events_url":"https://api.github.com/users/joehoyle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joehoyle/salt","description":"Infrastructure automation and management system","fork":true,"url":"https://api.github.com/repos/joehoyle/salt","forks_url":"https://api.github.com/repos/joehoyle/salt/forks","keys_url":"https://api.github.com/repos/joehoyle/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joehoyle/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joehoyle/salt/teams","hooks_url":"https://api.github.com/repos/joehoyle/salt/hooks","issue_events_url":"https://api.github.com/repos/joehoyle/salt/issues/events{/number}","events_url":"https://api.github.com/repos/joehoyle/salt/events","assignees_url":"https://api.github.com/repos/joehoyle/salt/assignees{/user}","branches_url":"https://api.github.com/repos/joehoyle/salt/branches{/branch}","tags_url":"https://api.github.com/repos/joehoyle/salt/tags","blobs_url":"https://api.github.com/repos/joehoyle/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joehoyle/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joehoyle/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/joehoyle/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joehoyle/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/joehoyle/salt/languages","stargazers_url":"https://api.github.com/repos/joehoyle/salt/stargazers","contributors_url":"https://api.github.com/repos/joehoyle/salt/contributors","subscribers_url":"https://api.github.com/repos/joehoyle/salt/subscribers","subscription_url":"https://api.github.com/repos/joehoyle/salt/subscription","commits_url":"https://api.github.com/repos/joehoyle/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/joehoyle/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/joehoyle/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/joehoyle/salt/issues/comments/{number}","contents_url":"https://api.github.com/repos/joehoyle/salt/contents/{+path}","compare_url":"https://api.github.com/repos/joehoyle/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joehoyle/salt/merges","archive_url":"https://api.github.com/repos/joehoyle/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joehoyle/salt/downloads","issues_url":"https://api.github.com/repos/joehoyle/salt/issues{/number}","pulls_url":"https://api.github.com/repos/joehoyle/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/joehoyle/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/joehoyle/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joehoyle/salt/labels{/name}","releases_url":"https://api.github.com/repos/joehoyle/salt/releases{/id}","created_at":"2015-02-21T02:36:38Z","updated_at":"2015-02-21T02:36:46Z","pushed_at":"2015-02-21T02:41:01Z","git_url":"git://github.com/joehoyle/salt.git","ssh_url":"git@github.com:joehoyle/salt.git","clone_url":"https://github.com/joehoyle/salt.git","svn_url":"https://github.com/joehoyle/salt","homepage":"saltstack.com","size":84762,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"aa96665a2bd19e310a2d8c411ae3387c0ade3af4","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Infrastructure automation and management system","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments/{number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","created_at":"2011-02-20T20:16:56Z","updated_at":"2015-02-21T05:00:20Z","pushed_at":"2015-02-21T05:00:19Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"saltstack.com","size":182848,"stargazers_count":4725,"watchers_count":4725,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1945,"mirror_url":null,"open_issues_count":2274,"forks":1945,"open_issues":2274,"watchers":4725,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/20885"},"html":{"href":"https://github.com/saltstack/salt/pull/20885"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/20885"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/20885/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/20885/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/20885/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/5d8ba4aac2615092d07bf223ee9cfc9382344e4f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jfindlay","id":702905,"avatar_url":"https://avatars.githubusercontent.com/u/702905?v=3","gravatar_id":"","url":"https://api.github.com/users/jfindlay","html_url":"https://github.com/jfindlay","followers_url":"https://api.github.com/users/jfindlay/followers","following_url":"https://api.github.com/users/jfindlay/following{/other_user}","gists_url":"https://api.github.com/users/jfindlay/gists{/gist_id}","starred_url":"https://api.github.com/users/jfindlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfindlay/subscriptions","organizations_url":"https://api.github.com/users/jfindlay/orgs","repos_url":"https://api.github.com/users/jfindlay/repos","events_url":"https://api.github.com/users/jfindlay/events{/privacy}","received_events_url":"https://api.github.com/users/jfindlay/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}