{"action":"created","comment":{"url":"https://api.github.com/repos/christycui/myflix/pulls/comments/34009957","id":34009957,"diff_hunk":"@@ -0,0 +1,18 @@\n+require 'rails_helper'\n+\n+feature 'User reset password' do\n+  scenario 'user forgot password' do\n+    user = Fabricate(:user)\n+\n+    visit login_path\n+    click_link 'Forgot password?'\n+    expect(page).to have_content('Forgot Password?')\n+    fill_in \"email\", with: user.email_address\n+    click_button 'Send Email'\n+    expect(ActionMailer::Base.deliveries.last.to).to eq([user.email_address])\n+    visit \"/password_reset/#{user.token}\"","path":"spec/features/user_reset_password_spec.rb","position":13,"original_position":13,"commit_id":"b7b371c29e0feddd8763efda50f0b6fcc50b51a2","original_commit_id":"b7b371c29e0feddd8763efda50f0b6fcc50b51a2","user":{"login":"brandoncc","id":543973,"avatar_url":"https://avatars.githubusercontent.com/u/543973?v=3","gravatar_id":"","url":"https://api.github.com/users/brandoncc","html_url":"https://github.com/brandoncc","followers_url":"https://api.github.com/users/brandoncc/followers","following_url":"https://api.github.com/users/brandoncc/following{/other_user}","gists_url":"https://api.github.com/users/brandoncc/gists{/gist_id}","starred_url":"https://api.github.com/users/brandoncc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandoncc/subscriptions","organizations_url":"https://api.github.com/users/brandoncc/orgs","repos_url":"https://api.github.com/users/brandoncc/repos","events_url":"https://api.github.com/users/brandoncc/events{/privacy}","received_events_url":"https://api.github.com/users/brandoncc/received_events","type":"User","site_admin":false},"body":"This is another place you should be using names routes rather than hard coding urls. If you use named routes, you can change the actual url and your test code won't need to change.","created_at":"2015-07-07T06:04:14Z","updated_at":"2015-07-07T06:04:14Z","html_url":"https://github.com/christycui/myflix/pull/4#discussion_r34009957","pull_request_url":"https://api.github.com/repos/christycui/myflix/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/christycui/myflix/pulls/comments/34009957"},"html":{"href":"https://github.com/christycui/myflix/pull/4#discussion_r34009957"},"pull_request":{"href":"https://api.github.com/repos/christycui/myflix/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/christycui/myflix/pulls/4","id":39331351,"html_url":"https://github.com/christycui/myflix/pull/4","diff_url":"https://github.com/christycui/myflix/pull/4.diff","patch_url":"https://github.com/christycui/myflix/pull/4.patch","issue_url":"https://api.github.com/repos/christycui/myflix/issues/4","number":4,"state":"open","locked":false,"title":"Mod4","user":{"login":"christycui","id":8649274,"avatar_url":"https://avatars.githubusercontent.com/u/8649274?v=3","gravatar_id":"","url":"https://api.github.com/users/christycui","html_url":"https://github.com/christycui","followers_url":"https://api.github.com/users/christycui/followers","following_url":"https://api.github.com/users/christycui/following{/other_user}","gists_url":"https://api.github.com/users/christycui/gists{/gist_id}","starred_url":"https://api.github.com/users/christycui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christycui/subscriptions","organizations_url":"https://api.github.com/users/christycui/orgs","repos_url":"https://api.github.com/users/christycui/repos","events_url":"https://api.github.com/users/christycui/events{/privacy}","received_events_url":"https://api.github.com/users/christycui/received_events","type":"User","site_admin":false},"body":"First the first half of this module, I followed the solutions pretty closely; for the second half (reset password), I gave it a try myself and ended lumping everything into one controller PasswordResetController with more specific action names. Besides controller test, I also added a feature test for password reset. ","created_at":"2015-07-07T03:09:46Z","updated_at":"2015-07-07T06:04:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2be39c853f5d80474fec59b155ef499b9c20abc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/christycui/myflix/pulls/4/commits","review_comments_url":"https://api.github.com/repos/christycui/myflix/pulls/4/comments","review_comment_url":"https://api.github.com/repos/christycui/myflix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/christycui/myflix/issues/4/comments","statuses_url":"https://api.github.com/repos/christycui/myflix/statuses/b7b371c29e0feddd8763efda50f0b6fcc50b51a2","head":{"label":"christycui:mod4","ref":"mod4","sha":"b7b371c29e0feddd8763efda50f0b6fcc50b51a2","user":{"login":"christycui","id":8649274,"avatar_url":"https://avatars.githubusercontent.com/u/8649274?v=3","gravatar_id":"","url":"https://api.github.com/users/christycui","html_url":"https://github.com/christycui","followers_url":"https://api.github.com/users/christycui/followers","following_url":"https://api.github.com/users/christycui/following{/other_user}","gists_url":"https://api.github.com/users/christycui/gists{/gist_id}","starred_url":"https://api.github.com/users/christycui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christycui/subscriptions","organizations_url":"https://api.github.com/users/christycui/orgs","repos_url":"https://api.github.com/users/christycui/repos","events_url":"https://api.github.com/users/christycui/events{/privacy}","received_events_url":"https://api.github.com/users/christycui/received_events","type":"User","site_admin":false},"repo":{"id":31712909,"name":"myflix","full_name":"christycui/myflix","owner":{"login":"christycui","id":8649274,"avatar_url":"https://avatars.githubusercontent.com/u/8649274?v=3","gravatar_id":"","url":"https://api.github.com/users/christycui","html_url":"https://github.com/christycui","followers_url":"https://api.github.com/users/christycui/followers","following_url":"https://api.github.com/users/christycui/following{/other_user}","gists_url":"https://api.github.com/users/christycui/gists{/gist_id}","starred_url":"https://api.github.com/users/christycui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christycui/subscriptions","organizations_url":"https://api.github.com/users/christycui/orgs","repos_url":"https://api.github.com/users/christycui/repos","events_url":"https://api.github.com/users/christycui/events{/privacy}","received_events_url":"https://api.github.com/users/christycui/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/christycui/myflix","description":"","fork":false,"url":"https://api.github.com/repos/christycui/myflix","forks_url":"https://api.github.com/repos/christycui/myflix/forks","keys_url":"https://api.github.com/repos/christycui/myflix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christycui/myflix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christycui/myflix/teams","hooks_url":"https://api.github.com/repos/christycui/myflix/hooks","issue_events_url":"https://api.github.com/repos/christycui/myflix/issues/events{/number}","events_url":"https://api.github.com/repos/christycui/myflix/events","assignees_url":"https://api.github.com/repos/christycui/myflix/assignees{/user}","branches_url":"https://api.github.com/repos/christycui/myflix/branches{/branch}","tags_url":"https://api.github.com/repos/christycui/myflix/tags","blobs_url":"https://api.github.com/repos/christycui/myflix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christycui/myflix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christycui/myflix/git/refs{/sha}","trees_url":"https://api.github.com/repos/christycui/myflix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christycui/myflix/statuses/{sha}","languages_url":"https://api.github.com/repos/christycui/myflix/languages","stargazers_url":"https://api.github.com/repos/christycui/myflix/stargazers","contributors_url":"https://api.github.com/repos/christycui/myflix/contributors","subscribers_url":"https://api.github.com/repos/christycui/myflix/subscribers","subscription_url":"https://api.github.com/repos/christycui/myflix/subscription","commits_url":"https://api.github.com/repos/christycui/myflix/commits{/sha}","git_commits_url":"https://api.github.com/repos/christycui/myflix/git/commits{/sha}","comments_url":"https://api.github.com/repos/christycui/myflix/comments{/number}","issue_comment_url":"https://api.github.com/repos/christycui/myflix/issues/comments{/number}","contents_url":"https://api.github.com/repos/christycui/myflix/contents/{+path}","compare_url":"https://api.github.com/repos/christycui/myflix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christycui/myflix/merges","archive_url":"https://api.github.com/repos/christycui/myflix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christycui/myflix/downloads","issues_url":"https://api.github.com/repos/christycui/myflix/issues{/number}","pulls_url":"https://api.github.com/repos/christycui/myflix/pulls{/number}","milestones_url":"https://api.github.com/repos/christycui/myflix/milestones{/number}","notifications_url":"https://api.github.com/repos/christycui/myflix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christycui/myflix/labels{/name}","releases_url":"https://api.github.com/repos/christycui/myflix/releases{/id}","created_at":"2015-03-05T12:34:32Z","updated_at":"2015-03-25T20:19:48Z","pushed_at":"2015-07-07T03:09:46Z","git_url":"git://github.com/christycui/myflix.git","ssh_url":"git@github.com:christycui/myflix.git","clone_url":"https://github.com/christycui/myflix.git","svn_url":"https://github.com/christycui/myflix","homepage":null,"size":460,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"christycui:master","ref":"master","sha":"250d0fae8254b8e77263f854086bde131e5749d9","user":{"login":"christycui","id":8649274,"avatar_url":"https://avatars.githubusercontent.com/u/8649274?v=3","gravatar_id":"","url":"https://api.github.com/users/christycui","html_url":"https://github.com/christycui","followers_url":"https://api.github.com/users/christycui/followers","following_url":"https://api.github.com/users/christycui/following{/other_user}","gists_url":"https://api.github.com/users/christycui/gists{/gist_id}","starred_url":"https://api.github.com/users/christycui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christycui/subscriptions","organizations_url":"https://api.github.com/users/christycui/orgs","repos_url":"https://api.github.com/users/christycui/repos","events_url":"https://api.github.com/users/christycui/events{/privacy}","received_events_url":"https://api.github.com/users/christycui/received_events","type":"User","site_admin":false},"repo":{"id":31712909,"name":"myflix","full_name":"christycui/myflix","owner":{"login":"christycui","id":8649274,"avatar_url":"https://avatars.githubusercontent.com/u/8649274?v=3","gravatar_id":"","url":"https://api.github.com/users/christycui","html_url":"https://github.com/christycui","followers_url":"https://api.github.com/users/christycui/followers","following_url":"https://api.github.com/users/christycui/following{/other_user}","gists_url":"https://api.github.com/users/christycui/gists{/gist_id}","starred_url":"https://api.github.com/users/christycui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christycui/subscriptions","organizations_url":"https://api.github.com/users/christycui/orgs","repos_url":"https://api.github.com/users/christycui/repos","events_url":"https://api.github.com/users/christycui/events{/privacy}","received_events_url":"https://api.github.com/users/christycui/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/christycui/myflix","description":"","fork":false,"url":"https://api.github.com/repos/christycui/myflix","forks_url":"https://api.github.com/repos/christycui/myflix/forks","keys_url":"https://api.github.com/repos/christycui/myflix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christycui/myflix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christycui/myflix/teams","hooks_url":"https://api.github.com/repos/christycui/myflix/hooks","issue_events_url":"https://api.github.com/repos/christycui/myflix/issues/events{/number}","events_url":"https://api.github.com/repos/christycui/myflix/events","assignees_url":"https://api.github.com/repos/christycui/myflix/assignees{/user}","branches_url":"https://api.github.com/repos/christycui/myflix/branches{/branch}","tags_url":"https://api.github.com/repos/christycui/myflix/tags","blobs_url":"https://api.github.com/repos/christycui/myflix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christycui/myflix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christycui/myflix/git/refs{/sha}","trees_url":"https://api.github.com/repos/christycui/myflix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christycui/myflix/statuses/{sha}","languages_url":"https://api.github.com/repos/christycui/myflix/languages","stargazers_url":"https://api.github.com/repos/christycui/myflix/stargazers","contributors_url":"https://api.github.com/repos/christycui/myflix/contributors","subscribers_url":"https://api.github.com/repos/christycui/myflix/subscribers","subscription_url":"https://api.github.com/repos/christycui/myflix/subscription","commits_url":"https://api.github.com/repos/christycui/myflix/commits{/sha}","git_commits_url":"https://api.github.com/repos/christycui/myflix/git/commits{/sha}","comments_url":"https://api.github.com/repos/christycui/myflix/comments{/number}","issue_comment_url":"https://api.github.com/repos/christycui/myflix/issues/comments{/number}","contents_url":"https://api.github.com/repos/christycui/myflix/contents/{+path}","compare_url":"https://api.github.com/repos/christycui/myflix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christycui/myflix/merges","archive_url":"https://api.github.com/repos/christycui/myflix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christycui/myflix/downloads","issues_url":"https://api.github.com/repos/christycui/myflix/issues{/number}","pulls_url":"https://api.github.com/repos/christycui/myflix/pulls{/number}","milestones_url":"https://api.github.com/repos/christycui/myflix/milestones{/number}","notifications_url":"https://api.github.com/repos/christycui/myflix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christycui/myflix/labels{/name}","releases_url":"https://api.github.com/repos/christycui/myflix/releases{/id}","created_at":"2015-03-05T12:34:32Z","updated_at":"2015-03-25T20:19:48Z","pushed_at":"2015-07-07T03:09:46Z","git_url":"git://github.com/christycui/myflix.git","ssh_url":"git@github.com:christycui/myflix.git","clone_url":"https://github.com/christycui/myflix.git","svn_url":"https://github.com/christycui/myflix","homepage":null,"size":460,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/christycui/myflix/pulls/4"},"html":{"href":"https://github.com/christycui/myflix/pull/4"},"issue":{"href":"https://api.github.com/repos/christycui/myflix/issues/4"},"comments":{"href":"https://api.github.com/repos/christycui/myflix/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/christycui/myflix/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/christycui/myflix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/christycui/myflix/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/christycui/myflix/statuses/b7b371c29e0feddd8763efda50f0b6fcc50b51a2"}}}}