{"action":"closed","number":64,"pull_request":{"url":"https://api.github.com/repos/caitp/angular-drop/pulls/64","id":33490409,"html_url":"https://github.com/caitp/angular-drop/pull/64","diff_url":"https://github.com/caitp/angular-drop/pull/64.diff","patch_url":"https://github.com/caitp/angular-drop/pull/64.patch","issue_url":"https://api.github.com/repos/caitp/angular-drop/issues/64","number":64,"state":"closed","locked":false,"title":"fix($drag): offset dragged element relative to first positioned ancestor","user":{"login":"adam77","id":1613230,"avatar_url":"https://avatars.githubusercontent.com/u/1613230?v=3","gravatar_id":"","url":"https://api.github.com/users/adam77","html_url":"https://github.com/adam77","followers_url":"https://api.github.com/users/adam77/followers","following_url":"https://api.github.com/users/adam77/following{/other_user}","gists_url":"https://api.github.com/users/adam77/gists{/gist_id}","starred_url":"https://api.github.com/users/adam77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam77/subscriptions","organizations_url":"https://api.github.com/users/adam77/orgs","repos_url":"https://api.github.com/users/adam77/repos","events_url":"https://api.github.com/users/adam77/events{/privacy}","received_events_url":"https://api.github.com/users/adam77/received_events","type":"User","site_admin":false},"body":"fixes #63 \r\nNotes:\r\n* $dndPosition is a stripped down version of $position from angular-ui/bootstrap.\r\n* Removed draggable.positionAbs as it didn't appear to be in use.\r\n* Fixed a bug in draggable when using jqlite that showed up in the new test (relevant jqlite bug: https://github.com/angular/angular.js/pull/11614).\r\n* Manually tested OK in IE9.\r\n\r\nAt some point the DOM utils stuff could be merged with $dndPosition perhaps.","created_at":"2015-04-16T20:40:04Z","updated_at":"2015-04-17T03:36:41Z","closed_at":"2015-04-17T03:36:41Z","merged_at":null,"merge_commit_sha":"bf714e3820ee5c6404bbb663cd0e12173c0b472d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/caitp/angular-drop/pulls/64/commits","review_comments_url":"https://api.github.com/repos/caitp/angular-drop/pulls/64/comments","review_comment_url":"https://api.github.com/repos/caitp/angular-drop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caitp/angular-drop/issues/64/comments","statuses_url":"https://api.github.com/repos/caitp/angular-drop/statuses/32fda4017ea82e499570328d232e55bb301bb4c4","head":{"label":"adam77:offset-fix","ref":"offset-fix","sha":"32fda4017ea82e499570328d232e55bb301bb4c4","user":{"login":"adam77","id":1613230,"avatar_url":"https://avatars.githubusercontent.com/u/1613230?v=3","gravatar_id":"","url":"https://api.github.com/users/adam77","html_url":"https://github.com/adam77","followers_url":"https://api.github.com/users/adam77/followers","following_url":"https://api.github.com/users/adam77/following{/other_user}","gists_url":"https://api.github.com/users/adam77/gists{/gist_id}","starred_url":"https://api.github.com/users/adam77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam77/subscriptions","organizations_url":"https://api.github.com/users/adam77/orgs","repos_url":"https://api.github.com/users/adam77/repos","events_url":"https://api.github.com/users/adam77/events{/privacy}","received_events_url":"https://api.github.com/users/adam77/received_events","type":"User","site_admin":false},"repo":{"id":34025040,"name":"angular-drop","full_name":"adam77/angular-drop","owner":{"login":"adam77","id":1613230,"avatar_url":"https://avatars.githubusercontent.com/u/1613230?v=3","gravatar_id":"","url":"https://api.github.com/users/adam77","html_url":"https://github.com/adam77","followers_url":"https://api.github.com/users/adam77/followers","following_url":"https://api.github.com/users/adam77/following{/other_user}","gists_url":"https://api.github.com/users/adam77/gists{/gist_id}","starred_url":"https://api.github.com/users/adam77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam77/subscriptions","organizations_url":"https://api.github.com/users/adam77/orgs","repos_url":"https://api.github.com/users/adam77/repos","events_url":"https://api.github.com/users/adam77/events{/privacy}","received_events_url":"https://api.github.com/users/adam77/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adam77/angular-drop","description":"Drag & Drop functionality in AngularJS, no jQuery required","fork":true,"url":"https://api.github.com/repos/adam77/angular-drop","forks_url":"https://api.github.com/repos/adam77/angular-drop/forks","keys_url":"https://api.github.com/repos/adam77/angular-drop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adam77/angular-drop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adam77/angular-drop/teams","hooks_url":"https://api.github.com/repos/adam77/angular-drop/hooks","issue_events_url":"https://api.github.com/repos/adam77/angular-drop/issues/events{/number}","events_url":"https://api.github.com/repos/adam77/angular-drop/events","assignees_url":"https://api.github.com/repos/adam77/angular-drop/assignees{/user}","branches_url":"https://api.github.com/repos/adam77/angular-drop/branches{/branch}","tags_url":"https://api.github.com/repos/adam77/angular-drop/tags","blobs_url":"https://api.github.com/repos/adam77/angular-drop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adam77/angular-drop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adam77/angular-drop/git/refs{/sha}","trees_url":"https://api.github.com/repos/adam77/angular-drop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adam77/angular-drop/statuses/{sha}","languages_url":"https://api.github.com/repos/adam77/angular-drop/languages","stargazers_url":"https://api.github.com/repos/adam77/angular-drop/stargazers","contributors_url":"https://api.github.com/repos/adam77/angular-drop/contributors","subscribers_url":"https://api.github.com/repos/adam77/angular-drop/subscribers","subscription_url":"https://api.github.com/repos/adam77/angular-drop/subscription","commits_url":"https://api.github.com/repos/adam77/angular-drop/commits{/sha}","git_commits_url":"https://api.github.com/repos/adam77/angular-drop/git/commits{/sha}","comments_url":"https://api.github.com/repos/adam77/angular-drop/comments{/number}","issue_comment_url":"https://api.github.com/repos/adam77/angular-drop/issues/comments{/number}","contents_url":"https://api.github.com/repos/adam77/angular-drop/contents/{+path}","compare_url":"https://api.github.com/repos/adam77/angular-drop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adam77/angular-drop/merges","archive_url":"https://api.github.com/repos/adam77/angular-drop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adam77/angular-drop/downloads","issues_url":"https://api.github.com/repos/adam77/angular-drop/issues{/number}","pulls_url":"https://api.github.com/repos/adam77/angular-drop/pulls{/number}","milestones_url":"https://api.github.com/repos/adam77/angular-drop/milestones{/number}","notifications_url":"https://api.github.com/repos/adam77/angular-drop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adam77/angular-drop/labels{/name}","releases_url":"https://api.github.com/repos/adam77/angular-drop/releases{/id}","created_at":"2015-04-16T00:09:33Z","updated_at":"2015-04-17T02:56:39Z","pushed_at":"2015-04-17T03:06:47Z","git_url":"git://github.com/adam77/angular-drop.git","ssh_url":"git@github.com:adam77/angular-drop.git","clone_url":"https://github.com/adam77/angular-drop.git","svn_url":"https://github.com/adam77/angular-drop","homepage":"http://caitp.github.io/angular-drop","size":1379,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"caitp:master","ref":"master","sha":"97e2caed3bdb4049f19b1989edd8df19d1d69e51","user":{"login":"caitp","id":2294695,"avatar_url":"https://avatars.githubusercontent.com/u/2294695?v=3","gravatar_id":"","url":"https://api.github.com/users/caitp","html_url":"https://github.com/caitp","followers_url":"https://api.github.com/users/caitp/followers","following_url":"https://api.github.com/users/caitp/following{/other_user}","gists_url":"https://api.github.com/users/caitp/gists{/gist_id}","starred_url":"https://api.github.com/users/caitp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caitp/subscriptions","organizations_url":"https://api.github.com/users/caitp/orgs","repos_url":"https://api.github.com/users/caitp/repos","events_url":"https://api.github.com/users/caitp/events{/privacy}","received_events_url":"https://api.github.com/users/caitp/received_events","type":"User","site_admin":false},"repo":{"id":13914863,"name":"angular-drop","full_name":"caitp/angular-drop","owner":{"login":"caitp","id":2294695,"avatar_url":"https://avatars.githubusercontent.com/u/2294695?v=3","gravatar_id":"","url":"https://api.github.com/users/caitp","html_url":"https://github.com/caitp","followers_url":"https://api.github.com/users/caitp/followers","following_url":"https://api.github.com/users/caitp/following{/other_user}","gists_url":"https://api.github.com/users/caitp/gists{/gist_id}","starred_url":"https://api.github.com/users/caitp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caitp/subscriptions","organizations_url":"https://api.github.com/users/caitp/orgs","repos_url":"https://api.github.com/users/caitp/repos","events_url":"https://api.github.com/users/caitp/events{/privacy}","received_events_url":"https://api.github.com/users/caitp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caitp/angular-drop","description":"Drag & Drop functionality in AngularJS, no jQuery required","fork":false,"url":"https://api.github.com/repos/caitp/angular-drop","forks_url":"https://api.github.com/repos/caitp/angular-drop/forks","keys_url":"https://api.github.com/repos/caitp/angular-drop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caitp/angular-drop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caitp/angular-drop/teams","hooks_url":"https://api.github.com/repos/caitp/angular-drop/hooks","issue_events_url":"https://api.github.com/repos/caitp/angular-drop/issues/events{/number}","events_url":"https://api.github.com/repos/caitp/angular-drop/events","assignees_url":"https://api.github.com/repos/caitp/angular-drop/assignees{/user}","branches_url":"https://api.github.com/repos/caitp/angular-drop/branches{/branch}","tags_url":"https://api.github.com/repos/caitp/angular-drop/tags","blobs_url":"https://api.github.com/repos/caitp/angular-drop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caitp/angular-drop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caitp/angular-drop/git/refs{/sha}","trees_url":"https://api.github.com/repos/caitp/angular-drop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caitp/angular-drop/statuses/{sha}","languages_url":"https://api.github.com/repos/caitp/angular-drop/languages","stargazers_url":"https://api.github.com/repos/caitp/angular-drop/stargazers","contributors_url":"https://api.github.com/repos/caitp/angular-drop/contributors","subscribers_url":"https://api.github.com/repos/caitp/angular-drop/subscribers","subscription_url":"https://api.github.com/repos/caitp/angular-drop/subscription","commits_url":"https://api.github.com/repos/caitp/angular-drop/commits{/sha}","git_commits_url":"https://api.github.com/repos/caitp/angular-drop/git/commits{/sha}","comments_url":"https://api.github.com/repos/caitp/angular-drop/comments{/number}","issue_comment_url":"https://api.github.com/repos/caitp/angular-drop/issues/comments{/number}","contents_url":"https://api.github.com/repos/caitp/angular-drop/contents/{+path}","compare_url":"https://api.github.com/repos/caitp/angular-drop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caitp/angular-drop/merges","archive_url":"https://api.github.com/repos/caitp/angular-drop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caitp/angular-drop/downloads","issues_url":"https://api.github.com/repos/caitp/angular-drop/issues{/number}","pulls_url":"https://api.github.com/repos/caitp/angular-drop/pulls{/number}","milestones_url":"https://api.github.com/repos/caitp/angular-drop/milestones{/number}","notifications_url":"https://api.github.com/repos/caitp/angular-drop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caitp/angular-drop/labels{/name}","releases_url":"https://api.github.com/repos/caitp/angular-drop/releases{/id}","created_at":"2013-10-28T02:26:17Z","updated_at":"2015-04-17T02:39:02Z","pushed_at":"2015-04-17T03:36:41Z","git_url":"git://github.com/caitp/angular-drop.git","ssh_url":"git@github.com:caitp/angular-drop.git","clone_url":"https://github.com/caitp/angular-drop.git","svn_url":"https://github.com/caitp/angular-drop","homepage":"http://caitp.github.io/angular-drop","size":1953,"stargazers_count":152,"watchers_count":152,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":7,"forks":16,"open_issues":7,"watchers":152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caitp/angular-drop/pulls/64"},"html":{"href":"https://github.com/caitp/angular-drop/pull/64"},"issue":{"href":"https://api.github.com/repos/caitp/angular-drop/issues/64"},"comments":{"href":"https://api.github.com/repos/caitp/angular-drop/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/caitp/angular-drop/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/caitp/angular-drop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caitp/angular-drop/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/caitp/angular-drop/statuses/32fda4017ea82e499570328d232e55bb301bb4c4"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":15,"review_comments":2,"commits":12,"additions":245,"deletions":163,"changed_files":7}}