{"action":"created","comment":{"url":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/comments/39133800","id":39133800,"diff_hunk":"@@ -17,22 +15,22 @@ class SettingsController extends Controller {\n \n \tpublic function modifyAction(Request $request) {\n \t\t$em = $this->getDoctrine()->getManager();\n-\t\t$repo = $em->getRepository(get_class(new Setting()));\n+\t\t$repo = $em->getRepository('Craue\\ConfigBundle\\Entity\\Setting');\n \t\t$allStoredSettings = $repo->findAll();\n \n \t\t$formData = array(\n \t\t\t'settings' => $allStoredSettings,\n \t\t);\n \n-\t\t$form = Kernel::VERSION_ID < 20800\n-\t\t\t? $this->createForm(new LegacyModifySettingsForm(), $formData)\n-\t\t\t: $this->get('form.factory')->createNamed('craue_config_modifySettings', 'Craue\\ConfigBundle\\Form\\ModifySettingsForm', $formData);\n+\t\t$form = method_exists('Symfony\\Component\\Form\\AbstractType', 'getBlockPrefix')\n+\t\t\t? $this->get('form.factory')->createNamed('craue_config_modifySettings', 'Craue\\ConfigBundle\\Form\\ModifySettingsForm', $formData)","path":"Controller/SettingsController.php","position":27,"original_position":27,"commit_id":"608439019b2f0b245866b4d43559517f6184889e","original_commit_id":"608439019b2f0b245866b4d43559517f6184889e","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"it uses the block prefix as the default name","created_at":"2015-09-10T07:57:28Z","updated_at":"2015-09-10T07:57:28Z","html_url":"https://github.com/craue/CraueConfigBundle/pull/23#discussion_r39133800","pull_request_url":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/comments/39133800"},"html":{"href":"https://github.com/craue/CraueConfigBundle/pull/23#discussion_r39133800"},"pull_request":{"href":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/23","id":44563134,"html_url":"https://github.com/craue/CraueConfigBundle/pull/23","diff_url":"https://github.com/craue/CraueConfigBundle/pull/23.diff","patch_url":"https://github.com/craue/CraueConfigBundle/pull/23.patch","issue_url":"https://api.github.com/repos/craue/CraueConfigBundle/issues/23","number":23,"state":"open","locked":false,"title":"further improvements based on comments to #22","user":{"login":"craue","id":800119,"avatar_url":"https://avatars.githubusercontent.com/u/800119?v=3","gravatar_id":"","url":"https://api.github.com/users/craue","html_url":"https://github.com/craue","followers_url":"https://api.github.com/users/craue/followers","following_url":"https://api.github.com/users/craue/following{/other_user}","gists_url":"https://api.github.com/users/craue/gists{/gist_id}","starred_url":"https://api.github.com/users/craue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craue/subscriptions","organizations_url":"https://api.github.com/users/craue/orgs","repos_url":"https://api.github.com/users/craue/repos","events_url":"https://api.github.com/users/craue/events{/privacy}","received_events_url":"https://api.github.com/users/craue/received_events","type":"User","site_admin":false},"body":"This improves the code based on comments to #22.","created_at":"2015-09-09T15:18:57Z","updated_at":"2015-09-10T07:57:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18b377ced841f9713e3e9241e215fa9786d2f5f7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/23/commits","review_comments_url":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/23/comments","review_comment_url":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/craue/CraueConfigBundle/issues/23/comments","statuses_url":"https://api.github.com/repos/craue/CraueConfigBundle/statuses/608439019b2f0b245866b4d43559517f6184889e","head":{"label":"craue:avoid-deprecation-notices-reloaded","ref":"avoid-deprecation-notices-reloaded","sha":"608439019b2f0b245866b4d43559517f6184889e","user":{"login":"craue","id":800119,"avatar_url":"https://avatars.githubusercontent.com/u/800119?v=3","gravatar_id":"","url":"https://api.github.com/users/craue","html_url":"https://github.com/craue","followers_url":"https://api.github.com/users/craue/followers","following_url":"https://api.github.com/users/craue/following{/other_user}","gists_url":"https://api.github.com/users/craue/gists{/gist_id}","starred_url":"https://api.github.com/users/craue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craue/subscriptions","organizations_url":"https://api.github.com/users/craue/orgs","repos_url":"https://api.github.com/users/craue/repos","events_url":"https://api.github.com/users/craue/events{/privacy}","received_events_url":"https://api.github.com/users/craue/received_events","type":"User","site_admin":false},"repo":{"id":2011216,"name":"CraueConfigBundle","full_name":"craue/CraueConfigBundle","owner":{"login":"craue","id":800119,"avatar_url":"https://avatars.githubusercontent.com/u/800119?v=3","gravatar_id":"","url":"https://api.github.com/users/craue","html_url":"https://github.com/craue","followers_url":"https://api.github.com/users/craue/followers","following_url":"https://api.github.com/users/craue/following{/other_user}","gists_url":"https://api.github.com/users/craue/gists{/gist_id}","starred_url":"https://api.github.com/users/craue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craue/subscriptions","organizations_url":"https://api.github.com/users/craue/orgs","repos_url":"https://api.github.com/users/craue/repos","events_url":"https://api.github.com/users/craue/events{/privacy}","received_events_url":"https://api.github.com/users/craue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/craue/CraueConfigBundle","description":"Database-stored settings made available via a service for your Symfony2 project.","fork":false,"url":"https://api.github.com/repos/craue/CraueConfigBundle","forks_url":"https://api.github.com/repos/craue/CraueConfigBundle/forks","keys_url":"https://api.github.com/repos/craue/CraueConfigBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/craue/CraueConfigBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/craue/CraueConfigBundle/teams","hooks_url":"https://api.github.com/repos/craue/CraueConfigBundle/hooks","issue_events_url":"https://api.github.com/repos/craue/CraueConfigBundle/issues/events{/number}","events_url":"https://api.github.com/repos/craue/CraueConfigBundle/events","assignees_url":"https://api.github.com/repos/craue/CraueConfigBundle/assignees{/user}","branches_url":"https://api.github.com/repos/craue/CraueConfigBundle/branches{/branch}","tags_url":"https://api.github.com/repos/craue/CraueConfigBundle/tags","blobs_url":"https://api.github.com/repos/craue/CraueConfigBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/craue/CraueConfigBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/craue/CraueConfigBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/craue/CraueConfigBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/craue/CraueConfigBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/craue/CraueConfigBundle/languages","stargazers_url":"https://api.github.com/repos/craue/CraueConfigBundle/stargazers","contributors_url":"https://api.github.com/repos/craue/CraueConfigBundle/contributors","subscribers_url":"https://api.github.com/repos/craue/CraueConfigBundle/subscribers","subscription_url":"https://api.github.com/repos/craue/CraueConfigBundle/subscription","commits_url":"https://api.github.com/repos/craue/CraueConfigBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/craue/CraueConfigBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/craue/CraueConfigBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/craue/CraueConfigBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/craue/CraueConfigBundle/contents/{+path}","compare_url":"https://api.github.com/repos/craue/CraueConfigBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/craue/CraueConfigBundle/merges","archive_url":"https://api.github.com/repos/craue/CraueConfigBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/craue/CraueConfigBundle/downloads","issues_url":"https://api.github.com/repos/craue/CraueConfigBundle/issues{/number}","pulls_url":"https://api.github.com/repos/craue/CraueConfigBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/craue/CraueConfigBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/craue/CraueConfigBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/craue/CraueConfigBundle/labels{/name}","releases_url":"https://api.github.com/repos/craue/CraueConfigBundle/releases{/id}","created_at":"2011-07-07T08:39:50Z","updated_at":"2015-09-10T07:30:55Z","pushed_at":"2015-09-10T02:43:31Z","git_url":"git://github.com/craue/CraueConfigBundle.git","ssh_url":"git@github.com:craue/CraueConfigBundle.git","clone_url":"https://github.com/craue/CraueConfigBundle.git","svn_url":"https://github.com/craue/CraueConfigBundle","homepage":"","size":517,"stargazers_count":57,"watchers_count":57,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":9,"forks":16,"open_issues":9,"watchers":57,"default_branch":"master"}},"base":{"label":"craue:master","ref":"master","sha":"d2c00dd963e02f9f3a1275e85338d6376c196e2d","user":{"login":"craue","id":800119,"avatar_url":"https://avatars.githubusercontent.com/u/800119?v=3","gravatar_id":"","url":"https://api.github.com/users/craue","html_url":"https://github.com/craue","followers_url":"https://api.github.com/users/craue/followers","following_url":"https://api.github.com/users/craue/following{/other_user}","gists_url":"https://api.github.com/users/craue/gists{/gist_id}","starred_url":"https://api.github.com/users/craue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craue/subscriptions","organizations_url":"https://api.github.com/users/craue/orgs","repos_url":"https://api.github.com/users/craue/repos","events_url":"https://api.github.com/users/craue/events{/privacy}","received_events_url":"https://api.github.com/users/craue/received_events","type":"User","site_admin":false},"repo":{"id":2011216,"name":"CraueConfigBundle","full_name":"craue/CraueConfigBundle","owner":{"login":"craue","id":800119,"avatar_url":"https://avatars.githubusercontent.com/u/800119?v=3","gravatar_id":"","url":"https://api.github.com/users/craue","html_url":"https://github.com/craue","followers_url":"https://api.github.com/users/craue/followers","following_url":"https://api.github.com/users/craue/following{/other_user}","gists_url":"https://api.github.com/users/craue/gists{/gist_id}","starred_url":"https://api.github.com/users/craue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craue/subscriptions","organizations_url":"https://api.github.com/users/craue/orgs","repos_url":"https://api.github.com/users/craue/repos","events_url":"https://api.github.com/users/craue/events{/privacy}","received_events_url":"https://api.github.com/users/craue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/craue/CraueConfigBundle","description":"Database-stored settings made available via a service for your Symfony2 project.","fork":false,"url":"https://api.github.com/repos/craue/CraueConfigBundle","forks_url":"https://api.github.com/repos/craue/CraueConfigBundle/forks","keys_url":"https://api.github.com/repos/craue/CraueConfigBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/craue/CraueConfigBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/craue/CraueConfigBundle/teams","hooks_url":"https://api.github.com/repos/craue/CraueConfigBundle/hooks","issue_events_url":"https://api.github.com/repos/craue/CraueConfigBundle/issues/events{/number}","events_url":"https://api.github.com/repos/craue/CraueConfigBundle/events","assignees_url":"https://api.github.com/repos/craue/CraueConfigBundle/assignees{/user}","branches_url":"https://api.github.com/repos/craue/CraueConfigBundle/branches{/branch}","tags_url":"https://api.github.com/repos/craue/CraueConfigBundle/tags","blobs_url":"https://api.github.com/repos/craue/CraueConfigBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/craue/CraueConfigBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/craue/CraueConfigBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/craue/CraueConfigBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/craue/CraueConfigBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/craue/CraueConfigBundle/languages","stargazers_url":"https://api.github.com/repos/craue/CraueConfigBundle/stargazers","contributors_url":"https://api.github.com/repos/craue/CraueConfigBundle/contributors","subscribers_url":"https://api.github.com/repos/craue/CraueConfigBundle/subscribers","subscription_url":"https://api.github.com/repos/craue/CraueConfigBundle/subscription","commits_url":"https://api.github.com/repos/craue/CraueConfigBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/craue/CraueConfigBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/craue/CraueConfigBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/craue/CraueConfigBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/craue/CraueConfigBundle/contents/{+path}","compare_url":"https://api.github.com/repos/craue/CraueConfigBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/craue/CraueConfigBundle/merges","archive_url":"https://api.github.com/repos/craue/CraueConfigBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/craue/CraueConfigBundle/downloads","issues_url":"https://api.github.com/repos/craue/CraueConfigBundle/issues{/number}","pulls_url":"https://api.github.com/repos/craue/CraueConfigBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/craue/CraueConfigBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/craue/CraueConfigBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/craue/CraueConfigBundle/labels{/name}","releases_url":"https://api.github.com/repos/craue/CraueConfigBundle/releases{/id}","created_at":"2011-07-07T08:39:50Z","updated_at":"2015-09-10T07:30:55Z","pushed_at":"2015-09-10T02:43:31Z","git_url":"git://github.com/craue/CraueConfigBundle.git","ssh_url":"git@github.com:craue/CraueConfigBundle.git","clone_url":"https://github.com/craue/CraueConfigBundle.git","svn_url":"https://github.com/craue/CraueConfigBundle","homepage":"","size":517,"stargazers_count":57,"watchers_count":57,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":9,"forks":16,"open_issues":9,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/23"},"html":{"href":"https://github.com/craue/CraueConfigBundle/pull/23"},"issue":{"href":"https://api.github.com/repos/craue/CraueConfigBundle/issues/23"},"comments":{"href":"https://api.github.com/repos/craue/CraueConfigBundle/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/craue/CraueConfigBundle/statuses/608439019b2f0b245866b4d43559517f6184889e"}}}}