{"action":"created","issue":{"url":"https://api.github.com/repos/es-shims/es5-shim/issues/316","labels_url":"https://api.github.com/repos/es-shims/es5-shim/issues/316/labels{/name}","comments_url":"https://api.github.com/repos/es-shims/es5-shim/issues/316/comments","events_url":"https://api.github.com/repos/es-shims/es5-shim/issues/316/events","html_url":"https://github.com/es-shims/es5-shim/pull/316","id":91170343,"number":316,"title":"Update String#trim","user":{"login":"lewisje","id":4865237,"avatar_url":"https://avatars.githubusercontent.com/u/4865237?v=3","gravatar_id":"","url":"https://api.github.com/users/lewisje","html_url":"https://github.com/lewisje","followers_url":"https://api.github.com/users/lewisje/followers","following_url":"https://api.github.com/users/lewisje/following{/other_user}","gists_url":"https://api.github.com/users/lewisje/gists{/gist_id}","starred_url":"https://api.github.com/users/lewisje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewisje/subscriptions","organizations_url":"https://api.github.com/users/lewisje/orgs","repos_url":"https://api.github.com/users/lewisje/repos","events_url":"https://api.github.com/users/lewisje/events{/privacy}","received_events_url":"https://api.github.com/users/lewisje/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/es-shims/es5-shim/labels/noncompliant%20ES5","name":"noncompliant ES5","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2015-06-26T06:30:43Z","updated_at":"2015-06-26T08:31:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/es-shims/es5-shim/pulls/316","html_url":"https://github.com/es-shims/es5-shim/pull/316","diff_url":"https://github.com/es-shims/es5-shim/pull/316.diff","patch_url":"https://github.com/es-shims/es5-shim/pull/316.patch"},"body":"Test for incorrect trimming of two whitespace characters instead of just one, reduce the number of string concatenations, and more quickly determine `hasTrimWhitespaceBug` to be false in the usual pre-ES5 case.\r\n\r\nI would change `if (typeof this === 'undefined' || this === null)` to `if (this == null)` but I don't know whether that's allowed by this library's style guide."},"comment":{"url":"https://api.github.com/repos/es-shims/es5-shim/issues/comments/115573901","html_url":"https://github.com/es-shims/es5-shim/pull/316#issuecomment-115573901","issue_url":"https://api.github.com/repos/es-shims/es5-shim/issues/316","id":115573901,"user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"created_at":"2015-06-26T08:31:49Z","updated_at":"2015-06-26T08:31:49Z","body":"It's totally fine to have es5-shim use one version, and es6-shim use another."}}