{"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/elstargazer/ceres/pulls/2","id":42544488,"html_url":"https://github.com/elstargazer/ceres/pull/2","diff_url":"https://github.com/elstargazer/ceres/pull/2.diff","patch_url":"https://github.com/elstargazer/ceres/pull/2.patch","issue_url":"https://api.github.com/repos/elstargazer/ceres/issues/2","number":2,"state":"open","locked":false,"title":"Changed my favorite ellipsoid_fit function","user":{"login":"AntonErmakov","id":11699368,"avatar_url":"https://avatars.githubusercontent.com/u/11699368?v=3","gravatar_id":"","url":"https://api.github.com/users/AntonErmakov","html_url":"https://github.com/AntonErmakov","followers_url":"https://api.github.com/users/AntonErmakov/followers","following_url":"https://api.github.com/users/AntonErmakov/following{/other_user}","gists_url":"https://api.github.com/users/AntonErmakov/gists{/gist_id}","starred_url":"https://api.github.com/users/AntonErmakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntonErmakov/subscriptions","organizations_url":"https://api.github.com/users/AntonErmakov/orgs","repos_url":"https://api.github.com/users/AntonErmakov/repos","events_url":"https://api.github.com/users/AntonErmakov/events{/privacy}","received_events_url":"https://api.github.com/users/AntonErmakov/received_events","type":"User","site_admin":false},"body":"Hi Roger,\r\n\r\nIn these commits, I changed the ellipsoid_fit files. I noticed that you adapted my code in former FE_test class in an awkward way. FE_test class had many things which were not related to ellipsoid fitting, I got rid of them. I added a new private member object of ellipsoid_fit class to StokesProblem class. It is initialized in the constructor of StokesProblem by passing a pointer to triangulation, no need to copy triangulation (your cp_tr). So it's better for memory now. Also I changed the input parameters to the function that performs ellipsoid fit (compute_fit), now it takes a boundary id to which fitting should be done. I also renamed the file from \"ellipse_fit\" to \"ellipsoid fit\". I did corresponding changes in \"ceres.cc\" and tested them, it returned the same values as before. \r\n\r\nAnton.","created_at":"2015-08-16T22:12:15Z","updated_at":"2015-08-16T22:12:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elstargazer/ceres/pulls/2/commits","review_comments_url":"https://api.github.com/repos/elstargazer/ceres/pulls/2/comments","review_comment_url":"https://api.github.com/repos/elstargazer/ceres/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elstargazer/ceres/issues/2/comments","statuses_url":"https://api.github.com/repos/elstargazer/ceres/statuses/27e359c2b632195dd68653173e0b8cb18be7ed5a","head":{"label":"AntonErmakov:origin","ref":"origin","sha":"27e359c2b632195dd68653173e0b8cb18be7ed5a","user":{"login":"AntonErmakov","id":11699368,"avatar_url":"https://avatars.githubusercontent.com/u/11699368?v=3","gravatar_id":"","url":"https://api.github.com/users/AntonErmakov","html_url":"https://github.com/AntonErmakov","followers_url":"https://api.github.com/users/AntonErmakov/followers","following_url":"https://api.github.com/users/AntonErmakov/following{/other_user}","gists_url":"https://api.github.com/users/AntonErmakov/gists{/gist_id}","starred_url":"https://api.github.com/users/AntonErmakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntonErmakov/subscriptions","organizations_url":"https://api.github.com/users/AntonErmakov/orgs","repos_url":"https://api.github.com/users/AntonErmakov/repos","events_url":"https://api.github.com/users/AntonErmakov/events{/privacy}","received_events_url":"https://api.github.com/users/AntonErmakov/received_events","type":"User","site_admin":false},"repo":{"id":40790536,"name":"FE","full_name":"AntonErmakov/FE","owner":{"login":"AntonErmakov","id":11699368,"avatar_url":"https://avatars.githubusercontent.com/u/11699368?v=3","gravatar_id":"","url":"https://api.github.com/users/AntonErmakov","html_url":"https://github.com/AntonErmakov","followers_url":"https://api.github.com/users/AntonErmakov/followers","following_url":"https://api.github.com/users/AntonErmakov/following{/other_user}","gists_url":"https://api.github.com/users/AntonErmakov/gists{/gist_id}","starred_url":"https://api.github.com/users/AntonErmakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntonErmakov/subscriptions","organizations_url":"https://api.github.com/users/AntonErmakov/orgs","repos_url":"https://api.github.com/users/AntonErmakov/repos","events_url":"https://api.github.com/users/AntonErmakov/events{/privacy}","received_events_url":"https://api.github.com/users/AntonErmakov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AntonErmakov/FE","description":"relaxation code for ceres","fork":true,"url":"https://api.github.com/repos/AntonErmakov/FE","forks_url":"https://api.github.com/repos/AntonErmakov/FE/forks","keys_url":"https://api.github.com/repos/AntonErmakov/FE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AntonErmakov/FE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AntonErmakov/FE/teams","hooks_url":"https://api.github.com/repos/AntonErmakov/FE/hooks","issue_events_url":"https://api.github.com/repos/AntonErmakov/FE/issues/events{/number}","events_url":"https://api.github.com/repos/AntonErmakov/FE/events","assignees_url":"https://api.github.com/repos/AntonErmakov/FE/assignees{/user}","branches_url":"https://api.github.com/repos/AntonErmakov/FE/branches{/branch}","tags_url":"https://api.github.com/repos/AntonErmakov/FE/tags","blobs_url":"https://api.github.com/repos/AntonErmakov/FE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AntonErmakov/FE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AntonErmakov/FE/git/refs{/sha}","trees_url":"https://api.github.com/repos/AntonErmakov/FE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AntonErmakov/FE/statuses/{sha}","languages_url":"https://api.github.com/repos/AntonErmakov/FE/languages","stargazers_url":"https://api.github.com/repos/AntonErmakov/FE/stargazers","contributors_url":"https://api.github.com/repos/AntonErmakov/FE/contributors","subscribers_url":"https://api.github.com/repos/AntonErmakov/FE/subscribers","subscription_url":"https://api.github.com/repos/AntonErmakov/FE/subscription","commits_url":"https://api.github.com/repos/AntonErmakov/FE/commits{/sha}","git_commits_url":"https://api.github.com/repos/AntonErmakov/FE/git/commits{/sha}","comments_url":"https://api.github.com/repos/AntonErmakov/FE/comments{/number}","issue_comment_url":"https://api.github.com/repos/AntonErmakov/FE/issues/comments{/number}","contents_url":"https://api.github.com/repos/AntonErmakov/FE/contents/{+path}","compare_url":"https://api.github.com/repos/AntonErmakov/FE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AntonErmakov/FE/merges","archive_url":"https://api.github.com/repos/AntonErmakov/FE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AntonErmakov/FE/downloads","issues_url":"https://api.github.com/repos/AntonErmakov/FE/issues{/number}","pulls_url":"https://api.github.com/repos/AntonErmakov/FE/pulls{/number}","milestones_url":"https://api.github.com/repos/AntonErmakov/FE/milestones{/number}","notifications_url":"https://api.github.com/repos/AntonErmakov/FE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AntonErmakov/FE/labels{/name}","releases_url":"https://api.github.com/repos/AntonErmakov/FE/releases{/id}","created_at":"2015-08-15T23:05:50Z","updated_at":"2015-08-16T02:07:19Z","pushed_at":"2015-08-16T19:58:57Z","git_url":"git://github.com/AntonErmakov/FE.git","ssh_url":"git@github.com:AntonErmakov/FE.git","clone_url":"https://github.com/AntonErmakov/FE.git","svn_url":"https://github.com/AntonErmakov/FE","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"origin"}},"base":{"label":"elstargazer:origin","ref":"origin","sha":"b44cb932571a17f9d81143b19f8a82621d6e80fa","user":{"login":"elstargazer","id":12969209,"avatar_url":"https://avatars.githubusercontent.com/u/12969209?v=3","gravatar_id":"","url":"https://api.github.com/users/elstargazer","html_url":"https://github.com/elstargazer","followers_url":"https://api.github.com/users/elstargazer/followers","following_url":"https://api.github.com/users/elstargazer/following{/other_user}","gists_url":"https://api.github.com/users/elstargazer/gists{/gist_id}","starred_url":"https://api.github.com/users/elstargazer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elstargazer/subscriptions","organizations_url":"https://api.github.com/users/elstargazer/orgs","repos_url":"https://api.github.com/users/elstargazer/repos","events_url":"https://api.github.com/users/elstargazer/events{/privacy}","received_events_url":"https://api.github.com/users/elstargazer/received_events","type":"User","site_admin":false},"repo":{"id":40784504,"name":"ceres","full_name":"elstargazer/ceres","owner":{"login":"elstargazer","id":12969209,"avatar_url":"https://avatars.githubusercontent.com/u/12969209?v=3","gravatar_id":"","url":"https://api.github.com/users/elstargazer","html_url":"https://github.com/elstargazer","followers_url":"https://api.github.com/users/elstargazer/followers","following_url":"https://api.github.com/users/elstargazer/following{/other_user}","gists_url":"https://api.github.com/users/elstargazer/gists{/gist_id}","starred_url":"https://api.github.com/users/elstargazer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elstargazer/subscriptions","organizations_url":"https://api.github.com/users/elstargazer/orgs","repos_url":"https://api.github.com/users/elstargazer/repos","events_url":"https://api.github.com/users/elstargazer/events{/privacy}","received_events_url":"https://api.github.com/users/elstargazer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elstargazer/ceres","description":"relaxation code for ceres","fork":false,"url":"https://api.github.com/repos/elstargazer/ceres","forks_url":"https://api.github.com/repos/elstargazer/ceres/forks","keys_url":"https://api.github.com/repos/elstargazer/ceres/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elstargazer/ceres/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elstargazer/ceres/teams","hooks_url":"https://api.github.com/repos/elstargazer/ceres/hooks","issue_events_url":"https://api.github.com/repos/elstargazer/ceres/issues/events{/number}","events_url":"https://api.github.com/repos/elstargazer/ceres/events","assignees_url":"https://api.github.com/repos/elstargazer/ceres/assignees{/user}","branches_url":"https://api.github.com/repos/elstargazer/ceres/branches{/branch}","tags_url":"https://api.github.com/repos/elstargazer/ceres/tags","blobs_url":"https://api.github.com/repos/elstargazer/ceres/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elstargazer/ceres/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elstargazer/ceres/git/refs{/sha}","trees_url":"https://api.github.com/repos/elstargazer/ceres/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elstargazer/ceres/statuses/{sha}","languages_url":"https://api.github.com/repos/elstargazer/ceres/languages","stargazers_url":"https://api.github.com/repos/elstargazer/ceres/stargazers","contributors_url":"https://api.github.com/repos/elstargazer/ceres/contributors","subscribers_url":"https://api.github.com/repos/elstargazer/ceres/subscribers","subscription_url":"https://api.github.com/repos/elstargazer/ceres/subscription","commits_url":"https://api.github.com/repos/elstargazer/ceres/commits{/sha}","git_commits_url":"https://api.github.com/repos/elstargazer/ceres/git/commits{/sha}","comments_url":"https://api.github.com/repos/elstargazer/ceres/comments{/number}","issue_comment_url":"https://api.github.com/repos/elstargazer/ceres/issues/comments{/number}","contents_url":"https://api.github.com/repos/elstargazer/ceres/contents/{+path}","compare_url":"https://api.github.com/repos/elstargazer/ceres/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elstargazer/ceres/merges","archive_url":"https://api.github.com/repos/elstargazer/ceres/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elstargazer/ceres/downloads","issues_url":"https://api.github.com/repos/elstargazer/ceres/issues{/number}","pulls_url":"https://api.github.com/repos/elstargazer/ceres/pulls{/number}","milestones_url":"https://api.github.com/repos/elstargazer/ceres/milestones{/number}","notifications_url":"https://api.github.com/repos/elstargazer/ceres/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elstargazer/ceres/labels{/name}","releases_url":"https://api.github.com/repos/elstargazer/ceres/releases{/id}","created_at":"2015-08-15T20:54:16Z","updated_at":"2015-08-15T20:58:47Z","pushed_at":"2015-08-16T13:38:43Z","git_url":"git://github.com/elstargazer/ceres.git","ssh_url":"git@github.com:elstargazer/ceres.git","clone_url":"https://github.com/elstargazer/ceres.git","svn_url":"https://github.com/elstargazer/ceres","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"origin"}},"_links":{"self":{"href":"https://api.github.com/repos/elstargazer/ceres/pulls/2"},"html":{"href":"https://github.com/elstargazer/ceres/pull/2"},"issue":{"href":"https://api.github.com/repos/elstargazer/ceres/issues/2"},"comments":{"href":"https://api.github.com/repos/elstargazer/ceres/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/elstargazer/ceres/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/elstargazer/ceres/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elstargazer/ceres/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/elstargazer/ceres/statuses/27e359c2b632195dd68653173e0b8cb18be7ed5a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":142,"deletions":278,"changed_files":3}}