{"action":"created","issue":{"url":"https://api.github.com/repos/refinery/refinerycms/issues/2914","labels_url":"https://api.github.com/repos/refinery/refinerycms/issues/2914/labels{/name}","comments_url":"https://api.github.com/repos/refinery/refinerycms/issues/2914/comments","events_url":"https://api.github.com/repos/refinery/refinerycms/issues/2914/events","html_url":"https://github.com/refinery/refinerycms/pull/2914","id":59880147,"number":2914,"title":"If link_url set, Page.url (refinery.url_for) prefixes locale to URLs despite Refinery::I18n.url_filter_enabled = false","user":{"login":"LouisStAmour","id":53444,"avatar_url":"https://avatars.githubusercontent.com/u/53444?v=3","gravatar_id":"","url":"https://api.github.com/users/LouisStAmour","html_url":"https://github.com/LouisStAmour","followers_url":"https://api.github.com/users/LouisStAmour/followers","following_url":"https://api.github.com/users/LouisStAmour/following{/other_user}","gists_url":"https://api.github.com/users/LouisStAmour/gists{/gist_id}","starred_url":"https://api.github.com/users/LouisStAmour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LouisStAmour/subscriptions","organizations_url":"https://api.github.com/users/LouisStAmour/orgs","repos_url":"https://api.github.com/users/LouisStAmour/repos","events_url":"https://api.github.com/users/LouisStAmour/events{/privacy}","received_events_url":"https://api.github.com/users/LouisStAmour/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-04T23:29:48Z","updated_at":"2015-03-04T23:46:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/refinery/refinerycms/pulls/2914","html_url":"https://github.com/refinery/refinerycms/pull/2914","diff_url":"https://github.com/refinery/refinerycms/pull/2914.diff","patch_url":"https://github.com/refinery/refinerycms/pull/2914.patch"},"body":"This was a fun one, since sometimes it worked and sometimes it didn't. Eventually I realised that when it worked, a hash was returned and when it didn't, a string was returned, with a locale prefix. A-ha, checking the database it showed that when the string was returned, link_url was set. A bit of googling led me to link_url_localised? which eventually brought me to Refinery::Pages::Url::Localized (thank you changelog!) and finally to the spot where the check needed to be added.\r\n\r\nIt's been one heck of a whirlwind trying to get Refinery going under the latest stable Rails 4.2. I hit the Dragonfly SHA1 DDoS validation bug (probably need a rake task or migration to upgrade prior content to use sha1 hashes but for now I turned it off), I hit a bug, long-standing, where the admin panel seems to prefer loading content by ID number instead of how refinery blog prefers it (FriendlyID) so I had to force the blog to use ID numbers instead in admin panel (worked fine in front end), I also had to work around a few other smaller issues, and make sure I was loading off the git repo for basically every module out there, with the right 4-2-stable branches if they existed. Oh and there's a bug in the blogs module again where I had to disable the default blocks or every blog front-end page would error out with a Rails bug. I was so confused by this one I tried setting up a fresh copy, but encountered the same error. Luckily, I never liked the blocks layout approach anyway.\r\n\r\nIn the process of doing all of this, I cleaned up quite a bit of localization code. And the site feels a lot faster than it used to, though I haven't measured yet."},"comment":{"url":"https://api.github.com/repos/refinery/refinerycms/issues/comments/77276294","html_url":"https://github.com/refinery/refinerycms/pull/2914#issuecomment-77276294","issue_url":"https://api.github.com/repos/refinery/refinerycms/issues/2914","id":77276294,"user":{"login":"parndt","id":10128,"avatar_url":"https://avatars.githubusercontent.com/u/10128?v=3","gravatar_id":"","url":"https://api.github.com/users/parndt","html_url":"https://github.com/parndt","followers_url":"https://api.github.com/users/parndt/followers","following_url":"https://api.github.com/users/parndt/following{/other_user}","gists_url":"https://api.github.com/users/parndt/gists{/gist_id}","starred_url":"https://api.github.com/users/parndt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parndt/subscriptions","organizations_url":"https://api.github.com/users/parndt/orgs","repos_url":"https://api.github.com/users/parndt/repos","events_url":"https://api.github.com/users/parndt/events{/privacy}","received_events_url":"https://api.github.com/users/parndt/received_events","type":"User","site_admin":false},"created_at":"2015-03-04T23:46:34Z","updated_at":"2015-03-04T23:46:34Z","body":"This patch seems highly legit, I just have to wait for CI."}}