{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/29306237","id":29306237,"diff_hunk":"@@ -64,8 +64,10 @@ void grpc_winsocket_shutdown(grpc_winsocket *socket) {\n   shutdown_op(&socket->write_info);\n }\n \n-void grpc_winsocket_orphan(grpc_winsocket *socket) {\n-  grpc_iocp_socket_orphan(socket);\n+void grpc_winsocket_orphan(grpc_winsocket *socket, int increase_g_orphans) {\n+  if (increase_g_orphans) {\n+    grpc_iocp_socket_orphan(socket);","path":"src/core/iomgr/socket_windows.c","position":8,"original_position":8,"commit_id":"7048dc80d49ff8554c8484c7fc9aa77d5e4d063a","original_commit_id":"7048dc80d49ff8554c8484c7fc9aa77d5e4d063a","user":{"login":"nicolasnoble","id":7281574,"avatar_url":"https://avatars.githubusercontent.com/u/7281574?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolasnoble","html_url":"https://github.com/nicolasnoble","followers_url":"https://api.github.com/users/nicolasnoble/followers","following_url":"https://api.github.com/users/nicolasnoble/following{/other_user}","gists_url":"https://api.github.com/users/nicolasnoble/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasnoble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasnoble/subscriptions","organizations_url":"https://api.github.com/users/nicolasnoble/orgs","repos_url":"https://api.github.com/users/nicolasnoble/repos","events_url":"https://api.github.com/users/nicolasnoble/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasnoble/received_events","type":"User","site_admin":false},"body":"Or rather, \"`defer_destroy`\", as this is the terminology we're using in grpc.","created_at":"2015-04-29T02:13:55Z","updated_at":"2015-04-29T02:13:55Z","html_url":"https://github.com/grpc/grpc/pull/1401#discussion_r29306237","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/1401","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/29306237"},"html":{"href":"https://github.com/grpc/grpc/pull/1401#discussion_r29306237"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/1401"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/1401","id":34328479,"html_url":"https://github.com/grpc/grpc/pull/1401","diff_url":"https://github.com/grpc/grpc/pull/1401.diff","patch_url":"https://github.com/grpc/grpc/pull/1401.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/1401","number":1401,"state":"closed","locked":false,"title":"Fix issue #1387, don't increase g_orphans when connect failed.","user":{"login":"boolking","id":415515,"avatar_url":"https://avatars.githubusercontent.com/u/415515?v=3","gravatar_id":"","url":"https://api.github.com/users/boolking","html_url":"https://github.com/boolking","followers_url":"https://api.github.com/users/boolking/followers","following_url":"https://api.github.com/users/boolking/following{/other_user}","gists_url":"https://api.github.com/users/boolking/gists{/gist_id}","starred_url":"https://api.github.com/users/boolking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boolking/subscriptions","organizations_url":"https://api.github.com/users/boolking/orgs","repos_url":"https://api.github.com/users/boolking/repos","events_url":"https://api.github.com/users/boolking/events{/privacy}","received_events_url":"https://api.github.com/users/boolking/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-04-29T02:00:58Z","updated_at":"2015-04-29T02:13:55Z","closed_at":"2015-04-29T02:13:40Z","merged_at":null,"merge_commit_sha":"046b919a23da2dd99af990b116d1b77c45de1532","assignee":{"login":"nicolasnoble","id":7281574,"avatar_url":"https://avatars.githubusercontent.com/u/7281574?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolasnoble","html_url":"https://github.com/nicolasnoble","followers_url":"https://api.github.com/users/nicolasnoble/followers","following_url":"https://api.github.com/users/nicolasnoble/following{/other_user}","gists_url":"https://api.github.com/users/nicolasnoble/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasnoble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasnoble/subscriptions","organizations_url":"https://api.github.com/users/nicolasnoble/orgs","repos_url":"https://api.github.com/users/nicolasnoble/repos","events_url":"https://api.github.com/users/nicolasnoble/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasnoble/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/1401/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/1401/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/1401/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/7048dc80d49ff8554c8484c7fc9aa77d5e4d063a","head":{"label":"boolking:bugfix_1387","ref":"bugfix_1387","sha":"7048dc80d49ff8554c8484c7fc9aa77d5e4d063a","user":{"login":"boolking","id":415515,"avatar_url":"https://avatars.githubusercontent.com/u/415515?v=3","gravatar_id":"","url":"https://api.github.com/users/boolking","html_url":"https://github.com/boolking","followers_url":"https://api.github.com/users/boolking/followers","following_url":"https://api.github.com/users/boolking/following{/other_user}","gists_url":"https://api.github.com/users/boolking/gists{/gist_id}","starred_url":"https://api.github.com/users/boolking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boolking/subscriptions","organizations_url":"https://api.github.com/users/boolking/orgs","repos_url":"https://api.github.com/users/boolking/repos","events_url":"https://api.github.com/users/boolking/events{/privacy}","received_events_url":"https://api.github.com/users/boolking/received_events","type":"User","site_admin":false},"repo":{"id":34766387,"name":"grpc","full_name":"boolking/grpc","owner":{"login":"boolking","id":415515,"avatar_url":"https://avatars.githubusercontent.com/u/415515?v=3","gravatar_id":"","url":"https://api.github.com/users/boolking","html_url":"https://github.com/boolking","followers_url":"https://api.github.com/users/boolking/followers","following_url":"https://api.github.com/users/boolking/following{/other_user}","gists_url":"https://api.github.com/users/boolking/gists{/gist_id}","starred_url":"https://api.github.com/users/boolking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boolking/subscriptions","organizations_url":"https://api.github.com/users/boolking/orgs","repos_url":"https://api.github.com/users/boolking/repos","events_url":"https://api.github.com/users/boolking/events{/privacy}","received_events_url":"https://api.github.com/users/boolking/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/boolking/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/boolking/grpc","forks_url":"https://api.github.com/repos/boolking/grpc/forks","keys_url":"https://api.github.com/repos/boolking/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boolking/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boolking/grpc/teams","hooks_url":"https://api.github.com/repos/boolking/grpc/hooks","issue_events_url":"https://api.github.com/repos/boolking/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/boolking/grpc/events","assignees_url":"https://api.github.com/repos/boolking/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/boolking/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/boolking/grpc/tags","blobs_url":"https://api.github.com/repos/boolking/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boolking/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boolking/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/boolking/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boolking/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/boolking/grpc/languages","stargazers_url":"https://api.github.com/repos/boolking/grpc/stargazers","contributors_url":"https://api.github.com/repos/boolking/grpc/contributors","subscribers_url":"https://api.github.com/repos/boolking/grpc/subscribers","subscription_url":"https://api.github.com/repos/boolking/grpc/subscription","commits_url":"https://api.github.com/repos/boolking/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/boolking/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/boolking/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/boolking/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/boolking/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/boolking/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boolking/grpc/merges","archive_url":"https://api.github.com/repos/boolking/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boolking/grpc/downloads","issues_url":"https://api.github.com/repos/boolking/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/boolking/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/boolking/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/boolking/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boolking/grpc/labels{/name}","releases_url":"https://api.github.com/repos/boolking/grpc/releases{/id}","created_at":"2015-04-29T01:52:23Z","updated_at":"2015-04-29T01:52:27Z","pushed_at":"2015-04-29T01:58:58Z","git_url":"git://github.com/boolking/grpc.git","ssh_url":"git@github.com:boolking/grpc.git","clone_url":"https://github.com/boolking/grpc.git","svn_url":"https://github.com/boolking/grpc","homepage":"","size":42339,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"5b8c2558843ac6f10b3e16165b07e92002207f56","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","created_at":"2014-12-08T18:58:53Z","updated_at":"2015-04-29T00:38:23Z","pushed_at":"2015-04-29T02:00:58Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":42339,"stargazers_count":2505,"watchers_count":2505,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":328,"mirror_url":null,"open_issues_count":192,"forks":328,"open_issues":192,"watchers":2505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/1401"},"html":{"href":"https://github.com/grpc/grpc/pull/1401"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/1401"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/1401/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/1401/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/1401/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/7048dc80d49ff8554c8484c7fc9aa77d5e4d063a"}}}}