{"action":"created","comment":{"url":"https://api.github.com/repos/yahoo/atomizer/pulls/comments/27052208","id":27052208,"diff_hunk":"@@ -500,28 +544,74 @@ Atomizer.prototype.getCss = function (classNames/*:string[]*/, config/*:Atomizer\n                 // add the dot for the class\n                 className = ['.', className].join('');\n \n+                // fix the comma problem in Absurd\n+                // @TODO temporary until we replace Absurd\n+                // See also the return of this method.\n+                className = className.replace(',', '__COMMA__');\n+\n                 // finaly, create the object\n-                csso[className] = {};\n-                if (breakPoint) {\n-                    csso[className][breakPoint] = {};\n-                }\n \n-                if (treeo.declaration) {\n+                // helper rules doesn't have the same format as patterns\n+                if (rule.type === 'helper') {\n+                    cssoHelpers[className] = {};\n+\n+                    if (breakPoint) {\n+                        cssoHelpers[className][breakPoint] = {};\n+                    }\n+                    if (!rule.declaration) {\n+                        throw new Error('Declaration key is expected in a helper class. Helper class: ' + rule.prefix);\n+                    }\n+\n                     if (breakPoint) {\n-                        csso[className][breakPoint] = treeo.declaration;\n+                        cssoHelpers[className][breakPoint] = rule.declaration;\n                     } else {\n-                        csso[className] = treeo.declaration;\n+                        cssoHelpers[className] = rule.declaration;\n                     }\n-                } else {\n-                    rule.properties.forEach(function (property) {\n-                        var value = Atomizer.replaceConstants(treeo.value, options.rtl);\n-                        property = Atomizer.replaceConstants(property, options.rtl);\n+\n+                    // we have params in declaration\n+                    if (treeo.params) {\n+                        treeo.params.forEach(function (param, index) {\n+                            if (breakPoint) {\n+                                for (var prop in cssoHelpers[className][breakPoint]) {\n+                                    cssoHelpers[className][breakPoint][prop] = cssoHelpers[className][breakPoint][prop].replace('$' + index, param);","path":"src/atomizer.js","position":268,"original_position":268,"commit_id":"560e2182f58a1699b701888815939e46db2a5af4","original_commit_id":"560e2182f58a1699b701888815939e46db2a5af4","user":{"login":"src-code","id":60631,"avatar_url":"https://avatars.githubusercontent.com/u/60631?v=3","gravatar_id":"","url":"https://api.github.com/users/src-code","html_url":"https://github.com/src-code","followers_url":"https://api.github.com/users/src-code/followers","following_url":"https://api.github.com/users/src-code/following{/other_user}","gists_url":"https://api.github.com/users/src-code/gists{/gist_id}","starred_url":"https://api.github.com/users/src-code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-code/subscriptions","organizations_url":"https://api.github.com/users/src-code/orgs","repos_url":"https://api.github.com/users/src-code/repos","events_url":"https://api.github.com/users/src-code/events{/privacy}","received_events_url":"https://api.github.com/users/src-code/received_events","type":"User","site_admin":false},"body":"I've opened issue #113 to track changes to RTL tokens","created_at":"2015-03-24T17:30:31Z","updated_at":"2015-03-24T17:30:31Z","html_url":"https://github.com/yahoo/atomizer/pull/110#discussion_r27052208","pull_request_url":"https://api.github.com/repos/yahoo/atomizer/pulls/110","_links":{"self":{"href":"https://api.github.com/repos/yahoo/atomizer/pulls/comments/27052208"},"html":{"href":"https://github.com/yahoo/atomizer/pull/110#discussion_r27052208"},"pull_request":{"href":"https://api.github.com/repos/yahoo/atomizer/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/yahoo/atomizer/pulls/110","id":31662824,"html_url":"https://github.com/yahoo/atomizer/pull/110","diff_url":"https://github.com/yahoo/atomizer/pull/110.diff","patch_url":"https://github.com/yahoo/atomizer/pull/110.patch","issue_url":"https://api.github.com/repos/yahoo/atomizer/issues/110","number":110,"state":"closed","locked":false,"title":"Refactor helpers","user":{"login":"renatoi","id":371207,"avatar_url":"https://avatars.githubusercontent.com/u/371207?v=3","gravatar_id":"","url":"https://api.github.com/users/renatoi","html_url":"https://github.com/renatoi","followers_url":"https://api.github.com/users/renatoi/followers","following_url":"https://api.github.com/users/renatoi/following{/other_user}","gists_url":"https://api.github.com/users/renatoi/gists{/gist_id}","starred_url":"https://api.github.com/users/renatoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renatoi/subscriptions","organizations_url":"https://api.github.com/users/renatoi/orgs","repos_url":"https://api.github.com/users/renatoi/repos","events_url":"https://api.github.com/users/renatoi/events{/privacy}","received_events_url":"https://api.github.com/users/renatoi/received_events","type":"User","site_admin":false},"body":"@src-code ","created_at":"2015-03-21T00:44:52Z","updated_at":"2015-03-24T17:30:31Z","closed_at":"2015-03-23T21:09:49Z","merged_at":"2015-03-23T21:09:49Z","merge_commit_sha":"4bb8c9e688ff7c67d288ccb6c62ee59e71120f6e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yahoo/atomizer/pulls/110/commits","review_comments_url":"https://api.github.com/repos/yahoo/atomizer/pulls/110/comments","review_comment_url":"https://api.github.com/repos/yahoo/atomizer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yahoo/atomizer/issues/110/comments","statuses_url":"https://api.github.com/repos/yahoo/atomizer/statuses/560e2182f58a1699b701888815939e46db2a5af4","head":{"label":"yahoo:refactor-helpers","ref":"refactor-helpers","sha":"560e2182f58a1699b701888815939e46db2a5af4","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":24696357,"name":"atomizer","full_name":"yahoo/atomizer","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/atomizer","description":"A tool for creating Atomic CSS, a collection of single purpose styling units for maximum reuse","fork":false,"url":"https://api.github.com/repos/yahoo/atomizer","forks_url":"https://api.github.com/repos/yahoo/atomizer/forks","keys_url":"https://api.github.com/repos/yahoo/atomizer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/atomizer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/atomizer/teams","hooks_url":"https://api.github.com/repos/yahoo/atomizer/hooks","issue_events_url":"https://api.github.com/repos/yahoo/atomizer/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/atomizer/events","assignees_url":"https://api.github.com/repos/yahoo/atomizer/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/atomizer/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/atomizer/tags","blobs_url":"https://api.github.com/repos/yahoo/atomizer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/atomizer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/atomizer/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/atomizer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/atomizer/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/atomizer/languages","stargazers_url":"https://api.github.com/repos/yahoo/atomizer/stargazers","contributors_url":"https://api.github.com/repos/yahoo/atomizer/contributors","subscribers_url":"https://api.github.com/repos/yahoo/atomizer/subscribers","subscription_url":"https://api.github.com/repos/yahoo/atomizer/subscription","commits_url":"https://api.github.com/repos/yahoo/atomizer/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/atomizer/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/atomizer/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/atomizer/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/atomizer/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/atomizer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/atomizer/merges","archive_url":"https://api.github.com/repos/yahoo/atomizer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/atomizer/downloads","issues_url":"https://api.github.com/repos/yahoo/atomizer/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/atomizer/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/atomizer/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/atomizer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/atomizer/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/atomizer/releases{/id}","created_at":"2014-10-01T21:35:27Z","updated_at":"2015-03-24T07:30:22Z","pushed_at":"2015-03-24T07:30:22Z","git_url":"git://github.com/yahoo/atomizer.git","ssh_url":"git@github.com:yahoo/atomizer.git","clone_url":"https://github.com/yahoo/atomizer.git","svn_url":"https://github.com/yahoo/atomizer","homepage":"","size":2097,"stargazers_count":32,"watchers_count":32,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":16,"forks":3,"open_issues":16,"watchers":32,"default_branch":"master"}},"base":{"label":"yahoo:refactor","ref":"refactor","sha":"c11fa7969c01634250c518fc123add756b5b5236","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":24696357,"name":"atomizer","full_name":"yahoo/atomizer","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/atomizer","description":"A tool for creating Atomic CSS, a collection of single purpose styling units for maximum reuse","fork":false,"url":"https://api.github.com/repos/yahoo/atomizer","forks_url":"https://api.github.com/repos/yahoo/atomizer/forks","keys_url":"https://api.github.com/repos/yahoo/atomizer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/atomizer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/atomizer/teams","hooks_url":"https://api.github.com/repos/yahoo/atomizer/hooks","issue_events_url":"https://api.github.com/repos/yahoo/atomizer/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/atomizer/events","assignees_url":"https://api.github.com/repos/yahoo/atomizer/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/atomizer/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/atomizer/tags","blobs_url":"https://api.github.com/repos/yahoo/atomizer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/atomizer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/atomizer/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/atomizer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/atomizer/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/atomizer/languages","stargazers_url":"https://api.github.com/repos/yahoo/atomizer/stargazers","contributors_url":"https://api.github.com/repos/yahoo/atomizer/contributors","subscribers_url":"https://api.github.com/repos/yahoo/atomizer/subscribers","subscription_url":"https://api.github.com/repos/yahoo/atomizer/subscription","commits_url":"https://api.github.com/repos/yahoo/atomizer/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/atomizer/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/atomizer/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/atomizer/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/atomizer/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/atomizer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/atomizer/merges","archive_url":"https://api.github.com/repos/yahoo/atomizer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/atomizer/downloads","issues_url":"https://api.github.com/repos/yahoo/atomizer/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/atomizer/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/atomizer/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/atomizer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/atomizer/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/atomizer/releases{/id}","created_at":"2014-10-01T21:35:27Z","updated_at":"2015-03-24T07:30:22Z","pushed_at":"2015-03-24T07:30:22Z","git_url":"git://github.com/yahoo/atomizer.git","ssh_url":"git@github.com:yahoo/atomizer.git","clone_url":"https://github.com/yahoo/atomizer.git","svn_url":"https://github.com/yahoo/atomizer","homepage":"","size":2097,"stargazers_count":32,"watchers_count":32,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":16,"forks":3,"open_issues":16,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/atomizer/pulls/110"},"html":{"href":"https://github.com/yahoo/atomizer/pull/110"},"issue":{"href":"https://api.github.com/repos/yahoo/atomizer/issues/110"},"comments":{"href":"https://api.github.com/repos/yahoo/atomizer/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/atomizer/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/atomizer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yahoo/atomizer/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/atomizer/statuses/560e2182f58a1699b701888815939e46db2a5af4"}}}}