{"push_id":773464005,"size":4,"distinct_size":2,"ref":"refs/heads/misc","head":"6764754f3227a8e8e2056eadb1eadecfdcfeefd9","before":"8565fe1d2df1aaf7723d4bbfeb9194cfa5e83faa","commits":[{"sha":"8b39f1db492c1f6a7dfbf1bd7aa473f511e4fd0d","author":{"email":"f6672397850e914591889d29dcaf9077eb1a8a4f@intel.com","name":"Kevin Rocard"},"message":"Merge pull request #172 from krocard/misc_fix_for_windows\n\nSeveral fix for windows compilation\r\n - Add windows specific flags for skeleton subsystem\r\n - Remove the need for a semaphore in test-platform -> use a future&promise\r\n - Correct a unnecessary cast that was loosing precision","distinct":false,"url":"https://api.github.com/repos/krocard/parameter-framework/commits/8b39f1db492c1f6a7dfbf1bd7aa473f511e4fd0d"},{"sha":"990a4779df0f667f2fd5da4f2d221026d4aad956","author":{"email":"f6672397850e914591889d29dcaf9077eb1a8a4f@intel.com","name":"Kevin Rocard"},"message":"Normalize unused parameter declaration\n\nWhen a function parameter is unused, the compilator emits a warning.\nThere are several wais to avoid that,\nand thus express that this parameter is rightfully unused.\n\n 1) remove the unused parameter warning\n    => but their are errors when that would be hided\n 2) declare de parameter as __attribute__((unused))\n    => but it is gcc/clang specific\n 3) use the parameter in a no-op operation\n    (usually by casting it to void)\n    => but using the parameter declared as unused by this mean\n       will not trigger an error\n 4) remove the parameter identifier (leaving the type) from the function\n    => but when the name is non redundant with the type,\n       this looses information and thus make review harder.\n 5) comment the parameter identifier\n    => no drawback\n\nAs a result it has been chosen to normalize all unused parameters\nwith the 5th solution.\nFor identifiers that are a repetition of their type have been removed (4).\n\nSigned-off-by: Kevin Rocard <kevin.rocard@intel.com>","distinct":false,"url":"https://api.github.com/repos/krocard/parameter-framework/commits/990a4779df0f667f2fd5da4f2d221026d4aad956"},{"sha":"7d0293152b614208515836f909bb52982d84ee64","author":{"email":"eb080873e0961eb0e27ae23642f9b887ff089d6f@intel.com","name":"Sebastien Gonzalve"},"message":"Replace 'and' by && and 'or' by || as windows complains\n\nFor some reason, the MS compiler deactivated the possibility to use 'and'\nand 'or' instead of && and || although this is required by the norm.\nThis makes the code fail to compile on windows.\n\nThis patch replaces the 'and's by && (like in legacy C).\n\nSigned-off-by: Sebastien Gonzalve <sebastien.gonzalve@intel.com>","distinct":true,"url":"https://api.github.com/repos/krocard/parameter-framework/commits/7d0293152b614208515836f909bb52982d84ee64"},{"sha":"6764754f3227a8e8e2056eadb1eadecfdcfeefd9","author":{"email":"f6672397850e914591889d29dcaf9077eb1a8a4f@intel.com","name":"Kevin Rocard"},"message":"Correct wrong usage of int instead of int32_t\n\nOn windows int64_t != int thus code that was converting implicitly\nan int and a int64_t was raising a warning.\n\nReplace the int by the expected int64_t.\n\nSigned-off-by: Kevin Rocard <kevin.rocard@intel.com>","distinct":true,"url":"https://api.github.com/repos/krocard/parameter-framework/commits/6764754f3227a8e8e2056eadb1eadecfdcfeefd9"}]}