{"action":"closed","issue":{"url":"https://api.github.com/repos/teamed/qulice/issues/526","labels_url":"https://api.github.com/repos/teamed/qulice/issues/526/labels{/name}","comments_url":"https://api.github.com/repos/teamed/qulice/issues/526/comments","events_url":"https://api.github.com/repos/teamed/qulice/issues/526/events","html_url":"https://github.com/teamed/qulice/issues/526","id":122791012,"number":526,"title":"CheckstyleValidatorTest have much code redundancy","user":{"login":"HDouss","id":2956255,"avatar_url":"https://avatars.githubusercontent.com/u/2956255?v=3","gravatar_id":"","url":"https://api.github.com/users/HDouss","html_url":"https://github.com/HDouss","followers_url":"https://api.github.com/users/HDouss/followers","following_url":"https://api.github.com/users/HDouss/following{/other_user}","gists_url":"https://api.github.com/users/HDouss/gists{/gist_id}","starred_url":"https://api.github.com/users/HDouss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HDouss/subscriptions","organizations_url":"https://api.github.com/users/HDouss/orgs","repos_url":"https://api.github.com/users/HDouss/repos","events_url":"https://api.github.com/users/HDouss/events{/privacy}","received_events_url":"https://api.github.com/users/HDouss/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/teamed/qulice/labels/30%20mins","name":"30 mins","color":"eb6421"},{"url":"https://api.github.com/repos/teamed/qulice/labels/bug","name":"bug","color":"fbca04"},{"url":"https://api.github.com/repos/teamed/qulice/labels/DEV","name":"DEV","color":"bfd4f3"}],"state":"closed","locked":false,"assignee":{"login":"prahladyeri","id":5732256,"avatar_url":"https://avatars.githubusercontent.com/u/5732256?v=3","gravatar_id":"","url":"https://api.github.com/users/prahladyeri","html_url":"https://github.com/prahladyeri","followers_url":"https://api.github.com/users/prahladyeri/followers","following_url":"https://api.github.com/users/prahladyeri/following{/other_user}","gists_url":"https://api.github.com/users/prahladyeri/gists{/gist_id}","starred_url":"https://api.github.com/users/prahladyeri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prahladyeri/subscriptions","organizations_url":"https://api.github.com/users/prahladyeri/orgs","repos_url":"https://api.github.com/users/prahladyeri/repos","events_url":"https://api.github.com/users/prahladyeri/events{/privacy}","received_events_url":"https://api.github.com/users/prahladyeri/received_events","type":"User","site_admin":false},"milestone":null,"comments":16,"created_at":"2015-12-17T18:07:48Z","updated_at":"2015-12-22T07:58:45Z","closed_at":"2015-12-22T07:58:45Z","body":"Many methods in `CheckstyleValidatorTest` use the same code logic. This code logic is already encapsulated in `validateCheckstyle` method and is used by test methods : `acceptsDefaultMethodsWithFinalModifiers`, `acceptsSingleNameAuthor`, `acceptsConstantUsedInMethodAnnotation`, `acceptsConstructorParametersNamedJustLikeFields`.\r\n\r\nOther test methods are not using `validateCheckstyle` method and the same code is repeated over and over. These methods are : `catchesCheckstyleViolationsInLicense`, `acceptsInstanceMethodReferences`, `reportsErrorWhenParameterObjectIsNotDocumented`, `passesWindowsEndsOfLineWithoutException`, `testWindowsEndsOfLineWithLinuxSources`.\r\nThis makes the test class unusefully long and unmaintainable."}}