{"action":"created","comment":{"url":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/comments/40194337","id":40194337,"diff_hunk":"@@ -13,12 +13,41 @@ Lint/HandleExceptions:\n \n # Offense count: 18\n Metrics/AbcSize:\n-  Max: 40\n+  Max: 38\n \n-# Offense count: 172\n+# Offense count: 162\n # Configuration parameters: AllowURI, URISchemes.\n Metrics/LineLength:\n-  Max: 235\n+  Exclude:\n+    - 'config/application.rb'\n+    - 'config/environments/development.rb'\n+    - 'config/environments/production.rb'\n+    - 'config/environments/test.rb'\n+    - 'config/initializers/backtrace_silencers.rb'\n+    - 'config/initializers/encryptor.rb'\n+    - 'config/initializers/filter_parameter_logging.rb'\n+    - 'config/initializers/markdown_handler.rb'\n+    - 'config/initializers/wrap_parameters.rb'\n+    - 'config/routes.rb'\n+    - 'lib/calculated_metrics.rb'\n+    - 'lib/csv_formatter.rb'\n+    - 'lib/detailed_metrics.rb'\n+    - 'lib/detailed_windowed_metrics.rb'\n+    - 'lib/fortnightly_performance_report.rb'\n+    - 'lib/leaderboard_report.rb'\n+    - 'lib/mailer_helper.rb'\n+    - 'lib/metrics_logger.rb'\n+    - 'lib/rag_status_report.rb'\n+    - 'lib/session_guard.rb'\n+    - 'lib/slots_manipulator.rb'\n+    - 'lib/tasks/browserstack.rake'\n+    - 'lib/tasks/maintenance.rake'\n+    - 'lib/visitors_manipulator.rb'\n+    - 'lib/weekly_confirmations_report.rb'\n+    - 'test/mailers/previews/mailer_preview_common.rb'\n+    - 'test/mailers/previews/prison_mailer_preview.rb'\n+    - 'test/mailers/previews/visitor_mailer_preview.rb'\n+    - 'spec/**/*'","path":".rubocop_todo.yml","position":49,"original_position":49,"commit_id":"46b034b251c59f7d4bb41b96faa97294576db8e4","original_commit_id":"46b034b251c59f7d4bb41b96faa97294576db8e4","user":{"login":"SteveMarshall","id":2210,"avatar_url":"https://avatars.githubusercontent.com/u/2210?v=3","gravatar_id":"","url":"https://api.github.com/users/SteveMarshall","html_url":"https://github.com/SteveMarshall","followers_url":"https://api.github.com/users/SteveMarshall/followers","following_url":"https://api.github.com/users/SteveMarshall/following{/other_user}","gists_url":"https://api.github.com/users/SteveMarshall/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveMarshall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveMarshall/subscriptions","organizations_url":"https://api.github.com/users/SteveMarshall/orgs","repos_url":"https://api.github.com/users/SteveMarshall/repos","events_url":"https://api.github.com/users/SteveMarshall/events{/privacy}","received_events_url":"https://api.github.com/users/SteveMarshall/received_events","type":"User","site_admin":false},"body":"Do we need these line-length exclusions, or are these still to be fixed?","created_at":"2015-09-23T11:50:25Z","updated_at":"2015-09-23T11:50:25Z","html_url":"https://github.com/ministryofjustice/prison-visits/pull/324#discussion_r40194337","pull_request_url":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/324","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/comments/40194337"},"html":{"href":"https://github.com/ministryofjustice/prison-visits/pull/324#discussion_r40194337"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/324"}}},"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/324","id":45765987,"html_url":"https://github.com/ministryofjustice/prison-visits/pull/324","diff_url":"https://github.com/ministryofjustice/prison-visits/pull/324.diff","patch_url":"https://github.com/ministryofjustice/prison-visits/pull/324.patch","issue_url":"https://api.github.com/repos/ministryofjustice/prison-visits/issues/324","number":324,"state":"open","locked":false,"title":"Fix line length","user":{"login":"EGiataganas","id":7561969,"avatar_url":"https://avatars.githubusercontent.com/u/7561969?v=3","gravatar_id":"","url":"https://api.github.com/users/EGiataganas","html_url":"https://github.com/EGiataganas","followers_url":"https://api.github.com/users/EGiataganas/followers","following_url":"https://api.github.com/users/EGiataganas/following{/other_user}","gists_url":"https://api.github.com/users/EGiataganas/gists{/gist_id}","starred_url":"https://api.github.com/users/EGiataganas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EGiataganas/subscriptions","organizations_url":"https://api.github.com/users/EGiataganas/orgs","repos_url":"https://api.github.com/users/EGiataganas/repos","events_url":"https://api.github.com/users/EGiataganas/events{/privacy}","received_events_url":"https://api.github.com/users/EGiataganas/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-23T10:57:49Z","updated_at":"2015-09-23T11:50:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cd7db6fb0495409c36352edf717d7842d08ae05","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/324/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/324/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ministryofjustice/prison-visits/issues/324/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/prison-visits/statuses/46b034b251c59f7d4bb41b96faa97294576db8e4","head":{"label":"ministryofjustice:fix-line-length","ref":"fix-line-length","sha":"46b034b251c59f7d4bb41b96faa97294576db8e4","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":20570322,"name":"prison-visits","full_name":"ministryofjustice/prison-visits","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/prison-visits","description":"","fork":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits","forks_url":"https://api.github.com/repos/ministryofjustice/prison-visits/forks","keys_url":"https://api.github.com/repos/ministryofjustice/prison-visits/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/prison-visits/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/prison-visits/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/prison-visits/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/prison-visits/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/prison-visits/events","assignees_url":"https://api.github.com/repos/ministryofjustice/prison-visits/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/prison-visits/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/prison-visits/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/prison-visits/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/prison-visits/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/prison-visits/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/prison-visits/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/prison-visits/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/prison-visits/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/prison-visits/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/prison-visits/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/prison-visits/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/prison-visits/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/prison-visits/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/prison-visits/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/prison-visits/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/prison-visits/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/prison-visits/merges","archive_url":"https://api.github.com/repos/ministryofjustice/prison-visits/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/prison-visits/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/prison-visits/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/prison-visits/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/prison-visits/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/prison-visits/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/prison-visits/releases{/id}","created_at":"2014-06-06T16:24:26Z","updated_at":"2015-08-04T17:02:13Z","pushed_at":"2015-09-23T11:12:10Z","git_url":"git://github.com/ministryofjustice/prison-visits.git","ssh_url":"git@github.com:ministryofjustice/prison-visits.git","clone_url":"https://github.com/ministryofjustice/prison-visits.git","svn_url":"https://github.com/ministryofjustice/prison-visits","homepage":"https://www.prisonvisits.service.gov.uk","size":10357,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":5,"default_branch":"master"}},"base":{"label":"ministryofjustice:master","ref":"master","sha":"77ea9af5f63ff08ea761f8cbcf08648e719159a1","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":20570322,"name":"prison-visits","full_name":"ministryofjustice/prison-visits","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/prison-visits","description":"","fork":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits","forks_url":"https://api.github.com/repos/ministryofjustice/prison-visits/forks","keys_url":"https://api.github.com/repos/ministryofjustice/prison-visits/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/prison-visits/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/prison-visits/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/prison-visits/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/prison-visits/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/prison-visits/events","assignees_url":"https://api.github.com/repos/ministryofjustice/prison-visits/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/prison-visits/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/prison-visits/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/prison-visits/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/prison-visits/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/prison-visits/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/prison-visits/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/prison-visits/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/prison-visits/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/prison-visits/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/prison-visits/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/prison-visits/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/prison-visits/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/prison-visits/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/prison-visits/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/prison-visits/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/prison-visits/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/prison-visits/merges","archive_url":"https://api.github.com/repos/ministryofjustice/prison-visits/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/prison-visits/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/prison-visits/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/prison-visits/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/prison-visits/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/prison-visits/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/prison-visits/releases{/id}","created_at":"2014-06-06T16:24:26Z","updated_at":"2015-08-04T17:02:13Z","pushed_at":"2015-09-23T11:12:10Z","git_url":"git://github.com/ministryofjustice/prison-visits.git","ssh_url":"git@github.com:ministryofjustice/prison-visits.git","clone_url":"https://github.com/ministryofjustice/prison-visits.git","svn_url":"https://github.com/ministryofjustice/prison-visits","homepage":"https://www.prisonvisits.service.gov.uk","size":10357,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/324"},"html":{"href":"https://github.com/ministryofjustice/prison-visits/pull/324"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits/issues/324"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits/issues/324/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/324/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/324/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits/statuses/46b034b251c59f7d4bb41b96faa97294576db8e4"}}}}