{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/44124373","id":44124373,"diff_hunk":"@@ -549,14 +549,14 @@ void CGUIWindowMusicNav::GetContextButtons(int itemNumber, CContextButtons &butt\n         // 4. specific per album\n         buttons.Add(CONTEXT_BUTTON_SET_CONTENT, 20195);\n       }\n-      if (item->HasMusicInfoTag() && item->GetMusicInfoTag()->GetArtist().size() > 0)\n+      if (item->HasMusicInfoTag() && item->GetMusicInfoTag()->GetArtistString().size() > 0)","path":"xbmc/music/windows/GUIWindowMusicNav.cpp","position":5,"original_position":5,"commit_id":"62a3ce795587d087ddaa9b9a71b4689ff9d43b17","original_commit_id":"62a3ce795587d087ddaa9b9a71b4689ff9d43b17","user":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars.githubusercontent.com/u/13371422?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"body":"Thanks, I could get into that, but first I'll see if I get a volunteer. it is so hard to tell if you broken something that you have never see working or if you are testing it right when it seems to work.","created_at":"2015-11-06T10:45:28Z","updated_at":"2015-11-06T10:45:28Z","html_url":"https://github.com/xbmc/xbmc/pull/8354#discussion_r44124373","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/8354","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/44124373"},"html":{"href":"https://github.com/xbmc/xbmc/pull/8354#discussion_r44124373"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/8354"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/8354","id":49861675,"html_url":"https://github.com/xbmc/xbmc/pull/8354","diff_url":"https://github.com/xbmc/xbmc/pull/8354.diff","patch_url":"https://github.com/xbmc/xbmc/pull/8354.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/8354","number":8354,"state":"open","locked":false,"title":"Fix missing artist names in legacy Python music interface","user":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars.githubusercontent.com/u/13371422?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"body":"A few more places that need to use `CMusicInfoTag.GetArtistString()` and `GetAlbumArtistString()`  after the addition of processing for ARTISTS tag #7486 and the tidy-up that removed the artist vector from CSong and CArtist in #8158.\r\n\r\n@ronie thanks for spotting the missing artist name from Python (see #8339). I had overlooked the legacy folder software. In #8306 I removed a temp fix (for JSON) that was also helping legacy addons. I hope I have finally cracked it!!\r\n\r\nThis tidy-up has been painful because it has been tricky to spot all the places that were splitting the string from the strArtists field of the song and albums tables, sometimes only to re-join it immediately, rather than getting the full artist list from the song_artist, album_artist and artist tables. They can now differ in content, so it is important that we sort this out. The MusicInfoTag artist vector only gets populated when a) scanned from the tags or b) when queried from the artist table. If we only fetch the desc string then only that gets stored.\r\n\r\nCC: @Razzeee , @evilhamster ","created_at":"2015-11-05T18:30:24Z","updated_at":"2015-11-06T10:45:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8dcdb49f9f9401f1785ccbc48b6cbc3176aa330e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/8354/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/8354/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/8354/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/62a3ce795587d087ddaa9b9a71b4689ff9d43b17","head":{"label":"DaveTBlake:ArtistDescNotVector","ref":"ArtistDescNotVector","sha":"62a3ce795587d087ddaa9b9a71b4689ff9d43b17","user":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars.githubusercontent.com/u/13371422?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"repo":{"id":41623007,"name":"xbmc","full_name":"DaveTBlake/xbmc","owner":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars.githubusercontent.com/u/13371422?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DaveTBlake/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":true,"url":"https://api.github.com/repos/DaveTBlake/xbmc","forks_url":"https://api.github.com/repos/DaveTBlake/xbmc/forks","keys_url":"https://api.github.com/repos/DaveTBlake/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DaveTBlake/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DaveTBlake/xbmc/teams","hooks_url":"https://api.github.com/repos/DaveTBlake/xbmc/hooks","issue_events_url":"https://api.github.com/repos/DaveTBlake/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/DaveTBlake/xbmc/events","assignees_url":"https://api.github.com/repos/DaveTBlake/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/DaveTBlake/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/DaveTBlake/xbmc/tags","blobs_url":"https://api.github.com/repos/DaveTBlake/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DaveTBlake/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DaveTBlake/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/DaveTBlake/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DaveTBlake/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/DaveTBlake/xbmc/languages","stargazers_url":"https://api.github.com/repos/DaveTBlake/xbmc/stargazers","contributors_url":"https://api.github.com/repos/DaveTBlake/xbmc/contributors","subscribers_url":"https://api.github.com/repos/DaveTBlake/xbmc/subscribers","subscription_url":"https://api.github.com/repos/DaveTBlake/xbmc/subscription","commits_url":"https://api.github.com/repos/DaveTBlake/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/DaveTBlake/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/DaveTBlake/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/DaveTBlake/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/DaveTBlake/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/DaveTBlake/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DaveTBlake/xbmc/merges","archive_url":"https://api.github.com/repos/DaveTBlake/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DaveTBlake/xbmc/downloads","issues_url":"https://api.github.com/repos/DaveTBlake/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/DaveTBlake/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/DaveTBlake/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/DaveTBlake/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DaveTBlake/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/DaveTBlake/xbmc/releases{/id}","created_at":"2015-08-30T09:25:19Z","updated_at":"2015-08-30T09:25:50Z","pushed_at":"2015-11-05T23:32:55Z","git_url":"git://github.com/DaveTBlake/xbmc.git","ssh_url":"git@github.com:DaveTBlake/xbmc.git","clone_url":"https://github.com/DaveTBlake/xbmc.git","svn_url":"https://github.com/DaveTBlake/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":551322,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"8cee3e01bd9dfdfeafb1ab6d7defe75659d7b22e","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-11-06T04:01:22Z","pushed_at":"2015-11-06T08:42:20Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1906303,"stargazers_count":4249,"watchers_count":4249,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3109,"mirror_url":null,"open_issues_count":193,"forks":3109,"open_issues":193,"watchers":4249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/8354"},"html":{"href":"https://github.com/xbmc/xbmc/pull/8354"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/8354"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/8354/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/8354/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/8354/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/62a3ce795587d087ddaa9b9a71b4689ff9d43b17"}}}}