{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/1204","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/1204/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/1204/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/1204/events","html_url":"https://github.com/Automattic/wp-calypso/pull/1204","id":120045954,"number":1204,"title":"Framework: Move to Node 4","user":{"login":"blowery","id":14350,"avatar_url":"https://avatars.githubusercontent.com/u/14350?v=3","gravatar_id":"","url":"https://api.github.com/users/blowery","html_url":"https://github.com/blowery","followers_url":"https://api.github.com/users/blowery/followers","following_url":"https://api.github.com/users/blowery/following{/other_user}","gists_url":"https://api.github.com/users/blowery/gists{/gist_id}","starred_url":"https://api.github.com/users/blowery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blowery/subscriptions","organizations_url":"https://api.github.com/users/blowery/orgs","repos_url":"https://api.github.com/users/blowery/repos","events_url":"https://api.github.com/users/blowery/events{/privacy}","received_events_url":"https://api.github.com/users/blowery/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Build","name":"Build","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Framework","name":"Framework","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"blowery","id":14350,"avatar_url":"https://avatars.githubusercontent.com/u/14350?v=3","gravatar_id":"","url":"https://api.github.com/users/blowery","html_url":"https://github.com/blowery","followers_url":"https://api.github.com/users/blowery/followers","following_url":"https://api.github.com/users/blowery/following{/other_user}","gists_url":"https://api.github.com/users/blowery/gists{/gist_id}","starred_url":"https://api.github.com/users/blowery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blowery/subscriptions","organizations_url":"https://api.github.com/users/blowery/orgs","repos_url":"https://api.github.com/users/blowery/repos","events_url":"https://api.github.com/users/blowery/events{/privacy}","received_events_url":"https://api.github.com/users/blowery/received_events","type":"User","site_admin":false},"milestone":null,"comments":26,"created_at":"2015-12-02T22:03:18Z","updated_at":"2015-12-17T18:49:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/1204","html_url":"https://github.com/Automattic/wp-calypso/pull/1204","diff_url":"https://github.com/Automattic/wp-calypso/pull/1204.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/1204.patch"},"body":"This moves us up to Node v4.2.3, the current LTS version, in the Docker container. This needs a fair bit of testing and should not be merged until we're pretty happy with it.\r\n\r\nYes, the branch name is wrong.\r\n\r\nTo test, you'll need to \r\n1. install Vagrant, \r\n2. add a `env-config.sh` to the root of the project which exports CALYPSO_ENV set to a environment you want to test\r\n3. run `vagrant up`\r\n4. add the correct entries to /etc/hosts to hit your local env for the host you want to pretend to be\r\n5. add in a forwarder from port 80 to port 3000 locally, using nginx or polipo\r\n\r\nTODO:\r\n- [x] Bump Dockerfile up to 4.2.3\r\n- [x] Add `circle.yml` to tell Circle CI which node to use\r\n- [x] Upgrade any packages that need updates to run well on 4\r\n- [x] Fix up tests\r\n- [x] Bump `engines` in `package.json`\r\n- [x] Add `Makefile` target that checks node version and explodes if the dev is on pre 4.2.3.\r\n"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/165545815","html_url":"https://github.com/Automattic/wp-calypso/pull/1204#issuecomment-165545815","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/1204","id":165545815,"user":{"login":"blowery","id":14350,"avatar_url":"https://avatars.githubusercontent.com/u/14350?v=3","gravatar_id":"","url":"https://api.github.com/users/blowery","html_url":"https://github.com/blowery","followers_url":"https://api.github.com/users/blowery/followers","following_url":"https://api.github.com/users/blowery/following{/other_user}","gists_url":"https://api.github.com/users/blowery/gists{/gist_id}","starred_url":"https://api.github.com/users/blowery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blowery/subscriptions","organizations_url":"https://api.github.com/users/blowery/orgs","repos_url":"https://api.github.com/users/blowery/repos","events_url":"https://api.github.com/users/blowery/events{/privacy}","received_events_url":"https://api.github.com/users/blowery/received_events","type":"User","site_admin":false},"created_at":"2015-12-17T18:49:34Z","updated_at":"2015-12-17T18:49:34Z","body":"Just got this up and running, pretending to be a production node, and it seems to work just fine. I think this is ready to go."}}