{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/25398356","id":25398356,"diff_hunk":"@@ -144,4 +144,13 @@ describe('ReactMount', function() {\n     ReactMount.render(<div />, container);\n     expect(console.warn.mock.calls.length).toBe(0);\n   });\n+\n+  it('should warn when mounting into document.body', function () {\n+    spyOn(console, 'warn')\n+    ReactMount.render(<div />, document.body);","path":"src/browser/ui/__tests__/ReactMount-test.js","position":7,"original_position":7,"commit_id":"4a6d9aaa186dbac5f31b7ede84fea6903566778e","original_commit_id":"4a6d9aaa186dbac5f31b7ede84fea6903566778e","user":{"login":"spicyj","id":6820,"avatar_url":"https://avatars.githubusercontent.com/u/6820?v=3","gravatar_id":"","url":"https://api.github.com/users/spicyj","html_url":"https://github.com/spicyj","followers_url":"https://api.github.com/users/spicyj/followers","following_url":"https://api.github.com/users/spicyj/following{/other_user}","gists_url":"https://api.github.com/users/spicyj/gists{/gist_id}","starred_url":"https://api.github.com/users/spicyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicyj/subscriptions","organizations_url":"https://api.github.com/users/spicyj/orgs","repos_url":"https://api.github.com/users/spicyj/repos","events_url":"https://api.github.com/users/spicyj/events{/privacy}","received_events_url":"https://api.github.com/users/spicyj/received_events","type":"User","site_admin":false},"body":"This actually blows away the test runner UI in debug mode (`grunt test --debug`, then open http://127.0.0.1:9999/test/). Maybe we can make an iframe to render into and then instead check the tag name of the container instead of for raw equality to `document.body`?","created_at":"2015-02-26T01:38:40Z","updated_at":"2015-02-26T01:38:40Z","html_url":"https://github.com/facebook/react/pull/3211#discussion_r25398356","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/3211","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/25398356"},"html":{"href":"https://github.com/facebook/react/pull/3211#discussion_r25398356"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/3211"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/3211","id":29669413,"html_url":"https://github.com/facebook/react/pull/3211","diff_url":"https://github.com/facebook/react/pull/3211.diff","patch_url":"https://github.com/facebook/react/pull/3211.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/3211","number":3211,"state":"open","locked":false,"title":"Warn when rendering directly into document.body","user":{"login":"banderson","id":30241,"avatar_url":"https://avatars.githubusercontent.com/u/30241?v=3","gravatar_id":"","url":"https://api.github.com/users/banderson","html_url":"https://github.com/banderson","followers_url":"https://api.github.com/users/banderson/followers","following_url":"https://api.github.com/users/banderson/following{/other_user}","gists_url":"https://api.github.com/users/banderson/gists{/gist_id}","starred_url":"https://api.github.com/users/banderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/banderson/subscriptions","organizations_url":"https://api.github.com/users/banderson/orgs","repos_url":"https://api.github.com/users/banderson/repos","events_url":"https://api.github.com/users/banderson/events{/privacy}","received_events_url":"https://api.github.com/users/banderson/received_events","type":"User","site_admin":false},"body":"This is in response to #3207 to address concerns regarding third-party\r\nscripts and browser plugins potentially altering DOM nodes within\r\ndocument.body, causing problems with reconciliation.","created_at":"2015-02-20T02:43:38Z","updated_at":"2015-02-26T01:38:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"500cf0231e41bb0165613b1bd0b63c64e521c3fb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/3211/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/3211/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/3211/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/4a6d9aaa186dbac5f31b7ede84fea6903566778e","head":{"label":"banderson:master","ref":"master","sha":"4a6d9aaa186dbac5f31b7ede84fea6903566778e","user":{"login":"banderson","id":30241,"avatar_url":"https://avatars.githubusercontent.com/u/30241?v=3","gravatar_id":"","url":"https://api.github.com/users/banderson","html_url":"https://github.com/banderson","followers_url":"https://api.github.com/users/banderson/followers","following_url":"https://api.github.com/users/banderson/following{/other_user}","gists_url":"https://api.github.com/users/banderson/gists{/gist_id}","starred_url":"https://api.github.com/users/banderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/banderson/subscriptions","organizations_url":"https://api.github.com/users/banderson/orgs","repos_url":"https://api.github.com/users/banderson/repos","events_url":"https://api.github.com/users/banderson/events{/privacy}","received_events_url":"https://api.github.com/users/banderson/received_events","type":"User","site_admin":false},"repo":{"id":31047978,"name":"react","full_name":"banderson/react","owner":{"login":"banderson","id":30241,"avatar_url":"https://avatars.githubusercontent.com/u/30241?v=3","gravatar_id":"","url":"https://api.github.com/users/banderson","html_url":"https://github.com/banderson","followers_url":"https://api.github.com/users/banderson/followers","following_url":"https://api.github.com/users/banderson/following{/other_user}","gists_url":"https://api.github.com/users/banderson/gists{/gist_id}","starred_url":"https://api.github.com/users/banderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/banderson/subscriptions","organizations_url":"https://api.github.com/users/banderson/orgs","repos_url":"https://api.github.com/users/banderson/repos","events_url":"https://api.github.com/users/banderson/events{/privacy}","received_events_url":"https://api.github.com/users/banderson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/banderson/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/banderson/react","forks_url":"https://api.github.com/repos/banderson/react/forks","keys_url":"https://api.github.com/repos/banderson/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/banderson/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/banderson/react/teams","hooks_url":"https://api.github.com/repos/banderson/react/hooks","issue_events_url":"https://api.github.com/repos/banderson/react/issues/events{/number}","events_url":"https://api.github.com/repos/banderson/react/events","assignees_url":"https://api.github.com/repos/banderson/react/assignees{/user}","branches_url":"https://api.github.com/repos/banderson/react/branches{/branch}","tags_url":"https://api.github.com/repos/banderson/react/tags","blobs_url":"https://api.github.com/repos/banderson/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/banderson/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/banderson/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/banderson/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/banderson/react/statuses/{sha}","languages_url":"https://api.github.com/repos/banderson/react/languages","stargazers_url":"https://api.github.com/repos/banderson/react/stargazers","contributors_url":"https://api.github.com/repos/banderson/react/contributors","subscribers_url":"https://api.github.com/repos/banderson/react/subscribers","subscription_url":"https://api.github.com/repos/banderson/react/subscription","commits_url":"https://api.github.com/repos/banderson/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/banderson/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/banderson/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/banderson/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/banderson/react/contents/{+path}","compare_url":"https://api.github.com/repos/banderson/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/banderson/react/merges","archive_url":"https://api.github.com/repos/banderson/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/banderson/react/downloads","issues_url":"https://api.github.com/repos/banderson/react/issues{/number}","pulls_url":"https://api.github.com/repos/banderson/react/pulls{/number}","milestones_url":"https://api.github.com/repos/banderson/react/milestones{/number}","notifications_url":"https://api.github.com/repos/banderson/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/banderson/react/labels{/name}","releases_url":"https://api.github.com/repos/banderson/react/releases{/id}","created_at":"2015-02-20T02:25:12Z","updated_at":"2015-02-20T03:13:24Z","pushed_at":"2015-02-20T03:13:24Z","git_url":"git://github.com/banderson/react.git","ssh_url":"git@github.com:banderson/react.git","clone_url":"https://github.com/banderson/react.git","svn_url":"https://github.com/banderson/react","homepage":"http://facebook.github.io/react/","size":44057,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"362e9595c46c0a2079cd7bfbdbb93f8ea7b2f5f7","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","created_at":"2013-05-24T16:15:54Z","updated_at":"2015-02-26T01:35:07Z","pushed_at":"2015-02-26T01:35:07Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"http://facebook.github.io/react/","size":79111,"stargazers_count":16906,"watchers_count":16906,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2212,"mirror_url":null,"open_issues_count":533,"forks":2212,"open_issues":533,"watchers":16906,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/3211"},"html":{"href":"https://github.com/facebook/react/pull/3211"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/3211"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/3211/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/3211/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/3211/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/4a6d9aaa186dbac5f31b7ede84fea6903566778e"}}}}