{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/23353991","id":23353991,"diff_hunk":"@@ -28,6 +28,13 @@ func getHomeDir() string {\n \treturn os.Getenv(\"HOME\")\n }\n \n+func getDaemonConfDir() string {\n+\tif runtime.GOOS == \"windows\" {\n+\t\treturn filepath.Join(os.Getenv(\"USERPROFILE\"), \".docker\")","path":"docker/flags.go","position":6,"original_position":6,"commit_id":"007ef161b45dd91afcfb7ef9cd32e6c88dbf196e","original_commit_id":"007ef161b45dd91afcfb7ef9cd32e6c88dbf196e","user":{"login":"tiborvass","id":827131,"avatar_url":"https://avatars.githubusercontent.com/u/827131?v=3","gravatar_id":"","url":"https://api.github.com/users/tiborvass","html_url":"https://github.com/tiborvass","followers_url":"https://api.github.com/users/tiborvass/followers","following_url":"https://api.github.com/users/tiborvass/following{/other_user}","gists_url":"https://api.github.com/users/tiborvass/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborvass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborvass/subscriptions","organizations_url":"https://api.github.com/users/tiborvass/orgs","repos_url":"https://api.github.com/users/tiborvass/repos","events_url":"https://api.github.com/users/tiborvass/events{/privacy}","received_events_url":"https://api.github.com/users/tiborvass/received_events","type":"User","site_admin":false},"body":"There's also `FIXME` sometimes (we're not that consistent)","created_at":"2015-01-22T03:43:36Z","updated_at":"2015-01-22T03:43:36Z","html_url":"https://github.com/docker/docker/pull/10234#discussion_r23353991","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/10234","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/23353991"},"html":{"href":"https://github.com/docker/docker/pull/10234#discussion_r23353991"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/10234"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/10234","id":27732318,"html_url":"https://github.com/docker/docker/pull/10234","diff_url":"https://github.com/docker/docker/pull/10234.diff","patch_url":"https://github.com/docker/docker/pull/10234.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/10234","number":10234,"state":"open","locked":false,"title":"Fix daemon key file location","user":{"login":"dmcgowan","id":169601,"avatar_url":"https://avatars.githubusercontent.com/u/169601?v=3","gravatar_id":"","url":"https://api.github.com/users/dmcgowan","html_url":"https://github.com/dmcgowan","followers_url":"https://api.github.com/users/dmcgowan/followers","following_url":"https://api.github.com/users/dmcgowan/following{/other_user}","gists_url":"https://api.github.com/users/dmcgowan/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcgowan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcgowan/subscriptions","organizations_url":"https://api.github.com/users/dmcgowan/orgs","repos_url":"https://api.github.com/users/dmcgowan/repos","events_url":"https://api.github.com/users/dmcgowan/events{/privacy}","received_events_url":"https://api.github.com/users/dmcgowan/received_events","type":"User","site_admin":false},"body":"Used placeholder instead of flag, can add the flag just need to bring over the documentation as well.\r\n\r\nFixes #10233\r\n","created_at":"2015-01-21T03:09:55Z","updated_at":"2015-01-22T03:43:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f78e5ab1d2072cb4a574ec47d6664cc9136138ea","assignee":null,"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/34","labels_url":"https://api.github.com/repos/docker/docker/milestones/34/labels","id":906381,"number":34,"title":"1.5.0","description":"### NOTICE:\r\n\r\nIssues and PRs included in milestones are not a guarantee that they will be merged or included in a release. \r\n\r\n### RELEASE MANAGER:\r\n\r\n@icecrime will be the point of contact for the 1.5.0 release. \r\n\r\n### CODE FREEZE:\r\n\r\nCode freeze will begin on January 20th for the final features to be included in Docker 1.5.0.  Any features not merged by this time will not be included **or** considered for a release.  At this time a bump branch with the final commits for this release will be created and an RC will be pushed to https://test.docker.com for QA and testing in advance of the Feb. 3 release. date. ","creator":{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars.githubusercontent.com/u/749551?v=3","gravatar_id":"","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":57,"state":"open","created_at":"2014-12-16T23:52:21Z","updated_at":"2015-01-22T01:51:27Z","due_on":"2015-02-03T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/10234/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/10234/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments/{number}","comments_url":"https://api.github.com/repos/docker/docker/issues/10234/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/007ef161b45dd91afcfb7ef9cd32e6c88dbf196e","head":{"label":"dmcgowan:libtrust-key-fix","ref":"libtrust-key-fix","sha":"007ef161b45dd91afcfb7ef9cd32e6c88dbf196e","user":{"login":"dmcgowan","id":169601,"avatar_url":"https://avatars.githubusercontent.com/u/169601?v=3","gravatar_id":"","url":"https://api.github.com/users/dmcgowan","html_url":"https://github.com/dmcgowan","followers_url":"https://api.github.com/users/dmcgowan/followers","following_url":"https://api.github.com/users/dmcgowan/following{/other_user}","gists_url":"https://api.github.com/users/dmcgowan/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcgowan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcgowan/subscriptions","organizations_url":"https://api.github.com/users/dmcgowan/orgs","repos_url":"https://api.github.com/users/dmcgowan/repos","events_url":"https://api.github.com/users/dmcgowan/events{/privacy}","received_events_url":"https://api.github.com/users/dmcgowan/received_events","type":"User","site_admin":false},"repo":{"id":22739098,"name":"docker","full_name":"dmcgowan/docker","owner":{"login":"dmcgowan","id":169601,"avatar_url":"https://avatars.githubusercontent.com/u/169601?v=3","gravatar_id":"","url":"https://api.github.com/users/dmcgowan","html_url":"https://github.com/dmcgowan","followers_url":"https://api.github.com/users/dmcgowan/followers","following_url":"https://api.github.com/users/dmcgowan/following{/other_user}","gists_url":"https://api.github.com/users/dmcgowan/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcgowan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcgowan/subscriptions","organizations_url":"https://api.github.com/users/dmcgowan/orgs","repos_url":"https://api.github.com/users/dmcgowan/repos","events_url":"https://api.github.com/users/dmcgowan/events{/privacy}","received_events_url":"https://api.github.com/users/dmcgowan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmcgowan/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/dmcgowan/docker","forks_url":"https://api.github.com/repos/dmcgowan/docker/forks","keys_url":"https://api.github.com/repos/dmcgowan/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmcgowan/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmcgowan/docker/teams","hooks_url":"https://api.github.com/repos/dmcgowan/docker/hooks","issue_events_url":"https://api.github.com/repos/dmcgowan/docker/issues/events{/number}","events_url":"https://api.github.com/repos/dmcgowan/docker/events","assignees_url":"https://api.github.com/repos/dmcgowan/docker/assignees{/user}","branches_url":"https://api.github.com/repos/dmcgowan/docker/branches{/branch}","tags_url":"https://api.github.com/repos/dmcgowan/docker/tags","blobs_url":"https://api.github.com/repos/dmcgowan/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmcgowan/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmcgowan/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmcgowan/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmcgowan/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/dmcgowan/docker/languages","stargazers_url":"https://api.github.com/repos/dmcgowan/docker/stargazers","contributors_url":"https://api.github.com/repos/dmcgowan/docker/contributors","subscribers_url":"https://api.github.com/repos/dmcgowan/docker/subscribers","subscription_url":"https://api.github.com/repos/dmcgowan/docker/subscription","commits_url":"https://api.github.com/repos/dmcgowan/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmcgowan/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmcgowan/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmcgowan/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/dmcgowan/docker/contents/{+path}","compare_url":"https://api.github.com/repos/dmcgowan/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmcgowan/docker/merges","archive_url":"https://api.github.com/repos/dmcgowan/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmcgowan/docker/downloads","issues_url":"https://api.github.com/repos/dmcgowan/docker/issues{/number}","pulls_url":"https://api.github.com/repos/dmcgowan/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/dmcgowan/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/dmcgowan/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmcgowan/docker/labels{/name}","releases_url":"https://api.github.com/repos/dmcgowan/docker/releases{/id}","created_at":"2014-08-07T22:58:18Z","updated_at":"2014-10-07T18:25:37Z","pushed_at":"2015-01-22T03:29:09Z","git_url":"git://github.com/dmcgowan/docker.git","ssh_url":"git@github.com:dmcgowan/docker.git","clone_url":"https://github.com/dmcgowan/docker.git","svn_url":"https://github.com/dmcgowan/docker","homepage":"http://www.docker.com","size":41419,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"fcc4abc870e7f62590e418f10ff6f743a47fad12","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-01-22T03:36:32Z","pushed_at":"2015-01-22T01:51:29Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":127639,"stargazers_count":18582,"watchers_count":18582,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3804,"mirror_url":null,"open_issues_count":950,"forks":3804,"open_issues":950,"watchers":18582,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/10234"},"html":{"href":"https://github.com/docker/docker/pull/10234"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/10234"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/10234/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/10234/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/10234/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/007ef161b45dd91afcfb7ef9cd32e6c88dbf196e"}}}}