{"action":"created","comment":{"url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/pulls/comments/24317379","id":24317379,"diff_hunk":"@@ -21,19 +22,38 @@\n       exec { 'initial-setup-via-REST-API':\n           # Hardcoded user/pass to match setup-via-api.sh\n           unless  => \"curl --fail ${tenant_login_url} -e / -X POST -d 'username=admin@test.local&password=admin'\",\n-          command => \"/tmp/setup-via-api.sh ${admin_hostname} ${tenant_hostname}\"\n+          command => \"/tmp/setup-via-api.sh ${admin_hostname} ${tenant_hostname} ${tenant_appdisplayname_escaped}\"\n       } -> Exec['temporarily-stop-grasshopper-for-import']\n \n   }\n \n+\n   exec { 'temporarily-stop-grasshopper-for-import':\n       # if file for import exists and server is responding, stop the server","path":"modules/grasshopper/manifests/setup.pp","position":20,"original_position":20,"commit_id":"8cc79e07214fbaee6a10c4aae3c6b86e4b566a20","original_commit_id":"8cc79e07214fbaee6a10c4aae3c6b86e4b566a20","user":{"login":"Coenego","id":2194396,"avatar_url":"https://avatars.githubusercontent.com/u/2194396?v=3","gravatar_id":"","url":"https://api.github.com/users/Coenego","html_url":"https://github.com/Coenego","followers_url":"https://api.github.com/users/Coenego/followers","following_url":"https://api.github.com/users/Coenego/following{/other_user}","gists_url":"https://api.github.com/users/Coenego/gists{/gist_id}","starred_url":"https://api.github.com/users/Coenego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coenego/subscriptions","organizations_url":"https://api.github.com/users/Coenego/orgs","repos_url":"https://api.github.com/users/Coenego/repos","events_url":"https://api.github.com/users/Coenego/events{/privacy}","received_events_url":"https://api.github.com/users/Coenego/received_events","type":"User","site_admin":false},"body":"`# If file for...`","created_at":"2015-02-09T09:51:09Z","updated_at":"2015-02-09T09:51:09Z","html_url":"https://github.com/CUL-DigitalServices/grasshopper-puppet/pull/5#discussion_r24317379","pull_request_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/pulls/comments/24317379"},"html":{"href":"https://github.com/CUL-DigitalServices/grasshopper-puppet/pull/5#discussion_r24317379"},"pull_request":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/pulls/5","id":28811097,"html_url":"https://github.com/CUL-DigitalServices/grasshopper-puppet/pull/5","diff_url":"https://github.com/CUL-DigitalServices/grasshopper-puppet/pull/5.diff","patch_url":"https://github.com/CUL-DigitalServices/grasshopper-puppet/pull/5.patch","issue_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/issues/5","number":5,"state":"open","locked":false,"title":"Ready for qa server","user":{"login":"ucamrc","id":9320818,"avatar_url":"https://avatars.githubusercontent.com/u/9320818?v=3","gravatar_id":"","url":"https://api.github.com/users/ucamrc","html_url":"https://github.com/ucamrc","followers_url":"https://api.github.com/users/ucamrc/followers","following_url":"https://api.github.com/users/ucamrc/following{/other_user}","gists_url":"https://api.github.com/users/ucamrc/gists{/gist_id}","starred_url":"https://api.github.com/users/ucamrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucamrc/subscriptions","organizations_url":"https://api.github.com/users/ucamrc/orgs","repos_url":"https://api.github.com/users/ucamrc/repos","events_url":"https://api.github.com/users/ucamrc/events{/privacy}","received_events_url":"https://api.github.com/users/ucamrc/received_events","type":"User","site_admin":false},"body":"Notes:\r\n* Please don't deploy the \"real\" QA server yet until I've had a chance to chat to you both, but feel free to provision practice versions of it\r\n* **NOTE**: provisioning/grasshopper/init.sh now takes an argument, e.g. \"qa\"\r\n* Fixed a bug with auth protection, it used to let /api be publicly accessible, you might want to update any dev servers you have provisioned\r\n* Fixed applicable stuff in PR #3\r\n  * Replies to specific points:\r\n    * Re: AMI preference - I haven't decided anything definitively, I will chat you both about this later\r\n    * Re: Extras in Apache conf - the only two extras are robots.txt and basic-auth protection - not sure if you really want these in grasshopper-ui (and grasshopper) ?\r\n* QA environment is almost the same as dev except\r\n  * Publicly accessible (no basic auth)\r\n  * Example Git Revisions in `common.json` are now commit SHAs instead of \"master\", but you will want to **change them** to something deliberately chosen for QA\r\n  * Default App DisplayName for QA is \"My Timetable - Beta\" (but you can change this in `common.json` where all the other settings are like hostname and git revisions)\r\n","created_at":"2015-02-06T14:15:46Z","updated_at":"2015-02-09T09:51:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51305312c9b2beffdca707cad4a93451b8045eff","assignee":{"login":"bp323","id":218391,"avatar_url":"https://avatars.githubusercontent.com/u/218391?v=3","gravatar_id":"","url":"https://api.github.com/users/bp323","html_url":"https://github.com/bp323","followers_url":"https://api.github.com/users/bp323/followers","following_url":"https://api.github.com/users/bp323/following{/other_user}","gists_url":"https://api.github.com/users/bp323/gists{/gist_id}","starred_url":"https://api.github.com/users/bp323/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bp323/subscriptions","organizations_url":"https://api.github.com/users/bp323/orgs","repos_url":"https://api.github.com/users/bp323/repos","events_url":"https://api.github.com/users/bp323/events{/privacy}","received_events_url":"https://api.github.com/users/bp323/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/pulls/5/commits","review_comments_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/pulls/5/comments","review_comment_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/issues/5/comments","statuses_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/statuses/8cc79e07214fbaee6a10c4aae3c6b86e4b566a20","head":{"label":"ucamrc:ready-for-qa-server","ref":"ready-for-qa-server","sha":"8cc79e07214fbaee6a10c4aae3c6b86e4b566a20","user":{"login":"ucamrc","id":9320818,"avatar_url":"https://avatars.githubusercontent.com/u/9320818?v=3","gravatar_id":"","url":"https://api.github.com/users/ucamrc","html_url":"https://github.com/ucamrc","followers_url":"https://api.github.com/users/ucamrc/followers","following_url":"https://api.github.com/users/ucamrc/following{/other_user}","gists_url":"https://api.github.com/users/ucamrc/gists{/gist_id}","starred_url":"https://api.github.com/users/ucamrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucamrc/subscriptions","organizations_url":"https://api.github.com/users/ucamrc/orgs","repos_url":"https://api.github.com/users/ucamrc/repos","events_url":"https://api.github.com/users/ucamrc/events{/privacy}","received_events_url":"https://api.github.com/users/ucamrc/received_events","type":"User","site_admin":false},"repo":{"id":29536000,"name":"grasshopper-puppet","full_name":"ucamrc/grasshopper-puppet","owner":{"login":"ucamrc","id":9320818,"avatar_url":"https://avatars.githubusercontent.com/u/9320818?v=3","gravatar_id":"","url":"https://api.github.com/users/ucamrc","html_url":"https://github.com/ucamrc","followers_url":"https://api.github.com/users/ucamrc/followers","following_url":"https://api.github.com/users/ucamrc/following{/other_user}","gists_url":"https://api.github.com/users/ucamrc/gists{/gist_id}","starred_url":"https://api.github.com/users/ucamrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucamrc/subscriptions","organizations_url":"https://api.github.com/users/ucamrc/orgs","repos_url":"https://api.github.com/users/ucamrc/repos","events_url":"https://api.github.com/users/ucamrc/events{/privacy}","received_events_url":"https://api.github.com/users/ucamrc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ucamrc/grasshopper-puppet","description":"Grasshopper Puppet scripts","fork":true,"url":"https://api.github.com/repos/ucamrc/grasshopper-puppet","forks_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/forks","keys_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/teams","hooks_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/hooks","issue_events_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/events","assignees_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/tags","blobs_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/languages","stargazers_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/stargazers","contributors_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/contributors","subscribers_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/subscribers","subscription_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/subscription","commits_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/merges","archive_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/downloads","issues_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/labels{/name}","releases_url":"https://api.github.com/repos/ucamrc/grasshopper-puppet/releases{/id}","created_at":"2015-01-20T15:16:57Z","updated_at":"2015-02-05T13:43:05Z","pushed_at":"2015-02-06T14:09:33Z","git_url":"git://github.com/ucamrc/grasshopper-puppet.git","ssh_url":"git@github.com:ucamrc/grasshopper-puppet.git","clone_url":"https://github.com/ucamrc/grasshopper-puppet.git","svn_url":"https://github.com/ucamrc/grasshopper-puppet","homepage":null,"size":571,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CUL-DigitalServices:master","ref":"master","sha":"35a5219c5f9274d7d5a97d096217b1de6ecc438e","user":{"login":"CUL-DigitalServices","id":5594563,"avatar_url":"https://avatars.githubusercontent.com/u/5594563?v=3","gravatar_id":"","url":"https://api.github.com/users/CUL-DigitalServices","html_url":"https://github.com/CUL-DigitalServices","followers_url":"https://api.github.com/users/CUL-DigitalServices/followers","following_url":"https://api.github.com/users/CUL-DigitalServices/following{/other_user}","gists_url":"https://api.github.com/users/CUL-DigitalServices/gists{/gist_id}","starred_url":"https://api.github.com/users/CUL-DigitalServices/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CUL-DigitalServices/subscriptions","organizations_url":"https://api.github.com/users/CUL-DigitalServices/orgs","repos_url":"https://api.github.com/users/CUL-DigitalServices/repos","events_url":"https://api.github.com/users/CUL-DigitalServices/events{/privacy}","received_events_url":"https://api.github.com/users/CUL-DigitalServices/received_events","type":"Organization","site_admin":false},"repo":{"id":28180162,"name":"grasshopper-puppet","full_name":"CUL-DigitalServices/grasshopper-puppet","owner":{"login":"CUL-DigitalServices","id":5594563,"avatar_url":"https://avatars.githubusercontent.com/u/5594563?v=3","gravatar_id":"","url":"https://api.github.com/users/CUL-DigitalServices","html_url":"https://github.com/CUL-DigitalServices","followers_url":"https://api.github.com/users/CUL-DigitalServices/followers","following_url":"https://api.github.com/users/CUL-DigitalServices/following{/other_user}","gists_url":"https://api.github.com/users/CUL-DigitalServices/gists{/gist_id}","starred_url":"https://api.github.com/users/CUL-DigitalServices/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CUL-DigitalServices/subscriptions","organizations_url":"https://api.github.com/users/CUL-DigitalServices/orgs","repos_url":"https://api.github.com/users/CUL-DigitalServices/repos","events_url":"https://api.github.com/users/CUL-DigitalServices/events{/privacy}","received_events_url":"https://api.github.com/users/CUL-DigitalServices/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CUL-DigitalServices/grasshopper-puppet","description":"Grasshopper Puppet scripts","fork":false,"url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet","forks_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/forks","keys_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/teams","hooks_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/hooks","issue_events_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/events","assignees_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/tags","blobs_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/languages","stargazers_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/stargazers","contributors_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/contributors","subscribers_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/subscribers","subscription_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/subscription","commits_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/merges","archive_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/downloads","issues_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/labels{/name}","releases_url":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/releases{/id}","created_at":"2014-12-18T11:05:16Z","updated_at":"2015-02-05T13:21:32Z","pushed_at":"2015-02-05T13:21:32Z","git_url":"git://github.com/CUL-DigitalServices/grasshopper-puppet.git","ssh_url":"git@github.com:CUL-DigitalServices/grasshopper-puppet.git","clone_url":"https://github.com/CUL-DigitalServices/grasshopper-puppet.git","svn_url":"https://github.com/CUL-DigitalServices/grasshopper-puppet","homepage":null,"size":204,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/pulls/5"},"html":{"href":"https://github.com/CUL-DigitalServices/grasshopper-puppet/pull/5"},"issue":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/issues/5"},"comments":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/CUL-DigitalServices/grasshopper-puppet/statuses/8cc79e07214fbaee6a10c4aae3c6b86e4b566a20"}}}}