{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/43635014","id":43635014,"diff_hunk":"@@ -0,0 +1,78 @@\n+/*\n+ * The MIT License\n+ *\n+ * Copyright 2015 CloudBees, Inc.\n+ *\n+ * Permission is hereby granted, free of charge, to any person obtaining a copy\n+ * of this software and associated documentation files (the \"Software\"), to deal\n+ * in the Software without restriction, including without limitation the rights\n+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+ * copies of the Software, and to permit persons to whom the Software is\n+ * furnished to do so, subject to the following conditions:\n+ *\n+ * The above copyright notice and this permission notice shall be included in\n+ * all copies or substantial portions of the Software.\n+ *\n+ * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+ * THE SOFTWARE.\n+ */\n+\n+package jenkins.model;\n+\n+import hudson.Extension;\n+import hudson.model.Descriptor;\n+import hudson.model.DescriptorVisibilityFilter;\n+import hudson.model.Items;\n+import hudson.model.Job;\n+import org.kohsuke.stapler.DataBoundConstructor;\n+\n+/**\n+ * Defines a {@link BuildDiscarder}.\n+ */","path":"core/src/main/java/jenkins/model/BuildDiscarderProperty.java","position":null,"original_position":36,"commit_id":"182e99c24381fe1c7d3f2ec3f47d0b579b774f60","original_commit_id":"1cbbb23923d002dc6e676bfcaecbf8cbddb2e974","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"> And on methods too\r\n\r\n`@since` is not needed on members of a class introduced at the same time as the class as a whole.","created_at":"2015-11-02T14:49:48Z","updated_at":"2015-11-02T14:49:48Z","html_url":"https://github.com/jenkinsci/jenkins/pull/1889#discussion_r43635014","pull_request_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1889","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/43635014"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1889#discussion_r43635014"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1889"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1889","id":48930603,"html_url":"https://github.com/jenkinsci/jenkins/pull/1889","diff_url":"https://github.com/jenkinsci/jenkins/pull/1889.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/1889.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1889","number":1889,"state":"open","locked":false,"title":"BuildDiscarderProperty","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"Downstream of #1888. Migrates a legacy field into an `OptionalJobProperty`.\r\n\r\n[Incremental diff](https://github.com/jglick/jenkins/compare/OptionalJobProperty...jglick:BuildDiscarderProperty)\r\n\r\n@reviewbybees","created_at":"2015-10-27T20:52:59Z","updated_at":"2015-11-02T14:49:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"235c2013da9ab80a9b09b73452f64a3c4dec3982","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1889/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1889/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1889/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/182e99c24381fe1c7d3f2ec3f47d0b579b774f60","head":{"label":"jglick:BuildDiscarderProperty","ref":"BuildDiscarderProperty","sha":"182e99c24381fe1c7d3f2ec3f47d0b579b774f60","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"repo":{"id":4914128,"name":"jenkins","full_name":"jglick/jenkins","owner":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jglick/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/jglick/jenkins","forks_url":"https://api.github.com/repos/jglick/jenkins/forks","keys_url":"https://api.github.com/repos/jglick/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jglick/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jglick/jenkins/teams","hooks_url":"https://api.github.com/repos/jglick/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jglick/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jglick/jenkins/events","assignees_url":"https://api.github.com/repos/jglick/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jglick/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jglick/jenkins/tags","blobs_url":"https://api.github.com/repos/jglick/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jglick/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jglick/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jglick/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jglick/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jglick/jenkins/languages","stargazers_url":"https://api.github.com/repos/jglick/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jglick/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jglick/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jglick/jenkins/subscription","commits_url":"https://api.github.com/repos/jglick/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jglick/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jglick/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jglick/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jglick/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jglick/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jglick/jenkins/merges","archive_url":"https://api.github.com/repos/jglick/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jglick/jenkins/downloads","issues_url":"https://api.github.com/repos/jglick/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jglick/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jglick/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jglick/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jglick/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jglick/jenkins/releases{/id}","created_at":"2012-07-05T19:53:26Z","updated_at":"2015-02-22T21:27:52Z","pushed_at":"2015-11-02T14:46:30Z","git_url":"git://github.com/jglick/jenkins.git","ssh_url":"git@github.com:jglick/jenkins.git","clone_url":"https://github.com/jglick/jenkins.git","svn_url":"https://github.com/jglick/jenkins","homepage":"http://jenkins-ci.org/","size":88913,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"b21c33fb0bde99bfd999ebd8ad5a39523c466e46","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","created_at":"2010-11-22T21:21:23Z","updated_at":"2015-11-02T14:32:03Z","pushed_at":"2015-11-02T14:46:35Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"http://jenkins-ci.org/","size":459818,"stargazers_count":4709,"watchers_count":4709,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2110,"mirror_url":null,"open_issues_count":113,"forks":2110,"open_issues":113,"watchers":4709,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1889"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1889"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1889"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1889/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1889/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1889/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/182e99c24381fe1c7d3f2ec3f47d0b579b774f60"}}}}