{"action":"closed","number":203,"pull_request":{"url":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/203","id":52453018,"html_url":"https://github.com/facebook/augmented-traffic-control/pull/203","diff_url":"https://github.com/facebook/augmented-traffic-control/pull/203.diff","patch_url":"https://github.com/facebook/augmented-traffic-control/pull/203.patch","issue_url":"https://api.github.com/repos/facebook/augmented-traffic-control/issues/203","number":203,"state":"closed","locked":false,"title":"cleaned up makefile","user":{"login":"zfjagann","id":794008,"avatar_url":"https://avatars.githubusercontent.com/u/794008?v=3","gravatar_id":"","url":"https://api.github.com/users/zfjagann","html_url":"https://github.com/zfjagann","followers_url":"https://api.github.com/users/zfjagann/followers","following_url":"https://api.github.com/users/zfjagann/following{/other_user}","gists_url":"https://api.github.com/users/zfjagann/gists{/gist_id}","starred_url":"https://api.github.com/users/zfjagann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfjagann/subscriptions","organizations_url":"https://api.github.com/users/zfjagann/orgs","repos_url":"https://api.github.com/users/zfjagann/repos","events_url":"https://api.github.com/users/zfjagann/events{/privacy}","received_events_url":"https://api.github.com/users/zfjagann/received_events","type":"User","site_admin":false},"body":"I cleaned up the makefiles and added meta-targets for the things we do frequently, including:\r\n\r\n- `make bin`: just builds binaries and nothing else (the default)\r\n- `make test`: runs unit tests\r\n- `make ui`: compiles jsx and bundles into go file\r\n- `make lint`: runs go fmt/vet and jsx linter.\r\n- `make all`: all of the above, in the appropriate order\r\n\r\nThere is a [minor problem](https://gist.github.com/zfjagann/1ec32fc023ad50e9d0bf) where `ui` is an implicit dependency of `bin`, I plan to fix this in a later commit.","created_at":"2015-12-02T20:57:23Z","updated_at":"2015-12-02T22:41:33Z","closed_at":"2015-12-02T22:41:33Z","merged_at":"2015-12-02T22:41:33Z","merge_commit_sha":"76568ca3a96cd4af5138af56ad3caf8acb37eb43","assignee":{"login":"chantra","id":24572,"avatar_url":"https://avatars.githubusercontent.com/u/24572?v=3","gravatar_id":"","url":"https://api.github.com/users/chantra","html_url":"https://github.com/chantra","followers_url":"https://api.github.com/users/chantra/followers","following_url":"https://api.github.com/users/chantra/following{/other_user}","gists_url":"https://api.github.com/users/chantra/gists{/gist_id}","starred_url":"https://api.github.com/users/chantra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chantra/subscriptions","organizations_url":"https://api.github.com/users/chantra/orgs","repos_url":"https://api.github.com/users/chantra/repos","events_url":"https://api.github.com/users/chantra/events{/privacy}","received_events_url":"https://api.github.com/users/chantra/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/203/commits","review_comments_url":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/203/comments","review_comment_url":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/augmented-traffic-control/issues/203/comments","statuses_url":"https://api.github.com/repos/facebook/augmented-traffic-control/statuses/a8a5c6c0fbaefe7b38d0f4a017daf849abd8684f","head":{"label":"zfjagann:fix","ref":"fix","sha":"a8a5c6c0fbaefe7b38d0f4a017daf849abd8684f","user":{"login":"zfjagann","id":794008,"avatar_url":"https://avatars.githubusercontent.com/u/794008?v=3","gravatar_id":"","url":"https://api.github.com/users/zfjagann","html_url":"https://github.com/zfjagann","followers_url":"https://api.github.com/users/zfjagann/followers","following_url":"https://api.github.com/users/zfjagann/following{/other_user}","gists_url":"https://api.github.com/users/zfjagann/gists{/gist_id}","starred_url":"https://api.github.com/users/zfjagann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfjagann/subscriptions","organizations_url":"https://api.github.com/users/zfjagann/orgs","repos_url":"https://api.github.com/users/zfjagann/repos","events_url":"https://api.github.com/users/zfjagann/events{/privacy}","received_events_url":"https://api.github.com/users/zfjagann/received_events","type":"User","site_admin":false},"repo":{"id":32881625,"name":"augmented-traffic-control","full_name":"zfjagann/augmented-traffic-control","owner":{"login":"zfjagann","id":794008,"avatar_url":"https://avatars.githubusercontent.com/u/794008?v=3","gravatar_id":"","url":"https://api.github.com/users/zfjagann","html_url":"https://github.com/zfjagann","followers_url":"https://api.github.com/users/zfjagann/followers","following_url":"https://api.github.com/users/zfjagann/following{/other_user}","gists_url":"https://api.github.com/users/zfjagann/gists{/gist_id}","starred_url":"https://api.github.com/users/zfjagann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfjagann/subscriptions","organizations_url":"https://api.github.com/users/zfjagann/orgs","repos_url":"https://api.github.com/users/zfjagann/repos","events_url":"https://api.github.com/users/zfjagann/events{/privacy}","received_events_url":"https://api.github.com/users/zfjagann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zfjagann/augmented-traffic-control","description":"Augmented Traffic Control: A tool to simulate network conditions","fork":true,"url":"https://api.github.com/repos/zfjagann/augmented-traffic-control","forks_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/forks","keys_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/teams","hooks_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/hooks","issue_events_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/issues/events{/number}","events_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/events","assignees_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/assignees{/user}","branches_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/branches{/branch}","tags_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/tags","blobs_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/statuses/{sha}","languages_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/languages","stargazers_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/stargazers","contributors_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/contributors","subscribers_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/subscribers","subscription_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/subscription","commits_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/issues/comments{/number}","contents_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/contents/{+path}","compare_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/merges","archive_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/downloads","issues_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/issues{/number}","pulls_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/pulls{/number}","milestones_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/milestones{/number}","notifications_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/labels{/name}","releases_url":"https://api.github.com/repos/zfjagann/augmented-traffic-control/releases{/id}","created_at":"2015-03-25T17:59:02Z","updated_at":"2015-04-02T21:16:23Z","pushed_at":"2015-12-02T22:23:49Z","git_url":"git://github.com/zfjagann/augmented-traffic-control.git","ssh_url":"git@github.com:zfjagann/augmented-traffic-control.git","clone_url":"https://github.com/zfjagann/augmented-traffic-control.git","svn_url":"https://github.com/zfjagann/augmented-traffic-control","homepage":"https://facebook.github.io/augmented-traffic-control","size":10510,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:golang","ref":"golang","sha":"317f2249d6eccb3042a25574c2f598be2b9e3ea2","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":17996971,"name":"augmented-traffic-control","full_name":"facebook/augmented-traffic-control","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/augmented-traffic-control","description":"Augmented Traffic Control: A tool to simulate network conditions","fork":false,"url":"https://api.github.com/repos/facebook/augmented-traffic-control","forks_url":"https://api.github.com/repos/facebook/augmented-traffic-control/forks","keys_url":"https://api.github.com/repos/facebook/augmented-traffic-control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/augmented-traffic-control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/augmented-traffic-control/teams","hooks_url":"https://api.github.com/repos/facebook/augmented-traffic-control/hooks","issue_events_url":"https://api.github.com/repos/facebook/augmented-traffic-control/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/augmented-traffic-control/events","assignees_url":"https://api.github.com/repos/facebook/augmented-traffic-control/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/augmented-traffic-control/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/augmented-traffic-control/tags","blobs_url":"https://api.github.com/repos/facebook/augmented-traffic-control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/augmented-traffic-control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/augmented-traffic-control/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/augmented-traffic-control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/augmented-traffic-control/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/augmented-traffic-control/languages","stargazers_url":"https://api.github.com/repos/facebook/augmented-traffic-control/stargazers","contributors_url":"https://api.github.com/repos/facebook/augmented-traffic-control/contributors","subscribers_url":"https://api.github.com/repos/facebook/augmented-traffic-control/subscribers","subscription_url":"https://api.github.com/repos/facebook/augmented-traffic-control/subscription","commits_url":"https://api.github.com/repos/facebook/augmented-traffic-control/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/augmented-traffic-control/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/augmented-traffic-control/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/augmented-traffic-control/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/augmented-traffic-control/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/augmented-traffic-control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/augmented-traffic-control/merges","archive_url":"https://api.github.com/repos/facebook/augmented-traffic-control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/augmented-traffic-control/downloads","issues_url":"https://api.github.com/repos/facebook/augmented-traffic-control/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/augmented-traffic-control/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/augmented-traffic-control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/augmented-traffic-control/labels{/name}","releases_url":"https://api.github.com/repos/facebook/augmented-traffic-control/releases{/id}","created_at":"2014-03-21T22:58:17Z","updated_at":"2015-12-02T10:37:59Z","pushed_at":"2015-12-02T22:41:34Z","git_url":"git://github.com/facebook/augmented-traffic-control.git","ssh_url":"git@github.com:facebook/augmented-traffic-control.git","clone_url":"https://github.com/facebook/augmented-traffic-control.git","svn_url":"https://github.com/facebook/augmented-traffic-control","homepage":"https://facebook.github.io/augmented-traffic-control","size":10676,"stargazers_count":2629,"watchers_count":2629,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":362,"mirror_url":null,"open_issues_count":15,"forks":362,"open_issues":15,"watchers":2629,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/203"},"html":{"href":"https://github.com/facebook/augmented-traffic-control/pull/203"},"issue":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/issues/203"},"comments":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/statuses/a8a5c6c0fbaefe7b38d0f4a017daf849abd8684f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"chantra","id":24572,"avatar_url":"https://avatars.githubusercontent.com/u/24572?v=3","gravatar_id":"","url":"https://api.github.com/users/chantra","html_url":"https://github.com/chantra","followers_url":"https://api.github.com/users/chantra/followers","following_url":"https://api.github.com/users/chantra/following{/other_user}","gists_url":"https://api.github.com/users/chantra/gists{/gist_id}","starred_url":"https://api.github.com/users/chantra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chantra/subscriptions","organizations_url":"https://api.github.com/users/chantra/orgs","repos_url":"https://api.github.com/users/chantra/repos","events_url":"https://api.github.com/users/chantra/events{/privacy}","received_events_url":"https://api.github.com/users/chantra/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":3,"additions":386,"deletions":29,"changed_files":5}}