{"action":"created","issue":{"url":"https://api.github.com/repos/npm/newww/issues/860","labels_url":"https://api.github.com/repos/npm/newww/issues/860/labels{/name}","comments_url":"https://api.github.com/repos/npm/newww/issues/860/comments","events_url":"https://api.github.com/repos/npm/newww/issues/860/events","html_url":"https://github.com/npm/newww/issues/860","id":67483823,"number":860,"title":"Add logging for all external API requests","user":{"login":"rockbot","id":954269,"avatar_url":"https://avatars.githubusercontent.com/u/954269?v=3","gravatar_id":"","url":"https://api.github.com/users/rockbot","html_url":"https://github.com/rockbot","followers_url":"https://api.github.com/users/rockbot/followers","following_url":"https://api.github.com/users/rockbot/following{/other_user}","gists_url":"https://api.github.com/users/rockbot/gists{/gist_id}","starred_url":"https://api.github.com/users/rockbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockbot/subscriptions","organizations_url":"https://api.github.com/users/rockbot/orgs","repos_url":"https://api.github.com/users/rockbot/repos","events_url":"https://api.github.com/users/rockbot/events{/privacy}","received_events_url":"https://api.github.com/users/rockbot/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/npm/newww/labels/r2","name":"r2","color":"f7c6c7"}],"state":"open","locked":false,"assignee":{"login":"rockbot","id":954269,"avatar_url":"https://avatars.githubusercontent.com/u/954269?v=3","gravatar_id":"","url":"https://api.github.com/users/rockbot","html_url":"https://github.com/rockbot","followers_url":"https://api.github.com/users/rockbot/followers","following_url":"https://api.github.com/users/rockbot/following{/other_user}","gists_url":"https://api.github.com/users/rockbot/gists{/gist_id}","starred_url":"https://api.github.com/users/rockbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockbot/subscriptions","organizations_url":"https://api.github.com/users/rockbot/orgs","repos_url":"https://api.github.com/users/rockbot/repos","events_url":"https://api.github.com/users/rockbot/events{/privacy}","received_events_url":"https://api.github.com/users/rockbot/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/npm/newww/milestones/1","html_url":"https://github.com/npm/newww/milestones/Registry2","labels_url":"https://api.github.com/repos/npm/newww/milestones/1/labels","id":985538,"number":1,"title":"Registry2","description":"Electric boogaloo!","creator":{"login":"ceejbot","id":757502,"avatar_url":"https://avatars.githubusercontent.com/u/757502?v=3","gravatar_id":"","url":"https://api.github.com/users/ceejbot","html_url":"https://github.com/ceejbot","followers_url":"https://api.github.com/users/ceejbot/followers","following_url":"https://api.github.com/users/ceejbot/following{/other_user}","gists_url":"https://api.github.com/users/ceejbot/gists{/gist_id}","starred_url":"https://api.github.com/users/ceejbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceejbot/subscriptions","organizations_url":"https://api.github.com/users/ceejbot/orgs","repos_url":"https://api.github.com/users/ceejbot/repos","events_url":"https://api.github.com/users/ceejbot/events{/privacy}","received_events_url":"https://api.github.com/users/ceejbot/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":24,"state":"open","created_at":"2015-02-19T00:55:24Z","updated_at":"2015-04-10T01:17:01Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-04-10T01:16:35Z","updated_at":"2015-04-10T02:01:25Z","closed_at":null,"body":"> wherever we're interacting with an external API, I'd love to see all requests + status codes and the error message returned :smile: "},"comment":{"url":"https://api.github.com/repos/npm/newww/issues/comments/91400670","html_url":"https://github.com/npm/newww/issues/860#issuecomment-91400670","issue_url":"https://api.github.com/repos/npm/newww/issues/860","id":91400670,"user":{"login":"zeke","id":2289,"avatar_url":"https://avatars.githubusercontent.com/u/2289?v=3","gravatar_id":"","url":"https://api.github.com/users/zeke","html_url":"https://github.com/zeke","followers_url":"https://api.github.com/users/zeke/followers","following_url":"https://api.github.com/users/zeke/following{/other_user}","gists_url":"https://api.github.com/users/zeke/gists{/gist_id}","starred_url":"https://api.github.com/users/zeke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeke/subscriptions","organizations_url":"https://api.github.com/users/zeke/orgs","repos_url":"https://api.github.com/users/zeke/repos","events_url":"https://api.github.com/users/zeke/events{/privacy}","received_events_url":"https://api.github.com/users/zeke/received_events","type":"User","site_admin":false},"created_at":"2015-04-10T02:01:25Z","updated_at":"2015-04-10T02:01:25Z","body":"Two cents.\r\n\r\nWhile I agree in principle that every request should be easily logged, I would rather we add logging only where we're lacking visibility or investigating bugs for the moment (I.e licensing API stuff) for the time being.\r\n\r\nLater we can log all the things when we have something like hyperclient that wraps all requests. We have a lot of duplicate code debt to pay down in www already and I don't wish to prolong the phenomenon."}}