{"action":"created","issue":{"url":"https://api.github.com/repos/NLeSC/Xenon/issues/348","labels_url":"https://api.github.com/repos/NLeSC/Xenon/issues/348/labels{/name}","comments_url":"https://api.github.com/repos/NLeSC/Xenon/issues/348/comments","events_url":"https://api.github.com/repos/NLeSC/Xenon/issues/348/events","html_url":"https://github.com/NLeSC/Xenon/issues/348","id":121035898,"number":348,"title":"make sure that javadoc mentions that xenons, credential etc must be closed when done","user":{"login":"jspaaks","id":4558105,"avatar_url":"https://avatars.githubusercontent.com/u/4558105?v=3","gravatar_id":"","url":"https://api.github.com/users/jspaaks","html_url":"https://github.com/jspaaks","followers_url":"https://api.github.com/users/jspaaks/followers","following_url":"https://api.github.com/users/jspaaks/following{/other_user}","gists_url":"https://api.github.com/users/jspaaks/gists{/gist_id}","starred_url":"https://api.github.com/users/jspaaks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspaaks/subscriptions","organizations_url":"https://api.github.com/users/jspaaks/orgs","repos_url":"https://api.github.com/users/jspaaks/repos","events_url":"https://api.github.com/users/jspaaks/events{/privacy}","received_events_url":"https://api.github.com/users/jspaaks/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jspaaks","id":4558105,"avatar_url":"https://avatars.githubusercontent.com/u/4558105?v=3","gravatar_id":"","url":"https://api.github.com/users/jspaaks","html_url":"https://github.com/jspaaks","followers_url":"https://api.github.com/users/jspaaks/followers","following_url":"https://api.github.com/users/jspaaks/following{/other_user}","gists_url":"https://api.github.com/users/jspaaks/gists{/gist_id}","starred_url":"https://api.github.com/users/jspaaks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspaaks/subscriptions","organizations_url":"https://api.github.com/users/jspaaks/orgs","repos_url":"https://api.github.com/users/jspaaks/repos","events_url":"https://api.github.com/users/jspaaks/events{/privacy}","received_events_url":"https://api.github.com/users/jspaaks/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-12-08T15:50:47Z","updated_at":"2015-12-09T09:29:34Z","closed_at":null,"body":"e.g. \r\ncurrently mentioned in xenon.XenonFactory.endXenon, but not in \r\n- [ ] xenon.XenonFactory.newXenon\r\n- [ ] xenon.credentials.Credentials\r\n- [ ] xenon.files.Files\r\n- [ ] xenon.jobs.Jobs\r\n- [ ] etc"},"comment":{"url":"https://api.github.com/repos/NLeSC/Xenon/issues/comments/163161257","html_url":"https://github.com/NLeSC/Xenon/issues/348#issuecomment-163161257","issue_url":"https://api.github.com/repos/NLeSC/Xenon/issues/348","id":163161257,"user":{"login":"jspaaks","id":4558105,"avatar_url":"https://avatars.githubusercontent.com/u/4558105?v=3","gravatar_id":"","url":"https://api.github.com/users/jspaaks","html_url":"https://github.com/jspaaks","followers_url":"https://api.github.com/users/jspaaks/followers","following_url":"https://api.github.com/users/jspaaks/following{/other_user}","gists_url":"https://api.github.com/users/jspaaks/gists{/gist_id}","starred_url":"https://api.github.com/users/jspaaks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspaaks/subscriptions","organizations_url":"https://api.github.com/users/jspaaks/orgs","repos_url":"https://api.github.com/users/jspaaks/repos","events_url":"https://api.github.com/users/jspaaks/events{/privacy}","received_events_url":"https://api.github.com/users/jspaaks/received_events","type":"User","site_admin":false},"created_at":"2015-12-09T09:29:34Z","updated_at":"2015-12-09T09:29:34Z","body":"(From the javadoc) it looks like ending xenon will end any other resources, but it's probably better to at least indicate that allocated resources (be it credentials, files or anything else) should be released when you're done with them, and that it is up to the user to do so. \r\n\r\nIt would be even better if we could somehow check/guarantee this automatically, but let's solve that problem some other time."}}