{"action":"created","issue":{"url":"https://api.github.com/repos/php-http/promise/issues/1","labels_url":"https://api.github.com/repos/php-http/promise/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/php-http/promise/issues/1/comments","events_url":"https://api.github.com/repos/php-http/promise/issues/1/events","html_url":"https://github.com/php-http/promise/pull/1","id":121885959,"number":1,"title":"Add type hinting to wait function","user":{"login":"joelwurtz","id":90466,"avatar_url":"https://avatars.githubusercontent.com/u/90466?v=3","gravatar_id":"","url":"https://api.github.com/users/joelwurtz","html_url":"https://github.com/joelwurtz","followers_url":"https://api.github.com/users/joelwurtz/followers","following_url":"https://api.github.com/users/joelwurtz/following{/other_user}","gists_url":"https://api.github.com/users/joelwurtz/gists{/gist_id}","starred_url":"https://api.github.com/users/joelwurtz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelwurtz/subscriptions","organizations_url":"https://api.github.com/users/joelwurtz/orgs","repos_url":"https://api.github.com/users/joelwurtz/repos","events_url":"https://api.github.com/users/joelwurtz/events{/privacy}","received_events_url":"https://api.github.com/users/joelwurtz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-12T22:54:50Z","updated_at":"2015-12-13T00:11:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/php-http/promise/pulls/1","html_url":"https://github.com/php-http/promise/pull/1","diff_url":"https://github.com/php-http/promise/pull/1.diff","patch_url":"https://github.com/php-http/promise/pull/1.patch"},"body":"IMO, we should force the type hinting of the wait method.\r\n\r\nThere is some reason to that : \r\n\r\n1. The wait method will probably never be in a PSR so there is probably no BC break upcoming for that\r\n2. Not having this type hinting will mean we allow everything as the value fulfilled / reason, which will induce in every package to check that the return type / reason is correct\r\n\r\nWDYT ?"},"comment":{"url":"https://api.github.com/repos/php-http/promise/issues/comments/164203827","html_url":"https://github.com/php-http/promise/pull/1#issuecomment-164203827","issue_url":"https://api.github.com/repos/php-http/promise/issues/1","id":164203827,"user":{"login":"sagikazarmark","id":1226384,"avatar_url":"https://avatars.githubusercontent.com/u/1226384?v=3","gravatar_id":"","url":"https://api.github.com/users/sagikazarmark","html_url":"https://github.com/sagikazarmark","followers_url":"https://api.github.com/users/sagikazarmark/followers","following_url":"https://api.github.com/users/sagikazarmark/following{/other_user}","gists_url":"https://api.github.com/users/sagikazarmark/gists{/gist_id}","starred_url":"https://api.github.com/users/sagikazarmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagikazarmark/subscriptions","organizations_url":"https://api.github.com/users/sagikazarmark/orgs","repos_url":"https://api.github.com/users/sagikazarmark/repos","events_url":"https://api.github.com/users/sagikazarmark/events{/privacy}","received_events_url":"https://api.github.com/users/sagikazarmark/received_events","type":"User","site_admin":false},"created_at":"2015-12-13T00:11:34Z","updated_at":"2015-12-13T00:11:34Z","body":"> Because they will probably say that a promise should use an Event Loop\r\n\r\nI will fight four our wait method.\r\n\r\nThe promises are actually used INSIDE our libraries now and in case of a PSR, which means the chance of having an invalid value is exactly the same as we would use a PSR Promise implementation. But I am fine with that."}}