{"action":"created","comment":{"url":"https://api.github.com/repos/juju/charmstore/pulls/comments/47246636","id":47246636,"diff_hunk":"@@ -1120,21 +1120,65 @@ func (h *ReqHandler) serveMacaroon(_ http.Header, _ *http.Request) (interface{},\n // GET /delegatable-macaroon\n // See https://github.com/juju/charmstore/blob/v4/docs/API.md#get-delegatable-macaroon\n func (h *ReqHandler) serveDelegatableMacaroon(_ http.Header, req *http.Request) (interface{}, error) {\n+\tvalues, err := url.ParseQuery(req.URL.RawQuery)\n+\tif err != nil {\n+\t\treturn nil, errgo.Mask(err)\n+\t}\n+\tentityIds := values[\"id\"]\n+\tif len(entityIds) == 0 {\n+\t\tauth, err := h.authorize(req, []string{params.Everyone}, true, nil)","path":"internal/v5/api.go","position":10,"original_position":10,"commit_id":"297e453ca1ba27cc7a1571063f937dff789e285a","original_commit_id":"297e453ca1ba27cc7a1571063f937dff789e285a","user":{"login":"alesstimec","id":5555154,"avatar_url":"https://avatars.githubusercontent.com/u/5555154?v=3","gravatar_id":"","url":"https://api.github.com/users/alesstimec","html_url":"https://github.com/alesstimec","followers_url":"https://api.github.com/users/alesstimec/followers","following_url":"https://api.github.com/users/alesstimec/following{/other_user}","gists_url":"https://api.github.com/users/alesstimec/gists{/gist_id}","starred_url":"https://api.github.com/users/alesstimec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alesstimec/subscriptions","organizations_url":"https://api.github.com/users/alesstimec/orgs","repos_url":"https://api.github.com/users/alesstimec/repos","events_url":"https://api.github.com/users/alesstimec/events{/privacy}","received_events_url":"https://api.github.com/users/alesstimec/received_events","type":"User","site_admin":false},"body":"done","created_at":"2015-12-10T16:16:18Z","updated_at":"2015-12-10T16:16:18Z","html_url":"https://github.com/juju/charmstore/pull/449#discussion_r47246636","pull_request_url":"https://api.github.com/repos/juju/charmstore/pulls/449","_links":{"self":{"href":"https://api.github.com/repos/juju/charmstore/pulls/comments/47246636"},"html":{"href":"https://github.com/juju/charmstore/pull/449#discussion_r47246636"},"pull_request":{"href":"https://api.github.com/repos/juju/charmstore/pulls/449"}}},"pull_request":{"url":"https://api.github.com/repos/juju/charmstore/pulls/449","id":50399182,"html_url":"https://github.com/juju/charmstore/pull/449","diff_url":"https://github.com/juju/charmstore/pull/449.diff","patch_url":"https://github.com/juju/charmstore/pull/449.patch","issue_url":"https://api.github.com/repos/juju/charmstore/issues/449","number":449,"state":"open","locked":false,"title":"V5 terms","user":{"login":"alesstimec","id":5555154,"avatar_url":"https://avatars.githubusercontent.com/u/5555154?v=3","gravatar_id":"","url":"https://api.github.com/users/alesstimec","html_url":"https://github.com/alesstimec","followers_url":"https://api.github.com/users/alesstimec/followers","following_url":"https://api.github.com/users/alesstimec/following{/other_user}","gists_url":"https://api.github.com/users/alesstimec/gists{/gist_id}","starred_url":"https://api.github.com/users/alesstimec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alesstimec/subscriptions","organizations_url":"https://api.github.com/users/alesstimec/orgs","repos_url":"https://api.github.com/users/alesstimec/repos","events_url":"https://api.github.com/users/alesstimec/events{/privacy}","received_events_url":"https://api.github.com/users/alesstimec/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-11T15:54:27Z","updated_at":"2015-12-10T16:16:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fbbcdfb87000f1f06d1645d765c08d08ec369f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/charmstore/pulls/449/commits","review_comments_url":"https://api.github.com/repos/juju/charmstore/pulls/449/comments","review_comment_url":"https://api.github.com/repos/juju/charmstore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/charmstore/issues/449/comments","statuses_url":"https://api.github.com/repos/juju/charmstore/statuses/297e453ca1ba27cc7a1571063f937dff789e285a","head":{"label":"juju:v5-terms","ref":"v5-terms","sha":"297e453ca1ba27cc7a1571063f937dff789e285a","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20720417,"name":"charmstore","full_name":"juju/charmstore","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/charmstore","description":"The charm store server.","fork":false,"url":"https://api.github.com/repos/juju/charmstore","forks_url":"https://api.github.com/repos/juju/charmstore/forks","keys_url":"https://api.github.com/repos/juju/charmstore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/charmstore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/charmstore/teams","hooks_url":"https://api.github.com/repos/juju/charmstore/hooks","issue_events_url":"https://api.github.com/repos/juju/charmstore/issues/events{/number}","events_url":"https://api.github.com/repos/juju/charmstore/events","assignees_url":"https://api.github.com/repos/juju/charmstore/assignees{/user}","branches_url":"https://api.github.com/repos/juju/charmstore/branches{/branch}","tags_url":"https://api.github.com/repos/juju/charmstore/tags","blobs_url":"https://api.github.com/repos/juju/charmstore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/charmstore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/charmstore/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/charmstore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/charmstore/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/charmstore/languages","stargazers_url":"https://api.github.com/repos/juju/charmstore/stargazers","contributors_url":"https://api.github.com/repos/juju/charmstore/contributors","subscribers_url":"https://api.github.com/repos/juju/charmstore/subscribers","subscription_url":"https://api.github.com/repos/juju/charmstore/subscription","commits_url":"https://api.github.com/repos/juju/charmstore/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/charmstore/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/charmstore/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/charmstore/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/charmstore/contents/{+path}","compare_url":"https://api.github.com/repos/juju/charmstore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/charmstore/merges","archive_url":"https://api.github.com/repos/juju/charmstore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/charmstore/downloads","issues_url":"https://api.github.com/repos/juju/charmstore/issues{/number}","pulls_url":"https://api.github.com/repos/juju/charmstore/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/charmstore/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/charmstore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/charmstore/labels{/name}","releases_url":"https://api.github.com/repos/juju/charmstore/releases{/id}","created_at":"2014-06-11T09:53:37Z","updated_at":"2015-11-13T21:09:17Z","pushed_at":"2015-12-10T15:32:05Z","git_url":"git://github.com/juju/charmstore.git","ssh_url":"git@github.com:juju/charmstore.git","clone_url":"https://github.com/juju/charmstore.git","svn_url":"https://github.com/juju/charmstore","homepage":null,"size":5015,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":17,"forks":16,"open_issues":17,"watchers":7,"default_branch":"v5-unstable"}},"base":{"label":"juju:v5-unstable","ref":"v5-unstable","sha":"679253d3f5cd5c6c7e2bd9babb75320cec961cd4","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20720417,"name":"charmstore","full_name":"juju/charmstore","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/charmstore","description":"The charm store server.","fork":false,"url":"https://api.github.com/repos/juju/charmstore","forks_url":"https://api.github.com/repos/juju/charmstore/forks","keys_url":"https://api.github.com/repos/juju/charmstore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/charmstore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/charmstore/teams","hooks_url":"https://api.github.com/repos/juju/charmstore/hooks","issue_events_url":"https://api.github.com/repos/juju/charmstore/issues/events{/number}","events_url":"https://api.github.com/repos/juju/charmstore/events","assignees_url":"https://api.github.com/repos/juju/charmstore/assignees{/user}","branches_url":"https://api.github.com/repos/juju/charmstore/branches{/branch}","tags_url":"https://api.github.com/repos/juju/charmstore/tags","blobs_url":"https://api.github.com/repos/juju/charmstore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/charmstore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/charmstore/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/charmstore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/charmstore/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/charmstore/languages","stargazers_url":"https://api.github.com/repos/juju/charmstore/stargazers","contributors_url":"https://api.github.com/repos/juju/charmstore/contributors","subscribers_url":"https://api.github.com/repos/juju/charmstore/subscribers","subscription_url":"https://api.github.com/repos/juju/charmstore/subscription","commits_url":"https://api.github.com/repos/juju/charmstore/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/charmstore/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/charmstore/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/charmstore/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/charmstore/contents/{+path}","compare_url":"https://api.github.com/repos/juju/charmstore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/charmstore/merges","archive_url":"https://api.github.com/repos/juju/charmstore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/charmstore/downloads","issues_url":"https://api.github.com/repos/juju/charmstore/issues{/number}","pulls_url":"https://api.github.com/repos/juju/charmstore/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/charmstore/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/charmstore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/charmstore/labels{/name}","releases_url":"https://api.github.com/repos/juju/charmstore/releases{/id}","created_at":"2014-06-11T09:53:37Z","updated_at":"2015-11-13T21:09:17Z","pushed_at":"2015-12-10T15:32:05Z","git_url":"git://github.com/juju/charmstore.git","ssh_url":"git@github.com:juju/charmstore.git","clone_url":"https://github.com/juju/charmstore.git","svn_url":"https://github.com/juju/charmstore","homepage":null,"size":5015,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":17,"forks":16,"open_issues":17,"watchers":7,"default_branch":"v5-unstable"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/charmstore/pulls/449"},"html":{"href":"https://github.com/juju/charmstore/pull/449"},"issue":{"href":"https://api.github.com/repos/juju/charmstore/issues/449"},"comments":{"href":"https://api.github.com/repos/juju/charmstore/issues/449/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/charmstore/pulls/449/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/charmstore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/charmstore/pulls/449/commits"},"statuses":{"href":"https://api.github.com/repos/juju/charmstore/statuses/297e453ca1ba27cc7a1571063f937dff789e285a"}}}}