{"action":"created","issue":{"url":"https://api.github.com/repos/Perl-Toolchain-Gang/ExtUtils-Manifest/issues/19","labels_url":"https://api.github.com/repos/Perl-Toolchain-Gang/ExtUtils-Manifest/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/Perl-Toolchain-Gang/ExtUtils-Manifest/issues/19/comments","events_url":"https://api.github.com/repos/Perl-Toolchain-Gang/ExtUtils-Manifest/issues/19/events","html_url":"https://github.com/Perl-Toolchain-Gang/ExtUtils-Manifest/pull/19","id":90263755,"number":19,"title":"Alternative Include-default tests","user":{"login":"kentfredric","id":44790,"avatar_url":"https://avatars.githubusercontent.com/u/44790?v=3","gravatar_id":"","url":"https://api.github.com/users/kentfredric","html_url":"https://github.com/kentfredric","followers_url":"https://api.github.com/users/kentfredric/followers","following_url":"https://api.github.com/users/kentfredric/following{/other_user}","gists_url":"https://api.github.com/users/kentfredric/gists{/gist_id}","starred_url":"https://api.github.com/users/kentfredric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentfredric/subscriptions","organizations_url":"https://api.github.com/users/kentfredric/orgs","repos_url":"https://api.github.com/users/kentfredric/repos","events_url":"https://api.github.com/users/kentfredric/events{/privacy}","received_events_url":"https://api.github.com/users/kentfredric/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-06-23T01:57:51Z","updated_at":"2015-09-08T15:45:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Perl-Toolchain-Gang/ExtUtils-Manifest/pulls/19","html_url":"https://github.com/Perl-Toolchain-Gang/ExtUtils-Manifest/pull/19","diff_url":"https://github.com/Perl-Toolchain-Gang/ExtUtils-Manifest/pull/19.diff","patch_url":"https://github.com/Perl-Toolchain-Gang/ExtUtils-Manifest/pull/19.patch"},"body":"This branch incorporates the patches to Manifest.pm by @mohawk2  in pull #17.\r\n\r\nHowever, it takes a different approach at testing, trying to put our best foot forwards in terms of not making the existing tests worse.\r\n\r\nThis sequence is of course, presently advisory, and commits can be squashed as needed.\r\n\r\nIdeally I would make the file IO inside the test-case neater by having a tinyer version of Path::Tiny so you can more clearly see where the tests are happening and where the cruft is happening.\r\n\r\nAdditionally, this code would be substantially neater if https://github.com/dagolden/Test-TempDir-Tiny/issues/7 was done.\r\n\r\nMy hope is this test will be 100% clear in exactly what it is testing, and why it is testing it.\r\n\r\nThere is by comparison nothing clear about: https://github.com/mohawk2/ExtUtils-Manifest/commit/4ab7d94a330848fb20d02bcbd5a5928d57ed3a9d#diff-58b9e890377f53ed47933c81a658843fR439 \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Perl-Toolchain-Gang/ExtUtils-Manifest/issues/comments/138605002","html_url":"https://github.com/Perl-Toolchain-Gang/ExtUtils-Manifest/pull/19#issuecomment-138605002","issue_url":"https://api.github.com/repos/Perl-Toolchain-Gang/ExtUtils-Manifest/issues/19","id":138605002,"user":{"login":"haarg","id":50029,"avatar_url":"https://avatars.githubusercontent.com/u/50029?v=3","gravatar_id":"","url":"https://api.github.com/users/haarg","html_url":"https://github.com/haarg","followers_url":"https://api.github.com/users/haarg/followers","following_url":"https://api.github.com/users/haarg/following{/other_user}","gists_url":"https://api.github.com/users/haarg/gists{/gist_id}","starred_url":"https://api.github.com/users/haarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haarg/subscriptions","organizations_url":"https://api.github.com/users/haarg/orgs","repos_url":"https://api.github.com/users/haarg/repos","events_url":"https://api.github.com/users/haarg/events{/privacy}","received_events_url":"https://api.github.com/users/haarg/received_events","type":"User","site_admin":false},"created_at":"2015-09-08T15:45:29Z","updated_at":"2015-09-08T15:45:29Z","body":"@mohawk2 Yes, definitely."}}