{"action":"created","comment":{"url":"https://api.github.com/repos/iadvize/git/pulls/comments/28073333","id":28073333,"diff_hunk":"@@ -15,56 +19,148 @@\n   - Explicit (non fast-forward) merge when done.\n \n   - Open a Pull Request as early as possible\n-  \n+\n Pull Requests are a great way to start a conversation of a feature, so start one as soon as possible - even before you are finished with the code. The team can comment on the feature as it evolves, instead of providing all their feedback at the very end.\n \n+## <a name='branching'>Branching</a>\n+\n+You should always create a new branch when working on a new feature.\n+\n+  - **master**: Should be exactly the same as production.\n+  - **develop**: Used as preproduction branch\n+  - **ABC-XXX-Description**: Feature branches\n+        > ABC-XXX is the issue identifier (ex: MCP-4332)\n+        > Description is a short introduction about the feature (MCP-4332-addSomeCrazyFeature)\n+\n+## <a name='start-feature'>Start a feature</a>\n \n+```bash\n+# Fetch commits from remote\n+$ git fetch origin\n \n-## <a name='workflow'>Workflow</a>\n+# Create feature branch\n+$ git checkout -b ABC-XXX-Description origin/develop\n \n-  1. Pull down the latest changes from `master`\n+# Push your branch early to get feedback\n+# Use `rebase` if you need to fresh up your branch\n+# Follow convention for commit message\n+$ git push -u origin ABC-XXX-Description\n \n-```sh\n-git fetch origin\n+# When you're ready, create a pull request following convention\n ```\n \n-  2. Create a new branch\n+## <a name='commit-message'>Commit message conventions</a>\n+\n+Commit message must be readable and understandable.\n+\n+### Commit message Format\n+\n+```php\n+// Simple\n+<type>(<scope...>): <Description>\n+\n+// Simple with issue\n+<type>(<scope...>): <Description>\n+#ABC-XXX\n+\n+// Full description\n+<type>(<scope...>): <Short description>\n+\n+<Explain more...>\n+\n+#ABC-XXX\n \n-```sh\n-git checkout -b feat-myAwesomeFeature-1234 origin/master\n ```\n \n-Branch name structure is composed of 3 parts separated by `-`:\n+### Type\n+\n+- **feature**: `feat(ApiController): Add post method for feature A`\n+    > Should represent a feature commit\n+\n+- **fix**: `fix(MessageService): fix wrong status code on GET request`\n+    > Should represent a bug fix\n+\n+- **style**: `style(ApiController): :lipstick:`\n+    > Changes that don't affect meaning of the code ony white-space, formatting\n+\n+- **documentation**: `doc(ApiController, MessageService): add documentation in controller + Reword class description for  Service`\n+    > Should represent a documentation changes\n+\n+- **refactor**: `refacto(MessageService): change message generation process`\n+    > A change for better readablilty (Don't add feature or fix bug)\n \n-  - Type of the changes: `feat` for a new feature or `fix` for a bug-fix\n-  - Short but explicit name in camelCase describing the changes\n-  - ID of the corresponding JIRA ticket (no need for the `IDZ-` part)\n-  \n-  3. Work on the feature\n+- **performance**: `perf(UrlGenerator): Replace libA for libB`\n+    > Should represent a performance improvment\n \n-  - Commit early, commit often.\n-  - Make sure your commits are meaningful.\n-  - Do not cluster separate changes together.\n+- **test**: `test(MessageService): Implement message service test for GET request`\n+    > Should represent a test implementation","path":"README.md","position":108,"original_position":108,"commit_id":"bd7f80974e4889e43fa9c6e1c1cdc871b4a60afa","original_commit_id":"533dfdc1b60e969d42d698bbcf5e69ce31165ea7","user":{"login":"antham","id":4854264,"avatar_url":"https://avatars.githubusercontent.com/u/4854264?v=3","gravatar_id":"","url":"https://api.github.com/users/antham","html_url":"https://github.com/antham","followers_url":"https://api.github.com/users/antham/followers","following_url":"https://api.github.com/users/antham/following{/other_user}","gists_url":"https://api.github.com/users/antham/gists{/gist_id}","starred_url":"https://api.github.com/users/antham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antham/subscriptions","organizations_url":"https://api.github.com/users/antham/orgs","repos_url":"https://api.github.com/users/antham/repos","events_url":"https://api.github.com/users/antham/events{/privacy}","received_events_url":"https://api.github.com/users/antham/received_events","type":"User","site_admin":false},"body":"Par contre mettre le nom des services, des controllers, etc... dans les parenthèses je trouve ça un peu lourd, le commit est là pour parler de lui-même aussi","created_at":"2015-04-09T15:39:09Z","updated_at":"2015-04-09T15:39:09Z","html_url":"https://github.com/iadvize/git/pull/2#discussion_r28073333","pull_request_url":"https://api.github.com/repos/iadvize/git/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/iadvize/git/pulls/comments/28073333"},"html":{"href":"https://github.com/iadvize/git/pull/2#discussion_r28073333"},"pull_request":{"href":"https://api.github.com/repos/iadvize/git/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/iadvize/git/pulls/2","id":31191870,"html_url":"https://github.com/iadvize/git/pull/2","diff_url":"https://github.com/iadvize/git/pull/2.diff","patch_url":"https://github.com/iadvize/git/pull/2.patch","issue_url":"https://api.github.com/repos/iadvize/git/issues/2","number":2,"state":"open","locked":false,"title":"Git convention proposal","user":{"login":"Freyskeyd","id":1394604,"avatar_url":"https://avatars.githubusercontent.com/u/1394604?v=3","gravatar_id":"","url":"https://api.github.com/users/Freyskeyd","html_url":"https://github.com/Freyskeyd","followers_url":"https://api.github.com/users/Freyskeyd/followers","following_url":"https://api.github.com/users/Freyskeyd/following{/other_user}","gists_url":"https://api.github.com/users/Freyskeyd/gists{/gist_id}","starred_url":"https://api.github.com/users/Freyskeyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Freyskeyd/subscriptions","organizations_url":"https://api.github.com/users/Freyskeyd/orgs","repos_url":"https://api.github.com/users/Freyskeyd/repos","events_url":"https://api.github.com/users/Freyskeyd/events{/privacy}","received_events_url":"https://api.github.com/users/Freyskeyd/received_events","type":"User","site_admin":false},"body":"Convention proposal:\r\n\r\n- Commit message convention\r\n- Branching description and management\r\n- Submission guidelines\r\n- Tips and tricks\r\n\r\nYou can see a preview of changes here : [Preview](https://github.com/Freyskeyd/git/blob/master/README.md)","created_at":"2015-03-14T23:05:07Z","updated_at":"2015-04-09T15:39:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0df2bc5e42254f205def8ff24b28a8393b34c0a1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iadvize/git/pulls/2/commits","review_comments_url":"https://api.github.com/repos/iadvize/git/pulls/2/comments","review_comment_url":"https://api.github.com/repos/iadvize/git/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iadvize/git/issues/2/comments","statuses_url":"https://api.github.com/repos/iadvize/git/statuses/bd7f80974e4889e43fa9c6e1c1cdc871b4a60afa","head":{"label":"Freyskeyd:master","ref":"master","sha":"bd7f80974e4889e43fa9c6e1c1cdc871b4a60afa","user":{"login":"Freyskeyd","id":1394604,"avatar_url":"https://avatars.githubusercontent.com/u/1394604?v=3","gravatar_id":"","url":"https://api.github.com/users/Freyskeyd","html_url":"https://github.com/Freyskeyd","followers_url":"https://api.github.com/users/Freyskeyd/followers","following_url":"https://api.github.com/users/Freyskeyd/following{/other_user}","gists_url":"https://api.github.com/users/Freyskeyd/gists{/gist_id}","starred_url":"https://api.github.com/users/Freyskeyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Freyskeyd/subscriptions","organizations_url":"https://api.github.com/users/Freyskeyd/orgs","repos_url":"https://api.github.com/users/Freyskeyd/repos","events_url":"https://api.github.com/users/Freyskeyd/events{/privacy}","received_events_url":"https://api.github.com/users/Freyskeyd/received_events","type":"User","site_admin":false},"repo":{"id":32209990,"name":"git","full_name":"Freyskeyd/git","owner":{"login":"Freyskeyd","id":1394604,"avatar_url":"https://avatars.githubusercontent.com/u/1394604?v=3","gravatar_id":"","url":"https://api.github.com/users/Freyskeyd","html_url":"https://github.com/Freyskeyd","followers_url":"https://api.github.com/users/Freyskeyd/followers","following_url":"https://api.github.com/users/Freyskeyd/following{/other_user}","gists_url":"https://api.github.com/users/Freyskeyd/gists{/gist_id}","starred_url":"https://api.github.com/users/Freyskeyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Freyskeyd/subscriptions","organizations_url":"https://api.github.com/users/Freyskeyd/orgs","repos_url":"https://api.github.com/users/Freyskeyd/repos","events_url":"https://api.github.com/users/Freyskeyd/events{/privacy}","received_events_url":"https://api.github.com/users/Freyskeyd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Freyskeyd/git","description":"iAdvize Git Convention","fork":true,"url":"https://api.github.com/repos/Freyskeyd/git","forks_url":"https://api.github.com/repos/Freyskeyd/git/forks","keys_url":"https://api.github.com/repos/Freyskeyd/git/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Freyskeyd/git/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Freyskeyd/git/teams","hooks_url":"https://api.github.com/repos/Freyskeyd/git/hooks","issue_events_url":"https://api.github.com/repos/Freyskeyd/git/issues/events{/number}","events_url":"https://api.github.com/repos/Freyskeyd/git/events","assignees_url":"https://api.github.com/repos/Freyskeyd/git/assignees{/user}","branches_url":"https://api.github.com/repos/Freyskeyd/git/branches{/branch}","tags_url":"https://api.github.com/repos/Freyskeyd/git/tags","blobs_url":"https://api.github.com/repos/Freyskeyd/git/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Freyskeyd/git/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Freyskeyd/git/git/refs{/sha}","trees_url":"https://api.github.com/repos/Freyskeyd/git/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Freyskeyd/git/statuses/{sha}","languages_url":"https://api.github.com/repos/Freyskeyd/git/languages","stargazers_url":"https://api.github.com/repos/Freyskeyd/git/stargazers","contributors_url":"https://api.github.com/repos/Freyskeyd/git/contributors","subscribers_url":"https://api.github.com/repos/Freyskeyd/git/subscribers","subscription_url":"https://api.github.com/repos/Freyskeyd/git/subscription","commits_url":"https://api.github.com/repos/Freyskeyd/git/commits{/sha}","git_commits_url":"https://api.github.com/repos/Freyskeyd/git/git/commits{/sha}","comments_url":"https://api.github.com/repos/Freyskeyd/git/comments{/number}","issue_comment_url":"https://api.github.com/repos/Freyskeyd/git/issues/comments{/number}","contents_url":"https://api.github.com/repos/Freyskeyd/git/contents/{+path}","compare_url":"https://api.github.com/repos/Freyskeyd/git/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Freyskeyd/git/merges","archive_url":"https://api.github.com/repos/Freyskeyd/git/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Freyskeyd/git/downloads","issues_url":"https://api.github.com/repos/Freyskeyd/git/issues{/number}","pulls_url":"https://api.github.com/repos/Freyskeyd/git/pulls{/number}","milestones_url":"https://api.github.com/repos/Freyskeyd/git/milestones{/number}","notifications_url":"https://api.github.com/repos/Freyskeyd/git/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Freyskeyd/git/labels{/name}","releases_url":"https://api.github.com/repos/Freyskeyd/git/releases{/id}","created_at":"2015-03-14T12:15:30Z","updated_at":"2014-09-29T05:47:00Z","pushed_at":"2015-04-02T07:52:46Z","git_url":"git://github.com/Freyskeyd/git.git","ssh_url":"git@github.com:Freyskeyd/git.git","clone_url":"https://github.com/Freyskeyd/git.git","svn_url":"https://github.com/Freyskeyd/git","homepage":null,"size":129,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iadvize:master","ref":"master","sha":"5d0ff461bf26ac6aec75f164c9c635fd3fc0b40c","user":{"login":"iadvize","id":216094,"avatar_url":"https://avatars.githubusercontent.com/u/216094?v=3","gravatar_id":"","url":"https://api.github.com/users/iadvize","html_url":"https://github.com/iadvize","followers_url":"https://api.github.com/users/iadvize/followers","following_url":"https://api.github.com/users/iadvize/following{/other_user}","gists_url":"https://api.github.com/users/iadvize/gists{/gist_id}","starred_url":"https://api.github.com/users/iadvize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iadvize/subscriptions","organizations_url":"https://api.github.com/users/iadvize/orgs","repos_url":"https://api.github.com/users/iadvize/repos","events_url":"https://api.github.com/users/iadvize/events{/privacy}","received_events_url":"https://api.github.com/users/iadvize/received_events","type":"Organization","site_admin":false},"repo":{"id":16006203,"name":"git","full_name":"iadvize/git","owner":{"login":"iadvize","id":216094,"avatar_url":"https://avatars.githubusercontent.com/u/216094?v=3","gravatar_id":"","url":"https://api.github.com/users/iadvize","html_url":"https://github.com/iadvize","followers_url":"https://api.github.com/users/iadvize/followers","following_url":"https://api.github.com/users/iadvize/following{/other_user}","gists_url":"https://api.github.com/users/iadvize/gists{/gist_id}","starred_url":"https://api.github.com/users/iadvize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iadvize/subscriptions","organizations_url":"https://api.github.com/users/iadvize/orgs","repos_url":"https://api.github.com/users/iadvize/repos","events_url":"https://api.github.com/users/iadvize/events{/privacy}","received_events_url":"https://api.github.com/users/iadvize/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iadvize/git","description":"iAdvize Git Convention","fork":false,"url":"https://api.github.com/repos/iadvize/git","forks_url":"https://api.github.com/repos/iadvize/git/forks","keys_url":"https://api.github.com/repos/iadvize/git/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iadvize/git/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iadvize/git/teams","hooks_url":"https://api.github.com/repos/iadvize/git/hooks","issue_events_url":"https://api.github.com/repos/iadvize/git/issues/events{/number}","events_url":"https://api.github.com/repos/iadvize/git/events","assignees_url":"https://api.github.com/repos/iadvize/git/assignees{/user}","branches_url":"https://api.github.com/repos/iadvize/git/branches{/branch}","tags_url":"https://api.github.com/repos/iadvize/git/tags","blobs_url":"https://api.github.com/repos/iadvize/git/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iadvize/git/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iadvize/git/git/refs{/sha}","trees_url":"https://api.github.com/repos/iadvize/git/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iadvize/git/statuses/{sha}","languages_url":"https://api.github.com/repos/iadvize/git/languages","stargazers_url":"https://api.github.com/repos/iadvize/git/stargazers","contributors_url":"https://api.github.com/repos/iadvize/git/contributors","subscribers_url":"https://api.github.com/repos/iadvize/git/subscribers","subscription_url":"https://api.github.com/repos/iadvize/git/subscription","commits_url":"https://api.github.com/repos/iadvize/git/commits{/sha}","git_commits_url":"https://api.github.com/repos/iadvize/git/git/commits{/sha}","comments_url":"https://api.github.com/repos/iadvize/git/comments{/number}","issue_comment_url":"https://api.github.com/repos/iadvize/git/issues/comments{/number}","contents_url":"https://api.github.com/repos/iadvize/git/contents/{+path}","compare_url":"https://api.github.com/repos/iadvize/git/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iadvize/git/merges","archive_url":"https://api.github.com/repos/iadvize/git/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iadvize/git/downloads","issues_url":"https://api.github.com/repos/iadvize/git/issues{/number}","pulls_url":"https://api.github.com/repos/iadvize/git/pulls{/number}","milestones_url":"https://api.github.com/repos/iadvize/git/milestones{/number}","notifications_url":"https://api.github.com/repos/iadvize/git/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iadvize/git/labels{/name}","releases_url":"https://api.github.com/repos/iadvize/git/releases{/id}","created_at":"2014-01-17T17:15:19Z","updated_at":"2014-09-29T05:47:00Z","pushed_at":"2015-04-02T07:52:47Z","git_url":"git://github.com/iadvize/git.git","ssh_url":"git@github.com:iadvize/git.git","clone_url":"https://github.com/iadvize/git.git","svn_url":"https://github.com/iadvize/git","homepage":null,"size":231,"stargazers_count":2,"watchers_count":2,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iadvize/git/pulls/2"},"html":{"href":"https://github.com/iadvize/git/pull/2"},"issue":{"href":"https://api.github.com/repos/iadvize/git/issues/2"},"comments":{"href":"https://api.github.com/repos/iadvize/git/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/iadvize/git/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/iadvize/git/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iadvize/git/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/iadvize/git/statuses/bd7f80974e4889e43fa9c6e1c1cdc871b4a60afa"}}}}