{"action":"created","issue":{"url":"https://api.github.com/repos/codeforamerica/somerville-teacher-tool/issues/286","labels_url":"https://api.github.com/repos/codeforamerica/somerville-teacher-tool/issues/286/labels{/name}","comments_url":"https://api.github.com/repos/codeforamerica/somerville-teacher-tool/issues/286/comments","events_url":"https://api.github.com/repos/codeforamerica/somerville-teacher-tool/issues/286/events","html_url":"https://github.com/codeforamerica/somerville-teacher-tool/pull/286","id":106424591,"number":286,"title":"access returns MissingStudentAssessment as nil object instead of MissingStudentAssessmentCollection","user":{"login":"r11runner","id":8597439,"avatar_url":"https://avatars.githubusercontent.com/u/8597439?v=3","gravatar_id":"","url":"https://api.github.com/users/r11runner","html_url":"https://github.com/r11runner","followers_url":"https://api.github.com/users/r11runner/followers","following_url":"https://api.github.com/users/r11runner/following{/other_user}","gists_url":"https://api.github.com/users/r11runner/gists{/gist_id}","starred_url":"https://api.github.com/users/r11runner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r11runner/subscriptions","organizations_url":"https://api.github.com/users/r11runner/orgs","repos_url":"https://api.github.com/users/r11runner/repos","events_url":"https://api.github.com/users/r11runner/events{/privacy}","received_events_url":"https://api.github.com/users/r11runner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-14T20:47:33Z","updated_at":"2015-09-15T06:02:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/codeforamerica/somerville-teacher-tool/pulls/286","html_url":"https://github.com/codeforamerica/somerville-teacher-tool/pull/286","diff_url":"https://github.com/codeforamerica/somerville-teacher-tool/pull/286.diff","patch_url":"https://github.com/codeforamerica/somerville-teacher-tool/pull/286.patch"},"body":"Hi,\r\n\r\nwhile writing tests for the new risk level calculation, I noticed a small inconsistency - which made writing tests for access results a little bit more difficult.\r\n\r\nIn the model Student:\r\nthe method access returns a single access assessment,\r\nbut it can also return a MissingStudentAssessmentCollection, if some data is missing.\r\n\r\nThe other methods which return only a single assessment, always return MissingStudentAssessment as \"nil object\".\r\n\r\nDoes this have a specific reason?\r\nIf not, please review this pull request :-)\r\n\r\nCheers,\r\nr11runner"},"comment":{"url":"https://api.github.com/repos/codeforamerica/somerville-teacher-tool/issues/comments/140289460","html_url":"https://github.com/codeforamerica/somerville-teacher-tool/pull/286#issuecomment-140289460","issue_url":"https://api.github.com/repos/codeforamerica/somerville-teacher-tool/issues/286","id":140289460,"user":{"login":"r11runner","id":8597439,"avatar_url":"https://avatars.githubusercontent.com/u/8597439?v=3","gravatar_id":"","url":"https://api.github.com/users/r11runner","html_url":"https://github.com/r11runner","followers_url":"https://api.github.com/users/r11runner/followers","following_url":"https://api.github.com/users/r11runner/following{/other_user}","gists_url":"https://api.github.com/users/r11runner/gists{/gist_id}","starred_url":"https://api.github.com/users/r11runner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r11runner/subscriptions","organizations_url":"https://api.github.com/users/r11runner/orgs","repos_url":"https://api.github.com/users/r11runner/repos","events_url":"https://api.github.com/users/r11runner/events{/privacy}","received_events_url":"https://api.github.com/users/r11runner/received_events","type":"User","site_admin":false},"created_at":"2015-09-15T06:02:30Z","updated_at":"2015-09-15T06:02:30Z","body":"Student profile page:\r\nIt seems that at the moment (in the master branch), an empty access result is shown\r\n![student_profile_without_access_branch_master](https://cloud.githubusercontent.com/assets/8597439/9869061/fdd160cc-5b7f-11e5-9a3d-0bb674d831da.png)\r\n\r\nThis would not be the case after this fix:\r\n![student_profile_without_access_after_fix](https://cloud.githubusercontent.com/assets/8597439/9869071/118cffa4-5b80-11e5-82f6-2114d5407974.png)\r\n"}}