{"action":"created","issue":{"url":"https://api.github.com/repos/influxdb/influxdb/issues/2443","labels_url":"https://api.github.com/repos/influxdb/influxdb/issues/2443/labels{/name}","comments_url":"https://api.github.com/repos/influxdb/influxdb/issues/2443/comments","events_url":"https://api.github.com/repos/influxdb/influxdb/issues/2443/events","html_url":"https://github.com/influxdb/influxdb/pull/2443","id":71434828,"number":2443,"title":"Update collectd plugin to write values under the field \"value\"","user":{"login":"josh-padnick","id":4295964,"avatar_url":"https://avatars.githubusercontent.com/u/4295964?v=3","gravatar_id":"","url":"https://api.github.com/users/josh-padnick","html_url":"https://github.com/josh-padnick","followers_url":"https://api.github.com/users/josh-padnick/followers","following_url":"https://api.github.com/users/josh-padnick/following{/other_user}","gists_url":"https://api.github.com/users/josh-padnick/gists{/gist_id}","starred_url":"https://api.github.com/users/josh-padnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh-padnick/subscriptions","organizations_url":"https://api.github.com/users/josh-padnick/orgs","repos_url":"https://api.github.com/users/josh-padnick/repos","events_url":"https://api.github.com/users/josh-padnick/events{/privacy}","received_events_url":"https://api.github.com/users/josh-padnick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-04-28T00:09:06Z","updated_at":"2015-04-28T19:24:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/influxdb/influxdb/pulls/2443","html_url":"https://github.com/influxdb/influxdb/pull/2443","diff_url":"https://github.com/influxdb/influxdb/pull/2443.diff","patch_url":"https://github.com/influxdb/influxdb/pull/2443.patch"},"body":"This is a fix for #2412.  I'm a golang newb, so I'll describe my testing procedure to make sure it's sufficient.\r\n\r\n1. Forked repo\r\n2. Used `go get x` to install each dependency\r\n3. Ran `go test` and received `PASS`\r\n4. Made fix\r\n5. Ran `go test` and received `PASS`\r\n\r\nSimple change, but this was holding us up.  Thanks."},"comment":{"url":"https://api.github.com/repos/influxdb/influxdb/issues/comments/97176179","html_url":"https://github.com/influxdb/influxdb/pull/2443#issuecomment-97176179","issue_url":"https://api.github.com/repos/influxdb/influxdb/issues/2443","id":97176179,"user":{"login":"josh-padnick","id":4295964,"avatar_url":"https://avatars.githubusercontent.com/u/4295964?v=3","gravatar_id":"","url":"https://api.github.com/users/josh-padnick","html_url":"https://github.com/josh-padnick","followers_url":"https://api.github.com/users/josh-padnick/followers","following_url":"https://api.github.com/users/josh-padnick/following{/other_user}","gists_url":"https://api.github.com/users/josh-padnick/gists{/gist_id}","starred_url":"https://api.github.com/users/josh-padnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh-padnick/subscriptions","organizations_url":"https://api.github.com/users/josh-padnick/orgs","repos_url":"https://api.github.com/users/josh-padnick/repos","events_url":"https://api.github.com/users/josh-padnick/events{/privacy}","received_events_url":"https://api.github.com/users/josh-padnick/received_events","type":"User","site_admin":false},"created_at":"2015-04-28T19:24:54Z","updated_at":"2015-04-28T19:24:54Z","body":"@corylanou I've updated the test to include a case that now fails.  See latest commit.  This isn't yet ready for merging, though, because this test is failing now.\r\n\r\nRegarding what's motivating this change in the first place, for our team, it came down to what Grafana is expecting, which I assume will be the overwhelmingly popular choice for dashboard.  Grafana assumes that every metric name's value is stored in a field called `value`, rather than a field like `disk_read`.  This means that you have to manually edit the query to get it working.\r\n\r\nCertainly, Grafana could change its behavior, but since a measured named `disk_read` that has a field named `disk_read` seems redundant, I'm inclined to change the collectd plugin, not Grafana.\r\n\r\nI'm not sure how to proceed from here, and am happy to pass this PR on to @kimor79 or someone else w/ more experience w/ the InfluxDB code base."}}