{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/serenity/pulls/comments/32521868","id":32521868,"diff_hunk":"@@ -18,17 +18,30 @@ SET(CMAKE_CXX_FLAGS \"${CMAKE_CXX_FLAGS} -std=c++11\")\n # Protobuf stuff\n find_package(Protobuf REQUIRED)\n set(PROTOBUF_IMPORT_DIRS ${MESOS_INSTALLATION_DIR}/include/)\n-file(GLOB ProtoFiles \"${CMAKE_CURRENT_SOURCE_DIR}/messages/serenity.proto\")\n+file(GLOB ProtoFiles \"messages/serenity.proto\")\n+file(GLOB TestProtoFiles \"tests/helpers/sources/json_source.proto\")\n PROTOBUF_GENERATE_CPP(ProtoSources ProtoHeaders ${ProtoFiles})\n add_library(messages STATIC ${ProtoSources} ${ProtoHeaders})\n \n+PROTOBUF_GENERATE_CPP(TestProtoSources TestProtoHeaders ${TestProtoFiles})\n+add_library(messages-test STATIC ${TestProtoSources} ${TestProtoHeaders})\n+\n+\n+# pbjson + rapidjson\n+add_library(pbjson lib/pbjson/src/pbjson.cpp)\n+target_link_libraries(pbjson protobuf)\n include_directories(","path":"CMakeLists.txt","position":17,"original_position":17,"commit_id":"0ede9c5a6615ad46dfa17a3cf74ce94ec49943bd","original_commit_id":"0ede9c5a6615ad46dfa17a3cf74ce94ec49943bd","user":{"login":"Bplotka","id":6950331,"avatar_url":"https://avatars.githubusercontent.com/u/6950331?v=3","gravatar_id":"","url":"https://api.github.com/users/Bplotka","html_url":"https://github.com/Bplotka","followers_url":"https://api.github.com/users/Bplotka/followers","following_url":"https://api.github.com/users/Bplotka/following{/other_user}","gists_url":"https://api.github.com/users/Bplotka/gists{/gist_id}","starred_url":"https://api.github.com/users/Bplotka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bplotka/subscriptions","organizations_url":"https://api.github.com/users/Bplotka/orgs","repos_url":"https://api.github.com/users/Bplotka/repos","events_url":"https://api.github.com/users/Bplotka/events{/privacy}","received_events_url":"https://api.github.com/users/Bplotka/received_events","type":"User","site_admin":false},"body":"new line above","created_at":"2015-06-16T13:48:35Z","updated_at":"2015-06-16T13:48:35Z","html_url":"https://github.com/mesosphere/serenity/pull/19#discussion_r32521868","pull_request_url":"https://api.github.com/repos/mesosphere/serenity/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/serenity/pulls/comments/32521868"},"html":{"href":"https://github.com/mesosphere/serenity/pull/19#discussion_r32521868"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/serenity/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/serenity/pulls/19","id":37709684,"html_url":"https://github.com/mesosphere/serenity/pull/19","diff_url":"https://github.com/mesosphere/serenity/pull/19.diff","patch_url":"https://github.com/mesosphere/serenity/pull/19.patch","issue_url":"https://api.github.com/repos/mesosphere/serenity/issues/19","number":19,"state":"open","locked":false,"title":"Integration test harness","user":{"login":"skonefal","id":10141081,"avatar_url":"https://avatars.githubusercontent.com/u/10141081?v=3","gravatar_id":"","url":"https://api.github.com/users/skonefal","html_url":"https://github.com/skonefal","followers_url":"https://api.github.com/users/skonefal/followers","following_url":"https://api.github.com/users/skonefal/following{/other_user}","gists_url":"https://api.github.com/users/skonefal/gists{/gist_id}","starred_url":"https://api.github.com/users/skonefal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skonefal/subscriptions","organizations_url":"https://api.github.com/users/skonefal/orgs","repos_url":"https://api.github.com/users/skonefal/repos","events_url":"https://api.github.com/users/skonefal/events{/privacy}","received_events_url":"https://api.github.com/users/skonefal/received_events","type":"User","site_admin":false},"body":"I show this as a preview, I would like to squash it later.\r\nFeel free to comment, or if you need it - pull this request to master","created_at":"2015-06-15T16:25:08Z","updated_at":"2015-06-16T13:48:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfb164f54910e371ec10b1b4f427a2411475c718","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/serenity/pulls/19/commits","review_comments_url":"https://api.github.com/repos/mesosphere/serenity/pulls/19/comments","review_comment_url":"https://api.github.com/repos/mesosphere/serenity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/serenity/issues/19/comments","statuses_url":"https://api.github.com/repos/mesosphere/serenity/statuses/0ede9c5a6615ad46dfa17a3cf74ce94ec49943bd","head":{"label":"skonefal:integration_test_harness","ref":"integration_test_harness","sha":"0ede9c5a6615ad46dfa17a3cf74ce94ec49943bd","user":{"login":"skonefal","id":10141081,"avatar_url":"https://avatars.githubusercontent.com/u/10141081?v=3","gravatar_id":"","url":"https://api.github.com/users/skonefal","html_url":"https://github.com/skonefal","followers_url":"https://api.github.com/users/skonefal/followers","following_url":"https://api.github.com/users/skonefal/following{/other_user}","gists_url":"https://api.github.com/users/skonefal/gists{/gist_id}","starred_url":"https://api.github.com/users/skonefal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skonefal/subscriptions","organizations_url":"https://api.github.com/users/skonefal/orgs","repos_url":"https://api.github.com/users/skonefal/repos","events_url":"https://api.github.com/users/skonefal/events{/privacy}","received_events_url":"https://api.github.com/users/skonefal/received_events","type":"User","site_admin":false},"repo":{"id":35975826,"name":"serenity","full_name":"skonefal/serenity","owner":{"login":"skonefal","id":10141081,"avatar_url":"https://avatars.githubusercontent.com/u/10141081?v=3","gravatar_id":"","url":"https://api.github.com/users/skonefal","html_url":"https://github.com/skonefal","followers_url":"https://api.github.com/users/skonefal/followers","following_url":"https://api.github.com/users/skonefal/following{/other_user}","gists_url":"https://api.github.com/users/skonefal/gists{/gist_id}","starred_url":"https://api.github.com/users/skonefal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skonefal/subscriptions","organizations_url":"https://api.github.com/users/skonefal/orgs","repos_url":"https://api.github.com/users/skonefal/repos","events_url":"https://api.github.com/users/skonefal/events{/privacy}","received_events_url":"https://api.github.com/users/skonefal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skonefal/serenity","description":"Repo for Intel:Mesosphere Oversubscription Technologies","fork":true,"url":"https://api.github.com/repos/skonefal/serenity","forks_url":"https://api.github.com/repos/skonefal/serenity/forks","keys_url":"https://api.github.com/repos/skonefal/serenity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skonefal/serenity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skonefal/serenity/teams","hooks_url":"https://api.github.com/repos/skonefal/serenity/hooks","issue_events_url":"https://api.github.com/repos/skonefal/serenity/issues/events{/number}","events_url":"https://api.github.com/repos/skonefal/serenity/events","assignees_url":"https://api.github.com/repos/skonefal/serenity/assignees{/user}","branches_url":"https://api.github.com/repos/skonefal/serenity/branches{/branch}","tags_url":"https://api.github.com/repos/skonefal/serenity/tags","blobs_url":"https://api.github.com/repos/skonefal/serenity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skonefal/serenity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skonefal/serenity/git/refs{/sha}","trees_url":"https://api.github.com/repos/skonefal/serenity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skonefal/serenity/statuses/{sha}","languages_url":"https://api.github.com/repos/skonefal/serenity/languages","stargazers_url":"https://api.github.com/repos/skonefal/serenity/stargazers","contributors_url":"https://api.github.com/repos/skonefal/serenity/contributors","subscribers_url":"https://api.github.com/repos/skonefal/serenity/subscribers","subscription_url":"https://api.github.com/repos/skonefal/serenity/subscription","commits_url":"https://api.github.com/repos/skonefal/serenity/commits{/sha}","git_commits_url":"https://api.github.com/repos/skonefal/serenity/git/commits{/sha}","comments_url":"https://api.github.com/repos/skonefal/serenity/comments{/number}","issue_comment_url":"https://api.github.com/repos/skonefal/serenity/issues/comments{/number}","contents_url":"https://api.github.com/repos/skonefal/serenity/contents/{+path}","compare_url":"https://api.github.com/repos/skonefal/serenity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skonefal/serenity/merges","archive_url":"https://api.github.com/repos/skonefal/serenity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skonefal/serenity/downloads","issues_url":"https://api.github.com/repos/skonefal/serenity/issues{/number}","pulls_url":"https://api.github.com/repos/skonefal/serenity/pulls{/number}","milestones_url":"https://api.github.com/repos/skonefal/serenity/milestones{/number}","notifications_url":"https://api.github.com/repos/skonefal/serenity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skonefal/serenity/labels{/name}","releases_url":"https://api.github.com/repos/skonefal/serenity/releases{/id}","created_at":"2015-05-20T21:42:25Z","updated_at":"2015-05-20T21:42:26Z","pushed_at":"2015-06-16T13:32:56Z","git_url":"git://github.com/skonefal/serenity.git","ssh_url":"git@github.com:skonefal/serenity.git","clone_url":"https://github.com/skonefal/serenity.git","svn_url":"https://github.com/skonefal/serenity","homepage":null,"size":2314,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"a3ca595e6c8127e6f3729babddb61400471472a1","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":35688047,"name":"serenity","full_name":"mesosphere/serenity","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/serenity","description":"Repo for Intel:Mesosphere Oversubscription Technologies","fork":false,"url":"https://api.github.com/repos/mesosphere/serenity","forks_url":"https://api.github.com/repos/mesosphere/serenity/forks","keys_url":"https://api.github.com/repos/mesosphere/serenity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/serenity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/serenity/teams","hooks_url":"https://api.github.com/repos/mesosphere/serenity/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/serenity/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/serenity/events","assignees_url":"https://api.github.com/repos/mesosphere/serenity/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/serenity/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/serenity/tags","blobs_url":"https://api.github.com/repos/mesosphere/serenity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/serenity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/serenity/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/serenity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/serenity/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/serenity/languages","stargazers_url":"https://api.github.com/repos/mesosphere/serenity/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/serenity/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/serenity/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/serenity/subscription","commits_url":"https://api.github.com/repos/mesosphere/serenity/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/serenity/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/serenity/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/serenity/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/serenity/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/serenity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/serenity/merges","archive_url":"https://api.github.com/repos/mesosphere/serenity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/serenity/downloads","issues_url":"https://api.github.com/repos/mesosphere/serenity/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/serenity/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/serenity/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/serenity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/serenity/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/serenity/releases{/id}","created_at":"2015-05-15T17:46:54Z","updated_at":"2015-06-15T09:54:06Z","pushed_at":"2015-06-16T13:32:56Z","git_url":"git://github.com/mesosphere/serenity.git","ssh_url":"git@github.com:mesosphere/serenity.git","clone_url":"https://github.com/mesosphere/serenity.git","svn_url":"https://github.com/mesosphere/serenity","homepage":null,"size":2583,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/serenity/pulls/19"},"html":{"href":"https://github.com/mesosphere/serenity/pull/19"},"issue":{"href":"https://api.github.com/repos/mesosphere/serenity/issues/19"},"comments":{"href":"https://api.github.com/repos/mesosphere/serenity/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/serenity/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/serenity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/serenity/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/serenity/statuses/0ede9c5a6615ad46dfa17a3cf74ce94ec49943bd"}}}}