{"action":"created","issue":{"url":"https://api.github.com/repos/vokal/VOKMockUrlProtocol/issues/27","labels_url":"https://api.github.com/repos/vokal/VOKMockUrlProtocol/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/vokal/VOKMockUrlProtocol/issues/27/comments","events_url":"https://api.github.com/repos/vokal/VOKMockUrlProtocol/issues/27/events","html_url":"https://github.com/vokal/VOKMockUrlProtocol/pull/27","id":95056627,"number":27,"title":"Modifies VOKMockUrlProtocol to allow for custom directory names","user":{"login":"caleb-lee","id":11948335,"avatar_url":"https://avatars.githubusercontent.com/u/11948335?v=3","gravatar_id":"","url":"https://api.github.com/users/caleb-lee","html_url":"https://github.com/caleb-lee","followers_url":"https://api.github.com/users/caleb-lee/followers","following_url":"https://api.github.com/users/caleb-lee/following{/other_user}","gists_url":"https://api.github.com/users/caleb-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/caleb-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caleb-lee/subscriptions","organizations_url":"https://api.github.com/users/caleb-lee/orgs","repos_url":"https://api.github.com/users/caleb-lee/repos","events_url":"https://api.github.com/users/caleb-lee/events{/privacy}","received_events_url":"https://api.github.com/users/caleb-lee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-07-14T22:24:50Z","updated_at":"2015-07-16T17:28:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vokal/VOKMockUrlProtocol/pulls/27","html_url":"https://github.com/vokal/VOKMockUrlProtocol/pull/27","diff_url":"https://github.com/vokal/VOKMockUrlProtocol/pull/27.diff","patch_url":"https://github.com/vokal/VOKMockUrlProtocol/pull/27.patch"},"body":"This PR modifies VOKMockUrlProtocol to allow for custom directory names for mock data.\r\n\r\nIt sets the default directory name to the forced name from before. You can easily change the directory name by subclassing VOKMockUrlProtocol and overriding -initWithRequest:cachedResponse:client and setting the directory name in that method. This offers the advantage of being able to change mocked server responses based on conditions.\r\n\r\n@vokal/ios-developers code review please :)"},"comment":{"url":"https://api.github.com/repos/vokal/VOKMockUrlProtocol/issues/comments/122029149","html_url":"https://github.com/vokal/VOKMockUrlProtocol/pull/27#issuecomment-122029149","issue_url":"https://api.github.com/repos/vokal/VOKMockUrlProtocol/issues/27","id":122029149,"user":{"login":"chillpop","id":49619,"avatar_url":"https://avatars.githubusercontent.com/u/49619?v=3","gravatar_id":"","url":"https://api.github.com/users/chillpop","html_url":"https://github.com/chillpop","followers_url":"https://api.github.com/users/chillpop/followers","following_url":"https://api.github.com/users/chillpop/following{/other_user}","gists_url":"https://api.github.com/users/chillpop/gists{/gist_id}","starred_url":"https://api.github.com/users/chillpop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chillpop/subscriptions","organizations_url":"https://api.github.com/users/chillpop/orgs","repos_url":"https://api.github.com/users/chillpop/repos","events_url":"https://api.github.com/users/chillpop/events{/privacy}","received_events_url":"https://api.github.com/users/chillpop/received_events","type":"User","site_admin":false},"created_at":"2015-07-16T17:28:46Z","updated_at":"2015-07-16T17:28:46Z","body":"The way I'm envisioning using this feature is to have a base of mock data that can get overridden for specific test suites/tests/requests.  So you'd be changing the mock data directory possibly for each test or each request.  In that usage pattern, having an array doesn't make sense.\r\n\r\nAre you thinking of a different usage pattern?"}}