{"action":"opened","number":737,"pull_request":{"url":"https://api.github.com/repos/eddiemachado/bones/pulls/737","id":28440091,"html_url":"https://github.com/eddiemachado/bones/pull/737","diff_url":"https://github.com/eddiemachado/bones/pull/737.diff","patch_url":"https://github.com/eddiemachado/bones/pull/737.patch","issue_url":"https://api.github.com/repos/eddiemachado/bones/issues/737","number":737,"state":"open","locked":false,"title":"Fix whitespace and indentation","user":{"login":"justincwatt","id":1240939,"avatar_url":"https://avatars.githubusercontent.com/u/1240939?v=3","gravatar_id":"","url":"https://api.github.com/users/justincwatt","html_url":"https://github.com/justincwatt","followers_url":"https://api.github.com/users/justincwatt/followers","following_url":"https://api.github.com/users/justincwatt/following{/other_user}","gists_url":"https://api.github.com/users/justincwatt/gists{/gist_id}","starred_url":"https://api.github.com/users/justincwatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justincwatt/subscriptions","organizations_url":"https://api.github.com/users/justincwatt/orgs","repos_url":"https://api.github.com/users/justincwatt/repos","events_url":"https://api.github.com/users/justincwatt/events{/privacy}","received_events_url":"https://api.github.com/users/justincwatt/received_events","type":"User","site_admin":false},"body":"I noticed a few indentation bugs in the Bones template files, so I decided to fork the repo and clean them up. A few hours and several passes later, I think I've got things into much better and more consistent shape. Unfortunately these kinds of whitespace changes make the diff pretty gross, so it might be easier to review the individual template files, post-modification.\r\n\r\nThis is a pretty comprehensive list of the whitespace/indentation changes I made:\r\n\r\n* Convert accidental spaces in indentation to tabs\r\n* Fix indentation mistakes, misalignment\r\n* Maintain HTML indentation level throughout templates (ie: avoid indenting html content inside php if-statements)\r\n* Add blank lines between lines for readability (remove double/triple blank lines)\r\n* Align php associative arrays around `=>`\r\n* Use WordPress-style spacing before/after parentheses\r\n* Eliminate whitespace between `<h1>`/`<p>` tags and `<?php` tags\r\n* Remove redundant php comments, e.g. `</article> <?php // end article ?>`\r\n* Fixed occasional typos, grammatical errors in comments\r\n* Use PHP's \"alternative control structure format\", e.g. `if (true) : ... endif;` rather than curly brace-style\r\n\r\nAlso, after making those changes and running the resulting output through the HTML5 validator, I discovered a copy/paste bug where a span tag used in the byline had an erroneous attribute `itemptype` which should have been `itemtype` per https://html.spec.whatwg.org/multipage/dom.html#global-attributes\r\n\r\nFinally I flipped on support for HTML5 in galleries and captions.\r\n\r\nLet me know what you think.","created_at":"2015-02-02T00:37:30Z","updated_at":"2015-02-02T00:37:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eddiemachado/bones/pulls/737/commits","review_comments_url":"https://api.github.com/repos/eddiemachado/bones/pulls/737/comments","review_comment_url":"https://api.github.com/repos/eddiemachado/bones/pulls/comments/{number}","comments_url":"https://api.github.com/repos/eddiemachado/bones/issues/737/comments","statuses_url":"https://api.github.com/repos/eddiemachado/bones/statuses/f3400bc254f56820e9ce0afdf4523a5284a48d02","head":{"label":"justincwatt:fix-whitespace-and-indentation","ref":"fix-whitespace-and-indentation","sha":"f3400bc254f56820e9ce0afdf4523a5284a48d02","user":{"login":"justincwatt","id":1240939,"avatar_url":"https://avatars.githubusercontent.com/u/1240939?v=3","gravatar_id":"","url":"https://api.github.com/users/justincwatt","html_url":"https://github.com/justincwatt","followers_url":"https://api.github.com/users/justincwatt/followers","following_url":"https://api.github.com/users/justincwatt/following{/other_user}","gists_url":"https://api.github.com/users/justincwatt/gists{/gist_id}","starred_url":"https://api.github.com/users/justincwatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justincwatt/subscriptions","organizations_url":"https://api.github.com/users/justincwatt/orgs","repos_url":"https://api.github.com/users/justincwatt/repos","events_url":"https://api.github.com/users/justincwatt/events{/privacy}","received_events_url":"https://api.github.com/users/justincwatt/received_events","type":"User","site_admin":false},"repo":{"id":30159400,"name":"bones","full_name":"justincwatt/bones","owner":{"login":"justincwatt","id":1240939,"avatar_url":"https://avatars.githubusercontent.com/u/1240939?v=3","gravatar_id":"","url":"https://api.github.com/users/justincwatt","html_url":"https://github.com/justincwatt","followers_url":"https://api.github.com/users/justincwatt/followers","following_url":"https://api.github.com/users/justincwatt/following{/other_user}","gists_url":"https://api.github.com/users/justincwatt/gists{/gist_id}","starred_url":"https://api.github.com/users/justincwatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justincwatt/subscriptions","organizations_url":"https://api.github.com/users/justincwatt/orgs","repos_url":"https://api.github.com/users/justincwatt/repos","events_url":"https://api.github.com/users/justincwatt/events{/privacy}","received_events_url":"https://api.github.com/users/justincwatt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justincwatt/bones","description":"A Mobile-First, Responsive WordPress starter theme based off 320 and Up & HTML5 Boilerplate.","fork":true,"url":"https://api.github.com/repos/justincwatt/bones","forks_url":"https://api.github.com/repos/justincwatt/bones/forks","keys_url":"https://api.github.com/repos/justincwatt/bones/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justincwatt/bones/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justincwatt/bones/teams","hooks_url":"https://api.github.com/repos/justincwatt/bones/hooks","issue_events_url":"https://api.github.com/repos/justincwatt/bones/issues/events{/number}","events_url":"https://api.github.com/repos/justincwatt/bones/events","assignees_url":"https://api.github.com/repos/justincwatt/bones/assignees{/user}","branches_url":"https://api.github.com/repos/justincwatt/bones/branches{/branch}","tags_url":"https://api.github.com/repos/justincwatt/bones/tags","blobs_url":"https://api.github.com/repos/justincwatt/bones/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justincwatt/bones/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justincwatt/bones/git/refs{/sha}","trees_url":"https://api.github.com/repos/justincwatt/bones/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justincwatt/bones/statuses/{sha}","languages_url":"https://api.github.com/repos/justincwatt/bones/languages","stargazers_url":"https://api.github.com/repos/justincwatt/bones/stargazers","contributors_url":"https://api.github.com/repos/justincwatt/bones/contributors","subscribers_url":"https://api.github.com/repos/justincwatt/bones/subscribers","subscription_url":"https://api.github.com/repos/justincwatt/bones/subscription","commits_url":"https://api.github.com/repos/justincwatt/bones/commits{/sha}","git_commits_url":"https://api.github.com/repos/justincwatt/bones/git/commits{/sha}","comments_url":"https://api.github.com/repos/justincwatt/bones/comments{/number}","issue_comment_url":"https://api.github.com/repos/justincwatt/bones/issues/comments/{number}","contents_url":"https://api.github.com/repos/justincwatt/bones/contents/{+path}","compare_url":"https://api.github.com/repos/justincwatt/bones/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justincwatt/bones/merges","archive_url":"https://api.github.com/repos/justincwatt/bones/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justincwatt/bones/downloads","issues_url":"https://api.github.com/repos/justincwatt/bones/issues{/number}","pulls_url":"https://api.github.com/repos/justincwatt/bones/pulls{/number}","milestones_url":"https://api.github.com/repos/justincwatt/bones/milestones{/number}","notifications_url":"https://api.github.com/repos/justincwatt/bones/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justincwatt/bones/labels{/name}","releases_url":"https://api.github.com/repos/justincwatt/bones/releases{/id}","created_at":"2015-02-01T20:52:33Z","updated_at":"2015-02-01T20:52:34Z","pushed_at":"2015-02-02T00:15:41Z","git_url":"git://github.com/justincwatt/bones.git","ssh_url":"git@github.com:justincwatt/bones.git","clone_url":"https://github.com/justincwatt/bones.git","svn_url":"https://github.com/justincwatt/bones","homepage":"http://themble.com/bones/","size":5583,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eddiemachado:master","ref":"master","sha":"cfbfb62e91c4d97a26538ee90bf4ca5ef47da300","user":{"login":"eddiemachado","id":419873,"avatar_url":"https://avatars.githubusercontent.com/u/419873?v=3","gravatar_id":"","url":"https://api.github.com/users/eddiemachado","html_url":"https://github.com/eddiemachado","followers_url":"https://api.github.com/users/eddiemachado/followers","following_url":"https://api.github.com/users/eddiemachado/following{/other_user}","gists_url":"https://api.github.com/users/eddiemachado/gists{/gist_id}","starred_url":"https://api.github.com/users/eddiemachado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddiemachado/subscriptions","organizations_url":"https://api.github.com/users/eddiemachado/orgs","repos_url":"https://api.github.com/users/eddiemachado/repos","events_url":"https://api.github.com/users/eddiemachado/events{/privacy}","received_events_url":"https://api.github.com/users/eddiemachado/received_events","type":"User","site_admin":false},"repo":{"id":1191176,"name":"bones","full_name":"eddiemachado/bones","owner":{"login":"eddiemachado","id":419873,"avatar_url":"https://avatars.githubusercontent.com/u/419873?v=3","gravatar_id":"","url":"https://api.github.com/users/eddiemachado","html_url":"https://github.com/eddiemachado","followers_url":"https://api.github.com/users/eddiemachado/followers","following_url":"https://api.github.com/users/eddiemachado/following{/other_user}","gists_url":"https://api.github.com/users/eddiemachado/gists{/gist_id}","starred_url":"https://api.github.com/users/eddiemachado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddiemachado/subscriptions","organizations_url":"https://api.github.com/users/eddiemachado/orgs","repos_url":"https://api.github.com/users/eddiemachado/repos","events_url":"https://api.github.com/users/eddiemachado/events{/privacy}","received_events_url":"https://api.github.com/users/eddiemachado/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eddiemachado/bones","description":"A Mobile-First, Responsive WordPress starter theme based off 320 and Up & HTML5 Boilerplate.","fork":false,"url":"https://api.github.com/repos/eddiemachado/bones","forks_url":"https://api.github.com/repos/eddiemachado/bones/forks","keys_url":"https://api.github.com/repos/eddiemachado/bones/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eddiemachado/bones/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eddiemachado/bones/teams","hooks_url":"https://api.github.com/repos/eddiemachado/bones/hooks","issue_events_url":"https://api.github.com/repos/eddiemachado/bones/issues/events{/number}","events_url":"https://api.github.com/repos/eddiemachado/bones/events","assignees_url":"https://api.github.com/repos/eddiemachado/bones/assignees{/user}","branches_url":"https://api.github.com/repos/eddiemachado/bones/branches{/branch}","tags_url":"https://api.github.com/repos/eddiemachado/bones/tags","blobs_url":"https://api.github.com/repos/eddiemachado/bones/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eddiemachado/bones/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eddiemachado/bones/git/refs{/sha}","trees_url":"https://api.github.com/repos/eddiemachado/bones/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eddiemachado/bones/statuses/{sha}","languages_url":"https://api.github.com/repos/eddiemachado/bones/languages","stargazers_url":"https://api.github.com/repos/eddiemachado/bones/stargazers","contributors_url":"https://api.github.com/repos/eddiemachado/bones/contributors","subscribers_url":"https://api.github.com/repos/eddiemachado/bones/subscribers","subscription_url":"https://api.github.com/repos/eddiemachado/bones/subscription","commits_url":"https://api.github.com/repos/eddiemachado/bones/commits{/sha}","git_commits_url":"https://api.github.com/repos/eddiemachado/bones/git/commits{/sha}","comments_url":"https://api.github.com/repos/eddiemachado/bones/comments{/number}","issue_comment_url":"https://api.github.com/repos/eddiemachado/bones/issues/comments/{number}","contents_url":"https://api.github.com/repos/eddiemachado/bones/contents/{+path}","compare_url":"https://api.github.com/repos/eddiemachado/bones/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eddiemachado/bones/merges","archive_url":"https://api.github.com/repos/eddiemachado/bones/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eddiemachado/bones/downloads","issues_url":"https://api.github.com/repos/eddiemachado/bones/issues{/number}","pulls_url":"https://api.github.com/repos/eddiemachado/bones/pulls{/number}","milestones_url":"https://api.github.com/repos/eddiemachado/bones/milestones{/number}","notifications_url":"https://api.github.com/repos/eddiemachado/bones/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eddiemachado/bones/labels{/name}","releases_url":"https://api.github.com/repos/eddiemachado/bones/releases{/id}","created_at":"2010-12-22T20:34:53Z","updated_at":"2015-01-31T12:37:47Z","pushed_at":"2015-01-17T20:16:45Z","git_url":"git://github.com/eddiemachado/bones.git","ssh_url":"git@github.com:eddiemachado/bones.git","clone_url":"https://github.com/eddiemachado/bones.git","svn_url":"https://github.com/eddiemachado/bones","homepage":"http://themble.com/bones/","size":5583,"stargazers_count":2642,"watchers_count":2642,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":972,"mirror_url":null,"open_issues_count":70,"forks":972,"open_issues":70,"watchers":2642,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eddiemachado/bones/pulls/737"},"html":{"href":"https://github.com/eddiemachado/bones/pull/737"},"issue":{"href":"https://api.github.com/repos/eddiemachado/bones/issues/737"},"comments":{"href":"https://api.github.com/repos/eddiemachado/bones/issues/737/comments"},"review_comments":{"href":"https://api.github.com/repos/eddiemachado/bones/pulls/737/comments"},"review_comment":{"href":"https://api.github.com/repos/eddiemachado/bones/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/eddiemachado/bones/pulls/737/commits"},"statuses":{"href":"https://api.github.com/repos/eddiemachado/bones/statuses/f3400bc254f56820e9ce0afdf4523a5284a48d02"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":1371,"deletions":1228,"changed_files":29}}