{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/promdash/pulls/comments/30236788","id":30236788,"diff_hunk":"@@ -33,9 +33,14 @@ angular.module(\"Prometheus.directives\").directive('inlineFrame', [\"$sce\",\n       // http://khaidoan.wikidot.com/iframe-and-browser-history\n       scope.refreshFrame = function() {\n         var url = VariableInterpolator(scope.frame.url, scope.vars);\n-        var trustedURL = $sce.trustAsResourceUrl(buildFrameURL(url));\n+        var parser = buildParser(url);\n+        var trustedURL = $sce.trustAsResourceUrl(parser.stringify());\n         var frame = element.find('.frame_container');\n         frame.height(frameHeight());\n+        if (parser.error) {\n+          frame.html('<div>Error: ' + parser.error + '. Please check your frame url.</div>');","path":"app/assets/javascripts/angular/directives/frame.js.erb","position":10,"original_position":10,"commit_id":"b8c532eecad8e986e8730b158db6a1b1fb849eaf","original_commit_id":"b8c532eecad8e986e8730b158db6a1b1fb849eaf","user":{"login":"juliusv","id":538008,"avatar_url":"https://avatars.githubusercontent.com/u/538008?v=3","gravatar_id":"","url":"https://api.github.com/users/juliusv","html_url":"https://github.com/juliusv","followers_url":"https://api.github.com/users/juliusv/followers","following_url":"https://api.github.com/users/juliusv/following{/other_user}","gists_url":"https://api.github.com/users/juliusv/gists{/gist_id}","starred_url":"https://api.github.com/users/juliusv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliusv/subscriptions","organizations_url":"https://api.github.com/users/juliusv/orgs","repos_url":"https://api.github.com/users/juliusv/repos","events_url":"https://api.github.com/users/juliusv/events{/privacy}","received_events_url":"https://api.github.com/users/juliusv/received_events","type":"User","site_admin":false},"body":"s/url/URL/ :package: ","created_at":"2015-05-13T14:39:58Z","updated_at":"2015-05-13T14:39:58Z","html_url":"https://github.com/prometheus/promdash/pull/402#discussion_r30236788","pull_request_url":"https://api.github.com/repos/prometheus/promdash/pulls/402","_links":{"self":{"href":"https://api.github.com/repos/prometheus/promdash/pulls/comments/30236788"},"html":{"href":"https://github.com/prometheus/promdash/pull/402#discussion_r30236788"},"pull_request":{"href":"https://api.github.com/repos/prometheus/promdash/pulls/402"}}},"pull_request":{"url":"https://api.github.com/repos/prometheus/promdash/pulls/402","id":35331986,"html_url":"https://github.com/prometheus/promdash/pull/402","diff_url":"https://github.com/prometheus/promdash/pull/402.diff","patch_url":"https://github.com/prometheus/promdash/pull/402.patch","issue_url":"https://api.github.com/repos/prometheus/promdash/issues/402","number":402,"state":"open","locked":false,"title":"Broken frame widgets now can be modified and fixed.","user":{"login":"stuartnelson3","id":1398104,"avatar_url":"https://avatars.githubusercontent.com/u/1398104?v=3","gravatar_id":"","url":"https://api.github.com/users/stuartnelson3","html_url":"https://github.com/stuartnelson3","followers_url":"https://api.github.com/users/stuartnelson3/followers","following_url":"https://api.github.com/users/stuartnelson3/following{/other_user}","gists_url":"https://api.github.com/users/stuartnelson3/gists{/gist_id}","starred_url":"https://api.github.com/users/stuartnelson3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuartnelson3/subscriptions","organizations_url":"https://api.github.com/users/stuartnelson3/orgs","repos_url":"https://api.github.com/users/stuartnelson3/repos","events_url":"https://api.github.com/users/stuartnelson3/events{/privacy}","received_events_url":"https://api.github.com/users/stuartnelson3/received_events","type":"User","site_admin":false},"body":"Previously, broken frame widgets were totally borked and could not be\r\nremoved or modified. This allows the user to modify frame widgets if\r\nthey break because of an error parsing the frame url.\r\n\r\n@juliusv ","created_at":"2015-05-13T14:25:03Z","updated_at":"2015-05-13T14:39:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1cc6d791904ec395463284aa733239a11605d68","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/promdash/pulls/402/commits","review_comments_url":"https://api.github.com/repos/prometheus/promdash/pulls/402/comments","review_comment_url":"https://api.github.com/repos/prometheus/promdash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/promdash/issues/402/comments","statuses_url":"https://api.github.com/repos/prometheus/promdash/statuses/b8c532eecad8e986e8730b158db6a1b1fb849eaf","head":{"label":"prometheus:handle-broken-frame-widgets","ref":"handle-broken-frame-widgets","sha":"b8c532eecad8e986e8730b158db6a1b1fb849eaf","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":13788490,"name":"promdash","full_name":"prometheus/promdash","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/promdash","description":"Prometheus Dashboard Builder","fork":false,"url":"https://api.github.com/repos/prometheus/promdash","forks_url":"https://api.github.com/repos/prometheus/promdash/forks","keys_url":"https://api.github.com/repos/prometheus/promdash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/promdash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/promdash/teams","hooks_url":"https://api.github.com/repos/prometheus/promdash/hooks","issue_events_url":"https://api.github.com/repos/prometheus/promdash/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/promdash/events","assignees_url":"https://api.github.com/repos/prometheus/promdash/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/promdash/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/promdash/tags","blobs_url":"https://api.github.com/repos/prometheus/promdash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/promdash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/promdash/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/promdash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/promdash/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/promdash/languages","stargazers_url":"https://api.github.com/repos/prometheus/promdash/stargazers","contributors_url":"https://api.github.com/repos/prometheus/promdash/contributors","subscribers_url":"https://api.github.com/repos/prometheus/promdash/subscribers","subscription_url":"https://api.github.com/repos/prometheus/promdash/subscription","commits_url":"https://api.github.com/repos/prometheus/promdash/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/promdash/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/promdash/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/promdash/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/promdash/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/promdash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/promdash/merges","archive_url":"https://api.github.com/repos/prometheus/promdash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/promdash/downloads","issues_url":"https://api.github.com/repos/prometheus/promdash/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/promdash/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/promdash/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/promdash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/promdash/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/promdash/releases{/id}","created_at":"2013-10-22T23:15:38Z","updated_at":"2015-05-09T13:52:43Z","pushed_at":"2015-05-13T14:31:32Z","git_url":"git://github.com/prometheus/promdash.git","ssh_url":"git@github.com:prometheus/promdash.git","clone_url":"https://github.com/prometheus/promdash.git","svn_url":"https://github.com/prometheus/promdash","homepage":"http://prometheus.io/","size":6786,"stargazers_count":107,"watchers_count":107,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":54,"forks":22,"open_issues":54,"watchers":107,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"3f016e44a5fd1260be18dd8d70f80a393b266f74","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":13788490,"name":"promdash","full_name":"prometheus/promdash","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/promdash","description":"Prometheus Dashboard Builder","fork":false,"url":"https://api.github.com/repos/prometheus/promdash","forks_url":"https://api.github.com/repos/prometheus/promdash/forks","keys_url":"https://api.github.com/repos/prometheus/promdash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/promdash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/promdash/teams","hooks_url":"https://api.github.com/repos/prometheus/promdash/hooks","issue_events_url":"https://api.github.com/repos/prometheus/promdash/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/promdash/events","assignees_url":"https://api.github.com/repos/prometheus/promdash/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/promdash/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/promdash/tags","blobs_url":"https://api.github.com/repos/prometheus/promdash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/promdash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/promdash/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/promdash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/promdash/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/promdash/languages","stargazers_url":"https://api.github.com/repos/prometheus/promdash/stargazers","contributors_url":"https://api.github.com/repos/prometheus/promdash/contributors","subscribers_url":"https://api.github.com/repos/prometheus/promdash/subscribers","subscription_url":"https://api.github.com/repos/prometheus/promdash/subscription","commits_url":"https://api.github.com/repos/prometheus/promdash/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/promdash/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/promdash/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/promdash/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/promdash/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/promdash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/promdash/merges","archive_url":"https://api.github.com/repos/prometheus/promdash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/promdash/downloads","issues_url":"https://api.github.com/repos/prometheus/promdash/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/promdash/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/promdash/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/promdash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/promdash/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/promdash/releases{/id}","created_at":"2013-10-22T23:15:38Z","updated_at":"2015-05-09T13:52:43Z","pushed_at":"2015-05-13T14:31:32Z","git_url":"git://github.com/prometheus/promdash.git","ssh_url":"git@github.com:prometheus/promdash.git","clone_url":"https://github.com/prometheus/promdash.git","svn_url":"https://github.com/prometheus/promdash","homepage":"http://prometheus.io/","size":6786,"stargazers_count":107,"watchers_count":107,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":54,"forks":22,"open_issues":54,"watchers":107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/promdash/pulls/402"},"html":{"href":"https://github.com/prometheus/promdash/pull/402"},"issue":{"href":"https://api.github.com/repos/prometheus/promdash/issues/402"},"comments":{"href":"https://api.github.com/repos/prometheus/promdash/issues/402/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/promdash/pulls/402/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/promdash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/promdash/pulls/402/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/promdash/statuses/b8c532eecad8e986e8730b158db6a1b1fb849eaf"}}}}