{"action":"created","issue":{"url":"https://api.github.com/repos/Aalk4308/Words/issues/106","labels_url":"https://api.github.com/repos/Aalk4308/Words/issues/106/labels{/name}","comments_url":"https://api.github.com/repos/Aalk4308/Words/issues/106/comments","events_url":"https://api.github.com/repos/Aalk4308/Words/issues/106/events","html_url":"https://github.com/Aalk4308/Words/pull/106","id":69438313,"number":106,"title":"Refactor Direction Class","user":{"login":"Aalk4308","id":3944243,"avatar_url":"https://avatars.githubusercontent.com/u/3944243?v=3","gravatar_id":"","url":"https://api.github.com/users/Aalk4308","html_url":"https://github.com/Aalk4308","followers_url":"https://api.github.com/users/Aalk4308/followers","following_url":"https://api.github.com/users/Aalk4308/following{/other_user}","gists_url":"https://api.github.com/users/Aalk4308/gists{/gist_id}","starred_url":"https://api.github.com/users/Aalk4308/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aalk4308/subscriptions","organizations_url":"https://api.github.com/users/Aalk4308/orgs","repos_url":"https://api.github.com/users/Aalk4308/repos","events_url":"https://api.github.com/users/Aalk4308/events{/privacy}","received_events_url":"https://api.github.com/users/Aalk4308/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-04-19T16:03:22Z","updated_at":"2015-04-20T05:46:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Aalk4308/Words/pulls/106","html_url":"https://github.com/Aalk4308/Words/pull/106","diff_url":"https://github.com/Aalk4308/Words/pull/106.diff","patch_url":"https://github.com/Aalk4308/Words/pull/106.patch"},"body":"This branch does a slight refactor of the Direction class.  Previously, a Direction was an object that could be instantiated.  This actually could create some subtle problems when we flip a direction in a move because the value was negative, but the original LNodeDirection still has a handle to it.  (I encountered this as a subtle bug when experimenting with a Marco Polo sample program).  That could be fixed by always copying the Direction object when creating a new one, but I think the approach on this branch is safer and clearer.  Now, there is no Direction object per se.  The Direction class simply provides a static enum with the different directions.\r\n\r\nThis branch also has a minor unrelated bug fix in WordsObject.setProperty(), where after we set the row or column, it should exit, whereas previously is would go on to actually set a property called row or column.  (It never had any adverse effect, because the getProperty() method would always retrieve the current row or column.)"},"comment":{"url":"https://api.github.com/repos/Aalk4308/Words/issues/comments/94363442","html_url":"https://github.com/Aalk4308/Words/pull/106#issuecomment-94363442","issue_url":"https://api.github.com/repos/Aalk4308/Words/issues/106","id":94363442,"user":{"login":"mzbenami","id":4739877,"avatar_url":"https://avatars.githubusercontent.com/u/4739877?v=3","gravatar_id":"","url":"https://api.github.com/users/mzbenami","html_url":"https://github.com/mzbenami","followers_url":"https://api.github.com/users/mzbenami/followers","following_url":"https://api.github.com/users/mzbenami/following{/other_user}","gists_url":"https://api.github.com/users/mzbenami/gists{/gist_id}","starred_url":"https://api.github.com/users/mzbenami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzbenami/subscriptions","organizations_url":"https://api.github.com/users/mzbenami/orgs","repos_url":"https://api.github.com/users/mzbenami/repos","events_url":"https://api.github.com/users/mzbenami/events{/privacy}","received_events_url":"https://api.github.com/users/mzbenami/received_events","type":"User","site_admin":false},"created_at":"2015-04-20T05:46:36Z","updated_at":"2015-04-20T05:46:36Z","body":"slick, i didn't know you could use enums like that either."}}