{"action":"created","issue":{"url":"https://api.github.com/repos/NLog/NLog/issues/629","labels_url":"https://api.github.com/repos/NLog/NLog/issues/629/labels{/name}","comments_url":"https://api.github.com/repos/NLog/NLog/issues/629/comments","events_url":"https://api.github.com/repos/NLog/NLog/issues/629/events","html_url":"https://github.com/NLog/NLog/pull/629","id":60015297,"number":629,"title":"BOM option/fix for WebserviceTarget + code improvements (WIP) ","user":{"login":"304NotModified","id":5808377,"avatar_url":"https://avatars.githubusercontent.com/u/5808377?v=3","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NLog/NLog/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/NLog/NLog/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/NLog/NLog/labels/has%20unittests","name":"has unittests","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-05T21:01:59Z","updated_at":"2015-03-06T00:17:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NLog/NLog/pulls/629","html_url":"https://github.com/NLog/NLog/pull/629","diff_url":"https://github.com/NLog/NLog/pull/629.diff","patch_url":"https://github.com/NLog/NLog/pull/629.patch"},"body":"Fixes: #212, #250 (duplicate), #380 (duplicate)\r\n\r\n- option to include BOM in `WebserviceTarget ` - UTF-8 only. Doens't do anything with a different encoding. BOM is disabled by default. (breaking change). Property `IncludeBOM`. Possible values; \r\n - `null` (dont change BOM), \r\n - `true` (always include UTF-8 bom on UTF-8 encodings), \r\n - `false` (**default**, always skip bom on UTF-8 encodings)\r\n- no `Stream` to `byte[]` and back to `Stream`. Just write direct from `Stream` to `Stream`\r\n- removed code duplication `WebserviceTarget `\r\n- documented code `WebserviceTarget `\r\n- made `WebserviceTarget ` mockable with internal method. See unit tests.\r\n- unit tests for `WebserviceTarget ` including async testing\r\n"},"comment":{"url":"https://api.github.com/repos/NLog/NLog/issues/comments/77481715","html_url":"https://github.com/NLog/NLog/pull/629#issuecomment-77481715","issue_url":"https://api.github.com/repos/NLog/NLog/issues/629","id":77481715,"user":{"login":"ilya-g","id":4257577,"avatar_url":"https://avatars.githubusercontent.com/u/4257577?v=3","gravatar_id":"","url":"https://api.github.com/users/ilya-g","html_url":"https://github.com/ilya-g","followers_url":"https://api.github.com/users/ilya-g/followers","following_url":"https://api.github.com/users/ilya-g/following{/other_user}","gists_url":"https://api.github.com/users/ilya-g/gists{/gist_id}","starred_url":"https://api.github.com/users/ilya-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilya-g/subscriptions","organizations_url":"https://api.github.com/users/ilya-g/orgs","repos_url":"https://api.github.com/users/ilya-g/repos","events_url":"https://api.github.com/users/ilya-g/events{/privacy}","received_events_url":"https://api.github.com/users/ilya-g/received_events","type":"User","site_admin":false},"created_at":"2015-03-06T00:17:36Z","updated_at":"2015-03-06T00:17:36Z","body":"Nice refactoring in `WebServiceTarget`.\r\n\r\nIt was suprise for me that you have abandoned your idea about 'utf-8-no-bom' special encoding name. I've made checkout at the commit https://github.com/304NotModified/NLog/commit/81cb6721f4dc67f4a96435b8d0f482dc43867fd1 and have all its tests passing. Why do you feel that solution was wrong?"}}