{"push_id":869025860,"size":3,"distinct_size":3,"ref":"refs/heads/develop","head":"d4698e4985e2a36be7d13ec83715ab2283e121d5","before":"b387e3c25ecdc89d5aaf3723971d0c8d8f53103b","commits":[{"sha":"ad91491260428a36e6bd4ce59334aa9f905fee81","author":{"email":"dfddabaa9af05982b01940b837a87844148069c9@ni.com","name":"Sergey Kizunov"},"message":"Windows salt-master failures due to passing 'log_queue'\n\nOn Windows, there are failures that appear like:\n`TypeError: __init__() got an unexpected keyword argument 'log_queue'`\n\nTo fix this:\n\nsalt/utils/events.py:\n- Objects inheriting from\n`salt.utils.process.SignalHandlingMultiprocessingProcess` must be\ncapable of passing the kwarg 'log_queue' through to the parent class\n`MultiprocessingProcess` so that it will be used on Windows. See PR\n26999 as to why this was needed.\n\nsalt/utils/reactor.py:\n- Same as event.py\n- Moved `__setstate__` and `__getstate__` from `salt.state.Compiler`\nto `salt.utils.reactor.Reactor`. The reason is that this is the most\nderived class, and we want to accomplish two things:\n1) Avoid pickling self.rend (inherited from salt.state.Compiler)\nwhich is unpicklable, hence the need for `__setstate__` and\n`__getstate__` in the first place.\n2) Initialize the class from the top-most point. The `__init__` function\nhere will, in turn, initialize parent classes such as\n`salt.state.Compiler`, creating the renderer as needed.\n\nsalt/state.py:\n- Removed `__setstate__` and `__getstate__` from `salt.state.Compiler`\nas per comment above.\n\nSigned-off-by: Sergey Kizunov <sergey.kizunov@ni.com>","distinct":true,"url":"https://api.github.com/repos/saltstack/salt/commits/ad91491260428a36e6bd4ce59334aa9f905fee81"},{"sha":"ebc3b738b61d82e1b85bb7c3f9efdbd9086a03ec","author":{"email":"dfddabaa9af05982b01940b837a87844148069c9@ni.com","name":"Sergey Kizunov"},"message":"Passing in `log_queue` explicitly instead of using `**kwargs`\n\nsalt/utils/process.py:\n- Since `log_queue` is now passed in explicitly, it now may exist with a\nvalue of `None`. `MultiprocessingProcess.__init__` has been modified to\nhandle this case.\n\nSigned-off-by: Sergey Kizunov <sergey.kizunov@ni.com>","distinct":true,"url":"https://api.github.com/repos/saltstack/salt/commits/ebc3b738b61d82e1b85bb7c3f9efdbd9086a03ec"},{"sha":"d4698e4985e2a36be7d13ec83715ab2283e121d5","author":{"email":"91f6e575920d2d503d8597338fd1637d580f4243@saltstack.com","name":"Mike Place"},"message":"Merge pull request #28936 from skizunov/develop2\n\nWindows salt-master failures due to passing 'log_queue'","distinct":true,"url":"https://api.github.com/repos/saltstack/salt/commits/d4698e4985e2a36be7d13ec83715ab2283e121d5"}]}