{"action":"created","comment":{"url":"https://api.github.com/repos/slamdata/slamengine/pulls/comments/32770639","id":32770639,"diff_hunk":"@@ -171,6 +191,10 @@ final case class FileSystemApi(backend: Backend, contentPath: String, config: Co\n \n   object Offset extends OptionalQueryParamDecoderMatcher[Long](\"offset\")\n   object Limit extends OptionalQueryParamDecoderMatcher[Long](\"limit\")\n+  object ColumnDelimiter extends OptionalQueryParamDecoderMatcher[Char](\"columnDelimiter\")\n+  object RowDelimiter extends OptionalQueryParamDecoderMatcher[String](\"rowDelimiter\")\n+  object QuoteChar extends OptionalQueryParamDecoderMatcher[Char](\"quoteChar\")\n+  object EscapeChar extends OptionalQueryParamDecoderMatcher[Char](\"escapeChar\")","path":"web/src/main/scala/slamdata/engine/api/fs.scala","position":135,"original_position":139,"commit_id":"2a4868fb4cda03f89a54d497cd25508a8ad9bc96","original_commit_id":"df2f52881448fbe715b009dd74d9c2cc6b5f6f88","user":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"body":"Looks like we could define a separate \"Content-Type\" header and use that. We can't use the provided one, because it uses the broken `MediaType.render`.","created_at":"2015-06-18T19:50:09Z","updated_at":"2015-06-18T19:50:09Z","html_url":"https://github.com/slamdata/slamengine/pull/776#discussion_r32770639","pull_request_url":"https://api.github.com/repos/slamdata/slamengine/pulls/776","_links":{"self":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/comments/32770639"},"html":{"href":"https://github.com/slamdata/slamengine/pull/776#discussion_r32770639"},"pull_request":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/776"}}},"pull_request":{"url":"https://api.github.com/repos/slamdata/slamengine/pulls/776","id":37651721,"html_url":"https://github.com/slamdata/slamengine/pull/776","diff_url":"https://github.com/slamdata/slamengine/pull/776.diff","patch_url":"https://github.com/slamdata/slamengine/pull/776.patch","issue_url":"https://api.github.com/repos/slamdata/slamengine/issues/776","number":776,"state":"open","locked":false,"title":"more output options, mostly for GET /data","user":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"body":"Includes 3 of 4 features included in issue #763.\r\n\r\n1. additional query params for specifying CSV delimiters\r\n2. allow client to request valid JSON (values wrapped in an array) via `Accept`\r\n3. support gzip compression via `Accept-Encoding`\r\n\r\nNote: integration tests verify that the gzip encoding is happening, but do not actually verify the content. That can be done manually by running something like `curl -i --compressed \"http://localhost:8180/data/fs/local/zips?limit=10\"`\r\n\r\nAlso fixed the Cors middleware to respond only to OPTIONS requests.\r\n\r\nGot rid of one use of a syntax that was breaking half the world's Scala parsers (including github's).\r\n\r\nTagged a pending test with the relevant issue number.","created_at":"2015-06-15T00:34:33Z","updated_at":"2015-06-18T19:50:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77811f944c624cd6e99b1846a4468721a5d3d645","assignee":{"login":"sellout","id":33031,"avatar_url":"https://avatars.githubusercontent.com/u/33031?v=3","gravatar_id":"","url":"https://api.github.com/users/sellout","html_url":"https://github.com/sellout","followers_url":"https://api.github.com/users/sellout/followers","following_url":"https://api.github.com/users/sellout/following{/other_user}","gists_url":"https://api.github.com/users/sellout/gists{/gist_id}","starred_url":"https://api.github.com/users/sellout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sellout/subscriptions","organizations_url":"https://api.github.com/users/sellout/orgs","repos_url":"https://api.github.com/users/sellout/repos","events_url":"https://api.github.com/users/sellout/events{/privacy}","received_events_url":"https://api.github.com/users/sellout/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/slamdata/slamengine/pulls/776/commits","review_comments_url":"https://api.github.com/repos/slamdata/slamengine/pulls/776/comments","review_comment_url":"https://api.github.com/repos/slamdata/slamengine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slamdata/slamengine/issues/776/comments","statuses_url":"https://api.github.com/repos/slamdata/slamengine/statuses/2a4868fb4cda03f89a54d497cd25508a8ad9bc96","head":{"label":"mossprescott:ready/763-output-options","ref":"ready/763-output-options","sha":"2a4868fb4cda03f89a54d497cd25508a8ad9bc96","user":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"repo":{"id":21178367,"name":"slamengine","full_name":"mossprescott/slamengine","owner":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mossprescott/slamengine","description":"The engine for SlamData","fork":true,"url":"https://api.github.com/repos/mossprescott/slamengine","forks_url":"https://api.github.com/repos/mossprescott/slamengine/forks","keys_url":"https://api.github.com/repos/mossprescott/slamengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mossprescott/slamengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mossprescott/slamengine/teams","hooks_url":"https://api.github.com/repos/mossprescott/slamengine/hooks","issue_events_url":"https://api.github.com/repos/mossprescott/slamengine/issues/events{/number}","events_url":"https://api.github.com/repos/mossprescott/slamengine/events","assignees_url":"https://api.github.com/repos/mossprescott/slamengine/assignees{/user}","branches_url":"https://api.github.com/repos/mossprescott/slamengine/branches{/branch}","tags_url":"https://api.github.com/repos/mossprescott/slamengine/tags","blobs_url":"https://api.github.com/repos/mossprescott/slamengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mossprescott/slamengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mossprescott/slamengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/mossprescott/slamengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mossprescott/slamengine/statuses/{sha}","languages_url":"https://api.github.com/repos/mossprescott/slamengine/languages","stargazers_url":"https://api.github.com/repos/mossprescott/slamengine/stargazers","contributors_url":"https://api.github.com/repos/mossprescott/slamengine/contributors","subscribers_url":"https://api.github.com/repos/mossprescott/slamengine/subscribers","subscription_url":"https://api.github.com/repos/mossprescott/slamengine/subscription","commits_url":"https://api.github.com/repos/mossprescott/slamengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/mossprescott/slamengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/mossprescott/slamengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/mossprescott/slamengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/mossprescott/slamengine/contents/{+path}","compare_url":"https://api.github.com/repos/mossprescott/slamengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mossprescott/slamengine/merges","archive_url":"https://api.github.com/repos/mossprescott/slamengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mossprescott/slamengine/downloads","issues_url":"https://api.github.com/repos/mossprescott/slamengine/issues{/number}","pulls_url":"https://api.github.com/repos/mossprescott/slamengine/pulls{/number}","milestones_url":"https://api.github.com/repos/mossprescott/slamengine/milestones{/number}","notifications_url":"https://api.github.com/repos/mossprescott/slamengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mossprescott/slamengine/labels{/name}","releases_url":"https://api.github.com/repos/mossprescott/slamengine/releases{/id}","created_at":"2014-06-24T19:43:22Z","updated_at":"2015-01-08T17:19:20Z","pushed_at":"2015-06-18T18:40:02Z","git_url":"git://github.com/mossprescott/slamengine.git","ssh_url":"git@github.com:mossprescott/slamengine.git","clone_url":"https://github.com/mossprescott/slamengine.git","svn_url":"https://github.com/mossprescott/slamengine","homepage":null,"size":6857,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CHECK-UPSTREAM-REPO"}},"base":{"label":"slamdata:master","ref":"master","sha":"f4d0e2b0b3cc4654fff6af1c39b932ad89e69247","user":{"login":"slamdata","id":5385602,"avatar_url":"https://avatars.githubusercontent.com/u/5385602?v=3","gravatar_id":"","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"repo":{"id":16515058,"name":"slamengine","full_name":"slamdata/slamengine","owner":{"login":"slamdata","id":5385602,"avatar_url":"https://avatars.githubusercontent.com/u/5385602?v=3","gravatar_id":"","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slamdata/slamengine","description":"The engine for SlamData","fork":false,"url":"https://api.github.com/repos/slamdata/slamengine","forks_url":"https://api.github.com/repos/slamdata/slamengine/forks","keys_url":"https://api.github.com/repos/slamdata/slamengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slamdata/slamengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slamdata/slamengine/teams","hooks_url":"https://api.github.com/repos/slamdata/slamengine/hooks","issue_events_url":"https://api.github.com/repos/slamdata/slamengine/issues/events{/number}","events_url":"https://api.github.com/repos/slamdata/slamengine/events","assignees_url":"https://api.github.com/repos/slamdata/slamengine/assignees{/user}","branches_url":"https://api.github.com/repos/slamdata/slamengine/branches{/branch}","tags_url":"https://api.github.com/repos/slamdata/slamengine/tags","blobs_url":"https://api.github.com/repos/slamdata/slamengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slamdata/slamengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slamdata/slamengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/slamdata/slamengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slamdata/slamengine/statuses/{sha}","languages_url":"https://api.github.com/repos/slamdata/slamengine/languages","stargazers_url":"https://api.github.com/repos/slamdata/slamengine/stargazers","contributors_url":"https://api.github.com/repos/slamdata/slamengine/contributors","subscribers_url":"https://api.github.com/repos/slamdata/slamengine/subscribers","subscription_url":"https://api.github.com/repos/slamdata/slamengine/subscription","commits_url":"https://api.github.com/repos/slamdata/slamengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/slamdata/slamengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/slamdata/slamengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/slamdata/slamengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/slamdata/slamengine/contents/{+path}","compare_url":"https://api.github.com/repos/slamdata/slamengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slamdata/slamengine/merges","archive_url":"https://api.github.com/repos/slamdata/slamengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slamdata/slamengine/downloads","issues_url":"https://api.github.com/repos/slamdata/slamengine/issues{/number}","pulls_url":"https://api.github.com/repos/slamdata/slamengine/pulls{/number}","milestones_url":"https://api.github.com/repos/slamdata/slamengine/milestones{/number}","notifications_url":"https://api.github.com/repos/slamdata/slamengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slamdata/slamengine/labels{/name}","releases_url":"https://api.github.com/repos/slamdata/slamengine/releases{/id}","created_at":"2014-02-04T15:01:27Z","updated_at":"2015-06-12T16:43:09Z","pushed_at":"2015-06-18T18:40:03Z","git_url":"git://github.com/slamdata/slamengine.git","ssh_url":"git@github.com:slamdata/slamengine.git","clone_url":"https://github.com/slamdata/slamengine.git","svn_url":"https://github.com/slamdata/slamengine","homepage":null,"size":8590,"stargazers_count":122,"watchers_count":122,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":151,"forks":28,"open_issues":151,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/776"},"html":{"href":"https://github.com/slamdata/slamengine/pull/776"},"issue":{"href":"https://api.github.com/repos/slamdata/slamengine/issues/776"},"comments":{"href":"https://api.github.com/repos/slamdata/slamengine/issues/776/comments"},"review_comments":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/776/comments"},"review_comment":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/776/commits"},"statuses":{"href":"https://api.github.com/repos/slamdata/slamengine/statuses/2a4868fb4cda03f89a54d497cd25508a8ad9bc96"}}}}