{"action":"created","issue":{"url":"https://api.github.com/repos/SwissTPH/openmalaria/issues/110","labels_url":"https://api.github.com/repos/SwissTPH/openmalaria/issues/110/labels{/name}","comments_url":"https://api.github.com/repos/SwissTPH/openmalaria/issues/110/comments","events_url":"https://api.github.com/repos/SwissTPH/openmalaria/issues/110/events","html_url":"https://github.com/SwissTPH/openmalaria/issues/110","id":86673612,"number":110,"title":"non-const-pop-size","user":{"login":"tph-thuering","id":9700759,"avatar_url":"https://avatars.githubusercontent.com/u/9700759?v=3","gravatar_id":"","url":"https://api.github.com/users/tph-thuering","html_url":"https://github.com/tph-thuering","followers_url":"https://api.github.com/users/tph-thuering/followers","following_url":"https://api.github.com/users/tph-thuering/following{/other_user}","gists_url":"https://api.github.com/users/tph-thuering/gists{/gist_id}","starred_url":"https://api.github.com/users/tph-thuering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tph-thuering/subscriptions","organizations_url":"https://api.github.com/users/tph-thuering/orgs","repos_url":"https://api.github.com/users/tph-thuering/repos","events_url":"https://api.github.com/users/tph-thuering/events{/privacy}","received_events_url":"https://api.github.com/users/tph-thuering/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/SwissTPH/openmalaria/labels/3:%20low","name":"3: low","color":"fef2c0"},{"url":"https://api.github.com/repos/SwissTPH/openmalaria/labels/from-OM_TODO","name":"from-OM_TODO","color":"ffaadd"}],"state":"open","locked":false,"assignee":{"login":"dhardy","id":134893,"avatar_url":"https://avatars.githubusercontent.com/u/134893?v=3","gravatar_id":"","url":"https://api.github.com/users/dhardy","html_url":"https://github.com/dhardy","followers_url":"https://api.github.com/users/dhardy/followers","following_url":"https://api.github.com/users/dhardy/following{/other_user}","gists_url":"https://api.github.com/users/dhardy/gists{/gist_id}","starred_url":"https://api.github.com/users/dhardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhardy/subscriptions","organizations_url":"https://api.github.com/users/dhardy/orgs","repos_url":"https://api.github.com/users/dhardy/repos","events_url":"https://api.github.com/users/dhardy/events{/privacy}","received_events_url":"https://api.github.com/users/dhardy/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-06-09T17:28:56Z","updated_at":"2015-08-19T19:44:11Z","closed_at":null,"body":"Use of Population::_populationSize needs to be checked in code for this.\r\n\r\n> Diggory\r\n> \r\n> So far rho has always been zero.   Ideally we would like it to be able\r\n> to take small positive values (population growth) but this is not a\r\n> priority.\r\n> I think this should be flagged as a rather distant TODO with the text of\r\n> your mail somewhere in the documentation of the TODO\r\n> \r\n> Tom\r\n> \r\n> Diggory Hardy wrote:\r\n> > Hi,\r\n> >\r\n> > One little thing I noticed (in update1):\r\n> >{{{#!cpp\r\n> >\r\n> >   //targetPop is the population size at time t allowing population growth\r\n> >   int targetPop = (int)(_populationSize *\r\n> >   exp(rho*Simulation::simulationTime));\r\n> >\r\n> >}}}\r\n> >\r\n> > Is rho ever non-zero? (It defaults to zero if not present.) Currently\r\n> > some of the code (largely vector code I've written, but also\r\n> > checkpointing), uses _populationSize as the current, exact, population\r\n> > size; hence there will be problems (checkpoints should crash, vector\r\n> > calculations off) if rho is non-zero.\r\n> > \r\n> > So should I correct this? (Currently I just put a catch in to check rho\r\n> > is zero. It doesn't really make sense to have code like this which never\r\n> > does anything, of course.)\r\n> > \r\n> > Another thing with _populationSize is that it's used to find per-human\r\n> > averages (at least in the vector code), however the number of\r\n> > individuals who's params are added up is going to be less than popSize,\r\n> > due to some being out-migrated or dying of old age, and new births not\r\n> > getting added until after the loop. Actually, too-old individuals die\r\n> > immediately while outmigrated indivs aren't removed until after being\r\n> > updated in the loop which doesn't make much sense... I'm a bit wary of\r\n> > the knock on effects of changing the whole ordering though.\r\n> > \r\n> > DH"},"comment":{"url":"https://api.github.com/repos/SwissTPH/openmalaria/issues/comments/132755818","html_url":"https://github.com/SwissTPH/openmalaria/issues/110#issuecomment-132755818","issue_url":"https://api.github.com/repos/SwissTPH/openmalaria/issues/110","id":132755818,"user":{"login":"ThomasASmith","id":9484964,"avatar_url":"https://avatars.githubusercontent.com/u/9484964?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasASmith","html_url":"https://github.com/ThomasASmith","followers_url":"https://api.github.com/users/ThomasASmith/followers","following_url":"https://api.github.com/users/ThomasASmith/following{/other_user}","gists_url":"https://api.github.com/users/ThomasASmith/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasASmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasASmith/subscriptions","organizations_url":"https://api.github.com/users/ThomasASmith/orgs","repos_url":"https://api.github.com/users/ThomasASmith/repos","events_url":"https://api.github.com/users/ThomasASmith/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasASmith/received_events","type":"User","site_admin":false},"created_at":"2015-08-19T19:44:11Z","updated_at":"2015-08-19T19:44:11Z","body":"No its not urgent.  I was just tidying up which issues are assigned to whom.\n\nOn 19.08.2015 20:43, Diggory Hardy wrote:\n>\n> @ThomasASmith <https://github.com/ThomasASmith> This note has been \n> around a long time. Are you saying I should look into implementing \n> non-const population sizes now? I can't guess how difficult this is \n> without looking further into it.\n>\n> —\n> Reply to this email directly or view it on GitHub \n> <https://github.com/SwissTPH/openmalaria/issues/110#issuecomment-132737930>.\n>\n\n\n-- \nThomas Smith\nSwiss Tropical & Public Health Institute\nDepartment of Epidemiology & Public Health\nSocinstrasse 57\nP.O . Box\nCH-4002 Basel\nSwitzerland\nTel  +41 61 284 8273 Fax +41 61 284 8101\nemail: Thomas-A.Smith@unibas.ch\nhttp://www.swisstph.ch/about-us/departments/epidemiology-and-public-health-eph/health-systems-research-and-dynamical-modelling.html\n\n"}}