{"action":"closed","number":124,"pull_request":{"url":"https://api.github.com/repos/glennjones/hapi-swagger/pulls/124","id":32409030,"html_url":"https://github.com/glennjones/hapi-swagger/pull/124","diff_url":"https://github.com/glennjones/hapi-swagger/pull/124.diff","patch_url":"https://github.com/glennjones/hapi-swagger/pull/124.patch","issue_url":"https://api.github.com/repos/glennjones/hapi-swagger/issues/124","number":124,"state":"closed","locked":false,"title":"Strip unknown fields from settings.info during validation","user":{"login":"fhemberger","id":153481,"avatar_url":"https://avatars.githubusercontent.com/u/153481?v=3","gravatar_id":"","url":"https://api.github.com/users/fhemberger","html_url":"https://github.com/fhemberger","followers_url":"https://api.github.com/users/fhemberger/followers","following_url":"https://api.github.com/users/fhemberger/following{/other_user}","gists_url":"https://api.github.com/users/fhemberger/gists{/gist_id}","starred_url":"https://api.github.com/users/fhemberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhemberger/subscriptions","organizations_url":"https://api.github.com/users/fhemberger/orgs","repos_url":"https://api.github.com/users/fhemberger/repos","events_url":"https://api.github.com/users/fhemberger/events{/privacy}","received_events_url":"https://api.github.com/users/fhemberger/received_events","type":"User","site_admin":false},"body":"And use the cleaned up `value` parameter instead of `settings.info`.\r\n\r\nI'm using the popular [node-config](https://github.com/lorenwest/node-config) module to manage all sorts of hapi configuration option (including parameters for hapi-swagger). Unfortunately it seems to inject additional functions to help merging parts of the configuration options, thus the validation of `settings.info\r\n` will fail. This can easily be fixed by asking Joi to drop all unknown additional keys.","created_at":"2015-04-01T11:09:54Z","updated_at":"2015-04-06T16:46:41Z","closed_at":"2015-04-06T16:46:41Z","merged_at":"2015-04-06T16:46:41Z","merge_commit_sha":"fefa60a43177bf00d57e19e71a0abc026c589ad5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/glennjones/hapi-swagger/pulls/124/commits","review_comments_url":"https://api.github.com/repos/glennjones/hapi-swagger/pulls/124/comments","review_comment_url":"https://api.github.com/repos/glennjones/hapi-swagger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/glennjones/hapi-swagger/issues/124/comments","statuses_url":"https://api.github.com/repos/glennjones/hapi-swagger/statuses/ba2ebc7fe02f25e75afd44b5ba23e9241c3edc69","head":{"label":"fhemberger:feature/info-validation","ref":"feature/info-validation","sha":"ba2ebc7fe02f25e75afd44b5ba23e9241c3edc69","user":{"login":"fhemberger","id":153481,"avatar_url":"https://avatars.githubusercontent.com/u/153481?v=3","gravatar_id":"","url":"https://api.github.com/users/fhemberger","html_url":"https://github.com/fhemberger","followers_url":"https://api.github.com/users/fhemberger/followers","following_url":"https://api.github.com/users/fhemberger/following{/other_user}","gists_url":"https://api.github.com/users/fhemberger/gists{/gist_id}","starred_url":"https://api.github.com/users/fhemberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhemberger/subscriptions","organizations_url":"https://api.github.com/users/fhemberger/orgs","repos_url":"https://api.github.com/users/fhemberger/repos","events_url":"https://api.github.com/users/fhemberger/events{/privacy}","received_events_url":"https://api.github.com/users/fhemberger/received_events","type":"User","site_admin":false},"repo":{"id":33232732,"name":"hapi-swagger","full_name":"fhemberger/hapi-swagger","owner":{"login":"fhemberger","id":153481,"avatar_url":"https://avatars.githubusercontent.com/u/153481?v=3","gravatar_id":"","url":"https://api.github.com/users/fhemberger","html_url":"https://github.com/fhemberger","followers_url":"https://api.github.com/users/fhemberger/followers","following_url":"https://api.github.com/users/fhemberger/following{/other_user}","gists_url":"https://api.github.com/users/fhemberger/gists{/gist_id}","starred_url":"https://api.github.com/users/fhemberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhemberger/subscriptions","organizations_url":"https://api.github.com/users/fhemberger/orgs","repos_url":"https://api.github.com/users/fhemberger/repos","events_url":"https://api.github.com/users/fhemberger/events{/privacy}","received_events_url":"https://api.github.com/users/fhemberger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fhemberger/hapi-swagger","description":"A Swagger interface for HAPI","fork":true,"url":"https://api.github.com/repos/fhemberger/hapi-swagger","forks_url":"https://api.github.com/repos/fhemberger/hapi-swagger/forks","keys_url":"https://api.github.com/repos/fhemberger/hapi-swagger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fhemberger/hapi-swagger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fhemberger/hapi-swagger/teams","hooks_url":"https://api.github.com/repos/fhemberger/hapi-swagger/hooks","issue_events_url":"https://api.github.com/repos/fhemberger/hapi-swagger/issues/events{/number}","events_url":"https://api.github.com/repos/fhemberger/hapi-swagger/events","assignees_url":"https://api.github.com/repos/fhemberger/hapi-swagger/assignees{/user}","branches_url":"https://api.github.com/repos/fhemberger/hapi-swagger/branches{/branch}","tags_url":"https://api.github.com/repos/fhemberger/hapi-swagger/tags","blobs_url":"https://api.github.com/repos/fhemberger/hapi-swagger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fhemberger/hapi-swagger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fhemberger/hapi-swagger/git/refs{/sha}","trees_url":"https://api.github.com/repos/fhemberger/hapi-swagger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fhemberger/hapi-swagger/statuses/{sha}","languages_url":"https://api.github.com/repos/fhemberger/hapi-swagger/languages","stargazers_url":"https://api.github.com/repos/fhemberger/hapi-swagger/stargazers","contributors_url":"https://api.github.com/repos/fhemberger/hapi-swagger/contributors","subscribers_url":"https://api.github.com/repos/fhemberger/hapi-swagger/subscribers","subscription_url":"https://api.github.com/repos/fhemberger/hapi-swagger/subscription","commits_url":"https://api.github.com/repos/fhemberger/hapi-swagger/commits{/sha}","git_commits_url":"https://api.github.com/repos/fhemberger/hapi-swagger/git/commits{/sha}","comments_url":"https://api.github.com/repos/fhemberger/hapi-swagger/comments{/number}","issue_comment_url":"https://api.github.com/repos/fhemberger/hapi-swagger/issues/comments{/number}","contents_url":"https://api.github.com/repos/fhemberger/hapi-swagger/contents/{+path}","compare_url":"https://api.github.com/repos/fhemberger/hapi-swagger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fhemberger/hapi-swagger/merges","archive_url":"https://api.github.com/repos/fhemberger/hapi-swagger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fhemberger/hapi-swagger/downloads","issues_url":"https://api.github.com/repos/fhemberger/hapi-swagger/issues{/number}","pulls_url":"https://api.github.com/repos/fhemberger/hapi-swagger/pulls{/number}","milestones_url":"https://api.github.com/repos/fhemberger/hapi-swagger/milestones{/number}","notifications_url":"https://api.github.com/repos/fhemberger/hapi-swagger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fhemberger/hapi-swagger/labels{/name}","releases_url":"https://api.github.com/repos/fhemberger/hapi-swagger/releases{/id}","created_at":"2015-04-01T07:20:47Z","updated_at":"2015-04-01T11:16:11Z","pushed_at":"2015-04-01T11:16:11Z","git_url":"git://github.com/fhemberger/hapi-swagger.git","ssh_url":"git@github.com:fhemberger/hapi-swagger.git","clone_url":"https://github.com/fhemberger/hapi-swagger.git","svn_url":"https://github.com/fhemberger/hapi-swagger","homepage":null,"size":835,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"glennjones:master","ref":"master","sha":"36077c53f85b7d75fa8df63b63aa7aef06c740c3","user":{"login":"glennjones","id":175288,"avatar_url":"https://avatars.githubusercontent.com/u/175288?v=3","gravatar_id":"","url":"https://api.github.com/users/glennjones","html_url":"https://github.com/glennjones","followers_url":"https://api.github.com/users/glennjones/followers","following_url":"https://api.github.com/users/glennjones/following{/other_user}","gists_url":"https://api.github.com/users/glennjones/gists{/gist_id}","starred_url":"https://api.github.com/users/glennjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennjones/subscriptions","organizations_url":"https://api.github.com/users/glennjones/orgs","repos_url":"https://api.github.com/users/glennjones/repos","events_url":"https://api.github.com/users/glennjones/events{/privacy}","received_events_url":"https://api.github.com/users/glennjones/received_events","type":"User","site_admin":false},"repo":{"id":11896413,"name":"hapi-swagger","full_name":"glennjones/hapi-swagger","owner":{"login":"glennjones","id":175288,"avatar_url":"https://avatars.githubusercontent.com/u/175288?v=3","gravatar_id":"","url":"https://api.github.com/users/glennjones","html_url":"https://github.com/glennjones","followers_url":"https://api.github.com/users/glennjones/followers","following_url":"https://api.github.com/users/glennjones/following{/other_user}","gists_url":"https://api.github.com/users/glennjones/gists{/gist_id}","starred_url":"https://api.github.com/users/glennjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennjones/subscriptions","organizations_url":"https://api.github.com/users/glennjones/orgs","repos_url":"https://api.github.com/users/glennjones/repos","events_url":"https://api.github.com/users/glennjones/events{/privacy}","received_events_url":"https://api.github.com/users/glennjones/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/glennjones/hapi-swagger","description":"A Swagger interface for HAPI","fork":false,"url":"https://api.github.com/repos/glennjones/hapi-swagger","forks_url":"https://api.github.com/repos/glennjones/hapi-swagger/forks","keys_url":"https://api.github.com/repos/glennjones/hapi-swagger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glennjones/hapi-swagger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glennjones/hapi-swagger/teams","hooks_url":"https://api.github.com/repos/glennjones/hapi-swagger/hooks","issue_events_url":"https://api.github.com/repos/glennjones/hapi-swagger/issues/events{/number}","events_url":"https://api.github.com/repos/glennjones/hapi-swagger/events","assignees_url":"https://api.github.com/repos/glennjones/hapi-swagger/assignees{/user}","branches_url":"https://api.github.com/repos/glennjones/hapi-swagger/branches{/branch}","tags_url":"https://api.github.com/repos/glennjones/hapi-swagger/tags","blobs_url":"https://api.github.com/repos/glennjones/hapi-swagger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glennjones/hapi-swagger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glennjones/hapi-swagger/git/refs{/sha}","trees_url":"https://api.github.com/repos/glennjones/hapi-swagger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glennjones/hapi-swagger/statuses/{sha}","languages_url":"https://api.github.com/repos/glennjones/hapi-swagger/languages","stargazers_url":"https://api.github.com/repos/glennjones/hapi-swagger/stargazers","contributors_url":"https://api.github.com/repos/glennjones/hapi-swagger/contributors","subscribers_url":"https://api.github.com/repos/glennjones/hapi-swagger/subscribers","subscription_url":"https://api.github.com/repos/glennjones/hapi-swagger/subscription","commits_url":"https://api.github.com/repos/glennjones/hapi-swagger/commits{/sha}","git_commits_url":"https://api.github.com/repos/glennjones/hapi-swagger/git/commits{/sha}","comments_url":"https://api.github.com/repos/glennjones/hapi-swagger/comments{/number}","issue_comment_url":"https://api.github.com/repos/glennjones/hapi-swagger/issues/comments{/number}","contents_url":"https://api.github.com/repos/glennjones/hapi-swagger/contents/{+path}","compare_url":"https://api.github.com/repos/glennjones/hapi-swagger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glennjones/hapi-swagger/merges","archive_url":"https://api.github.com/repos/glennjones/hapi-swagger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glennjones/hapi-swagger/downloads","issues_url":"https://api.github.com/repos/glennjones/hapi-swagger/issues{/number}","pulls_url":"https://api.github.com/repos/glennjones/hapi-swagger/pulls{/number}","milestones_url":"https://api.github.com/repos/glennjones/hapi-swagger/milestones{/number}","notifications_url":"https://api.github.com/repos/glennjones/hapi-swagger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glennjones/hapi-swagger/labels{/name}","releases_url":"https://api.github.com/repos/glennjones/hapi-swagger/releases{/id}","created_at":"2013-08-05T11:13:40Z","updated_at":"2015-04-06T16:46:41Z","pushed_at":"2015-04-06T16:46:41Z","git_url":"git://github.com/glennjones/hapi-swagger.git","ssh_url":"git@github.com:glennjones/hapi-swagger.git","clone_url":"https://github.com/glennjones/hapi-swagger.git","svn_url":"https://github.com/glennjones/hapi-swagger","homepage":null,"size":1500,"stargazers_count":112,"watchers_count":112,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":17,"forks":45,"open_issues":17,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/glennjones/hapi-swagger/pulls/124"},"html":{"href":"https://github.com/glennjones/hapi-swagger/pull/124"},"issue":{"href":"https://api.github.com/repos/glennjones/hapi-swagger/issues/124"},"comments":{"href":"https://api.github.com/repos/glennjones/hapi-swagger/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/glennjones/hapi-swagger/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/glennjones/hapi-swagger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/glennjones/hapi-swagger/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/glennjones/hapi-swagger/statuses/ba2ebc7fe02f25e75afd44b5ba23e9241c3edc69"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"glennjones","id":175288,"avatar_url":"https://avatars.githubusercontent.com/u/175288?v=3","gravatar_id":"","url":"https://api.github.com/users/glennjones","html_url":"https://github.com/glennjones","followers_url":"https://api.github.com/users/glennjones/followers","following_url":"https://api.github.com/users/glennjones/following{/other_user}","gists_url":"https://api.github.com/users/glennjones/gists{/gist_id}","starred_url":"https://api.github.com/users/glennjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennjones/subscriptions","organizations_url":"https://api.github.com/users/glennjones/orgs","repos_url":"https://api.github.com/users/glennjones/repos","events_url":"https://api.github.com/users/glennjones/events{/privacy}","received_events_url":"https://api.github.com/users/glennjones/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}