{"action":"created","issue":{"url":"https://api.github.com/repos/github/VisualStudio/issues/161","labels_url":"https://api.github.com/repos/github/VisualStudio/issues/161/labels{/name}","comments_url":"https://api.github.com/repos/github/VisualStudio/issues/161/comments","events_url":"https://api.github.com/repos/github/VisualStudio/issues/161/events","html_url":"https://github.com/github/VisualStudio/pull/161","id":121120239,"number":161,"title":"Bump libgit2sharp and fix broken Publish","user":{"login":"shana","id":310137,"avatar_url":"https://avatars.githubusercontent.com/u/310137?v=3","gravatar_id":"","url":"https://api.github.com/users/shana","html_url":"https://github.com/shana","followers_url":"https://api.github.com/users/shana/followers","following_url":"https://api.github.com/users/shana/following{/other_user}","gists_url":"https://api.github.com/users/shana/gists{/gist_id}","starred_url":"https://api.github.com/users/shana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shana/subscriptions","organizations_url":"https://api.github.com/users/shana/orgs","repos_url":"https://api.github.com/users/shana/repos","events_url":"https://api.github.com/users/shana/events{/privacy}","received_events_url":"https://api.github.com/users/shana/received_events","type":"User","site_admin":true},"labels":[],"state":"open","locked":false,"assignee":{"login":"Haacked","id":19977,"avatar_url":"https://avatars.githubusercontent.com/u/19977?v=3","gravatar_id":"","url":"https://api.github.com/users/Haacked","html_url":"https://github.com/Haacked","followers_url":"https://api.github.com/users/Haacked/followers","following_url":"https://api.github.com/users/Haacked/following{/other_user}","gists_url":"https://api.github.com/users/Haacked/gists{/gist_id}","starred_url":"https://api.github.com/users/Haacked/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Haacked/subscriptions","organizations_url":"https://api.github.com/users/Haacked/orgs","repos_url":"https://api.github.com/users/Haacked/repos","events_url":"https://api.github.com/users/Haacked/events{/privacy}","received_events_url":"https://api.github.com/users/Haacked/received_events","type":"User","site_admin":true},"milestone":null,"comments":2,"created_at":"2015-12-08T22:59:23Z","updated_at":"2015-12-08T23:36:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/github/VisualStudio/pulls/161","html_url":"https://github.com/github/VisualStudio/pull/161","diff_url":"https://github.com/github/VisualStudio/pull/161.diff","patch_url":"https://github.com/github/VisualStudio/pull/161.patch"},"body":"The publish repository flow is currently broken in VS Update 1 due to a mismatch between the libgit2sharp we compile against and the one that's served to the extension. The libgit2sharp switch was delayed due to auth issues, so the current version of the extension was still using an older copy of libgit2sharp from the first release of VS, which unfortunately matches the version of the library that runs in all VS versions (regardless of whether it is ABI compatible - it is not). This is totally my bad, I should have pressed on with the libgit2sharp update and switch after the dust settled down over the open sourcing of the extension.\r\n\r\nSo, this PR bumps the version of libgit2sharp to the latest of the vNext branch upstream, and hooks up the credential cache to libgit2 via a credential provider callback, so it can grab the credentials as it needs to do network operations. This also adds secure variants to the credential cache methods because libgit2sharp supports secure passwords and we already mostly supported it, so credentials are passed from the windows credential manager to libgit2 without having dropping down to insecure `string`\r\n\r\n/cc @Haacked "},"comment":{"url":"https://api.github.com/repos/github/VisualStudio/issues/comments/163057203","html_url":"https://github.com/github/VisualStudio/pull/161#issuecomment-163057203","issue_url":"https://api.github.com/repos/github/VisualStudio/issues/161","id":163057203,"user":{"login":"shana","id":310137,"avatar_url":"https://avatars.githubusercontent.com/u/310137?v=3","gravatar_id":"","url":"https://api.github.com/users/shana","html_url":"https://github.com/shana","followers_url":"https://api.github.com/users/shana/followers","following_url":"https://api.github.com/users/shana/following{/other_user}","gists_url":"https://api.github.com/users/shana/gists{/gist_id}","starred_url":"https://api.github.com/users/shana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shana/subscriptions","organizations_url":"https://api.github.com/users/shana/orgs","repos_url":"https://api.github.com/users/shana/repos","events_url":"https://api.github.com/users/shana/events{/privacy}","received_events_url":"https://api.github.com/users/shana/received_events","type":"User","site_admin":true},"created_at":"2015-12-08T23:36:58Z","updated_at":"2015-12-08T23:36:58Z","body":"@shiftkey Oh! You have VS 2015 without Update 1, right? It would be really handy to see if it doesn't break on that one, since I'm now stuck on Update 1 and don't have another VM at hand to test it. What breaks is:\r\n\r\n- When you clone, don't forget the submodule update, the script dir is a private submodule with the oauth tokens for the app (that are useful and you probably want them :) )\r\n- Create a new project of any kind and add it to source control\r\n- Go to Changes and create a commit\r\n- Click on the \"sync\" link that shows up when the commit is done, in the informational message\r\n- Click on \"Get Started\" in the GitHub section\r\n- Go through the login dialog that pops up (if you're not logged in to github)\r\n- Fill out and publish the repo in the form that shows up (replacing the GitHub section with the Get Started link)\r\n\r\nIt should say \"Repository published\" and possibly the message then disappears because of Other Reasons(tm). It should _not_ say \"Blew up on libgit2sharp boo for you\" (not a literal transcription of the message but close enough)"}}