{"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/jetpack/pulls/comments/48092582","id":48092582,"diff_hunk":"@@ -6886,53 +6877,4 @@ public function dashboard_widget_connect_to_wpcom() {\n \t\t<?php\n \t}\n \n-\t/*\n-\t * A graceful transition to using Core's site icon.\n-\t *\n-\t * All of the hard work has already been done with the image\n-\t * in all_done_page(). All that needs to be done now is update\n-\t * the option and display proper messaging.\n-\t *\n-\t * @todo remove when WP 4.3 is minimum\n-\t *\n-\t * @since 3.6.1\n-\t *\n-\t * @return bool false = Core's icon not available || true = Core's icon is available\n-\t */\n-\tpublic static function jetpack_site_icon_available_in_core() {\n-\t\tglobal $wp_version;\n-\t\t$core_icon_available = function_exists( 'has_site_icon' ) && version_compare( $wp_version, '4.3-beta' ) >= 0;\n-\n-\t\tif ( ! $core_icon_available ) {\n-\t\t\treturn false;\n-\t\t}\n-\n-\t\t// No need for Jetpack's site icon anymore if core's is already set\n-\t\tif ( has_site_icon() ) {\n-\t\t\tif ( Jetpack::is_module_active( 'site-icon' ) ) {\n-\t\t\t\tJetpack::log( 'deactivate', 'site-icon' );\n-\t\t\t\tJetpack::deactivate_module( 'site-icon' );\n-\t\t\t}\n-\t\t\treturn true;\n-\t\t}\n-\n-\t\t// Transfer Jetpack's site icon to use core.\n-\t\t$site_icon_id = Jetpack::get_option( 'site_icon_id' );","path":"class.jetpack.php","position":51,"original_position":51,"commit_id":"0229e790a8d9b323289dfb984e5a731cf5a22e44","original_commit_id":"e3eef69f5a6f9be6fcb515cac34fc7800387b180","user":{"login":"dereksmart","id":7129409,"avatar_url":"https://avatars.githubusercontent.com/u/7129409?v=3","gravatar_id":"","url":"https://api.github.com/users/dereksmart","html_url":"https://github.com/dereksmart","followers_url":"https://api.github.com/users/dereksmart/followers","following_url":"https://api.github.com/users/dereksmart/following{/other_user}","gists_url":"https://api.github.com/users/dereksmart/gists{/gist_id}","starred_url":"https://api.github.com/users/dereksmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dereksmart/subscriptions","organizations_url":"https://api.github.com/users/dereksmart/orgs","repos_url":"https://api.github.com/users/dereksmart/repos","events_url":"https://api.github.com/users/dereksmart/events{/privacy}","received_events_url":"https://api.github.com/users/dereksmart/received_events","type":"User","site_admin":false},"body":"How long do we give them?  It'll be 6 months in January.  ","created_at":"2015-12-19T13:57:17Z","updated_at":"2015-12-19T13:57:17Z","html_url":"https://github.com/Automattic/jetpack/pull/3156#discussion_r48092582","pull_request_url":"https://api.github.com/repos/Automattic/jetpack/pulls/3156","_links":{"self":{"href":"https://api.github.com/repos/Automattic/jetpack/pulls/comments/48092582"},"html":{"href":"https://github.com/Automattic/jetpack/pull/3156#discussion_r48092582"},"pull_request":{"href":"https://api.github.com/repos/Automattic/jetpack/pulls/3156"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/jetpack/pulls/3156","id":53750585,"html_url":"https://github.com/Automattic/jetpack/pull/3156","diff_url":"https://github.com/Automattic/jetpack/pull/3156.diff","patch_url":"https://github.com/Automattic/jetpack/pull/3156.patch","issue_url":"https://api.github.com/repos/Automattic/jetpack/issues/3156","number":3156,"state":"open","locked":false,"title":"Site Icon: Remove all traces","user":{"login":"dereksmart","id":7129409,"avatar_url":"https://avatars.githubusercontent.com/u/7129409?v=3","gravatar_id":"","url":"https://api.github.com/users/dereksmart","html_url":"https://github.com/dereksmart","followers_url":"https://api.github.com/users/dereksmart/followers","following_url":"https://api.github.com/users/dereksmart/following{/other_user}","gists_url":"https://api.github.com/users/dereksmart/gists{/gist_id}","starred_url":"https://api.github.com/users/dereksmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dereksmart/subscriptions","organizations_url":"https://api.github.com/users/dereksmart/orgs","repos_url":"https://api.github.com/users/dereksmart/repos","events_url":"https://api.github.com/users/dereksmart/events{/privacy}","received_events_url":"https://api.github.com/users/dereksmart/received_events","type":"User","site_admin":false},"body":"Fixes #3073\r\n\r\nTo be merged when 4.3 is minimum.  \r\n\r\nRemoves all traces of jetpack's Site Icon code.  In places like opengraph, post images, twitter cards, etc, I've changed it to use core's methods.  \r\n\r\nIt should be removed from our settings table completely and please test to make sure that your Icon is still working in Calypso as well.  ","created_at":"2015-12-15T19:34:01Z","updated_at":"2015-12-19T13:57:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77de98423321dcd24d6c5d095bcd434ebadc5b05","assignee":null,"milestone":{"url":"https://api.github.com/repos/Automattic/jetpack/milestones/30","html_url":"https://github.com/Automattic/jetpack/milestones/3.9","labels_url":"https://api.github.com/repos/Automattic/jetpack/milestones/30/labels","id":1332406,"number":30,"title":"3.9","description":null,"creator":{"login":"kraftbj","id":88897,"avatar_url":"https://avatars.githubusercontent.com/u/88897?v=3","gravatar_id":"","url":"https://api.github.com/users/kraftbj","html_url":"https://github.com/kraftbj","followers_url":"https://api.github.com/users/kraftbj/followers","following_url":"https://api.github.com/users/kraftbj/following{/other_user}","gists_url":"https://api.github.com/users/kraftbj/gists{/gist_id}","starred_url":"https://api.github.com/users/kraftbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kraftbj/subscriptions","organizations_url":"https://api.github.com/users/kraftbj/orgs","repos_url":"https://api.github.com/users/kraftbj/repos","events_url":"https://api.github.com/users/kraftbj/events{/privacy}","received_events_url":"https://api.github.com/users/kraftbj/received_events","type":"User","site_admin":false},"open_issues":167,"closed_issues":15,"state":"open","created_at":"2015-10-01T01:30:05Z","updated_at":"2015-12-18T23:00:19Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Automattic/jetpack/pulls/3156/commits","review_comments_url":"https://api.github.com/repos/Automattic/jetpack/pulls/3156/comments","review_comment_url":"https://api.github.com/repos/Automattic/jetpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/jetpack/issues/3156/comments","statuses_url":"https://api.github.com/repos/Automattic/jetpack/statuses/0229e790a8d9b323289dfb984e5a731cf5a22e44","head":{"label":"Automattic:update/remove-site-icon-code","ref":"update/remove-site-icon-code","sha":"0229e790a8d9b323289dfb984e5a731cf5a22e44","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":15231212,"name":"jetpack","full_name":"Automattic/jetpack","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/jetpack","description":"Your WordPress, Streamlined.","fork":false,"url":"https://api.github.com/repos/Automattic/jetpack","forks_url":"https://api.github.com/repos/Automattic/jetpack/forks","keys_url":"https://api.github.com/repos/Automattic/jetpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/jetpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/jetpack/teams","hooks_url":"https://api.github.com/repos/Automattic/jetpack/hooks","issue_events_url":"https://api.github.com/repos/Automattic/jetpack/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/jetpack/events","assignees_url":"https://api.github.com/repos/Automattic/jetpack/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/jetpack/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/jetpack/tags","blobs_url":"https://api.github.com/repos/Automattic/jetpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/jetpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/jetpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/jetpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/jetpack/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/jetpack/languages","stargazers_url":"https://api.github.com/repos/Automattic/jetpack/stargazers","contributors_url":"https://api.github.com/repos/Automattic/jetpack/contributors","subscribers_url":"https://api.github.com/repos/Automattic/jetpack/subscribers","subscription_url":"https://api.github.com/repos/Automattic/jetpack/subscription","commits_url":"https://api.github.com/repos/Automattic/jetpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/jetpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/jetpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/jetpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/jetpack/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/jetpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/jetpack/merges","archive_url":"https://api.github.com/repos/Automattic/jetpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/jetpack/downloads","issues_url":"https://api.github.com/repos/Automattic/jetpack/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/jetpack/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/jetpack/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/jetpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/jetpack/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/jetpack/releases{/id}","created_at":"2013-12-16T16:43:01Z","updated_at":"2015-12-19T01:30:19Z","pushed_at":"2015-12-19T12:45:21Z","git_url":"git://github.com/Automattic/jetpack.git","ssh_url":"git@github.com:Automattic/jetpack.git","clone_url":"https://github.com/Automattic/jetpack.git","svn_url":"https://github.com/Automattic/jetpack","homepage":"http://jetpack.me","size":72262,"stargazers_count":475,"watchers_count":475,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":293,"mirror_url":null,"open_issues_count":659,"forks":293,"open_issues":659,"watchers":475,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"02cdec6a4ff78e913bf027d099344989ff6d684e","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":15231212,"name":"jetpack","full_name":"Automattic/jetpack","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/jetpack","description":"Your WordPress, Streamlined.","fork":false,"url":"https://api.github.com/repos/Automattic/jetpack","forks_url":"https://api.github.com/repos/Automattic/jetpack/forks","keys_url":"https://api.github.com/repos/Automattic/jetpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/jetpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/jetpack/teams","hooks_url":"https://api.github.com/repos/Automattic/jetpack/hooks","issue_events_url":"https://api.github.com/repos/Automattic/jetpack/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/jetpack/events","assignees_url":"https://api.github.com/repos/Automattic/jetpack/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/jetpack/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/jetpack/tags","blobs_url":"https://api.github.com/repos/Automattic/jetpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/jetpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/jetpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/jetpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/jetpack/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/jetpack/languages","stargazers_url":"https://api.github.com/repos/Automattic/jetpack/stargazers","contributors_url":"https://api.github.com/repos/Automattic/jetpack/contributors","subscribers_url":"https://api.github.com/repos/Automattic/jetpack/subscribers","subscription_url":"https://api.github.com/repos/Automattic/jetpack/subscription","commits_url":"https://api.github.com/repos/Automattic/jetpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/jetpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/jetpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/jetpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/jetpack/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/jetpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/jetpack/merges","archive_url":"https://api.github.com/repos/Automattic/jetpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/jetpack/downloads","issues_url":"https://api.github.com/repos/Automattic/jetpack/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/jetpack/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/jetpack/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/jetpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/jetpack/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/jetpack/releases{/id}","created_at":"2013-12-16T16:43:01Z","updated_at":"2015-12-19T01:30:19Z","pushed_at":"2015-12-19T12:45:21Z","git_url":"git://github.com/Automattic/jetpack.git","ssh_url":"git@github.com:Automattic/jetpack.git","clone_url":"https://github.com/Automattic/jetpack.git","svn_url":"https://github.com/Automattic/jetpack","homepage":"http://jetpack.me","size":72262,"stargazers_count":475,"watchers_count":475,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":293,"mirror_url":null,"open_issues_count":659,"forks":293,"open_issues":659,"watchers":475,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/jetpack/pulls/3156"},"html":{"href":"https://github.com/Automattic/jetpack/pull/3156"},"issue":{"href":"https://api.github.com/repos/Automattic/jetpack/issues/3156"},"comments":{"href":"https://api.github.com/repos/Automattic/jetpack/issues/3156/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/jetpack/pulls/3156/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/jetpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/jetpack/pulls/3156/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/jetpack/statuses/0229e790a8d9b323289dfb984e5a731cf5a22e44"}}}}