{"action":"created","comment":{"url":"https://api.github.com/repos/deis/workflow/pulls/comments/47934214","id":47934214,"diff_hunk":"@@ -68,7 +68,80 @@\n         \"containers\": [\n           {\n             \"name\": \"$containername\",\n-            \"image\": \"$image\"\n+            \"image\": \"$image\",\n+            \"env\": [\n+            {\n+                \"name\":\"DEIS_APP\",\n+                \"value\":\"$id\"\n+            },\n+            {\n+                \"name\":\"DEIS_RELEASE\",\n+                \"value\":\"$appversion\"\n+            }\n+            ]\n+          }\n+        ]\n+      }\n+    }\n+  }\n+}\n+\"\"\"\n+\n+RCB_TEMPLATE = \"\"\"\\\n+{\n+  \"kind\": \"ReplicationController\",\n+  \"apiVersion\": \"$version\",\n+  \"metadata\": {\n+    \"name\": \"$name\",\n+    \"labels\": {\n+      \"app\": \"$id\",\n+      \"heritage\": \"deis\"\n+    }\n+  },\n+  \"spec\": {\n+    \"replicas\": $num,\n+    \"selector\": {\n+      \"app\": \"$id\",\n+      \"version\": \"$appversion\",\n+      \"type\": \"$type\",\n+      \"heritage\": \"deis\"\n+    },\n+    \"template\": {\n+      \"metadata\": {\n+        \"labels\": {\n+          \"app\": \"$id\",\n+          \"version\": \"$appversion\",\n+          \"type\": \"$type\",\n+          \"heritage\": \"deis\"\n+        }\n+      },\n+      \"spec\": {\n+        \"containers\": [\n+          {\n+            \"name\": \"$containername\",\n+            \"image\": \"smothiki/slugrunner:4\",","path":"rootfs/scheduler/k8s.py","position":65,"original_position":65,"commit_id":"b73692040db4777721c4eaaf073a36c6d458dfe0","original_commit_id":"b73692040db4777721c4eaaf073a36c6d458dfe0","user":{"login":"arschles","id":70865,"avatar_url":"https://avatars.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"body":"looks like we have [slugrunner builds](https://travis-ci.org/deis/slugrunner) working now, so this should be [`quay.io/deisci/slugrunner`](https://quay.io/repository/deisci/slugrunner?tag=latest&tab=tags)","created_at":"2015-12-17T17:27:10Z","updated_at":"2015-12-17T17:27:10Z","html_url":"https://github.com/deis/workflow/pull/95#discussion_r47934214","pull_request_url":"https://api.github.com/repos/deis/workflow/pulls/95","_links":{"self":{"href":"https://api.github.com/repos/deis/workflow/pulls/comments/47934214"},"html":{"href":"https://github.com/deis/workflow/pull/95#discussion_r47934214"},"pull_request":{"href":"https://api.github.com/repos/deis/workflow/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/deis/workflow/pulls/95","id":53789350,"html_url":"https://github.com/deis/workflow/pull/95","diff_url":"https://github.com/deis/workflow/pull/95.diff","patch_url":"https://github.com/deis/workflow/pull/95.patch","issue_url":"https://api.github.com/repos/deis/workflow/issues/95","number":95,"state":"open","locked":false,"title":"feat(workflow): identify app type and move envs to rc templates","user":{"login":"smothiki","id":7416231,"avatar_url":"https://avatars.githubusercontent.com/u/7416231?v=3","gravatar_id":"","url":"https://api.github.com/users/smothiki","html_url":"https://github.com/smothiki","followers_url":"https://api.github.com/users/smothiki/followers","following_url":"https://api.github.com/users/smothiki/following{/other_user}","gists_url":"https://api.github.com/users/smothiki/gists{/gist_id}","starred_url":"https://api.github.com/users/smothiki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smothiki/subscriptions","organizations_url":"https://api.github.com/users/smothiki/orgs","repos_url":"https://api.github.com/users/smothiki/repos","events_url":"https://api.github.com/users/smothiki/events{/privacy}","received_events_url":"https://api.github.com/users/smothiki/received_events","type":"User","site_admin":false},"body":"K8s selects respective RC template based on app type.\r\nDockerfile app types wont go through publish_release function\r\nMoved environment variables to RC templates.\r\n\r\nThe following was added by @arschles on 12/17/2015:\r\nFixes #47","created_at":"2015-12-16T01:51:38Z","updated_at":"2015-12-17T17:27:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2cdda935939fdc6f82c3c64876db983452bb272","assignee":{"login":"smothiki","id":7416231,"avatar_url":"https://avatars.githubusercontent.com/u/7416231?v=3","gravatar_id":"","url":"https://api.github.com/users/smothiki","html_url":"https://github.com/smothiki","followers_url":"https://api.github.com/users/smothiki/followers","following_url":"https://api.github.com/users/smothiki/following{/other_user}","gists_url":"https://api.github.com/users/smothiki/gists{/gist_id}","starred_url":"https://api.github.com/users/smothiki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smothiki/subscriptions","organizations_url":"https://api.github.com/users/smothiki/orgs","repos_url":"https://api.github.com/users/smothiki/repos","events_url":"https://api.github.com/users/smothiki/events{/privacy}","received_events_url":"https://api.github.com/users/smothiki/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/deis/workflow/milestones/1","html_url":"https://github.com/deis/workflow/milestones/v2.0-alpha1","labels_url":"https://api.github.com/repos/deis/workflow/milestones/1/labels","id":1409407,"number":1,"title":"v2.0-alpha1","description":"","creator":{"login":"slack","id":28873,"avatar_url":"https://avatars.githubusercontent.com/u/28873?v=3","gravatar_id":"","url":"https://api.github.com/users/slack","html_url":"https://github.com/slack","followers_url":"https://api.github.com/users/slack/followers","following_url":"https://api.github.com/users/slack/following{/other_user}","gists_url":"https://api.github.com/users/slack/gists{/gist_id}","starred_url":"https://api.github.com/users/slack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slack/subscriptions","organizations_url":"https://api.github.com/users/slack/orgs","repos_url":"https://api.github.com/users/slack/repos","events_url":"https://api.github.com/users/slack/events{/privacy}","received_events_url":"https://api.github.com/users/slack/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":50,"state":"open","created_at":"2015-11-12T22:39:15Z","updated_at":"2015-12-17T17:10:47Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/deis/workflow/pulls/95/commits","review_comments_url":"https://api.github.com/repos/deis/workflow/pulls/95/comments","review_comment_url":"https://api.github.com/repos/deis/workflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deis/workflow/issues/95/comments","statuses_url":"https://api.github.com/repos/deis/workflow/statuses/b73692040db4777721c4eaaf073a36c6d458dfe0","head":{"label":"smothiki:newbuild","ref":"newbuild","sha":"b73692040db4777721c4eaaf073a36c6d458dfe0","user":{"login":"smothiki","id":7416231,"avatar_url":"https://avatars.githubusercontent.com/u/7416231?v=3","gravatar_id":"","url":"https://api.github.com/users/smothiki","html_url":"https://github.com/smothiki","followers_url":"https://api.github.com/users/smothiki/followers","following_url":"https://api.github.com/users/smothiki/following{/other_user}","gists_url":"https://api.github.com/users/smothiki/gists{/gist_id}","starred_url":"https://api.github.com/users/smothiki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smothiki/subscriptions","organizations_url":"https://api.github.com/users/smothiki/orgs","repos_url":"https://api.github.com/users/smothiki/repos","events_url":"https://api.github.com/users/smothiki/events{/privacy}","received_events_url":"https://api.github.com/users/smothiki/received_events","type":"User","site_admin":false},"repo":{"id":46741350,"name":"workflow","full_name":"smothiki/workflow","owner":{"login":"smothiki","id":7416231,"avatar_url":"https://avatars.githubusercontent.com/u/7416231?v=3","gravatar_id":"","url":"https://api.github.com/users/smothiki","html_url":"https://github.com/smothiki","followers_url":"https://api.github.com/users/smothiki/followers","following_url":"https://api.github.com/users/smothiki/following{/other_user}","gists_url":"https://api.github.com/users/smothiki/gists{/gist_id}","starred_url":"https://api.github.com/users/smothiki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smothiki/subscriptions","organizations_url":"https://api.github.com/users/smothiki/orgs","repos_url":"https://api.github.com/users/smothiki/repos","events_url":"https://api.github.com/users/smothiki/events{/privacy}","received_events_url":"https://api.github.com/users/smothiki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smothiki/workflow","description":"PaaS workflow controller and client for Deis v2","fork":true,"url":"https://api.github.com/repos/smothiki/workflow","forks_url":"https://api.github.com/repos/smothiki/workflow/forks","keys_url":"https://api.github.com/repos/smothiki/workflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smothiki/workflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smothiki/workflow/teams","hooks_url":"https://api.github.com/repos/smothiki/workflow/hooks","issue_events_url":"https://api.github.com/repos/smothiki/workflow/issues/events{/number}","events_url":"https://api.github.com/repos/smothiki/workflow/events","assignees_url":"https://api.github.com/repos/smothiki/workflow/assignees{/user}","branches_url":"https://api.github.com/repos/smothiki/workflow/branches{/branch}","tags_url":"https://api.github.com/repos/smothiki/workflow/tags","blobs_url":"https://api.github.com/repos/smothiki/workflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smothiki/workflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smothiki/workflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/smothiki/workflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smothiki/workflow/statuses/{sha}","languages_url":"https://api.github.com/repos/smothiki/workflow/languages","stargazers_url":"https://api.github.com/repos/smothiki/workflow/stargazers","contributors_url":"https://api.github.com/repos/smothiki/workflow/contributors","subscribers_url":"https://api.github.com/repos/smothiki/workflow/subscribers","subscription_url":"https://api.github.com/repos/smothiki/workflow/subscription","commits_url":"https://api.github.com/repos/smothiki/workflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/smothiki/workflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/smothiki/workflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/smothiki/workflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/smothiki/workflow/contents/{+path}","compare_url":"https://api.github.com/repos/smothiki/workflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smothiki/workflow/merges","archive_url":"https://api.github.com/repos/smothiki/workflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smothiki/workflow/downloads","issues_url":"https://api.github.com/repos/smothiki/workflow/issues{/number}","pulls_url":"https://api.github.com/repos/smothiki/workflow/pulls{/number}","milestones_url":"https://api.github.com/repos/smothiki/workflow/milestones{/number}","notifications_url":"https://api.github.com/repos/smothiki/workflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smothiki/workflow/labels{/name}","releases_url":"https://api.github.com/repos/smothiki/workflow/releases{/id}","created_at":"2015-11-23T18:59:17Z","updated_at":"2015-11-23T18:59:19Z","pushed_at":"2015-12-17T03:10:28Z","git_url":"git://github.com/smothiki/workflow.git","ssh_url":"git@github.com:smothiki/workflow.git","clone_url":"https://github.com/smothiki/workflow.git","svn_url":"https://github.com/smothiki/workflow","homepage":null,"size":14613,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"e4a313429f552af031d0ba80ae8d789a1ab2d748","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":45704630,"name":"workflow","full_name":"deis/workflow","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/workflow","description":"PaaS workflow controller and client for Deis v2","fork":false,"url":"https://api.github.com/repos/deis/workflow","forks_url":"https://api.github.com/repos/deis/workflow/forks","keys_url":"https://api.github.com/repos/deis/workflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/workflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/workflow/teams","hooks_url":"https://api.github.com/repos/deis/workflow/hooks","issue_events_url":"https://api.github.com/repos/deis/workflow/issues/events{/number}","events_url":"https://api.github.com/repos/deis/workflow/events","assignees_url":"https://api.github.com/repos/deis/workflow/assignees{/user}","branches_url":"https://api.github.com/repos/deis/workflow/branches{/branch}","tags_url":"https://api.github.com/repos/deis/workflow/tags","blobs_url":"https://api.github.com/repos/deis/workflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/workflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/workflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/workflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/workflow/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/workflow/languages","stargazers_url":"https://api.github.com/repos/deis/workflow/stargazers","contributors_url":"https://api.github.com/repos/deis/workflow/contributors","subscribers_url":"https://api.github.com/repos/deis/workflow/subscribers","subscription_url":"https://api.github.com/repos/deis/workflow/subscription","commits_url":"https://api.github.com/repos/deis/workflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/workflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/workflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/workflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/deis/workflow/contents/{+path}","compare_url":"https://api.github.com/repos/deis/workflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/workflow/merges","archive_url":"https://api.github.com/repos/deis/workflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/workflow/downloads","issues_url":"https://api.github.com/repos/deis/workflow/issues{/number}","pulls_url":"https://api.github.com/repos/deis/workflow/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/workflow/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/workflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/workflow/labels{/name}","releases_url":"https://api.github.com/repos/deis/workflow/releases{/id}","created_at":"2015-11-06T20:06:05Z","updated_at":"2015-12-07T18:08:48Z","pushed_at":"2015-12-17T16:50:58Z","git_url":"git://github.com/deis/workflow.git","ssh_url":"git@github.com:deis/workflow.git","clone_url":"https://github.com/deis/workflow.git","svn_url":"https://github.com/deis/workflow","homepage":"http://deis.io","size":14682,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":35,"forks":11,"open_issues":35,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/workflow/pulls/95"},"html":{"href":"https://github.com/deis/workflow/pull/95"},"issue":{"href":"https://api.github.com/repos/deis/workflow/issues/95"},"comments":{"href":"https://api.github.com/repos/deis/workflow/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/workflow/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/workflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deis/workflow/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/deis/workflow/statuses/b73692040db4777721c4eaaf073a36c6d458dfe0"}}}}