{"action":"opened","number":124,"pull_request":{"url":"https://api.github.com/repos/guardian/facia-scala-client/pulls/124","id":40779385,"html_url":"https://github.com/guardian/facia-scala-client/pull/124","diff_url":"https://github.com/guardian/facia-scala-client/pull/124.diff","patch_url":"https://github.com/guardian/facia-scala-client/pull/124.patch","issue_url":"https://api.github.com/repos/guardian/facia-scala-client/issues/124","number":124,"state":"open","locked":false,"title":"Remove editors picks from backfill results","user":{"login":"janua","id":445472,"avatar_url":"https://avatars.githubusercontent.com/u/445472?v=3","gravatar_id":"","url":"https://api.github.com/users/janua","html_url":"https://github.com/janua","followers_url":"https://api.github.com/users/janua/followers","following_url":"https://api.github.com/users/janua/following{/other_user}","gists_url":"https://api.github.com/users/janua/gists{/gist_id}","starred_url":"https://api.github.com/users/janua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janua/subscriptions","organizations_url":"https://api.github.com/users/janua/orgs","repos_url":"https://api.github.com/users/janua/repos","events_url":"https://api.github.com/users/janua/events{/privacy}","received_events_url":"https://api.github.com/users/janua/received_events","type":"User","site_admin":false},"body":"TLDR; This forces `show-editors-picks` to be `false` on `backfill` queries.\r\n\r\n\r\n### Problem\r\n\r\nWe are in a bit of a situation on some fronts that aren't massively curated and depend on backfills.\r\n\r\nStep-by-step:\r\n - On frontend, when requesting backfills for a certain `path`, we ask for and **add** `editorsPicks` to the head of the `results` that `CAPI` returns to us.\r\n - We then generate a `lite.json` file from these results.\r\n - `CAPI` now reads this `lite.json` file and puts them into editors picks for the `path`.\r\n - On frontend, when requesting backfills for a certain `path`, we ask for and **add** `editorsPicks` to the head of the `results` that `CAPI` returns to us.\r\n\r\nIt's completely circular and confusing. We did sort this for some situations in the past, but this is what is left of it.\r\n\r\nWe have realised we definitely do not need `editorsPicks` anywhere near this library, as this library IS `editorsPicks`. Are you confused yet?\r\n\r\n### Background\r\n##### Why were we adding `editorsPicks` to the head of the list?\r\n\r\nAdding `editorsPicks` to the head of the results like this worked fine and as expected up until we were the `editorPicks`. Before, `editorsPicks` came from `r2-admin`.\r\n\r\nWe always could see the circular dependency coming, and this is the last of it.\r\n\r\n### Fix\r\n\r\nRemove `editors-picks` from `facia-scala-client`. This will break the cycle.\r\n\r\n@piuccio @stephanfowler @mchv ","created_at":"2015-07-24T14:19:31Z","updated_at":"2015-07-24T14:19:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/facia-scala-client/pulls/124/commits","review_comments_url":"https://api.github.com/repos/guardian/facia-scala-client/pulls/124/comments","review_comment_url":"https://api.github.com/repos/guardian/facia-scala-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/facia-scala-client/issues/124/comments","statuses_url":"https://api.github.com/repos/guardian/facia-scala-client/statuses/56143941d59f4eee9e9809246d9c16ab0ed73495","head":{"label":"guardian:remove-editors-picks","ref":"remove-editors-picks","sha":"56143941d59f4eee9e9809246d9c16ab0ed73495","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":20723151,"name":"facia-scala-client","full_name":"guardian/facia-scala-client","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/facia-scala-client","description":"Low level client for the Facia JSON API","fork":false,"url":"https://api.github.com/repos/guardian/facia-scala-client","forks_url":"https://api.github.com/repos/guardian/facia-scala-client/forks","keys_url":"https://api.github.com/repos/guardian/facia-scala-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/facia-scala-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/facia-scala-client/teams","hooks_url":"https://api.github.com/repos/guardian/facia-scala-client/hooks","issue_events_url":"https://api.github.com/repos/guardian/facia-scala-client/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/facia-scala-client/events","assignees_url":"https://api.github.com/repos/guardian/facia-scala-client/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/facia-scala-client/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/facia-scala-client/tags","blobs_url":"https://api.github.com/repos/guardian/facia-scala-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/facia-scala-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/facia-scala-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/facia-scala-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/facia-scala-client/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/facia-scala-client/languages","stargazers_url":"https://api.github.com/repos/guardian/facia-scala-client/stargazers","contributors_url":"https://api.github.com/repos/guardian/facia-scala-client/contributors","subscribers_url":"https://api.github.com/repos/guardian/facia-scala-client/subscribers","subscription_url":"https://api.github.com/repos/guardian/facia-scala-client/subscription","commits_url":"https://api.github.com/repos/guardian/facia-scala-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/facia-scala-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/facia-scala-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/facia-scala-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/facia-scala-client/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/facia-scala-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/facia-scala-client/merges","archive_url":"https://api.github.com/repos/guardian/facia-scala-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/facia-scala-client/downloads","issues_url":"https://api.github.com/repos/guardian/facia-scala-client/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/facia-scala-client/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/facia-scala-client/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/facia-scala-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/facia-scala-client/labels{/name}","releases_url":"https://api.github.com/repos/guardian/facia-scala-client/releases{/id}","created_at":"2014-06-11T11:45:55Z","updated_at":"2015-05-08T14:47:52Z","pushed_at":"2015-07-24T14:03:00Z","git_url":"git://github.com/guardian/facia-scala-client.git","ssh_url":"git@github.com:guardian/facia-scala-client.git","clone_url":"https://github.com/guardian/facia-scala-client.git","svn_url":"https://github.com/guardian/facia-scala-client","homepage":null,"size":2568,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":0,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"ee09d0ec39416b8f9c07d17bae104161bde4654a","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":20723151,"name":"facia-scala-client","full_name":"guardian/facia-scala-client","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/facia-scala-client","description":"Low level client for the Facia JSON API","fork":false,"url":"https://api.github.com/repos/guardian/facia-scala-client","forks_url":"https://api.github.com/repos/guardian/facia-scala-client/forks","keys_url":"https://api.github.com/repos/guardian/facia-scala-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/facia-scala-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/facia-scala-client/teams","hooks_url":"https://api.github.com/repos/guardian/facia-scala-client/hooks","issue_events_url":"https://api.github.com/repos/guardian/facia-scala-client/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/facia-scala-client/events","assignees_url":"https://api.github.com/repos/guardian/facia-scala-client/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/facia-scala-client/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/facia-scala-client/tags","blobs_url":"https://api.github.com/repos/guardian/facia-scala-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/facia-scala-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/facia-scala-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/facia-scala-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/facia-scala-client/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/facia-scala-client/languages","stargazers_url":"https://api.github.com/repos/guardian/facia-scala-client/stargazers","contributors_url":"https://api.github.com/repos/guardian/facia-scala-client/contributors","subscribers_url":"https://api.github.com/repos/guardian/facia-scala-client/subscribers","subscription_url":"https://api.github.com/repos/guardian/facia-scala-client/subscription","commits_url":"https://api.github.com/repos/guardian/facia-scala-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/facia-scala-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/facia-scala-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/facia-scala-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/facia-scala-client/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/facia-scala-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/facia-scala-client/merges","archive_url":"https://api.github.com/repos/guardian/facia-scala-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/facia-scala-client/downloads","issues_url":"https://api.github.com/repos/guardian/facia-scala-client/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/facia-scala-client/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/facia-scala-client/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/facia-scala-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/facia-scala-client/labels{/name}","releases_url":"https://api.github.com/repos/guardian/facia-scala-client/releases{/id}","created_at":"2014-06-11T11:45:55Z","updated_at":"2015-05-08T14:47:52Z","pushed_at":"2015-07-24T14:03:00Z","git_url":"git://github.com/guardian/facia-scala-client.git","ssh_url":"git@github.com:guardian/facia-scala-client.git","clone_url":"https://github.com/guardian/facia-scala-client.git","svn_url":"https://github.com/guardian/facia-scala-client","homepage":null,"size":2568,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/facia-scala-client/pulls/124"},"html":{"href":"https://github.com/guardian/facia-scala-client/pull/124"},"issue":{"href":"https://api.github.com/repos/guardian/facia-scala-client/issues/124"},"comments":{"href":"https://api.github.com/repos/guardian/facia-scala-client/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/facia-scala-client/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/facia-scala-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/facia-scala-client/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/facia-scala-client/statuses/56143941d59f4eee9e9809246d9c16ab0ed73495"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":11,"deletions":21,"changed_files":2}}