{"action":"created","issue":{"url":"https://api.github.com/repos/StackStorm/st2/issues/1003","labels_url":"https://api.github.com/repos/StackStorm/st2/issues/1003/labels{/name}","comments_url":"https://api.github.com/repos/StackStorm/st2/issues/1003/comments","events_url":"https://api.github.com/repos/StackStorm/st2/issues/1003/events","html_url":"https://github.com/StackStorm/st2/pull/1003","id":54981241,"number":1003,"title":"WIP: Actionchain improvements","user":{"login":"manasdk","id":1776099,"avatar_url":"https://avatars.githubusercontent.com/u/1776099?v=3","gravatar_id":"","url":"https://api.github.com/users/manasdk","html_url":"https://github.com/manasdk","followers_url":"https://api.github.com/users/manasdk/followers","following_url":"https://api.github.com/users/manasdk/following{/other_user}","gists_url":"https://api.github.com/users/manasdk/gists{/gist_id}","starred_url":"https://api.github.com/users/manasdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manasdk/subscriptions","organizations_url":"https://api.github.com/users/manasdk/orgs","repos_url":"https://api.github.com/users/manasdk/repos","events_url":"https://api.github.com/users/manasdk/events{/privacy}","received_events_url":"https://api.github.com/users/manasdk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-01-21T06:04:08Z","updated_at":"2015-01-22T16:14:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/StackStorm/st2/pulls/1003","html_url":"https://github.com/StackStorm/st2/pull/1003","diff_url":"https://github.com/StackStorm/st2/pull/1003.diff","patch_url":"https://github.com/StackStorm/st2/pull/1003.patch"},"body":"- Proper schema for ActionChain\r\n- Schema validation catches malformed yaml/json\r\n- default node is now optional\r\n- support for vars\r\n```\r\n{\r\n    \"vars\": {\r\n        \"strtype\": \"{{system.a}}\",\r\n        \"inttype\": 1\r\n    },\r\n    \"chain\": [\r\n        {\r\n            \"name\": \"c1\",\r\n            \"ref\": \"wolfpack.a2\",\r\n            \"params\":\r\n            {\r\n                \"inttype\": \"{{inttype}}\",\r\n                \"strtype\": \"{{strtype}}\",\r\n                \"booltype\": true\r\n            }\r\n        }\r\n    ],\r\n    \"default\": \"c1\"\r\n}\r\n```\r\n- support for output variable per action_node\r\n```\r\n{\r\n    \"chain\": [\r\n        {\r\n            \"name\": \"c1\",\r\n            \"ref\": \"wolfpack.a2\",\r\n            \"params\":\r\n            {\r\n                \"inttype\": \"{{inttype}}\",\r\n                \"strtype\": \"{{strtype}}\",\r\n                \"booltype\": true\r\n            },\r\n            \"output\":\r\n            {\r\n                \"o1\": \"{{c1.foo.bar}}\"\r\n            },\r\n            \"on-success\": \"c2\"\r\n        },\r\n        {\r\n            \"name\": \"c2\",\r\n            \"ref\": \"wolfpack.a2\",\r\n            \"params\":\r\n            {\r\n                \"strtype\": \"{{c1.o1}}\"\r\n            }\r\n        }\r\n    ],\r\n    \"default\": \"c1\"\r\n}\r\n```\r\nNote : Full result of `c1` is no longer available since c1 is publishing output."},"comment":{"url":"https://api.github.com/repos/StackStorm/st2/issues/comments/71046168","html_url":"https://github.com/StackStorm/st2/pull/1003#issuecomment-71046168","issue_url":"https://api.github.com/repos/StackStorm/st2/issues/1003","id":71046168,"user":{"login":"jfryman","id":20028,"avatar_url":"https://avatars.githubusercontent.com/u/20028?v=3","gravatar_id":"","url":"https://api.github.com/users/jfryman","html_url":"https://github.com/jfryman","followers_url":"https://api.github.com/users/jfryman/followers","following_url":"https://api.github.com/users/jfryman/following{/other_user}","gists_url":"https://api.github.com/users/jfryman/gists{/gist_id}","starred_url":"https://api.github.com/users/jfryman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfryman/subscriptions","organizations_url":"https://api.github.com/users/jfryman/orgs","repos_url":"https://api.github.com/users/jfryman/repos","events_url":"https://api.github.com/users/jfryman/events{/privacy}","received_events_url":"https://api.github.com/users/jfryman/received_events","type":"User","site_admin":false},"created_at":"2015-01-22T16:14:34Z","updated_at":"2015-01-22T16:14:34Z","body":"> Before we switch to input we must consider the lack of internal consistency.\r\n\r\nI was actually going to mention this, but the disconnect between AC's `params` and `parameters` used everywhere else in the codebase is noticeably annoying when developing.  Now, I realize words mean something, but just the fact that the same usage is used (even slightly differently) is yet another thing a new user needs to keep in their head. I would rather use the wrong word everywhere, than have multiple right words.\r\n\r\nIf you are going to change `params` to anything, I would strongly suggest `parameters`. I do realize that `mistral` uses the `input`/`output` verbs, but that is an integration versus a native component. Because of this, I am inclined to say that the delta in verbs is okay... it's only natural that external tools will model things slightly differently. However, AC is native, and I think internal consistency is merited in this case. \r\n\r\n$0.02"}}