{"action":"closed","number":926,"pull_request":{"url":"https://api.github.com/repos/Reactive-Extensions/RxJS/pulls/926","id":45597811,"html_url":"https://github.com/Reactive-Extensions/RxJS/pull/926","diff_url":"https://github.com/Reactive-Extensions/RxJS/pull/926.diff","patch_url":"https://github.com/Reactive-Extensions/RxJS/pull/926.patch","issue_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/issues/926","number":926,"state":"closed","locked":false,"title":"TS: Fixed optional arguments on fromnodecallback","user":{"login":"david-driscoll","id":1269157,"avatar_url":"https://avatars.githubusercontent.com/u/1269157?v=3","gravatar_id":"","url":"https://api.github.com/users/david-driscoll","html_url":"https://github.com/david-driscoll","followers_url":"https://api.github.com/users/david-driscoll/followers","following_url":"https://api.github.com/users/david-driscoll/following{/other_user}","gists_url":"https://api.github.com/users/david-driscoll/gists{/gist_id}","starred_url":"https://api.github.com/users/david-driscoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-driscoll/subscriptions","organizations_url":"https://api.github.com/users/david-driscoll/orgs","repos_url":"https://api.github.com/users/david-driscoll/repos","events_url":"https://api.github.com/users/david-driscoll/events{/privacy}","received_events_url":"https://api.github.com/users/david-driscoll/received_events","type":"User","site_admin":false},"body":"Fixes #922.\r\n\r\nApparently only the first definition was missing the optional arguments.","created_at":"2015-09-21T20:46:46Z","updated_at":"2015-09-21T20:56:42Z","closed_at":"2015-09-21T20:56:42Z","merged_at":"2015-09-21T20:56:42Z","merge_commit_sha":"46007a92cc1555d0614a2e00dfa2154295eec0f1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/pulls/926/commits","review_comments_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/pulls/926/comments","review_comment_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/issues/926/comments","statuses_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/statuses/a7a3cf6f84ca70ac9a5a68fc41a860af46e33d21","head":{"label":"david-driscoll:master","ref":"master","sha":"a7a3cf6f84ca70ac9a5a68fc41a860af46e33d21","user":{"login":"david-driscoll","id":1269157,"avatar_url":"https://avatars.githubusercontent.com/u/1269157?v=3","gravatar_id":"","url":"https://api.github.com/users/david-driscoll","html_url":"https://github.com/david-driscoll","followers_url":"https://api.github.com/users/david-driscoll/followers","following_url":"https://api.github.com/users/david-driscoll/following{/other_user}","gists_url":"https://api.github.com/users/david-driscoll/gists{/gist_id}","starred_url":"https://api.github.com/users/david-driscoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-driscoll/subscriptions","organizations_url":"https://api.github.com/users/david-driscoll/orgs","repos_url":"https://api.github.com/users/david-driscoll/repos","events_url":"https://api.github.com/users/david-driscoll/events{/privacy}","received_events_url":"https://api.github.com/users/david-driscoll/received_events","type":"User","site_admin":false},"repo":{"id":40214448,"name":"RxJS","full_name":"david-driscoll/RxJS","owner":{"login":"david-driscoll","id":1269157,"avatar_url":"https://avatars.githubusercontent.com/u/1269157?v=3","gravatar_id":"","url":"https://api.github.com/users/david-driscoll","html_url":"https://github.com/david-driscoll","followers_url":"https://api.github.com/users/david-driscoll/followers","following_url":"https://api.github.com/users/david-driscoll/following{/other_user}","gists_url":"https://api.github.com/users/david-driscoll/gists{/gist_id}","starred_url":"https://api.github.com/users/david-driscoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-driscoll/subscriptions","organizations_url":"https://api.github.com/users/david-driscoll/orgs","repos_url":"https://api.github.com/users/david-driscoll/repos","events_url":"https://api.github.com/users/david-driscoll/events{/privacy}","received_events_url":"https://api.github.com/users/david-driscoll/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/david-driscoll/RxJS","description":"The Reactive Extensions for JavaScript","fork":true,"url":"https://api.github.com/repos/david-driscoll/RxJS","forks_url":"https://api.github.com/repos/david-driscoll/RxJS/forks","keys_url":"https://api.github.com/repos/david-driscoll/RxJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/david-driscoll/RxJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/david-driscoll/RxJS/teams","hooks_url":"https://api.github.com/repos/david-driscoll/RxJS/hooks","issue_events_url":"https://api.github.com/repos/david-driscoll/RxJS/issues/events{/number}","events_url":"https://api.github.com/repos/david-driscoll/RxJS/events","assignees_url":"https://api.github.com/repos/david-driscoll/RxJS/assignees{/user}","branches_url":"https://api.github.com/repos/david-driscoll/RxJS/branches{/branch}","tags_url":"https://api.github.com/repos/david-driscoll/RxJS/tags","blobs_url":"https://api.github.com/repos/david-driscoll/RxJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/david-driscoll/RxJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/david-driscoll/RxJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/david-driscoll/RxJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/david-driscoll/RxJS/statuses/{sha}","languages_url":"https://api.github.com/repos/david-driscoll/RxJS/languages","stargazers_url":"https://api.github.com/repos/david-driscoll/RxJS/stargazers","contributors_url":"https://api.github.com/repos/david-driscoll/RxJS/contributors","subscribers_url":"https://api.github.com/repos/david-driscoll/RxJS/subscribers","subscription_url":"https://api.github.com/repos/david-driscoll/RxJS/subscription","commits_url":"https://api.github.com/repos/david-driscoll/RxJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/david-driscoll/RxJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/david-driscoll/RxJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/david-driscoll/RxJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/david-driscoll/RxJS/contents/{+path}","compare_url":"https://api.github.com/repos/david-driscoll/RxJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/david-driscoll/RxJS/merges","archive_url":"https://api.github.com/repos/david-driscoll/RxJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/david-driscoll/RxJS/downloads","issues_url":"https://api.github.com/repos/david-driscoll/RxJS/issues{/number}","pulls_url":"https://api.github.com/repos/david-driscoll/RxJS/pulls{/number}","milestones_url":"https://api.github.com/repos/david-driscoll/RxJS/milestones{/number}","notifications_url":"https://api.github.com/repos/david-driscoll/RxJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/david-driscoll/RxJS/labels{/name}","releases_url":"https://api.github.com/repos/david-driscoll/RxJS/releases{/id}","created_at":"2015-08-04T23:43:08Z","updated_at":"2015-08-04T23:43:13Z","pushed_at":"2015-09-21T20:44:11Z","git_url":"git://github.com/david-driscoll/RxJS.git","ssh_url":"git@github.com:david-driscoll/RxJS.git","clone_url":"https://github.com/david-driscoll/RxJS.git","svn_url":"https://github.com/david-driscoll/RxJS","homepage":"http://reactivex.io","size":51756,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Reactive-Extensions:master","ref":"master","sha":"0512c348a1a2b3edaa64a6b1d022067640d8a734","user":{"login":"Reactive-Extensions","id":984368,"avatar_url":"https://avatars.githubusercontent.com/u/984368?v=3","gravatar_id":"","url":"https://api.github.com/users/Reactive-Extensions","html_url":"https://github.com/Reactive-Extensions","followers_url":"https://api.github.com/users/Reactive-Extensions/followers","following_url":"https://api.github.com/users/Reactive-Extensions/following{/other_user}","gists_url":"https://api.github.com/users/Reactive-Extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/Reactive-Extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reactive-Extensions/subscriptions","organizations_url":"https://api.github.com/users/Reactive-Extensions/orgs","repos_url":"https://api.github.com/users/Reactive-Extensions/repos","events_url":"https://api.github.com/users/Reactive-Extensions/events{/privacy}","received_events_url":"https://api.github.com/users/Reactive-Extensions/received_events","type":"Organization","site_admin":false},"repo":{"id":3122202,"name":"RxJS","full_name":"Reactive-Extensions/RxJS","owner":{"login":"Reactive-Extensions","id":984368,"avatar_url":"https://avatars.githubusercontent.com/u/984368?v=3","gravatar_id":"","url":"https://api.github.com/users/Reactive-Extensions","html_url":"https://github.com/Reactive-Extensions","followers_url":"https://api.github.com/users/Reactive-Extensions/followers","following_url":"https://api.github.com/users/Reactive-Extensions/following{/other_user}","gists_url":"https://api.github.com/users/Reactive-Extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/Reactive-Extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reactive-Extensions/subscriptions","organizations_url":"https://api.github.com/users/Reactive-Extensions/orgs","repos_url":"https://api.github.com/users/Reactive-Extensions/repos","events_url":"https://api.github.com/users/Reactive-Extensions/events{/privacy}","received_events_url":"https://api.github.com/users/Reactive-Extensions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Reactive-Extensions/RxJS","description":"The Reactive Extensions for JavaScript","fork":false,"url":"https://api.github.com/repos/Reactive-Extensions/RxJS","forks_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/forks","keys_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/teams","hooks_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/hooks","issue_events_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/issues/events{/number}","events_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/events","assignees_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/assignees{/user}","branches_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/branches{/branch}","tags_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/tags","blobs_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/statuses/{sha}","languages_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/languages","stargazers_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/stargazers","contributors_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/contributors","subscribers_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/subscribers","subscription_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/subscription","commits_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/contents/{+path}","compare_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/merges","archive_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/downloads","issues_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/issues{/number}","pulls_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/pulls{/number}","milestones_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/milestones{/number}","notifications_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/labels{/name}","releases_url":"https://api.github.com/repos/Reactive-Extensions/RxJS/releases{/id}","created_at":"2012-01-07T00:31:41Z","updated_at":"2015-09-21T20:31:41Z","pushed_at":"2015-09-21T20:56:42Z","git_url":"git://github.com/Reactive-Extensions/RxJS.git","ssh_url":"git@github.com:Reactive-Extensions/RxJS.git","clone_url":"https://github.com/Reactive-Extensions/RxJS.git","svn_url":"https://github.com/Reactive-Extensions/RxJS","homepage":"http://reactivex.io","size":68365,"stargazers_count":5636,"watchers_count":5636,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":568,"mirror_url":null,"open_issues_count":27,"forks":568,"open_issues":27,"watchers":5636,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Reactive-Extensions/RxJS/pulls/926"},"html":{"href":"https://github.com/Reactive-Extensions/RxJS/pull/926"},"issue":{"href":"https://api.github.com/repos/Reactive-Extensions/RxJS/issues/926"},"comments":{"href":"https://api.github.com/repos/Reactive-Extensions/RxJS/issues/926/comments"},"review_comments":{"href":"https://api.github.com/repos/Reactive-Extensions/RxJS/pulls/926/comments"},"review_comment":{"href":"https://api.github.com/repos/Reactive-Extensions/RxJS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Reactive-Extensions/RxJS/pulls/926/commits"},"statuses":{"href":"https://api.github.com/repos/Reactive-Extensions/RxJS/statuses/a7a3cf6f84ca70ac9a5a68fc41a860af46e33d21"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mattpodwysocki","id":49051,"avatar_url":"https://avatars.githubusercontent.com/u/49051?v=3","gravatar_id":"","url":"https://api.github.com/users/mattpodwysocki","html_url":"https://github.com/mattpodwysocki","followers_url":"https://api.github.com/users/mattpodwysocki/followers","following_url":"https://api.github.com/users/mattpodwysocki/following{/other_user}","gists_url":"https://api.github.com/users/mattpodwysocki/gists{/gist_id}","starred_url":"https://api.github.com/users/mattpodwysocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattpodwysocki/subscriptions","organizations_url":"https://api.github.com/users/mattpodwysocki/orgs","repos_url":"https://api.github.com/users/mattpodwysocki/repos","events_url":"https://api.github.com/users/mattpodwysocki/events{/privacy}","received_events_url":"https://api.github.com/users/mattpodwysocki/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}