{"action":"created","issue":{"url":"https://api.github.com/repos/prestodb/presto-admin/issues/38","labels_url":"https://api.github.com/repos/prestodb/presto-admin/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/prestodb/presto-admin/issues/38/comments","events_url":"https://api.github.com/repos/prestodb/presto-admin/issues/38/events","html_url":"https://github.com/prestodb/presto-admin/pull/38","id":102159341,"number":38,"title":"presto-admin: make presto-admin parse teradata versions","user":{"login":"arhimondr","id":5570988,"avatar_url":"https://avatars.githubusercontent.com/u/5570988?v=3","gravatar_id":"","url":"https://api.github.com/users/arhimondr","html_url":"https://github.com/arhimondr","followers_url":"https://api.github.com/users/arhimondr/followers","following_url":"https://api.github.com/users/arhimondr/following{/other_user}","gists_url":"https://api.github.com/users/arhimondr/gists{/gist_id}","starred_url":"https://api.github.com/users/arhimondr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhimondr/subscriptions","organizations_url":"https://api.github.com/users/arhimondr/orgs","repos_url":"https://api.github.com/users/arhimondr/repos","events_url":"https://api.github.com/users/arhimondr/events{/privacy}","received_events_url":"https://api.github.com/users/arhimondr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-20T14:59:33Z","updated_at":"2015-08-20T15:32:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/prestodb/presto-admin/pulls/38","html_url":"https://github.com/prestodb/presto-admin/pull/38","diff_url":"https://github.com/prestodb/presto-admin/pull/38.diff","patch_url":"https://github.com/prestodb/presto-admin/pull/38.patch"},"body":"Now we are checking that presto is installed before checking version using 'rpm -q presto' and 'rpm -q presto-server-rpm'.\r\nSo, now we will get 'Presto is not installed' message just in case when presto is not installed at all.\r\n\r\nThen if presto is installed, we are trying to parse presto version usin '(\\d+)\\.(\\d+)t?([-\\.]SNAPSHOT)?' regexp.\r\nFirst group - is the major version, second group is the minor version.\r\nThis regexp should parse all possible versions including teradata ones and snapshot ones.\r\n\r\nWhen version doesn't match this pattern we are showing to user 'Incorrect presto version' message\r\ninstead of telling him that presto is not installed at all.\r\n\r\nTesting: manual"},"comment":{"url":"https://api.github.com/repos/prestodb/presto-admin/issues/comments/133052511","html_url":"https://github.com/prestodb/presto-admin/pull/38#issuecomment-133052511","issue_url":"https://api.github.com/repos/prestodb/presto-admin/issues/38","id":133052511,"user":{"login":"cawallin","id":3652644,"avatar_url":"https://avatars.githubusercontent.com/u/3652644?v=3","gravatar_id":"","url":"https://api.github.com/users/cawallin","html_url":"https://github.com/cawallin","followers_url":"https://api.github.com/users/cawallin/followers","following_url":"https://api.github.com/users/cawallin/following{/other_user}","gists_url":"https://api.github.com/users/cawallin/gists{/gist_id}","starred_url":"https://api.github.com/users/cawallin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cawallin/subscriptions","organizations_url":"https://api.github.com/users/cawallin/orgs","repos_url":"https://api.github.com/users/cawallin/repos","events_url":"https://api.github.com/users/cawallin/events{/privacy}","received_events_url":"https://api.github.com/users/cawallin/received_events","type":"User","site_admin":false},"created_at":"2015-08-20T15:32:00Z","updated_at":"2015-08-20T15:32:00Z","body":"@ilfrin: presto-admin is meant to work with all version of Presto -- 115, 115t, and any SNAPSHOT version.\r\n\r\n@arhimondr: Please also run make lint, if you haven't already, and the status product tests."}}