{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/barsoom/sie/pulls/4","id":29219397,"html_url":"https://github.com/barsoom/sie/pull/4","diff_url":"https://github.com/barsoom/sie/pull/4.diff","patch_url":"https://github.com/barsoom/sie/pull/4.patch","issue_url":"https://api.github.com/repos/barsoom/sie/issues/4","number":4,"state":"closed","locked":false,"title":"Add support for voucher line dimensions","user":{"login":"Koronen","id":543455,"avatar_url":"https://avatars.githubusercontent.com/u/543455?v=3","gravatar_id":"","url":"https://api.github.com/users/Koronen","html_url":"https://github.com/Koronen","followers_url":"https://api.github.com/users/Koronen/followers","following_url":"https://api.github.com/users/Koronen/following{/other_user}","gists_url":"https://api.github.com/users/Koronen/gists{/gist_id}","starred_url":"https://api.github.com/users/Koronen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Koronen/subscriptions","organizations_url":"https://api.github.com/users/Koronen/orgs","repos_url":"https://api.github.com/users/Koronen/repos","events_url":"https://api.github.com/users/Koronen/events{/privacy}","received_events_url":"https://api.github.com/users/Koronen/received_events","type":"User","site_admin":false},"body":"As a user of this library\r\nIn order to integrate with other bookkeeping software\r\nI want this library to support voucher line dimensions\r\n\r\nThis change is currently backward incompatible, as it requires making the data source respond to `dimensions`.\r\n\r\nFeedback (including nitpicks) is appreciated, especially on how to clean up `LineParser`.\r\n\r\nTODO:\r\n- [x] Update README","created_at":"2015-02-12T21:46:10Z","updated_at":"2015-03-23T10:51:37Z","closed_at":"2015-03-23T10:51:37Z","merged_at":"2015-03-23T10:51:37Z","merge_commit_sha":"e3e328f1397ab59e2fc4c04e9c42cf402e97af37","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/barsoom/sie/pulls/4/commits","review_comments_url":"https://api.github.com/repos/barsoom/sie/pulls/4/comments","review_comment_url":"https://api.github.com/repos/barsoom/sie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/barsoom/sie/issues/4/comments","statuses_url":"https://api.github.com/repos/barsoom/sie/statuses/9fe7b52c26813796afa766e0482acaa388bae341","head":{"label":"Koronen:vk-dimensions","ref":"vk-dimensions","sha":"9fe7b52c26813796afa766e0482acaa388bae341","user":{"login":"Koronen","id":543455,"avatar_url":"https://avatars.githubusercontent.com/u/543455?v=3","gravatar_id":"","url":"https://api.github.com/users/Koronen","html_url":"https://github.com/Koronen","followers_url":"https://api.github.com/users/Koronen/followers","following_url":"https://api.github.com/users/Koronen/following{/other_user}","gists_url":"https://api.github.com/users/Koronen/gists{/gist_id}","starred_url":"https://api.github.com/users/Koronen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Koronen/subscriptions","organizations_url":"https://api.github.com/users/Koronen/orgs","repos_url":"https://api.github.com/users/Koronen/repos","events_url":"https://api.github.com/users/Koronen/events{/privacy}","received_events_url":"https://api.github.com/users/Koronen/received_events","type":"User","site_admin":false},"repo":{"id":30506938,"name":"sie","full_name":"Koronen/sie","owner":{"login":"Koronen","id":543455,"avatar_url":"https://avatars.githubusercontent.com/u/543455?v=3","gravatar_id":"","url":"https://api.github.com/users/Koronen","html_url":"https://github.com/Koronen","followers_url":"https://api.github.com/users/Koronen/followers","following_url":"https://api.github.com/users/Koronen/following{/other_user}","gists_url":"https://api.github.com/users/Koronen/gists{/gist_id}","starred_url":"https://api.github.com/users/Koronen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Koronen/subscriptions","organizations_url":"https://api.github.com/users/Koronen/orgs","repos_url":"https://api.github.com/users/Koronen/repos","events_url":"https://api.github.com/users/Koronen/events{/privacy}","received_events_url":"https://api.github.com/users/Koronen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Koronen/sie","description":"Parser and generator for SIE files (http://sie.se/)","fork":true,"url":"https://api.github.com/repos/Koronen/sie","forks_url":"https://api.github.com/repos/Koronen/sie/forks","keys_url":"https://api.github.com/repos/Koronen/sie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Koronen/sie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Koronen/sie/teams","hooks_url":"https://api.github.com/repos/Koronen/sie/hooks","issue_events_url":"https://api.github.com/repos/Koronen/sie/issues/events{/number}","events_url":"https://api.github.com/repos/Koronen/sie/events","assignees_url":"https://api.github.com/repos/Koronen/sie/assignees{/user}","branches_url":"https://api.github.com/repos/Koronen/sie/branches{/branch}","tags_url":"https://api.github.com/repos/Koronen/sie/tags","blobs_url":"https://api.github.com/repos/Koronen/sie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Koronen/sie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Koronen/sie/git/refs{/sha}","trees_url":"https://api.github.com/repos/Koronen/sie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Koronen/sie/statuses/{sha}","languages_url":"https://api.github.com/repos/Koronen/sie/languages","stargazers_url":"https://api.github.com/repos/Koronen/sie/stargazers","contributors_url":"https://api.github.com/repos/Koronen/sie/contributors","subscribers_url":"https://api.github.com/repos/Koronen/sie/subscribers","subscription_url":"https://api.github.com/repos/Koronen/sie/subscription","commits_url":"https://api.github.com/repos/Koronen/sie/commits{/sha}","git_commits_url":"https://api.github.com/repos/Koronen/sie/git/commits{/sha}","comments_url":"https://api.github.com/repos/Koronen/sie/comments{/number}","issue_comment_url":"https://api.github.com/repos/Koronen/sie/issues/comments{/number}","contents_url":"https://api.github.com/repos/Koronen/sie/contents/{+path}","compare_url":"https://api.github.com/repos/Koronen/sie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Koronen/sie/merges","archive_url":"https://api.github.com/repos/Koronen/sie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Koronen/sie/downloads","issues_url":"https://api.github.com/repos/Koronen/sie/issues{/number}","pulls_url":"https://api.github.com/repos/Koronen/sie/pulls{/number}","milestones_url":"https://api.github.com/repos/Koronen/sie/milestones{/number}","notifications_url":"https://api.github.com/repos/Koronen/sie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Koronen/sie/labels{/name}","releases_url":"https://api.github.com/repos/Koronen/sie/releases{/id}","created_at":"2015-02-08T21:41:06Z","updated_at":"2015-03-12T20:46:31Z","pushed_at":"2015-03-18T15:59:46Z","git_url":"git://github.com/Koronen/sie.git","ssh_url":"git@github.com:Koronen/sie.git","clone_url":"https://github.com/Koronen/sie.git","svn_url":"https://github.com/Koronen/sie","homepage":"","size":222,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"barsoom:master","ref":"master","sha":"82bd48d0782e89915c035644b19f2b1b4671b713","user":{"login":"barsoom","id":875187,"avatar_url":"https://avatars.githubusercontent.com/u/875187?v=3","gravatar_id":"","url":"https://api.github.com/users/barsoom","html_url":"https://github.com/barsoom","followers_url":"https://api.github.com/users/barsoom/followers","following_url":"https://api.github.com/users/barsoom/following{/other_user}","gists_url":"https://api.github.com/users/barsoom/gists{/gist_id}","starred_url":"https://api.github.com/users/barsoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barsoom/subscriptions","organizations_url":"https://api.github.com/users/barsoom/orgs","repos_url":"https://api.github.com/users/barsoom/repos","events_url":"https://api.github.com/users/barsoom/events{/privacy}","received_events_url":"https://api.github.com/users/barsoom/received_events","type":"Organization","site_admin":false},"repo":{"id":14694748,"name":"sie","full_name":"barsoom/sie","owner":{"login":"barsoom","id":875187,"avatar_url":"https://avatars.githubusercontent.com/u/875187?v=3","gravatar_id":"","url":"https://api.github.com/users/barsoom","html_url":"https://github.com/barsoom","followers_url":"https://api.github.com/users/barsoom/followers","following_url":"https://api.github.com/users/barsoom/following{/other_user}","gists_url":"https://api.github.com/users/barsoom/gists{/gist_id}","starred_url":"https://api.github.com/users/barsoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barsoom/subscriptions","organizations_url":"https://api.github.com/users/barsoom/orgs","repos_url":"https://api.github.com/users/barsoom/repos","events_url":"https://api.github.com/users/barsoom/events{/privacy}","received_events_url":"https://api.github.com/users/barsoom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/barsoom/sie","description":"Parser and generator for SIE files (http://sie.se/)","fork":false,"url":"https://api.github.com/repos/barsoom/sie","forks_url":"https://api.github.com/repos/barsoom/sie/forks","keys_url":"https://api.github.com/repos/barsoom/sie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/barsoom/sie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/barsoom/sie/teams","hooks_url":"https://api.github.com/repos/barsoom/sie/hooks","issue_events_url":"https://api.github.com/repos/barsoom/sie/issues/events{/number}","events_url":"https://api.github.com/repos/barsoom/sie/events","assignees_url":"https://api.github.com/repos/barsoom/sie/assignees{/user}","branches_url":"https://api.github.com/repos/barsoom/sie/branches{/branch}","tags_url":"https://api.github.com/repos/barsoom/sie/tags","blobs_url":"https://api.github.com/repos/barsoom/sie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/barsoom/sie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/barsoom/sie/git/refs{/sha}","trees_url":"https://api.github.com/repos/barsoom/sie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/barsoom/sie/statuses/{sha}","languages_url":"https://api.github.com/repos/barsoom/sie/languages","stargazers_url":"https://api.github.com/repos/barsoom/sie/stargazers","contributors_url":"https://api.github.com/repos/barsoom/sie/contributors","subscribers_url":"https://api.github.com/repos/barsoom/sie/subscribers","subscription_url":"https://api.github.com/repos/barsoom/sie/subscription","commits_url":"https://api.github.com/repos/barsoom/sie/commits{/sha}","git_commits_url":"https://api.github.com/repos/barsoom/sie/git/commits{/sha}","comments_url":"https://api.github.com/repos/barsoom/sie/comments{/number}","issue_comment_url":"https://api.github.com/repos/barsoom/sie/issues/comments{/number}","contents_url":"https://api.github.com/repos/barsoom/sie/contents/{+path}","compare_url":"https://api.github.com/repos/barsoom/sie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/barsoom/sie/merges","archive_url":"https://api.github.com/repos/barsoom/sie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/barsoom/sie/downloads","issues_url":"https://api.github.com/repos/barsoom/sie/issues{/number}","pulls_url":"https://api.github.com/repos/barsoom/sie/pulls{/number}","milestones_url":"https://api.github.com/repos/barsoom/sie/milestones{/number}","notifications_url":"https://api.github.com/repos/barsoom/sie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/barsoom/sie/labels{/name}","releases_url":"https://api.github.com/repos/barsoom/sie/releases{/id}","created_at":"2013-11-25T18:47:25Z","updated_at":"2015-03-12T13:26:21Z","pushed_at":"2015-03-23T10:51:37Z","git_url":"git://github.com/barsoom/sie.git","ssh_url":"git@github.com:barsoom/sie.git","clone_url":"https://github.com/barsoom/sie.git","svn_url":"https://github.com/barsoom/sie","homepage":"","size":490,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/barsoom/sie/pulls/4"},"html":{"href":"https://github.com/barsoom/sie/pull/4"},"issue":{"href":"https://api.github.com/repos/barsoom/sie/issues/4"},"comments":{"href":"https://api.github.com/repos/barsoom/sie/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/barsoom/sie/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/barsoom/sie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/barsoom/sie/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/barsoom/sie/statuses/9fe7b52c26813796afa766e0482acaa388bae341"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"joakimk","id":13256,"avatar_url":"https://avatars.githubusercontent.com/u/13256?v=3","gravatar_id":"","url":"https://api.github.com/users/joakimk","html_url":"https://github.com/joakimk","followers_url":"https://api.github.com/users/joakimk/followers","following_url":"https://api.github.com/users/joakimk/following{/other_user}","gists_url":"https://api.github.com/users/joakimk/gists{/gist_id}","starred_url":"https://api.github.com/users/joakimk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakimk/subscriptions","organizations_url":"https://api.github.com/users/joakimk/orgs","repos_url":"https://api.github.com/users/joakimk/repos","events_url":"https://api.github.com/users/joakimk/events{/privacy}","received_events_url":"https://api.github.com/users/joakimk/received_events","type":"User","site_admin":false},"comments":4,"review_comments":10,"commits":7,"additions":140,"deletions":42,"changed_files":8}}