{"action":"created","issue":{"url":"https://api.github.com/repos/mila-udem/blocks-examples/issues/20","labels_url":"https://api.github.com/repos/mila-udem/blocks-examples/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/mila-udem/blocks-examples/issues/20/comments","events_url":"https://api.github.com/repos/mila-udem/blocks-examples/issues/20/events","html_url":"https://github.com/mila-udem/blocks-examples/pull/20","id":92208176,"number":20,"title":"NMT","user":{"login":"orhanf","id":3654684,"avatar_url":"https://avatars.githubusercontent.com/u/3654684?v=3","gravatar_id":"","url":"https://api.github.com/users/orhanf","html_url":"https://github.com/orhanf","followers_url":"https://api.github.com/users/orhanf/followers","following_url":"https://api.github.com/users/orhanf/following{/other_user}","gists_url":"https://api.github.com/users/orhanf/gists{/gist_id}","starred_url":"https://api.github.com/users/orhanf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orhanf/subscriptions","organizations_url":"https://api.github.com/users/orhanf/orgs","repos_url":"https://api.github.com/users/orhanf/repos","events_url":"https://api.github.com/users/orhanf/events{/privacy}","received_events_url":"https://api.github.com/users/orhanf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":29,"created_at":"2015-06-30T21:43:12Z","updated_at":"2015-08-05T23:23:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mila-udem/blocks-examples/pulls/20","html_url":"https://github.com/mila-udem/blocks-examples/pull/20","diff_url":"https://github.com/mila-udem/blocks-examples/pull/20.diff","patch_url":"https://github.com/mila-udem/blocks-examples/pull/20.patch"},"body":"@dmitriy-serdyuk, this is the initial implementation of RNN encoder-decoder with attention for machine translation. Working with the following versions (latest commits June30, 2015): [blocks](https://github.com/mila-udem/blocks/tree/39184e2c559a3a469f75399ddd4b8b6557bccdb8), [fuel](https://github.com/mila-udem/fuel/tree/ba15181b357035ee19ae32953f0c7c77f4ad490d) and [picklable_itertools](https://github.com/mila-udem/picklable-itertools/tree/5de7171788524eb6521117652e5fa09b45f74023)\r\n\r\nItems TODO:\r\n- [x] Documentation; is not complete yet but decent\r\n- [x] Sampling; ~~not~~ tested ~~but should be fine~~\r\n- [x] Early stopping based on BLEU; ~~not~~ tested, ~~have to clean it up and adapt the changes/fixes from NMT~~\r\n- [x] Example is using WMT'15 Czech->English translation, but necessary input files (preprocessed bitext, vocabularies, validation sets) are not provided. This will be handled by adding a script that does all the pre-processing and puts everything to the corresponding folder. Have the scripts that we used for WMT'15, will clean it up and put it here soon.\r\n- [x] Fix logging saving and loading issues.\r\n- [ ] Add tests\r\n- [ ] Anything else ?\r\n\r\nI will continue on these items this week, all minor issues compared to the whole PR\r\n\r\n@ejls, can you please take a look if i am missing something.\r\n@rizar your comments/recommendations are also highly welcomed \r\n\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mila-udem/blocks-examples/issues/comments/128182439","html_url":"https://github.com/mila-udem/blocks-examples/pull/20#issuecomment-128182439","issue_url":"https://api.github.com/repos/mila-udem/blocks-examples/issues/20","id":128182439,"user":{"login":"orhanf","id":3654684,"avatar_url":"https://avatars.githubusercontent.com/u/3654684?v=3","gravatar_id":"","url":"https://api.github.com/users/orhanf","html_url":"https://github.com/orhanf","followers_url":"https://api.github.com/users/orhanf/followers","following_url":"https://api.github.com/users/orhanf/following{/other_user}","gists_url":"https://api.github.com/users/orhanf/gists{/gist_id}","starred_url":"https://api.github.com/users/orhanf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orhanf/subscriptions","organizations_url":"https://api.github.com/users/orhanf/orgs","repos_url":"https://api.github.com/users/orhanf/repos","events_url":"https://api.github.com/users/orhanf/events{/privacy}","received_events_url":"https://api.github.com/users/orhanf/received_events","type":"User","site_admin":false},"created_at":"2015-08-05T23:23:52Z","updated_at":"2015-08-05T23:23:52Z","body":"@fhirschmann you're right, those little details make the code \"hacky\" at the end, i also agree on supporting and properly using `BOS` token, since the example should be extended to any dataset etc.\r\n\r\n@dmitriy-serdyuk, what u say about popping this one out as another ticket?"}}