{"action":"created","issue":{"url":"https://api.github.com/repos/PolymerElements/iron-ajax/issues/132","labels_url":"https://api.github.com/repos/PolymerElements/iron-ajax/issues/132/labels{/name}","comments_url":"https://api.github.com/repos/PolymerElements/iron-ajax/issues/132/comments","events_url":"https://api.github.com/repos/PolymerElements/iron-ajax/issues/132/events","html_url":"https://github.com/PolymerElements/iron-ajax/pull/132","id":111510794,"number":132,"title":"No automatic requests without a url.","user":{"login":"rictic","id":1659,"avatar_url":"https://avatars.githubusercontent.com/u/1659?v=3","gravatar_id":"","url":"https://api.github.com/users/rictic","html_url":"https://github.com/rictic","followers_url":"https://api.github.com/users/rictic/followers","following_url":"https://api.github.com/users/rictic/following{/other_user}","gists_url":"https://api.github.com/users/rictic/gists{/gist_id}","starred_url":"https://api.github.com/users/rictic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rictic/subscriptions","organizations_url":"https://api.github.com/users/rictic/orgs","repos_url":"https://api.github.com/users/rictic/repos","events_url":"https://api.github.com/users/rictic/events{/privacy}","received_events_url":"https://api.github.com/users/rictic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"cdata","id":240083,"avatar_url":"https://avatars.githubusercontent.com/u/240083?v=3","gravatar_id":"","url":"https://api.github.com/users/cdata","html_url":"https://github.com/cdata","followers_url":"https://api.github.com/users/cdata/followers","following_url":"https://api.github.com/users/cdata/following{/other_user}","gists_url":"https://api.github.com/users/cdata/gists{/gist_id}","starred_url":"https://api.github.com/users/cdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdata/subscriptions","organizations_url":"https://api.github.com/users/cdata/orgs","repos_url":"https://api.github.com/users/cdata/repos","events_url":"https://api.github.com/users/cdata/events{/privacy}","received_events_url":"https://api.github.com/users/cdata/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-10-14T22:52:45Z","updated_at":"2015-10-21T00:32:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PolymerElements/iron-ajax/pulls/132","html_url":"https://github.com/PolymerElements/iron-ajax/pull/132","diff_url":"https://github.com/PolymerElements/iron-ajax/pull/132.diff","patch_url":"https://github.com/PolymerElements/iron-ajax/pull/132.patch"},"body":"We've got this bug where we send unintended requests when the URL hasn't yet been set: https://github.com/PolymerElements/iron-ajax/issues/55\r\n\r\nThe fix that people have been proposing is that we not fire requests when the URL is the empty string. The tricky thing there is that an empty string URL is totally valid, it refers to the current URL. This isn't just a theoritical use either, it's not uncommon for servers to return different results for a URL based on method, params, accept headers, etc.\r\n\r\nThis commit tries to thread the needle of back-compat and user intent. The URL now defaults to `null`, and we won't perform any automatic requests while the url is `null`. If you explictly set the url to `''` then requests will fire, and if you call generateRequest with a `null` url we'll treat it as `''`.\r\n\r\nThis will hopefully solve the unintended request problem while also giving users control of when requests will and won't be fired (by setting the url to null), while having minimal impact on users that are happy with the current behavior.\r\n\r\nFixes #55"},"comment":{"url":"https://api.github.com/repos/PolymerElements/iron-ajax/issues/comments/149743515","html_url":"https://github.com/PolymerElements/iron-ajax/pull/132#issuecomment-149743515","issue_url":"https://api.github.com/repos/PolymerElements/iron-ajax/issues/132","id":149743515,"user":{"login":"cdata","id":240083,"avatar_url":"https://avatars.githubusercontent.com/u/240083?v=3","gravatar_id":"","url":"https://api.github.com/users/cdata","html_url":"https://github.com/cdata","followers_url":"https://api.github.com/users/cdata/followers","following_url":"https://api.github.com/users/cdata/following{/other_user}","gists_url":"https://api.github.com/users/cdata/gists{/gist_id}","starred_url":"https://api.github.com/users/cdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdata/subscriptions","organizations_url":"https://api.github.com/users/cdata/orgs","repos_url":"https://api.github.com/users/cdata/repos","events_url":"https://api.github.com/users/cdata/events{/privacy}","received_events_url":"https://api.github.com/users/cdata/received_events","type":"User","site_admin":false},"created_at":"2015-10-21T00:32:01Z","updated_at":"2015-10-21T00:32:01Z","body":"LGTM :+1: "}}