{"action":"created","issue":{"url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/issues/131","labels_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/issues/131/labels{/name}","comments_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/issues/131/comments","events_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/issues/131/events","html_url":"https://github.com/ClusterHQ/build.clusterhq.com/pull/131","id":100066812,"number":131,"title":"[FLOC-2841] Fix staging tag","user":{"login":"jongiddy","id":3735327,"avatar_url":"https://avatars.githubusercontent.com/u/3735327?v=3","gravatar_id":"","url":"https://api.github.com/users/jongiddy","html_url":"https://github.com/jongiddy","followers_url":"https://api.github.com/users/jongiddy/followers","following_url":"https://api.github.com/users/jongiddy/following{/other_user}","gists_url":"https://api.github.com/users/jongiddy/gists{/gist_id}","starred_url":"https://api.github.com/users/jongiddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jongiddy/subscriptions","organizations_url":"https://api.github.com/users/jongiddy/orgs","repos_url":"https://api.github.com/users/jongiddy/repos","events_url":"https://api.github.com/users/jongiddy/events{/privacy}","received_events_url":"https://api.github.com/users/jongiddy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-10T13:32:27Z","updated_at":"2015-08-10T16:06:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/pulls/131","html_url":"https://github.com/ClusterHQ/build.clusterhq.com/pull/131","diff_url":"https://github.com/ClusterHQ/build.clusterhq.com/pull/131.diff","patch_url":"https://github.com/ClusterHQ/build.clusterhq.com/pull/131.patch"},"body":"The staging instructions were recently modified to remove the instructions to set the `docker_tag`, but the commands to create the image were not changed to create an image with a different tag (`latest`).\r\n\r\nThis means that the staging instructions are broken, as they will ignore the built image, and download the latest master image, not incorporating the desired feature branch changes.\r\n\r\nThis could be solved by reverting the change (adding the `docker_tag` instructions back in), or by modifying other commands to build an image tagged `latest`.  This PR chooses the former, since tagging a temporary, non-master image as `latest` may be confusing.\r\n\r\nAlso, combined the instructions for the `buildbot` stanza to avoid the user having to jump back and forth in the `staging.yml` configuration file.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/clusterhq/build.clusterhq.com/131)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/issues/comments/129509870","html_url":"https://github.com/ClusterHQ/build.clusterhq.com/pull/131#issuecomment-129509870","issue_url":"https://api.github.com/repos/ClusterHQ/build.clusterhq.com/issues/131","id":129509870,"user":{"login":"jml","id":125674,"avatar_url":"https://avatars.githubusercontent.com/u/125674?v=3","gravatar_id":"","url":"https://api.github.com/users/jml","html_url":"https://github.com/jml","followers_url":"https://api.github.com/users/jml/followers","following_url":"https://api.github.com/users/jml/following{/other_user}","gists_url":"https://api.github.com/users/jml/gists{/gist_id}","starred_url":"https://api.github.com/users/jml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jml/subscriptions","organizations_url":"https://api.github.com/users/jml/orgs","repos_url":"https://api.github.com/users/jml/repos","events_url":"https://api.github.com/users/jml/events{/privacy}","received_events_url":"https://api.github.com/users/jml/received_events","type":"User","site_admin":false},"created_at":"2015-08-10T16:06:09Z","updated_at":"2015-08-10T16:06:09Z","body":"LGTM, thanks!\n\n---\n\nReview status: 0 of 1 files reviewed at latest revision, all discussions resolved, all commit checks successful.\n\n---\n\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/clusterhq/build.clusterhq.com/131)\n<!-- Sent from Reviewable.io -->\n"}}