{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/solidity/issues/203","labels_url":"https://api.github.com/repos/ethereum/solidity/issues/203/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/203/comments","events_url":"https://api.github.com/repos/ethereum/solidity/issues/203/events","html_url":"https://github.com/ethereum/solidity/pull/203","id":115562087,"number":203,"title":"Piper/style guide function modifiers","user":{"login":"pipermerriam","id":824194,"avatar_url":"https://avatars.githubusercontent.com/u/824194?v=3","gravatar_id":"","url":"https://api.github.com/users/pipermerriam","html_url":"https://github.com/pipermerriam","followers_url":"https://api.github.com/users/pipermerriam/followers","following_url":"https://api.github.com/users/pipermerriam/following{/other_user}","gists_url":"https://api.github.com/users/pipermerriam/gists{/gist_id}","starred_url":"https://api.github.com/users/pipermerriam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipermerriam/subscriptions","organizations_url":"https://api.github.com/users/pipermerriam/orgs","repos_url":"https://api.github.com/users/pipermerriam/repos","events_url":"https://api.github.com/users/pipermerriam/events{/privacy}","received_events_url":"https://api.github.com/users/pipermerriam/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-11-06T18:35:16Z","updated_at":"2015-11-18T14:57:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/203","html_url":"https://github.com/ethereum/solidity/pull/203","diff_url":"https://github.com/ethereum/solidity/pull/203.diff","patch_url":"https://github.com/ethereum/solidity/pull/203.patch"},"body":"### What was wrong\r\n\r\nThe style guide had a `TODO` for function declarations.\r\n\r\n### How was it fixed.\r\n\r\nI took some of the recommendations from the previous [pull request](https://github.com/ethereum/solidity/pull/196) from @chriseth @rabbit as well as general practices seen in other codebases and my own and tried to cover the most general cases for function declarations.\r\n\r\nThis addition tries to cover.\r\n\r\n* General declaration and placement of parenthesis on simple short functions\r\n* Ordering of modifiers\r\n* Wrapping of arguments for long declarations\r\n* Wrapping of modifiers for long declarations\r\n* Wrapping of base constructors.\r\n* Parenthesis placement for situations where the constructor spans multiple lines.\r\n\r\n*I also took the liberty of fixing a few indentation issues with the other code blocks.*\r\n\r\n#### Cute animal picture\r\n\r\n![tumblr_mnvcbijrtk1qf47bgo1_500](https://cloud.githubusercontent.com/assets/824194/11005284/2c3dff6a-847a-11e5-9312-0f4d5a5de92c.jpg)\r\n"},"comment":{"url":"https://api.github.com/repos/ethereum/solidity/issues/comments/157739788","html_url":"https://github.com/ethereum/solidity/pull/203#issuecomment-157739788","issue_url":"https://api.github.com/repos/ethereum/solidity/issues/203","id":157739788,"user":{"login":"chriseth","id":9073706,"avatar_url":"https://avatars.githubusercontent.com/u/9073706?v=3","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"created_at":"2015-11-18T14:57:48Z","updated_at":"2015-11-18T14:57:48Z","body":"Any comments? Good to be merged?"}}