{"action":"created","issue":{"url":"https://api.github.com/repos/real-logic/Aeron/issues/118","labels_url":"https://api.github.com/repos/real-logic/Aeron/issues/118/labels{/name}","comments_url":"https://api.github.com/repos/real-logic/Aeron/issues/118/comments","events_url":"https://api.github.com/repos/real-logic/Aeron/issues/118/events","html_url":"https://github.com/real-logic/Aeron/issues/118","id":74881898,"number":118,"title":"IllegalArgumentException when Aeron.addSubscription timeouts","user":{"login":"lech-glowiak","id":2694353,"avatar_url":"https://avatars.githubusercontent.com/u/2694353?v=3","gravatar_id":"","url":"https://api.github.com/users/lech-glowiak","html_url":"https://github.com/lech-glowiak","followers_url":"https://api.github.com/users/lech-glowiak/followers","following_url":"https://api.github.com/users/lech-glowiak/following{/other_user}","gists_url":"https://api.github.com/users/lech-glowiak/gists{/gist_id}","starred_url":"https://api.github.com/users/lech-glowiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lech-glowiak/subscriptions","organizations_url":"https://api.github.com/users/lech-glowiak/orgs","repos_url":"https://api.github.com/users/lech-glowiak/repos","events_url":"https://api.github.com/users/lech-glowiak/events{/privacy}","received_events_url":"https://api.github.com/users/lech-glowiak/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/real-logic/Aeron/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"tmontgomery","id":1979352,"avatar_url":"https://avatars.githubusercontent.com/u/1979352?v=3","gravatar_id":"","url":"https://api.github.com/users/tmontgomery","html_url":"https://github.com/tmontgomery","followers_url":"https://api.github.com/users/tmontgomery/followers","following_url":"https://api.github.com/users/tmontgomery/following{/other_user}","gists_url":"https://api.github.com/users/tmontgomery/gists{/gist_id}","starred_url":"https://api.github.com/users/tmontgomery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmontgomery/subscriptions","organizations_url":"https://api.github.com/users/tmontgomery/orgs","repos_url":"https://api.github.com/users/tmontgomery/repos","events_url":"https://api.github.com/users/tmontgomery/events{/privacy}","received_events_url":"https://api.github.com/users/tmontgomery/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-05-10T09:45:27Z","updated_at":"2015-05-31T15:32:21Z","closed_at":null,"body":"ClientConductor uses Agrona's Signal to await for subscription addition.\r\nSignal in turn throws IllegalArgumentException when it calls with negative argument (that is after timeout duration).\r\n\r\nAlso `private void ClientConductorTest.willSignalTimeOut()` should `throw new IllegalArgumentException(\"timeout cannot be negative\");`\r\ninstead of returning null.\r\nMaybe this should be fixed in Agrona: other 'await' method that checks if timeout has passed and returns boolean?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/real-logic/Aeron/issues/comments/107206265","html_url":"https://github.com/real-logic/Aeron/issues/118#issuecomment-107206265","issue_url":"https://api.github.com/repos/real-logic/Aeron/issues/118","id":107206265,"user":{"login":"tmontgomery","id":1979352,"avatar_url":"https://avatars.githubusercontent.com/u/1979352?v=3","gravatar_id":"","url":"https://api.github.com/users/tmontgomery","html_url":"https://github.com/tmontgomery","followers_url":"https://api.github.com/users/tmontgomery/followers","following_url":"https://api.github.com/users/tmontgomery/following{/other_user}","gists_url":"https://api.github.com/users/tmontgomery/gists{/gist_id}","starred_url":"https://api.github.com/users/tmontgomery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmontgomery/subscriptions","organizations_url":"https://api.github.com/users/tmontgomery/orgs","repos_url":"https://api.github.com/users/tmontgomery/repos","events_url":"https://api.github.com/users/tmontgomery/events{/privacy}","received_events_url":"https://api.github.com/users/tmontgomery/received_events","type":"User","site_admin":false},"created_at":"2015-05-31T15:32:21Z","updated_at":"2015-05-31T15:32:21Z","body":"The client API model has been redone. With the elimination of Signal, this should act differently.\r\n\r\nWould you be so kind as to retest this with the latest?"}}