{"action":"created","comment":{"url":"https://api.github.com/repos/juxt/aero/pulls/comments/44144997","id":44144997,"diff_hunk":"@@ -34,7 +34,8 @@\n          config\n          (with-open [pr (java.io.PushbackReader. (io/reader r))]\n            (edn/read\n-            {:readers (readers {:profile (or profile :default)\n+            {:eof {}","path":"src/aero/core.clj","position":5,"original_position":5,"commit_id":"60b554ed0f3d69dccdbacf1f06dd147a01e749be","original_commit_id":"60b554ed0f3d69dccdbacf1f06dd147a01e749be","user":{"login":"imrekoszo","id":1116295,"avatar_url":"https://avatars.githubusercontent.com/u/1116295?v=3","gravatar_id":"","url":"https://api.github.com/users/imrekoszo","html_url":"https://github.com/imrekoszo","followers_url":"https://api.github.com/users/imrekoszo/followers","following_url":"https://api.github.com/users/imrekoszo/following{/other_user}","gists_url":"https://api.github.com/users/imrekoszo/gists{/gist_id}","starred_url":"https://api.github.com/users/imrekoszo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imrekoszo/subscriptions","organizations_url":"https://api.github.com/users/imrekoszo/orgs","repos_url":"https://api.github.com/users/imrekoszo/repos","events_url":"https://api.github.com/users/imrekoszo/events{/privacy}","received_events_url":"https://api.github.com/users/imrekoszo/received_events","type":"User","site_admin":false},"body":"I was thinking along the empty file-empty config versus no file-no config lines (although no file will still throw and that might be desired). I see your point and would have no trouble changing it to nil if you prefer that.","created_at":"2015-11-06T15:03:54Z","updated_at":"2015-11-06T15:03:54Z","html_url":"https://github.com/juxt/aero/pull/2#discussion_r44144997","pull_request_url":"https://api.github.com/repos/juxt/aero/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/juxt/aero/pulls/comments/44144997"},"html":{"href":"https://github.com/juxt/aero/pull/2#discussion_r44144997"},"pull_request":{"href":"https://api.github.com/repos/juxt/aero/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/juxt/aero/pulls/2","id":49962406,"html_url":"https://github.com/juxt/aero/pull/2","diff_url":"https://github.com/juxt/aero/pull/2.diff","patch_url":"https://github.com/juxt/aero/pull/2.patch","issue_url":"https://api.github.com/repos/juxt/aero/issues/2","number":2,"state":"open","locked":false,"title":"Reading empty config file throws an exception","user":{"login":"imrekoszo","id":1116295,"avatar_url":"https://avatars.githubusercontent.com/u/1116295?v=3","gravatar_id":"","url":"https://api.github.com/users/imrekoszo","html_url":"https://github.com/imrekoszo","followers_url":"https://api.github.com/users/imrekoszo/followers","following_url":"https://api.github.com/users/imrekoszo/following{/other_user}","gists_url":"https://api.github.com/users/imrekoszo/gists{/gist_id}","starred_url":"https://api.github.com/users/imrekoszo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imrekoszo/subscriptions","organizations_url":"https://api.github.com/users/imrekoszo/orgs","repos_url":"https://api.github.com/users/imrekoszo/repos","events_url":"https://api.github.com/users/imrekoszo/events{/privacy}","received_events_url":"https://api.github.com/users/imrekoszo/received_events","type":"User","site_admin":false},"body":"Hey Malcolm,\r\n\r\nI noticed that reading empty config files will throw an exception. I thought maybe returning an empty map would be a better default, hence this pull request.\r\n\r\nIn my usecase I look at several possible config files, reading them with aero and then merging together. None of those are mandatory to be present and I wouldn't want the app to fail if one of the files in the chain got set empty by an admin.\r\n\r\n(Haven't bumped the version on purpose)\r\n\r\nGood luck","created_at":"2015-11-06T14:56:04Z","updated_at":"2015-11-06T15:03:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff7b501951a074e9025e8c6decf70a7ebe99c820","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juxt/aero/pulls/2/commits","review_comments_url":"https://api.github.com/repos/juxt/aero/pulls/2/comments","review_comment_url":"https://api.github.com/repos/juxt/aero/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juxt/aero/issues/2/comments","statuses_url":"https://api.github.com/repos/juxt/aero/statuses/60b554ed0f3d69dccdbacf1f06dd147a01e749be","head":{"label":"imrekoszo:master","ref":"master","sha":"60b554ed0f3d69dccdbacf1f06dd147a01e749be","user":{"login":"imrekoszo","id":1116295,"avatar_url":"https://avatars.githubusercontent.com/u/1116295?v=3","gravatar_id":"","url":"https://api.github.com/users/imrekoszo","html_url":"https://github.com/imrekoszo","followers_url":"https://api.github.com/users/imrekoszo/followers","following_url":"https://api.github.com/users/imrekoszo/following{/other_user}","gists_url":"https://api.github.com/users/imrekoszo/gists{/gist_id}","starred_url":"https://api.github.com/users/imrekoszo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imrekoszo/subscriptions","organizations_url":"https://api.github.com/users/imrekoszo/orgs","repos_url":"https://api.github.com/users/imrekoszo/repos","events_url":"https://api.github.com/users/imrekoszo/events{/privacy}","received_events_url":"https://api.github.com/users/imrekoszo/received_events","type":"User","site_admin":false},"repo":{"id":45687094,"name":"aero","full_name":"imrekoszo/aero","owner":{"login":"imrekoszo","id":1116295,"avatar_url":"https://avatars.githubusercontent.com/u/1116295?v=3","gravatar_id":"","url":"https://api.github.com/users/imrekoszo","html_url":"https://github.com/imrekoszo","followers_url":"https://api.github.com/users/imrekoszo/followers","following_url":"https://api.github.com/users/imrekoszo/following{/other_user}","gists_url":"https://api.github.com/users/imrekoszo/gists{/gist_id}","starred_url":"https://api.github.com/users/imrekoszo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imrekoszo/subscriptions","organizations_url":"https://api.github.com/users/imrekoszo/orgs","repos_url":"https://api.github.com/users/imrekoszo/repos","events_url":"https://api.github.com/users/imrekoszo/events{/privacy}","received_events_url":"https://api.github.com/users/imrekoszo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imrekoszo/aero","description":"Light and fluffy configuration","fork":true,"url":"https://api.github.com/repos/imrekoszo/aero","forks_url":"https://api.github.com/repos/imrekoszo/aero/forks","keys_url":"https://api.github.com/repos/imrekoszo/aero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imrekoszo/aero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imrekoszo/aero/teams","hooks_url":"https://api.github.com/repos/imrekoszo/aero/hooks","issue_events_url":"https://api.github.com/repos/imrekoszo/aero/issues/events{/number}","events_url":"https://api.github.com/repos/imrekoszo/aero/events","assignees_url":"https://api.github.com/repos/imrekoszo/aero/assignees{/user}","branches_url":"https://api.github.com/repos/imrekoszo/aero/branches{/branch}","tags_url":"https://api.github.com/repos/imrekoszo/aero/tags","blobs_url":"https://api.github.com/repos/imrekoszo/aero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imrekoszo/aero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imrekoszo/aero/git/refs{/sha}","trees_url":"https://api.github.com/repos/imrekoszo/aero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imrekoszo/aero/statuses/{sha}","languages_url":"https://api.github.com/repos/imrekoszo/aero/languages","stargazers_url":"https://api.github.com/repos/imrekoszo/aero/stargazers","contributors_url":"https://api.github.com/repos/imrekoszo/aero/contributors","subscribers_url":"https://api.github.com/repos/imrekoszo/aero/subscribers","subscription_url":"https://api.github.com/repos/imrekoszo/aero/subscription","commits_url":"https://api.github.com/repos/imrekoszo/aero/commits{/sha}","git_commits_url":"https://api.github.com/repos/imrekoszo/aero/git/commits{/sha}","comments_url":"https://api.github.com/repos/imrekoszo/aero/comments{/number}","issue_comment_url":"https://api.github.com/repos/imrekoszo/aero/issues/comments{/number}","contents_url":"https://api.github.com/repos/imrekoszo/aero/contents/{+path}","compare_url":"https://api.github.com/repos/imrekoszo/aero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imrekoszo/aero/merges","archive_url":"https://api.github.com/repos/imrekoszo/aero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imrekoszo/aero/downloads","issues_url":"https://api.github.com/repos/imrekoszo/aero/issues{/number}","pulls_url":"https://api.github.com/repos/imrekoszo/aero/pulls{/number}","milestones_url":"https://api.github.com/repos/imrekoszo/aero/milestones{/number}","notifications_url":"https://api.github.com/repos/imrekoszo/aero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imrekoszo/aero/labels{/name}","releases_url":"https://api.github.com/repos/imrekoszo/aero/releases{/id}","created_at":"2015-11-06T14:36:53Z","updated_at":"2015-11-06T14:36:55Z","pushed_at":"2015-11-06T14:44:46Z","git_url":"git://github.com/imrekoszo/aero.git","ssh_url":"git@github.com:imrekoszo/aero.git","clone_url":"https://github.com/imrekoszo/aero.git","svn_url":"https://github.com/imrekoszo/aero","homepage":null,"size":195,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juxt:master","ref":"master","sha":"48bd6e25cdadf1297fc7ef692b9cc6e58089a283","user":{"login":"juxt","id":2892228,"avatar_url":"https://avatars.githubusercontent.com/u/2892228?v=3","gravatar_id":"","url":"https://api.github.com/users/juxt","html_url":"https://github.com/juxt","followers_url":"https://api.github.com/users/juxt/followers","following_url":"https://api.github.com/users/juxt/following{/other_user}","gists_url":"https://api.github.com/users/juxt/gists{/gist_id}","starred_url":"https://api.github.com/users/juxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juxt/subscriptions","organizations_url":"https://api.github.com/users/juxt/orgs","repos_url":"https://api.github.com/users/juxt/repos","events_url":"https://api.github.com/users/juxt/events{/privacy}","received_events_url":"https://api.github.com/users/juxt/received_events","type":"Organization","site_admin":false},"repo":{"id":35664663,"name":"aero","full_name":"juxt/aero","owner":{"login":"juxt","id":2892228,"avatar_url":"https://avatars.githubusercontent.com/u/2892228?v=3","gravatar_id":"","url":"https://api.github.com/users/juxt","html_url":"https://github.com/juxt","followers_url":"https://api.github.com/users/juxt/followers","following_url":"https://api.github.com/users/juxt/following{/other_user}","gists_url":"https://api.github.com/users/juxt/gists{/gist_id}","starred_url":"https://api.github.com/users/juxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juxt/subscriptions","organizations_url":"https://api.github.com/users/juxt/orgs","repos_url":"https://api.github.com/users/juxt/repos","events_url":"https://api.github.com/users/juxt/events{/privacy}","received_events_url":"https://api.github.com/users/juxt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juxt/aero","description":"Light and fluffy configuration","fork":false,"url":"https://api.github.com/repos/juxt/aero","forks_url":"https://api.github.com/repos/juxt/aero/forks","keys_url":"https://api.github.com/repos/juxt/aero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juxt/aero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juxt/aero/teams","hooks_url":"https://api.github.com/repos/juxt/aero/hooks","issue_events_url":"https://api.github.com/repos/juxt/aero/issues/events{/number}","events_url":"https://api.github.com/repos/juxt/aero/events","assignees_url":"https://api.github.com/repos/juxt/aero/assignees{/user}","branches_url":"https://api.github.com/repos/juxt/aero/branches{/branch}","tags_url":"https://api.github.com/repos/juxt/aero/tags","blobs_url":"https://api.github.com/repos/juxt/aero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juxt/aero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juxt/aero/git/refs{/sha}","trees_url":"https://api.github.com/repos/juxt/aero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juxt/aero/statuses/{sha}","languages_url":"https://api.github.com/repos/juxt/aero/languages","stargazers_url":"https://api.github.com/repos/juxt/aero/stargazers","contributors_url":"https://api.github.com/repos/juxt/aero/contributors","subscribers_url":"https://api.github.com/repos/juxt/aero/subscribers","subscription_url":"https://api.github.com/repos/juxt/aero/subscription","commits_url":"https://api.github.com/repos/juxt/aero/commits{/sha}","git_commits_url":"https://api.github.com/repos/juxt/aero/git/commits{/sha}","comments_url":"https://api.github.com/repos/juxt/aero/comments{/number}","issue_comment_url":"https://api.github.com/repos/juxt/aero/issues/comments{/number}","contents_url":"https://api.github.com/repos/juxt/aero/contents/{+path}","compare_url":"https://api.github.com/repos/juxt/aero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juxt/aero/merges","archive_url":"https://api.github.com/repos/juxt/aero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juxt/aero/downloads","issues_url":"https://api.github.com/repos/juxt/aero/issues{/number}","pulls_url":"https://api.github.com/repos/juxt/aero/pulls{/number}","milestones_url":"https://api.github.com/repos/juxt/aero/milestones{/number}","notifications_url":"https://api.github.com/repos/juxt/aero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juxt/aero/labels{/name}","releases_url":"https://api.github.com/repos/juxt/aero/releases{/id}","created_at":"2015-05-15T09:08:54Z","updated_at":"2015-10-22T16:22:06Z","pushed_at":"2015-11-06T14:56:09Z","git_url":"git://github.com/juxt/aero.git","ssh_url":"git@github.com:juxt/aero.git","clone_url":"https://github.com/juxt/aero.git","svn_url":"https://github.com/juxt/aero","homepage":null,"size":195,"stargazers_count":12,"watchers_count":12,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juxt/aero/pulls/2"},"html":{"href":"https://github.com/juxt/aero/pull/2"},"issue":{"href":"https://api.github.com/repos/juxt/aero/issues/2"},"comments":{"href":"https://api.github.com/repos/juxt/aero/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/juxt/aero/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/juxt/aero/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juxt/aero/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/juxt/aero/statuses/60b554ed0f3d69dccdbacf1f06dd147a01e749be"}}}}