{"action":"created","comment":{"url":"https://api.github.com/repos/MailCore/mailcore2/pulls/comments/30463420","id":30463420,"diff_hunk":"@@ -170,6 +170,13 @@ IMAPSearchExpression * IMAPSearchExpression::searchUIDs(IndexSet * uids)\n     return (IMAPSearchExpression *) expr->autorelease();\n }\n \n+IMAPSearchExpression * IMAPSearchExpression::searchNumbers(IndexSet * numbers)\n+{\n+\tIMAPSearchExpression * expr = new IMAPSearchExpression();\n+\texpr->mKind = IMAPSearchKindNumbers;","path":"src/core/imap/MCIMAPSearchExpression.cpp","position":7,"original_position":7,"commit_id":"b0b9c5269bcb881141ff6f9d192ba771cde485aa","original_commit_id":"b0b9c5269bcb881141ff6f9d192ba771cde485aa","user":{"login":"dinhviethoa","id":332168,"avatar_url":"https://avatars.githubusercontent.com/u/332168?v=3","gravatar_id":"","url":"https://api.github.com/users/dinhviethoa","html_url":"https://github.com/dinhviethoa","followers_url":"https://api.github.com/users/dinhviethoa/followers","following_url":"https://api.github.com/users/dinhviethoa/following{/other_user}","gists_url":"https://api.github.com/users/dinhviethoa/gists{/gist_id}","starred_url":"https://api.github.com/users/dinhviethoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dinhviethoa/subscriptions","organizations_url":"https://api.github.com/users/dinhviethoa/orgs","repos_url":"https://api.github.com/users/dinhviethoa/repos","events_url":"https://api.github.com/users/dinhviethoa/events{/privacy}","received_events_url":"https://api.github.com/users/dinhviethoa/received_events","type":"User","site_admin":false},"body":"You forget to add IMAPSearchKindNumbers in the constants.","created_at":"2015-05-16T18:38:44Z","updated_at":"2015-05-16T18:38:44Z","html_url":"https://github.com/MailCore/mailcore2/pull/1122#discussion_r30463420","pull_request_url":"https://api.github.com/repos/MailCore/mailcore2/pulls/1122","_links":{"self":{"href":"https://api.github.com/repos/MailCore/mailcore2/pulls/comments/30463420"},"html":{"href":"https://github.com/MailCore/mailcore2/pull/1122#discussion_r30463420"},"pull_request":{"href":"https://api.github.com/repos/MailCore/mailcore2/pulls/1122"}}},"pull_request":{"url":"https://api.github.com/repos/MailCore/mailcore2/pulls/1122","id":35570435,"html_url":"https://github.com/MailCore/mailcore2/pull/1122","diff_url":"https://github.com/MailCore/mailcore2/pull/1122.diff","patch_url":"https://github.com/MailCore/mailcore2/pull/1122.patch","issue_url":"https://api.github.com/repos/MailCore/mailcore2/issues/1122","number":1122,"state":"open","locked":false,"title":"Added UID Search with message number expression and SearchKindNumber for IMAP","user":{"login":"jstarfruits","id":5737558,"avatar_url":"https://avatars.githubusercontent.com/u/5737558?v=3","gravatar_id":"","url":"https://api.github.com/users/jstarfruits","html_url":"https://github.com/jstarfruits","followers_url":"https://api.github.com/users/jstarfruits/followers","following_url":"https://api.github.com/users/jstarfruits/following{/other_user}","gists_url":"https://api.github.com/users/jstarfruits/gists{/gist_id}","starred_url":"https://api.github.com/users/jstarfruits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstarfruits/subscriptions","organizations_url":"https://api.github.com/users/jstarfruits/orgs","repos_url":"https://api.github.com/users/jstarfruits/repos","events_url":"https://api.github.com/users/jstarfruits/events{/privacy}","received_events_url":"https://api.github.com/users/jstarfruits/received_events","type":"User","site_admin":false},"body":"I added this method, because I want to throw a more compact query, e.g. \"UID SEARCH 1:10\"\r\nPlease merge if it is necessary.","created_at":"2015-05-16T12:28:18Z","updated_at":"2015-05-16T18:38:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"256976438716625a034ac5d957d0dbf6b349216b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MailCore/mailcore2/pulls/1122/commits","review_comments_url":"https://api.github.com/repos/MailCore/mailcore2/pulls/1122/comments","review_comment_url":"https://api.github.com/repos/MailCore/mailcore2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MailCore/mailcore2/issues/1122/comments","statuses_url":"https://api.github.com/repos/MailCore/mailcore2/statuses/b0b9c5269bcb881141ff6f9d192ba771cde485aa","head":{"label":"jstarfruits:master","ref":"master","sha":"b0b9c5269bcb881141ff6f9d192ba771cde485aa","user":{"login":"jstarfruits","id":5737558,"avatar_url":"https://avatars.githubusercontent.com/u/5737558?v=3","gravatar_id":"","url":"https://api.github.com/users/jstarfruits","html_url":"https://github.com/jstarfruits","followers_url":"https://api.github.com/users/jstarfruits/followers","following_url":"https://api.github.com/users/jstarfruits/following{/other_user}","gists_url":"https://api.github.com/users/jstarfruits/gists{/gist_id}","starred_url":"https://api.github.com/users/jstarfruits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstarfruits/subscriptions","organizations_url":"https://api.github.com/users/jstarfruits/orgs","repos_url":"https://api.github.com/users/jstarfruits/repos","events_url":"https://api.github.com/users/jstarfruits/events{/privacy}","received_events_url":"https://api.github.com/users/jstarfruits/received_events","type":"User","site_admin":false},"repo":{"id":35415473,"name":"mailcore2","full_name":"jstarfruits/mailcore2","owner":{"login":"jstarfruits","id":5737558,"avatar_url":"https://avatars.githubusercontent.com/u/5737558?v=3","gravatar_id":"","url":"https://api.github.com/users/jstarfruits","html_url":"https://github.com/jstarfruits","followers_url":"https://api.github.com/users/jstarfruits/followers","following_url":"https://api.github.com/users/jstarfruits/following{/other_user}","gists_url":"https://api.github.com/users/jstarfruits/gists{/gist_id}","starred_url":"https://api.github.com/users/jstarfruits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstarfruits/subscriptions","organizations_url":"https://api.github.com/users/jstarfruits/orgs","repos_url":"https://api.github.com/users/jstarfruits/repos","events_url":"https://api.github.com/users/jstarfruits/events{/privacy}","received_events_url":"https://api.github.com/users/jstarfruits/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jstarfruits/mailcore2","description":"MailCore 2 provide a simple and asynchronous API to work with e-mail protocols IMAP, POP and SMTP. The API has been redesigned from ground up.","fork":true,"url":"https://api.github.com/repos/jstarfruits/mailcore2","forks_url":"https://api.github.com/repos/jstarfruits/mailcore2/forks","keys_url":"https://api.github.com/repos/jstarfruits/mailcore2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jstarfruits/mailcore2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jstarfruits/mailcore2/teams","hooks_url":"https://api.github.com/repos/jstarfruits/mailcore2/hooks","issue_events_url":"https://api.github.com/repos/jstarfruits/mailcore2/issues/events{/number}","events_url":"https://api.github.com/repos/jstarfruits/mailcore2/events","assignees_url":"https://api.github.com/repos/jstarfruits/mailcore2/assignees{/user}","branches_url":"https://api.github.com/repos/jstarfruits/mailcore2/branches{/branch}","tags_url":"https://api.github.com/repos/jstarfruits/mailcore2/tags","blobs_url":"https://api.github.com/repos/jstarfruits/mailcore2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jstarfruits/mailcore2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jstarfruits/mailcore2/git/refs{/sha}","trees_url":"https://api.github.com/repos/jstarfruits/mailcore2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jstarfruits/mailcore2/statuses/{sha}","languages_url":"https://api.github.com/repos/jstarfruits/mailcore2/languages","stargazers_url":"https://api.github.com/repos/jstarfruits/mailcore2/stargazers","contributors_url":"https://api.github.com/repos/jstarfruits/mailcore2/contributors","subscribers_url":"https://api.github.com/repos/jstarfruits/mailcore2/subscribers","subscription_url":"https://api.github.com/repos/jstarfruits/mailcore2/subscription","commits_url":"https://api.github.com/repos/jstarfruits/mailcore2/commits{/sha}","git_commits_url":"https://api.github.com/repos/jstarfruits/mailcore2/git/commits{/sha}","comments_url":"https://api.github.com/repos/jstarfruits/mailcore2/comments{/number}","issue_comment_url":"https://api.github.com/repos/jstarfruits/mailcore2/issues/comments{/number}","contents_url":"https://api.github.com/repos/jstarfruits/mailcore2/contents/{+path}","compare_url":"https://api.github.com/repos/jstarfruits/mailcore2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jstarfruits/mailcore2/merges","archive_url":"https://api.github.com/repos/jstarfruits/mailcore2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jstarfruits/mailcore2/downloads","issues_url":"https://api.github.com/repos/jstarfruits/mailcore2/issues{/number}","pulls_url":"https://api.github.com/repos/jstarfruits/mailcore2/pulls{/number}","milestones_url":"https://api.github.com/repos/jstarfruits/mailcore2/milestones{/number}","notifications_url":"https://api.github.com/repos/jstarfruits/mailcore2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jstarfruits/mailcore2/labels{/name}","releases_url":"https://api.github.com/repos/jstarfruits/mailcore2/releases{/id}","created_at":"2015-05-11T09:51:33Z","updated_at":"2015-05-11T09:51:38Z","pushed_at":"2015-05-16T07:43:57Z","git_url":"git://github.com/jstarfruits/mailcore2.git","ssh_url":"git@github.com:jstarfruits/mailcore2.git","clone_url":"https://github.com/jstarfruits/mailcore2.git","svn_url":"https://github.com/jstarfruits/mailcore2","homepage":"","size":12278,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MailCore:master","ref":"master","sha":"640d1945f279038c197e31419677ac64e4246453","user":{"login":"MailCore","id":3229324,"avatar_url":"https://avatars.githubusercontent.com/u/3229324?v=3","gravatar_id":"","url":"https://api.github.com/users/MailCore","html_url":"https://github.com/MailCore","followers_url":"https://api.github.com/users/MailCore/followers","following_url":"https://api.github.com/users/MailCore/following{/other_user}","gists_url":"https://api.github.com/users/MailCore/gists{/gist_id}","starred_url":"https://api.github.com/users/MailCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MailCore/subscriptions","organizations_url":"https://api.github.com/users/MailCore/orgs","repos_url":"https://api.github.com/users/MailCore/repos","events_url":"https://api.github.com/users/MailCore/events{/privacy}","received_events_url":"https://api.github.com/users/MailCore/received_events","type":"Organization","site_admin":false},"repo":{"id":7527552,"name":"mailcore2","full_name":"MailCore/mailcore2","owner":{"login":"MailCore","id":3229324,"avatar_url":"https://avatars.githubusercontent.com/u/3229324?v=3","gravatar_id":"","url":"https://api.github.com/users/MailCore","html_url":"https://github.com/MailCore","followers_url":"https://api.github.com/users/MailCore/followers","following_url":"https://api.github.com/users/MailCore/following{/other_user}","gists_url":"https://api.github.com/users/MailCore/gists{/gist_id}","starred_url":"https://api.github.com/users/MailCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MailCore/subscriptions","organizations_url":"https://api.github.com/users/MailCore/orgs","repos_url":"https://api.github.com/users/MailCore/repos","events_url":"https://api.github.com/users/MailCore/events{/privacy}","received_events_url":"https://api.github.com/users/MailCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MailCore/mailcore2","description":"MailCore 2 provide a simple and asynchronous API to work with e-mail protocols IMAP, POP and SMTP. The API has been redesigned from ground up.","fork":false,"url":"https://api.github.com/repos/MailCore/mailcore2","forks_url":"https://api.github.com/repos/MailCore/mailcore2/forks","keys_url":"https://api.github.com/repos/MailCore/mailcore2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MailCore/mailcore2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MailCore/mailcore2/teams","hooks_url":"https://api.github.com/repos/MailCore/mailcore2/hooks","issue_events_url":"https://api.github.com/repos/MailCore/mailcore2/issues/events{/number}","events_url":"https://api.github.com/repos/MailCore/mailcore2/events","assignees_url":"https://api.github.com/repos/MailCore/mailcore2/assignees{/user}","branches_url":"https://api.github.com/repos/MailCore/mailcore2/branches{/branch}","tags_url":"https://api.github.com/repos/MailCore/mailcore2/tags","blobs_url":"https://api.github.com/repos/MailCore/mailcore2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MailCore/mailcore2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MailCore/mailcore2/git/refs{/sha}","trees_url":"https://api.github.com/repos/MailCore/mailcore2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MailCore/mailcore2/statuses/{sha}","languages_url":"https://api.github.com/repos/MailCore/mailcore2/languages","stargazers_url":"https://api.github.com/repos/MailCore/mailcore2/stargazers","contributors_url":"https://api.github.com/repos/MailCore/mailcore2/contributors","subscribers_url":"https://api.github.com/repos/MailCore/mailcore2/subscribers","subscription_url":"https://api.github.com/repos/MailCore/mailcore2/subscription","commits_url":"https://api.github.com/repos/MailCore/mailcore2/commits{/sha}","git_commits_url":"https://api.github.com/repos/MailCore/mailcore2/git/commits{/sha}","comments_url":"https://api.github.com/repos/MailCore/mailcore2/comments{/number}","issue_comment_url":"https://api.github.com/repos/MailCore/mailcore2/issues/comments{/number}","contents_url":"https://api.github.com/repos/MailCore/mailcore2/contents/{+path}","compare_url":"https://api.github.com/repos/MailCore/mailcore2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MailCore/mailcore2/merges","archive_url":"https://api.github.com/repos/MailCore/mailcore2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MailCore/mailcore2/downloads","issues_url":"https://api.github.com/repos/MailCore/mailcore2/issues{/number}","pulls_url":"https://api.github.com/repos/MailCore/mailcore2/pulls{/number}","milestones_url":"https://api.github.com/repos/MailCore/mailcore2/milestones{/number}","notifications_url":"https://api.github.com/repos/MailCore/mailcore2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MailCore/mailcore2/labels{/name}","releases_url":"https://api.github.com/repos/MailCore/mailcore2/releases{/id}","created_at":"2013-01-09T19:35:49Z","updated_at":"2015-05-15T13:52:56Z","pushed_at":"2015-05-16T12:28:19Z","git_url":"git://github.com/MailCore/mailcore2.git","ssh_url":"git@github.com:MailCore/mailcore2.git","clone_url":"https://github.com/MailCore/mailcore2.git","svn_url":"https://github.com/MailCore/mailcore2","homepage":"","size":17421,"stargazers_count":975,"watchers_count":975,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":290,"mirror_url":null,"open_issues_count":24,"forks":290,"open_issues":24,"watchers":975,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MailCore/mailcore2/pulls/1122"},"html":{"href":"https://github.com/MailCore/mailcore2/pull/1122"},"issue":{"href":"https://api.github.com/repos/MailCore/mailcore2/issues/1122"},"comments":{"href":"https://api.github.com/repos/MailCore/mailcore2/issues/1122/comments"},"review_comments":{"href":"https://api.github.com/repos/MailCore/mailcore2/pulls/1122/comments"},"review_comment":{"href":"https://api.github.com/repos/MailCore/mailcore2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MailCore/mailcore2/pulls/1122/commits"},"statuses":{"href":"https://api.github.com/repos/MailCore/mailcore2/statuses/b0b9c5269bcb881141ff6f9d192ba771cde485aa"}}}}