{"action":"created","issue":{"url":"https://api.github.com/repos/docker/compose/issues/2206","labels_url":"https://api.github.com/repos/docker/compose/issues/2206/labels{/name}","comments_url":"https://api.github.com/repos/docker/compose/issues/2206/comments","events_url":"https://api.github.com/repos/docker/compose/issues/2206/events","html_url":"https://github.com/docker/compose/pull/2206","id":111858424,"number":2206,"title":"extends must be copied from override file","user":{"login":"dnephin","id":442180,"avatar_url":"https://avatars.githubusercontent.com/u/442180?v=3","gravatar_id":"","url":"https://api.github.com/users/dnephin","html_url":"https://github.com/dnephin","followers_url":"https://api.github.com/users/dnephin/followers","following_url":"https://api.github.com/users/dnephin/following{/other_user}","gists_url":"https://api.github.com/users/dnephin/gists{/gist_id}","starred_url":"https://api.github.com/users/dnephin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnephin/subscriptions","organizations_url":"https://api.github.com/users/dnephin/orgs","repos_url":"https://api.github.com/users/dnephin/repos","events_url":"https://api.github.com/users/dnephin/events{/privacy}","received_events_url":"https://api.github.com/users/dnephin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/compose/labels/area/config","name":"area/config","color":"c7def8"},{"url":"https://api.github.com/repos/docker/compose/labels/kind/bug","name":"kind/bug","color":"fc2929"},{"url":"https://api.github.com/repos/docker/compose/labels/status/0-triage","name":"status/0-triage","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/docker/compose/milestones/9","html_url":"https://github.com/docker/compose/milestones/1.5.0","labels_url":"https://api.github.com/repos/docker/compose/milestones/9/labels","id":1229222,"number":9,"title":"1.5.0","description":"","creator":{"login":"aanand","id":1062,"avatar_url":"https://avatars.githubusercontent.com/u/1062?v=3","gravatar_id":"","url":"https://api.github.com/users/aanand","html_url":"https://github.com/aanand","followers_url":"https://api.github.com/users/aanand/followers","following_url":"https://api.github.com/users/aanand/following{/other_user}","gists_url":"https://api.github.com/users/aanand/gists{/gist_id}","starred_url":"https://api.github.com/users/aanand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanand/subscriptions","organizations_url":"https://api.github.com/users/aanand/orgs","repos_url":"https://api.github.com/users/aanand/repos","events_url":"https://api.github.com/users/aanand/events{/privacy}","received_events_url":"https://api.github.com/users/aanand/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":87,"state":"open","created_at":"2015-07-28T11:48:08Z","updated_at":"2015-10-19T17:32:49Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2015-10-16T15:49:14Z","updated_at":"2015-10-19T17:33:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/compose/pulls/2206","html_url":"https://github.com/docker/compose/pull/2206","diff_url":"https://github.com/docker/compose/pull/2206.diff","patch_url":"https://github.com/docker/compose/pull/2206.patch"},"body":"Fixes #2205\r\n\r\n`merge_service_dicts()` which is used for extends doesn't copy extends, but we need to copy extends for overriding of files.\r\n\r\nIn the test for this fix I've used a `tempdir` for creating the necessary file instead of using a real file. I think this makes the test easier to understand because the fixtures are inline, instead of a separate file.\r\n\r\nIf we're happy with this approach, I think we could convert a few of our other unit tests to use this setup."},"comment":{"url":"https://api.github.com/repos/docker/compose/issues/comments/149290733","html_url":"https://github.com/docker/compose/pull/2206#issuecomment-149290733","issue_url":"https://api.github.com/repos/docker/compose/issues/2206","id":149290733,"user":{"login":"aanand","id":1062,"avatar_url":"https://avatars.githubusercontent.com/u/1062?v=3","gravatar_id":"","url":"https://api.github.com/users/aanand","html_url":"https://github.com/aanand","followers_url":"https://api.github.com/users/aanand/followers","following_url":"https://api.github.com/users/aanand/following{/other_user}","gists_url":"https://api.github.com/users/aanand/gists{/gist_id}","starred_url":"https://api.github.com/users/aanand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanand/subscriptions","organizations_url":"https://api.github.com/users/aanand/orgs","repos_url":"https://api.github.com/users/aanand/repos","events_url":"https://api.github.com/users/aanand/events{/privacy}","received_events_url":"https://api.github.com/users/aanand/received_events","type":"User","site_admin":false},"created_at":"2015-10-19T17:33:02Z","updated_at":"2015-10-19T17:33:02Z","body":"Yeah, I like it. Fixtures are good in that an actual directory with actual files is nice and easy to understand, but I never liked the coupling-at-a-distance."}}