{"action":"created","comment":{"url":"https://api.github.com/repos/yahoo/squidb/pulls/comments/36208317","id":36208317,"diff_hunk":"@@ -97,8 +97,6 @@ private static void copyFile(File in, File out) throws Exception {\n         FileOutputStream fos = new FileOutputStream(out);\n         try {\n             copyStream(fis, fos);\n-        } catch (Exception e) {\n-            throw e;","path":"squidb/src/com/yahoo/squidb/utility/SquidUtilities.java","position":5,"original_position":5,"commit_id":"aee47bb5685dda8f3e16f2b973d8e058d59aa4d1","original_commit_id":"aee47bb5685dda8f3e16f2b973d8e058d59aa4d1","user":{"login":"sbosley","id":622224,"avatar_url":"https://avatars.githubusercontent.com/u/622224?v=3","gravatar_id":"","url":"https://api.github.com/users/sbosley","html_url":"https://github.com/sbosley","followers_url":"https://api.github.com/users/sbosley/followers","following_url":"https://api.github.com/users/sbosley/following{/other_user}","gists_url":"https://api.github.com/users/sbosley/gists{/gist_id}","starred_url":"https://api.github.com/users/sbosley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbosley/subscriptions","organizations_url":"https://api.github.com/users/sbosley/orgs","repos_url":"https://api.github.com/users/sbosley/repos","events_url":"https://api.github.com/users/sbosley/events{/privacy}","received_events_url":"https://api.github.com/users/sbosley/received_events","type":"User","site_admin":false},"body":"I bet that's been there since Astrid :)","created_at":"2015-08-04T16:19:31Z","updated_at":"2015-08-04T16:19:31Z","html_url":"https://github.com/yahoo/squidb/pull/67#discussion_r36208317","pull_request_url":"https://api.github.com/repos/yahoo/squidb/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/yahoo/squidb/pulls/comments/36208317"},"html":{"href":"https://github.com/yahoo/squidb/pull/67#discussion_r36208317"},"pull_request":{"href":"https://api.github.com/repos/yahoo/squidb/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/yahoo/squidb/pulls/67","id":41584728,"html_url":"https://github.com/yahoo/squidb/pull/67","diff_url":"https://github.com/yahoo/squidb/pull/67.diff","patch_url":"https://github.com/yahoo/squidb/pull/67.patch","issue_url":"https://api.github.com/repos/yahoo/squidb/issues/67","number":67,"state":"open","locked":false,"title":"Unified SquidDatabase [2.0]","user":{"login":"sbosley","id":622224,"avatar_url":"https://avatars.githubusercontent.com/u/622224?v=3","gravatar_id":"","url":"https://api.github.com/users/sbosley","html_url":"https://github.com/sbosley","followers_url":"https://api.github.com/users/sbosley/followers","following_url":"https://api.github.com/users/sbosley/following{/other_user}","gists_url":"https://api.github.com/users/sbosley/gists{/gist_id}","starred_url":"https://api.github.com/users/sbosley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbosley/subscriptions","organizations_url":"https://api.github.com/users/sbosley/orgs","repos_url":"https://api.github.com/users/sbosley/repos","events_url":"https://api.github.com/users/sbosley/events{/privacy}","received_events_url":"https://api.github.com/users/sbosley/received_events","type":"User","site_admin":false},"body":"This is a large api change intended for SquiDB 2.0. The basic idea is to merge the responsibilities of AbstractDatabase and DatabaseDao into a single, unified class called SquidDatabase. This has several benefits:\r\n\r\n* The fact that DatabaseDao wrapped an AbstractDatabase subclass made it hard to know what kind of database you were talking to, especially in apps with multiple databases. Now, all that's required is to subclass SquidDatabase instead of AbstractDatabase--that part of the api remains the same. But now, you can now talk directly to your SquidDatabase subclass for all database I/O, which means you always know what kind of database you're talking to.\r\n* You can define custom database access methods directly in your database subclass using dao methods without also needing to create a subclass of DatabaseDao\r\n* Dao methods that work with model objects are now easily available from hooks like onUpgrade() and onTablesCreated().\r\n\r\nFurther changes intended for SquiDB 2.0 will build on this foundation.","created_at":"2015-08-04T15:45:43Z","updated_at":"2015-08-04T16:19:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90520f13f560c87db9256cc687ba6edad79322b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yahoo/squidb/pulls/67/commits","review_comments_url":"https://api.github.com/repos/yahoo/squidb/pulls/67/comments","review_comment_url":"https://api.github.com/repos/yahoo/squidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yahoo/squidb/issues/67/comments","statuses_url":"https://api.github.com/repos/yahoo/squidb/statuses/aee47bb5685dda8f3e16f2b973d8e058d59aa4d1","head":{"label":"sbosley:unified_squid_database","ref":"unified_squid_database","sha":"aee47bb5685dda8f3e16f2b973d8e058d59aa4d1","user":{"login":"sbosley","id":622224,"avatar_url":"https://avatars.githubusercontent.com/u/622224?v=3","gravatar_id":"","url":"https://api.github.com/users/sbosley","html_url":"https://github.com/sbosley","followers_url":"https://api.github.com/users/sbosley/followers","following_url":"https://api.github.com/users/sbosley/following{/other_user}","gists_url":"https://api.github.com/users/sbosley/gists{/gist_id}","starred_url":"https://api.github.com/users/sbosley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbosley/subscriptions","organizations_url":"https://api.github.com/users/sbosley/orgs","repos_url":"https://api.github.com/users/sbosley/repos","events_url":"https://api.github.com/users/sbosley/events{/privacy}","received_events_url":"https://api.github.com/users/sbosley/received_events","type":"User","site_admin":false},"repo":{"id":34016211,"name":"squidb","full_name":"sbosley/squidb","owner":{"login":"sbosley","id":622224,"avatar_url":"https://avatars.githubusercontent.com/u/622224?v=3","gravatar_id":"","url":"https://api.github.com/users/sbosley","html_url":"https://github.com/sbosley","followers_url":"https://api.github.com/users/sbosley/followers","following_url":"https://api.github.com/users/sbosley/following{/other_user}","gists_url":"https://api.github.com/users/sbosley/gists{/gist_id}","starred_url":"https://api.github.com/users/sbosley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbosley/subscriptions","organizations_url":"https://api.github.com/users/sbosley/orgs","repos_url":"https://api.github.com/users/sbosley/repos","events_url":"https://api.github.com/users/sbosley/events{/privacy}","received_events_url":"https://api.github.com/users/sbosley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sbosley/squidb","description":"SquiDB is a SQLite database layer for Android","fork":true,"url":"https://api.github.com/repos/sbosley/squidb","forks_url":"https://api.github.com/repos/sbosley/squidb/forks","keys_url":"https://api.github.com/repos/sbosley/squidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbosley/squidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbosley/squidb/teams","hooks_url":"https://api.github.com/repos/sbosley/squidb/hooks","issue_events_url":"https://api.github.com/repos/sbosley/squidb/issues/events{/number}","events_url":"https://api.github.com/repos/sbosley/squidb/events","assignees_url":"https://api.github.com/repos/sbosley/squidb/assignees{/user}","branches_url":"https://api.github.com/repos/sbosley/squidb/branches{/branch}","tags_url":"https://api.github.com/repos/sbosley/squidb/tags","blobs_url":"https://api.github.com/repos/sbosley/squidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbosley/squidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbosley/squidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbosley/squidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbosley/squidb/statuses/{sha}","languages_url":"https://api.github.com/repos/sbosley/squidb/languages","stargazers_url":"https://api.github.com/repos/sbosley/squidb/stargazers","contributors_url":"https://api.github.com/repos/sbosley/squidb/contributors","subscribers_url":"https://api.github.com/repos/sbosley/squidb/subscribers","subscription_url":"https://api.github.com/repos/sbosley/squidb/subscription","commits_url":"https://api.github.com/repos/sbosley/squidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbosley/squidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbosley/squidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbosley/squidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbosley/squidb/contents/{+path}","compare_url":"https://api.github.com/repos/sbosley/squidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbosley/squidb/merges","archive_url":"https://api.github.com/repos/sbosley/squidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbosley/squidb/downloads","issues_url":"https://api.github.com/repos/sbosley/squidb/issues{/number}","pulls_url":"https://api.github.com/repos/sbosley/squidb/pulls{/number}","milestones_url":"https://api.github.com/repos/sbosley/squidb/milestones{/number}","notifications_url":"https://api.github.com/repos/sbosley/squidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbosley/squidb/labels{/name}","releases_url":"https://api.github.com/repos/sbosley/squidb/releases{/id}","created_at":"2015-04-15T20:13:50Z","updated_at":"2015-05-07T22:43:49Z","pushed_at":"2015-08-04T15:51:35Z","git_url":"git://github.com/sbosley/squidb.git","ssh_url":"git@github.com:sbosley/squidb.git","clone_url":"https://github.com/sbosley/squidb.git","svn_url":"https://github.com/sbosley/squidb","homepage":"https://github.com/yahoo/squidb/wiki","size":1921,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yahoo:dev_2.0","ref":"dev_2.0","sha":"297db8cc113fc0b11a1f1c0905775bdd89facca7","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":34006895,"name":"squidb","full_name":"yahoo/squidb","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/squidb","description":"SquiDB is a SQLite database layer for Android","fork":false,"url":"https://api.github.com/repos/yahoo/squidb","forks_url":"https://api.github.com/repos/yahoo/squidb/forks","keys_url":"https://api.github.com/repos/yahoo/squidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/squidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/squidb/teams","hooks_url":"https://api.github.com/repos/yahoo/squidb/hooks","issue_events_url":"https://api.github.com/repos/yahoo/squidb/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/squidb/events","assignees_url":"https://api.github.com/repos/yahoo/squidb/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/squidb/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/squidb/tags","blobs_url":"https://api.github.com/repos/yahoo/squidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/squidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/squidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/squidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/squidb/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/squidb/languages","stargazers_url":"https://api.github.com/repos/yahoo/squidb/stargazers","contributors_url":"https://api.github.com/repos/yahoo/squidb/contributors","subscribers_url":"https://api.github.com/repos/yahoo/squidb/subscribers","subscription_url":"https://api.github.com/repos/yahoo/squidb/subscription","commits_url":"https://api.github.com/repos/yahoo/squidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/squidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/squidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/squidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/squidb/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/squidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/squidb/merges","archive_url":"https://api.github.com/repos/yahoo/squidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/squidb/downloads","issues_url":"https://api.github.com/repos/yahoo/squidb/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/squidb/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/squidb/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/squidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/squidb/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/squidb/releases{/id}","created_at":"2015-04-15T16:54:33Z","updated_at":"2015-08-03T13:58:50Z","pushed_at":"2015-08-04T15:45:44Z","git_url":"git://github.com/yahoo/squidb.git","ssh_url":"git@github.com:yahoo/squidb.git","clone_url":"https://github.com/yahoo/squidb.git","svn_url":"https://github.com/yahoo/squidb","homepage":"https://github.com/yahoo/squidb/wiki","size":2509,"stargazers_count":941,"watchers_count":941,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":9,"forks":82,"open_issues":9,"watchers":941,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/squidb/pulls/67"},"html":{"href":"https://github.com/yahoo/squidb/pull/67"},"issue":{"href":"https://api.github.com/repos/yahoo/squidb/issues/67"},"comments":{"href":"https://api.github.com/repos/yahoo/squidb/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/squidb/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/squidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yahoo/squidb/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/squidb/statuses/aee47bb5685dda8f3e16f2b973d8e058d59aa4d1"}}}}