{"action":"created","comment":{"url":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments/48019293","id":48019293,"diff_hunk":"@@ -153,6 +153,8 @@ let pool_migrate ~__context ~vm ~host ~options =\n \t\traise (Api_errors.Server_error (Api_errors.vm_failed_shutdown_ack, []))\n \t| Xenops_interface.Cancelled _ ->\n \t\tTaskHelper.raise_cancelled ~__context\n+\t| Xenops_interface.Storage_backend_error _ ->\n+\t\traise (Api_errors.Server_error (Api_errors.sr_backend_failure, []))","path":"ocaml/xapi/xapi_vm_migrate.ml","position":5,"original_position":5,"commit_id":"3b4cd95c7b826333992e2095cd9170ce2ef59ad2","original_commit_id":"3b4cd95c7b826333992e2095cd9170ce2ef59ad2","user":{"login":"simonjbeaumont","id":1125539,"avatar_url":"https://avatars.githubusercontent.com/u/1125539?v=3","gravatar_id":"","url":"https://api.github.com/users/simonjbeaumont","html_url":"https://github.com/simonjbeaumont","followers_url":"https://api.github.com/users/simonjbeaumont/followers","following_url":"https://api.github.com/users/simonjbeaumont/following{/other_user}","gists_url":"https://api.github.com/users/simonjbeaumont/gists{/gist_id}","starred_url":"https://api.github.com/users/simonjbeaumont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonjbeaumont/subscriptions","organizations_url":"https://api.github.com/users/simonjbeaumont/orgs","repos_url":"https://api.github.com/users/simonjbeaumont/repos","events_url":"https://api.github.com/users/simonjbeaumont/events{/privacy}","received_events_url":"https://api.github.com/users/simonjbeaumont/received_events","type":"User","site_admin":false},"body":"Don't we have a number we can at least put in? I see you're discarding the value from the `Storage_backend_error` constructor. How is this normally raised by the XenAPI?","created_at":"2015-12-18T12:08:59Z","updated_at":"2015-12-18T12:08:59Z","html_url":"https://github.com/xapi-project/xen-api/pull/2543#discussion_r48019293","pull_request_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2543","_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments/48019293"},"html":{"href":"https://github.com/xapi-project/xen-api/pull/2543#discussion_r48019293"},"pull_request":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2543"}}},"pull_request":{"url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2543","id":54070177,"html_url":"https://github.com/xapi-project/xen-api/pull/2543","diff_url":"https://github.com/xapi-project/xen-api/pull/2543.diff","patch_url":"https://github.com/xapi-project/xen-api/pull/2543.patch","issue_url":"https://api.github.com/repos/xapi-project/xen-api/issues/2543","number":2543,"state":"open","locked":false,"title":"CA-186212: Handle Storage_backend_error during vm-migrate","user":{"login":"sharady","id":4865661,"avatar_url":"https://avatars.githubusercontent.com/u/4865661?v=3","gravatar_id":"","url":"https://api.github.com/users/sharady","html_url":"https://github.com/sharady","followers_url":"https://api.github.com/users/sharady/followers","following_url":"https://api.github.com/users/sharady/following{/other_user}","gists_url":"https://api.github.com/users/sharady/gists{/gist_id}","starred_url":"https://api.github.com/users/sharady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharady/subscriptions","organizations_url":"https://api.github.com/users/sharady/orgs","repos_url":"https://api.github.com/users/sharady/repos","events_url":"https://api.github.com/users/sharady/events{/privacy}","received_events_url":"https://api.github.com/users/sharady/received_events","type":"User","site_admin":false},"body":"During RPU: When vm-migrate is in progress and storage backend\r\nlosses connection to host. In such case xapi must handle\r\nStorage_backend_error.\r\n\r\nSigned-off-by: Sharad Yadav <sharad.yadav@citrix.com>","created_at":"2015-12-18T06:47:34Z","updated_at":"2015-12-18T12:08:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f30d4fd9a4e7ff42e4fe0fac7879b56609ad7559","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2543/commits","review_comments_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2543/comments","review_comment_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapi-project/xen-api/issues/2543/comments","statuses_url":"https://api.github.com/repos/xapi-project/xen-api/statuses/3b4cd95c7b826333992e2095cd9170ce2ef59ad2","head":{"label":"sharady:CA-186212","ref":"CA-186212","sha":"3b4cd95c7b826333992e2095cd9170ce2ef59ad2","user":{"login":"sharady","id":4865661,"avatar_url":"https://avatars.githubusercontent.com/u/4865661?v=3","gravatar_id":"","url":"https://api.github.com/users/sharady","html_url":"https://github.com/sharady","followers_url":"https://api.github.com/users/sharady/followers","following_url":"https://api.github.com/users/sharady/following{/other_user}","gists_url":"https://api.github.com/users/sharady/gists{/gist_id}","starred_url":"https://api.github.com/users/sharady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharady/subscriptions","organizations_url":"https://api.github.com/users/sharady/orgs","repos_url":"https://api.github.com/users/sharady/repos","events_url":"https://api.github.com/users/sharady/events{/privacy}","received_events_url":"https://api.github.com/users/sharady/received_events","type":"User","site_admin":false},"repo":{"id":24841127,"name":"xen-api","full_name":"sharady/xen-api","owner":{"login":"sharady","id":4865661,"avatar_url":"https://avatars.githubusercontent.com/u/4865661?v=3","gravatar_id":"","url":"https://api.github.com/users/sharady","html_url":"https://github.com/sharady","followers_url":"https://api.github.com/users/sharady/followers","following_url":"https://api.github.com/users/sharady/following{/other_user}","gists_url":"https://api.github.com/users/sharady/gists{/gist_id}","starred_url":"https://api.github.com/users/sharady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharady/subscriptions","organizations_url":"https://api.github.com/users/sharady/orgs","repos_url":"https://api.github.com/users/sharady/repos","events_url":"https://api.github.com/users/sharady/events{/privacy}","received_events_url":"https://api.github.com/users/sharady/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sharady/xen-api","description":"The Xapi Project's XenAPI Server","fork":true,"url":"https://api.github.com/repos/sharady/xen-api","forks_url":"https://api.github.com/repos/sharady/xen-api/forks","keys_url":"https://api.github.com/repos/sharady/xen-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sharady/xen-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sharady/xen-api/teams","hooks_url":"https://api.github.com/repos/sharady/xen-api/hooks","issue_events_url":"https://api.github.com/repos/sharady/xen-api/issues/events{/number}","events_url":"https://api.github.com/repos/sharady/xen-api/events","assignees_url":"https://api.github.com/repos/sharady/xen-api/assignees{/user}","branches_url":"https://api.github.com/repos/sharady/xen-api/branches{/branch}","tags_url":"https://api.github.com/repos/sharady/xen-api/tags","blobs_url":"https://api.github.com/repos/sharady/xen-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sharady/xen-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sharady/xen-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/sharady/xen-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sharady/xen-api/statuses/{sha}","languages_url":"https://api.github.com/repos/sharady/xen-api/languages","stargazers_url":"https://api.github.com/repos/sharady/xen-api/stargazers","contributors_url":"https://api.github.com/repos/sharady/xen-api/contributors","subscribers_url":"https://api.github.com/repos/sharady/xen-api/subscribers","subscription_url":"https://api.github.com/repos/sharady/xen-api/subscription","commits_url":"https://api.github.com/repos/sharady/xen-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/sharady/xen-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/sharady/xen-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/sharady/xen-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/sharady/xen-api/contents/{+path}","compare_url":"https://api.github.com/repos/sharady/xen-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sharady/xen-api/merges","archive_url":"https://api.github.com/repos/sharady/xen-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sharady/xen-api/downloads","issues_url":"https://api.github.com/repos/sharady/xen-api/issues{/number}","pulls_url":"https://api.github.com/repos/sharady/xen-api/pulls{/number}","milestones_url":"https://api.github.com/repos/sharady/xen-api/milestones{/number}","notifications_url":"https://api.github.com/repos/sharady/xen-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sharady/xen-api/labels{/name}","releases_url":"https://api.github.com/repos/sharady/xen-api/releases{/id}","created_at":"2014-10-06T10:05:17Z","updated_at":"2014-09-25T07:06:19Z","pushed_at":"2015-12-18T06:45:19Z","git_url":"git://github.com/sharady/xen-api.git","ssh_url":"git@github.com:sharady/xen-api.git","clone_url":"https://github.com/sharady/xen-api.git","svn_url":"https://github.com/sharady/xen-api","homepage":"http://xenproject.org/developers/teams/xapi.html","size":29651,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xapi-project:master","ref":"master","sha":"cf58e3e44f9d82c9155591af44b4a7786ea8003c","user":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars.githubusercontent.com/u/317268?v=3","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"repo":{"id":960233,"name":"xen-api","full_name":"xapi-project/xen-api","owner":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars.githubusercontent.com/u/317268?v=3","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapi-project/xen-api","description":"The Xapi Project's XenAPI Server","fork":false,"url":"https://api.github.com/repos/xapi-project/xen-api","forks_url":"https://api.github.com/repos/xapi-project/xen-api/forks","keys_url":"https://api.github.com/repos/xapi-project/xen-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapi-project/xen-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapi-project/xen-api/teams","hooks_url":"https://api.github.com/repos/xapi-project/xen-api/hooks","issue_events_url":"https://api.github.com/repos/xapi-project/xen-api/issues/events{/number}","events_url":"https://api.github.com/repos/xapi-project/xen-api/events","assignees_url":"https://api.github.com/repos/xapi-project/xen-api/assignees{/user}","branches_url":"https://api.github.com/repos/xapi-project/xen-api/branches{/branch}","tags_url":"https://api.github.com/repos/xapi-project/xen-api/tags","blobs_url":"https://api.github.com/repos/xapi-project/xen-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapi-project/xen-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapi-project/xen-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapi-project/xen-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapi-project/xen-api/statuses/{sha}","languages_url":"https://api.github.com/repos/xapi-project/xen-api/languages","stargazers_url":"https://api.github.com/repos/xapi-project/xen-api/stargazers","contributors_url":"https://api.github.com/repos/xapi-project/xen-api/contributors","subscribers_url":"https://api.github.com/repos/xapi-project/xen-api/subscribers","subscription_url":"https://api.github.com/repos/xapi-project/xen-api/subscription","commits_url":"https://api.github.com/repos/xapi-project/xen-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapi-project/xen-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapi-project/xen-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapi-project/xen-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapi-project/xen-api/contents/{+path}","compare_url":"https://api.github.com/repos/xapi-project/xen-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapi-project/xen-api/merges","archive_url":"https://api.github.com/repos/xapi-project/xen-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapi-project/xen-api/downloads","issues_url":"https://api.github.com/repos/xapi-project/xen-api/issues{/number}","pulls_url":"https://api.github.com/repos/xapi-project/xen-api/pulls{/number}","milestones_url":"https://api.github.com/repos/xapi-project/xen-api/milestones{/number}","notifications_url":"https://api.github.com/repos/xapi-project/xen-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapi-project/xen-api/labels{/name}","releases_url":"https://api.github.com/repos/xapi-project/xen-api/releases{/id}","created_at":"2010-10-04T10:52:57Z","updated_at":"2015-12-17T23:49:02Z","pushed_at":"2015-12-18T12:08:27Z","git_url":"git://github.com/xapi-project/xen-api.git","ssh_url":"git@github.com:xapi-project/xen-api.git","clone_url":"https://github.com/xapi-project/xen-api.git","svn_url":"https://github.com/xapi-project/xen-api","homepage":"http://xenproject.org/developers/teams/xapi.html","size":30581,"stargazers_count":195,"watchers_count":195,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"open_issues_count":18,"forks":141,"open_issues":18,"watchers":195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2543"},"html":{"href":"https://github.com/xapi-project/xen-api/pull/2543"},"issue":{"href":"https://api.github.com/repos/xapi-project/xen-api/issues/2543"},"comments":{"href":"https://api.github.com/repos/xapi-project/xen-api/issues/2543/comments"},"review_comments":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2543/comments"},"review_comment":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2543/commits"},"statuses":{"href":"https://api.github.com/repos/xapi-project/xen-api/statuses/3b4cd95c7b826333992e2095cd9170ce2ef59ad2"}}}}