{"action":"created","issue":{"url":"https://api.github.com/repos/seomoz/qless-java/issues/38","labels_url":"https://api.github.com/repos/seomoz/qless-java/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/seomoz/qless-java/issues/38/comments","events_url":"https://api.github.com/repos/seomoz/qless-java/issues/38/events","html_url":"https://github.com/seomoz/qless-java/issues/38","id":87086269,"number":38,"title":"`Client implements Closeable`?","user":{"login":"phs","id":36229,"avatar_url":"https://avatars.githubusercontent.com/u/36229?v=3","gravatar_id":"","url":"https://api.github.com/users/phs","html_url":"https://github.com/phs","followers_url":"https://api.github.com/users/phs/followers","following_url":"https://api.github.com/users/phs/following{/other_user}","gists_url":"https://api.github.com/users/phs/gists{/gist_id}","starred_url":"https://api.github.com/users/phs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phs/subscriptions","organizations_url":"https://api.github.com/users/phs/orgs","repos_url":"https://api.github.com/users/phs/repos","events_url":"https://api.github.com/users/phs/events{/privacy}","received_events_url":"https://api.github.com/users/phs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-06-10T19:54:53Z","updated_at":"2015-08-20T18:04:45Z","closed_at":null,"body":"That jedis pool looks like it could use a `close()`..."},"comment":{"url":"https://api.github.com/repos/seomoz/qless-java/issues/comments/133100232","html_url":"https://github.com/seomoz/qless-java/issues/38#issuecomment-133100232","issue_url":"https://api.github.com/repos/seomoz/qless-java/issues/38","id":133100232,"user":{"login":"b4hand","id":708767,"avatar_url":"https://avatars.githubusercontent.com/u/708767?v=3","gravatar_id":"","url":"https://api.github.com/users/b4hand","html_url":"https://github.com/b4hand","followers_url":"https://api.github.com/users/b4hand/followers","following_url":"https://api.github.com/users/b4hand/following{/other_user}","gists_url":"https://api.github.com/users/b4hand/gists{/gist_id}","starred_url":"https://api.github.com/users/b4hand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b4hand/subscriptions","organizations_url":"https://api.github.com/users/b4hand/orgs","repos_url":"https://api.github.com/users/b4hand/repos","events_url":"https://api.github.com/users/b4hand/events{/privacy}","received_events_url":"https://api.github.com/users/b4hand/received_events","type":"User","site_admin":false},"created_at":"2015-08-20T18:04:45Z","updated_at":"2015-08-20T18:04:45Z","body":"I was saying that if I add a `close` method to `Client` that calling `close` on the `JedisPool` feels skeevy. I think your code above was a reasonable workaround especially if you're already explicitly passing the pool in via the constructor.\r\n\r\nThe weirdness is due to there being a default constructor that automatically constructs the `JedisPool` for you. In that case, it is clear the `Client` should `close` the `JedisPool` for you since it *owns* the pool, but when you pass the pool in, it would imply that it is the *callers* responsibility to close the pool. "}}