{"action":"created","issue":{"url":"https://api.github.com/repos/thoughtbot/clearance/issues/500","labels_url":"https://api.github.com/repos/thoughtbot/clearance/issues/500/labels{/name}","comments_url":"https://api.github.com/repos/thoughtbot/clearance/issues/500/comments","events_url":"https://api.github.com/repos/thoughtbot/clearance/issues/500/events","html_url":"https://github.com/thoughtbot/clearance/pull/500","id":53123797,"number":500,"title":"Dont set cookie header if not present","user":{"login":"arthurnn","id":833383,"avatar_url":"https://avatars.githubusercontent.com/u/833383?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurnn","html_url":"https://github.com/arthurnn","followers_url":"https://api.github.com/users/arthurnn/followers","following_url":"https://api.github.com/users/arthurnn/following{/other_user}","gists_url":"https://api.github.com/users/arthurnn/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurnn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurnn/subscriptions","organizations_url":"https://api.github.com/users/arthurnn/orgs","repos_url":"https://api.github.com/users/arthurnn/repos","events_url":"https://api.github.com/users/arthurnn/events{/privacy}","received_events_url":"https://api.github.com/users/arthurnn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2014-12-30T15:39:13Z","updated_at":"2015-01-07T01:21:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thoughtbot/clearance/pulls/500","html_url":"https://github.com/thoughtbot/clearance/pull/500","diff_url":"https://github.com/thoughtbot/clearance/pull/500.diff","patch_url":"https://github.com/thoughtbot/clearance/pull/500.patch"},"body":"[fixes #338]\r\n\r\nTrying to fix this problem on rubygems.org which uses clearance. The problem is well described in the issue.\r\n\r\n### Solution\r\nclearance always set the response cookie, even when is emtpy, so when doing a redirect, http->https, it would set an empty cookie, which is not what we want.\r\nI cannot see any problem about not setting the cookie when it is empty. (please let me know if I miss something)\r\n\r\nI hope CI passes, as I could not run tests locally ( see error: https://gist.github.com/arthurnn/e4bc23aecdc052870b0d )\r\n\r\nreview @derekprior"},"comment":{"url":"https://api.github.com/repos/thoughtbot/clearance/issues/comments/68964803","html_url":"https://github.com/thoughtbot/clearance/pull/500#issuecomment-68964803","issue_url":"https://api.github.com/repos/thoughtbot/clearance/issues/500","id":68964803,"user":{"login":"derekprior","id":152152,"avatar_url":"https://avatars.githubusercontent.com/u/152152?v=3","gravatar_id":"","url":"https://api.github.com/users/derekprior","html_url":"https://github.com/derekprior","followers_url":"https://api.github.com/users/derekprior/followers","following_url":"https://api.github.com/users/derekprior/following{/other_user}","gists_url":"https://api.github.com/users/derekprior/gists{/gist_id}","starred_url":"https://api.github.com/users/derekprior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekprior/subscriptions","organizations_url":"https://api.github.com/users/derekprior/orgs","repos_url":"https://api.github.com/users/derekprior/repos","events_url":"https://api.github.com/users/derekprior/events{/privacy}","received_events_url":"https://api.github.com/users/derekprior/received_events","type":"User","site_admin":false},"created_at":"2015-01-07T01:21:47Z","updated_at":"2015-01-07T01:21:47Z","body":"looks like a really good find, thanks. I'm going to play with this a bit in some test apps to make sure I'm not missing something, but this looks good."}}