{"action":"created","comment":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/36146210","id":36146210,"diff_hunk":"@@ -62,6 +62,7 @@ POSSIBILITY OF SUCH DAMAGE.\n \n #ifdef TORRENT_DISK_STATS\n #include \"libtorrent/io.hpp\"\n+#include \"libtorrent/storage.hpp\"","path":"src/file.cpp","position":4,"original_position":4,"commit_id":"fcce48351cf2b65ba804825d24707beadb0dfbbc","original_commit_id":"fcce48351cf2b65ba804825d24707beadb0dfbbc","user":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"body":"I'm not super excited about this dependency, is it important?","created_at":"2015-08-04T00:15:36Z","updated_at":"2015-08-04T00:15:36Z","html_url":"https://github.com/arvidn/libtorrent/pull/65#discussion_r36146210","pull_request_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/36146210"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/65#discussion_r36146210"},"pull_request":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/65","id":41434378,"html_url":"https://github.com/arvidn/libtorrent/pull/65","diff_url":"https://github.com/arvidn/libtorrent/pull/65.diff","patch_url":"https://github.com/arvidn/libtorrent/pull/65.patch","issue_url":"https://api.github.com/repos/arvidn/libtorrent/issues/65","number":65,"state":"open","locked":false,"title":"Moved TORRENT_DISK_STATS to default_storage","user":{"login":"aldenml","id":143813,"avatar_url":"https://avatars.githubusercontent.com/u/143813?v=3","gravatar_id":"","url":"https://api.github.com/users/aldenml","html_url":"https://github.com/aldenml","followers_url":"https://api.github.com/users/aldenml/followers","following_url":"https://api.github.com/users/aldenml/following{/other_user}","gists_url":"https://api.github.com/users/aldenml/gists{/gist_id}","starred_url":"https://api.github.com/users/aldenml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldenml/subscriptions","organizations_url":"https://api.github.com/users/aldenml/orgs","repos_url":"https://api.github.com/users/aldenml/repos","events_url":"https://api.github.com/users/aldenml/events{/privacy}","received_events_url":"https://api.github.com/users/aldenml/received_events","type":"User","site_admin":false},"body":"The previous implementation while convenient have the drawback of relying in the constructor and destructor of disk_io_thread. However, the use of this class in `set_piece_hashes` void the assumption of just one creation and deletion of g_access_log.\r\n\r\nNow the responsibility is to the library caller and it could be enable/disable at any point during runtime. This allow the compilation of the library with the flag `<disk-stats>on` without penalty.","created_at":"2015-08-03T04:35:19Z","updated_at":"2015-08-04T00:15:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b48720ca164cdf58c27643e950387b3b2f0d8e3d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/65/commits","review_comments_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/65/comments","review_comment_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/issues/65/comments","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/fcce48351cf2b65ba804825d24707beadb0dfbbc","head":{"label":"aldenml:file-access-log-parameter","ref":"file-access-log-parameter","sha":"fcce48351cf2b65ba804825d24707beadb0dfbbc","user":{"login":"aldenml","id":143813,"avatar_url":"https://avatars.githubusercontent.com/u/143813?v=3","gravatar_id":"","url":"https://api.github.com/users/aldenml","html_url":"https://github.com/aldenml","followers_url":"https://api.github.com/users/aldenml/followers","following_url":"https://api.github.com/users/aldenml/following{/other_user}","gists_url":"https://api.github.com/users/aldenml/gists{/gist_id}","starred_url":"https://api.github.com/users/aldenml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldenml/subscriptions","organizations_url":"https://api.github.com/users/aldenml/orgs","repos_url":"https://api.github.com/users/aldenml/repos","events_url":"https://api.github.com/users/aldenml/events{/privacy}","received_events_url":"https://api.github.com/users/aldenml/received_events","type":"User","site_admin":false},"repo":{"id":37677407,"name":"libtorrent","full_name":"aldenml/libtorrent","owner":{"login":"aldenml","id":143813,"avatar_url":"https://avatars.githubusercontent.com/u/143813?v=3","gravatar_id":"","url":"https://api.github.com/users/aldenml","html_url":"https://github.com/aldenml","followers_url":"https://api.github.com/users/aldenml/followers","following_url":"https://api.github.com/users/aldenml/following{/other_user}","gists_url":"https://api.github.com/users/aldenml/gists{/gist_id}","starred_url":"https://api.github.com/users/aldenml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldenml/subscriptions","organizations_url":"https://api.github.com/users/aldenml/orgs","repos_url":"https://api.github.com/users/aldenml/repos","events_url":"https://api.github.com/users/aldenml/events{/privacy}","received_events_url":"https://api.github.com/users/aldenml/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aldenml/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":true,"url":"https://api.github.com/repos/aldenml/libtorrent","forks_url":"https://api.github.com/repos/aldenml/libtorrent/forks","keys_url":"https://api.github.com/repos/aldenml/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aldenml/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aldenml/libtorrent/teams","hooks_url":"https://api.github.com/repos/aldenml/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/aldenml/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/aldenml/libtorrent/events","assignees_url":"https://api.github.com/repos/aldenml/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/aldenml/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/aldenml/libtorrent/tags","blobs_url":"https://api.github.com/repos/aldenml/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aldenml/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aldenml/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/aldenml/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aldenml/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/aldenml/libtorrent/languages","stargazers_url":"https://api.github.com/repos/aldenml/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/aldenml/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/aldenml/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/aldenml/libtorrent/subscription","commits_url":"https://api.github.com/repos/aldenml/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/aldenml/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/aldenml/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/aldenml/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/aldenml/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/aldenml/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aldenml/libtorrent/merges","archive_url":"https://api.github.com/repos/aldenml/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aldenml/libtorrent/downloads","issues_url":"https://api.github.com/repos/aldenml/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/aldenml/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/aldenml/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/aldenml/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aldenml/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/aldenml/libtorrent/releases{/id}","created_at":"2015-06-18T18:31:58Z","updated_at":"2015-06-18T18:32:00Z","pushed_at":"2015-08-03T23:53:32Z","git_url":"git://github.com/aldenml/libtorrent.git","ssh_url":"git@github.com:aldenml/libtorrent.git","clone_url":"https://github.com/aldenml/libtorrent.git","svn_url":"https://github.com/aldenml/libtorrent","homepage":"http://libtorrent.org","size":45333,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arvidn:master","ref":"master","sha":"661a595cb053ab00443b4354b469522af3b4a322","user":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"repo":{"id":36781769,"name":"libtorrent","full_name":"arvidn/libtorrent","owner":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arvidn/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":false,"url":"https://api.github.com/repos/arvidn/libtorrent","forks_url":"https://api.github.com/repos/arvidn/libtorrent/forks","keys_url":"https://api.github.com/repos/arvidn/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arvidn/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arvidn/libtorrent/teams","hooks_url":"https://api.github.com/repos/arvidn/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/arvidn/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/arvidn/libtorrent/events","assignees_url":"https://api.github.com/repos/arvidn/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/arvidn/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/arvidn/libtorrent/tags","blobs_url":"https://api.github.com/repos/arvidn/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arvidn/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arvidn/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/arvidn/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/arvidn/libtorrent/languages","stargazers_url":"https://api.github.com/repos/arvidn/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/arvidn/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/arvidn/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/arvidn/libtorrent/subscription","commits_url":"https://api.github.com/repos/arvidn/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/arvidn/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/arvidn/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/arvidn/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/arvidn/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arvidn/libtorrent/merges","archive_url":"https://api.github.com/repos/arvidn/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arvidn/libtorrent/downloads","issues_url":"https://api.github.com/repos/arvidn/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/arvidn/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/arvidn/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/arvidn/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arvidn/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/arvidn/libtorrent/releases{/id}","created_at":"2015-06-03T05:22:03Z","updated_at":"2015-08-03T19:49:17Z","pushed_at":"2015-08-03T23:53:32Z","git_url":"git://github.com/arvidn/libtorrent.git","ssh_url":"git@github.com:arvidn/libtorrent.git","clone_url":"https://github.com/arvidn/libtorrent.git","svn_url":"https://github.com/arvidn/libtorrent","homepage":"http://libtorrent.org","size":65471,"stargazers_count":71,"watchers_count":71,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":19,"forks":21,"open_issues":19,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/65"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/65"},"issue":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/65"},"comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/arvidn/libtorrent/statuses/fcce48351cf2b65ba804825d24707beadb0dfbbc"}}}}