{"action":"created","comment":{"url":"https://api.github.com/repos/HyperSuprime-Cam/afw/pulls/comments/33002581","id":33002581,"diff_hunk":"@@ -290,50 +290,39 @@ bool Footprint::contains(\n }\n \n namespace {\n+\n+/// Predicate for removing spans outside a bbox\n+struct ClipSpansPredicate : public std::unary_function<PTR(Span) const&, bool> {\n+    geom::Box2I const& bbox;\n+    ClipSpansPredicate(geom::Box2I const& _bbox) : bbox(_bbox) {}\n+    bool operator()(PTR(Span) const& spanPtr) const {\n+        Span const& span = *spanPtr;\n+        int const y = span.getY();\n+        return (y < bbox.getMinY() || y > bbox.getMaxY() ||\n+                span.getX0() > bbox.getMaxX() || span.getX1() < bbox.getMinX());\n+    }\n+};","path":"src/detection/Footprint.cc","position":15,"original_position":15,"commit_id":"ca9615e623821748fda1ad61bc17534381b338a1","original_commit_id":"ca9615e623821748fda1ad61bc17534381b338a1","user":{"login":"TallJimbo","id":1330720,"avatar_url":"https://avatars.githubusercontent.com/u/1330720?v=3","gravatar_id":"","url":"https://api.github.com/users/TallJimbo","html_url":"https://github.com/TallJimbo","followers_url":"https://api.github.com/users/TallJimbo/followers","following_url":"https://api.github.com/users/TallJimbo/following{/other_user}","gists_url":"https://api.github.com/users/TallJimbo/gists{/gist_id}","starred_url":"https://api.github.com/users/TallJimbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TallJimbo/subscriptions","organizations_url":"https://api.github.com/users/TallJimbo/orgs","repos_url":"https://api.github.com/users/TallJimbo/repos","events_url":"https://api.github.com/users/TallJimbo/events{/privacy}","received_events_url":"https://api.github.com/users/TallJimbo/received_events","type":"User","site_admin":false},"body":"A bit of vertical whitespace in this struct would make it much more readable.","created_at":"2015-06-23T01:33:38Z","updated_at":"2015-06-23T01:33:38Z","html_url":"https://github.com/HyperSuprime-Cam/afw/pull/2#discussion_r33002581","pull_request_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/HyperSuprime-Cam/afw/pulls/comments/33002581"},"html":{"href":"https://github.com/HyperSuprime-Cam/afw/pull/2#discussion_r33002581"},"pull_request":{"href":"https://api.github.com/repos/HyperSuprime-Cam/afw/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/HyperSuprime-Cam/afw/pulls/2","id":38293641,"html_url":"https://github.com/HyperSuprime-Cam/afw/pull/2","diff_url":"https://github.com/HyperSuprime-Cam/afw/pull/2.diff","patch_url":"https://github.com/HyperSuprime-Cam/afw/pull/2.patch","issue_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/issues/2","number":2,"state":"open","locked":false,"title":"afw review for tickets/HSC-1274: deblender optimization","user":{"login":"TallJimbo","id":1330720,"avatar_url":"https://avatars.githubusercontent.com/u/1330720?v=3","gravatar_id":"","url":"https://api.github.com/users/TallJimbo","html_url":"https://github.com/TallJimbo","followers_url":"https://api.github.com/users/TallJimbo/followers","following_url":"https://api.github.com/users/TallJimbo/following{/other_user}","gists_url":"https://api.github.com/users/TallJimbo/gists{/gist_id}","starred_url":"https://api.github.com/users/TallJimbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TallJimbo/subscriptions","organizations_url":"https://api.github.com/users/TallJimbo/orgs","repos_url":"https://api.github.com/users/TallJimbo/repos","events_url":"https://api.github.com/users/TallJimbo/events{/privacy}","received_events_url":"https://api.github.com/users/TallJimbo/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-23T01:31:01Z","updated_at":"2015-06-23T01:33:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84817ce713e74adc4909d4995697c796d21a10f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/pulls/2/commits","review_comments_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/pulls/2/comments","review_comment_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/issues/2/comments","statuses_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/statuses/ca9615e623821748fda1ad61bc17534381b338a1","head":{"label":"HyperSuprime-Cam:tickets/HSC-1274","ref":"tickets/HSC-1274","sha":"ca9615e623821748fda1ad61bc17534381b338a1","user":{"login":"HyperSuprime-Cam","id":6607948,"avatar_url":"https://avatars.githubusercontent.com/u/6607948?v=3","gravatar_id":"","url":"https://api.github.com/users/HyperSuprime-Cam","html_url":"https://github.com/HyperSuprime-Cam","followers_url":"https://api.github.com/users/HyperSuprime-Cam/followers","following_url":"https://api.github.com/users/HyperSuprime-Cam/following{/other_user}","gists_url":"https://api.github.com/users/HyperSuprime-Cam/gists{/gist_id}","starred_url":"https://api.github.com/users/HyperSuprime-Cam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyperSuprime-Cam/subscriptions","organizations_url":"https://api.github.com/users/HyperSuprime-Cam/orgs","repos_url":"https://api.github.com/users/HyperSuprime-Cam/repos","events_url":"https://api.github.com/users/HyperSuprime-Cam/events{/privacy}","received_events_url":"https://api.github.com/users/HyperSuprime-Cam/received_events","type":"Organization","site_admin":false},"repo":{"id":16622395,"name":"afw","full_name":"HyperSuprime-Cam/afw","owner":{"login":"HyperSuprime-Cam","id":6607948,"avatar_url":"https://avatars.githubusercontent.com/u/6607948?v=3","gravatar_id":"","url":"https://api.github.com/users/HyperSuprime-Cam","html_url":"https://github.com/HyperSuprime-Cam","followers_url":"https://api.github.com/users/HyperSuprime-Cam/followers","following_url":"https://api.github.com/users/HyperSuprime-Cam/following{/other_user}","gists_url":"https://api.github.com/users/HyperSuprime-Cam/gists{/gist_id}","starred_url":"https://api.github.com/users/HyperSuprime-Cam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyperSuprime-Cam/subscriptions","organizations_url":"https://api.github.com/users/HyperSuprime-Cam/orgs","repos_url":"https://api.github.com/users/HyperSuprime-Cam/repos","events_url":"https://api.github.com/users/HyperSuprime-Cam/events{/privacy}","received_events_url":"https://api.github.com/users/HyperSuprime-Cam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HyperSuprime-Cam/afw","description":"","fork":false,"url":"https://api.github.com/repos/HyperSuprime-Cam/afw","forks_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/forks","keys_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/teams","hooks_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/hooks","issue_events_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/issues/events{/number}","events_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/events","assignees_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/assignees{/user}","branches_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/branches{/branch}","tags_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/tags","blobs_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/git/refs{/sha}","trees_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/statuses/{sha}","languages_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/languages","stargazers_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/stargazers","contributors_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/contributors","subscribers_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/subscribers","subscription_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/subscription","commits_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/commits{/sha}","git_commits_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/git/commits{/sha}","comments_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/comments{/number}","issue_comment_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/issues/comments{/number}","contents_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/contents/{+path}","compare_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/merges","archive_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/downloads","issues_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/issues{/number}","pulls_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/pulls{/number}","milestones_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/milestones{/number}","notifications_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/labels{/name}","releases_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/releases{/id}","created_at":"2014-02-07T17:45:36Z","updated_at":"2015-04-24T17:22:32Z","pushed_at":"2015-06-23T01:31:03Z","git_url":"git://github.com/HyperSuprime-Cam/afw.git","ssh_url":"git@github.com:HyperSuprime-Cam/afw.git","clone_url":"https://github.com/HyperSuprime-Cam/afw.git","svn_url":"https://github.com/HyperSuprime-Cam/afw","homepage":null,"size":42616,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"HyperSuprime-Cam:master","ref":"master","sha":"d95a73a5c8ee851ecc8e36fbf71c93d869342121","user":{"login":"HyperSuprime-Cam","id":6607948,"avatar_url":"https://avatars.githubusercontent.com/u/6607948?v=3","gravatar_id":"","url":"https://api.github.com/users/HyperSuprime-Cam","html_url":"https://github.com/HyperSuprime-Cam","followers_url":"https://api.github.com/users/HyperSuprime-Cam/followers","following_url":"https://api.github.com/users/HyperSuprime-Cam/following{/other_user}","gists_url":"https://api.github.com/users/HyperSuprime-Cam/gists{/gist_id}","starred_url":"https://api.github.com/users/HyperSuprime-Cam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyperSuprime-Cam/subscriptions","organizations_url":"https://api.github.com/users/HyperSuprime-Cam/orgs","repos_url":"https://api.github.com/users/HyperSuprime-Cam/repos","events_url":"https://api.github.com/users/HyperSuprime-Cam/events{/privacy}","received_events_url":"https://api.github.com/users/HyperSuprime-Cam/received_events","type":"Organization","site_admin":false},"repo":{"id":16622395,"name":"afw","full_name":"HyperSuprime-Cam/afw","owner":{"login":"HyperSuprime-Cam","id":6607948,"avatar_url":"https://avatars.githubusercontent.com/u/6607948?v=3","gravatar_id":"","url":"https://api.github.com/users/HyperSuprime-Cam","html_url":"https://github.com/HyperSuprime-Cam","followers_url":"https://api.github.com/users/HyperSuprime-Cam/followers","following_url":"https://api.github.com/users/HyperSuprime-Cam/following{/other_user}","gists_url":"https://api.github.com/users/HyperSuprime-Cam/gists{/gist_id}","starred_url":"https://api.github.com/users/HyperSuprime-Cam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyperSuprime-Cam/subscriptions","organizations_url":"https://api.github.com/users/HyperSuprime-Cam/orgs","repos_url":"https://api.github.com/users/HyperSuprime-Cam/repos","events_url":"https://api.github.com/users/HyperSuprime-Cam/events{/privacy}","received_events_url":"https://api.github.com/users/HyperSuprime-Cam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HyperSuprime-Cam/afw","description":"","fork":false,"url":"https://api.github.com/repos/HyperSuprime-Cam/afw","forks_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/forks","keys_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/teams","hooks_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/hooks","issue_events_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/issues/events{/number}","events_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/events","assignees_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/assignees{/user}","branches_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/branches{/branch}","tags_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/tags","blobs_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/git/refs{/sha}","trees_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/statuses/{sha}","languages_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/languages","stargazers_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/stargazers","contributors_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/contributors","subscribers_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/subscribers","subscription_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/subscription","commits_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/commits{/sha}","git_commits_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/git/commits{/sha}","comments_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/comments{/number}","issue_comment_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/issues/comments{/number}","contents_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/contents/{+path}","compare_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/merges","archive_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/downloads","issues_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/issues{/number}","pulls_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/pulls{/number}","milestones_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/milestones{/number}","notifications_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/labels{/name}","releases_url":"https://api.github.com/repos/HyperSuprime-Cam/afw/releases{/id}","created_at":"2014-02-07T17:45:36Z","updated_at":"2015-04-24T17:22:32Z","pushed_at":"2015-06-23T01:31:03Z","git_url":"git://github.com/HyperSuprime-Cam/afw.git","ssh_url":"git@github.com:HyperSuprime-Cam/afw.git","clone_url":"https://github.com/HyperSuprime-Cam/afw.git","svn_url":"https://github.com/HyperSuprime-Cam/afw","homepage":null,"size":42616,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HyperSuprime-Cam/afw/pulls/2"},"html":{"href":"https://github.com/HyperSuprime-Cam/afw/pull/2"},"issue":{"href":"https://api.github.com/repos/HyperSuprime-Cam/afw/issues/2"},"comments":{"href":"https://api.github.com/repos/HyperSuprime-Cam/afw/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/HyperSuprime-Cam/afw/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/HyperSuprime-Cam/afw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HyperSuprime-Cam/afw/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/HyperSuprime-Cam/afw/statuses/ca9615e623821748fda1ad61bc17534381b338a1"}}}}