{"action":"created","comment":{"url":"https://api.github.com/repos/patrickod/noisebridge-donate/pulls/comments/28656055","id":28656055,"diff_hunk":"@@ -0,0 +1,10 @@\n+class ErrorsController < ApplicationController\n+  def file_not_found","path":"app/controllers/errors_controller.rb","position":2,"original_position":2,"commit_id":"dfb4a6740d6f5ebd5511e7a585a04e9437105304","original_commit_id":"dfb4a6740d6f5ebd5511e7a585a04e9437105304","user":{"login":"patrickod","id":84262,"avatar_url":"https://avatars.githubusercontent.com/u/84262?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickod","html_url":"https://github.com/patrickod","followers_url":"https://api.github.com/users/patrickod/followers","following_url":"https://api.github.com/users/patrickod/following{/other_user}","gists_url":"https://api.github.com/users/patrickod/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickod/subscriptions","organizations_url":"https://api.github.com/users/patrickod/orgs","repos_url":"https://api.github.com/users/patrickod/repos","events_url":"https://api.github.com/users/patrickod/events{/privacy}","received_events_url":"https://api.github.com/users/patrickod/received_events","type":"User","site_admin":false},"body":"I think we can just have these controllers return `head :$status`. This gets rid of the exception type behavior that Rails is using to treat 404s, and keeps the return codes consistent","created_at":"2015-04-19T19:53:54Z","updated_at":"2015-04-19T19:53:54Z","html_url":"https://github.com/patrickod/noisebridge-donate/pull/18#discussion_r28656055","pull_request_url":"https://api.github.com/repos/patrickod/noisebridge-donate/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/patrickod/noisebridge-donate/pulls/comments/28656055"},"html":{"href":"https://github.com/patrickod/noisebridge-donate/pull/18#discussion_r28656055"},"pull_request":{"href":"https://api.github.com/repos/patrickod/noisebridge-donate/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/patrickod/noisebridge-donate/pulls/18","id":33615108,"html_url":"https://github.com/patrickod/noisebridge-donate/pull/18","diff_url":"https://github.com/patrickod/noisebridge-donate/pull/18.diff","patch_url":"https://github.com/patrickod/noisebridge-donate/pull/18.patch","issue_url":"https://api.github.com/repos/patrickod/noisebridge-donate/issues/18","number":18,"state":"open","locked":false,"title":"Show 404, 422 and 500 pages","user":{"login":"morenoh149","id":587438,"avatar_url":"https://avatars.githubusercontent.com/u/587438?v=3","gravatar_id":"","url":"https://api.github.com/users/morenoh149","html_url":"https://github.com/morenoh149","followers_url":"https://api.github.com/users/morenoh149/followers","following_url":"https://api.github.com/users/morenoh149/following{/other_user}","gists_url":"https://api.github.com/users/morenoh149/gists{/gist_id}","starred_url":"https://api.github.com/users/morenoh149/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morenoh149/subscriptions","organizations_url":"https://api.github.com/users/morenoh149/orgs","repos_url":"https://api.github.com/users/morenoh149/repos","events_url":"https://api.github.com/users/morenoh149/events{/privacy}","received_events_url":"https://api.github.com/users/morenoh149/received_events","type":"User","site_admin":false},"body":"When the appropriate error is encountered.\r\nUsing this approach http://easyactiverecord.com/blog/2014/08/19/redirecting-to-custom-404-and-500-pages-in-rails/","created_at":"2015-04-19T07:53:09Z","updated_at":"2015-04-19T19:53:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1729f4ed580a429b95e8e425f31ce70afcfd464","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/patrickod/noisebridge-donate/pulls/18/commits","review_comments_url":"https://api.github.com/repos/patrickod/noisebridge-donate/pulls/18/comments","review_comment_url":"https://api.github.com/repos/patrickod/noisebridge-donate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/patrickod/noisebridge-donate/issues/18/comments","statuses_url":"https://api.github.com/repos/patrickod/noisebridge-donate/statuses/dfb4a6740d6f5ebd5511e7a585a04e9437105304","head":{"label":"morenoh149:hm-show-404","ref":"hm-show-404","sha":"dfb4a6740d6f5ebd5511e7a585a04e9437105304","user":{"login":"morenoh149","id":587438,"avatar_url":"https://avatars.githubusercontent.com/u/587438?v=3","gravatar_id":"","url":"https://api.github.com/users/morenoh149","html_url":"https://github.com/morenoh149","followers_url":"https://api.github.com/users/morenoh149/followers","following_url":"https://api.github.com/users/morenoh149/following{/other_user}","gists_url":"https://api.github.com/users/morenoh149/gists{/gist_id}","starred_url":"https://api.github.com/users/morenoh149/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morenoh149/subscriptions","organizations_url":"https://api.github.com/users/morenoh149/orgs","repos_url":"https://api.github.com/users/morenoh149/repos","events_url":"https://api.github.com/users/morenoh149/events{/privacy}","received_events_url":"https://api.github.com/users/morenoh149/received_events","type":"User","site_admin":false},"repo":{"id":31007331,"name":"noisebridge-donate","full_name":"morenoh149/noisebridge-donate","owner":{"login":"morenoh149","id":587438,"avatar_url":"https://avatars.githubusercontent.com/u/587438?v=3","gravatar_id":"","url":"https://api.github.com/users/morenoh149","html_url":"https://github.com/morenoh149","followers_url":"https://api.github.com/users/morenoh149/followers","following_url":"https://api.github.com/users/morenoh149/following{/other_user}","gists_url":"https://api.github.com/users/morenoh149/gists{/gist_id}","starred_url":"https://api.github.com/users/morenoh149/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morenoh149/subscriptions","organizations_url":"https://api.github.com/users/morenoh149/orgs","repos_url":"https://api.github.com/users/morenoh149/repos","events_url":"https://api.github.com/users/morenoh149/events{/privacy}","received_events_url":"https://api.github.com/users/morenoh149/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/morenoh149/noisebridge-donate","description":"A donation page for Noisebridge.","fork":true,"url":"https://api.github.com/repos/morenoh149/noisebridge-donate","forks_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/forks","keys_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/teams","hooks_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/hooks","issue_events_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/issues/events{/number}","events_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/events","assignees_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/assignees{/user}","branches_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/branches{/branch}","tags_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/tags","blobs_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/git/refs{/sha}","trees_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/statuses/{sha}","languages_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/languages","stargazers_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/stargazers","contributors_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/contributors","subscribers_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/subscribers","subscription_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/subscription","commits_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/commits{/sha}","git_commits_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/git/commits{/sha}","comments_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/comments{/number}","issue_comment_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/issues/comments{/number}","contents_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/contents/{+path}","compare_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/merges","archive_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/downloads","issues_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/issues{/number}","pulls_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/pulls{/number}","milestones_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/milestones{/number}","notifications_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/labels{/name}","releases_url":"https://api.github.com/repos/morenoh149/noisebridge-donate/releases{/id}","created_at":"2015-02-19T08:47:00Z","updated_at":"2015-04-19T07:10:31Z","pushed_at":"2015-04-19T07:51:29Z","git_url":"git://github.com/morenoh149/noisebridge-donate.git","ssh_url":"git@github.com:morenoh149/noisebridge-donate.git","clone_url":"https://github.com/morenoh149/noisebridge-donate.git","svn_url":"https://github.com/morenoh149/noisebridge-donate","homepage":null,"size":516,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"patrickod:master","ref":"master","sha":"492e562ca4cd6cbe4466b8e3fbaec7f5765ef254","user":{"login":"patrickod","id":84262,"avatar_url":"https://avatars.githubusercontent.com/u/84262?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickod","html_url":"https://github.com/patrickod","followers_url":"https://api.github.com/users/patrickod/followers","following_url":"https://api.github.com/users/patrickod/following{/other_user}","gists_url":"https://api.github.com/users/patrickod/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickod/subscriptions","organizations_url":"https://api.github.com/users/patrickod/orgs","repos_url":"https://api.github.com/users/patrickod/repos","events_url":"https://api.github.com/users/patrickod/events{/privacy}","received_events_url":"https://api.github.com/users/patrickod/received_events","type":"User","site_admin":false},"repo":{"id":30167214,"name":"noisebridge-donate","full_name":"patrickod/noisebridge-donate","owner":{"login":"patrickod","id":84262,"avatar_url":"https://avatars.githubusercontent.com/u/84262?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickod","html_url":"https://github.com/patrickod","followers_url":"https://api.github.com/users/patrickod/followers","following_url":"https://api.github.com/users/patrickod/following{/other_user}","gists_url":"https://api.github.com/users/patrickod/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickod/subscriptions","organizations_url":"https://api.github.com/users/patrickod/orgs","repos_url":"https://api.github.com/users/patrickod/repos","events_url":"https://api.github.com/users/patrickod/events{/privacy}","received_events_url":"https://api.github.com/users/patrickod/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/patrickod/noisebridge-donate","description":"A donation page for Noisebridge.","fork":false,"url":"https://api.github.com/repos/patrickod/noisebridge-donate","forks_url":"https://api.github.com/repos/patrickod/noisebridge-donate/forks","keys_url":"https://api.github.com/repos/patrickod/noisebridge-donate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patrickod/noisebridge-donate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patrickod/noisebridge-donate/teams","hooks_url":"https://api.github.com/repos/patrickod/noisebridge-donate/hooks","issue_events_url":"https://api.github.com/repos/patrickod/noisebridge-donate/issues/events{/number}","events_url":"https://api.github.com/repos/patrickod/noisebridge-donate/events","assignees_url":"https://api.github.com/repos/patrickod/noisebridge-donate/assignees{/user}","branches_url":"https://api.github.com/repos/patrickod/noisebridge-donate/branches{/branch}","tags_url":"https://api.github.com/repos/patrickod/noisebridge-donate/tags","blobs_url":"https://api.github.com/repos/patrickod/noisebridge-donate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patrickod/noisebridge-donate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patrickod/noisebridge-donate/git/refs{/sha}","trees_url":"https://api.github.com/repos/patrickod/noisebridge-donate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patrickod/noisebridge-donate/statuses/{sha}","languages_url":"https://api.github.com/repos/patrickod/noisebridge-donate/languages","stargazers_url":"https://api.github.com/repos/patrickod/noisebridge-donate/stargazers","contributors_url":"https://api.github.com/repos/patrickod/noisebridge-donate/contributors","subscribers_url":"https://api.github.com/repos/patrickod/noisebridge-donate/subscribers","subscription_url":"https://api.github.com/repos/patrickod/noisebridge-donate/subscription","commits_url":"https://api.github.com/repos/patrickod/noisebridge-donate/commits{/sha}","git_commits_url":"https://api.github.com/repos/patrickod/noisebridge-donate/git/commits{/sha}","comments_url":"https://api.github.com/repos/patrickod/noisebridge-donate/comments{/number}","issue_comment_url":"https://api.github.com/repos/patrickod/noisebridge-donate/issues/comments{/number}","contents_url":"https://api.github.com/repos/patrickod/noisebridge-donate/contents/{+path}","compare_url":"https://api.github.com/repos/patrickod/noisebridge-donate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patrickod/noisebridge-donate/merges","archive_url":"https://api.github.com/repos/patrickod/noisebridge-donate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patrickod/noisebridge-donate/downloads","issues_url":"https://api.github.com/repos/patrickod/noisebridge-donate/issues{/number}","pulls_url":"https://api.github.com/repos/patrickod/noisebridge-donate/pulls{/number}","milestones_url":"https://api.github.com/repos/patrickod/noisebridge-donate/milestones{/number}","notifications_url":"https://api.github.com/repos/patrickod/noisebridge-donate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patrickod/noisebridge-donate/labels{/name}","releases_url":"https://api.github.com/repos/patrickod/noisebridge-donate/releases{/id}","created_at":"2015-02-02T02:06:13Z","updated_at":"2015-04-11T19:38:35Z","pushed_at":"2015-04-19T07:53:10Z","git_url":"git://github.com/patrickod/noisebridge-donate.git","ssh_url":"git@github.com:patrickod/noisebridge-donate.git","clone_url":"https://github.com/patrickod/noisebridge-donate.git","svn_url":"https://github.com/patrickod/noisebridge-donate","homepage":null,"size":793,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":8,"forks":2,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/patrickod/noisebridge-donate/pulls/18"},"html":{"href":"https://github.com/patrickod/noisebridge-donate/pull/18"},"issue":{"href":"https://api.github.com/repos/patrickod/noisebridge-donate/issues/18"},"comments":{"href":"https://api.github.com/repos/patrickod/noisebridge-donate/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/patrickod/noisebridge-donate/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/patrickod/noisebridge-donate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/patrickod/noisebridge-donate/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/patrickod/noisebridge-donate/statuses/dfb4a6740d6f5ebd5511e7a585a04e9437105304"}}}}