{"action":"closed","number":35,"pull_request":{"url":"https://api.github.com/repos/ocsigen/lwt/pulls/35","id":11431696,"html_url":"https://github.com/ocsigen/lwt/pull/35","diff_url":"https://github.com/ocsigen/lwt/pull/35.diff","patch_url":"https://github.com/ocsigen/lwt/pull/35.patch","issue_url":"https://api.github.com/repos/ocsigen/lwt/issues/35","number":35,"state":"closed","locked":false,"title":"lwt_unix: sub-second precision for stat results","user":{"login":"gfxmonk","id":14172,"avatar_url":"https://avatars.githubusercontent.com/u/14172?v=3","gravatar_id":"","url":"https://api.github.com/users/gfxmonk","html_url":"https://github.com/gfxmonk","followers_url":"https://api.github.com/users/gfxmonk/followers","following_url":"https://api.github.com/users/gfxmonk/following{/other_user}","gists_url":"https://api.github.com/users/gfxmonk/gists{/gist_id}","starred_url":"https://api.github.com/users/gfxmonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfxmonk/subscriptions","organizations_url":"https://api.github.com/users/gfxmonk/orgs","repos_url":"https://api.github.com/users/gfxmonk/repos","events_url":"https://api.github.com/users/gfxmonk/events{/privacy}","received_events_url":"https://api.github.com/users/gfxmonk/received_events","type":"User","site_admin":false},"body":"This patch does make lwt_Unix.stat results unequal to the corresponding Unix.stat results, since Unix.stat still only uses the second-level fields. I'd like to fix that as well, but forking and compiling ocaml itself is harder than lwt.\r\n\r\n(there's an open bug if anyone else wants to jump in: http://caml.inria.fr/mantis/view.php?id=6285)\r\n\r\n**note**: The code is copied from Jane street core (https://github.com/janestreet/core/blob/master/lib/unix_stubs.c#L426). The code is under the APL, although I don't know if copyright attribution is required, since the code is driven almost entirely by maths and system APIs.","created_at":"2014-01-12T01:25:08Z","updated_at":"2015-07-03T11:34:52Z","closed_at":"2015-07-03T11:34:52Z","merged_at":"2015-07-03T11:34:52Z","merge_commit_sha":"eef66b97d9187036d7c875beed08a6979b8593a9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ocsigen/lwt/pulls/35/commits","review_comments_url":"https://api.github.com/repos/ocsigen/lwt/pulls/35/comments","review_comment_url":"https://api.github.com/repos/ocsigen/lwt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocsigen/lwt/issues/35/comments","statuses_url":"https://api.github.com/repos/ocsigen/lwt/statuses/b515a5f9d49663964a85088d9a17bb4bb9cd479a","head":{"label":"gfxmonk:subsecond-stat-results","ref":"subsecond-stat-results","sha":"b515a5f9d49663964a85088d9a17bb4bb9cd479a","user":{"login":"gfxmonk","id":14172,"avatar_url":"https://avatars.githubusercontent.com/u/14172?v=3","gravatar_id":"","url":"https://api.github.com/users/gfxmonk","html_url":"https://github.com/gfxmonk","followers_url":"https://api.github.com/users/gfxmonk/followers","following_url":"https://api.github.com/users/gfxmonk/following{/other_user}","gists_url":"https://api.github.com/users/gfxmonk/gists{/gist_id}","starred_url":"https://api.github.com/users/gfxmonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfxmonk/subscriptions","organizations_url":"https://api.github.com/users/gfxmonk/orgs","repos_url":"https://api.github.com/users/gfxmonk/repos","events_url":"https://api.github.com/users/gfxmonk/events{/privacy}","received_events_url":"https://api.github.com/users/gfxmonk/received_events","type":"User","site_admin":false},"repo":{"id":15834213,"name":"lwt","full_name":"gfxmonk/lwt","owner":{"login":"gfxmonk","id":14172,"avatar_url":"https://avatars.githubusercontent.com/u/14172?v=3","gravatar_id":"","url":"https://api.github.com/users/gfxmonk","html_url":"https://github.com/gfxmonk","followers_url":"https://api.github.com/users/gfxmonk/followers","following_url":"https://api.github.com/users/gfxmonk/following{/other_user}","gists_url":"https://api.github.com/users/gfxmonk/gists{/gist_id}","starred_url":"https://api.github.com/users/gfxmonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfxmonk/subscriptions","organizations_url":"https://api.github.com/users/gfxmonk/orgs","repos_url":"https://api.github.com/users/gfxmonk/repos","events_url":"https://api.github.com/users/gfxmonk/events{/privacy}","received_events_url":"https://api.github.com/users/gfxmonk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gfxmonk/lwt","description":"A cooperative threads library for OCaml.","fork":true,"url":"https://api.github.com/repos/gfxmonk/lwt","forks_url":"https://api.github.com/repos/gfxmonk/lwt/forks","keys_url":"https://api.github.com/repos/gfxmonk/lwt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gfxmonk/lwt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gfxmonk/lwt/teams","hooks_url":"https://api.github.com/repos/gfxmonk/lwt/hooks","issue_events_url":"https://api.github.com/repos/gfxmonk/lwt/issues/events{/number}","events_url":"https://api.github.com/repos/gfxmonk/lwt/events","assignees_url":"https://api.github.com/repos/gfxmonk/lwt/assignees{/user}","branches_url":"https://api.github.com/repos/gfxmonk/lwt/branches{/branch}","tags_url":"https://api.github.com/repos/gfxmonk/lwt/tags","blobs_url":"https://api.github.com/repos/gfxmonk/lwt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gfxmonk/lwt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gfxmonk/lwt/git/refs{/sha}","trees_url":"https://api.github.com/repos/gfxmonk/lwt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gfxmonk/lwt/statuses/{sha}","languages_url":"https://api.github.com/repos/gfxmonk/lwt/languages","stargazers_url":"https://api.github.com/repos/gfxmonk/lwt/stargazers","contributors_url":"https://api.github.com/repos/gfxmonk/lwt/contributors","subscribers_url":"https://api.github.com/repos/gfxmonk/lwt/subscribers","subscription_url":"https://api.github.com/repos/gfxmonk/lwt/subscription","commits_url":"https://api.github.com/repos/gfxmonk/lwt/commits{/sha}","git_commits_url":"https://api.github.com/repos/gfxmonk/lwt/git/commits{/sha}","comments_url":"https://api.github.com/repos/gfxmonk/lwt/comments{/number}","issue_comment_url":"https://api.github.com/repos/gfxmonk/lwt/issues/comments{/number}","contents_url":"https://api.github.com/repos/gfxmonk/lwt/contents/{+path}","compare_url":"https://api.github.com/repos/gfxmonk/lwt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gfxmonk/lwt/merges","archive_url":"https://api.github.com/repos/gfxmonk/lwt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gfxmonk/lwt/downloads","issues_url":"https://api.github.com/repos/gfxmonk/lwt/issues{/number}","pulls_url":"https://api.github.com/repos/gfxmonk/lwt/pulls{/number}","milestones_url":"https://api.github.com/repos/gfxmonk/lwt/milestones{/number}","notifications_url":"https://api.github.com/repos/gfxmonk/lwt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gfxmonk/lwt/labels{/name}","releases_url":"https://api.github.com/repos/gfxmonk/lwt/releases{/id}","created_at":"2014-01-12T01:16:02Z","updated_at":"2014-01-18T12:29:19Z","pushed_at":"2015-07-03T11:17:48Z","git_url":"git://github.com/gfxmonk/lwt.git","ssh_url":"git@github.com:gfxmonk/lwt.git","clone_url":"https://github.com/gfxmonk/lwt.git","svn_url":"https://github.com/gfxmonk/lwt","homepage":"http://ocsigen.org/lwt/","size":3193,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ocsigen:master","ref":"master","sha":"431215075b82ec2293f37bc40c594712e581624a","user":{"login":"ocsigen","id":4729424,"avatar_url":"https://avatars.githubusercontent.com/u/4729424?v=3","gravatar_id":"","url":"https://api.github.com/users/ocsigen","html_url":"https://github.com/ocsigen","followers_url":"https://api.github.com/users/ocsigen/followers","following_url":"https://api.github.com/users/ocsigen/following{/other_user}","gists_url":"https://api.github.com/users/ocsigen/gists{/gist_id}","starred_url":"https://api.github.com/users/ocsigen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocsigen/subscriptions","organizations_url":"https://api.github.com/users/ocsigen/orgs","repos_url":"https://api.github.com/users/ocsigen/repos","events_url":"https://api.github.com/users/ocsigen/events{/privacy}","received_events_url":"https://api.github.com/users/ocsigen/received_events","type":"Organization","site_admin":false},"repo":{"id":11749475,"name":"lwt","full_name":"ocsigen/lwt","owner":{"login":"ocsigen","id":4729424,"avatar_url":"https://avatars.githubusercontent.com/u/4729424?v=3","gravatar_id":"","url":"https://api.github.com/users/ocsigen","html_url":"https://github.com/ocsigen","followers_url":"https://api.github.com/users/ocsigen/followers","following_url":"https://api.github.com/users/ocsigen/following{/other_user}","gists_url":"https://api.github.com/users/ocsigen/gists{/gist_id}","starred_url":"https://api.github.com/users/ocsigen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocsigen/subscriptions","organizations_url":"https://api.github.com/users/ocsigen/orgs","repos_url":"https://api.github.com/users/ocsigen/repos","events_url":"https://api.github.com/users/ocsigen/events{/privacy}","received_events_url":"https://api.github.com/users/ocsigen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocsigen/lwt","description":"A cooperative threads library for OCaml.","fork":false,"url":"https://api.github.com/repos/ocsigen/lwt","forks_url":"https://api.github.com/repos/ocsigen/lwt/forks","keys_url":"https://api.github.com/repos/ocsigen/lwt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocsigen/lwt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocsigen/lwt/teams","hooks_url":"https://api.github.com/repos/ocsigen/lwt/hooks","issue_events_url":"https://api.github.com/repos/ocsigen/lwt/issues/events{/number}","events_url":"https://api.github.com/repos/ocsigen/lwt/events","assignees_url":"https://api.github.com/repos/ocsigen/lwt/assignees{/user}","branches_url":"https://api.github.com/repos/ocsigen/lwt/branches{/branch}","tags_url":"https://api.github.com/repos/ocsigen/lwt/tags","blobs_url":"https://api.github.com/repos/ocsigen/lwt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocsigen/lwt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocsigen/lwt/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocsigen/lwt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocsigen/lwt/statuses/{sha}","languages_url":"https://api.github.com/repos/ocsigen/lwt/languages","stargazers_url":"https://api.github.com/repos/ocsigen/lwt/stargazers","contributors_url":"https://api.github.com/repos/ocsigen/lwt/contributors","subscribers_url":"https://api.github.com/repos/ocsigen/lwt/subscribers","subscription_url":"https://api.github.com/repos/ocsigen/lwt/subscription","commits_url":"https://api.github.com/repos/ocsigen/lwt/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocsigen/lwt/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocsigen/lwt/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocsigen/lwt/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocsigen/lwt/contents/{+path}","compare_url":"https://api.github.com/repos/ocsigen/lwt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocsigen/lwt/merges","archive_url":"https://api.github.com/repos/ocsigen/lwt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocsigen/lwt/downloads","issues_url":"https://api.github.com/repos/ocsigen/lwt/issues{/number}","pulls_url":"https://api.github.com/repos/ocsigen/lwt/pulls{/number}","milestones_url":"https://api.github.com/repos/ocsigen/lwt/milestones{/number}","notifications_url":"https://api.github.com/repos/ocsigen/lwt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocsigen/lwt/labels{/name}","releases_url":"https://api.github.com/repos/ocsigen/lwt/releases{/id}","created_at":"2013-07-29T20:47:51Z","updated_at":"2015-05-01T12:26:24Z","pushed_at":"2015-07-03T11:34:52Z","git_url":"git://github.com/ocsigen/lwt.git","ssh_url":"git@github.com:ocsigen/lwt.git","clone_url":"https://github.com/ocsigen/lwt.git","svn_url":"https://github.com/ocsigen/lwt","homepage":"http://ocsigen.org/lwt/","size":5421,"stargazers_count":45,"watchers_count":45,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":42,"forks":44,"open_issues":42,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocsigen/lwt/pulls/35"},"html":{"href":"https://github.com/ocsigen/lwt/pull/35"},"issue":{"href":"https://api.github.com/repos/ocsigen/lwt/issues/35"},"comments":{"href":"https://api.github.com/repos/ocsigen/lwt/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/ocsigen/lwt/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/ocsigen/lwt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocsigen/lwt/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/ocsigen/lwt/statuses/b515a5f9d49663964a85088d9a17bb4bb9cd479a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"vbmithr","id":797581,"avatar_url":"https://avatars.githubusercontent.com/u/797581?v=3","gravatar_id":"","url":"https://api.github.com/users/vbmithr","html_url":"https://github.com/vbmithr","followers_url":"https://api.github.com/users/vbmithr/followers","following_url":"https://api.github.com/users/vbmithr/following{/other_user}","gists_url":"https://api.github.com/users/vbmithr/gists{/gist_id}","starred_url":"https://api.github.com/users/vbmithr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbmithr/subscriptions","organizations_url":"https://api.github.com/users/vbmithr/orgs","repos_url":"https://api.github.com/users/vbmithr/repos","events_url":"https://api.github.com/users/vbmithr/events{/privacy}","received_events_url":"https://api.github.com/users/vbmithr/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":2,"additions":45,"deletions":3,"changed_files":2}}