{"action":"closed","number":746,"pull_request":{"url":"https://api.github.com/repos/RESTful-Drupal/restful/pulls/746","id":51059943,"html_url":"https://github.com/RESTful-Drupal/restful/pull/746","diff_url":"https://github.com/RESTful-Drupal/restful/pull/746.diff","patch_url":"https://github.com/RESTful-Drupal/restful/pull/746.patch","issue_url":"https://api.github.com/repos/RESTful-Drupal/restful/issues/746","number":746,"state":"closed","locked":false,"title":"Allow bundles FALSE","user":{"login":"edwardaa","id":8274162,"avatar_url":"https://avatars.githubusercontent.com/u/8274162?v=3","gravatar_id":"","url":"https://api.github.com/users/edwardaa","html_url":"https://github.com/edwardaa","followers_url":"https://api.github.com/users/edwardaa/followers","following_url":"https://api.github.com/users/edwardaa/following{/other_user}","gists_url":"https://api.github.com/users/edwardaa/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardaa/subscriptions","organizations_url":"https://api.github.com/users/edwardaa/orgs","repos_url":"https://api.github.com/users/edwardaa/repos","events_url":"https://api.github.com/users/edwardaa/events{/privacy}","received_events_url":"https://api.github.com/users/edwardaa/received_events","type":"User","site_admin":false},"body":"`SQLSTATE[42S22]: Column not found: 1054 Unknown column 'comment.node_type' in 'where clause'` occurs on below `comments` resource:\r\n```php\r\n/**\r\n * Class Comments__1_0\r\n * @package Drupal\\restful_example\\Plugin\\resource\\comment\r\n *\r\n * @Resource(\r\n *   name = \"comments:1.0\",\r\n *   resource = \"comments\",\r\n *   label = \"Comments\",\r\n *   description = \"Export the comments with all authentication providers.\",\r\n *   authenticationTypes = TRUE,\r\n *   authenticationOptional = TRUE,\r\n *   dataProvider = {\r\n *     \"entityType\": \"comment\",\r\n *     \"bundles\": {\r\n *       \"comment_node_article\"\r\n *     },\r\n *   },\r\n *   majorVersion = 1,\r\n *   minorVersion = 0\r\n * )\r\n */\r\nclass Comments__1_0 extends ResourceEntity implements ResourceInterface {}\r\n```\r\nUnlike other entities, the comment table doesn't have a column for bundle, If we allow no bundles using `bundles = FALSE`:\r\n```php\r\n/**\r\n* ...\r\n *   dataProvider = {\r\n *     \"entityType\": \"comment\",\r\n *     \"bundles\": FALSE,\r\n *   },\r\n * ...\r\n */\r\n```\r\nand bypass entity bundle condition for EntityFieldQuery, the comments resource would work.","created_at":"2015-11-18T09:26:18Z","updated_at":"2015-11-24T11:29:42Z","closed_at":"2015-11-24T11:29:42Z","merged_at":null,"merge_commit_sha":"f4e5e68bfb5790908788cb916960134ceab12a89","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RESTful-Drupal/restful/pulls/746/commits","review_comments_url":"https://api.github.com/repos/RESTful-Drupal/restful/pulls/746/comments","review_comment_url":"https://api.github.com/repos/RESTful-Drupal/restful/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RESTful-Drupal/restful/issues/746/comments","statuses_url":"https://api.github.com/repos/RESTful-Drupal/restful/statuses/0e754c4e5b30e4093a4c8396740fc941c593ce07","head":{"label":"edwardaa:allow_false_bundle","ref":"allow_false_bundle","sha":"0e754c4e5b30e4093a4c8396740fc941c593ce07","user":{"login":"edwardaa","id":8274162,"avatar_url":"https://avatars.githubusercontent.com/u/8274162?v=3","gravatar_id":"","url":"https://api.github.com/users/edwardaa","html_url":"https://github.com/edwardaa","followers_url":"https://api.github.com/users/edwardaa/followers","following_url":"https://api.github.com/users/edwardaa/following{/other_user}","gists_url":"https://api.github.com/users/edwardaa/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardaa/subscriptions","organizations_url":"https://api.github.com/users/edwardaa/orgs","repos_url":"https://api.github.com/users/edwardaa/repos","events_url":"https://api.github.com/users/edwardaa/events{/privacy}","received_events_url":"https://api.github.com/users/edwardaa/received_events","type":"User","site_admin":false},"repo":{"id":45304952,"name":"restful","full_name":"edwardaa/restful","owner":{"login":"edwardaa","id":8274162,"avatar_url":"https://avatars.githubusercontent.com/u/8274162?v=3","gravatar_id":"","url":"https://api.github.com/users/edwardaa","html_url":"https://github.com/edwardaa","followers_url":"https://api.github.com/users/edwardaa/followers","following_url":"https://api.github.com/users/edwardaa/following{/other_user}","gists_url":"https://api.github.com/users/edwardaa/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardaa/subscriptions","organizations_url":"https://api.github.com/users/edwardaa/orgs","repos_url":"https://api.github.com/users/edwardaa/repos","events_url":"https://api.github.com/users/edwardaa/events{/privacy}","received_events_url":"https://api.github.com/users/edwardaa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edwardaa/restful","description":"RESTful best practices for Drupal","fork":true,"url":"https://api.github.com/repos/edwardaa/restful","forks_url":"https://api.github.com/repos/edwardaa/restful/forks","keys_url":"https://api.github.com/repos/edwardaa/restful/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edwardaa/restful/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edwardaa/restful/teams","hooks_url":"https://api.github.com/repos/edwardaa/restful/hooks","issue_events_url":"https://api.github.com/repos/edwardaa/restful/issues/events{/number}","events_url":"https://api.github.com/repos/edwardaa/restful/events","assignees_url":"https://api.github.com/repos/edwardaa/restful/assignees{/user}","branches_url":"https://api.github.com/repos/edwardaa/restful/branches{/branch}","tags_url":"https://api.github.com/repos/edwardaa/restful/tags","blobs_url":"https://api.github.com/repos/edwardaa/restful/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edwardaa/restful/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edwardaa/restful/git/refs{/sha}","trees_url":"https://api.github.com/repos/edwardaa/restful/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edwardaa/restful/statuses/{sha}","languages_url":"https://api.github.com/repos/edwardaa/restful/languages","stargazers_url":"https://api.github.com/repos/edwardaa/restful/stargazers","contributors_url":"https://api.github.com/repos/edwardaa/restful/contributors","subscribers_url":"https://api.github.com/repos/edwardaa/restful/subscribers","subscription_url":"https://api.github.com/repos/edwardaa/restful/subscription","commits_url":"https://api.github.com/repos/edwardaa/restful/commits{/sha}","git_commits_url":"https://api.github.com/repos/edwardaa/restful/git/commits{/sha}","comments_url":"https://api.github.com/repos/edwardaa/restful/comments{/number}","issue_comment_url":"https://api.github.com/repos/edwardaa/restful/issues/comments{/number}","contents_url":"https://api.github.com/repos/edwardaa/restful/contents/{+path}","compare_url":"https://api.github.com/repos/edwardaa/restful/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edwardaa/restful/merges","archive_url":"https://api.github.com/repos/edwardaa/restful/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edwardaa/restful/downloads","issues_url":"https://api.github.com/repos/edwardaa/restful/issues{/number}","pulls_url":"https://api.github.com/repos/edwardaa/restful/pulls{/number}","milestones_url":"https://api.github.com/repos/edwardaa/restful/milestones{/number}","notifications_url":"https://api.github.com/repos/edwardaa/restful/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edwardaa/restful/labels{/name}","releases_url":"https://api.github.com/repos/edwardaa/restful/releases{/id}","created_at":"2015-10-31T14:35:43Z","updated_at":"2015-10-31T14:35:44Z","pushed_at":"2015-11-20T10:35:44Z","git_url":"git://github.com/edwardaa/restful.git","ssh_url":"git@github.com:edwardaa/restful.git","clone_url":"https://github.com/edwardaa/restful.git","svn_url":"https://github.com/edwardaa/restful","homepage":"https://drupal.org/project/restful","size":2459,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"7.x-1.x"}},"base":{"label":"RESTful-Drupal:7.x-2.x","ref":"7.x-2.x","sha":"0e2878c7fc0bfa435ad9efc07b75fb903ea95fa6","user":{"login":"RESTful-Drupal","id":10175793,"avatar_url":"https://avatars.githubusercontent.com/u/10175793?v=3","gravatar_id":"","url":"https://api.github.com/users/RESTful-Drupal","html_url":"https://github.com/RESTful-Drupal","followers_url":"https://api.github.com/users/RESTful-Drupal/followers","following_url":"https://api.github.com/users/RESTful-Drupal/following{/other_user}","gists_url":"https://api.github.com/users/RESTful-Drupal/gists{/gist_id}","starred_url":"https://api.github.com/users/RESTful-Drupal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RESTful-Drupal/subscriptions","organizations_url":"https://api.github.com/users/RESTful-Drupal/orgs","repos_url":"https://api.github.com/users/RESTful-Drupal/repos","events_url":"https://api.github.com/users/RESTful-Drupal/events{/privacy}","received_events_url":"https://api.github.com/users/RESTful-Drupal/received_events","type":"Organization","site_admin":false},"repo":{"id":17918315,"name":"restful","full_name":"RESTful-Drupal/restful","owner":{"login":"RESTful-Drupal","id":10175793,"avatar_url":"https://avatars.githubusercontent.com/u/10175793?v=3","gravatar_id":"","url":"https://api.github.com/users/RESTful-Drupal","html_url":"https://github.com/RESTful-Drupal","followers_url":"https://api.github.com/users/RESTful-Drupal/followers","following_url":"https://api.github.com/users/RESTful-Drupal/following{/other_user}","gists_url":"https://api.github.com/users/RESTful-Drupal/gists{/gist_id}","starred_url":"https://api.github.com/users/RESTful-Drupal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RESTful-Drupal/subscriptions","organizations_url":"https://api.github.com/users/RESTful-Drupal/orgs","repos_url":"https://api.github.com/users/RESTful-Drupal/repos","events_url":"https://api.github.com/users/RESTful-Drupal/events{/privacy}","received_events_url":"https://api.github.com/users/RESTful-Drupal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RESTful-Drupal/restful","description":"RESTful best practices for Drupal","fork":false,"url":"https://api.github.com/repos/RESTful-Drupal/restful","forks_url":"https://api.github.com/repos/RESTful-Drupal/restful/forks","keys_url":"https://api.github.com/repos/RESTful-Drupal/restful/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RESTful-Drupal/restful/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RESTful-Drupal/restful/teams","hooks_url":"https://api.github.com/repos/RESTful-Drupal/restful/hooks","issue_events_url":"https://api.github.com/repos/RESTful-Drupal/restful/issues/events{/number}","events_url":"https://api.github.com/repos/RESTful-Drupal/restful/events","assignees_url":"https://api.github.com/repos/RESTful-Drupal/restful/assignees{/user}","branches_url":"https://api.github.com/repos/RESTful-Drupal/restful/branches{/branch}","tags_url":"https://api.github.com/repos/RESTful-Drupal/restful/tags","blobs_url":"https://api.github.com/repos/RESTful-Drupal/restful/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RESTful-Drupal/restful/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RESTful-Drupal/restful/git/refs{/sha}","trees_url":"https://api.github.com/repos/RESTful-Drupal/restful/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RESTful-Drupal/restful/statuses/{sha}","languages_url":"https://api.github.com/repos/RESTful-Drupal/restful/languages","stargazers_url":"https://api.github.com/repos/RESTful-Drupal/restful/stargazers","contributors_url":"https://api.github.com/repos/RESTful-Drupal/restful/contributors","subscribers_url":"https://api.github.com/repos/RESTful-Drupal/restful/subscribers","subscription_url":"https://api.github.com/repos/RESTful-Drupal/restful/subscription","commits_url":"https://api.github.com/repos/RESTful-Drupal/restful/commits{/sha}","git_commits_url":"https://api.github.com/repos/RESTful-Drupal/restful/git/commits{/sha}","comments_url":"https://api.github.com/repos/RESTful-Drupal/restful/comments{/number}","issue_comment_url":"https://api.github.com/repos/RESTful-Drupal/restful/issues/comments{/number}","contents_url":"https://api.github.com/repos/RESTful-Drupal/restful/contents/{+path}","compare_url":"https://api.github.com/repos/RESTful-Drupal/restful/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RESTful-Drupal/restful/merges","archive_url":"https://api.github.com/repos/RESTful-Drupal/restful/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RESTful-Drupal/restful/downloads","issues_url":"https://api.github.com/repos/RESTful-Drupal/restful/issues{/number}","pulls_url":"https://api.github.com/repos/RESTful-Drupal/restful/pulls{/number}","milestones_url":"https://api.github.com/repos/RESTful-Drupal/restful/milestones{/number}","notifications_url":"https://api.github.com/repos/RESTful-Drupal/restful/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RESTful-Drupal/restful/labels{/name}","releases_url":"https://api.github.com/repos/RESTful-Drupal/restful/releases{/id}","created_at":"2014-03-19T19:58:55Z","updated_at":"2015-11-19T14:58:05Z","pushed_at":"2015-11-24T11:29:21Z","git_url":"git://github.com/RESTful-Drupal/restful.git","ssh_url":"git@github.com:RESTful-Drupal/restful.git","clone_url":"https://github.com/RESTful-Drupal/restful.git","svn_url":"https://github.com/RESTful-Drupal/restful","homepage":"https://drupal.org/project/restful","size":3876,"stargazers_count":290,"watchers_count":290,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":124,"forks":92,"open_issues":124,"watchers":290,"default_branch":"7.x-2.x"}},"_links":{"self":{"href":"https://api.github.com/repos/RESTful-Drupal/restful/pulls/746"},"html":{"href":"https://github.com/RESTful-Drupal/restful/pull/746"},"issue":{"href":"https://api.github.com/repos/RESTful-Drupal/restful/issues/746"},"comments":{"href":"https://api.github.com/repos/RESTful-Drupal/restful/issues/746/comments"},"review_comments":{"href":"https://api.github.com/repos/RESTful-Drupal/restful/pulls/746/comments"},"review_comment":{"href":"https://api.github.com/repos/RESTful-Drupal/restful/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RESTful-Drupal/restful/pulls/746/commits"},"statuses":{"href":"https://api.github.com/repos/RESTful-Drupal/restful/statuses/0e754c4e5b30e4093a4c8396740fc941c593ce07"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":0,"commits":5,"additions":451,"deletions":2,"changed_files":5}}