{"action":"created","issue":{"url":"https://api.github.com/repos/YOURLS/antispam/issues/12","labels_url":"https://api.github.com/repos/YOURLS/antispam/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/YOURLS/antispam/issues/12/comments","events_url":"https://api.github.com/repos/YOURLS/antispam/issues/12/events","html_url":"https://github.com/YOURLS/antispam/pull/12","id":60070619,"number":12,"title":"Bugfix: confusion about spamhaus' ZEN vs. DBL","user":{"login":"BstName","id":11042889,"avatar_url":"https://avatars.githubusercontent.com/u/11042889?v=3","gravatar_id":"","url":"https://api.github.com/users/BstName","html_url":"https://github.com/BstName","followers_url":"https://api.github.com/users/BstName/followers","following_url":"https://api.github.com/users/BstName/following{/other_user}","gists_url":"https://api.github.com/users/BstName/gists{/gist_id}","starred_url":"https://api.github.com/users/BstName/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BstName/subscriptions","organizations_url":"https://api.github.com/users/BstName/orgs","repos_url":"https://api.github.com/users/BstName/repos","events_url":"https://api.github.com/users/BstName/events{/privacy}","received_events_url":"https://api.github.com/users/BstName/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-06T07:56:02Z","updated_at":"2015-03-06T21:22:54Z","closed_at":"2015-03-06T18:39:51Z","pull_request":{"url":"https://api.github.com/repos/YOURLS/antispam/pulls/12","html_url":"https://github.com/YOURLS/antispam/pull/12","diff_url":"https://github.com/YOURLS/antispam/pull/12.diff","patch_url":"https://github.com/YOURLS/antispam/pull/12.patch"},"body":"Quoting http://www.spamhaus.org/zen/: \"ZEN is the combination of all Spamhaus IP-based DNSBLs into one single powerful and comprehensive blocklist to make querying faster and simpler. It contains the SBL, SBLCSS, XBL and PBL blocklists.\"\r\n\r\nThese are all IP-based block (or black) lists, i.e. they do not cover domain names. Your code however tests whether a hostname is blacklisted. Spamhaus has a separate list for this purpose, called the DBL. This is the list you should use here. For instance, on a Unix machine\r\n\r\nhost dbltest.com.zen.spamhaus.org \r\n\r\nwill report a non-existent domain, while \r\n\r\nhost dbltest.com.dbl.spamhaus.org\r\n\r\nwill result in the address 127.0.1.2, indicating a spam domain (in this case, this is just a permanent test point for the list). You can also use the unix 'dig' command instead of 'host', or 'nslookup' in a shell under MS Windows(tm).\r\n\r\nA perhaps more convincing example with a real spam domain (BE AWARE, DON'T VISIT IT):\r\n\r\nhost controlins.com.zen.spamhaus.org \r\n\r\nwill yield a non-existing domain, while \r\n\r\nhost controlins.com.dbl.spamhaus.org\r\n\r\nyields 127.0.1.2 (thus detecting the spam domain). You can also try shortening 'http://controlins.com-MUNGED' (without the '-MUNGED' part) in a YOURLS shortener, where the current version of the antispam plugin is activated. Since, unfortunately, neither SURBL nor URIBL, ATTOW, know the aforementioned spam domain, it will pass the check, and a short URL is created, duh. With the bug fix applied however (zen -> dbl), this filthy URI is rejected. \r\n\r\n(Again, this hold ATTOW, as you know things can change quickly, as the lists are being updated continuously)."},"comment":{"url":"https://api.github.com/repos/YOURLS/antispam/issues/comments/77638407","html_url":"https://github.com/YOURLS/antispam/pull/12#issuecomment-77638407","issue_url":"https://api.github.com/repos/YOURLS/antispam/issues/12","id":77638407,"user":{"login":"BstName","id":11042889,"avatar_url":"https://avatars.githubusercontent.com/u/11042889?v=3","gravatar_id":"","url":"https://api.github.com/users/BstName","html_url":"https://github.com/BstName","followers_url":"https://api.github.com/users/BstName/followers","following_url":"https://api.github.com/users/BstName/following{/other_user}","gists_url":"https://api.github.com/users/BstName/gists{/gist_id}","starred_url":"https://api.github.com/users/BstName/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BstName/subscriptions","organizations_url":"https://api.github.com/users/BstName/orgs","repos_url":"https://api.github.com/users/BstName/repos","events_url":"https://api.github.com/users/BstName/events{/privacy}","received_events_url":"https://api.github.com/users/BstName/received_events","type":"User","site_admin":false},"created_at":"2015-03-06T21:22:54Z","updated_at":"2015-03-06T21:22:54Z","body":"You're welcome, and thanks for the swift action,"}}