{"action":"closed","number":37,"pull_request":{"url":"https://api.github.com/repos/vega/vega-editor/pulls/37","id":54041331,"html_url":"https://github.com/vega/vega-editor/pull/37","diff_url":"https://github.com/vega/vega-editor/pull/37.diff","patch_url":"https://github.com/vega/vega-editor/pull/37.patch","issue_url":"https://api.github.com/repos/vega/vega-editor/issues/37","number":37,"state":"closed","locked":false,"title":"Prevent editor to break after first error","user":{"login":"floribon","id":2934743,"avatar_url":"https://avatars.githubusercontent.com/u/2934743?v=3","gravatar_id":"","url":"https://api.github.com/users/floribon","html_url":"https://github.com/floribon","followers_url":"https://api.github.com/users/floribon/followers","following_url":"https://api.github.com/users/floribon/following{/other_user}","gists_url":"https://api.github.com/users/floribon/gists{/gist_id}","starred_url":"https://api.github.com/users/floribon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floribon/subscriptions","organizations_url":"https://api.github.com/users/floribon/orgs","repos_url":"https://api.github.com/users/floribon/repos","events_url":"https://api.github.com/users/floribon/events{/privacy}","received_events_url":"https://api.github.com/users/floribon/received_events","type":"User","site_admin":false},"body":"If a spec is wrong, `ved.view` becomes an instance of `Error`. The code\r\ntrying to execute `ved.view.destroy()` fails, and it becomes impossible\r\nto parse a valid spec again unless one refreshes the HTML page.\r\n\r\nSteps to reproduce:\r\n - Open any example of the live editor\r\n - Change the name of the data `table` into `foo`\r\n - Click \"Parse\" > this generates an error\r\n - Change \"foo\" back into \"table\"\r\n - Click \"Parse\" again: the editor is still broken","created_at":"2015-12-17T22:33:50Z","updated_at":"2015-12-17T22:40:16Z","closed_at":"2015-12-17T22:40:16Z","merged_at":"2015-12-17T22:40:16Z","merge_commit_sha":"8c55fcaef6dfacb15d7b5ab17714765d8045d559","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vega/vega-editor/pulls/37/commits","review_comments_url":"https://api.github.com/repos/vega/vega-editor/pulls/37/comments","review_comment_url":"https://api.github.com/repos/vega/vega-editor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vega/vega-editor/issues/37/comments","statuses_url":"https://api.github.com/repos/vega/vega-editor/statuses/9bd9e3332b4fc4c75b2771bf76f0e5e9fe0d81a9","head":{"label":"floribon:break-on-error","ref":"break-on-error","sha":"9bd9e3332b4fc4c75b2771bf76f0e5e9fe0d81a9","user":{"login":"floribon","id":2934743,"avatar_url":"https://avatars.githubusercontent.com/u/2934743?v=3","gravatar_id":"","url":"https://api.github.com/users/floribon","html_url":"https://github.com/floribon","followers_url":"https://api.github.com/users/floribon/followers","following_url":"https://api.github.com/users/floribon/following{/other_user}","gists_url":"https://api.github.com/users/floribon/gists{/gist_id}","starred_url":"https://api.github.com/users/floribon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floribon/subscriptions","organizations_url":"https://api.github.com/users/floribon/orgs","repos_url":"https://api.github.com/users/floribon/repos","events_url":"https://api.github.com/users/floribon/events{/privacy}","received_events_url":"https://api.github.com/users/floribon/received_events","type":"User","site_admin":false},"repo":{"id":48201639,"name":"vega-editor","full_name":"floribon/vega-editor","owner":{"login":"floribon","id":2934743,"avatar_url":"https://avatars.githubusercontent.com/u/2934743?v=3","gravatar_id":"","url":"https://api.github.com/users/floribon","html_url":"https://github.com/floribon","followers_url":"https://api.github.com/users/floribon/followers","following_url":"https://api.github.com/users/floribon/following{/other_user}","gists_url":"https://api.github.com/users/floribon/gists{/gist_id}","starred_url":"https://api.github.com/users/floribon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floribon/subscriptions","organizations_url":"https://api.github.com/users/floribon/orgs","repos_url":"https://api.github.com/users/floribon/repos","events_url":"https://api.github.com/users/floribon/events{/privacy}","received_events_url":"https://api.github.com/users/floribon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/floribon/vega-editor","description":"Web-based Vega and Vega-Lite authoring environment.","fork":true,"url":"https://api.github.com/repos/floribon/vega-editor","forks_url":"https://api.github.com/repos/floribon/vega-editor/forks","keys_url":"https://api.github.com/repos/floribon/vega-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/floribon/vega-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/floribon/vega-editor/teams","hooks_url":"https://api.github.com/repos/floribon/vega-editor/hooks","issue_events_url":"https://api.github.com/repos/floribon/vega-editor/issues/events{/number}","events_url":"https://api.github.com/repos/floribon/vega-editor/events","assignees_url":"https://api.github.com/repos/floribon/vega-editor/assignees{/user}","branches_url":"https://api.github.com/repos/floribon/vega-editor/branches{/branch}","tags_url":"https://api.github.com/repos/floribon/vega-editor/tags","blobs_url":"https://api.github.com/repos/floribon/vega-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/floribon/vega-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/floribon/vega-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/floribon/vega-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/floribon/vega-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/floribon/vega-editor/languages","stargazers_url":"https://api.github.com/repos/floribon/vega-editor/stargazers","contributors_url":"https://api.github.com/repos/floribon/vega-editor/contributors","subscribers_url":"https://api.github.com/repos/floribon/vega-editor/subscribers","subscription_url":"https://api.github.com/repos/floribon/vega-editor/subscription","commits_url":"https://api.github.com/repos/floribon/vega-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/floribon/vega-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/floribon/vega-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/floribon/vega-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/floribon/vega-editor/contents/{+path}","compare_url":"https://api.github.com/repos/floribon/vega-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/floribon/vega-editor/merges","archive_url":"https://api.github.com/repos/floribon/vega-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/floribon/vega-editor/downloads","issues_url":"https://api.github.com/repos/floribon/vega-editor/issues{/number}","pulls_url":"https://api.github.com/repos/floribon/vega-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/floribon/vega-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/floribon/vega-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/floribon/vega-editor/labels{/name}","releases_url":"https://api.github.com/repos/floribon/vega-editor/releases{/id}","created_at":"2015-12-17T22:30:02Z","updated_at":"2015-12-17T22:30:03Z","pushed_at":"2015-12-17T22:31:29Z","git_url":"git://github.com/floribon/vega-editor.git","ssh_url":"git@github.com:floribon/vega-editor.git","clone_url":"https://github.com/floribon/vega-editor.git","svn_url":"https://github.com/floribon/vega-editor","homepage":"http://vega.github.io/vega-editor","size":4383,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vega:master","ref":"master","sha":"15b6e16114a502ac20a5751470dd4718a4246ed1","user":{"login":"vega","id":11796929,"avatar_url":"https://avatars.githubusercontent.com/u/11796929?v=3","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":38760297,"name":"vega-editor","full_name":"vega/vega-editor","owner":{"login":"vega","id":11796929,"avatar_url":"https://avatars.githubusercontent.com/u/11796929?v=3","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/vega-editor","description":"Web-based Vega and Vega-Lite authoring environment.","fork":false,"url":"https://api.github.com/repos/vega/vega-editor","forks_url":"https://api.github.com/repos/vega/vega-editor/forks","keys_url":"https://api.github.com/repos/vega/vega-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/vega-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/vega-editor/teams","hooks_url":"https://api.github.com/repos/vega/vega-editor/hooks","issue_events_url":"https://api.github.com/repos/vega/vega-editor/issues/events{/number}","events_url":"https://api.github.com/repos/vega/vega-editor/events","assignees_url":"https://api.github.com/repos/vega/vega-editor/assignees{/user}","branches_url":"https://api.github.com/repos/vega/vega-editor/branches{/branch}","tags_url":"https://api.github.com/repos/vega/vega-editor/tags","blobs_url":"https://api.github.com/repos/vega/vega-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/vega-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/vega-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/vega-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/vega-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/vega-editor/languages","stargazers_url":"https://api.github.com/repos/vega/vega-editor/stargazers","contributors_url":"https://api.github.com/repos/vega/vega-editor/contributors","subscribers_url":"https://api.github.com/repos/vega/vega-editor/subscribers","subscription_url":"https://api.github.com/repos/vega/vega-editor/subscription","commits_url":"https://api.github.com/repos/vega/vega-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/vega-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/vega-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/vega-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/vega-editor/contents/{+path}","compare_url":"https://api.github.com/repos/vega/vega-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/vega-editor/merges","archive_url":"https://api.github.com/repos/vega/vega-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/vega-editor/downloads","issues_url":"https://api.github.com/repos/vega/vega-editor/issues{/number}","pulls_url":"https://api.github.com/repos/vega/vega-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/vega-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/vega-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/vega-editor/labels{/name}","releases_url":"https://api.github.com/repos/vega/vega-editor/releases{/id}","created_at":"2015-07-08T14:45:42Z","updated_at":"2015-11-14T13:52:02Z","pushed_at":"2015-12-17T22:40:16Z","git_url":"git://github.com/vega/vega-editor.git","ssh_url":"git@github.com:vega/vega-editor.git","clone_url":"https://github.com/vega/vega-editor.git","svn_url":"https://github.com/vega/vega-editor","homepage":"http://vega.github.io/vega-editor","size":4427,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vega/vega-editor/pulls/37"},"html":{"href":"https://github.com/vega/vega-editor/pull/37"},"issue":{"href":"https://api.github.com/repos/vega/vega-editor/issues/37"},"comments":{"href":"https://api.github.com/repos/vega/vega-editor/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/vega/vega-editor/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/vega/vega-editor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vega/vega-editor/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/vega/vega-editor/statuses/9bd9e3332b4fc4c75b2771bf76f0e5e9fe0d81a9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jheer","id":202799,"avatar_url":"https://avatars.githubusercontent.com/u/202799?v=3","gravatar_id":"","url":"https://api.github.com/users/jheer","html_url":"https://github.com/jheer","followers_url":"https://api.github.com/users/jheer/followers","following_url":"https://api.github.com/users/jheer/following{/other_user}","gists_url":"https://api.github.com/users/jheer/gists{/gist_id}","starred_url":"https://api.github.com/users/jheer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jheer/subscriptions","organizations_url":"https://api.github.com/users/jheer/orgs","repos_url":"https://api.github.com/users/jheer/repos","events_url":"https://api.github.com/users/jheer/events{/privacy}","received_events_url":"https://api.github.com/users/jheer/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}