{"action":"opened","number":208,"pull_request":{"url":"https://api.github.com/repos/dmtcp/dmtcp/pulls/208","id":47098797,"html_url":"https://github.com/dmtcp/dmtcp/pull/208","diff_url":"https://github.com/dmtcp/dmtcp/pull/208.diff","patch_url":"https://github.com/dmtcp/dmtcp/pull/208.patch","issue_url":"https://api.github.com/repos/dmtcp/dmtcp/issues/208","number":208,"state":"open","locked":false,"title":"Fix for bbb0332 (decl. of msgrcv for SLES10 lost)","user":{"login":"gc00","id":1207321,"avatar_url":"https://avatars.githubusercontent.com/u/1207321?v=3","gravatar_id":"","url":"https://api.github.com/users/gc00","html_url":"https://github.com/gc00","followers_url":"https://api.github.com/users/gc00/followers","following_url":"https://api.github.com/users/gc00/following{/other_user}","gists_url":"https://api.github.com/users/gc00/gists{/gist_id}","starred_url":"https://api.github.com/users/gc00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gc00/subscriptions","organizations_url":"https://api.github.com/users/gc00/orgs","repos_url":"https://api.github.com/users/gc00/repos","events_url":"https://api.github.com/users/gc00/events{/privacy}","received_events_url":"https://api.github.com/users/gc00/received_events","type":"User","site_admin":false},"body":"I added a small change to sysvipcwrappers.cpp.  This is a hack.  But for the 2.4.2 release, this is a minimal change, and we don't want to risk breaking DMTCP.\r\n\r\nThe story is that in the commit bbb0332, there was no chance to test for SLES10.  This commit\r\nbroke SLES10, which was using glibc version 2.4.  The declaration of msgrcv() changed after glibc-2.4.  Our wrapper for msgrcv() has to use either the SLES10 declaration, or the current POSIX declaration.\r\n\r\nPrior to commit bbb0332, we had a scheme for doing this (`#define msgrcv msgrcv_glibc` before `#include <sys/msg.h>`, so that `msg.h` doesn't declare msgrcv().  Then our own wrapper can declare msgrcv() the same way for everybody.\r\n\r\nThis minimal fix brings back the logic prior to commit bbb0332.  After the 2.4.2 release, we can simplify the logic.  Currently, we have two DMTCP .h files that try to include almost everything available in glibc, and our .cpp files then include these \"giant\" .h file.  This is a bad idea.  The glibc include files should be included only where they are needed, and not almost everywhere.","created_at":"2015-10-08T00:16:36Z","updated_at":"2015-10-08T00:16:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dmtcp/dmtcp/pulls/208/commits","review_comments_url":"https://api.github.com/repos/dmtcp/dmtcp/pulls/208/comments","review_comment_url":"https://api.github.com/repos/dmtcp/dmtcp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmtcp/dmtcp/issues/208/comments","statuses_url":"https://api.github.com/repos/dmtcp/dmtcp/statuses/c3413206276e49f716790154cddd8e2fca94ab1e","head":{"label":"gc00:fix-msgrcv-sles10","ref":"fix-msgrcv-sles10","sha":"c3413206276e49f716790154cddd8e2fca94ab1e","user":{"login":"gc00","id":1207321,"avatar_url":"https://avatars.githubusercontent.com/u/1207321?v=3","gravatar_id":"","url":"https://api.github.com/users/gc00","html_url":"https://github.com/gc00","followers_url":"https://api.github.com/users/gc00/followers","following_url":"https://api.github.com/users/gc00/following{/other_user}","gists_url":"https://api.github.com/users/gc00/gists{/gist_id}","starred_url":"https://api.github.com/users/gc00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gc00/subscriptions","organizations_url":"https://api.github.com/users/gc00/orgs","repos_url":"https://api.github.com/users/gc00/repos","events_url":"https://api.github.com/users/gc00/events{/privacy}","received_events_url":"https://api.github.com/users/gc00/received_events","type":"User","site_admin":false},"repo":{"id":32842900,"name":"dmtcp","full_name":"gc00/dmtcp","owner":{"login":"gc00","id":1207321,"avatar_url":"https://avatars.githubusercontent.com/u/1207321?v=3","gravatar_id":"","url":"https://api.github.com/users/gc00","html_url":"https://github.com/gc00","followers_url":"https://api.github.com/users/gc00/followers","following_url":"https://api.github.com/users/gc00/following{/other_user}","gists_url":"https://api.github.com/users/gc00/gists{/gist_id}","starred_url":"https://api.github.com/users/gc00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gc00/subscriptions","organizations_url":"https://api.github.com/users/gc00/orgs","repos_url":"https://api.github.com/users/gc00/repos","events_url":"https://api.github.com/users/gc00/events{/privacy}","received_events_url":"https://api.github.com/users/gc00/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gc00/dmtcp","description":"DMTCP: Distributed MultiThreaded CheckPointing","fork":true,"url":"https://api.github.com/repos/gc00/dmtcp","forks_url":"https://api.github.com/repos/gc00/dmtcp/forks","keys_url":"https://api.github.com/repos/gc00/dmtcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gc00/dmtcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gc00/dmtcp/teams","hooks_url":"https://api.github.com/repos/gc00/dmtcp/hooks","issue_events_url":"https://api.github.com/repos/gc00/dmtcp/issues/events{/number}","events_url":"https://api.github.com/repos/gc00/dmtcp/events","assignees_url":"https://api.github.com/repos/gc00/dmtcp/assignees{/user}","branches_url":"https://api.github.com/repos/gc00/dmtcp/branches{/branch}","tags_url":"https://api.github.com/repos/gc00/dmtcp/tags","blobs_url":"https://api.github.com/repos/gc00/dmtcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gc00/dmtcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gc00/dmtcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/gc00/dmtcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gc00/dmtcp/statuses/{sha}","languages_url":"https://api.github.com/repos/gc00/dmtcp/languages","stargazers_url":"https://api.github.com/repos/gc00/dmtcp/stargazers","contributors_url":"https://api.github.com/repos/gc00/dmtcp/contributors","subscribers_url":"https://api.github.com/repos/gc00/dmtcp/subscribers","subscription_url":"https://api.github.com/repos/gc00/dmtcp/subscription","commits_url":"https://api.github.com/repos/gc00/dmtcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/gc00/dmtcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/gc00/dmtcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/gc00/dmtcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/gc00/dmtcp/contents/{+path}","compare_url":"https://api.github.com/repos/gc00/dmtcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gc00/dmtcp/merges","archive_url":"https://api.github.com/repos/gc00/dmtcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gc00/dmtcp/downloads","issues_url":"https://api.github.com/repos/gc00/dmtcp/issues{/number}","pulls_url":"https://api.github.com/repos/gc00/dmtcp/pulls{/number}","milestones_url":"https://api.github.com/repos/gc00/dmtcp/milestones{/number}","notifications_url":"https://api.github.com/repos/gc00/dmtcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gc00/dmtcp/labels{/name}","releases_url":"https://api.github.com/repos/gc00/dmtcp/releases{/id}","created_at":"2015-03-25T04:39:37Z","updated_at":"2015-04-17T07:35:22Z","pushed_at":"2015-10-08T00:07:50Z","git_url":"git://github.com/gc00/dmtcp.git","ssh_url":"git@github.com:gc00/dmtcp.git","clone_url":"https://github.com/gc00/dmtcp.git","svn_url":"https://github.com/gc00/dmtcp","homepage":"http://dmtcp.sourceforge.net/","size":12234,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dmtcp:master","ref":"master","sha":"48d492b578adcb047966232462c655d05549d833","user":{"login":"dmtcp","id":1207316,"avatar_url":"https://avatars.githubusercontent.com/u/1207316?v=3","gravatar_id":"","url":"https://api.github.com/users/dmtcp","html_url":"https://github.com/dmtcp","followers_url":"https://api.github.com/users/dmtcp/followers","following_url":"https://api.github.com/users/dmtcp/following{/other_user}","gists_url":"https://api.github.com/users/dmtcp/gists{/gist_id}","starred_url":"https://api.github.com/users/dmtcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmtcp/subscriptions","organizations_url":"https://api.github.com/users/dmtcp/orgs","repos_url":"https://api.github.com/users/dmtcp/repos","events_url":"https://api.github.com/users/dmtcp/events{/privacy}","received_events_url":"https://api.github.com/users/dmtcp/received_events","type":"Organization","site_admin":false},"repo":{"id":24297650,"name":"dmtcp","full_name":"dmtcp/dmtcp","owner":{"login":"dmtcp","id":1207316,"avatar_url":"https://avatars.githubusercontent.com/u/1207316?v=3","gravatar_id":"","url":"https://api.github.com/users/dmtcp","html_url":"https://github.com/dmtcp","followers_url":"https://api.github.com/users/dmtcp/followers","following_url":"https://api.github.com/users/dmtcp/following{/other_user}","gists_url":"https://api.github.com/users/dmtcp/gists{/gist_id}","starred_url":"https://api.github.com/users/dmtcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmtcp/subscriptions","organizations_url":"https://api.github.com/users/dmtcp/orgs","repos_url":"https://api.github.com/users/dmtcp/repos","events_url":"https://api.github.com/users/dmtcp/events{/privacy}","received_events_url":"https://api.github.com/users/dmtcp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dmtcp/dmtcp","description":"DMTCP: Distributed MultiThreaded CheckPointing","fork":false,"url":"https://api.github.com/repos/dmtcp/dmtcp","forks_url":"https://api.github.com/repos/dmtcp/dmtcp/forks","keys_url":"https://api.github.com/repos/dmtcp/dmtcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmtcp/dmtcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmtcp/dmtcp/teams","hooks_url":"https://api.github.com/repos/dmtcp/dmtcp/hooks","issue_events_url":"https://api.github.com/repos/dmtcp/dmtcp/issues/events{/number}","events_url":"https://api.github.com/repos/dmtcp/dmtcp/events","assignees_url":"https://api.github.com/repos/dmtcp/dmtcp/assignees{/user}","branches_url":"https://api.github.com/repos/dmtcp/dmtcp/branches{/branch}","tags_url":"https://api.github.com/repos/dmtcp/dmtcp/tags","blobs_url":"https://api.github.com/repos/dmtcp/dmtcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmtcp/dmtcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmtcp/dmtcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmtcp/dmtcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmtcp/dmtcp/statuses/{sha}","languages_url":"https://api.github.com/repos/dmtcp/dmtcp/languages","stargazers_url":"https://api.github.com/repos/dmtcp/dmtcp/stargazers","contributors_url":"https://api.github.com/repos/dmtcp/dmtcp/contributors","subscribers_url":"https://api.github.com/repos/dmtcp/dmtcp/subscribers","subscription_url":"https://api.github.com/repos/dmtcp/dmtcp/subscription","commits_url":"https://api.github.com/repos/dmtcp/dmtcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmtcp/dmtcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmtcp/dmtcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmtcp/dmtcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmtcp/dmtcp/contents/{+path}","compare_url":"https://api.github.com/repos/dmtcp/dmtcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmtcp/dmtcp/merges","archive_url":"https://api.github.com/repos/dmtcp/dmtcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmtcp/dmtcp/downloads","issues_url":"https://api.github.com/repos/dmtcp/dmtcp/issues{/number}","pulls_url":"https://api.github.com/repos/dmtcp/dmtcp/pulls{/number}","milestones_url":"https://api.github.com/repos/dmtcp/dmtcp/milestones{/number}","notifications_url":"https://api.github.com/repos/dmtcp/dmtcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmtcp/dmtcp/labels{/name}","releases_url":"https://api.github.com/repos/dmtcp/dmtcp/releases{/id}","created_at":"2014-09-21T17:21:59Z","updated_at":"2015-09-22T13:27:33Z","pushed_at":"2015-10-07T22:40:19Z","git_url":"git://github.com/dmtcp/dmtcp.git","ssh_url":"git@github.com:dmtcp/dmtcp.git","clone_url":"https://github.com/dmtcp/dmtcp.git","svn_url":"https://github.com/dmtcp/dmtcp","homepage":"http://dmtcp.sourceforge.net/","size":15476,"stargazers_count":27,"watchers_count":27,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":78,"forks":19,"open_issues":78,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmtcp/dmtcp/pulls/208"},"html":{"href":"https://github.com/dmtcp/dmtcp/pull/208"},"issue":{"href":"https://api.github.com/repos/dmtcp/dmtcp/issues/208"},"comments":{"href":"https://api.github.com/repos/dmtcp/dmtcp/issues/208/comments"},"review_comments":{"href":"https://api.github.com/repos/dmtcp/dmtcp/pulls/208/comments"},"review_comment":{"href":"https://api.github.com/repos/dmtcp/dmtcp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmtcp/dmtcp/pulls/208/commits"},"statuses":{"href":"https://api.github.com/repos/dmtcp/dmtcp/statuses/c3413206276e49f716790154cddd8e2fca94ab1e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":28,"deletions":2,"changed_files":3}}