{"action":"created","issue":{"url":"https://api.github.com/repos/Sarcasm/irony-mode/issues/237","labels_url":"https://api.github.com/repos/Sarcasm/irony-mode/issues/237/labels{/name}","comments_url":"https://api.github.com/repos/Sarcasm/irony-mode/issues/237/comments","events_url":"https://api.github.com/repos/Sarcasm/irony-mode/issues/237/events","html_url":"https://github.com/Sarcasm/irony-mode/pull/237","id":110555020,"number":237,"title":"Useful additions to irony-cdb-json","user":{"login":"MikeSanMichel2","id":14960200,"avatar_url":"https://avatars.githubusercontent.com/u/14960200?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeSanMichel2","html_url":"https://github.com/MikeSanMichel2","followers_url":"https://api.github.com/users/MikeSanMichel2/followers","following_url":"https://api.github.com/users/MikeSanMichel2/following{/other_user}","gists_url":"https://api.github.com/users/MikeSanMichel2/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeSanMichel2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeSanMichel2/subscriptions","organizations_url":"https://api.github.com/users/MikeSanMichel2/orgs","repos_url":"https://api.github.com/users/MikeSanMichel2/repos","events_url":"https://api.github.com/users/MikeSanMichel2/events{/privacy}","received_events_url":"https://api.github.com/users/MikeSanMichel2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-10-08T22:34:47Z","updated_at":"2015-10-14T17:48:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Sarcasm/irony-mode/pulls/237","html_url":"https://github.com/Sarcasm/irony-mode/pull/237","diff_url":"https://github.com/Sarcasm/irony-mode/pull/237.diff","patch_url":"https://github.com/Sarcasm/irony-mode/pull/237.patch"},"body":"closes #234, #236 maybe some issues linked there as well. \r\n\r\nFirst, now looks recursively for parents for both \".json\" and \"build/.json\". (#234)\r\n\r\nSecond, #236. One confusing bit is that calling `irony-cdb-json-add-compile-commands-path`\r\ndoesn't actually finish by loading the database you added. That might be \"Cleaner\", but\r\nits inconvenient and under-documented. Commit 2 fixes that.\r\n\r\nThird, still #236, I was led astray by `add-compile-commands-path` asking for both\r\nproject root and cdb path and ended up choosing the build directory, then the file within it.\r\nI may not have been paying enough attention, but the issues suggest I may not be\r\nthe only one. So, commit 3 adds an alternative which takes only a cdb path,\r\nloads it, and uses the source file paths in it to find the project root as the deepest\r\ndir parenting everything in the cdb.\r\nI would have just replaced `add-compile-commands-path` entirely, but that's public\r\nand the new function takes one argument less. If you like the idea and don't mind\r\nbreaking the API, go for it.\r\n\r\nPlease review/test, I only wrote it, I haven't actually tested it (much) :)\r\n\r\nIf you merge 1m my problem is basically solved. 2 I think is reasonable. 3 was just\r\nfrustration."},"comment":{"url":"https://api.github.com/repos/Sarcasm/irony-mode/issues/comments/148132877","html_url":"https://github.com/Sarcasm/irony-mode/pull/237#issuecomment-148132877","issue_url":"https://api.github.com/repos/Sarcasm/irony-mode/issues/237","id":148132877,"user":{"login":"Sarcasm","id":424046,"avatar_url":"https://avatars.githubusercontent.com/u/424046?v=3","gravatar_id":"","url":"https://api.github.com/users/Sarcasm","html_url":"https://github.com/Sarcasm","followers_url":"https://api.github.com/users/Sarcasm/followers","following_url":"https://api.github.com/users/Sarcasm/following{/other_user}","gists_url":"https://api.github.com/users/Sarcasm/gists{/gist_id}","starred_url":"https://api.github.com/users/Sarcasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sarcasm/subscriptions","organizations_url":"https://api.github.com/users/Sarcasm/orgs","repos_url":"https://api.github.com/users/Sarcasm/repos","events_url":"https://api.github.com/users/Sarcasm/events{/privacy}","received_events_url":"https://api.github.com/users/Sarcasm/received_events","type":"User","site_admin":false},"created_at":"2015-10-14T17:48:14Z","updated_at":"2015-10-14T17:48:14Z","body":"> Can you please disable AppVeyor until you get a chance to fix up the windows CI?\r\n\r\nSecond tentative, to ignore it. If it happens again I will use a more radical approach. Sorry about that."}}