{"action":"created","issue":{"url":"https://api.github.com/repos/ptal/expected/issues/74","labels_url":"https://api.github.com/repos/ptal/expected/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/ptal/expected/issues/74/comments","events_url":"https://api.github.com/repos/ptal/expected/issues/74/events","html_url":"https://github.com/ptal/expected/pull/74","id":53709742,"number":74,"title":"Fixed bug involving static_addressof","user":{"login":"Fraser999","id":190532,"avatar_url":"https://avatars.githubusercontent.com/u/190532?v=3","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-08T03:05:21Z","updated_at":"2015-01-08T03:16:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ptal/expected/pulls/74","html_url":"https://github.com/ptal/expected/pull/74","diff_url":"https://github.com/ptal/expected/pull/74.diff","patch_url":"https://github.com/ptal/expected/pull/74.patch"},"body":"The test I added exposes a bug in expected.hpp where the calls to `static_addressof` need to be prefixed with `detail::`.\r\n\r\nHowever if that's applied, with MSVC 2013, the calls to `has_overloaded_addressof::value` generate the following error:\r\n\r\n    .../boost/expected/detail/static_addressof.hpp(34): error C2057: expected constant expression\r\n\r\ndue to the lack of `constexpr` support.\r\n\r\nI couldn't see a reason to not use `std::addressof` in place of `detail::static_addressof`, but I might well be missing something.  If so, feel free to reject the patch and I can just file an issue separately if you want.\r\n\r\nFinally, I deleted the const overloads of `errorptr()` since they're unused.  `errorptr()` seems to be useful only in the context of non-const functions like the move c'tor or `swap`."},"comment":{"url":"https://api.github.com/repos/ptal/expected/issues/comments/69130529","html_url":"https://github.com/ptal/expected/pull/74#issuecomment-69130529","issue_url":"https://api.github.com/repos/ptal/expected/issues/74","id":69130529,"user":{"login":"viboes","id":721225,"avatar_url":"https://avatars.githubusercontent.com/u/721225?v=3","gravatar_id":"","url":"https://api.github.com/users/viboes","html_url":"https://github.com/viboes","followers_url":"https://api.github.com/users/viboes/followers","following_url":"https://api.github.com/users/viboes/following{/other_user}","gists_url":"https://api.github.com/users/viboes/gists{/gist_id}","starred_url":"https://api.github.com/users/viboes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viboes/subscriptions","organizations_url":"https://api.github.com/users/viboes/orgs","repos_url":"https://api.github.com/users/viboes/repos","events_url":"https://api.github.com/users/viboes/events{/privacy}","received_events_url":"https://api.github.com/users/viboes/received_events","type":"User","site_admin":false},"created_at":"2015-01-08T03:16:49Z","updated_at":"2015-01-08T03:16:49Z","body":"Hi,\r\n\r\nI don't want to replace the static_addressof. We could have a flag that makes it use std::addressof if the user prefers it. Do you mind to prepare this patch?\r\n\r\nCould you provide two PR? one for the test and one for the patch?\r\n\r\nThanks,\r\nVicente"}}