{"action":"created","issue":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/484","labels_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/484/labels{/name}","comments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/484/comments","events_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/484/events","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/484","id":118777667,"number":484,"title":"Validation Against SAS Calculator Nov Updates ","user":{"login":"GoFroggyRun","id":13324931,"avatar_url":"https://avatars.githubusercontent.com/u/13324931?v=3","gravatar_id":"","url":"https://api.github.com/users/GoFroggyRun","html_url":"https://github.com/GoFroggyRun","followers_url":"https://api.github.com/users/GoFroggyRun/followers","following_url":"https://api.github.com/users/GoFroggyRun/following{/other_user}","gists_url":"https://api.github.com/users/GoFroggyRun/gists{/gist_id}","starred_url":"https://api.github.com/users/GoFroggyRun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoFroggyRun/subscriptions","organizations_url":"https://api.github.com/users/GoFroggyRun/orgs","repos_url":"https://api.github.com/users/GoFroggyRun/repos","events_url":"https://api.github.com/users/GoFroggyRun/events{/privacy}","received_events_url":"https://api.github.com/users/GoFroggyRun/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":20,"created_at":"2015-11-25T07:19:23Z","updated_at":"2015-12-10T16:46:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/484","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/484","diff_url":"https://github.com/open-source-economics/Tax-Calculator/pull/484.diff","patch_url":"https://github.com/open-source-economics/Tax-Calculator/pull/484.patch"},"body":"This PR deals with recent updates in the SAS calculator. There'll be no difference (at least empirically) for the two calculators after this PR being merged. Detailed reasons for most changes are provided between lines. Major changes involved are calculation of `NIIT`, `_amed`, `c02900 `, and incorporating the `AGERANGE` variable to estimate `numextra`.  Some clean-ups are also involved, which shall have no changes toward  tax logic. All test results come clean for this PR.\r\n\r\nOutput changes are presented by the following two tables:\r\n\r\nDiagnostic table for master:\r\n![master](https://cloud.githubusercontent.com/assets/13324931/11675393/729c7126-9df7-11e5-9e22-776d0e294a28.png)\r\nDiagnostic table for this PR:\r\n![new pr](https://cloud.githubusercontent.com/assets/13324931/11675399/7c4e1c4c-9df7-11e5-827c-1a0af189fa2a.png)"},"comment":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/comments/163683772","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/484#issuecomment-163683772","issue_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/484","id":163683772,"user":{"login":"GoFroggyRun","id":13324931,"avatar_url":"https://avatars.githubusercontent.com/u/13324931?v=3","gravatar_id":"","url":"https://api.github.com/users/GoFroggyRun","html_url":"https://github.com/GoFroggyRun","followers_url":"https://api.github.com/users/GoFroggyRun/followers","following_url":"https://api.github.com/users/GoFroggyRun/following{/other_user}","gists_url":"https://api.github.com/users/GoFroggyRun/gists{/gist_id}","starred_url":"https://api.github.com/users/GoFroggyRun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoFroggyRun/subscriptions","organizations_url":"https://api.github.com/users/GoFroggyRun/orgs","repos_url":"https://api.github.com/users/GoFroggyRun/repos","events_url":"https://api.github.com/users/GoFroggyRun/events{/privacy}","received_events_url":"https://api.github.com/users/GoFroggyRun/received_events","type":"User","site_admin":false},"created_at":"2015-12-10T16:46:32Z","updated_at":"2015-12-10T16:46:32Z","body":"@martinholmer \r\n`_line45` is defined by `_line45 = max(0., AMT_CG_thd1[MARS - 1] - c24520)`. I'm quite sure that the aggregate difference in income tax liability might not be explained completely by the changes in AMT, which are considered to be minor. The fact that the two units are now itemizer (note they were all standard filers in current master) shall have more significant impact on the income tax liability. And, as I mentioned, such shifts in deduction might have something to do with `c03260`, and also the change of `_limitratio`, from `_limitratio = _phase2_i / _sep` to `_limitratio = _phase2_i`, which are all involved in calculating the itemized deduction. "}}