{"action":"opened","number":284,"pull_request":{"url":"https://api.github.com/repos/mohiva/play-silhouette/pulls/284","id":29322904,"html_url":"https://github.com/mohiva/play-silhouette/pull/284","diff_url":"https://github.com/mohiva/play-silhouette/pull/284.diff","patch_url":"https://github.com/mohiva/play-silhouette/pull/284.patch","issue_url":"https://api.github.com/repos/mohiva/play-silhouette/issues/284","number":284,"state":"open","locked":false,"title":"CredentialsProvider & BasicAuthProvider should throw AccessDeniedExceptions","user":{"login":"akkie","id":307006,"avatar_url":"https://avatars.githubusercontent.com/u/307006?v=3","gravatar_id":"","url":"https://api.github.com/users/akkie","html_url":"https://github.com/akkie","followers_url":"https://api.github.com/users/akkie/followers","following_url":"https://api.github.com/users/akkie/following{/other_user}","gists_url":"https://api.github.com/users/akkie/gists{/gist_id}","starred_url":"https://api.github.com/users/akkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akkie/subscriptions","organizations_url":"https://api.github.com/users/akkie/orgs","repos_url":"https://api.github.com/users/akkie/repos","events_url":"https://api.github.com/users/akkie/events{/privacy}","received_events_url":"https://api.github.com/users/akkie/received_events","type":"User","site_admin":false},"body":"Unless I'm misunderstanding https://github.com/mohiva/play-silhouette/blob/ce877f/docs/how-it-works/error-handling.rst\r\n> The AccessDeniedException will be thrown if a user provides incorrect credentials\r\n\r\nThe following lines should throw AccessDeniedExceptions instead of AuthenticationExceptions:\r\n\r\n[CredentialsProvider.scala#L76](https://github.com/mohiva/play-silhouette/blob/ce877f/silhouette/app/com/mohiva/play/silhouette/impl/providers/CredentialsProvider.scala#L76)\r\n\r\n[BasicAuthProvider.scala#L77](https://github.com/mohiva/play-silhouette/blob/ce877f/silhouette/app/com/mohiva/play/silhouette/impl/providers/BasicAuthProvider.scala#L77)\r\n","created_at":"2015-02-14T17:34:20Z","updated_at":"2015-02-14T17:34:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":{"url":"https://api.github.com/repos/mohiva/play-silhouette/milestones/3","labels_url":"https://api.github.com/repos/mohiva/play-silhouette/milestones/3/labels","id":820721,"number":3,"title":"2.0","description":"","creator":{"login":"akkie","id":307006,"avatar_url":"https://avatars.githubusercontent.com/u/307006?v=3","gravatar_id":"","url":"https://api.github.com/users/akkie","html_url":"https://github.com/akkie","followers_url":"https://api.github.com/users/akkie/followers","following_url":"https://api.github.com/users/akkie/following{/other_user}","gists_url":"https://api.github.com/users/akkie/gists{/gist_id}","starred_url":"https://api.github.com/users/akkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akkie/subscriptions","organizations_url":"https://api.github.com/users/akkie/orgs","repos_url":"https://api.github.com/users/akkie/repos","events_url":"https://api.github.com/users/akkie/events{/privacy}","received_events_url":"https://api.github.com/users/akkie/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":10,"state":"open","created_at":"2014-10-10T05:58:25Z","updated_at":"2015-02-13T06:59:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mohiva/play-silhouette/pulls/284/commits","review_comments_url":"https://api.github.com/repos/mohiva/play-silhouette/pulls/284/comments","review_comment_url":"https://api.github.com/repos/mohiva/play-silhouette/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mohiva/play-silhouette/issues/284/comments","statuses_url":"https://api.github.com/repos/mohiva/play-silhouette/statuses/865f39c93cf3c8b14247b9433b4e4bdf7400a7f2","head":{"label":"akkie:master","ref":"master","sha":"865f39c93cf3c8b14247b9433b4e4bdf7400a7f2","user":{"login":"akkie","id":307006,"avatar_url":"https://avatars.githubusercontent.com/u/307006?v=3","gravatar_id":"","url":"https://api.github.com/users/akkie","html_url":"https://github.com/akkie","followers_url":"https://api.github.com/users/akkie/followers","following_url":"https://api.github.com/users/akkie/following{/other_user}","gists_url":"https://api.github.com/users/akkie/gists{/gist_id}","starred_url":"https://api.github.com/users/akkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akkie/subscriptions","organizations_url":"https://api.github.com/users/akkie/orgs","repos_url":"https://api.github.com/users/akkie/repos","events_url":"https://api.github.com/users/akkie/events{/privacy}","received_events_url":"https://api.github.com/users/akkie/received_events","type":"User","site_admin":false},"repo":{"id":17032529,"name":"play-silhouette","full_name":"akkie/play-silhouette","owner":{"login":"akkie","id":307006,"avatar_url":"https://avatars.githubusercontent.com/u/307006?v=3","gravatar_id":"","url":"https://api.github.com/users/akkie","html_url":"https://github.com/akkie","followers_url":"https://api.github.com/users/akkie/followers","following_url":"https://api.github.com/users/akkie/following{/other_user}","gists_url":"https://api.github.com/users/akkie/gists{/gist_id}","starred_url":"https://api.github.com/users/akkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akkie/subscriptions","organizations_url":"https://api.github.com/users/akkie/orgs","repos_url":"https://api.github.com/users/akkie/repos","events_url":"https://api.github.com/users/akkie/events{/privacy}","received_events_url":"https://api.github.com/users/akkie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akkie/play-silhouette","description":"Silhouette is an authentication library for Play Framework applications that supports several authentication methods, including OAuth, OAuth2, OpenID and password.","fork":true,"url":"https://api.github.com/repos/akkie/play-silhouette","forks_url":"https://api.github.com/repos/akkie/play-silhouette/forks","keys_url":"https://api.github.com/repos/akkie/play-silhouette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akkie/play-silhouette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akkie/play-silhouette/teams","hooks_url":"https://api.github.com/repos/akkie/play-silhouette/hooks","issue_events_url":"https://api.github.com/repos/akkie/play-silhouette/issues/events{/number}","events_url":"https://api.github.com/repos/akkie/play-silhouette/events","assignees_url":"https://api.github.com/repos/akkie/play-silhouette/assignees{/user}","branches_url":"https://api.github.com/repos/akkie/play-silhouette/branches{/branch}","tags_url":"https://api.github.com/repos/akkie/play-silhouette/tags","blobs_url":"https://api.github.com/repos/akkie/play-silhouette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akkie/play-silhouette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akkie/play-silhouette/git/refs{/sha}","trees_url":"https://api.github.com/repos/akkie/play-silhouette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akkie/play-silhouette/statuses/{sha}","languages_url":"https://api.github.com/repos/akkie/play-silhouette/languages","stargazers_url":"https://api.github.com/repos/akkie/play-silhouette/stargazers","contributors_url":"https://api.github.com/repos/akkie/play-silhouette/contributors","subscribers_url":"https://api.github.com/repos/akkie/play-silhouette/subscribers","subscription_url":"https://api.github.com/repos/akkie/play-silhouette/subscription","commits_url":"https://api.github.com/repos/akkie/play-silhouette/commits{/sha}","git_commits_url":"https://api.github.com/repos/akkie/play-silhouette/git/commits{/sha}","comments_url":"https://api.github.com/repos/akkie/play-silhouette/comments{/number}","issue_comment_url":"https://api.github.com/repos/akkie/play-silhouette/issues/comments/{number}","contents_url":"https://api.github.com/repos/akkie/play-silhouette/contents/{+path}","compare_url":"https://api.github.com/repos/akkie/play-silhouette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akkie/play-silhouette/merges","archive_url":"https://api.github.com/repos/akkie/play-silhouette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akkie/play-silhouette/downloads","issues_url":"https://api.github.com/repos/akkie/play-silhouette/issues{/number}","pulls_url":"https://api.github.com/repos/akkie/play-silhouette/pulls{/number}","milestones_url":"https://api.github.com/repos/akkie/play-silhouette/milestones{/number}","notifications_url":"https://api.github.com/repos/akkie/play-silhouette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akkie/play-silhouette/labels{/name}","releases_url":"https://api.github.com/repos/akkie/play-silhouette/releases{/id}","created_at":"2014-02-20T19:22:41Z","updated_at":"2015-02-14T17:32:25Z","pushed_at":"2015-02-14T17:32:25Z","git_url":"git://github.com/akkie/play-silhouette.git","ssh_url":"git@github.com:akkie/play-silhouette.git","clone_url":"https://github.com/akkie/play-silhouette.git","svn_url":"https://github.com/akkie/play-silhouette","homepage":"http://silhouette.mohiva.com","size":2571,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mohiva:master","ref":"master","sha":"064f7b4c97eef548e9d99b2a4d9492ec064a45db","user":{"login":"mohiva","id":594563,"avatar_url":"https://avatars.githubusercontent.com/u/594563?v=3","gravatar_id":"","url":"https://api.github.com/users/mohiva","html_url":"https://github.com/mohiva","followers_url":"https://api.github.com/users/mohiva/followers","following_url":"https://api.github.com/users/mohiva/following{/other_user}","gists_url":"https://api.github.com/users/mohiva/gists{/gist_id}","starred_url":"https://api.github.com/users/mohiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohiva/subscriptions","organizations_url":"https://api.github.com/users/mohiva/orgs","repos_url":"https://api.github.com/users/mohiva/repos","events_url":"https://api.github.com/users/mohiva/events{/privacy}","received_events_url":"https://api.github.com/users/mohiva/received_events","type":"Organization","site_admin":false},"repo":{"id":15529618,"name":"play-silhouette","full_name":"mohiva/play-silhouette","owner":{"login":"mohiva","id":594563,"avatar_url":"https://avatars.githubusercontent.com/u/594563?v=3","gravatar_id":"","url":"https://api.github.com/users/mohiva","html_url":"https://github.com/mohiva","followers_url":"https://api.github.com/users/mohiva/followers","following_url":"https://api.github.com/users/mohiva/following{/other_user}","gists_url":"https://api.github.com/users/mohiva/gists{/gist_id}","starred_url":"https://api.github.com/users/mohiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohiva/subscriptions","organizations_url":"https://api.github.com/users/mohiva/orgs","repos_url":"https://api.github.com/users/mohiva/repos","events_url":"https://api.github.com/users/mohiva/events{/privacy}","received_events_url":"https://api.github.com/users/mohiva/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mohiva/play-silhouette","description":"Silhouette is an authentication library for Play Framework applications that supports several authentication methods, including OAuth1, OAuth2, OpenID, Credentials, Basic Authentication or custom authentication schemes.","fork":false,"url":"https://api.github.com/repos/mohiva/play-silhouette","forks_url":"https://api.github.com/repos/mohiva/play-silhouette/forks","keys_url":"https://api.github.com/repos/mohiva/play-silhouette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mohiva/play-silhouette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mohiva/play-silhouette/teams","hooks_url":"https://api.github.com/repos/mohiva/play-silhouette/hooks","issue_events_url":"https://api.github.com/repos/mohiva/play-silhouette/issues/events{/number}","events_url":"https://api.github.com/repos/mohiva/play-silhouette/events","assignees_url":"https://api.github.com/repos/mohiva/play-silhouette/assignees{/user}","branches_url":"https://api.github.com/repos/mohiva/play-silhouette/branches{/branch}","tags_url":"https://api.github.com/repos/mohiva/play-silhouette/tags","blobs_url":"https://api.github.com/repos/mohiva/play-silhouette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mohiva/play-silhouette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mohiva/play-silhouette/git/refs{/sha}","trees_url":"https://api.github.com/repos/mohiva/play-silhouette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mohiva/play-silhouette/statuses/{sha}","languages_url":"https://api.github.com/repos/mohiva/play-silhouette/languages","stargazers_url":"https://api.github.com/repos/mohiva/play-silhouette/stargazers","contributors_url":"https://api.github.com/repos/mohiva/play-silhouette/contributors","subscribers_url":"https://api.github.com/repos/mohiva/play-silhouette/subscribers","subscription_url":"https://api.github.com/repos/mohiva/play-silhouette/subscription","commits_url":"https://api.github.com/repos/mohiva/play-silhouette/commits{/sha}","git_commits_url":"https://api.github.com/repos/mohiva/play-silhouette/git/commits{/sha}","comments_url":"https://api.github.com/repos/mohiva/play-silhouette/comments{/number}","issue_comment_url":"https://api.github.com/repos/mohiva/play-silhouette/issues/comments/{number}","contents_url":"https://api.github.com/repos/mohiva/play-silhouette/contents/{+path}","compare_url":"https://api.github.com/repos/mohiva/play-silhouette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mohiva/play-silhouette/merges","archive_url":"https://api.github.com/repos/mohiva/play-silhouette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mohiva/play-silhouette/downloads","issues_url":"https://api.github.com/repos/mohiva/play-silhouette/issues{/number}","pulls_url":"https://api.github.com/repos/mohiva/play-silhouette/pulls{/number}","milestones_url":"https://api.github.com/repos/mohiva/play-silhouette/milestones{/number}","notifications_url":"https://api.github.com/repos/mohiva/play-silhouette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mohiva/play-silhouette/labels{/name}","releases_url":"https://api.github.com/repos/mohiva/play-silhouette/releases{/id}","created_at":"2013-12-30T14:44:12Z","updated_at":"2015-02-13T19:08:09Z","pushed_at":"2015-02-13T06:59:00Z","git_url":"git://github.com/mohiva/play-silhouette.git","ssh_url":"git@github.com:mohiva/play-silhouette.git","clone_url":"https://github.com/mohiva/play-silhouette.git","svn_url":"https://github.com/mohiva/play-silhouette","homepage":"http://silhouette.mohiva.com","size":6029,"stargazers_count":189,"watchers_count":189,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":34,"mirror_url":null,"open_issues_count":7,"forks":34,"open_issues":7,"watchers":189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mohiva/play-silhouette/pulls/284"},"html":{"href":"https://github.com/mohiva/play-silhouette/pull/284"},"issue":{"href":"https://api.github.com/repos/mohiva/play-silhouette/issues/284"},"comments":{"href":"https://api.github.com/repos/mohiva/play-silhouette/issues/284/comments"},"review_comments":{"href":"https://api.github.com/repos/mohiva/play-silhouette/pulls/284/comments"},"review_comment":{"href":"https://api.github.com/repos/mohiva/play-silhouette/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mohiva/play-silhouette/pulls/284/commits"},"statuses":{"href":"https://api.github.com/repos/mohiva/play-silhouette/statuses/865f39c93cf3c8b14247b9433b4e4bdf7400a7f2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":8,"deletions":4,"changed_files":1}}