{"action":"created","comment":{"url":"https://api.github.com/repos/non/algebra/pulls/comments/24352043","id":24352043,"diff_hunk":"@@ -26,33 +50,80 @@ class MapEq[K, V](implicit ev: Eq[V], a: AdditiveMonoid[V]) extends Eq[Map[K, V]\n     check(x, y) && check(y, x)","path":"std/src/main/scala/algebra/std/map.scala","position":59,"original_position":59,"commit_id":"b85650c27a1f8abb475de0dc17c3dead8ba6e570","original_commit_id":"b85650c27a1f8abb475de0dc17c3dead8ba6e570","user":{"login":"johnynek","id":67958,"avatar_url":"https://avatars.githubusercontent.com/u/67958?v=3","gravatar_id":"","url":"https://api.github.com/users/johnynek","html_url":"https://github.com/johnynek","followers_url":"https://api.github.com/users/johnynek/followers","following_url":"https://api.github.com/users/johnynek/following{/other_user}","gists_url":"https://api.github.com/users/johnynek/gists{/gist_id}","starred_url":"https://api.github.com/users/johnynek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnynek/subscriptions","organizations_url":"https://api.github.com/users/johnynek/orgs","repos_url":"https://api.github.com/users/johnynek/repos","events_url":"https://api.github.com/users/johnynek/events{/privacy}","received_events_url":"https://api.github.com/users/johnynek/received_events","type":"User","site_admin":false},"body":"scratch that. Fracking 0 == None.","created_at":"2015-02-09T18:34:40Z","updated_at":"2015-02-09T18:34:40Z","html_url":"https://github.com/non/algebra/pull/44#discussion_r24352043","pull_request_url":"https://api.github.com/repos/non/algebra/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/non/algebra/pulls/comments/24352043"},"html":{"href":"https://github.com/non/algebra/pull/44#discussion_r24352043"},"pull_request":{"href":"https://api.github.com/repos/non/algebra/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/non/algebra/pulls/44","id":28870266,"html_url":"https://github.com/non/algebra/pull/44","diff_url":"https://github.com/non/algebra/pull/44.diff","patch_url":"https://github.com/non/algebra/pull/44.patch","issue_url":"https://api.github.com/repos/non/algebra/issues/44","number":44,"state":"open","locked":false,"title":"Topic/clean up std instances","user":{"login":"non","id":218045,"avatar_url":"https://avatars.githubusercontent.com/u/218045?v=3","gravatar_id":"","url":"https://api.github.com/users/non","html_url":"https://github.com/non","followers_url":"https://api.github.com/users/non/followers","following_url":"https://api.github.com/users/non/following{/other_user}","gists_url":"https://api.github.com/users/non/gists{/gist_id}","starred_url":"https://api.github.com/users/non/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/non/subscriptions","organizations_url":"https://api.github.com/users/non/orgs","repos_url":"https://api.github.com/users/non/repos","events_url":"https://api.github.com/users/non/events{/privacy}","received_events_url":"https://api.github.com/users/non/received_events","type":"User","site_admin":false},"body":"Here are a bunch of new instances, some clean ups, etc.\r\n\r\nI think all these should be good to go. However:\r\n\r\n1. There are still some common types missing (e.g. `Vector`)\r\n2. We need additional additive/multiplicative variants (e.g. for `Option`)\r\n3. Maybe we should make addition a default semigroup for number types?\r\n4. We provide `Semigroup[A] => Semigroup[Option[A]]` but `Option[_]` could use `orElse` in other cases. Worth supporting?\r\n\r\nI don't think we have to answer all those questions immediately but we'll eventually want to.","created_at":"2015-02-07T21:12:50Z","updated_at":"2015-02-09T18:34:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb7a4c4dbadd9cf6c26efcde7e8eb79e5771c5d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/non/algebra/pulls/44/commits","review_comments_url":"https://api.github.com/repos/non/algebra/pulls/44/comments","review_comment_url":"https://api.github.com/repos/non/algebra/pulls/comments/{number}","comments_url":"https://api.github.com/repos/non/algebra/issues/44/comments","statuses_url":"https://api.github.com/repos/non/algebra/statuses/b85650c27a1f8abb475de0dc17c3dead8ba6e570","head":{"label":"non:topic/clean-up-std-instances","ref":"topic/clean-up-std-instances","sha":"b85650c27a1f8abb475de0dc17c3dead8ba6e570","user":{"login":"non","id":218045,"avatar_url":"https://avatars.githubusercontent.com/u/218045?v=3","gravatar_id":"","url":"https://api.github.com/users/non","html_url":"https://github.com/non","followers_url":"https://api.github.com/users/non/followers","following_url":"https://api.github.com/users/non/following{/other_user}","gists_url":"https://api.github.com/users/non/gists{/gist_id}","starred_url":"https://api.github.com/users/non/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/non/subscriptions","organizations_url":"https://api.github.com/users/non/orgs","repos_url":"https://api.github.com/users/non/repos","events_url":"https://api.github.com/users/non/events{/privacy}","received_events_url":"https://api.github.com/users/non/received_events","type":"User","site_admin":false},"repo":{"id":13668558,"name":"algebra","full_name":"non/algebra","owner":{"login":"non","id":218045,"avatar_url":"https://avatars.githubusercontent.com/u/218045?v=3","gravatar_id":"","url":"https://api.github.com/users/non","html_url":"https://github.com/non","followers_url":"https://api.github.com/users/non/followers","following_url":"https://api.github.com/users/non/following{/other_user}","gists_url":"https://api.github.com/users/non/gists{/gist_id}","starred_url":"https://api.github.com/users/non/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/non/subscriptions","organizations_url":"https://api.github.com/users/non/orgs","repos_url":"https://api.github.com/users/non/repos","events_url":"https://api.github.com/users/non/events{/privacy}","received_events_url":"https://api.github.com/users/non/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/non/algebra","description":"Experimental project to lay out basic algebra type classes","fork":false,"url":"https://api.github.com/repos/non/algebra","forks_url":"https://api.github.com/repos/non/algebra/forks","keys_url":"https://api.github.com/repos/non/algebra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/non/algebra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/non/algebra/teams","hooks_url":"https://api.github.com/repos/non/algebra/hooks","issue_events_url":"https://api.github.com/repos/non/algebra/issues/events{/number}","events_url":"https://api.github.com/repos/non/algebra/events","assignees_url":"https://api.github.com/repos/non/algebra/assignees{/user}","branches_url":"https://api.github.com/repos/non/algebra/branches{/branch}","tags_url":"https://api.github.com/repos/non/algebra/tags","blobs_url":"https://api.github.com/repos/non/algebra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/non/algebra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/non/algebra/git/refs{/sha}","trees_url":"https://api.github.com/repos/non/algebra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/non/algebra/statuses/{sha}","languages_url":"https://api.github.com/repos/non/algebra/languages","stargazers_url":"https://api.github.com/repos/non/algebra/stargazers","contributors_url":"https://api.github.com/repos/non/algebra/contributors","subscribers_url":"https://api.github.com/repos/non/algebra/subscribers","subscription_url":"https://api.github.com/repos/non/algebra/subscription","commits_url":"https://api.github.com/repos/non/algebra/commits{/sha}","git_commits_url":"https://api.github.com/repos/non/algebra/git/commits{/sha}","comments_url":"https://api.github.com/repos/non/algebra/comments{/number}","issue_comment_url":"https://api.github.com/repos/non/algebra/issues/comments/{number}","contents_url":"https://api.github.com/repos/non/algebra/contents/{+path}","compare_url":"https://api.github.com/repos/non/algebra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/non/algebra/merges","archive_url":"https://api.github.com/repos/non/algebra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/non/algebra/downloads","issues_url":"https://api.github.com/repos/non/algebra/issues{/number}","pulls_url":"https://api.github.com/repos/non/algebra/pulls{/number}","milestones_url":"https://api.github.com/repos/non/algebra/milestones{/number}","notifications_url":"https://api.github.com/repos/non/algebra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/non/algebra/labels{/name}","releases_url":"https://api.github.com/repos/non/algebra/releases{/id}","created_at":"2013-10-18T03:59:21Z","updated_at":"2015-02-09T16:16:37Z","pushed_at":"2015-02-09T16:16:37Z","git_url":"git://github.com/non/algebra.git","ssh_url":"git@github.com:non/algebra.git","clone_url":"https://github.com/non/algebra.git","svn_url":"https://github.com/non/algebra","homepage":null,"size":989,"stargazers_count":87,"watchers_count":87,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":15,"forks":12,"open_issues":15,"watchers":87,"default_branch":"master"}},"base":{"label":"non:master","ref":"master","sha":"d9abf08a98bb94953ff28eba24b20a6e4df07dc8","user":{"login":"non","id":218045,"avatar_url":"https://avatars.githubusercontent.com/u/218045?v=3","gravatar_id":"","url":"https://api.github.com/users/non","html_url":"https://github.com/non","followers_url":"https://api.github.com/users/non/followers","following_url":"https://api.github.com/users/non/following{/other_user}","gists_url":"https://api.github.com/users/non/gists{/gist_id}","starred_url":"https://api.github.com/users/non/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/non/subscriptions","organizations_url":"https://api.github.com/users/non/orgs","repos_url":"https://api.github.com/users/non/repos","events_url":"https://api.github.com/users/non/events{/privacy}","received_events_url":"https://api.github.com/users/non/received_events","type":"User","site_admin":false},"repo":{"id":13668558,"name":"algebra","full_name":"non/algebra","owner":{"login":"non","id":218045,"avatar_url":"https://avatars.githubusercontent.com/u/218045?v=3","gravatar_id":"","url":"https://api.github.com/users/non","html_url":"https://github.com/non","followers_url":"https://api.github.com/users/non/followers","following_url":"https://api.github.com/users/non/following{/other_user}","gists_url":"https://api.github.com/users/non/gists{/gist_id}","starred_url":"https://api.github.com/users/non/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/non/subscriptions","organizations_url":"https://api.github.com/users/non/orgs","repos_url":"https://api.github.com/users/non/repos","events_url":"https://api.github.com/users/non/events{/privacy}","received_events_url":"https://api.github.com/users/non/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/non/algebra","description":"Experimental project to lay out basic algebra type classes","fork":false,"url":"https://api.github.com/repos/non/algebra","forks_url":"https://api.github.com/repos/non/algebra/forks","keys_url":"https://api.github.com/repos/non/algebra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/non/algebra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/non/algebra/teams","hooks_url":"https://api.github.com/repos/non/algebra/hooks","issue_events_url":"https://api.github.com/repos/non/algebra/issues/events{/number}","events_url":"https://api.github.com/repos/non/algebra/events","assignees_url":"https://api.github.com/repos/non/algebra/assignees{/user}","branches_url":"https://api.github.com/repos/non/algebra/branches{/branch}","tags_url":"https://api.github.com/repos/non/algebra/tags","blobs_url":"https://api.github.com/repos/non/algebra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/non/algebra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/non/algebra/git/refs{/sha}","trees_url":"https://api.github.com/repos/non/algebra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/non/algebra/statuses/{sha}","languages_url":"https://api.github.com/repos/non/algebra/languages","stargazers_url":"https://api.github.com/repos/non/algebra/stargazers","contributors_url":"https://api.github.com/repos/non/algebra/contributors","subscribers_url":"https://api.github.com/repos/non/algebra/subscribers","subscription_url":"https://api.github.com/repos/non/algebra/subscription","commits_url":"https://api.github.com/repos/non/algebra/commits{/sha}","git_commits_url":"https://api.github.com/repos/non/algebra/git/commits{/sha}","comments_url":"https://api.github.com/repos/non/algebra/comments{/number}","issue_comment_url":"https://api.github.com/repos/non/algebra/issues/comments/{number}","contents_url":"https://api.github.com/repos/non/algebra/contents/{+path}","compare_url":"https://api.github.com/repos/non/algebra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/non/algebra/merges","archive_url":"https://api.github.com/repos/non/algebra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/non/algebra/downloads","issues_url":"https://api.github.com/repos/non/algebra/issues{/number}","pulls_url":"https://api.github.com/repos/non/algebra/pulls{/number}","milestones_url":"https://api.github.com/repos/non/algebra/milestones{/number}","notifications_url":"https://api.github.com/repos/non/algebra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/non/algebra/labels{/name}","releases_url":"https://api.github.com/repos/non/algebra/releases{/id}","created_at":"2013-10-18T03:59:21Z","updated_at":"2015-02-09T16:16:37Z","pushed_at":"2015-02-09T16:16:37Z","git_url":"git://github.com/non/algebra.git","ssh_url":"git@github.com:non/algebra.git","clone_url":"https://github.com/non/algebra.git","svn_url":"https://github.com/non/algebra","homepage":null,"size":989,"stargazers_count":87,"watchers_count":87,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":15,"forks":12,"open_issues":15,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/non/algebra/pulls/44"},"html":{"href":"https://github.com/non/algebra/pull/44"},"issue":{"href":"https://api.github.com/repos/non/algebra/issues/44"},"comments":{"href":"https://api.github.com/repos/non/algebra/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/non/algebra/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/non/algebra/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/non/algebra/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/non/algebra/statuses/b85650c27a1f8abb475de0dc17c3dead8ba6e570"}}}}