{"action":"created","comment":{"url":"https://api.github.com/repos/appscot/sails-orientdb/pulls/comments/29930461","id":29930461,"diff_hunk":"@@ -3,7 +3,8 @@ var assert = require('assert'),\n \n var self = this,\n     fixtures,\n-    config;\n+    config,\n+\t\tconfigConn = require('../../../test-connection.json');","path":"test/integration-orientdb/tests/config/database.test.js","position":6,"original_position":6,"commit_id":"b736ba3e7625a8edd4bd9d282c32f68c35f1619d","original_commit_id":"b736ba3e7625a8edd4bd9d282c32f68c35f1619d","user":{"login":"dmarcelino","id":1280446,"avatar_url":"https://avatars.githubusercontent.com/u/1280446?v=3","gravatar_id":"","url":"https://api.github.com/users/dmarcelino","html_url":"https://github.com/dmarcelino","followers_url":"https://api.github.com/users/dmarcelino/followers","following_url":"https://api.github.com/users/dmarcelino/following{/other_user}","gists_url":"https://api.github.com/users/dmarcelino/gists{/gist_id}","starred_url":"https://api.github.com/users/dmarcelino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmarcelino/subscriptions","organizations_url":"https://api.github.com/users/dmarcelino/orgs","repos_url":"https://api.github.com/users/dmarcelino/repos","events_url":"https://api.github.com/users/dmarcelino/events{/privacy}","received_events_url":"https://api.github.com/users/dmarcelino/received_events","type":"User","site_admin":false},"body":"The indentation seems off, can you fix it please? We use 2 spaces as tabs.","created_at":"2015-05-08T10:32:10Z","updated_at":"2015-05-08T10:32:10Z","html_url":"https://github.com/appscot/sails-orientdb/pull/86#discussion_r29930461","pull_request_url":"https://api.github.com/repos/appscot/sails-orientdb/pulls/86","_links":{"self":{"href":"https://api.github.com/repos/appscot/sails-orientdb/pulls/comments/29930461"},"html":{"href":"https://github.com/appscot/sails-orientdb/pull/86#discussion_r29930461"},"pull_request":{"href":"https://api.github.com/repos/appscot/sails-orientdb/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/appscot/sails-orientdb/pulls/86","id":33992781,"html_url":"https://github.com/appscot/sails-orientdb/pull/86","diff_url":"https://github.com/appscot/sails-orientdb/pull/86.diff","patch_url":"https://github.com/appscot/sails-orientdb/pull/86.patch","issue_url":"https://api.github.com/repos/appscot/sails-orientdb/issues/86","number":86,"state":"open","locked":false,"title":"Wrong user/password for database(not server) credentials","user":{"login":"matanshukry","id":5613042,"avatar_url":"https://avatars.githubusercontent.com/u/5613042?v=3","gravatar_id":"","url":"https://api.github.com/users/matanshukry","html_url":"https://github.com/matanshukry","followers_url":"https://api.github.com/users/matanshukry/followers","following_url":"https://api.github.com/users/matanshukry/following{/other_user}","gists_url":"https://api.github.com/users/matanshukry/gists{/gist_id}","starred_url":"https://api.github.com/users/matanshukry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matanshukry/subscriptions","organizations_url":"https://api.github.com/users/matanshukry/orgs","repos_url":"https://api.github.com/users/matanshukry/repos","events_url":"https://api.github.com/users/matanshukry/events{/privacy}","received_events_url":"https://api.github.com/users/matanshukry/received_events","type":"User","site_admin":false},"body":"Currently, we require to insert server (root) credentials.\r\nThis is since in connection.js, we try to get list of databases, and if one doesn't exists, we attempt to create it.\r\n\r\nI added an option we can bypass that, and only enter database credentials rather than server credentials. Obviously, however, one has to create the database in advance.\r\n\r\nTo use it, simply omit config.username , and use config.options.databaseUser\r\nNote the code only checks for the username, but the password should accompany the user in the same location.","created_at":"2015-04-23T20:22:40Z","updated_at":"2015-05-08T10:32:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ac6c464c846a9275b801490e8e26b12a010f0a0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/appscot/sails-orientdb/pulls/86/commits","review_comments_url":"https://api.github.com/repos/appscot/sails-orientdb/pulls/86/comments","review_comment_url":"https://api.github.com/repos/appscot/sails-orientdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appscot/sails-orientdb/issues/86/comments","statuses_url":"https://api.github.com/repos/appscot/sails-orientdb/statuses/b736ba3e7625a8edd4bd9d282c32f68c35f1619d","head":{"label":"matanshukry:master","ref":"master","sha":"b736ba3e7625a8edd4bd9d282c32f68c35f1619d","user":{"login":"matanshukry","id":5613042,"avatar_url":"https://avatars.githubusercontent.com/u/5613042?v=3","gravatar_id":"","url":"https://api.github.com/users/matanshukry","html_url":"https://github.com/matanshukry","followers_url":"https://api.github.com/users/matanshukry/followers","following_url":"https://api.github.com/users/matanshukry/following{/other_user}","gists_url":"https://api.github.com/users/matanshukry/gists{/gist_id}","starred_url":"https://api.github.com/users/matanshukry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matanshukry/subscriptions","organizations_url":"https://api.github.com/users/matanshukry/orgs","repos_url":"https://api.github.com/users/matanshukry/repos","events_url":"https://api.github.com/users/matanshukry/events{/privacy}","received_events_url":"https://api.github.com/users/matanshukry/received_events","type":"User","site_admin":false},"repo":{"id":34472661,"name":"sails-orientdb","full_name":"matanshukry/sails-orientdb","owner":{"login":"matanshukry","id":5613042,"avatar_url":"https://avatars.githubusercontent.com/u/5613042?v=3","gravatar_id":"","url":"https://api.github.com/users/matanshukry","html_url":"https://github.com/matanshukry","followers_url":"https://api.github.com/users/matanshukry/followers","following_url":"https://api.github.com/users/matanshukry/following{/other_user}","gists_url":"https://api.github.com/users/matanshukry/gists{/gist_id}","starred_url":"https://api.github.com/users/matanshukry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matanshukry/subscriptions","organizations_url":"https://api.github.com/users/matanshukry/orgs","repos_url":"https://api.github.com/users/matanshukry/repos","events_url":"https://api.github.com/users/matanshukry/events{/privacy}","received_events_url":"https://api.github.com/users/matanshukry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matanshukry/sails-orientdb","description":"OrientDB adapter for Waterline / Sails.js ORM","fork":true,"url":"https://api.github.com/repos/matanshukry/sails-orientdb","forks_url":"https://api.github.com/repos/matanshukry/sails-orientdb/forks","keys_url":"https://api.github.com/repos/matanshukry/sails-orientdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matanshukry/sails-orientdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matanshukry/sails-orientdb/teams","hooks_url":"https://api.github.com/repos/matanshukry/sails-orientdb/hooks","issue_events_url":"https://api.github.com/repos/matanshukry/sails-orientdb/issues/events{/number}","events_url":"https://api.github.com/repos/matanshukry/sails-orientdb/events","assignees_url":"https://api.github.com/repos/matanshukry/sails-orientdb/assignees{/user}","branches_url":"https://api.github.com/repos/matanshukry/sails-orientdb/branches{/branch}","tags_url":"https://api.github.com/repos/matanshukry/sails-orientdb/tags","blobs_url":"https://api.github.com/repos/matanshukry/sails-orientdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matanshukry/sails-orientdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matanshukry/sails-orientdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/matanshukry/sails-orientdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matanshukry/sails-orientdb/statuses/{sha}","languages_url":"https://api.github.com/repos/matanshukry/sails-orientdb/languages","stargazers_url":"https://api.github.com/repos/matanshukry/sails-orientdb/stargazers","contributors_url":"https://api.github.com/repos/matanshukry/sails-orientdb/contributors","subscribers_url":"https://api.github.com/repos/matanshukry/sails-orientdb/subscribers","subscription_url":"https://api.github.com/repos/matanshukry/sails-orientdb/subscription","commits_url":"https://api.github.com/repos/matanshukry/sails-orientdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/matanshukry/sails-orientdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/matanshukry/sails-orientdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/matanshukry/sails-orientdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/matanshukry/sails-orientdb/contents/{+path}","compare_url":"https://api.github.com/repos/matanshukry/sails-orientdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matanshukry/sails-orientdb/merges","archive_url":"https://api.github.com/repos/matanshukry/sails-orientdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matanshukry/sails-orientdb/downloads","issues_url":"https://api.github.com/repos/matanshukry/sails-orientdb/issues{/number}","pulls_url":"https://api.github.com/repos/matanshukry/sails-orientdb/pulls{/number}","milestones_url":"https://api.github.com/repos/matanshukry/sails-orientdb/milestones{/number}","notifications_url":"https://api.github.com/repos/matanshukry/sails-orientdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matanshukry/sails-orientdb/labels{/name}","releases_url":"https://api.github.com/repos/matanshukry/sails-orientdb/releases{/id}","created_at":"2015-04-23T17:59:01Z","updated_at":"2015-05-01T16:39:54Z","pushed_at":"2015-05-01T16:39:54Z","git_url":"git://github.com/matanshukry/sails-orientdb.git","ssh_url":"git@github.com:matanshukry/sails-orientdb.git","clone_url":"https://github.com/matanshukry/sails-orientdb.git","svn_url":"https://github.com/matanshukry/sails-orientdb","homepage":"","size":581,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appscot:master","ref":"master","sha":"000a036b860ea48705614e6d0d9f5121e8031695","user":{"login":"appscot","id":6073769,"avatar_url":"https://avatars.githubusercontent.com/u/6073769?v=3","gravatar_id":"","url":"https://api.github.com/users/appscot","html_url":"https://github.com/appscot","followers_url":"https://api.github.com/users/appscot/followers","following_url":"https://api.github.com/users/appscot/following{/other_user}","gists_url":"https://api.github.com/users/appscot/gists{/gist_id}","starred_url":"https://api.github.com/users/appscot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appscot/subscriptions","organizations_url":"https://api.github.com/users/appscot/orgs","repos_url":"https://api.github.com/users/appscot/repos","events_url":"https://api.github.com/users/appscot/events{/privacy}","received_events_url":"https://api.github.com/users/appscot/received_events","type":"Organization","site_admin":false},"repo":{"id":26050796,"name":"sails-orientdb","full_name":"appscot/sails-orientdb","owner":{"login":"appscot","id":6073769,"avatar_url":"https://avatars.githubusercontent.com/u/6073769?v=3","gravatar_id":"","url":"https://api.github.com/users/appscot","html_url":"https://github.com/appscot","followers_url":"https://api.github.com/users/appscot/followers","following_url":"https://api.github.com/users/appscot/following{/other_user}","gists_url":"https://api.github.com/users/appscot/gists{/gist_id}","starred_url":"https://api.github.com/users/appscot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appscot/subscriptions","organizations_url":"https://api.github.com/users/appscot/orgs","repos_url":"https://api.github.com/users/appscot/repos","events_url":"https://api.github.com/users/appscot/events{/privacy}","received_events_url":"https://api.github.com/users/appscot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appscot/sails-orientdb","description":"OrientDB adapter for Waterline / Sails.js ORM","fork":false,"url":"https://api.github.com/repos/appscot/sails-orientdb","forks_url":"https://api.github.com/repos/appscot/sails-orientdb/forks","keys_url":"https://api.github.com/repos/appscot/sails-orientdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appscot/sails-orientdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appscot/sails-orientdb/teams","hooks_url":"https://api.github.com/repos/appscot/sails-orientdb/hooks","issue_events_url":"https://api.github.com/repos/appscot/sails-orientdb/issues/events{/number}","events_url":"https://api.github.com/repos/appscot/sails-orientdb/events","assignees_url":"https://api.github.com/repos/appscot/sails-orientdb/assignees{/user}","branches_url":"https://api.github.com/repos/appscot/sails-orientdb/branches{/branch}","tags_url":"https://api.github.com/repos/appscot/sails-orientdb/tags","blobs_url":"https://api.github.com/repos/appscot/sails-orientdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appscot/sails-orientdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appscot/sails-orientdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/appscot/sails-orientdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appscot/sails-orientdb/statuses/{sha}","languages_url":"https://api.github.com/repos/appscot/sails-orientdb/languages","stargazers_url":"https://api.github.com/repos/appscot/sails-orientdb/stargazers","contributors_url":"https://api.github.com/repos/appscot/sails-orientdb/contributors","subscribers_url":"https://api.github.com/repos/appscot/sails-orientdb/subscribers","subscription_url":"https://api.github.com/repos/appscot/sails-orientdb/subscription","commits_url":"https://api.github.com/repos/appscot/sails-orientdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/appscot/sails-orientdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/appscot/sails-orientdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/appscot/sails-orientdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/appscot/sails-orientdb/contents/{+path}","compare_url":"https://api.github.com/repos/appscot/sails-orientdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appscot/sails-orientdb/merges","archive_url":"https://api.github.com/repos/appscot/sails-orientdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appscot/sails-orientdb/downloads","issues_url":"https://api.github.com/repos/appscot/sails-orientdb/issues{/number}","pulls_url":"https://api.github.com/repos/appscot/sails-orientdb/pulls{/number}","milestones_url":"https://api.github.com/repos/appscot/sails-orientdb/milestones{/number}","notifications_url":"https://api.github.com/repos/appscot/sails-orientdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appscot/sails-orientdb/labels{/name}","releases_url":"https://api.github.com/repos/appscot/sails-orientdb/releases{/id}","created_at":"2014-11-01T13:03:15Z","updated_at":"2015-05-08T10:16:19Z","pushed_at":"2015-05-08T10:24:10Z","git_url":"git://github.com/appscot/sails-orientdb.git","ssh_url":"git@github.com:appscot/sails-orientdb.git","clone_url":"https://github.com/appscot/sails-orientdb.git","svn_url":"https://github.com/appscot/sails-orientdb","homepage":"","size":2287,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":12,"forks":7,"open_issues":12,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appscot/sails-orientdb/pulls/86"},"html":{"href":"https://github.com/appscot/sails-orientdb/pull/86"},"issue":{"href":"https://api.github.com/repos/appscot/sails-orientdb/issues/86"},"comments":{"href":"https://api.github.com/repos/appscot/sails-orientdb/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/appscot/sails-orientdb/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/appscot/sails-orientdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appscot/sails-orientdb/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/appscot/sails-orientdb/statuses/b736ba3e7625a8edd4bd9d282c32f68c35f1619d"}}}}