{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/pulls/12","id":43671719,"html_url":"https://github.com/labyrinthofdreams/icm-enhanced/pull/12","diff_url":"https://github.com/labyrinthofdreams/icm-enhanced/pull/12.diff","patch_url":"https://github.com/labyrinthofdreams/icm-enhanced/pull/12.patch","issue_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/issues/12","number":12,"state":"closed","locked":false,"title":"More accurate page matching & small fixes","user":{"login":"monk-time","id":7759622,"avatar_url":"https://avatars.githubusercontent.com/u/7759622?v=3","gravatar_id":"","url":"https://api.github.com/users/monk-time","html_url":"https://github.com/monk-time","followers_url":"https://api.github.com/users/monk-time/followers","following_url":"https://api.github.com/users/monk-time/following{/other_user}","gists_url":"https://api.github.com/users/monk-time/gists{/gist_id}","starred_url":"https://api.github.com/users/monk-time/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monk-time/subscriptions","organizations_url":"https://api.github.com/users/monk-time/orgs","repos_url":"https://api.github.com/users/monk-time/repos","events_url":"https://api.github.com/users/monk-time/events{/privacy}","received_events_url":"https://api.github.com/users/monk-time/received_events","type":"User","site_admin":false},"body":"Hi!\r\n\r\nAnother batch of fixes and refactorings. The main one is that modules no longer have to include regexes for page matching in their settings, only keys for an object of narrow mutually exclusive regexes for different page types. You can still use the old system of specifying extra regexes in `includes` and `excludes` arrays if you need to fine-tune, but most cases should be covered by new page types.\r\n\r\nAs a result, many modules now work only on pages they are supposed to work. Also the code for checking module state is no longer duplicated in every module.\r\n\r\nSince I wanted to split HideTags between movies and lists, I added a way to place options inline (`frontDesc` and `inline` keys of option-objects in module settings). And the code for a row of the script's stats and links is extracted into an utility function.\r\n\r\nTested in FF+GM and Chrome+TM.\r\n\r\nOther fixes:\r\n10dabf0e56a8dd7db79b5f00158b2743ad3a9de2 - Random film link, Large posters, Export lists: now work on a watchlist/favs/checked movies/etc. (but exporting downloads only a single page)\r\nb4f20e66b69c8eb643882577e73b381da2274917 - Random film link: disable on completed lists, allow returning to a full list when using on a watchlist/favs/etc.\r\nf30d6a26b799800dba10cbc1897491960000647a - Hide tags: separate options for hiding tags of movies and lists; hide tags also on /movies/\\<movie-name\\>/rankings/\r\ndcf6e09b7520149bd87bfaab5c9406990e1f5603 - Hide tags: don't show tags when hovering in compact mode\r\n13381cbe0a6ef16d76e45bb2441039e06cc158d2 - Lists tab display: links on /movies/checked/ didn't redirect properly\r\n","created_at":"2015-08-28T21:01:43Z","updated_at":"2015-08-29T09:21:20Z","closed_at":"2015-08-29T09:21:20Z","merged_at":"2015-08-29T09:21:19Z","merge_commit_sha":"d6bb40a5842f973b01a0d5405aecba8d0a453733","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/pulls/12/commits","review_comments_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/pulls/12/comments","review_comment_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/pulls/comments{/number}","comments_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/issues/12/comments","statuses_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/statuses/3d9fc2c68c7fe772e8a94fd460dada327417cac4","head":{"label":"monk-time:small-fixes","ref":"small-fixes","sha":"3d9fc2c68c7fe772e8a94fd460dada327417cac4","user":{"login":"monk-time","id":7759622,"avatar_url":"https://avatars.githubusercontent.com/u/7759622?v=3","gravatar_id":"","url":"https://api.github.com/users/monk-time","html_url":"https://github.com/monk-time","followers_url":"https://api.github.com/users/monk-time/followers","following_url":"https://api.github.com/users/monk-time/following{/other_user}","gists_url":"https://api.github.com/users/monk-time/gists{/gist_id}","starred_url":"https://api.github.com/users/monk-time/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monk-time/subscriptions","organizations_url":"https://api.github.com/users/monk-time/orgs","repos_url":"https://api.github.com/users/monk-time/repos","events_url":"https://api.github.com/users/monk-time/events{/privacy}","received_events_url":"https://api.github.com/users/monk-time/received_events","type":"User","site_admin":false},"repo":{"id":21785608,"name":"icm-enhanced","full_name":"monk-time/icm-enhanced","owner":{"login":"monk-time","id":7759622,"avatar_url":"https://avatars.githubusercontent.com/u/7759622?v=3","gravatar_id":"","url":"https://api.github.com/users/monk-time","html_url":"https://github.com/monk-time","followers_url":"https://api.github.com/users/monk-time/followers","following_url":"https://api.github.com/users/monk-time/following{/other_user}","gists_url":"https://api.github.com/users/monk-time/gists{/gist_id}","starred_url":"https://api.github.com/users/monk-time/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monk-time/subscriptions","organizations_url":"https://api.github.com/users/monk-time/orgs","repos_url":"https://api.github.com/users/monk-time/repos","events_url":"https://api.github.com/users/monk-time/events{/privacy}","received_events_url":"https://api.github.com/users/monk-time/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/monk-time/icm-enhanced","description":"Add functionality to iCheckMovies","fork":true,"url":"https://api.github.com/repos/monk-time/icm-enhanced","forks_url":"https://api.github.com/repos/monk-time/icm-enhanced/forks","keys_url":"https://api.github.com/repos/monk-time/icm-enhanced/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monk-time/icm-enhanced/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monk-time/icm-enhanced/teams","hooks_url":"https://api.github.com/repos/monk-time/icm-enhanced/hooks","issue_events_url":"https://api.github.com/repos/monk-time/icm-enhanced/issues/events{/number}","events_url":"https://api.github.com/repos/monk-time/icm-enhanced/events","assignees_url":"https://api.github.com/repos/monk-time/icm-enhanced/assignees{/user}","branches_url":"https://api.github.com/repos/monk-time/icm-enhanced/branches{/branch}","tags_url":"https://api.github.com/repos/monk-time/icm-enhanced/tags","blobs_url":"https://api.github.com/repos/monk-time/icm-enhanced/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monk-time/icm-enhanced/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monk-time/icm-enhanced/git/refs{/sha}","trees_url":"https://api.github.com/repos/monk-time/icm-enhanced/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monk-time/icm-enhanced/statuses/{sha}","languages_url":"https://api.github.com/repos/monk-time/icm-enhanced/languages","stargazers_url":"https://api.github.com/repos/monk-time/icm-enhanced/stargazers","contributors_url":"https://api.github.com/repos/monk-time/icm-enhanced/contributors","subscribers_url":"https://api.github.com/repos/monk-time/icm-enhanced/subscribers","subscription_url":"https://api.github.com/repos/monk-time/icm-enhanced/subscription","commits_url":"https://api.github.com/repos/monk-time/icm-enhanced/commits{/sha}","git_commits_url":"https://api.github.com/repos/monk-time/icm-enhanced/git/commits{/sha}","comments_url":"https://api.github.com/repos/monk-time/icm-enhanced/comments{/number}","issue_comment_url":"https://api.github.com/repos/monk-time/icm-enhanced/issues/comments{/number}","contents_url":"https://api.github.com/repos/monk-time/icm-enhanced/contents/{+path}","compare_url":"https://api.github.com/repos/monk-time/icm-enhanced/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monk-time/icm-enhanced/merges","archive_url":"https://api.github.com/repos/monk-time/icm-enhanced/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monk-time/icm-enhanced/downloads","issues_url":"https://api.github.com/repos/monk-time/icm-enhanced/issues{/number}","pulls_url":"https://api.github.com/repos/monk-time/icm-enhanced/pulls{/number}","milestones_url":"https://api.github.com/repos/monk-time/icm-enhanced/milestones{/number}","notifications_url":"https://api.github.com/repos/monk-time/icm-enhanced/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monk-time/icm-enhanced/labels{/name}","releases_url":"https://api.github.com/repos/monk-time/icm-enhanced/releases{/id}","created_at":"2014-07-13T07:53:31Z","updated_at":"2015-02-18T18:37:44Z","pushed_at":"2015-08-28T21:39:40Z","git_url":"git://github.com/monk-time/icm-enhanced.git","ssh_url":"git@github.com:monk-time/icm-enhanced.git","clone_url":"https://github.com/monk-time/icm-enhanced.git","svn_url":"https://github.com/monk-time/icm-enhanced","homepage":null,"size":446,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"labyrinthofdreams:master","ref":"master","sha":"f65a2424e631519c89060461aed217562db81981","user":{"login":"labyrinthofdreams","id":1516621,"avatar_url":"https://avatars.githubusercontent.com/u/1516621?v=3","gravatar_id":"","url":"https://api.github.com/users/labyrinthofdreams","html_url":"https://github.com/labyrinthofdreams","followers_url":"https://api.github.com/users/labyrinthofdreams/followers","following_url":"https://api.github.com/users/labyrinthofdreams/following{/other_user}","gists_url":"https://api.github.com/users/labyrinthofdreams/gists{/gist_id}","starred_url":"https://api.github.com/users/labyrinthofdreams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labyrinthofdreams/subscriptions","organizations_url":"https://api.github.com/users/labyrinthofdreams/orgs","repos_url":"https://api.github.com/users/labyrinthofdreams/repos","events_url":"https://api.github.com/users/labyrinthofdreams/events{/privacy}","received_events_url":"https://api.github.com/users/labyrinthofdreams/received_events","type":"User","site_admin":false},"repo":{"id":16462610,"name":"icm-enhanced","full_name":"labyrinthofdreams/icm-enhanced","owner":{"login":"labyrinthofdreams","id":1516621,"avatar_url":"https://avatars.githubusercontent.com/u/1516621?v=3","gravatar_id":"","url":"https://api.github.com/users/labyrinthofdreams","html_url":"https://github.com/labyrinthofdreams","followers_url":"https://api.github.com/users/labyrinthofdreams/followers","following_url":"https://api.github.com/users/labyrinthofdreams/following{/other_user}","gists_url":"https://api.github.com/users/labyrinthofdreams/gists{/gist_id}","starred_url":"https://api.github.com/users/labyrinthofdreams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labyrinthofdreams/subscriptions","organizations_url":"https://api.github.com/users/labyrinthofdreams/orgs","repos_url":"https://api.github.com/users/labyrinthofdreams/repos","events_url":"https://api.github.com/users/labyrinthofdreams/events{/privacy}","received_events_url":"https://api.github.com/users/labyrinthofdreams/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/labyrinthofdreams/icm-enhanced","description":"Add functionality to iCheckMovies","fork":false,"url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced","forks_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/forks","keys_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/keys{/key_id}","collaborators_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/teams","hooks_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/hooks","issue_events_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/issues/events{/number}","events_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/events","assignees_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/assignees{/user}","branches_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/branches{/branch}","tags_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/tags","blobs_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/git/refs{/sha}","trees_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/git/trees{/sha}","statuses_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/statuses/{sha}","languages_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/languages","stargazers_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/stargazers","contributors_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/contributors","subscribers_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/subscribers","subscription_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/subscription","commits_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/commits{/sha}","git_commits_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/git/commits{/sha}","comments_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/comments{/number}","issue_comment_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/issues/comments{/number}","contents_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/contents/{+path}","compare_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/compare/{base}...{head}","merges_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/merges","archive_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/downloads","issues_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/issues{/number}","pulls_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/pulls{/number}","milestones_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/milestones{/number}","notifications_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/labels{/name}","releases_url":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/releases{/id}","created_at":"2014-02-02T20:37:20Z","updated_at":"2015-02-18T18:25:25Z","pushed_at":"2015-08-29T09:21:20Z","git_url":"git://github.com/labyrinthofdreams/icm-enhanced.git","ssh_url":"git@github.com:labyrinthofdreams/icm-enhanced.git","clone_url":"https://github.com/labyrinthofdreams/icm-enhanced.git","svn_url":"https://github.com/labyrinthofdreams/icm-enhanced","homepage":null,"size":546,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/pulls/12"},"html":{"href":"https://github.com/labyrinthofdreams/icm-enhanced/pull/12"},"issue":{"href":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/issues/12"},"comments":{"href":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/labyrinthofdreams/icm-enhanced/statuses/3d9fc2c68c7fe772e8a94fd460dada327417cac4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"labyrinthofdreams","id":1516621,"avatar_url":"https://avatars.githubusercontent.com/u/1516621?v=3","gravatar_id":"","url":"https://api.github.com/users/labyrinthofdreams","html_url":"https://github.com/labyrinthofdreams","followers_url":"https://api.github.com/users/labyrinthofdreams/followers","following_url":"https://api.github.com/users/labyrinthofdreams/following{/other_user}","gists_url":"https://api.github.com/users/labyrinthofdreams/gists{/gist_id}","starred_url":"https://api.github.com/users/labyrinthofdreams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labyrinthofdreams/subscriptions","organizations_url":"https://api.github.com/users/labyrinthofdreams/orgs","repos_url":"https://api.github.com/users/labyrinthofdreams/repos","events_url":"https://api.github.com/users/labyrinthofdreams/events{/privacy}","received_events_url":"https://api.github.com/users/labyrinthofdreams/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":13,"additions":250,"deletions":272,"changed_files":3}}