{"action":"closed","number":320,"pull_request":{"url":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/320","id":42117209,"html_url":"https://github.com/jmxtrans/jmxtrans/pull/320","diff_url":"https://github.com/jmxtrans/jmxtrans/pull/320.diff","patch_url":"https://github.com/jmxtrans/jmxtrans/pull/320.patch","issue_url":"https://api.github.com/repos/jmxtrans/jmxtrans/issues/320","number":320,"state":"closed","locked":false,"title":"Changing jmxtrans user home dir in deb packages","user":{"login":"sogorkis","id":1992051,"avatar_url":"https://avatars.githubusercontent.com/u/1992051?v=3","gravatar_id":"","url":"https://api.github.com/users/sogorkis","html_url":"https://github.com/sogorkis","followers_url":"https://api.github.com/users/sogorkis/followers","following_url":"https://api.github.com/users/sogorkis/following{/other_user}","gists_url":"https://api.github.com/users/sogorkis/gists{/gist_id}","starred_url":"https://api.github.com/users/sogorkis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sogorkis/subscriptions","organizations_url":"https://api.github.com/users/sogorkis/orgs","repos_url":"https://api.github.com/users/sogorkis/repos","events_url":"https://api.github.com/users/sogorkis/events{/privacy}","received_events_url":"https://api.github.com/users/sogorkis/received_events","type":"User","site_admin":false},"body":"Installing rpm in SLES failed as -U flag of useradd is not supported\r\non this system. This commit fixes this issue by manually creating\r\njmxtrans group first and then using -G flag in useradd command.\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/jmxtrans/jmxtrans/pull/320%23discussion_r36734156%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/320%23issuecomment-129844681%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/320%23issuecomment-129844681%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Added%20%60-f%60%20option%20to%20%60groupadd%60%20command.%22%2C%20%22created_at%22%3A%20%222015-08-11T11%3A28%3A59Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1992051%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/sogorkis%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%2C%20%22Pull%20edd6daacd6997011ecaf3a4827974f9ab318065b%20jmxtrans/pom.xml%204%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/320%23discussion_r36734156%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Should%20you%20add%20a%20check%20to%20only%20create%20the%20group%20if%20it%20already%20exists%3F%20Or%20use%20the%20%60-f%60%20option%3F%22%2C%20%22created_at%22%3A%20%222015-08-11T11%3A19%3A11Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1415765%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/gehel%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20jmxtrans/pom.xml%3AL316-325%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-Pull edd6daacd6997011ecaf3a4827974f9ab318065b jmxtrans/pom.xml 4'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/jmxtrans/jmxtrans/pull/320#discussion_r36734156'>File: jmxtrans/pom.xml:L316-325</a></b>\n- <a href='https://github.com/gehel'><img border=0 src='https://avatars.githubusercontent.com/u/1415765?v=3' height=16 width=16'></a> Should you add a check to only create the group if it already exists? Or use the `-f` option?\n- [ ] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/jmxtrans/jmxtrans/pull/320#issuecomment-129844681'>General Comment</a></b>\n- <a href='https://github.com/sogorkis'><img border=0 src='https://avatars.githubusercontent.com/u/1992051?v=3' height=16 width=16'></a> Added `-f` option to `groupadd` command.\n\n\n<a href='https://www.codereviewhub.com/jmxtrans/jmxtrans/pull/320?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/jmxtrans/jmxtrans/pull/320?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/jmxtrans/jmxtrans/pull/320'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2015-08-11T11:09:58Z","updated_at":"2015-08-11T11:29:50Z","closed_at":"2015-08-11T11:29:49Z","merged_at":"2015-08-11T11:29:49Z","merge_commit_sha":"44700633b24ad576907fee0f8afc1b213c963cb7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/320/commits","review_comments_url":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/320/comments","review_comment_url":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmxtrans/jmxtrans/issues/320/comments","statuses_url":"https://api.github.com/repos/jmxtrans/jmxtrans/statuses/c790fd4ea2c86fb9253989678e5ed7b7b3412d8c","head":{"label":"sogorkis:slesRpmFix","ref":"slesRpmFix","sha":"c790fd4ea2c86fb9253989678e5ed7b7b3412d8c","user":{"login":"sogorkis","id":1992051,"avatar_url":"https://avatars.githubusercontent.com/u/1992051?v=3","gravatar_id":"","url":"https://api.github.com/users/sogorkis","html_url":"https://github.com/sogorkis","followers_url":"https://api.github.com/users/sogorkis/followers","following_url":"https://api.github.com/users/sogorkis/following{/other_user}","gists_url":"https://api.github.com/users/sogorkis/gists{/gist_id}","starred_url":"https://api.github.com/users/sogorkis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sogorkis/subscriptions","organizations_url":"https://api.github.com/users/sogorkis/orgs","repos_url":"https://api.github.com/users/sogorkis/repos","events_url":"https://api.github.com/users/sogorkis/events{/privacy}","received_events_url":"https://api.github.com/users/sogorkis/received_events","type":"User","site_admin":false},"repo":{"id":40533596,"name":"jmxtrans","full_name":"sogorkis/jmxtrans","owner":{"login":"sogorkis","id":1992051,"avatar_url":"https://avatars.githubusercontent.com/u/1992051?v=3","gravatar_id":"","url":"https://api.github.com/users/sogorkis","html_url":"https://github.com/sogorkis","followers_url":"https://api.github.com/users/sogorkis/followers","following_url":"https://api.github.com/users/sogorkis/following{/other_user}","gists_url":"https://api.github.com/users/sogorkis/gists{/gist_id}","starred_url":"https://api.github.com/users/sogorkis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sogorkis/subscriptions","organizations_url":"https://api.github.com/users/sogorkis/orgs","repos_url":"https://api.github.com/users/sogorkis/repos","events_url":"https://api.github.com/users/sogorkis/events{/privacy}","received_events_url":"https://api.github.com/users/sogorkis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sogorkis/jmxtrans","description":"jmxtrans","fork":true,"url":"https://api.github.com/repos/sogorkis/jmxtrans","forks_url":"https://api.github.com/repos/sogorkis/jmxtrans/forks","keys_url":"https://api.github.com/repos/sogorkis/jmxtrans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sogorkis/jmxtrans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sogorkis/jmxtrans/teams","hooks_url":"https://api.github.com/repos/sogorkis/jmxtrans/hooks","issue_events_url":"https://api.github.com/repos/sogorkis/jmxtrans/issues/events{/number}","events_url":"https://api.github.com/repos/sogorkis/jmxtrans/events","assignees_url":"https://api.github.com/repos/sogorkis/jmxtrans/assignees{/user}","branches_url":"https://api.github.com/repos/sogorkis/jmxtrans/branches{/branch}","tags_url":"https://api.github.com/repos/sogorkis/jmxtrans/tags","blobs_url":"https://api.github.com/repos/sogorkis/jmxtrans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sogorkis/jmxtrans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sogorkis/jmxtrans/git/refs{/sha}","trees_url":"https://api.github.com/repos/sogorkis/jmxtrans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sogorkis/jmxtrans/statuses/{sha}","languages_url":"https://api.github.com/repos/sogorkis/jmxtrans/languages","stargazers_url":"https://api.github.com/repos/sogorkis/jmxtrans/stargazers","contributors_url":"https://api.github.com/repos/sogorkis/jmxtrans/contributors","subscribers_url":"https://api.github.com/repos/sogorkis/jmxtrans/subscribers","subscription_url":"https://api.github.com/repos/sogorkis/jmxtrans/subscription","commits_url":"https://api.github.com/repos/sogorkis/jmxtrans/commits{/sha}","git_commits_url":"https://api.github.com/repos/sogorkis/jmxtrans/git/commits{/sha}","comments_url":"https://api.github.com/repos/sogorkis/jmxtrans/comments{/number}","issue_comment_url":"https://api.github.com/repos/sogorkis/jmxtrans/issues/comments{/number}","contents_url":"https://api.github.com/repos/sogorkis/jmxtrans/contents/{+path}","compare_url":"https://api.github.com/repos/sogorkis/jmxtrans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sogorkis/jmxtrans/merges","archive_url":"https://api.github.com/repos/sogorkis/jmxtrans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sogorkis/jmxtrans/downloads","issues_url":"https://api.github.com/repos/sogorkis/jmxtrans/issues{/number}","pulls_url":"https://api.github.com/repos/sogorkis/jmxtrans/pulls{/number}","milestones_url":"https://api.github.com/repos/sogorkis/jmxtrans/milestones{/number}","notifications_url":"https://api.github.com/repos/sogorkis/jmxtrans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sogorkis/jmxtrans/labels{/name}","releases_url":"https://api.github.com/repos/sogorkis/jmxtrans/releases{/id}","created_at":"2015-08-11T09:33:56Z","updated_at":"2015-08-11T09:33:57Z","pushed_at":"2015-08-11T11:28:00Z","git_url":"git://github.com/sogorkis/jmxtrans.git","ssh_url":"git@github.com:sogorkis/jmxtrans.git","clone_url":"https://github.com/sogorkis/jmxtrans.git","svn_url":"https://github.com/sogorkis/jmxtrans","homepage":"","size":34929,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmxtrans:master","ref":"master","sha":"8ed0a72f7df20831dd580cfbcfa869e0a7133d9c","user":{"login":"jmxtrans","id":3198433,"avatar_url":"https://avatars.githubusercontent.com/u/3198433?v=3","gravatar_id":"","url":"https://api.github.com/users/jmxtrans","html_url":"https://github.com/jmxtrans","followers_url":"https://api.github.com/users/jmxtrans/followers","following_url":"https://api.github.com/users/jmxtrans/following{/other_user}","gists_url":"https://api.github.com/users/jmxtrans/gists{/gist_id}","starred_url":"https://api.github.com/users/jmxtrans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmxtrans/subscriptions","organizations_url":"https://api.github.com/users/jmxtrans/orgs","repos_url":"https://api.github.com/users/jmxtrans/repos","events_url":"https://api.github.com/users/jmxtrans/events{/privacy}","received_events_url":"https://api.github.com/users/jmxtrans/received_events","type":"Organization","site_admin":false},"repo":{"id":2934254,"name":"jmxtrans","full_name":"jmxtrans/jmxtrans","owner":{"login":"jmxtrans","id":3198433,"avatar_url":"https://avatars.githubusercontent.com/u/3198433?v=3","gravatar_id":"","url":"https://api.github.com/users/jmxtrans","html_url":"https://github.com/jmxtrans","followers_url":"https://api.github.com/users/jmxtrans/followers","following_url":"https://api.github.com/users/jmxtrans/following{/other_user}","gists_url":"https://api.github.com/users/jmxtrans/gists{/gist_id}","starred_url":"https://api.github.com/users/jmxtrans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmxtrans/subscriptions","organizations_url":"https://api.github.com/users/jmxtrans/orgs","repos_url":"https://api.github.com/users/jmxtrans/repos","events_url":"https://api.github.com/users/jmxtrans/events{/privacy}","received_events_url":"https://api.github.com/users/jmxtrans/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jmxtrans/jmxtrans","description":"jmxtrans","fork":false,"url":"https://api.github.com/repos/jmxtrans/jmxtrans","forks_url":"https://api.github.com/repos/jmxtrans/jmxtrans/forks","keys_url":"https://api.github.com/repos/jmxtrans/jmxtrans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmxtrans/jmxtrans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmxtrans/jmxtrans/teams","hooks_url":"https://api.github.com/repos/jmxtrans/jmxtrans/hooks","issue_events_url":"https://api.github.com/repos/jmxtrans/jmxtrans/issues/events{/number}","events_url":"https://api.github.com/repos/jmxtrans/jmxtrans/events","assignees_url":"https://api.github.com/repos/jmxtrans/jmxtrans/assignees{/user}","branches_url":"https://api.github.com/repos/jmxtrans/jmxtrans/branches{/branch}","tags_url":"https://api.github.com/repos/jmxtrans/jmxtrans/tags","blobs_url":"https://api.github.com/repos/jmxtrans/jmxtrans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmxtrans/jmxtrans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmxtrans/jmxtrans/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmxtrans/jmxtrans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmxtrans/jmxtrans/statuses/{sha}","languages_url":"https://api.github.com/repos/jmxtrans/jmxtrans/languages","stargazers_url":"https://api.github.com/repos/jmxtrans/jmxtrans/stargazers","contributors_url":"https://api.github.com/repos/jmxtrans/jmxtrans/contributors","subscribers_url":"https://api.github.com/repos/jmxtrans/jmxtrans/subscribers","subscription_url":"https://api.github.com/repos/jmxtrans/jmxtrans/subscription","commits_url":"https://api.github.com/repos/jmxtrans/jmxtrans/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmxtrans/jmxtrans/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmxtrans/jmxtrans/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmxtrans/jmxtrans/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmxtrans/jmxtrans/contents/{+path}","compare_url":"https://api.github.com/repos/jmxtrans/jmxtrans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmxtrans/jmxtrans/merges","archive_url":"https://api.github.com/repos/jmxtrans/jmxtrans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmxtrans/jmxtrans/downloads","issues_url":"https://api.github.com/repos/jmxtrans/jmxtrans/issues{/number}","pulls_url":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls{/number}","milestones_url":"https://api.github.com/repos/jmxtrans/jmxtrans/milestones{/number}","notifications_url":"https://api.github.com/repos/jmxtrans/jmxtrans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmxtrans/jmxtrans/labels{/name}","releases_url":"https://api.github.com/repos/jmxtrans/jmxtrans/releases{/id}","created_at":"2011-12-07T17:24:36Z","updated_at":"2015-08-11T06:12:49Z","pushed_at":"2015-08-11T11:29:49Z","git_url":"git://github.com/jmxtrans/jmxtrans.git","ssh_url":"git@github.com:jmxtrans/jmxtrans.git","clone_url":"https://github.com/jmxtrans/jmxtrans.git","svn_url":"https://github.com/jmxtrans/jmxtrans","homepage":"","size":34929,"stargazers_count":725,"watchers_count":725,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":241,"mirror_url":null,"open_issues_count":18,"forks":241,"open_issues":18,"watchers":725,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/320"},"html":{"href":"https://github.com/jmxtrans/jmxtrans/pull/320"},"issue":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/issues/320"},"comments":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/issues/320/comments"},"review_comments":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/320/comments"},"review_comment":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/320/commits"},"statuses":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/statuses/c790fd4ea2c86fb9253989678e5ed7b7b3412d8c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gehel","id":1415765,"avatar_url":"https://avatars.githubusercontent.com/u/1415765?v=3","gravatar_id":"","url":"https://api.github.com/users/gehel","html_url":"https://github.com/gehel","followers_url":"https://api.github.com/users/gehel/followers","following_url":"https://api.github.com/users/gehel/following{/other_user}","gists_url":"https://api.github.com/users/gehel/gists{/gist_id}","starred_url":"https://api.github.com/users/gehel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gehel/subscriptions","organizations_url":"https://api.github.com/users/gehel/orgs","repos_url":"https://api.github.com/users/gehel/repos","events_url":"https://api.github.com/users/gehel/events{/privacy}","received_events_url":"https://api.github.com/users/gehel/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"commits":1,"additions":2,"deletions":1,"changed_files":1}}