{"action":"created","issue":{"url":"https://api.github.com/repos/damirn/rapidx2j/issues/1","labels_url":"https://api.github.com/repos/damirn/rapidx2j/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/damirn/rapidx2j/issues/1/comments","events_url":"https://api.github.com/repos/damirn/rapidx2j/issues/1/events","html_url":"https://github.com/damirn/rapidx2j/issues/1","id":103273601,"number":1,"title":"Fails to build on Ubuntu.","user":{"login":"Redsandro","id":1702193,"avatar_url":"https://avatars.githubusercontent.com/u/1702193?v=3","gravatar_id":"","url":"https://api.github.com/users/Redsandro","html_url":"https://github.com/Redsandro","followers_url":"https://api.github.com/users/Redsandro/followers","following_url":"https://api.github.com/users/Redsandro/following{/other_user}","gists_url":"https://api.github.com/users/Redsandro/gists{/gist_id}","starred_url":"https://api.github.com/users/Redsandro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Redsandro/subscriptions","organizations_url":"https://api.github.com/users/Redsandro/orgs","repos_url":"https://api.github.com/users/Redsandro/repos","events_url":"https://api.github.com/users/Redsandro/events{/privacy}","received_events_url":"https://api.github.com/users/Redsandro/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-08-26T13:46:01Z","updated_at":"2015-08-28T14:34:59Z","closed_at":"2015-08-28T12:42:42Z","body":"I was curious to see if this would outperform xml-expat. But there are build problems:\r\n\r\n```\r\n$ npm install rapidx2j\r\nnpm http GET https://registry.npmjs.org/rapidx2j\r\nnpm http 200 https://registry.npmjs.org/rapidx2j\r\nnpm http GET https://registry.npmjs.org/rapidx2j/-/rapidx2j-0.0.7.tgz\r\nnpm http 200 https://registry.npmjs.org/rapidx2j/-/rapidx2j-0.0.7.tgz\r\nnpm http GET https://registry.npmjs.org/nan\r\nnpm http 200 https://registry.npmjs.org/nan\r\nnpm http GET https://registry.npmjs.org/nan/-/nan-2.0.7.tgz\r\nnpm http 200 https://registry.npmjs.org/nan/-/nan-2.0.7.tgz\r\n\r\n> rapidx2j@0.0.7 install /var/tests/xml2js/node_modules/rapidx2j\r\n> node-gyp rebuild\r\n\r\nmake: Entering directory `/var/tests/xml2js/node_modules/rapidx2j/build'\r\n  CXX(target) Release/obj.target/rapidx2j/src/rapidx2j.o\r\n../src/rapidx2j.cc: In function ‘void InitAll(v8::Handle<v8::Object>)’:\r\n../src/rapidx2j.cc:5:16: error: ‘NanNew’ was not declared in this scope\r\n   exports->Set(NanNew<v8::String>(\"parse\"), NanNew<v8::FunctionTemplate>(parse)->GetFunction());\r\n                ^\r\n../src/rapidx2j.cc:5:33: error: expected primary-expression before ‘>’ token\r\n   exports->Set(NanNew<v8::String>(\"parse\"), NanNew<v8::FunctionTemplate>(parse)->GetFunction());\r\n                                 ^\r\n../src/rapidx2j.cc:5:72: error: expected primary-expression before ‘>’ token\r\n   exports->Set(NanNew<v8::String>(\"parse\"), NanNew<v8::FunctionTemplate>(parse)->GetFunction());\r\n                                                                        ^\r\n../src/rapidx2j.cc:5:82: error: request for member ‘GetFunction’ in ‘parse’, which is of non-class type ‘Nan::NAN_METHOD_RETURN_TYPE(Nan::NAN_METHOD_ARGS_TYPE) {aka void(const Nan::FunctionCallbackInfo<v8::Value>&)}’\r\n   exports->Set(NanNew<v8::String>(\"parse\"), NanNew<v8::FunctionTemplate>(parse)->GetFunction());\r\n                                                                                  ^\r\nmake: *** [Release/obj.target/rapidx2j/src/rapidx2j.o] Error 1\r\nmake: Leaving directory `/var/tests/xml2js/node_modules/rapidx2j/build'\r\ngyp ERR! build error \r\ngyp ERR! stack Error: `make` failed with exit code: 2\r\ngyp ERR! stack     at ChildProcess.onExit (/usr/share/node-gyp/lib/build.js:267:23)\r\ngyp ERR! stack     at ChildProcess.EventEmitter.emit (events.js:98:17)\r\ngyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:797:12)\r\ngyp ERR! System Linux 3.16.0-38-generic\r\ngyp ERR! command \"nodejs\" \"/usr/bin/node-gyp\" \"rebuild\"\r\ngyp ERR! cwd /var/tests/xml2js/node_modules/rapidx2j\r\ngyp ERR! node -v v0.10.25\r\ngyp ERR! node-gyp -v v0.10.10\r\ngyp ERR! not ok \r\nnpm ERR! weird error 1\r\nnpm ERR! not ok code 0\r\n```\r\n\r\n```\r\n$ npm --version\r\n1.3.10\r\n$ node --version\r\nv0.10.25\r\n```"},"comment":{"url":"https://api.github.com/repos/damirn/rapidx2j/issues/comments/135790486","html_url":"https://github.com/damirn/rapidx2j/issues/1#issuecomment-135790486","issue_url":"https://api.github.com/repos/damirn/rapidx2j/issues/1","id":135790486,"user":{"login":"Redsandro","id":1702193,"avatar_url":"https://avatars.githubusercontent.com/u/1702193?v=3","gravatar_id":"","url":"https://api.github.com/users/Redsandro","html_url":"https://github.com/Redsandro","followers_url":"https://api.github.com/users/Redsandro/followers","following_url":"https://api.github.com/users/Redsandro/following{/other_user}","gists_url":"https://api.github.com/users/Redsandro/gists{/gist_id}","starred_url":"https://api.github.com/users/Redsandro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Redsandro/subscriptions","organizations_url":"https://api.github.com/users/Redsandro/orgs","repos_url":"https://api.github.com/users/Redsandro/repos","events_url":"https://api.github.com/users/Redsandro/events{/privacy}","received_events_url":"https://api.github.com/users/Redsandro/received_events","type":"User","site_admin":false},"created_at":"2015-08-28T14:34:59Z","updated_at":"2015-08-28T14:34:59Z","body":"Speed increase for 2 MB xml seems 1.7 times faster.\r\n\r\nOn files around 200 KB, it can be up to 3 times faster.\r\n\r\n```\r\nxml2json 0.5.1: 140ms\r\nxml2json 0.5.1: 125ms\r\nxml2json 0.5.1: 125ms\r\nxml2json 0.5.1: 129ms\r\nxml2json 0.5.1: 130ms\r\nxml2js-expat 0.2.2: 120ms\r\nxml2js-expat 0.2.2: 129ms\r\nxml2js-expat 0.2.2: 102ms\r\nxml2js-expat 0.2.2: 117ms\r\nxml2js-expat 0.2.2: 112ms\r\nrapidx2j 0.0.9: 28ms\r\nrapidx2j 0.0.9: 52ms\r\nrapidx2j 0.0.9: 30ms\r\nrapidx2j 0.0.9: 31ms\r\nrapidx2j 0.0.9: 30ms\r\n```\r\n\r\nBenchmarking in good faith; I will verify actual output later."}}