{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3205","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3205/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3205/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3205/events","html_url":"https://github.com/cockroachdb/cockroach/pull/3205","id":118444019,"number":3205,"title":"rpc: client.Close() waits for heartbeat goroutine shutdown","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-23T18:38:12Z","updated_at":"2015-11-23T20:16:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/3205","html_url":"https://github.com/cockroachdb/cockroach/pull/3205","diff_url":"https://github.com/cockroachdb/cockroach/pull/3205.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/3205.patch"},"body":"This is kind of not so good when the client is stuck connecting. Sadly, there is no way to plumb stopper channels into the dialer.\r\n\r\nCloses #3194.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/3205)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/159051421","html_url":"https://github.com/cockroachdb/cockroach/pull/3205#issuecomment-159051421","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3205","id":159051421,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2015-11-23T20:16:10Z","updated_at":"2015-11-23T20:16:10Z","body":"Likewise :(\n\nOn Mon, Nov 23, 2015 at 3:12 PM, mrtracy <notifications@github.com> wrote:\n\n> LGTM, although the word \"close\" has now lost its meaning to me through\n> repetition. :)\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/cockroachdb/cockroach/pull/3205#issuecomment-159050167>\n> .\n>\n"}}