{"action":"created","issue":{"url":"https://api.github.com/repos/gotwarlost/istanbul/issues/481","labels_url":"https://api.github.com/repos/gotwarlost/istanbul/issues/481/labels{/name}","comments_url":"https://api.github.com/repos/gotwarlost/istanbul/issues/481/comments","events_url":"https://api.github.com/repos/gotwarlost/istanbul/issues/481/events","html_url":"https://github.com/gotwarlost/istanbul/pull/481","id":116704184,"number":481,"title":"Add test support for Node 4 and 5","user":{"login":"kpdecker","id":196390,"avatar_url":"https://avatars.githubusercontent.com/u/196390?v=3","gravatar_id":"","url":"https://api.github.com/users/kpdecker","html_url":"https://github.com/kpdecker","followers_url":"https://api.github.com/users/kpdecker/followers","following_url":"https://api.github.com/users/kpdecker/following{/other_user}","gists_url":"https://api.github.com/users/kpdecker/gists{/gist_id}","starred_url":"https://api.github.com/users/kpdecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpdecker/subscriptions","organizations_url":"https://api.github.com/users/kpdecker/orgs","repos_url":"https://api.github.com/users/kpdecker/repos","events_url":"https://api.github.com/users/kpdecker/events{/privacy}","received_events_url":"https://api.github.com/users/kpdecker/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/gotwarlost/istanbul/labels/merge_pre_v1","name":"merge_pre_v1","color":"009800"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-13T05:42:58Z","updated_at":"2015-11-24T17:27:45Z","closed_at":"2015-11-24T16:17:45Z","pull_request":{"url":"https://api.github.com/repos/gotwarlost/istanbul/pulls/481","html_url":"https://github.com/gotwarlost/istanbul/pull/481","diff_url":"https://github.com/gotwarlost/istanbul/pull/481.diff","patch_url":"https://github.com/gotwarlost/istanbul/pull/481.patch"},"body":"This required a very minor modification to the prettify library due to differences in how RegExp.toString works with / under modern node instances.\r\n\r\n```\r\ndiff phanton.test.js node4.test.js\r\n1668c1668\r\n<   [PR.PR_DECLARATION, /^{{[#^>/]?\\s*[\\w.][^}]*}}/],\r\n---\r\n>   [PR.PR_DECLARATION, /^{{[#^>\\/]?\\s*[\\w.][^}]*}}/],\r\n```\r\n\r\nThe original regex contained `[#^>/]` and under the newer V8 versions, the toString version rendered as `[#^>\\/]`. By altering the source to have the escape character, the test works across all major versions of Node."},"comment":{"url":"https://api.github.com/repos/gotwarlost/istanbul/issues/comments/159348482","html_url":"https://github.com/gotwarlost/istanbul/pull/481#issuecomment-159348482","issue_url":"https://api.github.com/repos/gotwarlost/istanbul/issues/481","id":159348482,"user":{"login":"kpdecker","id":196390,"avatar_url":"https://avatars.githubusercontent.com/u/196390?v=3","gravatar_id":"","url":"https://api.github.com/users/kpdecker","html_url":"https://github.com/kpdecker","followers_url":"https://api.github.com/users/kpdecker/followers","following_url":"https://api.github.com/users/kpdecker/following{/other_user}","gists_url":"https://api.github.com/users/kpdecker/gists{/gist_id}","starred_url":"https://api.github.com/users/kpdecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpdecker/subscriptions","organizations_url":"https://api.github.com/users/kpdecker/orgs","repos_url":"https://api.github.com/users/kpdecker/repos","events_url":"https://api.github.com/users/kpdecker/events{/privacy}","received_events_url":"https://api.github.com/users/kpdecker/received_events","type":"User","site_admin":false},"created_at":"2015-11-24T17:27:45Z","updated_at":"2015-11-24T17:27:45Z","body":"What do you mean \"change vendor code\"? This is just updating the test config to run tests against modern node version."}}