{"action":"created","comment":{"url":"https://api.github.com/repos/AaronFriesen/Trydent/pulls/comments/25605803","id":25605803,"diff_hunk":"@@ -25,7 +25,7 @@\n \n     private String name = \"Untitled GameObject\";\n \n-    private Group fxNode;\n+    protected Group fxNode;","path":"src/main/java/edu/gatech/cs2340/trydent/GameObject.java","position":5,"original_position":5,"commit_id":"1428f99786705dd9c4db1bf901fb2c346eff3269","original_commit_id":"1428f99786705dd9c4db1bf901fb2c346eff3269","user":{"login":"gmalmquist","id":3391199,"avatar_url":"https://avatars.githubusercontent.com/u/3391199?v=3","gravatar_id":"","url":"https://api.github.com/users/gmalmquist","html_url":"https://github.com/gmalmquist","followers_url":"https://api.github.com/users/gmalmquist/followers","following_url":"https://api.github.com/users/gmalmquist/following{/other_user}","gists_url":"https://api.github.com/users/gmalmquist/gists{/gist_id}","starred_url":"https://api.github.com/users/gmalmquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmalmquist/subscriptions","organizations_url":"https://api.github.com/users/gmalmquist/orgs","repos_url":"https://api.github.com/users/gmalmquist/repos","events_url":"https://api.github.com/users/gmalmquist/events{/privacy}","received_events_url":"https://api.github.com/users/gmalmquist/received_events","type":"User","site_admin":false},"body":"I would prefer it be private, with a protected getter, unless subclasses need to assign to fxNode. The reason it's hidden a bit is that our parent/child tree is externally simplified but internally complicated, so I tried to separate the distinction as much as possible.","created_at":"2015-03-02T15:24:47Z","updated_at":"2015-03-02T15:24:47Z","html_url":"https://github.com/AaronFriesen/Trydent/pull/13#discussion_r25605803","pull_request_url":"https://api.github.com/repos/AaronFriesen/Trydent/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/AaronFriesen/Trydent/pulls/comments/25605803"},"html":{"href":"https://github.com/AaronFriesen/Trydent/pull/13#discussion_r25605803"},"pull_request":{"href":"https://api.github.com/repos/AaronFriesen/Trydent/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/AaronFriesen/Trydent/pulls/13","id":30250633,"html_url":"https://github.com/AaronFriesen/Trydent/pull/13","diff_url":"https://github.com/AaronFriesen/Trydent/pull/13.diff","patch_url":"https://github.com/AaronFriesen/Trydent/pull/13.patch","issue_url":"https://api.github.com/repos/AaronFriesen/Trydent/issues/13","number":13,"state":"open","locked":false,"title":"Adding a simple sprite implementation.","user":{"login":"djkeyes","id":6512637,"avatar_url":"https://avatars.githubusercontent.com/u/6512637?v=3","gravatar_id":"","url":"https://api.github.com/users/djkeyes","html_url":"https://github.com/djkeyes","followers_url":"https://api.github.com/users/djkeyes/followers","following_url":"https://api.github.com/users/djkeyes/following{/other_user}","gists_url":"https://api.github.com/users/djkeyes/gists{/gist_id}","starred_url":"https://api.github.com/users/djkeyes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djkeyes/subscriptions","organizations_url":"https://api.github.com/users/djkeyes/orgs","repos_url":"https://api.github.com/users/djkeyes/repos","events_url":"https://api.github.com/users/djkeyes/events{/privacy}","received_events_url":"https://api.github.com/users/djkeyes/received_events","type":"User","site_admin":false},"body":"This allows users to load and display simple sprites from a file (any of the\r\nkinds supported by javafx.scene.image.Image).\r\n\r\nIt also allows users to create simple sprite animations by looping a list of\r\nsprites. Maybe that isn't a use case people actually care about though--maybe\r\nwhat people really want are spritesheets. Who knows.\r\n\r\nThis would also benefit from having a cache for images.","created_at":"2015-03-01T22:48:32Z","updated_at":"2015-03-02T15:24:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AaronFriesen/Trydent/pulls/13/commits","review_comments_url":"https://api.github.com/repos/AaronFriesen/Trydent/pulls/13/comments","review_comment_url":"https://api.github.com/repos/AaronFriesen/Trydent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AaronFriesen/Trydent/issues/13/comments","statuses_url":"https://api.github.com/repos/AaronFriesen/Trydent/statuses/1428f99786705dd9c4db1bf901fb2c346eff3269","head":{"label":"AaronFriesen:sprites","ref":"sprites","sha":"1428f99786705dd9c4db1bf901fb2c346eff3269","user":{"login":"AaronFriesen","id":1156679,"avatar_url":"https://avatars.githubusercontent.com/u/1156679?v=3","gravatar_id":"","url":"https://api.github.com/users/AaronFriesen","html_url":"https://github.com/AaronFriesen","followers_url":"https://api.github.com/users/AaronFriesen/followers","following_url":"https://api.github.com/users/AaronFriesen/following{/other_user}","gists_url":"https://api.github.com/users/AaronFriesen/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronFriesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronFriesen/subscriptions","organizations_url":"https://api.github.com/users/AaronFriesen/orgs","repos_url":"https://api.github.com/users/AaronFriesen/repos","events_url":"https://api.github.com/users/AaronFriesen/events{/privacy}","received_events_url":"https://api.github.com/users/AaronFriesen/received_events","type":"User","site_admin":false},"repo":{"id":29509654,"name":"Trydent","full_name":"AaronFriesen/Trydent","owner":{"login":"AaronFriesen","id":1156679,"avatar_url":"https://avatars.githubusercontent.com/u/1156679?v=3","gravatar_id":"","url":"https://api.github.com/users/AaronFriesen","html_url":"https://github.com/AaronFriesen","followers_url":"https://api.github.com/users/AaronFriesen/followers","following_url":"https://api.github.com/users/AaronFriesen/following{/other_user}","gists_url":"https://api.github.com/users/AaronFriesen/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronFriesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronFriesen/subscriptions","organizations_url":"https://api.github.com/users/AaronFriesen/orgs","repos_url":"https://api.github.com/users/AaronFriesen/repos","events_url":"https://api.github.com/users/AaronFriesen/events{/privacy}","received_events_url":"https://api.github.com/users/AaronFriesen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AaronFriesen/Trydent","description":"Simple JavaFX GUI Engine.","fork":false,"url":"https://api.github.com/repos/AaronFriesen/Trydent","forks_url":"https://api.github.com/repos/AaronFriesen/Trydent/forks","keys_url":"https://api.github.com/repos/AaronFriesen/Trydent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AaronFriesen/Trydent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AaronFriesen/Trydent/teams","hooks_url":"https://api.github.com/repos/AaronFriesen/Trydent/hooks","issue_events_url":"https://api.github.com/repos/AaronFriesen/Trydent/issues/events{/number}","events_url":"https://api.github.com/repos/AaronFriesen/Trydent/events","assignees_url":"https://api.github.com/repos/AaronFriesen/Trydent/assignees{/user}","branches_url":"https://api.github.com/repos/AaronFriesen/Trydent/branches{/branch}","tags_url":"https://api.github.com/repos/AaronFriesen/Trydent/tags","blobs_url":"https://api.github.com/repos/AaronFriesen/Trydent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AaronFriesen/Trydent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AaronFriesen/Trydent/git/refs{/sha}","trees_url":"https://api.github.com/repos/AaronFriesen/Trydent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AaronFriesen/Trydent/statuses/{sha}","languages_url":"https://api.github.com/repos/AaronFriesen/Trydent/languages","stargazers_url":"https://api.github.com/repos/AaronFriesen/Trydent/stargazers","contributors_url":"https://api.github.com/repos/AaronFriesen/Trydent/contributors","subscribers_url":"https://api.github.com/repos/AaronFriesen/Trydent/subscribers","subscription_url":"https://api.github.com/repos/AaronFriesen/Trydent/subscription","commits_url":"https://api.github.com/repos/AaronFriesen/Trydent/commits{/sha}","git_commits_url":"https://api.github.com/repos/AaronFriesen/Trydent/git/commits{/sha}","comments_url":"https://api.github.com/repos/AaronFriesen/Trydent/comments{/number}","issue_comment_url":"https://api.github.com/repos/AaronFriesen/Trydent/issues/comments{/number}","contents_url":"https://api.github.com/repos/AaronFriesen/Trydent/contents/{+path}","compare_url":"https://api.github.com/repos/AaronFriesen/Trydent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AaronFriesen/Trydent/merges","archive_url":"https://api.github.com/repos/AaronFriesen/Trydent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AaronFriesen/Trydent/downloads","issues_url":"https://api.github.com/repos/AaronFriesen/Trydent/issues{/number}","pulls_url":"https://api.github.com/repos/AaronFriesen/Trydent/pulls{/number}","milestones_url":"https://api.github.com/repos/AaronFriesen/Trydent/milestones{/number}","notifications_url":"https://api.github.com/repos/AaronFriesen/Trydent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AaronFriesen/Trydent/labels{/name}","releases_url":"https://api.github.com/repos/AaronFriesen/Trydent/releases{/id}","created_at":"2015-01-20T03:21:32Z","updated_at":"2015-02-28T03:45:30Z","pushed_at":"2015-03-02T01:27:14Z","git_url":"git://github.com/AaronFriesen/Trydent.git","ssh_url":"git@github.com:AaronFriesen/Trydent.git","clone_url":"https://github.com/AaronFriesen/Trydent.git","svn_url":"https://github.com/AaronFriesen/Trydent","homepage":null,"size":538,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"AaronFriesen:master","ref":"master","sha":"bc740b8971bb3b1b22ecca0fc54b934b49b84d32","user":{"login":"AaronFriesen","id":1156679,"avatar_url":"https://avatars.githubusercontent.com/u/1156679?v=3","gravatar_id":"","url":"https://api.github.com/users/AaronFriesen","html_url":"https://github.com/AaronFriesen","followers_url":"https://api.github.com/users/AaronFriesen/followers","following_url":"https://api.github.com/users/AaronFriesen/following{/other_user}","gists_url":"https://api.github.com/users/AaronFriesen/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronFriesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronFriesen/subscriptions","organizations_url":"https://api.github.com/users/AaronFriesen/orgs","repos_url":"https://api.github.com/users/AaronFriesen/repos","events_url":"https://api.github.com/users/AaronFriesen/events{/privacy}","received_events_url":"https://api.github.com/users/AaronFriesen/received_events","type":"User","site_admin":false},"repo":{"id":29509654,"name":"Trydent","full_name":"AaronFriesen/Trydent","owner":{"login":"AaronFriesen","id":1156679,"avatar_url":"https://avatars.githubusercontent.com/u/1156679?v=3","gravatar_id":"","url":"https://api.github.com/users/AaronFriesen","html_url":"https://github.com/AaronFriesen","followers_url":"https://api.github.com/users/AaronFriesen/followers","following_url":"https://api.github.com/users/AaronFriesen/following{/other_user}","gists_url":"https://api.github.com/users/AaronFriesen/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronFriesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronFriesen/subscriptions","organizations_url":"https://api.github.com/users/AaronFriesen/orgs","repos_url":"https://api.github.com/users/AaronFriesen/repos","events_url":"https://api.github.com/users/AaronFriesen/events{/privacy}","received_events_url":"https://api.github.com/users/AaronFriesen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AaronFriesen/Trydent","description":"Simple JavaFX GUI Engine.","fork":false,"url":"https://api.github.com/repos/AaronFriesen/Trydent","forks_url":"https://api.github.com/repos/AaronFriesen/Trydent/forks","keys_url":"https://api.github.com/repos/AaronFriesen/Trydent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AaronFriesen/Trydent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AaronFriesen/Trydent/teams","hooks_url":"https://api.github.com/repos/AaronFriesen/Trydent/hooks","issue_events_url":"https://api.github.com/repos/AaronFriesen/Trydent/issues/events{/number}","events_url":"https://api.github.com/repos/AaronFriesen/Trydent/events","assignees_url":"https://api.github.com/repos/AaronFriesen/Trydent/assignees{/user}","branches_url":"https://api.github.com/repos/AaronFriesen/Trydent/branches{/branch}","tags_url":"https://api.github.com/repos/AaronFriesen/Trydent/tags","blobs_url":"https://api.github.com/repos/AaronFriesen/Trydent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AaronFriesen/Trydent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AaronFriesen/Trydent/git/refs{/sha}","trees_url":"https://api.github.com/repos/AaronFriesen/Trydent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AaronFriesen/Trydent/statuses/{sha}","languages_url":"https://api.github.com/repos/AaronFriesen/Trydent/languages","stargazers_url":"https://api.github.com/repos/AaronFriesen/Trydent/stargazers","contributors_url":"https://api.github.com/repos/AaronFriesen/Trydent/contributors","subscribers_url":"https://api.github.com/repos/AaronFriesen/Trydent/subscribers","subscription_url":"https://api.github.com/repos/AaronFriesen/Trydent/subscription","commits_url":"https://api.github.com/repos/AaronFriesen/Trydent/commits{/sha}","git_commits_url":"https://api.github.com/repos/AaronFriesen/Trydent/git/commits{/sha}","comments_url":"https://api.github.com/repos/AaronFriesen/Trydent/comments{/number}","issue_comment_url":"https://api.github.com/repos/AaronFriesen/Trydent/issues/comments{/number}","contents_url":"https://api.github.com/repos/AaronFriesen/Trydent/contents/{+path}","compare_url":"https://api.github.com/repos/AaronFriesen/Trydent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AaronFriesen/Trydent/merges","archive_url":"https://api.github.com/repos/AaronFriesen/Trydent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AaronFriesen/Trydent/downloads","issues_url":"https://api.github.com/repos/AaronFriesen/Trydent/issues{/number}","pulls_url":"https://api.github.com/repos/AaronFriesen/Trydent/pulls{/number}","milestones_url":"https://api.github.com/repos/AaronFriesen/Trydent/milestones{/number}","notifications_url":"https://api.github.com/repos/AaronFriesen/Trydent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AaronFriesen/Trydent/labels{/name}","releases_url":"https://api.github.com/repos/AaronFriesen/Trydent/releases{/id}","created_at":"2015-01-20T03:21:32Z","updated_at":"2015-02-28T03:45:30Z","pushed_at":"2015-03-02T01:27:14Z","git_url":"git://github.com/AaronFriesen/Trydent.git","ssh_url":"git@github.com:AaronFriesen/Trydent.git","clone_url":"https://github.com/AaronFriesen/Trydent.git","svn_url":"https://github.com/AaronFriesen/Trydent","homepage":null,"size":538,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AaronFriesen/Trydent/pulls/13"},"html":{"href":"https://github.com/AaronFriesen/Trydent/pull/13"},"issue":{"href":"https://api.github.com/repos/AaronFriesen/Trydent/issues/13"},"comments":{"href":"https://api.github.com/repos/AaronFriesen/Trydent/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/AaronFriesen/Trydent/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/AaronFriesen/Trydent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AaronFriesen/Trydent/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/AaronFriesen/Trydent/statuses/1428f99786705dd9c4db1bf901fb2c346eff3269"}}}}