{"action":"created","issue":{"url":"https://api.github.com/repos/joshua-decoder/joshua/issues/212","labels_url":"https://api.github.com/repos/joshua-decoder/joshua/issues/212/labels{/name}","comments_url":"https://api.github.com/repos/joshua-decoder/joshua/issues/212/comments","events_url":"https://api.github.com/repos/joshua-decoder/joshua/issues/212/events","html_url":"https://github.com/joshua-decoder/joshua/issues/212","id":108179151,"number":212,"title":"Speed issue with string construction","user":{"login":"mjpost","id":455256,"avatar_url":"https://avatars.githubusercontent.com/u/455256?v=3","gravatar_id":"","url":"https://api.github.com/users/mjpost","html_url":"https://github.com/mjpost","followers_url":"https://api.github.com/users/mjpost/followers","following_url":"https://api.github.com/users/mjpost/following{/other_user}","gists_url":"https://api.github.com/users/mjpost/gists{/gist_id}","starred_url":"https://api.github.com/users/mjpost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjpost/subscriptions","organizations_url":"https://api.github.com/users/mjpost/orgs","repos_url":"https://api.github.com/users/mjpost/repos","events_url":"https://api.github.com/users/mjpost/events{/privacy}","received_events_url":"https://api.github.com/users/mjpost/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-24T17:44:00Z","updated_at":"2015-10-16T15:11:23Z","closed_at":"2015-10-16T15:11:22Z","body":"Features contribute their values using string lookups. This occurs for every edge that is created and for every feature. It would be much faster to define a vocabulary for feature IDs, and have features that are able to pre-register the set of features they will contribute. This would likely result in a large speedup."},"comment":{"url":"https://api.github.com/repos/joshua-decoder/joshua/issues/comments/148742563","html_url":"https://github.com/joshua-decoder/joshua/issues/212#issuecomment-148742563","issue_url":"https://api.github.com/repos/joshua-decoder/joshua/issues/212","id":148742563,"user":{"login":"mjpost","id":455256,"avatar_url":"https://avatars.githubusercontent.com/u/455256?v=3","gravatar_id":"","url":"https://api.github.com/users/mjpost","html_url":"https://github.com/mjpost","followers_url":"https://api.github.com/users/mjpost/followers","following_url":"https://api.github.com/users/mjpost/following{/other_user}","gists_url":"https://api.github.com/users/mjpost/gists{/gist_id}","starred_url":"https://api.github.com/users/mjpost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjpost/subscriptions","organizations_url":"https://api.github.com/users/mjpost/orgs","repos_url":"https://api.github.com/users/mjpost/repos","events_url":"https://api.github.com/users/mjpost/events{/privacy}","received_events_url":"https://api.github.com/users/mjpost/received_events","type":"User","site_admin":false},"created_at":"2015-10-16T15:11:22Z","updated_at":"2015-10-16T15:11:22Z","body":"This is addressed with commit 64f4043cf6fc5985ec3c0b20fcd23f3541b32eb1, which adds proper dense features. It didn't result in much of a performance increase, but the code is a bit cleaner now, since the features themselves know which dense and which sparse features they contribute."}}