{"action":"created","issue":{"url":"https://api.github.com/repos/betfair/cougar/issues/84","labels_url":"https://api.github.com/repos/betfair/cougar/issues/84/labels{/name}","comments_url":"https://api.github.com/repos/betfair/cougar/issues/84/comments","events_url":"https://api.github.com/repos/betfair/cougar/issues/84/events","html_url":"https://github.com/betfair/cougar/issues/84","id":46796639,"number":84,"title":"Bug in the generated client code regarding TimeConstraints","user":{"login":"andredasilvapinto","id":2671593,"avatar_url":"https://avatars.githubusercontent.com/u/2671593?v=3","gravatar_id":"","url":"https://api.github.com/users/andredasilvapinto","html_url":"https://github.com/andredasilvapinto","followers_url":"https://api.github.com/users/andredasilvapinto/followers","following_url":"https://api.github.com/users/andredasilvapinto/following{/other_user}","gists_url":"https://api.github.com/users/andredasilvapinto/gists{/gist_id}","starred_url":"https://api.github.com/users/andredasilvapinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andredasilvapinto/subscriptions","organizations_url":"https://api.github.com/users/andredasilvapinto/orgs","repos_url":"https://api.github.com/users/andredasilvapinto/repos","events_url":"https://api.github.com/users/andredasilvapinto/events{/privacy}","received_events_url":"https://api.github.com/users/andredasilvapinto/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/betfair/cougar/labels/accepted","name":"accepted","color":"5319e7"},{"url":"https://api.github.com/repos/betfair/cougar/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/betfair/cougar/milestones/9","labels_url":"https://api.github.com/repos/betfair/cougar/milestones/9/labels","id":870663,"number":9,"title":"Release 3.1.1","description":"","creator":{"login":"eswdd","id":1651355,"avatar_url":"https://avatars.githubusercontent.com/u/1651355?v=3","gravatar_id":"","url":"https://api.github.com/users/eswdd","html_url":"https://github.com/eswdd","followers_url":"https://api.github.com/users/eswdd/followers","following_url":"https://api.github.com/users/eswdd/following{/other_user}","gists_url":"https://api.github.com/users/eswdd/gists{/gist_id}","starred_url":"https://api.github.com/users/eswdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eswdd/subscriptions","organizations_url":"https://api.github.com/users/eswdd/orgs","repos_url":"https://api.github.com/users/eswdd/repos","events_url":"https://api.github.com/users/eswdd/events{/privacy}","received_events_url":"https://api.github.com/users/eswdd/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":1,"state":"open","created_at":"2014-11-18T06:14:26Z","updated_at":"2014-11-18T06:15:03Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2014-10-25T00:33:52Z","updated_at":"2015-01-25T11:05:55Z","closed_at":null,"body":"The timeout to TimeConstraint conversion is not considering the case of no timeout (timeout == 0) for the AsyncClient.\r\n\r\ncougar-codegen-plugin/templates/client-impl.ftl\r\n``` DefaultTimeConstraints.fromTimeout(timeoutMillis) ```\r\n\r\nThis effectively transforms a \"no timeout\" to a \"timeout now\" operation.\r\n\r\nMy suggestion (contained on the referenced pull request) would be not to add the same logic as we have on /templates/clientSyncServiceImpl.ftl, but instead extract it to to a centralized point inside the fromTimeout static method."},"comment":{"url":"https://api.github.com/repos/betfair/cougar/issues/comments/71366670","html_url":"https://github.com/betfair/cougar/issues/84#issuecomment-71366670","issue_url":"https://api.github.com/repos/betfair/cougar/issues/84","id":71366670,"user":{"login":"eswdd","id":1651355,"avatar_url":"https://avatars.githubusercontent.com/u/1651355?v=3","gravatar_id":"","url":"https://api.github.com/users/eswdd","html_url":"https://github.com/eswdd","followers_url":"https://api.github.com/users/eswdd/followers","following_url":"https://api.github.com/users/eswdd/following{/other_user}","gists_url":"https://api.github.com/users/eswdd/gists{/gist_id}","starred_url":"https://api.github.com/users/eswdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eswdd/subscriptions","organizations_url":"https://api.github.com/users/eswdd/orgs","repos_url":"https://api.github.com/users/eswdd/repos","events_url":"https://api.github.com/users/eswdd/events{/privacy}","received_events_url":"https://api.github.com/users/eswdd/received_events","type":"User","site_admin":false},"created_at":"2015-01-25T11:05:55Z","updated_at":"2015-01-25T11:05:55Z","body":"Will expand tests in trunk under #91"}}