{"action":"created","comment":{"url":"https://api.github.com/repos/docker/compose/pulls/comments/39205351","id":39205351,"diff_hunk":"@@ -37,7 +37,15 @@\n \n         \"environment\": {","path":"compose/config/fields_schema.json","position":2,"original_position":2,"commit_id":"bb4c9e27bf32fe237f86d78aebbbe354a8f8070a","original_commit_id":"4c34672ab6c5087de5eff5331887c13434855773","user":{"login":"mnowster","id":557287,"avatar_url":"https://avatars.githubusercontent.com/u/557287?v=3","gravatar_id":"","url":"https://api.github.com/users/mnowster","html_url":"https://github.com/mnowster","followers_url":"https://api.github.com/users/mnowster/followers","following_url":"https://api.github.com/users/mnowster/following{/other_user}","gists_url":"https://api.github.com/users/mnowster/gists{/gist_id}","starred_url":"https://api.github.com/users/mnowster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnowster/subscriptions","organizations_url":"https://api.github.com/users/mnowster/orgs","repos_url":"https://api.github.com/users/mnowster/repos","events_url":"https://api.github.com/users/mnowster/events{/privacy}","received_events_url":"https://api.github.com/users/mnowster/received_events","type":"User","site_admin":false},"body":"I honestly can't remember now why I thought they had separate requirements and I can't find it in my notes. If you can't think of any issues with doing that, I think that's a good suggestion, I will amend. Thanks.","created_at":"2015-09-10T19:54:01Z","updated_at":"2015-09-10T19:54:01Z","html_url":"https://github.com/docker/compose/pull/2000#discussion_r39205351","pull_request_url":"https://api.github.com/repos/docker/compose/pulls/2000","_links":{"self":{"href":"https://api.github.com/repos/docker/compose/pulls/comments/39205351"},"html":{"href":"https://github.com/docker/compose/pull/2000#discussion_r39205351"},"pull_request":{"href":"https://api.github.com/repos/docker/compose/pulls/2000"}}},"pull_request":{"url":"https://api.github.com/repos/docker/compose/pulls/2000","id":44367054,"html_url":"https://github.com/docker/compose/pull/2000","diff_url":"https://github.com/docker/compose/pull/2000.diff","patch_url":"https://github.com/docker/compose/pull/2000.patch","issue_url":"https://api.github.com/repos/docker/compose/issues/2000","number":2000,"state":"open","locked":false,"title":"Disallow booleans in environment","user":{"login":"mnowster","id":557287,"avatar_url":"https://avatars.githubusercontent.com/u/557287?v=3","gravatar_id":"","url":"https://api.github.com/users/mnowster","html_url":"https://github.com/mnowster","followers_url":"https://api.github.com/users/mnowster/followers","following_url":"https://api.github.com/users/mnowster/following{/other_user}","gists_url":"https://api.github.com/users/mnowster/gists{/gist_id}","starred_url":"https://api.github.com/users/mnowster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnowster/subscriptions","organizations_url":"https://api.github.com/users/mnowster/orgs","repos_url":"https://api.github.com/users/mnowster/repos","events_url":"https://api.github.com/users/mnowster/events{/privacy}","received_events_url":"https://api.github.com/users/mnowster/received_events","type":"User","site_admin":false},"body":"This change will force people to put boolean values in quotes, thus ensuring\r\nthat the value gets passed through as intended.\r\n\r\nFixes #1788","created_at":"2015-09-07T15:48:21Z","updated_at":"2015-09-10T19:54:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3c009c81ff0b0e09b2e414dce83119f17d67136","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/compose/pulls/2000/commits","review_comments_url":"https://api.github.com/repos/docker/compose/pulls/2000/comments","review_comment_url":"https://api.github.com/repos/docker/compose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/compose/issues/2000/comments","statuses_url":"https://api.github.com/repos/docker/compose/statuses/bb4c9e27bf32fe237f86d78aebbbe354a8f8070a","head":{"label":"mnowster:do-not-allow-booleans-in-environment","ref":"do-not-allow-booleans-in-environment","sha":"bb4c9e27bf32fe237f86d78aebbbe354a8f8070a","user":{"login":"mnowster","id":557287,"avatar_url":"https://avatars.githubusercontent.com/u/557287?v=3","gravatar_id":"","url":"https://api.github.com/users/mnowster","html_url":"https://github.com/mnowster","followers_url":"https://api.github.com/users/mnowster/followers","following_url":"https://api.github.com/users/mnowster/following{/other_user}","gists_url":"https://api.github.com/users/mnowster/gists{/gist_id}","starred_url":"https://api.github.com/users/mnowster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnowster/subscriptions","organizations_url":"https://api.github.com/users/mnowster/orgs","repos_url":"https://api.github.com/users/mnowster/repos","events_url":"https://api.github.com/users/mnowster/events{/privacy}","received_events_url":"https://api.github.com/users/mnowster/received_events","type":"User","site_admin":false},"repo":{"id":38368096,"name":"compose","full_name":"mnowster/compose","owner":{"login":"mnowster","id":557287,"avatar_url":"https://avatars.githubusercontent.com/u/557287?v=3","gravatar_id":"","url":"https://api.github.com/users/mnowster","html_url":"https://github.com/mnowster","followers_url":"https://api.github.com/users/mnowster/followers","following_url":"https://api.github.com/users/mnowster/following{/other_user}","gists_url":"https://api.github.com/users/mnowster/gists{/gist_id}","starred_url":"https://api.github.com/users/mnowster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnowster/subscriptions","organizations_url":"https://api.github.com/users/mnowster/orgs","repos_url":"https://api.github.com/users/mnowster/repos","events_url":"https://api.github.com/users/mnowster/events{/privacy}","received_events_url":"https://api.github.com/users/mnowster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mnowster/compose","description":"Define and run multi-container applications with Docker","fork":true,"url":"https://api.github.com/repos/mnowster/compose","forks_url":"https://api.github.com/repos/mnowster/compose/forks","keys_url":"https://api.github.com/repos/mnowster/compose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mnowster/compose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mnowster/compose/teams","hooks_url":"https://api.github.com/repos/mnowster/compose/hooks","issue_events_url":"https://api.github.com/repos/mnowster/compose/issues/events{/number}","events_url":"https://api.github.com/repos/mnowster/compose/events","assignees_url":"https://api.github.com/repos/mnowster/compose/assignees{/user}","branches_url":"https://api.github.com/repos/mnowster/compose/branches{/branch}","tags_url":"https://api.github.com/repos/mnowster/compose/tags","blobs_url":"https://api.github.com/repos/mnowster/compose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mnowster/compose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mnowster/compose/git/refs{/sha}","trees_url":"https://api.github.com/repos/mnowster/compose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mnowster/compose/statuses/{sha}","languages_url":"https://api.github.com/repos/mnowster/compose/languages","stargazers_url":"https://api.github.com/repos/mnowster/compose/stargazers","contributors_url":"https://api.github.com/repos/mnowster/compose/contributors","subscribers_url":"https://api.github.com/repos/mnowster/compose/subscribers","subscription_url":"https://api.github.com/repos/mnowster/compose/subscription","commits_url":"https://api.github.com/repos/mnowster/compose/commits{/sha}","git_commits_url":"https://api.github.com/repos/mnowster/compose/git/commits{/sha}","comments_url":"https://api.github.com/repos/mnowster/compose/comments{/number}","issue_comment_url":"https://api.github.com/repos/mnowster/compose/issues/comments{/number}","contents_url":"https://api.github.com/repos/mnowster/compose/contents/{+path}","compare_url":"https://api.github.com/repos/mnowster/compose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mnowster/compose/merges","archive_url":"https://api.github.com/repos/mnowster/compose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mnowster/compose/downloads","issues_url":"https://api.github.com/repos/mnowster/compose/issues{/number}","pulls_url":"https://api.github.com/repos/mnowster/compose/pulls{/number}","milestones_url":"https://api.github.com/repos/mnowster/compose/milestones{/number}","notifications_url":"https://api.github.com/repos/mnowster/compose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mnowster/compose/labels{/name}","releases_url":"https://api.github.com/repos/mnowster/compose/releases{/id}","created_at":"2015-07-01T11:42:55Z","updated_at":"2015-07-01T11:42:57Z","pushed_at":"2015-09-10T15:55:21Z","git_url":"git://github.com/mnowster/compose.git","ssh_url":"git@github.com:mnowster/compose.git","clone_url":"https://github.com/mnowster/compose.git","svn_url":"https://github.com/mnowster/compose","homepage":"https://docs.docker.com/compose/","size":3680,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"9da2bf3973cc78cbdf141197fd3338b233245696","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":15045751,"name":"compose","full_name":"docker/compose","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/compose","description":"Define and run multi-container applications with Docker","fork":false,"url":"https://api.github.com/repos/docker/compose","forks_url":"https://api.github.com/repos/docker/compose/forks","keys_url":"https://api.github.com/repos/docker/compose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/compose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/compose/teams","hooks_url":"https://api.github.com/repos/docker/compose/hooks","issue_events_url":"https://api.github.com/repos/docker/compose/issues/events{/number}","events_url":"https://api.github.com/repos/docker/compose/events","assignees_url":"https://api.github.com/repos/docker/compose/assignees{/user}","branches_url":"https://api.github.com/repos/docker/compose/branches{/branch}","tags_url":"https://api.github.com/repos/docker/compose/tags","blobs_url":"https://api.github.com/repos/docker/compose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/compose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/compose/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/compose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/compose/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/compose/languages","stargazers_url":"https://api.github.com/repos/docker/compose/stargazers","contributors_url":"https://api.github.com/repos/docker/compose/contributors","subscribers_url":"https://api.github.com/repos/docker/compose/subscribers","subscription_url":"https://api.github.com/repos/docker/compose/subscription","commits_url":"https://api.github.com/repos/docker/compose/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/compose/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/compose/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/compose/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/compose/contents/{+path}","compare_url":"https://api.github.com/repos/docker/compose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/compose/merges","archive_url":"https://api.github.com/repos/docker/compose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/compose/downloads","issues_url":"https://api.github.com/repos/docker/compose/issues{/number}","pulls_url":"https://api.github.com/repos/docker/compose/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/compose/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/compose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/compose/labels{/name}","releases_url":"https://api.github.com/repos/docker/compose/releases{/id}","created_at":"2013-12-09T11:40:58Z","updated_at":"2015-09-10T12:54:34Z","pushed_at":"2015-09-10T19:21:33Z","git_url":"git://github.com/docker/compose.git","ssh_url":"git@github.com:docker/compose.git","clone_url":"https://github.com/docker/compose.git","svn_url":"https://github.com/docker/compose","homepage":"https://docs.docker.com/compose/","size":72978,"stargazers_count":6257,"watchers_count":6257,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":771,"mirror_url":null,"open_issues_count":428,"forks":771,"open_issues":428,"watchers":6257,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/compose/pulls/2000"},"html":{"href":"https://github.com/docker/compose/pull/2000"},"issue":{"href":"https://api.github.com/repos/docker/compose/issues/2000"},"comments":{"href":"https://api.github.com/repos/docker/compose/issues/2000/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/compose/pulls/2000/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/compose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/compose/pulls/2000/commits"},"statuses":{"href":"https://api.github.com/repos/docker/compose/statuses/bb4c9e27bf32fe237f86d78aebbbe354a8f8070a"}}}}