{"action":"closed","number":949,"pull_request":{"url":"https://api.github.com/repos/sinkillerj/ProjectE/pulls/949","id":42863503,"html_url":"https://github.com/sinkillerj/ProjectE/pull/949","diff_url":"https://github.com/sinkillerj/ProjectE/pull/949.diff","patch_url":"https://github.com/sinkillerj/ProjectE/pull/949.patch","issue_url":"https://api.github.com/repos/sinkillerj/ProjectE/issues/949","number":949,"state":"closed","locked":false,"title":"Custom recipes","user":{"login":"Lilylicious","id":5985728,"avatar_url":"https://avatars.githubusercontent.com/u/5985728?v=3","gravatar_id":"","url":"https://api.github.com/users/Lilylicious","html_url":"https://github.com/Lilylicious","followers_url":"https://api.github.com/users/Lilylicious/followers","following_url":"https://api.github.com/users/Lilylicious/following{/other_user}","gists_url":"https://api.github.com/users/Lilylicious/gists{/gist_id}","starred_url":"https://api.github.com/users/Lilylicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lilylicious/subscriptions","organizations_url":"https://api.github.com/users/Lilylicious/orgs","repos_url":"https://api.github.com/users/Lilylicious/repos","events_url":"https://api.github.com/users/Lilylicious/events{/privacy}","received_events_url":"https://api.github.com/users/Lilylicious/received_events","type":"User","site_admin":false},"body":"NOTE: This is ready to be merged as it is, but there's one thing that I want input on before I put any work into it. The custom recipe RecipesCovalenceRepair. It's definitely something I want to get into NEI, but someone thought that @sinkillerj might've mentioned that he wants to do some changes in that area. \r\n\r\nThe question is: Are the covalence recipes going to change in the near future, and should I thus avoid working on them until such time? If they won't change, I have some ideas on how I can represent it in NEI. I think I would do a recipe for each covalence dust count, with the tool being cycled between the applicable ones, and the output matching the current tool. Find usages on covalence dust would then produce a tab in NEI that shows each dust count as well as what tools are repaired with how much dust. The other option is a text screen explaining that you can repair with dust.\r\n\r\n---\r\n\r\nDid some changing in two of the custom recipes, AlchemyBag and KleinStar. Instead of having a single instance of the recipes that has a catchall matches() method, they're now properly divided up into multiple instances (30 for the alchemy bags, 5 for the klein stars).\r\n\r\nThis meant adding constructors and changing how the matching() method worked. When registering the recipes, they're now added with output/input (for klein stars) and output/inputBag/inputDye(for alch bags). This simplifies the matches() method as well as conforms to how recipes usually work in Minecraft code (looks similar to Shapeless/Shaped recipes now, which they are).\r\n\r\nThe reason we need the custom recipes is to retain NBT data through crafting (klein stars with charge upgrade into the next step with the same charge, etc).\r\n\r\nThe alchemy bags are added into NEI as 16 recipes. 15 for white->non-white bag, one for each dye, as well as one for oredictBag + Bonemeal = white bag. That one cycles between all of the bags, including white even though that recipe doesn't work. I don't think it'd be a problem, no one should even try to do that recipe even though it technically says that you can. (it cycles between all colours of bags, spotting white would take a while).","created_at":"2015-08-19T21:00:47Z","updated_at":"2015-08-23T15:59:07Z","closed_at":"2015-08-23T15:59:07Z","merged_at":"2015-08-23T15:59:07Z","merge_commit_sha":"121e2845b31dab120d253d2cee9de28d20fa01de","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sinkillerj/ProjectE/pulls/949/commits","review_comments_url":"https://api.github.com/repos/sinkillerj/ProjectE/pulls/949/comments","review_comment_url":"https://api.github.com/repos/sinkillerj/ProjectE/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sinkillerj/ProjectE/issues/949/comments","statuses_url":"https://api.github.com/repos/sinkillerj/ProjectE/statuses/a9c9697d9f0b46f67299c48a0b9bb83896a83bc3","head":{"label":"Lilylicious:CustomRecipes","ref":"CustomRecipes","sha":"a9c9697d9f0b46f67299c48a0b9bb83896a83bc3","user":{"login":"Lilylicious","id":5985728,"avatar_url":"https://avatars.githubusercontent.com/u/5985728?v=3","gravatar_id":"","url":"https://api.github.com/users/Lilylicious","html_url":"https://github.com/Lilylicious","followers_url":"https://api.github.com/users/Lilylicious/followers","following_url":"https://api.github.com/users/Lilylicious/following{/other_user}","gists_url":"https://api.github.com/users/Lilylicious/gists{/gist_id}","starred_url":"https://api.github.com/users/Lilylicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lilylicious/subscriptions","organizations_url":"https://api.github.com/users/Lilylicious/orgs","repos_url":"https://api.github.com/users/Lilylicious/repos","events_url":"https://api.github.com/users/Lilylicious/events{/privacy}","received_events_url":"https://api.github.com/users/Lilylicious/received_events","type":"User","site_admin":false},"repo":{"id":38118397,"name":"ProjectE","full_name":"Lilylicious/ProjectE","owner":{"login":"Lilylicious","id":5985728,"avatar_url":"https://avatars.githubusercontent.com/u/5985728?v=3","gravatar_id":"","url":"https://api.github.com/users/Lilylicious","html_url":"https://github.com/Lilylicious","followers_url":"https://api.github.com/users/Lilylicious/followers","following_url":"https://api.github.com/users/Lilylicious/following{/other_user}","gists_url":"https://api.github.com/users/Lilylicious/gists{/gist_id}","starred_url":"https://api.github.com/users/Lilylicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lilylicious/subscriptions","organizations_url":"https://api.github.com/users/Lilylicious/orgs","repos_url":"https://api.github.com/users/Lilylicious/repos","events_url":"https://api.github.com/users/Lilylicious/events{/privacy}","received_events_url":"https://api.github.com/users/Lilylicious/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lilylicious/ProjectE","description":"ProjectE (1.7 Version). A complete rewrite of EE2 for modern Minecraft versions.","fork":true,"url":"https://api.github.com/repos/Lilylicious/ProjectE","forks_url":"https://api.github.com/repos/Lilylicious/ProjectE/forks","keys_url":"https://api.github.com/repos/Lilylicious/ProjectE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lilylicious/ProjectE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lilylicious/ProjectE/teams","hooks_url":"https://api.github.com/repos/Lilylicious/ProjectE/hooks","issue_events_url":"https://api.github.com/repos/Lilylicious/ProjectE/issues/events{/number}","events_url":"https://api.github.com/repos/Lilylicious/ProjectE/events","assignees_url":"https://api.github.com/repos/Lilylicious/ProjectE/assignees{/user}","branches_url":"https://api.github.com/repos/Lilylicious/ProjectE/branches{/branch}","tags_url":"https://api.github.com/repos/Lilylicious/ProjectE/tags","blobs_url":"https://api.github.com/repos/Lilylicious/ProjectE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lilylicious/ProjectE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lilylicious/ProjectE/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lilylicious/ProjectE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lilylicious/ProjectE/statuses/{sha}","languages_url":"https://api.github.com/repos/Lilylicious/ProjectE/languages","stargazers_url":"https://api.github.com/repos/Lilylicious/ProjectE/stargazers","contributors_url":"https://api.github.com/repos/Lilylicious/ProjectE/contributors","subscribers_url":"https://api.github.com/repos/Lilylicious/ProjectE/subscribers","subscription_url":"https://api.github.com/repos/Lilylicious/ProjectE/subscription","commits_url":"https://api.github.com/repos/Lilylicious/ProjectE/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lilylicious/ProjectE/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lilylicious/ProjectE/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lilylicious/ProjectE/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lilylicious/ProjectE/contents/{+path}","compare_url":"https://api.github.com/repos/Lilylicious/ProjectE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lilylicious/ProjectE/merges","archive_url":"https://api.github.com/repos/Lilylicious/ProjectE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lilylicious/ProjectE/downloads","issues_url":"https://api.github.com/repos/Lilylicious/ProjectE/issues{/number}","pulls_url":"https://api.github.com/repos/Lilylicious/ProjectE/pulls{/number}","milestones_url":"https://api.github.com/repos/Lilylicious/ProjectE/milestones{/number}","notifications_url":"https://api.github.com/repos/Lilylicious/ProjectE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lilylicious/ProjectE/labels{/name}","releases_url":"https://api.github.com/repos/Lilylicious/ProjectE/releases{/id}","created_at":"2015-06-26T15:25:16Z","updated_at":"2015-06-26T15:25:18Z","pushed_at":"2015-08-23T14:52:26Z","git_url":"git://github.com/Lilylicious/ProjectE.git","ssh_url":"git@github.com:Lilylicious/ProjectE.git","clone_url":"https://github.com/Lilylicious/ProjectE.git","svn_url":"https://github.com/Lilylicious/ProjectE","homepage":"","size":5456,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sinkillerj:master","ref":"master","sha":"6190506feaa36d6fcd0e0102e801d508a9e474fd","user":{"login":"sinkillerj","id":1589514,"avatar_url":"https://avatars.githubusercontent.com/u/1589514?v=3","gravatar_id":"","url":"https://api.github.com/users/sinkillerj","html_url":"https://github.com/sinkillerj","followers_url":"https://api.github.com/users/sinkillerj/followers","following_url":"https://api.github.com/users/sinkillerj/following{/other_user}","gists_url":"https://api.github.com/users/sinkillerj/gists{/gist_id}","starred_url":"https://api.github.com/users/sinkillerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinkillerj/subscriptions","organizations_url":"https://api.github.com/users/sinkillerj/orgs","repos_url":"https://api.github.com/users/sinkillerj/repos","events_url":"https://api.github.com/users/sinkillerj/events{/privacy}","received_events_url":"https://api.github.com/users/sinkillerj/received_events","type":"User","site_admin":false},"repo":{"id":22923251,"name":"ProjectE","full_name":"sinkillerj/ProjectE","owner":{"login":"sinkillerj","id":1589514,"avatar_url":"https://avatars.githubusercontent.com/u/1589514?v=3","gravatar_id":"","url":"https://api.github.com/users/sinkillerj","html_url":"https://github.com/sinkillerj","followers_url":"https://api.github.com/users/sinkillerj/followers","following_url":"https://api.github.com/users/sinkillerj/following{/other_user}","gists_url":"https://api.github.com/users/sinkillerj/gists{/gist_id}","starred_url":"https://api.github.com/users/sinkillerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinkillerj/subscriptions","organizations_url":"https://api.github.com/users/sinkillerj/orgs","repos_url":"https://api.github.com/users/sinkillerj/repos","events_url":"https://api.github.com/users/sinkillerj/events{/privacy}","received_events_url":"https://api.github.com/users/sinkillerj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sinkillerj/ProjectE","description":"ProjectE. A complete rewrite of EE2 for modern Minecraft versions.","fork":false,"url":"https://api.github.com/repos/sinkillerj/ProjectE","forks_url":"https://api.github.com/repos/sinkillerj/ProjectE/forks","keys_url":"https://api.github.com/repos/sinkillerj/ProjectE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sinkillerj/ProjectE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sinkillerj/ProjectE/teams","hooks_url":"https://api.github.com/repos/sinkillerj/ProjectE/hooks","issue_events_url":"https://api.github.com/repos/sinkillerj/ProjectE/issues/events{/number}","events_url":"https://api.github.com/repos/sinkillerj/ProjectE/events","assignees_url":"https://api.github.com/repos/sinkillerj/ProjectE/assignees{/user}","branches_url":"https://api.github.com/repos/sinkillerj/ProjectE/branches{/branch}","tags_url":"https://api.github.com/repos/sinkillerj/ProjectE/tags","blobs_url":"https://api.github.com/repos/sinkillerj/ProjectE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sinkillerj/ProjectE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sinkillerj/ProjectE/git/refs{/sha}","trees_url":"https://api.github.com/repos/sinkillerj/ProjectE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sinkillerj/ProjectE/statuses/{sha}","languages_url":"https://api.github.com/repos/sinkillerj/ProjectE/languages","stargazers_url":"https://api.github.com/repos/sinkillerj/ProjectE/stargazers","contributors_url":"https://api.github.com/repos/sinkillerj/ProjectE/contributors","subscribers_url":"https://api.github.com/repos/sinkillerj/ProjectE/subscribers","subscription_url":"https://api.github.com/repos/sinkillerj/ProjectE/subscription","commits_url":"https://api.github.com/repos/sinkillerj/ProjectE/commits{/sha}","git_commits_url":"https://api.github.com/repos/sinkillerj/ProjectE/git/commits{/sha}","comments_url":"https://api.github.com/repos/sinkillerj/ProjectE/comments{/number}","issue_comment_url":"https://api.github.com/repos/sinkillerj/ProjectE/issues/comments{/number}","contents_url":"https://api.github.com/repos/sinkillerj/ProjectE/contents/{+path}","compare_url":"https://api.github.com/repos/sinkillerj/ProjectE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sinkillerj/ProjectE/merges","archive_url":"https://api.github.com/repos/sinkillerj/ProjectE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sinkillerj/ProjectE/downloads","issues_url":"https://api.github.com/repos/sinkillerj/ProjectE/issues{/number}","pulls_url":"https://api.github.com/repos/sinkillerj/ProjectE/pulls{/number}","milestones_url":"https://api.github.com/repos/sinkillerj/ProjectE/milestones{/number}","notifications_url":"https://api.github.com/repos/sinkillerj/ProjectE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sinkillerj/ProjectE/labels{/name}","releases_url":"https://api.github.com/repos/sinkillerj/ProjectE/releases{/id}","created_at":"2014-08-13T16:46:11Z","updated_at":"2015-08-23T03:25:15Z","pushed_at":"2015-08-23T15:59:07Z","git_url":"git://github.com/sinkillerj/ProjectE.git","ssh_url":"git@github.com:sinkillerj/ProjectE.git","clone_url":"https://github.com/sinkillerj/ProjectE.git","svn_url":"https://github.com/sinkillerj/ProjectE","homepage":"","size":10090,"stargazers_count":138,"watchers_count":138,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"open_issues_count":96,"forks":94,"open_issues":96,"watchers":138,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sinkillerj/ProjectE/pulls/949"},"html":{"href":"https://github.com/sinkillerj/ProjectE/pull/949"},"issue":{"href":"https://api.github.com/repos/sinkillerj/ProjectE/issues/949"},"comments":{"href":"https://api.github.com/repos/sinkillerj/ProjectE/issues/949/comments"},"review_comments":{"href":"https://api.github.com/repos/sinkillerj/ProjectE/pulls/949/comments"},"review_comment":{"href":"https://api.github.com/repos/sinkillerj/ProjectE/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sinkillerj/ProjectE/pulls/949/commits"},"statuses":{"href":"https://api.github.com/repos/sinkillerj/ProjectE/statuses/a9c9697d9f0b46f67299c48a0b9bb83896a83bc3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sinkillerj","id":1589514,"avatar_url":"https://avatars.githubusercontent.com/u/1589514?v=3","gravatar_id":"","url":"https://api.github.com/users/sinkillerj","html_url":"https://github.com/sinkillerj","followers_url":"https://api.github.com/users/sinkillerj/followers","following_url":"https://api.github.com/users/sinkillerj/following{/other_user}","gists_url":"https://api.github.com/users/sinkillerj/gists{/gist_id}","starred_url":"https://api.github.com/users/sinkillerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinkillerj/subscriptions","organizations_url":"https://api.github.com/users/sinkillerj/orgs","repos_url":"https://api.github.com/users/sinkillerj/repos","events_url":"https://api.github.com/users/sinkillerj/events{/privacy}","received_events_url":"https://api.github.com/users/sinkillerj/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":7,"additions":547,"deletions":149,"changed_files":8}}