{"action":"created","comment":{"url":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/comments/40785225","id":40785225,"diff_hunk":"@@ -18,9 +18,9 @@ CONST.HOVER_PSEUDO_CLASS_ATTR = 'data-hammerhead-hovered';\n \n CONST.DOCUMENT_CHARSET = 'hammerhead|document-charset';\n \n-CONST.XHR_CORS_SUPPORTED_FLAG   = 0x10;\n-CONST.XHR_REQUEST_MARKER_HEADER = 'hammerhead|xhr-request-marker-header';\n-CONST.XHR_WITH_CREDENTIALS_FLAG = 0x01;\n+CONST.XHR_REQUEST_MARKER_HEADER   = 'hammerhead|xhr-request-marker-header';\n+CONST.XHR_CORS_SUPPORTED_HEADER   = 'hammerhead|xhr-cors-supported-header';\n+CONST.XHR_WITH_CREDENTIALS_HEADER = 'hammerhead|xhr-with-credentials-header';","path":"src/const.js","position":9,"original_position":9,"commit_id":"615fa57d1ec80b71084bf2f8baa6e2df39569f22","original_commit_id":"615fa57d1ec80b71084bf2f8baa6e2df39569f22","user":{"login":"inikulin","id":453071,"avatar_url":"https://avatars.githubusercontent.com/u/453071?v=3","gravatar_id":"","url":"https://api.github.com/users/inikulin","html_url":"https://github.com/inikulin","followers_url":"https://api.github.com/users/inikulin/followers","following_url":"https://api.github.com/users/inikulin/following{/other_user}","gists_url":"https://api.github.com/users/inikulin/gists{/gist_id}","starred_url":"https://api.github.com/users/inikulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inikulin/subscriptions","organizations_url":"https://api.github.com/users/inikulin/orgs","repos_url":"https://api.github.com/users/inikulin/repos","events_url":"https://api.github.com/users/inikulin/events{/privacy}","received_events_url":"https://api.github.com/users/inikulin/received_events","type":"User","site_admin":false},"body":"We can definitely move it from here as a part of #68. I suggest creating new dir `src/pipeline/xhr` and move there `same-origin-policy.js` and this constants in `headers.js`.","created_at":"2015-09-30T12:00:30Z","updated_at":"2015-09-30T12:00:30Z","html_url":"https://github.com/superroma/testcafe-hammerhead/pull/142#discussion_r40785225","pull_request_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/142","_links":{"self":{"href":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/comments/40785225"},"html":{"href":"https://github.com/superroma/testcafe-hammerhead/pull/142#discussion_r40785225"},"pull_request":{"href":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/142"}}},"pull_request":{"url":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/142","id":46391537,"html_url":"https://github.com/superroma/testcafe-hammerhead/pull/142","diff_url":"https://github.com/superroma/testcafe-hammerhead/pull/142.diff","patch_url":"https://github.com/superroma/testcafe-hammerhead/pull/142.patch","issue_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/issues/142","number":142,"state":"open","locked":false,"title":"Use separate headers instead of binary flags in the xhr sandbox (close #122)","user":{"login":"churkin","id":5182202,"avatar_url":"https://avatars.githubusercontent.com/u/5182202?v=3","gravatar_id":"","url":"https://api.github.com/users/churkin","html_url":"https://github.com/churkin","followers_url":"https://api.github.com/users/churkin/followers","following_url":"https://api.github.com/users/churkin/following{/other_user}","gists_url":"https://api.github.com/users/churkin/gists{/gist_id}","starred_url":"https://api.github.com/users/churkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/churkin/subscriptions","organizations_url":"https://api.github.com/users/churkin/orgs","repos_url":"https://api.github.com/users/churkin/repos","events_url":"https://api.github.com/users/churkin/events{/privacy}","received_events_url":"https://api.github.com/users/churkin/received_events","type":"User","site_admin":false},"body":"\\сс @inikulin @miherlosev ","created_at":"2015-09-30T11:47:33Z","updated_at":"2015-09-30T12:00:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d339d9db74847f4bf43fd9b1f69d5d428ed20c08","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/142/commits","review_comments_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/142/comments","review_comment_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/comments{/number}","comments_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/issues/142/comments","statuses_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/statuses/615fa57d1ec80b71084bf2f8baa6e2df39569f22","head":{"label":"churkin:i122","ref":"i122","sha":"615fa57d1ec80b71084bf2f8baa6e2df39569f22","user":{"login":"churkin","id":5182202,"avatar_url":"https://avatars.githubusercontent.com/u/5182202?v=3","gravatar_id":"","url":"https://api.github.com/users/churkin","html_url":"https://github.com/churkin","followers_url":"https://api.github.com/users/churkin/followers","following_url":"https://api.github.com/users/churkin/following{/other_user}","gists_url":"https://api.github.com/users/churkin/gists{/gist_id}","starred_url":"https://api.github.com/users/churkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/churkin/subscriptions","organizations_url":"https://api.github.com/users/churkin/orgs","repos_url":"https://api.github.com/users/churkin/repos","events_url":"https://api.github.com/users/churkin/events{/privacy}","received_events_url":"https://api.github.com/users/churkin/received_events","type":"User","site_admin":false},"repo":{"id":39562496,"name":"testcafe-hammerhead","full_name":"churkin/testcafe-hammerhead","owner":{"login":"churkin","id":5182202,"avatar_url":"https://avatars.githubusercontent.com/u/5182202?v=3","gravatar_id":"","url":"https://api.github.com/users/churkin","html_url":"https://github.com/churkin","followers_url":"https://api.github.com/users/churkin/followers","following_url":"https://api.github.com/users/churkin/following{/other_user}","gists_url":"https://api.github.com/users/churkin/gists{/gist_id}","starred_url":"https://api.github.com/users/churkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/churkin/subscriptions","organizations_url":"https://api.github.com/users/churkin/orgs","repos_url":"https://api.github.com/users/churkin/repos","events_url":"https://api.github.com/users/churkin/events{/privacy}","received_events_url":"https://api.github.com/users/churkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/churkin/testcafe-hammerhead","description":"","fork":true,"url":"https://api.github.com/repos/churkin/testcafe-hammerhead","forks_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/forks","keys_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/keys{/key_id}","collaborators_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/teams","hooks_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/hooks","issue_events_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/issues/events{/number}","events_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/events","assignees_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/assignees{/user}","branches_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/branches{/branch}","tags_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/tags","blobs_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/git/refs{/sha}","trees_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/git/trees{/sha}","statuses_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/statuses/{sha}","languages_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/languages","stargazers_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/stargazers","contributors_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/contributors","subscribers_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/subscribers","subscription_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/subscription","commits_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/commits{/sha}","git_commits_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/git/commits{/sha}","comments_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/comments{/number}","issue_comment_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/issues/comments{/number}","contents_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/contents/{+path}","compare_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/compare/{base}...{head}","merges_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/merges","archive_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/downloads","issues_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/issues{/number}","pulls_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/pulls{/number}","milestones_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/milestones{/number}","notifications_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/labels{/name}","releases_url":"https://api.github.com/repos/churkin/testcafe-hammerhead/releases{/id}","created_at":"2015-07-23T11:03:55Z","updated_at":"2015-07-24T11:26:01Z","pushed_at":"2015-09-30T11:46:23Z","git_url":"git://github.com/churkin/testcafe-hammerhead.git","ssh_url":"git@github.com:churkin/testcafe-hammerhead.git","clone_url":"https://github.com/churkin/testcafe-hammerhead.git","svn_url":"https://github.com/churkin/testcafe-hammerhead","homepage":null,"size":1547,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"superroma:master","ref":"master","sha":"11fbf44d7a920c9fc3ddd00ac7e52fa2cf604257","user":{"login":"superroma","id":8553464,"avatar_url":"https://avatars.githubusercontent.com/u/8553464?v=3","gravatar_id":"","url":"https://api.github.com/users/superroma","html_url":"https://github.com/superroma","followers_url":"https://api.github.com/users/superroma/followers","following_url":"https://api.github.com/users/superroma/following{/other_user}","gists_url":"https://api.github.com/users/superroma/gists{/gist_id}","starred_url":"https://api.github.com/users/superroma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superroma/subscriptions","organizations_url":"https://api.github.com/users/superroma/orgs","repos_url":"https://api.github.com/users/superroma/repos","events_url":"https://api.github.com/users/superroma/events{/privacy}","received_events_url":"https://api.github.com/users/superroma/received_events","type":"User","site_admin":false},"repo":{"id":36883823,"name":"testcafe-hammerhead","full_name":"superroma/testcafe-hammerhead","owner":{"login":"superroma","id":8553464,"avatar_url":"https://avatars.githubusercontent.com/u/8553464?v=3","gravatar_id":"","url":"https://api.github.com/users/superroma","html_url":"https://github.com/superroma","followers_url":"https://api.github.com/users/superroma/followers","following_url":"https://api.github.com/users/superroma/following{/other_user}","gists_url":"https://api.github.com/users/superroma/gists{/gist_id}","starred_url":"https://api.github.com/users/superroma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superroma/subscriptions","organizations_url":"https://api.github.com/users/superroma/orgs","repos_url":"https://api.github.com/users/superroma/repos","events_url":"https://api.github.com/users/superroma/events{/privacy}","received_events_url":"https://api.github.com/users/superroma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/superroma/testcafe-hammerhead","description":"","fork":false,"url":"https://api.github.com/repos/superroma/testcafe-hammerhead","forks_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/forks","keys_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/keys{/key_id}","collaborators_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/teams","hooks_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/hooks","issue_events_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/issues/events{/number}","events_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/events","assignees_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/assignees{/user}","branches_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/branches{/branch}","tags_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/tags","blobs_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/git/refs{/sha}","trees_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/git/trees{/sha}","statuses_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/statuses/{sha}","languages_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/languages","stargazers_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/stargazers","contributors_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/contributors","subscribers_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/subscribers","subscription_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/subscription","commits_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/commits{/sha}","git_commits_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/git/commits{/sha}","comments_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/comments{/number}","issue_comment_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/issues/comments{/number}","contents_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/contents/{+path}","compare_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/compare/{base}...{head}","merges_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/merges","archive_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/downloads","issues_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/issues{/number}","pulls_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls{/number}","milestones_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/milestones{/number}","notifications_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/labels{/name}","releases_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/releases{/id}","created_at":"2015-06-04T16:56:53Z","updated_at":"2015-09-18T08:51:50Z","pushed_at":"2015-09-30T11:47:33Z","git_url":"git://github.com/superroma/testcafe-hammerhead.git","ssh_url":"git@github.com:superroma/testcafe-hammerhead.git","clone_url":"https://github.com/superroma/testcafe-hammerhead.git","svn_url":"https://github.com/superroma/testcafe-hammerhead","homepage":null,"size":1807,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":37,"forks":9,"open_issues":37,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/142"},"html":{"href":"https://github.com/superroma/testcafe-hammerhead/pull/142"},"issue":{"href":"https://api.github.com/repos/superroma/testcafe-hammerhead/issues/142"},"comments":{"href":"https://api.github.com/repos/superroma/testcafe-hammerhead/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/superroma/testcafe-hammerhead/statuses/615fa57d1ec80b71084bf2f8baa6e2df39569f22"}}}}