{"action":"created","issue":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/3603","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/3603/labels{/name}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/3603/comments","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/3603/events","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/3603","id":72414659,"number":3603,"title":"Implement Comments infinite scroll","user":{"login":"SergioEstevao","id":651601,"avatar_url":"https://avatars.githubusercontent.com/u/651601?v=3","gravatar_id":"","url":"https://api.github.com/users/SergioEstevao","html_url":"https://github.com/SergioEstevao","followers_url":"https://api.github.com/users/SergioEstevao/followers","following_url":"https://api.github.com/users/SergioEstevao/following{/other_user}","gists_url":"https://api.github.com/users/SergioEstevao/gists{/gist_id}","starred_url":"https://api.github.com/users/SergioEstevao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergioEstevao/subscriptions","organizations_url":"https://api.github.com/users/SergioEstevao/orgs","repos_url":"https://api.github.com/users/SergioEstevao/repos","events_url":"https://api.github.com/users/SergioEstevao/events{/privacy}","received_events_url":"https://api.github.com/users/SergioEstevao/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/labels/review","name":"review","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/milestones/39","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/milestones/5.2","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/milestones/39/labels","id":1065334,"number":39,"title":"5.2","description":"","creator":{"login":"aerych","id":1435271,"avatar_url":"https://avatars.githubusercontent.com/u/1435271?v=3","gravatar_id":"","url":"https://api.github.com/users/aerych","html_url":"https://github.com/aerych","followers_url":"https://api.github.com/users/aerych/followers","following_url":"https://api.github.com/users/aerych/following{/other_user}","gists_url":"https://api.github.com/users/aerych/gists{/gist_id}","starred_url":"https://api.github.com/users/aerych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerych/subscriptions","organizations_url":"https://api.github.com/users/aerych/orgs","repos_url":"https://api.github.com/users/aerych/repos","events_url":"https://api.github.com/users/aerych/events{/privacy}","received_events_url":"https://api.github.com/users/aerych/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":22,"state":"open","created_at":"2015-04-13T15:51:41Z","updated_at":"2015-05-01T20:22:52Z","due_on":"2015-05-11T05:00:00Z","closed_at":null},"comments":6,"created_at":"2015-05-01T11:39:48Z","updated_at":"2015-05-04T08:52:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/3603","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/3603","diff_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/3603.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/3603.patch"},"body":"Closes #2925 \r\n\r\ncc @aerych and @koke can you please review\r\n\r\nI implemented this feature based on the behaviour implements on Posts. While doing this I struggle with some things:\r\n\r\n * Do the blog properties isSyncingPosts, isSyncingPages, isSyncingComments, isSyncingMedia ever being accessed somewhere in the code? I searched but couldn't find a place where they are being changed.Was this something that was used before and didn't got deleted? Or something that was added but not used yet?\r\n * The same for hasOlderPosts, hasOlderPages\r\n\r\nThe PR don't need this properties but I wanted to now if this is something that needs to be fixed/implemented."},"comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/comments/98639791","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/3603#issuecomment-98639791","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/3603","id":98639791,"user":{"login":"koke","id":8739,"avatar_url":"https://avatars.githubusercontent.com/u/8739?v=3","gravatar_id":"","url":"https://api.github.com/users/koke","html_url":"https://github.com/koke","followers_url":"https://api.github.com/users/koke/followers","following_url":"https://api.github.com/users/koke/following{/other_user}","gists_url":"https://api.github.com/users/koke/gists{/gist_id}","starred_url":"https://api.github.com/users/koke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koke/subscriptions","organizations_url":"https://api.github.com/users/koke/orgs","repos_url":"https://api.github.com/users/koke/repos","events_url":"https://api.github.com/users/koke/events{/privacy}","received_events_url":"https://api.github.com/users/koke/received_events","type":"User","site_admin":false},"created_at":"2015-05-04T08:52:13Z","updated_at":"2015-05-04T08:52:13Z","body":"About the `isSyncing*` properties, they were used in the past, but maybe not anymore? The purpose was not to handle the activity indicator, but to prevent two syncs happening at once, as it could have weird side effects, like:\r\n- Open a comment\r\n- Trash/Spam that comment, a request is sent and the comment is deleted locally\r\n- Pop back to the comments list, that triggers a refresh\r\n- The sync call finishes before the trash call\r\n- The deleted comment reappears\r\n\r\nI agree that this locking shouldn't be in the model, and I think it got removed when we moved to the Service classes. Since those are disposable, it didn't seem like a good place to move it."}}