{"action":"created","issue":{"url":"https://api.github.com/repos/Chorus/chorus/issues/79","labels_url":"https://api.github.com/repos/Chorus/chorus/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/Chorus/chorus/issues/79/comments","events_url":"https://api.github.com/repos/Chorus/chorus/issues/79/events","html_url":"https://github.com/Chorus/chorus/pull/79","id":94851666,"number":79,"title":"DEV-11396: Display job creation/deletion in workspace activity stream","user":{"login":"kevin-alpine","id":12001313,"avatar_url":"https://avatars.githubusercontent.com/u/12001313?v=3","gravatar_id":"","url":"https://api.github.com/users/kevin-alpine","html_url":"https://github.com/kevin-alpine","followers_url":"https://api.github.com/users/kevin-alpine/followers","following_url":"https://api.github.com/users/kevin-alpine/following{/other_user}","gists_url":"https://api.github.com/users/kevin-alpine/gists{/gist_id}","starred_url":"https://api.github.com/users/kevin-alpine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevin-alpine/subscriptions","organizations_url":"https://api.github.com/users/kevin-alpine/orgs","repos_url":"https://api.github.com/users/kevin-alpine/repos","events_url":"https://api.github.com/users/kevin-alpine/events{/privacy}","received_events_url":"https://api.github.com/users/kevin-alpine/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Chorus/chorus/labels/Reviewed:%20LGTM","name":"Reviewed: LGTM","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-07-14T02:10:36Z","updated_at":"2015-07-16T04:27:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Chorus/chorus/pulls/79","html_url":"https://github.com/Chorus/chorus/pull/79","diff_url":"https://github.com/Chorus/chorus/pull/79.diff","patch_url":"https://github.com/Chorus/chorus/pull/79.patch"},"body":"This is a medium feature, it touches the entire stack, but it is very vertically specialized.\r\n\r\nIt's very similar to #80.\r\n\r\nSee original ticket here: https://alpine.atlassian.net/browse/DEV-11396"},"comment":{"url":"https://api.github.com/repos/Chorus/chorus/issues/comments/121825822","html_url":"https://github.com/Chorus/chorus/pull/79#issuecomment-121825822","issue_url":"https://api.github.com/repos/Chorus/chorus/issues/79","id":121825822,"user":{"login":"atul-alpine","id":12968995,"avatar_url":"https://avatars.githubusercontent.com/u/12968995?v=3","gravatar_id":"","url":"https://api.github.com/users/atul-alpine","html_url":"https://github.com/atul-alpine","followers_url":"https://api.github.com/users/atul-alpine/followers","following_url":"https://api.github.com/users/atul-alpine/following{/other_user}","gists_url":"https://api.github.com/users/atul-alpine/gists{/gist_id}","starred_url":"https://api.github.com/users/atul-alpine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atul-alpine/subscriptions","organizations_url":"https://api.github.com/users/atul-alpine/orgs","repos_url":"https://api.github.com/users/atul-alpine/repos","events_url":"https://api.github.com/users/atul-alpine/events{/privacy}","received_events_url":"https://api.github.com/users/atul-alpine/received_events","type":"User","site_admin":false},"created_at":"2015-07-16T04:27:43Z","updated_at":"2015-07-16T04:27:43Z","body":"Hey Kevin!\n\nThanks for insightful comments. I am learning a lot from it. You are right\nthe cost of finding those bugs earlier in the cycle is way better and if\nthat costs us some more work at database side then its justified since\neffort is only of 2 people and not lot of people once bug gets filed and it\ngoes through the cycle of tracking fixing, reviewing and re-testing,\nupdating Jira etc!\n\nAwesome! thanks for the inputs. Will improve upon the suggestions!\n\n-Atul\n\n\nOn Thu, Jul 16, 2015 at 2:40 AM, kevin-alpine <notifications@github.com>\nwrote:\n\n> As a result of dividing these commits I faced some problems in testing the\n> changes.\n>\n> I absolutely understand that there's additional overhead in dividing up\n> your single branch, into 4. But, as a result of divvying them up and\n> reviewing them, we have discovered >=5 issues:\n>\n>    - In #77 <https://github.com/Chorus/chorus/pull/77> we discovered the\n>    leftover localization string help_n_support\n>    - In #78 <https://github.com/Chorus/chorus/pull/78> we discovered the\n>    inconsistencies between the new and existing notifications: one is bolded\n>    and one is not. Also, Michael gave us good feedback on the naming of the\n>    keys.\n>    - In this one #79 <https://github.com/Chorus/chorus/pull/79> we've\n>    discovered two broken Jasmine tests and a bug in the way the new activity\n>    feed was being displayed on the app's dashboard.\n>    - I have yet to review #80 <https://github.com/Chorus/chorus/pull/80>\n>    but I imagine we'll find some things there.\n>\n> And this is totally expected! I have almost never submitted a PR that\n> hasn't benefitted from peer review. But some of these things would have\n> come up again for sure either via another bug, or failing Jasmine tests in\n> the CI build.\n>\n> The Chorus code is difficult to work with, and we are trying to turn the\n> ship around. That's why we have to be careful: each PR that we merge in has\n> to either keep the code quality the same, or improve it.\n>\n> (I do think that #79 <https://github.com/Chorus/chorus/pull/79> and #80\n> <https://github.com/Chorus/chorus/pull/80> could have been done in a\n> single branch. But we're both new to this codebase so I took the\n> conservative routing of dividing them.)\n>\n> Issue is Database has no idea of what is going on (separate PRs etc) so it\n> becomes inconsistent and we start to see all sorts of different errors.\n>\n> I totally understand this is awkward, but we need to be able to deal with\n> getting our development database into the state it needs to be to do\n> precise, small, pieces of work.\n>\n> What I did was to rake db:drop db:create db:migrate and then reload the\n> dev database Prakash gave me, via this command ./postgres/bin/psql -p8543\n> -h127.0.0.1 -d chorus_rails_development -f chorus_db.sql. Later when I\n> understood more what was going wrong, I deleted the non-existent Single\n> Table Inheritance Event types from the database using the Rubymine database\n> GUI.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/Chorus/chorus/pull/79#issuecomment-121748537>.\n>\n\n\n\n-- \nRegards,\nAtul Veer.\n"}}