{"action":"created","issue":{"url":"https://api.github.com/repos/neillturner/cfndsl_examples/issues/1","labels_url":"https://api.github.com/repos/neillturner/cfndsl_examples/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/neillturner/cfndsl_examples/issues/1/comments","events_url":"https://api.github.com/repos/neillturner/cfndsl_examples/issues/1/events","html_url":"https://github.com/neillturner/cfndsl_examples/issues/1","id":93707660,"number":1,"title":"Running cfndsl on the example files","user":{"login":"yumpy","id":1904586,"avatar_url":"https://avatars.githubusercontent.com/u/1904586?v=3","gravatar_id":"","url":"https://api.github.com/users/yumpy","html_url":"https://github.com/yumpy","followers_url":"https://api.github.com/users/yumpy/followers","following_url":"https://api.github.com/users/yumpy/following{/other_user}","gists_url":"https://api.github.com/users/yumpy/gists{/gist_id}","starred_url":"https://api.github.com/users/yumpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yumpy/subscriptions","organizations_url":"https://api.github.com/users/yumpy/orgs","repos_url":"https://api.github.com/users/yumpy/repos","events_url":"https://api.github.com/users/yumpy/events{/privacy}","received_events_url":"https://api.github.com/users/yumpy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-08T06:25:28Z","updated_at":"2015-07-08T07:25:14Z","closed_at":null,"body":"Neil, you've done a great job in converting the sample json templates using cfn2dsl. I think files would be a good basis for a comprehensive test suite for cfndsl. \r\n\r\nI note that the original source json templates from AWS are not in a 100% valid format for stack deployment as they contain many unresolved references. This means that the example cfndsl files also have these unresolved references and cfndsl cannot be used to generate the CF json template.\r\n\r\nI took a copy of \"EC2instance.rb\" and replaced the unresolved references with either a string or with a reference to another resource that is defined in the same cfndsl file. This seemed to do the trick but this means that the generated json file does not 100% match the original json file.\r\n\r\nJust wondering if you had any thoughts on how to tidy up the original json template snippets?\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/neillturner/cfndsl_examples/issues/comments/119467819","html_url":"https://github.com/neillturner/cfndsl_examples/issues/1#issuecomment-119467819","issue_url":"https://api.github.com/repos/neillturner/cfndsl_examples/issues/1","id":119467819,"user":{"login":"neillturner","id":408419,"avatar_url":"https://avatars.githubusercontent.com/u/408419?v=3","gravatar_id":"","url":"https://api.github.com/users/neillturner","html_url":"https://github.com/neillturner","followers_url":"https://api.github.com/users/neillturner/followers","following_url":"https://api.github.com/users/neillturner/following{/other_user}","gists_url":"https://api.github.com/users/neillturner/gists{/gist_id}","starred_url":"https://api.github.com/users/neillturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neillturner/subscriptions","organizations_url":"https://api.github.com/users/neillturner/orgs","repos_url":"https://api.github.com/users/neillturner/repos","events_url":"https://api.github.com/users/neillturner/events{/privacy}","received_events_url":"https://api.github.com/users/neillturner/received_events","type":"User","site_admin":false},"created_at":"2015-07-08T07:25:14Z","updated_at":"2015-07-08T07:25:14Z","body":"all good thoughts. Currently i going to add a whole lots more AWS sample cloudformation templates. \r\nI guess i created them for myself to help me in development.   "}}