{"action":"closed","number":6019,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/6019","id":26537025,"html_url":"https://github.com/xbmc/xbmc/pull/6019","diff_url":"https://github.com/xbmc/xbmc/pull/6019.diff","patch_url":"https://github.com/xbmc/xbmc/pull/6019.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/6019","number":6019,"state":"closed","locked":false,"title":"videodb: avoid an empty entry in string arrays","user":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"body":"When working on my media import stuff I noticed that we fill in `std::vector<std::string>` members of `CVideoInfoTag` with an empty string element instead of nothing if the value of the members is empty. So if we retrieve a movie without any genres the result will be that `CVideoInfoTag::m_genre` will contain a single empty string in the vector instead of simply being empty.\r\n\r\nI've been using this since the very beginning of my media import work and haven't seen any fallout but it's very difficult to determine if something is relying on the vector not being empty.","created_at":"2014-12-23T23:02:14Z","updated_at":"2015-01-07T07:59:33Z","closed_at":"2015-01-07T07:59:33Z","merged_at":"2015-01-07T07:59:33Z","merge_commit_sha":"b7e413e6066c21a4211012708aaedec4bd0eeb58","assignee":null,"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/56","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/56/labels","id":903185,"number":56,"title":"Helix 15.0-alpha1","description":"","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars.githubusercontent.com/u/907436?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":105,"state":"open","created_at":"2014-12-14T13:42:20Z","updated_at":"2015-01-07T07:59:33Z","due_on":"2015-01-30T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/6019/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/6019/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/6019/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/472eb31614924765a36c28c39c89b02d3f392fec","head":{"label":"Montellese:videodb_avoid_empty_string_arrays","ref":"videodb_avoid_empty_string_arrays","sha":"472eb31614924765a36c28c39c89b02d3f392fec","user":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"repo":{"id":1287028,"name":"xbmc","full_name":"Montellese/xbmc","owner":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Montellese/xbmc","description":"Montellese's fork of XBMC ","fork":true,"url":"https://api.github.com/repos/Montellese/xbmc","forks_url":"https://api.github.com/repos/Montellese/xbmc/forks","keys_url":"https://api.github.com/repos/Montellese/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Montellese/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Montellese/xbmc/teams","hooks_url":"https://api.github.com/repos/Montellese/xbmc/hooks","issue_events_url":"https://api.github.com/repos/Montellese/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/Montellese/xbmc/events","assignees_url":"https://api.github.com/repos/Montellese/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/Montellese/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/Montellese/xbmc/tags","blobs_url":"https://api.github.com/repos/Montellese/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Montellese/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Montellese/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Montellese/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Montellese/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/Montellese/xbmc/languages","stargazers_url":"https://api.github.com/repos/Montellese/xbmc/stargazers","contributors_url":"https://api.github.com/repos/Montellese/xbmc/contributors","subscribers_url":"https://api.github.com/repos/Montellese/xbmc/subscribers","subscription_url":"https://api.github.com/repos/Montellese/xbmc/subscription","commits_url":"https://api.github.com/repos/Montellese/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Montellese/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Montellese/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Montellese/xbmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/Montellese/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/Montellese/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Montellese/xbmc/merges","archive_url":"https://api.github.com/repos/Montellese/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Montellese/xbmc/downloads","issues_url":"https://api.github.com/repos/Montellese/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/Montellese/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/Montellese/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/Montellese/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Montellese/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/Montellese/xbmc/releases{/id}","created_at":"2011-01-24T08:36:12Z","updated_at":"2015-01-06T13:05:54Z","pushed_at":"2015-01-07T07:57:57Z","git_url":"git://github.com/Montellese/xbmc.git","ssh_url":"git@github.com:Montellese/xbmc.git","clone_url":"https://github.com/Montellese/xbmc.git","svn_url":"https://github.com/Montellese/xbmc","homepage":"http://xbmc.org","size":492050,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":4,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"a5fd3370e7c077f7761e101124599818e38b2189","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-01-07T07:55:25Z","pushed_at":"2015-01-07T07:59:33Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1797733,"stargazers_count":3592,"watchers_count":3592,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2581,"mirror_url":null,"open_issues_count":231,"forks":2581,"open_issues":231,"watchers":3592,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/6019"},"html":{"href":"https://github.com/xbmc/xbmc/pull/6019"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/6019"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/6019/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/6019/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/6019/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/472eb31614924765a36c28c39c89b02d3f392fec"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":1,"changed_files":1}}