{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/amitkgupta/flannel/pulls/1","id":52054862,"html_url":"https://github.com/amitkgupta/flannel/pull/1","diff_url":"https://github.com/amitkgupta/flannel/pull/1.diff","patch_url":"https://github.com/amitkgupta/flannel/pull/1.patch","issue_url":"https://api.github.com/repos/amitkgupta/flannel/issues/1","number":1,"state":"closed","locked":false,"title":"subnet: fix SubnetMax calculation when parsing config","user":{"login":"amitkgupta","id":1580649,"avatar_url":"https://avatars.githubusercontent.com/u/1580649?v=3","gravatar_id":"","url":"https://api.github.com/users/amitkgupta","html_url":"https://github.com/amitkgupta","followers_url":"https://api.github.com/users/amitkgupta/followers","following_url":"https://api.github.com/users/amitkgupta/following{/other_user}","gists_url":"https://api.github.com/users/amitkgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/amitkgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitkgupta/subscriptions","organizations_url":"https://api.github.com/users/amitkgupta/orgs","repos_url":"https://api.github.com/users/amitkgupta/repos","events_url":"https://api.github.com/users/amitkgupta/events{/privacy}","received_events_url":"https://api.github.com/users/amitkgupta/received_events","type":"User","site_admin":false},"body":"Given a /24 subnet I see:\r\n\"Picking subnet in range 10.244.8.128 ... 10.244.8.128\"\r\n\"Failed to acquire subnet: out of subnets\"\r\nThe SubnetMax calculation looks wrong, fixed it.\r\n\r\nI could not add or run tests, because I'm on a Mac, and\r\nam hitting: https://github.com/vishvananda/netlink/issues/17","created_at":"2015-11-29T04:48:28Z","updated_at":"2015-11-29T05:25:23Z","closed_at":"2015-11-29T05:25:23Z","merged_at":null,"merge_commit_sha":"53befcf3e8390d45c6b3ed46dc120d3a3017a687","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amitkgupta/flannel/pulls/1/commits","review_comments_url":"https://api.github.com/repos/amitkgupta/flannel/pulls/1/comments","review_comment_url":"https://api.github.com/repos/amitkgupta/flannel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amitkgupta/flannel/issues/1/comments","statuses_url":"https://api.github.com/repos/amitkgupta/flannel/statuses/dab70b49d44772861cbeca306c44880d5d216a08","head":{"label":"amitkgupta:fix-subnet-config","ref":"fix-subnet-config","sha":"dab70b49d44772861cbeca306c44880d5d216a08","user":{"login":"amitkgupta","id":1580649,"avatar_url":"https://avatars.githubusercontent.com/u/1580649?v=3","gravatar_id":"","url":"https://api.github.com/users/amitkgupta","html_url":"https://github.com/amitkgupta","followers_url":"https://api.github.com/users/amitkgupta/followers","following_url":"https://api.github.com/users/amitkgupta/following{/other_user}","gists_url":"https://api.github.com/users/amitkgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/amitkgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitkgupta/subscriptions","organizations_url":"https://api.github.com/users/amitkgupta/orgs","repos_url":"https://api.github.com/users/amitkgupta/repos","events_url":"https://api.github.com/users/amitkgupta/events{/privacy}","received_events_url":"https://api.github.com/users/amitkgupta/received_events","type":"User","site_admin":false},"repo":{"id":47050218,"name":"flannel","full_name":"amitkgupta/flannel","owner":{"login":"amitkgupta","id":1580649,"avatar_url":"https://avatars.githubusercontent.com/u/1580649?v=3","gravatar_id":"","url":"https://api.github.com/users/amitkgupta","html_url":"https://github.com/amitkgupta","followers_url":"https://api.github.com/users/amitkgupta/followers","following_url":"https://api.github.com/users/amitkgupta/following{/other_user}","gists_url":"https://api.github.com/users/amitkgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/amitkgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitkgupta/subscriptions","organizations_url":"https://api.github.com/users/amitkgupta/orgs","repos_url":"https://api.github.com/users/amitkgupta/repos","events_url":"https://api.github.com/users/amitkgupta/events{/privacy}","received_events_url":"https://api.github.com/users/amitkgupta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amitkgupta/flannel","description":"flannel is an etcd backed network fabric for containers","fork":true,"url":"https://api.github.com/repos/amitkgupta/flannel","forks_url":"https://api.github.com/repos/amitkgupta/flannel/forks","keys_url":"https://api.github.com/repos/amitkgupta/flannel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amitkgupta/flannel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amitkgupta/flannel/teams","hooks_url":"https://api.github.com/repos/amitkgupta/flannel/hooks","issue_events_url":"https://api.github.com/repos/amitkgupta/flannel/issues/events{/number}","events_url":"https://api.github.com/repos/amitkgupta/flannel/events","assignees_url":"https://api.github.com/repos/amitkgupta/flannel/assignees{/user}","branches_url":"https://api.github.com/repos/amitkgupta/flannel/branches{/branch}","tags_url":"https://api.github.com/repos/amitkgupta/flannel/tags","blobs_url":"https://api.github.com/repos/amitkgupta/flannel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amitkgupta/flannel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amitkgupta/flannel/git/refs{/sha}","trees_url":"https://api.github.com/repos/amitkgupta/flannel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amitkgupta/flannel/statuses/{sha}","languages_url":"https://api.github.com/repos/amitkgupta/flannel/languages","stargazers_url":"https://api.github.com/repos/amitkgupta/flannel/stargazers","contributors_url":"https://api.github.com/repos/amitkgupta/flannel/contributors","subscribers_url":"https://api.github.com/repos/amitkgupta/flannel/subscribers","subscription_url":"https://api.github.com/repos/amitkgupta/flannel/subscription","commits_url":"https://api.github.com/repos/amitkgupta/flannel/commits{/sha}","git_commits_url":"https://api.github.com/repos/amitkgupta/flannel/git/commits{/sha}","comments_url":"https://api.github.com/repos/amitkgupta/flannel/comments{/number}","issue_comment_url":"https://api.github.com/repos/amitkgupta/flannel/issues/comments{/number}","contents_url":"https://api.github.com/repos/amitkgupta/flannel/contents/{+path}","compare_url":"https://api.github.com/repos/amitkgupta/flannel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amitkgupta/flannel/merges","archive_url":"https://api.github.com/repos/amitkgupta/flannel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amitkgupta/flannel/downloads","issues_url":"https://api.github.com/repos/amitkgupta/flannel/issues{/number}","pulls_url":"https://api.github.com/repos/amitkgupta/flannel/pulls{/number}","milestones_url":"https://api.github.com/repos/amitkgupta/flannel/milestones{/number}","notifications_url":"https://api.github.com/repos/amitkgupta/flannel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amitkgupta/flannel/labels{/name}","releases_url":"https://api.github.com/repos/amitkgupta/flannel/releases{/id}","created_at":"2015-11-29T04:42:32Z","updated_at":"2015-11-29T04:42:33Z","pushed_at":"2015-11-29T04:48:28Z","git_url":"git://github.com/amitkgupta/flannel.git","ssh_url":"git@github.com:amitkgupta/flannel.git","clone_url":"https://github.com/amitkgupta/flannel.git","svn_url":"https://github.com/amitkgupta/flannel","homepage":"","size":4221,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amitkgupta:master","ref":"master","sha":"59c71646a9e76e07ed50c66f8d453a1800127590","user":{"login":"amitkgupta","id":1580649,"avatar_url":"https://avatars.githubusercontent.com/u/1580649?v=3","gravatar_id":"","url":"https://api.github.com/users/amitkgupta","html_url":"https://github.com/amitkgupta","followers_url":"https://api.github.com/users/amitkgupta/followers","following_url":"https://api.github.com/users/amitkgupta/following{/other_user}","gists_url":"https://api.github.com/users/amitkgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/amitkgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitkgupta/subscriptions","organizations_url":"https://api.github.com/users/amitkgupta/orgs","repos_url":"https://api.github.com/users/amitkgupta/repos","events_url":"https://api.github.com/users/amitkgupta/events{/privacy}","received_events_url":"https://api.github.com/users/amitkgupta/received_events","type":"User","site_admin":false},"repo":{"id":47050218,"name":"flannel","full_name":"amitkgupta/flannel","owner":{"login":"amitkgupta","id":1580649,"avatar_url":"https://avatars.githubusercontent.com/u/1580649?v=3","gravatar_id":"","url":"https://api.github.com/users/amitkgupta","html_url":"https://github.com/amitkgupta","followers_url":"https://api.github.com/users/amitkgupta/followers","following_url":"https://api.github.com/users/amitkgupta/following{/other_user}","gists_url":"https://api.github.com/users/amitkgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/amitkgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitkgupta/subscriptions","organizations_url":"https://api.github.com/users/amitkgupta/orgs","repos_url":"https://api.github.com/users/amitkgupta/repos","events_url":"https://api.github.com/users/amitkgupta/events{/privacy}","received_events_url":"https://api.github.com/users/amitkgupta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amitkgupta/flannel","description":"flannel is an etcd backed network fabric for containers","fork":true,"url":"https://api.github.com/repos/amitkgupta/flannel","forks_url":"https://api.github.com/repos/amitkgupta/flannel/forks","keys_url":"https://api.github.com/repos/amitkgupta/flannel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amitkgupta/flannel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amitkgupta/flannel/teams","hooks_url":"https://api.github.com/repos/amitkgupta/flannel/hooks","issue_events_url":"https://api.github.com/repos/amitkgupta/flannel/issues/events{/number}","events_url":"https://api.github.com/repos/amitkgupta/flannel/events","assignees_url":"https://api.github.com/repos/amitkgupta/flannel/assignees{/user}","branches_url":"https://api.github.com/repos/amitkgupta/flannel/branches{/branch}","tags_url":"https://api.github.com/repos/amitkgupta/flannel/tags","blobs_url":"https://api.github.com/repos/amitkgupta/flannel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amitkgupta/flannel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amitkgupta/flannel/git/refs{/sha}","trees_url":"https://api.github.com/repos/amitkgupta/flannel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amitkgupta/flannel/statuses/{sha}","languages_url":"https://api.github.com/repos/amitkgupta/flannel/languages","stargazers_url":"https://api.github.com/repos/amitkgupta/flannel/stargazers","contributors_url":"https://api.github.com/repos/amitkgupta/flannel/contributors","subscribers_url":"https://api.github.com/repos/amitkgupta/flannel/subscribers","subscription_url":"https://api.github.com/repos/amitkgupta/flannel/subscription","commits_url":"https://api.github.com/repos/amitkgupta/flannel/commits{/sha}","git_commits_url":"https://api.github.com/repos/amitkgupta/flannel/git/commits{/sha}","comments_url":"https://api.github.com/repos/amitkgupta/flannel/comments{/number}","issue_comment_url":"https://api.github.com/repos/amitkgupta/flannel/issues/comments{/number}","contents_url":"https://api.github.com/repos/amitkgupta/flannel/contents/{+path}","compare_url":"https://api.github.com/repos/amitkgupta/flannel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amitkgupta/flannel/merges","archive_url":"https://api.github.com/repos/amitkgupta/flannel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amitkgupta/flannel/downloads","issues_url":"https://api.github.com/repos/amitkgupta/flannel/issues{/number}","pulls_url":"https://api.github.com/repos/amitkgupta/flannel/pulls{/number}","milestones_url":"https://api.github.com/repos/amitkgupta/flannel/milestones{/number}","notifications_url":"https://api.github.com/repos/amitkgupta/flannel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amitkgupta/flannel/labels{/name}","releases_url":"https://api.github.com/repos/amitkgupta/flannel/releases{/id}","created_at":"2015-11-29T04:42:32Z","updated_at":"2015-11-29T04:42:33Z","pushed_at":"2015-11-29T04:48:28Z","git_url":"git://github.com/amitkgupta/flannel.git","ssh_url":"git@github.com:amitkgupta/flannel.git","clone_url":"https://github.com/amitkgupta/flannel.git","svn_url":"https://github.com/amitkgupta/flannel","homepage":"","size":4221,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amitkgupta/flannel/pulls/1"},"html":{"href":"https://github.com/amitkgupta/flannel/pull/1"},"issue":{"href":"https://api.github.com/repos/amitkgupta/flannel/issues/1"},"comments":{"href":"https://api.github.com/repos/amitkgupta/flannel/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/amitkgupta/flannel/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/amitkgupta/flannel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amitkgupta/flannel/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/amitkgupta/flannel/statuses/dab70b49d44772861cbeca306c44880d5d216a08"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}