{"action":"created","issue":{"url":"https://api.github.com/repos/influxdb/influxdb/issues/4731","labels_url":"https://api.github.com/repos/influxdb/influxdb/issues/4731/labels{/name}","comments_url":"https://api.github.com/repos/influxdb/influxdb/issues/4731/comments","events_url":"https://api.github.com/repos/influxdb/influxdb/issues/4731/events","html_url":"https://github.com/influxdb/influxdb/pull/4731","id":116016871,"number":4731,"title":"ShardGroups() supports returning all ShardGroups","user":{"login":"otoolep","id":536312,"avatar_url":"https://avatars.githubusercontent.com/u/536312?v=3","gravatar_id":"","url":"https://api.github.com/users/otoolep","html_url":"https://github.com/otoolep","followers_url":"https://api.github.com/users/otoolep/followers","following_url":"https://api.github.com/users/otoolep/following{/other_user}","gists_url":"https://api.github.com/users/otoolep/gists{/gist_id}","starred_url":"https://api.github.com/users/otoolep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otoolep/subscriptions","organizations_url":"https://api.github.com/users/otoolep/orgs","repos_url":"https://api.github.com/users/otoolep/repos","events_url":"https://api.github.com/users/otoolep/events{/privacy}","received_events_url":"https://api.github.com/users/otoolep/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/influxdb/influxdb/labels/2%20-%20Working","name":"2 - Working","color":"CCCCCC"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-11-10T03:16:48Z","updated_at":"2015-11-10T04:27:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/influxdb/influxdb/pulls/4731","html_url":"https://github.com/influxdb/influxdb/pull/4731","diff_url":"https://github.com/influxdb/influxdb/pull/4731.diff","patch_url":"https://github.com/influxdb/influxdb/pull/4731.patch"},"body":"With this change the function would support the following forms:\r\n```\r\nShardGroups()\r\nShardGroups(\"mydb\")\r\nShardGroups(\"mydb\", \"myrp\")\r\n```\r\n\r\nThis will make it easier to code stuff like `DROP SHARD GROUP`.\r\n"},"comment":{"url":"https://api.github.com/repos/influxdb/influxdb/issues/comments/155283144","html_url":"https://github.com/influxdb/influxdb/pull/4731#issuecomment-155283144","issue_url":"https://api.github.com/repos/influxdb/influxdb/issues/4731","id":155283144,"user":{"login":"otoolep","id":536312,"avatar_url":"https://avatars.githubusercontent.com/u/536312?v=3","gravatar_id":"","url":"https://api.github.com/users/otoolep","html_url":"https://github.com/otoolep","followers_url":"https://api.github.com/users/otoolep/followers","following_url":"https://api.github.com/users/otoolep/following{/other_user}","gists_url":"https://api.github.com/users/otoolep/gists{/gist_id}","starred_url":"https://api.github.com/users/otoolep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otoolep/subscriptions","organizations_url":"https://api.github.com/users/otoolep/orgs","repos_url":"https://api.github.com/users/otoolep/repos","events_url":"https://api.github.com/users/otoolep/events{/privacy}","received_events_url":"https://api.github.com/users/otoolep/received_events","type":"User","site_admin":false},"created_at":"2015-11-10T04:27:08Z","updated_at":"2015-11-10T04:27:08Z","body":"Yeah I did consider using \"\",\"\" as the params. I just like the vargs.\n\nOpen to consensus.\n\nOn Monday, November 9, 2015, dgnorton <notifications@github.com> wrote:\n\n> golang's builtins have spurred more than a few debates. :)\n>\n> ShardGroups could be written to accept empty strings for either parameter\n> and then AllShardGroups() could just callShardGroups(\"\", \"\")`.\n>\n> No strong feelings either way on this one function but I would be opposed\n> to widespread use of that style. I worked on some Go code, before InfluxDB,\n> that someone else wrote that used that style a lot. I found the code harder\n> to understand and had to fix a few bugs related to it.\n>\n> Whatever Cory & Ben vote works for me on this one though.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/influxdb/influxdb/pull/4731#issuecomment-155280341>.\n>\n"}}