{"action":"created","comment":{"url":"https://api.github.com/repos/scala/pickling/pulls/comments/32795469","id":32795469,"diff_hunk":"@@ -104,6 +104,9 @@ trait PBuilder extends Hintable {\n   /** Return the resulting pickle of this builder. */\n   def result(): Pickle\n }\n+/** Abstract shim for Java. */\n+abstract class AbtractPBuilder extends PBuilder with PickleTools","path":"core/src/main/scala/scala/pickling/PBuilderReader.scala","position":5,"original_position":5,"commit_id":"27c416cbef9f4e0a74c26cf26580ea964d605616","original_commit_id":"27c416cbef9f4e0a74c26cf26580ea964d605616","user":{"login":"retronym","id":65551,"avatar_url":"https://avatars.githubusercontent.com/u/65551?v=3","gravatar_id":"","url":"https://api.github.com/users/retronym","html_url":"https://github.com/retronym","followers_url":"https://api.github.com/users/retronym/followers","following_url":"https://api.github.com/users/retronym/following{/other_user}","gists_url":"https://api.github.com/users/retronym/gists{/gist_id}","starred_url":"https://api.github.com/users/retronym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retronym/subscriptions","organizations_url":"https://api.github.com/users/retronym/orgs","repos_url":"https://api.github.com/users/retronym/repos","events_url":"https://api.github.com/users/retronym/events{/privacy}","received_events_url":"https://api.github.com/users/retronym/received_events","type":"User","site_admin":false},"body":"typo","created_at":"2015-06-19T01:34:12Z","updated_at":"2015-06-19T01:34:12Z","html_url":"https://github.com/scala/pickling/pull/340#discussion_r32795469","pull_request_url":"https://api.github.com/repos/scala/pickling/pulls/340","_links":{"self":{"href":"https://api.github.com/repos/scala/pickling/pulls/comments/32795469"},"html":{"href":"https://github.com/scala/pickling/pull/340#discussion_r32795469"},"pull_request":{"href":"https://api.github.com/repos/scala/pickling/pulls/340"}}},"pull_request":{"url":"https://api.github.com/repos/scala/pickling/pulls/340","id":37742417,"html_url":"https://github.com/scala/pickling/pull/340","diff_url":"https://github.com/scala/pickling/pull/340.diff","patch_url":"https://github.com/scala/pickling/pull/340.patch","issue_url":"https://api.github.com/repos/scala/pickling/issues/340","number":340,"state":"open","locked":false,"title":"Macro Hygiene + Locking Hygiene","user":{"login":"jsuereth","id":29006,"avatar_url":"https://avatars.githubusercontent.com/u/29006?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuereth","html_url":"https://github.com/jsuereth","followers_url":"https://api.github.com/users/jsuereth/followers","following_url":"https://api.github.com/users/jsuereth/following{/other_user}","gists_url":"https://api.github.com/users/jsuereth/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuereth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuereth/subscriptions","organizations_url":"https://api.github.com/users/jsuereth/orgs","repos_url":"https://api.github.com/users/jsuereth/repos","events_url":"https://api.github.com/users/jsuereth/events{/privacy}","received_events_url":"https://api.github.com/users/jsuereth/received_events","type":"User","site_admin":false},"body":"This PR does two things:\r\n\r\n1. We migrate all instances of GRL locks into dynamic sections of pickling.  ANything which *generates* a runtime pickler is locked.   All runtime picklers which use reflection lock in their pickle/unpickle methods.\r\n2. We fully qualify ALL types in the macro in `_root_.` which means we can remove the imports from the generated macro trees.\r\n\r\nShould take care to review, but all tests pass and I tried an experiment with overriding sbt-server using this code, but not sure I fully refreshed the generated macro code to be clear of GRL locks.\r\n\r\n\r\nReview by> @eed3si9n @phaller ","created_at":"2015-06-15T22:28:43Z","updated_at":"2015-06-19T01:34:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62ce585d28c15453518861b601247edba5bb7b18","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scala/pickling/pulls/340/commits","review_comments_url":"https://api.github.com/repos/scala/pickling/pulls/340/comments","review_comment_url":"https://api.github.com/repos/scala/pickling/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala/pickling/issues/340/comments","statuses_url":"https://api.github.com/repos/scala/pickling/statuses/27c416cbef9f4e0a74c26cf26580ea964d605616","head":{"label":"scala:wip/macro-hygiene","ref":"wip/macro-hygiene","sha":"27c416cbef9f4e0a74c26cf26580ea964d605616","user":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"repo":{"id":10566713,"name":"pickling","full_name":"scala/pickling","owner":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala/pickling","description":"Fast, customizable, boilerplate-free pickling support for Scala","fork":false,"url":"https://api.github.com/repos/scala/pickling","forks_url":"https://api.github.com/repos/scala/pickling/forks","keys_url":"https://api.github.com/repos/scala/pickling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala/pickling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala/pickling/teams","hooks_url":"https://api.github.com/repos/scala/pickling/hooks","issue_events_url":"https://api.github.com/repos/scala/pickling/issues/events{/number}","events_url":"https://api.github.com/repos/scala/pickling/events","assignees_url":"https://api.github.com/repos/scala/pickling/assignees{/user}","branches_url":"https://api.github.com/repos/scala/pickling/branches{/branch}","tags_url":"https://api.github.com/repos/scala/pickling/tags","blobs_url":"https://api.github.com/repos/scala/pickling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala/pickling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala/pickling/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala/pickling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala/pickling/statuses/{sha}","languages_url":"https://api.github.com/repos/scala/pickling/languages","stargazers_url":"https://api.github.com/repos/scala/pickling/stargazers","contributors_url":"https://api.github.com/repos/scala/pickling/contributors","subscribers_url":"https://api.github.com/repos/scala/pickling/subscribers","subscription_url":"https://api.github.com/repos/scala/pickling/subscription","commits_url":"https://api.github.com/repos/scala/pickling/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala/pickling/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala/pickling/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala/pickling/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala/pickling/contents/{+path}","compare_url":"https://api.github.com/repos/scala/pickling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala/pickling/merges","archive_url":"https://api.github.com/repos/scala/pickling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala/pickling/downloads","issues_url":"https://api.github.com/repos/scala/pickling/issues{/number}","pulls_url":"https://api.github.com/repos/scala/pickling/pulls{/number}","milestones_url":"https://api.github.com/repos/scala/pickling/milestones{/number}","notifications_url":"https://api.github.com/repos/scala/pickling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala/pickling/labels{/name}","releases_url":"https://api.github.com/repos/scala/pickling/releases{/id}","created_at":"2013-06-08T09:37:07Z","updated_at":"2015-06-15T14:12:07Z","pushed_at":"2015-06-17T23:01:06Z","git_url":"git://github.com/scala/pickling.git","ssh_url":"git@github.com:scala/pickling.git","clone_url":"https://github.com/scala/pickling.git","svn_url":"https://github.com/scala/pickling","homepage":"lampwww.epfl.ch/~hmiller/pickling","size":76276,"stargazers_count":614,"watchers_count":614,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":83,"forks":54,"open_issues":83,"watchers":614,"default_branch":"0.10.x"}},"base":{"label":"scala:0.10.x","ref":"0.10.x","sha":"8677e90713075af75c06e01bc456f84e62491d64","user":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"repo":{"id":10566713,"name":"pickling","full_name":"scala/pickling","owner":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala/pickling","description":"Fast, customizable, boilerplate-free pickling support for Scala","fork":false,"url":"https://api.github.com/repos/scala/pickling","forks_url":"https://api.github.com/repos/scala/pickling/forks","keys_url":"https://api.github.com/repos/scala/pickling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala/pickling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala/pickling/teams","hooks_url":"https://api.github.com/repos/scala/pickling/hooks","issue_events_url":"https://api.github.com/repos/scala/pickling/issues/events{/number}","events_url":"https://api.github.com/repos/scala/pickling/events","assignees_url":"https://api.github.com/repos/scala/pickling/assignees{/user}","branches_url":"https://api.github.com/repos/scala/pickling/branches{/branch}","tags_url":"https://api.github.com/repos/scala/pickling/tags","blobs_url":"https://api.github.com/repos/scala/pickling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala/pickling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala/pickling/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala/pickling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala/pickling/statuses/{sha}","languages_url":"https://api.github.com/repos/scala/pickling/languages","stargazers_url":"https://api.github.com/repos/scala/pickling/stargazers","contributors_url":"https://api.github.com/repos/scala/pickling/contributors","subscribers_url":"https://api.github.com/repos/scala/pickling/subscribers","subscription_url":"https://api.github.com/repos/scala/pickling/subscription","commits_url":"https://api.github.com/repos/scala/pickling/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala/pickling/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala/pickling/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala/pickling/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala/pickling/contents/{+path}","compare_url":"https://api.github.com/repos/scala/pickling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala/pickling/merges","archive_url":"https://api.github.com/repos/scala/pickling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala/pickling/downloads","issues_url":"https://api.github.com/repos/scala/pickling/issues{/number}","pulls_url":"https://api.github.com/repos/scala/pickling/pulls{/number}","milestones_url":"https://api.github.com/repos/scala/pickling/milestones{/number}","notifications_url":"https://api.github.com/repos/scala/pickling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala/pickling/labels{/name}","releases_url":"https://api.github.com/repos/scala/pickling/releases{/id}","created_at":"2013-06-08T09:37:07Z","updated_at":"2015-06-15T14:12:07Z","pushed_at":"2015-06-17T23:01:06Z","git_url":"git://github.com/scala/pickling.git","ssh_url":"git@github.com:scala/pickling.git","clone_url":"https://github.com/scala/pickling.git","svn_url":"https://github.com/scala/pickling","homepage":"lampwww.epfl.ch/~hmiller/pickling","size":76276,"stargazers_count":614,"watchers_count":614,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":83,"forks":54,"open_issues":83,"watchers":614,"default_branch":"0.10.x"}},"_links":{"self":{"href":"https://api.github.com/repos/scala/pickling/pulls/340"},"html":{"href":"https://github.com/scala/pickling/pull/340"},"issue":{"href":"https://api.github.com/repos/scala/pickling/issues/340"},"comments":{"href":"https://api.github.com/repos/scala/pickling/issues/340/comments"},"review_comments":{"href":"https://api.github.com/repos/scala/pickling/pulls/340/comments"},"review_comment":{"href":"https://api.github.com/repos/scala/pickling/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala/pickling/pulls/340/commits"},"statuses":{"href":"https://api.github.com/repos/scala/pickling/statuses/27c416cbef9f4e0a74c26cf26580ea964d605616"}}}}