{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/39591533","id":39591533,"diff_hunk":"@@ -461,3 +461,75 @@ type JobCondition struct {\n \t// Human readable message indicating details about last transition.\n \tMessage string `json:\"message,omitempty\"`\n }\n+\n+// IngressPoint encapsulates the inputs needed to connect an alias to endpoints.\n+// It represents a rule collection of inbound connections from the external network\n+// that would be satisfied by a load balancer.\n+type IngressPoint struct {\n+\tapi.TypeMeta `json:\",inline\"`\n+\t// Standard object's metadata.\n+\t// More info: http://releases.k8s.io/HEAD/docs/devel/api-conventions.md#metadata\n+\tapi.ObjectMeta `json:\"metadata,omitempty\"`\n+\n+\t// Spec is the desired state of the IngressPoint.\n+\t// More info: http://releases.k8s.io/HEAD/docs/devel/api-conventions.md#spec-and-status\n+\tSpec IngressPointSpec `json:\"spec,omitempty\"`\n+\n+\t// Status is the current state of the IngressPoint.\n+\t// More info: http://releases.k8s.io/HEAD/docs/devel/api-conventions.md#spec-and-status\n+\tStatus IngressPointStatus `json:\"status,omitempty\"`\n+}\n+\n+// IngressPointList is a collection of IngressPoints,\n+type IngressPointList struct {\n+\tapi.TypeMeta `json:\",inline\"`\n+\t// Standard object's metadata.\n+\t// More info: http://releases.k8s.io/HEAD/docs/devel/api-conventions.md#metadata\n+\tapi.ListMeta `json:\"metadata,omitempty\"`\n+\n+\t// Items is the list of ingressPoints.\n+\tItems []IngressPoint `json:\"items\"`\n+}\n+\n+// ServiceRef represents a reference to a single service:port.\n+type ServiceRef struct {\n+\t// Define the name of the referenced service.\n+\tName string `json:\"name,omitempty\"`\n+\n+\t// Define the namespace of the referenced service.\n+\tNamespace string `json:\"namespace,omitempty\"`\n+\n+\t// Define the service's port which the http traffic will be forwarded to.\n+\tPort int `json:\"port,omitempty\"`","path":"pkg/apis/experimental/types.go","position":43,"original_position":43,"commit_id":"725ff40f8a74c93f68c81d5bad83a65494708917","original_commit_id":"725ff40f8a74c93f68c81d5bad83a65494708917","user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"body":"This needs to clearly detail that this port MUST match a port in the target Service.\r\n\r\nAnd it still needs to be IntOrString - named ports are a thing.","created_at":"2015-09-16T03:45:35Z","updated_at":"2015-09-16T03:45:35Z","html_url":"https://github.com/kubernetes/kubernetes/pull/13947#discussion_r39591533","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13947","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/39591533"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/13947#discussion_r39591533"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13947"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13947","id":44993869,"html_url":"https://github.com/kubernetes/kubernetes/pull/13947","diff_url":"https://github.com/kubernetes/kubernetes/pull/13947.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/13947.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13947","number":13947,"state":"open","locked":false,"title":"Add Basic IngressPoint resource type for L7 Loadbalancing","user":{"login":"alfred-huangjian","id":6328548,"avatar_url":"https://avatars.githubusercontent.com/u/6328548?v=3","gravatar_id":"","url":"https://api.github.com/users/alfred-huangjian","html_url":"https://github.com/alfred-huangjian","followers_url":"https://api.github.com/users/alfred-huangjian/followers","following_url":"https://api.github.com/users/alfred-huangjian/following{/other_user}","gists_url":"https://api.github.com/users/alfred-huangjian/gists{/gist_id}","starred_url":"https://api.github.com/users/alfred-huangjian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfred-huangjian/subscriptions","organizations_url":"https://api.github.com/users/alfred-huangjian/orgs","repos_url":"https://api.github.com/users/alfred-huangjian/repos","events_url":"https://api.github.com/users/alfred-huangjian/events{/privacy}","received_events_url":"https://api.github.com/users/alfred-huangjian/received_events","type":"User","site_admin":false},"body":"Required for implementing L7 loadbalancing.\r\nFirst add the IngressPoint API type for review.\r\n@bprashanth \r\n#12825 #12827 ","created_at":"2015-09-14T23:36:38Z","updated_at":"2015-09-16T03:45:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6cd4e70b26daac0cd59d31aa61d91d99adf9ade","assignee":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13947/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13947/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13947/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/725ff40f8a74c93f68c81d5bad83a65494708917","head":{"label":"alfred-huangjian:l7-inp-resouce-type","ref":"l7-inp-resouce-type","sha":"725ff40f8a74c93f68c81d5bad83a65494708917","user":{"login":"alfred-huangjian","id":6328548,"avatar_url":"https://avatars.githubusercontent.com/u/6328548?v=3","gravatar_id":"","url":"https://api.github.com/users/alfred-huangjian","html_url":"https://github.com/alfred-huangjian","followers_url":"https://api.github.com/users/alfred-huangjian/followers","following_url":"https://api.github.com/users/alfred-huangjian/following{/other_user}","gists_url":"https://api.github.com/users/alfred-huangjian/gists{/gist_id}","starred_url":"https://api.github.com/users/alfred-huangjian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfred-huangjian/subscriptions","organizations_url":"https://api.github.com/users/alfred-huangjian/orgs","repos_url":"https://api.github.com/users/alfred-huangjian/repos","events_url":"https://api.github.com/users/alfred-huangjian/events{/privacy}","received_events_url":"https://api.github.com/users/alfred-huangjian/received_events","type":"User","site_admin":false},"repo":{"id":42294945,"name":"kubernetes","full_name":"alfred-huangjian/kubernetes","owner":{"login":"alfred-huangjian","id":6328548,"avatar_url":"https://avatars.githubusercontent.com/u/6328548?v=3","gravatar_id":"","url":"https://api.github.com/users/alfred-huangjian","html_url":"https://github.com/alfred-huangjian","followers_url":"https://api.github.com/users/alfred-huangjian/followers","following_url":"https://api.github.com/users/alfred-huangjian/following{/other_user}","gists_url":"https://api.github.com/users/alfred-huangjian/gists{/gist_id}","starred_url":"https://api.github.com/users/alfred-huangjian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfred-huangjian/subscriptions","organizations_url":"https://api.github.com/users/alfred-huangjian/orgs","repos_url":"https://api.github.com/users/alfred-huangjian/repos","events_url":"https://api.github.com/users/alfred-huangjian/events{/privacy}","received_events_url":"https://api.github.com/users/alfred-huangjian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alfred-huangjian/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/alfred-huangjian/kubernetes","forks_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/forks","keys_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/teams","hooks_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/events","assignees_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/tags","blobs_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/languages","stargazers_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/subscription","commits_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/merges","archive_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/downloads","issues_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/alfred-huangjian/kubernetes/releases{/id}","created_at":"2015-09-11T07:44:43Z","updated_at":"2015-09-11T07:44:50Z","pushed_at":"2015-09-14T23:26:18Z","git_url":"git://github.com/alfred-huangjian/kubernetes.git","ssh_url":"git@github.com:alfred-huangjian/kubernetes.git","clone_url":"https://github.com/alfred-huangjian/kubernetes.git","svn_url":"https://github.com/alfred-huangjian/kubernetes","homepage":"http://kubernetes.io","size":108311,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"db128ac0f7a0ffe9bd94c0910e6d288eda1bd601","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-09-16T03:18:02Z","pushed_at":"2015-09-16T03:39:53Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":413158,"stargazers_count":10258,"watchers_count":10258,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2530,"mirror_url":null,"open_issues_count":1766,"forks":2530,"open_issues":1766,"watchers":10258,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13947"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/13947"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/13947"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/13947/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13947/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13947/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/725ff40f8a74c93f68c81d5bad83a65494708917"}}}}