{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/versity/libs3/pulls/3","id":49302049,"html_url":"https://github.com/versity/libs3/pull/3","diff_url":"https://github.com/versity/libs3/pull/3.diff","patch_url":"https://github.com/versity/libs3/pull/3.patch","issue_url":"https://api.github.com/repos/versity/libs3/issues/3","number":3,"state":"closed","locked":false,"title":"commit id on aws for multipart was truncated","user":{"login":"benmcclelland","id":2184287,"avatar_url":"https://avatars.githubusercontent.com/u/2184287?v=3","gravatar_id":"","url":"https://api.github.com/users/benmcclelland","html_url":"https://github.com/benmcclelland","followers_url":"https://api.github.com/users/benmcclelland/followers","following_url":"https://api.github.com/users/benmcclelland/following{/other_user}","gists_url":"https://api.github.com/users/benmcclelland/gists{/gist_id}","starred_url":"https://api.github.com/users/benmcclelland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benmcclelland/subscriptions","organizations_url":"https://api.github.com/users/benmcclelland/orgs","repos_url":"https://api.github.com/users/benmcclelland/repos","events_url":"https://api.github.com/users/benmcclelland/events{/privacy}","received_events_url":"https://api.github.com/users/benmcclelland/received_events","type":"User","site_admin":false},"body":"the string returned from amazon in testing is\r\n128 + null term for final length of 129\r\nthis was previously truncating the last char\r\nresulting in an incorrect id when trying to\r\ncomplete the upload\r\n\r\nsince there doesnt seem to be any documentation\r\non how long these could get from aws, double the\r\nprevious buffer length to 256 for now\r\n\r\nbug:\r\n$ ./s3 -h put testb/test filename=./test\r\nSending Part Seq 1, length=15728640\r\n\r\nERROR: ErrorNoSuchUpload\r\n  Message: The specified upload does not exist. The upload ID may be\r\ninvalid, or the upload may have been aborted or completed.\r\n  Extra Details:\r\n    UploadId:\r\n.yh43YCRYOhfHGAxy_WLPcVAlt.erMiqR2cgv78cdFPPUUa.qiJ.jIvxDlmCHVxyvcLQkztIs6lPmZZyefwl7XJ3gJSQcidWpq80bjxBIGn1NgJ6yUQlUVzrGuqBE2.\r\n    RequestId: 2E96F0D8A8D5CC81\r\n    HostId:\r\n72aAmPpiGcH+gtz/PoZpLRnAA8+1XTxOxLIrznAfRMU8Rj7LObrntPCtpArA1r03S1ubxBjlCAU=\r\n\r\n$ s3cmd multipart s3://testb\r\ns3://testb/\r\nInitiated\tPath\tId\r\n2015-10-30T17:47:02.000Z\ts3://testb/test\r\n.yh43YCRYOhfHGAxy_WLPcVAlt.erMiqR2cgv78cdFPPUUa.qiJ.jIvxDlmCHVxyvcLQkztIs6lPmZZyefwl7XJ3gJSQcidWpq80bjxBIGn1NgJ6yUQlUVzrGuqBE2.r\r\n\r\nnotice missing \"r\" from error UploadId above\r\n\r\nfix:\r\n$ ./s3 -h put testb/test filename=./test\r\nSending Part Seq 1, length=15728640\r\n15712256 bytes remaining (50% complete) ...\r\n...\r\n32768 bytes remaining (99% complete) ...\r\n16384 bytes remaining (99% complete) ...","created_at":"2015-10-30T17:57:09Z","updated_at":"2015-11-03T18:36:10Z","closed_at":"2015-11-03T18:36:10Z","merged_at":"2015-11-03T18:36:10Z","merge_commit_sha":"719e021e8f9bdde6a9963901bc22281e8a759007","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/versity/libs3/pulls/3/commits","review_comments_url":"https://api.github.com/repos/versity/libs3/pulls/3/comments","review_comment_url":"https://api.github.com/repos/versity/libs3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/versity/libs3/issues/3/comments","statuses_url":"https://api.github.com/repos/versity/libs3/statuses/22867105dd2cb611894144dbe8ff30bb88e18740","head":{"label":"versity:upload_id_trunc","ref":"upload_id_trunc","sha":"22867105dd2cb611894144dbe8ff30bb88e18740","user":{"login":"versity","id":6293622,"avatar_url":"https://avatars.githubusercontent.com/u/6293622?v=3","gravatar_id":"","url":"https://api.github.com/users/versity","html_url":"https://github.com/versity","followers_url":"https://api.github.com/users/versity/followers","following_url":"https://api.github.com/users/versity/following{/other_user}","gists_url":"https://api.github.com/users/versity/gists{/gist_id}","starred_url":"https://api.github.com/users/versity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/versity/subscriptions","organizations_url":"https://api.github.com/users/versity/orgs","repos_url":"https://api.github.com/users/versity/repos","events_url":"https://api.github.com/users/versity/events{/privacy}","received_events_url":"https://api.github.com/users/versity/received_events","type":"Organization","site_admin":false},"repo":{"id":44764255,"name":"libs3","full_name":"versity/libs3","owner":{"login":"versity","id":6293622,"avatar_url":"https://avatars.githubusercontent.com/u/6293622?v=3","gravatar_id":"","url":"https://api.github.com/users/versity","html_url":"https://github.com/versity","followers_url":"https://api.github.com/users/versity/followers","following_url":"https://api.github.com/users/versity/following{/other_user}","gists_url":"https://api.github.com/users/versity/gists{/gist_id}","starred_url":"https://api.github.com/users/versity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/versity/subscriptions","organizations_url":"https://api.github.com/users/versity/orgs","repos_url":"https://api.github.com/users/versity/repos","events_url":"https://api.github.com/users/versity/events{/privacy}","received_events_url":"https://api.github.com/users/versity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/versity/libs3","description":"","fork":true,"url":"https://api.github.com/repos/versity/libs3","forks_url":"https://api.github.com/repos/versity/libs3/forks","keys_url":"https://api.github.com/repos/versity/libs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/versity/libs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/versity/libs3/teams","hooks_url":"https://api.github.com/repos/versity/libs3/hooks","issue_events_url":"https://api.github.com/repos/versity/libs3/issues/events{/number}","events_url":"https://api.github.com/repos/versity/libs3/events","assignees_url":"https://api.github.com/repos/versity/libs3/assignees{/user}","branches_url":"https://api.github.com/repos/versity/libs3/branches{/branch}","tags_url":"https://api.github.com/repos/versity/libs3/tags","blobs_url":"https://api.github.com/repos/versity/libs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/versity/libs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/versity/libs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/versity/libs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/versity/libs3/statuses/{sha}","languages_url":"https://api.github.com/repos/versity/libs3/languages","stargazers_url":"https://api.github.com/repos/versity/libs3/stargazers","contributors_url":"https://api.github.com/repos/versity/libs3/contributors","subscribers_url":"https://api.github.com/repos/versity/libs3/subscribers","subscription_url":"https://api.github.com/repos/versity/libs3/subscription","commits_url":"https://api.github.com/repos/versity/libs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/versity/libs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/versity/libs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/versity/libs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/versity/libs3/contents/{+path}","compare_url":"https://api.github.com/repos/versity/libs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/versity/libs3/merges","archive_url":"https://api.github.com/repos/versity/libs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/versity/libs3/downloads","issues_url":"https://api.github.com/repos/versity/libs3/issues{/number}","pulls_url":"https://api.github.com/repos/versity/libs3/pulls{/number}","milestones_url":"https://api.github.com/repos/versity/libs3/milestones{/number}","notifications_url":"https://api.github.com/repos/versity/libs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/versity/libs3/labels{/name}","releases_url":"https://api.github.com/repos/versity/libs3/releases{/id}","created_at":"2015-10-22T18:12:56Z","updated_at":"2015-10-22T18:12:56Z","pushed_at":"2015-11-03T18:36:10Z","git_url":"git://github.com/versity/libs3.git","ssh_url":"git@github.com:versity/libs3.git","clone_url":"https://github.com/versity/libs3.git","svn_url":"https://github.com/versity/libs3","homepage":null,"size":580,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"versity:master","ref":"master","sha":"eba1d65ecb9af530a1628e68366dfe4e0a9c9890","user":{"login":"versity","id":6293622,"avatar_url":"https://avatars.githubusercontent.com/u/6293622?v=3","gravatar_id":"","url":"https://api.github.com/users/versity","html_url":"https://github.com/versity","followers_url":"https://api.github.com/users/versity/followers","following_url":"https://api.github.com/users/versity/following{/other_user}","gists_url":"https://api.github.com/users/versity/gists{/gist_id}","starred_url":"https://api.github.com/users/versity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/versity/subscriptions","organizations_url":"https://api.github.com/users/versity/orgs","repos_url":"https://api.github.com/users/versity/repos","events_url":"https://api.github.com/users/versity/events{/privacy}","received_events_url":"https://api.github.com/users/versity/received_events","type":"Organization","site_admin":false},"repo":{"id":44764255,"name":"libs3","full_name":"versity/libs3","owner":{"login":"versity","id":6293622,"avatar_url":"https://avatars.githubusercontent.com/u/6293622?v=3","gravatar_id":"","url":"https://api.github.com/users/versity","html_url":"https://github.com/versity","followers_url":"https://api.github.com/users/versity/followers","following_url":"https://api.github.com/users/versity/following{/other_user}","gists_url":"https://api.github.com/users/versity/gists{/gist_id}","starred_url":"https://api.github.com/users/versity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/versity/subscriptions","organizations_url":"https://api.github.com/users/versity/orgs","repos_url":"https://api.github.com/users/versity/repos","events_url":"https://api.github.com/users/versity/events{/privacy}","received_events_url":"https://api.github.com/users/versity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/versity/libs3","description":"","fork":true,"url":"https://api.github.com/repos/versity/libs3","forks_url":"https://api.github.com/repos/versity/libs3/forks","keys_url":"https://api.github.com/repos/versity/libs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/versity/libs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/versity/libs3/teams","hooks_url":"https://api.github.com/repos/versity/libs3/hooks","issue_events_url":"https://api.github.com/repos/versity/libs3/issues/events{/number}","events_url":"https://api.github.com/repos/versity/libs3/events","assignees_url":"https://api.github.com/repos/versity/libs3/assignees{/user}","branches_url":"https://api.github.com/repos/versity/libs3/branches{/branch}","tags_url":"https://api.github.com/repos/versity/libs3/tags","blobs_url":"https://api.github.com/repos/versity/libs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/versity/libs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/versity/libs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/versity/libs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/versity/libs3/statuses/{sha}","languages_url":"https://api.github.com/repos/versity/libs3/languages","stargazers_url":"https://api.github.com/repos/versity/libs3/stargazers","contributors_url":"https://api.github.com/repos/versity/libs3/contributors","subscribers_url":"https://api.github.com/repos/versity/libs3/subscribers","subscription_url":"https://api.github.com/repos/versity/libs3/subscription","commits_url":"https://api.github.com/repos/versity/libs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/versity/libs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/versity/libs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/versity/libs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/versity/libs3/contents/{+path}","compare_url":"https://api.github.com/repos/versity/libs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/versity/libs3/merges","archive_url":"https://api.github.com/repos/versity/libs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/versity/libs3/downloads","issues_url":"https://api.github.com/repos/versity/libs3/issues{/number}","pulls_url":"https://api.github.com/repos/versity/libs3/pulls{/number}","milestones_url":"https://api.github.com/repos/versity/libs3/milestones{/number}","notifications_url":"https://api.github.com/repos/versity/libs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/versity/libs3/labels{/name}","releases_url":"https://api.github.com/repos/versity/libs3/releases{/id}","created_at":"2015-10-22T18:12:56Z","updated_at":"2015-10-22T18:12:56Z","pushed_at":"2015-11-03T18:36:10Z","git_url":"git://github.com/versity/libs3.git","ssh_url":"git@github.com:versity/libs3.git","clone_url":"https://github.com/versity/libs3.git","svn_url":"https://github.com/versity/libs3","homepage":null,"size":580,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/versity/libs3/pulls/3"},"html":{"href":"https://github.com/versity/libs3/pull/3"},"issue":{"href":"https://api.github.com/repos/versity/libs3/issues/3"},"comments":{"href":"https://api.github.com/repos/versity/libs3/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/versity/libs3/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/versity/libs3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/versity/libs3/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/versity/libs3/statuses/22867105dd2cb611894144dbe8ff30bb88e18740"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nichenke","id":5995476,"avatar_url":"https://avatars.githubusercontent.com/u/5995476?v=3","gravatar_id":"","url":"https://api.github.com/users/nichenke","html_url":"https://github.com/nichenke","followers_url":"https://api.github.com/users/nichenke/followers","following_url":"https://api.github.com/users/nichenke/following{/other_user}","gists_url":"https://api.github.com/users/nichenke/gists{/gist_id}","starred_url":"https://api.github.com/users/nichenke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nichenke/subscriptions","organizations_url":"https://api.github.com/users/nichenke/orgs","repos_url":"https://api.github.com/users/nichenke/repos","events_url":"https://api.github.com/users/nichenke/events{/privacy}","received_events_url":"https://api.github.com/users/nichenke/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"commits":1,"additions":27,"deletions":16,"changed_files":2}}