{"action":"created","comment":{"url":"https://api.github.com/repos/projecthydra/active_fedora/pulls/comments/22717330","id":22717330,"diff_hunk":"@@ -171,16 +171,37 @@ def multiple?(field)\n       end\n \n       def property name, properties={}, &block\n+        warn_duplicate_predicates name, properties\n         properties = { multiple: true }.merge(properties)\n         find_or_create_defined_attribute(name, nil, properties)\n         raise ArgumentError, \"#{name} is a keyword and not an acceptable property name.\" if protected_property_name? name\n         reflection = ActiveFedora::Attributes::PropertyBuilder.build(self, name, properties, &block)\n-        # reflection = ActiveTriple::PropertyBuilder.build(self, name, properties, &block)\n         ActiveTriples::Reflection.add_reflection self, name, reflection\n       end\n \n       private\n \n+      def warn_duplicate_predicates new_name, new_properties\n+        # TODO: Simplify logic once I am sure I got it right.\n+        self.properties.each do |property, config| \n+          if config.predicate == new_properties[:predicate]\n+            puts \"- potential issue for predicate #{config.predicate} between #{new_name} and #{property}\"","path":"lib/active_fedora/attributes.rb","position":19,"original_position":19,"commit_id":"03ff40ec62bad3bf6e44c5f9ab424f3cd6012a27","original_commit_id":"03ff40ec62bad3bf6e44c5f9ab424f3cd6012a27","user":{"login":"jcoyne","id":92044,"avatar_url":"https://avatars.githubusercontent.com/u/92044?v=3","gravatar_id":"","url":"https://api.github.com/users/jcoyne","html_url":"https://github.com/jcoyne","followers_url":"https://api.github.com/users/jcoyne/followers","following_url":"https://api.github.com/users/jcoyne/following{/other_user}","gists_url":"https://api.github.com/users/jcoyne/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoyne/subscriptions","organizations_url":"https://api.github.com/users/jcoyne/orgs","repos_url":"https://api.github.com/users/jcoyne/repos","events_url":"https://api.github.com/users/jcoyne/events{/privacy}","received_events_url":"https://api.github.com/users/jcoyne/received_events","type":"User","site_admin":false},"body":"This should be `ActiveFedora::Base.logger`","created_at":"2015-01-09T14:14:45Z","updated_at":"2015-01-09T14:14:45Z","html_url":"https://github.com/projecthydra/active_fedora/pull/681#discussion_r22717330","pull_request_url":"https://api.github.com/repos/projecthydra/active_fedora/pulls/681","_links":{"self":{"href":"https://api.github.com/repos/projecthydra/active_fedora/pulls/comments/22717330"},"html":{"href":"https://github.com/projecthydra/active_fedora/pull/681#discussion_r22717330"},"pull_request":{"href":"https://api.github.com/repos/projecthydra/active_fedora/pulls/681"}}},"pull_request":{"url":"https://api.github.com/repos/projecthydra/active_fedora/pulls/681","id":27065614,"html_url":"https://github.com/projecthydra/active_fedora/pull/681","diff_url":"https://github.com/projecthydra/active_fedora/pull/681.diff","patch_url":"https://github.com/projecthydra/active_fedora/pull/681.patch","issue_url":"https://api.github.com/repos/projecthydra/active_fedora/issues/681","number":681,"state":"open","locked":false,"title":"Warn when the same predicate is used in more than one property","user":{"login":"hectorcorrea","id":568286,"avatar_url":"https://avatars.githubusercontent.com/u/568286?v=3","gravatar_id":"","url":"https://api.github.com/users/hectorcorrea","html_url":"https://github.com/hectorcorrea","followers_url":"https://api.github.com/users/hectorcorrea/followers","following_url":"https://api.github.com/users/hectorcorrea/following{/other_user}","gists_url":"https://api.github.com/users/hectorcorrea/gists{/gist_id}","starred_url":"https://api.github.com/users/hectorcorrea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hectorcorrea/subscriptions","organizations_url":"https://api.github.com/users/hectorcorrea/orgs","repos_url":"https://api.github.com/users/hectorcorrea/repos","events_url":"https://api.github.com/users/hectorcorrea/events{/privacy}","received_events_url":"https://api.github.com/users/hectorcorrea/received_events","type":"User","site_admin":false},"body":"This addresses issue #662 \r\n\r\n** This is a first draft for feedback **","created_at":"2015-01-08T22:32:48Z","updated_at":"2015-01-09T14:14:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"744d32111ad31006be8edd29eb5c2dfd5c79bdea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projecthydra/active_fedora/pulls/681/commits","review_comments_url":"https://api.github.com/repos/projecthydra/active_fedora/pulls/681/comments","review_comment_url":"https://api.github.com/repos/projecthydra/active_fedora/pulls/comments/{number}","comments_url":"https://api.github.com/repos/projecthydra/active_fedora/issues/681/comments","statuses_url":"https://api.github.com/repos/projecthydra/active_fedora/statuses/03ff40ec62bad3bf6e44c5f9ab424f3cd6012a27","head":{"label":"projecthydra:property_warn","ref":"property_warn","sha":"03ff40ec62bad3bf6e44c5f9ab424f3cd6012a27","user":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"repo":{"id":3867127,"name":"active_fedora","full_name":"projecthydra/active_fedora","owner":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecthydra/active_fedora","description":"A Rails interface to the Fedora repository, akin to Active Model","fork":false,"url":"https://api.github.com/repos/projecthydra/active_fedora","forks_url":"https://api.github.com/repos/projecthydra/active_fedora/forks","keys_url":"https://api.github.com/repos/projecthydra/active_fedora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecthydra/active_fedora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecthydra/active_fedora/teams","hooks_url":"https://api.github.com/repos/projecthydra/active_fedora/hooks","issue_events_url":"https://api.github.com/repos/projecthydra/active_fedora/issues/events{/number}","events_url":"https://api.github.com/repos/projecthydra/active_fedora/events","assignees_url":"https://api.github.com/repos/projecthydra/active_fedora/assignees{/user}","branches_url":"https://api.github.com/repos/projecthydra/active_fedora/branches{/branch}","tags_url":"https://api.github.com/repos/projecthydra/active_fedora/tags","blobs_url":"https://api.github.com/repos/projecthydra/active_fedora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecthydra/active_fedora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecthydra/active_fedora/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecthydra/active_fedora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecthydra/active_fedora/statuses/{sha}","languages_url":"https://api.github.com/repos/projecthydra/active_fedora/languages","stargazers_url":"https://api.github.com/repos/projecthydra/active_fedora/stargazers","contributors_url":"https://api.github.com/repos/projecthydra/active_fedora/contributors","subscribers_url":"https://api.github.com/repos/projecthydra/active_fedora/subscribers","subscription_url":"https://api.github.com/repos/projecthydra/active_fedora/subscription","commits_url":"https://api.github.com/repos/projecthydra/active_fedora/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecthydra/active_fedora/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecthydra/active_fedora/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecthydra/active_fedora/issues/comments/{number}","contents_url":"https://api.github.com/repos/projecthydra/active_fedora/contents/{+path}","compare_url":"https://api.github.com/repos/projecthydra/active_fedora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecthydra/active_fedora/merges","archive_url":"https://api.github.com/repos/projecthydra/active_fedora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecthydra/active_fedora/downloads","issues_url":"https://api.github.com/repos/projecthydra/active_fedora/issues{/number}","pulls_url":"https://api.github.com/repos/projecthydra/active_fedora/pulls{/number}","milestones_url":"https://api.github.com/repos/projecthydra/active_fedora/milestones{/number}","notifications_url":"https://api.github.com/repos/projecthydra/active_fedora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecthydra/active_fedora/labels{/name}","releases_url":"https://api.github.com/repos/projecthydra/active_fedora/releases{/id}","created_at":"2012-03-29T15:01:13Z","updated_at":"2015-01-07T21:43:13Z","pushed_at":"2015-01-08T22:43:13Z","git_url":"git://github.com/projecthydra/active_fedora.git","ssh_url":"git@github.com:projecthydra/active_fedora.git","clone_url":"https://github.com/projecthydra/active_fedora.git","svn_url":"https://github.com/projecthydra/active_fedora","homepage":"","size":12998,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":42,"forks":42,"open_issues":42,"watchers":27,"default_branch":"master"}},"base":{"label":"projecthydra:master","ref":"master","sha":"bee58b88a84c2b9957b70f1d977a77d4e494fba4","user":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"repo":{"id":3867127,"name":"active_fedora","full_name":"projecthydra/active_fedora","owner":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecthydra/active_fedora","description":"A Rails interface to the Fedora repository, akin to Active Model","fork":false,"url":"https://api.github.com/repos/projecthydra/active_fedora","forks_url":"https://api.github.com/repos/projecthydra/active_fedora/forks","keys_url":"https://api.github.com/repos/projecthydra/active_fedora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecthydra/active_fedora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecthydra/active_fedora/teams","hooks_url":"https://api.github.com/repos/projecthydra/active_fedora/hooks","issue_events_url":"https://api.github.com/repos/projecthydra/active_fedora/issues/events{/number}","events_url":"https://api.github.com/repos/projecthydra/active_fedora/events","assignees_url":"https://api.github.com/repos/projecthydra/active_fedora/assignees{/user}","branches_url":"https://api.github.com/repos/projecthydra/active_fedora/branches{/branch}","tags_url":"https://api.github.com/repos/projecthydra/active_fedora/tags","blobs_url":"https://api.github.com/repos/projecthydra/active_fedora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecthydra/active_fedora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecthydra/active_fedora/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecthydra/active_fedora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecthydra/active_fedora/statuses/{sha}","languages_url":"https://api.github.com/repos/projecthydra/active_fedora/languages","stargazers_url":"https://api.github.com/repos/projecthydra/active_fedora/stargazers","contributors_url":"https://api.github.com/repos/projecthydra/active_fedora/contributors","subscribers_url":"https://api.github.com/repos/projecthydra/active_fedora/subscribers","subscription_url":"https://api.github.com/repos/projecthydra/active_fedora/subscription","commits_url":"https://api.github.com/repos/projecthydra/active_fedora/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecthydra/active_fedora/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecthydra/active_fedora/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecthydra/active_fedora/issues/comments/{number}","contents_url":"https://api.github.com/repos/projecthydra/active_fedora/contents/{+path}","compare_url":"https://api.github.com/repos/projecthydra/active_fedora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecthydra/active_fedora/merges","archive_url":"https://api.github.com/repos/projecthydra/active_fedora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecthydra/active_fedora/downloads","issues_url":"https://api.github.com/repos/projecthydra/active_fedora/issues{/number}","pulls_url":"https://api.github.com/repos/projecthydra/active_fedora/pulls{/number}","milestones_url":"https://api.github.com/repos/projecthydra/active_fedora/milestones{/number}","notifications_url":"https://api.github.com/repos/projecthydra/active_fedora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecthydra/active_fedora/labels{/name}","releases_url":"https://api.github.com/repos/projecthydra/active_fedora/releases{/id}","created_at":"2012-03-29T15:01:13Z","updated_at":"2015-01-07T21:43:13Z","pushed_at":"2015-01-08T22:43:13Z","git_url":"git://github.com/projecthydra/active_fedora.git","ssh_url":"git@github.com:projecthydra/active_fedora.git","clone_url":"https://github.com/projecthydra/active_fedora.git","svn_url":"https://github.com/projecthydra/active_fedora","homepage":"","size":12998,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":42,"forks":42,"open_issues":42,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projecthydra/active_fedora/pulls/681"},"html":{"href":"https://github.com/projecthydra/active_fedora/pull/681"},"issue":{"href":"https://api.github.com/repos/projecthydra/active_fedora/issues/681"},"comments":{"href":"https://api.github.com/repos/projecthydra/active_fedora/issues/681/comments"},"review_comments":{"href":"https://api.github.com/repos/projecthydra/active_fedora/pulls/681/comments"},"review_comment":{"href":"https://api.github.com/repos/projecthydra/active_fedora/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/projecthydra/active_fedora/pulls/681/commits"},"statuses":{"href":"https://api.github.com/repos/projecthydra/active_fedora/statuses/03ff40ec62bad3bf6e44c5f9ab424f3cd6012a27"}}}}