{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/comments/34165086","id":34165086,"diff_hunk":"@@ -0,0 +1,16 @@\n+Feature: Creating and editing manuals\n+  As a GDS editor\n+  I want to create and edit manuals of my own and other organisations","path":"features/creating-a-manual-as-a-gds-editor.feature","position":3,"original_position":3,"commit_id":"38d6a248c1267f2b8bb777cec883febd443daa2a","original_commit_id":"38d6a248c1267f2b8bb777cec883febd443daa2a","user":{"login":"jennyd","id":1822424,"avatar_url":"https://avatars.githubusercontent.com/u/1822424?v=3","gravatar_id":"","url":"https://api.github.com/users/jennyd","html_url":"https://github.com/jennyd","followers_url":"https://api.github.com/users/jennyd/followers","following_url":"https://api.github.com/users/jennyd/following{/other_user}","gists_url":"https://api.github.com/users/jennyd/gists{/gist_id}","starred_url":"https://api.github.com/users/jennyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennyd/subscriptions","organizations_url":"https://api.github.com/users/jennyd/orgs","repos_url":"https://api.github.com/users/jennyd/repos","events_url":"https://api.github.com/users/jennyd/events{/privacy}","received_events_url":"https://api.github.com/users/jennyd/received_events","type":"User","site_admin":false},"body":"This isn't quite accurate: GDS editors can't create new manuals which belong to other organisations, they can only view and edit existing ones.","created_at":"2015-07-08T15:59:22Z","updated_at":"2015-07-08T15:59:22Z","html_url":"https://github.com/alphagov/specialist-publisher/pull/511#discussion_r34165086","pull_request_url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/511","_links":{"self":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/comments/34165086"},"html":{"href":"https://github.com/alphagov/specialist-publisher/pull/511#discussion_r34165086"},"pull_request":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/511"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/511","id":39080520,"html_url":"https://github.com/alphagov/specialist-publisher/pull/511","diff_url":"https://github.com/alphagov/specialist-publisher/pull/511.diff","patch_url":"https://github.com/alphagov/specialist-publisher/pull/511.patch","issue_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/511","number":511,"state":"open","locked":false,"title":"Gds editor permission manual everything","user":{"login":"mikejustdoit","id":348052,"avatar_url":"https://avatars.githubusercontent.com/u/348052?v=3","gravatar_id":"","url":"https://api.github.com/users/mikejustdoit","html_url":"https://github.com/mikejustdoit","followers_url":"https://api.github.com/users/mikejustdoit/followers","following_url":"https://api.github.com/users/mikejustdoit/following{/other_user}","gists_url":"https://api.github.com/users/mikejustdoit/gists{/gist_id}","starred_url":"https://api.github.com/users/mikejustdoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikejustdoit/subscriptions","organizations_url":"https://api.github.com/users/mikejustdoit/orgs","repos_url":"https://api.github.com/users/mikejustdoit/repos","events_url":"https://api.github.com/users/mikejustdoit/events{/privacy}","received_events_url":"https://api.github.com/users/mikejustdoit/received_events","type":"User","site_admin":false},"body":"Access is normally limited to Manuals owned by the current user's organisation. So that GDS Editors can support other departmental content editors, without having to change their own organisation temporarily in Signon, we treat a GDS Editor as a special case with access to all Manuals.\r\n\r\nThese changes do not allow a GDS Editor to create a Manual on behalf of another organisation, only to access existing Manuals and to create GDS Manuals.\r\n\r\nIt might make more sense to abstract the explicit use of current_user_is_gds_editor? here into a new or existing dedicated object/config for permissions logic. Suggestions would be very welcome.\r\n\r\nI think the changes made to the various ServiceRegistries here really draw attention to the increasing duplication and need for refactoring. Again, suggestions would be excellent there as well.","created_at":"2015-07-02T13:09:56Z","updated_at":"2015-07-08T15:59:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1788d802fbcf2849a59987cec5b81bf96d100ee1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/511/commits","review_comments_url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/511/comments","review_comment_url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/511/comments","statuses_url":"https://api.github.com/repos/alphagov/specialist-publisher/statuses/38d6a248c1267f2b8bb777cec883febd443daa2a","head":{"label":"alphagov:gds-editor-permission-manual-everything","ref":"gds-editor-permission-manual-everything","sha":"38d6a248c1267f2b8bb777cec883febd443daa2a","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":16176198,"name":"specialist-publisher","full_name":"alphagov/specialist-publisher","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/specialist-publisher","description":"Publishing App for Specialist Documents and Manuals on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/specialist-publisher","forks_url":"https://api.github.com/repos/alphagov/specialist-publisher/forks","keys_url":"https://api.github.com/repos/alphagov/specialist-publisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/specialist-publisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/specialist-publisher/teams","hooks_url":"https://api.github.com/repos/alphagov/specialist-publisher/hooks","issue_events_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/specialist-publisher/events","assignees_url":"https://api.github.com/repos/alphagov/specialist-publisher/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/specialist-publisher/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/specialist-publisher/tags","blobs_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/specialist-publisher/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/specialist-publisher/languages","stargazers_url":"https://api.github.com/repos/alphagov/specialist-publisher/stargazers","contributors_url":"https://api.github.com/repos/alphagov/specialist-publisher/contributors","subscribers_url":"https://api.github.com/repos/alphagov/specialist-publisher/subscribers","subscription_url":"https://api.github.com/repos/alphagov/specialist-publisher/subscription","commits_url":"https://api.github.com/repos/alphagov/specialist-publisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/specialist-publisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/specialist-publisher/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/specialist-publisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/specialist-publisher/merges","archive_url":"https://api.github.com/repos/alphagov/specialist-publisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/specialist-publisher/downloads","issues_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/specialist-publisher/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/specialist-publisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/specialist-publisher/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/specialist-publisher/releases{/id}","created_at":"2014-01-23T15:21:42Z","updated_at":"2015-05-07T16:53:19Z","pushed_at":"2015-07-08T13:11:53Z","git_url":"git://github.com/alphagov/specialist-publisher.git","ssh_url":"git@github.com:alphagov/specialist-publisher.git","clone_url":"https://github.com/alphagov/specialist-publisher.git","svn_url":"https://github.com/alphagov/specialist-publisher","homepage":"","size":13057,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"38b188d4e18bdcb60a76f9f1bff452eb48975114","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":16176198,"name":"specialist-publisher","full_name":"alphagov/specialist-publisher","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/specialist-publisher","description":"Publishing App for Specialist Documents and Manuals on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/specialist-publisher","forks_url":"https://api.github.com/repos/alphagov/specialist-publisher/forks","keys_url":"https://api.github.com/repos/alphagov/specialist-publisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/specialist-publisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/specialist-publisher/teams","hooks_url":"https://api.github.com/repos/alphagov/specialist-publisher/hooks","issue_events_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/specialist-publisher/events","assignees_url":"https://api.github.com/repos/alphagov/specialist-publisher/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/specialist-publisher/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/specialist-publisher/tags","blobs_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/specialist-publisher/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/specialist-publisher/languages","stargazers_url":"https://api.github.com/repos/alphagov/specialist-publisher/stargazers","contributors_url":"https://api.github.com/repos/alphagov/specialist-publisher/contributors","subscribers_url":"https://api.github.com/repos/alphagov/specialist-publisher/subscribers","subscription_url":"https://api.github.com/repos/alphagov/specialist-publisher/subscription","commits_url":"https://api.github.com/repos/alphagov/specialist-publisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/specialist-publisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/specialist-publisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/specialist-publisher/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/specialist-publisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/specialist-publisher/merges","archive_url":"https://api.github.com/repos/alphagov/specialist-publisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/specialist-publisher/downloads","issues_url":"https://api.github.com/repos/alphagov/specialist-publisher/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/specialist-publisher/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/specialist-publisher/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/specialist-publisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/specialist-publisher/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/specialist-publisher/releases{/id}","created_at":"2014-01-23T15:21:42Z","updated_at":"2015-05-07T16:53:19Z","pushed_at":"2015-07-08T13:11:53Z","git_url":"git://github.com/alphagov/specialist-publisher.git","ssh_url":"git@github.com:alphagov/specialist-publisher.git","clone_url":"https://github.com/alphagov/specialist-publisher.git","svn_url":"https://github.com/alphagov/specialist-publisher","homepage":"","size":13057,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/511"},"html":{"href":"https://github.com/alphagov/specialist-publisher/pull/511"},"issue":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/issues/511"},"comments":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/issues/511/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/511/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/pulls/511/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/specialist-publisher/statuses/38d6a248c1267f2b8bb777cec883febd443daa2a"}}}}