{"action":"created","issue":{"url":"https://api.github.com/repos/openstreetmap/osm2pgsql/issues/248","labels_url":"https://api.github.com/repos/openstreetmap/osm2pgsql/issues/248/labels{/name}","comments_url":"https://api.github.com/repos/openstreetmap/osm2pgsql/issues/248/comments","events_url":"https://api.github.com/repos/openstreetmap/osm2pgsql/issues/248/events","html_url":"https://github.com/openstreetmap/osm2pgsql/pull/248","id":53352855,"number":248,"title":"Replace manually allocated strings in middle-pgsql with std::string","user":{"login":"lonvia","id":1447941,"avatar_url":"https://avatars.githubusercontent.com/u/1447941?v=3","gravatar_id":"","url":"https://api.github.com/users/lonvia","html_url":"https://github.com/lonvia","followers_url":"https://api.github.com/users/lonvia/followers","following_url":"https://api.github.com/users/lonvia/following{/other_user}","gists_url":"https://api.github.com/users/lonvia/gists{/gist_id}","starred_url":"https://api.github.com/users/lonvia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonvia/subscriptions","organizations_url":"https://api.github.com/users/lonvia/orgs","repos_url":"https://api.github.com/users/lonvia/repos","events_url":"https://api.github.com/users/lonvia/events{/privacy}","received_events_url":"https://api.github.com/users/lonvia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-01-04T23:26:08Z","updated_at":"2015-01-18T16:05:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openstreetmap/osm2pgsql/pulls/248","html_url":"https://github.com/openstreetmap/osm2pgsql/pull/248","diff_url":"https://github.com/openstreetmap/osm2pgsql/pull/248.diff","patch_url":"https://github.com/openstreetmap/osm2pgsql/pull/248.patch"},"body":"This removes all the remaining char* that were manually allocated through either malloc or strdup and replaces them with std::string. Namely they are\r\n\r\n * sql commands in the table descriptions\r\n * buffers for building tag and node lists\r\n \r\nIt fixes another couple of smaller memory leaks (see #228). Note that it also contains a test for #247 which is currently disabled because it fails.\r\n\r\n@pnorman would you mind running another round of performance tests with the full planet? It would also be good to have some numbers on osc updates, if your setup permits to do that easily."},"comment":{"url":"https://api.github.com/repos/openstreetmap/osm2pgsql/issues/comments/70413648","html_url":"https://github.com/openstreetmap/osm2pgsql/pull/248#issuecomment-70413648","issue_url":"https://api.github.com/repos/openstreetmap/osm2pgsql/issues/248","id":70413648,"user":{"login":"lonvia","id":1447941,"avatar_url":"https://avatars.githubusercontent.com/u/1447941?v=3","gravatar_id":"","url":"https://api.github.com/users/lonvia","html_url":"https://github.com/lonvia","followers_url":"https://api.github.com/users/lonvia/followers","following_url":"https://api.github.com/users/lonvia/following{/other_user}","gists_url":"https://api.github.com/users/lonvia/gists{/gist_id}","starred_url":"https://api.github.com/users/lonvia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonvia/subscriptions","organizations_url":"https://api.github.com/users/lonvia/orgs","repos_url":"https://api.github.com/users/lonvia/repos","events_url":"https://api.github.com/users/lonvia/events{/privacy}","received_events_url":"https://api.github.com/users/lonvia/received_events","type":"User","site_admin":false},"created_at":"2015-01-18T16:05:05Z","updated_at":"2015-01-18T16:05:05Z","body":"Thanks, @pnorman. That's so not what I expected. I'll see if I can get the performance of processing ways to what it was before. The difference in indexing is curious. Hopefully, it's not due to missing data. I'll check that."}}