{"action":"created","issue":{"url":"https://api.github.com/repos/rails/rails/issues/22469","labels_url":"https://api.github.com/repos/rails/rails/issues/22469/labels{/name}","comments_url":"https://api.github.com/repos/rails/rails/issues/22469/comments","events_url":"https://api.github.com/repos/rails/rails/issues/22469/events","html_url":"https://github.com/rails/rails/pull/22469","id":120013066,"number":22469,"title":"Fix failing test using custom file watcher","user":{"login":"merhard","id":3860146,"avatar_url":"https://avatars.githubusercontent.com/u/3860146?v=3","gravatar_id":"","url":"https://api.github.com/users/merhard","html_url":"https://github.com/merhard","followers_url":"https://api.github.com/users/merhard/followers","following_url":"https://api.github.com/users/merhard/following{/other_user}","gists_url":"https://api.github.com/users/merhard/gists{/gist_id}","starred_url":"https://api.github.com/users/merhard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merhard/subscriptions","organizations_url":"https://api.github.com/users/merhard/orgs","repos_url":"https://api.github.com/users/merhard/repos","events_url":"https://api.github.com/users/merhard/events{/privacy}","received_events_url":"https://api.github.com/users/merhard/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"arthurnn","id":833383,"avatar_url":"https://avatars.githubusercontent.com/u/833383?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurnn","html_url":"https://github.com/arthurnn","followers_url":"https://api.github.com/users/arthurnn/followers","following_url":"https://api.github.com/users/arthurnn/following{/other_user}","gists_url":"https://api.github.com/users/arthurnn/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurnn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurnn/subscriptions","organizations_url":"https://api.github.com/users/arthurnn/orgs","repos_url":"https://api.github.com/users/arthurnn/repos","events_url":"https://api.github.com/users/arthurnn/events{/privacy}","received_events_url":"https://api.github.com/users/arthurnn/received_events","type":"User","site_admin":true},"milestone":null,"comments":5,"created_at":"2015-12-02T19:04:35Z","updated_at":"2015-12-02T20:20:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/22469","html_url":"https://github.com/rails/rails/pull/22469","diff_url":"https://github.com/rails/rails/pull/22469.diff","patch_url":"https://github.com/rails/rails/pull/22469.patch"},"body":"LoadingTest#test_does_not_reload_constants_on_development_if_custom_file_watcher_always_returns_false in railties/test/application/loading_test.rb is failing with: `NoMethodError: undefined method 'execute' for #<#<Class:0x00000002465a30>:0x00000001f79698>`\r\n\r\nThe test creates an anonymous class to be used as a custom file watcher using `config.file_watcher=`. Per the Rails guides for Configuring, the class set to `config.file_watcher`:\r\n> Must conform to ActiveSupport::FileUpdateChecker API.\r\n\r\nPer the docs for ActiveSupport::FileUpdateChecker, the API depends on four methods: #initialize, #updated?, #execute, and #execute_if_updated. The custom file watcher in the failing test only implements the first two methods.\r\n\r\nThis pull request adds #execute and #execute_if_updated to the custom file_watcher, conforming it to the ActiveSupport::FileUpdateChecker API, and passing the test."},"comment":{"url":"https://api.github.com/repos/rails/rails/issues/comments/161421855","html_url":"https://github.com/rails/rails/pull/22469#issuecomment-161421855","issue_url":"https://api.github.com/repos/rails/rails/issues/22469","id":161421855,"user":{"login":"rafaelfranca","id":47848,"avatar_url":"https://avatars.githubusercontent.com/u/47848?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false},"created_at":"2015-12-02T20:20:37Z","updated_at":"2015-12-02T20:20:37Z","body":":+1: to revert for now."}}