{"action":"created","issue":{"url":"https://api.github.com/repos/mathiasverraes/money/issues/115","labels_url":"https://api.github.com/repos/mathiasverraes/money/issues/115/labels{/name}","comments_url":"https://api.github.com/repos/mathiasverraes/money/issues/115/comments","events_url":"https://api.github.com/repos/mathiasverraes/money/issues/115/events","html_url":"https://github.com/mathiasverraes/money/pull/115","id":123665014,"number":115,"title":"deal with integer limits","user":{"login":"frederikbosch","id":1552577,"avatar_url":"https://avatars.githubusercontent.com/u/1552577?v=3","gravatar_id":"","url":"https://api.github.com/users/frederikbosch","html_url":"https://github.com/frederikbosch","followers_url":"https://api.github.com/users/frederikbosch/followers","following_url":"https://api.github.com/users/frederikbosch/following{/other_user}","gists_url":"https://api.github.com/users/frederikbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/frederikbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frederikbosch/subscriptions","organizations_url":"https://api.github.com/users/frederikbosch/orgs","repos_url":"https://api.github.com/users/frederikbosch/repos","events_url":"https://api.github.com/users/frederikbosch/events{/privacy}","received_events_url":"https://api.github.com/users/frederikbosch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-12-23T14:05:42Z","updated_at":"2015-12-28T15:18:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mathiasverraes/money/pulls/115","html_url":"https://github.com/mathiasverraes/money/pull/115","diff_url":"https://github.com/mathiasverraes/money/pull/115.diff","patch_url":"https://github.com/mathiasverraes/money/pull/115.patch"},"body":"Solves #111.\r\n\r\nProbably has quite some impact on the library. Review carefully. Rather see some more comments on the design decisions than on some PSR-2 compliance. The latter will be solved - if there is any compliance oversights - when there is agreement on the design.\r\n\r\nHard aspect of this PR was rounding in GMP and BC Math libraries. Had a look at some other libraries for this to implement."},"comment":{"url":"https://api.github.com/repos/mathiasverraes/money/issues/comments/167586809","html_url":"https://github.com/mathiasverraes/money/pull/115#issuecomment-167586809","issue_url":"https://api.github.com/repos/mathiasverraes/money/issues/115","id":167586809,"user":{"login":"frederikbosch","id":1552577,"avatar_url":"https://avatars.githubusercontent.com/u/1552577?v=3","gravatar_id":"","url":"https://api.github.com/users/frederikbosch","html_url":"https://github.com/frederikbosch","followers_url":"https://api.github.com/users/frederikbosch/followers","following_url":"https://api.github.com/users/frederikbosch/following{/other_user}","gists_url":"https://api.github.com/users/frederikbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/frederikbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frederikbosch/subscriptions","organizations_url":"https://api.github.com/users/frederikbosch/orgs","repos_url":"https://api.github.com/users/frederikbosch/repos","events_url":"https://api.github.com/users/frederikbosch/events{/privacy}","received_events_url":"https://api.github.com/users/frederikbosch/received_events","type":"User","site_admin":false},"created_at":"2015-12-28T15:18:33Z","updated_at":"2015-12-28T15:18:33Z","body":"@sagikazarmark No, that is whole point of no integer limits, right? Big integer (bigger than php's max int) can only be expressed in string, not in integers."}}