{"action":"closed","number":72,"pull_request":{"url":"https://api.github.com/repos/mmagnuski/eegDb/pulls/72","id":36970750,"html_url":"https://github.com/mmagnuski/eegDb/pull/72","diff_url":"https://github.com/mmagnuski/eegDb/pull/72.diff","patch_url":"https://github.com/mmagnuski/eegDb/pull/72.patch","issue_url":"https://api.github.com/repos/mmagnuski/eegDb/issues/72","number":72,"state":"closed","locked":false,"title":"KeyboardManager object for reacting to sequences of key presses","user":{"login":"mmagnuski","id":8452354,"avatar_url":"https://avatars.githubusercontent.com/u/8452354?v=3","gravatar_id":"","url":"https://api.github.com/users/mmagnuski","html_url":"https://github.com/mmagnuski","followers_url":"https://api.github.com/users/mmagnuski/followers","following_url":"https://api.github.com/users/mmagnuski/following{/other_user}","gists_url":"https://api.github.com/users/mmagnuski/gists{/gist_id}","starred_url":"https://api.github.com/users/mmagnuski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmagnuski/subscriptions","organizations_url":"https://api.github.com/users/mmagnuski/orgs","repos_url":"https://api.github.com/users/mmagnuski/repos","events_url":"https://api.github.com/users/mmagnuski/events{/privacy}","received_events_url":"https://api.github.com/users/mmagnuski/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis PR refactors previous `eegplot_readkey_new` to be object-oriented, more convinient and elegant.\r\nIt also adds an `eval` method to `KeyboardManager` and `fastplot`. This method allows to pass strings to `KeyboardManager` to be evaluated as if they were actual key presses.\r\nBecause matlab's object oriented programming is slower than its default function-calling way I will have to test whether this does not slow `fastplot` significantly.\r\n\r\n### TODOs:\r\n- [x] test speed of KeyboardManager vs eegplot_readky_new\r\n- [x] add option to interpret `>` as arrow key presses in `KeyboardManager.eval()`","created_at":"2015-06-04T19:45:37Z","updated_at":"2015-06-07T01:04:39Z","closed_at":"2015-06-07T01:04:39Z","merged_at":"2015-06-07T01:04:39Z","merge_commit_sha":"e50ff07150942786d333c42a547056d63ba5b239","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mmagnuski/eegDb/pulls/72/commits","review_comments_url":"https://api.github.com/repos/mmagnuski/eegDb/pulls/72/comments","review_comment_url":"https://api.github.com/repos/mmagnuski/eegDb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mmagnuski/eegDb/issues/72/comments","statuses_url":"https://api.github.com/repos/mmagnuski/eegDb/statuses/81c015bd833b6fb2d93699cca85f79f2d2f5f8ef","head":{"label":"mmagnuski:rf_keyboard_manager","ref":"rf_keyboard_manager","sha":"81c015bd833b6fb2d93699cca85f79f2d2f5f8ef","user":{"login":"mmagnuski","id":8452354,"avatar_url":"https://avatars.githubusercontent.com/u/8452354?v=3","gravatar_id":"","url":"https://api.github.com/users/mmagnuski","html_url":"https://github.com/mmagnuski","followers_url":"https://api.github.com/users/mmagnuski/followers","following_url":"https://api.github.com/users/mmagnuski/following{/other_user}","gists_url":"https://api.github.com/users/mmagnuski/gists{/gist_id}","starred_url":"https://api.github.com/users/mmagnuski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmagnuski/subscriptions","organizations_url":"https://api.github.com/users/mmagnuski/orgs","repos_url":"https://api.github.com/users/mmagnuski/repos","events_url":"https://api.github.com/users/mmagnuski/events{/privacy}","received_events_url":"https://api.github.com/users/mmagnuski/received_events","type":"User","site_admin":false},"repo":{"id":22987506,"name":"eegDb","full_name":"mmagnuski/eegDb","owner":{"login":"mmagnuski","id":8452354,"avatar_url":"https://avatars.githubusercontent.com/u/8452354?v=3","gravatar_id":"","url":"https://api.github.com/users/mmagnuski","html_url":"https://github.com/mmagnuski","followers_url":"https://api.github.com/users/mmagnuski/followers","following_url":"https://api.github.com/users/mmagnuski/following{/other_user}","gists_url":"https://api.github.com/users/mmagnuski/gists{/gist_id}","starred_url":"https://api.github.com/users/mmagnuski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmagnuski/subscriptions","organizations_url":"https://api.github.com/users/mmagnuski/orgs","repos_url":"https://api.github.com/users/mmagnuski/repos","events_url":"https://api.github.com/users/mmagnuski/events{/privacy}","received_events_url":"https://api.github.com/users/mmagnuski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmagnuski/eegDb","description":"eegDb is an egglab plugin that eases up managing preprocessing routines. It allows to create project databases for reproducible eeg preprocessing with eeglab.","fork":false,"url":"https://api.github.com/repos/mmagnuski/eegDb","forks_url":"https://api.github.com/repos/mmagnuski/eegDb/forks","keys_url":"https://api.github.com/repos/mmagnuski/eegDb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmagnuski/eegDb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmagnuski/eegDb/teams","hooks_url":"https://api.github.com/repos/mmagnuski/eegDb/hooks","issue_events_url":"https://api.github.com/repos/mmagnuski/eegDb/issues/events{/number}","events_url":"https://api.github.com/repos/mmagnuski/eegDb/events","assignees_url":"https://api.github.com/repos/mmagnuski/eegDb/assignees{/user}","branches_url":"https://api.github.com/repos/mmagnuski/eegDb/branches{/branch}","tags_url":"https://api.github.com/repos/mmagnuski/eegDb/tags","blobs_url":"https://api.github.com/repos/mmagnuski/eegDb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmagnuski/eegDb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmagnuski/eegDb/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmagnuski/eegDb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmagnuski/eegDb/statuses/{sha}","languages_url":"https://api.github.com/repos/mmagnuski/eegDb/languages","stargazers_url":"https://api.github.com/repos/mmagnuski/eegDb/stargazers","contributors_url":"https://api.github.com/repos/mmagnuski/eegDb/contributors","subscribers_url":"https://api.github.com/repos/mmagnuski/eegDb/subscribers","subscription_url":"https://api.github.com/repos/mmagnuski/eegDb/subscription","commits_url":"https://api.github.com/repos/mmagnuski/eegDb/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmagnuski/eegDb/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmagnuski/eegDb/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmagnuski/eegDb/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmagnuski/eegDb/contents/{+path}","compare_url":"https://api.github.com/repos/mmagnuski/eegDb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmagnuski/eegDb/merges","archive_url":"https://api.github.com/repos/mmagnuski/eegDb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmagnuski/eegDb/downloads","issues_url":"https://api.github.com/repos/mmagnuski/eegDb/issues{/number}","pulls_url":"https://api.github.com/repos/mmagnuski/eegDb/pulls{/number}","milestones_url":"https://api.github.com/repos/mmagnuski/eegDb/milestones{/number}","notifications_url":"https://api.github.com/repos/mmagnuski/eegDb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmagnuski/eegDb/labels{/name}","releases_url":"https://api.github.com/repos/mmagnuski/eegDb/releases{/id}","created_at":"2014-08-15T11:22:48Z","updated_at":"2015-04-29T14:47:16Z","pushed_at":"2015-06-07T01:04:39Z","git_url":"git://github.com/mmagnuski/eegDb.git","ssh_url":"git@github.com:mmagnuski/eegDb.git","clone_url":"https://github.com/mmagnuski/eegDb.git","svn_url":"https://github.com/mmagnuski/eegDb","homepage":null,"size":175206,"stargazers_count":2,"watchers_count":2,"language":"Matlab","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":27,"forks":2,"open_issues":27,"watchers":2,"default_branch":"master"}},"base":{"label":"mmagnuski:master","ref":"master","sha":"407106b1d11f0cd0c02e75d8536c286f97fac614","user":{"login":"mmagnuski","id":8452354,"avatar_url":"https://avatars.githubusercontent.com/u/8452354?v=3","gravatar_id":"","url":"https://api.github.com/users/mmagnuski","html_url":"https://github.com/mmagnuski","followers_url":"https://api.github.com/users/mmagnuski/followers","following_url":"https://api.github.com/users/mmagnuski/following{/other_user}","gists_url":"https://api.github.com/users/mmagnuski/gists{/gist_id}","starred_url":"https://api.github.com/users/mmagnuski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmagnuski/subscriptions","organizations_url":"https://api.github.com/users/mmagnuski/orgs","repos_url":"https://api.github.com/users/mmagnuski/repos","events_url":"https://api.github.com/users/mmagnuski/events{/privacy}","received_events_url":"https://api.github.com/users/mmagnuski/received_events","type":"User","site_admin":false},"repo":{"id":22987506,"name":"eegDb","full_name":"mmagnuski/eegDb","owner":{"login":"mmagnuski","id":8452354,"avatar_url":"https://avatars.githubusercontent.com/u/8452354?v=3","gravatar_id":"","url":"https://api.github.com/users/mmagnuski","html_url":"https://github.com/mmagnuski","followers_url":"https://api.github.com/users/mmagnuski/followers","following_url":"https://api.github.com/users/mmagnuski/following{/other_user}","gists_url":"https://api.github.com/users/mmagnuski/gists{/gist_id}","starred_url":"https://api.github.com/users/mmagnuski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmagnuski/subscriptions","organizations_url":"https://api.github.com/users/mmagnuski/orgs","repos_url":"https://api.github.com/users/mmagnuski/repos","events_url":"https://api.github.com/users/mmagnuski/events{/privacy}","received_events_url":"https://api.github.com/users/mmagnuski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmagnuski/eegDb","description":"eegDb is an egglab plugin that eases up managing preprocessing routines. It allows to create project databases for reproducible eeg preprocessing with eeglab.","fork":false,"url":"https://api.github.com/repos/mmagnuski/eegDb","forks_url":"https://api.github.com/repos/mmagnuski/eegDb/forks","keys_url":"https://api.github.com/repos/mmagnuski/eegDb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmagnuski/eegDb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmagnuski/eegDb/teams","hooks_url":"https://api.github.com/repos/mmagnuski/eegDb/hooks","issue_events_url":"https://api.github.com/repos/mmagnuski/eegDb/issues/events{/number}","events_url":"https://api.github.com/repos/mmagnuski/eegDb/events","assignees_url":"https://api.github.com/repos/mmagnuski/eegDb/assignees{/user}","branches_url":"https://api.github.com/repos/mmagnuski/eegDb/branches{/branch}","tags_url":"https://api.github.com/repos/mmagnuski/eegDb/tags","blobs_url":"https://api.github.com/repos/mmagnuski/eegDb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmagnuski/eegDb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmagnuski/eegDb/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmagnuski/eegDb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmagnuski/eegDb/statuses/{sha}","languages_url":"https://api.github.com/repos/mmagnuski/eegDb/languages","stargazers_url":"https://api.github.com/repos/mmagnuski/eegDb/stargazers","contributors_url":"https://api.github.com/repos/mmagnuski/eegDb/contributors","subscribers_url":"https://api.github.com/repos/mmagnuski/eegDb/subscribers","subscription_url":"https://api.github.com/repos/mmagnuski/eegDb/subscription","commits_url":"https://api.github.com/repos/mmagnuski/eegDb/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmagnuski/eegDb/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmagnuski/eegDb/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmagnuski/eegDb/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmagnuski/eegDb/contents/{+path}","compare_url":"https://api.github.com/repos/mmagnuski/eegDb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmagnuski/eegDb/merges","archive_url":"https://api.github.com/repos/mmagnuski/eegDb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmagnuski/eegDb/downloads","issues_url":"https://api.github.com/repos/mmagnuski/eegDb/issues{/number}","pulls_url":"https://api.github.com/repos/mmagnuski/eegDb/pulls{/number}","milestones_url":"https://api.github.com/repos/mmagnuski/eegDb/milestones{/number}","notifications_url":"https://api.github.com/repos/mmagnuski/eegDb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmagnuski/eegDb/labels{/name}","releases_url":"https://api.github.com/repos/mmagnuski/eegDb/releases{/id}","created_at":"2014-08-15T11:22:48Z","updated_at":"2015-04-29T14:47:16Z","pushed_at":"2015-06-07T01:04:39Z","git_url":"git://github.com/mmagnuski/eegDb.git","ssh_url":"git@github.com:mmagnuski/eegDb.git","clone_url":"https://github.com/mmagnuski/eegDb.git","svn_url":"https://github.com/mmagnuski/eegDb","homepage":null,"size":175206,"stargazers_count":2,"watchers_count":2,"language":"Matlab","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":27,"forks":2,"open_issues":27,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mmagnuski/eegDb/pulls/72"},"html":{"href":"https://github.com/mmagnuski/eegDb/pull/72"},"issue":{"href":"https://api.github.com/repos/mmagnuski/eegDb/issues/72"},"comments":{"href":"https://api.github.com/repos/mmagnuski/eegDb/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/mmagnuski/eegDb/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/mmagnuski/eegDb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mmagnuski/eegDb/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/mmagnuski/eegDb/statuses/81c015bd833b6fb2d93699cca85f79f2d2f5f8ef"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mmagnuski","id":8452354,"avatar_url":"https://avatars.githubusercontent.com/u/8452354?v=3","gravatar_id":"","url":"https://api.github.com/users/mmagnuski","html_url":"https://github.com/mmagnuski","followers_url":"https://api.github.com/users/mmagnuski/followers","following_url":"https://api.github.com/users/mmagnuski/following{/other_user}","gists_url":"https://api.github.com/users/mmagnuski/gists{/gist_id}","starred_url":"https://api.github.com/users/mmagnuski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmagnuski/subscriptions","organizations_url":"https://api.github.com/users/mmagnuski/orgs","repos_url":"https://api.github.com/users/mmagnuski/repos","events_url":"https://api.github.com/users/mmagnuski/events{/privacy}","received_events_url":"https://api.github.com/users/mmagnuski/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":3,"additions":213,"deletions":5,"changed_files":2}}