{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/23097713","id":23097713,"diff_hunk":"@@ -52,23 +52,23 @@ def self.to_role(server_role)\n   end\n \n   def self.all_names\n-    self.find(:all, :order => :name, :select => \"id, name\").collect { |r| r.name }\n+    self.order(:name).pluck(:name)","path":"vmdb/app/models/server_role.rb","position":23,"original_position":23,"commit_id":"3b51c9c9309e5d4ba92a281b9a3645bc9e7d41b2","original_commit_id":"1fe11a95aacf7bae12791a79384fd1836ef77838","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"body":"Good point, it's probably better to put it back when it fails then to proactively put possibly unused selects.","created_at":"2015-01-16T18:10:45Z","updated_at":"2015-01-16T18:10:45Z","html_url":"https://github.com/ManageIQ/manageiq/pull/1351#discussion_r23097713","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1351","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/23097713"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/1351#discussion_r23097713"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1351"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1351","id":27233400,"html_url":"https://github.com/ManageIQ/manageiq/pull/1351","diff_url":"https://github.com/ManageIQ/manageiq/pull/1351.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/1351.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1351","number":1351,"state":"open","locked":false,"title":"Convert rails 2 finders to arel for rails 3/4","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"body":"Note: this commit was required to be able to use arel_converter to mass convert some of the remaining rails 2 finders:  https://github.com/jrafanie/manageiq/commit/73968a0ca0ba5e09a8166281c2fb07ae492f634e\r\n\r\nI can split this PR up if needed.","created_at":"2015-01-12T22:48:31Z","updated_at":"2015-01-16T18:10:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d9b1b8a7bf8e7345c8e3ef7ab85f008ff701226","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1351/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1351/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1351/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/3b51c9c9309e5d4ba92a281b9a3645bc9e7d41b2","head":{"label":"jrafanie:finder2","ref":"finder2","sha":"3b51c9c9309e5d4ba92a281b9a3645bc9e7d41b2","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"repo":{"id":20803842,"name":"manageiq","full_name":"jrafanie/manageiq","owner":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrafanie/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/jrafanie/manageiq","forks_url":"https://api.github.com/repos/jrafanie/manageiq/forks","keys_url":"https://api.github.com/repos/jrafanie/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrafanie/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrafanie/manageiq/teams","hooks_url":"https://api.github.com/repos/jrafanie/manageiq/hooks","issue_events_url":"https://api.github.com/repos/jrafanie/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/jrafanie/manageiq/events","assignees_url":"https://api.github.com/repos/jrafanie/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/jrafanie/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/jrafanie/manageiq/tags","blobs_url":"https://api.github.com/repos/jrafanie/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrafanie/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrafanie/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrafanie/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrafanie/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/jrafanie/manageiq/languages","stargazers_url":"https://api.github.com/repos/jrafanie/manageiq/stargazers","contributors_url":"https://api.github.com/repos/jrafanie/manageiq/contributors","subscribers_url":"https://api.github.com/repos/jrafanie/manageiq/subscribers","subscription_url":"https://api.github.com/repos/jrafanie/manageiq/subscription","commits_url":"https://api.github.com/repos/jrafanie/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrafanie/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrafanie/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrafanie/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/jrafanie/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/jrafanie/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrafanie/manageiq/merges","archive_url":"https://api.github.com/repos/jrafanie/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrafanie/manageiq/downloads","issues_url":"https://api.github.com/repos/jrafanie/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/jrafanie/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/jrafanie/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/jrafanie/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrafanie/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/jrafanie/manageiq/releases{/id}","created_at":"2014-06-13T12:47:01Z","updated_at":"2015-01-14T15:21:32Z","pushed_at":"2015-01-15T20:56:17Z","git_url":"git://github.com/jrafanie/manageiq.git","ssh_url":"git@github.com:jrafanie/manageiq.git","clone_url":"https://github.com/jrafanie/manageiq.git","svn_url":"https://github.com/jrafanie/manageiq","homepage":null,"size":61779,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"e45b80af12e772fce666eae153e3b9614f654ad0","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-01-16T15:59:23Z","pushed_at":"2015-01-16T15:59:23Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":85083,"stargazers_count":77,"watchers_count":77,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":81,"mirror_url":null,"open_issues_count":223,"forks":81,"open_issues":223,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1351"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/1351"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/1351"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/1351/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1351/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1351/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/3b51c9c9309e5d4ba92a281b9a3645bc9e7d41b2"}}}}