{"action":"created","issue":{"url":"https://api.github.com/repos/dart-lang/logging/issues/1","labels_url":"https://api.github.com/repos/dart-lang/logging/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/logging/issues/1/comments","events_url":"https://api.github.com/repos/dart-lang/logging/issues/1/events","html_url":"https://github.com/dart-lang/logging/pull/1","id":67590949,"number":1,"title":"Allow a greater range of types as a stack trace","user":{"login":"Fox32","id":648527,"avatar_url":"https://avatars.githubusercontent.com/u/648527?v=3","gravatar_id":"","url":"https://api.github.com/users/Fox32","html_url":"https://github.com/Fox32","followers_url":"https://api.github.com/users/Fox32/followers","following_url":"https://api.github.com/users/Fox32/following{/other_user}","gists_url":"https://api.github.com/users/Fox32/gists{/gist_id}","starred_url":"https://api.github.com/users/Fox32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fox32/subscriptions","organizations_url":"https://api.github.com/users/Fox32/orgs","repos_url":"https://api.github.com/users/Fox32/repos","events_url":"https://api.github.com/users/Fox32/events{/privacy}","received_events_url":"https://api.github.com/users/Fox32/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2015-04-10T13:06:44Z","updated_at":"2015-04-13T15:23:43Z","closed_at":"2015-04-10T17:07:05Z","pull_request":{"url":"https://api.github.com/repos/dart-lang/logging/pulls/1","html_url":"https://github.com/dart-lang/logging/pull/1","diff_url":"https://github.com/dart-lang/logging/pull/1.diff","patch_url":"https://github.com/dart-lang/logging/pull/1.patch"},"body":"I'm currently working with isolates and notices the following problem: The callback registered with an ```addErrorListener``` on an isolate received an error and a ```String``` as a stack trace. However, ```LogRecord``` expects for ```stackTrace``` a ```StackTrace```. I expect this is a limitation of the isolate library and not solvable there. This means I can't pass the received stack trace to the ```LogRecord```.\r\n\r\nThis pull request changes the type of ```stackTrace``` to ```Object``` so that one can also pass a ```String```. The ```error``` member is already of type ```Object```. That wouldn't change any behavior but would allow for a broader usage.\r\n"},"comment":{"url":"https://api.github.com/repos/dart-lang/logging/issues/comments/92400421","html_url":"https://github.com/dart-lang/logging/pull/1#issuecomment-92400421","issue_url":"https://api.github.com/repos/dart-lang/logging/issues/1","id":92400421,"user":{"login":"sgjesse","id":1343914,"avatar_url":"https://avatars.githubusercontent.com/u/1343914?v=3","gravatar_id":"","url":"https://api.github.com/users/sgjesse","html_url":"https://github.com/sgjesse","followers_url":"https://api.github.com/users/sgjesse/followers","following_url":"https://api.github.com/users/sgjesse/following{/other_user}","gists_url":"https://api.github.com/users/sgjesse/gists{/gist_id}","starred_url":"https://api.github.com/users/sgjesse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgjesse/subscriptions","organizations_url":"https://api.github.com/users/sgjesse/orgs","repos_url":"https://api.github.com/users/sgjesse/repos","events_url":"https://api.github.com/users/sgjesse/events{/privacy}","received_events_url":"https://api.github.com/users/sgjesse/received_events","type":"User","site_admin":false},"created_at":"2015-04-13T15:23:43Z","updated_at":"2015-04-13T15:23:43Z","body":"I don't think this is the right solution. The `StackTrace` interface is simple - it only has `toString`, so implementing it and including the provided stacktrace should be simple. To make it even simpler we added a `fromString` to `StackTrace`, see https://code.google.com/p/dart/source/detail?r=45088. The problem with this change is that reverting it becomes a breaking change with this version already published."}}