{"action":"closed","number":19,"pull_request":{"url":"https://api.github.com/repos/wickedest/Mergely/pulls/19","id":28035693,"html_url":"https://github.com/wickedest/Mergely/pull/19","diff_url":"https://github.com/wickedest/Mergely/pull/19.diff","patch_url":"https://github.com/wickedest/Mergely/pull/19.patch","issue_url":"https://api.github.com/repos/wickedest/Mergely/issues/19","number":19,"state":"closed","locked":false,"title":"Removed resize handler on teardown","user":{"login":"TheT0dd","id":1975562,"avatar_url":"https://avatars.githubusercontent.com/u/1975562?v=3","gravatar_id":"","url":"https://api.github.com/users/TheT0dd","html_url":"https://github.com/TheT0dd","followers_url":"https://api.github.com/users/TheT0dd/followers","following_url":"https://api.github.com/users/TheT0dd/following{/other_user}","gists_url":"https://api.github.com/users/TheT0dd/gists{/gist_id}","starred_url":"https://api.github.com/users/TheT0dd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheT0dd/subscriptions","organizations_url":"https://api.github.com/users/TheT0dd/orgs","repos_url":"https://api.github.com/users/TheT0dd/repos","events_url":"https://api.github.com/users/TheT0dd/events{/privacy}","received_events_url":"https://api.github.com/users/TheT0dd/received_events","type":"User","site_admin":false},"body":"The [resize handler] (https://github.com/wickedest/Mergely/blob/master/lib/mergely.js#L702-707) registered on window during `bind` was never removed during `unbind`, which caused a memory leak and \"Failed to find canvas\" exceptions after `destroy`ing mergely.\r\n\r\nI simply namespace the resize event and on `unbind` I remove it alongside all  `mergely` namespaced events.","created_at":"2015-01-26T15:45:57Z","updated_at":"2015-01-27T20:24:07Z","closed_at":"2015-01-27T20:24:07Z","merged_at":"2015-01-27T20:24:07Z","merge_commit_sha":"5d3242b7efff9dbc40cc4c14f56246308408ba23","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wickedest/Mergely/pulls/19/commits","review_comments_url":"https://api.github.com/repos/wickedest/Mergely/pulls/19/comments","review_comment_url":"https://api.github.com/repos/wickedest/Mergely/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wickedest/Mergely/issues/19/comments","statuses_url":"https://api.github.com/repos/wickedest/Mergely/statuses/0a069a061aae1628da21521753b5adbe1fdcaa30","head":{"label":"TheT0dd:resize-handler-cleanup","ref":"resize-handler-cleanup","sha":"0a069a061aae1628da21521753b5adbe1fdcaa30","user":{"login":"TheT0dd","id":1975562,"avatar_url":"https://avatars.githubusercontent.com/u/1975562?v=3","gravatar_id":"","url":"https://api.github.com/users/TheT0dd","html_url":"https://github.com/TheT0dd","followers_url":"https://api.github.com/users/TheT0dd/followers","following_url":"https://api.github.com/users/TheT0dd/following{/other_user}","gists_url":"https://api.github.com/users/TheT0dd/gists{/gist_id}","starred_url":"https://api.github.com/users/TheT0dd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheT0dd/subscriptions","organizations_url":"https://api.github.com/users/TheT0dd/orgs","repos_url":"https://api.github.com/users/TheT0dd/repos","events_url":"https://api.github.com/users/TheT0dd/events{/privacy}","received_events_url":"https://api.github.com/users/TheT0dd/received_events","type":"User","site_admin":false},"repo":{"id":29866877,"name":"Mergely","full_name":"TheT0dd/Mergely","owner":{"login":"TheT0dd","id":1975562,"avatar_url":"https://avatars.githubusercontent.com/u/1975562?v=3","gravatar_id":"","url":"https://api.github.com/users/TheT0dd","html_url":"https://github.com/TheT0dd","followers_url":"https://api.github.com/users/TheT0dd/followers","following_url":"https://api.github.com/users/TheT0dd/following{/other_user}","gists_url":"https://api.github.com/users/TheT0dd/gists{/gist_id}","starred_url":"https://api.github.com/users/TheT0dd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheT0dd/subscriptions","organizations_url":"https://api.github.com/users/TheT0dd/orgs","repos_url":"https://api.github.com/users/TheT0dd/repos","events_url":"https://api.github.com/users/TheT0dd/events{/privacy}","received_events_url":"https://api.github.com/users/TheT0dd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheT0dd/Mergely","description":"Merge and diff documents online","fork":true,"url":"https://api.github.com/repos/TheT0dd/Mergely","forks_url":"https://api.github.com/repos/TheT0dd/Mergely/forks","keys_url":"https://api.github.com/repos/TheT0dd/Mergely/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheT0dd/Mergely/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheT0dd/Mergely/teams","hooks_url":"https://api.github.com/repos/TheT0dd/Mergely/hooks","issue_events_url":"https://api.github.com/repos/TheT0dd/Mergely/issues/events{/number}","events_url":"https://api.github.com/repos/TheT0dd/Mergely/events","assignees_url":"https://api.github.com/repos/TheT0dd/Mergely/assignees{/user}","branches_url":"https://api.github.com/repos/TheT0dd/Mergely/branches{/branch}","tags_url":"https://api.github.com/repos/TheT0dd/Mergely/tags","blobs_url":"https://api.github.com/repos/TheT0dd/Mergely/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheT0dd/Mergely/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheT0dd/Mergely/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheT0dd/Mergely/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheT0dd/Mergely/statuses/{sha}","languages_url":"https://api.github.com/repos/TheT0dd/Mergely/languages","stargazers_url":"https://api.github.com/repos/TheT0dd/Mergely/stargazers","contributors_url":"https://api.github.com/repos/TheT0dd/Mergely/contributors","subscribers_url":"https://api.github.com/repos/TheT0dd/Mergely/subscribers","subscription_url":"https://api.github.com/repos/TheT0dd/Mergely/subscription","commits_url":"https://api.github.com/repos/TheT0dd/Mergely/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheT0dd/Mergely/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheT0dd/Mergely/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheT0dd/Mergely/issues/comments/{number}","contents_url":"https://api.github.com/repos/TheT0dd/Mergely/contents/{+path}","compare_url":"https://api.github.com/repos/TheT0dd/Mergely/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheT0dd/Mergely/merges","archive_url":"https://api.github.com/repos/TheT0dd/Mergely/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheT0dd/Mergely/downloads","issues_url":"https://api.github.com/repos/TheT0dd/Mergely/issues{/number}","pulls_url":"https://api.github.com/repos/TheT0dd/Mergely/pulls{/number}","milestones_url":"https://api.github.com/repos/TheT0dd/Mergely/milestones{/number}","notifications_url":"https://api.github.com/repos/TheT0dd/Mergely/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheT0dd/Mergely/labels{/name}","releases_url":"https://api.github.com/repos/TheT0dd/Mergely/releases{/id}","created_at":"2015-01-26T15:23:43Z","updated_at":"2015-01-26T15:23:43Z","pushed_at":"2015-01-26T15:32:13Z","git_url":"git://github.com/TheT0dd/Mergely.git","ssh_url":"git@github.com:TheT0dd/Mergely.git","clone_url":"https://github.com/TheT0dd/Mergely.git","svn_url":"https://github.com/TheT0dd/Mergely","homepage":"http://www.mergely.com","size":929,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wickedest:master","ref":"master","sha":"36152678990eb102c195eea5dd0b028ce1af4897","user":{"login":"wickedest","id":871639,"avatar_url":"https://avatars.githubusercontent.com/u/871639?v=3","gravatar_id":"","url":"https://api.github.com/users/wickedest","html_url":"https://github.com/wickedest","followers_url":"https://api.github.com/users/wickedest/followers","following_url":"https://api.github.com/users/wickedest/following{/other_user}","gists_url":"https://api.github.com/users/wickedest/gists{/gist_id}","starred_url":"https://api.github.com/users/wickedest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wickedest/subscriptions","organizations_url":"https://api.github.com/users/wickedest/orgs","repos_url":"https://api.github.com/users/wickedest/repos","events_url":"https://api.github.com/users/wickedest/events{/privacy}","received_events_url":"https://api.github.com/users/wickedest/received_events","type":"User","site_admin":false},"repo":{"id":3640908,"name":"Mergely","full_name":"wickedest/Mergely","owner":{"login":"wickedest","id":871639,"avatar_url":"https://avatars.githubusercontent.com/u/871639?v=3","gravatar_id":"","url":"https://api.github.com/users/wickedest","html_url":"https://github.com/wickedest","followers_url":"https://api.github.com/users/wickedest/followers","following_url":"https://api.github.com/users/wickedest/following{/other_user}","gists_url":"https://api.github.com/users/wickedest/gists{/gist_id}","starred_url":"https://api.github.com/users/wickedest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wickedest/subscriptions","organizations_url":"https://api.github.com/users/wickedest/orgs","repos_url":"https://api.github.com/users/wickedest/repos","events_url":"https://api.github.com/users/wickedest/events{/privacy}","received_events_url":"https://api.github.com/users/wickedest/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wickedest/Mergely","description":"Merge and diff documents online","fork":false,"url":"https://api.github.com/repos/wickedest/Mergely","forks_url":"https://api.github.com/repos/wickedest/Mergely/forks","keys_url":"https://api.github.com/repos/wickedest/Mergely/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wickedest/Mergely/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wickedest/Mergely/teams","hooks_url":"https://api.github.com/repos/wickedest/Mergely/hooks","issue_events_url":"https://api.github.com/repos/wickedest/Mergely/issues/events{/number}","events_url":"https://api.github.com/repos/wickedest/Mergely/events","assignees_url":"https://api.github.com/repos/wickedest/Mergely/assignees{/user}","branches_url":"https://api.github.com/repos/wickedest/Mergely/branches{/branch}","tags_url":"https://api.github.com/repos/wickedest/Mergely/tags","blobs_url":"https://api.github.com/repos/wickedest/Mergely/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wickedest/Mergely/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wickedest/Mergely/git/refs{/sha}","trees_url":"https://api.github.com/repos/wickedest/Mergely/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wickedest/Mergely/statuses/{sha}","languages_url":"https://api.github.com/repos/wickedest/Mergely/languages","stargazers_url":"https://api.github.com/repos/wickedest/Mergely/stargazers","contributors_url":"https://api.github.com/repos/wickedest/Mergely/contributors","subscribers_url":"https://api.github.com/repos/wickedest/Mergely/subscribers","subscription_url":"https://api.github.com/repos/wickedest/Mergely/subscription","commits_url":"https://api.github.com/repos/wickedest/Mergely/commits{/sha}","git_commits_url":"https://api.github.com/repos/wickedest/Mergely/git/commits{/sha}","comments_url":"https://api.github.com/repos/wickedest/Mergely/comments{/number}","issue_comment_url":"https://api.github.com/repos/wickedest/Mergely/issues/comments/{number}","contents_url":"https://api.github.com/repos/wickedest/Mergely/contents/{+path}","compare_url":"https://api.github.com/repos/wickedest/Mergely/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wickedest/Mergely/merges","archive_url":"https://api.github.com/repos/wickedest/Mergely/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wickedest/Mergely/downloads","issues_url":"https://api.github.com/repos/wickedest/Mergely/issues{/number}","pulls_url":"https://api.github.com/repos/wickedest/Mergely/pulls{/number}","milestones_url":"https://api.github.com/repos/wickedest/Mergely/milestones{/number}","notifications_url":"https://api.github.com/repos/wickedest/Mergely/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wickedest/Mergely/labels{/name}","releases_url":"https://api.github.com/repos/wickedest/Mergely/releases{/id}","created_at":"2012-03-06T18:06:46Z","updated_at":"2015-01-27T04:44:38Z","pushed_at":"2015-01-27T20:24:07Z","git_url":"git://github.com/wickedest/Mergely.git","ssh_url":"git@github.com:wickedest/Mergely.git","clone_url":"https://github.com/wickedest/Mergely.git","svn_url":"https://github.com/wickedest/Mergely","homepage":"http://www.mergely.com","size":929,"stargazers_count":245,"watchers_count":245,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":2,"forks":54,"open_issues":2,"watchers":245,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wickedest/Mergely/pulls/19"},"html":{"href":"https://github.com/wickedest/Mergely/pull/19"},"issue":{"href":"https://api.github.com/repos/wickedest/Mergely/issues/19"},"comments":{"href":"https://api.github.com/repos/wickedest/Mergely/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/wickedest/Mergely/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/wickedest/Mergely/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wickedest/Mergely/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/wickedest/Mergely/statuses/0a069a061aae1628da21521753b5adbe1fdcaa30"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"wickedest","id":871639,"avatar_url":"https://avatars.githubusercontent.com/u/871639?v=3","gravatar_id":"","url":"https://api.github.com/users/wickedest","html_url":"https://github.com/wickedest","followers_url":"https://api.github.com/users/wickedest/followers","following_url":"https://api.github.com/users/wickedest/following{/other_user}","gists_url":"https://api.github.com/users/wickedest/gists{/gist_id}","starred_url":"https://api.github.com/users/wickedest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wickedest/subscriptions","organizations_url":"https://api.github.com/users/wickedest/orgs","repos_url":"https://api.github.com/users/wickedest/repos","events_url":"https://api.github.com/users/wickedest/events{/privacy}","received_events_url":"https://api.github.com/users/wickedest/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":1,"changed_files":1}}