{"action":"created","comment":{"url":"https://api.github.com/repos/pydata/pandas/pulls/comments/39042211","id":39042211,"diff_hunk":"@@ -2872,12 +2875,14 @@ def grouped_hist(data, column=None, by=None, ax=None, bins=50, figsize=None,\n     -------\n     axes: collection of Matplotlib Axes\n     \"\"\"\n-    def plot_group(group, ax):\n-        ax.hist(group.dropna().values, bins=bins, **kwargs)\n+    def plot_group(group, ax, weights=None):\n+        if weights is not None:\n+            weights=weights.dropna().values","path":"pandas/tools/plotting.py","position":52,"original_position":52,"commit_id":"1c0df890137d5cdc07c11d10721c35f2baa552a7","original_commit_id":"1c0df890137d5cdc07c11d10721c35f2baa552a7","user":{"login":"Twizzledrizzle","id":6655099,"avatar_url":"https://avatars.githubusercontent.com/u/6655099?v=3","gravatar_id":"","url":"https://api.github.com/users/Twizzledrizzle","html_url":"https://github.com/Twizzledrizzle","followers_url":"https://api.github.com/users/Twizzledrizzle/followers","following_url":"https://api.github.com/users/Twizzledrizzle/following{/other_user}","gists_url":"https://api.github.com/users/Twizzledrizzle/gists{/gist_id}","starred_url":"https://api.github.com/users/Twizzledrizzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Twizzledrizzle/subscriptions","organizations_url":"https://api.github.com/users/Twizzledrizzle/orgs","repos_url":"https://api.github.com/users/Twizzledrizzle/repos","events_url":"https://api.github.com/users/Twizzledrizzle/events{/privacy}","received_events_url":"https://api.github.com/users/Twizzledrizzle/received_events","type":"User","site_admin":false},"body":"ah, issues when na is different on weights and group arrays, did not think of this, will think a little bit more","created_at":"2015-09-09T13:36:59Z","updated_at":"2015-09-09T13:36:59Z","html_url":"https://github.com/pydata/pandas/pull/11028#discussion_r39042211","pull_request_url":"https://api.github.com/repos/pydata/pandas/pulls/11028","_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/39042211"},"html":{"href":"https://github.com/pydata/pandas/pull/11028#discussion_r39042211"},"pull_request":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11028"}}},"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/11028","id":44479580,"html_url":"https://github.com/pydata/pandas/pull/11028","diff_url":"https://github.com/pydata/pandas/pull/11028.diff","patch_url":"https://github.com/pydata/pandas/pull/11028.patch","issue_url":"https://api.github.com/repos/pydata/pandas/issues/11028","number":11028,"state":"open","locked":false,"title":"Fix for DataFrame.hist() with by- and weights-keyword","user":{"login":"Twizzledrizzle","id":6655099,"avatar_url":"https://avatars.githubusercontent.com/u/6655099?v=3","gravatar_id":"","url":"https://api.github.com/users/Twizzledrizzle","html_url":"https://github.com/Twizzledrizzle","followers_url":"https://api.github.com/users/Twizzledrizzle/followers","following_url":"https://api.github.com/users/Twizzledrizzle/following{/other_user}","gists_url":"https://api.github.com/users/Twizzledrizzle/gists{/gist_id}","starred_url":"https://api.github.com/users/Twizzledrizzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Twizzledrizzle/subscriptions","organizations_url":"https://api.github.com/users/Twizzledrizzle/orgs","repos_url":"https://api.github.com/users/Twizzledrizzle/repos","events_url":"https://api.github.com/users/Twizzledrizzle/events{/privacy}","received_events_url":"https://api.github.com/users/Twizzledrizzle/received_events","type":"User","site_admin":false},"body":"closes https://github.com/pydata/pandas/issues/9540\r\n\r\nfor example:\r\n\r\n```python\r\nimport pandas as pd\r\nd = {'one' : ['A', 'A', 'B', 'C'],\r\n     'two' : [4., 3., 2., 1.],\r\n     'three' : [10., 8., 5., 7.]}     \r\ndf = pd.DataFrame(d)\r\ndf.hist('two', by='one', weights='three', bins=range(0, 10))\r\n```\r\n\r\ndoes not seem to break anything, but this is my first meddling in the pandas library, so a review would be nice","created_at":"2015-09-08T20:34:19Z","updated_at":"2015-09-09T13:36:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aadaa94904fb52f29ce631aef390f466f262c4aa","assignee":null,"milestone":{"url":"https://api.github.com/repos/pydata/pandas/milestones/36","html_url":"https://github.com/pydata/pandas/milestones/0.18.0","labels_url":"https://api.github.com/repos/pydata/pandas/milestones/36/labels","id":1214851,"number":36,"title":"0.18.0","description":"","creator":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2015-07-19T20:18:45Z","updated_at":"2015-09-09T12:48:32Z","due_on":"2015-11-30T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pydata/pandas/pulls/11028/commits","review_comments_url":"https://api.github.com/repos/pydata/pandas/pulls/11028/comments","review_comment_url":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/11028/comments","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/1c0df890137d5cdc07c11d10721c35f2baa552a7","head":{"label":"Twizzledrizzle:Twizzledrizzle-patch-df-hist","ref":"Twizzledrizzle-patch-df-hist","sha":"1c0df890137d5cdc07c11d10721c35f2baa552a7","user":{"login":"Twizzledrizzle","id":6655099,"avatar_url":"https://avatars.githubusercontent.com/u/6655099?v=3","gravatar_id":"","url":"https://api.github.com/users/Twizzledrizzle","html_url":"https://github.com/Twizzledrizzle","followers_url":"https://api.github.com/users/Twizzledrizzle/followers","following_url":"https://api.github.com/users/Twizzledrizzle/following{/other_user}","gists_url":"https://api.github.com/users/Twizzledrizzle/gists{/gist_id}","starred_url":"https://api.github.com/users/Twizzledrizzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Twizzledrizzle/subscriptions","organizations_url":"https://api.github.com/users/Twizzledrizzle/orgs","repos_url":"https://api.github.com/users/Twizzledrizzle/repos","events_url":"https://api.github.com/users/Twizzledrizzle/events{/privacy}","received_events_url":"https://api.github.com/users/Twizzledrizzle/received_events","type":"User","site_admin":false},"repo":{"id":42136249,"name":"pandas","full_name":"Twizzledrizzle/pandas","owner":{"login":"Twizzledrizzle","id":6655099,"avatar_url":"https://avatars.githubusercontent.com/u/6655099?v=3","gravatar_id":"","url":"https://api.github.com/users/Twizzledrizzle","html_url":"https://github.com/Twizzledrizzle","followers_url":"https://api.github.com/users/Twizzledrizzle/followers","following_url":"https://api.github.com/users/Twizzledrizzle/following{/other_user}","gists_url":"https://api.github.com/users/Twizzledrizzle/gists{/gist_id}","starred_url":"https://api.github.com/users/Twizzledrizzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Twizzledrizzle/subscriptions","organizations_url":"https://api.github.com/users/Twizzledrizzle/orgs","repos_url":"https://api.github.com/users/Twizzledrizzle/repos","events_url":"https://api.github.com/users/Twizzledrizzle/events{/privacy}","received_events_url":"https://api.github.com/users/Twizzledrizzle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Twizzledrizzle/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/Twizzledrizzle/pandas","forks_url":"https://api.github.com/repos/Twizzledrizzle/pandas/forks","keys_url":"https://api.github.com/repos/Twizzledrizzle/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Twizzledrizzle/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Twizzledrizzle/pandas/teams","hooks_url":"https://api.github.com/repos/Twizzledrizzle/pandas/hooks","issue_events_url":"https://api.github.com/repos/Twizzledrizzle/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/Twizzledrizzle/pandas/events","assignees_url":"https://api.github.com/repos/Twizzledrizzle/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/Twizzledrizzle/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/Twizzledrizzle/pandas/tags","blobs_url":"https://api.github.com/repos/Twizzledrizzle/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Twizzledrizzle/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Twizzledrizzle/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/Twizzledrizzle/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Twizzledrizzle/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/Twizzledrizzle/pandas/languages","stargazers_url":"https://api.github.com/repos/Twizzledrizzle/pandas/stargazers","contributors_url":"https://api.github.com/repos/Twizzledrizzle/pandas/contributors","subscribers_url":"https://api.github.com/repos/Twizzledrizzle/pandas/subscribers","subscription_url":"https://api.github.com/repos/Twizzledrizzle/pandas/subscription","commits_url":"https://api.github.com/repos/Twizzledrizzle/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/Twizzledrizzle/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/Twizzledrizzle/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/Twizzledrizzle/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/Twizzledrizzle/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/Twizzledrizzle/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Twizzledrizzle/pandas/merges","archive_url":"https://api.github.com/repos/Twizzledrizzle/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Twizzledrizzle/pandas/downloads","issues_url":"https://api.github.com/repos/Twizzledrizzle/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/Twizzledrizzle/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/Twizzledrizzle/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/Twizzledrizzle/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Twizzledrizzle/pandas/labels{/name}","releases_url":"https://api.github.com/repos/Twizzledrizzle/pandas/releases{/id}","created_at":"2015-09-08T20:08:29Z","updated_at":"2015-09-08T20:08:33Z","pushed_at":"2015-09-09T11:28:43Z","git_url":"git://github.com/Twizzledrizzle/pandas.git","ssh_url":"git@github.com:Twizzledrizzle/pandas.git","clone_url":"https://github.com/Twizzledrizzle/pandas.git","svn_url":"https://github.com/Twizzledrizzle/pandas","homepage":"http://pandas.pydata.org","size":63416,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"6b9c46b821293ed2674543eca35bf5b403b0727e","user":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pydata/pandas","owner":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pydata/pandas","forks_url":"https://api.github.com/repos/pydata/pandas/forks","keys_url":"https://api.github.com/repos/pydata/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/pandas/teams","hooks_url":"https://api.github.com/repos/pydata/pandas/hooks","issue_events_url":"https://api.github.com/repos/pydata/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/pandas/events","assignees_url":"https://api.github.com/repos/pydata/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/pandas/tags","blobs_url":"https://api.github.com/repos/pydata/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/pandas/languages","stargazers_url":"https://api.github.com/repos/pydata/pandas/stargazers","contributors_url":"https://api.github.com/repos/pydata/pandas/contributors","subscribers_url":"https://api.github.com/repos/pydata/pandas/subscribers","subscription_url":"https://api.github.com/repos/pydata/pandas/subscription","commits_url":"https://api.github.com/repos/pydata/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydata/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/pandas/merges","archive_url":"https://api.github.com/repos/pydata/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/pandas/downloads","issues_url":"https://api.github.com/repos/pydata/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pydata/pandas/releases{/id}","created_at":"2010-08-24T01:37:33Z","updated_at":"2015-09-09T10:13:00Z","pushed_at":"2015-09-09T12:56:45Z","git_url":"git://github.com/pydata/pandas.git","ssh_url":"git@github.com:pydata/pandas.git","clone_url":"https://github.com/pydata/pandas.git","svn_url":"https://github.com/pydata/pandas","homepage":"http://pandas.pydata.org","size":155909,"stargazers_count":4912,"watchers_count":4912,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1894,"mirror_url":null,"open_issues_count":1452,"forks":1894,"open_issues":1452,"watchers":4912,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11028"},"html":{"href":"https://github.com/pydata/pandas/pull/11028"},"issue":{"href":"https://api.github.com/repos/pydata/pandas/issues/11028"},"comments":{"href":"https://api.github.com/repos/pydata/pandas/issues/11028/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11028/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11028/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/pandas/statuses/1c0df890137d5cdc07c11d10721c35f2baa552a7"}}}}