{"action":"created","issue":{"url":"https://api.github.com/repos/libgdx/libgdx/issues/2892","labels_url":"https://api.github.com/repos/libgdx/libgdx/issues/2892/labels{/name}","comments_url":"https://api.github.com/repos/libgdx/libgdx/issues/2892/comments","events_url":"https://api.github.com/repos/libgdx/libgdx/issues/2892/events","html_url":"https://github.com/libgdx/libgdx/pull/2892","id":59457159,"number":2892,"title":"Remove of static temporaries in math classes","user":{"login":"code-disaster","id":4644167,"avatar_url":"https://avatars.githubusercontent.com/u/4644167?v=3","gravatar_id":"","url":"https://api.github.com/users/code-disaster","html_url":"https://github.com/code-disaster","followers_url":"https://api.github.com/users/code-disaster/followers","following_url":"https://api.github.com/users/code-disaster/following{/other_user}","gists_url":"https://api.github.com/users/code-disaster/gists{/gist_id}","starred_url":"https://api.github.com/users/code-disaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-disaster/subscriptions","organizations_url":"https://api.github.com/users/code-disaster/orgs","repos_url":"https://api.github.com/users/code-disaster/repos","events_url":"https://api.github.com/users/code-disaster/events{/privacy}","received_events_url":"https://api.github.com/users/code-disaster/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-02T09:32:45Z","updated_at":"2015-04-27T21:05:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/libgdx/libgdx/pulls/2892","html_url":"https://github.com/libgdx/libgdx/pull/2892","diff_url":"https://github.com/libgdx/libgdx/pull/2892.diff","patch_url":"https://github.com/libgdx/libgdx/pull/2892.patch"},"body":"With this PR I want to revive an issue previously discussed in e.g. #846. It's one step towards thread safety in the math classes.\r\n\r\nThere are still some static temporaries left: Vector3.tmpMat and Matrix4.quat/quat2. The long-lived deprecated Matrix4.tmp could now be removed.\r\n\r\nI've run a couple of tests to verify my changes, but as far as I've seen not all modified functions are covered by them. Also, I've only run the tests on desktop systems. That said, a code review and **some tests on Android/iOS** would be wise. ;) Also, feel free to try the changes with your project if you are heavily using Matrix4/Quaternion."},"comment":{"url":"https://api.github.com/repos/libgdx/libgdx/issues/comments/96819900","html_url":"https://github.com/libgdx/libgdx/pull/2892#issuecomment-96819900","issue_url":"https://api.github.com/repos/libgdx/libgdx/issues/2892","id":96819900,"user":{"login":"xoppa","id":2349087,"avatar_url":"https://avatars.githubusercontent.com/u/2349087?v=3","gravatar_id":"","url":"https://api.github.com/users/xoppa","html_url":"https://github.com/xoppa","followers_url":"https://api.github.com/users/xoppa/followers","following_url":"https://api.github.com/users/xoppa/following{/other_user}","gists_url":"https://api.github.com/users/xoppa/gists{/gist_id}","starred_url":"https://api.github.com/users/xoppa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xoppa/subscriptions","organizations_url":"https://api.github.com/users/xoppa/orgs","repos_url":"https://api.github.com/users/xoppa/repos","events_url":"https://api.github.com/users/xoppa/events{/privacy}","received_events_url":"https://api.github.com/users/xoppa/received_events","type":"User","site_admin":false},"created_at":"2015-04-27T21:05:28Z","updated_at":"2015-04-27T21:05:28Z","body":"Yeah, I'm not sure this actually solves an issue now. I guess this PR is about whether we want to complicate code for thread safety."}}