{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/32446120","id":32446120,"diff_hunk":"@@ -1321,40 +1260,35 @@\n         }\n       };\n \n-      // only pass element when id is given.\n-      if (id) cmd.parameters.element = id;\n+      // only pass element when id is given\n+      if (id)\n+        cmd.parameters.element = id;\n \n-      if (this.searchMethods.indexOf(cmd.parameters.using) === -1) {\n+      if (this.searchMethods.indexOf(cmd.parameters.using) < 0) {","path":"tests/jsmarionette/client/marionette-client/lib/marionette/client.js","position":503,"original_position":503,"commit_id":"6ecb69dc43bff76a48b867f8014a05b762ac2d47","original_commit_id":"6ecb69dc43bff76a48b867f8014a05b762ac2d47","user":{"login":"gaye","id":535859,"avatar_url":"https://avatars.githubusercontent.com/u/535859?v=3","gravatar_id":"","url":"https://api.github.com/users/gaye","html_url":"https://github.com/gaye","followers_url":"https://api.github.com/users/gaye/followers","following_url":"https://api.github.com/users/gaye/following{/other_user}","gists_url":"https://api.github.com/users/gaye/gists{/gist_id}","starred_url":"https://api.github.com/users/gaye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaye/subscriptions","organizations_url":"https://api.github.com/users/gaye/orgs","repos_url":"https://api.github.com/users/gaye/repos","events_url":"https://api.github.com/users/gaye/events{/privacy}","received_events_url":"https://api.github.com/users/gaye/received_events","type":"User","site_admin":false},"body":"Why?","created_at":"2015-06-15T17:41:07Z","updated_at":"2015-06-15T17:41:07Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/30570#discussion_r32446120","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30570","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/32446120"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/30570#discussion_r32446120"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30570"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30570","id":37589673,"html_url":"https://github.com/mozilla-b2g/gaia/pull/30570","diff_url":"https://github.com/mozilla-b2g/gaia/pull/30570.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/30570.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/30570","number":30570,"state":"open","locked":false,"title":"Bug 1168396 - Adjust Marionette JS client to protocol changes; r=gaye","user":{"login":"andreastt","id":399120,"avatar_url":"https://avatars.githubusercontent.com/u/399120?v=3","gravatar_id":"","url":"https://api.github.com/users/andreastt","html_url":"https://github.com/andreastt","followers_url":"https://api.github.com/users/andreastt/followers","following_url":"https://api.github.com/users/andreastt/following{/other_user}","gists_url":"https://api.github.com/users/andreastt/gists{/gist_id}","starred_url":"https://api.github.com/users/andreastt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreastt/subscriptions","organizations_url":"https://api.github.com/users/andreastt/orgs","repos_url":"https://api.github.com/users/andreastt/repos","events_url":"https://api.github.com/users/andreastt/events{/privacy}","received_events_url":"https://api.github.com/users/andreastt/received_events","type":"User","site_admin":false},"body":"Bug 1153822 to Gecko reduces the amount of data sent will make requests\r\nfaster. Aligning the protocol closer to what WebDriver expects, will\r\nreduce the amount of post-processing required in the httpd.\r\n\r\nPrevious to this patch, this is a value response:\r\n\r\n```\r\n{\"from\":\"0\",\"value\":null,\"status\":0,\"sessionId\":\"{6b6d68d2-4ac9-4308-9f07-d2e72519c407}\"}\r\n```\r\n\r\nAnd this for ok responses:\r\n\r\n```\r\n{\"from\":\"0\",\"ok\":true}\r\n```\r\n\r\nAnd this for errors:\r\n\r\n```\r\n{\"from\":\"0\",\"status\":21,\"sessionId\":\"{6b6d68d2-4ac9-4308-9f07-d2e72519c407}\",\"error\":{\"message\":\"Error loading page, timed out (onDOMContentLoaded)\",\"stacktrace\":null,\"status\":21}}\r\n```\r\n\r\nBug 1153822 drops the \"from\" and \"sessionId\" fields and \"status\" field\r\nfrom non-error responses. It also drops the \"ok\" field in non-value\r\nresponses and flattes the error response.","created_at":"2015-06-12T18:11:22Z","updated_at":"2015-06-15T17:41:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be1d55691285f82b433d648816a5d62ddff2c655","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30570/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30570/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/30570/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/6ecb69dc43bff76a48b867f8014a05b762ac2d47","head":{"label":"andreastt:bug_1168396","ref":"bug_1168396","sha":"6ecb69dc43bff76a48b867f8014a05b762ac2d47","user":{"login":"andreastt","id":399120,"avatar_url":"https://avatars.githubusercontent.com/u/399120?v=3","gravatar_id":"","url":"https://api.github.com/users/andreastt","html_url":"https://github.com/andreastt","followers_url":"https://api.github.com/users/andreastt/followers","following_url":"https://api.github.com/users/andreastt/following{/other_user}","gists_url":"https://api.github.com/users/andreastt/gists{/gist_id}","starred_url":"https://api.github.com/users/andreastt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreastt/subscriptions","organizations_url":"https://api.github.com/users/andreastt/orgs","repos_url":"https://api.github.com/users/andreastt/repos","events_url":"https://api.github.com/users/andreastt/events{/privacy}","received_events_url":"https://api.github.com/users/andreastt/received_events","type":"User","site_admin":false},"repo":{"id":33993494,"name":"gaia","full_name":"andreastt/gaia","owner":{"login":"andreastt","id":399120,"avatar_url":"https://avatars.githubusercontent.com/u/399120?v=3","gravatar_id":"","url":"https://api.github.com/users/andreastt","html_url":"https://github.com/andreastt","followers_url":"https://api.github.com/users/andreastt/followers","following_url":"https://api.github.com/users/andreastt/following{/other_user}","gists_url":"https://api.github.com/users/andreastt/gists{/gist_id}","starred_url":"https://api.github.com/users/andreastt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreastt/subscriptions","organizations_url":"https://api.github.com/users/andreastt/orgs","repos_url":"https://api.github.com/users/andreastt/repos","events_url":"https://api.github.com/users/andreastt/events{/privacy}","received_events_url":"https://api.github.com/users/andreastt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreastt/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":true,"url":"https://api.github.com/repos/andreastt/gaia","forks_url":"https://api.github.com/repos/andreastt/gaia/forks","keys_url":"https://api.github.com/repos/andreastt/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreastt/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreastt/gaia/teams","hooks_url":"https://api.github.com/repos/andreastt/gaia/hooks","issue_events_url":"https://api.github.com/repos/andreastt/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/andreastt/gaia/events","assignees_url":"https://api.github.com/repos/andreastt/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/andreastt/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/andreastt/gaia/tags","blobs_url":"https://api.github.com/repos/andreastt/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreastt/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreastt/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreastt/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreastt/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/andreastt/gaia/languages","stargazers_url":"https://api.github.com/repos/andreastt/gaia/stargazers","contributors_url":"https://api.github.com/repos/andreastt/gaia/contributors","subscribers_url":"https://api.github.com/repos/andreastt/gaia/subscribers","subscription_url":"https://api.github.com/repos/andreastt/gaia/subscription","commits_url":"https://api.github.com/repos/andreastt/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreastt/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreastt/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreastt/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreastt/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/andreastt/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreastt/gaia/merges","archive_url":"https://api.github.com/repos/andreastt/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreastt/gaia/downloads","issues_url":"https://api.github.com/repos/andreastt/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/andreastt/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/andreastt/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/andreastt/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreastt/gaia/labels{/name}","releases_url":"https://api.github.com/repos/andreastt/gaia/releases{/id}","created_at":"2015-04-15T12:50:43Z","updated_at":"2015-04-15T12:51:10Z","pushed_at":"2015-06-15T10:50:28Z","git_url":"git://github.com/andreastt/gaia.git","ssh_url":"git@github.com:andreastt/gaia.git","clone_url":"https://github.com/andreastt/gaia.git","svn_url":"https://github.com/andreastt/gaia","homepage":"https://wiki.mozilla.org/B2G","size":932067,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"386bd6b583f5abbc8b5a611f9c86fa8b5606e3e7","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-06-12T12:24:13Z","pushed_at":"2015-06-15T17:40:51Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1637194,"stargazers_count":1941,"watchers_count":1941,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2339,"mirror_url":null,"open_issues_count":1023,"forks":2339,"open_issues":1023,"watchers":1941,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30570"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/30570"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/30570"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/30570/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30570/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30570/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/6ecb69dc43bff76a48b867f8014a05b762ac2d47"}}}}