{"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/comments/31163456","id":31163456,"diff_hunk":"@@ -78,14 +82,15 @@ public RollupHandler() {\n                     .withCorePoolSize(ESthreadCount)\n                     .withMaxPoolSize(ESthreadCount).withName(\"Rolluphandler ES executors\").build();\n         }\n-        ThreadPoolExecutor RollupsOnReadExecutors = new ThreadPoolBuilder().withUnboundedQueue()\n+        if (!Configuration.getInstance().getBooleanProperty(CoreConfig.PERFORM_ROLLUPS_ON_READ_SYNC)) {\n+            ThreadPoolExecutor RollupsOnReadExecutors = new ThreadPoolBuilder().withUnboundedQueue()","path":"blueflood-core/src/main/java/com/rackspacecloud/blueflood/outputs/handlers/RollupHandler.java","position":22,"original_position":22,"commit_id":"5b24249679d319a07567a0072d1ba8addc473872","original_commit_id":"5b24249679d319a07567a0072d1ba8addc473872","user":{"login":"GeorgeJahad","id":86830,"avatar_url":"https://avatars.githubusercontent.com/u/86830?v=3","gravatar_id":"","url":"https://api.github.com/users/GeorgeJahad","html_url":"https://github.com/GeorgeJahad","followers_url":"https://api.github.com/users/GeorgeJahad/followers","following_url":"https://api.github.com/users/GeorgeJahad/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeJahad/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeJahad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeJahad/subscriptions","organizations_url":"https://api.github.com/users/GeorgeJahad/orgs","repos_url":"https://api.github.com/users/GeorgeJahad/repos","events_url":"https://api.github.com/users/GeorgeJahad/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeJahad/received_events","type":"User","site_admin":false},"body":"Still seems weird that this instance var is capitalized.","created_at":"2015-05-27T18:14:32Z","updated_at":"2015-05-27T18:14:32Z","html_url":"https://github.com/rackerlabs/blueflood/pull/469#discussion_r31163456","pull_request_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/469","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/comments/31163456"},"html":{"href":"https://github.com/rackerlabs/blueflood/pull/469#discussion_r31163456"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/469"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/469","id":36274079,"html_url":"https://github.com/rackerlabs/blueflood/pull/469","diff_url":"https://github.com/rackerlabs/blueflood/pull/469.diff","patch_url":"https://github.com/rackerlabs/blueflood/pull/469.patch","issue_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/469","number":469,"state":"open","locked":false,"title":"Add a configuration option for sync rollups on read operations","user":{"login":"chinmay-gupte","id":4722931,"avatar_url":"https://avatars.githubusercontent.com/u/4722931?v=3","gravatar_id":"","url":"https://api.github.com/users/chinmay-gupte","html_url":"https://github.com/chinmay-gupte","followers_url":"https://api.github.com/users/chinmay-gupte/followers","following_url":"https://api.github.com/users/chinmay-gupte/following{/other_user}","gists_url":"https://api.github.com/users/chinmay-gupte/gists{/gist_id}","starred_url":"https://api.github.com/users/chinmay-gupte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinmay-gupte/subscriptions","organizations_url":"https://api.github.com/users/chinmay-gupte/orgs","repos_url":"https://api.github.com/users/chinmay-gupte/repos","events_url":"https://api.github.com/users/chinmay-gupte/events{/privacy}","received_events_url":"https://api.github.com/users/chinmay-gupte/received_events","type":"User","site_admin":false},"body":"This PR adds a configuration option for doing rollups on read synchronously. There might be a value in playing around with this option depending on the work-load.","created_at":"2015-05-27T06:55:19Z","updated_at":"2015-05-27T18:14:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f86924bc94f539b0899833ae5d96462cd39844a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/469/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/469/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/469/comments","statuses_url":"https://api.github.com/repos/rackerlabs/blueflood/statuses/5b24249679d319a07567a0072d1ba8addc473872","head":{"label":"chinmay-gupte:chinmay/add_option_for_sync_rollup_on_read_operations","ref":"chinmay/add_option_for_sync_rollup_on_read_operations","sha":"5b24249679d319a07567a0072d1ba8addc473872","user":{"login":"chinmay-gupte","id":4722931,"avatar_url":"https://avatars.githubusercontent.com/u/4722931?v=3","gravatar_id":"","url":"https://api.github.com/users/chinmay-gupte","html_url":"https://github.com/chinmay-gupte","followers_url":"https://api.github.com/users/chinmay-gupte/followers","following_url":"https://api.github.com/users/chinmay-gupte/following{/other_user}","gists_url":"https://api.github.com/users/chinmay-gupte/gists{/gist_id}","starred_url":"https://api.github.com/users/chinmay-gupte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinmay-gupte/subscriptions","organizations_url":"https://api.github.com/users/chinmay-gupte/orgs","repos_url":"https://api.github.com/users/chinmay-gupte/repos","events_url":"https://api.github.com/users/chinmay-gupte/events{/privacy}","received_events_url":"https://api.github.com/users/chinmay-gupte/received_events","type":"User","site_admin":false},"repo":{"id":13116620,"name":"blueflood","full_name":"chinmay-gupte/blueflood","owner":{"login":"chinmay-gupte","id":4722931,"avatar_url":"https://avatars.githubusercontent.com/u/4722931?v=3","gravatar_id":"","url":"https://api.github.com/users/chinmay-gupte","html_url":"https://github.com/chinmay-gupte","followers_url":"https://api.github.com/users/chinmay-gupte/followers","following_url":"https://api.github.com/users/chinmay-gupte/following{/other_user}","gists_url":"https://api.github.com/users/chinmay-gupte/gists{/gist_id}","starred_url":"https://api.github.com/users/chinmay-gupte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinmay-gupte/subscriptions","organizations_url":"https://api.github.com/users/chinmay-gupte/orgs","repos_url":"https://api.github.com/users/chinmay-gupte/repos","events_url":"https://api.github.com/users/chinmay-gupte/events{/privacy}","received_events_url":"https://api.github.com/users/chinmay-gupte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chinmay-gupte/blueflood","description":"A distributed system designed to ingest and process time series data","fork":true,"url":"https://api.github.com/repos/chinmay-gupte/blueflood","forks_url":"https://api.github.com/repos/chinmay-gupte/blueflood/forks","keys_url":"https://api.github.com/repos/chinmay-gupte/blueflood/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chinmay-gupte/blueflood/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chinmay-gupte/blueflood/teams","hooks_url":"https://api.github.com/repos/chinmay-gupte/blueflood/hooks","issue_events_url":"https://api.github.com/repos/chinmay-gupte/blueflood/issues/events{/number}","events_url":"https://api.github.com/repos/chinmay-gupte/blueflood/events","assignees_url":"https://api.github.com/repos/chinmay-gupte/blueflood/assignees{/user}","branches_url":"https://api.github.com/repos/chinmay-gupte/blueflood/branches{/branch}","tags_url":"https://api.github.com/repos/chinmay-gupte/blueflood/tags","blobs_url":"https://api.github.com/repos/chinmay-gupte/blueflood/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chinmay-gupte/blueflood/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chinmay-gupte/blueflood/git/refs{/sha}","trees_url":"https://api.github.com/repos/chinmay-gupte/blueflood/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chinmay-gupte/blueflood/statuses/{sha}","languages_url":"https://api.github.com/repos/chinmay-gupte/blueflood/languages","stargazers_url":"https://api.github.com/repos/chinmay-gupte/blueflood/stargazers","contributors_url":"https://api.github.com/repos/chinmay-gupte/blueflood/contributors","subscribers_url":"https://api.github.com/repos/chinmay-gupte/blueflood/subscribers","subscription_url":"https://api.github.com/repos/chinmay-gupte/blueflood/subscription","commits_url":"https://api.github.com/repos/chinmay-gupte/blueflood/commits{/sha}","git_commits_url":"https://api.github.com/repos/chinmay-gupte/blueflood/git/commits{/sha}","comments_url":"https://api.github.com/repos/chinmay-gupte/blueflood/comments{/number}","issue_comment_url":"https://api.github.com/repos/chinmay-gupte/blueflood/issues/comments{/number}","contents_url":"https://api.github.com/repos/chinmay-gupte/blueflood/contents/{+path}","compare_url":"https://api.github.com/repos/chinmay-gupte/blueflood/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chinmay-gupte/blueflood/merges","archive_url":"https://api.github.com/repos/chinmay-gupte/blueflood/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chinmay-gupte/blueflood/downloads","issues_url":"https://api.github.com/repos/chinmay-gupte/blueflood/issues{/number}","pulls_url":"https://api.github.com/repos/chinmay-gupte/blueflood/pulls{/number}","milestones_url":"https://api.github.com/repos/chinmay-gupte/blueflood/milestones{/number}","notifications_url":"https://api.github.com/repos/chinmay-gupte/blueflood/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chinmay-gupte/blueflood/labels{/name}","releases_url":"https://api.github.com/repos/chinmay-gupte/blueflood/releases{/id}","created_at":"2013-09-26T08:16:42Z","updated_at":"2015-05-07T23:10:46Z","pushed_at":"2015-05-27T06:52:24Z","git_url":"git://github.com/chinmay-gupte/blueflood.git","ssh_url":"git@github.com:chinmay-gupte/blueflood.git","clone_url":"https://github.com/chinmay-gupte/blueflood.git","svn_url":"https://github.com/chinmay-gupte/blueflood","homepage":"http://www.blueflood.io","size":5676,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":0,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"3f96876e8e811ffd824592773ac8735c86e7850c","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":10081109,"name":"blueflood","full_name":"rackerlabs/blueflood","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/blueflood","description":"A distributed system designed to ingest and process time series data","fork":false,"url":"https://api.github.com/repos/rackerlabs/blueflood","forks_url":"https://api.github.com/repos/rackerlabs/blueflood/forks","keys_url":"https://api.github.com/repos/rackerlabs/blueflood/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/blueflood/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/blueflood/teams","hooks_url":"https://api.github.com/repos/rackerlabs/blueflood/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/blueflood/events","assignees_url":"https://api.github.com/repos/rackerlabs/blueflood/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/blueflood/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/blueflood/tags","blobs_url":"https://api.github.com/repos/rackerlabs/blueflood/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/blueflood/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/blueflood/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/blueflood/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/blueflood/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/blueflood/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/blueflood/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/blueflood/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/blueflood/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/blueflood/subscription","commits_url":"https://api.github.com/repos/rackerlabs/blueflood/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/blueflood/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/blueflood/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/blueflood/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/blueflood/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/blueflood/merges","archive_url":"https://api.github.com/repos/rackerlabs/blueflood/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/blueflood/downloads","issues_url":"https://api.github.com/repos/rackerlabs/blueflood/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/blueflood/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/blueflood/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/blueflood/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/blueflood/releases{/id}","created_at":"2013-05-15T14:50:39Z","updated_at":"2015-05-27T08:28:02Z","pushed_at":"2015-05-27T16:48:17Z","git_url":"git://github.com/rackerlabs/blueflood.git","ssh_url":"git@github.com:rackerlabs/blueflood.git","clone_url":"https://github.com/rackerlabs/blueflood.git","svn_url":"https://github.com/rackerlabs/blueflood","homepage":"http://www.blueflood.io","size":11449,"stargazers_count":316,"watchers_count":316,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":42,"mirror_url":null,"open_issues_count":34,"forks":42,"open_issues":34,"watchers":316,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/469"},"html":{"href":"https://github.com/rackerlabs/blueflood/pull/469"},"issue":{"href":"https://api.github.com/repos/rackerlabs/blueflood/issues/469"},"comments":{"href":"https://api.github.com/repos/rackerlabs/blueflood/issues/469/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/469/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/469/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/blueflood/statuses/5b24249679d319a07567a0072d1ba8addc473872"}}}}