{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-notifications/pulls/comments/27124910","id":27124910,"diff_hunk":"@@ -113,15 +114,19 @@ var CounterIconView = Backbone.View.extend({\n      e.stopPropagation();\n   },\n \n-  autoRefreshNotifications: function(counterView) {\n+ autoRefreshNotifications: function(counterView) {\n      var currentModel = new CounterIconModel();\n      currentModel.url = counterView.model.url;\n      currentModel.fetch().done(function(){\n          // if notification counter is incremented.\n          if(currentModel.get('count') > counterView.model.get('count')){\n-             var notification_alert = new Audio(counterView.view_audios.notification_alert);\n              counterView.model = currentModel;\n-             notification_alert.play();\n+","path":"edx_notifications/server/web/static/edx_notifications/js/views/counter_icon_view.js","position":24,"original_position":24,"commit_id":"15a7e205fbcacc69bcbcf02beb1748bc7a848c6d","original_commit_id":"15a7e205fbcacc69bcbcf02beb1748bc7a848c6d","user":{"login":"chrisndodge","id":2362917,"avatar_url":"https://avatars.githubusercontent.com/u/2362917?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisndodge","html_url":"https://github.com/chrisndodge","followers_url":"https://api.github.com/users/chrisndodge/followers","following_url":"https://api.github.com/users/chrisndodge/following{/other_user}","gists_url":"https://api.github.com/users/chrisndodge/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisndodge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisndodge/subscriptions","organizations_url":"https://api.github.com/users/chrisndodge/orgs","repos_url":"https://api.github.com/users/chrisndodge/repos","events_url":"https://api.github.com/users/chrisndodge/events{/privacy}","received_events_url":"https://api.github.com/users/chrisndodge/received_events","type":"User","site_admin":false},"body":"Hi, one comment unrelated to this PR fix, but I just realized that an audio alert is optional, so we should do a test to see if counterView.view_audios.notification_alert is undefined (or null), which should not attempt to play an audio tone.","created_at":"2015-03-25T14:27:19Z","updated_at":"2015-03-25T14:27:19Z","html_url":"https://github.com/edx/edx-notifications/pull/93#discussion_r27124910","pull_request_url":"https://api.github.com/repos/edx/edx-notifications/pulls/93","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-notifications/pulls/comments/27124910"},"html":{"href":"https://github.com/edx/edx-notifications/pull/93#discussion_r27124910"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-notifications/pulls/93"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-notifications/pulls/93","id":31913154,"html_url":"https://github.com/edx/edx-notifications/pull/93","diff_url":"https://github.com/edx/edx-notifications/pull/93.diff","patch_url":"https://github.com/edx/edx-notifications/pull/93.patch","issue_url":"https://api.github.com/repos/edx/edx-notifications/issues/93","number":93,"state":"open","locked":false,"title":"SOL-564 IE9 not auto refreshing","user":{"login":"asadiqbal08","id":7334669,"avatar_url":"https://avatars.githubusercontent.com/u/7334669?v=3","gravatar_id":"","url":"https://api.github.com/users/asadiqbal08","html_url":"https://github.com/asadiqbal08","followers_url":"https://api.github.com/users/asadiqbal08/followers","following_url":"https://api.github.com/users/asadiqbal08/following{/other_user}","gists_url":"https://api.github.com/users/asadiqbal08/gists{/gist_id}","starred_url":"https://api.github.com/users/asadiqbal08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asadiqbal08/subscriptions","organizations_url":"https://api.github.com/users/asadiqbal08/orgs","repos_url":"https://api.github.com/users/asadiqbal08/repos","events_url":"https://api.github.com/users/asadiqbal08/events{/privacy}","received_events_url":"https://api.github.com/users/asadiqbal08/received_events","type":"User","site_admin":false},"body":"@chrisndodge kindly review the changes. \r\n- Fixed: IE9 not auto refreshing","created_at":"2015-03-25T11:24:49Z","updated_at":"2015-03-25T14:27:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c76626af4ed1f6fe8ddc94ddc923ef9052bcc2a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-notifications/pulls/93/commits","review_comments_url":"https://api.github.com/repos/edx/edx-notifications/pulls/93/comments","review_comment_url":"https://api.github.com/repos/edx/edx-notifications/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-notifications/issues/93/comments","statuses_url":"https://api.github.com/repos/edx/edx-notifications/statuses/15a7e205fbcacc69bcbcf02beb1748bc7a848c6d","head":{"label":"edx:asadiqbal08/SOL-564","ref":"asadiqbal08/SOL-564","sha":"15a7e205fbcacc69bcbcf02beb1748bc7a848c6d","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":29154572,"name":"edx-notifications","full_name":"edx/edx-notifications","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-notifications","description":"","fork":false,"url":"https://api.github.com/repos/edx/edx-notifications","forks_url":"https://api.github.com/repos/edx/edx-notifications/forks","keys_url":"https://api.github.com/repos/edx/edx-notifications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-notifications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-notifications/teams","hooks_url":"https://api.github.com/repos/edx/edx-notifications/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-notifications/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-notifications/events","assignees_url":"https://api.github.com/repos/edx/edx-notifications/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-notifications/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-notifications/tags","blobs_url":"https://api.github.com/repos/edx/edx-notifications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-notifications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-notifications/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-notifications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-notifications/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-notifications/languages","stargazers_url":"https://api.github.com/repos/edx/edx-notifications/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-notifications/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-notifications/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-notifications/subscription","commits_url":"https://api.github.com/repos/edx/edx-notifications/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-notifications/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-notifications/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-notifications/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-notifications/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-notifications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-notifications/merges","archive_url":"https://api.github.com/repos/edx/edx-notifications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-notifications/downloads","issues_url":"https://api.github.com/repos/edx/edx-notifications/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-notifications/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-notifications/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-notifications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-notifications/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-notifications/releases{/id}","created_at":"2015-01-12T20:11:02Z","updated_at":"2015-03-07T22:58:42Z","pushed_at":"2015-03-25T12:35:49Z","git_url":"git://github.com/edx/edx-notifications.git","ssh_url":"git@github.com:edx/edx-notifications.git","clone_url":"https://github.com/edx/edx-notifications.git","svn_url":"https://github.com/edx/edx-notifications","homepage":null,"size":4214,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"edx:cdodge/mcka-master","ref":"cdodge/mcka-master","sha":"4282cf750849fde82591d6d96d5d6f97e2b3ffee","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":29154572,"name":"edx-notifications","full_name":"edx/edx-notifications","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-notifications","description":"","fork":false,"url":"https://api.github.com/repos/edx/edx-notifications","forks_url":"https://api.github.com/repos/edx/edx-notifications/forks","keys_url":"https://api.github.com/repos/edx/edx-notifications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-notifications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-notifications/teams","hooks_url":"https://api.github.com/repos/edx/edx-notifications/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-notifications/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-notifications/events","assignees_url":"https://api.github.com/repos/edx/edx-notifications/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-notifications/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-notifications/tags","blobs_url":"https://api.github.com/repos/edx/edx-notifications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-notifications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-notifications/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-notifications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-notifications/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-notifications/languages","stargazers_url":"https://api.github.com/repos/edx/edx-notifications/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-notifications/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-notifications/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-notifications/subscription","commits_url":"https://api.github.com/repos/edx/edx-notifications/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-notifications/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-notifications/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-notifications/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-notifications/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-notifications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-notifications/merges","archive_url":"https://api.github.com/repos/edx/edx-notifications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-notifications/downloads","issues_url":"https://api.github.com/repos/edx/edx-notifications/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-notifications/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-notifications/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-notifications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-notifications/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-notifications/releases{/id}","created_at":"2015-01-12T20:11:02Z","updated_at":"2015-03-07T22:58:42Z","pushed_at":"2015-03-25T12:35:49Z","git_url":"git://github.com/edx/edx-notifications.git","ssh_url":"git@github.com:edx/edx-notifications.git","clone_url":"https://github.com/edx/edx-notifications.git","svn_url":"https://github.com/edx/edx-notifications","homepage":null,"size":4214,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-notifications/pulls/93"},"html":{"href":"https://github.com/edx/edx-notifications/pull/93"},"issue":{"href":"https://api.github.com/repos/edx/edx-notifications/issues/93"},"comments":{"href":"https://api.github.com/repos/edx/edx-notifications/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-notifications/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-notifications/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-notifications/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-notifications/statuses/15a7e205fbcacc69bcbcf02beb1748bc7a848c6d"}}}}