{"action":"created","issue":{"url":"https://api.github.com/repos/haste/oUF/issues/251","labels_url":"https://api.github.com/repos/haste/oUF/issues/251/labels{/name}","comments_url":"https://api.github.com/repos/haste/oUF/issues/251/comments","events_url":"https://api.github.com/repos/haste/oUF/issues/251/events","html_url":"https://github.com/haste/oUF/pull/251","id":97747157,"number":251,"title":"runebar: Bail if GetRuneCooldown returns nil values","user":{"login":"p3lim","id":26496,"avatar_url":"https://avatars.githubusercontent.com/u/26496?v=3","gravatar_id":"","url":"https://api.github.com/users/p3lim","html_url":"https://github.com/p3lim","followers_url":"https://api.github.com/users/p3lim/followers","following_url":"https://api.github.com/users/p3lim/following{/other_user}","gists_url":"https://api.github.com/users/p3lim/gists{/gist_id}","starred_url":"https://api.github.com/users/p3lim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p3lim/subscriptions","organizations_url":"https://api.github.com/users/p3lim/orgs","repos_url":"https://api.github.com/users/p3lim/repos","events_url":"https://api.github.com/users/p3lim/events{/privacy}","received_events_url":"https://api.github.com/users/p3lim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-28T16:24:23Z","updated_at":"2015-07-28T17:32:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/haste/oUF/pulls/251","html_url":"https://github.com/haste/oUF/pull/251","diff_url":"https://github.com/haste/oUF/pull/251.diff","patch_url":"https://github.com/haste/oUF/pull/251.patch"},"body":"Since 6.2, `GetRuneCooldown` returns nil values during loading screens, which result in errors being spewed.\r\n\r\nIt is most likely an issue with the API, but it's probably best to check for it to avoid errors.\r\n\r\nDiscussion: http://www.wowinterface.com/forums/showthread.php?t=52535"},"comment":{"url":"https://api.github.com/repos/haste/oUF/issues/comments/125686428","html_url":"https://github.com/haste/oUF/pull/251#issuecomment-125686428","issue_url":"https://api.github.com/repos/haste/oUF/issues/251","id":125686428,"user":{"login":"Pondidum","id":219090,"avatar_url":"https://avatars.githubusercontent.com/u/219090?v=3","gravatar_id":"","url":"https://api.github.com/users/Pondidum","html_url":"https://github.com/Pondidum","followers_url":"https://api.github.com/users/Pondidum/followers","following_url":"https://api.github.com/users/Pondidum/following{/other_user}","gists_url":"https://api.github.com/users/Pondidum/gists{/gist_id}","starred_url":"https://api.github.com/users/Pondidum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pondidum/subscriptions","organizations_url":"https://api.github.com/users/Pondidum/orgs","repos_url":"https://api.github.com/users/Pondidum/repos","events_url":"https://api.github.com/users/Pondidum/events{/privacy}","received_events_url":"https://api.github.com/users/Pondidum/received_events","type":"User","site_admin":false},"created_at":"2015-07-28T17:32:35Z","updated_at":"2015-07-28T17:32:35Z","body":"I also had to do a similar fix in ouf_Dark for my custom rune bar.  You can emulate the original return values by wrapping calls to `GetRuneCooldown`:\r\n\r\n\tlocal getRuneCooldown = function(rid)\r\n\t\tlocal currentStart, currentDuration, currentReady = GetRuneCooldown(rid)\r\n\r\n\t\treturn currentStart or 0, currentDuration or 0, currentReady\r\n\tend\r\n\r\nAlso worth noting that `GetRuneType` can also break (might get hit here: [runebar.lua](https://github.com/p3lim-wow/oUF/blob/FixRunebar/elements/runebar.lua#L68)), and return nil rather than the range it should do (1 -> 4), again wrapping the call to restore original functionality:\r\n\r\n\tlocal getRuneType = function(rid)\r\n\t\treturn GetRuneType(rid) or 1\r\n\tend\r\n"}}