{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/21132","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/21132/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/21132/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/21132/events","html_url":"https://github.com/rust-lang/rust/pull/21132","id":54293795,"number":21132,"title":"Overhaul and make Condvar::wait_timeout public","user":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-01-14T07:58:09Z","updated_at":"2015-01-14T18:56:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/21132","html_url":"https://github.com/rust-lang/rust/pull/21132","diff_url":"https://github.com/rust-lang/rust/pull/21132.diff","patch_url":"https://github.com/rust-lang/rust/pull/21132.patch"},"body":"**The implementation is a direct adaptation of libcxx's condition_variable implementation.**\r\n\r\nI also added a wait_timeout_with method, which matches the second overload in C++'s condition_variable. The implementation right now is kind of dumb but it works. There is an outstanding issue with it: as is it doesn't support the use case where a user doesn't care about poisoning and wants to continue through poison.\r\n\r\nr? @alexcrichton @aturon "},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/69970058","html_url":"https://github.com/rust-lang/rust/pull/21132#issuecomment-69970058","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/21132","id":69970058,"user":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"created_at":"2015-01-14T18:56:45Z","updated_at":"2015-01-14T18:56:45Z","body":"Another thing to consider here is that we may want to rename `wait_timeout` to `wait_for`. This matches with C++'s API and allows room for the addition of a `wait_until` method that takes an absolute time in some future release when std gains a time library."}}