{"action":"created","comment":{"url":"https://api.github.com/repos/geotools/geotools/pulls/comments/38157536","id":38157536,"diff_hunk":"@@ -0,0 +1,300 @@\n+/*\n+ *    GeoTools - The Open Source Java GIS Toolkit\n+ *    http://geotools.org\n+ *\n+ *    (C) 2011 - 2015, Open Source Geospatial Foundation (OSGeo)\n+ *\n+ *    This library is free software; you can redistribute it and/or\n+ *    modify it under the terms of the GNU Lesser General Public\n+ *    License as published by the Free Software Foundation;\n+ *    version 2.1 of the License.\n+ *\n+ *    This library is distributed in the hope that it will be useful,\n+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU\n+ *    Lesser General Public License for more details.\n+ */\n+package org.geotools.renderer.lite;\n+\n+import junit.framework.TestCase;\n+import org.geotools.data.property.PropertyDataStore;\n+import org.geotools.data.simple.SimpleFeatureSource;\n+import org.geotools.geometry.jts.ReferencedEnvelope;\n+import org.geotools.map.DefaultMapContext;\n+import org.geotools.referencing.crs.DefaultGeographicCRS;\n+import org.geotools.renderer.label.LabelCacheImpl;\n+import org.geotools.styling.Style;\n+import org.geotools.test.TestData;\n+\n+import javax.imageio.ImageIO;\n+import java.awt.*;\n+import java.awt.event.WindowAdapter;\n+import java.awt.event.WindowEvent;\n+import java.awt.image.BufferedImage;\n+import java.io.File;\n+import java.util.HashMap;\n+import java.util.Map;\n+\n+import static java.awt.RenderingHints.KEY_ANTIALIASING;\n+import static java.awt.RenderingHints.VALUE_ANTIALIAS_ON;\n+\n+/**\n+ * Created by mmichaud on 19/08/2015.\n+ */\n+public class LetterConflictTest extends TestCase {\n+\n+    private boolean SHOW_RESULT = Boolean.getBoolean(\"org.geotools.labelcache.showLetterConflictTestResult\");\n+    private boolean OUTPUT_IMAGE = Boolean.getBoolean(\"org.geotools.labelcache.outputLetterConflictTestResult\");\n+","path":"modules/library/render/src/test/java/org/geotools/renderer/lite/LetterConflictTest.java","position":48,"original_position":48,"commit_id":"4cc31a4ec15c1a62f60d85982d7667bfe30ddd1a","original_commit_id":"4cc31a4ec15c1a62f60d85982d7667bfe30ddd1a","user":{"login":"jodygarnett","id":629681,"avatar_url":"https://avatars.githubusercontent.com/u/629681?v=3","gravatar_id":"","url":"https://api.github.com/users/jodygarnett","html_url":"https://github.com/jodygarnett","followers_url":"https://api.github.com/users/jodygarnett/followers","following_url":"https://api.github.com/users/jodygarnett/following{/other_user}","gists_url":"https://api.github.com/users/jodygarnett/gists{/gist_id}","starred_url":"https://api.github.com/users/jodygarnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodygarnett/subscriptions","organizations_url":"https://api.github.com/users/jodygarnett/orgs","repos_url":"https://api.github.com/users/jodygarnett/repos","events_url":"https://api.github.com/users/jodygarnett/events{/privacy}","received_events_url":"https://api.github.com/users/jodygarnett/received_events","type":"User","site_admin":false},"body":"You seem to have reverse engineered our -P interactive.image setting, but have used a different system property name.\r\n\r\nFor more info http://docs.geotools.org/latest/userguide/build/maven/testing.html","created_at":"2015-08-27T23:17:26Z","updated_at":"2015-08-27T23:17:26Z","html_url":"https://github.com/geotools/geotools/pull/948#discussion_r38157536","pull_request_url":"https://api.github.com/repos/geotools/geotools/pulls/948","_links":{"self":{"href":"https://api.github.com/repos/geotools/geotools/pulls/comments/38157536"},"html":{"href":"https://github.com/geotools/geotools/pull/948#discussion_r38157536"},"pull_request":{"href":"https://api.github.com/repos/geotools/geotools/pulls/948"}}},"pull_request":{"url":"https://api.github.com/repos/geotools/geotools/pulls/948","id":43280484,"html_url":"https://github.com/geotools/geotools/pull/948","diff_url":"https://github.com/geotools/geotools/pull/948.diff","patch_url":"https://github.com/geotools/geotools/pull/948.patch","issue_url":"https://api.github.com/repos/geotools/geotools/issues/948","number":948,"state":"open","locked":false,"title":"Improvements of LineLabel patch \"letter level conflict management\" according to Andrea's advices : suppression of dead code, refactoring of glyph processing.","user":{"login":"mmichaud-ign","id":13834201,"avatar_url":"https://avatars.githubusercontent.com/u/13834201?v=3","gravatar_id":"","url":"https://api.github.com/users/mmichaud-ign","html_url":"https://github.com/mmichaud-ign","followers_url":"https://api.github.com/users/mmichaud-ign/followers","following_url":"https://api.github.com/users/mmichaud-ign/following{/other_user}","gists_url":"https://api.github.com/users/mmichaud-ign/gists{/gist_id}","starred_url":"https://api.github.com/users/mmichaud-ign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmichaud-ign/subscriptions","organizations_url":"https://api.github.com/users/mmichaud-ign/orgs","repos_url":"https://api.github.com/users/mmichaud-ign/repos","events_url":"https://api.github.com/users/mmichaud-ign/events{/privacy}","received_events_url":"https://api.github.com/users/mmichaud-ign/received_events","type":"User","site_admin":false},"body":"LineLabel placement improved","created_at":"2015-08-25T12:39:35Z","updated_at":"2015-08-27T23:17:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"605b17238d8ce45485ea9fae98383624a05bd4c4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/geotools/geotools/pulls/948/commits","review_comments_url":"https://api.github.com/repos/geotools/geotools/pulls/948/comments","review_comment_url":"https://api.github.com/repos/geotools/geotools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geotools/geotools/issues/948/comments","statuses_url":"https://api.github.com/repos/geotools/geotools/statuses/4cc31a4ec15c1a62f60d85982d7667bfe30ddd1a","head":{"label":"mmichaud-ign:master","ref":"master","sha":"4cc31a4ec15c1a62f60d85982d7667bfe30ddd1a","user":{"login":"mmichaud-ign","id":13834201,"avatar_url":"https://avatars.githubusercontent.com/u/13834201?v=3","gravatar_id":"","url":"https://api.github.com/users/mmichaud-ign","html_url":"https://github.com/mmichaud-ign","followers_url":"https://api.github.com/users/mmichaud-ign/followers","following_url":"https://api.github.com/users/mmichaud-ign/following{/other_user}","gists_url":"https://api.github.com/users/mmichaud-ign/gists{/gist_id}","starred_url":"https://api.github.com/users/mmichaud-ign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmichaud-ign/subscriptions","organizations_url":"https://api.github.com/users/mmichaud-ign/orgs","repos_url":"https://api.github.com/users/mmichaud-ign/repos","events_url":"https://api.github.com/users/mmichaud-ign/events{/privacy}","received_events_url":"https://api.github.com/users/mmichaud-ign/received_events","type":"User","site_admin":false},"repo":{"id":41319710,"name":"geotools","full_name":"mmichaud-ign/geotools","owner":{"login":"mmichaud-ign","id":13834201,"avatar_url":"https://avatars.githubusercontent.com/u/13834201?v=3","gravatar_id":"","url":"https://api.github.com/users/mmichaud-ign","html_url":"https://github.com/mmichaud-ign","followers_url":"https://api.github.com/users/mmichaud-ign/followers","following_url":"https://api.github.com/users/mmichaud-ign/following{/other_user}","gists_url":"https://api.github.com/users/mmichaud-ign/gists{/gist_id}","starred_url":"https://api.github.com/users/mmichaud-ign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmichaud-ign/subscriptions","organizations_url":"https://api.github.com/users/mmichaud-ign/orgs","repos_url":"https://api.github.com/users/mmichaud-ign/repos","events_url":"https://api.github.com/users/mmichaud-ign/events{/privacy}","received_events_url":"https://api.github.com/users/mmichaud-ign/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmichaud-ign/geotools","description":"Official GeoTools repository","fork":true,"url":"https://api.github.com/repos/mmichaud-ign/geotools","forks_url":"https://api.github.com/repos/mmichaud-ign/geotools/forks","keys_url":"https://api.github.com/repos/mmichaud-ign/geotools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmichaud-ign/geotools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmichaud-ign/geotools/teams","hooks_url":"https://api.github.com/repos/mmichaud-ign/geotools/hooks","issue_events_url":"https://api.github.com/repos/mmichaud-ign/geotools/issues/events{/number}","events_url":"https://api.github.com/repos/mmichaud-ign/geotools/events","assignees_url":"https://api.github.com/repos/mmichaud-ign/geotools/assignees{/user}","branches_url":"https://api.github.com/repos/mmichaud-ign/geotools/branches{/branch}","tags_url":"https://api.github.com/repos/mmichaud-ign/geotools/tags","blobs_url":"https://api.github.com/repos/mmichaud-ign/geotools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmichaud-ign/geotools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmichaud-ign/geotools/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmichaud-ign/geotools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmichaud-ign/geotools/statuses/{sha}","languages_url":"https://api.github.com/repos/mmichaud-ign/geotools/languages","stargazers_url":"https://api.github.com/repos/mmichaud-ign/geotools/stargazers","contributors_url":"https://api.github.com/repos/mmichaud-ign/geotools/contributors","subscribers_url":"https://api.github.com/repos/mmichaud-ign/geotools/subscribers","subscription_url":"https://api.github.com/repos/mmichaud-ign/geotools/subscription","commits_url":"https://api.github.com/repos/mmichaud-ign/geotools/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmichaud-ign/geotools/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmichaud-ign/geotools/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmichaud-ign/geotools/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmichaud-ign/geotools/contents/{+path}","compare_url":"https://api.github.com/repos/mmichaud-ign/geotools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmichaud-ign/geotools/merges","archive_url":"https://api.github.com/repos/mmichaud-ign/geotools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmichaud-ign/geotools/downloads","issues_url":"https://api.github.com/repos/mmichaud-ign/geotools/issues{/number}","pulls_url":"https://api.github.com/repos/mmichaud-ign/geotools/pulls{/number}","milestones_url":"https://api.github.com/repos/mmichaud-ign/geotools/milestones{/number}","notifications_url":"https://api.github.com/repos/mmichaud-ign/geotools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmichaud-ign/geotools/labels{/name}","releases_url":"https://api.github.com/repos/mmichaud-ign/geotools/releases{/id}","created_at":"2015-08-24T18:23:42Z","updated_at":"2015-08-24T18:24:19Z","pushed_at":"2015-08-27T16:01:51Z","git_url":"git://github.com/mmichaud-ign/geotools.git","ssh_url":"git@github.com:mmichaud-ign/geotools.git","clone_url":"https://github.com/mmichaud-ign/geotools.git","svn_url":"https://github.com/mmichaud-ign/geotools","homepage":"http://geotools.org","size":112307,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"geotools:master","ref":"master","sha":"e9341cd1000a667b4d3568c9cafc68011d4591d7","user":{"login":"geotools","id":1187031,"avatar_url":"https://avatars.githubusercontent.com/u/1187031?v=3","gravatar_id":"","url":"https://api.github.com/users/geotools","html_url":"https://github.com/geotools","followers_url":"https://api.github.com/users/geotools/followers","following_url":"https://api.github.com/users/geotools/following{/other_user}","gists_url":"https://api.github.com/users/geotools/gists{/gist_id}","starred_url":"https://api.github.com/users/geotools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geotools/subscriptions","organizations_url":"https://api.github.com/users/geotools/orgs","repos_url":"https://api.github.com/users/geotools/repos","events_url":"https://api.github.com/users/geotools/events{/privacy}","received_events_url":"https://api.github.com/users/geotools/received_events","type":"Organization","site_admin":false},"repo":{"id":2752522,"name":"geotools","full_name":"geotools/geotools","owner":{"login":"geotools","id":1187031,"avatar_url":"https://avatars.githubusercontent.com/u/1187031?v=3","gravatar_id":"","url":"https://api.github.com/users/geotools","html_url":"https://github.com/geotools","followers_url":"https://api.github.com/users/geotools/followers","following_url":"https://api.github.com/users/geotools/following{/other_user}","gists_url":"https://api.github.com/users/geotools/gists{/gist_id}","starred_url":"https://api.github.com/users/geotools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geotools/subscriptions","organizations_url":"https://api.github.com/users/geotools/orgs","repos_url":"https://api.github.com/users/geotools/repos","events_url":"https://api.github.com/users/geotools/events{/privacy}","received_events_url":"https://api.github.com/users/geotools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geotools/geotools","description":"Official GeoTools repository","fork":false,"url":"https://api.github.com/repos/geotools/geotools","forks_url":"https://api.github.com/repos/geotools/geotools/forks","keys_url":"https://api.github.com/repos/geotools/geotools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geotools/geotools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geotools/geotools/teams","hooks_url":"https://api.github.com/repos/geotools/geotools/hooks","issue_events_url":"https://api.github.com/repos/geotools/geotools/issues/events{/number}","events_url":"https://api.github.com/repos/geotools/geotools/events","assignees_url":"https://api.github.com/repos/geotools/geotools/assignees{/user}","branches_url":"https://api.github.com/repos/geotools/geotools/branches{/branch}","tags_url":"https://api.github.com/repos/geotools/geotools/tags","blobs_url":"https://api.github.com/repos/geotools/geotools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geotools/geotools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geotools/geotools/git/refs{/sha}","trees_url":"https://api.github.com/repos/geotools/geotools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geotools/geotools/statuses/{sha}","languages_url":"https://api.github.com/repos/geotools/geotools/languages","stargazers_url":"https://api.github.com/repos/geotools/geotools/stargazers","contributors_url":"https://api.github.com/repos/geotools/geotools/contributors","subscribers_url":"https://api.github.com/repos/geotools/geotools/subscribers","subscription_url":"https://api.github.com/repos/geotools/geotools/subscription","commits_url":"https://api.github.com/repos/geotools/geotools/commits{/sha}","git_commits_url":"https://api.github.com/repos/geotools/geotools/git/commits{/sha}","comments_url":"https://api.github.com/repos/geotools/geotools/comments{/number}","issue_comment_url":"https://api.github.com/repos/geotools/geotools/issues/comments{/number}","contents_url":"https://api.github.com/repos/geotools/geotools/contents/{+path}","compare_url":"https://api.github.com/repos/geotools/geotools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geotools/geotools/merges","archive_url":"https://api.github.com/repos/geotools/geotools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geotools/geotools/downloads","issues_url":"https://api.github.com/repos/geotools/geotools/issues{/number}","pulls_url":"https://api.github.com/repos/geotools/geotools/pulls{/number}","milestones_url":"https://api.github.com/repos/geotools/geotools/milestones{/number}","notifications_url":"https://api.github.com/repos/geotools/geotools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geotools/geotools/labels{/name}","releases_url":"https://api.github.com/repos/geotools/geotools/releases{/id}","created_at":"2011-11-10T23:22:12Z","updated_at":"2015-08-22T01:01:17Z","pushed_at":"2015-08-27T16:01:52Z","git_url":"git://github.com/geotools/geotools.git","ssh_url":"git@github.com:geotools/geotools.git","clone_url":"https://github.com/geotools/geotools.git","svn_url":"https://github.com/geotools/geotools","homepage":"http://geotools.org","size":254247,"stargazers_count":218,"watchers_count":218,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":343,"mirror_url":null,"open_issues_count":7,"forks":343,"open_issues":7,"watchers":218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geotools/geotools/pulls/948"},"html":{"href":"https://github.com/geotools/geotools/pull/948"},"issue":{"href":"https://api.github.com/repos/geotools/geotools/issues/948"},"comments":{"href":"https://api.github.com/repos/geotools/geotools/issues/948/comments"},"review_comments":{"href":"https://api.github.com/repos/geotools/geotools/pulls/948/comments"},"review_comment":{"href":"https://api.github.com/repos/geotools/geotools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geotools/geotools/pulls/948/commits"},"statuses":{"href":"https://api.github.com/repos/geotools/geotools/statuses/4cc31a4ec15c1a62f60d85982d7667bfe30ddd1a"}}}}