{"action":"created","comment":{"url":"https://api.github.com/repos/sequelize/sequelize/pulls/comments/30695530","id":30695530,"diff_hunk":"@@ -236,15 +236,14 @@ module.exports = (function() {\n \n         if (options.attributes) {\n           keys = options.attributes;\n-          if (this.Model._hasVirtualAttributes) {\n-            keys = keys.concat(this.Model._virtualAttributes);\n-          }\n \n           if (this.options.includeNames) {\n             keys = keys.concat(this.options.includeNames);\n+          } else if (this.Model._hasVirtualAttributes) {\n+            keys = keys.concat(this.Model._virtualAttributes);\n           }\n \n-          for (i = 0, length = keys.length; i < length; i++) {\n+          for (i = 0; i < keys.length; i++) {","path":"lib/instance.js","position":67,"original_position":67,"commit_id":"ad6013348a507fa8914f47d66de93d2741813703","original_commit_id":"ad6013348a507fa8914f47d66de93d2741813703","user":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars.githubusercontent.com/u/8822573?v=3","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"body":"This is not true anymore. V8 will optimize this. As backend developers we do not have to support old browsers :)","created_at":"2015-05-20T12:28:38Z","updated_at":"2015-05-20T12:28:38Z","html_url":"https://github.com/sequelize/sequelize/pull/3745#discussion_r30695530","pull_request_url":"https://api.github.com/repos/sequelize/sequelize/pulls/3745","_links":{"self":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/comments/30695530"},"html":{"href":"https://github.com/sequelize/sequelize/pull/3745#discussion_r30695530"},"pull_request":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/3745"}}},"pull_request":{"url":"https://api.github.com/repos/sequelize/sequelize/pulls/3745","id":35607123,"html_url":"https://github.com/sequelize/sequelize/pull/3745","diff_url":"https://github.com/sequelize/sequelize/pull/3745.diff","patch_url":"https://github.com/sequelize/sequelize/pull/3745.patch","issue_url":"https://api.github.com/repos/sequelize/sequelize/issues/3745","number":3745,"state":"open","locked":false,"title":"Improve small stuff","user":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars.githubusercontent.com/u/8822573?v=3","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"body":"Just a couple of very small improvements. I removed some statements that were unused or shortened some and similar things","created_at":"2015-05-18T07:02:28Z","updated_at":"2015-05-20T12:28:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9775e80c70fd34af23756e972de2a9b5e45d42b8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sequelize/sequelize/pulls/3745/commits","review_comments_url":"https://api.github.com/repos/sequelize/sequelize/pulls/3745/comments","review_comment_url":"https://api.github.com/repos/sequelize/sequelize/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sequelize/sequelize/issues/3745/comments","statuses_url":"https://api.github.com/repos/sequelize/sequelize/statuses/ad6013348a507fa8914f47d66de93d2741813703","head":{"label":"BridgeAR:small-stuff","ref":"small-stuff","sha":"ad6013348a507fa8914f47d66de93d2741813703","user":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars.githubusercontent.com/u/8822573?v=3","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"repo":{"id":33316359,"name":"sequelize","full_name":"BridgeAR/sequelize","owner":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars.githubusercontent.com/u/8822573?v=3","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BridgeAR/sequelize","description":"Sequelize is an easy-to-use multi sql dialect ORM for Node.js & io.js. It currently supports MySQL, MariaDB, SQLite, PostgreSQL and MSSQL.","fork":true,"url":"https://api.github.com/repos/BridgeAR/sequelize","forks_url":"https://api.github.com/repos/BridgeAR/sequelize/forks","keys_url":"https://api.github.com/repos/BridgeAR/sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BridgeAR/sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BridgeAR/sequelize/teams","hooks_url":"https://api.github.com/repos/BridgeAR/sequelize/hooks","issue_events_url":"https://api.github.com/repos/BridgeAR/sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/BridgeAR/sequelize/events","assignees_url":"https://api.github.com/repos/BridgeAR/sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/BridgeAR/sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/BridgeAR/sequelize/tags","blobs_url":"https://api.github.com/repos/BridgeAR/sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BridgeAR/sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BridgeAR/sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/BridgeAR/sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BridgeAR/sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/BridgeAR/sequelize/languages","stargazers_url":"https://api.github.com/repos/BridgeAR/sequelize/stargazers","contributors_url":"https://api.github.com/repos/BridgeAR/sequelize/contributors","subscribers_url":"https://api.github.com/repos/BridgeAR/sequelize/subscribers","subscription_url":"https://api.github.com/repos/BridgeAR/sequelize/subscription","commits_url":"https://api.github.com/repos/BridgeAR/sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/BridgeAR/sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/BridgeAR/sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/BridgeAR/sequelize/issues/comments{/number}","contents_url":"https://api.github.com/repos/BridgeAR/sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/BridgeAR/sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BridgeAR/sequelize/merges","archive_url":"https://api.github.com/repos/BridgeAR/sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BridgeAR/sequelize/downloads","issues_url":"https://api.github.com/repos/BridgeAR/sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/BridgeAR/sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/BridgeAR/sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/BridgeAR/sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BridgeAR/sequelize/labels{/name}","releases_url":"https://api.github.com/repos/BridgeAR/sequelize/releases{/id}","created_at":"2015-04-02T15:27:23Z","updated_at":"2015-05-06T11:20:52Z","pushed_at":"2015-05-20T11:59:19Z","git_url":"git://github.com/BridgeAR/sequelize.git","ssh_url":"git@github.com:BridgeAR/sequelize.git","clone_url":"https://github.com/BridgeAR/sequelize.git","svn_url":"https://github.com/BridgeAR/sequelize","homepage":"http://sequelizejs.com","size":14484,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sequelize:master","ref":"master","sha":"14ee54f49c070360d991a4f266c7240a85da5a2b","user":{"login":"sequelize","id":3591786,"avatar_url":"https://avatars.githubusercontent.com/u/3591786?v=3","gravatar_id":"","url":"https://api.github.com/users/sequelize","html_url":"https://github.com/sequelize","followers_url":"https://api.github.com/users/sequelize/followers","following_url":"https://api.github.com/users/sequelize/following{/other_user}","gists_url":"https://api.github.com/users/sequelize/gists{/gist_id}","starred_url":"https://api.github.com/users/sequelize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequelize/subscriptions","organizations_url":"https://api.github.com/users/sequelize/orgs","repos_url":"https://api.github.com/users/sequelize/repos","events_url":"https://api.github.com/users/sequelize/events{/privacy}","received_events_url":"https://api.github.com/users/sequelize/received_events","type":"Organization","site_admin":false},"repo":{"id":790359,"name":"sequelize","full_name":"sequelize/sequelize","owner":{"login":"sequelize","id":3591786,"avatar_url":"https://avatars.githubusercontent.com/u/3591786?v=3","gravatar_id":"","url":"https://api.github.com/users/sequelize","html_url":"https://github.com/sequelize","followers_url":"https://api.github.com/users/sequelize/followers","following_url":"https://api.github.com/users/sequelize/following{/other_user}","gists_url":"https://api.github.com/users/sequelize/gists{/gist_id}","starred_url":"https://api.github.com/users/sequelize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequelize/subscriptions","organizations_url":"https://api.github.com/users/sequelize/orgs","repos_url":"https://api.github.com/users/sequelize/repos","events_url":"https://api.github.com/users/sequelize/events{/privacy}","received_events_url":"https://api.github.com/users/sequelize/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sequelize/sequelize","description":"Sequelize is an easy-to-use multi sql dialect ORM for Node.js & io.js. It currently supports MySQL, MariaDB, SQLite, PostgreSQL and MSSQL.","fork":false,"url":"https://api.github.com/repos/sequelize/sequelize","forks_url":"https://api.github.com/repos/sequelize/sequelize/forks","keys_url":"https://api.github.com/repos/sequelize/sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sequelize/sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sequelize/sequelize/teams","hooks_url":"https://api.github.com/repos/sequelize/sequelize/hooks","issue_events_url":"https://api.github.com/repos/sequelize/sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/sequelize/sequelize/events","assignees_url":"https://api.github.com/repos/sequelize/sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/sequelize/sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/sequelize/sequelize/tags","blobs_url":"https://api.github.com/repos/sequelize/sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sequelize/sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sequelize/sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/sequelize/sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sequelize/sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/sequelize/sequelize/languages","stargazers_url":"https://api.github.com/repos/sequelize/sequelize/stargazers","contributors_url":"https://api.github.com/repos/sequelize/sequelize/contributors","subscribers_url":"https://api.github.com/repos/sequelize/sequelize/subscribers","subscription_url":"https://api.github.com/repos/sequelize/sequelize/subscription","commits_url":"https://api.github.com/repos/sequelize/sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/sequelize/sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/sequelize/sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/sequelize/sequelize/issues/comments{/number}","contents_url":"https://api.github.com/repos/sequelize/sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/sequelize/sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sequelize/sequelize/merges","archive_url":"https://api.github.com/repos/sequelize/sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sequelize/sequelize/downloads","issues_url":"https://api.github.com/repos/sequelize/sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/sequelize/sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/sequelize/sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/sequelize/sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sequelize/sequelize/labels{/name}","releases_url":"https://api.github.com/repos/sequelize/sequelize/releases{/id}","created_at":"2010-07-22T07:11:11Z","updated_at":"2015-05-20T11:50:21Z","pushed_at":"2015-05-20T11:59:20Z","git_url":"git://github.com/sequelize/sequelize.git","ssh_url":"git@github.com:sequelize/sequelize.git","clone_url":"https://github.com/sequelize/sequelize.git","svn_url":"https://github.com/sequelize/sequelize","homepage":"http://sequelizejs.com","size":59507,"stargazers_count":3741,"watchers_count":3741,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":838,"mirror_url":null,"open_issues_count":394,"forks":838,"open_issues":394,"watchers":3741,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/3745"},"html":{"href":"https://github.com/sequelize/sequelize/pull/3745"},"issue":{"href":"https://api.github.com/repos/sequelize/sequelize/issues/3745"},"comments":{"href":"https://api.github.com/repos/sequelize/sequelize/issues/3745/comments"},"review_comments":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/3745/comments"},"review_comment":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/3745/commits"},"statuses":{"href":"https://api.github.com/repos/sequelize/sequelize/statuses/ad6013348a507fa8914f47d66de93d2741813703"}}}}