{"action":"created","comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/34799137","id":34799137,"diff_hunk":"@@ -301,6 +305,8 @@ public boolean hasReachedErrorLimit()\n         // This is set to true when -p option us used.\n         boolean useSuppliedProcedure = false;\n \n+        @Option(desc = \"use upsert instead of insert\", hasArg = false)\n+        boolean upsertMode = DEFAULT_UPSERT_MODE;","path":"src/frontend/org/voltdb/utils/CSVLoader.java","position":21,"original_position":21,"commit_id":"62f8b4e5c2acc0c91af188980479c1c8eade69bd","original_commit_id":"62f8b4e5c2acc0c91af188980479c1c8eade69bd","user":{"login":"akhanzode","id":1675698,"avatar_url":"https://avatars.githubusercontent.com/u/1675698?v=3","gravatar_id":"","url":"https://api.github.com/users/akhanzode","html_url":"https://github.com/akhanzode","followers_url":"https://api.github.com/users/akhanzode/followers","following_url":"https://api.github.com/users/akhanzode/following{/other_user}","gists_url":"https://api.github.com/users/akhanzode/gists{/gist_id}","starred_url":"https://api.github.com/users/akhanzode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhanzode/subscriptions","organizations_url":"https://api.github.com/users/akhanzode/orgs","repos_url":"https://api.github.com/users/akhanzode/repos","events_url":"https://api.github.com/users/akhanzode/events{/privacy}","received_events_url":"https://api.github.com/users/akhanzode/received_events","type":"User","site_admin":false},"body":"The CLI switch should --upsert when specified should defaults to true. and nor upsertMode","created_at":"2015-07-16T15:19:01Z","updated_at":"2015-07-16T15:19:01Z","html_url":"https://github.com/VoltDB/voltdb/pull/2534#discussion_r34799137","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2534","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/34799137"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/2534#discussion_r34799137"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2534"}}},"pull_request":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2534","id":39622218,"html_url":"https://github.com/VoltDB/voltdb/pull/2534","diff_url":"https://github.com/VoltDB/voltdb/pull/2534.diff","patch_url":"https://github.com/VoltDB/voltdb/pull/2534.patch","issue_url":"https://api.github.com/repos/VoltDB/voltdb/issues/2534","number":2534,"state":"open","locked":false,"title":" ENG-8048: Add upsert option to BulkLoader and CSVLoader","user":{"login":"JadenW","id":4342624,"avatar_url":"https://avatars.githubusercontent.com/u/4342624?v=3","gravatar_id":"","url":"https://api.github.com/users/JadenW","html_url":"https://github.com/JadenW","followers_url":"https://api.github.com/users/JadenW/followers","following_url":"https://api.github.com/users/JadenW/following{/other_user}","gists_url":"https://api.github.com/users/JadenW/gists{/gist_id}","starred_url":"https://api.github.com/users/JadenW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JadenW/subscriptions","organizations_url":"https://api.github.com/users/JadenW/orgs","repos_url":"https://api.github.com/users/JadenW/repos","events_url":"https://api.github.com/users/JadenW/events{/privacy}","received_events_url":"https://api.github.com/users/JadenW/received_events","type":"User","site_admin":false},"body":"Unit Test CSVLoader of two upsert cases:\r\n1. multiple lines with same primary key\r\n2. repeatly load same data\r\n\r\nWill add same unit tests for VoltBultLoader if this test approach is correct","created_at":"2015-07-09T20:01:17Z","updated_at":"2015-07-16T15:19:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fe423fa259b81e752ee12ea3b27e27f29e39f38","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2534/commits","review_comments_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2534/comments","review_comment_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/issues/2534/comments","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/62f8b4e5c2acc0c91af188980479c1c8eade69bd","head":{"label":"VoltDB:ENG-8048","ref":"ENG-8048","sha":"62f8b4e5c2acc0c91af188980479c1c8eade69bd","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","created_at":"2011-09-23T18:46:12Z","updated_at":"2015-07-16T06:45:59Z","pushed_at":"2015-07-16T15:16:04Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":714950,"stargazers_count":593,"watchers_count":593,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":175,"mirror_url":null,"open_issues_count":29,"forks":175,"open_issues":29,"watchers":593,"default_branch":"master"}},"base":{"label":"VoltDB:master","ref":"master","sha":"e799045f622e2aae1e2ac9c67314bf5563816ada","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","created_at":"2011-09-23T18:46:12Z","updated_at":"2015-07-16T06:45:59Z","pushed_at":"2015-07-16T15:16:04Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":714950,"stargazers_count":593,"watchers_count":593,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":175,"mirror_url":null,"open_issues_count":29,"forks":175,"open_issues":29,"watchers":593,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2534"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/2534"},"issue":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/2534"},"comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/2534/comments"},"review_comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2534/comments"},"review_comment":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2534/commits"},"statuses":{"href":"https://api.github.com/repos/VoltDB/voltdb/statuses/62f8b4e5c2acc0c91af188980479c1c8eade69bd"}}}}