{"action":"created","issue":{"url":"https://api.github.com/repos/diaspora/diaspora/issues/5654","labels_url":"https://api.github.com/repos/diaspora/diaspora/issues/5654/labels{/name}","comments_url":"https://api.github.com/repos/diaspora/diaspora/issues/5654/comments","events_url":"https://api.github.com/repos/diaspora/diaspora/issues/5654/events","html_url":"https://github.com/diaspora/diaspora/pull/5654","id":57398928,"number":5654,"title":"respect http/https in image paths","user":{"login":"fscz","id":1260104,"avatar_url":"https://avatars.githubusercontent.com/u/1260104?v=3","gravatar_id":"","url":"https://api.github.com/users/fscz","html_url":"https://github.com/fscz","followers_url":"https://api.github.com/users/fscz/followers","following_url":"https://api.github.com/users/fscz/following{/other_user}","gists_url":"https://api.github.com/users/fscz/gists{/gist_id}","starred_url":"https://api.github.com/users/fscz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fscz/subscriptions","organizations_url":"https://api.github.com/users/fscz/orgs","repos_url":"https://api.github.com/users/fscz/repos","events_url":"https://api.github.com/users/fscz/events{/privacy}","received_events_url":"https://api.github.com/users/fscz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-02-12T00:18:06Z","updated_at":"2015-02-12T23:16:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/diaspora/diaspora/pulls/5654","html_url":"https://github.com/diaspora/diaspora/pull/5654","diff_url":"https://github.com/diaspora/diaspora/pull/5654.diff","patch_url":"https://github.com/diaspora/diaspora/pull/5654.patch"},"body":"when running on http, paths to public/uploaded/images... would still be prefixed with https.\r\nmake those paths respect the pod's mode of operation"},"comment":{"url":"https://api.github.com/repos/diaspora/diaspora/issues/comments/74174690","html_url":"https://github.com/diaspora/diaspora/pull/5654#issuecomment-74174690","issue_url":"https://api.github.com/repos/diaspora/diaspora/issues/5654","id":74174690,"user":{"login":"jhass","id":141294,"avatar_url":"https://avatars.githubusercontent.com/u/141294?v=3","gravatar_id":"","url":"https://api.github.com/users/jhass","html_url":"https://github.com/jhass","followers_url":"https://api.github.com/users/jhass/followers","following_url":"https://api.github.com/users/jhass/following{/other_user}","gists_url":"https://api.github.com/users/jhass/gists{/gist_id}","starred_url":"https://api.github.com/users/jhass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhass/subscriptions","organizations_url":"https://api.github.com/users/jhass/orgs","repos_url":"https://api.github.com/users/jhass/repos","events_url":"https://api.github.com/users/jhass/events{/privacy}","received_events_url":"https://api.github.com/users/jhass/received_events","type":"User","site_admin":false},"created_at":"2015-02-12T23:16:54Z","updated_at":"2015-02-12T23:16:54Z","body":"> I see. From my point of we, those tests should be adjusted. But it's not my decision\r\n\r\nThat's a silly statement. If you believe your change is correct and then your change breaks existing tests, of course those needs to be adapted. The decision the reviewer has to make is not whether you need to adapt the tests, but whether your change is correct."}}