{"action":"created","comment":{"url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/comments/38181399","id":38181399,"diff_hunk":"@@ -0,0 +1,18 @@\n+<?xml version=\"1.0\" ?>\n+\n+<container xmlns=\"http://symfony.com/schema/dic/services\"\n+    xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\n+    xsi:schemaLocation=\"http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd\">\n+\n+    <parameters>\n+        <parameter key=\"knp_menu.extension.default_options.class\">Knp\\Bundle\\MenuBundle\\Extension\\DefaultOptionsExtension</parameter>","path":"Resources/config/options_extension.xml","position":8,"original_position":8,"commit_id":"d9514b6265a934884109d00385641b0731ce4e4e","original_commit_id":"d9514b6265a934884109d00385641b0731ce4e4e","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"body":"Ok, in the CMF, we decided to add them in the 1.x serie, for consistency and remove them all in 2.0. So I was a bit unsure about the standard of KnpMenu :)","created_at":"2015-08-28T08:53:12Z","updated_at":"2015-08-28T08:53:12Z","html_url":"https://github.com/KnpLabs/KnpMenuBundle/pull/278#discussion_r38181399","pull_request_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/278","_links":{"self":{"href":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/comments/38181399"},"html":{"href":"https://github.com/KnpLabs/KnpMenuBundle/pull/278#discussion_r38181399"},"pull_request":{"href":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/278"}}},"pull_request":{"url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/278","id":43563932,"html_url":"https://github.com/KnpLabs/KnpMenuBundle/pull/278","diff_url":"https://github.com/KnpLabs/KnpMenuBundle/pull/278.diff","patch_url":"https://github.com/KnpLabs/KnpMenuBundle/pull/278.patch","issue_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/278","number":278,"state":"open","locked":false,"title":"Add ability to configure default menu options","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"body":"In the CMF, menu's aren't created programatically. With the current code, it means the menu options needs to be saved in the database in order to be set on the menu items.\r\n\r\nIt would be much better if we could configure this in the application settings. This PR implements a very simple DefaultOptionsExtensions, setting the default options based on a configured set of options.\r\n\r\nThis extension is automatically registered as soon as at least one option is configured.\r\n\r\n@stof @Nek- I would love to hear your opinion about this (both the idea and whether it should be in this bundle or in the CMF).\r\n\r\nRelated issue: https://github.com/symfony-cmf/MenuBundle/issues/128","created_at":"2015-08-27T20:38:46Z","updated_at":"2015-08-28T08:53:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b5ee863130811a94dec37997ceb1e79a6e3407f","assignee":null,"milestone":{"url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/milestones/1","html_url":"https://github.com/KnpLabs/KnpMenuBundle/milestones/2.1","labels_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/milestones/1/labels","id":1276521,"number":1,"title":"2.1","description":"","creator":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2015-08-27T20:39:11Z","updated_at":"2015-08-28T07:46:41Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/278/commits","review_comments_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/278/comments","review_comment_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/278/comments","statuses_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/statuses/d9514b6265a934884109d00385641b0731ce4e4e","head":{"label":"WouterJ:configure_default_values","ref":"configure_default_values","sha":"d9514b6265a934884109d00385641b0731ce4e4e","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"repo":{"id":14066501,"name":"KnpMenuBundle","full_name":"WouterJ/KnpMenuBundle","owner":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WouterJ/KnpMenuBundle","description":"Object Oriented menus for your Symfony2 project.","fork":true,"url":"https://api.github.com/repos/WouterJ/KnpMenuBundle","forks_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/forks","keys_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/teams","hooks_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/hooks","issue_events_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/issues/events{/number}","events_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/events","assignees_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/assignees{/user}","branches_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/branches{/branch}","tags_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/tags","blobs_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/languages","stargazers_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/stargazers","contributors_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/contributors","subscribers_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/subscribers","subscription_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/subscription","commits_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/contents/{+path}","compare_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/merges","archive_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/downloads","issues_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/issues{/number}","pulls_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/labels{/name}","releases_url":"https://api.github.com/repos/WouterJ/KnpMenuBundle/releases{/id}","created_at":"2013-11-02T13:23:05Z","updated_at":"2013-12-03T07:39:06Z","pushed_at":"2015-08-27T21:04:27Z","git_url":"git://github.com/WouterJ/KnpMenuBundle.git","ssh_url":"git@github.com:WouterJ/KnpMenuBundle.git","clone_url":"https://github.com/WouterJ/KnpMenuBundle.git","svn_url":"https://github.com/WouterJ/KnpMenuBundle","homepage":"KnpLabs.com","size":565,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KnpLabs:master","ref":"master","sha":"5c5b01905d671134efde7dd5d769fee4934a164a","user":{"login":"KnpLabs","id":202732,"avatar_url":"https://avatars.githubusercontent.com/u/202732?v=3","gravatar_id":"","url":"https://api.github.com/users/KnpLabs","html_url":"https://github.com/KnpLabs","followers_url":"https://api.github.com/users/KnpLabs/followers","following_url":"https://api.github.com/users/KnpLabs/following{/other_user}","gists_url":"https://api.github.com/users/KnpLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/KnpLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnpLabs/subscriptions","organizations_url":"https://api.github.com/users/KnpLabs/orgs","repos_url":"https://api.github.com/users/KnpLabs/repos","events_url":"https://api.github.com/users/KnpLabs/events{/privacy}","received_events_url":"https://api.github.com/users/KnpLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":828595,"name":"KnpMenuBundle","full_name":"KnpLabs/KnpMenuBundle","owner":{"login":"KnpLabs","id":202732,"avatar_url":"https://avatars.githubusercontent.com/u/202732?v=3","gravatar_id":"","url":"https://api.github.com/users/KnpLabs","html_url":"https://github.com/KnpLabs","followers_url":"https://api.github.com/users/KnpLabs/followers","following_url":"https://api.github.com/users/KnpLabs/following{/other_user}","gists_url":"https://api.github.com/users/KnpLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/KnpLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnpLabs/subscriptions","organizations_url":"https://api.github.com/users/KnpLabs/orgs","repos_url":"https://api.github.com/users/KnpLabs/repos","events_url":"https://api.github.com/users/KnpLabs/events{/privacy}","received_events_url":"https://api.github.com/users/KnpLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KnpLabs/KnpMenuBundle","description":"Object Oriented menus for your Symfony2 project.","fork":false,"url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle","forks_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/forks","keys_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/teams","hooks_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/hooks","issue_events_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/events{/number}","events_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/events","assignees_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/assignees{/user}","branches_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/branches{/branch}","tags_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/tags","blobs_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/languages","stargazers_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/stargazers","contributors_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/contributors","subscribers_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/subscribers","subscription_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/subscription","commits_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/contents/{+path}","compare_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/merges","archive_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/downloads","issues_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues{/number}","pulls_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/labels{/name}","releases_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/releases{/id}","created_at":"2010-08-10T12:46:57Z","updated_at":"2015-08-26T13:50:36Z","pushed_at":"2015-08-28T07:44:31Z","git_url":"git://github.com/KnpLabs/KnpMenuBundle.git","ssh_url":"git@github.com:KnpLabs/KnpMenuBundle.git","clone_url":"https://github.com/KnpLabs/KnpMenuBundle.git","svn_url":"https://github.com/KnpLabs/KnpMenuBundle","homepage":"KnpLabs.com","size":1316,"stargazers_count":482,"watchers_count":482,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":180,"mirror_url":null,"open_issues_count":12,"forks":180,"open_issues":12,"watchers":482,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/278"},"html":{"href":"https://github.com/KnpLabs/KnpMenuBundle/pull/278"},"issue":{"href":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/278"},"comments":{"href":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/278/comments"},"review_comments":{"href":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/278/comments"},"review_comment":{"href":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/278/commits"},"statuses":{"href":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/statuses/d9514b6265a934884109d00385641b0731ce4e4e"}}}}