{"action":"created","comment":{"url":"https://api.github.com/repos/systemd/systemd/pulls/comments/36045299","id":36045299,"diff_hunk":"@@ -780,6 +843,37 @@ int sd_dhcp_lease_load(sd_dhcp_lease **ret, const char *lease_file) {\n                            \"ROUTES\", &routes,\n                            \"CLIENTID\", &client_id_hex,\n                            \"VENDOR_SPECIFIC\", &vendor_specific_hex,\n+                           \"OPTION_224\", &options[DHCP_OPTION_PRIVATE_0 - DHCP_OPTION_PRIVATE_START],","path":"src/libsystemd-network/sd-dhcp-lease.c","position":116,"original_position":117,"commit_id":"8840922673c0f06f0fe517a2b7f8d769830fd470","original_commit_id":"8db84a4e2e2e5e542baeebc17cd4da376361e813","user":{"login":"crawford","id":368848,"avatar_url":"https://avatars.githubusercontent.com/u/368848?v=3","gravatar_id":"","url":"https://api.github.com/users/crawford","html_url":"https://github.com/crawford","followers_url":"https://api.github.com/users/crawford/followers","following_url":"https://api.github.com/users/crawford/following{/other_user}","gists_url":"https://api.github.com/users/crawford/gists{/gist_id}","starred_url":"https://api.github.com/users/crawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crawford/subscriptions","organizations_url":"https://api.github.com/users/crawford/orgs","repos_url":"https://api.github.com/users/crawford/repos","events_url":"https://api.github.com/users/crawford/events{/privacy}","received_events_url":"https://api.github.com/users/crawford/received_events","type":"User","site_admin":false},"body":"Hmm, actually it doesn't. I get no warning about `&options[31]`, but it does complain if I write `options[31]`. I guess it's treating `&options[31]` the same way as it would `options + 31`.","created_at":"2015-08-02T17:37:01Z","updated_at":"2015-08-02T17:37:01Z","html_url":"https://github.com/systemd/systemd/pull/824#discussion_r36045299","pull_request_url":"https://api.github.com/repos/systemd/systemd/pulls/824","_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments/36045299"},"html":{"href":"https://github.com/systemd/systemd/pull/824#discussion_r36045299"},"pull_request":{"href":"https://api.github.com/repos/systemd/systemd/pulls/824"}}},"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/824","id":41399972,"html_url":"https://github.com/systemd/systemd/pull/824","diff_url":"https://github.com/systemd/systemd/pull/824.diff","patch_url":"https://github.com/systemd/systemd/pull/824.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/824","number":824,"state":"open","locked":false,"title":"networkd: save private-zone DHCP options","user":{"login":"crawford","id":368848,"avatar_url":"https://avatars.githubusercontent.com/u/368848?v=3","gravatar_id":"","url":"https://api.github.com/users/crawford","html_url":"https://github.com/crawford","followers_url":"https://api.github.com/users/crawford/followers","following_url":"https://api.github.com/users/crawford/following{/other_user}","gists_url":"https://api.github.com/users/crawford/gists{/gist_id}","starred_url":"https://api.github.com/users/crawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crawford/subscriptions","organizations_url":"https://api.github.com/users/crawford/orgs","repos_url":"https://api.github.com/users/crawford/repos","events_url":"https://api.github.com/users/crawford/events{/privacy}","received_events_url":"https://api.github.com/users/crawford/received_events","type":"User","site_admin":false},"body":"It's useful to have networkd expose private-zone DHCP options provided in the current leases. This series of commits is the first half of this functionality. The options are stored as part of the lease and written to the lease files along with the other options.\r\n\r\n```\r\n# This is private data. Do not parse.\r\nADDRESS=10.0.0.2\r\nNETMASK=255.255.255.0\r\nROUTER=10.0.0.1\r\nSERVER_ADDRESS=10.0.0.1\r\nNEXT_SERVER=10.0.0.1\r\nDNS=10.0.0.1\r\nNTP=10.0.0.1\r\nDOMAINNAME=br2.local\r\nCLIENTID=ff3f90f17800020000ab11aecd425e31d72980\r\nOPTION_247=48616c6c6f\r\n```","created_at":"2015-08-01T10:32:35Z","updated_at":"2015-08-02T17:37:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9d13d1a98e1007707e71139d00390f8ce56af1a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/824/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/824/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/824/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/8840922673c0f06f0fe517a2b7f8d769830fd470","head":{"label":"crawford:dhcp-private-options","ref":"dhcp-private-options","sha":"8840922673c0f06f0fe517a2b7f8d769830fd470","user":{"login":"crawford","id":368848,"avatar_url":"https://avatars.githubusercontent.com/u/368848?v=3","gravatar_id":"","url":"https://api.github.com/users/crawford","html_url":"https://github.com/crawford","followers_url":"https://api.github.com/users/crawford/followers","following_url":"https://api.github.com/users/crawford/following{/other_user}","gists_url":"https://api.github.com/users/crawford/gists{/gist_id}","starred_url":"https://api.github.com/users/crawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crawford/subscriptions","organizations_url":"https://api.github.com/users/crawford/orgs","repos_url":"https://api.github.com/users/crawford/repos","events_url":"https://api.github.com/users/crawford/events{/privacy}","received_events_url":"https://api.github.com/users/crawford/received_events","type":"User","site_admin":false},"repo":{"id":36767757,"name":"systemd","full_name":"crawford/systemd","owner":{"login":"crawford","id":368848,"avatar_url":"https://avatars.githubusercontent.com/u/368848?v=3","gravatar_id":"","url":"https://api.github.com/users/crawford","html_url":"https://github.com/crawford","followers_url":"https://api.github.com/users/crawford/followers","following_url":"https://api.github.com/users/crawford/following{/other_user}","gists_url":"https://api.github.com/users/crawford/gists{/gist_id}","starred_url":"https://api.github.com/users/crawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crawford/subscriptions","organizations_url":"https://api.github.com/users/crawford/orgs","repos_url":"https://api.github.com/users/crawford/repos","events_url":"https://api.github.com/users/crawford/events{/privacy}","received_events_url":"https://api.github.com/users/crawford/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crawford/systemd","description":"CoreOS systemd release branches","fork":true,"url":"https://api.github.com/repos/crawford/systemd","forks_url":"https://api.github.com/repos/crawford/systemd/forks","keys_url":"https://api.github.com/repos/crawford/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crawford/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crawford/systemd/teams","hooks_url":"https://api.github.com/repos/crawford/systemd/hooks","issue_events_url":"https://api.github.com/repos/crawford/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/crawford/systemd/events","assignees_url":"https://api.github.com/repos/crawford/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/crawford/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/crawford/systemd/tags","blobs_url":"https://api.github.com/repos/crawford/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crawford/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crawford/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/crawford/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crawford/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/crawford/systemd/languages","stargazers_url":"https://api.github.com/repos/crawford/systemd/stargazers","contributors_url":"https://api.github.com/repos/crawford/systemd/contributors","subscribers_url":"https://api.github.com/repos/crawford/systemd/subscribers","subscription_url":"https://api.github.com/repos/crawford/systemd/subscription","commits_url":"https://api.github.com/repos/crawford/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/crawford/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/crawford/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/crawford/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/crawford/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/crawford/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crawford/systemd/merges","archive_url":"https://api.github.com/repos/crawford/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crawford/systemd/downloads","issues_url":"https://api.github.com/repos/crawford/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/crawford/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/crawford/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/crawford/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crawford/systemd/labels{/name}","releases_url":"https://api.github.com/repos/crawford/systemd/releases{/id}","created_at":"2015-06-02T23:27:40Z","updated_at":"2015-06-02T23:27:45Z","pushed_at":"2015-08-02T16:53:21Z","git_url":"git://github.com/crawford/systemd.git","ssh_url":"git@github.com:crawford/systemd.git","clone_url":"https://github.com/crawford/systemd.git","svn_url":"https://github.com/crawford/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":36415,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"58d5d500d83d51307fd580c788a5ca3a9f4cb96c","user":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"name":"systemd","full_name":"systemd/systemd","owner":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systemd/systemd","description":"systemd upstream","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","created_at":"2015-03-25T15:27:27Z","updated_at":"2015-08-02T03:22:54Z","pushed_at":"2015-08-02T17:32:21Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"git@github.com:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":45585,"stargazers_count":478,"watchers_count":478,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":134,"mirror_url":null,"open_issues_count":113,"forks":134,"open_issues":113,"watchers":478,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/824"},"html":{"href":"https://github.com/systemd/systemd/pull/824"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/824"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/824/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/824/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/824/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/8840922673c0f06f0fe517a2b7f8d769830fd470"}}}}