{"action":"created","comment":{"url":"https://api.github.com/repos/airblade/paper_trail/pulls/comments/46845183","id":46845183,"diff_hunk":"@@ -210,9 +212,8 @@ def reify(options = {})\n     # not have an `object_changes` text column.\n     def changeset\n       return nil unless self.class.column_names.include? 'object_changes'\n-\n-      _changes = self.class.object_changes_col_is_json? ? object_changes : PaperTrail.serializer.load(object_changes)\n-      @changeset ||= HashWithIndifferentAccess.new(_changes).tap do |changes|\n+      _changes = HashWithIndifferentAccess.new(object_changes_deserialized)\n+      @changeset ||= _changes.tap do |changes|\n         if PaperTrail.serialized_attributes?\n           item_type.constantize.unserialize_attribute_changes_for_paper_trail!(changes)\n         end","path":"lib/paper_trail/version_concern.rb","position":31,"original_position":31,"commit_id":"4ac68883e8a2b6cb38efc23b61d672a8ca44fffb","original_commit_id":"4ac68883e8a2b6cb38efc23b61d672a8ca44fffb","user":{"login":"jaredbeck","id":380809,"avatar_url":"https://avatars.githubusercontent.com/u/380809?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredbeck","html_url":"https://github.com/jaredbeck","followers_url":"https://api.github.com/users/jaredbeck/followers","following_url":"https://api.github.com/users/jaredbeck/following{/other_user}","gists_url":"https://api.github.com/users/jaredbeck/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredbeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredbeck/subscriptions","organizations_url":"https://api.github.com/users/jaredbeck/orgs","repos_url":"https://api.github.com/users/jaredbeck/repos","events_url":"https://api.github.com/users/jaredbeck/events{/privacy}","received_events_url":"https://api.github.com/users/jaredbeck/received_events","type":"User","site_admin":false},"body":"Good suggestion.  I like it, though I prefer to extract a new method rather than have an anonymous block that long.","created_at":"2015-12-07T16:55:32Z","updated_at":"2015-12-07T16:55:32Z","html_url":"https://github.com/airblade/paper_trail/pull/661#discussion_r46845183","pull_request_url":"https://api.github.com/repos/airblade/paper_trail/pulls/661","_links":{"self":{"href":"https://api.github.com/repos/airblade/paper_trail/pulls/comments/46845183"},"html":{"href":"https://github.com/airblade/paper_trail/pull/661#discussion_r46845183"},"pull_request":{"href":"https://api.github.com/repos/airblade/paper_trail/pulls/661"}}},"pull_request":{"url":"https://api.github.com/repos/airblade/paper_trail/pulls/661","id":52033379,"html_url":"https://github.com/airblade/paper_trail/pull/661","diff_url":"https://github.com/airblade/paper_trail/pull/661.diff","patch_url":"https://github.com/airblade/paper_trail/pull/661.patch","issue_url":"https://api.github.com/repos/airblade/paper_trail/issues/661","number":661,"state":"open","locked":false,"title":"Code style: break long lines","user":{"login":"jaredbeck","id":380809,"avatar_url":"https://avatars.githubusercontent.com/u/380809?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredbeck","html_url":"https://github.com/jaredbeck","followers_url":"https://api.github.com/users/jaredbeck/followers","following_url":"https://api.github.com/users/jaredbeck/following{/other_user}","gists_url":"https://api.github.com/users/jaredbeck/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredbeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredbeck/subscriptions","organizations_url":"https://api.github.com/users/jaredbeck/orgs","repos_url":"https://api.github.com/users/jaredbeck/repos","events_url":"https://api.github.com/users/jaredbeck/events{/privacy}","received_events_url":"https://api.github.com/users/jaredbeck/received_events","type":"User","site_admin":false},"body":"Limits maximum line length to 100 characters.  The ruby style guide recommends 80 characters (https://github.com/bbatsov/ruby-style-guide#80-character-limits), but that would be a big undertaking.\r\n\r\nIn a few places, extracting a method was the best way to break a long line. I've made separate commits for each of those method extractions. Some of the new methods were hard to name. Also, I'm not thrilled about adding more methods to `PaperTrail::Model`. We already add a lot of clutter to people's AR models. I'm open to other ideas about where these methods could live.","created_at":"2015-11-28T04:46:19Z","updated_at":"2015-12-07T16:55:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d10093b7d65c983b8bc2507548cc78be75fa0719","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/airblade/paper_trail/pulls/661/commits","review_comments_url":"https://api.github.com/repos/airblade/paper_trail/pulls/661/comments","review_comment_url":"https://api.github.com/repos/airblade/paper_trail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airblade/paper_trail/issues/661/comments","statuses_url":"https://api.github.com/repos/airblade/paper_trail/statuses/4ac68883e8a2b6cb38efc23b61d672a8ca44fffb","head":{"label":"airblade:code_style_20151127","ref":"code_style_20151127","sha":"4ac68883e8a2b6cb38efc23b61d672a8ca44fffb","user":{"login":"airblade","id":7265,"avatar_url":"https://avatars.githubusercontent.com/u/7265?v=3","gravatar_id":"","url":"https://api.github.com/users/airblade","html_url":"https://github.com/airblade","followers_url":"https://api.github.com/users/airblade/followers","following_url":"https://api.github.com/users/airblade/following{/other_user}","gists_url":"https://api.github.com/users/airblade/gists{/gist_id}","starred_url":"https://api.github.com/users/airblade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airblade/subscriptions","organizations_url":"https://api.github.com/users/airblade/orgs","repos_url":"https://api.github.com/users/airblade/repos","events_url":"https://api.github.com/users/airblade/events{/privacy}","received_events_url":"https://api.github.com/users/airblade/received_events","type":"User","site_admin":false},"repo":{"id":211588,"name":"paper_trail","full_name":"airblade/paper_trail","owner":{"login":"airblade","id":7265,"avatar_url":"https://avatars.githubusercontent.com/u/7265?v=3","gravatar_id":"","url":"https://api.github.com/users/airblade","html_url":"https://github.com/airblade","followers_url":"https://api.github.com/users/airblade/followers","following_url":"https://api.github.com/users/airblade/following{/other_user}","gists_url":"https://api.github.com/users/airblade/gists{/gist_id}","starred_url":"https://api.github.com/users/airblade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airblade/subscriptions","organizations_url":"https://api.github.com/users/airblade/orgs","repos_url":"https://api.github.com/users/airblade/repos","events_url":"https://api.github.com/users/airblade/events{/privacy}","received_events_url":"https://api.github.com/users/airblade/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/airblade/paper_trail","description":"Track changes to your models' data.  Good for auditing or versioning.","fork":false,"url":"https://api.github.com/repos/airblade/paper_trail","forks_url":"https://api.github.com/repos/airblade/paper_trail/forks","keys_url":"https://api.github.com/repos/airblade/paper_trail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airblade/paper_trail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airblade/paper_trail/teams","hooks_url":"https://api.github.com/repos/airblade/paper_trail/hooks","issue_events_url":"https://api.github.com/repos/airblade/paper_trail/issues/events{/number}","events_url":"https://api.github.com/repos/airblade/paper_trail/events","assignees_url":"https://api.github.com/repos/airblade/paper_trail/assignees{/user}","branches_url":"https://api.github.com/repos/airblade/paper_trail/branches{/branch}","tags_url":"https://api.github.com/repos/airblade/paper_trail/tags","blobs_url":"https://api.github.com/repos/airblade/paper_trail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airblade/paper_trail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airblade/paper_trail/git/refs{/sha}","trees_url":"https://api.github.com/repos/airblade/paper_trail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airblade/paper_trail/statuses/{sha}","languages_url":"https://api.github.com/repos/airblade/paper_trail/languages","stargazers_url":"https://api.github.com/repos/airblade/paper_trail/stargazers","contributors_url":"https://api.github.com/repos/airblade/paper_trail/contributors","subscribers_url":"https://api.github.com/repos/airblade/paper_trail/subscribers","subscription_url":"https://api.github.com/repos/airblade/paper_trail/subscription","commits_url":"https://api.github.com/repos/airblade/paper_trail/commits{/sha}","git_commits_url":"https://api.github.com/repos/airblade/paper_trail/git/commits{/sha}","comments_url":"https://api.github.com/repos/airblade/paper_trail/comments{/number}","issue_comment_url":"https://api.github.com/repos/airblade/paper_trail/issues/comments{/number}","contents_url":"https://api.github.com/repos/airblade/paper_trail/contents/{+path}","compare_url":"https://api.github.com/repos/airblade/paper_trail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airblade/paper_trail/merges","archive_url":"https://api.github.com/repos/airblade/paper_trail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airblade/paper_trail/downloads","issues_url":"https://api.github.com/repos/airblade/paper_trail/issues{/number}","pulls_url":"https://api.github.com/repos/airblade/paper_trail/pulls{/number}","milestones_url":"https://api.github.com/repos/airblade/paper_trail/milestones{/number}","notifications_url":"https://api.github.com/repos/airblade/paper_trail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airblade/paper_trail/labels{/name}","releases_url":"https://api.github.com/repos/airblade/paper_trail/releases{/id}","created_at":"2009-05-27T15:20:55Z","updated_at":"2015-12-07T13:40:43Z","pushed_at":"2015-12-07T16:51:09Z","git_url":"git://github.com/airblade/paper_trail.git","ssh_url":"git@github.com:airblade/paper_trail.git","clone_url":"https://github.com/airblade/paper_trail.git","svn_url":"https://github.com/airblade/paper_trail","homepage":"","size":2904,"stargazers_count":3680,"watchers_count":3680,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":483,"mirror_url":null,"open_issues_count":22,"forks":483,"open_issues":22,"watchers":3680,"default_branch":"master"}},"base":{"label":"airblade:master","ref":"master","sha":"416ce64c145240466e28a55ae983629aaf1316f5","user":{"login":"airblade","id":7265,"avatar_url":"https://avatars.githubusercontent.com/u/7265?v=3","gravatar_id":"","url":"https://api.github.com/users/airblade","html_url":"https://github.com/airblade","followers_url":"https://api.github.com/users/airblade/followers","following_url":"https://api.github.com/users/airblade/following{/other_user}","gists_url":"https://api.github.com/users/airblade/gists{/gist_id}","starred_url":"https://api.github.com/users/airblade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airblade/subscriptions","organizations_url":"https://api.github.com/users/airblade/orgs","repos_url":"https://api.github.com/users/airblade/repos","events_url":"https://api.github.com/users/airblade/events{/privacy}","received_events_url":"https://api.github.com/users/airblade/received_events","type":"User","site_admin":false},"repo":{"id":211588,"name":"paper_trail","full_name":"airblade/paper_trail","owner":{"login":"airblade","id":7265,"avatar_url":"https://avatars.githubusercontent.com/u/7265?v=3","gravatar_id":"","url":"https://api.github.com/users/airblade","html_url":"https://github.com/airblade","followers_url":"https://api.github.com/users/airblade/followers","following_url":"https://api.github.com/users/airblade/following{/other_user}","gists_url":"https://api.github.com/users/airblade/gists{/gist_id}","starred_url":"https://api.github.com/users/airblade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airblade/subscriptions","organizations_url":"https://api.github.com/users/airblade/orgs","repos_url":"https://api.github.com/users/airblade/repos","events_url":"https://api.github.com/users/airblade/events{/privacy}","received_events_url":"https://api.github.com/users/airblade/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/airblade/paper_trail","description":"Track changes to your models' data.  Good for auditing or versioning.","fork":false,"url":"https://api.github.com/repos/airblade/paper_trail","forks_url":"https://api.github.com/repos/airblade/paper_trail/forks","keys_url":"https://api.github.com/repos/airblade/paper_trail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airblade/paper_trail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airblade/paper_trail/teams","hooks_url":"https://api.github.com/repos/airblade/paper_trail/hooks","issue_events_url":"https://api.github.com/repos/airblade/paper_trail/issues/events{/number}","events_url":"https://api.github.com/repos/airblade/paper_trail/events","assignees_url":"https://api.github.com/repos/airblade/paper_trail/assignees{/user}","branches_url":"https://api.github.com/repos/airblade/paper_trail/branches{/branch}","tags_url":"https://api.github.com/repos/airblade/paper_trail/tags","blobs_url":"https://api.github.com/repos/airblade/paper_trail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airblade/paper_trail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airblade/paper_trail/git/refs{/sha}","trees_url":"https://api.github.com/repos/airblade/paper_trail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airblade/paper_trail/statuses/{sha}","languages_url":"https://api.github.com/repos/airblade/paper_trail/languages","stargazers_url":"https://api.github.com/repos/airblade/paper_trail/stargazers","contributors_url":"https://api.github.com/repos/airblade/paper_trail/contributors","subscribers_url":"https://api.github.com/repos/airblade/paper_trail/subscribers","subscription_url":"https://api.github.com/repos/airblade/paper_trail/subscription","commits_url":"https://api.github.com/repos/airblade/paper_trail/commits{/sha}","git_commits_url":"https://api.github.com/repos/airblade/paper_trail/git/commits{/sha}","comments_url":"https://api.github.com/repos/airblade/paper_trail/comments{/number}","issue_comment_url":"https://api.github.com/repos/airblade/paper_trail/issues/comments{/number}","contents_url":"https://api.github.com/repos/airblade/paper_trail/contents/{+path}","compare_url":"https://api.github.com/repos/airblade/paper_trail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airblade/paper_trail/merges","archive_url":"https://api.github.com/repos/airblade/paper_trail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airblade/paper_trail/downloads","issues_url":"https://api.github.com/repos/airblade/paper_trail/issues{/number}","pulls_url":"https://api.github.com/repos/airblade/paper_trail/pulls{/number}","milestones_url":"https://api.github.com/repos/airblade/paper_trail/milestones{/number}","notifications_url":"https://api.github.com/repos/airblade/paper_trail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airblade/paper_trail/labels{/name}","releases_url":"https://api.github.com/repos/airblade/paper_trail/releases{/id}","created_at":"2009-05-27T15:20:55Z","updated_at":"2015-12-07T13:40:43Z","pushed_at":"2015-12-07T16:51:09Z","git_url":"git://github.com/airblade/paper_trail.git","ssh_url":"git@github.com:airblade/paper_trail.git","clone_url":"https://github.com/airblade/paper_trail.git","svn_url":"https://github.com/airblade/paper_trail","homepage":"","size":2904,"stargazers_count":3680,"watchers_count":3680,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":483,"mirror_url":null,"open_issues_count":22,"forks":483,"open_issues":22,"watchers":3680,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airblade/paper_trail/pulls/661"},"html":{"href":"https://github.com/airblade/paper_trail/pull/661"},"issue":{"href":"https://api.github.com/repos/airblade/paper_trail/issues/661"},"comments":{"href":"https://api.github.com/repos/airblade/paper_trail/issues/661/comments"},"review_comments":{"href":"https://api.github.com/repos/airblade/paper_trail/pulls/661/comments"},"review_comment":{"href":"https://api.github.com/repos/airblade/paper_trail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airblade/paper_trail/pulls/661/commits"},"statuses":{"href":"https://api.github.com/repos/airblade/paper_trail/statuses/4ac68883e8a2b6cb38efc23b61d672a8ca44fffb"}}}}