{"action":"created","issue":{"url":"https://api.github.com/repos/zalando/patroni/issues/79","labels_url":"https://api.github.com/repos/zalando/patroni/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/zalando/patroni/issues/79/comments","events_url":"https://api.github.com/repos/zalando/patroni/issues/79/events","html_url":"https://github.com/zalando/patroni/pull/79","id":113112545,"number":79,"title":"Move basebackup method to postgresql.py, make other methods extensions","user":{"login":"jberkus","id":115146,"avatar_url":"https://avatars.githubusercontent.com/u/115146?v=3","gravatar_id":"","url":"https://api.github.com/users/jberkus","html_url":"https://github.com/jberkus","followers_url":"https://api.github.com/users/jberkus/followers","following_url":"https://api.github.com/users/jberkus/following{/other_user}","gists_url":"https://api.github.com/users/jberkus/gists{/gist_id}","starred_url":"https://api.github.com/users/jberkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jberkus/subscriptions","organizations_url":"https://api.github.com/users/jberkus/orgs","repos_url":"https://api.github.com/users/jberkus/repos","events_url":"https://api.github.com/users/jberkus/events{/privacy}","received_events_url":"https://api.github.com/users/jberkus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-23T22:45:12Z","updated_at":"2015-10-26T16:41:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zalando/patroni/pulls/79","html_url":"https://github.com/zalando/patroni/pull/79","diff_url":"https://github.com/zalando/patroni/pull/79.diff","patch_url":"https://github.com/zalando/patroni/pull/79.patch"},"body":"This is my PR to merge the default replica method, basebackup, into the mainstream postgresql.py.  Some notes:\r\n\r\n1. The create_replica test is failing for reasons I can't figure out.  The body of the test consists of passing an invalid connection string and having create_replica fail.  When I walk through the code on my own, with the same parameters, it fails as it should, but it \"succeeds\" in the test for reasons I can't discern.  Probably I should just rewrite the test to actually create a replica, except is there a postgresql running at that point?\r\n\r\n2. I had to make substantial changes to the connstring static method.  As far as I can tell, this is used only by create_replica at present, but please check to make sure I didn't break something else.\r\n\r\n3. I split out restore-from-wal-e into its own library in scripts/.  However, this probably means some of the other files in scripts/ should be deleted.\r\n\r\nOther comments?"},"comment":{"url":"https://api.github.com/repos/zalando/patroni/issues/comments/151203210","html_url":"https://github.com/zalando/patroni/pull/79#issuecomment-151203210","issue_url":"https://api.github.com/repos/zalando/patroni/issues/79","id":151203210,"user":{"login":"jberkus","id":115146,"avatar_url":"https://avatars.githubusercontent.com/u/115146?v=3","gravatar_id":"","url":"https://api.github.com/users/jberkus","html_url":"https://github.com/jberkus","followers_url":"https://api.github.com/users/jberkus/followers","following_url":"https://api.github.com/users/jberkus/following{/other_user}","gists_url":"https://api.github.com/users/jberkus/gists{/gist_id}","starred_url":"https://api.github.com/users/jberkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jberkus/subscriptions","organizations_url":"https://api.github.com/users/jberkus/orgs","repos_url":"https://api.github.com/users/jberkus/repos","events_url":"https://api.github.com/users/jberkus/events{/privacy}","received_events_url":"https://api.github.com/users/jberkus/received_events","type":"User","site_admin":false},"created_at":"2015-10-26T16:41:01Z","updated_at":"2015-10-26T16:41:01Z","body":"Will check for wal-e-restore.sh.  Also I see that my changed to postgres0.yml didn't merge in; fixing."}}