{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/puppet-elasticsearch/issues/491","labels_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/issues/491/labels{/name}","comments_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/issues/491/comments","events_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/issues/491/events","html_url":"https://github.com/elastic/puppet-elasticsearch/pull/491","id":116753686,"number":491,"title":"Some changes to support OpenBSD:","user":{"login":"buzzdeee","id":8383396,"avatar_url":"https://avatars.githubusercontent.com/u/8383396?v=3","gravatar_id":"","url":"https://api.github.com/users/buzzdeee","html_url":"https://github.com/buzzdeee","followers_url":"https://api.github.com/users/buzzdeee/followers","following_url":"https://api.github.com/users/buzzdeee/following{/other_user}","gists_url":"https://api.github.com/users/buzzdeee/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzdeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzdeee/subscriptions","organizations_url":"https://api.github.com/users/buzzdeee/orgs","repos_url":"https://api.github.com/users/buzzdeee/repos","events_url":"https://api.github.com/users/buzzdeee/events{/privacy}","received_events_url":"https://api.github.com/users/buzzdeee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-11-13T11:48:23Z","updated_at":"2015-11-16T21:59:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/puppet-elasticsearch/pulls/491","html_url":"https://github.com/elastic/puppet-elasticsearch/pull/491","diff_url":"https://github.com/elastic/puppet-elasticsearch/pull/491.diff","patch_url":"https://github.com/elastic/puppet-elasticsearch/pull/491.patch"},"body":" * a couple of OpenBSD specific additions to params.pp, i.e. user,\r\n   download tool, paths, service provider, etc.\r\n * add a $service_flags parameter to instance.pp, since the OpenBSD\r\n   service type supports flags, and those should be settable.\r\n * add a $service_flags parameter to service.pp, that gets passed\r\n   in from instance.pp, and handed over to openbsd.pp service.\r\n * add an easy openbsd service provider, that only knows about\r\n   status, ensure, pid_dir, service_flags and init_template\r\n   parameters. There is no \"standard\" defaults file on OpenBSD.\r\n * because the defaults_location on OpenBSD is not set, guard\r\n   the augeas call in config.pp to manage the defaults file.\r\n * added a template for the openbsd service, based on the\r\n   rc script, that comes with the package.\r\n\r\n\r\ntested with elasticsearch-1.7.2, configured and fired up an instance as well as plugin installation works.\r\n\r\nLet me know if there is something that needs change/enhancement to get merged.\r\n\r\nthanks,\r\nSebastian"},"comment":{"url":"https://api.github.com/repos/elastic/puppet-elasticsearch/issues/comments/157183999","html_url":"https://github.com/elastic/puppet-elasticsearch/pull/491#issuecomment-157183999","issue_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/issues/491","id":157183999,"user":{"login":"electrical","id":271677,"avatar_url":"https://avatars.githubusercontent.com/u/271677?v=3","gravatar_id":"","url":"https://api.github.com/users/electrical","html_url":"https://github.com/electrical","followers_url":"https://api.github.com/users/electrical/followers","following_url":"https://api.github.com/users/electrical/following{/other_user}","gists_url":"https://api.github.com/users/electrical/gists{/gist_id}","starred_url":"https://api.github.com/users/electrical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrical/subscriptions","organizations_url":"https://api.github.com/users/electrical/orgs","repos_url":"https://api.github.com/users/electrical/repos","events_url":"https://api.github.com/users/electrical/events{/privacy}","received_events_url":"https://api.github.com/users/electrical/received_events","type":"User","site_admin":false},"created_at":"2015-11-16T21:59:49Z","updated_at":"2015-11-16T21:59:49Z","body":"Cool. Thank you for the clarification.\r\nI assume that we don't need to setup any special repositories then ?\r\nI'll kick off jenkins for the current things.\r\nI don't have an openbsd vagrant box to run the tests against but will be doing that at some point so I can be sure not to break things later :)"}}