{"action":"created","issue":{"url":"https://api.github.com/repos/hhff/ember-infinity/issues/77","labels_url":"https://api.github.com/repos/hhff/ember-infinity/issues/77/labels{/name}","comments_url":"https://api.github.com/repos/hhff/ember-infinity/issues/77/comments","events_url":"https://api.github.com/repos/hhff/ember-infinity/issues/77/events","html_url":"https://github.com/hhff/ember-infinity/pull/77","id":101732172,"number":77,"title":"Add afterModelPromise option","user":{"login":"kxcrl","id":2732584,"avatar_url":"https://avatars.githubusercontent.com/u/2732584?v=3","gravatar_id":"","url":"https://api.github.com/users/kxcrl","html_url":"https://github.com/kxcrl","followers_url":"https://api.github.com/users/kxcrl/followers","following_url":"https://api.github.com/users/kxcrl/following{/other_user}","gists_url":"https://api.github.com/users/kxcrl/gists{/gist_id}","starred_url":"https://api.github.com/users/kxcrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kxcrl/subscriptions","organizations_url":"https://api.github.com/users/kxcrl/orgs","repos_url":"https://api.github.com/users/kxcrl/repos","events_url":"https://api.github.com/users/kxcrl/events{/privacy}","received_events_url":"https://api.github.com/users/kxcrl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-18T19:33:29Z","updated_at":"2015-08-18T20:43:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hhff/ember-infinity/pulls/77","html_url":"https://github.com/hhff/ember-infinity/pull/77","diff_url":"https://github.com/hhff/ember-infinity/pull/77.diff","patch_url":"https://github.com/hhff/ember-infinity/pull/77.patch"},"body":"In the application that I'm working on, there are many cases where `get(this, 'store').find(modelName, params)` is not the end of the promise chain before we hand the fetched models to the route. This PR adds that functionality.\r\n\r\nI tried to follow the conventions that I could see for declaring private parameters, using the options object, and deleting keys after creating variables for them. That said, it does seem a little odd to have an `_afterModelPromise` private property, and you might have better suggestions for how things should be named."},"comment":{"url":"https://api.github.com/repos/hhff/ember-infinity/issues/comments/132344904","html_url":"https://github.com/hhff/ember-infinity/pull/77#issuecomment-132344904","issue_url":"https://api.github.com/repos/hhff/ember-infinity/issues/77","id":132344904,"user":{"login":"kxcrl","id":2732584,"avatar_url":"https://avatars.githubusercontent.com/u/2732584?v=3","gravatar_id":"","url":"https://api.github.com/users/kxcrl","html_url":"https://github.com/kxcrl","followers_url":"https://api.github.com/users/kxcrl/followers","following_url":"https://api.github.com/users/kxcrl/following{/other_user}","gists_url":"https://api.github.com/users/kxcrl/gists{/gist_id}","starred_url":"https://api.github.com/users/kxcrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kxcrl/subscriptions","organizations_url":"https://api.github.com/users/kxcrl/orgs","repos_url":"https://api.github.com/users/kxcrl/repos","events_url":"https://api.github.com/users/kxcrl/events{/privacy}","received_events_url":"https://api.github.com/users/kxcrl/received_events","type":"User","site_admin":false},"created_at":"2015-08-18T20:43:27Z","updated_at":"2015-08-18T20:43:27Z","body":"Sorry about opening a PR with test failures. Before I go in and fix them up, I wanted to make sure that this was actually an option you were interested in and an approach that makes sense. If it is, I'm happy to go in and update all of the testing. If the approach doesn't make sense, I'm also happy to try something else."}}