{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/25095843","id":25095843,"diff_hunk":"@@ -13,17 +13,41 @@ def self.description\n \n   def self.raw_connect(hostname, port, api_version)\n     require 'kubeclient'\n-    require 'uri'\n-\n-    uri = URI::HTTP.build(:path => \"/api\", :port => port.to_i)\n+    api_endpoint = raw_api_endpoint(hostname, port)\n+    Kubeclient::Client.new(api_endpoint, api_version)\n+  end\n \n+  def self.raw_api_endpoint(hostname, port)\n+    require 'uri'\n     # URI::Generic#hostname= was added in ruby 1.9.3 and will automatically\n     # wrap an ipv6 address in []\n-    uri.hostname = hostname\n-    Kubeclient::Client.new uri.to_s, api_version\n+    URI::HTTP.build(:host => hostname, :port => port.to_i, :path => '/api')","path":"vmdb/app/models/ems_kubernetes.rb","position":17,"original_position":17,"commit_id":"f26272cb2fce03b64e7c349d78b6a7994b9db559","original_commit_id":"f26272cb2fce03b64e7c349d78b6a7994b9db559","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"body":"You did.   I just didn't see your message before I replied\n:stuck_out_tongue:\n On Feb 20, 2015 2:28 PM, \"Joe Rafaniello\" <notifications@github.com> wrote:\n\n> In vmdb/app/models/ems_kubernetes.rb\n> <https://github.com/ManageIQ/manageiq/pull/1679#discussion_r25095744>:\n>\n> >      # URI::Generic#hostname= was added in ruby 1.9.3 and will automatically\n> >      # wrap an ipv6 address in []\n> > -    uri.hostname = hostname\n> > -    Kubeclient::Client.new uri.to_s, api_version\n> > +    URI::HTTP.build(:host => hostname, :port => port.to_i, :path => '/api')\n>\n> Yeah, that's what I said... I thought.\n>\n> You have to create a URI object and call .hostname=.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/ManageIQ/manageiq/pull/1679/files#r25095744>.\n>\n","created_at":"2015-02-20T19:29:03Z","updated_at":"2015-02-20T19:29:03Z","html_url":"https://github.com/ManageIQ/manageiq/pull/1679#discussion_r25095843","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1679","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/25095843"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/1679#discussion_r25095843"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1679"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1679","id":29261313,"html_url":"https://github.com/ManageIQ/manageiq/pull/1679","diff_url":"https://github.com/ManageIQ/manageiq/pull/1679.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/1679.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1679","number":1679,"state":"open","locked":false,"title":"kubernetes: add event catcher implementation","user":{"login":"simon3z","id":130393,"avatar_url":"https://avatars.githubusercontent.com/u/130393?v=3","gravatar_id":"","url":"https://api.github.com/users/simon3z","html_url":"https://github.com/simon3z","followers_url":"https://api.github.com/users/simon3z/followers","following_url":"https://api.github.com/users/simon3z/following{/other_user}","gists_url":"https://api.github.com/users/simon3z/gists{/gist_id}","starred_url":"https://api.github.com/users/simon3z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon3z/subscriptions","organizations_url":"https://api.github.com/users/simon3z/orgs","repos_url":"https://api.github.com/users/simon3z/repos","events_url":"https://api.github.com/users/simon3z/events{/privacy}","received_events_url":"https://api.github.com/users/simon3z/received_events","type":"User","site_admin":false},"body":"@Fryguy @blomquisg this is an initial (working) implementation of the kubernetes event catcher. We should still wait for a new kubeclient release and I am currently working on triggering the inventory pull.","created_at":"2015-02-13T12:37:07Z","updated_at":"2015-02-20T19:29:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05e73dc7a920a889f87b7148c99514064dd2d5a5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1679/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1679/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1679/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/f26272cb2fce03b64e7c349d78b6a7994b9db559","head":{"label":"simon3z:master","ref":"master","sha":"f26272cb2fce03b64e7c349d78b6a7994b9db559","user":{"login":"simon3z","id":130393,"avatar_url":"https://avatars.githubusercontent.com/u/130393?v=3","gravatar_id":"","url":"https://api.github.com/users/simon3z","html_url":"https://github.com/simon3z","followers_url":"https://api.github.com/users/simon3z/followers","following_url":"https://api.github.com/users/simon3z/following{/other_user}","gists_url":"https://api.github.com/users/simon3z/gists{/gist_id}","starred_url":"https://api.github.com/users/simon3z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon3z/subscriptions","organizations_url":"https://api.github.com/users/simon3z/orgs","repos_url":"https://api.github.com/users/simon3z/repos","events_url":"https://api.github.com/users/simon3z/events{/privacy}","received_events_url":"https://api.github.com/users/simon3z/received_events","type":"User","site_admin":false},"repo":{"id":30755562,"name":"manageiq","full_name":"simon3z/manageiq","owner":{"login":"simon3z","id":130393,"avatar_url":"https://avatars.githubusercontent.com/u/130393?v=3","gravatar_id":"","url":"https://api.github.com/users/simon3z","html_url":"https://github.com/simon3z","followers_url":"https://api.github.com/users/simon3z/followers","following_url":"https://api.github.com/users/simon3z/following{/other_user}","gists_url":"https://api.github.com/users/simon3z/gists{/gist_id}","starred_url":"https://api.github.com/users/simon3z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon3z/subscriptions","organizations_url":"https://api.github.com/users/simon3z/orgs","repos_url":"https://api.github.com/users/simon3z/repos","events_url":"https://api.github.com/users/simon3z/events{/privacy}","received_events_url":"https://api.github.com/users/simon3z/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simon3z/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/simon3z/manageiq","forks_url":"https://api.github.com/repos/simon3z/manageiq/forks","keys_url":"https://api.github.com/repos/simon3z/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simon3z/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simon3z/manageiq/teams","hooks_url":"https://api.github.com/repos/simon3z/manageiq/hooks","issue_events_url":"https://api.github.com/repos/simon3z/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/simon3z/manageiq/events","assignees_url":"https://api.github.com/repos/simon3z/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/simon3z/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/simon3z/manageiq/tags","blobs_url":"https://api.github.com/repos/simon3z/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simon3z/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simon3z/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/simon3z/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simon3z/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/simon3z/manageiq/languages","stargazers_url":"https://api.github.com/repos/simon3z/manageiq/stargazers","contributors_url":"https://api.github.com/repos/simon3z/manageiq/contributors","subscribers_url":"https://api.github.com/repos/simon3z/manageiq/subscribers","subscription_url":"https://api.github.com/repos/simon3z/manageiq/subscription","commits_url":"https://api.github.com/repos/simon3z/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/simon3z/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/simon3z/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/simon3z/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/simon3z/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/simon3z/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simon3z/manageiq/merges","archive_url":"https://api.github.com/repos/simon3z/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simon3z/manageiq/downloads","issues_url":"https://api.github.com/repos/simon3z/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/simon3z/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/simon3z/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/simon3z/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simon3z/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/simon3z/manageiq/releases{/id}","created_at":"2015-02-13T12:31:45Z","updated_at":"2015-02-19T12:36:44Z","pushed_at":"2015-02-19T12:36:27Z","git_url":"git://github.com/simon3z/manageiq.git","ssh_url":"git@github.com:simon3z/manageiq.git","clone_url":"https://github.com/simon3z/manageiq.git","svn_url":"https://github.com/simon3z/manageiq","homepage":"manageiq.org","size":63392,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"64c0205afba76dd2b5b4bb5012d50577c328a7f9","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-02-20T18:44:33Z","pushed_at":"2015-02-20T18:44:33Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":98139,"stargazers_count":89,"watchers_count":89,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":87,"mirror_url":null,"open_issues_count":265,"forks":87,"open_issues":265,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1679"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/1679"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/1679"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/1679/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1679/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1679/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/f26272cb2fce03b64e7c349d78b6a7994b9db559"}}}}