{"action":"closed","issue":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/2031","labels_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/2031/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/2031/comments","events_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/2031/events","html_url":"https://github.com/mozilla/fxa-content-server/issues/2031","id":53648195,"number":2031,"title":"Question: does a `p.reject()` without a return do anything?","user":{"login":"shane-tomlinson","id":848085,"avatar_url":"https://avatars.githubusercontent.com/u/848085?v=3","gravatar_id":"","url":"https://api.github.com/users/shane-tomlinson","html_url":"https://github.com/shane-tomlinson","followers_url":"https://api.github.com/users/shane-tomlinson/followers","following_url":"https://api.github.com/users/shane-tomlinson/following{/other_user}","gists_url":"https://api.github.com/users/shane-tomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/shane-tomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shane-tomlinson/subscriptions","organizations_url":"https://api.github.com/users/shane-tomlinson/orgs","repos_url":"https://api.github.com/users/shane-tomlinson/repos","events_url":"https://api.github.com/users/shane-tomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/shane-tomlinson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/fxa-content-server/labels/waffle%3Aneeds+review","name":"waffle:needs review","color":"ededed"}],"state":"closed","locked":false,"assignee":{"login":"vladikoff","id":128755,"avatar_url":"https://avatars.githubusercontent.com/u/128755?v=3","gravatar_id":"","url":"https://api.github.com/users/vladikoff","html_url":"https://github.com/vladikoff","followers_url":"https://api.github.com/users/vladikoff/followers","following_url":"https://api.github.com/users/vladikoff/following{/other_user}","gists_url":"https://api.github.com/users/vladikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/vladikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladikoff/subscriptions","organizations_url":"https://api.github.com/users/vladikoff/orgs","repos_url":"https://api.github.com/users/vladikoff/repos","events_url":"https://api.github.com/users/vladikoff/events{/privacy}","received_events_url":"https://api.github.com/users/vladikoff/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-01-07T16:06:36Z","updated_at":"2015-01-16T08:17:12Z","closed_at":"2015-01-16T08:17:12Z","body":"@vladikoff and @zaach - I was spelunking in [views/sign_in.js](https://github.com/mozilla/fxa-content-server/blob/8beec51167e75651afa2763c860039f99411aec5/app/scripts/views/sign_in.js) and came across these two `p.reject()` statements introduced in 7780e49aa007db60d12e29ea791d60489298ad3a:\r\n\r\n1. https://github.com/mozilla/fxa-content-server/blob/8beec51167e75651afa2763c860039f99411aec5/app/scripts/views/sign_in.js#L106\r\n1. https://github.com/mozilla/fxa-content-server/blob/8beec51167e75651afa2763c860039f99411aec5/app/scripts/views/sign_in.js#L129\r\n\r\nWithout a `return` statement in front of them, do they do anything?\r\n\r\nWhen I add a `return`, the tests start to fail because there is no error message to display."}}