{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/28814966","id":28814966,"diff_hunk":"@@ -926,20 +925,42 @@ public unsafe int BuildForEnc(object pUpdatePE)\n                 Debug.Assert(_lastEditSessionSummary == ProjectAnalysisSummary.ValidInsignificantChanges ||\n                              _lastEditSessionSummary == ProjectAnalysisSummary.ValidChanges);\n \n-                var updater = (Interop.IDebugUpdateInMemoryPE2)pUpdatePE;\n+                var updater = (IDebugUpdateInMemoryPE2)pUpdatePE;\n                 if (_committedBaseline == null)\n                 {\n-                    Interop.IENCDebugInfo debugInfo;","path":"src/VisualStudio/Core/Def/Implementation/EditAndContinue/VsENCRebuildableProjectImpl.cs","position":43,"original_position":43,"commit_id":"619e0eb17acab1cf63b11573858d2e383b6b8a43","original_commit_id":"619e0eb17acab1cf63b11573858d2e383b6b8a43","user":{"login":"tmat","id":41759,"avatar_url":"https://avatars.githubusercontent.com/u/41759?v=3","gravatar_id":"","url":"https://api.github.com/users/tmat","html_url":"https://github.com/tmat","followers_url":"https://api.github.com/users/tmat/followers","following_url":"https://api.github.com/users/tmat/following{/other_user}","gists_url":"https://api.github.com/users/tmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmat/subscriptions","organizations_url":"https://api.github.com/users/tmat/orgs","repos_url":"https://api.github.com/users/tmat/repos","events_url":"https://api.github.com/users/tmat/events{/privacy}","received_events_url":"https://api.github.com/users/tmat/received_events","type":"User","site_admin":false},"body":"Could you extract all this symreader logic to a method?","created_at":"2015-04-21T19:47:01Z","updated_at":"2015-04-21T19:47:01Z","html_url":"https://github.com/dotnet/roslyn/pull/2152#discussion_r28814966","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2152","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/28814966"},"html":{"href":"https://github.com/dotnet/roslyn/pull/2152#discussion_r28814966"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2152"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/2152","id":33782379,"html_url":"https://github.com/dotnet/roslyn/pull/2152","diff_url":"https://github.com/dotnet/roslyn/pull/2152.diff","patch_url":"https://github.com/dotnet/roslyn/pull/2152.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/2152","number":2152,"state":"open","locked":false,"title":"Use different mechanism for passing symbol reader to MTA...","user":{"login":"KevinH-MS","id":6464209,"avatar_url":"https://avatars.githubusercontent.com/u/6464209?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinH-MS","html_url":"https://github.com/KevinH-MS","followers_url":"https://api.github.com/users/KevinH-MS/followers","following_url":"https://api.github.com/users/KevinH-MS/following{/other_user}","gists_url":"https://api.github.com/users/KevinH-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinH-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinH-MS/subscriptions","organizations_url":"https://api.github.com/users/KevinH-MS/orgs","repos_url":"https://api.github.com/users/KevinH-MS/repos","events_url":"https://api.github.com/users/KevinH-MS/events{/privacy}","received_events_url":"https://api.github.com/users/KevinH-MS/received_events","type":"User","site_admin":false},"body":"Previously, we'd store a direct pointer to the IUnknown instance and\r\nunwrap that in the MTA.  The IENCSymbolReaderProvider interface is\r\nbeing changed to prevent calls from an STA by returning the IUnknown\r\ninstance directly, rather than a pointer to it.\r\n\r\nThus, we need to add a layer of indirection (marshal the IUnknown\r\nin a Stream and pass a pointer to the Stream instance to the MTA).","created_at":"2015-04-21T17:06:24Z","updated_at":"2015-04-21T19:47:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58b91b9cfa9170579d13b37525f4174f9b83d144","assignee":null,"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/1","html_url":"https://github.com/dotnet/roslyn/milestones/1.0%20(stable)","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/1/labels","id":937397,"number":1,"title":"1.0 (stable)","description":"This is our 1.0 Milestone. ","creator":{"login":"jaredpar","id":146967,"avatar_url":"https://avatars.githubusercontent.com/u/146967?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredpar","html_url":"https://github.com/jaredpar","followers_url":"https://api.github.com/users/jaredpar/followers","following_url":"https://api.github.com/users/jaredpar/following{/other_user}","gists_url":"https://api.github.com/users/jaredpar/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredpar/subscriptions","organizations_url":"https://api.github.com/users/jaredpar/orgs","repos_url":"https://api.github.com/users/jaredpar/repos","events_url":"https://api.github.com/users/jaredpar/events{/privacy}","received_events_url":"https://api.github.com/users/jaredpar/received_events","type":"User","site_admin":false},"open_issues":224,"closed_issues":182,"state":"open","created_at":"2015-01-15T20:45:24Z","updated_at":"2015-04-21T19:33:36Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2152/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2152/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/2152/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/619e0eb17acab1cf63b11573858d2e383b6b8a43","head":{"label":"KevinH-MS:CrossThreadCall","ref":"CrossThreadCall","sha":"619e0eb17acab1cf63b11573858d2e383b6b8a43","user":{"login":"KevinH-MS","id":6464209,"avatar_url":"https://avatars.githubusercontent.com/u/6464209?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinH-MS","html_url":"https://github.com/KevinH-MS","followers_url":"https://api.github.com/users/KevinH-MS/followers","following_url":"https://api.github.com/users/KevinH-MS/following{/other_user}","gists_url":"https://api.github.com/users/KevinH-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinH-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinH-MS/subscriptions","organizations_url":"https://api.github.com/users/KevinH-MS/orgs","repos_url":"https://api.github.com/users/KevinH-MS/repos","events_url":"https://api.github.com/users/KevinH-MS/events{/privacy}","received_events_url":"https://api.github.com/users/KevinH-MS/received_events","type":"User","site_admin":false},"repo":{"id":30554696,"name":"roslyn","full_name":"KevinH-MS/roslyn","owner":{"login":"KevinH-MS","id":6464209,"avatar_url":"https://avatars.githubusercontent.com/u/6464209?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinH-MS","html_url":"https://github.com/KevinH-MS","followers_url":"https://api.github.com/users/KevinH-MS/followers","following_url":"https://api.github.com/users/KevinH-MS/following{/other_user}","gists_url":"https://api.github.com/users/KevinH-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinH-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinH-MS/subscriptions","organizations_url":"https://api.github.com/users/KevinH-MS/orgs","repos_url":"https://api.github.com/users/KevinH-MS/repos","events_url":"https://api.github.com/users/KevinH-MS/events{/privacy}","received_events_url":"https://api.github.com/users/KevinH-MS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KevinH-MS/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/KevinH-MS/roslyn","forks_url":"https://api.github.com/repos/KevinH-MS/roslyn/forks","keys_url":"https://api.github.com/repos/KevinH-MS/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KevinH-MS/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KevinH-MS/roslyn/teams","hooks_url":"https://api.github.com/repos/KevinH-MS/roslyn/hooks","issue_events_url":"https://api.github.com/repos/KevinH-MS/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/KevinH-MS/roslyn/events","assignees_url":"https://api.github.com/repos/KevinH-MS/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/KevinH-MS/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/KevinH-MS/roslyn/tags","blobs_url":"https://api.github.com/repos/KevinH-MS/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KevinH-MS/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KevinH-MS/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/KevinH-MS/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KevinH-MS/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/KevinH-MS/roslyn/languages","stargazers_url":"https://api.github.com/repos/KevinH-MS/roslyn/stargazers","contributors_url":"https://api.github.com/repos/KevinH-MS/roslyn/contributors","subscribers_url":"https://api.github.com/repos/KevinH-MS/roslyn/subscribers","subscription_url":"https://api.github.com/repos/KevinH-MS/roslyn/subscription","commits_url":"https://api.github.com/repos/KevinH-MS/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/KevinH-MS/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/KevinH-MS/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/KevinH-MS/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/KevinH-MS/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/KevinH-MS/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KevinH-MS/roslyn/merges","archive_url":"https://api.github.com/repos/KevinH-MS/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KevinH-MS/roslyn/downloads","issues_url":"https://api.github.com/repos/KevinH-MS/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/KevinH-MS/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/KevinH-MS/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/KevinH-MS/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KevinH-MS/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/KevinH-MS/roslyn/releases{/id}","created_at":"2015-02-09T19:43:41Z","updated_at":"2015-04-21T16:59:50Z","pushed_at":"2015-04-21T18:43:20Z","git_url":"git://github.com/KevinH-MS/roslyn.git","ssh_url":"git@github.com:KevinH-MS/roslyn.git","clone_url":"https://github.com/KevinH-MS/roslyn.git","svn_url":"https://github.com/KevinH-MS/roslyn","homepage":"","size":67653,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"ae819709f93d6119461771deb2dacef524d31e9c","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-04-21T19:33:37Z","pushed_at":"2015-04-21T19:33:37Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":112449,"stargazers_count":1841,"watchers_count":1841,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":410,"mirror_url":null,"open_issues_count":744,"forks":410,"open_issues":744,"watchers":1841,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2152"},"html":{"href":"https://github.com/dotnet/roslyn/pull/2152"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/2152"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/2152/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2152/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2152/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/619e0eb17acab1cf63b11573858d2e383b6b8a43"}}}}