{"action":"created","issue":{"url":"https://api.github.com/repos/davisking/dlib/issues/33","labels_url":"https://api.github.com/repos/davisking/dlib/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/davisking/dlib/issues/33/comments","events_url":"https://api.github.com/repos/davisking/dlib/issues/33/events","html_url":"https://github.com/davisking/dlib/pull/33","id":105699259,"number":33,"title":"minor syntax changes for C++ compliance","user":{"login":"mikeseven","id":809004,"avatar_url":"https://avatars.githubusercontent.com/u/809004?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeseven","html_url":"https://github.com/mikeseven","followers_url":"https://api.github.com/users/mikeseven/followers","following_url":"https://api.github.com/users/mikeseven/following{/other_user}","gists_url":"https://api.github.com/users/mikeseven/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeseven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeseven/subscriptions","organizations_url":"https://api.github.com/users/mikeseven/orgs","repos_url":"https://api.github.com/users/mikeseven/repos","events_url":"https://api.github.com/users/mikeseven/events{/privacy}","received_events_url":"https://api.github.com/users/mikeseven/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-09T22:49:53Z","updated_at":"2015-09-10T10:38:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/davisking/dlib/pulls/33","html_url":"https://github.com/davisking/dlib/pull/33","diff_url":"https://github.com/davisking/dlib/pull/33.diff","patch_url":"https://github.com/davisking/dlib/pull/33.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/davisking/dlib/issues/comments/139200973","html_url":"https://github.com/davisking/dlib/pull/33#issuecomment-139200973","issue_url":"https://api.github.com/repos/davisking/dlib/issues/33","id":139200973,"user":{"login":"davisking","id":6259399,"avatar_url":"https://avatars.githubusercontent.com/u/6259399?v=3","gravatar_id":"","url":"https://api.github.com/users/davisking","html_url":"https://github.com/davisking","followers_url":"https://api.github.com/users/davisking/followers","following_url":"https://api.github.com/users/davisking/following{/other_user}","gists_url":"https://api.github.com/users/davisking/gists{/gist_id}","starred_url":"https://api.github.com/users/davisking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davisking/subscriptions","organizations_url":"https://api.github.com/users/davisking/orgs","repos_url":"https://api.github.com/users/davisking/repos","events_url":"https://api.github.com/users/davisking/events{/privacy}","received_events_url":"https://api.github.com/users/davisking/received_events","type":"User","site_admin":false},"created_at":"2015-09-10T10:38:22Z","updated_at":"2015-09-10T10:38:22Z","body":"Oh right, good catch about the destructor.  However, the right thing to do is to add an exception specification so that the error message is not hidden.  Otherwise, calling exit() is basically the same as what the compiler will do automatically which is call std::terminate().\r\n\r\nSo add \"throw (std::exception)\" to the end of the destructor declaration so the compiler knows this destructor is allowed to throw and I'll merge the pull request (and don't forget to remove the try/catch) :)"}}