{"action":"created","issue":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/5701","labels_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/5701/labels{/name}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/5701/comments","events_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/5701/events","html_url":"https://github.com/rapid7/metasploit-framework/pull/5701","id":94480534,"number":5701,"title":"Fix FileZilla_Server","user":{"login":"g0tmi1k","id":535942,"avatar_url":"https://avatars.githubusercontent.com/u/535942?v=3","gravatar_id":"","url":"https://api.github.com/users/g0tmi1k","html_url":"https://github.com/g0tmi1k","followers_url":"https://api.github.com/users/g0tmi1k/followers","following_url":"https://api.github.com/users/g0tmi1k/following{/other_user}","gists_url":"https://api.github.com/users/g0tmi1k/gists{/gist_id}","starred_url":"https://api.github.com/users/g0tmi1k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g0tmi1k/subscriptions","organizations_url":"https://api.github.com/users/g0tmi1k/orgs","repos_url":"https://api.github.com/users/g0tmi1k/repos","events_url":"https://api.github.com/users/g0tmi1k/events{/privacy}","received_events_url":"https://api.github.com/users/g0tmi1k/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rapid7/metasploit-framework/labels/bug","name":"bug","color":"e11d21"},{"url":"https://api.github.com/repos/rapid7/metasploit-framework/labels/module","name":"module","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"wvu-r7","id":4551878,"avatar_url":"https://avatars.githubusercontent.com/u/4551878?v=3","gravatar_id":"","url":"https://api.github.com/users/wvu-r7","html_url":"https://github.com/wvu-r7","followers_url":"https://api.github.com/users/wvu-r7/followers","following_url":"https://api.github.com/users/wvu-r7/following{/other_user}","gists_url":"https://api.github.com/users/wvu-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/wvu-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wvu-r7/subscriptions","organizations_url":"https://api.github.com/users/wvu-r7/orgs","repos_url":"https://api.github.com/users/wvu-r7/repos","events_url":"https://api.github.com/users/wvu-r7/events{/privacy}","received_events_url":"https://api.github.com/users/wvu-r7/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2015-07-11T15:09:05Z","updated_at":"2015-07-29T14:25:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/5701","html_url":"https://github.com/rapid7/metasploit-framework/pull/5701","diff_url":"https://github.com/rapid7/metasploit-framework/pull/5701.diff","patch_url":"https://github.com/rapid7/metasploit-framework/pull/5701.patch"},"body":"## Summary\r\n\r\n* Passwords & groups values where the **same for the first user** (repeated for every user afterwards) - display and loot\r\n* Permissions were **same for the first user** (in loot) (repeated for every user afterwards)\r\n* **Failed to detect correct** 'FTP Port' when using default settings\r\n* **Wasn't using** `FileZilla Server Interface.xml` file at all \r\n* **Hide output** if/when group is empty\r\n* _...more **verbose**!_\r\n\r\n\r\n## Setup\r\n\r\n```\r\nuse post/windows/gather/credentials/filezilla_server\r\nset session 1\r\nset verbose true\r\ndb_disconnect\r\n```\r\n\r\n\r\n## Before\r\n\r\n```\r\nmsf post(filezilla_server) > run\r\n\r\n[*] Checking for Filezilla Server directory in: C:\\Program Files (x86)\\FileZilla Server\\\r\n[*] Found FileZilla Server\r\n\r\n[*]     Collected the following credentials:\r\n[*]     Username: <USER_1>\r\n[*]     Password: <PASSWORD_1>\r\n[*]        Group: <GROUP_1>\r\n\r\n[*]     Collected the following credentials:\r\n[*]     Username: <USER_2>\r\n[*]     Password: <PASSWORD_1>\r\n[*]        Group: <GROUP_1>\r\n\r\n[*]     Collected the following credentials:\r\n[*]     Username: <USER_3>\r\n[*]     Password: <PASSWORD_1>\r\n[*]        Group: <GROUP_1>\r\n\r\n[*]     Collected the following credentials:\r\n[*]     Username: <USER_4>\r\n[*]     Password: <PASSWORD_1>\r\n[*]        Group: <GROUP_1>\r\n\r\n[*]     Collected the following credentials:\r\n[*]     Username: <USER_5>\r\n[*]     Password: <PASSWORD_1>\r\n[*]        Group: <GROUP_1>\r\n\r\n[*]     Collected the following credentials:\r\n[*]     Username: <USER_6>\r\n[*]     Password: <PASSWORD_1>\r\n[*]        Group: <GROUP_1>\r\n\r\n[*]     Collected the following credentials:\r\n[*]     Username: <USER_7>\r\n[*]     Password: <PASSWORD_1>\r\n[*]        Group: <GROUP_1>\r\n\r\n[!] No active DB -- Credential data will not be saved!\r\n[*]     Collected the following configuration details:\r\n[*]        FTP Port: 14147\r\n[*]     FTP Bind IP: \r\n[*]             SSL: false\r\n[*]      Admin Port: <none>\r\n[*]   Admin Bind IP: \r\n[*]      Admin Pass: <none>\r\n\r\n[*] (No admin information found.)\r\n[*] Credentials saved in: /root/.msf4/loot/20150711181917_default_192.168.1.2_filezilla.server_688042.txt\r\n[*] Permissions saved in: /root/.msf4/loot/20150711181917_default_192.168.1.2_filezilla.server_583100.txt\r\n[*] Config saved in: /root/.msf4/loot/20150711181917_default_192.168.1.2_filezilla.server_212868.txt\r\n[*] Post module execution completed\r\nmsf post(filezilla_server) > \r\n```\r\n\r\n## After\r\n```\r\nmsf post(filezilla_server) > run\r\n\r\n[*] Checking for Filezilla Server directory in: C:\\Program Files (x86)\\FileZilla Server\\\r\n[*] Configuration File Found: C:\\Program Files (x86)\\FileZilla Server\\FileZilla Server Interface.xml\r\n[*] Configuration File Found: C:\\Program Files (x86)\\FileZilla Server\\FileZilla Server.xml\r\n[+] Found FileZilla Server on <TARGET> via session ID: 1\r\n\r\n[*] Collected the following credentials:\r\n[*]     Username: <USER_1>\r\n[*]     Password: <PASSWORD_1>\r\n[*]        Group: <GROUP_1>\r\n\r\n[*]     Username: <USER_2>\r\n[*]     Password: <PASSWORD_2>\r\n[*]        Group: <GROUP_2>\r\n\r\n[*]     Username: <USER_3>\r\n[*]     Password: <PASSWORD_3>\r\n\r\n[*]     Username: <USER_4>\r\n[*]     Password: <PASSWORD_4>\r\n\r\n[*]     Username: <USER_5>\r\n[*]     Password: <PASSWORD_5>\r\n\r\n[*]     Username: <USER_6>\r\n[*]     Password: <PASSWORD_6>\r\n\r\n[*]     Username: <USER_7>\r\n[*]     Password: <PASSWORD_7>\r\n\r\n[!] No active DB -- Credential data will not be saved!\r\n[*] Detected Default Adminstration Settings:\r\n[*]        FTP Port: 21\r\n[*]     FTP Bind IP: 0.0.0.0\r\n[*]             SSL: false\r\n[*]      Admin Port: 14147\r\n[*]   Admin Bind IP: 0.0.0.0\r\n[*]      Admin Pass: <none>\r\n\r\n[*] Last Server Information:\r\n[*]          IP: 127.0.0.1\r\n[*]        Port: 14147\r\n[*]    Password: <none>\r\n\r\n[*] Credentials saved in: /root/.msf4/loot/20150711182115_default_192.168.1.2_filezilla.server_678817.txt\r\n[*] Permissions saved in: /root/.msf4/loot/20150711182115_default_192.168.1.2_filezilla.server_118015.txt\r\n[*]      Config saved in: /root/.msf4/loot/20150711182115_default_192.168.1.2_filezilla.server_800083.txt\r\n[*]  Last server history: /root/.msf4/loot/20150711182115_default_192.168.1.2_filezilla.server_188488.txt\r\n\r\n[*] Post module execution completed\r\nmsf post(filezilla_server) >\r\n```\r\n\r\n\r\n_...Skipping comparing log/loot files output._"},"comment":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/comments/125969112","html_url":"https://github.com/rapid7/metasploit-framework/pull/5701#issuecomment-125969112","issue_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/5701","id":125969112,"user":{"login":"wvu-r7","id":4551878,"avatar_url":"https://avatars.githubusercontent.com/u/4551878?v=3","gravatar_id":"","url":"https://api.github.com/users/wvu-r7","html_url":"https://github.com/wvu-r7","followers_url":"https://api.github.com/users/wvu-r7/followers","following_url":"https://api.github.com/users/wvu-r7/following{/other_user}","gists_url":"https://api.github.com/users/wvu-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/wvu-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wvu-r7/subscriptions","organizations_url":"https://api.github.com/users/wvu-r7/orgs","repos_url":"https://api.github.com/users/wvu-r7/repos","events_url":"https://api.github.com/users/wvu-r7/events{/privacy}","received_events_url":"https://api.github.com/users/wvu-r7/received_events","type":"User","site_admin":false},"created_at":"2015-07-29T14:25:50Z","updated_at":"2015-07-29T14:25:50Z","body":"Lol, sorry for the confusion. I was asking if it was necessary to loop through two filenames, not remove the ```each```. I think it's fine now that I looked at it again."}}