{"action":"created","issue":{"url":"https://api.github.com/repos/dancol90/MenuLib/issues/1","labels_url":"https://api.github.com/repos/dancol90/MenuLib/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/dancol90/MenuLib/issues/1/comments","events_url":"https://api.github.com/repos/dancol90/MenuLib/issues/1/events","html_url":"https://github.com/dancol90/MenuLib/issues/1","id":97958754,"number":1,"title":"Provided example doesn't work for me","user":{"login":"slavkoja","id":5506544,"avatar_url":"https://avatars.githubusercontent.com/u/5506544?v=3","gravatar_id":"","url":"https://api.github.com/users/slavkoja","html_url":"https://github.com/slavkoja","followers_url":"https://api.github.com/users/slavkoja/followers","following_url":"https://api.github.com/users/slavkoja/following{/other_user}","gists_url":"https://api.github.com/users/slavkoja/gists{/gist_id}","starred_url":"https://api.github.com/users/slavkoja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavkoja/subscriptions","organizations_url":"https://api.github.com/users/slavkoja/orgs","repos_url":"https://api.github.com/users/slavkoja/repos","events_url":"https://api.github.com/users/slavkoja/events{/privacy}","received_events_url":"https://api.github.com/users/slavkoja/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-29T15:09:53Z","updated_at":"2015-07-29T23:04:37Z","closed_at":null,"body":"When i try to compile provided example i get the errors:\r\n```\r\nIn file included from oledMenu.ino:6:0:\r\n/home/XXXX/Arduino/libraries/MenuLib/LcdDrawer.h: In member function 'void LcdDrawer::drawSelector(NumericSelector*)':\r\n/home/XXXX/Arduino/libraries/MenuLib/LcdDrawer.h:158:33: error: 'RECT_W' was not declared in this scope\r\n   #define RECT_X (lcd.width() - RECT_W) / 2\r\n                                 ^\r\n/home/XXXX/Arduino/libraries/MenuLib/LcdDrawer.h:167:17: note: in expansion of macro 'RECT_X'\r\n    lcd.drawRect(RECT_X, RECT_Y, RECT_W, RECT_H, 1);\r\n                 ^\r\n/home/XXXX/Arduino/libraries/MenuLib/LcdDrawer.h:167:25: error: 'RECT_Y' was not declared in this scope\r\n    lcd.drawRect(RECT_X, RECT_Y, RECT_W, RECT_H, 1);\r\n                         ^\r\n/home/XXXX/Arduino/libraries/MenuLib/LcdDrawer.h:167:41: error: 'RECT_H' was not declared in this scope\r\n    lcd.drawRect(RECT_X, RECT_Y, RECT_W, RECT_H, 1);\r\n                                         ^\r\nError compiling.\r\n```\r\nAfter i moved the include of the `LcdDrawer.h` after include of the `LightSSD1306.h`, it is solved, but then the compilation fails with:\r\n```\r\noledMenu:12: error: no matching function for call to 'LcdDrawer::LcdDrawer(LightSSD1306&)'\r\noledMenu.ino:12:34: note: candidates are:\r\nIn file included from oledMenu.ino:7:0:\r\n/home/XXXX/Arduino/libraries/MenuLib/LcdDrawer.h:186:3: note: LcdDrawer::LcdDrawer(LightLCD&, uint8_t)\r\n   LcdDrawer(LightLCD& lcd, uint8_t num_items) : lcd(lcd), items_per_screen(num_items) {}\r\n   ^\r\n/home/XXXX/Arduino/libraries/MenuLib/LcdDrawer.h:186:3: note:   candidate expects 2 arguments, 1 provided\r\n/home/XXXX/Arduino/libraries/MenuLib/LcdDrawer.h:7:7: note: LcdDrawer::LcdDrawer(const LcdDrawer&)\r\n class LcdDrawer : public MenuItemDrawer {\r\n       ^\r\n/home/XXXX/Arduino/libraries/MenuLib/LcdDrawer.h:7:7: note:   no known conversion for argument 1 from 'LightSSD1306' to 'const LcdDrawer&'\r\nno matching function for call to 'LcdDrawer::LcdDrawer(LightSSD1306&)'\r\n```\r\nAnd this is out of my knowledge ;-)"},"comment":{"url":"https://api.github.com/repos/dancol90/MenuLib/issues/comments/126122686","html_url":"https://github.com/dancol90/MenuLib/issues/1#issuecomment-126122686","issue_url":"https://api.github.com/repos/dancol90/MenuLib/issues/1","id":126122686,"user":{"login":"dancol90","id":1417524,"avatar_url":"https://avatars.githubusercontent.com/u/1417524?v=3","gravatar_id":"","url":"https://api.github.com/users/dancol90","html_url":"https://github.com/dancol90","followers_url":"https://api.github.com/users/dancol90/followers","following_url":"https://api.github.com/users/dancol90/following{/other_user}","gists_url":"https://api.github.com/users/dancol90/gists{/gist_id}","starred_url":"https://api.github.com/users/dancol90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dancol90/subscriptions","organizations_url":"https://api.github.com/users/dancol90/orgs","repos_url":"https://api.github.com/users/dancol90/repos","events_url":"https://api.github.com/users/dancol90/events{/privacy}","received_events_url":"https://api.github.com/users/dancol90/received_events","type":"User","site_admin":false},"created_at":"2015-07-29T23:04:37Z","updated_at":"2015-07-29T23:04:37Z","body":"Yeah I forgot to update the example after changing the LcdDrawer constructor. You need to pass to it, along with the LightLcd instance, the number of menu item to fit on screen, one per row. So, in the sketch, it should become:\r\n\r\n```\r\nLcdDrawer* dr = new LcdDrawer(lcd, 4);\r\n```\r\n\r\nto have 4 row of the current menu on screen."}}