{"action":"closed","number":2260,"pull_request":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/2260","id":45844848,"html_url":"https://github.com/pantsbuild/pants/pull/2260","diff_url":"https://github.com/pantsbuild/pants/pull/2260.diff","patch_url":"https://github.com/pantsbuild/pants/pull/2260.patch","issue_url":"https://api.github.com/repos/pantsbuild/pants/issues/2260","number":2260,"state":"closed","locked":false,"title":"Fix javadocs and add jvm doc gen to CI.","user":{"login":"jsirois","id":157586,"avatar_url":"https://avatars.githubusercontent.com/u/157586?v=3","gravatar_id":"","url":"https://api.github.com/users/jsirois","html_url":"https://github.com/jsirois","followers_url":"https://api.github.com/users/jsirois/followers","following_url":"https://api.github.com/users/jsirois/following{/other_user}","gists_url":"https://api.github.com/users/jsirois/gists{/gist_id}","starred_url":"https://api.github.com/users/jsirois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsirois/subscriptions","organizations_url":"https://api.github.com/users/jsirois/orgs","repos_url":"https://api.github.com/users/jsirois/repos","events_url":"https://api.github.com/users/jsirois/events{/privacy}","received_events_url":"https://api.github.com/users/jsirois/received_events","type":"User","site_admin":false},"body":"Previously we could have invalid javadoc ond/or scaladoc on master,\r\nnow CI checks there are no jvm doc errors.\r\n\r\nAn existing javadoc error is fixed so CI passes.  Also `ScaladocGen` is\r\nfixed to only grab java_sources when it actually can.  No test is added\r\nfor the latter, but without the fix, CI goes red on `junit_tests` owning\r\nscala code, but not exporting a `java_sources` attribute.  This issue\r\ntracks a proper solution to `java_sources` attribute tests:\r\n  https://github.com/pantsbuild/pants/issues/65\r\n\r\nhttps://rbcommons.com/s/twitter/r/2877/","created_at":"2015-09-23T23:39:15Z","updated_at":"2015-09-24T02:25:42Z","closed_at":"2015-09-24T02:25:42Z","merged_at":null,"merge_commit_sha":"d4f0ac9910720840e0ab9e096334720b806df5cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pantsbuild/pants/pulls/2260/commits","review_comments_url":"https://api.github.com/repos/pantsbuild/pants/pulls/2260/comments","review_comment_url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pantsbuild/pants/issues/2260/comments","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/f2811d8606bca5bf179245056bd8e7bd2028a7b7","head":{"label":"jsirois:jsirois/javadoc/fix_and_ci","ref":"jsirois/javadoc/fix_and_ci","sha":"f2811d8606bca5bf179245056bd8e7bd2028a7b7","user":{"login":"jsirois","id":157586,"avatar_url":"https://avatars.githubusercontent.com/u/157586?v=3","gravatar_id":"","url":"https://api.github.com/users/jsirois","html_url":"https://github.com/jsirois","followers_url":"https://api.github.com/users/jsirois/followers","following_url":"https://api.github.com/users/jsirois/following{/other_user}","gists_url":"https://api.github.com/users/jsirois/gists{/gist_id}","starred_url":"https://api.github.com/users/jsirois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsirois/subscriptions","organizations_url":"https://api.github.com/users/jsirois/orgs","repos_url":"https://api.github.com/users/jsirois/repos","events_url":"https://api.github.com/users/jsirois/events{/privacy}","received_events_url":"https://api.github.com/users/jsirois/received_events","type":"User","site_admin":false},"repo":{"id":19150258,"name":"pants","full_name":"jsirois/pants","owner":{"login":"jsirois","id":157586,"avatar_url":"https://avatars.githubusercontent.com/u/157586?v=3","gravatar_id":"","url":"https://api.github.com/users/jsirois","html_url":"https://github.com/jsirois","followers_url":"https://api.github.com/users/jsirois/followers","following_url":"https://api.github.com/users/jsirois/following{/other_user}","gists_url":"https://api.github.com/users/jsirois/gists{/gist_id}","starred_url":"https://api.github.com/users/jsirois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsirois/subscriptions","organizations_url":"https://api.github.com/users/jsirois/orgs","repos_url":"https://api.github.com/users/jsirois/repos","events_url":"https://api.github.com/users/jsirois/events{/privacy}","received_events_url":"https://api.github.com/users/jsirois/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsirois/pants","description":"Pants Build System","fork":true,"url":"https://api.github.com/repos/jsirois/pants","forks_url":"https://api.github.com/repos/jsirois/pants/forks","keys_url":"https://api.github.com/repos/jsirois/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsirois/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsirois/pants/teams","hooks_url":"https://api.github.com/repos/jsirois/pants/hooks","issue_events_url":"https://api.github.com/repos/jsirois/pants/issues/events{/number}","events_url":"https://api.github.com/repos/jsirois/pants/events","assignees_url":"https://api.github.com/repos/jsirois/pants/assignees{/user}","branches_url":"https://api.github.com/repos/jsirois/pants/branches{/branch}","tags_url":"https://api.github.com/repos/jsirois/pants/tags","blobs_url":"https://api.github.com/repos/jsirois/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsirois/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsirois/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsirois/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsirois/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/jsirois/pants/languages","stargazers_url":"https://api.github.com/repos/jsirois/pants/stargazers","contributors_url":"https://api.github.com/repos/jsirois/pants/contributors","subscribers_url":"https://api.github.com/repos/jsirois/pants/subscribers","subscription_url":"https://api.github.com/repos/jsirois/pants/subscription","commits_url":"https://api.github.com/repos/jsirois/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsirois/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsirois/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsirois/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsirois/pants/contents/{+path}","compare_url":"https://api.github.com/repos/jsirois/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsirois/pants/merges","archive_url":"https://api.github.com/repos/jsirois/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsirois/pants/downloads","issues_url":"https://api.github.com/repos/jsirois/pants/issues{/number}","pulls_url":"https://api.github.com/repos/jsirois/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/jsirois/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/jsirois/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsirois/pants/labels{/name}","releases_url":"https://api.github.com/repos/jsirois/pants/releases{/id}","created_at":"2014-04-25T15:11:53Z","updated_at":"2015-05-08T08:37:03Z","pushed_at":"2015-09-24T02:06:59Z","git_url":"git://github.com/jsirois/pants.git","ssh_url":"git@github.com:jsirois/pants.git","clone_url":"https://github.com/jsirois/pants.git","svn_url":"https://github.com/jsirois/pants","homepage":"http://pantsbuild.github.io/","size":59514,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pantsbuild:master","ref":"master","sha":"35ba6bfdb63cfedbedfd28c1705996e582178064","user":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars.githubusercontent.com/u/3065172?v=3","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":7209075,"name":"pants","full_name":"pantsbuild/pants","owner":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars.githubusercontent.com/u/3065172?v=3","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pantsbuild/pants","description":"Pants Build System","fork":false,"url":"https://api.github.com/repos/pantsbuild/pants","forks_url":"https://api.github.com/repos/pantsbuild/pants/forks","keys_url":"https://api.github.com/repos/pantsbuild/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pantsbuild/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pantsbuild/pants/teams","hooks_url":"https://api.github.com/repos/pantsbuild/pants/hooks","issue_events_url":"https://api.github.com/repos/pantsbuild/pants/issues/events{/number}","events_url":"https://api.github.com/repos/pantsbuild/pants/events","assignees_url":"https://api.github.com/repos/pantsbuild/pants/assignees{/user}","branches_url":"https://api.github.com/repos/pantsbuild/pants/branches{/branch}","tags_url":"https://api.github.com/repos/pantsbuild/pants/tags","blobs_url":"https://api.github.com/repos/pantsbuild/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pantsbuild/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pantsbuild/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/pantsbuild/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/pantsbuild/pants/languages","stargazers_url":"https://api.github.com/repos/pantsbuild/pants/stargazers","contributors_url":"https://api.github.com/repos/pantsbuild/pants/contributors","subscribers_url":"https://api.github.com/repos/pantsbuild/pants/subscribers","subscription_url":"https://api.github.com/repos/pantsbuild/pants/subscription","commits_url":"https://api.github.com/repos/pantsbuild/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/pantsbuild/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/pantsbuild/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/pantsbuild/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/pantsbuild/pants/contents/{+path}","compare_url":"https://api.github.com/repos/pantsbuild/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pantsbuild/pants/merges","archive_url":"https://api.github.com/repos/pantsbuild/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pantsbuild/pants/downloads","issues_url":"https://api.github.com/repos/pantsbuild/pants/issues{/number}","pulls_url":"https://api.github.com/repos/pantsbuild/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/pantsbuild/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/pantsbuild/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pantsbuild/pants/labels{/name}","releases_url":"https://api.github.com/repos/pantsbuild/pants/releases{/id}","created_at":"2012-12-17T17:39:04Z","updated_at":"2015-09-23T09:15:59Z","pushed_at":"2015-09-24T02:24:53Z","git_url":"git://github.com/pantsbuild/pants.git","ssh_url":"git@github.com:pantsbuild/pants.git","clone_url":"https://github.com/pantsbuild/pants.git","svn_url":"https://github.com/pantsbuild/pants","homepage":"http://pantsbuild.github.io/","size":80685,"stargazers_count":401,"watchers_count":401,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":290,"forks":120,"open_issues":290,"watchers":401,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/2260"},"html":{"href":"https://github.com/pantsbuild/pants/pull/2260"},"issue":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/2260"},"comments":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/2260/comments"},"review_comments":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/2260/comments"},"review_comment":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/2260/commits"},"statuses":{"href":"https://api.github.com/repos/pantsbuild/pants/statuses/f2811d8606bca5bf179245056bd8e7bd2028a7b7"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":7,"deletions":4,"changed_files":3}}