{"action":"closed","number":76,"pull_request":{"url":"https://api.github.com/repos/symphonists/order_entries/pulls/76","id":50610361,"html_url":"https://github.com/symphonists/order_entries/pull/76","diff_url":"https://github.com/symphonists/order_entries/pull/76.diff","patch_url":"https://github.com/symphonists/order_entries/pull/76.patch","issue_url":"https://api.github.com/repos/symphonists/order_entries/issues/76","number":76,"state":"closed","locked":false,"title":"do not set a value for null filters","user":{"login":"jonmifsud","id":859775,"avatar_url":"https://avatars.githubusercontent.com/u/859775?v=3","gravatar_id":"","url":"https://api.github.com/users/jonmifsud","html_url":"https://github.com/jonmifsud","followers_url":"https://api.github.com/users/jonmifsud/followers","following_url":"https://api.github.com/users/jonmifsud/following{/other_user}","gists_url":"https://api.github.com/users/jonmifsud/gists{/gist_id}","starred_url":"https://api.github.com/users/jonmifsud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonmifsud/subscriptions","organizations_url":"https://api.github.com/users/jonmifsud/orgs","repos_url":"https://api.github.com/users/jonmifsud/repos","events_url":"https://api.github.com/users/jonmifsud/events{/privacy}","received_events_url":"https://api.github.com/users/jonmifsud/received_events","type":"User","site_admin":false},"body":"@nitriques I'm running this on production today so will get back with feedback.\r\n\r\nHad a complaint from the client that the site was throwing 500s regularly, when resaving an entry with a filtered order entries field. ( I don't know why it took them that long to report ) the issue seems to be that the 'unfiltered' view was getting a sort order, and on re-saving the filter was being changed with a value - so it could have created issues on at least 2 levels.\r\n\r\n1. Filters were screwed up as the null filters were changed with a value.\r\n2. Null filters were given a value, which saved once or twice were throwing a 500 as the unique constraint was broken.\r\n\r\nThe changes seem to fix the above scenarios will give a go ahead once all is clear in production in case there are any related issues which need to be sorted out.","created_at":"2015-11-13T07:01:10Z","updated_at":"2015-11-20T22:11:17Z","closed_at":"2015-11-20T22:11:17Z","merged_at":"2015-11-20T22:11:17Z","merge_commit_sha":"c0b30c6c9e51a741160332188a438f708f661464","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symphonists/order_entries/pulls/76/commits","review_comments_url":"https://api.github.com/repos/symphonists/order_entries/pulls/76/comments","review_comment_url":"https://api.github.com/repos/symphonists/order_entries/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symphonists/order_entries/issues/76/comments","statuses_url":"https://api.github.com/repos/symphonists/order_entries/statuses/9bb8a32f4ec807ad86c7d22dc0df3881a2e1f3c4","head":{"label":"jonmifsud:nullFilter","ref":"nullFilter","sha":"9bb8a32f4ec807ad86c7d22dc0df3881a2e1f3c4","user":{"login":"jonmifsud","id":859775,"avatar_url":"https://avatars.githubusercontent.com/u/859775?v=3","gravatar_id":"","url":"https://api.github.com/users/jonmifsud","html_url":"https://github.com/jonmifsud","followers_url":"https://api.github.com/users/jonmifsud/followers","following_url":"https://api.github.com/users/jonmifsud/following{/other_user}","gists_url":"https://api.github.com/users/jonmifsud/gists{/gist_id}","starred_url":"https://api.github.com/users/jonmifsud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonmifsud/subscriptions","organizations_url":"https://api.github.com/users/jonmifsud/orgs","repos_url":"https://api.github.com/users/jonmifsud/repos","events_url":"https://api.github.com/users/jonmifsud/events{/privacy}","received_events_url":"https://api.github.com/users/jonmifsud/received_events","type":"User","site_admin":false},"repo":{"id":29603215,"name":"order_entries","full_name":"jonmifsud/order_entries","owner":{"login":"jonmifsud","id":859775,"avatar_url":"https://avatars.githubusercontent.com/u/859775?v=3","gravatar_id":"","url":"https://api.github.com/users/jonmifsud","html_url":"https://github.com/jonmifsud","followers_url":"https://api.github.com/users/jonmifsud/followers","following_url":"https://api.github.com/users/jonmifsud/following{/other_user}","gists_url":"https://api.github.com/users/jonmifsud/gists{/gist_id}","starred_url":"https://api.github.com/users/jonmifsud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonmifsud/subscriptions","organizations_url":"https://api.github.com/users/jonmifsud/orgs","repos_url":"https://api.github.com/users/jonmifsud/repos","events_url":"https://api.github.com/users/jonmifsud/events{/privacy}","received_events_url":"https://api.github.com/users/jonmifsud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonmifsud/order_entries","description":"[Symphony 2] Allow drag-and-drop re-ordering of entries","fork":true,"url":"https://api.github.com/repos/jonmifsud/order_entries","forks_url":"https://api.github.com/repos/jonmifsud/order_entries/forks","keys_url":"https://api.github.com/repos/jonmifsud/order_entries/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonmifsud/order_entries/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonmifsud/order_entries/teams","hooks_url":"https://api.github.com/repos/jonmifsud/order_entries/hooks","issue_events_url":"https://api.github.com/repos/jonmifsud/order_entries/issues/events{/number}","events_url":"https://api.github.com/repos/jonmifsud/order_entries/events","assignees_url":"https://api.github.com/repos/jonmifsud/order_entries/assignees{/user}","branches_url":"https://api.github.com/repos/jonmifsud/order_entries/branches{/branch}","tags_url":"https://api.github.com/repos/jonmifsud/order_entries/tags","blobs_url":"https://api.github.com/repos/jonmifsud/order_entries/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonmifsud/order_entries/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonmifsud/order_entries/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonmifsud/order_entries/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonmifsud/order_entries/statuses/{sha}","languages_url":"https://api.github.com/repos/jonmifsud/order_entries/languages","stargazers_url":"https://api.github.com/repos/jonmifsud/order_entries/stargazers","contributors_url":"https://api.github.com/repos/jonmifsud/order_entries/contributors","subscribers_url":"https://api.github.com/repos/jonmifsud/order_entries/subscribers","subscription_url":"https://api.github.com/repos/jonmifsud/order_entries/subscription","commits_url":"https://api.github.com/repos/jonmifsud/order_entries/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonmifsud/order_entries/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonmifsud/order_entries/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonmifsud/order_entries/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonmifsud/order_entries/contents/{+path}","compare_url":"https://api.github.com/repos/jonmifsud/order_entries/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonmifsud/order_entries/merges","archive_url":"https://api.github.com/repos/jonmifsud/order_entries/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonmifsud/order_entries/downloads","issues_url":"https://api.github.com/repos/jonmifsud/order_entries/issues{/number}","pulls_url":"https://api.github.com/repos/jonmifsud/order_entries/pulls{/number}","milestones_url":"https://api.github.com/repos/jonmifsud/order_entries/milestones{/number}","notifications_url":"https://api.github.com/repos/jonmifsud/order_entries/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonmifsud/order_entries/labels{/name}","releases_url":"https://api.github.com/repos/jonmifsud/order_entries/releases{/id}","created_at":"2015-01-21T17:56:42Z","updated_at":"2015-01-21T17:56:43Z","pushed_at":"2015-11-20T07:44:36Z","git_url":"git://github.com/jonmifsud/order_entries.git","ssh_url":"git@github.com:jonmifsud/order_entries.git","clone_url":"https://github.com/jonmifsud/order_entries.git","svn_url":"https://github.com/jonmifsud/order_entries","homepage":"http://github.com/symphonists/order_entries","size":113,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symphonists:integration","ref":"integration","sha":"434222c4998df22b1a799b66dcf05969670f631e","user":{"login":"symphonists","id":448444,"avatar_url":"https://avatars.githubusercontent.com/u/448444?v=3","gravatar_id":"","url":"https://api.github.com/users/symphonists","html_url":"https://github.com/symphonists","followers_url":"https://api.github.com/users/symphonists/followers","following_url":"https://api.github.com/users/symphonists/following{/other_user}","gists_url":"https://api.github.com/users/symphonists/gists{/gist_id}","starred_url":"https://api.github.com/users/symphonists/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symphonists/subscriptions","organizations_url":"https://api.github.com/users/symphonists/orgs","repos_url":"https://api.github.com/users/symphonists/repos","events_url":"https://api.github.com/users/symphonists/events{/privacy}","received_events_url":"https://api.github.com/users/symphonists/received_events","type":"Organization","site_admin":false},"repo":{"id":141781,"name":"order_entries","full_name":"symphonists/order_entries","owner":{"login":"symphonists","id":448444,"avatar_url":"https://avatars.githubusercontent.com/u/448444?v=3","gravatar_id":"","url":"https://api.github.com/users/symphonists","html_url":"https://github.com/symphonists","followers_url":"https://api.github.com/users/symphonists/followers","following_url":"https://api.github.com/users/symphonists/following{/other_user}","gists_url":"https://api.github.com/users/symphonists/gists{/gist_id}","starred_url":"https://api.github.com/users/symphonists/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symphonists/subscriptions","organizations_url":"https://api.github.com/users/symphonists/orgs","repos_url":"https://api.github.com/users/symphonists/repos","events_url":"https://api.github.com/users/symphonists/events{/privacy}","received_events_url":"https://api.github.com/users/symphonists/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symphonists/order_entries","description":"[Symphony 2] Allow drag-and-drop re-ordering of entries","fork":false,"url":"https://api.github.com/repos/symphonists/order_entries","forks_url":"https://api.github.com/repos/symphonists/order_entries/forks","keys_url":"https://api.github.com/repos/symphonists/order_entries/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symphonists/order_entries/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symphonists/order_entries/teams","hooks_url":"https://api.github.com/repos/symphonists/order_entries/hooks","issue_events_url":"https://api.github.com/repos/symphonists/order_entries/issues/events{/number}","events_url":"https://api.github.com/repos/symphonists/order_entries/events","assignees_url":"https://api.github.com/repos/symphonists/order_entries/assignees{/user}","branches_url":"https://api.github.com/repos/symphonists/order_entries/branches{/branch}","tags_url":"https://api.github.com/repos/symphonists/order_entries/tags","blobs_url":"https://api.github.com/repos/symphonists/order_entries/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symphonists/order_entries/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symphonists/order_entries/git/refs{/sha}","trees_url":"https://api.github.com/repos/symphonists/order_entries/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symphonists/order_entries/statuses/{sha}","languages_url":"https://api.github.com/repos/symphonists/order_entries/languages","stargazers_url":"https://api.github.com/repos/symphonists/order_entries/stargazers","contributors_url":"https://api.github.com/repos/symphonists/order_entries/contributors","subscribers_url":"https://api.github.com/repos/symphonists/order_entries/subscribers","subscription_url":"https://api.github.com/repos/symphonists/order_entries/subscription","commits_url":"https://api.github.com/repos/symphonists/order_entries/commits{/sha}","git_commits_url":"https://api.github.com/repos/symphonists/order_entries/git/commits{/sha}","comments_url":"https://api.github.com/repos/symphonists/order_entries/comments{/number}","issue_comment_url":"https://api.github.com/repos/symphonists/order_entries/issues/comments{/number}","contents_url":"https://api.github.com/repos/symphonists/order_entries/contents/{+path}","compare_url":"https://api.github.com/repos/symphonists/order_entries/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symphonists/order_entries/merges","archive_url":"https://api.github.com/repos/symphonists/order_entries/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symphonists/order_entries/downloads","issues_url":"https://api.github.com/repos/symphonists/order_entries/issues{/number}","pulls_url":"https://api.github.com/repos/symphonists/order_entries/pulls{/number}","milestones_url":"https://api.github.com/repos/symphonists/order_entries/milestones{/number}","notifications_url":"https://api.github.com/repos/symphonists/order_entries/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symphonists/order_entries/labels{/name}","releases_url":"https://api.github.com/repos/symphonists/order_entries/releases{/id}","created_at":"2009-03-03T07:57:42Z","updated_at":"2015-09-07T10:19:29Z","pushed_at":"2015-11-20T22:11:16Z","git_url":"git://github.com/symphonists/order_entries.git","ssh_url":"git@github.com:symphonists/order_entries.git","clone_url":"https://github.com/symphonists/order_entries.git","svn_url":"https://github.com/symphonists/order_entries","homepage":"http://github.com/symphonists/order_entries","size":457,"stargazers_count":33,"watchers_count":33,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":2,"forks":19,"open_issues":2,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symphonists/order_entries/pulls/76"},"html":{"href":"https://github.com/symphonists/order_entries/pull/76"},"issue":{"href":"https://api.github.com/repos/symphonists/order_entries/issues/76"},"comments":{"href":"https://api.github.com/repos/symphonists/order_entries/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/symphonists/order_entries/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/symphonists/order_entries/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symphonists/order_entries/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/symphonists/order_entries/statuses/9bb8a32f4ec807ad86c7d22dc0df3881a2e1f3c4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nitriques","id":771169,"avatar_url":"https://avatars.githubusercontent.com/u/771169?v=3","gravatar_id":"","url":"https://api.github.com/users/nitriques","html_url":"https://github.com/nitriques","followers_url":"https://api.github.com/users/nitriques/followers","following_url":"https://api.github.com/users/nitriques/following{/other_user}","gists_url":"https://api.github.com/users/nitriques/gists{/gist_id}","starred_url":"https://api.github.com/users/nitriques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitriques/subscriptions","organizations_url":"https://api.github.com/users/nitriques/orgs","repos_url":"https://api.github.com/users/nitriques/repos","events_url":"https://api.github.com/users/nitriques/events{/privacy}","received_events_url":"https://api.github.com/users/nitriques/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":2,"additions":7,"deletions":1,"changed_files":2}}