{"action":"created","comment":{"url":"https://api.github.com/repos/php/php-src/pulls/comments/22718438","id":22718438,"diff_hunk":"@@ -1819,6 +1903,32 @@ static size_t php_openssl_sockop_read(php_stream *stream, char *buf, size_t coun\n }\n /* }}} */\n \n+struct timeval subtractTimeval( struct timeval a, struct timeval b )","path":"ext/openssl/xp_ssl.c","position":270,"original_position":270,"commit_id":"8ded274413590a073a2412098ba3e5413d481ef6","original_commit_id":"8ded274413590a073a2412098ba3e5413d481ef6","user":{"login":"jpauli","id":72415,"avatar_url":"https://avatars.githubusercontent.com/u/72415?v=3","gravatar_id":"","url":"https://api.github.com/users/jpauli","html_url":"https://github.com/jpauli","followers_url":"https://api.github.com/users/jpauli/followers","following_url":"https://api.github.com/users/jpauli/following{/other_user}","gists_url":"https://api.github.com/users/jpauli/gists{/gist_id}","starred_url":"https://api.github.com/users/jpauli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpauli/subscriptions","organizations_url":"https://api.github.com/users/jpauli/orgs","repos_url":"https://api.github.com/users/jpauli/repos","events_url":"https://api.github.com/users/jpauli/events{/privacy}","received_events_url":"https://api.github.com/users/jpauli/received_events","type":"User","site_admin":false},"body":"This should be declared static","created_at":"2015-01-09T14:38:43Z","updated_at":"2015-01-09T14:38:43Z","html_url":"https://github.com/php/php-src/pull/971#discussion_r22718438","pull_request_url":"https://api.github.com/repos/php/php-src/pulls/971","_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/comments/22718438"},"html":{"href":"https://github.com/php/php-src/pull/971#discussion_r22718438"},"pull_request":{"href":"https://api.github.com/repos/php/php-src/pulls/971"}}},"pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/971","id":26727075,"html_url":"https://github.com/php/php-src/pull/971","diff_url":"https://github.com/php/php-src/pull/971.diff","patch_url":"https://github.com/php/php-src/pull/971.patch","issue_url":"https://api.github.com/repos/php/php-src/issues/971","number":971,"state":"open","locked":false,"title":"Fix 61285 - SSL connections do not timeout","user":{"login":"bbroerman30","id":2095142,"avatar_url":"https://avatars.githubusercontent.com/u/2095142?v=3","gravatar_id":"","url":"https://api.github.com/users/bbroerman30","html_url":"https://github.com/bbroerman30","followers_url":"https://api.github.com/users/bbroerman30/followers","following_url":"https://api.github.com/users/bbroerman30/following{/other_user}","gists_url":"https://api.github.com/users/bbroerman30/gists{/gist_id}","starred_url":"https://api.github.com/users/bbroerman30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbroerman30/subscriptions","organizations_url":"https://api.github.com/users/bbroerman30/orgs","repos_url":"https://api.github.com/users/bbroerman30/repos","events_url":"https://api.github.com/users/bbroerman30/events{/privacy}","received_events_url":"https://api.github.com/users/bbroerman30/received_events","type":"User","site_admin":false},"body":"Updated xp_ssl.c to use non-blocking SSL read and write along with php_pollfd_for to perform a timed wait if data can not be read / written. Tested with blocking (no timeout set), and non-blocking IO ","created_at":"2014-12-31T15:38:33Z","updated_at":"2015-01-09T14:38:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"283fe467fdd3b1ad17dccda2b32fe4fd829dcafd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/php/php-src/pulls/971/commits","review_comments_url":"https://api.github.com/repos/php/php-src/pulls/971/comments","review_comment_url":"https://api.github.com/repos/php/php-src/pulls/comments/{number}","comments_url":"https://api.github.com/repos/php/php-src/issues/971/comments","statuses_url":"https://api.github.com/repos/php/php-src/statuses/8ded274413590a073a2412098ba3e5413d481ef6","head":{"label":"bbroerman30:master","ref":"master","sha":"8ded274413590a073a2412098ba3e5413d481ef6","user":{"login":"bbroerman30","id":2095142,"avatar_url":"https://avatars.githubusercontent.com/u/2095142?v=3","gravatar_id":"","url":"https://api.github.com/users/bbroerman30","html_url":"https://github.com/bbroerman30","followers_url":"https://api.github.com/users/bbroerman30/followers","following_url":"https://api.github.com/users/bbroerman30/following{/other_user}","gists_url":"https://api.github.com/users/bbroerman30/gists{/gist_id}","starred_url":"https://api.github.com/users/bbroerman30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbroerman30/subscriptions","organizations_url":"https://api.github.com/users/bbroerman30/orgs","repos_url":"https://api.github.com/users/bbroerman30/repos","events_url":"https://api.github.com/users/bbroerman30/events{/privacy}","received_events_url":"https://api.github.com/users/bbroerman30/received_events","type":"User","site_admin":false},"repo":{"id":7719495,"name":"php-src","full_name":"bbroerman30/php-src","owner":{"login":"bbroerman30","id":2095142,"avatar_url":"https://avatars.githubusercontent.com/u/2095142?v=3","gravatar_id":"","url":"https://api.github.com/users/bbroerman30","html_url":"https://github.com/bbroerman30","followers_url":"https://api.github.com/users/bbroerman30/followers","following_url":"https://api.github.com/users/bbroerman30/following{/other_user}","gists_url":"https://api.github.com/users/bbroerman30/gists{/gist_id}","starred_url":"https://api.github.com/users/bbroerman30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbroerman30/subscriptions","organizations_url":"https://api.github.com/users/bbroerman30/orgs","repos_url":"https://api.github.com/users/bbroerman30/repos","events_url":"https://api.github.com/users/bbroerman30/events{/privacy}","received_events_url":"https://api.github.com/users/bbroerman30/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbroerman30/php-src","description":"The PHP Interpreter (Updated to fix timeouts on SSL streams)","fork":true,"url":"https://api.github.com/repos/bbroerman30/php-src","forks_url":"https://api.github.com/repos/bbroerman30/php-src/forks","keys_url":"https://api.github.com/repos/bbroerman30/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbroerman30/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbroerman30/php-src/teams","hooks_url":"https://api.github.com/repos/bbroerman30/php-src/hooks","issue_events_url":"https://api.github.com/repos/bbroerman30/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/bbroerman30/php-src/events","assignees_url":"https://api.github.com/repos/bbroerman30/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/bbroerman30/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/bbroerman30/php-src/tags","blobs_url":"https://api.github.com/repos/bbroerman30/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbroerman30/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbroerman30/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbroerman30/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbroerman30/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/bbroerman30/php-src/languages","stargazers_url":"https://api.github.com/repos/bbroerman30/php-src/stargazers","contributors_url":"https://api.github.com/repos/bbroerman30/php-src/contributors","subscribers_url":"https://api.github.com/repos/bbroerman30/php-src/subscribers","subscription_url":"https://api.github.com/repos/bbroerman30/php-src/subscription","commits_url":"https://api.github.com/repos/bbroerman30/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbroerman30/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbroerman30/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbroerman30/php-src/issues/comments/{number}","contents_url":"https://api.github.com/repos/bbroerman30/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/bbroerman30/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbroerman30/php-src/merges","archive_url":"https://api.github.com/repos/bbroerman30/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbroerman30/php-src/downloads","issues_url":"https://api.github.com/repos/bbroerman30/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/bbroerman30/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/bbroerman30/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/bbroerman30/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbroerman30/php-src/labels{/name}","releases_url":"https://api.github.com/repos/bbroerman30/php-src/releases{/id}","created_at":"2013-01-20T17:45:46Z","updated_at":"2014-12-31T18:31:49Z","pushed_at":"2014-12-31T18:31:48Z","git_url":"git://github.com/bbroerman30/php-src.git","ssh_url":"git@github.com:bbroerman30/php-src.git","clone_url":"https://github.com/bbroerman30/php-src.git","svn_url":"https://github.com/bbroerman30/php-src","homepage":"http://www.php.net","size":201636,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php:master","ref":"master","sha":"365f428d463502fd8a2c63640b280753df4bf71f","user":{"login":"php","id":25158,"avatar_url":"https://avatars.githubusercontent.com/u/25158?v=3","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"repo":{"id":1903522,"name":"php-src","full_name":"php/php-src","owner":{"login":"php","id":25158,"avatar_url":"https://avatars.githubusercontent.com/u/25158?v=3","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php/php-src","description":"The PHP Interpreter","fork":false,"url":"https://api.github.com/repos/php/php-src","forks_url":"https://api.github.com/repos/php/php-src/forks","keys_url":"https://api.github.com/repos/php/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php/php-src/teams","hooks_url":"https://api.github.com/repos/php/php-src/hooks","issue_events_url":"https://api.github.com/repos/php/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/php/php-src/events","assignees_url":"https://api.github.com/repos/php/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/php/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/php/php-src/tags","blobs_url":"https://api.github.com/repos/php/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/php/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/php/php-src/languages","stargazers_url":"https://api.github.com/repos/php/php-src/stargazers","contributors_url":"https://api.github.com/repos/php/php-src/contributors","subscribers_url":"https://api.github.com/repos/php/php-src/subscribers","subscription_url":"https://api.github.com/repos/php/php-src/subscription","commits_url":"https://api.github.com/repos/php/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/php/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/php/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/php/php-src/issues/comments/{number}","contents_url":"https://api.github.com/repos/php/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/php/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php/php-src/merges","archive_url":"https://api.github.com/repos/php/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php/php-src/downloads","issues_url":"https://api.github.com/repos/php/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/php/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/php/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/php/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php/php-src/labels{/name}","releases_url":"https://api.github.com/repos/php/php-src/releases{/id}","created_at":"2011-06-16T01:52:25Z","updated_at":"2015-01-09T13:53:38Z","pushed_at":"2015-01-09T13:53:38Z","git_url":"git://github.com/php/php-src.git","ssh_url":"git@github.com:php/php-src.git","clone_url":"https://github.com/php/php-src.git","svn_url":"https://github.com/php/php-src","homepage":"http://www.php.net","size":1275442,"stargazers_count":5142,"watchers_count":5142,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1805,"mirror_url":null,"open_issues_count":162,"forks":1805,"open_issues":162,"watchers":5142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/971"},"html":{"href":"https://github.com/php/php-src/pull/971"},"issue":{"href":"https://api.github.com/repos/php/php-src/issues/971"},"comments":{"href":"https://api.github.com/repos/php/php-src/issues/971/comments"},"review_comments":{"href":"https://api.github.com/repos/php/php-src/pulls/971/comments"},"review_comment":{"href":"https://api.github.com/repos/php/php-src/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/php/php-src/pulls/971/commits"},"statuses":{"href":"https://api.github.com/repos/php/php-src/statuses/8ded274413590a073a2412098ba3e5413d481ef6"}}}}