{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/3462","labels_url":"https://api.github.com/repos/openshift/origin/issues/3462/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/3462/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/3462/events","html_url":"https://github.com/openshift/origin/pull/3462","id":91328699,"number":3462,"title":"Fix deployment scaling race in test-cmd.sh","user":{"login":"ironcladlou","id":298299,"avatar_url":"https://avatars.githubusercontent.com/u/298299?v=3","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-06-26T18:33:09Z","updated_at":"2015-06-26T20:18:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/3462","html_url":"https://github.com/openshift/origin/pull/3462","diff_url":"https://github.com/openshift/origin/pull/3462.diff","patch_url":"https://github.com/openshift/origin/pull/3462.patch"},"body":"Relax the expectations in test-cmd.sh for deployment scaling scenarios.\r\nThe current test attempts to scale a failed deployment and make assertions\r\nwhich assume a more realistic OpenShift environment (like working deployments).\r\n\r\nThe existing test scenarios race by manipulating the replicas of a failed\r\ndeployment in a way that can sometimes fail due to the failed deployment\r\nreplica count being set back to 0 (possibly by the deployment controller) prior\r\nto a later assertion that the count will be 1.\r\n\r\nThis test should just validate that the scale commands work against a certain\r\ntype of resource and shouldn't try to validate actual scaling scenarios.\r\nRealistic scaling scenarios belong somewhere like the e2e tests.\r\n\r\nCloses #3460."},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/115867339","html_url":"https://github.com/openshift/origin/pull/3462#issuecomment-115867339","issue_url":"https://api.github.com/repos/openshift/origin/issues/3462","id":115867339,"user":{"login":"ironcladlou","id":298299,"avatar_url":"https://avatars.githubusercontent.com/u/298299?v=3","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"created_at":"2015-06-26T20:18:29Z","updated_at":"2015-06-26T20:18:29Z","body":"delete flake... @liggitt, want to merge this in to get it out of the way?"}}