{"action":"created","issue":{"url":"https://api.github.com/repos/gregorio-project/gregorio/issues/50","labels_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/50/comments","events_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/50/events","html_url":"https://github.com/gregorio-project/gregorio/issues/50","id":58359564,"number":50,"title":"grefactor initialization","user":{"login":"rpspringuel","id":7671682,"avatar_url":"https://avatars.githubusercontent.com/u/7671682?v=3","gravatar_id":"","url":"https://api.github.com/users/rpspringuel","html_url":"https://github.com/rpspringuel","followers_url":"https://api.github.com/users/rpspringuel/followers","following_url":"https://api.github.com/users/rpspringuel/following{/other_user}","gists_url":"https://api.github.com/users/rpspringuel/gists{/gist_id}","starred_url":"https://api.github.com/users/rpspringuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpspringuel/subscriptions","organizations_url":"https://api.github.com/users/rpspringuel/orgs","repos_url":"https://api.github.com/users/rpspringuel/repos","events_url":"https://api.github.com/users/rpspringuel/events{/privacy}","received_events_url":"https://api.github.com/users/rpspringuel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/gregorio-project/gregorio/labels/question","name":"question","color":"cc317c"},{"url":"https://api.github.com/repos/gregorio-project/gregorio/labels/TeX","name":"TeX","color":"bfd4f2"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-02-20T14:27:01Z","updated_at":"2015-02-20T16:44:49Z","closed_at":null,"body":"Currently `\\grefactor` is initialized as `0`, assumed to be `1`, and then changed to `17` when the first score is inserted if the user hasn't manually changed it already.  This change causes all distances to rescale.  For the distances in `gsp-default` this is okay because they are all 1/17th of what actually appears in the default score.  However, for any distance which the user manually changes before inserting the score, the change throws a monkey wrench in the works if they don't have an explicit `\\setgrefactor` statement.\r\n\r\nIf we change those distances so that they don't scale, then if a user tweaks them and then decides they want to change the scale of the score, they have to repeat the tweaking process all over again.  Avoiding this requires a proliferation of `\\ifnum\\grefactor=0\\relax\\setgrefactor{17}\\fi` code blocks.\r\n\r\nI think it might be useful to modify this behavior so that the `grefactor` is initialized as `17`.  This would allow the elimination of the `\\ifnum` code blocks but would also require multiplying all the distances in `gsp-default` by 17.  This later change would have the benefit of making the distances more relatable to the user (especially if they were switched out of `sp` and written in `cm` or `mm`).\r\n\r\nFinally, `\\setgrefactor` could have a built in error check that makes sure it's argument is a positive integer.\r\n\r\nOpinions?"},"comment":{"url":"https://api.github.com/repos/gregorio-project/gregorio/issues/comments/75270444","html_url":"https://github.com/gregorio-project/gregorio/issues/50#issuecomment-75270444","issue_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/50","id":75270444,"user":{"login":"eroux","id":60868,"avatar_url":"https://avatars.githubusercontent.com/u/60868?v=3","gravatar_id":"","url":"https://api.github.com/users/eroux","html_url":"https://github.com/eroux","followers_url":"https://api.github.com/users/eroux/followers","following_url":"https://api.github.com/users/eroux/following{/other_user}","gists_url":"https://api.github.com/users/eroux/gists{/gist_id}","starred_url":"https://api.github.com/users/eroux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eroux/subscriptions","organizations_url":"https://api.github.com/users/eroux/orgs","repos_url":"https://api.github.com/users/eroux/repos","events_url":"https://api.github.com/users/eroux/events{/privacy}","received_events_url":"https://api.github.com/users/eroux/received_events","type":"User","site_admin":false},"created_at":"2015-02-20T16:44:48Z","updated_at":"2015-02-20T16:44:48Z","body":"Seems good! By the way, thank you very much for your involvement, it's really helpful!"}}