{"action":"created","comment":{"url":"https://api.github.com/repos/uber/tchannel-node/pulls/comments/47255707","id":47255707,"diff_hunk":"@@ -506,7 +507,13 @@ Operations.prototype._sweepOps = function _sweepOps(ops, direction, callback) {\n \n         var id = opKeys[i];\n         var op = ops[id];\n-        if (op === undefined) {\n+\n+        if (!Object.prototype.hasOwnProperty.call(ops, id)) {\n+            setImmediate(deferNextOp);","path":"operations.js","position":15,"original_position":15,"commit_id":"04b5496b276a7205b696ba49ae181f0467a86e8a","original_commit_id":"04b5496b276a7205b696ba49ae181f0467a86e8a","user":{"login":"jcorbin","id":49715,"avatar_url":"https://avatars.githubusercontent.com/u/49715?v=3","gravatar_id":"","url":"https://api.github.com/users/jcorbin","html_url":"https://github.com/jcorbin","followers_url":"https://api.github.com/users/jcorbin/followers","following_url":"https://api.github.com/users/jcorbin/following{/other_user}","gists_url":"https://api.github.com/users/jcorbin/gists{/gist_id}","starred_url":"https://api.github.com/users/jcorbin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcorbin/subscriptions","organizations_url":"https://api.github.com/users/jcorbin/orgs","repos_url":"https://api.github.com/users/jcorbin/repos","events_url":"https://api.github.com/users/jcorbin/events{/privacy}","received_events_url":"https://api.github.com/users/jcorbin/received_events","type":"User","site_admin":false},"body":"no observability?","created_at":"2015-12-10T17:21:39Z","updated_at":"2015-12-10T17:21:39Z","html_url":"https://github.com/uber/tchannel-node/pull/244#discussion_r47255707","pull_request_url":"https://api.github.com/repos/uber/tchannel-node/pulls/244","_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel-node/pulls/comments/47255707"},"html":{"href":"https://github.com/uber/tchannel-node/pull/244#discussion_r47255707"},"pull_request":{"href":"https://api.github.com/repos/uber/tchannel-node/pulls/244"}}},"pull_request":{"url":"https://api.github.com/repos/uber/tchannel-node/pulls/244","id":53204138,"html_url":"https://github.com/uber/tchannel-node/pull/244","diff_url":"https://github.com/uber/tchannel-node/pull/244.diff","patch_url":"https://github.com/uber/tchannel-node/pull/244.patch","issue_url":"https://api.github.com/repos/uber/tchannel-node/issues/244","number":244,"state":"open","locked":false,"title":"Fix a race conditions in operations.sanitySweep()","user":{"login":"Raynos","id":479538,"avatar_url":"https://avatars.githubusercontent.com/u/479538?v=3","gravatar_id":"","url":"https://api.github.com/users/Raynos","html_url":"https://github.com/Raynos","followers_url":"https://api.github.com/users/Raynos/followers","following_url":"https://api.github.com/users/Raynos/following{/other_user}","gists_url":"https://api.github.com/users/Raynos/gists{/gist_id}","starred_url":"https://api.github.com/users/Raynos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raynos/subscriptions","organizations_url":"https://api.github.com/users/Raynos/orgs","repos_url":"https://api.github.com/users/Raynos/repos","events_url":"https://api.github.com/users/Raynos/events{/privacy}","received_events_url":"https://api.github.com/users/Raynos/received_events","type":"User","site_admin":false},"body":"Because of nextTicks its possible for the cached `opKeys`\narray and the `ops` object disagree about the state of the\nworld.\n\nThis is why I skip over any keys in `opKeys` that are not\nown propertys of `ops`\n\nr: @jcorbin @kriskowal @rf","created_at":"2015-12-10T01:28:18Z","updated_at":"2015-12-10T17:21:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48e9f7e838c4930a0a984e57d44ae268716f2535","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/tchannel-node/pulls/244/commits","review_comments_url":"https://api.github.com/repos/uber/tchannel-node/pulls/244/comments","review_comment_url":"https://api.github.com/repos/uber/tchannel-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/tchannel-node/issues/244/comments","statuses_url":"https://api.github.com/repos/uber/tchannel-node/statuses/04b5496b276a7205b696ba49ae181f0467a86e8a","head":{"label":"uber:fix-operations-race","ref":"fix-operations-race","sha":"04b5496b276a7205b696ba49ae181f0467a86e8a","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":42619114,"name":"tchannel-node","full_name":"uber/tchannel-node","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel-node","description":"","fork":false,"url":"https://api.github.com/repos/uber/tchannel-node","forks_url":"https://api.github.com/repos/uber/tchannel-node/forks","keys_url":"https://api.github.com/repos/uber/tchannel-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel-node/teams","hooks_url":"https://api.github.com/repos/uber/tchannel-node/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel-node/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel-node/events","assignees_url":"https://api.github.com/repos/uber/tchannel-node/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel-node/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel-node/tags","blobs_url":"https://api.github.com/repos/uber/tchannel-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel-node/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel-node/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel-node/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel-node/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel-node/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel-node/subscription","commits_url":"https://api.github.com/repos/uber/tchannel-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel-node/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel-node/merges","archive_url":"https://api.github.com/repos/uber/tchannel-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel-node/downloads","issues_url":"https://api.github.com/repos/uber/tchannel-node/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel-node/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel-node/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel-node/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel-node/releases{/id}","created_at":"2015-09-16T23:37:37Z","updated_at":"2015-12-08T18:45:14Z","pushed_at":"2015-12-10T02:18:46Z","git_url":"git://github.com/uber/tchannel-node.git","ssh_url":"git@github.com:uber/tchannel-node.git","clone_url":"https://github.com/uber/tchannel-node.git","svn_url":"https://github.com/uber/tchannel-node","homepage":null,"size":4439,"stargazers_count":29,"watchers_count":29,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":36,"forks":2,"open_issues":36,"watchers":29,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"8fcbc457046552d10151cc6790b4d849997a5e08","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":42619114,"name":"tchannel-node","full_name":"uber/tchannel-node","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel-node","description":"","fork":false,"url":"https://api.github.com/repos/uber/tchannel-node","forks_url":"https://api.github.com/repos/uber/tchannel-node/forks","keys_url":"https://api.github.com/repos/uber/tchannel-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel-node/teams","hooks_url":"https://api.github.com/repos/uber/tchannel-node/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel-node/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel-node/events","assignees_url":"https://api.github.com/repos/uber/tchannel-node/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel-node/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel-node/tags","blobs_url":"https://api.github.com/repos/uber/tchannel-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel-node/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel-node/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel-node/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel-node/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel-node/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel-node/subscription","commits_url":"https://api.github.com/repos/uber/tchannel-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel-node/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel-node/merges","archive_url":"https://api.github.com/repos/uber/tchannel-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel-node/downloads","issues_url":"https://api.github.com/repos/uber/tchannel-node/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel-node/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel-node/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel-node/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel-node/releases{/id}","created_at":"2015-09-16T23:37:37Z","updated_at":"2015-12-08T18:45:14Z","pushed_at":"2015-12-10T02:18:46Z","git_url":"git://github.com/uber/tchannel-node.git","ssh_url":"git@github.com:uber/tchannel-node.git","clone_url":"https://github.com/uber/tchannel-node.git","svn_url":"https://github.com/uber/tchannel-node","homepage":null,"size":4439,"stargazers_count":29,"watchers_count":29,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":36,"forks":2,"open_issues":36,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel-node/pulls/244"},"html":{"href":"https://github.com/uber/tchannel-node/pull/244"},"issue":{"href":"https://api.github.com/repos/uber/tchannel-node/issues/244"},"comments":{"href":"https://api.github.com/repos/uber/tchannel-node/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/tchannel-node/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/tchannel-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/tchannel-node/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/uber/tchannel-node/statuses/04b5496b276a7205b696ba49ae181f0467a86e8a"}}}}