{"action":"created","issue":{"url":"https://api.github.com/repos/artus-analysis/Excalibur/issues/4","labels_url":"https://api.github.com/repos/artus-analysis/Excalibur/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/artus-analysis/Excalibur/issues/4/comments","events_url":"https://api.github.com/repos/artus-analysis/Excalibur/issues/4/events","html_url":"https://github.com/artus-analysis/Excalibur/issues/4","id":94766489,"number":4,"title":"re-implement PU reweighting","user":{"login":"dhaitz","id":5802753,"avatar_url":"https://avatars.githubusercontent.com/u/5802753?v=3","gravatar_id":"","url":"https://api.github.com/users/dhaitz","html_url":"https://github.com/dhaitz","followers_url":"https://api.github.com/users/dhaitz/followers","following_url":"https://api.github.com/users/dhaitz/following{/other_user}","gists_url":"https://api.github.com/users/dhaitz/gists{/gist_id}","starred_url":"https://api.github.com/users/dhaitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhaitz/subscriptions","organizations_url":"https://api.github.com/users/dhaitz/orgs","repos_url":"https://api.github.com/users/dhaitz/repos","events_url":"https://api.github.com/users/dhaitz/events{/privacy}","received_events_url":"https://api.github.com/users/dhaitz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/artus-analysis/Excalibur/labels/prio:minor","name":"prio:minor","color":"009800"}],"state":"closed","locked":false,"assignee":{"login":"JoramBerger","id":5812039,"avatar_url":"https://avatars.githubusercontent.com/u/5812039?v=3","gravatar_id":"","url":"https://api.github.com/users/JoramBerger","html_url":"https://github.com/JoramBerger","followers_url":"https://api.github.com/users/JoramBerger/followers","following_url":"https://api.github.com/users/JoramBerger/following{/other_user}","gists_url":"https://api.github.com/users/JoramBerger/gists{/gist_id}","starred_url":"https://api.github.com/users/JoramBerger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoramBerger/subscriptions","organizations_url":"https://api.github.com/users/JoramBerger/orgs","repos_url":"https://api.github.com/users/JoramBerger/repos","events_url":"https://api.github.com/users/JoramBerger/events{/privacy}","received_events_url":"https://api.github.com/users/JoramBerger/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2015-07-13T17:02:23Z","updated_at":"2015-10-26T14:05:22Z","closed_at":"2015-10-26T14:05:22Z","body":""},"comment":{"url":"https://api.github.com/repos/artus-analysis/Excalibur/issues/comments/151143854","html_url":"https://github.com/artus-analysis/Excalibur/issues/4#issuecomment-151143854","issue_url":"https://api.github.com/repos/artus-analysis/Excalibur/issues/4","id":151143854,"user":{"login":"MaxFischer-KIT","id":8394047,"avatar_url":"https://avatars.githubusercontent.com/u/8394047?v=3","gravatar_id":"","url":"https://api.github.com/users/MaxFischer-KIT","html_url":"https://github.com/MaxFischer-KIT","followers_url":"https://api.github.com/users/MaxFischer-KIT/followers","following_url":"https://api.github.com/users/MaxFischer-KIT/following{/other_user}","gists_url":"https://api.github.com/users/MaxFischer-KIT/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxFischer-KIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxFischer-KIT/subscriptions","organizations_url":"https://api.github.com/users/MaxFischer-KIT/orgs","repos_url":"https://api.github.com/users/MaxFischer-KIT/repos","events_url":"https://api.github.com/users/MaxFischer-KIT/events{/privacy}","received_events_url":"https://api.github.com/users/MaxFischer-KIT/received_events","type":"User","site_admin":false},"created_at":"2015-10-26T14:05:22Z","updated_at":"2015-10-26T14:05:22Z","body":"I've added some config utilities to handle the dependencies between data and MC (https://github.com/artus-analysis/Excalibur/commit/2eab9f4481ed165381cc5a7c54cd818db32cdcfa). They are used by default for 2015 25ns (https://github.com/artus-analysis/Excalibur/commit/37fcfc0dfc7f211322d8512a14fe9bf5e24b076d).\r\n\r\nSome settings that were previously data only are now used for calculating the weights. I've moved `JsonFiles`, `Minbiasxsec` and `NPUFile` to the general config for 2015.\r\n\r\nI'm aware that the new classes may seem like a **lot** of effort for setting simple configuration values. The alternative was juggling several internal and external dependencies by hand or having lots of boilerplate code that does almost the same every time. The current approach should be much more resistant to misconfiguration. If anybody has questions/concerns regarding design, implementation or usage of the new functionality, please let me know."}}