{"action":"created","comment":{"url":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/comments/47477899","id":47477899,"diff_hunk":"@@ -52,11 +52,11 @@ struct x509_digest {\n #define COOKIE_SIZE\t300\n \n struct vpn_config {\n-\tchar \t\tgateway_host[FIELD_SIZE];\n+\tchar \t\tgateway_host[FIELD_SIZE + 1];\n \tstruct in_addr\tgateway_ip;\n \tuint16_t\tgateway_port;\n-\tchar\t\tusername[FIELD_SIZE];\n-\tchar\t\tpassword[FIELD_SIZE];\n+\tchar\t\tusername[FIELD_SIZE + 1];\n+\tchar\t\tpassword[FIELD_SIZE + 1];","path":"src/config.h","position":11,"original_position":11,"commit_id":"25c7f992eeb7de4644bfe4df8b00bdf2c6ddb326","original_commit_id":"25c7f992eeb7de4644bfe4df8b00bdf2c6ddb326","user":{"login":"mvk","id":152877,"avatar_url":"https://avatars.githubusercontent.com/u/152877?v=3","gravatar_id":"","url":"https://api.github.com/users/mvk","html_url":"https://github.com/mvk","followers_url":"https://api.github.com/users/mvk/followers","following_url":"https://api.github.com/users/mvk/following{/other_user}","gists_url":"https://api.github.com/users/mvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvk/subscriptions","organizations_url":"https://api.github.com/users/mvk/orgs","repos_url":"https://api.github.com/users/mvk/repos","events_url":"https://api.github.com/users/mvk/events{/privacy}","received_events_url":"https://api.github.com/users/mvk/received_events","type":"User","site_admin":false},"body":"I wanted mainly to unify those fields with cookie's policy: maybe what really needs to be changed it the cookie.\r\n","created_at":"2015-12-14T09:53:26Z","updated_at":"2015-12-14T09:53:26Z","html_url":"https://github.com/adrienverge/openfortivpn/pull/37#discussion_r47477899","pull_request_url":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/comments/47477899"},"html":{"href":"https://github.com/adrienverge/openfortivpn/pull/37#discussion_r47477899"},"pull_request":{"href":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/37","id":53471332,"html_url":"https://github.com/adrienverge/openfortivpn/pull/37","diff_url":"https://github.com/adrienverge/openfortivpn/pull/37.diff","patch_url":"https://github.com/adrienverge/openfortivpn/pull/37.patch","issue_url":"https://api.github.com/repos/adrienverge/openfortivpn/issues/37","number":37,"state":"open","locked":false,"title":"quick fix #35","user":{"login":"mvk","id":152877,"avatar_url":"https://avatars.githubusercontent.com/u/152877?v=3","gravatar_id":"","url":"https://api.github.com/users/mvk","html_url":"https://github.com/mvk","followers_url":"https://api.github.com/users/mvk/followers","following_url":"https://api.github.com/users/mvk/following{/other_user}","gists_url":"https://api.github.com/users/mvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvk/subscriptions","organizations_url":"https://api.github.com/users/mvk/orgs","repos_url":"https://api.github.com/users/mvk/repos","events_url":"https://api.github.com/users/mvk/events{/privacy}","received_events_url":"https://api.github.com/users/mvk/received_events","type":"User","site_admin":false},"body":"My previous PR was generated based on a messy branches in my fork, cleaned it up a bit.\r\nThis one only handles URL encoding of username and password.\r\nIt does so by adding dependency to libcurl, and using its functionality.\r\nI've noticed the buffer lengths for user/pass is 64 bytes.\r\nThis is good without url encoding, in the worst case scenario a password can exceed 64 bytes without a problem.\r\nWe can detect this situation, but I didn't wanna mess with this now.\r\nLet's 1st agree on the general approach.\r\n\r\nPlease comment,\r\nThanks!\r\n","created_at":"2015-12-12T08:01:48Z","updated_at":"2015-12-14T09:53:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3de4049b4564960f93fce038579954af3e8cae6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/37/commits","review_comments_url":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/37/comments","review_comment_url":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adrienverge/openfortivpn/issues/37/comments","statuses_url":"https://api.github.com/repos/adrienverge/openfortivpn/statuses/25c7f992eeb7de4644bfe4df8b00bdf2c6ddb326","head":{"label":"mvk:master","ref":"master","sha":"25c7f992eeb7de4644bfe4df8b00bdf2c6ddb326","user":{"login":"mvk","id":152877,"avatar_url":"https://avatars.githubusercontent.com/u/152877?v=3","gravatar_id":"","url":"https://api.github.com/users/mvk","html_url":"https://github.com/mvk","followers_url":"https://api.github.com/users/mvk/followers","following_url":"https://api.github.com/users/mvk/following{/other_user}","gists_url":"https://api.github.com/users/mvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvk/subscriptions","organizations_url":"https://api.github.com/users/mvk/orgs","repos_url":"https://api.github.com/users/mvk/repos","events_url":"https://api.github.com/users/mvk/events{/privacy}","received_events_url":"https://api.github.com/users/mvk/received_events","type":"User","site_admin":false},"repo":{"id":47395439,"name":"openfortivpn","full_name":"mvk/openfortivpn","owner":{"login":"mvk","id":152877,"avatar_url":"https://avatars.githubusercontent.com/u/152877?v=3","gravatar_id":"","url":"https://api.github.com/users/mvk","html_url":"https://github.com/mvk","followers_url":"https://api.github.com/users/mvk/followers","following_url":"https://api.github.com/users/mvk/following{/other_user}","gists_url":"https://api.github.com/users/mvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvk/subscriptions","organizations_url":"https://api.github.com/users/mvk/orgs","repos_url":"https://api.github.com/users/mvk/repos","events_url":"https://api.github.com/users/mvk/events{/privacy}","received_events_url":"https://api.github.com/users/mvk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mvk/openfortivpn","description":"Client for PPP+SSL VPN tunnel services","fork":true,"url":"https://api.github.com/repos/mvk/openfortivpn","forks_url":"https://api.github.com/repos/mvk/openfortivpn/forks","keys_url":"https://api.github.com/repos/mvk/openfortivpn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mvk/openfortivpn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mvk/openfortivpn/teams","hooks_url":"https://api.github.com/repos/mvk/openfortivpn/hooks","issue_events_url":"https://api.github.com/repos/mvk/openfortivpn/issues/events{/number}","events_url":"https://api.github.com/repos/mvk/openfortivpn/events","assignees_url":"https://api.github.com/repos/mvk/openfortivpn/assignees{/user}","branches_url":"https://api.github.com/repos/mvk/openfortivpn/branches{/branch}","tags_url":"https://api.github.com/repos/mvk/openfortivpn/tags","blobs_url":"https://api.github.com/repos/mvk/openfortivpn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mvk/openfortivpn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mvk/openfortivpn/git/refs{/sha}","trees_url":"https://api.github.com/repos/mvk/openfortivpn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mvk/openfortivpn/statuses/{sha}","languages_url":"https://api.github.com/repos/mvk/openfortivpn/languages","stargazers_url":"https://api.github.com/repos/mvk/openfortivpn/stargazers","contributors_url":"https://api.github.com/repos/mvk/openfortivpn/contributors","subscribers_url":"https://api.github.com/repos/mvk/openfortivpn/subscribers","subscription_url":"https://api.github.com/repos/mvk/openfortivpn/subscription","commits_url":"https://api.github.com/repos/mvk/openfortivpn/commits{/sha}","git_commits_url":"https://api.github.com/repos/mvk/openfortivpn/git/commits{/sha}","comments_url":"https://api.github.com/repos/mvk/openfortivpn/comments{/number}","issue_comment_url":"https://api.github.com/repos/mvk/openfortivpn/issues/comments{/number}","contents_url":"https://api.github.com/repos/mvk/openfortivpn/contents/{+path}","compare_url":"https://api.github.com/repos/mvk/openfortivpn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mvk/openfortivpn/merges","archive_url":"https://api.github.com/repos/mvk/openfortivpn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mvk/openfortivpn/downloads","issues_url":"https://api.github.com/repos/mvk/openfortivpn/issues{/number}","pulls_url":"https://api.github.com/repos/mvk/openfortivpn/pulls{/number}","milestones_url":"https://api.github.com/repos/mvk/openfortivpn/milestones{/number}","notifications_url":"https://api.github.com/repos/mvk/openfortivpn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mvk/openfortivpn/labels{/name}","releases_url":"https://api.github.com/repos/mvk/openfortivpn/releases{/id}","created_at":"2015-12-04T09:48:52Z","updated_at":"2015-12-04T09:48:52Z","pushed_at":"2015-12-12T08:18:00Z","git_url":"git://github.com/mvk/openfortivpn.git","ssh_url":"git@github.com:mvk/openfortivpn.git","clone_url":"https://github.com/mvk/openfortivpn.git","svn_url":"https://github.com/mvk/openfortivpn","homepage":"","size":154,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"adrienverge:master","ref":"master","sha":"ce4c2cf09d1c671995163447491b955ff2a3ec8f","user":{"login":"adrienverge","id":5244945,"avatar_url":"https://avatars.githubusercontent.com/u/5244945?v=3","gravatar_id":"","url":"https://api.github.com/users/adrienverge","html_url":"https://github.com/adrienverge","followers_url":"https://api.github.com/users/adrienverge/followers","following_url":"https://api.github.com/users/adrienverge/following{/other_user}","gists_url":"https://api.github.com/users/adrienverge/gists{/gist_id}","starred_url":"https://api.github.com/users/adrienverge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrienverge/subscriptions","organizations_url":"https://api.github.com/users/adrienverge/orgs","repos_url":"https://api.github.com/users/adrienverge/repos","events_url":"https://api.github.com/users/adrienverge/events{/privacy}","received_events_url":"https://api.github.com/users/adrienverge/received_events","type":"User","site_admin":false},"repo":{"id":29872502,"name":"openfortivpn","full_name":"adrienverge/openfortivpn","owner":{"login":"adrienverge","id":5244945,"avatar_url":"https://avatars.githubusercontent.com/u/5244945?v=3","gravatar_id":"","url":"https://api.github.com/users/adrienverge","html_url":"https://github.com/adrienverge","followers_url":"https://api.github.com/users/adrienverge/followers","following_url":"https://api.github.com/users/adrienverge/following{/other_user}","gists_url":"https://api.github.com/users/adrienverge/gists{/gist_id}","starred_url":"https://api.github.com/users/adrienverge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrienverge/subscriptions","organizations_url":"https://api.github.com/users/adrienverge/orgs","repos_url":"https://api.github.com/users/adrienverge/repos","events_url":"https://api.github.com/users/adrienverge/events{/privacy}","received_events_url":"https://api.github.com/users/adrienverge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adrienverge/openfortivpn","description":"Client for PPP+SSL VPN tunnel services","fork":false,"url":"https://api.github.com/repos/adrienverge/openfortivpn","forks_url":"https://api.github.com/repos/adrienverge/openfortivpn/forks","keys_url":"https://api.github.com/repos/adrienverge/openfortivpn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrienverge/openfortivpn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrienverge/openfortivpn/teams","hooks_url":"https://api.github.com/repos/adrienverge/openfortivpn/hooks","issue_events_url":"https://api.github.com/repos/adrienverge/openfortivpn/issues/events{/number}","events_url":"https://api.github.com/repos/adrienverge/openfortivpn/events","assignees_url":"https://api.github.com/repos/adrienverge/openfortivpn/assignees{/user}","branches_url":"https://api.github.com/repos/adrienverge/openfortivpn/branches{/branch}","tags_url":"https://api.github.com/repos/adrienverge/openfortivpn/tags","blobs_url":"https://api.github.com/repos/adrienverge/openfortivpn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrienverge/openfortivpn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrienverge/openfortivpn/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrienverge/openfortivpn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrienverge/openfortivpn/statuses/{sha}","languages_url":"https://api.github.com/repos/adrienverge/openfortivpn/languages","stargazers_url":"https://api.github.com/repos/adrienverge/openfortivpn/stargazers","contributors_url":"https://api.github.com/repos/adrienverge/openfortivpn/contributors","subscribers_url":"https://api.github.com/repos/adrienverge/openfortivpn/subscribers","subscription_url":"https://api.github.com/repos/adrienverge/openfortivpn/subscription","commits_url":"https://api.github.com/repos/adrienverge/openfortivpn/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrienverge/openfortivpn/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrienverge/openfortivpn/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrienverge/openfortivpn/issues/comments{/number}","contents_url":"https://api.github.com/repos/adrienverge/openfortivpn/contents/{+path}","compare_url":"https://api.github.com/repos/adrienverge/openfortivpn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrienverge/openfortivpn/merges","archive_url":"https://api.github.com/repos/adrienverge/openfortivpn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrienverge/openfortivpn/downloads","issues_url":"https://api.github.com/repos/adrienverge/openfortivpn/issues{/number}","pulls_url":"https://api.github.com/repos/adrienverge/openfortivpn/pulls{/number}","milestones_url":"https://api.github.com/repos/adrienverge/openfortivpn/milestones{/number}","notifications_url":"https://api.github.com/repos/adrienverge/openfortivpn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrienverge/openfortivpn/labels{/name}","releases_url":"https://api.github.com/repos/adrienverge/openfortivpn/releases{/id}","created_at":"2015-01-26T17:25:00Z","updated_at":"2015-12-11T12:34:26Z","pushed_at":"2015-12-12T08:18:00Z","git_url":"git://github.com/adrienverge/openfortivpn.git","ssh_url":"git@github.com:adrienverge/openfortivpn.git","clone_url":"https://github.com/adrienverge/openfortivpn.git","svn_url":"https://github.com/adrienverge/openfortivpn","homepage":"","size":152,"stargazers_count":19,"watchers_count":19,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":10,"forks":9,"open_issues":10,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/37"},"html":{"href":"https://github.com/adrienverge/openfortivpn/pull/37"},"issue":{"href":"https://api.github.com/repos/adrienverge/openfortivpn/issues/37"},"comments":{"href":"https://api.github.com/repos/adrienverge/openfortivpn/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/adrienverge/openfortivpn/statuses/25c7f992eeb7de4644bfe4df8b00bdf2c6ddb326"}}}}