{"action":"opened","issue":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1455","labels_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1455/labels{/name}","comments_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1455/comments","events_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1455/events","html_url":"https://github.com/magnumripper/JohnTheRipper/issues/1455","id":89804222,"number":1455,"title":"Build warnings for Sayantan's new hash stuff","user":{"login":"magnumripper","id":1268598,"avatar_url":"https://avatars.githubusercontent.com/u/1268598?v=3","gravatar_id":"","url":"https://api.github.com/users/magnumripper","html_url":"https://github.com/magnumripper","followers_url":"https://api.github.com/users/magnumripper/followers","following_url":"https://api.github.com/users/magnumripper/following{/other_user}","gists_url":"https://api.github.com/users/magnumripper/gists{/gist_id}","starred_url":"https://api.github.com/users/magnumripper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnumripper/subscriptions","organizations_url":"https://api.github.com/users/magnumripper/orgs","repos_url":"https://api.github.com/users/magnumripper/repos","events_url":"https://api.github.com/users/magnumripper/events{/privacy}","received_events_url":"https://api.github.com/users/magnumripper/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/labels/bug","name":"bug","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"Sayantan2048","id":1608941,"avatar_url":"https://avatars.githubusercontent.com/u/1608941?v=3","gravatar_id":"","url":"https://api.github.com/users/Sayantan2048","html_url":"https://github.com/Sayantan2048","followers_url":"https://api.github.com/users/Sayantan2048/followers","following_url":"https://api.github.com/users/Sayantan2048/following{/other_user}","gists_url":"https://api.github.com/users/Sayantan2048/gists{/gist_id}","starred_url":"https://api.github.com/users/Sayantan2048/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sayantan2048/subscriptions","organizations_url":"https://api.github.com/users/Sayantan2048/orgs","repos_url":"https://api.github.com/users/Sayantan2048/repos","events_url":"https://api.github.com/users/Sayantan2048/events{/privacy}","received_events_url":"https://api.github.com/users/Sayantan2048/received_events","type":"User","site_admin":false},"milestone":null,"comments":0,"created_at":"2015-06-20T18:57:00Z","updated_at":"2015-06-20T18:57:00Z","closed_at":null,"body":"```\r\nbuild_table.c:247:71: warning: for loop has empty body [-Wempty-body]\r\n                for (i = 0; i < offset_table_size && offset_data[i].collisions; i++);\r\n                                                                                    ^\r\nbuild_table.c:247:71: note: put the semicolon on a separate line to silence this warning\r\nbuild_table.c:323:14: warning: variable 'last_offset' is uninitialized when used here\r\n      [-Wuninitialized]\r\n                        offset = (last_offset + 1) % hash_table_size;\r\n                                  ^~~~~~~~~~~\r\nbuild_table.c:297:31: note: initialize the variable 'last_offset' to silence this warning\r\n        OFFSET_TABLE_WORD last_offset;\r\n                                     ^\r\n                                      = 0\r\n2 warnings generated.\r\n```\r\nThe indentation on line 248 implies that semicolon should be removed.\r\n\r\n```\r\nhash_type_128.c:416:36: warning: comparison of unsigned expression >= 0 is always true\r\n      [-Wtautological-compare]\r\n        for (i = num_loaded_hashes - 1; i >= 0; i--)\r\n                                        ~ ^  ~\r\nhash_type_128.c:428:34: warning: comparison of unsigned expression >= 0 is always true\r\n      [-Wtautological-compare]\r\n                        for (j = num_unique_hashes; j >= 0; j--)\r\n                                                    ~ ^  ~\r\nhash_type_128.c:416:34: warning: variable 'num_unique_hashes' is used uninitialized whenever 'for'\r\n      loop exits because its condition is false [-Wsometimes-uninitialized]\r\n        for (i = num_loaded_hashes - 1; i >= 0; i--)\r\n                                        ^~~~~~\r\nhash_type_128.c:422:19: note: uninitialized use occurs here\r\n        for (i = 0; i <= num_unique_hashes; i++)\r\n                         ^~~~~~~~~~~~~~~~~\r\nhash_type_128.c:416:34: note: remove the condition if it is always true\r\n        for (i = num_loaded_hashes - 1; i >= 0; i--)\r\n                                        ^~~~~~\r\nhash_type_128.c:261:35: note: initialize the variable 'num_unique_hashes' to silence this warning\r\n        unsigned int i, num_unique_hashes, *rehash_list, counter;\r\n                                         ^\r\n                                          = 0\r\n3 warnings generated.\r\n```\r\n```\r\nhash_type_192.c:423:36: warning: comparison of unsigned expression >= 0 is always true\r\n      [-Wtautological-compare]\r\n        for (i = num_loaded_hashes - 1; i >= 0; i--)\r\n                                        ~ ^  ~\r\nhash_type_192.c:435:34: warning: comparison of unsigned expression >= 0 is always true\r\n      [-Wtautological-compare]\r\n                        for (j = num_unique_hashes; j >= 0; j--)\r\n                                                    ~ ^  ~\r\nhash_type_192.c:423:34: warning: variable 'num_unique_hashes' is used uninitialized whenever 'for'\r\n      loop exits because its condition is false [-Wsometimes-uninitialized]\r\n        for (i = num_loaded_hashes - 1; i >= 0; i--)\r\n                                        ^~~~~~\r\nhash_type_192.c:429:19: note: uninitialized use occurs here\r\n        for (i = 0; i <= num_unique_hashes; i++)\r\n                         ^~~~~~~~~~~~~~~~~\r\nhash_type_192.c:423:34: note: remove the condition if it is always true\r\n        for (i = num_loaded_hashes - 1; i >= 0; i--)\r\n                                        ^~~~~~\r\nhash_type_192.c:268:35: note: initialize the variable 'num_unique_hashes' to silence this warning\r\n        unsigned int i, num_unique_hashes, *rehash_list, counter;\r\n                                         ^\r\n                                          = 0\r\n3 warnings generated.\r\n```"}}