{"action":"created","issue":{"url":"https://api.github.com/repos/OpenMS/OpenMS/issues/1508","labels_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/1508/labels{/name}","comments_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/1508/comments","events_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/1508/events","html_url":"https://github.com/OpenMS/OpenMS/pull/1508","id":94234971,"number":1508,"title":"[FIX] IsotopeDistribution bug for gapped isotopes (e.g. Bromine)","user":{"login":"cbielow","id":6008722,"avatar_url":"https://avatars.githubusercontent.com/u/6008722?v=3","gravatar_id":"","url":"https://api.github.com/users/cbielow","html_url":"https://github.com/cbielow","followers_url":"https://api.github.com/users/cbielow/followers","following_url":"https://api.github.com/users/cbielow/following{/other_user}","gists_url":"https://api.github.com/users/cbielow/gists{/gist_id}","starred_url":"https://api.github.com/users/cbielow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbielow/subscriptions","organizations_url":"https://api.github.com/users/cbielow/orgs","repos_url":"https://api.github.com/users/cbielow/repos","events_url":"https://api.github.com/users/cbielow/events{/privacy}","received_events_url":"https://api.github.com/users/cbielow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-07-10T07:13:51Z","updated_at":"2015-07-20T15:43:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/1508","html_url":"https://github.com/OpenMS/OpenMS/pull/1508","diff_url":"https://github.com/OpenMS/OpenMS/pull/1508.diff","patch_url":"https://github.com/OpenMS/OpenMS/pull/1508.patch"},"body":"Elemental isotope distributions can be gapped, i.e. Bromine only has Br79 and Br81 as stable isotopes.\r\n\r\nOur convolution algorithm however, assumes ungapped isotope distributions, i.e. an explicit Br80=0 (which is missing in our case).\r\n\r\nThis PR fills the required gaps before computing the isotope distribution."},"comment":{"url":"https://api.github.com/repos/OpenMS/OpenMS/issues/comments/122921946","html_url":"https://github.com/OpenMS/OpenMS/pull/1508#issuecomment-122921946","issue_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/1508","id":122921946,"user":{"login":"cbielow","id":6008722,"avatar_url":"https://avatars.githubusercontent.com/u/6008722?v=3","gravatar_id":"","url":"https://api.github.com/users/cbielow","html_url":"https://github.com/cbielow","followers_url":"https://api.github.com/users/cbielow/followers","following_url":"https://api.github.com/users/cbielow/following{/other_user}","gists_url":"https://api.github.com/users/cbielow/gists{/gist_id}","starred_url":"https://api.github.com/users/cbielow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbielow/subscriptions","organizations_url":"https://api.github.com/users/cbielow/orgs","repos_url":"https://api.github.com/users/cbielow/repos","events_url":"https://api.github.com/users/cbielow/events{/privacy}","received_events_url":"https://api.github.com/users/cbielow/received_events","type":"User","site_admin":false},"created_at":"2015-07-20T15:43:58Z","updated_at":"2015-07-20T15:43:58Z","body":"rebased to enable merge again.\r\n\r\nadded some comments to test code (even though I would expect people to understand convolution if they work on isotope distributions?!?)"}}