{"action":"created","issue":{"url":"https://api.github.com/repos/hypothesis/h/issues/2582","labels_url":"https://api.github.com/repos/hypothesis/h/issues/2582/labels{/name}","comments_url":"https://api.github.com/repos/hypothesis/h/issues/2582/comments","events_url":"https://api.github.com/repos/hypothesis/h/issues/2582/events","html_url":"https://github.com/hypothesis/h/pull/2582","id":109763529,"number":2582,"title":"Server-rendered accounts forms","user":{"login":"nickstenning","id":3602,"avatar_url":"https://avatars.githubusercontent.com/u/3602?v=3","gravatar_id":"","url":"https://api.github.com/users/nickstenning","html_url":"https://github.com/nickstenning","followers_url":"https://api.github.com/users/nickstenning/followers","following_url":"https://api.github.com/users/nickstenning/following{/other_user}","gists_url":"https://api.github.com/users/nickstenning/gists{/gist_id}","starred_url":"https://api.github.com/users/nickstenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickstenning/subscriptions","organizations_url":"https://api.github.com/users/nickstenning/orgs","repos_url":"https://api.github.com/users/nickstenning/repos","events_url":"https://api.github.com/users/nickstenning/events{/privacy}","received_events_url":"https://api.github.com/users/nickstenning/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-10-05T09:45:03Z","updated_at":"2015-10-13T10:48:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hypothesis/h/pulls/2582","html_url":"https://github.com/hypothesis/h/pull/2582","diff_url":"https://github.com/hypothesis/h/pull/2582.diff","patch_url":"https://github.com/hypothesis/h/pull/2582.patch"},"body":"Replaces the client-rendered account lifecycle forms, namely:\r\n\r\n- registration\r\n- forgot password\r\n- reset password\r\n\r\nwith forms rendered on the server with deform and validated with colander. The ajax endpoints for the associated forms are removed by this PR, and the associated client code for form handling is removed.\r\n\r\nThe server-side forms should be visually identical to their predecessors with a couple of small exceptions:\r\n\r\n- Make the use of \"Sentence case\" (as opposed to \"Initial Caps\") consistent across form labels: so, \"Email address\" rather than \"Email Address\".\r\n- Render the email form inputs as HTML5 `<input type=\"email\">` fields. This allows mobile clients to customize the keyboard, and triggers automatic client-side validation in most modern browsers.\r\n- The \"reset password\" form will now tell you explicitly if your reset code is invalid. In addition, you can visit \"/reset_password\" (without a code) in order to get a form where you can paste the code as sent in your email.\r\n- The \"forgot password\" form now redirects you to the code-less version of the \"reset password\" form by default, rather than to the home page.\r\n- The \"forgot password\" form no longer flashes you a \"check your email\" message. Instead, the \"reset password\" form will remind you to do so if you didn't provide a code.\r\n- The client registration template had out-of-date information on the allowable length of usernames. The server-side form now uses the `USERNAME_MAX_LENGTH` and `USERNAME_MIN_LENGTH` constants so this is unlikely to happen again.\r\n"},"comment":{"url":"https://api.github.com/repos/hypothesis/h/issues/comments/147679754","html_url":"https://github.com/hypothesis/h/pull/2582#issuecomment-147679754","issue_url":"https://api.github.com/repos/hypothesis/h/issues/2582","id":147679754,"user":{"login":"seanh","id":22498,"avatar_url":"https://avatars.githubusercontent.com/u/22498?v=3","gravatar_id":"","url":"https://api.github.com/users/seanh","html_url":"https://github.com/seanh","followers_url":"https://api.github.com/users/seanh/followers","following_url":"https://api.github.com/users/seanh/following{/other_user}","gists_url":"https://api.github.com/users/seanh/gists{/gist_id}","starred_url":"https://api.github.com/users/seanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanh/subscriptions","organizations_url":"https://api.github.com/users/seanh/orgs","repos_url":"https://api.github.com/users/seanh/repos","events_url":"https://api.github.com/users/seanh/events{/privacy}","received_events_url":"https://api.github.com/users/seanh/received_events","type":"User","site_admin":false},"created_at":"2015-10-13T10:48:11Z","updated_at":"2015-10-13T10:48:11Z","body":"I'd argue that the registration form should not autocomplete, you can't register with the same username or email twice and shouldn't be using the same password, so it doesn't seem useful to me? Not a big deal though."}}