{"action":"created","issue":{"url":"https://api.github.com/repos/damianh/LibLog/issues/48","labels_url":"https://api.github.com/repos/damianh/LibLog/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/damianh/LibLog/issues/48/comments","events_url":"https://api.github.com/repos/damianh/LibLog/issues/48/events","html_url":"https://github.com/damianh/LibLog/issues/48","id":65000758,"number":48,"title":"What should be the accessibility of the various LogProvider get logger methods?","user":{"login":"damianh","id":57436,"avatar_url":"https://avatars.githubusercontent.com/u/57436?v=3","gravatar_id":"","url":"https://api.github.com/users/damianh","html_url":"https://github.com/damianh","followers_url":"https://api.github.com/users/damianh/followers","following_url":"https://api.github.com/users/damianh/following{/other_user}","gists_url":"https://api.github.com/users/damianh/gists{/gist_id}","starred_url":"https://api.github.com/users/damianh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianh/subscriptions","organizations_url":"https://api.github.com/users/damianh/orgs","repos_url":"https://api.github.com/users/damianh/repos","events_url":"https://api.github.com/users/damianh/events{/privacy}","received_events_url":"https://api.github.com/users/damianh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-03-28T23:15:38Z","updated_at":"2015-03-29T19:32:51Z","closed_at":null,"body":"In v1-3, `LogProvider.For<>()`, `LogProvider.GetCurrentClassLogger()` and `LogProvider.GetLogger()` were public and available to all.\r\n\r\nReports in the field were of people doing `var logger = YourLib.Logging.LogProvider.For<>()` in _their_ code causing undesirable coupling.\r\n\r\nIn v4 the intention was to make them internal to prevent this but there is a scenario where this fails: where people have one solution with several projects and they only want to use one LibLog from their `Core` project (and they aren't using `[InternalsVisibleTo]`\r\n\r\nOptions are:\r\n\r\n 1. Make them `public` and add an xml comment something along the lines of \"If you don't own this library, it is advisable that you don't calling this.\"\r\n 2. Make them `internal` only and encourage `[InternalsVisibleTo]` which will have it's own side effects.\r\n 3. ??\r\n\r\n**v4 is delisted pending fixing of this**\r\n\r\nPing @SimonCropp @adamralph"},"comment":{"url":"https://api.github.com/repos/damianh/LibLog/issues/comments/87461103","html_url":"https://github.com/damianh/LibLog/issues/48#issuecomment-87461103","issue_url":"https://api.github.com/repos/damianh/LibLog/issues/48","id":87461103,"user":{"login":"damianh","id":57436,"avatar_url":"https://avatars.githubusercontent.com/u/57436?v=3","gravatar_id":"","url":"https://api.github.com/users/damianh","html_url":"https://github.com/damianh","followers_url":"https://api.github.com/users/damianh/followers","following_url":"https://api.github.com/users/damianh/following{/other_user}","gists_url":"https://api.github.com/users/damianh/gists{/gist_id}","starred_url":"https://api.github.com/users/damianh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianh/subscriptions","organizations_url":"https://api.github.com/users/damianh/orgs","repos_url":"https://api.github.com/users/damianh/repos","events_url":"https://api.github.com/users/damianh/events{/privacy}","received_events_url":"https://api.github.com/users/damianh/received_events","type":"User","site_admin":false},"created_at":"2015-03-29T19:32:51Z","updated_at":"2015-03-29T19:32:51Z","body":"Ping @Erwinvandervalk"}}