{"action":"opened","number":152,"pull_request":{"url":"https://api.github.com/repos/priologic/easyrtc/pulls/152","id":41736644,"html_url":"https://github.com/priologic/easyrtc/pull/152","diff_url":"https://github.com/priologic/easyrtc/pull/152.diff","patch_url":"https://github.com/priologic/easyrtc/pull/152.patch","issue_url":"https://api.github.com/repos/priologic/easyrtc/issues/152","number":152,"state":"open","locked":false,"title":"fix: variables in onEmitEasyrtcCmd/Msg","user":{"login":"merictaze","id":3140073,"avatar_url":"https://avatars.githubusercontent.com/u/3140073?v=3","gravatar_id":"","url":"https://api.github.com/users/merictaze","html_url":"https://github.com/merictaze","followers_url":"https://api.github.com/users/merictaze/followers","following_url":"https://api.github.com/users/merictaze/following{/other_user}","gists_url":"https://api.github.com/users/merictaze/gists{/gist_id}","starred_url":"https://api.github.com/users/merictaze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merictaze/subscriptions","organizations_url":"https://api.github.com/users/merictaze/orgs","repos_url":"https://api.github.com/users/merictaze/repos","events_url":"https://api.github.com/users/merictaze/events{/privacy}","received_events_url":"https://api.github.com/users/merictaze/received_events","type":"User","site_admin":false},"body":"1. instead of \"easyrtcid\", \"senderEasyrtcid\" has to be used due to this check on the client side:\r\nhttps://github.com/priologic/easyrtc/blob/master/api/easyrtc.js#L4188\r\n\r\n2. actual message sent by the user on the server site should be wrapped into \"outgoingMsg.msgData\" instead of directly using it. Otherwise it will be combined with senderEasyrtcid, msgType and serverTime. In addition, client will not be able to find msgData field, and it will be lost..","created_at":"2015-08-05T23:08:59Z","updated_at":"2015-08-05T23:08:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c2013aff00aa508570a1985a02abafc91f11148","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/priologic/easyrtc/pulls/152/commits","review_comments_url":"https://api.github.com/repos/priologic/easyrtc/pulls/152/comments","review_comment_url":"https://api.github.com/repos/priologic/easyrtc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/priologic/easyrtc/issues/152/comments","statuses_url":"https://api.github.com/repos/priologic/easyrtc/statuses/be06bee27170db346f464a87bdb64e6c5bbee346","head":{"label":"merictaze:patch-3","ref":"patch-3","sha":"be06bee27170db346f464a87bdb64e6c5bbee346","user":{"login":"merictaze","id":3140073,"avatar_url":"https://avatars.githubusercontent.com/u/3140073?v=3","gravatar_id":"","url":"https://api.github.com/users/merictaze","html_url":"https://github.com/merictaze","followers_url":"https://api.github.com/users/merictaze/followers","following_url":"https://api.github.com/users/merictaze/following{/other_user}","gists_url":"https://api.github.com/users/merictaze/gists{/gist_id}","starred_url":"https://api.github.com/users/merictaze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merictaze/subscriptions","organizations_url":"https://api.github.com/users/merictaze/orgs","repos_url":"https://api.github.com/users/merictaze/repos","events_url":"https://api.github.com/users/merictaze/events{/privacy}","received_events_url":"https://api.github.com/users/merictaze/received_events","type":"User","site_admin":false},"repo":{"id":40269980,"name":"easyrtc","full_name":"merictaze/easyrtc","owner":{"login":"merictaze","id":3140073,"avatar_url":"https://avatars.githubusercontent.com/u/3140073?v=3","gravatar_id":"","url":"https://api.github.com/users/merictaze","html_url":"https://github.com/merictaze","followers_url":"https://api.github.com/users/merictaze/followers","following_url":"https://api.github.com/users/merictaze/following{/other_user}","gists_url":"https://api.github.com/users/merictaze/gists{/gist_id}","starred_url":"https://api.github.com/users/merictaze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merictaze/subscriptions","organizations_url":"https://api.github.com/users/merictaze/orgs","repos_url":"https://api.github.com/users/merictaze/repos","events_url":"https://api.github.com/users/merictaze/events{/privacy}","received_events_url":"https://api.github.com/users/merictaze/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/merictaze/easyrtc","description":"EasyRTC is a bundle of Open Source WebRTC joy!   Our Javascript API hides the differences between Chrome and Firefox browsers and simplifies coding needed for working WebRTC apps. Signalling server using socket.io built on node.js.  Tons of free code so you can build WebRTC apps in a few hours that just work.  Demos include Instant messaging, Multiparty chatroom, Audio + Video, Screen sharing, Data channel Messaging and File sharing, and more.","fork":true,"url":"https://api.github.com/repos/merictaze/easyrtc","forks_url":"https://api.github.com/repos/merictaze/easyrtc/forks","keys_url":"https://api.github.com/repos/merictaze/easyrtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/merictaze/easyrtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/merictaze/easyrtc/teams","hooks_url":"https://api.github.com/repos/merictaze/easyrtc/hooks","issue_events_url":"https://api.github.com/repos/merictaze/easyrtc/issues/events{/number}","events_url":"https://api.github.com/repos/merictaze/easyrtc/events","assignees_url":"https://api.github.com/repos/merictaze/easyrtc/assignees{/user}","branches_url":"https://api.github.com/repos/merictaze/easyrtc/branches{/branch}","tags_url":"https://api.github.com/repos/merictaze/easyrtc/tags","blobs_url":"https://api.github.com/repos/merictaze/easyrtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/merictaze/easyrtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/merictaze/easyrtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/merictaze/easyrtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/merictaze/easyrtc/statuses/{sha}","languages_url":"https://api.github.com/repos/merictaze/easyrtc/languages","stargazers_url":"https://api.github.com/repos/merictaze/easyrtc/stargazers","contributors_url":"https://api.github.com/repos/merictaze/easyrtc/contributors","subscribers_url":"https://api.github.com/repos/merictaze/easyrtc/subscribers","subscription_url":"https://api.github.com/repos/merictaze/easyrtc/subscription","commits_url":"https://api.github.com/repos/merictaze/easyrtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/merictaze/easyrtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/merictaze/easyrtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/merictaze/easyrtc/issues/comments{/number}","contents_url":"https://api.github.com/repos/merictaze/easyrtc/contents/{+path}","compare_url":"https://api.github.com/repos/merictaze/easyrtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/merictaze/easyrtc/merges","archive_url":"https://api.github.com/repos/merictaze/easyrtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/merictaze/easyrtc/downloads","issues_url":"https://api.github.com/repos/merictaze/easyrtc/issues{/number}","pulls_url":"https://api.github.com/repos/merictaze/easyrtc/pulls{/number}","milestones_url":"https://api.github.com/repos/merictaze/easyrtc/milestones{/number}","notifications_url":"https://api.github.com/repos/merictaze/easyrtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/merictaze/easyrtc/labels{/name}","releases_url":"https://api.github.com/repos/merictaze/easyrtc/releases{/id}","created_at":"2015-08-05T21:36:05Z","updated_at":"2015-08-05T21:36:06Z","pushed_at":"2015-08-05T23:08:29Z","git_url":"git://github.com/merictaze/easyrtc.git","ssh_url":"git@github.com:merictaze/easyrtc.git","clone_url":"https://github.com/merictaze/easyrtc.git","svn_url":"https://github.com/merictaze/easyrtc","homepage":"http://easyrtc.com","size":6526,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"priologic:master","ref":"master","sha":"04bf1295d741a2c5e8c06ca5705fed1d9c44a1a1","user":{"login":"priologic","id":2780997,"avatar_url":"https://avatars.githubusercontent.com/u/2780997?v=3","gravatar_id":"","url":"https://api.github.com/users/priologic","html_url":"https://github.com/priologic","followers_url":"https://api.github.com/users/priologic/followers","following_url":"https://api.github.com/users/priologic/following{/other_user}","gists_url":"https://api.github.com/users/priologic/gists{/gist_id}","starred_url":"https://api.github.com/users/priologic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priologic/subscriptions","organizations_url":"https://api.github.com/users/priologic/orgs","repos_url":"https://api.github.com/users/priologic/repos","events_url":"https://api.github.com/users/priologic/events{/privacy}","received_events_url":"https://api.github.com/users/priologic/received_events","type":"User","site_admin":false},"repo":{"id":7097588,"name":"easyrtc","full_name":"priologic/easyrtc","owner":{"login":"priologic","id":2780997,"avatar_url":"https://avatars.githubusercontent.com/u/2780997?v=3","gravatar_id":"","url":"https://api.github.com/users/priologic","html_url":"https://github.com/priologic","followers_url":"https://api.github.com/users/priologic/followers","following_url":"https://api.github.com/users/priologic/following{/other_user}","gists_url":"https://api.github.com/users/priologic/gists{/gist_id}","starred_url":"https://api.github.com/users/priologic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priologic/subscriptions","organizations_url":"https://api.github.com/users/priologic/orgs","repos_url":"https://api.github.com/users/priologic/repos","events_url":"https://api.github.com/users/priologic/events{/privacy}","received_events_url":"https://api.github.com/users/priologic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/priologic/easyrtc","description":"EasyRTC is a bundle of Open Source WebRTC joy!   Our Javascript API hides the differences between Chrome and Firefox browsers and simplifies coding needed for working WebRTC apps. Signalling server using socket.io built on node.js.  Tons of free code so you can build WebRTC apps in a few hours that just work.  Demos include Instant messaging, Multiparty chatroom, Audio + Video, Screen sharing, Data channel Messaging and File sharing, and more.","fork":false,"url":"https://api.github.com/repos/priologic/easyrtc","forks_url":"https://api.github.com/repos/priologic/easyrtc/forks","keys_url":"https://api.github.com/repos/priologic/easyrtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/priologic/easyrtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/priologic/easyrtc/teams","hooks_url":"https://api.github.com/repos/priologic/easyrtc/hooks","issue_events_url":"https://api.github.com/repos/priologic/easyrtc/issues/events{/number}","events_url":"https://api.github.com/repos/priologic/easyrtc/events","assignees_url":"https://api.github.com/repos/priologic/easyrtc/assignees{/user}","branches_url":"https://api.github.com/repos/priologic/easyrtc/branches{/branch}","tags_url":"https://api.github.com/repos/priologic/easyrtc/tags","blobs_url":"https://api.github.com/repos/priologic/easyrtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/priologic/easyrtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/priologic/easyrtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/priologic/easyrtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/priologic/easyrtc/statuses/{sha}","languages_url":"https://api.github.com/repos/priologic/easyrtc/languages","stargazers_url":"https://api.github.com/repos/priologic/easyrtc/stargazers","contributors_url":"https://api.github.com/repos/priologic/easyrtc/contributors","subscribers_url":"https://api.github.com/repos/priologic/easyrtc/subscribers","subscription_url":"https://api.github.com/repos/priologic/easyrtc/subscription","commits_url":"https://api.github.com/repos/priologic/easyrtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/priologic/easyrtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/priologic/easyrtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/priologic/easyrtc/issues/comments{/number}","contents_url":"https://api.github.com/repos/priologic/easyrtc/contents/{+path}","compare_url":"https://api.github.com/repos/priologic/easyrtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/priologic/easyrtc/merges","archive_url":"https://api.github.com/repos/priologic/easyrtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/priologic/easyrtc/downloads","issues_url":"https://api.github.com/repos/priologic/easyrtc/issues{/number}","pulls_url":"https://api.github.com/repos/priologic/easyrtc/pulls{/number}","milestones_url":"https://api.github.com/repos/priologic/easyrtc/milestones{/number}","notifications_url":"https://api.github.com/repos/priologic/easyrtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/priologic/easyrtc/labels{/name}","releases_url":"https://api.github.com/repos/priologic/easyrtc/releases{/id}","created_at":"2012-12-10T17:38:07Z","updated_at":"2015-08-05T21:43:20Z","pushed_at":"2015-08-05T23:08:59Z","git_url":"git://github.com/priologic/easyrtc.git","ssh_url":"git@github.com:priologic/easyrtc.git","clone_url":"https://github.com/priologic/easyrtc.git","svn_url":"https://github.com/priologic/easyrtc","homepage":"http://easyrtc.com","size":6526,"stargazers_count":751,"watchers_count":751,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":282,"mirror_url":null,"open_issues_count":50,"forks":282,"open_issues":50,"watchers":751,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/priologic/easyrtc/pulls/152"},"html":{"href":"https://github.com/priologic/easyrtc/pull/152"},"issue":{"href":"https://api.github.com/repos/priologic/easyrtc/issues/152"},"comments":{"href":"https://api.github.com/repos/priologic/easyrtc/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/priologic/easyrtc/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/priologic/easyrtc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/priologic/easyrtc/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/priologic/easyrtc/statuses/be06bee27170db346f464a87bdb64e6c5bbee346"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":14,"deletions":8,"changed_files":1}}