{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/35190687","id":35190687,"diff_hunk":"@@ -46,6 +46,12 @@ class CPlayerController : public ISliderCallback\n    */\n   virtual void OnSliderChange(void *data, CGUISliderControl *slider);\n \n+protected:\n+  CPlayerController();\n+  CPlayerController(const CPlayerController&);\n+  CPlayerController& operator=(CPlayerController const&);\n+  virtual ~CPlayerController();","path":"xbmc/video/PlayerController.h","position":30,"original_position":30,"commit_id":"ae0960c0b19b03684132ae928402899367e5e8c4","original_commit_id":"ae0960c0b19b03684132ae928402899367e5e8c4","user":{"login":"xhaggi","id":1878991,"avatar_url":"https://avatars.githubusercontent.com/u/1878991?v=3","gravatar_id":"","url":"https://api.github.com/users/xhaggi","html_url":"https://github.com/xhaggi","followers_url":"https://api.github.com/users/xhaggi/followers","following_url":"https://api.github.com/users/xhaggi/following{/other_user}","gists_url":"https://api.github.com/users/xhaggi/gists{/gist_id}","starred_url":"https://api.github.com/users/xhaggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhaggi/subscriptions","organizations_url":"https://api.github.com/users/xhaggi/orgs","repos_url":"https://api.github.com/users/xhaggi/repos","events_url":"https://api.github.com/users/xhaggi/events{/privacy}","received_events_url":"https://api.github.com/users/xhaggi/received_events","type":"User","site_admin":false},"body":"I've to disagree, if it's declared as a static member or static local within its own class, then the destructor may be private/protected.","created_at":"2015-07-22T08:22:58Z","updated_at":"2015-07-22T08:22:58Z","html_url":"https://github.com/xbmc/xbmc/pull/7581#discussion_r35190687","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7581","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/35190687"},"html":{"href":"https://github.com/xbmc/xbmc/pull/7581#discussion_r35190687"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7581"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/7581","id":40534392,"html_url":"https://github.com/xbmc/xbmc/pull/7581","diff_url":"https://github.com/xbmc/xbmc/pull/7581.diff","patch_url":"https://github.com/xbmc/xbmc/pull/7581.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/7581","number":7581,"state":"open","locked":false,"title":"[video] use action listener pattern for CPlayerController","user":{"login":"xhaggi","id":1878991,"avatar_url":"https://avatars.githubusercontent.com/u/1878991?v=3","gravatar_id":"","url":"https://api.github.com/users/xhaggi","html_url":"https://github.com/xhaggi","followers_url":"https://api.github.com/users/xhaggi/followers","following_url":"https://api.github.com/users/xhaggi/following{/other_user}","gists_url":"https://api.github.com/users/xhaggi/gists{/gist_id}","starred_url":"https://api.github.com/users/xhaggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhaggi/subscriptions","organizations_url":"https://api.github.com/users/xhaggi/orgs","repos_url":"https://api.github.com/users/xhaggi/repos","events_url":"https://api.github.com/users/xhaggi/events{/privacy}","received_events_url":"https://api.github.com/users/xhaggi/received_events","type":"User","site_admin":false},"body":"As the title said this refactors `CPlayerController` to use the action listener interface/pattern and register/unregister it `CApplication`. It also change `CPlayerController` to be Singleton so we can drop the member from `CApplication`.\r\n\r\n@Paxxi mind taking a look","created_at":"2015-07-22T06:37:15Z","updated_at":"2015-07-22T08:22:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1021620cc525377dbf01227c80cf3596baddfee4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7581/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7581/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/7581/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/ae0960c0b19b03684132ae928402899367e5e8c4","head":{"label":"xhaggi:player-controller-as-action-listener","ref":"player-controller-as-action-listener","sha":"ae0960c0b19b03684132ae928402899367e5e8c4","user":{"login":"xhaggi","id":1878991,"avatar_url":"https://avatars.githubusercontent.com/u/1878991?v=3","gravatar_id":"","url":"https://api.github.com/users/xhaggi","html_url":"https://github.com/xhaggi","followers_url":"https://api.github.com/users/xhaggi/followers","following_url":"https://api.github.com/users/xhaggi/following{/other_user}","gists_url":"https://api.github.com/users/xhaggi/gists{/gist_id}","starred_url":"https://api.github.com/users/xhaggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhaggi/subscriptions","organizations_url":"https://api.github.com/users/xhaggi/orgs","repos_url":"https://api.github.com/users/xhaggi/repos","events_url":"https://api.github.com/users/xhaggi/events{/privacy}","received_events_url":"https://api.github.com/users/xhaggi/received_events","type":"User","site_admin":false},"repo":{"id":5698705,"name":"xbmc","full_name":"xhaggi/xbmc","owner":{"login":"xhaggi","id":1878991,"avatar_url":"https://avatars.githubusercontent.com/u/1878991?v=3","gravatar_id":"","url":"https://api.github.com/users/xhaggi","html_url":"https://github.com/xhaggi","followers_url":"https://api.github.com/users/xhaggi/followers","following_url":"https://api.github.com/users/xhaggi/following{/other_user}","gists_url":"https://api.github.com/users/xhaggi/gists{/gist_id}","starred_url":"https://api.github.com/users/xhaggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhaggi/subscriptions","organizations_url":"https://api.github.com/users/xhaggi/orgs","repos_url":"https://api.github.com/users/xhaggi/repos","events_url":"https://api.github.com/users/xhaggi/events{/privacy}","received_events_url":"https://api.github.com/users/xhaggi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xhaggi/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/xhaggi/xbmc","forks_url":"https://api.github.com/repos/xhaggi/xbmc/forks","keys_url":"https://api.github.com/repos/xhaggi/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xhaggi/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xhaggi/xbmc/teams","hooks_url":"https://api.github.com/repos/xhaggi/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xhaggi/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xhaggi/xbmc/events","assignees_url":"https://api.github.com/repos/xhaggi/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xhaggi/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xhaggi/xbmc/tags","blobs_url":"https://api.github.com/repos/xhaggi/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xhaggi/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xhaggi/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xhaggi/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xhaggi/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xhaggi/xbmc/languages","stargazers_url":"https://api.github.com/repos/xhaggi/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xhaggi/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xhaggi/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xhaggi/xbmc/subscription","commits_url":"https://api.github.com/repos/xhaggi/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xhaggi/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xhaggi/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xhaggi/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xhaggi/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xhaggi/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xhaggi/xbmc/merges","archive_url":"https://api.github.com/repos/xhaggi/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xhaggi/xbmc/downloads","issues_url":"https://api.github.com/repos/xhaggi/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xhaggi/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xhaggi/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xhaggi/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xhaggi/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xhaggi/xbmc/releases{/id}","created_at":"2012-09-06T07:06:44Z","updated_at":"2015-04-20T10:44:49Z","pushed_at":"2015-07-22T07:21:26Z","git_url":"git://github.com/xhaggi/xbmc.git","ssh_url":"git@github.com:xhaggi/xbmc.git","clone_url":"https://github.com/xhaggi/xbmc.git","svn_url":"https://github.com/xhaggi/xbmc","homepage":"http://xbmc.org","size":524218,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"f9e57db1834a7883bba738f29d05e61089aa0666","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-07-20T22:54:54Z","pushed_at":"2015-07-22T07:33:38Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1865295,"stargazers_count":4014,"watchers_count":4014,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2929,"mirror_url":null,"open_issues_count":194,"forks":2929,"open_issues":194,"watchers":4014,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7581"},"html":{"href":"https://github.com/xbmc/xbmc/pull/7581"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7581"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7581/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7581/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7581/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/ae0960c0b19b03684132ae928402899367e5e8c4"}}}}