{"action":"opened","number":137,"pull_request":{"url":"https://api.github.com/repos/kenji0919/pirodx_manager/pulls/137","id":31838036,"html_url":"https://github.com/kenji0919/pirodx_manager/pull/137","diff_url":"https://github.com/kenji0919/pirodx_manager/pull/137.diff","patch_url":"https://github.com/kenji0919/pirodx_manager/pull/137.patch","issue_url":"https://api.github.com/repos/kenji0919/pirodx_manager/issues/137","number":137,"state":"open","locked":false,"title":"fix bug: rival/search_user can't handle errors","user":{"login":"kenji0919","id":2742315,"avatar_url":"https://avatars.githubusercontent.com/u/2742315?v=3","gravatar_id":"","url":"https://api.github.com/users/kenji0919","html_url":"https://github.com/kenji0919","followers_url":"https://api.github.com/users/kenji0919/followers","following_url":"https://api.github.com/users/kenji0919/following{/other_user}","gists_url":"https://api.github.com/users/kenji0919/gists{/gist_id}","starred_url":"https://api.github.com/users/kenji0919/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenji0919/subscriptions","organizations_url":"https://api.github.com/users/kenji0919/orgs","repos_url":"https://api.github.com/users/kenji0919/repos","events_url":"https://api.github.com/users/kenji0919/events{/privacy}","received_events_url":"https://api.github.com/users/kenji0919/received_events","type":"User","site_admin":false},"body":"ライバルページでユーザ検索した時の挙動がおかしかったので修正しました。\r\n\r\n- 以下のようなシチュエーションで、undefinedをtrimしているって怒られる\r\n  - eAMUにログインしていない状態でユーザ検索する\r\n  - 存在しない（桁は合ってる）IIDX IDで検索する\r\n  - 無効な（桁が違うなど）IIDX IDで検索する\r\n\r\n→エラー判定をして、アラートを出すようにしました（しょぼいですが）\r\nもう少し真面目に判定しても良かったのですが、コスパ悪そうだったので、面倒くさくない範囲でエラー処理しました。","created_at":"2015-03-24T15:34:34Z","updated_at":"2015-03-24T15:34:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kenji0919/pirodx_manager/pulls/137/commits","review_comments_url":"https://api.github.com/repos/kenji0919/pirodx_manager/pulls/137/comments","review_comment_url":"https://api.github.com/repos/kenji0919/pirodx_manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kenji0919/pirodx_manager/issues/137/comments","statuses_url":"https://api.github.com/repos/kenji0919/pirodx_manager/statuses/8af038f906a9453fd7e5ceb00e7d797f037a694f","head":{"label":"kenji0919:hotfix","ref":"hotfix","sha":"8af038f906a9453fd7e5ceb00e7d797f037a694f","user":{"login":"kenji0919","id":2742315,"avatar_url":"https://avatars.githubusercontent.com/u/2742315?v=3","gravatar_id":"","url":"https://api.github.com/users/kenji0919","html_url":"https://github.com/kenji0919","followers_url":"https://api.github.com/users/kenji0919/followers","following_url":"https://api.github.com/users/kenji0919/following{/other_user}","gists_url":"https://api.github.com/users/kenji0919/gists{/gist_id}","starred_url":"https://api.github.com/users/kenji0919/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenji0919/subscriptions","organizations_url":"https://api.github.com/users/kenji0919/orgs","repos_url":"https://api.github.com/users/kenji0919/repos","events_url":"https://api.github.com/users/kenji0919/events{/privacy}","received_events_url":"https://api.github.com/users/kenji0919/received_events","type":"User","site_admin":false},"repo":{"id":28089974,"name":"pirodx_manager","full_name":"kenji0919/pirodx_manager","owner":{"login":"kenji0919","id":2742315,"avatar_url":"https://avatars.githubusercontent.com/u/2742315?v=3","gravatar_id":"","url":"https://api.github.com/users/kenji0919","html_url":"https://github.com/kenji0919","followers_url":"https://api.github.com/users/kenji0919/followers","following_url":"https://api.github.com/users/kenji0919/following{/other_user}","gists_url":"https://api.github.com/users/kenji0919/gists{/gist_id}","starred_url":"https://api.github.com/users/kenji0919/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenji0919/subscriptions","organizations_url":"https://api.github.com/users/kenji0919/orgs","repos_url":"https://api.github.com/users/kenji0919/repos","events_url":"https://api.github.com/users/kenji0919/events{/privacy}","received_events_url":"https://api.github.com/users/kenji0919/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kenji0919/pirodx_manager","description":"Score Manager for beatmania IIDX","fork":false,"url":"https://api.github.com/repos/kenji0919/pirodx_manager","forks_url":"https://api.github.com/repos/kenji0919/pirodx_manager/forks","keys_url":"https://api.github.com/repos/kenji0919/pirodx_manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kenji0919/pirodx_manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kenji0919/pirodx_manager/teams","hooks_url":"https://api.github.com/repos/kenji0919/pirodx_manager/hooks","issue_events_url":"https://api.github.com/repos/kenji0919/pirodx_manager/issues/events{/number}","events_url":"https://api.github.com/repos/kenji0919/pirodx_manager/events","assignees_url":"https://api.github.com/repos/kenji0919/pirodx_manager/assignees{/user}","branches_url":"https://api.github.com/repos/kenji0919/pirodx_manager/branches{/branch}","tags_url":"https://api.github.com/repos/kenji0919/pirodx_manager/tags","blobs_url":"https://api.github.com/repos/kenji0919/pirodx_manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kenji0919/pirodx_manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kenji0919/pirodx_manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/kenji0919/pirodx_manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kenji0919/pirodx_manager/statuses/{sha}","languages_url":"https://api.github.com/repos/kenji0919/pirodx_manager/languages","stargazers_url":"https://api.github.com/repos/kenji0919/pirodx_manager/stargazers","contributors_url":"https://api.github.com/repos/kenji0919/pirodx_manager/contributors","subscribers_url":"https://api.github.com/repos/kenji0919/pirodx_manager/subscribers","subscription_url":"https://api.github.com/repos/kenji0919/pirodx_manager/subscription","commits_url":"https://api.github.com/repos/kenji0919/pirodx_manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/kenji0919/pirodx_manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/kenji0919/pirodx_manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/kenji0919/pirodx_manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/kenji0919/pirodx_manager/contents/{+path}","compare_url":"https://api.github.com/repos/kenji0919/pirodx_manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kenji0919/pirodx_manager/merges","archive_url":"https://api.github.com/repos/kenji0919/pirodx_manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kenji0919/pirodx_manager/downloads","issues_url":"https://api.github.com/repos/kenji0919/pirodx_manager/issues{/number}","pulls_url":"https://api.github.com/repos/kenji0919/pirodx_manager/pulls{/number}","milestones_url":"https://api.github.com/repos/kenji0919/pirodx_manager/milestones{/number}","notifications_url":"https://api.github.com/repos/kenji0919/pirodx_manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kenji0919/pirodx_manager/labels{/name}","releases_url":"https://api.github.com/repos/kenji0919/pirodx_manager/releases{/id}","created_at":"2014-12-16T14:14:58Z","updated_at":"2015-03-22T15:01:56Z","pushed_at":"2015-03-24T15:32:20Z","git_url":"git://github.com/kenji0919/pirodx_manager.git","ssh_url":"git@github.com:kenji0919/pirodx_manager.git","clone_url":"https://github.com/kenji0919/pirodx_manager.git","svn_url":"https://github.com/kenji0919/pirodx_manager","homepage":null,"size":5557,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"kenji0919:master","ref":"master","sha":"5770c9317a557d1a224670237f258b1c0addc48d","user":{"login":"kenji0919","id":2742315,"avatar_url":"https://avatars.githubusercontent.com/u/2742315?v=3","gravatar_id":"","url":"https://api.github.com/users/kenji0919","html_url":"https://github.com/kenji0919","followers_url":"https://api.github.com/users/kenji0919/followers","following_url":"https://api.github.com/users/kenji0919/following{/other_user}","gists_url":"https://api.github.com/users/kenji0919/gists{/gist_id}","starred_url":"https://api.github.com/users/kenji0919/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenji0919/subscriptions","organizations_url":"https://api.github.com/users/kenji0919/orgs","repos_url":"https://api.github.com/users/kenji0919/repos","events_url":"https://api.github.com/users/kenji0919/events{/privacy}","received_events_url":"https://api.github.com/users/kenji0919/received_events","type":"User","site_admin":false},"repo":{"id":28089974,"name":"pirodx_manager","full_name":"kenji0919/pirodx_manager","owner":{"login":"kenji0919","id":2742315,"avatar_url":"https://avatars.githubusercontent.com/u/2742315?v=3","gravatar_id":"","url":"https://api.github.com/users/kenji0919","html_url":"https://github.com/kenji0919","followers_url":"https://api.github.com/users/kenji0919/followers","following_url":"https://api.github.com/users/kenji0919/following{/other_user}","gists_url":"https://api.github.com/users/kenji0919/gists{/gist_id}","starred_url":"https://api.github.com/users/kenji0919/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenji0919/subscriptions","organizations_url":"https://api.github.com/users/kenji0919/orgs","repos_url":"https://api.github.com/users/kenji0919/repos","events_url":"https://api.github.com/users/kenji0919/events{/privacy}","received_events_url":"https://api.github.com/users/kenji0919/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kenji0919/pirodx_manager","description":"Score Manager for beatmania IIDX","fork":false,"url":"https://api.github.com/repos/kenji0919/pirodx_manager","forks_url":"https://api.github.com/repos/kenji0919/pirodx_manager/forks","keys_url":"https://api.github.com/repos/kenji0919/pirodx_manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kenji0919/pirodx_manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kenji0919/pirodx_manager/teams","hooks_url":"https://api.github.com/repos/kenji0919/pirodx_manager/hooks","issue_events_url":"https://api.github.com/repos/kenji0919/pirodx_manager/issues/events{/number}","events_url":"https://api.github.com/repos/kenji0919/pirodx_manager/events","assignees_url":"https://api.github.com/repos/kenji0919/pirodx_manager/assignees{/user}","branches_url":"https://api.github.com/repos/kenji0919/pirodx_manager/branches{/branch}","tags_url":"https://api.github.com/repos/kenji0919/pirodx_manager/tags","blobs_url":"https://api.github.com/repos/kenji0919/pirodx_manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kenji0919/pirodx_manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kenji0919/pirodx_manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/kenji0919/pirodx_manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kenji0919/pirodx_manager/statuses/{sha}","languages_url":"https://api.github.com/repos/kenji0919/pirodx_manager/languages","stargazers_url":"https://api.github.com/repos/kenji0919/pirodx_manager/stargazers","contributors_url":"https://api.github.com/repos/kenji0919/pirodx_manager/contributors","subscribers_url":"https://api.github.com/repos/kenji0919/pirodx_manager/subscribers","subscription_url":"https://api.github.com/repos/kenji0919/pirodx_manager/subscription","commits_url":"https://api.github.com/repos/kenji0919/pirodx_manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/kenji0919/pirodx_manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/kenji0919/pirodx_manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/kenji0919/pirodx_manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/kenji0919/pirodx_manager/contents/{+path}","compare_url":"https://api.github.com/repos/kenji0919/pirodx_manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kenji0919/pirodx_manager/merges","archive_url":"https://api.github.com/repos/kenji0919/pirodx_manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kenji0919/pirodx_manager/downloads","issues_url":"https://api.github.com/repos/kenji0919/pirodx_manager/issues{/number}","pulls_url":"https://api.github.com/repos/kenji0919/pirodx_manager/pulls{/number}","milestones_url":"https://api.github.com/repos/kenji0919/pirodx_manager/milestones{/number}","notifications_url":"https://api.github.com/repos/kenji0919/pirodx_manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kenji0919/pirodx_manager/labels{/name}","releases_url":"https://api.github.com/repos/kenji0919/pirodx_manager/releases{/id}","created_at":"2014-12-16T14:14:58Z","updated_at":"2015-03-22T15:01:56Z","pushed_at":"2015-03-24T15:32:20Z","git_url":"git://github.com/kenji0919/pirodx_manager.git","ssh_url":"git@github.com:kenji0919/pirodx_manager.git","clone_url":"https://github.com/kenji0919/pirodx_manager.git","svn_url":"https://github.com/kenji0919/pirodx_manager","homepage":null,"size":5557,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kenji0919/pirodx_manager/pulls/137"},"html":{"href":"https://github.com/kenji0919/pirodx_manager/pull/137"},"issue":{"href":"https://api.github.com/repos/kenji0919/pirodx_manager/issues/137"},"comments":{"href":"https://api.github.com/repos/kenji0919/pirodx_manager/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/kenji0919/pirodx_manager/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/kenji0919/pirodx_manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kenji0919/pirodx_manager/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/kenji0919/pirodx_manager/statuses/8af038f906a9453fd7e5ceb00e7d797f037a694f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":38,"deletions":8,"changed_files":4}}