{"action":"closed","number":1786,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/1786","id":38802029,"html_url":"https://github.com/facebook/react-native/pull/1786","diff_url":"https://github.com/facebook/react-native/pull/1786.diff","patch_url":"https://github.com/facebook/react-native/pull/1786.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/1786","number":1786,"state":"closed","locked":false,"title":"Allow horizontal ListView. Rename height -> size","user":{"login":"mrspeaker","id":129330,"avatar_url":"https://avatars.githubusercontent.com/u/129330?v=3","gravatar_id":"","url":"https://api.github.com/users/mrspeaker","html_url":"https://github.com/mrspeaker","followers_url":"https://api.github.com/users/mrspeaker/followers","following_url":"https://api.github.com/users/mrspeaker/following{/other_user}","gists_url":"https://api.github.com/users/mrspeaker/gists{/gist_id}","starred_url":"https://api.github.com/users/mrspeaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrspeaker/subscriptions","organizations_url":"https://api.github.com/users/mrspeaker/orgs","repos_url":"https://api.github.com/users/mrspeaker/repos","events_url":"https://api.github.com/users/mrspeaker/events{/privacy}","received_events_url":"https://api.github.com/users/mrspeaker/received_events","type":"User","site_admin":false},"body":"Infinite scrolling in horizontal ListViews. Rather than just using height and Y offset to determine when to load more rows, it checks `props.horizontal` and switches between width/height and offset X/Y accordingly.\r\n\r\nThis changed required some renaming. However, the only change external to `ListView.js` is exporting `contentSize` instead of `contentHeight` from the `getMetrics()` function. (This is not part of the API, but is used \"for perf investigations or analytics\" and isn't reference in the repo).\r\n\r\nI believe this change works as expected (and the xcode tests pass) though it's possible that there may more complexity in this issue that I have overlooked.","created_at":"2015-06-29T18:21:32Z","updated_at":"2015-07-17T12:26:50Z","closed_at":"2015-07-17T12:26:50Z","merged_at":null,"merge_commit_sha":"0ec7f717da8ef3dbbeb70af248720f74342645b1","assignee":{"login":"sahrens","id":1509831,"avatar_url":"https://avatars.githubusercontent.com/u/1509831?v=3","gravatar_id":"","url":"https://api.github.com/users/sahrens","html_url":"https://github.com/sahrens","followers_url":"https://api.github.com/users/sahrens/followers","following_url":"https://api.github.com/users/sahrens/following{/other_user}","gists_url":"https://api.github.com/users/sahrens/gists{/gist_id}","starred_url":"https://api.github.com/users/sahrens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sahrens/subscriptions","organizations_url":"https://api.github.com/users/sahrens/orgs","repos_url":"https://api.github.com/users/sahrens/repos","events_url":"https://api.github.com/users/sahrens/events{/privacy}","received_events_url":"https://api.github.com/users/sahrens/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/1786/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/1786/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/1786/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/17f61e29d698c732f9767046cf2216a23d52694b","head":{"label":"mrspeaker:topic/horizontalListView","ref":"topic/horizontalListView","sha":"17f61e29d698c732f9767046cf2216a23d52694b","user":{"login":"mrspeaker","id":129330,"avatar_url":"https://avatars.githubusercontent.com/u/129330?v=3","gravatar_id":"","url":"https://api.github.com/users/mrspeaker","html_url":"https://github.com/mrspeaker","followers_url":"https://api.github.com/users/mrspeaker/followers","following_url":"https://api.github.com/users/mrspeaker/following{/other_user}","gists_url":"https://api.github.com/users/mrspeaker/gists{/gist_id}","starred_url":"https://api.github.com/users/mrspeaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrspeaker/subscriptions","organizations_url":"https://api.github.com/users/mrspeaker/orgs","repos_url":"https://api.github.com/users/mrspeaker/repos","events_url":"https://api.github.com/users/mrspeaker/events{/privacy}","received_events_url":"https://api.github.com/users/mrspeaker/received_events","type":"User","site_admin":false},"repo":{"id":37367089,"name":"react-native","full_name":"mrspeaker/react-native","owner":{"login":"mrspeaker","id":129330,"avatar_url":"https://avatars.githubusercontent.com/u/129330?v=3","gravatar_id":"","url":"https://api.github.com/users/mrspeaker","html_url":"https://github.com/mrspeaker","followers_url":"https://api.github.com/users/mrspeaker/followers","following_url":"https://api.github.com/users/mrspeaker/following{/other_user}","gists_url":"https://api.github.com/users/mrspeaker/gists{/gist_id}","starred_url":"https://api.github.com/users/mrspeaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrspeaker/subscriptions","organizations_url":"https://api.github.com/users/mrspeaker/orgs","repos_url":"https://api.github.com/users/mrspeaker/repos","events_url":"https://api.github.com/users/mrspeaker/events{/privacy}","received_events_url":"https://api.github.com/users/mrspeaker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrspeaker/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/mrspeaker/react-native","forks_url":"https://api.github.com/repos/mrspeaker/react-native/forks","keys_url":"https://api.github.com/repos/mrspeaker/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrspeaker/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrspeaker/react-native/teams","hooks_url":"https://api.github.com/repos/mrspeaker/react-native/hooks","issue_events_url":"https://api.github.com/repos/mrspeaker/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/mrspeaker/react-native/events","assignees_url":"https://api.github.com/repos/mrspeaker/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/mrspeaker/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/mrspeaker/react-native/tags","blobs_url":"https://api.github.com/repos/mrspeaker/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrspeaker/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrspeaker/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrspeaker/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrspeaker/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/mrspeaker/react-native/languages","stargazers_url":"https://api.github.com/repos/mrspeaker/react-native/stargazers","contributors_url":"https://api.github.com/repos/mrspeaker/react-native/contributors","subscribers_url":"https://api.github.com/repos/mrspeaker/react-native/subscribers","subscription_url":"https://api.github.com/repos/mrspeaker/react-native/subscription","commits_url":"https://api.github.com/repos/mrspeaker/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrspeaker/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrspeaker/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrspeaker/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrspeaker/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/mrspeaker/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrspeaker/react-native/merges","archive_url":"https://api.github.com/repos/mrspeaker/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrspeaker/react-native/downloads","issues_url":"https://api.github.com/repos/mrspeaker/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/mrspeaker/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/mrspeaker/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/mrspeaker/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrspeaker/react-native/labels{/name}","releases_url":"https://api.github.com/repos/mrspeaker/react-native/releases{/id}","created_at":"2015-06-13T10:18:17Z","updated_at":"2015-06-13T10:18:19Z","pushed_at":"2015-07-16T21:34:51Z","git_url":"git://github.com/mrspeaker/react-native.git","ssh_url":"git@github.com:mrspeaker/react-native.git","clone_url":"https://github.com/mrspeaker/react-native.git","svn_url":"https://github.com/mrspeaker/react-native","homepage":"http://facebook.github.io/react-native/","size":20843,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"fe9af98a2867475f5d4af9bbe49ce0ed0a7b1d08","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","created_at":"2015-01-09T18:10:16Z","updated_at":"2015-07-17T12:10:13Z","pushed_at":"2015-07-17T12:26:44Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":53536,"stargazers_count":15823,"watchers_count":15823,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1987,"mirror_url":null,"open_issues_count":453,"forks":1987,"open_issues":453,"watchers":15823,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/1786"},"html":{"href":"https://github.com/facebook/react-native/pull/1786"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/1786"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/1786/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/1786/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/1786/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/17f61e29d698c732f9767046cf2216a23d52694b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":27,"deletions":25,"changed_files":1}}