{"action":"created","comment":{"url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/comments/24316837","id":24316837,"diff_hunk":"@@ -345,25 +380,31 @@ extern \"C\" {\n     pub fn EVP_aes_128_ecb() -> *const EVP_CIPHER;\n     #[cfg(feature = \"aes_xts\")]\n     pub fn EVP_aes_128_xts() -> *const EVP_CIPHER;\n-    // fn EVP_aes_128_ctr() -> EVP_CIPHER;\n-    // fn EVP_aes_128_gcm() -> EVP_CIPHER;\n+    pub fn EVP_aes_128_ctr() -> *const EVP_CIPHER;","path":"openssl-sys/src/lib.rs","position":48,"original_position":48,"commit_id":"6e263a51f4cebd3f671228e78aaf480f55ee45b8","original_commit_id":"6e263a51f4cebd3f671228e78aaf480f55ee45b8","user":{"login":"gkoz","id":4260361,"avatar_url":"https://avatars.githubusercontent.com/u/4260361?v=3","gravatar_id":"","url":"https://api.github.com/users/gkoz","html_url":"https://github.com/gkoz","followers_url":"https://api.github.com/users/gkoz/followers","following_url":"https://api.github.com/users/gkoz/following{/other_user}","gists_url":"https://api.github.com/users/gkoz/gists{/gist_id}","starred_url":"https://api.github.com/users/gkoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkoz/subscriptions","organizations_url":"https://api.github.com/users/gkoz/orgs","repos_url":"https://api.github.com/users/gkoz/repos","events_url":"https://api.github.com/users/gkoz/events{/privacy}","received_events_url":"https://api.github.com/users/gkoz/received_events","type":"User","site_admin":false},"body":"Should each feature be gated individually or would it make sense for them to be branch based or even just \"modern_openssl\" for stuff not present in OpenSSL 0.x? There isn't a build-time feature detection phase anyway, is there?\r\nSpeaking of versions, would you mind putting an official statement in the Readme as to which OpenSSL versions or branches the bindings are expected to support?","created_at":"2015-02-09T09:40:35Z","updated_at":"2015-02-09T09:40:35Z","html_url":"https://github.com/sfackler/rust-openssl/pull/154#discussion_r24316837","pull_request_url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/154","_links":{"self":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/comments/24316837"},"html":{"href":"https://github.com/sfackler/rust-openssl/pull/154#discussion_r24316837"},"pull_request":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/154"}}},"pull_request":{"url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/154","id":28655957,"html_url":"https://github.com/sfackler/rust-openssl/pull/154","diff_url":"https://github.com/sfackler/rust-openssl/pull/154.diff","patch_url":"https://github.com/sfackler/rust-openssl/pull/154.patch","issue_url":"https://api.github.com/repos/sfackler/rust-openssl/issues/154","number":154,"state":"open","locked":false,"title":"crypto::symm rewrite","user":{"login":"gkoz","id":4260361,"avatar_url":"https://avatars.githubusercontent.com/u/4260361?v=3","gravatar_id":"","url":"https://api.github.com/users/gkoz","html_url":"https://github.com/gkoz","followers_url":"https://api.github.com/users/gkoz/followers","following_url":"https://api.github.com/users/gkoz/following{/other_user}","gists_url":"https://api.github.com/users/gkoz/gists{/gist_id}","starred_url":"https://api.github.com/users/gkoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkoz/subscriptions","organizations_url":"https://api.github.com/users/gkoz/orgs","repos_url":"https://api.github.com/users/gkoz/repos","events_url":"https://api.github.com/users/gkoz/events{/privacy}","received_events_url":"https://api.github.com/users/gkoz/received_events","type":"User","site_admin":false},"body":"This is a prototype `symm` module rewrite that takes some inspiration from `hash` refactoring.\r\nIt's difficult to come up with a clean general API because each mode's API is slightly incompatible with every other one.\r\nThis version provides a `Writer` adapter for composability and an `apply` method that writes to `&mut [u8]`.\r\nBecause the static check model I tried out with `hash` and `hmac` wasn't settled on, call order requirements are checked dynamically and panic in case of errors.\r\nPadding/alignment and authentication errors are handled with `Result`s, more \"impossible\" errors are checked with asserts.","created_at":"2015-02-04T17:10:32Z","updated_at":"2015-02-09T09:40:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a530408679f8b7371b0835ccc45d0f6a707d95a0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/154/commits","review_comments_url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/154/comments","review_comment_url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sfackler/rust-openssl/issues/154/comments","statuses_url":"https://api.github.com/repos/sfackler/rust-openssl/statuses/6e263a51f4cebd3f671228e78aaf480f55ee45b8","head":{"label":"gkoz:symm_new","ref":"symm_new","sha":"6e263a51f4cebd3f671228e78aaf480f55ee45b8","user":{"login":"gkoz","id":4260361,"avatar_url":"https://avatars.githubusercontent.com/u/4260361?v=3","gravatar_id":"","url":"https://api.github.com/users/gkoz","html_url":"https://github.com/gkoz","followers_url":"https://api.github.com/users/gkoz/followers","following_url":"https://api.github.com/users/gkoz/following{/other_user}","gists_url":"https://api.github.com/users/gkoz/gists{/gist_id}","starred_url":"https://api.github.com/users/gkoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkoz/subscriptions","organizations_url":"https://api.github.com/users/gkoz/orgs","repos_url":"https://api.github.com/users/gkoz/repos","events_url":"https://api.github.com/users/gkoz/events{/privacy}","received_events_url":"https://api.github.com/users/gkoz/received_events","type":"User","site_admin":false},"repo":{"id":26825953,"name":"rust-openssl","full_name":"gkoz/rust-openssl","owner":{"login":"gkoz","id":4260361,"avatar_url":"https://avatars.githubusercontent.com/u/4260361?v=3","gravatar_id":"","url":"https://api.github.com/users/gkoz","html_url":"https://github.com/gkoz","followers_url":"https://api.github.com/users/gkoz/followers","following_url":"https://api.github.com/users/gkoz/following{/other_user}","gists_url":"https://api.github.com/users/gkoz/gists{/gist_id}","starred_url":"https://api.github.com/users/gkoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkoz/subscriptions","organizations_url":"https://api.github.com/users/gkoz/orgs","repos_url":"https://api.github.com/users/gkoz/repos","events_url":"https://api.github.com/users/gkoz/events{/privacy}","received_events_url":"https://api.github.com/users/gkoz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gkoz/rust-openssl","description":"OpenSSL bindings for Rust","fork":true,"url":"https://api.github.com/repos/gkoz/rust-openssl","forks_url":"https://api.github.com/repos/gkoz/rust-openssl/forks","keys_url":"https://api.github.com/repos/gkoz/rust-openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gkoz/rust-openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gkoz/rust-openssl/teams","hooks_url":"https://api.github.com/repos/gkoz/rust-openssl/hooks","issue_events_url":"https://api.github.com/repos/gkoz/rust-openssl/issues/events{/number}","events_url":"https://api.github.com/repos/gkoz/rust-openssl/events","assignees_url":"https://api.github.com/repos/gkoz/rust-openssl/assignees{/user}","branches_url":"https://api.github.com/repos/gkoz/rust-openssl/branches{/branch}","tags_url":"https://api.github.com/repos/gkoz/rust-openssl/tags","blobs_url":"https://api.github.com/repos/gkoz/rust-openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gkoz/rust-openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gkoz/rust-openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/gkoz/rust-openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gkoz/rust-openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/gkoz/rust-openssl/languages","stargazers_url":"https://api.github.com/repos/gkoz/rust-openssl/stargazers","contributors_url":"https://api.github.com/repos/gkoz/rust-openssl/contributors","subscribers_url":"https://api.github.com/repos/gkoz/rust-openssl/subscribers","subscription_url":"https://api.github.com/repos/gkoz/rust-openssl/subscription","commits_url":"https://api.github.com/repos/gkoz/rust-openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/gkoz/rust-openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/gkoz/rust-openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/gkoz/rust-openssl/issues/comments/{number}","contents_url":"https://api.github.com/repos/gkoz/rust-openssl/contents/{+path}","compare_url":"https://api.github.com/repos/gkoz/rust-openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gkoz/rust-openssl/merges","archive_url":"https://api.github.com/repos/gkoz/rust-openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gkoz/rust-openssl/downloads","issues_url":"https://api.github.com/repos/gkoz/rust-openssl/issues{/number}","pulls_url":"https://api.github.com/repos/gkoz/rust-openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/gkoz/rust-openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/gkoz/rust-openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gkoz/rust-openssl/labels{/name}","releases_url":"https://api.github.com/repos/gkoz/rust-openssl/releases{/id}","created_at":"2014-11-18T19:24:12Z","updated_at":"2015-02-06T16:05:06Z","pushed_at":"2015-02-08T10:10:30Z","git_url":"git://github.com/gkoz/rust-openssl.git","ssh_url":"git@github.com:gkoz/rust-openssl.git","clone_url":"https://github.com/gkoz/rust-openssl.git","svn_url":"https://github.com/gkoz/rust-openssl","homepage":"","size":1008,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sfackler:master","ref":"master","sha":"ad476f25c7d9474ab7698c06481e7bb7536dfdfd","user":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"repo":{"id":15500883,"name":"rust-openssl","full_name":"sfackler/rust-openssl","owner":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sfackler/rust-openssl","description":"OpenSSL bindings for Rust","fork":false,"url":"https://api.github.com/repos/sfackler/rust-openssl","forks_url":"https://api.github.com/repos/sfackler/rust-openssl/forks","keys_url":"https://api.github.com/repos/sfackler/rust-openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sfackler/rust-openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sfackler/rust-openssl/teams","hooks_url":"https://api.github.com/repos/sfackler/rust-openssl/hooks","issue_events_url":"https://api.github.com/repos/sfackler/rust-openssl/issues/events{/number}","events_url":"https://api.github.com/repos/sfackler/rust-openssl/events","assignees_url":"https://api.github.com/repos/sfackler/rust-openssl/assignees{/user}","branches_url":"https://api.github.com/repos/sfackler/rust-openssl/branches{/branch}","tags_url":"https://api.github.com/repos/sfackler/rust-openssl/tags","blobs_url":"https://api.github.com/repos/sfackler/rust-openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sfackler/rust-openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sfackler/rust-openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/sfackler/rust-openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sfackler/rust-openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/sfackler/rust-openssl/languages","stargazers_url":"https://api.github.com/repos/sfackler/rust-openssl/stargazers","contributors_url":"https://api.github.com/repos/sfackler/rust-openssl/contributors","subscribers_url":"https://api.github.com/repos/sfackler/rust-openssl/subscribers","subscription_url":"https://api.github.com/repos/sfackler/rust-openssl/subscription","commits_url":"https://api.github.com/repos/sfackler/rust-openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/sfackler/rust-openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/sfackler/rust-openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/sfackler/rust-openssl/issues/comments/{number}","contents_url":"https://api.github.com/repos/sfackler/rust-openssl/contents/{+path}","compare_url":"https://api.github.com/repos/sfackler/rust-openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sfackler/rust-openssl/merges","archive_url":"https://api.github.com/repos/sfackler/rust-openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sfackler/rust-openssl/downloads","issues_url":"https://api.github.com/repos/sfackler/rust-openssl/issues{/number}","pulls_url":"https://api.github.com/repos/sfackler/rust-openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/sfackler/rust-openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/sfackler/rust-openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sfackler/rust-openssl/labels{/name}","releases_url":"https://api.github.com/repos/sfackler/rust-openssl/releases{/id}","created_at":"2013-12-28T23:56:50Z","updated_at":"2015-02-09T08:06:00Z","pushed_at":"2015-02-09T08:05:59Z","git_url":"git://github.com/sfackler/rust-openssl.git","ssh_url":"git@github.com:sfackler/rust-openssl.git","clone_url":"https://github.com/sfackler/rust-openssl.git","svn_url":"https://github.com/sfackler/rust-openssl","homepage":"","size":2270,"stargazers_count":62,"watchers_count":62,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":56,"mirror_url":null,"open_issues_count":13,"forks":56,"open_issues":13,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/154"},"html":{"href":"https://github.com/sfackler/rust-openssl/pull/154"},"issue":{"href":"https://api.github.com/repos/sfackler/rust-openssl/issues/154"},"comments":{"href":"https://api.github.com/repos/sfackler/rust-openssl/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/sfackler/rust-openssl/statuses/6e263a51f4cebd3f671228e78aaf480f55ee45b8"}}}}