{"action":"created","comment":{"url":"https://api.github.com/repos/pyugrid/pyugrid/pulls/comments/43422767","id":43422767,"diff_hunk":"@@ -1,27 +1,57 @@\n-sudo: false\n language: python\n \n env:\n-    - CONDA=\"python=2.7\"\n-    - CONDA=\"python=3.3\"\n-    - CONDA=\"python=3.4\"\n+  - CONDA_PYTHON_VERSION=\"2\"\n+  - CONDA_PYTHON_VERSION=\"3\"","path":".travis.yml","position":9,"original_position":9,"commit_id":"259ad633d22180aeb050f71186562da16f9cc818","original_commit_id":"b8e55f890a4d1e1dc0be0dba964056305810b58e","user":{"login":"ocefpaf","id":950575,"avatar_url":"https://avatars.githubusercontent.com/u/950575?v=3","gravatar_id":"","url":"https://api.github.com/users/ocefpaf","html_url":"https://github.com/ocefpaf","followers_url":"https://api.github.com/users/ocefpaf/followers","following_url":"https://api.github.com/users/ocefpaf/following{/other_user}","gists_url":"https://api.github.com/users/ocefpaf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocefpaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocefpaf/subscriptions","organizations_url":"https://api.github.com/users/ocefpaf/orgs","repos_url":"https://api.github.com/users/ocefpaf/repos","events_url":"https://api.github.com/users/ocefpaf/events{/privacy}","received_events_url":"https://api.github.com/users/ocefpaf/received_events","type":"User","site_admin":false},"body":"My comment regarding the python versions where direct at this:\r\n\r\n>  the original configuration file did not seem to be testing all the Python versions. \r\n\r\n> https://travis-ci.org/NESII/pyugrid/jobs/87780816#L409. Does that make sense?\r\n\r\nYou need to check if all the run and build dependencies exists for the python version you are testing against.   Since the current version of pyugrid installs just fine for 3.4 my guess is that you are missing a new dependency introduced by this PR.\r\n\r\n> That's a nice example! \r\n\r\nIndeed.\r\n\r\n> Are they testing Python 3?\r\n\r\nNo.  The point of the example is to show how to separate the context of testing (build test /code test), which I am still :-1: BTW.\r\n\r\n>  It looks like they are also installing miniconda in a similar way to the in-question \r\n\r\nThey do because their tests are very long and downloading the \"right\" version of miniconda makes it faster.  That only works because they test against 2.7 only (and maybe in the future 2.7 and 3.4).  However, when testing against several python versions, like we do, that advantage is lost.  We still need to create ENVs for all those python versions.   So a simpler travis that downloads only version of minconda is cleaner and better.","created_at":"2015-10-29T18:09:52Z","updated_at":"2015-10-29T18:09:52Z","html_url":"https://github.com/pyugrid/pyugrid/pull/98#discussion_r43422767","pull_request_url":"https://api.github.com/repos/pyugrid/pyugrid/pulls/98","_links":{"self":{"href":"https://api.github.com/repos/pyugrid/pyugrid/pulls/comments/43422767"},"html":{"href":"https://github.com/pyugrid/pyugrid/pull/98#discussion_r43422767"},"pull_request":{"href":"https://api.github.com/repos/pyugrid/pyugrid/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/pyugrid/pyugrid/pulls/98","id":46333510,"html_url":"https://github.com/pyugrid/pyugrid/pull/98","diff_url":"https://github.com/pyugrid/pyugrid/pull/98.diff","patch_url":"https://github.com/pyugrid/pyugrid/pull/98.patch","issue_url":"https://api.github.com/repos/pyugrid/pyugrid/issues/98","number":98,"state":"open","locked":false,"title":"adding 2D flexible mesh conversion","user":{"login":"bekozi","id":636921,"avatar_url":"https://avatars.githubusercontent.com/u/636921?v=3","gravatar_id":"","url":"https://api.github.com/users/bekozi","html_url":"https://github.com/bekozi","followers_url":"https://api.github.com/users/bekozi/followers","following_url":"https://api.github.com/users/bekozi/following{/other_user}","gists_url":"https://api.github.com/users/bekozi/gists{/gist_id}","starred_url":"https://api.github.com/users/bekozi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bekozi/subscriptions","organizations_url":"https://api.github.com/users/bekozi/orgs","repos_url":"https://api.github.com/users/bekozi/repos","events_url":"https://api.github.com/users/bekozi/events{/privacy}","received_events_url":"https://api.github.com/users/bekozi/received_events","type":"User","site_admin":false},"body":"Adds flexible mesh object following UGRID specification (http://bit.ly/1UJwyrI). Minimal changes were required to the UGrid codebase. I will add GitHub comments for the more controversial (perhaps) changes. I'm sure there is still work to be done!\r\n\r\nBrief summary:\r\n * Shapely, Fiona, and rtree are required for shapefile IO.\r\n * Mpi4py is entirely optional. MPI is only used when reading from shapefile.\r\n * Conda recipe updated to reflect new dependencies.\r\n * Travis configuration updated to use conda build with support for Python 3 (which fails).\r\n  * Test with and without MPI.\r\n  * Test with and without optional dependencies.\r\n * Shapefile reading/writing only on flexible mesh object. Other UGrid objects could use this code as it is sufficiently general.\r\n * All tests are passing.\r\n * Two tests marked as \"slow\". To avoid running them:\r\n \r\n ```sh\r\n py.test -m 'not slow'\r\n ```\r\n \r\n * Flexible mesh tests placed in test/test_flexible_mesh.\r\n\r\nNot in this PR:\r\n * No RST or README documentation changes.\r\n * No data compression.","created_at":"2015-09-29T21:19:47Z","updated_at":"2015-10-29T18:09:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c38fc3b7079d060d44c43302acdd888e80bd3394","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pyugrid/pyugrid/pulls/98/commits","review_comments_url":"https://api.github.com/repos/pyugrid/pyugrid/pulls/98/comments","review_comment_url":"https://api.github.com/repos/pyugrid/pyugrid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pyugrid/pyugrid/issues/98/comments","statuses_url":"https://api.github.com/repos/pyugrid/pyugrid/statuses/259ad633d22180aeb050f71186562da16f9cc818","head":{"label":"NESII:i96-flexible-mesh","ref":"i96-flexible-mesh","sha":"259ad633d22180aeb050f71186562da16f9cc818","user":{"login":"NESII","id":10067813,"avatar_url":"https://avatars.githubusercontent.com/u/10067813?v=3","gravatar_id":"","url":"https://api.github.com/users/NESII","html_url":"https://github.com/NESII","followers_url":"https://api.github.com/users/NESII/followers","following_url":"https://api.github.com/users/NESII/following{/other_user}","gists_url":"https://api.github.com/users/NESII/gists{/gist_id}","starred_url":"https://api.github.com/users/NESII/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NESII/subscriptions","organizations_url":"https://api.github.com/users/NESII/orgs","repos_url":"https://api.github.com/users/NESII/repos","events_url":"https://api.github.com/users/NESII/events{/privacy}","received_events_url":"https://api.github.com/users/NESII/received_events","type":"Organization","site_admin":false},"repo":{"id":42538740,"name":"pyugrid","full_name":"NESII/pyugrid","owner":{"login":"NESII","id":10067813,"avatar_url":"https://avatars.githubusercontent.com/u/10067813?v=3","gravatar_id":"","url":"https://api.github.com/users/NESII","html_url":"https://github.com/NESII","followers_url":"https://api.github.com/users/NESII/followers","following_url":"https://api.github.com/users/NESII/following{/other_user}","gists_url":"https://api.github.com/users/NESII/gists{/gist_id}","starred_url":"https://api.github.com/users/NESII/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NESII/subscriptions","organizations_url":"https://api.github.com/users/NESII/orgs","repos_url":"https://api.github.com/users/NESII/repos","events_url":"https://api.github.com/users/NESII/events{/privacy}","received_events_url":"https://api.github.com/users/NESII/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NESII/pyugrid","description":"Handle UGRID-convention NetCDF","fork":true,"url":"https://api.github.com/repos/NESII/pyugrid","forks_url":"https://api.github.com/repos/NESII/pyugrid/forks","keys_url":"https://api.github.com/repos/NESII/pyugrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NESII/pyugrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NESII/pyugrid/teams","hooks_url":"https://api.github.com/repos/NESII/pyugrid/hooks","issue_events_url":"https://api.github.com/repos/NESII/pyugrid/issues/events{/number}","events_url":"https://api.github.com/repos/NESII/pyugrid/events","assignees_url":"https://api.github.com/repos/NESII/pyugrid/assignees{/user}","branches_url":"https://api.github.com/repos/NESII/pyugrid/branches{/branch}","tags_url":"https://api.github.com/repos/NESII/pyugrid/tags","blobs_url":"https://api.github.com/repos/NESII/pyugrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NESII/pyugrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NESII/pyugrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/NESII/pyugrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NESII/pyugrid/statuses/{sha}","languages_url":"https://api.github.com/repos/NESII/pyugrid/languages","stargazers_url":"https://api.github.com/repos/NESII/pyugrid/stargazers","contributors_url":"https://api.github.com/repos/NESII/pyugrid/contributors","subscribers_url":"https://api.github.com/repos/NESII/pyugrid/subscribers","subscription_url":"https://api.github.com/repos/NESII/pyugrid/subscription","commits_url":"https://api.github.com/repos/NESII/pyugrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/NESII/pyugrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/NESII/pyugrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/NESII/pyugrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/NESII/pyugrid/contents/{+path}","compare_url":"https://api.github.com/repos/NESII/pyugrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NESII/pyugrid/merges","archive_url":"https://api.github.com/repos/NESII/pyugrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NESII/pyugrid/downloads","issues_url":"https://api.github.com/repos/NESII/pyugrid/issues{/number}","pulls_url":"https://api.github.com/repos/NESII/pyugrid/pulls{/number}","milestones_url":"https://api.github.com/repos/NESII/pyugrid/milestones{/number}","notifications_url":"https://api.github.com/repos/NESII/pyugrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NESII/pyugrid/labels{/name}","releases_url":"https://api.github.com/repos/NESII/pyugrid/releases{/id}","created_at":"2015-09-15T18:34:27Z","updated_at":"2015-09-15T18:34:27Z","pushed_at":"2015-10-29T17:27:13Z","git_url":"git://github.com/NESII/pyugrid.git","ssh_url":"git@github.com:NESII/pyugrid.git","clone_url":"https://github.com/NESII/pyugrid.git","svn_url":"https://github.com/NESII/pyugrid","homepage":"http://pyugrid.github.io/pyugrid","size":1417,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pyugrid:master","ref":"master","sha":"8dab25c5310a7677d4d43a38ee441889cdfc66fc","user":{"login":"pyugrid","id":4869809,"avatar_url":"https://avatars.githubusercontent.com/u/4869809?v=3","gravatar_id":"","url":"https://api.github.com/users/pyugrid","html_url":"https://github.com/pyugrid","followers_url":"https://api.github.com/users/pyugrid/followers","following_url":"https://api.github.com/users/pyugrid/following{/other_user}","gists_url":"https://api.github.com/users/pyugrid/gists{/gist_id}","starred_url":"https://api.github.com/users/pyugrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyugrid/subscriptions","organizations_url":"https://api.github.com/users/pyugrid/orgs","repos_url":"https://api.github.com/users/pyugrid/repos","events_url":"https://api.github.com/users/pyugrid/events{/privacy}","received_events_url":"https://api.github.com/users/pyugrid/received_events","type":"Organization","site_admin":false},"repo":{"id":11030918,"name":"pyugrid","full_name":"pyugrid/pyugrid","owner":{"login":"pyugrid","id":4869809,"avatar_url":"https://avatars.githubusercontent.com/u/4869809?v=3","gravatar_id":"","url":"https://api.github.com/users/pyugrid","html_url":"https://github.com/pyugrid","followers_url":"https://api.github.com/users/pyugrid/followers","following_url":"https://api.github.com/users/pyugrid/following{/other_user}","gists_url":"https://api.github.com/users/pyugrid/gists{/gist_id}","starred_url":"https://api.github.com/users/pyugrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyugrid/subscriptions","organizations_url":"https://api.github.com/users/pyugrid/orgs","repos_url":"https://api.github.com/users/pyugrid/repos","events_url":"https://api.github.com/users/pyugrid/events{/privacy}","received_events_url":"https://api.github.com/users/pyugrid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pyugrid/pyugrid","description":"Handle UGRID-convention NetCDF","fork":false,"url":"https://api.github.com/repos/pyugrid/pyugrid","forks_url":"https://api.github.com/repos/pyugrid/pyugrid/forks","keys_url":"https://api.github.com/repos/pyugrid/pyugrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyugrid/pyugrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyugrid/pyugrid/teams","hooks_url":"https://api.github.com/repos/pyugrid/pyugrid/hooks","issue_events_url":"https://api.github.com/repos/pyugrid/pyugrid/issues/events{/number}","events_url":"https://api.github.com/repos/pyugrid/pyugrid/events","assignees_url":"https://api.github.com/repos/pyugrid/pyugrid/assignees{/user}","branches_url":"https://api.github.com/repos/pyugrid/pyugrid/branches{/branch}","tags_url":"https://api.github.com/repos/pyugrid/pyugrid/tags","blobs_url":"https://api.github.com/repos/pyugrid/pyugrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyugrid/pyugrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyugrid/pyugrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyugrid/pyugrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyugrid/pyugrid/statuses/{sha}","languages_url":"https://api.github.com/repos/pyugrid/pyugrid/languages","stargazers_url":"https://api.github.com/repos/pyugrid/pyugrid/stargazers","contributors_url":"https://api.github.com/repos/pyugrid/pyugrid/contributors","subscribers_url":"https://api.github.com/repos/pyugrid/pyugrid/subscribers","subscription_url":"https://api.github.com/repos/pyugrid/pyugrid/subscription","commits_url":"https://api.github.com/repos/pyugrid/pyugrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyugrid/pyugrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyugrid/pyugrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyugrid/pyugrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyugrid/pyugrid/contents/{+path}","compare_url":"https://api.github.com/repos/pyugrid/pyugrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyugrid/pyugrid/merges","archive_url":"https://api.github.com/repos/pyugrid/pyugrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyugrid/pyugrid/downloads","issues_url":"https://api.github.com/repos/pyugrid/pyugrid/issues{/number}","pulls_url":"https://api.github.com/repos/pyugrid/pyugrid/pulls{/number}","milestones_url":"https://api.github.com/repos/pyugrid/pyugrid/milestones{/number}","notifications_url":"https://api.github.com/repos/pyugrid/pyugrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyugrid/pyugrid/labels{/name}","releases_url":"https://api.github.com/repos/pyugrid/pyugrid/releases{/id}","created_at":"2013-06-28T16:03:42Z","updated_at":"2015-10-29T16:09:15Z","pushed_at":"2015-10-29T17:26:45Z","git_url":"git://github.com/pyugrid/pyugrid.git","ssh_url":"git@github.com:pyugrid/pyugrid.git","clone_url":"https://github.com/pyugrid/pyugrid.git","svn_url":"https://github.com/pyugrid/pyugrid","homepage":"http://pyugrid.github.io/pyugrid","size":2133,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"open_issues_count":46,"forks":22,"open_issues":46,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pyugrid/pyugrid/pulls/98"},"html":{"href":"https://github.com/pyugrid/pyugrid/pull/98"},"issue":{"href":"https://api.github.com/repos/pyugrid/pyugrid/issues/98"},"comments":{"href":"https://api.github.com/repos/pyugrid/pyugrid/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/pyugrid/pyugrid/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/pyugrid/pyugrid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pyugrid/pyugrid/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/pyugrid/pyugrid/statuses/259ad633d22180aeb050f71186562da16f9cc818"}}}}