{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13310","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13310/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13310/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13310/events","html_url":"https://github.com/kubernetes/kubernetes/pull/13310","id":103756771,"number":13310,"title":"Added VolumeConfig to volumes","user":{"login":"markturansky","id":8001968,"avatar_url":"https://avatars.githubusercontent.com/u/8001968?v=3","gravatar_id":"","url":"https://api.github.com/users/markturansky","html_url":"https://github.com/markturansky","followers_url":"https://api.github.com/users/markturansky/followers","following_url":"https://api.github.com/users/markturansky/following{/other_user}","gists_url":"https://api.github.com/users/markturansky/gists{/gist_id}","starred_url":"https://api.github.com/users/markturansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markturansky/subscriptions","organizations_url":"https://api.github.com/users/markturansky/orgs","repos_url":"https://api.github.com/users/markturansky/repos","events_url":"https://api.github.com/users/markturansky/events{/privacy}","received_events_url":"https://api.github.com/users/markturansky/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900"}],"state":"open","locked":false,"assignee":{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"milestone":null,"comments":15,"created_at":"2015-08-28T17:04:40Z","updated_at":"2015-09-02T03:48:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13310","html_url":"https://github.com/kubernetes/kubernetes/pull/13310","diff_url":"https://github.com/kubernetes/kubernetes/pull/13310.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/13310.patch"},"body":"High level design:\r\n\r\n1.  Only the binary knows what plugins are installed/compiled.  Limit all specific configuration (say, an NFS timeout) to the binary.  No leaking \"NFS\" (or other specific plugin terms) outside of the binary or the plugin.\r\n\r\n2.  top level VolumeConfigFlags in the binary contains *all* enumerated CLI flags related to volumes.  \r\n\r\n3.  plugins.go is where plugins are loaded.  VolumeConfigFlags is passed there and instances of volume.VolumeConfig are created and passed to each plugin, as appropriate.\r\n\r\nThis config idea will be easier to unit test in the follow-on PR that configures PV Recycling.  Each plugin can test it receives the necessary config that's handed down to Builders, Cleaners, and Recyclers.\r\n\r\n@kubernetes/rh-storage "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/136928553","html_url":"https://github.com/kubernetes/kubernetes/pull/13310#issuecomment-136928553","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13310","id":136928553,"user":{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"created_at":"2015-09-02T03:48:52Z","updated_at":"2015-09-02T03:48:52Z","body":"LGTM"}}