{"action":"created","issue":{"url":"https://api.github.com/repos/opencog/relex/issues/194","labels_url":"https://api.github.com/repos/opencog/relex/issues/194/labels{/name}","comments_url":"https://api.github.com/repos/opencog/relex/issues/194/comments","events_url":"https://api.github.com/repos/opencog/relex/issues/194/events","html_url":"https://github.com/opencog/relex/pull/194","id":50937823,"number":194,"title":"created missing predadj dependency for 'how adj' questions","user":{"login":"anitzkin","id":8509213,"avatar_url":"https://avatars.githubusercontent.com/u/8509213?v=3","gravatar_id":"","url":"https://api.github.com/users/anitzkin","html_url":"https://github.com/anitzkin","followers_url":"https://api.github.com/users/anitzkin/followers","following_url":"https://api.github.com/users/anitzkin/following{/other_user}","gists_url":"https://api.github.com/users/anitzkin/gists{/gist_id}","starred_url":"https://api.github.com/users/anitzkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anitzkin/subscriptions","organizations_url":"https://api.github.com/users/anitzkin/orgs","repos_url":"https://api.github.com/users/anitzkin/repos","events_url":"https://api.github.com/users/anitzkin/events{/privacy}","received_events_url":"https://api.github.com/users/anitzkin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":41,"created_at":"2014-12-04T07:50:47Z","updated_at":"2015-01-28T16:34:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opencog/relex/pulls/194","html_url":"https://github.com/opencog/relex/pull/194","diff_url":"https://github.com/opencog/relex/pull/194.diff","patch_url":"https://github.com/opencog/relex/pull/194.patch"},"body":"I found out that quesitons like \"How crazy are you?\" were not getting any _predadj dependency so I added one.  Except now, since they were getting a _subj() dependency, the SV-rule is firing twice, once for the _subj() and once for the _predadj() so I should correct that, although the redundancy isn't generating any incorrect relations, just redundancy."},"comment":{"url":"https://api.github.com/repos/opencog/relex/issues/comments/71867016","html_url":"https://github.com/opencog/relex/pull/194#issuecomment-71867016","issue_url":"https://api.github.com/repos/opencog/relex/issues/194","id":71867016,"user":{"login":"linas","id":94368,"avatar_url":"https://avatars.githubusercontent.com/u/94368?v=3","gravatar_id":"","url":"https://api.github.com/users/linas","html_url":"https://github.com/linas","followers_url":"https://api.github.com/users/linas/followers","following_url":"https://api.github.com/users/linas/following{/other_user}","gists_url":"https://api.github.com/users/linas/gists{/gist_id}","starred_url":"https://api.github.com/users/linas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linas/subscriptions","organizations_url":"https://api.github.com/users/linas/orgs","repos_url":"https://api.github.com/users/linas/repos","events_url":"https://api.github.com/users/linas/events{/privacy}","received_events_url":"https://api.github.com/users/linas/received_events","type":"User","site_admin":false},"created_at":"2015-01-28T16:34:55Z","updated_at":"2015-01-28T16:34:55Z","body":"OK, I'm going to merge this ... but I am really not happy about it. It is much too large a set of changes to review in one gulp.  It is essentially impossible for me to review what's going on here: its just one giant black box of stuff.   This is why I kept saying: merge early, merge often: it makes the changes small and reviewable for design and correctness.\r\n\r\nI saw a number of serious issues that must be fixed. I have to now trust you to fix them.  Do NOT do this ever again!  This is really bad form.\r\n\r\nSo: almost none of the added rules have any sort of example sentences illustrating the conditions under which they trigger.  This will make it hard for future maintainers to figure out what is going on.  \r\n\r\nMy eyes glazed over before I could get to the bottom of this, but:\r\n\r\nSome of the changes look weird -- adding head words to determiners? Why?  Modifying the words in the sentence?  Surely that cannot be right ... Based on this, I  suspect there are other issues in here, which is again .. a reason to make changes in much smaller, more manageable chunks.\r\n\r\n"}}