{"action":"closed","number":39,"pull_request":{"url":"https://api.github.com/repos/christophergregory/shopify-node-api/pulls/39","id":52589887,"html_url":"https://github.com/christophergregory/shopify-node-api/pull/39","diff_url":"https://github.com/christophergregory/shopify-node-api/pull/39.diff","patch_url":"https://github.com/christophergregory/shopify-node-api/pull/39.patch","issue_url":"https://api.github.com/repos/christophergregory/shopify-node-api/issues/39","number":39,"state":"closed","locked":false,"title":"Shopify.js updated to now verify the OAuth state parameter and nonce.","user":{"login":"frehner","id":3054066,"avatar_url":"https://avatars.githubusercontent.com/u/3054066?v=3","gravatar_id":"","url":"https://api.github.com/users/frehner","html_url":"https://github.com/frehner","followers_url":"https://api.github.com/users/frehner/followers","following_url":"https://api.github.com/users/frehner/following{/other_user}","gists_url":"https://api.github.com/users/frehner/gists{/gist_id}","starred_url":"https://api.github.com/users/frehner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frehner/subscriptions","organizations_url":"https://api.github.com/users/frehner/orgs","repos_url":"https://api.github.com/users/frehner/repos","events_url":"https://api.github.com/users/frehner/events{/privacy}","received_events_url":"https://api.github.com/users/frehner/received_events","type":"User","site_admin":false},"body":"npm test passes all checks, and I also tested with a Shopify app to verify that it works as expected. Resolves #38 \r\n\r\nCommit notes: \r\nTests updated in order to correctly pass tests with the state parameter.\r\nVersion updated to 1.5 (because config requires a new parameter)\r\nREADME updated to include information about state/nonce, and also to improve documentation around private vs public Shopify apps with this package.","created_at":"2015-12-03T20:46:22Z","updated_at":"2015-12-11T16:41:48Z","closed_at":"2015-12-11T16:41:48Z","merged_at":"2015-12-11T16:41:48Z","merge_commit_sha":"50e0d15ab74223d0b14baee28c306b218ba1f98c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/christophergregory/shopify-node-api/pulls/39/commits","review_comments_url":"https://api.github.com/repos/christophergregory/shopify-node-api/pulls/39/comments","review_comment_url":"https://api.github.com/repos/christophergregory/shopify-node-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/christophergregory/shopify-node-api/issues/39/comments","statuses_url":"https://api.github.com/repos/christophergregory/shopify-node-api/statuses/d0369acb419fc53f5017c2829961cef3fda042dc","head":{"label":"frehner:master","ref":"master","sha":"d0369acb419fc53f5017c2829961cef3fda042dc","user":{"login":"frehner","id":3054066,"avatar_url":"https://avatars.githubusercontent.com/u/3054066?v=3","gravatar_id":"","url":"https://api.github.com/users/frehner","html_url":"https://github.com/frehner","followers_url":"https://api.github.com/users/frehner/followers","following_url":"https://api.github.com/users/frehner/following{/other_user}","gists_url":"https://api.github.com/users/frehner/gists{/gist_id}","starred_url":"https://api.github.com/users/frehner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frehner/subscriptions","organizations_url":"https://api.github.com/users/frehner/orgs","repos_url":"https://api.github.com/users/frehner/repos","events_url":"https://api.github.com/users/frehner/events{/privacy}","received_events_url":"https://api.github.com/users/frehner/received_events","type":"User","site_admin":false},"repo":{"id":47345267,"name":"shopify-node-api","full_name":"frehner/shopify-node-api","owner":{"login":"frehner","id":3054066,"avatar_url":"https://avatars.githubusercontent.com/u/3054066?v=3","gravatar_id":"","url":"https://api.github.com/users/frehner","html_url":"https://github.com/frehner","followers_url":"https://api.github.com/users/frehner/followers","following_url":"https://api.github.com/users/frehner/following{/other_user}","gists_url":"https://api.github.com/users/frehner/gists{/gist_id}","starred_url":"https://api.github.com/users/frehner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frehner/subscriptions","organizations_url":"https://api.github.com/users/frehner/orgs","repos_url":"https://api.github.com/users/frehner/repos","events_url":"https://api.github.com/users/frehner/events{/privacy}","received_events_url":"https://api.github.com/users/frehner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/frehner/shopify-node-api","description":"OAuth2 Module for Shopify API","fork":true,"url":"https://api.github.com/repos/frehner/shopify-node-api","forks_url":"https://api.github.com/repos/frehner/shopify-node-api/forks","keys_url":"https://api.github.com/repos/frehner/shopify-node-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frehner/shopify-node-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frehner/shopify-node-api/teams","hooks_url":"https://api.github.com/repos/frehner/shopify-node-api/hooks","issue_events_url":"https://api.github.com/repos/frehner/shopify-node-api/issues/events{/number}","events_url":"https://api.github.com/repos/frehner/shopify-node-api/events","assignees_url":"https://api.github.com/repos/frehner/shopify-node-api/assignees{/user}","branches_url":"https://api.github.com/repos/frehner/shopify-node-api/branches{/branch}","tags_url":"https://api.github.com/repos/frehner/shopify-node-api/tags","blobs_url":"https://api.github.com/repos/frehner/shopify-node-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frehner/shopify-node-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frehner/shopify-node-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/frehner/shopify-node-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frehner/shopify-node-api/statuses/{sha}","languages_url":"https://api.github.com/repos/frehner/shopify-node-api/languages","stargazers_url":"https://api.github.com/repos/frehner/shopify-node-api/stargazers","contributors_url":"https://api.github.com/repos/frehner/shopify-node-api/contributors","subscribers_url":"https://api.github.com/repos/frehner/shopify-node-api/subscribers","subscription_url":"https://api.github.com/repos/frehner/shopify-node-api/subscription","commits_url":"https://api.github.com/repos/frehner/shopify-node-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/frehner/shopify-node-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/frehner/shopify-node-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/frehner/shopify-node-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/frehner/shopify-node-api/contents/{+path}","compare_url":"https://api.github.com/repos/frehner/shopify-node-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frehner/shopify-node-api/merges","archive_url":"https://api.github.com/repos/frehner/shopify-node-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frehner/shopify-node-api/downloads","issues_url":"https://api.github.com/repos/frehner/shopify-node-api/issues{/number}","pulls_url":"https://api.github.com/repos/frehner/shopify-node-api/pulls{/number}","milestones_url":"https://api.github.com/repos/frehner/shopify-node-api/milestones{/number}","notifications_url":"https://api.github.com/repos/frehner/shopify-node-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frehner/shopify-node-api/labels{/name}","releases_url":"https://api.github.com/repos/frehner/shopify-node-api/releases{/id}","created_at":"2015-12-03T16:38:38Z","updated_at":"2015-12-03T16:38:39Z","pushed_at":"2015-12-03T20:42:05Z","git_url":"git://github.com/frehner/shopify-node-api.git","ssh_url":"git@github.com:frehner/shopify-node-api.git","clone_url":"https://github.com/frehner/shopify-node-api.git","svn_url":"https://github.com/frehner/shopify-node-api","homepage":null,"size":54,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"christophergregory:master","ref":"master","sha":"e27df7009c5fed577d35dfda5bf0fa8688a8c451","user":{"login":"christophergregory","id":2483319,"avatar_url":"https://avatars.githubusercontent.com/u/2483319?v=3","gravatar_id":"","url":"https://api.github.com/users/christophergregory","html_url":"https://github.com/christophergregory","followers_url":"https://api.github.com/users/christophergregory/followers","following_url":"https://api.github.com/users/christophergregory/following{/other_user}","gists_url":"https://api.github.com/users/christophergregory/gists{/gist_id}","starred_url":"https://api.github.com/users/christophergregory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophergregory/subscriptions","organizations_url":"https://api.github.com/users/christophergregory/orgs","repos_url":"https://api.github.com/users/christophergregory/repos","events_url":"https://api.github.com/users/christophergregory/events{/privacy}","received_events_url":"https://api.github.com/users/christophergregory/received_events","type":"User","site_admin":false},"repo":{"id":17997340,"name":"shopify-node-api","full_name":"christophergregory/shopify-node-api","owner":{"login":"christophergregory","id":2483319,"avatar_url":"https://avatars.githubusercontent.com/u/2483319?v=3","gravatar_id":"","url":"https://api.github.com/users/christophergregory","html_url":"https://github.com/christophergregory","followers_url":"https://api.github.com/users/christophergregory/followers","following_url":"https://api.github.com/users/christophergregory/following{/other_user}","gists_url":"https://api.github.com/users/christophergregory/gists{/gist_id}","starred_url":"https://api.github.com/users/christophergregory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophergregory/subscriptions","organizations_url":"https://api.github.com/users/christophergregory/orgs","repos_url":"https://api.github.com/users/christophergregory/repos","events_url":"https://api.github.com/users/christophergregory/events{/privacy}","received_events_url":"https://api.github.com/users/christophergregory/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/christophergregory/shopify-node-api","description":"OAuth2 Module for Shopify API","fork":false,"url":"https://api.github.com/repos/christophergregory/shopify-node-api","forks_url":"https://api.github.com/repos/christophergregory/shopify-node-api/forks","keys_url":"https://api.github.com/repos/christophergregory/shopify-node-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christophergregory/shopify-node-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christophergregory/shopify-node-api/teams","hooks_url":"https://api.github.com/repos/christophergregory/shopify-node-api/hooks","issue_events_url":"https://api.github.com/repos/christophergregory/shopify-node-api/issues/events{/number}","events_url":"https://api.github.com/repos/christophergregory/shopify-node-api/events","assignees_url":"https://api.github.com/repos/christophergregory/shopify-node-api/assignees{/user}","branches_url":"https://api.github.com/repos/christophergregory/shopify-node-api/branches{/branch}","tags_url":"https://api.github.com/repos/christophergregory/shopify-node-api/tags","blobs_url":"https://api.github.com/repos/christophergregory/shopify-node-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christophergregory/shopify-node-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christophergregory/shopify-node-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/christophergregory/shopify-node-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christophergregory/shopify-node-api/statuses/{sha}","languages_url":"https://api.github.com/repos/christophergregory/shopify-node-api/languages","stargazers_url":"https://api.github.com/repos/christophergregory/shopify-node-api/stargazers","contributors_url":"https://api.github.com/repos/christophergregory/shopify-node-api/contributors","subscribers_url":"https://api.github.com/repos/christophergregory/shopify-node-api/subscribers","subscription_url":"https://api.github.com/repos/christophergregory/shopify-node-api/subscription","commits_url":"https://api.github.com/repos/christophergregory/shopify-node-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/christophergregory/shopify-node-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/christophergregory/shopify-node-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/christophergregory/shopify-node-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/christophergregory/shopify-node-api/contents/{+path}","compare_url":"https://api.github.com/repos/christophergregory/shopify-node-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christophergregory/shopify-node-api/merges","archive_url":"https://api.github.com/repos/christophergregory/shopify-node-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christophergregory/shopify-node-api/downloads","issues_url":"https://api.github.com/repos/christophergregory/shopify-node-api/issues{/number}","pulls_url":"https://api.github.com/repos/christophergregory/shopify-node-api/pulls{/number}","milestones_url":"https://api.github.com/repos/christophergregory/shopify-node-api/milestones{/number}","notifications_url":"https://api.github.com/repos/christophergregory/shopify-node-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christophergregory/shopify-node-api/labels{/name}","releases_url":"https://api.github.com/repos/christophergregory/shopify-node-api/releases{/id}","created_at":"2014-03-21T23:18:20Z","updated_at":"2015-12-07T19:03:55Z","pushed_at":"2015-12-11T16:41:47Z","git_url":"git://github.com/christophergregory/shopify-node-api.git","ssh_url":"git@github.com:christophergregory/shopify-node-api.git","clone_url":"https://github.com/christophergregory/shopify-node-api.git","svn_url":"https://github.com/christophergregory/shopify-node-api","homepage":null,"size":60,"stargazers_count":46,"watchers_count":46,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":3,"forks":30,"open_issues":3,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/christophergregory/shopify-node-api/pulls/39"},"html":{"href":"https://github.com/christophergregory/shopify-node-api/pull/39"},"issue":{"href":"https://api.github.com/repos/christophergregory/shopify-node-api/issues/39"},"comments":{"href":"https://api.github.com/repos/christophergregory/shopify-node-api/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/christophergregory/shopify-node-api/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/christophergregory/shopify-node-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/christophergregory/shopify-node-api/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/christophergregory/shopify-node-api/statuses/d0369acb419fc53f5017c2829961cef3fda042dc"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nodeit","id":9152504,"avatar_url":"https://avatars.githubusercontent.com/u/9152504?v=3","gravatar_id":"","url":"https://api.github.com/users/nodeit","html_url":"https://github.com/nodeit","followers_url":"https://api.github.com/users/nodeit/followers","following_url":"https://api.github.com/users/nodeit/following{/other_user}","gists_url":"https://api.github.com/users/nodeit/gists{/gist_id}","starred_url":"https://api.github.com/users/nodeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodeit/subscriptions","organizations_url":"https://api.github.com/users/nodeit/orgs","repos_url":"https://api.github.com/users/nodeit/repos","events_url":"https://api.github.com/users/nodeit/events{/privacy}","received_events_url":"https://api.github.com/users/nodeit/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":41,"deletions":11,"changed_files":4}}