{"action":"opened","issue":{"url":"https://api.github.com/repos/oddityoverseer13/node-taginfo/issues/1","labels_url":"https://api.github.com/repos/oddityoverseer13/node-taginfo/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/oddityoverseer13/node-taginfo/issues/1/comments","events_url":"https://api.github.com/repos/oddityoverseer13/node-taginfo/issues/1/events","html_url":"https://github.com/oddityoverseer13/node-taginfo/issues/1","id":63032505,"number":1,"title":"Interface Improvements","user":{"login":"missinglink","id":738069,"avatar_url":"https://avatars.githubusercontent.com/u/738069?v=3","gravatar_id":"","url":"https://api.github.com/users/missinglink","html_url":"https://github.com/missinglink","followers_url":"https://api.github.com/users/missinglink/followers","following_url":"https://api.github.com/users/missinglink/following{/other_user}","gists_url":"https://api.github.com/users/missinglink/gists{/gist_id}","starred_url":"https://api.github.com/users/missinglink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/missinglink/subscriptions","organizations_url":"https://api.github.com/users/missinglink/orgs","repos_url":"https://api.github.com/users/missinglink/repos","events_url":"https://api.github.com/users/missinglink/events{/privacy}","received_events_url":"https://api.github.com/users/missinglink/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-03-19T16:41:36Z","updated_at":"2015-03-19T16:41:36Z","closed_at":null,"body":"hey @oddityoverseer13 thanks for the great lib, I used it today to pull down a list of tag names from taginfo :)\r\n\r\nIMHO there are a couple of small changes to the interface which could make the lib a bit more robust:\r\n\r\n**argument ordering**: `rtype, callback, optional`, it's unusual to find a nodejs library with this signature, usually the function comes last. The obvious exception here is `setInterval` which most people agree is super-annoying to read and write.\r\n\r\n**error reporting**: the most common convention here is to use a callback with the signature `(err,res)` so that the errors can be bubbled up the the consumer, currently they get squashed. This signature also makes it much more interoperable with libs like `npm async` which use the error-first convention.\r\n\r\n**always call the callback**: in the case of a non `200 OK` code or a request error the callback will never fire and no error would be emitted, this is super-hard to debug.\r\n\r\nI would be happy to submit a PR to change this stuff but since it would change the API in a way that isn't backwards compatible I figured you'd be unlikely to merge it.\r\n\r\nThoughts?"}}