{"action":"created","issue":{"url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/3714","labels_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/3714/labels{/name}","comments_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/3714/comments","events_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/3714/events","html_url":"https://github.com/borisyankov/DefinitelyTyped/pull/3714","id":58588086,"number":3714,"title":"Fix Angular externs to work with TS 1.4","user":{"login":"mprobst","id":7208,"avatar_url":"https://avatars.githubusercontent.com/u/7208?v=3","gravatar_id":"","url":"https://api.github.com/users/mprobst","html_url":"https://github.com/mprobst","followers_url":"https://api.github.com/users/mprobst/followers","following_url":"https://api.github.com/users/mprobst/following{/other_user}","gists_url":"https://api.github.com/users/mprobst/gists{/gist_id}","starred_url":"https://api.github.com/users/mprobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprobst/subscriptions","organizations_url":"https://api.github.com/users/mprobst/orgs","repos_url":"https://api.github.com/users/mprobst/repos","events_url":"https://api.github.com/users/mprobst/events{/privacy}","received_events_url":"https://api.github.com/users/mprobst/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-23T13:55:03Z","updated_at":"2015-03-03T17:31:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/3714","html_url":"https://github.com/borisyankov/DefinitelyTyped/pull/3714","diff_url":"https://github.com/borisyankov/DefinitelyTyped/pull/3714.diff","patch_url":"https://github.com/borisyankov/DefinitelyTyped/pull/3714.patch"},"body":"Merge the IAngularStatic and the angular namespace by moving all type definitions into the main \"angular\" module.\r\nThis fixes compatibility with TypeScript 1.4 (see issue #3656 and issue #3670), and allow depending on the definitions using \"require\" style imports instead of <reference> style.\r\n\r\nThe drawback is that this is a compatibility breaking change. Existing clients must replace all occurences of \"ng.\" in their code base with \"angular.\", for example by running `sed -i 's|\\bng\\.|angular.|g'` or something similar over their entire code base.\r\n\r\nI don't see another reasonable way to create compatibility with TS 1.4 - any other ideas that'd maintain backwards compatibility? Maybe it'd be possible to declare a `var ng = angular;` in a compatibility shim?"},"comment":{"url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/comments/76992773","html_url":"https://github.com/borisyankov/DefinitelyTyped/pull/3714#issuecomment-76992773","issue_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/3714","id":76992773,"user":{"login":"xi","id":202576,"avatar_url":"https://avatars.githubusercontent.com/u/202576?v=3","gravatar_id":"","url":"https://api.github.com/users/xi","html_url":"https://github.com/xi","followers_url":"https://api.github.com/users/xi/followers","following_url":"https://api.github.com/users/xi/following{/other_user}","gists_url":"https://api.github.com/users/xi/gists{/gist_id}","starred_url":"https://api.github.com/users/xi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xi/subscriptions","organizations_url":"https://api.github.com/users/xi/orgs","repos_url":"https://api.github.com/users/xi/repos","events_url":"https://api.github.com/users/xi/events{/privacy}","received_events_url":"https://api.github.com/users/xi/received_events","type":"User","site_admin":false},"created_at":"2015-03-03T17:31:01Z","updated_at":"2015-03-03T17:31:01Z","body":"I pass angular via dependency injection in order to be able to mock it and run my unit tests without a browser."}}