{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4170","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4170/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4170/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4170/events","html_url":"https://github.com/ManageIQ/manageiq/pull/4170","id":104476626,"number":4170,"title":"Tenant quota UI","user":{"login":"lgalis","id":12769982,"avatar_url":"https://avatars.githubusercontent.com/u/12769982?v=3","gravatar_id":"","url":"https://api.github.com/users/lgalis","html_url":"https://github.com/lgalis","followers_url":"https://api.github.com/users/lgalis/followers","following_url":"https://api.github.com/users/lgalis/following{/other_user}","gists_url":"https://api.github.com/users/lgalis/gists{/gist_id}","starred_url":"https://api.github.com/users/lgalis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgalis/subscriptions","organizations_url":"https://api.github.com/users/lgalis/orgs","repos_url":"https://api.github.com/users/lgalis/repos","events_url":"https://api.github.com/users/lgalis/events{/privacy}","received_events_url":"https://api.github.com/users/lgalis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-09-02T13:09:13Z","updated_at":"2015-09-14T16:08:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4170","html_url":"https://github.com/ManageIQ/manageiq/pull/4170","diff_url":"https://github.com/ManageIQ/manageiq/pull/4170.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/4170.patch"},"body":"Wip - to add validation, specs and styling. depends on  #4085\r\n\r\n@miq-bot add_label wip\r\n@miq-bot add_label ui\r\n@miq-bot add_label enhancement\r\n"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/140127289","html_url":"https://github.com/ManageIQ/manageiq/pull/4170#issuecomment-140127289","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4170","id":140127289,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2015-09-14T16:08:13Z","updated_at":"2015-09-14T16:08:13Z","body":"<rubocop />Checked commits https://github.com/lgalis/manageiq/compare/21cc9aa51c3e34b6cf1df17403e337d244d68e87~...39a95a1a6d322714c9f5e223ec27f52cc90fa00e with ruby 1.9.3, rubocop 0.33.0, and haml-lint 0.13.0\n6 files checked, 42 offenses detected\n\n**app/controllers/ops_controller.rb**\n- [ ] :large_orange_diamond: - [Line 654](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/controllers/ops_controller.rb#L654), Col 45 - [Style/ExtraSpacing](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/ExtraSpacing) - Unnecessary spacing detected.\n- [ ] :large_orange_diamond: - [Line 658](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/controllers/ops_controller.rb#L658), Col 26 - [Style/MultilineTernaryOperator](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/MultilineTernaryOperator) - Avoid multi-line ?: (the ternary operator); use `if`/`unless` instead.\n\n**app/controllers/ops_controller/ops_rbac.rb**\n- [ ] :large_orange_diamond: - [Line 178](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/controllers/ops_controller/ops_rbac.rb#L178), Col 7 - [Style/CaseIndentation](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/CaseIndentation) - Indent `when` as deep as `case`.\n- [ ] :large_orange_diamond: - [Line 184](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/controllers/ops_controller/ops_rbac.rb#L184), Col 7 - [Style/CaseIndentation](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/CaseIndentation) - Indent `when` as deep as `case`.\n- [ ] :large_orange_diamond: - [Line 190](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/controllers/ops_controller/ops_rbac.rb#L190), Col 11 - [Style/IndentationWidth](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/IndentationWidth) - Use 2 (not 4) spaces for indentation.\n- [ ] :large_orange_diamond: - [Line 205](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/controllers/ops_controller/ops_rbac.rb#L205), Col 7 - [Style/CaseIndentation](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/CaseIndentation) - Indent `when` as deep as `case`.\n- [ ] :large_orange_diamond: - [Line 208](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/controllers/ops_controller/ops_rbac.rb#L208), Col 38 - [Style/ExtraSpacing](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/ExtraSpacing) - Unnecessary spacing detected.\n- [ ] :large_orange_diamond: - [Line 223](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/controllers/ops_controller/ops_rbac.rb#L223), Col 1 - [Style/EmptyLinesAroundMethodBody](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/EmptyLinesAroundMethodBody) - Extra empty line detected at method body beginning.\n- [ ] :large_orange_diamond: - [Line 227](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/controllers/ops_controller/ops_rbac.rb#L227), Col 16 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :large_orange_diamond: - [Line 227](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/controllers/ops_controller/ops_rbac.rb#L227), Col 16 - [Style/IndentHash](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/IndentHash) - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.\n- [ ] :large_orange_diamond: - [Line 228](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/controllers/ops_controller/ops_rbac.rb#L228), Col 16 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :large_orange_diamond: - [Line 229](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/controllers/ops_controller/ops_rbac.rb#L229), Col 12 - [Style/IndentHash](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/IndentHash) - Indent the right brace the same as the start of the line where the left brace is.\n- [ ] :large_orange_diamond: - [Line 1337](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/controllers/ops_controller/ops_rbac.rb#L1337), Col 1 - [Style/TrailingBlankLines](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/TrailingBlankLines) - 1 trailing blank lines detected.\n- [ ] :small_blue_diamond: - [Line 175](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/controllers/ops_controller/ops_rbac.rb#L175), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for rbac_tenant_manage_quotas is too high. [64.99/15]\n- [ ] :small_blue_diamond: - [Line 175](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/controllers/ops_controller/ops_rbac.rb#L175), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for rbac_tenant_manage_quotas is too high. [9/6]\n- [ ] :small_blue_diamond: - [Line 175](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/controllers/ops_controller/ops_rbac.rb#L175), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [41/25]\n- [ ] :small_blue_diamond: - [Line 175](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/controllers/ops_controller/ops_rbac.rb#L175), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for rbac_tenant_manage_quotas is too high. [8/7]\n\n**app/views/ops/_tenant_quota_form.html.haml**\n- [ ] :red_circle: **Warn** - [Line 1](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/views/ops/_tenant_quota_form.html.haml#L1), Col  -  - Style/VariableName: Use snake_case for variable names.\n- [ ] :red_circle: **Warn** - [Line 3](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/views/ops/_tenant_quota_form.html.haml#L3), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 3](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/views/ops/_tenant_quota_form.html.haml#L3), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 3](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/views/ops/_tenant_quota_form.html.haml#L3), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 22](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/views/ops/_tenant_quota_form.html.haml#L22), Col  -  - Line is too long. [161/120]\n- [ ] :red_circle: **Warn** - [Line 24](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/views/ops/_tenant_quota_form.html.haml#L24), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 24](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/views/ops/_tenant_quota_form.html.haml#L24), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 24](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/views/ops/_tenant_quota_form.html.haml#L24), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 24](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/views/ops/_tenant_quota_form.html.haml#L24), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 30](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/views/ops/_tenant_quota_form.html.haml#L30), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 30](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/views/ops/_tenant_quota_form.html.haml#L30), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 30](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/views/ops/_tenant_quota_form.html.haml#L30), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 30](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/views/ops/_tenant_quota_form.html.haml#L30), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 30](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/views/ops/_tenant_quota_form.html.haml#L30), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 30](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/views/ops/_tenant_quota_form.html.haml#L30), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 30](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/views/ops/_tenant_quota_form.html.haml#L30), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 40](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/views/ops/_tenant_quota_form.html.haml#L40), Col  -  - Style/SpaceBeforeComma: Space found before comma.\n- [ ] :red_circle: **Warn** - [Line 40](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/app/views/ops/_tenant_quota_form.html.haml#L40), Col  -  - Style/SpaceAroundOperators: Surrounding space missing for operator `=>`.\n\n**spec/controllers/ops_controller/ops_rbac_spec.rb**\n- [ ] :large_orange_diamond: - [Line 166](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/spec/controllers/ops_controller/ops_rbac_spec.rb#L166), Col 13 - [Style/IndentHash](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/IndentHash) - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.\n- [ ] :large_orange_diamond: - [Line 194](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/spec/controllers/ops_controller/ops_rbac_spec.rb#L194), Col 42 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :large_orange_diamond: - [Line 195](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/spec/controllers/ops_controller/ops_rbac_spec.rb#L195), Col 42 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :large_orange_diamond: - [Line 195](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/spec/controllers/ops_controller/ops_rbac_spec.rb#L195), Col 59 - [Style/SpaceInsideHashLiteralBraces](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/SpaceInsideHashLiteralBraces) - Space inside { detected.\n- [ ] :large_orange_diamond: - [Line 198](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/spec/controllers/ops_controller/ops_rbac_spec.rb#L198), Col 42 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :large_orange_diamond: - [Line 199](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/spec/controllers/ops_controller/ops_rbac_spec.rb#L199), Col 42 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :large_orange_diamond: - [Line 200](https://github.com/lgalis/manageiq/blob/39a95a1a6d322714c9f5e223ec27f52cc90fa00e/spec/controllers/ops_controller/ops_rbac_spec.rb#L200), Col 42 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n"}}