{"action":"created","issue":{"url":"https://api.github.com/repos/hechoendrupal/DrupalConsole/issues/826","labels_url":"https://api.github.com/repos/hechoendrupal/DrupalConsole/issues/826/labels{/name}","comments_url":"https://api.github.com/repos/hechoendrupal/DrupalConsole/issues/826/comments","events_url":"https://api.github.com/repos/hechoendrupal/DrupalConsole/issues/826/events","html_url":"https://github.com/hechoendrupal/DrupalConsole/issues/826","id":103596716,"number":826,"title":"[generate:form:config] add Fieldset generation","user":{"login":"jygastaud","id":1499325,"avatar_url":"https://avatars.githubusercontent.com/u/1499325?v=3","gravatar_id":"","url":"https://api.github.com/users/jygastaud","html_url":"https://github.com/jygastaud","followers_url":"https://api.github.com/users/jygastaud/followers","following_url":"https://api.github.com/users/jygastaud/following{/other_user}","gists_url":"https://api.github.com/users/jygastaud/gists{/gist_id}","starred_url":"https://api.github.com/users/jygastaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jygastaud/subscriptions","organizations_url":"https://api.github.com/users/jygastaud/orgs","repos_url":"https://api.github.com/users/jygastaud/repos","events_url":"https://api.github.com/users/jygastaud/events{/privacy}","received_events_url":"https://api.github.com/users/jygastaud/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"enzolutions","id":907914,"avatar_url":"https://avatars.githubusercontent.com/u/907914?v=3","gravatar_id":"","url":"https://api.github.com/users/enzolutions","html_url":"https://github.com/enzolutions","followers_url":"https://api.github.com/users/enzolutions/followers","following_url":"https://api.github.com/users/enzolutions/following{/other_user}","gists_url":"https://api.github.com/users/enzolutions/gists{/gist_id}","starred_url":"https://api.github.com/users/enzolutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enzolutions/subscriptions","organizations_url":"https://api.github.com/users/enzolutions/orgs","repos_url":"https://api.github.com/users/enzolutions/repos","events_url":"https://api.github.com/users/enzolutions/events{/privacy}","received_events_url":"https://api.github.com/users/enzolutions/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/hechoendrupal/DrupalConsole/milestones/2","html_url":"https://github.com/hechoendrupal/DrupalConsole/milestones/must-have","labels_url":"https://api.github.com/repos/hechoendrupal/DrupalConsole/milestones/2/labels","id":1161186,"number":2,"title":"must-have","description":"sdsd","creator":{"login":"jmolivas","id":366275,"avatar_url":"https://avatars.githubusercontent.com/u/366275?v=3","gravatar_id":"","url":"https://api.github.com/users/jmolivas","html_url":"https://github.com/jmolivas","followers_url":"https://api.github.com/users/jmolivas/followers","following_url":"https://api.github.com/users/jmolivas/following{/other_user}","gists_url":"https://api.github.com/users/jmolivas/gists{/gist_id}","starred_url":"https://api.github.com/users/jmolivas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmolivas/subscriptions","organizations_url":"https://api.github.com/users/jmolivas/orgs","repos_url":"https://api.github.com/users/jmolivas/repos","events_url":"https://api.github.com/users/jmolivas/events{/privacy}","received_events_url":"https://api.github.com/users/jmolivas/received_events","type":"User","site_admin":false},"open_issues":38,"closed_issues":14,"state":"open","created_at":"2015-06-12T00:29:42Z","updated_at":"2015-11-23T15:48:31Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-08-27T21:16:44Z","updated_at":"2015-11-23T15:48:31Z","closed_at":"2015-11-23T15:48:31Z","body":"Hi,\r\n\r\nIt should be great if generate:form:config can also deal with presentational elements as fieldset.\r\n\r\n## Motivation\r\n\r\nCurrently we can generate flat form as \r\n```\r\n  $form['button_add'] = array(\r\n      '#required' => '1',\r\n      '#default_value' => $config->get('button_add'),\r\n      '#description' => $this->t('Default: \"off\"<br />\r\n                            Choose \"on\" if you want the \"add\" buttons displayed by default.<br />\r\n                            Each field can override this value.'),\r\n      '#weight' => '0',\r\n      '#type' => 'radios',\r\n      '#options' => array(\r\n        '0' => $this->t('on'),\r\n        '1' => $this->t('off'),\r\n      ),\r\n      '#title' => $this->t('Default Entity Connect \"add\" button display'),\r\n    );\r\n```\r\n\r\nthen, add manually fieldset to obtain something like that \r\n\r\n```\r\n  $form['entityconnect'] = array(\r\n      '#type' => 'fieldset',\r\n      '#title' => $this->t('EntityConnect default Parameters'),\r\n    );\r\n\r\n    $form['entityconnect']['button_add'] = array(\r\n      '#required' => '1',\r\n      '#default_value' => $config->get('button_add'),\r\n      '#description' => $this->t('Default: \"off\"<br />\r\n                            Choose \"on\" if you want the \"add\" buttons displayed by default.<br />\r\n                            Each field can override this value.'),\r\n      '#weight' => '0',\r\n      '#type' => 'radios',\r\n      '#options' => array(\r\n        '0' => $this->t('on'),\r\n        '1' => $this->t('off'),\r\n      ),\r\n      '#title' => $this->t('Default Entity Connect \"add\" button display'),\r\n    );\r\n```\r\n\r\nor even deep like that\r\n\r\n```\r\n    $form['entityconnect'] = array(\r\n      '#type' => 'fieldset',\r\n      '#title' => $this->t('EntityConnect default Parameters'),\r\n    );\r\n\r\n    $form['entityconnect']['button'] = array(\r\n      '#type' => 'fieldset',\r\n      '#title' => $this->t('Buttons display Parameters'),\r\n    );\r\n\r\n    $form['entityconnect']['button']['button_add'] = array(\r\n      '#required' => '1',\r\n      '#default_value' => $config->get('button_add'),\r\n      '#description' => $this->t('Default: \"off\"<br />\r\n                            Choose \"on\" if you want the \"add\" buttons displayed by default.<br />\r\n                            Each field can override this value.'),\r\n      '#weight' => '0',\r\n      '#type' => 'radios',\r\n      '#options' => array(\r\n        '0' => $this->t('on'),\r\n        '1' => $this->t('off'),\r\n      ),\r\n      '#title' => $this->t('Default Entity Connect \"add\" button display'),\r\n    );\r\n```\r\n\r\nI thought that be able to generate fieldset can be really time-saving.\r\n"},"comment":{"url":"https://api.github.com/repos/hechoendrupal/DrupalConsole/issues/comments/158974425","html_url":"https://github.com/hechoendrupal/DrupalConsole/issues/826#issuecomment-158974425","issue_url":"https://api.github.com/repos/hechoendrupal/DrupalConsole/issues/826","id":158974425,"user":{"login":"enzolutions","id":907914,"avatar_url":"https://avatars.githubusercontent.com/u/907914?v=3","gravatar_id":"","url":"https://api.github.com/users/enzolutions","html_url":"https://github.com/enzolutions","followers_url":"https://api.github.com/users/enzolutions/followers","following_url":"https://api.github.com/users/enzolutions/following{/other_user}","gists_url":"https://api.github.com/users/enzolutions/gists{/gist_id}","starred_url":"https://api.github.com/users/enzolutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enzolutions/subscriptions","organizations_url":"https://api.github.com/users/enzolutions/orgs","repos_url":"https://api.github.com/users/enzolutions/repos","events_url":"https://api.github.com/users/enzolutions/events{/privacy}","received_events_url":"https://api.github.com/users/enzolutions/received_events","type":"User","site_admin":false},"created_at":"2015-11-23T15:48:31Z","updated_at":"2015-11-23T15:48:31Z","body":"Hi @jygastaud your suggestion was implemented in https://github.com/hechoendrupal/DrupalConsole/pull/1327"}}