{"action":"created","issue":{"url":"https://api.github.com/repos/Shopify/liquid-c/issues/27","labels_url":"https://api.github.com/repos/Shopify/liquid-c/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/Shopify/liquid-c/issues/27/comments","events_url":"https://api.github.com/repos/Shopify/liquid-c/issues/27/events","html_url":"https://github.com/Shopify/liquid-c/pull/27","id":94852085,"number":27,"title":"Allow variable and tag end characters to be quoted.","user":{"login":"dylanahsmith","id":954402,"avatar_url":"https://avatars.githubusercontent.com/u/954402?v=3","gravatar_id":"","url":"https://api.github.com/users/dylanahsmith","html_url":"https://github.com/dylanahsmith","followers_url":"https://api.github.com/users/dylanahsmith/followers","following_url":"https://api.github.com/users/dylanahsmith/following{/other_user}","gists_url":"https://api.github.com/users/dylanahsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/dylanahsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylanahsmith/subscriptions","organizations_url":"https://api.github.com/users/dylanahsmith/orgs","repos_url":"https://api.github.com/users/dylanahsmith/repos","events_url":"https://api.github.com/users/dylanahsmith/events{/privacy}","received_events_url":"https://api.github.com/users/dylanahsmith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-07-14T02:14:32Z","updated_at":"2015-07-14T03:12:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Shopify/liquid-c/pulls/27","html_url":"https://github.com/Shopify/liquid-c/pull/27","diff_url":"https://github.com/Shopify/liquid-c/pull/27.diff","patch_url":"https://github.com/Shopify/liquid-c/pull/27.patch"},"body":"@pushrax & @trishume for review\r\n\r\nFor https://github.com/Shopify/liquid/pull/623\r\n\r\n## Problem\r\n\r\nhttps://github.com/Shopify/liquid/pull/170 tried to allow curly braces in variables, but was rejected for performance reasons.  However, parsing is a lot faster now that we are using liquid-c, so I think I don't think performance would be as much of a concern now.\r\n\r\n## Solution\r\n\r\nWhen encountering a quote character inside a variable or tag, the tokenizer will include everything up to the end quote character (if one is present) even if it includes the tag/variable end characters."},"comment":{"url":"https://api.github.com/repos/Shopify/liquid-c/issues/comments/121119988","html_url":"https://github.com/Shopify/liquid-c/pull/27#issuecomment-121119988","issue_url":"https://api.github.com/repos/Shopify/liquid-c/issues/27","id":121119988,"user":{"login":"dylanahsmith","id":954402,"avatar_url":"https://avatars.githubusercontent.com/u/954402?v=3","gravatar_id":"","url":"https://api.github.com/users/dylanahsmith","html_url":"https://github.com/dylanahsmith","followers_url":"https://api.github.com/users/dylanahsmith/followers","following_url":"https://api.github.com/users/dylanahsmith/following{/other_user}","gists_url":"https://api.github.com/users/dylanahsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/dylanahsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylanahsmith/subscriptions","organizations_url":"https://api.github.com/users/dylanahsmith/orgs","repos_url":"https://api.github.com/users/dylanahsmith/repos","events_url":"https://api.github.com/users/dylanahsmith/events{/privacy}","received_events_url":"https://api.github.com/users/dylanahsmith/received_events","type":"User","site_admin":false},"created_at":"2015-07-14T03:12:17Z","updated_at":"2015-07-14T03:12:17Z","body":"Yes, unterminated quotes would be a behaviour change.  Should we check existing templates to see how often this happens, and how much of an effect it would have on those templates?"}}