{"action":"created","comment":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments/40541662","id":40541662,"diff_hunk":"@@ -32,32 +32,22 @@ public void setEnvironment(Environment environment) {\n     public DataSource dataSource(<% if (hibernateCache == 'hazelcast') { %>CacheManager cacheManager<% } %>) {\n         log.debug(\"Configuring Heroku Datasource\");\n \n-        String herokuUrl = propertyResolver.getProperty(\"heroku-url\");\n+        String herokuUrl = System.getenv(\"JDBC_DATABASE_URL\");","path":"heroku/templates/src/main/java/package/config/_HerokuDatabaseConfiguration.java","position":5,"original_position":5,"commit_id":"e0a455710859451453613f09f1e23ac357c4bda2","original_commit_id":"e0a455710859451453613f09f1e23ac357c4bda2","user":{"login":"jdubois","id":316835,"avatar_url":"https://avatars.githubusercontent.com/u/316835?v=3","gravatar_id":"","url":"https://api.github.com/users/jdubois","html_url":"https://github.com/jdubois","followers_url":"https://api.github.com/users/jdubois/followers","following_url":"https://api.github.com/users/jdubois/following{/other_user}","gists_url":"https://api.github.com/users/jdubois/gists{/gist_id}","starred_url":"https://api.github.com/users/jdubois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdubois/subscriptions","organizations_url":"https://api.github.com/users/jdubois/orgs","repos_url":"https://api.github.com/users/jdubois/repos","events_url":"https://api.github.com/users/jdubois/events{/privacy}","received_events_url":"https://api.github.com/users/jdubois/received_events","type":"User","site_admin":false},"body":"I'm not sure about the \"System.getenv\" -> we could do the same with the Spring propertyResolver, normally, and this is how we do it everywhere else","created_at":"2015-09-28T11:24:14Z","updated_at":"2015-09-28T11:24:14Z","html_url":"https://github.com/jhipster/generator-jhipster/pull/2039#discussion_r40541662","pull_request_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/2039","_links":{"self":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments/40541662"},"html":{"href":"https://github.com/jhipster/generator-jhipster/pull/2039#discussion_r40541662"},"pull_request":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/2039"}}},"pull_request":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/2039","id":45916188,"html_url":"https://github.com/jhipster/generator-jhipster/pull/2039","diff_url":"https://github.com/jhipster/generator-jhipster/pull/2039.diff","patch_url":"https://github.com/jhipster/generator-jhipster/pull/2039.patch","issue_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/2039","number":2039,"state":"open","locked":false,"title":"Added support for MySQL to Heroku template","user":{"login":"jkutner","id":1589,"avatar_url":"https://avatars.githubusercontent.com/u/1589?v=3","gravatar_id":"","url":"https://api.github.com/users/jkutner","html_url":"https://github.com/jkutner","followers_url":"https://api.github.com/users/jkutner/followers","following_url":"https://api.github.com/users/jkutner/following{/other_user}","gists_url":"https://api.github.com/users/jkutner/gists{/gist_id}","starred_url":"https://api.github.com/users/jkutner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkutner/subscriptions","organizations_url":"https://api.github.com/users/jkutner/orgs","repos_url":"https://api.github.com/users/jkutner/repos","events_url":"https://api.github.com/users/jkutner/events{/privacy}","received_events_url":"https://api.github.com/users/jkutner/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-24T16:04:28Z","updated_at":"2015-09-28T11:24:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"211da3b3f5166ffc0598088ffd46ce1f476990c9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/2039/commits","review_comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/2039/comments","review_comment_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/2039/comments","statuses_url":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/e0a455710859451453613f09f1e23ac357c4bda2","head":{"label":"jkutner:master","ref":"master","sha":"e0a455710859451453613f09f1e23ac357c4bda2","user":{"login":"jkutner","id":1589,"avatar_url":"https://avatars.githubusercontent.com/u/1589?v=3","gravatar_id":"","url":"https://api.github.com/users/jkutner","html_url":"https://github.com/jkutner","followers_url":"https://api.github.com/users/jkutner/followers","following_url":"https://api.github.com/users/jkutner/following{/other_user}","gists_url":"https://api.github.com/users/jkutner/gists{/gist_id}","starred_url":"https://api.github.com/users/jkutner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkutner/subscriptions","organizations_url":"https://api.github.com/users/jkutner/orgs","repos_url":"https://api.github.com/users/jkutner/repos","events_url":"https://api.github.com/users/jkutner/events{/privacy}","received_events_url":"https://api.github.com/users/jkutner/received_events","type":"User","site_admin":false},"repo":{"id":35347683,"name":"generator-jhipster","full_name":"jkutner/generator-jhipster","owner":{"login":"jkutner","id":1589,"avatar_url":"https://avatars.githubusercontent.com/u/1589?v=3","gravatar_id":"","url":"https://api.github.com/users/jkutner","html_url":"https://github.com/jkutner","followers_url":"https://api.github.com/users/jkutner/followers","following_url":"https://api.github.com/users/jkutner/following{/other_user}","gists_url":"https://api.github.com/users/jkutner/gists{/gist_id}","starred_url":"https://api.github.com/users/jkutner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkutner/subscriptions","organizations_url":"https://api.github.com/users/jkutner/orgs","repos_url":"https://api.github.com/users/jkutner/repos","events_url":"https://api.github.com/users/jkutner/events{/privacy}","received_events_url":"https://api.github.com/users/jkutner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jkutner/generator-jhipster","description":"Hipster stack for Java developers. Yeoman + Maven + Spring + AngularJS in one handy generator.","fork":true,"url":"https://api.github.com/repos/jkutner/generator-jhipster","forks_url":"https://api.github.com/repos/jkutner/generator-jhipster/forks","keys_url":"https://api.github.com/repos/jkutner/generator-jhipster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jkutner/generator-jhipster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jkutner/generator-jhipster/teams","hooks_url":"https://api.github.com/repos/jkutner/generator-jhipster/hooks","issue_events_url":"https://api.github.com/repos/jkutner/generator-jhipster/issues/events{/number}","events_url":"https://api.github.com/repos/jkutner/generator-jhipster/events","assignees_url":"https://api.github.com/repos/jkutner/generator-jhipster/assignees{/user}","branches_url":"https://api.github.com/repos/jkutner/generator-jhipster/branches{/branch}","tags_url":"https://api.github.com/repos/jkutner/generator-jhipster/tags","blobs_url":"https://api.github.com/repos/jkutner/generator-jhipster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jkutner/generator-jhipster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jkutner/generator-jhipster/git/refs{/sha}","trees_url":"https://api.github.com/repos/jkutner/generator-jhipster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jkutner/generator-jhipster/statuses/{sha}","languages_url":"https://api.github.com/repos/jkutner/generator-jhipster/languages","stargazers_url":"https://api.github.com/repos/jkutner/generator-jhipster/stargazers","contributors_url":"https://api.github.com/repos/jkutner/generator-jhipster/contributors","subscribers_url":"https://api.github.com/repos/jkutner/generator-jhipster/subscribers","subscription_url":"https://api.github.com/repos/jkutner/generator-jhipster/subscription","commits_url":"https://api.github.com/repos/jkutner/generator-jhipster/commits{/sha}","git_commits_url":"https://api.github.com/repos/jkutner/generator-jhipster/git/commits{/sha}","comments_url":"https://api.github.com/repos/jkutner/generator-jhipster/comments{/number}","issue_comment_url":"https://api.github.com/repos/jkutner/generator-jhipster/issues/comments{/number}","contents_url":"https://api.github.com/repos/jkutner/generator-jhipster/contents/{+path}","compare_url":"https://api.github.com/repos/jkutner/generator-jhipster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jkutner/generator-jhipster/merges","archive_url":"https://api.github.com/repos/jkutner/generator-jhipster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jkutner/generator-jhipster/downloads","issues_url":"https://api.github.com/repos/jkutner/generator-jhipster/issues{/number}","pulls_url":"https://api.github.com/repos/jkutner/generator-jhipster/pulls{/number}","milestones_url":"https://api.github.com/repos/jkutner/generator-jhipster/milestones{/number}","notifications_url":"https://api.github.com/repos/jkutner/generator-jhipster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jkutner/generator-jhipster/labels{/name}","releases_url":"https://api.github.com/repos/jkutner/generator-jhipster/releases{/id}","created_at":"2015-05-09T22:23:25Z","updated_at":"2015-05-09T22:23:27Z","pushed_at":"2015-09-25T19:03:36Z","git_url":"git://github.com/jkutner/generator-jhipster.git","ssh_url":"git@github.com:jkutner/generator-jhipster.git","clone_url":"https://github.com/jkutner/generator-jhipster.git","svn_url":"https://github.com/jkutner/generator-jhipster","homepage":"http://jhipster.github.io","size":7442,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jhipster:master","ref":"master","sha":"f1f37cd6105828d39e70f5ffb3e50ed10aee9345","user":{"login":"jhipster","id":6059488,"avatar_url":"https://avatars.githubusercontent.com/u/6059488?v=3","gravatar_id":"","url":"https://api.github.com/users/jhipster","html_url":"https://github.com/jhipster","followers_url":"https://api.github.com/users/jhipster/followers","following_url":"https://api.github.com/users/jhipster/following{/other_user}","gists_url":"https://api.github.com/users/jhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/jhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhipster/subscriptions","organizations_url":"https://api.github.com/users/jhipster/orgs","repos_url":"https://api.github.com/users/jhipster/repos","events_url":"https://api.github.com/users/jhipster/events{/privacy}","received_events_url":"https://api.github.com/users/jhipster/received_events","type":"Organization","site_admin":false},"repo":{"id":13753636,"name":"generator-jhipster","full_name":"jhipster/generator-jhipster","owner":{"login":"jhipster","id":6059488,"avatar_url":"https://avatars.githubusercontent.com/u/6059488?v=3","gravatar_id":"","url":"https://api.github.com/users/jhipster","html_url":"https://github.com/jhipster","followers_url":"https://api.github.com/users/jhipster/followers","following_url":"https://api.github.com/users/jhipster/following{/other_user}","gists_url":"https://api.github.com/users/jhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/jhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhipster/subscriptions","organizations_url":"https://api.github.com/users/jhipster/orgs","repos_url":"https://api.github.com/users/jhipster/repos","events_url":"https://api.github.com/users/jhipster/events{/privacy}","received_events_url":"https://api.github.com/users/jhipster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jhipster/generator-jhipster","description":"Hipster stack for Java developers. Yeoman + Maven + Spring + AngularJS in one handy generator.","fork":false,"url":"https://api.github.com/repos/jhipster/generator-jhipster","forks_url":"https://api.github.com/repos/jhipster/generator-jhipster/forks","keys_url":"https://api.github.com/repos/jhipster/generator-jhipster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhipster/generator-jhipster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhipster/generator-jhipster/teams","hooks_url":"https://api.github.com/repos/jhipster/generator-jhipster/hooks","issue_events_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/events{/number}","events_url":"https://api.github.com/repos/jhipster/generator-jhipster/events","assignees_url":"https://api.github.com/repos/jhipster/generator-jhipster/assignees{/user}","branches_url":"https://api.github.com/repos/jhipster/generator-jhipster/branches{/branch}","tags_url":"https://api.github.com/repos/jhipster/generator-jhipster/tags","blobs_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/{sha}","languages_url":"https://api.github.com/repos/jhipster/generator-jhipster/languages","stargazers_url":"https://api.github.com/repos/jhipster/generator-jhipster/stargazers","contributors_url":"https://api.github.com/repos/jhipster/generator-jhipster/contributors","subscribers_url":"https://api.github.com/repos/jhipster/generator-jhipster/subscribers","subscription_url":"https://api.github.com/repos/jhipster/generator-jhipster/subscription","commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhipster/generator-jhipster/contents/{+path}","compare_url":"https://api.github.com/repos/jhipster/generator-jhipster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhipster/generator-jhipster/merges","archive_url":"https://api.github.com/repos/jhipster/generator-jhipster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhipster/generator-jhipster/downloads","issues_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues{/number}","pulls_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls{/number}","milestones_url":"https://api.github.com/repos/jhipster/generator-jhipster/milestones{/number}","notifications_url":"https://api.github.com/repos/jhipster/generator-jhipster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhipster/generator-jhipster/labels{/name}","releases_url":"https://api.github.com/repos/jhipster/generator-jhipster/releases{/id}","created_at":"2013-10-21T20:07:22Z","updated_at":"2015-09-28T10:57:16Z","pushed_at":"2015-09-28T11:22:29Z","git_url":"git://github.com/jhipster/generator-jhipster.git","ssh_url":"git@github.com:jhipster/generator-jhipster.git","clone_url":"https://github.com/jhipster/generator-jhipster.git","svn_url":"https://github.com/jhipster/generator-jhipster","homepage":"http://jhipster.github.io","size":17862,"stargazers_count":2732,"watchers_count":2732,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":611,"mirror_url":null,"open_issues_count":48,"forks":611,"open_issues":48,"watchers":2732,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/2039"},"html":{"href":"https://github.com/jhipster/generator-jhipster/pull/2039"},"issue":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/issues/2039"},"comments":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/issues/2039/comments"},"review_comments":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/2039/comments"},"review_comment":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/2039/commits"},"statuses":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/e0a455710859451453613f09f1e23ac357c4bda2"}}}}