{"push_id":553805044,"size":16,"distinct_size":15,"ref":"refs/heads/master","head":"cb07080cfd4d957384798028dd6ba5813a8c43f9","before":"786aa638c3029e6fa8697b676dc2a83e84a1d2a8","commits":[{"sha":"cdd2c06ca1751acda8d0dc325c42efb27cff7d44","author":{"email":"a3e5bf1e23f9b398fd796b3f030b30fdb8b825f9@chipx86.com","name":"Christian Hammond"},"message":"Use a timestamp server for the RBTools Windows installer.\n\nThis uses the Comodo timestamp server when signing the Windows installer\nusing our authenticode certificate. This ensures that when the\ncertificate expires, the installers will still be functional, since\nthere will be a way to ensure that the certificate was valid when the\ninstaller was made.\n\nTesting Done:\nBuilt the installer. I didn't have any errors.\n\nSet the timestamp server to google.com, just to verify that it was being\nused for timestamping. Saw an error.\n\nReviewed at https://reviews.reviewboard.org/r/6749/","distinct":true,"url":"https://api.github.com/repos/davidt/rbtools/commits/cdd2c06ca1751acda8d0dc325c42efb27cff7d44"},{"sha":"a8446ad1e4d726141fd1723d357eed32144987f0","author":{"email":"d48e92e0fe6588b5a3f3112bd87e4d5c011e10af@beanbaginc.com","name":"Barret Rennie"},"message":"Update API schema to allow non-ASCII HTTP responses to be cached.\n\nPreviously, if `rbt` was used to fetch a a response that was not\nencoded with ASCII, writing to the SQLite database would cause it to\ncrash due to trying to insert binary data into a text field. The API\ncache now stores the response body as a binary blob. The caching layer\nno longer has to worry about the encoding or data type of the data\nbeing cached.\n\nBecause of the schema change, update API Cache schema to version 2.\n\nUse unicode literals in api/cache.py.\n\nTesting Done:\nUnit tests passed.\n\nPosted and updated this review request with the patch.\n\nCaching an HTTP response that is not ASCII encoded no longer causes\n`rbt` to crash.\n\nReviewed at https://reviews.reviewboard.org/r/6735/","distinct":true,"url":"https://api.github.com/repos/davidt/rbtools/commits/a8446ad1e4d726141fd1723d357eed32144987f0"},{"sha":"eba575f5e6709d06406f4eefc0e14a82e97eed4f","author":{"email":"d48e92e0fe6588b5a3f3112bd87e4d5c011e10af@beanbaginc.com","name":"Barret Rennie"},"message":"Make APICache always update entries correctly.\n\nThe `APICache` now properly updates entries when the `Last-Modifed`\nand/or `ETag` headers change and the `Vary` header does not.\nPreviously, the entries would only be updated if the `Vary` header\nwas updated.\n\nUpdate the `MockUrlOpener` test harness to compare the provided\n`If-Modified-Since` header against the `Last-Modified` header.\n\nAdded a test for the `Cache-Control: no-cacche` and `Last-Modified`\nheader combination. It makes additional requests after the\n`Last-Modified` header is modified to ensure that the cache entry is\nupdated correctly.\n\nUpdated the test for the `Cache-Control: no-cache` and `ETag` header\ncombination to make another request after the `ETag` is modified to\nverify that the cache entry is updated.\n\nTesting Done:\nRan unit tests.\n\nReviewed at https://reviews.reviewboard.org/r/6772/","distinct":true,"url":"https://api.github.com/repos/davidt/rbtools/commits/eba575f5e6709d06406f4eefc0e14a82e97eed4f"},{"sha":"d5afed238c189a5e342644bc7deeae69fa63bea4","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Fix double messages about pending changes when posting or stamping.\n\nPosting and stamping made use of some of the new utility functions that\nwere pulled out of rbt post. Each of these utility functions ended up\ncalling `get_revisions()`, which, in the case of Git, could cause the same\nwarning about pending changes in the working directory to be displayed.\n\nThere was really one major utility function that needed to be called,\nand it was calling other utility functions that each called\n`get_revisions()`. Now the main utility function, used for guessing review\nrequests, takes the revisions as an argument, ensuring we only ever\nperform that logic once.\n\nAlong with fixing the warning, this should also speed things up a little\nbit by reducing the number of calls that need to be made to other\ncommand line apps, such as git.\n\nTesting Done:\nPosted this change, along with some modified files not staged for commit.\nOnly saw one message.\n\nThen I posted again with `rbt post -u`. Only saw the message once, not twice.\n\nRan `rbt stamp` against this review request. Worked fine.\n\nIn debug mode, I didn't see extra invocations of `git`.\n\nUnit tests pass.\n\nPyflakes had nothing to complain about.\n\nReviewed at https://reviews.reviewboard.org/r/6771/","distinct":true,"url":"https://api.github.com/repos/davidt/rbtools/commits/d5afed238c189a5e342644bc7deeae69fa63bea4"},{"sha":"a38ca9b51b2d8b6b28e8a0c85de0b8803eb6adb5","author":{"email":"1f81e848faf55004077c594fb2256b536cb2c8e0@gmail.com","name":"Theo Belaire"},"message":"Fixed rbt patch to work with $EDITOR that has spaces\n\nBefore, it was looking for the executable with exactly\nthe name in $EDITOR, spaces and all, and failing to find it.\nNow it splits it up by spaces before calling the shell.\n\nFixes issue: Issue 3652: rbt patch throws \"OSError: [Errno 2] No such file or directory\" if EDITOR contains flags\n\nTesting Done:\nFrom the issue.\n\n    EDITOR=\"vim -X\" python -c \"from rbtools.utils.console import edit_text; edit_text('')\"\n\nBefore, it crashed, now it does not.\n\nReviewed at https://reviews.reviewboard.org/r/6784/","distinct":true,"url":"https://api.github.com/repos/davidt/rbtools/commits/a38ca9b51b2d8b6b28e8a0c85de0b8803eb6adb5"},{"sha":"121cf355051b73fbd89c475f417f0427b99c5eca","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Fix guessing review requests in rbt land.\n\nMy recent fix to prevent fetching commit and revision history twice\nresulted in a breakage to rbt land, which wasn't updated for the new\nparameters. This broke landing local branches.\n\nThis change fixes the arguments to allow landing to work correctly\nagain.\n\nReviewed at https://reviews.reviewboard.org/r/6800/","distinct":true,"url":"https://api.github.com/repos/davidt/rbtools/commits/121cf355051b73fbd89c475f417f0427b99c5eca"},{"sha":"3333bb384cc3f70f4d37443f3b5e5ef79aca58e6","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Add Theo Belaire's bug fix to the RBTools release notes.\n\nThis adds the fix from Theo Belaire to the release notes, and adds him\nto the list of contributors. It should be the last non-documentation fix\nbefore we release.\n\nTesting Done:\nBuilt the docs.\n\nReviewed at https://reviews.reviewboard.org/r/6789/","distinct":true,"url":"https://api.github.com/repos/davidt/rbtools/commits/3333bb384cc3f70f4d37443f3b5e5ef79aca58e6"},{"sha":"d11ff5b355a2a1fe837e1150cd3c104ee695aa54","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Clean up and reorganize the RBTools documentation.\n\nThis updates the documentation to provide a simpler, more descriptive\nfront page, and to better organize some of the configuration and API\npages.\n\nThe front page starts off with a more fleshed-out description of\nRBTools, with simple sections on installation and configuration. Each of\nthese point to the relevant pages for the topic.\n\nThe Installation section no longer has instructions for each OS, but\nrather links to the new RBTools Downloads page, which has more modern\ninstructions and installers.\n\nThere's now two configuration pages: One for repository configuration,\nand one for user configuration. The latter includes configuration of\naliases, which is no longer its own page.\n\nAll the directories now have their own indexes, which are properly\nchained into toctrees, helping with the organization.\n\nSome of the text in various sections was also cleaned up just a bit to\nflesh out the content and make things more readable.\n\nTesting Done:\nBuilt the docs and browsed around. Checked that links were still working\nafter the intersphinx updates.\n\nThe docs building didn't show any warnings.\n\nReviewed at https://reviews.reviewboard.org/r/6794/","distinct":true,"url":"https://api.github.com/repos/davidt/rbtools/commits/d11ff5b355a2a1fe837e1150cd3c104ee695aa54"},{"sha":"48c63b7a59cbc24d5e884ff309dbbadc12e2eae7","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Split up the RBTools release notes by major version.\n\nThis splits up the RBTools release notes page to look like the Review\nBoard release notes page, where each major set of releases has its own\nsection. It helps for finding release notes for a particular release.","distinct":true,"url":"https://api.github.com/repos/davidt/rbtools/commits/48c63b7a59cbc24d5e884ff309dbbadc12e2eae7"},{"sha":"b5bdfba75482d6bfc8d4e04aa9141b8e02c0bf01","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Release RBTools 0.7.","distinct":true,"url":"https://api.github.com/repos/davidt/rbtools/commits/b5bdfba75482d6bfc8d4e04aa9141b8e02c0bf01"},{"sha":"40a18a8654d7276761d7e00b23cc860595834982","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Don't build RBTools for Python 2.5 anymore.\n\nThe release script was still trying to build Python 2.5 releases, which\nare no longer supported. It now only builds 2.6 and 2.7.","distinct":true,"url":"https://api.github.com/repos/davidt/rbtools/commits/40a18a8654d7276761d7e00b23cc860595834982"},{"sha":"33e27e0bb50517eb776ad644b2dde7bd15a37fba","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Update the branch information in .reviewboardrc for release-0.7.x.","distinct":true,"url":"https://api.github.com/repos/davidt/rbtools/commits/33e27e0bb50517eb776ad644b2dde7bd15a37fba"},{"sha":"701e2f88958f08606158fc34c97dd01a4c1b5678","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Bump to 0.7.1 dev.","distinct":true,"url":"https://api.github.com/repos/davidt/rbtools/commits/701e2f88958f08606158fc34c97dd01a4c1b5678"},{"sha":"447bab6b74b7fcb5d5d7aba646effd8f6577d9c6","author":{"email":"2314b2e3a4a1f7db165be2aafbf1efd78f28cc97@beanbaginc.com","name":"Christian Hammond"},"message":"Merge branch 'release-0.7.x'","distinct":true,"url":"https://api.github.com/repos/davidt/rbtools/commits/447bab6b74b7fcb5d5d7aba646effd8f6577d9c6"},{"sha":"121b973b7c77464de23a0b1e45061f580dd57c6d","author":{"email":"fea5df6a87d20332fd7981758a59664cee1abf07@gmail.com","name":"Xuanyi Lin"},"message":"Default to http protocol for server url.\n\nCurrently, rbtools assumes that the reviewboard server url is given with http\nprotocol. This results in an error connecting to the server despite the fact\nthat the url given is valid. This problem will arise if http protocol is not\ngiven in either the config file(.reviewboardrc) or in the input with rbt\nsetup-repo command.\n\nNow, the url will default to http protocol if no protocol is given. This\nprevents url retrieve from the config file or from the setup-repo command input\nfrom throwing connection not found error message when the correct url is given.\n\nTesting Done:\nTested rbt setup-repo and config file with and without the http protocol. E.g.\n“localhost:8080” and “http://localhost:8080”. Worked fine for both with\ndifferent commands.\n\nTested with invalid url. E.g. “htp://localhost:8080” . Valid error message\nshown.\n\nRan unit tests.\n\nBugs closed: 3718\n\nReviewed at https://reviews.reviewboard.org/r/6817/","distinct":false,"url":"https://api.github.com/repos/davidt/rbtools/commits/121b973b7c77464de23a0b1e45061f580dd57c6d"},{"sha":"cb07080cfd4d957384798028dd6ba5813a8c43f9","author":{"email":"c4a40333d2e70b3fcac4e7cd05d0e9037471cc26@gmail.com","name":"David Trowbridge"},"message":"Merge branch 'release-0.6.x'","distinct":true,"url":"https://api.github.com/repos/davidt/rbtools/commits/cb07080cfd4d957384798028dd6ba5813a8c43f9"}]}