{"action":"opened","issue":{"url":"https://api.github.com/repos/notepad-plus-plus/notepad-plus-plus/issues/205","labels_url":"https://api.github.com/repos/notepad-plus-plus/notepad-plus-plus/issues/205/labels{/name}","comments_url":"https://api.github.com/repos/notepad-plus-plus/notepad-plus-plus/issues/205/comments","events_url":"https://api.github.com/repos/notepad-plus-plus/notepad-plus-plus/issues/205/events","html_url":"https://github.com/notepad-plus-plus/notepad-plus-plus/issues/205","id":87936638,"number":205,"title":"Important return value ignored in VerticalFileSwitcher::run_dlgProc","user":{"login":"ariccio","id":2142308,"avatar_url":"https://avatars.githubusercontent.com/u/2142308?v=3","gravatar_id":"","url":"https://api.github.com/users/ariccio","html_url":"https://github.com/ariccio","followers_url":"https://api.github.com/users/ariccio/followers","following_url":"https://api.github.com/users/ariccio/following{/other_user}","gists_url":"https://api.github.com/users/ariccio/gists{/gist_id}","starred_url":"https://api.github.com/users/ariccio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariccio/subscriptions","organizations_url":"https://api.github.com/users/ariccio/orgs","repos_url":"https://api.github.com/users/ariccio/repos","events_url":"https://api.github.com/users/ariccio/events{/privacy}","received_events_url":"https://api.github.com/users/ariccio/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-06-13T05:31:42Z","updated_at":"2015-06-13T05:31:42Z","closed_at":null,"body":"For the case `LVN_GETINFOTIP`, one code path calls `lstrcpyn` (which itself is [*very evil*](https://randomascii.wordpress.com/2011/10/08/dangerous-documentation-part-1copying-strings/)) and then blindly returns `TRUE`:\r\n\r\n```\r\n\t\t\t\t\tlstrcpyn(pGetInfoTip->pszText, fn.c_str(), pGetInfoTip->cchTextMax);\r\n\t\t\t\t\treturn TRUE;\r\n```\r\n\r\n....but if `lstrcpyn` fails, the buffer in `pGetInfoTip` (which is `lParam`) is **NOT** null-terminated! Thus, a calling function will overrun the buffer."}}