{"action":"created","issue":{"url":"https://api.github.com/repos/m-lab/ndt/issues/15","labels_url":"https://api.github.com/repos/m-lab/ndt/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/m-lab/ndt/issues/15/comments","events_url":"https://api.github.com/repos/m-lab/ndt/issues/15/events","html_url":"https://github.com/m-lab/ndt/pull/15","id":115161952,"number":15,"title":"SSL support in NDT, merged with extended C2S and S2C tests.","user":{"login":"pboothe","id":143798,"avatar_url":"https://avatars.githubusercontent.com/u/143798?v=3","gravatar_id":"","url":"https://api.github.com/users/pboothe","html_url":"https://github.com/pboothe","followers_url":"https://api.github.com/users/pboothe/followers","following_url":"https://api.github.com/users/pboothe/following{/other_user}","gists_url":"https://api.github.com/users/pboothe/gists{/gist_id}","starred_url":"https://api.github.com/users/pboothe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboothe/subscriptions","organizations_url":"https://api.github.com/users/pboothe/orgs","repos_url":"https://api.github.com/users/pboothe/repos","events_url":"https://api.github.com/users/pboothe/events{/privacy}","received_events_url":"https://api.github.com/users/pboothe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-11-04T22:17:12Z","updated_at":"2015-11-10T21:07:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/m-lab/ndt/pulls/15","html_url":"https://github.com/m-lab/ndt/pull/15","diff_url":"https://github.com/m-lab/ndt/pull/15.diff","patch_url":"https://github.com/m-lab/ndt/pull/15.patch"},"body":"A clean merge! Please review and I will fix things up as needed.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/m-lab/ndt/15)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/m-lab/ndt/issues/comments/155566063","html_url":"https://github.com/m-lab/ndt/pull/15#issuecomment-155566063","issue_url":"https://api.github.com/repos/m-lab/ndt/issues/15","id":155566063,"user":{"login":"pboothe","id":143798,"avatar_url":"https://avatars.githubusercontent.com/u/143798?v=3","gravatar_id":"","url":"https://api.github.com/users/pboothe","html_url":"https://github.com/pboothe","followers_url":"https://api.github.com/users/pboothe/followers","following_url":"https://api.github.com/users/pboothe/following{/other_user}","gists_url":"https://api.github.com/users/pboothe/gists{/gist_id}","starred_url":"https://api.github.com/users/pboothe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboothe/subscriptions","organizations_url":"https://api.github.com/users/pboothe/orgs","repos_url":"https://api.github.com/users/pboothe/repos","events_url":"https://api.github.com/users/pboothe/events{/privacy}","received_events_url":"https://api.github.com/users/pboothe/received_events","type":"User","site_admin":false},"created_at":"2015-11-10T21:07:24Z","updated_at":"2015-11-10T21:07:24Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 8 unresolved discussions.\n\n---\n\n<sup>**[src/test_c2s_srv.c, line 273 \\[r1\\]](https://reviewable.io:443/reviews/m-lab/ndt/15#-K2SWRZJWquZSF-SH5NK)** ([raw file](https://github.com/m-lab/ndt/blob/86f690eb2bd33608a2d1b7ecd9ddbfd1566e925b/src/test_c2s_srv.c#L273)):</sup>\nmoved `conn_index` outside and renamed `retries` to `attempts`, as discussed offline\n<!-- Reviewable comment -K2hHU6iKifyTMaM6TaZ:1633206646 -->\n\n---\n\n<sup>**[src/test_c2s_srv.c, line 330 \\[r1\\]](https://reviewable.io:443/reviews/m-lab/ndt/15#-K2SaX70JBAi4L00bDdQ)** ([raw file](https://github.com/m-lab/ndt/blob/86f690eb2bd33608a2d1b7ecd9ddbfd1566e925b/src/test_c2s_srv.c#L330)):</sup>\nIt does. There used to be a lot more `break` and `continue` in the loop which skipped over this for errors.  Moved to inside an error-handling condition.\n<!-- Reviewable comment -K2nA1aVhWLo3U9MuYhK:762985709 -->\n\n---\n\n<sup>**[src/test_c2s_srv.c, line 27 \\[r2\\]](https://reviewable.io:443/reviews/m-lab/ndt/15#-K2m8BV1N0ZO4I5HOKDs)** ([raw file](https://github.com/m-lab/ndt/blob/b2276fb65701331dad83bcbfc556f7344ff3a5c9/src/test_c2s_srv.c#L27)):</sup>\nDone.\n<!-- Reviewable comment -K2mniEF6fKIR87YYIO7:-499146009 -->\n\n---\n\n<sup>**[src/test_c2s_srv.c, line 55 \\[r2\\]](https://reviewable.io:443/reviews/m-lab/ndt/15#-K2mKnrUEjV5M26v9Z8x)** ([raw file](https://github.com/m-lab/ndt/blob/b2276fb65701331dad83bcbfc556f7344ff3a5c9/src/test_c2s_srv.c#L55)):</sup>\nDeleted the condition, as it didn't actually do anything at all.\n<!-- Reviewable comment -K2mnMPu7q9yhVsDaWt-:-269721067 -->\n\n---\n\n<sup>**[src/test_c2s_srv.c, line 72 \\[r2\\]](https://reviewable.io:443/reviews/m-lab/ndt/15#-K2mLHqAghaekdW0paqo)** ([raw file](https://github.com/m-lab/ndt/blob/b2276fb65701331dad83bcbfc556f7344ff3a5c9/src/test_c2s_srv.c#L72)):</sup>\nDone (throughout the file).\n<!-- Reviewable comment -K2mmytAlrURivDzTQV4:1768664888 -->\n\n---\n\n<sup>**[src/test_c2s_srv.c, line 76 \\[r2\\]](https://reviewable.io:443/reviews/m-lab/ndt/15#-K2mLlNd3IYrJmW59_SN)** ([raw file](https://github.com/m-lab/ndt/blob/b2276fb65701331dad83bcbfc556f7344ff3a5c9/src/test_c2s_srv.c#L76)):</sup>\nOld instinct from too much C++. Changed to c-style.\n<!-- Reviewable comment -K2mn34k2DqbWDADp6sB:73533826 -->\n\n---\n\n<sup>**[src/test_c2s_srv.c, line 173 \\[r2\\]](https://reviewable.io:443/reviews/m-lab/ndt/15#-K2n2ocmH5urDNliX9Ra)** ([raw file](https://github.com/m-lab/ndt/blob/b2276fb65701331dad83bcbfc556f7344ff3a5c9/src/test_c2s_srv.c#L173)):</sup>\nFixed.\n<!-- Reviewable comment -K2n9tO2eTOcsVytoYUc:1758359711 -->\n\n---\n\n<sup>**[src/test_c2s_srv.c, line 375 \\[r2\\]](https://reviewable.io:443/reviews/m-lab/ndt/15#-K2n3pdzlIPp8UCb8-i2)** ([raw file](https://github.com/m-lab/ndt/blob/b2276fb65701331dad83bcbfc556f7344ff3a5c9/src/test_c2s_srv.c#L375)):</sup>\nDone. Discussed offline\n<!-- Reviewable comment -K2n9cr5EQkHzaCH4WGo:1452703273 -->\n\n---\n\n<sup>**[src/test_c2s_srv.c, line 499 \\[r2\\]](https://reviewable.io:443/reviews/m-lab/ndt/15#-K2n5Ek81d-GhIRZarpO)** ([raw file](https://github.com/m-lab/ndt/blob/b2276fb65701331dad83bcbfc556f7344ff3a5c9/src/test_c2s_srv.c#L499)):</sup>\nDone, nice catch.\n<!-- Reviewable comment -K2nAwsmGaAlwKe0n7Vb:-2126756293 -->\n\n---\n\n<sup>**[src/test_s2c_srv.c, line 296 \\[r1\\]](https://reviewable.io:443/reviews/m-lab/ndt/15#-K2TXyhI_R8ySEIT-XGs)** ([raw file](https://github.com/m-lab/ndt/blob/86f690eb2bd33608a2d1b7ecd9ddbfd1566e925b/src/test_s2c_srv.c#L296)):</sup>\nPerformed the same change as we did for the other such loop.\n<!-- Reviewable comment -K2n-2s1L2tUf8zdgn-Y:-969315274 -->\n\n---\n\n<sup>**[src/test_s2c_srv.c, line 806 \\[r1\\]](https://reviewable.io:443/reviews/m-lab/ndt/15#-K2Ta8HeA7ZZ5woS1i2l)** ([raw file](https://github.com/m-lab/ndt/blob/6476caa0474ca91e8a1e19be1230e9a90d8cbbf9/src/test_s2c_srv.c#L806)):</sup>\nDone.\n<!-- Reviewable comment -K2mlMNQcNZpjZoXVQ--:-499146009 -->\n\n---\n\n<sup>**[src/web100srv.c, line 1471 \\[r1\\]](https://reviewable.io:443/reviews/m-lab/ndt/15#-K2TyL3-bnEi5gNvcaOz)** ([raw file](https://github.com/m-lab/ndt/blob/86f690eb2bd33608a2d1b7ecd9ddbfd1566e925b/src/web100srv.c#L1471)):</sup>\nDone.\n<!-- Reviewable comment -K2mkxSI8AIPr4xaCOW-:-499146009 -->\n\n---\n\n<sup>**[src/web100srv_unit_tests.c, line 41 \\[r1\\]](https://reviewable.io:443/reviews/m-lab/ndt/15#-K2gu7oNbbXg2TvZQoMW)** ([raw file](https://github.com/m-lab/ndt/blob/86f690eb2bd33608a2d1b7ecd9ddbfd1566e925b/src/web100srv_unit_tests.c#L41)):</sup>\nDone.\n<!-- Reviewable comment -K2mj_Xc9kboCwzynD7y:-499146009 -->\n\n---\n\n<sup>**[src/web100srv_unit_tests.c, line 45 \\[r1\\]](https://reviewable.io:443/reviews/m-lab/ndt/15#-K2gsGXQJubxu_OHqK5M)** ([raw file](https://github.com/m-lab/ndt/blob/86f690eb2bd33608a2d1b7ecd9ddbfd1566e925b/src/web100srv_unit_tests.c#L45)):</sup>\nIt's pretty well known, but it looks confusing to my eye - I have to read the line a few times, while with the other I am confident that the order of operations is correct.\n\nI have added the exit code to the test failure output, as more information is always better when a test fails.\n<!-- Reviewable comment -K2miv3_v0cvl11NDFOb:740237552 -->\n\n---\n\n<sup>**[src/web100srv_unit_tests.c, line 25 \\[r2\\]](https://reviewable.io:443/reviews/m-lab/ndt/15#-K2mEuwWZoin3T1tJ9cw)** ([raw file](https://github.com/m-lab/ndt/blob/b2276fb65701331dad83bcbfc556f7344ff3a5c9/src/web100srv_unit_tests.c#L25)):</sup>\nDone.\n<!-- Reviewable comment -K2mkDq1exTPWR4cEibb:-499146009 -->\n\n---\n\n<sup>**[src/web100srv_unit_tests.c, line 26 \\[r2\\]](https://reviewable.io:443/reviews/m-lab/ndt/15#-K2mElIeHF7I7KgRJVgD)** ([raw file](https://github.com/m-lab/ndt/blob/b2276fb65701331dad83bcbfc556f7344ff3a5c9/src/web100srv_unit_tests.c#L26)):</sup>\nFixed all trailing whitespace.\n<!-- Reviewable comment -K2mkBHA2-ZdN-MPrPxy:-1753661955 -->\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/m-lab/ndt/15)\n<!-- Sent from Reviewable.io -->\n"}}