{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/40219295","id":40219295,"diff_hunk":"@@ -59,6 +60,9 @@ func (eventStrategy) AllowCreateOnUpdate() bool {\n \n func (eventStrategy) ValidateUpdate(ctx api.Context, obj, old runtime.Object) fielderrors.ValidationErrorList {\n \tevent := obj.(*api.Event)\n+\tif event.ObjectMeta.UID == \"\" {\n+\t\tevent.ObjectMeta.UID = util.NewUUID()","path":"pkg/registry/event/strategy.go","position":13,"original_position":13,"commit_id":"efc4f2baaebef8ef73a61d6360cf08d12ffd9b89","original_commit_id":"efc4f2baaebef8ef73a61d6360cf08d12ffd9b89","user":{"login":"jiangyaoguo","id":6777418,"avatar_url":"https://avatars.githubusercontent.com/u/6777418?v=3","gravatar_id":"","url":"https://api.github.com/users/jiangyaoguo","html_url":"https://github.com/jiangyaoguo","followers_url":"https://api.github.com/users/jiangyaoguo/followers","following_url":"https://api.github.com/users/jiangyaoguo/following{/other_user}","gists_url":"https://api.github.com/users/jiangyaoguo/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangyaoguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangyaoguo/subscriptions","organizations_url":"https://api.github.com/users/jiangyaoguo/orgs","repos_url":"https://api.github.com/users/jiangyaoguo/repos","events_url":"https://api.github.com/users/jiangyaoguo/events{/privacy}","received_events_url":"https://api.github.com/users/jiangyaoguo/received_events","type":"User","site_admin":false},"body":"@thockin  You're right. Sorry, I misunderstand what we want. Will fix it tomorrow.","created_at":"2015-09-23T15:41:07Z","updated_at":"2015-09-23T15:41:07Z","html_url":"https://github.com/kubernetes/kubernetes/pull/14422#discussion_r40219295","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14422","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/40219295"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/14422#discussion_r40219295"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14422"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14422","id":45776131,"html_url":"https://github.com/kubernetes/kubernetes/pull/14422","diff_url":"https://github.com/kubernetes/kubernetes/pull/14422.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/14422.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14422","number":14422,"state":"open","locked":false,"title":"fix missing UID when update event","user":{"login":"jiangyaoguo","id":6777418,"avatar_url":"https://avatars.githubusercontent.com/u/6777418?v=3","gravatar_id":"","url":"https://api.github.com/users/jiangyaoguo","html_url":"https://github.com/jiangyaoguo","followers_url":"https://api.github.com/users/jiangyaoguo/followers","following_url":"https://api.github.com/users/jiangyaoguo/following{/other_user}","gists_url":"https://api.github.com/users/jiangyaoguo/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangyaoguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangyaoguo/subscriptions","organizations_url":"https://api.github.com/users/jiangyaoguo/orgs","repos_url":"https://api.github.com/users/jiangyaoguo/repos","events_url":"https://api.github.com/users/jiangyaoguo/events{/privacy}","received_events_url":"https://api.github.com/users/jiangyaoguo/received_events","type":"User","site_admin":false},"body":"Fixed #14126","created_at":"2015-09-23T13:04:17Z","updated_at":"2015-09-23T15:41:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e40788df949a421060307b4ffa8dad39b4252a75","assignee":{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14422/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14422/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14422/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/efc4f2baaebef8ef73a61d6360cf08d12ffd9b89","head":{"label":"jiangyaoguo:fix-UID-validation-when-update-event","ref":"fix-UID-validation-when-update-event","sha":"efc4f2baaebef8ef73a61d6360cf08d12ffd9b89","user":{"login":"jiangyaoguo","id":6777418,"avatar_url":"https://avatars.githubusercontent.com/u/6777418?v=3","gravatar_id":"","url":"https://api.github.com/users/jiangyaoguo","html_url":"https://github.com/jiangyaoguo","followers_url":"https://api.github.com/users/jiangyaoguo/followers","following_url":"https://api.github.com/users/jiangyaoguo/following{/other_user}","gists_url":"https://api.github.com/users/jiangyaoguo/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangyaoguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangyaoguo/subscriptions","organizations_url":"https://api.github.com/users/jiangyaoguo/orgs","repos_url":"https://api.github.com/users/jiangyaoguo/repos","events_url":"https://api.github.com/users/jiangyaoguo/events{/privacy}","received_events_url":"https://api.github.com/users/jiangyaoguo/received_events","type":"User","site_admin":false},"repo":{"id":33133739,"name":"kubernetes","full_name":"jiangyaoguo/kubernetes","owner":{"login":"jiangyaoguo","id":6777418,"avatar_url":"https://avatars.githubusercontent.com/u/6777418?v=3","gravatar_id":"","url":"https://api.github.com/users/jiangyaoguo","html_url":"https://github.com/jiangyaoguo","followers_url":"https://api.github.com/users/jiangyaoguo/followers","following_url":"https://api.github.com/users/jiangyaoguo/following{/other_user}","gists_url":"https://api.github.com/users/jiangyaoguo/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangyaoguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangyaoguo/subscriptions","organizations_url":"https://api.github.com/users/jiangyaoguo/orgs","repos_url":"https://api.github.com/users/jiangyaoguo/repos","events_url":"https://api.github.com/users/jiangyaoguo/events{/privacy}","received_events_url":"https://api.github.com/users/jiangyaoguo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jiangyaoguo/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/jiangyaoguo/kubernetes","forks_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/forks","keys_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/teams","hooks_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/events","assignees_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/tags","blobs_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/languages","stargazers_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/subscription","commits_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/merges","archive_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/downloads","issues_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/jiangyaoguo/kubernetes/releases{/id}","created_at":"2015-03-30T16:10:38Z","updated_at":"2015-04-09T16:04:58Z","pushed_at":"2015-09-23T15:19:36Z","git_url":"git://github.com/jiangyaoguo/kubernetes.git","ssh_url":"git@github.com:jiangyaoguo/kubernetes.git","clone_url":"https://github.com/jiangyaoguo/kubernetes.git","svn_url":"https://github.com/jiangyaoguo/kubernetes","homepage":"http://kubernetes.io","size":109605,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"28585bc699e7f3b6d3343aebb507d3ecef8e4e28","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-09-23T15:02:30Z","pushed_at":"2015-09-23T15:41:02Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":429951,"stargazers_count":10398,"watchers_count":10398,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2583,"mirror_url":null,"open_issues_count":1884,"forks":2583,"open_issues":1884,"watchers":10398,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14422"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/14422"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/14422"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/14422/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14422/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14422/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/efc4f2baaebef8ef73a61d6360cf08d12ffd9b89"}}}}