{"action":"closed","number":84,"pull_request":{"url":"https://api.github.com/repos/jandecaluwe/myhdl/pulls/84","id":36480033,"html_url":"https://github.com/jandecaluwe/myhdl/pull/84","diff_url":"https://github.com/jandecaluwe/myhdl/pull/84.diff","patch_url":"https://github.com/jandecaluwe/myhdl/pull/84.patch","issue_url":"https://api.github.com/repos/jandecaluwe/myhdl/issues/84","number":84,"state":"closed","locked":false,"title":"Std logic ports shadow signals","user":{"login":"josyb","id":4457022,"avatar_url":"https://avatars.githubusercontent.com/u/4457022?v=3","gravatar_id":"","url":"https://api.github.com/users/josyb","html_url":"https://github.com/josyb","followers_url":"https://api.github.com/users/josyb/followers","following_url":"https://api.github.com/users/josyb/following{/other_user}","gists_url":"https://api.github.com/users/josyb/gists{/gist_id}","starred_url":"https://api.github.com/users/josyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josyb/subscriptions","organizations_url":"https://api.github.com/users/josyb/orgs","repos_url":"https://api.github.com/users/josyb/repos","events_url":"https://api.github.com/users/josyb/events{/privacy}","received_events_url":"https://api.github.com/users/josyb/received_events","type":"User","site_admin":false},"body":"See #80 where I describe an Issue with ShadowSignals from a top-level std_logic_vector port.\r\nAs a result of moving the _analyzeTopFunc() forward the original renaming of conflicting generated signals from an interface object is now skipped.\r\nI find silently renaming a less nice solution and added code to raise an error. Also read #64. IMHO I think this will be very rare, and if it arises I prefer changing the naming myself rather than see that (dare I say awkward)  mangled name in the VHDL code.","created_at":"2015-05-29T07:24:23Z","updated_at":"2015-05-29T21:36:16Z","closed_at":"2015-05-29T21:36:16Z","merged_at":null,"merge_commit_sha":"0067b913b8f3b5595b6a4089e1ca758ea0966ed7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jandecaluwe/myhdl/pulls/84/commits","review_comments_url":"https://api.github.com/repos/jandecaluwe/myhdl/pulls/84/comments","review_comment_url":"https://api.github.com/repos/jandecaluwe/myhdl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jandecaluwe/myhdl/issues/84/comments","statuses_url":"https://api.github.com/repos/jandecaluwe/myhdl/statuses/438cba160a3787dc195dfb81bef557e7615e960c","head":{"label":"josyb:std_logic_ports-ShadowSignals","ref":"std_logic_ports-ShadowSignals","sha":"438cba160a3787dc195dfb81bef557e7615e960c","user":{"login":"josyb","id":4457022,"avatar_url":"https://avatars.githubusercontent.com/u/4457022?v=3","gravatar_id":"","url":"https://api.github.com/users/josyb","html_url":"https://github.com/josyb","followers_url":"https://api.github.com/users/josyb/followers","following_url":"https://api.github.com/users/josyb/following{/other_user}","gists_url":"https://api.github.com/users/josyb/gists{/gist_id}","starred_url":"https://api.github.com/users/josyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josyb/subscriptions","organizations_url":"https://api.github.com/users/josyb/orgs","repos_url":"https://api.github.com/users/josyb/repos","events_url":"https://api.github.com/users/josyb/events{/privacy}","received_events_url":"https://api.github.com/users/josyb/received_events","type":"User","site_admin":false},"repo":{"id":32035396,"name":"myhdl","full_name":"josyb/myhdl","owner":{"login":"josyb","id":4457022,"avatar_url":"https://avatars.githubusercontent.com/u/4457022?v=3","gravatar_id":"","url":"https://api.github.com/users/josyb","html_url":"https://github.com/josyb","followers_url":"https://api.github.com/users/josyb/followers","following_url":"https://api.github.com/users/josyb/following{/other_user}","gists_url":"https://api.github.com/users/josyb/gists{/gist_id}","starred_url":"https://api.github.com/users/josyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josyb/subscriptions","organizations_url":"https://api.github.com/users/josyb/orgs","repos_url":"https://api.github.com/users/josyb/repos","events_url":"https://api.github.com/users/josyb/events{/privacy}","received_events_url":"https://api.github.com/users/josyb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/josyb/myhdl","description":"The MyHDL development repository","fork":true,"url":"https://api.github.com/repos/josyb/myhdl","forks_url":"https://api.github.com/repos/josyb/myhdl/forks","keys_url":"https://api.github.com/repos/josyb/myhdl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josyb/myhdl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josyb/myhdl/teams","hooks_url":"https://api.github.com/repos/josyb/myhdl/hooks","issue_events_url":"https://api.github.com/repos/josyb/myhdl/issues/events{/number}","events_url":"https://api.github.com/repos/josyb/myhdl/events","assignees_url":"https://api.github.com/repos/josyb/myhdl/assignees{/user}","branches_url":"https://api.github.com/repos/josyb/myhdl/branches{/branch}","tags_url":"https://api.github.com/repos/josyb/myhdl/tags","blobs_url":"https://api.github.com/repos/josyb/myhdl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josyb/myhdl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josyb/myhdl/git/refs{/sha}","trees_url":"https://api.github.com/repos/josyb/myhdl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josyb/myhdl/statuses/{sha}","languages_url":"https://api.github.com/repos/josyb/myhdl/languages","stargazers_url":"https://api.github.com/repos/josyb/myhdl/stargazers","contributors_url":"https://api.github.com/repos/josyb/myhdl/contributors","subscribers_url":"https://api.github.com/repos/josyb/myhdl/subscribers","subscription_url":"https://api.github.com/repos/josyb/myhdl/subscription","commits_url":"https://api.github.com/repos/josyb/myhdl/commits{/sha}","git_commits_url":"https://api.github.com/repos/josyb/myhdl/git/commits{/sha}","comments_url":"https://api.github.com/repos/josyb/myhdl/comments{/number}","issue_comment_url":"https://api.github.com/repos/josyb/myhdl/issues/comments{/number}","contents_url":"https://api.github.com/repos/josyb/myhdl/contents/{+path}","compare_url":"https://api.github.com/repos/josyb/myhdl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josyb/myhdl/merges","archive_url":"https://api.github.com/repos/josyb/myhdl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josyb/myhdl/downloads","issues_url":"https://api.github.com/repos/josyb/myhdl/issues{/number}","pulls_url":"https://api.github.com/repos/josyb/myhdl/pulls{/number}","milestones_url":"https://api.github.com/repos/josyb/myhdl/milestones{/number}","notifications_url":"https://api.github.com/repos/josyb/myhdl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josyb/myhdl/labels{/name}","releases_url":"https://api.github.com/repos/josyb/myhdl/releases{/id}","created_at":"2015-03-11T18:55:23Z","updated_at":"2015-05-06T09:22:13Z","pushed_at":"2015-05-28T18:14:28Z","git_url":"git://github.com/josyb/myhdl.git","ssh_url":"git@github.com:josyb/myhdl.git","clone_url":"https://github.com/josyb/myhdl.git","svn_url":"https://github.com/josyb/myhdl","homepage":"http://www.myhdl.org","size":12208,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jandecaluwe:master","ref":"master","sha":"846f7ad444059d0ca33d36f10adb2214223129f5","user":{"login":"jandecaluwe","id":1984236,"avatar_url":"https://avatars.githubusercontent.com/u/1984236?v=3","gravatar_id":"","url":"https://api.github.com/users/jandecaluwe","html_url":"https://github.com/jandecaluwe","followers_url":"https://api.github.com/users/jandecaluwe/followers","following_url":"https://api.github.com/users/jandecaluwe/following{/other_user}","gists_url":"https://api.github.com/users/jandecaluwe/gists{/gist_id}","starred_url":"https://api.github.com/users/jandecaluwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jandecaluwe/subscriptions","organizations_url":"https://api.github.com/users/jandecaluwe/orgs","repos_url":"https://api.github.com/users/jandecaluwe/repos","events_url":"https://api.github.com/users/jandecaluwe/events{/privacy}","received_events_url":"https://api.github.com/users/jandecaluwe/received_events","type":"User","site_admin":false},"repo":{"id":30467971,"name":"myhdl","full_name":"jandecaluwe/myhdl","owner":{"login":"jandecaluwe","id":1984236,"avatar_url":"https://avatars.githubusercontent.com/u/1984236?v=3","gravatar_id":"","url":"https://api.github.com/users/jandecaluwe","html_url":"https://github.com/jandecaluwe","followers_url":"https://api.github.com/users/jandecaluwe/followers","following_url":"https://api.github.com/users/jandecaluwe/following{/other_user}","gists_url":"https://api.github.com/users/jandecaluwe/gists{/gist_id}","starred_url":"https://api.github.com/users/jandecaluwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jandecaluwe/subscriptions","organizations_url":"https://api.github.com/users/jandecaluwe/orgs","repos_url":"https://api.github.com/users/jandecaluwe/repos","events_url":"https://api.github.com/users/jandecaluwe/events{/privacy}","received_events_url":"https://api.github.com/users/jandecaluwe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jandecaluwe/myhdl","description":"The MyHDL development repository","fork":false,"url":"https://api.github.com/repos/jandecaluwe/myhdl","forks_url":"https://api.github.com/repos/jandecaluwe/myhdl/forks","keys_url":"https://api.github.com/repos/jandecaluwe/myhdl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jandecaluwe/myhdl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jandecaluwe/myhdl/teams","hooks_url":"https://api.github.com/repos/jandecaluwe/myhdl/hooks","issue_events_url":"https://api.github.com/repos/jandecaluwe/myhdl/issues/events{/number}","events_url":"https://api.github.com/repos/jandecaluwe/myhdl/events","assignees_url":"https://api.github.com/repos/jandecaluwe/myhdl/assignees{/user}","branches_url":"https://api.github.com/repos/jandecaluwe/myhdl/branches{/branch}","tags_url":"https://api.github.com/repos/jandecaluwe/myhdl/tags","blobs_url":"https://api.github.com/repos/jandecaluwe/myhdl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jandecaluwe/myhdl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jandecaluwe/myhdl/git/refs{/sha}","trees_url":"https://api.github.com/repos/jandecaluwe/myhdl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jandecaluwe/myhdl/statuses/{sha}","languages_url":"https://api.github.com/repos/jandecaluwe/myhdl/languages","stargazers_url":"https://api.github.com/repos/jandecaluwe/myhdl/stargazers","contributors_url":"https://api.github.com/repos/jandecaluwe/myhdl/contributors","subscribers_url":"https://api.github.com/repos/jandecaluwe/myhdl/subscribers","subscription_url":"https://api.github.com/repos/jandecaluwe/myhdl/subscription","commits_url":"https://api.github.com/repos/jandecaluwe/myhdl/commits{/sha}","git_commits_url":"https://api.github.com/repos/jandecaluwe/myhdl/git/commits{/sha}","comments_url":"https://api.github.com/repos/jandecaluwe/myhdl/comments{/number}","issue_comment_url":"https://api.github.com/repos/jandecaluwe/myhdl/issues/comments{/number}","contents_url":"https://api.github.com/repos/jandecaluwe/myhdl/contents/{+path}","compare_url":"https://api.github.com/repos/jandecaluwe/myhdl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jandecaluwe/myhdl/merges","archive_url":"https://api.github.com/repos/jandecaluwe/myhdl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jandecaluwe/myhdl/downloads","issues_url":"https://api.github.com/repos/jandecaluwe/myhdl/issues{/number}","pulls_url":"https://api.github.com/repos/jandecaluwe/myhdl/pulls{/number}","milestones_url":"https://api.github.com/repos/jandecaluwe/myhdl/milestones{/number}","notifications_url":"https://api.github.com/repos/jandecaluwe/myhdl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jandecaluwe/myhdl/labels{/name}","releases_url":"https://api.github.com/repos/jandecaluwe/myhdl/releases{/id}","created_at":"2015-02-07T19:50:27Z","updated_at":"2015-05-26T02:07:16Z","pushed_at":"2015-05-29T07:24:24Z","git_url":"git://github.com/jandecaluwe/myhdl.git","ssh_url":"git@github.com:jandecaluwe/myhdl.git","clone_url":"https://github.com/jandecaluwe/myhdl.git","svn_url":"https://github.com/jandecaluwe/myhdl","homepage":"http://www.myhdl.org","size":13635,"stargazers_count":49,"watchers_count":49,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":18,"forks":26,"open_issues":18,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jandecaluwe/myhdl/pulls/84"},"html":{"href":"https://github.com/jandecaluwe/myhdl/pull/84"},"issue":{"href":"https://api.github.com/repos/jandecaluwe/myhdl/issues/84"},"comments":{"href":"https://api.github.com/repos/jandecaluwe/myhdl/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/jandecaluwe/myhdl/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/jandecaluwe/myhdl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jandecaluwe/myhdl/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/jandecaluwe/myhdl/statuses/438cba160a3787dc195dfb81bef557e7615e960c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":5,"additions":26,"deletions":13,"changed_files":6}}