{"action":"closed","number":187,"pull_request":{"url":"https://api.github.com/repos/jline/jline2/pulls/187","id":36968614,"html_url":"https://github.com/jline/jline2/pull/187","diff_url":"https://github.com/jline/jline2/pull/187.diff","patch_url":"https://github.com/jline/jline2/pull/187.patch","issue_url":"https://api.github.com/repos/jline/jline2/issues/187","number":187,"state":"closed","locked":false,"title":"Fixing warnings","user":{"login":"jlahoda","id":124144,"avatar_url":"https://avatars.githubusercontent.com/u/124144?v=3","gravatar_id":"","url":"https://api.github.com/users/jlahoda","html_url":"https://github.com/jlahoda","followers_url":"https://api.github.com/users/jlahoda/followers","following_url":"https://api.github.com/users/jlahoda/following{/other_user}","gists_url":"https://api.github.com/users/jlahoda/gists{/gist_id}","starred_url":"https://api.github.com/users/jlahoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlahoda/subscriptions","organizations_url":"https://api.github.com/users/jlahoda/orgs","repos_url":"https://api.github.com/users/jlahoda/repos","events_url":"https://api.github.com/users/jlahoda/events{/privacy}","received_events_url":"https://api.github.com/users/jlahoda/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nWhen warnings are enabled in javac, a few of them are reported in jline. This patch proposes a solution to them. I tried to resolve the warning (e.g. for static element access use class name instead of instance), but in a few cases, @SuppressWarnings seemed most appropriate to me. I'll be happy to provide rationale for the changes as needed.\r\n\r\nAlso, as a potentially controversial proposal, I also added -Xlint:all,-options and -Werror compiler options, which (for javac) enable most warnings and any warning will stop the compilation. Not sure if this is a good idea or not, please let me know if I should undo that.\r\n\r\nWhat do you think?\r\n\r\nThanks,\r\n    Jan","created_at":"2015-06-04T19:21:05Z","updated_at":"2015-07-13T13:17:11Z","closed_at":"2015-07-13T13:17:11Z","merged_at":null,"merge_commit_sha":"28a7423c5f0ed007ae29f5e783b68944e6c6f66e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jline/jline2/pulls/187/commits","review_comments_url":"https://api.github.com/repos/jline/jline2/pulls/187/comments","review_comment_url":"https://api.github.com/repos/jline/jline2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jline/jline2/issues/187/comments","statuses_url":"https://api.github.com/repos/jline/jline2/statuses/dcb8aac3394ce8d4a45ef7b5db5c77aec462aa31","head":{"label":"jlahoda:fix-warnings","ref":"fix-warnings","sha":"dcb8aac3394ce8d4a45ef7b5db5c77aec462aa31","user":{"login":"jlahoda","id":124144,"avatar_url":"https://avatars.githubusercontent.com/u/124144?v=3","gravatar_id":"","url":"https://api.github.com/users/jlahoda","html_url":"https://github.com/jlahoda","followers_url":"https://api.github.com/users/jlahoda/followers","following_url":"https://api.github.com/users/jlahoda/following{/other_user}","gists_url":"https://api.github.com/users/jlahoda/gists{/gist_id}","starred_url":"https://api.github.com/users/jlahoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlahoda/subscriptions","organizations_url":"https://api.github.com/users/jlahoda/orgs","repos_url":"https://api.github.com/users/jlahoda/repos","events_url":"https://api.github.com/users/jlahoda/events{/privacy}","received_events_url":"https://api.github.com/users/jlahoda/received_events","type":"User","site_admin":false},"repo":{"id":36463779,"name":"jline2","full_name":"jlahoda/jline2","owner":{"login":"jlahoda","id":124144,"avatar_url":"https://avatars.githubusercontent.com/u/124144?v=3","gravatar_id":"","url":"https://api.github.com/users/jlahoda","html_url":"https://github.com/jlahoda","followers_url":"https://api.github.com/users/jlahoda/followers","following_url":"https://api.github.com/users/jlahoda/following{/other_user}","gists_url":"https://api.github.com/users/jlahoda/gists{/gist_id}","starred_url":"https://api.github.com/users/jlahoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlahoda/subscriptions","organizations_url":"https://api.github.com/users/jlahoda/orgs","repos_url":"https://api.github.com/users/jlahoda/repos","events_url":"https://api.github.com/users/jlahoda/events{/privacy}","received_events_url":"https://api.github.com/users/jlahoda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jlahoda/jline2","description":"The new Jline","fork":true,"url":"https://api.github.com/repos/jlahoda/jline2","forks_url":"https://api.github.com/repos/jlahoda/jline2/forks","keys_url":"https://api.github.com/repos/jlahoda/jline2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlahoda/jline2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlahoda/jline2/teams","hooks_url":"https://api.github.com/repos/jlahoda/jline2/hooks","issue_events_url":"https://api.github.com/repos/jlahoda/jline2/issues/events{/number}","events_url":"https://api.github.com/repos/jlahoda/jline2/events","assignees_url":"https://api.github.com/repos/jlahoda/jline2/assignees{/user}","branches_url":"https://api.github.com/repos/jlahoda/jline2/branches{/branch}","tags_url":"https://api.github.com/repos/jlahoda/jline2/tags","blobs_url":"https://api.github.com/repos/jlahoda/jline2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlahoda/jline2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlahoda/jline2/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlahoda/jline2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlahoda/jline2/statuses/{sha}","languages_url":"https://api.github.com/repos/jlahoda/jline2/languages","stargazers_url":"https://api.github.com/repos/jlahoda/jline2/stargazers","contributors_url":"https://api.github.com/repos/jlahoda/jline2/contributors","subscribers_url":"https://api.github.com/repos/jlahoda/jline2/subscribers","subscription_url":"https://api.github.com/repos/jlahoda/jline2/subscription","commits_url":"https://api.github.com/repos/jlahoda/jline2/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlahoda/jline2/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlahoda/jline2/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlahoda/jline2/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlahoda/jline2/contents/{+path}","compare_url":"https://api.github.com/repos/jlahoda/jline2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlahoda/jline2/merges","archive_url":"https://api.github.com/repos/jlahoda/jline2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlahoda/jline2/downloads","issues_url":"https://api.github.com/repos/jlahoda/jline2/issues{/number}","pulls_url":"https://api.github.com/repos/jlahoda/jline2/pulls{/number}","milestones_url":"https://api.github.com/repos/jlahoda/jline2/milestones{/number}","notifications_url":"https://api.github.com/repos/jlahoda/jline2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlahoda/jline2/labels{/name}","releases_url":"https://api.github.com/repos/jlahoda/jline2/releases{/id}","created_at":"2015-05-28T20:18:14Z","updated_at":"2015-05-28T20:18:14Z","pushed_at":"2015-06-04T17:49:23Z","git_url":"git://github.com/jlahoda/jline2.git","ssh_url":"git@github.com:jlahoda/jline2.git","clone_url":"https://github.com/jlahoda/jline2.git","svn_url":"https://github.com/jlahoda/jline2","homepage":"http://jline.github.com/jline2/","size":3419,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jline:master","ref":"master","sha":"8d6c53c0c035435bbb14e8c600391c7c95f95aa0","user":{"login":"jline","id":711075,"avatar_url":"https://avatars.githubusercontent.com/u/711075?v=3","gravatar_id":"","url":"https://api.github.com/users/jline","html_url":"https://github.com/jline","followers_url":"https://api.github.com/users/jline/followers","following_url":"https://api.github.com/users/jline/following{/other_user}","gists_url":"https://api.github.com/users/jline/gists{/gist_id}","starred_url":"https://api.github.com/users/jline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jline/subscriptions","organizations_url":"https://api.github.com/users/jline/orgs","repos_url":"https://api.github.com/users/jline/repos","events_url":"https://api.github.com/users/jline/events{/privacy}","received_events_url":"https://api.github.com/users/jline/received_events","type":"Organization","site_admin":false},"repo":{"id":1577604,"name":"jline2","full_name":"jline/jline2","owner":{"login":"jline","id":711075,"avatar_url":"https://avatars.githubusercontent.com/u/711075?v=3","gravatar_id":"","url":"https://api.github.com/users/jline","html_url":"https://github.com/jline","followers_url":"https://api.github.com/users/jline/followers","following_url":"https://api.github.com/users/jline/following{/other_user}","gists_url":"https://api.github.com/users/jline/gists{/gist_id}","starred_url":"https://api.github.com/users/jline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jline/subscriptions","organizations_url":"https://api.github.com/users/jline/orgs","repos_url":"https://api.github.com/users/jline/repos","events_url":"https://api.github.com/users/jline/events{/privacy}","received_events_url":"https://api.github.com/users/jline/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jline/jline2","description":"The new Jline","fork":false,"url":"https://api.github.com/repos/jline/jline2","forks_url":"https://api.github.com/repos/jline/jline2/forks","keys_url":"https://api.github.com/repos/jline/jline2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jline/jline2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jline/jline2/teams","hooks_url":"https://api.github.com/repos/jline/jline2/hooks","issue_events_url":"https://api.github.com/repos/jline/jline2/issues/events{/number}","events_url":"https://api.github.com/repos/jline/jline2/events","assignees_url":"https://api.github.com/repos/jline/jline2/assignees{/user}","branches_url":"https://api.github.com/repos/jline/jline2/branches{/branch}","tags_url":"https://api.github.com/repos/jline/jline2/tags","blobs_url":"https://api.github.com/repos/jline/jline2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jline/jline2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jline/jline2/git/refs{/sha}","trees_url":"https://api.github.com/repos/jline/jline2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jline/jline2/statuses/{sha}","languages_url":"https://api.github.com/repos/jline/jline2/languages","stargazers_url":"https://api.github.com/repos/jline/jline2/stargazers","contributors_url":"https://api.github.com/repos/jline/jline2/contributors","subscribers_url":"https://api.github.com/repos/jline/jline2/subscribers","subscription_url":"https://api.github.com/repos/jline/jline2/subscription","commits_url":"https://api.github.com/repos/jline/jline2/commits{/sha}","git_commits_url":"https://api.github.com/repos/jline/jline2/git/commits{/sha}","comments_url":"https://api.github.com/repos/jline/jline2/comments{/number}","issue_comment_url":"https://api.github.com/repos/jline/jline2/issues/comments{/number}","contents_url":"https://api.github.com/repos/jline/jline2/contents/{+path}","compare_url":"https://api.github.com/repos/jline/jline2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jline/jline2/merges","archive_url":"https://api.github.com/repos/jline/jline2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jline/jline2/downloads","issues_url":"https://api.github.com/repos/jline/jline2/issues{/number}","pulls_url":"https://api.github.com/repos/jline/jline2/pulls{/number}","milestones_url":"https://api.github.com/repos/jline/jline2/milestones{/number}","notifications_url":"https://api.github.com/repos/jline/jline2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jline/jline2/labels{/name}","releases_url":"https://api.github.com/repos/jline/jline2/releases{/id}","created_at":"2011-04-06T14:53:44Z","updated_at":"2015-07-12T12:37:30Z","pushed_at":"2015-07-13T13:16:36Z","git_url":"git://github.com/jline/jline2.git","ssh_url":"git@github.com:jline/jline2.git","clone_url":"https://github.com/jline/jline2.git","svn_url":"https://github.com/jline/jline2","homepage":"http://jline.github.com/jline2/","size":4433,"stargazers_count":401,"watchers_count":401,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":127,"mirror_url":null,"open_issues_count":61,"forks":127,"open_issues":61,"watchers":401,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jline/jline2/pulls/187"},"html":{"href":"https://github.com/jline/jline2/pull/187"},"issue":{"href":"https://api.github.com/repos/jline/jline2/issues/187"},"comments":{"href":"https://api.github.com/repos/jline/jline2/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/jline/jline2/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/jline/jline2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jline/jline2/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/jline/jline2/statuses/dcb8aac3394ce8d4a45ef7b5db5c77aec462aa31"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":22,"deletions":11,"changed_files":7}}