{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/26575183","id":26575183,"diff_hunk":"@@ -0,0 +1,35 @@\n+<%! from django.utils.translation import ugettext as _ %>\n+<%! import mako.runtime %>\n+<% mako.runtime.UNDEFINED = '' %>\n+\n+<%\n+    # set doc language direction\n+    from django.utils.translation import get_language_bidi\n+    dir_rtl = 'rtl' if get_language_bidi() else 'ltr'\n+%>\n+\n+<!DOCTYPE html>\n+<html class=\"no-js\" lang=\"en\">\n+    <head dir=-\"${dir_rtl}\">\n+        <meta http-equiv=\"X-UA-Compatible\" content=\"IE=edge\">\n+        <meta charset=\"utf-8\">\n+        <meta name=\"viewport\" content=\"width=device-width, initial-scale=1\">\n+\n+        <title>${document_title}</title>\n+\n+        <!-- TODO: add description -->","path":"lms/templates/certificates/certificate-base.html","position":20,"original_position":20,"commit_id":"174b4453b846aa3cc058e333406dea207f009217","original_commit_id":"85065a6ab3419ee8e8bdb63cb43f29455d51afe6","user":{"login":"marcotuts","id":2023680,"avatar_url":"https://avatars.githubusercontent.com/u/2023680?v=3","gravatar_id":"","url":"https://api.github.com/users/marcotuts","html_url":"https://github.com/marcotuts","followers_url":"https://api.github.com/users/marcotuts/followers","following_url":"https://api.github.com/users/marcotuts/following{/other_user}","gists_url":"https://api.github.com/users/marcotuts/gists{/gist_id}","starred_url":"https://api.github.com/users/marcotuts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcotuts/subscriptions","organizations_url":"https://api.github.com/users/marcotuts/orgs","repos_url":"https://api.github.com/users/marcotuts/repos","events_url":"https://api.github.com/users/marcotuts/events{/privacy}","received_events_url":"https://api.github.com/users/marcotuts/received_events","type":"User","site_admin":false},"body":"I'm ok leaving the description field off for now. ","created_at":"2015-03-17T14:12:29Z","updated_at":"2015-03-17T14:12:29Z","html_url":"https://github.com/edx/edx-platform/pull/7345#discussion_r26575183","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/7345","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/26575183"},"html":{"href":"https://github.com/edx/edx-platform/pull/7345#discussion_r26575183"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/7345"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/7345","id":31145304,"html_url":"https://github.com/edx/edx-platform/pull/7345","diff_url":"https://github.com/edx/edx-platform/pull/7345.diff","patch_url":"https://github.com/edx/edx-platform/pull/7345.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/7345","number":7345,"state":"open","locked":false,"title":"Certificates: Revising Web Templates + UI for Open edX Use","user":{"login":"talbs","id":163763,"avatar_url":"https://avatars.githubusercontent.com/u/163763?v=3","gravatar_id":"","url":"https://api.github.com/users/talbs","html_url":"https://github.com/talbs","followers_url":"https://api.github.com/users/talbs/followers","following_url":"https://api.github.com/users/talbs/following{/other_user}","gists_url":"https://api.github.com/users/talbs/gists{/gist_id}","starred_url":"https://api.github.com/users/talbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talbs/subscriptions","organizations_url":"https://api.github.com/users/talbs/orgs","repos_url":"https://api.github.com/users/talbs/repos","events_url":"https://api.github.com/users/talbs/events{/privacy}","received_events_url":"https://api.github.com/users/talbs/received_events","type":"User","site_admin":false},"body":"This work includes some first steps in abstracting out an MVP web view for certificates/achievements. It focuses on:\r\n\r\n* moving templates and assets into their final places\r\n* abstracting out edX-specific copy and UI from the base edX certificate verification views.\r\n* moving the front end code from the base edX certificate verification views to our current standards and libraries\r\n\r\n- - -\r\n\r\nA few todo items still remaining:\r\n\r\n* ~~Move Sass comments to new convention~~\r\n* ~~Add in RTL vendor code~~\r\n* ~~Compile Sass to LTR + RTL files~~\r\n* ~~Change breakpoint names to new standards~~\r\n\r\n- - -\r\n\r\nHere's a local preview of what the view looks like now:\r\n\r\n![screen shot 2015-03-16 at 9 10 48 am](https://cloud.githubusercontent.com/assets/163763/6666820/53eb4eca-cbbe-11e4-914b-9d477ebfa1b5.png)\r\n","created_at":"2015-03-13T17:13:44Z","updated_at":"2015-03-17T14:12:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1c6987d9d33f7933256a504a97daba3168425ac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/7345/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/7345/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/7345/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/174b4453b846aa3cc058e333406dea207f009217","head":{"label":"edx:talbs/certs-webview-uicleanup","ref":"talbs/certs-webview-uicleanup","sha":"174b4453b846aa3cc058e333406dea207f009217","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"Open edX, the edX platform that powers http://edx.org","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-03-17T13:34:27Z","pushed_at":"2015-03-17T14:02:38Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://openedx.org/","size":1823791,"stargazers_count":1795,"watchers_count":1795,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1022,"mirror_url":null,"open_issues_count":142,"forks":1022,"open_issues":142,"watchers":1795,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"cb2c8bc8c71164f964e33928c344321d1237d34d","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"Open edX, the edX platform that powers http://edx.org","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-03-17T13:34:27Z","pushed_at":"2015-03-17T14:02:38Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://openedx.org/","size":1823791,"stargazers_count":1795,"watchers_count":1795,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1022,"mirror_url":null,"open_issues_count":142,"forks":1022,"open_issues":142,"watchers":1795,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/7345"},"html":{"href":"https://github.com/edx/edx-platform/pull/7345"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/7345"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/7345/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/7345/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/7345/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/174b4453b846aa3cc058e333406dea207f009217"}}}}