{"action":"created","comment":{"url":"https://api.github.com/repos/macropodhq/macropod-components/pulls/comments/23984039","id":23984039,"diff_hunk":"@@ -2,19 +2,57 @@\n \n require('./button.scss');\n \n-var React = require('react');\n+var React = require('react/addons');\n+var classSet = React.addons.classSet;\n+var _ = require('lodash-node');\n+\n+var validTypes = [\n+  'submit',\n+  'reset',\n+  'button',\n+];\n \n module.exports = React.createClass({\n   displayName: 'Button',\n \n+  propTypes: {\n+    small: React.PropTypes.bool,\n+    skeleton: React.PropTypes.bool,\n+    success: React.PropTypes.bool,\n+    cancel: React.PropTypes.bool,\n+    type: function(props, propName) {\n+      if (\n+        propName in props &&\n+        !_.contains(validTypes, props[propName])\n+      ) {\n+        // type is depricated because it overlaps with the built in html attribute","path":"packages/button/index.jsx","position":28,"original_position":28,"commit_id":"868fb9e1bb2b7326eb8dd58ebd294b78f51af8b0","original_commit_id":"868fb9e1bb2b7326eb8dd58ebd294b78f51af8b0","user":{"login":"grapegravity","id":282113,"avatar_url":"https://avatars.githubusercontent.com/u/282113?v=3","gravatar_id":"","url":"https://api.github.com/users/grapegravity","html_url":"https://github.com/grapegravity","followers_url":"https://api.github.com/users/grapegravity/followers","following_url":"https://api.github.com/users/grapegravity/following{/other_user}","gists_url":"https://api.github.com/users/grapegravity/gists{/gist_id}","starred_url":"https://api.github.com/users/grapegravity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grapegravity/subscriptions","organizations_url":"https://api.github.com/users/grapegravity/orgs","repos_url":"https://api.github.com/users/grapegravity/repos","events_url":"https://api.github.com/users/grapegravity/events{/privacy}","received_events_url":"https://api.github.com/users/grapegravity/received_events","type":"User","site_admin":false},"body":"Would you mind correcting `depricated` to `deprecated` here?","created_at":"2015-02-03T05:50:11Z","updated_at":"2015-02-03T05:50:11Z","html_url":"https://github.com/macropodhq/macropod-components/pull/156#discussion_r23984039","pull_request_url":"https://api.github.com/repos/macropodhq/macropod-components/pulls/156","_links":{"self":{"href":"https://api.github.com/repos/macropodhq/macropod-components/pulls/comments/23984039"},"html":{"href":"https://github.com/macropodhq/macropod-components/pull/156#discussion_r23984039"},"pull_request":{"href":"https://api.github.com/repos/macropodhq/macropod-components/pulls/156"}}},"pull_request":{"url":"https://api.github.com/repos/macropodhq/macropod-components/pulls/156","id":28517766,"html_url":"https://github.com/macropodhq/macropod-components/pull/156","diff_url":"https://github.com/macropodhq/macropod-components/pull/156.diff","patch_url":"https://github.com/macropodhq/macropod-components/pull/156.patch","issue_url":"https://api.github.com/repos/macropodhq/macropod-components/issues/156","number":156,"state":"open","locked":false,"title":"extend button api and type attribute deprecation","user":{"login":"nelix","id":33324,"avatar_url":"https://avatars.githubusercontent.com/u/33324?v=3","gravatar_id":"","url":"https://api.github.com/users/nelix","html_url":"https://github.com/nelix","followers_url":"https://api.github.com/users/nelix/followers","following_url":"https://api.github.com/users/nelix/following{/other_user}","gists_url":"https://api.github.com/users/nelix/gists{/gist_id}","starred_url":"https://api.github.com/users/nelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelix/subscriptions","organizations_url":"https://api.github.com/users/nelix/orgs","repos_url":"https://api.github.com/users/nelix/repos","events_url":"https://api.github.com/users/nelix/events{/privacy}","received_events_url":"https://api.github.com/users/nelix/received_events","type":"User","site_admin":false},"body":"![screen shot 2015-02-03 at 11 52 27 am](https://cloud.githubusercontent.com/assets/33324/6012390/b4fac9fe-ab9b-11e4-9855-789134dfedbb.png)\r\n\r\nBasic api for the main types of buttons I saw in stack client, willing to take this further.\r\nI don't like the way the colours work because the only overridable colours are listed by name, but thats an existing issue. I'm open for suggestions on a naming scheme that is easier to override for colours.","created_at":"2015-02-03T00:58:32Z","updated_at":"2015-02-03T05:50:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5a48969d7e4c3b556540d2a69dd6d5bd545d152","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/macropodhq/macropod-components/pulls/156/commits","review_comments_url":"https://api.github.com/repos/macropodhq/macropod-components/pulls/156/comments","review_comment_url":"https://api.github.com/repos/macropodhq/macropod-components/pulls/comments/{number}","comments_url":"https://api.github.com/repos/macropodhq/macropod-components/issues/156/comments","statuses_url":"https://api.github.com/repos/macropodhq/macropod-components/statuses/868fb9e1bb2b7326eb8dd58ebd294b78f51af8b0","head":{"label":"macropodhq:button-extension","ref":"button-extension","sha":"868fb9e1bb2b7326eb8dd58ebd294b78f51af8b0","user":{"login":"macropodhq","id":262822,"avatar_url":"https://avatars.githubusercontent.com/u/262822?v=3","gravatar_id":"","url":"https://api.github.com/users/macropodhq","html_url":"https://github.com/macropodhq","followers_url":"https://api.github.com/users/macropodhq/followers","following_url":"https://api.github.com/users/macropodhq/following{/other_user}","gists_url":"https://api.github.com/users/macropodhq/gists{/gist_id}","starred_url":"https://api.github.com/users/macropodhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macropodhq/subscriptions","organizations_url":"https://api.github.com/users/macropodhq/orgs","repos_url":"https://api.github.com/users/macropodhq/repos","events_url":"https://api.github.com/users/macropodhq/events{/privacy}","received_events_url":"https://api.github.com/users/macropodhq/received_events","type":"Organization","site_admin":false},"repo":{"id":23690791,"name":"macropod-components","full_name":"macropodhq/macropod-components","owner":{"login":"macropodhq","id":262822,"avatar_url":"https://avatars.githubusercontent.com/u/262822?v=3","gravatar_id":"","url":"https://api.github.com/users/macropodhq","html_url":"https://github.com/macropodhq","followers_url":"https://api.github.com/users/macropodhq/followers","following_url":"https://api.github.com/users/macropodhq/following{/other_user}","gists_url":"https://api.github.com/users/macropodhq/gists{/gist_id}","starred_url":"https://api.github.com/users/macropodhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macropodhq/subscriptions","organizations_url":"https://api.github.com/users/macropodhq/orgs","repos_url":"https://api.github.com/users/macropodhq/repos","events_url":"https://api.github.com/users/macropodhq/events{/privacy}","received_events_url":"https://api.github.com/users/macropodhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/macropodhq/macropod-components","description":"Playground for and library of react components","fork":false,"url":"https://api.github.com/repos/macropodhq/macropod-components","forks_url":"https://api.github.com/repos/macropodhq/macropod-components/forks","keys_url":"https://api.github.com/repos/macropodhq/macropod-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/macropodhq/macropod-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/macropodhq/macropod-components/teams","hooks_url":"https://api.github.com/repos/macropodhq/macropod-components/hooks","issue_events_url":"https://api.github.com/repos/macropodhq/macropod-components/issues/events{/number}","events_url":"https://api.github.com/repos/macropodhq/macropod-components/events","assignees_url":"https://api.github.com/repos/macropodhq/macropod-components/assignees{/user}","branches_url":"https://api.github.com/repos/macropodhq/macropod-components/branches{/branch}","tags_url":"https://api.github.com/repos/macropodhq/macropod-components/tags","blobs_url":"https://api.github.com/repos/macropodhq/macropod-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/macropodhq/macropod-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/macropodhq/macropod-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/macropodhq/macropod-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/macropodhq/macropod-components/statuses/{sha}","languages_url":"https://api.github.com/repos/macropodhq/macropod-components/languages","stargazers_url":"https://api.github.com/repos/macropodhq/macropod-components/stargazers","contributors_url":"https://api.github.com/repos/macropodhq/macropod-components/contributors","subscribers_url":"https://api.github.com/repos/macropodhq/macropod-components/subscribers","subscription_url":"https://api.github.com/repos/macropodhq/macropod-components/subscription","commits_url":"https://api.github.com/repos/macropodhq/macropod-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/macropodhq/macropod-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/macropodhq/macropod-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/macropodhq/macropod-components/issues/comments/{number}","contents_url":"https://api.github.com/repos/macropodhq/macropod-components/contents/{+path}","compare_url":"https://api.github.com/repos/macropodhq/macropod-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/macropodhq/macropod-components/merges","archive_url":"https://api.github.com/repos/macropodhq/macropod-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/macropodhq/macropod-components/downloads","issues_url":"https://api.github.com/repos/macropodhq/macropod-components/issues{/number}","pulls_url":"https://api.github.com/repos/macropodhq/macropod-components/pulls{/number}","milestones_url":"https://api.github.com/repos/macropodhq/macropod-components/milestones{/number}","notifications_url":"https://api.github.com/repos/macropodhq/macropod-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/macropodhq/macropod-components/labels{/name}","releases_url":"https://api.github.com/repos/macropodhq/macropod-components/releases{/id}","created_at":"2014-09-05T04:58:27Z","updated_at":"2015-02-02T00:25:06Z","pushed_at":"2015-02-03T04:26:32Z","git_url":"git://github.com/macropodhq/macropod-components.git","ssh_url":"git@github.com:macropodhq/macropod-components.git","clone_url":"https://github.com/macropodhq/macropod-components.git","svn_url":"https://github.com/macropodhq/macropod-components","homepage":null,"size":2885,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"macropodhq:master","ref":"master","sha":"5add1a95d03f70a9a71dcca10cf3c401f0b99981","user":{"login":"macropodhq","id":262822,"avatar_url":"https://avatars.githubusercontent.com/u/262822?v=3","gravatar_id":"","url":"https://api.github.com/users/macropodhq","html_url":"https://github.com/macropodhq","followers_url":"https://api.github.com/users/macropodhq/followers","following_url":"https://api.github.com/users/macropodhq/following{/other_user}","gists_url":"https://api.github.com/users/macropodhq/gists{/gist_id}","starred_url":"https://api.github.com/users/macropodhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macropodhq/subscriptions","organizations_url":"https://api.github.com/users/macropodhq/orgs","repos_url":"https://api.github.com/users/macropodhq/repos","events_url":"https://api.github.com/users/macropodhq/events{/privacy}","received_events_url":"https://api.github.com/users/macropodhq/received_events","type":"Organization","site_admin":false},"repo":{"id":23690791,"name":"macropod-components","full_name":"macropodhq/macropod-components","owner":{"login":"macropodhq","id":262822,"avatar_url":"https://avatars.githubusercontent.com/u/262822?v=3","gravatar_id":"","url":"https://api.github.com/users/macropodhq","html_url":"https://github.com/macropodhq","followers_url":"https://api.github.com/users/macropodhq/followers","following_url":"https://api.github.com/users/macropodhq/following{/other_user}","gists_url":"https://api.github.com/users/macropodhq/gists{/gist_id}","starred_url":"https://api.github.com/users/macropodhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macropodhq/subscriptions","organizations_url":"https://api.github.com/users/macropodhq/orgs","repos_url":"https://api.github.com/users/macropodhq/repos","events_url":"https://api.github.com/users/macropodhq/events{/privacy}","received_events_url":"https://api.github.com/users/macropodhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/macropodhq/macropod-components","description":"Playground for and library of react components","fork":false,"url":"https://api.github.com/repos/macropodhq/macropod-components","forks_url":"https://api.github.com/repos/macropodhq/macropod-components/forks","keys_url":"https://api.github.com/repos/macropodhq/macropod-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/macropodhq/macropod-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/macropodhq/macropod-components/teams","hooks_url":"https://api.github.com/repos/macropodhq/macropod-components/hooks","issue_events_url":"https://api.github.com/repos/macropodhq/macropod-components/issues/events{/number}","events_url":"https://api.github.com/repos/macropodhq/macropod-components/events","assignees_url":"https://api.github.com/repos/macropodhq/macropod-components/assignees{/user}","branches_url":"https://api.github.com/repos/macropodhq/macropod-components/branches{/branch}","tags_url":"https://api.github.com/repos/macropodhq/macropod-components/tags","blobs_url":"https://api.github.com/repos/macropodhq/macropod-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/macropodhq/macropod-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/macropodhq/macropod-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/macropodhq/macropod-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/macropodhq/macropod-components/statuses/{sha}","languages_url":"https://api.github.com/repos/macropodhq/macropod-components/languages","stargazers_url":"https://api.github.com/repos/macropodhq/macropod-components/stargazers","contributors_url":"https://api.github.com/repos/macropodhq/macropod-components/contributors","subscribers_url":"https://api.github.com/repos/macropodhq/macropod-components/subscribers","subscription_url":"https://api.github.com/repos/macropodhq/macropod-components/subscription","commits_url":"https://api.github.com/repos/macropodhq/macropod-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/macropodhq/macropod-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/macropodhq/macropod-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/macropodhq/macropod-components/issues/comments/{number}","contents_url":"https://api.github.com/repos/macropodhq/macropod-components/contents/{+path}","compare_url":"https://api.github.com/repos/macropodhq/macropod-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/macropodhq/macropod-components/merges","archive_url":"https://api.github.com/repos/macropodhq/macropod-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/macropodhq/macropod-components/downloads","issues_url":"https://api.github.com/repos/macropodhq/macropod-components/issues{/number}","pulls_url":"https://api.github.com/repos/macropodhq/macropod-components/pulls{/number}","milestones_url":"https://api.github.com/repos/macropodhq/macropod-components/milestones{/number}","notifications_url":"https://api.github.com/repos/macropodhq/macropod-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/macropodhq/macropod-components/labels{/name}","releases_url":"https://api.github.com/repos/macropodhq/macropod-components/releases{/id}","created_at":"2014-09-05T04:58:27Z","updated_at":"2015-02-02T00:25:06Z","pushed_at":"2015-02-03T04:26:32Z","git_url":"git://github.com/macropodhq/macropod-components.git","ssh_url":"git@github.com:macropodhq/macropod-components.git","clone_url":"https://github.com/macropodhq/macropod-components.git","svn_url":"https://github.com/macropodhq/macropod-components","homepage":null,"size":2885,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/macropodhq/macropod-components/pulls/156"},"html":{"href":"https://github.com/macropodhq/macropod-components/pull/156"},"issue":{"href":"https://api.github.com/repos/macropodhq/macropod-components/issues/156"},"comments":{"href":"https://api.github.com/repos/macropodhq/macropod-components/issues/156/comments"},"review_comments":{"href":"https://api.github.com/repos/macropodhq/macropod-components/pulls/156/comments"},"review_comment":{"href":"https://api.github.com/repos/macropodhq/macropod-components/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/macropodhq/macropod-components/pulls/156/commits"},"statuses":{"href":"https://api.github.com/repos/macropodhq/macropod-components/statuses/868fb9e1bb2b7326eb8dd58ebd294b78f51af8b0"}}}}