{"action":"created","comment":{"url":"https://api.github.com/repos/unl/UNL_Directory/pulls/comments/25198429","id":25198429,"diff_hunk":"@@ -63,9 +63,25 @@ protected function getCache()\n         ));\n     }\n \n+    protected function getBuildings() {","path":"src/UNL/Peoplefinder/Record.php","position":4,"original_position":4,"commit_id":"8798275bbbcef763f5e8038183fa1181c9fe0a1c","original_commit_id":"8798275bbbcef763f5e8038183fa1181c9fe0a1c","user":{"login":"mfairchild365","id":498678,"avatar_url":"https://avatars.githubusercontent.com/u/498678?v=3","gravatar_id":"","url":"https://api.github.com/users/mfairchild365","html_url":"https://github.com/mfairchild365","followers_url":"https://api.github.com/users/mfairchild365/followers","following_url":"https://api.github.com/users/mfairchild365/following{/other_user}","gists_url":"https://api.github.com/users/mfairchild365/gists{/gist_id}","starred_url":"https://api.github.com/users/mfairchild365/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfairchild365/subscriptions","organizations_url":"https://api.github.com/users/mfairchild365/orgs","repos_url":"https://api.github.com/users/mfairchild365/repos","events_url":"https://api.github.com/users/mfairchild365/events{/privacy}","received_events_url":"https://api.github.com/users/mfairchild365/received_events","type":"User","site_admin":false},"body":"Awesome!  I like seeing code broken out into testable, mockable functions.","created_at":"2015-02-23T20:26:25Z","updated_at":"2015-02-23T20:26:25Z","html_url":"https://github.com/unl/UNL_Directory/pull/22#discussion_r25198429","pull_request_url":"https://api.github.com/repos/unl/UNL_Directory/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/unl/UNL_Directory/pulls/comments/25198429"},"html":{"href":"https://github.com/unl/UNL_Directory/pull/22#discussion_r25198429"},"pull_request":{"href":"https://api.github.com/repos/unl/UNL_Directory/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/unl/UNL_Directory/pulls/22","id":29837341,"html_url":"https://github.com/unl/UNL_Directory/pull/22","diff_url":"https://github.com/unl/UNL_Directory/pull/22.diff","patch_url":"https://github.com/unl/UNL_Directory/pull/22.patch","issue_url":"https://api.github.com/repos/unl/UNL_Directory/issues/22","number":22,"state":"open","locked":false,"title":"Unit tests for Record. ","user":{"login":"tlemburg","id":1199848,"avatar_url":"https://avatars.githubusercontent.com/u/1199848?v=3","gravatar_id":"","url":"https://api.github.com/users/tlemburg","html_url":"https://github.com/tlemburg","followers_url":"https://api.github.com/users/tlemburg/followers","following_url":"https://api.github.com/users/tlemburg/following{/other_user}","gists_url":"https://api.github.com/users/tlemburg/gists{/gist_id}","starred_url":"https://api.github.com/users/tlemburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlemburg/subscriptions","organizations_url":"https://api.github.com/users/tlemburg/orgs","repos_url":"https://api.github.com/users/tlemburg/repos","events_url":"https://api.github.com/users/tlemburg/events{/privacy}","received_events_url":"https://api.github.com/users/tlemburg/received_events","type":"User","site_admin":false},"body":"First things first: I moved the current test suite from the folder tests to legacy_tests. These files looked VERY outdated and heavy so I have temporarily moved them; if we think they are worthless I can delete.\r\n\r\nThis is phpunit testing for the address computing functionality in the PeopleFinder Record class. The tests are very unit which means they don't try to touch the DB or anything, they simply see what a certain method returns. If we like these, we can add more later.\r\n\r\nFinally, there's Travis-CI integration as well.","created_at":"2015-02-23T19:28:00Z","updated_at":"2015-02-23T20:26:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c5489dc77c77d27f3ab8d4a3c3ee9ccb5a2241e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/unl/UNL_Directory/pulls/22/commits","review_comments_url":"https://api.github.com/repos/unl/UNL_Directory/pulls/22/comments","review_comment_url":"https://api.github.com/repos/unl/UNL_Directory/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unl/UNL_Directory/issues/22/comments","statuses_url":"https://api.github.com/repos/unl/UNL_Directory/statuses/8798275bbbcef763f5e8038183fa1181c9fe0a1c","head":{"label":"tlemburg:feature/address-record-tests","ref":"feature/address-record-tests","sha":"8798275bbbcef763f5e8038183fa1181c9fe0a1c","user":{"login":"tlemburg","id":1199848,"avatar_url":"https://avatars.githubusercontent.com/u/1199848?v=3","gravatar_id":"","url":"https://api.github.com/users/tlemburg","html_url":"https://github.com/tlemburg","followers_url":"https://api.github.com/users/tlemburg/followers","following_url":"https://api.github.com/users/tlemburg/following{/other_user}","gists_url":"https://api.github.com/users/tlemburg/gists{/gist_id}","starred_url":"https://api.github.com/users/tlemburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlemburg/subscriptions","organizations_url":"https://api.github.com/users/tlemburg/orgs","repos_url":"https://api.github.com/users/tlemburg/repos","events_url":"https://api.github.com/users/tlemburg/events{/privacy}","received_events_url":"https://api.github.com/users/tlemburg/received_events","type":"User","site_admin":false},"repo":{"id":30032000,"name":"UNL_Directory","full_name":"tlemburg/UNL_Directory","owner":{"login":"tlemburg","id":1199848,"avatar_url":"https://avatars.githubusercontent.com/u/1199848?v=3","gravatar_id":"","url":"https://api.github.com/users/tlemburg","html_url":"https://github.com/tlemburg","followers_url":"https://api.github.com/users/tlemburg/followers","following_url":"https://api.github.com/users/tlemburg/following{/other_user}","gists_url":"https://api.github.com/users/tlemburg/gists{/gist_id}","starred_url":"https://api.github.com/users/tlemburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlemburg/subscriptions","organizations_url":"https://api.github.com/users/tlemburg/orgs","repos_url":"https://api.github.com/users/tlemburg/repos","events_url":"https://api.github.com/users/tlemburg/events{/privacy}","received_events_url":"https://api.github.com/users/tlemburg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tlemburg/UNL_Directory","description":"The UNL Directory","fork":true,"url":"https://api.github.com/repos/tlemburg/UNL_Directory","forks_url":"https://api.github.com/repos/tlemburg/UNL_Directory/forks","keys_url":"https://api.github.com/repos/tlemburg/UNL_Directory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tlemburg/UNL_Directory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tlemburg/UNL_Directory/teams","hooks_url":"https://api.github.com/repos/tlemburg/UNL_Directory/hooks","issue_events_url":"https://api.github.com/repos/tlemburg/UNL_Directory/issues/events{/number}","events_url":"https://api.github.com/repos/tlemburg/UNL_Directory/events","assignees_url":"https://api.github.com/repos/tlemburg/UNL_Directory/assignees{/user}","branches_url":"https://api.github.com/repos/tlemburg/UNL_Directory/branches{/branch}","tags_url":"https://api.github.com/repos/tlemburg/UNL_Directory/tags","blobs_url":"https://api.github.com/repos/tlemburg/UNL_Directory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tlemburg/UNL_Directory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tlemburg/UNL_Directory/git/refs{/sha}","trees_url":"https://api.github.com/repos/tlemburg/UNL_Directory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tlemburg/UNL_Directory/statuses/{sha}","languages_url":"https://api.github.com/repos/tlemburg/UNL_Directory/languages","stargazers_url":"https://api.github.com/repos/tlemburg/UNL_Directory/stargazers","contributors_url":"https://api.github.com/repos/tlemburg/UNL_Directory/contributors","subscribers_url":"https://api.github.com/repos/tlemburg/UNL_Directory/subscribers","subscription_url":"https://api.github.com/repos/tlemburg/UNL_Directory/subscription","commits_url":"https://api.github.com/repos/tlemburg/UNL_Directory/commits{/sha}","git_commits_url":"https://api.github.com/repos/tlemburg/UNL_Directory/git/commits{/sha}","comments_url":"https://api.github.com/repos/tlemburg/UNL_Directory/comments{/number}","issue_comment_url":"https://api.github.com/repos/tlemburg/UNL_Directory/issues/comments{/number}","contents_url":"https://api.github.com/repos/tlemburg/UNL_Directory/contents/{+path}","compare_url":"https://api.github.com/repos/tlemburg/UNL_Directory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tlemburg/UNL_Directory/merges","archive_url":"https://api.github.com/repos/tlemburg/UNL_Directory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tlemburg/UNL_Directory/downloads","issues_url":"https://api.github.com/repos/tlemburg/UNL_Directory/issues{/number}","pulls_url":"https://api.github.com/repos/tlemburg/UNL_Directory/pulls{/number}","milestones_url":"https://api.github.com/repos/tlemburg/UNL_Directory/milestones{/number}","notifications_url":"https://api.github.com/repos/tlemburg/UNL_Directory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tlemburg/UNL_Directory/labels{/name}","releases_url":"https://api.github.com/repos/tlemburg/UNL_Directory/releases{/id}","created_at":"2015-01-29T17:24:50Z","updated_at":"2015-01-29T17:24:54Z","pushed_at":"2015-02-23T19:16:10Z","git_url":"git://github.com/tlemburg/UNL_Directory.git","ssh_url":"git@github.com:tlemburg/UNL_Directory.git","clone_url":"https://github.com/tlemburg/UNL_Directory.git","svn_url":"https://github.com/tlemburg/UNL_Directory","homepage":null,"size":3921,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"unl:master","ref":"master","sha":"287d282ac3025ef7823ce7ec055879dd849c542b","user":{"login":"unl","id":704049,"avatar_url":"https://avatars.githubusercontent.com/u/704049?v=3","gravatar_id":"","url":"https://api.github.com/users/unl","html_url":"https://github.com/unl","followers_url":"https://api.github.com/users/unl/followers","following_url":"https://api.github.com/users/unl/following{/other_user}","gists_url":"https://api.github.com/users/unl/gists{/gist_id}","starred_url":"https://api.github.com/users/unl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unl/subscriptions","organizations_url":"https://api.github.com/users/unl/orgs","repos_url":"https://api.github.com/users/unl/repos","events_url":"https://api.github.com/users/unl/events{/privacy}","received_events_url":"https://api.github.com/users/unl/received_events","type":"Organization","site_admin":false},"repo":{"id":10772673,"name":"UNL_Directory","full_name":"unl/UNL_Directory","owner":{"login":"unl","id":704049,"avatar_url":"https://avatars.githubusercontent.com/u/704049?v=3","gravatar_id":"","url":"https://api.github.com/users/unl","html_url":"https://github.com/unl","followers_url":"https://api.github.com/users/unl/followers","following_url":"https://api.github.com/users/unl/following{/other_user}","gists_url":"https://api.github.com/users/unl/gists{/gist_id}","starred_url":"https://api.github.com/users/unl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unl/subscriptions","organizations_url":"https://api.github.com/users/unl/orgs","repos_url":"https://api.github.com/users/unl/repos","events_url":"https://api.github.com/users/unl/events{/privacy}","received_events_url":"https://api.github.com/users/unl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unl/UNL_Directory","description":"The UNL Directory","fork":false,"url":"https://api.github.com/repos/unl/UNL_Directory","forks_url":"https://api.github.com/repos/unl/UNL_Directory/forks","keys_url":"https://api.github.com/repos/unl/UNL_Directory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unl/UNL_Directory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unl/UNL_Directory/teams","hooks_url":"https://api.github.com/repos/unl/UNL_Directory/hooks","issue_events_url":"https://api.github.com/repos/unl/UNL_Directory/issues/events{/number}","events_url":"https://api.github.com/repos/unl/UNL_Directory/events","assignees_url":"https://api.github.com/repos/unl/UNL_Directory/assignees{/user}","branches_url":"https://api.github.com/repos/unl/UNL_Directory/branches{/branch}","tags_url":"https://api.github.com/repos/unl/UNL_Directory/tags","blobs_url":"https://api.github.com/repos/unl/UNL_Directory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unl/UNL_Directory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unl/UNL_Directory/git/refs{/sha}","trees_url":"https://api.github.com/repos/unl/UNL_Directory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unl/UNL_Directory/statuses/{sha}","languages_url":"https://api.github.com/repos/unl/UNL_Directory/languages","stargazers_url":"https://api.github.com/repos/unl/UNL_Directory/stargazers","contributors_url":"https://api.github.com/repos/unl/UNL_Directory/contributors","subscribers_url":"https://api.github.com/repos/unl/UNL_Directory/subscribers","subscription_url":"https://api.github.com/repos/unl/UNL_Directory/subscription","commits_url":"https://api.github.com/repos/unl/UNL_Directory/commits{/sha}","git_commits_url":"https://api.github.com/repos/unl/UNL_Directory/git/commits{/sha}","comments_url":"https://api.github.com/repos/unl/UNL_Directory/comments{/number}","issue_comment_url":"https://api.github.com/repos/unl/UNL_Directory/issues/comments{/number}","contents_url":"https://api.github.com/repos/unl/UNL_Directory/contents/{+path}","compare_url":"https://api.github.com/repos/unl/UNL_Directory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unl/UNL_Directory/merges","archive_url":"https://api.github.com/repos/unl/UNL_Directory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unl/UNL_Directory/downloads","issues_url":"https://api.github.com/repos/unl/UNL_Directory/issues{/number}","pulls_url":"https://api.github.com/repos/unl/UNL_Directory/pulls{/number}","milestones_url":"https://api.github.com/repos/unl/UNL_Directory/milestones{/number}","notifications_url":"https://api.github.com/repos/unl/UNL_Directory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unl/UNL_Directory/labels{/name}","releases_url":"https://api.github.com/repos/unl/UNL_Directory/releases{/id}","created_at":"2013-06-18T20:19:05Z","updated_at":"2015-01-29T19:41:30Z","pushed_at":"2015-01-29T19:41:30Z","git_url":"git://github.com/unl/UNL_Directory.git","ssh_url":"git@github.com:unl/UNL_Directory.git","clone_url":"https://github.com/unl/UNL_Directory.git","svn_url":"https://github.com/unl/UNL_Directory","homepage":null,"size":4328,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":5,"forks":5,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unl/UNL_Directory/pulls/22"},"html":{"href":"https://github.com/unl/UNL_Directory/pull/22"},"issue":{"href":"https://api.github.com/repos/unl/UNL_Directory/issues/22"},"comments":{"href":"https://api.github.com/repos/unl/UNL_Directory/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/unl/UNL_Directory/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/unl/UNL_Directory/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unl/UNL_Directory/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/unl/UNL_Directory/statuses/8798275bbbcef763f5e8038183fa1181c9fe0a1c"}}}}