{"action":"created","comment":{"url":"https://api.github.com/repos/NYULibraries/findingaids/pulls/comments/23259971","id":23259971,"diff_hunk":"@@ -0,0 +1,12 @@\n+Feature: Search across all libraries\n+  As a researcher, I want to be able to search across all libraries\n+  so that I don't need to know the specific focus of a particular library.\n+\n+  Scenario: default search scope is labeled \"All Libraries\"\n+    Given I am on the default search page\n+    Then I should see a label \"All Libraries\" in the default scope\n+ \n+  Scenario: search is performed across all libraries by default\n+    Given I am on the default search page\n+    And I search on the phrase \"World War || \"\n+    Then I should see results from \"The Fales Library & Special Collections\" and from \"The Tamiment Library & Robert F. Wagner Labor Archives\"","path":"features/search_across_libraries.feature","position":12,"original_position":12,"commit_id":"59c4dde16fa465e19f852633c2df6d65bfa0c50d","original_commit_id":"59c4dde16fa465e19f852633c2df6d65bfa0c50d","user":{"login":"ekate","id":2539494,"avatar_url":"https://avatars.githubusercontent.com/u/2539494?v=3","gravatar_id":"","url":"https://api.github.com/users/ekate","html_url":"https://github.com/ekate","followers_url":"https://api.github.com/users/ekate/followers","following_url":"https://api.github.com/users/ekate/following{/other_user}","gists_url":"https://api.github.com/users/ekate/gists{/gist_id}","starred_url":"https://api.github.com/users/ekate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekate/subscriptions","organizations_url":"https://api.github.com/users/ekate/orgs","repos_url":"https://api.github.com/users/ekate/repos","events_url":"https://api.github.com/users/ekate/events{/privacy}","received_events_url":"https://api.github.com/users/ekate/received_events","type":"User","site_admin":false},"body":"but in the two scenarios this has different meanings- in the first scenario\r\nit just what label reads and in the second scenario it describes how the\r\nsearch is performed. Or do I misunderstand you ?\r\n\r\nOn Tue, Jan 20, 2015 at 4:45 PM, barnabyalter <notifications@github.com>\r\nwrote:\r\n\r\n> In features/search_across_libraries.feature\r\n> <https://github.com/NYULibraries/findingaids/pull/27#discussion-diff-23258743>\r\n> :\r\n>\r\n> > @@ -0,0 +1,12 @@\r\n> > +Feature: Search across all libraries\r\n> > +  As a researcher, I want to be able to search across all libraries\r\n> > +  so that I don't need to know the specific focus of a particular library.\r\n> > +\r\n> > +  Scenario: default search scope is labeled \"All Libraries\"\r\n> > +    Given I am on the default search page\r\n> > +    Then I should see a label \"All Libraries\" in the default scope\r\n> > +\r\n> > +  Scenario: search is performed across all libraries by default\r\n> > +    Given I am on the default search page\r\n> > +    And I search on the phrase \"World War || \"\r\n> > +    Then I should see results from \"The Fales Library & Special Collections\" and from \"The Tamiment Library & Robert F. Wagner Labor Archives\"\r\n>\r\n> @ekate <https://github.com/ekate> Also could you capitalize the scenario\r\n> sentences? And keep consistency when saying \"All Libraries\". If it's title\r\n> case in quotes, keep it that way across the board.\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/NYULibraries/findingaids/pull/27/files#r23258743>.\r\n>\r\n\r\n\r\n\r\n-- \r\nEkaterina Pechekhonova\r\nDigital Library Programmer/Analyst\r\nNew York University\r\nLibraries\r\nemail: ekate@nyu.edu\r\nphone: 212-992-9993","created_at":"2015-01-20T21:59:56Z","updated_at":"2015-01-20T21:59:56Z","html_url":"https://github.com/NYULibraries/findingaids/pull/27#discussion_r23259971","pull_request_url":"https://api.github.com/repos/NYULibraries/findingaids/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/NYULibraries/findingaids/pulls/comments/23259971"},"html":{"href":"https://github.com/NYULibraries/findingaids/pull/27#discussion_r23259971"},"pull_request":{"href":"https://api.github.com/repos/NYULibraries/findingaids/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/NYULibraries/findingaids/pulls/27","id":27535872,"html_url":"https://github.com/NYULibraries/findingaids/pull/27","diff_url":"https://github.com/NYULibraries/findingaids/pull/27.diff","patch_url":"https://github.com/NYULibraries/findingaids/pull/27.patch","issue_url":"https://api.github.com/repos/NYULibraries/findingaids/issues/27","number":27,"state":"open","locked":false,"title":"Added \"All Libraries\" label and tests","user":{"login":"ekate","id":2539494,"avatar_url":"https://avatars.githubusercontent.com/u/2539494?v=3","gravatar_id":"","url":"https://api.github.com/users/ekate","html_url":"https://github.com/ekate","followers_url":"https://api.github.com/users/ekate/followers","following_url":"https://api.github.com/users/ekate/following{/other_user}","gists_url":"https://api.github.com/users/ekate/gists{/gist_id}","starred_url":"https://api.github.com/users/ekate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekate/subscriptions","organizations_url":"https://api.github.com/users/ekate/orgs","repos_url":"https://api.github.com/users/ekate/repos","events_url":"https://api.github.com/users/ekate/events{/privacy}","received_events_url":"https://api.github.com/users/ekate/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-01-16T20:58:00Z","updated_at":"2015-01-20T21:59:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"029b567066986222072ac2a225148742e81c7908","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NYULibraries/findingaids/pulls/27/commits","review_comments_url":"https://api.github.com/repos/NYULibraries/findingaids/pulls/27/comments","review_comment_url":"https://api.github.com/repos/NYULibraries/findingaids/pulls/comments/{number}","comments_url":"https://api.github.com/repos/NYULibraries/findingaids/issues/27/comments","statuses_url":"https://api.github.com/repos/NYULibraries/findingaids/statuses/59c4dde16fa465e19f852633c2df6d65bfa0c50d","head":{"label":"NYULibraries:feature/search_across_libraries","ref":"feature/search_across_libraries","sha":"59c4dde16fa465e19f852633c2df6d65bfa0c50d","user":{"login":"NYULibraries","id":1707000,"avatar_url":"https://avatars.githubusercontent.com/u/1707000?v=3","gravatar_id":"","url":"https://api.github.com/users/NYULibraries","html_url":"https://github.com/NYULibraries","followers_url":"https://api.github.com/users/NYULibraries/followers","following_url":"https://api.github.com/users/NYULibraries/following{/other_user}","gists_url":"https://api.github.com/users/NYULibraries/gists{/gist_id}","starred_url":"https://api.github.com/users/NYULibraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYULibraries/subscriptions","organizations_url":"https://api.github.com/users/NYULibraries/orgs","repos_url":"https://api.github.com/users/NYULibraries/repos","events_url":"https://api.github.com/users/NYULibraries/events{/privacy}","received_events_url":"https://api.github.com/users/NYULibraries/received_events","type":"Organization","site_admin":false},"repo":{"id":9201295,"name":"findingaids","full_name":"NYULibraries/findingaids","owner":{"login":"NYULibraries","id":1707000,"avatar_url":"https://avatars.githubusercontent.com/u/1707000?v=3","gravatar_id":"","url":"https://api.github.com/users/NYULibraries","html_url":"https://github.com/NYULibraries","followers_url":"https://api.github.com/users/NYULibraries/followers","following_url":"https://api.github.com/users/NYULibraries/following{/other_user}","gists_url":"https://api.github.com/users/NYULibraries/gists{/gist_id}","starred_url":"https://api.github.com/users/NYULibraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYULibraries/subscriptions","organizations_url":"https://api.github.com/users/NYULibraries/orgs","repos_url":"https://api.github.com/users/NYULibraries/repos","events_url":"https://api.github.com/users/NYULibraries/events{/privacy}","received_events_url":"https://api.github.com/users/NYULibraries/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NYULibraries/findingaids","description":"","fork":false,"url":"https://api.github.com/repos/NYULibraries/findingaids","forks_url":"https://api.github.com/repos/NYULibraries/findingaids/forks","keys_url":"https://api.github.com/repos/NYULibraries/findingaids/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYULibraries/findingaids/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYULibraries/findingaids/teams","hooks_url":"https://api.github.com/repos/NYULibraries/findingaids/hooks","issue_events_url":"https://api.github.com/repos/NYULibraries/findingaids/issues/events{/number}","events_url":"https://api.github.com/repos/NYULibraries/findingaids/events","assignees_url":"https://api.github.com/repos/NYULibraries/findingaids/assignees{/user}","branches_url":"https://api.github.com/repos/NYULibraries/findingaids/branches{/branch}","tags_url":"https://api.github.com/repos/NYULibraries/findingaids/tags","blobs_url":"https://api.github.com/repos/NYULibraries/findingaids/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYULibraries/findingaids/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYULibraries/findingaids/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYULibraries/findingaids/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYULibraries/findingaids/statuses/{sha}","languages_url":"https://api.github.com/repos/NYULibraries/findingaids/languages","stargazers_url":"https://api.github.com/repos/NYULibraries/findingaids/stargazers","contributors_url":"https://api.github.com/repos/NYULibraries/findingaids/contributors","subscribers_url":"https://api.github.com/repos/NYULibraries/findingaids/subscribers","subscription_url":"https://api.github.com/repos/NYULibraries/findingaids/subscription","commits_url":"https://api.github.com/repos/NYULibraries/findingaids/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYULibraries/findingaids/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYULibraries/findingaids/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYULibraries/findingaids/issues/comments/{number}","contents_url":"https://api.github.com/repos/NYULibraries/findingaids/contents/{+path}","compare_url":"https://api.github.com/repos/NYULibraries/findingaids/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYULibraries/findingaids/merges","archive_url":"https://api.github.com/repos/NYULibraries/findingaids/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYULibraries/findingaids/downloads","issues_url":"https://api.github.com/repos/NYULibraries/findingaids/issues{/number}","pulls_url":"https://api.github.com/repos/NYULibraries/findingaids/pulls{/number}","milestones_url":"https://api.github.com/repos/NYULibraries/findingaids/milestones{/number}","notifications_url":"https://api.github.com/repos/NYULibraries/findingaids/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYULibraries/findingaids/labels{/name}","releases_url":"https://api.github.com/repos/NYULibraries/findingaids/releases{/id}","created_at":"2013-04-03T18:04:12Z","updated_at":"2015-01-16T17:47:25Z","pushed_at":"2015-01-16T20:46:38Z","git_url":"git://github.com/NYULibraries/findingaids.git","ssh_url":"git@github.com:NYULibraries/findingaids.git","clone_url":"https://github.com/NYULibraries/findingaids.git","svn_url":"https://github.com/NYULibraries/findingaids","homepage":null,"size":8604,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":2,"default_branch":"development"}},"base":{"label":"NYULibraries:development","ref":"development","sha":"7c1d521b33bb380aa6c3628114b26fc7ddfd60ae","user":{"login":"NYULibraries","id":1707000,"avatar_url":"https://avatars.githubusercontent.com/u/1707000?v=3","gravatar_id":"","url":"https://api.github.com/users/NYULibraries","html_url":"https://github.com/NYULibraries","followers_url":"https://api.github.com/users/NYULibraries/followers","following_url":"https://api.github.com/users/NYULibraries/following{/other_user}","gists_url":"https://api.github.com/users/NYULibraries/gists{/gist_id}","starred_url":"https://api.github.com/users/NYULibraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYULibraries/subscriptions","organizations_url":"https://api.github.com/users/NYULibraries/orgs","repos_url":"https://api.github.com/users/NYULibraries/repos","events_url":"https://api.github.com/users/NYULibraries/events{/privacy}","received_events_url":"https://api.github.com/users/NYULibraries/received_events","type":"Organization","site_admin":false},"repo":{"id":9201295,"name":"findingaids","full_name":"NYULibraries/findingaids","owner":{"login":"NYULibraries","id":1707000,"avatar_url":"https://avatars.githubusercontent.com/u/1707000?v=3","gravatar_id":"","url":"https://api.github.com/users/NYULibraries","html_url":"https://github.com/NYULibraries","followers_url":"https://api.github.com/users/NYULibraries/followers","following_url":"https://api.github.com/users/NYULibraries/following{/other_user}","gists_url":"https://api.github.com/users/NYULibraries/gists{/gist_id}","starred_url":"https://api.github.com/users/NYULibraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYULibraries/subscriptions","organizations_url":"https://api.github.com/users/NYULibraries/orgs","repos_url":"https://api.github.com/users/NYULibraries/repos","events_url":"https://api.github.com/users/NYULibraries/events{/privacy}","received_events_url":"https://api.github.com/users/NYULibraries/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NYULibraries/findingaids","description":"","fork":false,"url":"https://api.github.com/repos/NYULibraries/findingaids","forks_url":"https://api.github.com/repos/NYULibraries/findingaids/forks","keys_url":"https://api.github.com/repos/NYULibraries/findingaids/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYULibraries/findingaids/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYULibraries/findingaids/teams","hooks_url":"https://api.github.com/repos/NYULibraries/findingaids/hooks","issue_events_url":"https://api.github.com/repos/NYULibraries/findingaids/issues/events{/number}","events_url":"https://api.github.com/repos/NYULibraries/findingaids/events","assignees_url":"https://api.github.com/repos/NYULibraries/findingaids/assignees{/user}","branches_url":"https://api.github.com/repos/NYULibraries/findingaids/branches{/branch}","tags_url":"https://api.github.com/repos/NYULibraries/findingaids/tags","blobs_url":"https://api.github.com/repos/NYULibraries/findingaids/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYULibraries/findingaids/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYULibraries/findingaids/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYULibraries/findingaids/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYULibraries/findingaids/statuses/{sha}","languages_url":"https://api.github.com/repos/NYULibraries/findingaids/languages","stargazers_url":"https://api.github.com/repos/NYULibraries/findingaids/stargazers","contributors_url":"https://api.github.com/repos/NYULibraries/findingaids/contributors","subscribers_url":"https://api.github.com/repos/NYULibraries/findingaids/subscribers","subscription_url":"https://api.github.com/repos/NYULibraries/findingaids/subscription","commits_url":"https://api.github.com/repos/NYULibraries/findingaids/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYULibraries/findingaids/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYULibraries/findingaids/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYULibraries/findingaids/issues/comments/{number}","contents_url":"https://api.github.com/repos/NYULibraries/findingaids/contents/{+path}","compare_url":"https://api.github.com/repos/NYULibraries/findingaids/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYULibraries/findingaids/merges","archive_url":"https://api.github.com/repos/NYULibraries/findingaids/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYULibraries/findingaids/downloads","issues_url":"https://api.github.com/repos/NYULibraries/findingaids/issues{/number}","pulls_url":"https://api.github.com/repos/NYULibraries/findingaids/pulls{/number}","milestones_url":"https://api.github.com/repos/NYULibraries/findingaids/milestones{/number}","notifications_url":"https://api.github.com/repos/NYULibraries/findingaids/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYULibraries/findingaids/labels{/name}","releases_url":"https://api.github.com/repos/NYULibraries/findingaids/releases{/id}","created_at":"2013-04-03T18:04:12Z","updated_at":"2015-01-16T17:47:25Z","pushed_at":"2015-01-16T20:46:38Z","git_url":"git://github.com/NYULibraries/findingaids.git","ssh_url":"git@github.com:NYULibraries/findingaids.git","clone_url":"https://github.com/NYULibraries/findingaids.git","svn_url":"https://github.com/NYULibraries/findingaids","homepage":null,"size":8604,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":2,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/NYULibraries/findingaids/pulls/27"},"html":{"href":"https://github.com/NYULibraries/findingaids/pull/27"},"issue":{"href":"https://api.github.com/repos/NYULibraries/findingaids/issues/27"},"comments":{"href":"https://api.github.com/repos/NYULibraries/findingaids/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/NYULibraries/findingaids/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/NYULibraries/findingaids/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/NYULibraries/findingaids/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/NYULibraries/findingaids/statuses/59c4dde16fa465e19f852633c2df6d65bfa0c50d"}}}}