{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/29452561","id":29452561,"diff_hunk":"@@ -1,6 +1,11 @@\n class ConfigurationOrganization < ActiveRecord::Base\n   belongs_to :provisioning_manager\n   belongs_to :parent, :class_name => 'ConfigurationOrganization'\n+  has_and_belongs_to_many :configuration_profiles\n \n   alias_attribute :display_name, :title\n+\n+  def path\n+    (parent.try(:path) || []).push(self)\n+  end","path":"vmdb/app/models/configuration_organization.rb","position":10,"original_position":10,"commit_id":"d0567c3ca3e3d67f28b5256569f34603a9d0b163","original_commit_id":"d0567c3ca3e3d67f28b5256569f34603a9d0b163","user":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"body":"1. can we call this `subtree`\r\nThat is what it is called for [ancestry](https://github.com/stefankroes/ancestry)\r\n\r\n2. Does this read better to you?\r\nFor some reason the code has too many `if`s in it: `try` and `||`\r\n\r\n```\r\ndef path\r\n  parent ? parent.path.push(self) : [self]\r\nend\r\n```","created_at":"2015-04-30T17:48:22Z","updated_at":"2015-04-30T17:48:22Z","html_url":"https://github.com/ManageIQ/manageiq/pull/2797#discussion_r29452561","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2797","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/29452561"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/2797#discussion_r29452561"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2797"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2797","id":34397781,"html_url":"https://github.com/ManageIQ/manageiq/pull/2797","diff_url":"https://github.com/ManageIQ/manageiq/pull/2797.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/2797.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2797","number":2797,"state":"open","locked":false,"title":"Filter the available ConfigurationProfiles for provisioning dialogs","user":{"login":"brandondunne","id":651659,"avatar_url":"https://avatars.githubusercontent.com/u/651659?v=3","gravatar_id":"","url":"https://api.github.com/users/brandondunne","html_url":"https://github.com/brandondunne","followers_url":"https://api.github.com/users/brandondunne/followers","following_url":"https://api.github.com/users/brandondunne/following{/other_user}","gists_url":"https://api.github.com/users/brandondunne/gists{/gist_id}","starred_url":"https://api.github.com/users/brandondunne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandondunne/subscriptions","organizations_url":"https://api.github.com/users/brandondunne/orgs","repos_url":"https://api.github.com/users/brandondunne/repos","events_url":"https://api.github.com/users/brandondunne/events{/privacy}","received_events_url":"https://api.github.com/users/brandondunne/received_events","type":"User","site_admin":false},"body":"For each ConfiguredSystem, find its available ConfigurationProfiles taking\r\ninto account its ConfigurationLocation, ConfigurationOrganization and\r\nConfigurationArchitecture. Take a union of all arrays from all selected\r\nConfiguredSystems resulting in an array of ConfigurationProfiles that can\r\nbe applied to all selected ConfiguredSystems.\r\n\r\nThis is needed, but I think we need to request that the foreman team maintain their filtering logic.  Ideally I would prefer to ask their API what Hostgroups are available for a given Host.","created_at":"2015-04-29T19:34:54Z","updated_at":"2015-04-30T17:48:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdb30664e0e55939ca22339df35b74ecc059d5cf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2797/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2797/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2797/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/d0567c3ca3e3d67f28b5256569f34603a9d0b163","head":{"label":"brandondunne:foreman_provisioning_filtering","ref":"foreman_provisioning_filtering","sha":"d0567c3ca3e3d67f28b5256569f34603a9d0b163","user":{"login":"brandondunne","id":651659,"avatar_url":"https://avatars.githubusercontent.com/u/651659?v=3","gravatar_id":"","url":"https://api.github.com/users/brandondunne","html_url":"https://github.com/brandondunne","followers_url":"https://api.github.com/users/brandondunne/followers","following_url":"https://api.github.com/users/brandondunne/following{/other_user}","gists_url":"https://api.github.com/users/brandondunne/gists{/gist_id}","starred_url":"https://api.github.com/users/brandondunne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandondunne/subscriptions","organizations_url":"https://api.github.com/users/brandondunne/orgs","repos_url":"https://api.github.com/users/brandondunne/repos","events_url":"https://api.github.com/users/brandondunne/events{/privacy}","received_events_url":"https://api.github.com/users/brandondunne/received_events","type":"User","site_admin":false},"repo":{"id":20791794,"name":"manageiq","full_name":"brandondunne/manageiq","owner":{"login":"brandondunne","id":651659,"avatar_url":"https://avatars.githubusercontent.com/u/651659?v=3","gravatar_id":"","url":"https://api.github.com/users/brandondunne","html_url":"https://github.com/brandondunne","followers_url":"https://api.github.com/users/brandondunne/followers","following_url":"https://api.github.com/users/brandondunne/following{/other_user}","gists_url":"https://api.github.com/users/brandondunne/gists{/gist_id}","starred_url":"https://api.github.com/users/brandondunne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandondunne/subscriptions","organizations_url":"https://api.github.com/users/brandondunne/orgs","repos_url":"https://api.github.com/users/brandondunne/repos","events_url":"https://api.github.com/users/brandondunne/events{/privacy}","received_events_url":"https://api.github.com/users/brandondunne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brandondunne/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/brandondunne/manageiq","forks_url":"https://api.github.com/repos/brandondunne/manageiq/forks","keys_url":"https://api.github.com/repos/brandondunne/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brandondunne/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brandondunne/manageiq/teams","hooks_url":"https://api.github.com/repos/brandondunne/manageiq/hooks","issue_events_url":"https://api.github.com/repos/brandondunne/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/brandondunne/manageiq/events","assignees_url":"https://api.github.com/repos/brandondunne/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/brandondunne/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/brandondunne/manageiq/tags","blobs_url":"https://api.github.com/repos/brandondunne/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brandondunne/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brandondunne/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/brandondunne/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brandondunne/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/brandondunne/manageiq/languages","stargazers_url":"https://api.github.com/repos/brandondunne/manageiq/stargazers","contributors_url":"https://api.github.com/repos/brandondunne/manageiq/contributors","subscribers_url":"https://api.github.com/repos/brandondunne/manageiq/subscribers","subscription_url":"https://api.github.com/repos/brandondunne/manageiq/subscription","commits_url":"https://api.github.com/repos/brandondunne/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/brandondunne/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/brandondunne/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/brandondunne/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/brandondunne/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/brandondunne/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brandondunne/manageiq/merges","archive_url":"https://api.github.com/repos/brandondunne/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brandondunne/manageiq/downloads","issues_url":"https://api.github.com/repos/brandondunne/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/brandondunne/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/brandondunne/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/brandondunne/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brandondunne/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/brandondunne/manageiq/releases{/id}","created_at":"2014-06-13T04:12:55Z","updated_at":"2015-02-25T15:20:17Z","pushed_at":"2015-04-30T16:13:36Z","git_url":"git://github.com/brandondunne/manageiq.git","ssh_url":"git@github.com:brandondunne/manageiq.git","clone_url":"https://github.com/brandondunne/manageiq.git","svn_url":"https://github.com/brandondunne/manageiq","homepage":null,"size":71373,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"c2de96d457bfd9d4a614e1f969e843495b030df9","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-04-30T17:11:17Z","pushed_at":"2015-04-30T17:38:39Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":126356,"stargazers_count":106,"watchers_count":106,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":106,"mirror_url":null,"open_issues_count":363,"forks":106,"open_issues":363,"watchers":106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2797"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/2797"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/2797"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/2797/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2797/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2797/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/d0567c3ca3e3d67f28b5256569f34603a9d0b163"}}}}