{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/46704191","id":46704191,"diff_hunk":"@@ -224,6 +240,13 @@ def _synthesize_stim_channel(events, n_samp):\n     return stim_channel\n \n \n+def _check_version(header):\n+    end_tags = ['Version 1.0', 'Version 2.0']\n+    if not any([header.endswith(end_tag) for end_tag in end_tags]):","path":"mne/io/brainvision/brainvision.py","position":96,"original_position":96,"commit_id":"6caced2f339ee1703c85c57a5613ea81dd187fd8","original_commit_id":"6caced2f339ee1703c85c57a5613ea81dd187fd8","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"body":"Shouldn't we check the `startswith`, too, to be more complete?","created_at":"2015-12-04T16:59:24Z","updated_at":"2015-12-04T16:59:24Z","html_url":"https://github.com/mne-tools/mne-python/pull/2634#discussion_r46704191","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2634","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/46704191"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/2634#discussion_r46704191"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2634"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2634","id":51455060,"html_url":"https://github.com/mne-tools/mne-python/pull/2634","diff_url":"https://github.com/mne-tools/mne-python/pull/2634.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/2634.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2634","number":2634,"state":"open","locked":false,"title":"[MRG] ENH Add support for Brainvision V2.0","user":{"login":"teonlamont","id":1578674,"avatar_url":"https://avatars.githubusercontent.com/u/1578674?v=3","gravatar_id":"","url":"https://api.github.com/users/teonlamont","html_url":"https://github.com/teonlamont","followers_url":"https://api.github.com/users/teonlamont/followers","following_url":"https://api.github.com/users/teonlamont/following{/other_user}","gists_url":"https://api.github.com/users/teonlamont/gists{/gist_id}","starred_url":"https://api.github.com/users/teonlamont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teonlamont/subscriptions","organizations_url":"https://api.github.com/users/teonlamont/orgs","repos_url":"https://api.github.com/users/teonlamont/repos","events_url":"https://api.github.com/users/teonlamont/events{/privacy}","received_events_url":"https://api.github.com/users/teonlamont/received_events","type":"User","site_admin":false},"body":"closes #2613.\r\nTaking over #2614.\r\n\r\nThis is WIP. It provides reading support for BV 2.0.\r\n\r\nThings to be addressed: BV optionally has the channel locations listed in the vhdr file. Should we have  this supported in the montage module with a custom file format option `*.vhdr`?\r\n","created_at":"2015-11-22T01:31:50Z","updated_at":"2015-12-04T16:59:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3a118086ad9bc5f0551704934cb143eebd82729","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2634/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2634/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2634/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/6caced2f339ee1703c85c57a5613ea81dd187fd8","head":{"label":"teonlamont:bv2","ref":"bv2","sha":"6caced2f339ee1703c85c57a5613ea81dd187fd8","user":{"login":"teonlamont","id":1578674,"avatar_url":"https://avatars.githubusercontent.com/u/1578674?v=3","gravatar_id":"","url":"https://api.github.com/users/teonlamont","html_url":"https://github.com/teonlamont","followers_url":"https://api.github.com/users/teonlamont/followers","following_url":"https://api.github.com/users/teonlamont/following{/other_user}","gists_url":"https://api.github.com/users/teonlamont/gists{/gist_id}","starred_url":"https://api.github.com/users/teonlamont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teonlamont/subscriptions","organizations_url":"https://api.github.com/users/teonlamont/orgs","repos_url":"https://api.github.com/users/teonlamont/repos","events_url":"https://api.github.com/users/teonlamont/events{/privacy}","received_events_url":"https://api.github.com/users/teonlamont/received_events","type":"User","site_admin":false},"repo":{"id":6598396,"name":"mne-python","full_name":"teonlamont/mne-python","owner":{"login":"teonlamont","id":1578674,"avatar_url":"https://avatars.githubusercontent.com/u/1578674?v=3","gravatar_id":"","url":"https://api.github.com/users/teonlamont","html_url":"https://github.com/teonlamont","followers_url":"https://api.github.com/users/teonlamont/followers","following_url":"https://api.github.com/users/teonlamont/following{/other_user}","gists_url":"https://api.github.com/users/teonlamont/gists{/gist_id}","starred_url":"https://api.github.com/users/teonlamont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teonlamont/subscriptions","organizations_url":"https://api.github.com/users/teonlamont/orgs","repos_url":"https://api.github.com/users/teonlamont/repos","events_url":"https://api.github.com/users/teonlamont/events{/privacy}","received_events_url":"https://api.github.com/users/teonlamont/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/teonlamont/mne-python","description":"MNE scripting with Python","fork":true,"url":"https://api.github.com/repos/teonlamont/mne-python","forks_url":"https://api.github.com/repos/teonlamont/mne-python/forks","keys_url":"https://api.github.com/repos/teonlamont/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teonlamont/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teonlamont/mne-python/teams","hooks_url":"https://api.github.com/repos/teonlamont/mne-python/hooks","issue_events_url":"https://api.github.com/repos/teonlamont/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/teonlamont/mne-python/events","assignees_url":"https://api.github.com/repos/teonlamont/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/teonlamont/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/teonlamont/mne-python/tags","blobs_url":"https://api.github.com/repos/teonlamont/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teonlamont/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teonlamont/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/teonlamont/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teonlamont/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/teonlamont/mne-python/languages","stargazers_url":"https://api.github.com/repos/teonlamont/mne-python/stargazers","contributors_url":"https://api.github.com/repos/teonlamont/mne-python/contributors","subscribers_url":"https://api.github.com/repos/teonlamont/mne-python/subscribers","subscription_url":"https://api.github.com/repos/teonlamont/mne-python/subscription","commits_url":"https://api.github.com/repos/teonlamont/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/teonlamont/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/teonlamont/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/teonlamont/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/teonlamont/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/teonlamont/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teonlamont/mne-python/merges","archive_url":"https://api.github.com/repos/teonlamont/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teonlamont/mne-python/downloads","issues_url":"https://api.github.com/repos/teonlamont/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/teonlamont/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/teonlamont/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/teonlamont/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teonlamont/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/teonlamont/mne-python/releases{/id}","created_at":"2012-11-08T15:32:25Z","updated_at":"2015-05-06T14:22:04Z","pushed_at":"2015-12-04T05:35:50Z","git_url":"git://github.com/teonlamont/mne-python.git","ssh_url":"git@github.com:teonlamont/mne-python.git","clone_url":"https://github.com/teonlamont/mne-python.git","svn_url":"https://github.com/teonlamont/mne-python","homepage":"http://martinos.org/mne/","size":112156,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"948816938586e677eaf5cc652a2f7cdab4e7b73a","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","created_at":"2011-01-28T03:31:13Z","updated_at":"2015-12-02T16:18:24Z","pushed_at":"2015-12-04T16:00:47Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":168589,"stargazers_count":163,"watchers_count":163,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"open_issues_count":181,"forks":150,"open_issues":181,"watchers":163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2634"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/2634"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/2634"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/2634/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2634/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2634/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/6caced2f339ee1703c85c57a5613ea81dd187fd8"}}}}