{"comment":{"url":"https://api.github.com/repos/again4you/systemd/comments/13901536","html_url":"https://github.com/again4you/systemd/commit/a0f90865f637cbeae493eb4f0dec814558c9ad91#commitcomment-13901536","id":13901536,"user":{"login":"poettering","id":2130732,"avatar_url":"https://avatars.githubusercontent.com/u/2130732?v=3","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"position":32,"line":876,"path":"src/core/mount.c","commit_id":"a0f90865f637cbeae493eb4f0dec814558c9ad91","created_at":"2015-10-21T13:53:05Z","updated_at":"2015-10-21T13:53:05Z","body":"Logging is not clean. See CODING_STYLE. This function should either log all errors (in which case the caller should not log about errors from it) or it should not log about any errors at all (in which case the caller should do that).\r\n\r\nThe function as it stands now logs under one OOM condition on its own, but not on the other. "}}