{"action":"created","issue":{"url":"https://api.github.com/repos/typings/typings/issues/47","labels_url":"https://api.github.com/repos/typings/typings/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/typings/typings/issues/47/comments","events_url":"https://api.github.com/repos/typings/typings/issues/47/events","html_url":"https://github.com/typings/typings/pull/47","id":118724759,"number":47,"title":"[demo: do not merge] Demonstrate end-to-end coverage of .ts files using istanbul v1","user":{"login":"gotwarlost","id":1056819,"avatar_url":"https://avatars.githubusercontent.com/u/1056819?v=3","gravatar_id":"","url":"https://api.github.com/users/gotwarlost","html_url":"https://github.com/gotwarlost","followers_url":"https://api.github.com/users/gotwarlost/followers","following_url":"https://api.github.com/users/gotwarlost/following{/other_user}","gists_url":"https://api.github.com/users/gotwarlost/gists{/gist_id}","starred_url":"https://api.github.com/users/gotwarlost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gotwarlost/subscriptions","organizations_url":"https://api.github.com/users/gotwarlost/orgs","repos_url":"https://api.github.com/users/gotwarlost/repos","events_url":"https://api.github.com/users/gotwarlost/events{/privacy}","received_events_url":"https://api.github.com/users/gotwarlost/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-11-24T23:19:35Z","updated_at":"2015-12-03T04:23:06Z","closed_at":"2015-12-02T00:27:27Z","pull_request":{"url":"https://api.github.com/repos/typings/typings/pulls/47","html_url":"https://github.com/typings/typings/pull/47","diff_url":"https://github.com/typings/typings/pull/47.diff","patch_url":"https://github.com/typings/typings/pull/47.patch"},"body":"* Use my istanbul v1 branch\r\n* Pin to `ts-node@0.5.2`\r\n* Remove the pipe to `tap-dot` - this is just for ease of debugging and does not materially affect any outcome\r\n\r\nPlease run this locally and verify that the coverage looks like you expect it to and the HTML reports make sense.\r\n\r\nAlso note this hack: https://github.com/istanbuljs/istanbul-lib-source-maps/blob/master/lib/map-store.js#L53-L55\r\n\r\nFor some reason the typescript compiler (or maybe your wrapper?) base64 encodes an object that is not a source map but looks like `{ sourcemap: { real sourcemap_object} }`\r\n\r\nLet's sync up on the final form of this integration after you've had a chance to play with it."},"comment":{"url":"https://api.github.com/repos/typings/typings/issues/comments/161510939","html_url":"https://github.com/typings/typings/pull/47#issuecomment-161510939","issue_url":"https://api.github.com/repos/typings/typings/issues/47","id":161510939,"user":{"login":"blakeembrey","id":1088987,"avatar_url":"https://avatars.githubusercontent.com/u/1088987?v=3","gravatar_id":"","url":"https://api.github.com/users/blakeembrey","html_url":"https://github.com/blakeembrey","followers_url":"https://api.github.com/users/blakeembrey/followers","following_url":"https://api.github.com/users/blakeembrey/following{/other_user}","gists_url":"https://api.github.com/users/blakeembrey/gists{/gist_id}","starred_url":"https://api.github.com/users/blakeembrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blakeembrey/subscriptions","organizations_url":"https://api.github.com/users/blakeembrey/orgs","repos_url":"https://api.github.com/users/blakeembrey/repos","events_url":"https://api.github.com/users/blakeembrey/events{/privacy}","received_events_url":"https://api.github.com/users/blakeembrey/received_events","type":"User","site_admin":false},"created_at":"2015-12-03T04:23:06Z","updated_at":"2015-12-03T04:23:06Z","body":"Ok, that's what I gathered too. Why can't bullet 4 be read from the filesystem directly instead of with require? They don't need to be transpiled since they'll have zero coverage and the original source you want to print with should be what that file says anyway (if it has source maps in the file you read, you resolve them like normal - if not in the case of `ts-node` or `babel-node`, you just use the original source anyway).\r\n\r\nI guess the part I don't understand is why including the extra things and being required should improve coverage? Is it because they run successfully? In which case, can what I propose be a different flag? I want all sources to be included, but I don't want them to run randomly. Maybe executing them different. For instance, those files could be doing synchronous file mutations or something.\r\n\r\nThinking into it more, running those files will include a lot of additional things. For example, task runner files (`gulp`, `grunt`) - won't they now be executed? What about instead adding a flag for executing them (for whoever needs that) and then using `--include-sources \"src/**/*.js\"`. This sounds to me like a pretty critical issue. Some scripts (especially build/CLI) might take a long time to execute because they do synchronous actions."}}