{"action":"created","issue":{"url":"https://api.github.com/repos/landlab/landlab/issues/168","labels_url":"https://api.github.com/repos/landlab/landlab/issues/168/labels{/name}","comments_url":"https://api.github.com/repos/landlab/landlab/issues/168/comments","events_url":"https://api.github.com/repos/landlab/landlab/issues/168/events","html_url":"https://github.com/landlab/landlab/pull/168","id":112520655,"number":168,"title":"sink_fill component","user":{"login":"SiccarPoint","id":6867260,"avatar_url":"https://avatars.githubusercontent.com/u/6867260?v=3","gravatar_id":"","url":"https://api.github.com/users/SiccarPoint","html_url":"https://github.com/SiccarPoint","followers_url":"https://api.github.com/users/SiccarPoint/followers","following_url":"https://api.github.com/users/SiccarPoint/following{/other_user}","gists_url":"https://api.github.com/users/SiccarPoint/gists{/gist_id}","starred_url":"https://api.github.com/users/SiccarPoint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SiccarPoint/subscriptions","organizations_url":"https://api.github.com/users/SiccarPoint/orgs","repos_url":"https://api.github.com/users/SiccarPoint/repos","events_url":"https://api.github.com/users/SiccarPoint/events{/privacy}","received_events_url":"https://api.github.com/users/SiccarPoint/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jadams15","id":7536200,"avatar_url":"https://avatars.githubusercontent.com/u/7536200?v=3","gravatar_id":"","url":"https://api.github.com/users/jadams15","html_url":"https://github.com/jadams15","followers_url":"https://api.github.com/users/jadams15/followers","following_url":"https://api.github.com/users/jadams15/following{/other_user}","gists_url":"https://api.github.com/users/jadams15/gists{/gist_id}","starred_url":"https://api.github.com/users/jadams15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadams15/subscriptions","organizations_url":"https://api.github.com/users/jadams15/orgs","repos_url":"https://api.github.com/users/jadams15/repos","events_url":"https://api.github.com/users/jadams15/events{/privacy}","received_events_url":"https://api.github.com/users/jadams15/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-10-21T06:25:02Z","updated_at":"2015-10-21T17:54:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/landlab/landlab/pulls/168","html_url":"https://github.com/landlab/landlab/pull/168","diff_url":"https://github.com/landlab/landlab/pull/168.diff","patch_url":"https://github.com/landlab/landlab/pull/168.patch"},"body":"New component fills pits in a starting topography, exploiting the lake_mapper for a lot of the donkey work.\r\n\r\nFill can either be flat, or sloping gently towards the outlet. Method is clever enough to handle simple terrain where \"back flow\" is needed to get parts of the flat connected up to the outlet, but it remains to be seen how it performs on real topographies (and, dare I say, LiDAR??)\r\n\r\nBunch of tests here confirm things are 100% robust on simple topographies, though I suspect there might be some interesting use cases lurking out there in the wild where lakes get big and topos get highly irregular."},"comment":{"url":"https://api.github.com/repos/landlab/landlab/issues/comments/149976802","html_url":"https://github.com/landlab/landlab/pull/168#issuecomment-149976802","issue_url":"https://api.github.com/repos/landlab/landlab/issues/168","id":149976802,"user":{"login":"SiccarPoint","id":6867260,"avatar_url":"https://avatars.githubusercontent.com/u/6867260?v=3","gravatar_id":"","url":"https://api.github.com/users/SiccarPoint","html_url":"https://github.com/SiccarPoint","followers_url":"https://api.github.com/users/SiccarPoint/followers","following_url":"https://api.github.com/users/SiccarPoint/following{/other_user}","gists_url":"https://api.github.com/users/SiccarPoint/gists{/gist_id}","starred_url":"https://api.github.com/users/SiccarPoint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SiccarPoint/subscriptions","organizations_url":"https://api.github.com/users/SiccarPoint/orgs","repos_url":"https://api.github.com/users/SiccarPoint/repos","events_url":"https://api.github.com/users/SiccarPoint/events{/privacy}","received_events_url":"https://api.github.com/users/SiccarPoint/received_events","type":"User","site_admin":false},"created_at":"2015-10-21T17:54:34Z","updated_at":"2015-10-21T17:54:34Z","body":"1. Only insofar as assert_is is the same thing as assert_array_equal…\n\n2. How can we be numpdoc compliant when we talk about fields??\n\n\n\n> On 21 Oct 2015, at 11:34, Eric Hutton <notifications@github.com> wrote:\n> \n> I already had a quick look before I was unassigned. I noticed two small things.\n> \n> Is assert_close the same as the existing numpy assert_array_almost_equal? It looks like it. If so, probably best to use the existing numpy function.\n> Docstrings need to be numpydoc format. Headings like, \"Return fields\" will either get lost or mangled when converted to our HTML documentation.\n> I love the tests!\n> \n> —\n> Reply to this email directly or view it on GitHub <https://github.com/landlab/landlab/pull/168#issuecomment-149971890>.\n> \n\n"}}