{"action":"created","comment":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/39750218","id":39750218,"diff_hunk":"@@ -622,14 +622,34 @@ extern (C++) int runLINK()\n         {\n             char* buf = cast(char*)malloc(3 + slen + 1);\n             strcpy(buf, \"-l\");\n-            /* Use \"-l:libname.a\" if the library name is complete\n-             */\n-            if (slen > 3 + 2 && memcmp(libname, cast(char*)\"lib\", 3) == 0 && (memcmp(libname + slen - 2, cast(char*)\".a\", 2) == 0 || memcmp(libname + slen - 3, cast(char*)\".so\", 3) == 0))\n+\n+            if (slen > 3 + 2 && memcmp(libname, cast(char*)\"lib\", 3) == 0)\n+            {\n+                if (memcmp(libname + slen - 2, cast(char*)\".a\", 2) == 0)\n+                {\n+                    argv.push(\"-Xlinker\");\n+                    argv.push(\"-Bstatic\");\n+                    strncat(buf, libname + 3, slen - 3 - 2);\n+                    argv.push(buf);\n+                    argv.push(\"-Xlinker\");\n+                    argv.push(\"-Bdynamic\");\n+                }\n+                else if (memcmp(libname + slen - 3, cast(char*)\".so\", 3) == 0)","path":"src/link.d","position":19,"original_position":19,"commit_id":"45742c6485438134d3f71dfc2d029809a7e3907d","original_commit_id":"45742c6485438134d3f71dfc2d029809a7e3907d","user":{"login":"andralex","id":566679,"avatar_url":"https://avatars.githubusercontent.com/u/566679?v=3","gravatar_id":"","url":"https://api.github.com/users/andralex","html_url":"https://github.com/andralex","followers_url":"https://api.github.com/users/andralex/followers","following_url":"https://api.github.com/users/andralex/following{/other_user}","gists_url":"https://api.github.com/users/andralex/gists{/gist_id}","starred_url":"https://api.github.com/users/andralex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andralex/subscriptions","organizations_url":"https://api.github.com/users/andralex/orgs","repos_url":"https://api.github.com/users/andralex/repos","events_url":"https://api.github.com/users/andralex/events{/privacy}","received_events_url":"https://api.github.com/users/andralex/received_events","type":"User","site_admin":false},"body":"no cast","created_at":"2015-09-17T14:19:25Z","updated_at":"2015-09-17T14:19:25Z","html_url":"https://github.com/D-Programming-Language/dmd/pull/4975#discussion_r39750218","pull_request_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4975","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/39750218"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/4975#discussion_r39750218"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4975"}}},"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4975","id":43641655,"html_url":"https://github.com/D-Programming-Language/dmd/pull/4975","diff_url":"https://github.com/D-Programming-Language/dmd/pull/4975.diff","patch_url":"https://github.com/D-Programming-Language/dmd/pull/4975.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/4975","number":4975,"state":"open","locked":false,"title":"use static libphobos2.a as default","user":{"login":"MartinNowak","id":288976,"avatar_url":"https://avatars.githubusercontent.com/u/288976?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinNowak","html_url":"https://github.com/MartinNowak","followers_url":"https://api.github.com/users/MartinNowak/followers","following_url":"https://api.github.com/users/MartinNowak/following{/other_user}","gists_url":"https://api.github.com/users/MartinNowak/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinNowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinNowak/subscriptions","organizations_url":"https://api.github.com/users/MartinNowak/orgs","repos_url":"https://api.github.com/users/MartinNowak/repos","events_url":"https://api.github.com/users/MartinNowak/events{/privacy}","received_events_url":"https://api.github.com/users/MartinNowak/received_events","type":"User","site_admin":false},"body":"- except for OSX where -Bstatic isn't available","created_at":"2015-08-28T15:42:34Z","updated_at":"2015-09-17T14:19:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65c2b315a3f5943cd6b22a4e54fa0ff79e37b76e","assignee":null,"milestone":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/milestones/9","html_url":"https://github.com/D-Programming-Language/dmd/milestones/2.069.0","labels_url":"https://api.github.com/repos/D-Programming-Language/dmd/milestones/9/labels","id":1285934,"number":9,"title":"2.069.0","description":"","creator":{"login":"MartinNowak","id":288976,"avatar_url":"https://avatars.githubusercontent.com/u/288976?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinNowak","html_url":"https://github.com/MartinNowak","followers_url":"https://api.github.com/users/MartinNowak/followers","following_url":"https://api.github.com/users/MartinNowak/following{/other_user}","gists_url":"https://api.github.com/users/MartinNowak/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinNowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinNowak/subscriptions","organizations_url":"https://api.github.com/users/MartinNowak/orgs","repos_url":"https://api.github.com/users/MartinNowak/repos","events_url":"https://api.github.com/users/MartinNowak/events{/privacy}","received_events_url":"https://api.github.com/users/MartinNowak/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":2,"state":"open","created_at":"2015-09-02T10:07:40Z","updated_at":"2015-09-16T19:07:23Z","due_on":"2015-10-03T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4975/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4975/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/4975/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/45742c6485438134d3f71dfc2d029809a7e3907d","head":{"label":"MartinNowak:sharedFBSD","ref":"sharedFBSD","sha":"45742c6485438134d3f71dfc2d029809a7e3907d","user":{"login":"MartinNowak","id":288976,"avatar_url":"https://avatars.githubusercontent.com/u/288976?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinNowak","html_url":"https://github.com/MartinNowak","followers_url":"https://api.github.com/users/MartinNowak/followers","following_url":"https://api.github.com/users/MartinNowak/following{/other_user}","gists_url":"https://api.github.com/users/MartinNowak/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinNowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinNowak/subscriptions","organizations_url":"https://api.github.com/users/MartinNowak/orgs","repos_url":"https://api.github.com/users/MartinNowak/repos","events_url":"https://api.github.com/users/MartinNowak/events{/privacy}","received_events_url":"https://api.github.com/users/MartinNowak/received_events","type":"User","site_admin":false},"repo":{"id":1494042,"name":"dmd","full_name":"MartinNowak/dmd","owner":{"login":"MartinNowak","id":288976,"avatar_url":"https://avatars.githubusercontent.com/u/288976?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinNowak","html_url":"https://github.com/MartinNowak","followers_url":"https://api.github.com/users/MartinNowak/followers","following_url":"https://api.github.com/users/MartinNowak/following{/other_user}","gists_url":"https://api.github.com/users/MartinNowak/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinNowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinNowak/subscriptions","organizations_url":"https://api.github.com/users/MartinNowak/orgs","repos_url":"https://api.github.com/users/MartinNowak/repos","events_url":"https://api.github.com/users/MartinNowak/events{/privacy}","received_events_url":"https://api.github.com/users/MartinNowak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MartinNowak/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/MartinNowak/dmd","forks_url":"https://api.github.com/repos/MartinNowak/dmd/forks","keys_url":"https://api.github.com/repos/MartinNowak/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MartinNowak/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MartinNowak/dmd/teams","hooks_url":"https://api.github.com/repos/MartinNowak/dmd/hooks","issue_events_url":"https://api.github.com/repos/MartinNowak/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/MartinNowak/dmd/events","assignees_url":"https://api.github.com/repos/MartinNowak/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/MartinNowak/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/MartinNowak/dmd/tags","blobs_url":"https://api.github.com/repos/MartinNowak/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MartinNowak/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MartinNowak/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/MartinNowak/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MartinNowak/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/MartinNowak/dmd/languages","stargazers_url":"https://api.github.com/repos/MartinNowak/dmd/stargazers","contributors_url":"https://api.github.com/repos/MartinNowak/dmd/contributors","subscribers_url":"https://api.github.com/repos/MartinNowak/dmd/subscribers","subscription_url":"https://api.github.com/repos/MartinNowak/dmd/subscription","commits_url":"https://api.github.com/repos/MartinNowak/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/MartinNowak/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/MartinNowak/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/MartinNowak/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/MartinNowak/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/MartinNowak/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MartinNowak/dmd/merges","archive_url":"https://api.github.com/repos/MartinNowak/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MartinNowak/dmd/downloads","issues_url":"https://api.github.com/repos/MartinNowak/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/MartinNowak/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/MartinNowak/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/MartinNowak/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MartinNowak/dmd/labels{/name}","releases_url":"https://api.github.com/repos/MartinNowak/dmd/releases{/id}","created_at":"2011-03-17T23:58:29Z","updated_at":"2015-09-02T08:37:46Z","pushed_at":"2015-09-16T21:04:17Z","git_url":"git://github.com/MartinNowak/dmd.git","ssh_url":"git@github.com:MartinNowak/dmd.git","clone_url":"https://github.com/MartinNowak/dmd.git","svn_url":"https://github.com/MartinNowak/dmd","homepage":"d-programming-language.org","size":60413,"stargazers_count":1,"watchers_count":1,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"f0879ea1ac19736c114db0fc0a5c20cb20b0fe87","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"name":"dmd","full_name":"D-Programming-Language/dmd","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/dmd","forks_url":"https://api.github.com/repos/D-Programming-Language/dmd/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/dmd/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/dmd/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/dmd/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/dmd/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/dmd/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/dmd/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/dmd/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/dmd/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/dmd/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/D-Programming-Language/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/dmd/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/dmd/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/dmd/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/dmd/releases{/id}","created_at":"2011-01-15T06:53:53Z","updated_at":"2015-09-17T12:23:22Z","pushed_at":"2015-09-17T14:04:55Z","git_url":"git://github.com/D-Programming-Language/dmd.git","ssh_url":"git@github.com:D-Programming-Language/dmd.git","clone_url":"https://github.com/D-Programming-Language/dmd.git","svn_url":"https://github.com/D-Programming-Language/dmd","homepage":"dlang.org","size":111576,"stargazers_count":1076,"watchers_count":1076,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":340,"mirror_url":null,"open_issues_count":151,"forks":340,"open_issues":151,"watchers":1076,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4975"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/4975"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/issues/4975"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/issues/4975/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4975/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4975/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/45742c6485438134d3f71dfc2d029809a7e3907d"}}}}