{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/26665224","id":26665224,"diff_hunk":"@@ -0,0 +1,94 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.spark.ml.feature\n+\n+import org.scalatest.FunSuite\n+\n+import org.apache.spark.mllib.util.MLlibTestSparkContext\n+import org.apache.spark.sql.{DataFrame, Row, SQLContext}\n+\n+\n+case class TextData(rawText : String,wantedTokens: Seq[String])\n+class TokenizerSuite extends FunSuite with MLlibTestSparkContext {\n+  \n+  @transient var sqlContext: SQLContext = _\n+  @transient var dataset: DataFrame = _\n+\n+  override def beforeAll(): Unit = {\n+    super.beforeAll()\n+    sqlContext = new SQLContext(sc)\n+  }\n+\n+  test(\"RegexTokenizer\"){\n+    var myRegExTokenizer = new RegexTokenizer()\n+      .setInputCol(\"rawText\")\n+      .setOutputCol(\"tokens\")\n+\n+    dataset = sqlContext.createDataFrame(\n+      sc.parallelize(List(\n+        TextData(\"Test for tokenization.\",List(\"Test\",\"for\",\"tokenization\",\".\")),\n+        TextData(\"Te,st. punct\",List(\"Te\",\",\",\"st\",\".\",\"punct\"))\n+    )))\n+    testTokenizer(myRegExTokenizer,dataset)\n+\n+    dataset = sqlContext.createDataFrame(\n+      sc.parallelize(List(\n+        TextData(\"Test for tokenization.\",List(\"Test\",\"for\",\"tokenization\")),\n+        TextData(\"Te,st. punct\",List(\"punct\"))\n+    )))\n+    myRegExTokenizer.asInstanceOf[RegexTokenizer]\n+      .setMinTokenLength(3)\n+    testTokenizer(myRegExTokenizer,dataset)\n+\n+    myRegExTokenizer.asInstanceOf[RegexTokenizer]\n+      .setPattern(\"\\\\s\")\n+      .setGaps(true)\n+      .setMinTokenLength(0)\n+    dataset = sqlContext.createDataFrame(\n+      sc.parallelize(List(\n+        TextData(\"Test for tokenization.\",List(\"Test\",\"for\",\"tokenization.\")),\n+        TextData(\"Te,st.  punct\",List(\"Te,st.\",\"\",\"punct\"))\n+    )))\n+    testTokenizer(myRegExTokenizer,dataset)\n+  }\n+\n+  test(\"Tokenizer\"){\n+    val oldTokenizer =  new Tokenizer()\n+      .setInputCol(\"rawText\")\n+      .setOutputCol(\"tokens\")\n+    dataset = sqlContext.createDataFrame(\n+      sc.parallelize(List(\n+        TextData(\"Test for tokenization.\",List(\"test\",\"for\",\"tokenization.\")),\n+        TextData(\"Te,st.  punct\",List(\"te,st.\",\"\",\"punct\"))\n+    )))\n+    testTokenizer(oldTokenizer,dataset)\n+  }\n+\n+  def testTokenizer(t: Tokenizer,dataset: DataFrame){","path":"mllib/src/test/scala/org/apache/spark/ml/feature/TokenizerSuite.scala","position":82,"original_position":82,"commit_id":"e262bacc5fc3cc780466f49200cdf2466ce8e563","original_commit_id":"e262bacc5fc3cc780466f49200cdf2466ce8e563","user":{"login":"mengxr","id":829644,"avatar_url":"https://avatars.githubusercontent.com/u/829644?v=3","gravatar_id":"","url":"https://api.github.com/users/mengxr","html_url":"https://github.com/mengxr","followers_url":"https://api.github.com/users/mengxr/followers","following_url":"https://api.github.com/users/mengxr/following{/other_user}","gists_url":"https://api.github.com/users/mengxr/gists{/gist_id}","starred_url":"https://api.github.com/users/mengxr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengxr/subscriptions","organizations_url":"https://api.github.com/users/mengxr/orgs","repos_url":"https://api.github.com/users/mengxr/repos","events_url":"https://api.github.com/users/mengxr/events{/privacy}","received_events_url":"https://api.github.com/users/mengxr/received_events","type":"User","site_admin":false},"body":"space before `{`","created_at":"2015-03-18T14:07:55Z","updated_at":"2015-03-18T14:07:55Z","html_url":"https://github.com/apache/spark/pull/4504#discussion_r26665224","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/4504","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/26665224"},"html":{"href":"https://github.com/apache/spark/pull/4504#discussion_r26665224"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/4504"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/4504","id":28996608,"html_url":"https://github.com/apache/spark/pull/4504","diff_url":"https://github.com/apache/spark/pull/4504.diff","patch_url":"https://github.com/apache/spark/pull/4504.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/4504","number":4504,"state":"open","locked":false,"title":"[ML][FEATURE] SPARK-5566: RegEx Tokenizer","user":{"login":"aborsu985","id":5927780,"avatar_url":"https://avatars.githubusercontent.com/u/5927780?v=3","gravatar_id":"","url":"https://api.github.com/users/aborsu985","html_url":"https://github.com/aborsu985","followers_url":"https://api.github.com/users/aborsu985/followers","following_url":"https://api.github.com/users/aborsu985/following{/other_user}","gists_url":"https://api.github.com/users/aborsu985/gists{/gist_id}","starred_url":"https://api.github.com/users/aborsu985/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aborsu985/subscriptions","organizations_url":"https://api.github.com/users/aborsu985/orgs","repos_url":"https://api.github.com/users/aborsu985/repos","events_url":"https://api.github.com/users/aborsu985/events{/privacy}","received_events_url":"https://api.github.com/users/aborsu985/received_events","type":"User","site_admin":false},"body":"Added a Regex based tokenizer for ml.\r\nCurrently the regex is fixed but if I could add a regex type paramater to the paramMap,\r\nchanging the tokenizer regex could be a parameter used in the crossValidation.\r\nAlso I wonder what would be the best way to add a stop word list.\r\n","created_at":"2015-02-10T10:45:00Z","updated_at":"2015-03-18T14:07:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d51783c9becfc36e13ecef6bb1dae09724a16c11","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/4504/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/4504/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/4504/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/e262bacc5fc3cc780466f49200cdf2466ce8e563","head":{"label":"aborsu985:master","ref":"master","sha":"e262bacc5fc3cc780466f49200cdf2466ce8e563","user":{"login":"aborsu985","id":5927780,"avatar_url":"https://avatars.githubusercontent.com/u/5927780?v=3","gravatar_id":"","url":"https://api.github.com/users/aborsu985","html_url":"https://github.com/aborsu985","followers_url":"https://api.github.com/users/aborsu985/followers","following_url":"https://api.github.com/users/aborsu985/following{/other_user}","gists_url":"https://api.github.com/users/aborsu985/gists{/gist_id}","starred_url":"https://api.github.com/users/aborsu985/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aborsu985/subscriptions","organizations_url":"https://api.github.com/users/aborsu985/orgs","repos_url":"https://api.github.com/users/aborsu985/repos","events_url":"https://api.github.com/users/aborsu985/events{/privacy}","received_events_url":"https://api.github.com/users/aborsu985/received_events","type":"User","site_admin":false},"repo":{"id":30524147,"name":"spark","full_name":"aborsu985/spark","owner":{"login":"aborsu985","id":5927780,"avatar_url":"https://avatars.githubusercontent.com/u/5927780?v=3","gravatar_id":"","url":"https://api.github.com/users/aborsu985","html_url":"https://github.com/aborsu985","followers_url":"https://api.github.com/users/aborsu985/followers","following_url":"https://api.github.com/users/aborsu985/following{/other_user}","gists_url":"https://api.github.com/users/aborsu985/gists{/gist_id}","starred_url":"https://api.github.com/users/aborsu985/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aborsu985/subscriptions","organizations_url":"https://api.github.com/users/aborsu985/orgs","repos_url":"https://api.github.com/users/aborsu985/repos","events_url":"https://api.github.com/users/aborsu985/events{/privacy}","received_events_url":"https://api.github.com/users/aborsu985/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aborsu985/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/aborsu985/spark","forks_url":"https://api.github.com/repos/aborsu985/spark/forks","keys_url":"https://api.github.com/repos/aborsu985/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aborsu985/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aborsu985/spark/teams","hooks_url":"https://api.github.com/repos/aborsu985/spark/hooks","issue_events_url":"https://api.github.com/repos/aborsu985/spark/issues/events{/number}","events_url":"https://api.github.com/repos/aborsu985/spark/events","assignees_url":"https://api.github.com/repos/aborsu985/spark/assignees{/user}","branches_url":"https://api.github.com/repos/aborsu985/spark/branches{/branch}","tags_url":"https://api.github.com/repos/aborsu985/spark/tags","blobs_url":"https://api.github.com/repos/aborsu985/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aborsu985/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aborsu985/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/aborsu985/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aborsu985/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/aborsu985/spark/languages","stargazers_url":"https://api.github.com/repos/aborsu985/spark/stargazers","contributors_url":"https://api.github.com/repos/aborsu985/spark/contributors","subscribers_url":"https://api.github.com/repos/aborsu985/spark/subscribers","subscription_url":"https://api.github.com/repos/aborsu985/spark/subscription","commits_url":"https://api.github.com/repos/aborsu985/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/aborsu985/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/aborsu985/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/aborsu985/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/aborsu985/spark/contents/{+path}","compare_url":"https://api.github.com/repos/aborsu985/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aborsu985/spark/merges","archive_url":"https://api.github.com/repos/aborsu985/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aborsu985/spark/downloads","issues_url":"https://api.github.com/repos/aborsu985/spark/issues{/number}","pulls_url":"https://api.github.com/repos/aborsu985/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/aborsu985/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/aborsu985/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aborsu985/spark/labels{/name}","releases_url":"https://api.github.com/repos/aborsu985/spark/releases{/id}","created_at":"2015-02-09T07:38:08Z","updated_at":"2015-03-18T13:19:37Z","pushed_at":"2015-03-18T13:19:35Z","git_url":"git://github.com/aborsu985/spark.git","ssh_url":"git@github.com:aborsu985/spark.git","clone_url":"https://github.com/aborsu985/spark.git","svn_url":"https://github.com/aborsu985/spark","homepage":null,"size":93832,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c928796ade54f68e26bc55734a9867a046d2e3fe","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-03-18T13:33:02Z","pushed_at":"2015-03-18T13:18:43Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1409135,"stargazers_count":3255,"watchers_count":3255,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2819,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":291,"forks":2819,"open_issues":291,"watchers":3255,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/4504"},"html":{"href":"https://github.com/apache/spark/pull/4504"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/4504"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/4504/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/4504/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/4504/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/e262bacc5fc3cc780466f49200cdf2466ce8e563"}}}}