{"action":"created","issue":{"url":"https://api.github.com/repos/VOLTTRON/volttron/issues/21","labels_url":"https://api.github.com/repos/VOLTTRON/volttron/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/VOLTTRON/volttron/issues/21/comments","events_url":"https://api.github.com/repos/VOLTTRON/volttron/issues/21/events","html_url":"https://github.com/VOLTTRON/volttron/pull/21","id":60219893,"number":21,"title":"Fix tmp_dir cleanup during pkg configure","user":{"login":"ChrisFreeman","id":2237867,"avatar_url":"https://avatars.githubusercontent.com/u/2237867?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisFreeman","html_url":"https://github.com/ChrisFreeman","followers_url":"https://api.github.com/users/ChrisFreeman/followers","following_url":"https://api.github.com/users/ChrisFreeman/following{/other_user}","gists_url":"https://api.github.com/users/ChrisFreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisFreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisFreeman/subscriptions","organizations_url":"https://api.github.com/users/ChrisFreeman/orgs","repos_url":"https://api.github.com/users/ChrisFreeman/repos","events_url":"https://api.github.com/users/ChrisFreeman/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisFreeman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-07T19:10:48Z","updated_at":"2015-03-07T19:15:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/VOLTTRON/volttron/pulls/21","html_url":"https://github.com/VOLTTRON/volttron/pull/21","diff_url":"https://github.com/VOLTTRON/volttron/pull/21.diff","patch_url":"https://github.com/VOLTTRON/volttron/pull/21.patch"},"body":"Fixes issue #20 . Simple fix to `volttron/platform/packages.py`.  Wrapped `tmp_dir` code section in `VolttronPackageWheelFileNoSign.add_files()` with `try...finally` as was done in `remove_files()`.\r\n\r\nDue to the larger indentation change, file difference best viewed with `git diff -b` to ignore whitespace. "},"comment":{"url":"https://api.github.com/repos/VOLTTRON/volttron/issues/comments/77704860","html_url":"https://github.com/VOLTTRON/volttron/pull/21#issuecomment-77704860","issue_url":"https://api.github.com/repos/VOLTTRON/volttron/issues/21","id":77704860,"user":{"login":"ChrisFreeman","id":2237867,"avatar_url":"https://avatars.githubusercontent.com/u/2237867?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisFreeman","html_url":"https://github.com/ChrisFreeman","followers_url":"https://api.github.com/users/ChrisFreeman/followers","following_url":"https://api.github.com/users/ChrisFreeman/following{/other_user}","gists_url":"https://api.github.com/users/ChrisFreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisFreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisFreeman/subscriptions","organizations_url":"https://api.github.com/users/ChrisFreeman/orgs","repos_url":"https://api.github.com/users/ChrisFreeman/repos","events_url":"https://api.github.com/users/ChrisFreeman/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisFreeman/received_events","type":"User","site_admin":false},"created_at":"2015-03-07T19:15:29Z","updated_at":"2015-03-07T19:15:29Z","body":"A much better view of the diff using `-b` switch:\r\n\r\n```diff\r\n$ git diff -b HEAD HEAD^\r\ndiff --git a/volttron/platform/packages.py b/volttron/platform/packages.py\r\nindex 35b189e..edad98f 100644\r\n--- a/volttron/platform/packages.py\r\n+++ b/volttron/platform/packages.py\r\n@@ -116,7 +116,6 @@ class VolttronPackageWheelFileNoSign(WheelFile):\r\n #         new_record_name = \"RECORD.{}\".format(len(records))\r\n # \r\n         tmp_dir = tempfile.mkdtemp()\r\n-        try:\r\n         record_path = '/'.join((self.distinfo_name, last_record_name))\r\n         tmp_new_record_file = '/'.join((tmp_dir, self.distinfo_name, \r\n                                         last_record_name))\r\n@@ -182,9 +181,6 @@ class VolttronPackageWheelFileNoSign(WheelFile):\r\n         \r\n         self.zipfile.close()\r\n         self.__setupzipfile__()\r\n-        finally:\r\n-            shutil.rmtree(tmp_dir, True)\r\n-\r\n \r\n     def pop_records_file(self):\r\n         '''Pop off the last records file that was added'''\r\n```"}}