{"action":"created","comment":{"url":"https://api.github.com/repos/molgenis/molgenis/pulls/comments/48566633","id":48566633,"diff_hunk":"@@ -33,26 +34,50 @@\n \n \tprivate final FileRepositoryCollectionFactory fileRepositoryCollectionFactory;\n \tprivate final ImportServiceFactory importServiceFactory;\n+\tprivate final FileStore fileStore;\n \n \t@Autowired\n \tpublic I18nStringsPopulator(FileRepositoryCollectionFactory fileRepositoryCollectionFactory,\n-\t\t\tImportServiceFactory importServiceFactory)\n+\t\t\tImportServiceFactory importServiceFactory, FileStore fileStore)\n \t{\n \t\tthis.fileRepositoryCollectionFactory = fileRepositoryCollectionFactory;\n \t\tthis.importServiceFactory = importServiceFactory;\n+\t\tthis.fileStore = fileStore;\n \t}\n \n \t@Override\n \tpublic void onApplicationEvent(ContextRefreshedEvent event)\n \t{\n \t\tLOG.info(\"Importing i18n strings...\");\n+\t\tfinal String i18nFileName = \"i18n.xlsx\";\n+\n+\t\t// \"i18n is saved as a Application/Library resource.\n+\t\t// \"It is not possible to use it as a file but should streamed as a resource\"\n+\t\tClassLoader classLoader = Thread.currentThread().getContextClassLoader();\n+\t\tInputStream is = classLoader.getResourceAsStream(i18nFileName);","path":"molgenis-core-ui/src/main/java/org/molgenis/ui/I18nStringsPopulator.java","position":51,"original_position":51,"commit_id":"67de57f4d3034a15c1af2fccd17b19a02df91544","original_commit_id":"67de57f4d3034a15c1af2fccd17b19a02df91544","user":{"login":"jjettenn","id":5586255,"avatar_url":"https://avatars.githubusercontent.com/u/5586255?v=3","gravatar_id":"","url":"https://api.github.com/users/jjettenn","html_url":"https://github.com/jjettenn","followers_url":"https://api.github.com/users/jjettenn/followers","following_url":"https://api.github.com/users/jjettenn/following{/other_user}","gists_url":"https://api.github.com/users/jjettenn/gists{/gist_id}","starred_url":"https://api.github.com/users/jjettenn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjettenn/subscriptions","organizations_url":"https://api.github.com/users/jjettenn/orgs","repos_url":"https://api.github.com/users/jjettenn/repos","events_url":"https://api.github.com/users/jjettenn/events{/privacy}","received_events_url":"https://api.github.com/users/jjettenn/received_events","type":"User","site_admin":false},"body":"I18nStringsPopulator.class.getClassLoader().getResourceAsStream(i18nFileName) should probably also work. Resource is in the same package.","created_at":"2015-12-29T20:12:48Z","updated_at":"2015-12-29T20:12:48Z","html_url":"https://github.com/molgenis/molgenis/pull/4290#discussion_r48566633","pull_request_url":"https://api.github.com/repos/molgenis/molgenis/pulls/4290","_links":{"self":{"href":"https://api.github.com/repos/molgenis/molgenis/pulls/comments/48566633"},"html":{"href":"https://github.com/molgenis/molgenis/pull/4290#discussion_r48566633"},"pull_request":{"href":"https://api.github.com/repos/molgenis/molgenis/pulls/4290"}}},"pull_request":{"url":"https://api.github.com/repos/molgenis/molgenis/pulls/4290","id":54722495,"html_url":"https://github.com/molgenis/molgenis/pull/4290","diff_url":"https://github.com/molgenis/molgenis/pull/4290.diff","patch_url":"https://github.com/molgenis/molgenis/pull/4290.patch","issue_url":"https://api.github.com/repos/molgenis/molgenis/issues/4290","number":4290,"state":"open","locked":false,"title":"Fix2 #4289 ResourceUtils - NullPointerException is thrown","user":{"login":"jjettenn","id":5586255,"avatar_url":"https://avatars.githubusercontent.com/u/5586255?v=3","gravatar_id":"","url":"https://api.github.com/users/jjettenn","html_url":"https://github.com/jjettenn","followers_url":"https://api.github.com/users/jjettenn/followers","following_url":"https://api.github.com/users/jjettenn/following{/other_user}","gists_url":"https://api.github.com/users/jjettenn/gists{/gist_id}","starred_url":"https://api.github.com/users/jjettenn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjettenn/subscriptions","organizations_url":"https://api.github.com/users/jjettenn/orgs","repos_url":"https://api.github.com/users/jjettenn/repos","events_url":"https://api.github.com/users/jjettenn/events{/privacy}","received_events_url":"https://api.github.com/users/jjettenn/received_events","type":"User","site_admin":false},"body":"Second try","created_at":"2015-12-29T12:18:29Z","updated_at":"2015-12-29T20:12:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e15541ca4dfdff7732e0682e3108071e79c42f33","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/molgenis/molgenis/pulls/4290/commits","review_comments_url":"https://api.github.com/repos/molgenis/molgenis/pulls/4290/comments","review_comment_url":"https://api.github.com/repos/molgenis/molgenis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/molgenis/molgenis/issues/4290/comments","statuses_url":"https://api.github.com/repos/molgenis/molgenis/statuses/67de57f4d3034a15c1af2fccd17b19a02df91544","head":{"label":"jjettenn:fix/NullPointerException_i18n","ref":"fix/NullPointerException_i18n","sha":"67de57f4d3034a15c1af2fccd17b19a02df91544","user":{"login":"jjettenn","id":5586255,"avatar_url":"https://avatars.githubusercontent.com/u/5586255?v=3","gravatar_id":"","url":"https://api.github.com/users/jjettenn","html_url":"https://github.com/jjettenn","followers_url":"https://api.github.com/users/jjettenn/followers","following_url":"https://api.github.com/users/jjettenn/following{/other_user}","gists_url":"https://api.github.com/users/jjettenn/gists{/gist_id}","starred_url":"https://api.github.com/users/jjettenn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjettenn/subscriptions","organizations_url":"https://api.github.com/users/jjettenn/orgs","repos_url":"https://api.github.com/users/jjettenn/repos","events_url":"https://api.github.com/users/jjettenn/events{/privacy}","received_events_url":"https://api.github.com/users/jjettenn/received_events","type":"User","site_admin":false},"repo":{"id":13272521,"name":"molgenis","full_name":"jjettenn/molgenis","owner":{"login":"jjettenn","id":5586255,"avatar_url":"https://avatars.githubusercontent.com/u/5586255?v=3","gravatar_id":"","url":"https://api.github.com/users/jjettenn","html_url":"https://github.com/jjettenn","followers_url":"https://api.github.com/users/jjettenn/followers","following_url":"https://api.github.com/users/jjettenn/following{/other_user}","gists_url":"https://api.github.com/users/jjettenn/gists{/gist_id}","starred_url":"https://api.github.com/users/jjettenn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjettenn/subscriptions","organizations_url":"https://api.github.com/users/jjettenn/orgs","repos_url":"https://api.github.com/users/jjettenn/repos","events_url":"https://api.github.com/users/jjettenn/events{/privacy}","received_events_url":"https://api.github.com/users/jjettenn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jjettenn/molgenis","description":"MOLGENIS is an collaborative open source project on a mission to generate great software infrastructure for life science research. ","fork":true,"url":"https://api.github.com/repos/jjettenn/molgenis","forks_url":"https://api.github.com/repos/jjettenn/molgenis/forks","keys_url":"https://api.github.com/repos/jjettenn/molgenis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjettenn/molgenis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjettenn/molgenis/teams","hooks_url":"https://api.github.com/repos/jjettenn/molgenis/hooks","issue_events_url":"https://api.github.com/repos/jjettenn/molgenis/issues/events{/number}","events_url":"https://api.github.com/repos/jjettenn/molgenis/events","assignees_url":"https://api.github.com/repos/jjettenn/molgenis/assignees{/user}","branches_url":"https://api.github.com/repos/jjettenn/molgenis/branches{/branch}","tags_url":"https://api.github.com/repos/jjettenn/molgenis/tags","blobs_url":"https://api.github.com/repos/jjettenn/molgenis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjettenn/molgenis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjettenn/molgenis/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjettenn/molgenis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjettenn/molgenis/statuses/{sha}","languages_url":"https://api.github.com/repos/jjettenn/molgenis/languages","stargazers_url":"https://api.github.com/repos/jjettenn/molgenis/stargazers","contributors_url":"https://api.github.com/repos/jjettenn/molgenis/contributors","subscribers_url":"https://api.github.com/repos/jjettenn/molgenis/subscribers","subscription_url":"https://api.github.com/repos/jjettenn/molgenis/subscription","commits_url":"https://api.github.com/repos/jjettenn/molgenis/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjettenn/molgenis/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjettenn/molgenis/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjettenn/molgenis/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjettenn/molgenis/contents/{+path}","compare_url":"https://api.github.com/repos/jjettenn/molgenis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjettenn/molgenis/merges","archive_url":"https://api.github.com/repos/jjettenn/molgenis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjettenn/molgenis/downloads","issues_url":"https://api.github.com/repos/jjettenn/molgenis/issues{/number}","pulls_url":"https://api.github.com/repos/jjettenn/molgenis/pulls{/number}","milestones_url":"https://api.github.com/repos/jjettenn/molgenis/milestones{/number}","notifications_url":"https://api.github.com/repos/jjettenn/molgenis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjettenn/molgenis/labels{/name}","releases_url":"https://api.github.com/repos/jjettenn/molgenis/releases{/id}","created_at":"2013-10-02T14:00:43Z","updated_at":"2015-04-23T11:42:20Z","pushed_at":"2015-12-29T12:16:59Z","git_url":"git://github.com/jjettenn/molgenis.git","ssh_url":"git@github.com:jjettenn/molgenis.git","clone_url":"https://github.com/jjettenn/molgenis.git","svn_url":"https://github.com/jjettenn/molgenis","homepage":"","size":93591,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"molgenis:master","ref":"master","sha":"ed18e2b3420dbe2ee71a9068243cb7b39a22d1d1","user":{"login":"molgenis","id":1688158,"avatar_url":"https://avatars.githubusercontent.com/u/1688158?v=3","gravatar_id":"","url":"https://api.github.com/users/molgenis","html_url":"https://github.com/molgenis","followers_url":"https://api.github.com/users/molgenis/followers","following_url":"https://api.github.com/users/molgenis/following{/other_user}","gists_url":"https://api.github.com/users/molgenis/gists{/gist_id}","starred_url":"https://api.github.com/users/molgenis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molgenis/subscriptions","organizations_url":"https://api.github.com/users/molgenis/orgs","repos_url":"https://api.github.com/users/molgenis/repos","events_url":"https://api.github.com/users/molgenis/events{/privacy}","received_events_url":"https://api.github.com/users/molgenis/received_events","type":"Organization","site_admin":false},"repo":{"id":8010626,"name":"molgenis","full_name":"molgenis/molgenis","owner":{"login":"molgenis","id":1688158,"avatar_url":"https://avatars.githubusercontent.com/u/1688158?v=3","gravatar_id":"","url":"https://api.github.com/users/molgenis","html_url":"https://github.com/molgenis","followers_url":"https://api.github.com/users/molgenis/followers","following_url":"https://api.github.com/users/molgenis/following{/other_user}","gists_url":"https://api.github.com/users/molgenis/gists{/gist_id}","starred_url":"https://api.github.com/users/molgenis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molgenis/subscriptions","organizations_url":"https://api.github.com/users/molgenis/orgs","repos_url":"https://api.github.com/users/molgenis/repos","events_url":"https://api.github.com/users/molgenis/events{/privacy}","received_events_url":"https://api.github.com/users/molgenis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/molgenis/molgenis","description":"MOLGENIS - for scientific data: management, exploration, integration and analysis. ","fork":false,"url":"https://api.github.com/repos/molgenis/molgenis","forks_url":"https://api.github.com/repos/molgenis/molgenis/forks","keys_url":"https://api.github.com/repos/molgenis/molgenis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/molgenis/molgenis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/molgenis/molgenis/teams","hooks_url":"https://api.github.com/repos/molgenis/molgenis/hooks","issue_events_url":"https://api.github.com/repos/molgenis/molgenis/issues/events{/number}","events_url":"https://api.github.com/repos/molgenis/molgenis/events","assignees_url":"https://api.github.com/repos/molgenis/molgenis/assignees{/user}","branches_url":"https://api.github.com/repos/molgenis/molgenis/branches{/branch}","tags_url":"https://api.github.com/repos/molgenis/molgenis/tags","blobs_url":"https://api.github.com/repos/molgenis/molgenis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/molgenis/molgenis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/molgenis/molgenis/git/refs{/sha}","trees_url":"https://api.github.com/repos/molgenis/molgenis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/molgenis/molgenis/statuses/{sha}","languages_url":"https://api.github.com/repos/molgenis/molgenis/languages","stargazers_url":"https://api.github.com/repos/molgenis/molgenis/stargazers","contributors_url":"https://api.github.com/repos/molgenis/molgenis/contributors","subscribers_url":"https://api.github.com/repos/molgenis/molgenis/subscribers","subscription_url":"https://api.github.com/repos/molgenis/molgenis/subscription","commits_url":"https://api.github.com/repos/molgenis/molgenis/commits{/sha}","git_commits_url":"https://api.github.com/repos/molgenis/molgenis/git/commits{/sha}","comments_url":"https://api.github.com/repos/molgenis/molgenis/comments{/number}","issue_comment_url":"https://api.github.com/repos/molgenis/molgenis/issues/comments{/number}","contents_url":"https://api.github.com/repos/molgenis/molgenis/contents/{+path}","compare_url":"https://api.github.com/repos/molgenis/molgenis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/molgenis/molgenis/merges","archive_url":"https://api.github.com/repos/molgenis/molgenis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/molgenis/molgenis/downloads","issues_url":"https://api.github.com/repos/molgenis/molgenis/issues{/number}","pulls_url":"https://api.github.com/repos/molgenis/molgenis/pulls{/number}","milestones_url":"https://api.github.com/repos/molgenis/molgenis/milestones{/number}","notifications_url":"https://api.github.com/repos/molgenis/molgenis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/molgenis/molgenis/labels{/name}","releases_url":"https://api.github.com/repos/molgenis/molgenis/releases{/id}","created_at":"2013-02-04T16:02:36Z","updated_at":"2015-12-19T11:07:16Z","pushed_at":"2015-12-29T12:18:29Z","git_url":"git://github.com/molgenis/molgenis.git","ssh_url":"git@github.com:molgenis/molgenis.git","clone_url":"https://github.com/molgenis/molgenis.git","svn_url":"https://github.com/molgenis/molgenis","homepage":" https://molgenis.github.io","size":100549,"stargazers_count":20,"watchers_count":20,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":251,"forks":54,"open_issues":251,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/molgenis/molgenis/pulls/4290"},"html":{"href":"https://github.com/molgenis/molgenis/pull/4290"},"issue":{"href":"https://api.github.com/repos/molgenis/molgenis/issues/4290"},"comments":{"href":"https://api.github.com/repos/molgenis/molgenis/issues/4290/comments"},"review_comments":{"href":"https://api.github.com/repos/molgenis/molgenis/pulls/4290/comments"},"review_comment":{"href":"https://api.github.com/repos/molgenis/molgenis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/molgenis/molgenis/pulls/4290/commits"},"statuses":{"href":"https://api.github.com/repos/molgenis/molgenis/statuses/67de57f4d3034a15c1af2fccd17b19a02df91544"}}}}