{"action":"created","comment":{"url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/pulls/comments/47058247","id":47058247,"diff_hunk":"@@ -47,11 +47,34 @@ pcl::ExtractIndices<pcl::PCLPointCloud2>::applyFilter (PCLPointCloud2 &output)\n   if (keep_organized_)\n   {\n     output = *input_;\n-    for (size_t i = 0; i < indices_->size (); ++i) {\n-      for (size_t j = 0; j < output.fields.size(); ++j) {\n-        memcpy (&output.data[(*indices_)[i] * output.point_step + output.fields[j].offset],\n-                &user_filter_value_, sizeof(float));\n-      }\n+    if (negative_)\n+    {\n+      // Prepare the output and copy the data\n+      for (size_t i = 0; i < indices_->size (); ++i)","path":"jsk_pcl_ros/include/jsk_pcl_ros/pcl/extract_indices_patch.h","position":12,"original_position":12,"commit_id":"23f8e9103e666860aafb8baefc1d72c54e102bf0","original_commit_id":"23f8e9103e666860aafb8baefc1d72c54e102bf0","user":{"login":"wkentaro","id":4310419,"avatar_url":"https://avatars.githubusercontent.com/u/4310419?v=3","gravatar_id":"","url":"https://api.github.com/users/wkentaro","html_url":"https://github.com/wkentaro","followers_url":"https://api.github.com/users/wkentaro/followers","following_url":"https://api.github.com/users/wkentaro/following{/other_user}","gists_url":"https://api.github.com/users/wkentaro/gists{/gist_id}","starred_url":"https://api.github.com/users/wkentaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkentaro/subscriptions","organizations_url":"https://api.github.com/users/wkentaro/orgs","repos_url":"https://api.github.com/users/wkentaro/repos","events_url":"https://api.github.com/users/wkentaro/events{/privacy}","received_events_url":"https://api.github.com/users/wkentaro/received_events","type":"User","site_admin":false},"body":"I'd like to keep this file same as the one in pcl. Would you mind that?\r\nIn pcl library the above seems the common style. ","created_at":"2015-12-09T07:29:05Z","updated_at":"2015-12-09T07:29:05Z","html_url":"https://github.com/jsk-ros-pkg/jsk_recognition/pull/1383#discussion_r47058247","pull_request_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/pulls/1383","_links":{"self":{"href":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/pulls/comments/47058247"},"html":{"href":"https://github.com/jsk-ros-pkg/jsk_recognition/pull/1383#discussion_r47058247"},"pull_request":{"href":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/pulls/1383"}}},"pull_request":{"url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/pulls/1383","id":53065953,"html_url":"https://github.com/jsk-ros-pkg/jsk_recognition/pull/1383","diff_url":"https://github.com/jsk-ros-pkg/jsk_recognition/pull/1383.diff","patch_url":"https://github.com/jsk-ros-pkg/jsk_recognition/pull/1383.patch","issue_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/issues/1383","number":1383,"state":"open","locked":false,"title":"[jsk_pcl_ros] Fix flipped negative_ of ExtractIndices (bugfix)","user":{"login":"wkentaro","id":4310419,"avatar_url":"https://avatars.githubusercontent.com/u/4310419?v=3","gravatar_id":"","url":"https://api.github.com/users/wkentaro","html_url":"https://github.com/wkentaro","followers_url":"https://api.github.com/users/wkentaro/followers","following_url":"https://api.github.com/users/wkentaro/following{/other_user}","gists_url":"https://api.github.com/users/wkentaro/gists{/gist_id}","starred_url":"https://api.github.com/users/wkentaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkentaro/subscriptions","organizations_url":"https://api.github.com/users/wkentaro/orgs","repos_url":"https://api.github.com/users/wkentaro/repos","events_url":"https://api.github.com/users/wkentaro/events{/privacy}","received_events_url":"https://api.github.com/users/wkentaro/received_events","type":"User","site_admin":false},"body":"I mistakenly take it as opposite negative and non negative.\nI will send PR to pcl also.","created_at":"2015-12-09T01:41:27Z","updated_at":"2015-12-09T07:29:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b13959d701a3813ab94a51ea8c29269c5451e80","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/pulls/1383/commits","review_comments_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/pulls/1383/comments","review_comment_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/issues/1383/comments","statuses_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/statuses/23f8e9103e666860aafb8baefc1d72c54e102bf0","head":{"label":"wkentaro:fix-flipped-negative","ref":"fix-flipped-negative","sha":"23f8e9103e666860aafb8baefc1d72c54e102bf0","user":{"login":"wkentaro","id":4310419,"avatar_url":"https://avatars.githubusercontent.com/u/4310419?v=3","gravatar_id":"","url":"https://api.github.com/users/wkentaro","html_url":"https://github.com/wkentaro","followers_url":"https://api.github.com/users/wkentaro/followers","following_url":"https://api.github.com/users/wkentaro/following{/other_user}","gists_url":"https://api.github.com/users/wkentaro/gists{/gist_id}","starred_url":"https://api.github.com/users/wkentaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkentaro/subscriptions","organizations_url":"https://api.github.com/users/wkentaro/orgs","repos_url":"https://api.github.com/users/wkentaro/repos","events_url":"https://api.github.com/users/wkentaro/events{/privacy}","received_events_url":"https://api.github.com/users/wkentaro/received_events","type":"User","site_admin":false},"repo":{"id":31913659,"name":"jsk_recognition","full_name":"wkentaro/jsk_recognition","owner":{"login":"wkentaro","id":4310419,"avatar_url":"https://avatars.githubusercontent.com/u/4310419?v=3","gravatar_id":"","url":"https://api.github.com/users/wkentaro","html_url":"https://github.com/wkentaro","followers_url":"https://api.github.com/users/wkentaro/followers","following_url":"https://api.github.com/users/wkentaro/following{/other_user}","gists_url":"https://api.github.com/users/wkentaro/gists{/gist_id}","starred_url":"https://api.github.com/users/wkentaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkentaro/subscriptions","organizations_url":"https://api.github.com/users/wkentaro/orgs","repos_url":"https://api.github.com/users/wkentaro/repos","events_url":"https://api.github.com/users/wkentaro/events{/privacy}","received_events_url":"https://api.github.com/users/wkentaro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wkentaro/jsk_recognition","description":"JSK perception ROS packages","fork":true,"url":"https://api.github.com/repos/wkentaro/jsk_recognition","forks_url":"https://api.github.com/repos/wkentaro/jsk_recognition/forks","keys_url":"https://api.github.com/repos/wkentaro/jsk_recognition/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wkentaro/jsk_recognition/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wkentaro/jsk_recognition/teams","hooks_url":"https://api.github.com/repos/wkentaro/jsk_recognition/hooks","issue_events_url":"https://api.github.com/repos/wkentaro/jsk_recognition/issues/events{/number}","events_url":"https://api.github.com/repos/wkentaro/jsk_recognition/events","assignees_url":"https://api.github.com/repos/wkentaro/jsk_recognition/assignees{/user}","branches_url":"https://api.github.com/repos/wkentaro/jsk_recognition/branches{/branch}","tags_url":"https://api.github.com/repos/wkentaro/jsk_recognition/tags","blobs_url":"https://api.github.com/repos/wkentaro/jsk_recognition/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wkentaro/jsk_recognition/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wkentaro/jsk_recognition/git/refs{/sha}","trees_url":"https://api.github.com/repos/wkentaro/jsk_recognition/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wkentaro/jsk_recognition/statuses/{sha}","languages_url":"https://api.github.com/repos/wkentaro/jsk_recognition/languages","stargazers_url":"https://api.github.com/repos/wkentaro/jsk_recognition/stargazers","contributors_url":"https://api.github.com/repos/wkentaro/jsk_recognition/contributors","subscribers_url":"https://api.github.com/repos/wkentaro/jsk_recognition/subscribers","subscription_url":"https://api.github.com/repos/wkentaro/jsk_recognition/subscription","commits_url":"https://api.github.com/repos/wkentaro/jsk_recognition/commits{/sha}","git_commits_url":"https://api.github.com/repos/wkentaro/jsk_recognition/git/commits{/sha}","comments_url":"https://api.github.com/repos/wkentaro/jsk_recognition/comments{/number}","issue_comment_url":"https://api.github.com/repos/wkentaro/jsk_recognition/issues/comments{/number}","contents_url":"https://api.github.com/repos/wkentaro/jsk_recognition/contents/{+path}","compare_url":"https://api.github.com/repos/wkentaro/jsk_recognition/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wkentaro/jsk_recognition/merges","archive_url":"https://api.github.com/repos/wkentaro/jsk_recognition/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wkentaro/jsk_recognition/downloads","issues_url":"https://api.github.com/repos/wkentaro/jsk_recognition/issues{/number}","pulls_url":"https://api.github.com/repos/wkentaro/jsk_recognition/pulls{/number}","milestones_url":"https://api.github.com/repos/wkentaro/jsk_recognition/milestones{/number}","notifications_url":"https://api.github.com/repos/wkentaro/jsk_recognition/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wkentaro/jsk_recognition/labels{/name}","releases_url":"https://api.github.com/repos/wkentaro/jsk_recognition/releases{/id}","created_at":"2015-03-09T17:51:36Z","updated_at":"2015-08-03T12:43:08Z","pushed_at":"2015-12-09T01:41:24Z","git_url":"git://github.com/wkentaro/jsk_recognition.git","ssh_url":"git@github.com:wkentaro/jsk_recognition.git","clone_url":"https://github.com/wkentaro/jsk_recognition.git","svn_url":"https://github.com/wkentaro/jsk_recognition","homepage":"http://jsk-recognition.readthedocs.org","size":55424,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jsk-ros-pkg:master","ref":"master","sha":"ef40bfb408fb7d27f2d5c631a8eb11051fce663d","user":{"login":"jsk-ros-pkg","id":6836654,"avatar_url":"https://avatars.githubusercontent.com/u/6836654?v=3","gravatar_id":"","url":"https://api.github.com/users/jsk-ros-pkg","html_url":"https://github.com/jsk-ros-pkg","followers_url":"https://api.github.com/users/jsk-ros-pkg/followers","following_url":"https://api.github.com/users/jsk-ros-pkg/following{/other_user}","gists_url":"https://api.github.com/users/jsk-ros-pkg/gists{/gist_id}","starred_url":"https://api.github.com/users/jsk-ros-pkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsk-ros-pkg/subscriptions","organizations_url":"https://api.github.com/users/jsk-ros-pkg/orgs","repos_url":"https://api.github.com/users/jsk-ros-pkg/repos","events_url":"https://api.github.com/users/jsk-ros-pkg/events{/privacy}","received_events_url":"https://api.github.com/users/jsk-ros-pkg/received_events","type":"Organization","site_admin":false},"repo":{"id":17374628,"name":"jsk_recognition","full_name":"jsk-ros-pkg/jsk_recognition","owner":{"login":"jsk-ros-pkg","id":6836654,"avatar_url":"https://avatars.githubusercontent.com/u/6836654?v=3","gravatar_id":"","url":"https://api.github.com/users/jsk-ros-pkg","html_url":"https://github.com/jsk-ros-pkg","followers_url":"https://api.github.com/users/jsk-ros-pkg/followers","following_url":"https://api.github.com/users/jsk-ros-pkg/following{/other_user}","gists_url":"https://api.github.com/users/jsk-ros-pkg/gists{/gist_id}","starred_url":"https://api.github.com/users/jsk-ros-pkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsk-ros-pkg/subscriptions","organizations_url":"https://api.github.com/users/jsk-ros-pkg/orgs","repos_url":"https://api.github.com/users/jsk-ros-pkg/repos","events_url":"https://api.github.com/users/jsk-ros-pkg/events{/privacy}","received_events_url":"https://api.github.com/users/jsk-ros-pkg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jsk-ros-pkg/jsk_recognition","description":"JSK perception ROS packages","fork":false,"url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition","forks_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/forks","keys_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/teams","hooks_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/hooks","issue_events_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/issues/events{/number}","events_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/events","assignees_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/assignees{/user}","branches_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/branches{/branch}","tags_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/tags","blobs_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/statuses/{sha}","languages_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/languages","stargazers_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/stargazers","contributors_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/contributors","subscribers_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/subscribers","subscription_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/subscription","commits_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/contents/{+path}","compare_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/merges","archive_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/downloads","issues_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/issues{/number}","pulls_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/pulls{/number}","milestones_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/milestones{/number}","notifications_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/labels{/name}","releases_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/releases{/id}","created_at":"2014-03-03T17:59:44Z","updated_at":"2015-12-07T19:06:18Z","pushed_at":"2015-12-09T01:41:27Z","git_url":"git://github.com/jsk-ros-pkg/jsk_recognition.git","ssh_url":"git@github.com:jsk-ros-pkg/jsk_recognition.git","clone_url":"https://github.com/jsk-ros-pkg/jsk_recognition.git","svn_url":"https://github.com/jsk-ros-pkg/jsk_recognition","homepage":"https://github.com/jsk-ros-pkg/jsk_recognition","size":60432,"stargazers_count":21,"watchers_count":21,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":31,"forks":39,"open_issues":31,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/pulls/1383"},"html":{"href":"https://github.com/jsk-ros-pkg/jsk_recognition/pull/1383"},"issue":{"href":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/issues/1383"},"comments":{"href":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/issues/1383/comments"},"review_comments":{"href":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/pulls/1383/comments"},"review_comment":{"href":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/pulls/1383/commits"},"statuses":{"href":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/statuses/23f8e9103e666860aafb8baefc1d72c54e102bf0"}}}}