{"action":"closed","number":110,"pull_request":{"url":"https://api.github.com/repos/Valloric/ycmd/pulls/110","id":33240417,"html_url":"https://github.com/Valloric/ycmd/pull/110","diff_url":"https://github.com/Valloric/ycmd/pull/110.diff","patch_url":"https://github.com/Valloric/ycmd/pull/110.patch","issue_url":"https://api.github.com/repos/Valloric/ycmd/issues/110","number":110,"state":"closed","locked":false,"title":"now import can complete Frameworks","user":{"login":"SolaWing","id":3897953,"avatar_url":"https://avatars.githubusercontent.com/u/3897953?v=3","gravatar_id":"","url":"https://api.github.com/users/SolaWing","html_url":"https://github.com/SolaWing","followers_url":"https://api.github.com/users/SolaWing/followers","following_url":"https://api.github.com/users/SolaWing/following{/other_user}","gists_url":"https://api.github.com/users/SolaWing/gists{/gist_id}","starred_url":"https://api.github.com/users/SolaWing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolaWing/subscriptions","organizations_url":"https://api.github.com/users/SolaWing/orgs","repos_url":"https://api.github.com/users/SolaWing/repos","events_url":"https://api.github.com/users/SolaWing/events{/privacy}","received_events_url":"https://api.github.com/users/SolaWing/received_events","type":"User","site_admin":false},"body":"hi, @Valloric, I add completion of `Frameworks` in iOS&Mac.\r\n\r\nIn Mac, Frameworks have the following structure:\r\n\r\n`UIKit.framework/Headers/*.h`\r\n\r\nAnd in Xcode, the user can import a framework file as `import <UIKit/UIKit.h>`, the user don't need to type .framework/Headers.   So I add this complete feature.\r\n\r\nIn detail, I add `-F`, `-iframework` flags in `UserIncludePaths`, so includePaths will contains framework's path.  then, in `GetPathsIncludeCase`, if the path which join `include_path` and user's inputting path is not a dir, I try append `.framework/Headers` and check if it's a dir. if so, this inputting path match a framework and return the files inside `Headers`. and upon return, if the complete basename ends with `.framework`, I remove it, and recognize it as a \\[Lib](framework is long, so I use Lib instead)\r\n\r\nthe side effect is of standard file name completing which also use `_GenerateCandidatesForPaths`, so if file end with `.framework`, it also will be recognized as a framework and remove the extension. But I think this case is rarely happen.\r\n\r\n(I already sign **Google Contributor License Agreement**)","created_at":"2015-04-14T09:32:08Z","updated_at":"2015-07-13T18:34:24Z","closed_at":"2015-07-13T18:34:24Z","merged_at":null,"merge_commit_sha":"753ee7049e11a8fa5f0a783ecc93e692fe616620","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Valloric/ycmd/pulls/110/commits","review_comments_url":"https://api.github.com/repos/Valloric/ycmd/pulls/110/comments","review_comment_url":"https://api.github.com/repos/Valloric/ycmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Valloric/ycmd/issues/110/comments","statuses_url":"https://api.github.com/repos/Valloric/ycmd/statuses/4d1a840a2417862eb5c4df28552d44b98df290dd","head":{"label":"SolaWing:waitForMerge","ref":"waitForMerge","sha":"4d1a840a2417862eb5c4df28552d44b98df290dd","user":{"login":"SolaWing","id":3897953,"avatar_url":"https://avatars.githubusercontent.com/u/3897953?v=3","gravatar_id":"","url":"https://api.github.com/users/SolaWing","html_url":"https://github.com/SolaWing","followers_url":"https://api.github.com/users/SolaWing/followers","following_url":"https://api.github.com/users/SolaWing/following{/other_user}","gists_url":"https://api.github.com/users/SolaWing/gists{/gist_id}","starred_url":"https://api.github.com/users/SolaWing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolaWing/subscriptions","organizations_url":"https://api.github.com/users/SolaWing/orgs","repos_url":"https://api.github.com/users/SolaWing/repos","events_url":"https://api.github.com/users/SolaWing/events{/privacy}","received_events_url":"https://api.github.com/users/SolaWing/received_events","type":"User","site_admin":false},"repo":{"id":26075940,"name":"ycmd","full_name":"SolaWing/ycmd","owner":{"login":"SolaWing","id":3897953,"avatar_url":"https://avatars.githubusercontent.com/u/3897953?v=3","gravatar_id":"","url":"https://api.github.com/users/SolaWing","html_url":"https://github.com/SolaWing","followers_url":"https://api.github.com/users/SolaWing/followers","following_url":"https://api.github.com/users/SolaWing/following{/other_user}","gists_url":"https://api.github.com/users/SolaWing/gists{/gist_id}","starred_url":"https://api.github.com/users/SolaWing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolaWing/subscriptions","organizations_url":"https://api.github.com/users/SolaWing/orgs","repos_url":"https://api.github.com/users/SolaWing/repos","events_url":"https://api.github.com/users/SolaWing/events{/privacy}","received_events_url":"https://api.github.com/users/SolaWing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SolaWing/ycmd","description":"A code-completion & code-comprehension server","fork":true,"url":"https://api.github.com/repos/SolaWing/ycmd","forks_url":"https://api.github.com/repos/SolaWing/ycmd/forks","keys_url":"https://api.github.com/repos/SolaWing/ycmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SolaWing/ycmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SolaWing/ycmd/teams","hooks_url":"https://api.github.com/repos/SolaWing/ycmd/hooks","issue_events_url":"https://api.github.com/repos/SolaWing/ycmd/issues/events{/number}","events_url":"https://api.github.com/repos/SolaWing/ycmd/events","assignees_url":"https://api.github.com/repos/SolaWing/ycmd/assignees{/user}","branches_url":"https://api.github.com/repos/SolaWing/ycmd/branches{/branch}","tags_url":"https://api.github.com/repos/SolaWing/ycmd/tags","blobs_url":"https://api.github.com/repos/SolaWing/ycmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SolaWing/ycmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SolaWing/ycmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/SolaWing/ycmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SolaWing/ycmd/statuses/{sha}","languages_url":"https://api.github.com/repos/SolaWing/ycmd/languages","stargazers_url":"https://api.github.com/repos/SolaWing/ycmd/stargazers","contributors_url":"https://api.github.com/repos/SolaWing/ycmd/contributors","subscribers_url":"https://api.github.com/repos/SolaWing/ycmd/subscribers","subscription_url":"https://api.github.com/repos/SolaWing/ycmd/subscription","commits_url":"https://api.github.com/repos/SolaWing/ycmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/SolaWing/ycmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/SolaWing/ycmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/SolaWing/ycmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/SolaWing/ycmd/contents/{+path}","compare_url":"https://api.github.com/repos/SolaWing/ycmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SolaWing/ycmd/merges","archive_url":"https://api.github.com/repos/SolaWing/ycmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SolaWing/ycmd/downloads","issues_url":"https://api.github.com/repos/SolaWing/ycmd/issues{/number}","pulls_url":"https://api.github.com/repos/SolaWing/ycmd/pulls{/number}","milestones_url":"https://api.github.com/repos/SolaWing/ycmd/milestones{/number}","notifications_url":"https://api.github.com/repos/SolaWing/ycmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SolaWing/ycmd/labels{/name}","releases_url":"https://api.github.com/repos/SolaWing/ycmd/releases{/id}","created_at":"2014-11-02T09:01:16Z","updated_at":"2015-04-25T02:23:02Z","pushed_at":"2015-05-20T10:24:42Z","git_url":"git://github.com/SolaWing/ycmd.git","ssh_url":"git@github.com:SolaWing/ycmd.git","clone_url":"https://github.com/SolaWing/ycmd.git","svn_url":"https://github.com/SolaWing/ycmd","homepage":null,"size":6141,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"mine"}},"base":{"label":"Valloric:master","ref":"master","sha":"8e228643ffcab2aa274777ca8b9b0c8183f0ef24","user":{"login":"Valloric","id":919444,"avatar_url":"https://avatars.githubusercontent.com/u/919444?v=3","gravatar_id":"","url":"https://api.github.com/users/Valloric","html_url":"https://github.com/Valloric","followers_url":"https://api.github.com/users/Valloric/followers","following_url":"https://api.github.com/users/Valloric/following{/other_user}","gists_url":"https://api.github.com/users/Valloric/gists{/gist_id}","starred_url":"https://api.github.com/users/Valloric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valloric/subscriptions","organizations_url":"https://api.github.com/users/Valloric/orgs","repos_url":"https://api.github.com/users/Valloric/repos","events_url":"https://api.github.com/users/Valloric/events{/privacy}","received_events_url":"https://api.github.com/users/Valloric/received_events","type":"User","site_admin":false},"repo":{"id":19832415,"name":"ycmd","full_name":"Valloric/ycmd","owner":{"login":"Valloric","id":919444,"avatar_url":"https://avatars.githubusercontent.com/u/919444?v=3","gravatar_id":"","url":"https://api.github.com/users/Valloric","html_url":"https://github.com/Valloric","followers_url":"https://api.github.com/users/Valloric/followers","following_url":"https://api.github.com/users/Valloric/following{/other_user}","gists_url":"https://api.github.com/users/Valloric/gists{/gist_id}","starred_url":"https://api.github.com/users/Valloric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valloric/subscriptions","organizations_url":"https://api.github.com/users/Valloric/orgs","repos_url":"https://api.github.com/users/Valloric/repos","events_url":"https://api.github.com/users/Valloric/events{/privacy}","received_events_url":"https://api.github.com/users/Valloric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Valloric/ycmd","description":"A code-completion & code-comprehension server","fork":false,"url":"https://api.github.com/repos/Valloric/ycmd","forks_url":"https://api.github.com/repos/Valloric/ycmd/forks","keys_url":"https://api.github.com/repos/Valloric/ycmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Valloric/ycmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Valloric/ycmd/teams","hooks_url":"https://api.github.com/repos/Valloric/ycmd/hooks","issue_events_url":"https://api.github.com/repos/Valloric/ycmd/issues/events{/number}","events_url":"https://api.github.com/repos/Valloric/ycmd/events","assignees_url":"https://api.github.com/repos/Valloric/ycmd/assignees{/user}","branches_url":"https://api.github.com/repos/Valloric/ycmd/branches{/branch}","tags_url":"https://api.github.com/repos/Valloric/ycmd/tags","blobs_url":"https://api.github.com/repos/Valloric/ycmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Valloric/ycmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Valloric/ycmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Valloric/ycmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Valloric/ycmd/statuses/{sha}","languages_url":"https://api.github.com/repos/Valloric/ycmd/languages","stargazers_url":"https://api.github.com/repos/Valloric/ycmd/stargazers","contributors_url":"https://api.github.com/repos/Valloric/ycmd/contributors","subscribers_url":"https://api.github.com/repos/Valloric/ycmd/subscribers","subscription_url":"https://api.github.com/repos/Valloric/ycmd/subscription","commits_url":"https://api.github.com/repos/Valloric/ycmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Valloric/ycmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Valloric/ycmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Valloric/ycmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Valloric/ycmd/contents/{+path}","compare_url":"https://api.github.com/repos/Valloric/ycmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Valloric/ycmd/merges","archive_url":"https://api.github.com/repos/Valloric/ycmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Valloric/ycmd/downloads","issues_url":"https://api.github.com/repos/Valloric/ycmd/issues{/number}","pulls_url":"https://api.github.com/repos/Valloric/ycmd/pulls{/number}","milestones_url":"https://api.github.com/repos/Valloric/ycmd/milestones{/number}","notifications_url":"https://api.github.com/repos/Valloric/ycmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Valloric/ycmd/labels{/name}","releases_url":"https://api.github.com/repos/Valloric/ycmd/releases{/id}","created_at":"2014-05-15T19:30:17Z","updated_at":"2015-07-13T02:42:01Z","pushed_at":"2015-07-12T22:05:10Z","git_url":"git://github.com/Valloric/ycmd.git","ssh_url":"git@github.com:Valloric/ycmd.git","clone_url":"https://github.com/Valloric/ycmd.git","svn_url":"https://github.com/Valloric/ycmd","homepage":null,"size":9161,"stargazers_count":315,"watchers_count":315,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":168,"mirror_url":null,"open_issues_count":16,"forks":168,"open_issues":16,"watchers":315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/110"},"html":{"href":"https://github.com/Valloric/ycmd/pull/110"},"issue":{"href":"https://api.github.com/repos/Valloric/ycmd/issues/110"},"comments":{"href":"https://api.github.com/repos/Valloric/ycmd/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/Valloric/ycmd/statuses/4d1a840a2417862eb5c4df28552d44b98df290dd"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":52,"deletions":10,"changed_files":5}}