{"action":"created","issue":{"url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1262","labels_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1262/labels{/name}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1262/comments","events_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1262/events","html_url":"https://github.com/RPCS3/rpcs3/pull/1262","id":111966968,"number":1262,"title":"Lots of defect fixes","user":{"login":"tambry","id":1827708,"avatar_url":"https://avatars.githubusercontent.com/u/1827708?v=3","gravatar_id":"","url":"https://api.github.com/users/tambry","html_url":"https://github.com/tambry","followers_url":"https://api.github.com/users/tambry/followers","following_url":"https://api.github.com/users/tambry/following{/other_user}","gists_url":"https://api.github.com/users/tambry/gists{/gist_id}","starred_url":"https://api.github.com/users/tambry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tambry/subscriptions","organizations_url":"https://api.github.com/users/tambry/orgs","repos_url":"https://api.github.com/users/tambry/repos","events_url":"https://api.github.com/users/tambry/events{/privacy}","received_events_url":"https://api.github.com/users/tambry/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":25,"created_at":"2015-10-17T15:01:30Z","updated_at":"2015-11-08T12:16:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1262","html_url":"https://github.com/RPCS3/rpcs3/pull/1262","diff_url":"https://github.com/RPCS3/rpcs3/pull/1262.diff","patch_url":"https://github.com/RPCS3/rpcs3/pull/1262.patch"},"body":"Includes a few memory corruption bugs fixed, added initialization for a couple variables, fixed some flow control problems and added error checks and error logging to a lot of places.\r\n\r\nHDD functions now also return a negative version, if they fail seeking. Didn't add any checks for when they're actually used, but if we'd want to be more or less correct, we should check for errors from those functions in the future."},"comment":{"url":"https://api.github.com/repos/RPCS3/rpcs3/issues/comments/154816729","html_url":"https://github.com/RPCS3/rpcs3/pull/1262#issuecomment-154816729","issue_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1262","id":154816729,"user":{"login":"Nekotekina","id":6028184,"avatar_url":"https://avatars.githubusercontent.com/u/6028184?v=3","gravatar_id":"","url":"https://api.github.com/users/Nekotekina","html_url":"https://github.com/Nekotekina","followers_url":"https://api.github.com/users/Nekotekina/followers","following_url":"https://api.github.com/users/Nekotekina/following{/other_user}","gists_url":"https://api.github.com/users/Nekotekina/gists{/gist_id}","starred_url":"https://api.github.com/users/Nekotekina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nekotekina/subscriptions","organizations_url":"https://api.github.com/users/Nekotekina/orgs","repos_url":"https://api.github.com/users/Nekotekina/repos","events_url":"https://api.github.com/users/Nekotekina/events{/privacy}","received_events_url":"https://api.github.com/users/Nekotekina/received_events","type":"User","site_admin":false},"created_at":"2015-11-08T12:16:05Z","updated_at":"2015-11-08T12:16:05Z","body":"Who asked you to change return type?\r\nhttp://stackoverflow.com/questions/2711522/what-happens-if-i-assign-a-negative-value-to-an-unsigned-variable\r\n\r\n```\r\nCHECK_ASSERTION(x.seek(...) != -1);\r\n```\r\n\r\nMuch better and always works."}}