{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments/27332188","id":27332188,"diff_hunk":"@@ -70,12 +79,24 @@ def get(url, headers)\n     request_options.set_as(ResponseBodyType::TEXT)\n     configure_timeouts(request_options)\n     configure_ssl(request_options)\n-    response = SyncHttpClient.get(request_options)\n+    response = client_get(request_options)\n     ruby_response(response)\n   end\n \n   private\n \n+  def client_get(request_options)\n+    SyncHttpClient.get(request_options)\n+  rescue Java::ComPuppetlabsHttpClient::HttpClientException => e\n+    raise Puppet::Server::HttpClientError.new(e.inspect, e)","path":"src/ruby/puppet-server-lib/puppet/server/http_client.rb","position":50,"original_position":50,"commit_id":"968d39be33a6898acfe59c2a6672689cc0c30b8f","original_commit_id":"968d39be33a6898acfe59c2a6672689cc0c30b8f","user":{"login":"jeffmccune","id":8972,"avatar_url":"https://avatars.githubusercontent.com/u/8972?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmccune","html_url":"https://github.com/jeffmccune","followers_url":"https://api.github.com/users/jeffmccune/followers","following_url":"https://api.github.com/users/jeffmccune/following{/other_user}","gists_url":"https://api.github.com/users/jeffmccune/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmccune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmccune/subscriptions","organizations_url":"https://api.github.com/users/jeffmccune/orgs","repos_url":"https://api.github.com/users/jeffmccune/repos","events_url":"https://api.github.com/users/jeffmccune/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmccune/received_events","type":"User","site_admin":false},"body":"I agree, I think it should be message rather than inspect.","created_at":"2015-03-27T21:22:26Z","updated_at":"2015-03-27T21:22:26Z","html_url":"https://github.com/puppetlabs/puppet-server/pull/475#discussion_r27332188","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/475","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments/27332188"},"html":{"href":"https://github.com/puppetlabs/puppet-server/pull/475#discussion_r27332188"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/475"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/475","id":32070202,"html_url":"https://github.com/puppetlabs/puppet-server/pull/475","diff_url":"https://github.com/puppetlabs/puppet-server/pull/475.diff","patch_url":"https://github.com/puppetlabs/puppet-server/pull/475.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/475","number":475,"state":"open","locked":false,"title":"(SERVER-517) Raise Ruby errors from HTTP client","user":{"login":"nwolfe","id":1787615,"avatar_url":"https://avatars.githubusercontent.com/u/1787615?v=3","gravatar_id":"","url":"https://api.github.com/users/nwolfe","html_url":"https://github.com/nwolfe","followers_url":"https://api.github.com/users/nwolfe/followers","following_url":"https://api.github.com/users/nwolfe/following{/other_user}","gists_url":"https://api.github.com/users/nwolfe/gists{/gist_id}","starred_url":"https://api.github.com/users/nwolfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwolfe/subscriptions","organizations_url":"https://api.github.com/users/nwolfe/orgs","repos_url":"https://api.github.com/users/nwolfe/repos","events_url":"https://api.github.com/users/nwolfe/events{/privacy}","received_events_url":"https://api.github.com/users/nwolfe/received_events","type":"User","site_admin":false},"body":"This commit changes the HTTP client so it catches underlying Java\r\nexceptions and raises them as a Ruby Puppet::Server::HttpClientError\r\ninstead.\r\n\r\nThis change allows consumers of the HTTP client to catch errors using\r\nonly MRI Ruby and not require the use of JRuby.","created_at":"2015-03-26T23:05:17Z","updated_at":"2015-03-27T21:22:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f9fc86a123e82660be6ded1a7c52c1605634f36","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/475/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/475/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/475/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/968d39be33a6898acfe59c2a6672689cc0c30b8f","head":{"label":"nwolfe:feature/stable/svr517-no-java-exceptions","ref":"feature/stable/svr517-no-java-exceptions","sha":"968d39be33a6898acfe59c2a6672689cc0c30b8f","user":{"login":"nwolfe","id":1787615,"avatar_url":"https://avatars.githubusercontent.com/u/1787615?v=3","gravatar_id":"","url":"https://api.github.com/users/nwolfe","html_url":"https://github.com/nwolfe","followers_url":"https://api.github.com/users/nwolfe/followers","following_url":"https://api.github.com/users/nwolfe/following{/other_user}","gists_url":"https://api.github.com/users/nwolfe/gists{/gist_id}","starred_url":"https://api.github.com/users/nwolfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwolfe/subscriptions","organizations_url":"https://api.github.com/users/nwolfe/orgs","repos_url":"https://api.github.com/users/nwolfe/repos","events_url":"https://api.github.com/users/nwolfe/events{/privacy}","received_events_url":"https://api.github.com/users/nwolfe/received_events","type":"User","site_admin":false},"repo":{"id":24339727,"name":"puppet-server","full_name":"nwolfe/puppet-server","owner":{"login":"nwolfe","id":1787615,"avatar_url":"https://avatars.githubusercontent.com/u/1787615?v=3","gravatar_id":"","url":"https://api.github.com/users/nwolfe","html_url":"https://github.com/nwolfe","followers_url":"https://api.github.com/users/nwolfe/followers","following_url":"https://api.github.com/users/nwolfe/following{/other_user}","gists_url":"https://api.github.com/users/nwolfe/gists{/gist_id}","starred_url":"https://api.github.com/users/nwolfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwolfe/subscriptions","organizations_url":"https://api.github.com/users/nwolfe/orgs","repos_url":"https://api.github.com/users/nwolfe/repos","events_url":"https://api.github.com/users/nwolfe/events{/privacy}","received_events_url":"https://api.github.com/users/nwolfe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nwolfe/puppet-server","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/nwolfe/puppet-server","forks_url":"https://api.github.com/repos/nwolfe/puppet-server/forks","keys_url":"https://api.github.com/repos/nwolfe/puppet-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nwolfe/puppet-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nwolfe/puppet-server/teams","hooks_url":"https://api.github.com/repos/nwolfe/puppet-server/hooks","issue_events_url":"https://api.github.com/repos/nwolfe/puppet-server/issues/events{/number}","events_url":"https://api.github.com/repos/nwolfe/puppet-server/events","assignees_url":"https://api.github.com/repos/nwolfe/puppet-server/assignees{/user}","branches_url":"https://api.github.com/repos/nwolfe/puppet-server/branches{/branch}","tags_url":"https://api.github.com/repos/nwolfe/puppet-server/tags","blobs_url":"https://api.github.com/repos/nwolfe/puppet-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nwolfe/puppet-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nwolfe/puppet-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/nwolfe/puppet-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nwolfe/puppet-server/statuses/{sha}","languages_url":"https://api.github.com/repos/nwolfe/puppet-server/languages","stargazers_url":"https://api.github.com/repos/nwolfe/puppet-server/stargazers","contributors_url":"https://api.github.com/repos/nwolfe/puppet-server/contributors","subscribers_url":"https://api.github.com/repos/nwolfe/puppet-server/subscribers","subscription_url":"https://api.github.com/repos/nwolfe/puppet-server/subscription","commits_url":"https://api.github.com/repos/nwolfe/puppet-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/nwolfe/puppet-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/nwolfe/puppet-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/nwolfe/puppet-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/nwolfe/puppet-server/contents/{+path}","compare_url":"https://api.github.com/repos/nwolfe/puppet-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nwolfe/puppet-server/merges","archive_url":"https://api.github.com/repos/nwolfe/puppet-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nwolfe/puppet-server/downloads","issues_url":"https://api.github.com/repos/nwolfe/puppet-server/issues{/number}","pulls_url":"https://api.github.com/repos/nwolfe/puppet-server/pulls{/number}","milestones_url":"https://api.github.com/repos/nwolfe/puppet-server/milestones{/number}","notifications_url":"https://api.github.com/repos/nwolfe/puppet-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nwolfe/puppet-server/labels{/name}","releases_url":"https://api.github.com/repos/nwolfe/puppet-server/releases{/id}","created_at":"2014-09-22T18:14:12Z","updated_at":"2014-09-22T18:07:22Z","pushed_at":"2015-03-26T22:57:53Z","git_url":"git://github.com/nwolfe/puppet-server.git","ssh_url":"git@github.com:nwolfe/puppet-server.git","clone_url":"https://github.com/nwolfe/puppet-server.git","svn_url":"https://github.com/nwolfe/puppet-server","homepage":"","size":2178,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:stable","ref":"stable","sha":"86e2b6b79a9ad88c796579945d3d802cdc250359","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":19546488,"name":"puppet-server","full_name":"puppetlabs/puppet-server","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet-server","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet-server","forks_url":"https://api.github.com/repos/puppetlabs/puppet-server/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet-server/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet-server/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet-server/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet-server/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet-server/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet-server/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet-server/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet-server/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet-server/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet-server/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet-server/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet-server/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet-server/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet-server/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet-server/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet-server/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet-server/releases{/id}","created_at":"2014-05-07T19:00:24Z","updated_at":"2015-03-26T23:46:58Z","pushed_at":"2015-03-27T18:10:23Z","git_url":"git://github.com/puppetlabs/puppet-server.git","ssh_url":"git@github.com:puppetlabs/puppet-server.git","clone_url":"https://github.com/puppetlabs/puppet-server.git","svn_url":"https://github.com/puppetlabs/puppet-server","homepage":"https://tickets.puppetlabs.com/browse/SERVER","size":6171,"stargazers_count":90,"watchers_count":90,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":9,"forks":45,"open_issues":9,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/475"},"html":{"href":"https://github.com/puppetlabs/puppet-server/pull/475"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/issues/475"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/issues/475/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/475/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/475/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/968d39be33a6898acfe59c2a6672689cc0c30b8f"}}}}