{"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments/32872618","id":32872618,"diff_hunk":"@@ -0,0 +1,84 @@\n+/*\n+ * Copyright 2015 the original author or authors.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.springframework.integration.zookeeper;\n+\n+import java.io.IOException;\n+import java.util.concurrent.TimeUnit;\n+\n+import org.apache.commons.logging.Log;\n+import org.apache.commons.logging.LogFactory;\n+import org.apache.curator.framework.CuratorFramework;\n+import org.apache.curator.framework.CuratorFrameworkFactory;\n+import org.apache.curator.retry.BoundedExponentialBackoffRetry;\n+import org.apache.curator.test.TestingServer;\n+import org.apache.curator.utils.CloseableUtils;\n+import org.junit.After;\n+import org.junit.Before;\n+\n+/**\n+ * @author Marius Bogoevici\n+ * @author Gary Russell\n+ * @since 4.2\n+ *\n+ */\n+public class ZookeeperTestSupport {\n+\n+\tprotected final Log log = LogFactory.getLog(this.getClass());\n+\n+\tprivate TestingServer testingServer;\n+\n+\tprotected CuratorFramework client;\n+\n+\tpublic ZookeeperTestSupport() {\n+\t\tsuper();\n+\t}\n+\n+\t@Before\n+\tpublic void setUp() throws Exception {\n+\t\ttestingServer = new TestingServer(true);\n+\t\tclient = createNewClient();\n+\t}\n+\n+\t@After\n+\tpublic void tearDown() {\n+\t\tcloseClient(this.client);\n+\t\ttry {\n+\t\t\ttestingServer.stop();\n+\t\t}\n+\t\tcatch (IOException e) {\n+\t\t\tlog.warn(\"Exception thrown while shutting down ZooKeeper: \", e);\n+\t\t}\n+\t\ttestingServer.getTempDirectory().delete();\n+\t}","path":"spring-integration-zookeeper/src/test/java/org/springframework/integration/zookeeper/ZookeeperTestSupport.java","position":65,"original_position":65,"commit_id":"6b932eb5c9f4e932c992971f244f67ea3d480834","original_commit_id":"6b932eb5c9f4e932c992971f244f67ea3d480834","user":{"login":"artembilan","id":1071590,"avatar_url":"https://avatars.githubusercontent.com/u/1071590?v=3","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"body":"From other side in the real world we really get deal with shared instances and make objects clean and fresh is really a task for the end-application. \r\n\r\nI'd be happy do not have any issues with a shared server, but right now we doesn't reflect that with current solution.\r\n\r\nWell, to be kind we really can investigate that as a separate JIRA, but you haven't convinced me that your solution works well in distributed shared environment, because you provide only instance-per-task state. And I really sure that tidying server in the `@Before` would be better by performance than new server for each test.\r\n\r\nHaving those objections, I'd say that PR isn't acceptable yet, so no reason to move rest task to the separate JIRA :smile: .\r\n","created_at":"2015-06-19T21:52:58Z","updated_at":"2015-06-19T21:52:58Z","html_url":"https://github.com/spring-projects/spring-integration/pull/1475#discussion_r32872618","pull_request_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1475","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments/32872618"},"html":{"href":"https://github.com/spring-projects/spring-integration/pull/1475#discussion_r32872618"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1475"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1475","id":37943423,"html_url":"https://github.com/spring-projects/spring-integration/pull/1475","diff_url":"https://github.com/spring-projects/spring-integration/pull/1475.diff","patch_url":"https://github.com/spring-projects/spring-integration/pull/1475.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/1475","number":1475,"state":"open","locked":false,"title":"INT-3616: Zookeeper LockRegistry","user":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars.githubusercontent.com/u/483832?v=3","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"body":"JIRA: https://jira.spring.io/browse/INT-3616\r\n\r\nZookeeper implementation of `LockRegistry`, for example to support\r\nclustered aggregators (when using external message group stores).\r\n\r\n__TODO__\r\n\r\nDocs","created_at":"2015-06-17T20:32:45Z","updated_at":"2015-06-19T21:52:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9001e4afbd59d7822d5e1ce49cd435525a420ab1","assignee":{"login":"mbogoevici","id":159684,"avatar_url":"https://avatars.githubusercontent.com/u/159684?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogoevici","html_url":"https://github.com/mbogoevici","followers_url":"https://api.github.com/users/mbogoevici/followers","following_url":"https://api.github.com/users/mbogoevici/following{/other_user}","gists_url":"https://api.github.com/users/mbogoevici/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogoevici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogoevici/subscriptions","organizations_url":"https://api.github.com/users/mbogoevici/orgs","repos_url":"https://api.github.com/users/mbogoevici/repos","events_url":"https://api.github.com/users/mbogoevici/events{/privacy}","received_events_url":"https://api.github.com/users/mbogoevici/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1475/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1475/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/1475/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-integration/statuses/6b932eb5c9f4e932c992971f244f67ea3d480834","head":{"label":"garyrussell:INT-3616","ref":"INT-3616","sha":"6b932eb5c9f4e932c992971f244f67ea3d480834","user":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars.githubusercontent.com/u/483832?v=3","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"repo":{"id":2197787,"name":"spring-integration","full_name":"garyrussell/spring-integration","owner":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars.githubusercontent.com/u/483832?v=3","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garyrussell/spring-integration","description":"","fork":true,"url":"https://api.github.com/repos/garyrussell/spring-integration","forks_url":"https://api.github.com/repos/garyrussell/spring-integration/forks","keys_url":"https://api.github.com/repos/garyrussell/spring-integration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garyrussell/spring-integration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garyrussell/spring-integration/teams","hooks_url":"https://api.github.com/repos/garyrussell/spring-integration/hooks","issue_events_url":"https://api.github.com/repos/garyrussell/spring-integration/issues/events{/number}","events_url":"https://api.github.com/repos/garyrussell/spring-integration/events","assignees_url":"https://api.github.com/repos/garyrussell/spring-integration/assignees{/user}","branches_url":"https://api.github.com/repos/garyrussell/spring-integration/branches{/branch}","tags_url":"https://api.github.com/repos/garyrussell/spring-integration/tags","blobs_url":"https://api.github.com/repos/garyrussell/spring-integration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garyrussell/spring-integration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garyrussell/spring-integration/git/refs{/sha}","trees_url":"https://api.github.com/repos/garyrussell/spring-integration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garyrussell/spring-integration/statuses/{sha}","languages_url":"https://api.github.com/repos/garyrussell/spring-integration/languages","stargazers_url":"https://api.github.com/repos/garyrussell/spring-integration/stargazers","contributors_url":"https://api.github.com/repos/garyrussell/spring-integration/contributors","subscribers_url":"https://api.github.com/repos/garyrussell/spring-integration/subscribers","subscription_url":"https://api.github.com/repos/garyrussell/spring-integration/subscription","commits_url":"https://api.github.com/repos/garyrussell/spring-integration/commits{/sha}","git_commits_url":"https://api.github.com/repos/garyrussell/spring-integration/git/commits{/sha}","comments_url":"https://api.github.com/repos/garyrussell/spring-integration/comments{/number}","issue_comment_url":"https://api.github.com/repos/garyrussell/spring-integration/issues/comments{/number}","contents_url":"https://api.github.com/repos/garyrussell/spring-integration/contents/{+path}","compare_url":"https://api.github.com/repos/garyrussell/spring-integration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garyrussell/spring-integration/merges","archive_url":"https://api.github.com/repos/garyrussell/spring-integration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garyrussell/spring-integration/downloads","issues_url":"https://api.github.com/repos/garyrussell/spring-integration/issues{/number}","pulls_url":"https://api.github.com/repos/garyrussell/spring-integration/pulls{/number}","milestones_url":"https://api.github.com/repos/garyrussell/spring-integration/milestones{/number}","notifications_url":"https://api.github.com/repos/garyrussell/spring-integration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garyrussell/spring-integration/labels{/name}","releases_url":"https://api.github.com/repos/garyrussell/spring-integration/releases{/id}","created_at":"2011-08-12T15:45:00Z","updated_at":"2015-05-05T14:02:54Z","pushed_at":"2015-06-19T17:37:54Z","git_url":"git://github.com/garyrussell/spring-integration.git","ssh_url":"git@github.com:garyrussell/spring-integration.git","clone_url":"https://github.com/garyrussell/spring-integration.git","svn_url":"https://github.com/garyrussell/spring-integration","homepage":"","size":36455,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"8782d097cf7465efdb69c204ef2f0142b7b1a7cf","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":2090979,"name":"spring-integration","full_name":"spring-projects/spring-integration","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-integration","description":"Spring Integration provides an extension of the Spring programming model to support the well-known Enterprise Integration Patterns (EIP)","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-integration","forks_url":"https://api.github.com/repos/spring-projects/spring-integration/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-integration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-integration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-integration/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-integration/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-integration/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-integration/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-integration/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-integration/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-integration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-integration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-integration/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-integration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-integration/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-integration/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-integration/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-integration/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-integration/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-integration/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-integration/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-integration/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-integration/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-integration/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-integration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-integration/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-integration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-integration/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-integration/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-integration/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-integration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-integration/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-integration/releases{/id}","created_at":"2011-07-22T21:47:27Z","updated_at":"2015-06-19T11:41:49Z","pushed_at":"2015-06-19T19:21:49Z","git_url":"git://github.com/spring-projects/spring-integration.git","ssh_url":"git@github.com:spring-projects/spring-integration.git","clone_url":"https://github.com/spring-projects/spring-integration.git","svn_url":"https://github.com/spring-projects/spring-integration","homepage":"http://projects.spring.io/spring-integration/","size":86723,"stargazers_count":362,"watchers_count":362,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":329,"mirror_url":null,"open_issues_count":4,"forks":329,"open_issues":4,"watchers":362,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1475"},"html":{"href":"https://github.com/spring-projects/spring-integration/pull/1475"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-integration/issues/1475"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-integration/issues/1475/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1475/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1475/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-integration/statuses/6b932eb5c9f4e932c992971f244f67ea3d480834"}}}}