{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13363","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13363/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13363/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13363/events","html_url":"https://github.com/kubernetes/kubernetes/pull/13363","id":103942427,"number":13363,"title":"fix kubelet syncLoop busy loop upon close of updates chan","user":{"login":"jdef","id":2348332,"avatar_url":"https://avatars.githubusercontent.com/u/2348332?v=3","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/component/kubelet","name":"component/kubelet","color":"0052cc"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00"}],"state":"open","locked":false,"assignee":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-08-30T19:52:25Z","updated_at":"2015-09-04T06:51:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13363","html_url":"https://github.com/kubernetes/kubernetes/pull/13363","diff_url":"https://github.com/kubernetes/kubernetes/pull/13363.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/13363.patch"},"body":"The kubelet syncLoopIteration returns if the update chan is closed, but the syncLoop (controller func) will continue to invoke it regardless of the channel status. Busy loop.\r\n\r\nThis PR allows syncLoop to terminate if/when the update chan closes (and adds a test for such). The mesos kubelet-executor leverages the channel close to cause kubelet.Run() to exit cleanly.\r\n\r\nxref https://github.com/mesosphere/kubernetes-mesos/issues/459\r\n\r\n/cc @dchen1107 "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/137660678","html_url":"https://github.com/kubernetes/kubernetes/pull/13363#issuecomment-137660678","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13363","id":137660678,"user":{"login":"k8s-bot","id":12551979,"avatar_url":"https://avatars.githubusercontent.com/u/12551979?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-bot","html_url":"https://github.com/k8s-bot","followers_url":"https://api.github.com/users/k8s-bot/followers","following_url":"https://api.github.com/users/k8s-bot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-bot/subscriptions","organizations_url":"https://api.github.com/users/k8s-bot/orgs","repos_url":"https://api.github.com/users/k8s-bot/repos","events_url":"https://api.github.com/users/k8s-bot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-bot/received_events","type":"User","site_admin":false},"created_at":"2015-09-04T06:51:09Z","updated_at":"2015-09-04T06:51:09Z","body":"GCE e2e build/test **passed** for commit 9940377b567547161c4bd765f32be21b4e4f2aab.\n* [Build Log](https://storage.cloud.google.com/kubernetes-jenkins/pr-logs/9940377b567547161c4bd765f32be21b4e4f2aab/kubernetes-pull-build-test-e2e-gce/7419/build-log.txt)\n* [Test Artifacts](https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/9940377b567547161c4bd765f32be21b4e4f2aab/kubernetes-pull-build-test-e2e-gce/7419/_artifacts/)\n* [Internal Jenkins Results](http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//7419)\n"}}