{"comment":{"url":"https://api.github.com/repos/jxcore/jxcore/comments/14407809","html_url":"https://github.com/jxcore/jxcore/commit/4a98a020e8d3d9793811c98e142baee05b5e524f#commitcomment-14407809","id":14407809,"user":{"login":"dustmop","id":2515490,"avatar_url":"https://avatars.githubusercontent.com/u/2515490?v=3","gravatar_id":"","url":"https://api.github.com/users/dustmop","html_url":"https://github.com/dustmop","followers_url":"https://api.github.com/users/dustmop/followers","following_url":"https://api.github.com/users/dustmop/following{/other_user}","gists_url":"https://api.github.com/users/dustmop/gists{/gist_id}","starred_url":"https://api.github.com/users/dustmop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustmop/subscriptions","organizations_url":"https://api.github.com/users/dustmop/orgs","repos_url":"https://api.github.com/users/dustmop/repos","events_url":"https://api.github.com/users/dustmop/events{/privacy}","received_events_url":"https://api.github.com/users/dustmop/received_events","type":"User","site_admin":false},"position":4,"line":2199,"path":"src/node.cc","commit_id":"4a98a020e8d3d9793811c98e142baee05b5e524f","created_at":"2015-11-16T07:20:18Z","updated_at":"2015-11-16T07:20:18Z","body":"> BTW _ stands for private\r\n\r\nNot in this case, leading underscore means \"defined by implementation\". References:\r\nhttps://msdn.microsoft.com/en-us/library/b0084kay.aspx\r\nhttp://stackoverflow.com/questions/662084/whats-the-difference-between-the-win32-and-win32-defines-in-c\r\nhttp://blogs.msdn.com/b/reiley/archive/2011/08/12/macro-revisited.aspx\r\n\r\n> In the light of this, lets not put isWinGUI etc. instead we can check through tty_wrap whenever necessary ?\r\n\r\nWhat? No, that's the exact opposite of what I was saying. TTY is too specific, because stdout & stderr might be other kinds of streams. isWinGui describes more exactly what I'm testing for, whether we're on Windows and are running subsystem console or not."}}