{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/44785548","id":44785548,"diff_hunk":"@@ -127,6 +128,12 @@ def fit(self, X, y):\n \n         return self\n \n+    def _check_fitted(self):","path":"sklearn/ensemble/voting_classifier.py","position":12,"original_position":12,"commit_id":"0ec2ea451daad0edfaf8e88eff968f665ea2dd17","original_commit_id":"0ec2ea451daad0edfaf8e88eff968f665ea2dd17","user":{"login":"TomDLT","id":11065596,"avatar_url":"https://avatars.githubusercontent.com/u/11065596?v=3","gravatar_id":"","url":"https://api.github.com/users/TomDLT","html_url":"https://github.com/TomDLT","followers_url":"https://api.github.com/users/TomDLT/followers","following_url":"https://api.github.com/users/TomDLT/following{/other_user}","gists_url":"https://api.github.com/users/TomDLT/gists{/gist_id}","starred_url":"https://api.github.com/users/TomDLT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomDLT/subscriptions","organizations_url":"https://api.github.com/users/TomDLT/orgs","repos_url":"https://api.github.com/users/TomDLT/repos","events_url":"https://api.github.com/users/TomDLT/events{/privacy}","received_events_url":"https://api.github.com/users/TomDLT/received_events","type":"User","site_admin":false},"body":"you could re-use `sklearn.utils.validation.check_is_fitted`, couldn't you?","created_at":"2015-11-13T14:14:52Z","updated_at":"2015-11-13T14:14:52Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/5794#discussion_r44785548","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5794","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/44785548"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/5794#discussion_r44785548"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5794"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5794","id":50450746,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/5794","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/5794.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/5794.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5794","number":5794,"state":"open","locked":false,"title":"[MRG] raise NotFittedError in VotingClassifier","user":{"login":"rasbt","id":5618407,"avatar_url":"https://avatars.githubusercontent.com/u/5618407?v=3","gravatar_id":"","url":"https://api.github.com/users/rasbt","html_url":"https://github.com/rasbt","followers_url":"https://api.github.com/users/rasbt/followers","following_url":"https://api.github.com/users/rasbt/following{/other_user}","gists_url":"https://api.github.com/users/rasbt/gists{/gist_id}","starred_url":"https://api.github.com/users/rasbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasbt/subscriptions","organizations_url":"https://api.github.com/users/rasbt/orgs","repos_url":"https://api.github.com/users/rasbt/repos","events_url":"https://api.github.com/users/rasbt/events{/privacy}","received_events_url":"https://api.github.com/users/rasbt/received_events","type":"User","site_admin":false},"body":"Raise a `NotFittedError` if `predict`, `predict_proba,` or `transform` is called on the unfitted `VottingClassifier` object.","created_at":"2015-11-11T23:16:33Z","updated_at":"2015-11-13T14:14:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b21f132e7503d3c7d070d9d5e33fbf526dead76e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5794/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5794/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5794/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/0ec2ea451daad0edfaf8e88eff968f665ea2dd17","head":{"label":"rasbt:check_votingclassifier","ref":"check_votingclassifier","sha":"0ec2ea451daad0edfaf8e88eff968f665ea2dd17","user":{"login":"rasbt","id":5618407,"avatar_url":"https://avatars.githubusercontent.com/u/5618407?v=3","gravatar_id":"","url":"https://api.github.com/users/rasbt","html_url":"https://github.com/rasbt","followers_url":"https://api.github.com/users/rasbt/followers","following_url":"https://api.github.com/users/rasbt/following{/other_user}","gists_url":"https://api.github.com/users/rasbt/gists{/gist_id}","starred_url":"https://api.github.com/users/rasbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasbt/subscriptions","organizations_url":"https://api.github.com/users/rasbt/orgs","repos_url":"https://api.github.com/users/rasbt/repos","events_url":"https://api.github.com/users/rasbt/events{/privacy}","received_events_url":"https://api.github.com/users/rasbt/received_events","type":"User","site_admin":false},"repo":{"id":29846351,"name":"scikit-learn","full_name":"rasbt/scikit-learn","owner":{"login":"rasbt","id":5618407,"avatar_url":"https://avatars.githubusercontent.com/u/5618407?v=3","gravatar_id":"","url":"https://api.github.com/users/rasbt","html_url":"https://github.com/rasbt","followers_url":"https://api.github.com/users/rasbt/followers","following_url":"https://api.github.com/users/rasbt/following{/other_user}","gists_url":"https://api.github.com/users/rasbt/gists{/gist_id}","starred_url":"https://api.github.com/users/rasbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasbt/subscriptions","organizations_url":"https://api.github.com/users/rasbt/orgs","repos_url":"https://api.github.com/users/rasbt/repos","events_url":"https://api.github.com/users/rasbt/events{/privacy}","received_events_url":"https://api.github.com/users/rasbt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rasbt/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/rasbt/scikit-learn","forks_url":"https://api.github.com/repos/rasbt/scikit-learn/forks","keys_url":"https://api.github.com/repos/rasbt/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rasbt/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rasbt/scikit-learn/teams","hooks_url":"https://api.github.com/repos/rasbt/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/rasbt/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/rasbt/scikit-learn/events","assignees_url":"https://api.github.com/repos/rasbt/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/rasbt/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/rasbt/scikit-learn/tags","blobs_url":"https://api.github.com/repos/rasbt/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rasbt/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rasbt/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/rasbt/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rasbt/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/rasbt/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/rasbt/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/rasbt/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/rasbt/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/rasbt/scikit-learn/subscription","commits_url":"https://api.github.com/repos/rasbt/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/rasbt/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/rasbt/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/rasbt/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/rasbt/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/rasbt/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rasbt/scikit-learn/merges","archive_url":"https://api.github.com/repos/rasbt/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rasbt/scikit-learn/downloads","issues_url":"https://api.github.com/repos/rasbt/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/rasbt/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/rasbt/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/rasbt/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rasbt/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/rasbt/scikit-learn/releases{/id}","created_at":"2015-01-26T05:27:42Z","updated_at":"2015-04-06T18:18:56Z","pushed_at":"2015-11-12T17:26:09Z","git_url":"git://github.com/rasbt/scikit-learn.git","ssh_url":"git@github.com:rasbt/scikit-learn.git","clone_url":"https://github.com/rasbt/scikit-learn.git","svn_url":"https://github.com/rasbt/scikit-learn","homepage":"http://scikit-learn.org","size":70267,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"7cb9a23d5bd33ca59711862a800718845f9cb350","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","created_at":"2010-08-17T09:43:38Z","updated_at":"2015-11-13T11:37:14Z","pushed_at":"2015-11-13T12:43:54Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":142133,"stargazers_count":8241,"watchers_count":8241,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4906,"mirror_url":null,"open_issues_count":873,"forks":4906,"open_issues":873,"watchers":8241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5794"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/5794"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5794"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5794/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5794/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5794/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/0ec2ea451daad0edfaf8e88eff968f665ea2dd17"}}}}