{"action":"created","comment":{"url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/comments/34205932","id":34205932,"diff_hunk":"@@ -1646,13 +1646,16 @@ The client serializes the validation object to UTF-8, then uses its account\n private key to sign a JWS with the serialized JSON object as its payload.  This\n JWS is NOT REQUIRED to have the \"nonce\" header parameter.\n \n-The client will generate a self-signed certificate with the subject's\n-organizationName field set to the \"signature\" value from the JWS, i.e., the\n-base64-encoded signature value, and a subjectAlternativeName extension\n-containing a single dNSName of \"\\<token\\>.acme.invalid\".  The client will then\n-configure the TLS server at the domain such that when a handshake is initiated\n-with the Server Name Indication extension set to \"\\<token\\>.acme.invalid\", the\n-generated test certificate is presented.\n+The client will compute Z, the SHA-256 of the \"signature\" value from the JWS,\n+i.e., the base64-encoded signature value.  Z is encoded in hexidecimal form.\n+\n+The client will generate a self-signed certificate with the\n+subjectAlternativeName extension containing two dNSNames. The first is set to\n+\"\\<token\\>.acme.invalid\" and the second is set to\n+\"\\<Z[0:32]\\>.\\<Z[32:64]\\>.acme.invalid\".  The client will then configure the TLS\n+server at the domain such that when a handshake is initiated with the Server\n+Name Indication extension set to \"\\<token\\>.acme.invalid\", the generated test\n+certificate is presented.","path":"draft-barnes-acme.md","position":20,"original_position":20,"commit_id":"752c64b759956fe14aba2e51e658dc5f254efa11","original_commit_id":"752c64b759956fe14aba2e51e658dc5f254efa11","user":{"login":"bifurcation","id":75597,"avatar_url":"https://avatars.githubusercontent.com/u/75597?v=3","gravatar_id":"","url":"https://api.github.com/users/bifurcation","html_url":"https://github.com/bifurcation","followers_url":"https://api.github.com/users/bifurcation/followers","following_url":"https://api.github.com/users/bifurcation/following{/other_user}","gists_url":"https://api.github.com/users/bifurcation/gists{/gist_id}","starred_url":"https://api.github.com/users/bifurcation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bifurcation/subscriptions","organizations_url":"https://api.github.com/users/bifurcation/orgs","repos_url":"https://api.github.com/users/bifurcation/repos","events_url":"https://api.github.com/users/bifurcation/events{/privacy}","received_events_url":"https://api.github.com/users/bifurcation/received_events","type":"User","site_admin":false},"body":"This is duplicative.  Just use the `Z.acme.invalid` name, since the signature covers the token.","created_at":"2015-07-08T22:24:13Z","updated_at":"2015-07-08T22:24:13Z","html_url":"https://github.com/letsencrypt/acme-spec/pull/186#discussion_r34205932","pull_request_url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/186","_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/comments/34205932"},"html":{"href":"https://github.com/letsencrypt/acme-spec/pull/186#discussion_r34205932"},"pull_request":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/186"}}},"pull_request":{"url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/186","id":39429323,"html_url":"https://github.com/letsencrypt/acme-spec/pull/186","diff_url":"https://github.com/letsencrypt/acme-spec/pull/186.diff","patch_url":"https://github.com/letsencrypt/acme-spec/pull/186.patch","issue_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues/186","number":186,"state":"open","locked":false,"title":"Avoid 64 character limit in organizationName","user":{"login":"jdkasten","id":1581662,"avatar_url":"https://avatars.githubusercontent.com/u/1581662?v=3","gravatar_id":"","url":"https://api.github.com/users/jdkasten","html_url":"https://github.com/jdkasten","followers_url":"https://api.github.com/users/jdkasten/followers","following_url":"https://api.github.com/users/jdkasten/following{/other_user}","gists_url":"https://api.github.com/users/jdkasten/gists{/gist_id}","starred_url":"https://api.github.com/users/jdkasten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdkasten/subscriptions","organizations_url":"https://api.github.com/users/jdkasten/orgs","repos_url":"https://api.github.com/users/jdkasten/repos","events_url":"https://api.github.com/users/jdkasten/events{/privacy}","received_events_url":"https://api.github.com/users/jdkasten/received_events","type":"User","site_admin":false},"body":"Fix #183  After much discussion with @bifurcation and @pde.\r\n\r\nCompute Z, where Z is the SHA-256 of the JWS signature value.  Z is encoded in hexidecimal form.\r\n\r\nPlace Z in a subjectAltName of the form <Z[0:32]>.<Z[32:64]>.acme.invalid","created_at":"2015-07-07T23:53:08Z","updated_at":"2015-07-08T22:24:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"236d68a15e9230fd03c2f4c96b1edb91fd17a1ee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/186/commits","review_comments_url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/186/comments","review_comment_url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues/186/comments","statuses_url":"https://api.github.com/repos/letsencrypt/acme-spec/statuses/752c64b759956fe14aba2e51e658dc5f254efa11","head":{"label":"letsencrypt:fix_dvsni","ref":"fix_dvsni","sha":"752c64b759956fe14aba2e51e658dc5f254efa11","user":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"repo":{"id":25449702,"name":"acme-spec","full_name":"letsencrypt/acme-spec","owner":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/letsencrypt/acme-spec","description":"ACME Specification","fork":false,"url":"https://api.github.com/repos/letsencrypt/acme-spec","forks_url":"https://api.github.com/repos/letsencrypt/acme-spec/forks","keys_url":"https://api.github.com/repos/letsencrypt/acme-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letsencrypt/acme-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letsencrypt/acme-spec/teams","hooks_url":"https://api.github.com/repos/letsencrypt/acme-spec/hooks","issue_events_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues/events{/number}","events_url":"https://api.github.com/repos/letsencrypt/acme-spec/events","assignees_url":"https://api.github.com/repos/letsencrypt/acme-spec/assignees{/user}","branches_url":"https://api.github.com/repos/letsencrypt/acme-spec/branches{/branch}","tags_url":"https://api.github.com/repos/letsencrypt/acme-spec/tags","blobs_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letsencrypt/acme-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/letsencrypt/acme-spec/languages","stargazers_url":"https://api.github.com/repos/letsencrypt/acme-spec/stargazers","contributors_url":"https://api.github.com/repos/letsencrypt/acme-spec/contributors","subscribers_url":"https://api.github.com/repos/letsencrypt/acme-spec/subscribers","subscription_url":"https://api.github.com/repos/letsencrypt/acme-spec/subscription","commits_url":"https://api.github.com/repos/letsencrypt/acme-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/letsencrypt/acme-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/letsencrypt/acme-spec/contents/{+path}","compare_url":"https://api.github.com/repos/letsencrypt/acme-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letsencrypt/acme-spec/merges","archive_url":"https://api.github.com/repos/letsencrypt/acme-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letsencrypt/acme-spec/downloads","issues_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues{/number}","pulls_url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/letsencrypt/acme-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/letsencrypt/acme-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letsencrypt/acme-spec/labels{/name}","releases_url":"https://api.github.com/repos/letsencrypt/acme-spec/releases{/id}","created_at":"2014-10-20T03:43:00Z","updated_at":"2015-07-08T14:48:47Z","pushed_at":"2015-07-08T01:17:47Z","git_url":"git://github.com/letsencrypt/acme-spec.git","ssh_url":"git@github.com:letsencrypt/acme-spec.git","clone_url":"https://github.com/letsencrypt/acme-spec.git","svn_url":"https://github.com/letsencrypt/acme-spec","homepage":null,"size":1840,"stargazers_count":807,"watchers_count":807,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":68,"mirror_url":null,"open_issues_count":18,"forks":68,"open_issues":18,"watchers":807,"default_branch":"master"}},"base":{"label":"letsencrypt:master","ref":"master","sha":"31ea7feb1f278046740837ea2a3b39233d8cc9c0","user":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"repo":{"id":25449702,"name":"acme-spec","full_name":"letsencrypt/acme-spec","owner":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/letsencrypt/acme-spec","description":"ACME Specification","fork":false,"url":"https://api.github.com/repos/letsencrypt/acme-spec","forks_url":"https://api.github.com/repos/letsencrypt/acme-spec/forks","keys_url":"https://api.github.com/repos/letsencrypt/acme-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letsencrypt/acme-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letsencrypt/acme-spec/teams","hooks_url":"https://api.github.com/repos/letsencrypt/acme-spec/hooks","issue_events_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues/events{/number}","events_url":"https://api.github.com/repos/letsencrypt/acme-spec/events","assignees_url":"https://api.github.com/repos/letsencrypt/acme-spec/assignees{/user}","branches_url":"https://api.github.com/repos/letsencrypt/acme-spec/branches{/branch}","tags_url":"https://api.github.com/repos/letsencrypt/acme-spec/tags","blobs_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letsencrypt/acme-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/letsencrypt/acme-spec/languages","stargazers_url":"https://api.github.com/repos/letsencrypt/acme-spec/stargazers","contributors_url":"https://api.github.com/repos/letsencrypt/acme-spec/contributors","subscribers_url":"https://api.github.com/repos/letsencrypt/acme-spec/subscribers","subscription_url":"https://api.github.com/repos/letsencrypt/acme-spec/subscription","commits_url":"https://api.github.com/repos/letsencrypt/acme-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/letsencrypt/acme-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/letsencrypt/acme-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/letsencrypt/acme-spec/contents/{+path}","compare_url":"https://api.github.com/repos/letsencrypt/acme-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letsencrypt/acme-spec/merges","archive_url":"https://api.github.com/repos/letsencrypt/acme-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letsencrypt/acme-spec/downloads","issues_url":"https://api.github.com/repos/letsencrypt/acme-spec/issues{/number}","pulls_url":"https://api.github.com/repos/letsencrypt/acme-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/letsencrypt/acme-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/letsencrypt/acme-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letsencrypt/acme-spec/labels{/name}","releases_url":"https://api.github.com/repos/letsencrypt/acme-spec/releases{/id}","created_at":"2014-10-20T03:43:00Z","updated_at":"2015-07-08T14:48:47Z","pushed_at":"2015-07-08T01:17:47Z","git_url":"git://github.com/letsencrypt/acme-spec.git","ssh_url":"git@github.com:letsencrypt/acme-spec.git","clone_url":"https://github.com/letsencrypt/acme-spec.git","svn_url":"https://github.com/letsencrypt/acme-spec","homepage":null,"size":1840,"stargazers_count":807,"watchers_count":807,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":68,"mirror_url":null,"open_issues_count":18,"forks":68,"open_issues":18,"watchers":807,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/186"},"html":{"href":"https://github.com/letsencrypt/acme-spec/pull/186"},"issue":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/issues/186"},"comments":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/issues/186/comments"},"review_comments":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/186/comments"},"review_comment":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/pulls/186/commits"},"statuses":{"href":"https://api.github.com/repos/letsencrypt/acme-spec/statuses/752c64b759956fe14aba2e51e658dc5f254efa11"}}}}