{"push_id":627934549,"size":54,"distinct_size":54,"ref":"refs/heads/master","head":"6e7fe6c9bc0c4785fea72bf631708a01cfb5188d","before":"9e86374755c25a51ef979fc0fd50114a4959a947","commits":[{"sha":"0d2ad24d4db96e24831296f4b103174d42ba0705","author":{"email":"9bac359be05a518b7d82b230e2c8228861aa56ee@google.com","name":"nnaze"},"message":"commit db\n-------------\nCreated by MOE: http://code.google.com/p/moe-java\nMOE_MIGRATED_REVID=85813399","distinct":true,"url":"https://api.github.com/repos/google/closure-library/commits/0d2ad24d4db96e24831296f4b103174d42ba0705"},{"sha":"84fd9bc032b3bbc4c6418e56a68b18f11b7dac83","author":{"email":"e2cb9ece0484221df5e98347d1c044c17b6e45fb@google.com","name":"Andy Martone"},"message":"Use random, unique timeout IDs for all MockClocks\n\nAlso guarantees that timeout IDs will never be reused across multiple instances or between reset() boundaries.\n\n-------------\nCreated by MOE: http://code.google.com/p/moe-java\nMOE_MIGRATED_REVID=89500672","distinct":true,"url":"https://api.github.com/repos/google/closure-library/commits/84fd9bc032b3bbc4c6418e56a68b18f11b7dac83"},{"sha":"1ee4e8e88687d5167dedcbe2cfe19f1a2279583c","author":{"email":"e2cb9ece0484221df5e98347d1c044c17b6e45fb@google.com","name":"Andy Martone"},"message":"Small changes to htmlparser to fit current closure code style standards.\n-------------\nCreated by MOE: http://code.google.com/p/moe-java\nMOE_MIGRATED_REVID=89504841","distinct":true,"url":"https://api.github.com/repos/google/closure-library/commits/1ee4e8e88687d5167dedcbe2cfe19f1a2279583c"},{"sha":"7e1771d87e1800f65e0f38c179639f82715d4cac","author":{"email":"e2cb9ece0484221df5e98347d1c044c17b6e45fb@google.com","name":"Andy Martone"},"message":"Fix the return type for day of week in goog.date.Date. With the native JS Date, 1 = Monday, while with goog.date.weekDay, 0 = Monday.\n\n-------------\nCreated by MOE: http://code.google.com/p/moe-java\nMOE_MIGRATED_REVID=89510268","distinct":true,"url":"https://api.github.com/repos/google/closure-library/commits/7e1771d87e1800f65e0f38c179639f82715d4cac"},{"sha":"4345748eccc5f5ccbcf02050da6f7a5708a51452","author":{"email":"e2cb9ece0484221df5e98347d1c044c17b6e45fb@google.com","name":"martone"},"message":"Move properties to constructor in goog.pubsub.PubSub.\n\n-------------\nCreated by MOE: http://code.google.com/p/moe-java\nMOE_MIGRATED_REVID=89533905","distinct":true,"url":"https://api.github.com/repos/google/closure-library/commits/4345748eccc5f5ccbcf02050da6f7a5708a51452"},{"sha":"702d8e2b48993418e98e3c0ff3078dc4fe822839","author":{"email":"e2cb9ece0484221df5e98347d1c044c17b6e45fb@google.com","name":"martone"},"message":"Move properties in goog.Uri and goog.Uri.QueryData into the constructor.\n\n-------------\nCreated by MOE: http://code.google.com/p/moe-java\nMOE_MIGRATED_REVID=89539197","distinct":true,"url":"https://api.github.com/repos/google/closure-library/commits/702d8e2b48993418e98e3c0ff3078dc4fe822839"},{"sha":"ad05520c5d2191c7b7cb9c45e6eaa7e9631ab611","author":{"email":"e2cb9ece0484221df5e98347d1c044c17b6e45fb@google.com","name":"Andy Martone"},"message":"Have DrilldownRow constructor only accept SafeHtml. This is the final step in locking down DrilldownRow. All callers passing HTML-as-string are being refactored to use DrilldownRow.unsafeCreate().\n-------------\nCreated by MOE: http://code.google.com/p/moe-java\nMOE_MIGRATED_REVID=89587970","distinct":true,"url":"https://api.github.com/repos/google/closure-library/commits/ad05520c5d2191c7b7cb9c45e6eaa7e9631ab611"},{"sha":"631a388ebb5bb72c91682c7e93726006dcfca817","author":{"email":"e2cb9ece0484221df5e98347d1c044c17b6e45fb@google.com","name":"Andy Martone"},"message":"A bunch of fixes to window_test.js so that tests run again (IE disabled for most tests for a bunch of reasons, left TODOs in code).\n\n- Remove check to see if browser can open popups, which checks if file:// is in window.location. As a result of this check, tests probably didn't run for several years.  I believe tests are always loaded over HTTP on the test farm nowadays.  Nowadays all browsers in test farm also have popups disabled, so checking for popups should not be necessary but I also added a check so that the test fails immediately with a descriptive message if goog.window.open fails, which happens if there's a popup blocker.\n\n- Remove use of window.opener to set a value in the window that does the opening. This can't work because at some point in the past we changed window.js to set the opener for the newly opened window to null. Instead look inside the opened window to see if a variable has been set.\n\n- Remove unnecessary use of \" in test cases. \" causes problem on IE because IE does not percent-encode it automatically and the Closure test server will return an HTTP 400 upon seeing \" in a URL.\n\n- Fix duplicate test case names. This kept some test cases from running.\n\n- Reset newWin for each test to avoid global state messing things up. On IE not doing this seems to result in race conditions (though IE is disabled for most tests now).\n\n- Remove dead code.\n-------------\nCreated by MOE: http://code.google.com/p/moe-java\nMOE_MIGRATED_REVID=89603573","distinct":true,"url":"https://api.github.com/repos/google/closure-library/commits/631a388ebb5bb72c91682c7e93726006dcfca817"},{"sha":"76e95e6d520e2a0d23589dd18b815eacbeeccf22","author":{"email":"e2cb9ece0484221df5e98347d1c044c17b6e45fb@google.com","name":"Andy Martone"},"message":"Fix tests for IE.\n\nWhat kept the tests from running was that goog.window.open() was reopening the same window for IE due to target being undefined. To fix this we always set the target from tests. Arguably goog.window.open() is broken (it should probably set a default target of _self) but for now we at least get the tests to run.\n\nThe test for > is removed because it seems to cause the Closure test server to bork when IE sends it unencoded. It doesn't add any value since there's also a test for < and an HTML-escaping function would always have to escape < (but not necessarily >).\n-------------\nCreated by MOE: http://code.google.com/p/moe-java\nMOE_MIGRATED_REVID=89619443","distinct":true,"url":"https://api.github.com/repos/google/closure-library/commits/76e95e6d520e2a0d23589dd18b815eacbeeccf22"},{"sha":"3c43271abcbe88b90941385e2d6d5e46b81a7e6d","author":{"email":"e2cb9ece0484221df5e98347d1c044c17b6e45fb@google.com","name":"Andy Martone"},"message":"Closure Testing: making making goog.testing.dom.assertHtmlContentsMatch correctly compare svg attributes.\n-------------\nCreated by MOE: http://code.google.com/p/moe-java\nMOE_MIGRATED_REVID=89625103","distinct":true,"url":"https://api.github.com/repos/google/closure-library/commits/3c43271abcbe88b90941385e2d6d5e46b81a7e6d"},{"sha":"0bf619f0bb7c1ff71c28daeb5ca094c5ade72a19","author":{"email":"e2cb9ece0484221df5e98347d1c044c17b6e45fb@google.com","name":"Andy Martone"},"message":"Closure Testing: making goog.testing.dom.assertHtmlContentsMatch correctly handle the case with \"new line\" characters inside a script tag.\n\nIt is clearly a bug in getExpectedText_() since its purpose (according to the doc) is to remove browser specification strings, which implies that it should keep the text unchanged if there is no browser specification.\n-------------\nCreated by MOE: http://code.google.com/p/moe-java\nMOE_MIGRATED_REVID=89631017","distinct":true,"url":"https://api.github.com/repos/google/closure-library/commits/0bf619f0bb7c1ff71c28daeb5ca094c5ade72a19"},{"sha":"434b623cb4351745c10d53f47de67fc56692bc57","author":{"email":"ce8fdc2d33deed95dbddf8349a6aa5bf406708c9@google.com","name":"tbreisacher"},"message":"Add a goog.require() for AbstractPosition since it is used in @extends annotations and the compiler's missingRequire check will require it soon\n\nThe linter thinks there should not be a require here, so I'm suppressing the linter's check, but I'm hoping the compiler's check will be good enough that we can delete the linter's soon.\n\n(The @extends annotations are all on deprecated aliases, which I am trying to remove, separately.)\n-------------\nCreated by MOE: http://code.google.com/p/moe-java\nMOE_MIGRATED_REVID=89633588","distinct":true,"url":"https://api.github.com/repos/google/closure-library/commits/434b623cb4351745c10d53f47de67fc56692bc57"},{"sha":"fa8589575fc5343c45b6dea2ef1e6db40adcdb6c","author":{"email":"e2cb9ece0484221df5e98347d1c044c17b6e45fb@google.com","name":"Andy Martone"},"message":"Some spelling fixes.\n-------------\nCreated by MOE: http://code.google.com/p/moe-java\nMOE_MIGRATED_REVID=89638641","distinct":true,"url":"https://api.github.com/repos/google/closure-library/commits/fa8589575fc5343c45b6dea2ef1e6db40adcdb6c"},{"sha":"36f8d0d16d28e10a2d7331297c6fb8288114ce8e","author":{"email":"e2cb9ece0484221df5e98347d1c044c17b6e45fb@google.com","name":"Andy Martone"},"message":"Closure Testing: adding optional parameter opt_strictAttributes to goog.testing.dom.assertHtmlMatches.\n-------------\nCreated by MOE: http://code.google.com/p/moe-java\nMOE_MIGRATED_REVID=89640625","distinct":true,"url":"https://api.github.com/repos/google/closure-library/commits/36f8d0d16d28e10a2d7331297c6fb8288114ce8e"},{"sha":"d429bd8a98ce82afae717d17de9dc82ee46c02ac","author":{"email":"e2cb9ece0484221df5e98347d1c044c17b6e45fb@google.com","name":"martone"},"message":"@structify classes in goog.date.\n\n@struct is fantastic, it forces all properties on an object to be created in its constructor, and enforces dotted notation access. This prevents a class of bugs where developers mistype a property name. For more information see https://github.com/google/closure-compiler/wiki/@struct-and-@dict-Annotations.\n\n-------------\nCreated by MOE: http://code.google.com/p/moe-java\nMOE_MIGRATED_REVID=89679702","distinct":true,"url":"https://api.github.com/repos/google/closure-library/commits/d429bd8a98ce82afae717d17de9dc82ee46c02ac"},{"sha":"538aeecfa3966098581f772dcd66e1651b4c9e12","author":{"email":"e2cb9ece0484221df5e98347d1c044c17b6e45fb@google.com","name":"martone"},"message":"Mark goog.storage classes as @struct, and move properties into the constructor.\n-------------\nCreated by MOE: http://code.google.com/p/moe-java\nMOE_MIGRATED_REVID=89735178","distinct":true,"url":"https://api.github.com/repos/google/closure-library/commits/538aeecfa3966098581f772dcd66e1651b4c9e12"},{"sha":"eaf78fcc12fe4f0ec05e25a1471c5921a13a2a82","author":{"email":"e2cb9ece0484221df5e98347d1c044c17b6e45fb@google.com","name":"Andy Martone"},"message":"closure: avoid using magic strings when referring to tag names, cont.\n\nReplace use of string literals when referring to tag names with values\ndefined in goog.dom.TagName.\nThis time all changes have been made manually by grepping the sources\nand looking for string literals corresponding to tag names.\n\nPlaces that were left intact:\n  * dom/dom_test.js uses 'div' literal to test whether tested function\n    works with lower case tag names.\n  * goog.dom.tags.isVoidTag (from dom/tags.js) API specifies the\n    argument must be lower case.\n  * html/safehtml.js, labs/html/scrubber.js and related files are using\n    aforementioned isVoidTag function.\n  * Changing users of goog.html.SafeHtml would be affect formatted code.\n\nThere are still HTML files (used in tests and demos) that might need to\nbe taken care of but those are lower priority.\n-------------\nCreated by MOE: http://code.google.com/p/moe-java\nMOE_MIGRATED_REVID=89869327","distinct":true,"url":"https://api.github.com/repos/google/closure-library/commits/eaf78fcc12fe4f0ec05e25a1471c5921a13a2a82"},{"sha":"0d1d1cedf300b4ff3adecfd90ab843ea57959f82","author":{"email":"e2cb9ece0484221df5e98347d1c044c17b6e45fb@google.com","name":"Andy Martone"},"message":"goog.events.EventType: add missing RESET event\n\nhttps://html.spec.whatwg.org/multipage/indices.html#event-reset\n-------------\nCreated by MOE: http://code.google.com/p/moe-java\nMOE_MIGRATED_REVID=89873188","distinct":true,"url":"https://api.github.com/repos/google/closure-library/commits/0d1d1cedf300b4ff3adecfd90ab843ea57959f82"},{"sha":"5304722a0bda91cbd75a8de40555cb7cb1f5a9a1","author":{"email":"ce8fdc2d33deed95dbddf8349a6aa5bf406708c9@google.com","name":"tbreisacher"},"message":"Add a goog.require() for goog.events.Event since it is used in @extends annotations and the compiler's missingRequire check will require it soon\n\nThe linter thinks there should not be a require here, so I'm suppressing the linter's check, but I'm hoping the compiler's check will be good enough that we can delete the linter's soon.\n-------------\nCreated by MOE: http://code.google.com/p/moe-java\nMOE_MIGRATED_REVID=89886935","distinct":true,"url":"https://api.github.com/repos/google/closure-library/commits/5304722a0bda91cbd75a8de40555cb7cb1f5a9a1"},{"sha":"1537bec94f28c7fb69493d68c69b26d39919510c","author":{"email":"e2cb9ece0484221df5e98347d1c044c17b6e45fb@google.com","name":"martone"},"message":"Mark classes in goog.async as @struct, and move properties into the constructor.\n-------------\nCreated by MOE: http://code.google.com/p/moe-java\nMOE_MIGRATED_REVID=89887912","distinct":true,"url":"https://api.github.com/repos/google/closure-library/commits/1537bec94f28c7fb69493d68c69b26d39919510c"}]}