{"action":"created","issue":{"url":"https://api.github.com/repos/dhoer/chef-java_se/issues/8","labels_url":"https://api.github.com/repos/dhoer/chef-java_se/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/dhoer/chef-java_se/issues/8/comments","events_url":"https://api.github.com/repos/dhoer/chef-java_se/issues/8/events","html_url":"https://github.com/dhoer/chef-java_se/pull/8","id":111264307,"number":8,"title":"Fix for issue #5 - adding an option to specify public JRE install location","user":{"login":"tevert","id":6742531,"avatar_url":"https://avatars.githubusercontent.com/u/6742531?v=3","gravatar_id":"","url":"https://api.github.com/users/tevert","html_url":"https://github.com/tevert","followers_url":"https://api.github.com/users/tevert/followers","following_url":"https://api.github.com/users/tevert/following{/other_user}","gists_url":"https://api.github.com/users/tevert/gists{/gist_id}","starred_url":"https://api.github.com/users/tevert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tevert/subscriptions","organizations_url":"https://api.github.com/users/tevert/orgs","repos_url":"https://api.github.com/users/tevert/repos","events_url":"https://api.github.com/users/tevert/events{/privacy}","received_events_url":"https://api.github.com/users/tevert/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-13T20:30:39Z","updated_at":"2015-10-13T21:09:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dhoer/chef-java_se/pulls/8","html_url":"https://github.com/dhoer/chef-java_se/pull/8","diff_url":"https://github.com/dhoer/chef-java_se/pull/8.diff","patch_url":"https://github.com/dhoer/chef-java_se/pull/8.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/dhoer/chef-java_se/issues/comments/147854641","html_url":"https://github.com/dhoer/chef-java_se/pull/8#issuecomment-147854641","issue_url":"https://api.github.com/repos/dhoer/chef-java_se/issues/8","id":147854641,"user":{"login":"dhoer","id":648360,"avatar_url":"https://avatars.githubusercontent.com/u/648360?v=3","gravatar_id":"","url":"https://api.github.com/users/dhoer","html_url":"https://github.com/dhoer","followers_url":"https://api.github.com/users/dhoer/followers","following_url":"https://api.github.com/users/dhoer/following{/other_user}","gists_url":"https://api.github.com/users/dhoer/gists{/gist_id}","starred_url":"https://api.github.com/users/dhoer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhoer/subscriptions","organizations_url":"https://api.github.com/users/dhoer/orgs","repos_url":"https://api.github.com/users/dhoer/repos","events_url":"https://api.github.com/users/dhoer/events{/privacy}","received_events_url":"https://api.github.com/users/dhoer/received_events","type":"User","site_admin":false},"created_at":"2015-10-13T21:09:09Z","updated_at":"2015-10-13T21:09:09Z","body":"I'm not sure about the name `public_jre_home` because, unlike Windows, Linux is a true multi-user system. You have the choice of installing the JDK or JRE in /usr/java where its publicly available to any user or in a user's private space where only that user can access it.\r\n\r\nMaybe `win_jre_home`, since it is only available for windows or `java_jre_home` where support could be expanded to linux and mac in the future.  Either way, the attribute should be place under Windows Only section.\r\n\r\nThe robocop and chefspec test must pass and chefspec test must be 100%. Run `bundle update` and `bundle exec rake` to run these tests locally.\r\n \r\nThe serverspec default test should be updated to verify the default jre install location is still ok.\r\n\r\nAnother test kitchen suite should to be added to verify that java_home and jre home work as expected when overridden.   I can do this one if you are not comfortable do that. \r\n"}}