{"action":"created","issue":{"url":"https://api.github.com/repos/Parsely/pykafka/issues/183","labels_url":"https://api.github.com/repos/Parsely/pykafka/issues/183/labels{/name}","comments_url":"https://api.github.com/repos/Parsely/pykafka/issues/183/comments","events_url":"https://api.github.com/repos/Parsely/pykafka/issues/183/events","html_url":"https://github.com/Parsely/pykafka/pull/183","id":87769299,"number":183,"title":"[RDY] tests: cherry-picked changes from feature/rdkafka-extension","user":{"login":"yungchin","id":780001,"avatar_url":"https://avatars.githubusercontent.com/u/780001?v=3","gravatar_id":"","url":"https://api.github.com/users/yungchin","html_url":"https://github.com/yungchin","followers_url":"https://api.github.com/users/yungchin/followers","following_url":"https://api.github.com/users/yungchin/following{/other_user}","gists_url":"https://api.github.com/users/yungchin/gists{/gist_id}","starred_url":"https://api.github.com/users/yungchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yungchin/subscriptions","organizations_url":"https://api.github.com/users/yungchin/orgs","repos_url":"https://api.github.com/users/yungchin/repos","events_url":"https://api.github.com/users/yungchin/events{/privacy}","received_events_url":"https://api.github.com/users/yungchin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-12T15:51:49Z","updated_at":"2015-06-13T21:09:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Parsely/pykafka/pulls/183","html_url":"https://github.com/Parsely/pykafka/pull/183","diff_url":"https://github.com/Parsely/pykafka/pull/183.diff","patch_url":"https://github.com/Parsely/pykafka/pull/183.patch"},"body":"These are the accumulated changes to test_simpleconsumer on the rdkafka\r\nbranch at de4b5453910fe903ec51a7d29c13a65445f8ce7f.  There are basically\r\ntwo changes:\r\n\r\n * The instantiation of a consumer is spun out into a separate method,\r\n   so that this may be overridden (that is, to insert an rdkafka consumer\r\n   instead)\r\n * The assertions that required that offsets obtained were always on a\r\n   clean cluster, and thus zero-based, have been rewritten (but\r\n   preserving the aim of each test).  This was needed because the tests\r\n   would erratically pass then fail then pass, as the offsets obtained\r\n   through the Offset API would sometimes be stale offsets from a\r\n   previous run or a previous TestCase (I observed both)\r\n\r\nSigned-off-by: Yung-Chin Oei <yungchin@yungchin.nl>"},"comment":{"url":"https://api.github.com/repos/Parsely/pykafka/issues/comments/111752727","html_url":"https://github.com/Parsely/pykafka/pull/183#issuecomment-111752727","issue_url":"https://api.github.com/repos/Parsely/pykafka/issues/183","id":111752727,"user":{"login":"kbourgoin","id":136574,"avatar_url":"https://avatars.githubusercontent.com/u/136574?v=3","gravatar_id":"","url":"https://api.github.com/users/kbourgoin","html_url":"https://github.com/kbourgoin","followers_url":"https://api.github.com/users/kbourgoin/followers","following_url":"https://api.github.com/users/kbourgoin/following{/other_user}","gists_url":"https://api.github.com/users/kbourgoin/gists{/gist_id}","starred_url":"https://api.github.com/users/kbourgoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbourgoin/subscriptions","organizations_url":"https://api.github.com/users/kbourgoin/orgs","repos_url":"https://api.github.com/users/kbourgoin/repos","events_url":"https://api.github.com/users/kbourgoin/events{/privacy}","received_events_url":"https://api.github.com/users/kbourgoin/received_events","type":"User","site_admin":false},"created_at":"2015-06-13T21:09:05Z","updated_at":"2015-06-13T21:09:05Z","body":"@yungchin, I'm fine merging this in, but what's the success rate been on Travis? Does this help or hurt the rate at which tests are freezing, causing the build to error out?\r\n\r\nAlso, as far as keeping up to date with master goes, I'd recommend `git merge master` frequently. It'll help you stay up to date so that when we're ready to merge the rdkafka changes in, it'll be as seamless as possible."}}