{"action":"created","issue":{"url":"https://api.github.com/repos/mono/mono/issues/1580","labels_url":"https://api.github.com/repos/mono/mono/issues/1580/labels{/name}","comments_url":"https://api.github.com/repos/mono/mono/issues/1580/comments","events_url":"https://api.github.com/repos/mono/mono/issues/1580/events","html_url":"https://github.com/mono/mono/pull/1580","id":58222674,"number":1580,"title":"[Microsoft.Build.Engine] Fix bug with escaped semicolon and spaces","user":{"login":"akoeplinger","id":1376924,"avatar_url":"https://avatars.githubusercontent.com/u/1376924?v=3","gravatar_id":"","url":"https://api.github.com/users/akoeplinger","html_url":"https://github.com/akoeplinger","followers_url":"https://api.github.com/users/akoeplinger/followers","following_url":"https://api.github.com/users/akoeplinger/following{/other_user}","gists_url":"https://api.github.com/users/akoeplinger/gists{/gist_id}","starred_url":"https://api.github.com/users/akoeplinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akoeplinger/subscriptions","organizations_url":"https://api.github.com/users/akoeplinger/orgs","repos_url":"https://api.github.com/users/akoeplinger/repos","events_url":"https://api.github.com/users/akoeplinger/events{/privacy}","received_events_url":"https://api.github.com/users/akoeplinger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-19T15:28:03Z","updated_at":"2015-02-20T19:01:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/1580","html_url":"https://github.com/mono/mono/pull/1580","diff_url":"https://github.com/mono/mono/pull/1580.diff","patch_url":"https://github.com/mono/mono/pull/1580.patch"},"body":"This fixes a bug where escaped spaces and semicolons wouldn't be written to a file with WriteLinesToFileTest.\r\n\r\nNote: This is an intricate piece of code and I'm not really sure it's the correct fix or whether this breaks any corner case usages (it at least builds dotnet/corefx as a sanity check). Would love to get some more :eyes: on it. If anyone knows a better way to make the included tests pass, please show me.\r\n\r\n/cc @radical"},"comment":{"url":"https://api.github.com/repos/mono/mono/issues/comments/75298740","html_url":"https://github.com/mono/mono/pull/1580#issuecomment-75298740","issue_url":"https://api.github.com/repos/mono/mono/issues/1580","id":75298740,"user":{"login":"akoeplinger","id":1376924,"avatar_url":"https://avatars.githubusercontent.com/u/1376924?v=3","gravatar_id":"","url":"https://api.github.com/users/akoeplinger","html_url":"https://github.com/akoeplinger","followers_url":"https://api.github.com/users/akoeplinger/followers","following_url":"https://api.github.com/users/akoeplinger/following{/other_user}","gists_url":"https://api.github.com/users/akoeplinger/gists{/gist_id}","starred_url":"https://api.github.com/users/akoeplinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akoeplinger/subscriptions","organizations_url":"https://api.github.com/users/akoeplinger/orgs","repos_url":"https://api.github.com/users/akoeplinger/repos","events_url":"https://api.github.com/users/akoeplinger/events{/privacy}","received_events_url":"https://api.github.com/users/akoeplinger/received_events","type":"User","site_admin":false},"created_at":"2015-02-20T19:01:32Z","updated_at":"2015-02-20T19:01:32Z","body":"Sounds good. From what I can assess a regression could theoretically only happen for properties that included an escaped literal. I've not seen them widely used so I guess the impact should be quite low."}}