{"action":"created","comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/pulls/comments/33591751","id":33591751,"diff_hunk":"@@ -200,6 +205,16 @@ - (void)setNormalTintColor:(UIColor *)normalTintColor\n \t}\n }\n \n+- (void)setDisabledTintColor:(UIColor *)disabledTintColor\n+{\n+    if (_disabledTintColor != disabledTintColor) {","path":"Classes/WPEditorToolbarButton.m","position":257,"original_position":257,"commit_id":"9fafd9d56a0bda049f1d6f327102774291e0da74","original_commit_id":"9fafd9d56a0bda049f1d6f327102774291e0da74","user":{"login":"aerych","id":1435271,"avatar_url":"https://avatars.githubusercontent.com/u/1435271?v=3","gravatar_id":"","url":"https://api.github.com/users/aerych","html_url":"https://github.com/aerych","followers_url":"https://api.github.com/users/aerych/followers","following_url":"https://api.github.com/users/aerych/following{/other_user}","gists_url":"https://api.github.com/users/aerych/gists{/gist_id}","starred_url":"https://api.github.com/users/aerych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerych/subscriptions","organizations_url":"https://api.github.com/users/aerych/orgs","repos_url":"https://api.github.com/users/aerych/repos","events_url":"https://api.github.com/users/aerych/events{/privacy}","received_events_url":"https://api.github.com/users/aerych/received_events","type":"User","site_admin":false},"body":"Purely a matter of preference, but maybe check for equality and return and avoid nesting, vs checking for inequality and doing the work inside an if block.","created_at":"2015-06-30T16:17:01Z","updated_at":"2015-06-30T16:17:01Z","html_url":"https://github.com/wordpress-mobile/WordPress-Editor-iOS/pull/678#discussion_r33591751","pull_request_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/pulls/678","_links":{"self":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/pulls/comments/33591751"},"html":{"href":"https://github.com/wordpress-mobile/WordPress-Editor-iOS/pull/678#discussion_r33591751"},"pull_request":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/pulls/678"}}},"pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/pulls/678","id":38886452,"html_url":"https://github.com/wordpress-mobile/WordPress-Editor-iOS/pull/678","diff_url":"https://github.com/wordpress-mobile/WordPress-Editor-iOS/pull/678.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-Editor-iOS/pull/678.patch","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/issues/678","number":678,"state":"open","locked":false,"title":"Formatbar updates","user":{"login":"bummytime","id":154014,"avatar_url":"https://avatars.githubusercontent.com/u/154014?v=3","gravatar_id":"","url":"https://api.github.com/users/bummytime","html_url":"https://github.com/bummytime","followers_url":"https://api.github.com/users/bummytime/followers","following_url":"https://api.github.com/users/bummytime/following{/other_user}","gists_url":"https://api.github.com/users/bummytime/gists{/gist_id}","starred_url":"https://api.github.com/users/bummytime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bummytime/subscriptions","organizations_url":"https://api.github.com/users/bummytime/orgs","repos_url":"https://api.github.com/users/bummytime/repos","events_url":"https://api.github.com/users/bummytime/events{/privacy}","received_events_url":"https://api.github.com/users/bummytime/received_events","type":"User","site_admin":false},"body":"Addresses most of #675:\r\n\r\n* Fixes #657: Disabled toolbar and buttons (updated design)\r\n* Fixes #658: Default toolbar and buttons (updated design)\r\n* Fixes #659: Active button state (updated design)\r\n* Fixes #660: Animate format bar selection (updated design)\r\n* Fixes #661: Formatbar spacing on mobile (updated design)\r\n* Fixes #662: Formatbar spacing on tablet (updated design) \r\n\r\n/cc @aerych por favor! :grinning: \r\n","created_at":"2015-06-30T14:50:57Z","updated_at":"2015-06-30T16:17:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d09d65900178a6eaa32611277d4fd1322d40529","assignee":{"login":"aerych","id":1435271,"avatar_url":"https://avatars.githubusercontent.com/u/1435271?v=3","gravatar_id":"","url":"https://api.github.com/users/aerych","html_url":"https://github.com/aerych","followers_url":"https://api.github.com/users/aerych/followers","following_url":"https://api.github.com/users/aerych/following{/other_user}","gists_url":"https://api.github.com/users/aerych/gists{/gist_id}","starred_url":"https://api.github.com/users/aerych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerych/subscriptions","organizations_url":"https://api.github.com/users/aerych/orgs","repos_url":"https://api.github.com/users/aerych/repos","events_url":"https://api.github.com/users/aerych/events{/privacy}","received_events_url":"https://api.github.com/users/aerych/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/pulls/678/commits","review_comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/pulls/678/comments","review_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/issues/678/comments","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/statuses/9fafd9d56a0bda049f1d6f327102774291e0da74","head":{"label":"wordpress-mobile:feature/675-formatbar-updates","ref":"feature/675-formatbar-updates","sha":"9fafd9d56a0bda049f1d6f327102774291e0da74","user":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars.githubusercontent.com/u/1306301?v=3","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":19703913,"name":"WordPress-Editor-iOS","full_name":"wordpress-mobile/WordPress-Editor-iOS","owner":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars.githubusercontent.com/u/1306301?v=3","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wordpress-mobile/WordPress-Editor-iOS","description":"A reusable iOS rich text editor component.","fork":false,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS","forks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/forks","keys_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/teams","hooks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/hooks","issue_events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/events","assignees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/tags","blobs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/languages","stargazers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/stargazers","contributors_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/contributors","subscribers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/subscribers","subscription_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/subscription","commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/merges","archive_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/downloads","issues_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/labels{/name}","releases_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/releases{/id}","created_at":"2014-05-12T15:22:29Z","updated_at":"2015-06-30T14:45:26Z","pushed_at":"2015-06-30T14:50:57Z","git_url":"git://github.com/wordpress-mobile/WordPress-Editor-iOS.git","ssh_url":"git@github.com:wordpress-mobile/WordPress-Editor-iOS.git","clone_url":"https://github.com/wordpress-mobile/WordPress-Editor-iOS.git","svn_url":"https://github.com/wordpress-mobile/WordPress-Editor-iOS","homepage":"","size":8895,"stargazers_count":192,"watchers_count":192,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":152,"forks":34,"open_issues":152,"watchers":192,"default_branch":"develop"}},"base":{"label":"wordpress-mobile:develop","ref":"develop","sha":"78d59da8eaf49042b88f7141beac614379149d6f","user":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars.githubusercontent.com/u/1306301?v=3","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":19703913,"name":"WordPress-Editor-iOS","full_name":"wordpress-mobile/WordPress-Editor-iOS","owner":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars.githubusercontent.com/u/1306301?v=3","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wordpress-mobile/WordPress-Editor-iOS","description":"A reusable iOS rich text editor component.","fork":false,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS","forks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/forks","keys_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/teams","hooks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/hooks","issue_events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/events","assignees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/tags","blobs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/languages","stargazers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/stargazers","contributors_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/contributors","subscribers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/subscribers","subscription_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/subscription","commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/merges","archive_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/downloads","issues_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/labels{/name}","releases_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/releases{/id}","created_at":"2014-05-12T15:22:29Z","updated_at":"2015-06-30T14:45:26Z","pushed_at":"2015-06-30T14:50:57Z","git_url":"git://github.com/wordpress-mobile/WordPress-Editor-iOS.git","ssh_url":"git@github.com:wordpress-mobile/WordPress-Editor-iOS.git","clone_url":"https://github.com/wordpress-mobile/WordPress-Editor-iOS.git","svn_url":"https://github.com/wordpress-mobile/WordPress-Editor-iOS","homepage":"","size":8895,"stargazers_count":192,"watchers_count":192,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":152,"forks":34,"open_issues":152,"watchers":192,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/pulls/678"},"html":{"href":"https://github.com/wordpress-mobile/WordPress-Editor-iOS/pull/678"},"issue":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/issues/678"},"comments":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/issues/678/comments"},"review_comments":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/pulls/678/comments"},"review_comment":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/pulls/678/commits"},"statuses":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Editor-iOS/statuses/9fafd9d56a0bda049f1d6f327102774291e0da74"}}}}