{"action":"created","issue":{"url":"https://api.github.com/repos/lbdremy/solr-node-client/issues/149","labels_url":"https://api.github.com/repos/lbdremy/solr-node-client/issues/149/labels{/name}","comments_url":"https://api.github.com/repos/lbdremy/solr-node-client/issues/149/comments","events_url":"https://api.github.com/repos/lbdremy/solr-node-client/issues/149/events","html_url":"https://github.com/lbdremy/solr-node-client/pull/149","id":107630658,"number":149,"title":"Implement The TermsComponent","user":{"login":"godong9","id":1950670,"avatar_url":"https://avatars.githubusercontent.com/u/1950670?v=3","gravatar_id":"","url":"https://api.github.com/users/godong9","html_url":"https://github.com/godong9","followers_url":"https://api.github.com/users/godong9/followers","following_url":"https://api.github.com/users/godong9/following{/other_user}","gists_url":"https://api.github.com/users/godong9/gists{/gist_id}","starred_url":"https://api.github.com/users/godong9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godong9/subscriptions","organizations_url":"https://api.github.com/users/godong9/orgs","repos_url":"https://api.github.com/users/godong9/repos","events_url":"https://api.github.com/users/godong9/events{/privacy}","received_events_url":"https://api.github.com/users/godong9/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-22T01:39:50Z","updated_at":"2015-09-24T13:52:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lbdremy/solr-node-client/pulls/149","html_url":"https://github.com/lbdremy/solr-node-client/pull/149","diff_url":"https://github.com/lbdremy/solr-node-client/pull/149.diff","patch_url":"https://github.com/lbdremy/solr-node-client/pull/149.patch"},"body":"Implement The TermsComponent.\r\n\r\nTest need to modify \"solrconfig.xml\".\r\n\r\nhttp://wiki.apache.org/solr/TermsComponent"},"comment":{"url":"https://api.github.com/repos/lbdremy/solr-node-client/issues/comments/142934011","html_url":"https://github.com/lbdremy/solr-node-client/pull/149#issuecomment-142934011","issue_url":"https://api.github.com/repos/lbdremy/solr-node-client/issues/149","id":142934011,"user":{"login":"luketaverne","id":9134443,"avatar_url":"https://avatars.githubusercontent.com/u/9134443?v=3","gravatar_id":"","url":"https://api.github.com/users/luketaverne","html_url":"https://github.com/luketaverne","followers_url":"https://api.github.com/users/luketaverne/followers","following_url":"https://api.github.com/users/luketaverne/following{/other_user}","gists_url":"https://api.github.com/users/luketaverne/gists{/gist_id}","starred_url":"https://api.github.com/users/luketaverne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luketaverne/subscriptions","organizations_url":"https://api.github.com/users/luketaverne/orgs","repos_url":"https://api.github.com/users/luketaverne/repos","events_url":"https://api.github.com/users/luketaverne/events{/privacy}","received_events_url":"https://api.github.com/users/luketaverne/received_events","type":"User","site_admin":false},"created_at":"2015-09-24T13:52:18Z","updated_at":"2015-09-24T13:52:18Z","body":"This looks good. Nice work! Could you revise a few things before we merge this?\r\n\r\n* The https://wiki.apache.org/solr/ pages are for old versions of Solr, and I'm unsure whether they are still maintained. Can you **change these links to the relevant pages on the Solr 5 [cwiki](https://cwiki.apache.org/confluence/display/solr/Apache+Solr+Reference+Guide)**? We're aiming for full support of Solr 5, so having the Solr 5 docs from this point forward is desired.\r\n* Your test is failing because you're examining the `data.terms` object. The test platform (as far as I know, correct me if I'm wrong here @lbdremy @nicolasembleton), doesn't contain any example docs. So **your `assert.deepEqual()` should examine `data.responseHeader.params` instead**. Then the tests will pass.\r\n* Formatting of the \"Terms Component\" wiki page that was copied into the test should be removed. A link to the cwiki page will do just fine, and look cleaner.\r\n* Formatting of the options array on **line 55 of terms-query-test.js**. Extra space should be removed.\r\n\r\nAside from these small things, your implementation works well in my testing. Thanks for contributing!"}}