{"action":"created","comment":{"url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/pulls/comments/31929363","id":31929363,"diff_hunk":"@@ -141,20 +225,29 @@ gulp.task('clean-docs', function(cb) {\n // Test & code coverage\n //\n \n-gulp.task('cover', function() {\n-  var istanbul = '$(npm bin)/istanbul ';\n+gulp.task('cover', function(cb) {\n+  var _mocha = '$(npm bin)/_mocha';\n+  var istanbul = '$(npm bin)/istanbul';\n   var level = '--statements 100 --functions 100 --branches 100 --lines 100';\n-  var testCoverCommands = [istanbul + 'cover _mocha -- -R min test'];\n-  var testCoverOpts = {ignoreErrors: true};\n+  var quote = require('./util/TestingQuotes').random();\n \n-  var checkCoverCommands = [istanbul + ' check-coverage ' + level];\n-  var checkCoverOpts = {ignoreErrors: true};\n+  var testCoverCommand = istanbul + ' cover ' + _mocha + ' -- -R dot test';\n+  var checkCoverCommand = istanbul + ' check-coverage ' + level;\n \n-  return gulp.src('')\n-    .pipe($.shell(testCoverCommands, testCoverOpts))\n-    .pipe($.shell(checkCoverCommands, checkCoverOpts));\n+  exec(testCoverCommand, function(err, stdout, stderr) {\n+    if (err) {\n+      helpfulError(err || stderr, stdout);\n+    }\n+\n+    exec(checkCoverCommand, function(checkErr, checkStdout, checkStderr) {\n+      var parsedError = parseErrorObject(checkErr).err;\n+      helpfulError(parsedError || checkStderr, quote.quote + '\\n' + quote.by);\n+      cb();\n+    });\n+  });\n });\n ","path":"gulpfile.js","position":204,"original_position":204,"commit_id":"91bcd8365b06e6596127da0594cc387c69dddf96","original_commit_id":"91bcd8365b06e6596127da0594cc387c69dddf96","user":{"login":"eanplatter","id":3782604,"avatar_url":"https://avatars.githubusercontent.com/u/3782604?v=3","gravatar_id":"","url":"https://api.github.com/users/eanplatter","html_url":"https://github.com/eanplatter","followers_url":"https://api.github.com/users/eanplatter/followers","following_url":"https://api.github.com/users/eanplatter/following{/other_user}","gists_url":"https://api.github.com/users/eanplatter/gists{/gist_id}","starred_url":"https://api.github.com/users/eanplatter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eanplatter/subscriptions","organizations_url":"https://api.github.com/users/eanplatter/orgs","repos_url":"https://api.github.com/users/eanplatter/repos","events_url":"https://api.github.com/users/eanplatter/events{/privacy}","received_events_url":"https://api.github.com/users/eanplatter/received_events","type":"User","site_admin":false},"body":"For some reason the 'cover' task isn't displaying the results of tests, and the 'test' task is never being called. Should we call the test task? Or should the cover task be showing it's tests?","created_at":"2015-06-08T15:55:25Z","updated_at":"2015-06-08T15:55:25Z","html_url":"https://github.com/TechnologyAdvice/tap-flux/pull/13#discussion_r31929363","pull_request_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/TechnologyAdvice/tap-flux/pulls/comments/31929363"},"html":{"href":"https://github.com/TechnologyAdvice/tap-flux/pull/13#discussion_r31929363"},"pull_request":{"href":"https://api.github.com/repos/TechnologyAdvice/tap-flux/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/pulls/13","id":37086794,"html_url":"https://github.com/TechnologyAdvice/tap-flux/pull/13","diff_url":"https://github.com/TechnologyAdvice/tap-flux/pull/13.diff","patch_url":"https://github.com/TechnologyAdvice/tap-flux/pull/13.patch","issue_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/issues/13","number":13,"state":"open","locked":false,"title":"Helpful, fun, and pretty build messages","user":{"login":"levithomason","id":5067638,"avatar_url":"https://avatars.githubusercontent.com/u/5067638?v=3","gravatar_id":"","url":"https://api.github.com/users/levithomason","html_url":"https://github.com/levithomason","followers_url":"https://api.github.com/users/levithomason/followers","following_url":"https://api.github.com/users/levithomason/following{/other_user}","gists_url":"https://api.github.com/users/levithomason/gists{/gist_id}","starred_url":"https://api.github.com/users/levithomason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levithomason/subscriptions","organizations_url":"https://api.github.com/users/levithomason/orgs","repos_url":"https://api.github.com/users/levithomason/repos","events_url":"https://api.github.com/users/levithomason/events{/privacy}","received_events_url":"https://api.github.com/users/levithomason/received_events","type":"User","site_admin":false},"body":"Yea, the branch name makes no sense.\r\n\r\nMerge after gulp lint branch, as this includes it's commits.","created_at":"2015-06-06T07:49:05Z","updated_at":"2015-06-08T15:55:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"254009ed6a4e71828ca0d0a1793f7b21f13a9a82","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/pulls/13/commits","review_comments_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/pulls/13/comments","review_comment_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/issues/13/comments","statuses_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/statuses/91bcd8365b06e6596127da0594cc387c69dddf96","head":{"label":"TechnologyAdvice:feature/no-build-on-deploy","ref":"feature/no-build-on-deploy","sha":"91bcd8365b06e6596127da0594cc387c69dddf96","user":{"login":"TechnologyAdvice","id":6045188,"avatar_url":"https://avatars.githubusercontent.com/u/6045188?v=3","gravatar_id":"","url":"https://api.github.com/users/TechnologyAdvice","html_url":"https://github.com/TechnologyAdvice","followers_url":"https://api.github.com/users/TechnologyAdvice/followers","following_url":"https://api.github.com/users/TechnologyAdvice/following{/other_user}","gists_url":"https://api.github.com/users/TechnologyAdvice/gists{/gist_id}","starred_url":"https://api.github.com/users/TechnologyAdvice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechnologyAdvice/subscriptions","organizations_url":"https://api.github.com/users/TechnologyAdvice/orgs","repos_url":"https://api.github.com/users/TechnologyAdvice/repos","events_url":"https://api.github.com/users/TechnologyAdvice/events{/privacy}","received_events_url":"https://api.github.com/users/TechnologyAdvice/received_events","type":"Organization","site_admin":false},"repo":{"id":35972813,"name":"tap-flux","full_name":"TechnologyAdvice/tap-flux","owner":{"login":"TechnologyAdvice","id":6045188,"avatar_url":"https://avatars.githubusercontent.com/u/6045188?v=3","gravatar_id":"","url":"https://api.github.com/users/TechnologyAdvice","html_url":"https://github.com/TechnologyAdvice","followers_url":"https://api.github.com/users/TechnologyAdvice/followers","following_url":"https://api.github.com/users/TechnologyAdvice/following{/other_user}","gists_url":"https://api.github.com/users/TechnologyAdvice/gists{/gist_id}","starred_url":"https://api.github.com/users/TechnologyAdvice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechnologyAdvice/subscriptions","organizations_url":"https://api.github.com/users/TechnologyAdvice/orgs","repos_url":"https://api.github.com/users/TechnologyAdvice/repos","events_url":"https://api.github.com/users/TechnologyAdvice/events{/privacy}","received_events_url":"https://api.github.com/users/TechnologyAdvice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TechnologyAdvice/tap-flux","description":"Tap Flux makes writing React apps with Flux really simple.","fork":false,"url":"https://api.github.com/repos/TechnologyAdvice/tap-flux","forks_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/forks","keys_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/teams","hooks_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/hooks","issue_events_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/issues/events{/number}","events_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/events","assignees_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/assignees{/user}","branches_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/branches{/branch}","tags_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/tags","blobs_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/git/refs{/sha}","trees_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/statuses/{sha}","languages_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/languages","stargazers_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/stargazers","contributors_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/contributors","subscribers_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/subscribers","subscription_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/subscription","commits_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/commits{/sha}","git_commits_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/git/commits{/sha}","comments_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/comments{/number}","issue_comment_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/issues/comments{/number}","contents_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/contents/{+path}","compare_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/merges","archive_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/downloads","issues_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/issues{/number}","pulls_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/pulls{/number}","milestones_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/milestones{/number}","notifications_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/labels{/name}","releases_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/releases{/id}","created_at":"2015-05-20T20:36:10Z","updated_at":"2015-06-05T10:37:09Z","pushed_at":"2015-06-06T20:49:25Z","git_url":"git://github.com/TechnologyAdvice/tap-flux.git","ssh_url":"git@github.com:TechnologyAdvice/tap-flux.git","clone_url":"https://github.com/TechnologyAdvice/tap-flux.git","svn_url":"https://github.com/TechnologyAdvice/tap-flux","homepage":"http://tap-flux.js.org","size":4825,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"TechnologyAdvice:master","ref":"master","sha":"02a268936e308c59ab6aef4ba5bcd6da5eb27ede","user":{"login":"TechnologyAdvice","id":6045188,"avatar_url":"https://avatars.githubusercontent.com/u/6045188?v=3","gravatar_id":"","url":"https://api.github.com/users/TechnologyAdvice","html_url":"https://github.com/TechnologyAdvice","followers_url":"https://api.github.com/users/TechnologyAdvice/followers","following_url":"https://api.github.com/users/TechnologyAdvice/following{/other_user}","gists_url":"https://api.github.com/users/TechnologyAdvice/gists{/gist_id}","starred_url":"https://api.github.com/users/TechnologyAdvice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechnologyAdvice/subscriptions","organizations_url":"https://api.github.com/users/TechnologyAdvice/orgs","repos_url":"https://api.github.com/users/TechnologyAdvice/repos","events_url":"https://api.github.com/users/TechnologyAdvice/events{/privacy}","received_events_url":"https://api.github.com/users/TechnologyAdvice/received_events","type":"Organization","site_admin":false},"repo":{"id":35972813,"name":"tap-flux","full_name":"TechnologyAdvice/tap-flux","owner":{"login":"TechnologyAdvice","id":6045188,"avatar_url":"https://avatars.githubusercontent.com/u/6045188?v=3","gravatar_id":"","url":"https://api.github.com/users/TechnologyAdvice","html_url":"https://github.com/TechnologyAdvice","followers_url":"https://api.github.com/users/TechnologyAdvice/followers","following_url":"https://api.github.com/users/TechnologyAdvice/following{/other_user}","gists_url":"https://api.github.com/users/TechnologyAdvice/gists{/gist_id}","starred_url":"https://api.github.com/users/TechnologyAdvice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechnologyAdvice/subscriptions","organizations_url":"https://api.github.com/users/TechnologyAdvice/orgs","repos_url":"https://api.github.com/users/TechnologyAdvice/repos","events_url":"https://api.github.com/users/TechnologyAdvice/events{/privacy}","received_events_url":"https://api.github.com/users/TechnologyAdvice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TechnologyAdvice/tap-flux","description":"Tap Flux makes writing React apps with Flux really simple.","fork":false,"url":"https://api.github.com/repos/TechnologyAdvice/tap-flux","forks_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/forks","keys_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/teams","hooks_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/hooks","issue_events_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/issues/events{/number}","events_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/events","assignees_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/assignees{/user}","branches_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/branches{/branch}","tags_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/tags","blobs_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/git/refs{/sha}","trees_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/statuses/{sha}","languages_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/languages","stargazers_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/stargazers","contributors_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/contributors","subscribers_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/subscribers","subscription_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/subscription","commits_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/commits{/sha}","git_commits_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/git/commits{/sha}","comments_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/comments{/number}","issue_comment_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/issues/comments{/number}","contents_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/contents/{+path}","compare_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/merges","archive_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/downloads","issues_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/issues{/number}","pulls_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/pulls{/number}","milestones_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/milestones{/number}","notifications_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/labels{/name}","releases_url":"https://api.github.com/repos/TechnologyAdvice/tap-flux/releases{/id}","created_at":"2015-05-20T20:36:10Z","updated_at":"2015-06-05T10:37:09Z","pushed_at":"2015-06-06T20:49:25Z","git_url":"git://github.com/TechnologyAdvice/tap-flux.git","ssh_url":"git@github.com:TechnologyAdvice/tap-flux.git","clone_url":"https://github.com/TechnologyAdvice/tap-flux.git","svn_url":"https://github.com/TechnologyAdvice/tap-flux","homepage":"http://tap-flux.js.org","size":4825,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TechnologyAdvice/tap-flux/pulls/13"},"html":{"href":"https://github.com/TechnologyAdvice/tap-flux/pull/13"},"issue":{"href":"https://api.github.com/repos/TechnologyAdvice/tap-flux/issues/13"},"comments":{"href":"https://api.github.com/repos/TechnologyAdvice/tap-flux/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/TechnologyAdvice/tap-flux/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/TechnologyAdvice/tap-flux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TechnologyAdvice/tap-flux/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/TechnologyAdvice/tap-flux/statuses/91bcd8365b06e6596127da0594cc387c69dddf96"}}}}