{"action":"created","comment":{"url":"https://api.github.com/repos/ruflin/Elastica/pulls/comments/42490741","id":42490741,"diff_hunk":"@@ -299,6 +299,22 @@ public function setMapping($mapping)\n     }\n \n     /**\n+     * Sets value type mapping for this type with timestamp .\n+     *\n+     * @param \\Elastica\\Type\\Mapping|array $mapping Elastica\\Type\\MappingType object or property array with all mappings\n+     *\n+     * @return \\Elastica\\Response\n+     */\n+    public function setMappingWithTimeStamp($mapping,$timestamp)","path":"lib/Elastica/Type.php","position":10,"original_position":10,"commit_id":"f5de4c136daa9ce834f6ddb4c297c3416efc38ab","original_commit_id":"f5de4c136daa9ce834f6ddb4c297c3416efc38ab","user":{"login":"ruflin","id":244900,"avatar_url":"https://avatars.githubusercontent.com/u/244900?v=3","gravatar_id":"","url":"https://api.github.com/users/ruflin","html_url":"https://github.com/ruflin","followers_url":"https://api.github.com/users/ruflin/followers","following_url":"https://api.github.com/users/ruflin/following{/other_user}","gists_url":"https://api.github.com/users/ruflin/gists{/gist_id}","starred_url":"https://api.github.com/users/ruflin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruflin/subscriptions","organizations_url":"https://api.github.com/users/ruflin/orgs","repos_url":"https://api.github.com/users/ruflin/repos","events_url":"https://api.github.com/users/ruflin/events{/privacy}","received_events_url":"https://api.github.com/users/ruflin/received_events","type":"User","site_admin":false},"body":"Instead of introducing a new function, I would suggest to add a param to setMapping ","created_at":"2015-10-20T12:54:33Z","updated_at":"2015-10-20T12:54:33Z","html_url":"https://github.com/ruflin/Elastica/pull/965#discussion_r42490741","pull_request_url":"https://api.github.com/repos/ruflin/Elastica/pulls/965","_links":{"self":{"href":"https://api.github.com/repos/ruflin/Elastica/pulls/comments/42490741"},"html":{"href":"https://github.com/ruflin/Elastica/pull/965#discussion_r42490741"},"pull_request":{"href":"https://api.github.com/repos/ruflin/Elastica/pulls/965"}}},"pull_request":{"url":"https://api.github.com/repos/ruflin/Elastica/pulls/965","id":48193203,"html_url":"https://github.com/ruflin/Elastica/pull/965","diff_url":"https://github.com/ruflin/Elastica/pull/965.diff","patch_url":"https://github.com/ruflin/Elastica/pull/965.patch","issue_url":"https://api.github.com/repos/ruflin/Elastica/issues/965","number":965,"state":"open","locked":false,"title":" support of adding _timestamp in during mapping","user":{"login":"savdeep","id":316198,"avatar_url":"https://avatars.githubusercontent.com/u/316198?v=3","gravatar_id":"","url":"https://api.github.com/users/savdeep","html_url":"https://github.com/savdeep","followers_url":"https://api.github.com/users/savdeep/followers","following_url":"https://api.github.com/users/savdeep/following{/other_user}","gists_url":"https://api.github.com/users/savdeep/gists{/gist_id}","starred_url":"https://api.github.com/users/savdeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/savdeep/subscriptions","organizations_url":"https://api.github.com/users/savdeep/orgs","repos_url":"https://api.github.com/users/savdeep/repos","events_url":"https://api.github.com/users/savdeep/events{/privacy}","received_events_url":"https://api.github.com/users/savdeep/received_events","type":"User","site_admin":false},"body":"Added proxy methods for _timestamp","created_at":"2015-10-20T12:25:31Z","updated_at":"2015-10-20T12:54:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2227766d4c090ec75ee33ec11dddbc3090636e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ruflin/Elastica/pulls/965/commits","review_comments_url":"https://api.github.com/repos/ruflin/Elastica/pulls/965/comments","review_comment_url":"https://api.github.com/repos/ruflin/Elastica/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ruflin/Elastica/issues/965/comments","statuses_url":"https://api.github.com/repos/ruflin/Elastica/statuses/f5de4c136daa9ce834f6ddb4c297c3416efc38ab","head":{"label":"savdeep:master","ref":"master","sha":"f5de4c136daa9ce834f6ddb4c297c3416efc38ab","user":{"login":"savdeep","id":316198,"avatar_url":"https://avatars.githubusercontent.com/u/316198?v=3","gravatar_id":"","url":"https://api.github.com/users/savdeep","html_url":"https://github.com/savdeep","followers_url":"https://api.github.com/users/savdeep/followers","following_url":"https://api.github.com/users/savdeep/following{/other_user}","gists_url":"https://api.github.com/users/savdeep/gists{/gist_id}","starred_url":"https://api.github.com/users/savdeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/savdeep/subscriptions","organizations_url":"https://api.github.com/users/savdeep/orgs","repos_url":"https://api.github.com/users/savdeep/repos","events_url":"https://api.github.com/users/savdeep/events{/privacy}","received_events_url":"https://api.github.com/users/savdeep/received_events","type":"User","site_admin":false},"repo":{"id":44592944,"name":"Elastica","full_name":"savdeep/Elastica","owner":{"login":"savdeep","id":316198,"avatar_url":"https://avatars.githubusercontent.com/u/316198?v=3","gravatar_id":"","url":"https://api.github.com/users/savdeep","html_url":"https://github.com/savdeep","followers_url":"https://api.github.com/users/savdeep/followers","following_url":"https://api.github.com/users/savdeep/following{/other_user}","gists_url":"https://api.github.com/users/savdeep/gists{/gist_id}","starred_url":"https://api.github.com/users/savdeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/savdeep/subscriptions","organizations_url":"https://api.github.com/users/savdeep/orgs","repos_url":"https://api.github.com/users/savdeep/repos","events_url":"https://api.github.com/users/savdeep/events{/privacy}","received_events_url":"https://api.github.com/users/savdeep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/savdeep/Elastica","description":"Elastica is a PHP client for elasticsearch","fork":true,"url":"https://api.github.com/repos/savdeep/Elastica","forks_url":"https://api.github.com/repos/savdeep/Elastica/forks","keys_url":"https://api.github.com/repos/savdeep/Elastica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/savdeep/Elastica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/savdeep/Elastica/teams","hooks_url":"https://api.github.com/repos/savdeep/Elastica/hooks","issue_events_url":"https://api.github.com/repos/savdeep/Elastica/issues/events{/number}","events_url":"https://api.github.com/repos/savdeep/Elastica/events","assignees_url":"https://api.github.com/repos/savdeep/Elastica/assignees{/user}","branches_url":"https://api.github.com/repos/savdeep/Elastica/branches{/branch}","tags_url":"https://api.github.com/repos/savdeep/Elastica/tags","blobs_url":"https://api.github.com/repos/savdeep/Elastica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/savdeep/Elastica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/savdeep/Elastica/git/refs{/sha}","trees_url":"https://api.github.com/repos/savdeep/Elastica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/savdeep/Elastica/statuses/{sha}","languages_url":"https://api.github.com/repos/savdeep/Elastica/languages","stargazers_url":"https://api.github.com/repos/savdeep/Elastica/stargazers","contributors_url":"https://api.github.com/repos/savdeep/Elastica/contributors","subscribers_url":"https://api.github.com/repos/savdeep/Elastica/subscribers","subscription_url":"https://api.github.com/repos/savdeep/Elastica/subscription","commits_url":"https://api.github.com/repos/savdeep/Elastica/commits{/sha}","git_commits_url":"https://api.github.com/repos/savdeep/Elastica/git/commits{/sha}","comments_url":"https://api.github.com/repos/savdeep/Elastica/comments{/number}","issue_comment_url":"https://api.github.com/repos/savdeep/Elastica/issues/comments{/number}","contents_url":"https://api.github.com/repos/savdeep/Elastica/contents/{+path}","compare_url":"https://api.github.com/repos/savdeep/Elastica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/savdeep/Elastica/merges","archive_url":"https://api.github.com/repos/savdeep/Elastica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/savdeep/Elastica/downloads","issues_url":"https://api.github.com/repos/savdeep/Elastica/issues{/number}","pulls_url":"https://api.github.com/repos/savdeep/Elastica/pulls{/number}","milestones_url":"https://api.github.com/repos/savdeep/Elastica/milestones{/number}","notifications_url":"https://api.github.com/repos/savdeep/Elastica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/savdeep/Elastica/labels{/name}","releases_url":"https://api.github.com/repos/savdeep/Elastica/releases{/id}","created_at":"2015-10-20T08:35:46Z","updated_at":"2015-10-20T08:35:49Z","pushed_at":"2015-10-20T12:00:46Z","git_url":"git://github.com/savdeep/Elastica.git","ssh_url":"git@github.com:savdeep/Elastica.git","clone_url":"https://github.com/savdeep/Elastica.git","svn_url":"https://github.com/savdeep/Elastica","homepage":"http://elastica.io/","size":56650,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ruflin:master","ref":"master","sha":"af6ecbccae81bfc7fc1a52f6100542b9a81fce8a","user":{"login":"ruflin","id":244900,"avatar_url":"https://avatars.githubusercontent.com/u/244900?v=3","gravatar_id":"","url":"https://api.github.com/users/ruflin","html_url":"https://github.com/ruflin","followers_url":"https://api.github.com/users/ruflin/followers","following_url":"https://api.github.com/users/ruflin/following{/other_user}","gists_url":"https://api.github.com/users/ruflin/gists{/gist_id}","starred_url":"https://api.github.com/users/ruflin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruflin/subscriptions","organizations_url":"https://api.github.com/users/ruflin/orgs","repos_url":"https://api.github.com/users/ruflin/repos","events_url":"https://api.github.com/users/ruflin/events{/privacy}","received_events_url":"https://api.github.com/users/ruflin/received_events","type":"User","site_admin":false},"repo":{"id":1006445,"name":"Elastica","full_name":"ruflin/Elastica","owner":{"login":"ruflin","id":244900,"avatar_url":"https://avatars.githubusercontent.com/u/244900?v=3","gravatar_id":"","url":"https://api.github.com/users/ruflin","html_url":"https://github.com/ruflin","followers_url":"https://api.github.com/users/ruflin/followers","following_url":"https://api.github.com/users/ruflin/following{/other_user}","gists_url":"https://api.github.com/users/ruflin/gists{/gist_id}","starred_url":"https://api.github.com/users/ruflin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruflin/subscriptions","organizations_url":"https://api.github.com/users/ruflin/orgs","repos_url":"https://api.github.com/users/ruflin/repos","events_url":"https://api.github.com/users/ruflin/events{/privacy}","received_events_url":"https://api.github.com/users/ruflin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ruflin/Elastica","description":"Elastica is a PHP client for elasticsearch","fork":false,"url":"https://api.github.com/repos/ruflin/Elastica","forks_url":"https://api.github.com/repos/ruflin/Elastica/forks","keys_url":"https://api.github.com/repos/ruflin/Elastica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruflin/Elastica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruflin/Elastica/teams","hooks_url":"https://api.github.com/repos/ruflin/Elastica/hooks","issue_events_url":"https://api.github.com/repos/ruflin/Elastica/issues/events{/number}","events_url":"https://api.github.com/repos/ruflin/Elastica/events","assignees_url":"https://api.github.com/repos/ruflin/Elastica/assignees{/user}","branches_url":"https://api.github.com/repos/ruflin/Elastica/branches{/branch}","tags_url":"https://api.github.com/repos/ruflin/Elastica/tags","blobs_url":"https://api.github.com/repos/ruflin/Elastica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruflin/Elastica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruflin/Elastica/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruflin/Elastica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruflin/Elastica/statuses/{sha}","languages_url":"https://api.github.com/repos/ruflin/Elastica/languages","stargazers_url":"https://api.github.com/repos/ruflin/Elastica/stargazers","contributors_url":"https://api.github.com/repos/ruflin/Elastica/contributors","subscribers_url":"https://api.github.com/repos/ruflin/Elastica/subscribers","subscription_url":"https://api.github.com/repos/ruflin/Elastica/subscription","commits_url":"https://api.github.com/repos/ruflin/Elastica/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruflin/Elastica/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruflin/Elastica/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruflin/Elastica/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruflin/Elastica/contents/{+path}","compare_url":"https://api.github.com/repos/ruflin/Elastica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruflin/Elastica/merges","archive_url":"https://api.github.com/repos/ruflin/Elastica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruflin/Elastica/downloads","issues_url":"https://api.github.com/repos/ruflin/Elastica/issues{/number}","pulls_url":"https://api.github.com/repos/ruflin/Elastica/pulls{/number}","milestones_url":"https://api.github.com/repos/ruflin/Elastica/milestones{/number}","notifications_url":"https://api.github.com/repos/ruflin/Elastica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruflin/Elastica/labels{/name}","releases_url":"https://api.github.com/repos/ruflin/Elastica/releases{/id}","created_at":"2010-10-19T17:04:21Z","updated_at":"2015-10-20T07:52:18Z","pushed_at":"2015-10-20T12:25:31Z","git_url":"git://github.com/ruflin/Elastica.git","ssh_url":"git@github.com:ruflin/Elastica.git","clone_url":"https://github.com/ruflin/Elastica.git","svn_url":"https://github.com/ruflin/Elastica","homepage":"http://elastica.io/","size":56650,"stargazers_count":1079,"watchers_count":1079,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":408,"mirror_url":null,"open_issues_count":91,"forks":408,"open_issues":91,"watchers":1079,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ruflin/Elastica/pulls/965"},"html":{"href":"https://github.com/ruflin/Elastica/pull/965"},"issue":{"href":"https://api.github.com/repos/ruflin/Elastica/issues/965"},"comments":{"href":"https://api.github.com/repos/ruflin/Elastica/issues/965/comments"},"review_comments":{"href":"https://api.github.com/repos/ruflin/Elastica/pulls/965/comments"},"review_comment":{"href":"https://api.github.com/repos/ruflin/Elastica/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ruflin/Elastica/pulls/965/commits"},"statuses":{"href":"https://api.github.com/repos/ruflin/Elastica/statuses/f5de4c136daa9ce834f6ddb4c297c3416efc38ab"}}}}