{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin-dot-org/bitcoin.org/issues/939","labels_url":"https://api.github.com/repos/bitcoin-dot-org/bitcoin.org/issues/939/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin-dot-org/bitcoin.org/issues/939/comments","events_url":"https://api.github.com/repos/bitcoin-dot-org/bitcoin.org/issues/939/events","html_url":"https://github.com/bitcoin-dot-org/bitcoin.org/pull/939","id":93037825,"number":939,"title":"Avoid deleting excluded files in .gitignore in build script","user":{"login":"saivann","id":3578089,"avatar_url":"https://avatars.githubusercontent.com/u/3578089?v=3","gravatar_id":"","url":"https://api.github.com/users/saivann","html_url":"https://github.com/saivann","followers_url":"https://api.github.com/users/saivann/followers","following_url":"https://api.github.com/users/saivann/following{/other_user}","gists_url":"https://api.github.com/users/saivann/gists{/gist_id}","starred_url":"https://api.github.com/users/saivann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saivann/subscriptions","organizations_url":"https://api.github.com/users/saivann/orgs","repos_url":"https://api.github.com/users/saivann/repos","events_url":"https://api.github.com/users/saivann/events{/privacy}","received_events_url":"https://api.github.com/users/saivann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-04T18:49:29Z","updated_at":"2015-07-04T19:33:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin-dot-org/bitcoin.org/pulls/939","html_url":"https://github.com/bitcoin-dot-org/bitcoin.org/pull/939","diff_url":"https://github.com/bitcoin-dot-org/bitcoin.org/pull/939.diff","patch_url":"https://github.com/bitcoin-dot-org/bitcoin.org/pull/939.patch"},"body":"This change brings significant performance improvement for the build process, as the build script otherwise deletes ./vendor, which forces bundler to reinstall every dependency from scratch on every build, which then delays the build for approximately 3 minutes.\r\n\r\nIt also seems to me that downloading and installing dependencies on every build exposes us to some more third party risk for no reason.\r\n\r\nGit clean man file for the -x option:\r\nhttps://git-scm.com/docs/git-clean\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/bitcoin-dot-org/bitcoin.org/issues/comments/118544940","html_url":"https://github.com/bitcoin-dot-org/bitcoin.org/pull/939#issuecomment-118544940","issue_url":"https://api.github.com/repos/bitcoin-dot-org/bitcoin.org/issues/939","id":118544940,"user":{"login":"harding","id":61096,"avatar_url":"https://avatars.githubusercontent.com/u/61096?v=3","gravatar_id":"","url":"https://api.github.com/users/harding","html_url":"https://github.com/harding","followers_url":"https://api.github.com/users/harding/followers","following_url":"https://api.github.com/users/harding/following{/other_user}","gists_url":"https://api.github.com/users/harding/gists{/gist_id}","starred_url":"https://api.github.com/users/harding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harding/subscriptions","organizations_url":"https://api.github.com/users/harding/orgs","repos_url":"https://api.github.com/users/harding/repos","events_url":"https://api.github.com/users/harding/events{/privacy}","received_events_url":"https://api.github.com/users/harding/received_events","type":"User","site_admin":false},"created_at":"2015-07-04T19:33:30Z","updated_at":"2015-07-04T19:33:30Z","body":"@saivann huh.  I think that's a regression, as I don't remember it doing that when I first set it up.  (But I just tested, and you are correct)  However, I haven't been able to find a plausible commit where anything changed.\r\n\r\nI think dropping `-x` is the good option for now.  However, if we want it back later, we can add `--path=/some/directory` to the `install-deps-deployment` target in the Makefile.  (See `bundle help install` for details.)\r\n\r\nLGTM.  Suggest merging whenever you're ready to manually update the live build script.  Thanks for catching this!"}}