{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/40750347","id":40750347,"diff_hunk":"@@ -87,11 +87,11 @@ public boolean isInitiatedByNetworkClient() {\n         return isInitiatedByNetworkClient;\n     }\n \n-    public long getSendMs() {\n+    public long sendTime() {\n         return sendMs;\n     }\n \n-    public void setSendMs(long sendMs) {\n+    public void setSendTime(long sendMs) {","path":"clients/src/main/java/org/apache/kafka/clients/ClientRequest.java","position":10,"original_position":10,"commit_id":"de29695522ed5c4e408b5b385aa990d099d0c87e","original_commit_id":"de29695522ed5c4e408b5b385aa990d099d0c87e","user":{"login":"MayureshGharat","id":4326831,"avatar_url":"https://avatars.githubusercontent.com/u/4326831?v=3","gravatar_id":"","url":"https://api.github.com/users/MayureshGharat","html_url":"https://github.com/MayureshGharat","followers_url":"https://api.github.com/users/MayureshGharat/followers","following_url":"https://api.github.com/users/MayureshGharat/following{/other_user}","gists_url":"https://api.github.com/users/MayureshGharat/gists{/gist_id}","starred_url":"https://api.github.com/users/MayureshGharat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MayureshGharat/subscriptions","organizations_url":"https://api.github.com/users/MayureshGharat/orgs","repos_url":"https://api.github.com/users/MayureshGharat/repos","events_url":"https://api.github.com/users/MayureshGharat/events{/privacy}","received_events_url":"https://api.github.com/users/MayureshGharat/received_events","type":"User","site_admin":false},"body":"Yes. We can change them for consistency. That's a very good point.","created_at":"2015-09-30T01:18:55Z","updated_at":"2015-09-30T01:18:55Z","html_url":"https://github.com/apache/kafka/pull/264#discussion_r40750347","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/264","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/40750347"},"html":{"href":"https://github.com/apache/kafka/pull/264#discussion_r40750347"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/264"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/264","id":46350246,"html_url":"https://github.com/apache/kafka/pull/264","diff_url":"https://github.com/apache/kafka/pull/264.diff","patch_url":"https://github.com/apache/kafka/pull/264.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/264","number":264,"state":"open","locked":false,"title":"MINOR: Set `sendTime` in `doSend` instead of `InFlightRequests.add` and rename method names for consistency","user":{"login":"ijuma","id":24747,"avatar_url":"https://avatars.githubusercontent.com/u/24747?v=3","gravatar_id":"","url":"https://api.github.com/users/ijuma","html_url":"https://github.com/ijuma","followers_url":"https://api.github.com/users/ijuma/followers","following_url":"https://api.github.com/users/ijuma/following{/other_user}","gists_url":"https://api.github.com/users/ijuma/gists{/gist_id}","starred_url":"https://api.github.com/users/ijuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijuma/subscriptions","organizations_url":"https://api.github.com/users/ijuma/orgs","repos_url":"https://api.github.com/users/ijuma/repos","events_url":"https://api.github.com/users/ijuma/events{/privacy}","received_events_url":"https://api.github.com/users/ijuma/received_events","type":"User","site_admin":false},"body":"@hachikuji @MayureshGharat @jjkoshy Thoughts?","created_at":"2015-09-30T00:45:49Z","updated_at":"2015-09-30T01:18:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae6467cc7f43368514995e66d219d1f148f11022","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/264/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/264/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/264/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/de29695522ed5c4e408b5b385aa990d099d0c87e","head":{"label":"ijuma:tweak-send-ms","ref":"tweak-send-ms","sha":"de29695522ed5c4e408b5b385aa990d099d0c87e","user":{"login":"ijuma","id":24747,"avatar_url":"https://avatars.githubusercontent.com/u/24747?v=3","gravatar_id":"","url":"https://api.github.com/users/ijuma","html_url":"https://github.com/ijuma","followers_url":"https://api.github.com/users/ijuma/followers","following_url":"https://api.github.com/users/ijuma/following{/other_user}","gists_url":"https://api.github.com/users/ijuma/gists{/gist_id}","starred_url":"https://api.github.com/users/ijuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijuma/subscriptions","organizations_url":"https://api.github.com/users/ijuma/orgs","repos_url":"https://api.github.com/users/ijuma/repos","events_url":"https://api.github.com/users/ijuma/events{/privacy}","received_events_url":"https://api.github.com/users/ijuma/received_events","type":"User","site_admin":false},"repo":{"id":32646946,"name":"kafka","full_name":"ijuma/kafka","owner":{"login":"ijuma","id":24747,"avatar_url":"https://avatars.githubusercontent.com/u/24747?v=3","gravatar_id":"","url":"https://api.github.com/users/ijuma","html_url":"https://github.com/ijuma","followers_url":"https://api.github.com/users/ijuma/followers","following_url":"https://api.github.com/users/ijuma/following{/other_user}","gists_url":"https://api.github.com/users/ijuma/gists{/gist_id}","starred_url":"https://api.github.com/users/ijuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijuma/subscriptions","organizations_url":"https://api.github.com/users/ijuma/orgs","repos_url":"https://api.github.com/users/ijuma/repos","events_url":"https://api.github.com/users/ijuma/events{/privacy}","received_events_url":"https://api.github.com/users/ijuma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ijuma/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/ijuma/kafka","forks_url":"https://api.github.com/repos/ijuma/kafka/forks","keys_url":"https://api.github.com/repos/ijuma/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ijuma/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ijuma/kafka/teams","hooks_url":"https://api.github.com/repos/ijuma/kafka/hooks","issue_events_url":"https://api.github.com/repos/ijuma/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/ijuma/kafka/events","assignees_url":"https://api.github.com/repos/ijuma/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/ijuma/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/ijuma/kafka/tags","blobs_url":"https://api.github.com/repos/ijuma/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ijuma/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ijuma/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/ijuma/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ijuma/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/ijuma/kafka/languages","stargazers_url":"https://api.github.com/repos/ijuma/kafka/stargazers","contributors_url":"https://api.github.com/repos/ijuma/kafka/contributors","subscribers_url":"https://api.github.com/repos/ijuma/kafka/subscribers","subscription_url":"https://api.github.com/repos/ijuma/kafka/subscription","commits_url":"https://api.github.com/repos/ijuma/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/ijuma/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/ijuma/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/ijuma/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/ijuma/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/ijuma/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ijuma/kafka/merges","archive_url":"https://api.github.com/repos/ijuma/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ijuma/kafka/downloads","issues_url":"https://api.github.com/repos/ijuma/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/ijuma/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/ijuma/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/ijuma/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ijuma/kafka/labels{/name}","releases_url":"https://api.github.com/repos/ijuma/kafka/releases{/id}","created_at":"2015-03-21T19:33:59Z","updated_at":"2015-03-21T19:34:01Z","pushed_at":"2015-09-30T00:41:10Z","git_url":"git://github.com/ijuma/kafka.git","ssh_url":"git@github.com:ijuma/kafka.git","clone_url":"https://github.com/ijuma/kafka.git","svn_url":"https://github.com/ijuma/kafka","homepage":null,"size":22941,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"5e769ccd5bf81f82c90069d4b0e79182a1cfe3c0","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","created_at":"2011-08-15T18:06:16Z","updated_at":"2015-09-29T15:03:01Z","pushed_at":"2015-09-30T00:45:49Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":33786,"stargazers_count":1975,"watchers_count":1975,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1188,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":94,"forks":1188,"open_issues":94,"watchers":1975,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/264"},"html":{"href":"https://github.com/apache/kafka/pull/264"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/264"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/264/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/264/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/264/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/de29695522ed5c4e408b5b385aa990d099d0c87e"}}}}