{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/guitarrapc/DSCResources/pulls/17","id":29996861,"html_url":"https://github.com/guitarrapc/DSCResources/pull/17","diff_url":"https://github.com/guitarrapc/DSCResources/pull/17.diff","patch_url":"https://github.com/guitarrapc/DSCResources/pull/17.patch","issue_url":"https://api.github.com/repos/guitarrapc/DSCResources/issues/17","number":17,"state":"closed","locked":false,"title":"Added DomainJoin Resource to control Domain Join/Unjoin","user":{"login":"guitarrapc","id":3856350,"avatar_url":"https://avatars.githubusercontent.com/u/3856350?v=3","gravatar_id":"","url":"https://api.github.com/users/guitarrapc","html_url":"https://github.com/guitarrapc","followers_url":"https://api.github.com/users/guitarrapc/followers","following_url":"https://api.github.com/users/guitarrapc/following{/other_user}","gists_url":"https://api.github.com/users/guitarrapc/gists{/gist_id}","starred_url":"https://api.github.com/users/guitarrapc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guitarrapc/subscriptions","organizations_url":"https://api.github.com/users/guitarrapc/orgs","repos_url":"https://api.github.com/users/guitarrapc/repos","events_url":"https://api.github.com/users/guitarrapc/events{/privacy}","received_events_url":"https://api.github.com/users/guitarrapc/received_events","type":"User","site_admin":false},"body":"Description\r\n----\r\n\r\nThis resource simply just manage Join/UnJoin Domain.\r\n\r\nWhy it needed?\r\n----\r\n\r\nAs xComputerManagement resource which MSFT release is handling \r\n\r\n1. Computer Name change\r\n2. Domain Join control\r\n\r\nThe problem is Key Property is Name. But WE DON'T WANT TO HANDLE EACH NODE'S COMPUTER NAME at all!!!!!\r\n\r\nTherefore I re-structured xComputerManagement and split/fix DomainJoin Logic to cDomainJoin Resource.\r\n\r\nChanged\r\n----\r\n\r\nBase is xComputerManagement Logic. \r\n\r\n**Removed following functionality from original.**\r\n\r\n- Change target node name. (cDomainJoin resource never change target node hostname)\r\n- Change Name property from Key to Read only Property.\r\n\r\n**Added following functionality from original.**\r\n\r\n- Added Identifier Key property to identity unique key for all resource. \r\n- Added ReadOnly property Ensure. This allow you to detect whether state is as is or not.\r\n\r\nTest\r\n----\r\n\r\nOriginal xComputerManagement resource failed Pester test....\r\n\r\nFixed logic and now all pester, Get-DSCConfiguration, Test-DSCConfiguration test is passed.","created_at":"2015-02-25T15:38:07Z","updated_at":"2015-02-25T15:38:12Z","closed_at":"2015-02-25T15:38:12Z","merged_at":"2015-02-25T15:38:12Z","merge_commit_sha":"2a303ee335bfe612587cd7e874d0d7806fb63e57","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guitarrapc/DSCResources/pulls/17/commits","review_comments_url":"https://api.github.com/repos/guitarrapc/DSCResources/pulls/17/comments","review_comment_url":"https://api.github.com/repos/guitarrapc/DSCResources/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guitarrapc/DSCResources/issues/17/comments","statuses_url":"https://api.github.com/repos/guitarrapc/DSCResources/statuses/ae0579d327e1efe2753700aa1b3a1072fc90bdb7","head":{"label":"guitarrapc:ModifyDomainJoinResource","ref":"ModifyDomainJoinResource","sha":"ae0579d327e1efe2753700aa1b3a1072fc90bdb7","user":{"login":"guitarrapc","id":3856350,"avatar_url":"https://avatars.githubusercontent.com/u/3856350?v=3","gravatar_id":"","url":"https://api.github.com/users/guitarrapc","html_url":"https://github.com/guitarrapc","followers_url":"https://api.github.com/users/guitarrapc/followers","following_url":"https://api.github.com/users/guitarrapc/following{/other_user}","gists_url":"https://api.github.com/users/guitarrapc/gists{/gist_id}","starred_url":"https://api.github.com/users/guitarrapc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guitarrapc/subscriptions","organizations_url":"https://api.github.com/users/guitarrapc/orgs","repos_url":"https://api.github.com/users/guitarrapc/repos","events_url":"https://api.github.com/users/guitarrapc/events{/privacy}","received_events_url":"https://api.github.com/users/guitarrapc/received_events","type":"User","site_admin":false},"repo":{"id":27831575,"name":"DSCResources","full_name":"guitarrapc/DSCResources","owner":{"login":"guitarrapc","id":3856350,"avatar_url":"https://avatars.githubusercontent.com/u/3856350?v=3","gravatar_id":"","url":"https://api.github.com/users/guitarrapc","html_url":"https://github.com/guitarrapc","followers_url":"https://api.github.com/users/guitarrapc/followers","following_url":"https://api.github.com/users/guitarrapc/following{/other_user}","gists_url":"https://api.github.com/users/guitarrapc/gists{/gist_id}","starred_url":"https://api.github.com/users/guitarrapc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guitarrapc/subscriptions","organizations_url":"https://api.github.com/users/guitarrapc/orgs","repos_url":"https://api.github.com/users/guitarrapc/repos","events_url":"https://api.github.com/users/guitarrapc/events{/privacy}","received_events_url":"https://api.github.com/users/guitarrapc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guitarrapc/DSCResources","description":"PowerShell DSC Resources","fork":false,"url":"https://api.github.com/repos/guitarrapc/DSCResources","forks_url":"https://api.github.com/repos/guitarrapc/DSCResources/forks","keys_url":"https://api.github.com/repos/guitarrapc/DSCResources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guitarrapc/DSCResources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guitarrapc/DSCResources/teams","hooks_url":"https://api.github.com/repos/guitarrapc/DSCResources/hooks","issue_events_url":"https://api.github.com/repos/guitarrapc/DSCResources/issues/events{/number}","events_url":"https://api.github.com/repos/guitarrapc/DSCResources/events","assignees_url":"https://api.github.com/repos/guitarrapc/DSCResources/assignees{/user}","branches_url":"https://api.github.com/repos/guitarrapc/DSCResources/branches{/branch}","tags_url":"https://api.github.com/repos/guitarrapc/DSCResources/tags","blobs_url":"https://api.github.com/repos/guitarrapc/DSCResources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guitarrapc/DSCResources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guitarrapc/DSCResources/git/refs{/sha}","trees_url":"https://api.github.com/repos/guitarrapc/DSCResources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guitarrapc/DSCResources/statuses/{sha}","languages_url":"https://api.github.com/repos/guitarrapc/DSCResources/languages","stargazers_url":"https://api.github.com/repos/guitarrapc/DSCResources/stargazers","contributors_url":"https://api.github.com/repos/guitarrapc/DSCResources/contributors","subscribers_url":"https://api.github.com/repos/guitarrapc/DSCResources/subscribers","subscription_url":"https://api.github.com/repos/guitarrapc/DSCResources/subscription","commits_url":"https://api.github.com/repos/guitarrapc/DSCResources/commits{/sha}","git_commits_url":"https://api.github.com/repos/guitarrapc/DSCResources/git/commits{/sha}","comments_url":"https://api.github.com/repos/guitarrapc/DSCResources/comments{/number}","issue_comment_url":"https://api.github.com/repos/guitarrapc/DSCResources/issues/comments{/number}","contents_url":"https://api.github.com/repos/guitarrapc/DSCResources/contents/{+path}","compare_url":"https://api.github.com/repos/guitarrapc/DSCResources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guitarrapc/DSCResources/merges","archive_url":"https://api.github.com/repos/guitarrapc/DSCResources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guitarrapc/DSCResources/downloads","issues_url":"https://api.github.com/repos/guitarrapc/DSCResources/issues{/number}","pulls_url":"https://api.github.com/repos/guitarrapc/DSCResources/pulls{/number}","milestones_url":"https://api.github.com/repos/guitarrapc/DSCResources/milestones{/number}","notifications_url":"https://api.github.com/repos/guitarrapc/DSCResources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guitarrapc/DSCResources/labels{/name}","releases_url":"https://api.github.com/repos/guitarrapc/DSCResources/releases{/id}","created_at":"2014-12-10T17:39:22Z","updated_at":"2015-02-25T15:38:12Z","pushed_at":"2015-02-25T15:38:12Z","git_url":"git://github.com/guitarrapc/DSCResources.git","ssh_url":"git@github.com:guitarrapc/DSCResources.git","clone_url":"https://github.com/guitarrapc/DSCResources.git","svn_url":"https://github.com/guitarrapc/DSCResources","homepage":null,"size":2560,"stargazers_count":1,"watchers_count":1,"language":"PowerShell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":1,"default_branch":"master"}},"base":{"label":"guitarrapc:master","ref":"master","sha":"ddbb3dc2d8a903d5aaa6a7b627cc3e38e1586365","user":{"login":"guitarrapc","id":3856350,"avatar_url":"https://avatars.githubusercontent.com/u/3856350?v=3","gravatar_id":"","url":"https://api.github.com/users/guitarrapc","html_url":"https://github.com/guitarrapc","followers_url":"https://api.github.com/users/guitarrapc/followers","following_url":"https://api.github.com/users/guitarrapc/following{/other_user}","gists_url":"https://api.github.com/users/guitarrapc/gists{/gist_id}","starred_url":"https://api.github.com/users/guitarrapc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guitarrapc/subscriptions","organizations_url":"https://api.github.com/users/guitarrapc/orgs","repos_url":"https://api.github.com/users/guitarrapc/repos","events_url":"https://api.github.com/users/guitarrapc/events{/privacy}","received_events_url":"https://api.github.com/users/guitarrapc/received_events","type":"User","site_admin":false},"repo":{"id":27831575,"name":"DSCResources","full_name":"guitarrapc/DSCResources","owner":{"login":"guitarrapc","id":3856350,"avatar_url":"https://avatars.githubusercontent.com/u/3856350?v=3","gravatar_id":"","url":"https://api.github.com/users/guitarrapc","html_url":"https://github.com/guitarrapc","followers_url":"https://api.github.com/users/guitarrapc/followers","following_url":"https://api.github.com/users/guitarrapc/following{/other_user}","gists_url":"https://api.github.com/users/guitarrapc/gists{/gist_id}","starred_url":"https://api.github.com/users/guitarrapc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guitarrapc/subscriptions","organizations_url":"https://api.github.com/users/guitarrapc/orgs","repos_url":"https://api.github.com/users/guitarrapc/repos","events_url":"https://api.github.com/users/guitarrapc/events{/privacy}","received_events_url":"https://api.github.com/users/guitarrapc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guitarrapc/DSCResources","description":"PowerShell DSC Resources","fork":false,"url":"https://api.github.com/repos/guitarrapc/DSCResources","forks_url":"https://api.github.com/repos/guitarrapc/DSCResources/forks","keys_url":"https://api.github.com/repos/guitarrapc/DSCResources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guitarrapc/DSCResources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guitarrapc/DSCResources/teams","hooks_url":"https://api.github.com/repos/guitarrapc/DSCResources/hooks","issue_events_url":"https://api.github.com/repos/guitarrapc/DSCResources/issues/events{/number}","events_url":"https://api.github.com/repos/guitarrapc/DSCResources/events","assignees_url":"https://api.github.com/repos/guitarrapc/DSCResources/assignees{/user}","branches_url":"https://api.github.com/repos/guitarrapc/DSCResources/branches{/branch}","tags_url":"https://api.github.com/repos/guitarrapc/DSCResources/tags","blobs_url":"https://api.github.com/repos/guitarrapc/DSCResources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guitarrapc/DSCResources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guitarrapc/DSCResources/git/refs{/sha}","trees_url":"https://api.github.com/repos/guitarrapc/DSCResources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guitarrapc/DSCResources/statuses/{sha}","languages_url":"https://api.github.com/repos/guitarrapc/DSCResources/languages","stargazers_url":"https://api.github.com/repos/guitarrapc/DSCResources/stargazers","contributors_url":"https://api.github.com/repos/guitarrapc/DSCResources/contributors","subscribers_url":"https://api.github.com/repos/guitarrapc/DSCResources/subscribers","subscription_url":"https://api.github.com/repos/guitarrapc/DSCResources/subscription","commits_url":"https://api.github.com/repos/guitarrapc/DSCResources/commits{/sha}","git_commits_url":"https://api.github.com/repos/guitarrapc/DSCResources/git/commits{/sha}","comments_url":"https://api.github.com/repos/guitarrapc/DSCResources/comments{/number}","issue_comment_url":"https://api.github.com/repos/guitarrapc/DSCResources/issues/comments{/number}","contents_url":"https://api.github.com/repos/guitarrapc/DSCResources/contents/{+path}","compare_url":"https://api.github.com/repos/guitarrapc/DSCResources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guitarrapc/DSCResources/merges","archive_url":"https://api.github.com/repos/guitarrapc/DSCResources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guitarrapc/DSCResources/downloads","issues_url":"https://api.github.com/repos/guitarrapc/DSCResources/issues{/number}","pulls_url":"https://api.github.com/repos/guitarrapc/DSCResources/pulls{/number}","milestones_url":"https://api.github.com/repos/guitarrapc/DSCResources/milestones{/number}","notifications_url":"https://api.github.com/repos/guitarrapc/DSCResources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guitarrapc/DSCResources/labels{/name}","releases_url":"https://api.github.com/repos/guitarrapc/DSCResources/releases{/id}","created_at":"2014-12-10T17:39:22Z","updated_at":"2015-02-25T15:38:12Z","pushed_at":"2015-02-25T15:38:12Z","git_url":"git://github.com/guitarrapc/DSCResources.git","ssh_url":"git@github.com:guitarrapc/DSCResources.git","clone_url":"https://github.com/guitarrapc/DSCResources.git","svn_url":"https://github.com/guitarrapc/DSCResources","homepage":null,"size":2560,"stargazers_count":1,"watchers_count":1,"language":"PowerShell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guitarrapc/DSCResources/pulls/17"},"html":{"href":"https://github.com/guitarrapc/DSCResources/pull/17"},"issue":{"href":"https://api.github.com/repos/guitarrapc/DSCResources/issues/17"},"comments":{"href":"https://api.github.com/repos/guitarrapc/DSCResources/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/guitarrapc/DSCResources/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/guitarrapc/DSCResources/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guitarrapc/DSCResources/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/guitarrapc/DSCResources/statuses/ae0579d327e1efe2753700aa1b3a1072fc90bdb7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"guitarrapc","id":3856350,"avatar_url":"https://avatars.githubusercontent.com/u/3856350?v=3","gravatar_id":"","url":"https://api.github.com/users/guitarrapc","html_url":"https://github.com/guitarrapc","followers_url":"https://api.github.com/users/guitarrapc/followers","following_url":"https://api.github.com/users/guitarrapc/following{/other_user}","gists_url":"https://api.github.com/users/guitarrapc/gists{/gist_id}","starred_url":"https://api.github.com/users/guitarrapc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guitarrapc/subscriptions","organizations_url":"https://api.github.com/users/guitarrapc/orgs","repos_url":"https://api.github.com/users/guitarrapc/repos","events_url":"https://api.github.com/users/guitarrapc/events{/privacy}","received_events_url":"https://api.github.com/users/guitarrapc/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":5,"additions":824,"deletions":0,"changed_files":18}}