{"action":"created","issue":{"url":"https://api.github.com/repos/tavendo/AutobahnPython/issues/331","labels_url":"https://api.github.com/repos/tavendo/AutobahnPython/issues/331/labels{/name}","comments_url":"https://api.github.com/repos/tavendo/AutobahnPython/issues/331/comments","events_url":"https://api.github.com/repos/tavendo/AutobahnPython/issues/331/events","html_url":"https://github.com/tavendo/AutobahnPython/issues/331","id":56953208,"number":331,"title":"pep8, pylint, pyflakes compliance","user":{"login":"tardyp","id":109859,"avatar_url":"https://avatars.githubusercontent.com/u/109859?v=3","gravatar_id":"","url":"https://api.github.com/users/tardyp","html_url":"https://github.com/tardyp","followers_url":"https://api.github.com/users/tardyp/followers","following_url":"https://api.github.com/users/tardyp/following{/other_user}","gists_url":"https://api.github.com/users/tardyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tardyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tardyp/subscriptions","organizations_url":"https://api.github.com/users/tardyp/orgs","repos_url":"https://api.github.com/users/tardyp/repos","events_url":"https://api.github.com/users/tardyp/events{/privacy}","received_events_url":"https://api.github.com/users/tardyp/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/tavendo/AutobahnPython/labels/enhancement","name":"enhancement","color":"33CCFF"},{"url":"https://api.github.com/repos/tavendo/AutobahnPython/labels/needs-discussion","name":"needs-discussion","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-02-08T14:27:25Z","updated_at":"2015-02-09T18:00:45Z","closed_at":null,"body":"In buildbot we made gigantic progress in code cooperation quality after we ran autopep8 on the whole code.\r\n\r\nI would highly suggest that autobahn is at least complying to the pep8 standard.\r\n\r\nmain offenders of your coding style are:\r\n*  3 spaces indents\r\n*  double # comments\r\nThis makes it painful to contribute, as I have to change my editor to disable on the fly pep8, pylint, etc\r\n\r\nI would gladly propose a PR, but that would put me in the blame for every line of code of this, and clearly tobias mostly deserve the credit for them.\r\n\r\nInstead I just contribute the recipe to let python do it for you.\r\n```\r\npip install autopep8\r\nautopep8 -ri .\r\ngit diff --stat\r\n autobahn/autobahn/__init__.py                      |   36 +-\r\n autobahn/autobahn/asyncio/__init__.py              |   34 +-\r\n autobahn/autobahn/asyncio/wamp.py                  |  313 +-\r\n autobahn/autobahn/asyncio/websocket.py             |  559 +-\r\n autobahn/autobahn/twisted/__init__.py              |   34 +-\r\n autobahn/autobahn/twisted/choosereactor.py         |  281 +-\r\n autobahn/autobahn/twisted/flashpolicy.py           |  216 +-\r\n autobahn/autobahn/twisted/forwarder.py             |  153 +-\r\n autobahn/autobahn/twisted/longpoll.py              | 1159 ++-\r\n autobahn/autobahn/twisted/rawsocket.py             |  322 +-\r\n autobahn/autobahn/twisted/resource.py              |  275 +-\r\n autobahn/autobahn/twisted/util.py                  |   96 +-\r\n autobahn/autobahn/twisted/wamp.py                  |  879 +-\r\n autobahn/autobahn/twisted/websocket.py             | 1056 ++-\r\n autobahn/autobahn/util.py                          |  587 +-\r\n autobahn/autobahn/wamp/__init__.py                 |   94 +-\r\n autobahn/autobahn/wamp/auth.py                     |  382 +-\r\n autobahn/autobahn/wamp/exception.py                |  243 +-\r\n autobahn/autobahn/wamp/interfaces.py               |  969 ++-\r\n autobahn/autobahn/wamp/message.py                  | 4746 +++++------\r\n autobahn/autobahn/wamp/protocol.py                 | 1893 ++---\r\n autobahn/autobahn/wamp/role.py                     |  258 +-\r\n autobahn/autobahn/wamp/serializer.py               |  510 +-\r\n autobahn/autobahn/wamp/test/__init__.py            |   34 +-\r\n autobahn/autobahn/wamp/test/test_auth.py           |  222 +-\r\n autobahn/autobahn/wamp/test/test_component.py      |  329 +-\r\n autobahn/autobahn/wamp/test/test_message.py        | 1881 +++--\r\n autobahn/autobahn/wamp/test/test_protocol.py       |  474 +-\r\n autobahn/autobahn/wamp/test/test_protocol_peer.py  |  190 +-\r\n autobahn/autobahn/wamp/test/test_serializer.py     |  212 +-\r\n autobahn/autobahn/wamp/test/test_uri_pattern.py    |  910 +--\r\n autobahn/autobahn/wamp/types.py                    |  793 +-\r\n autobahn/autobahn/wamp/uri.py                      |  357 +-\r\n autobahn/autobahn/wamp/websocket.py                |  474 +-\r\n autobahn/autobahn/websocket/__init__.py            |   34 +-\r\n autobahn/autobahn/websocket/compress.py            |  154 +-\r\n autobahn/autobahn/websocket/compress_base.py       |   75 +-\r\n autobahn/autobahn/websocket/compress_bzip2.py      |  788 +-\r\n autobahn/autobahn/websocket/compress_deflate.py    | 1167 +--\r\n autobahn/autobahn/websocket/compress_snappy.py     |  739 +-\r\n autobahn/autobahn/websocket/http.py                |  448 +-\r\n autobahn/autobahn/websocket/interfaces.py          |  638 +-\r\n autobahn/autobahn/websocket/protocol.py            | 8466 ++++++++++----------\r\n autobahn/autobahn/websocket/test/__init__.py       |   34 +-\r\n .../autobahn/websocket/test/test_websocket_url.py  |  185 +-\r\n autobahn/autobahn/websocket/useragent.py           |  444 +-\r\n autobahn/autobahn/websocket/utf8validator.py       |  403 +-\r\n autobahn/autobahn/websocket/xormasker.py           |  231 +-\r\n autobahn/setup.py                                  |  235 +-\r\n autobahn/twisted/plugins/autobahn_endpoints.py     |  226 +-\r\n autobahn/twisted/plugins/autobahn_twistd.py        |   34 +-\r\n 51 files changed, 17661 insertions(+), 17611 deletions(-)\r\n```"},"comment":{"url":"https://api.github.com/repos/tavendo/AutobahnPython/issues/comments/73556916","html_url":"https://github.com/tavendo/AutobahnPython/issues/331#issuecomment-73556916","issue_url":"https://api.github.com/repos/tavendo/AutobahnPython/issues/331","id":73556916,"user":{"login":"tardyp","id":109859,"avatar_url":"https://avatars.githubusercontent.com/u/109859?v=3","gravatar_id":"","url":"https://api.github.com/users/tardyp","html_url":"https://github.com/tardyp","followers_url":"https://api.github.com/users/tardyp/followers","following_url":"https://api.github.com/users/tardyp/following{/other_user}","gists_url":"https://api.github.com/users/tardyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tardyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tardyp/subscriptions","organizations_url":"https://api.github.com/users/tardyp/orgs","repos_url":"https://api.github.com/users/tardyp/repos","events_url":"https://api.github.com/users/tardyp/events{/privacy}","received_events_url":"https://api.github.com/users/tardyp/received_events","type":"User","site_admin":false},"created_at":"2015-02-09T18:00:45Z","updated_at":"2015-02-09T18:00:45Z","body":"Yes, of course, the point of autopep8 is to not change semantics.\r\n\r\nWhen I did the run for buildbot, I had to remove some of the checks because it did stuff not compatible with python 2.5 that we supported at that time. But that should not be a problem for you.\r\n\r\nThe thing also is that buildbot has a very good test coverage, this helps to have confidence..\r\n"}}