{"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/27044335","id":27044335,"diff_hunk":"@@ -0,0 +1,124 @@\n+package org.infinispan.commons.configuration.attributes;\n+\n+import org.infinispan.commons.CacheConfigurationException;\n+\n+/**\n+ *\n+ * AttributeDefinition. Defines the characteristics of a configuration attribute. It is used to construct an actual {@link Attribute} holder.\n+ *\n+ * An attribute definition has the following characteristics:\n+ * <ul>\n+ * <li>A name</li>\n+ * <li>A default value or a value initializer</li>\n+ * <li>A type, which needs to be specified if it cannot be inferred from the default value, i.e. when it is null</li>\n+ * <li>Whether an attribute is immutable or not, i.e. whether its value is constant after initialization or it can be changed</li>\n+ * <li>A validator which intercepts invalid values</li>\n+ * </ul>\n+ *\n+ * @author Tristan Tarrant\n+ * @since 7.2\n+ */\n+public final class AttributeDefinition<T> implements Cloneable {\n+   private final String name;\n+   private final T defaultValue;\n+   private boolean immutable;","path":"commons/src/main/java/org/infinispan/commons/configuration/attributes/AttributeDefinition.java","position":24,"original_position":24,"commit_id":"15aec33bd5e4ffd125f23f5bdcc36e3b4b4024cb","original_commit_id":"15aec33bd5e4ffd125f23f5bdcc36e3b4b4024cb","user":{"login":"wburns","id":648175,"avatar_url":"https://avatars.githubusercontent.com/u/648175?v=3","gravatar_id":"","url":"https://api.github.com/users/wburns","html_url":"https://github.com/wburns","followers_url":"https://api.github.com/users/wburns/followers","following_url":"https://api.github.com/users/wburns/following{/other_user}","gists_url":"https://api.github.com/users/wburns/gists{/gist_id}","starred_url":"https://api.github.com/users/wburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wburns/subscriptions","organizations_url":"https://api.github.com/users/wburns/orgs","repos_url":"https://api.github.com/users/wburns/repos","events_url":"https://api.github.com/users/wburns/events{/privacy}","received_events_url":"https://api.github.com/users/wburns/received_events","type":"User","site_admin":false},"body":"This can be final.","created_at":"2015-03-24T16:17:22Z","updated_at":"2015-03-24T16:17:22Z","html_url":"https://github.com/infinispan/infinispan/pull/3319#discussion_r27044335","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3319","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/27044335"},"html":{"href":"https://github.com/infinispan/infinispan/pull/3319#discussion_r27044335"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3319"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/3319","id":31432488,"html_url":"https://github.com/infinispan/infinispan/pull/3319","diff_url":"https://github.com/infinispan/infinispan/pull/3319.diff","patch_url":"https://github.com/infinispan/infinispan/pull/3319.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/3319","number":3319,"state":"open","locked":false,"title":"ISPN-5243 Configuration Value wrappers","user":{"login":"tristantarrant","id":392478,"avatar_url":"https://avatars.githubusercontent.com/u/392478?v=3","gravatar_id":"","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User","site_admin":false},"body":"https://issues.jboss.org/browse/ISPN-5243\r\n\r\n- Create \"AttributeDefinitions\" which describe what configuration attributes look like (name, default value, type, mutable). These defs are \"public\" so that they can be consumed by others (e.g. Infinispan subsystem in server)\r\n- Attributes are created from definitions and can be either protected (immutable) or unprotected. Also listeners can be attached to react to changes.\r\n- Group Attributes into AttributeSets to manage them together\r\n\r\nThis feature allows partial configuration overlays and is a stepping stone towards proper template support.","created_at":"2015-03-18T14:17:38Z","updated_at":"2015-03-24T16:17:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0ac8c584bd6d3a52a8943ce10b2874f426c16bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3319/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3319/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/3319/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/15aec33bd5e4ffd125f23f5bdcc36e3b4b4024cb","head":{"label":"tristantarrant:ISPN-5243/configuration_attribute_holders","ref":"ISPN-5243/configuration_attribute_holders","sha":"15aec33bd5e4ffd125f23f5bdcc36e3b4b4024cb","user":{"login":"tristantarrant","id":392478,"avatar_url":"https://avatars.githubusercontent.com/u/392478?v=3","gravatar_id":"","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User","site_admin":false},"repo":{"id":2035565,"name":"infinispan","full_name":"tristantarrant/infinispan","owner":{"login":"tristantarrant","id":392478,"avatar_url":"https://avatars.githubusercontent.com/u/392478?v=3","gravatar_id":"","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tristantarrant/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/tristantarrant/infinispan","forks_url":"https://api.github.com/repos/tristantarrant/infinispan/forks","keys_url":"https://api.github.com/repos/tristantarrant/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tristantarrant/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tristantarrant/infinispan/teams","hooks_url":"https://api.github.com/repos/tristantarrant/infinispan/hooks","issue_events_url":"https://api.github.com/repos/tristantarrant/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/tristantarrant/infinispan/events","assignees_url":"https://api.github.com/repos/tristantarrant/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/tristantarrant/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/tristantarrant/infinispan/tags","blobs_url":"https://api.github.com/repos/tristantarrant/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tristantarrant/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tristantarrant/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/tristantarrant/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tristantarrant/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/tristantarrant/infinispan/languages","stargazers_url":"https://api.github.com/repos/tristantarrant/infinispan/stargazers","contributors_url":"https://api.github.com/repos/tristantarrant/infinispan/contributors","subscribers_url":"https://api.github.com/repos/tristantarrant/infinispan/subscribers","subscription_url":"https://api.github.com/repos/tristantarrant/infinispan/subscription","commits_url":"https://api.github.com/repos/tristantarrant/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/tristantarrant/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/tristantarrant/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/tristantarrant/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/tristantarrant/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/tristantarrant/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tristantarrant/infinispan/merges","archive_url":"https://api.github.com/repos/tristantarrant/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tristantarrant/infinispan/downloads","issues_url":"https://api.github.com/repos/tristantarrant/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/tristantarrant/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/tristantarrant/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/tristantarrant/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tristantarrant/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/tristantarrant/infinispan/releases{/id}","created_at":"2011-07-12T10:59:18Z","updated_at":"2014-06-25T09:10:17Z","pushed_at":"2015-03-18T14:06:00Z","git_url":"git://github.com/tristantarrant/infinispan.git","ssh_url":"git@github.com:tristantarrant/infinispan.git","clone_url":"https://github.com/tristantarrant/infinispan.git","svn_url":"https://github.com/tristantarrant/infinispan","homepage":"http://www.infinispan.org","size":64926,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"5a9132ec9a5c066253cddfd09c59e2c06c129e4c","user":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"name":"infinispan","full_name":"infinispan/infinispan","owner":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","created_at":"2010-11-04T12:33:19Z","updated_at":"2015-03-24T14:44:25Z","pushed_at":"2015-03-24T15:10:51Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"git@github.com:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":139997,"stargazers_count":367,"watchers_count":367,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":278,"mirror_url":null,"open_issues_count":15,"forks":278,"open_issues":15,"watchers":367,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3319"},"html":{"href":"https://github.com/infinispan/infinispan/pull/3319"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/3319"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/3319/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3319/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3319/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/15aec33bd5e4ffd125f23f5bdcc36e3b4b4024cb"}}}}