{"action":"created","issue":{"url":"https://api.github.com/repos/globaleaks/Tor2web/issues/254","labels_url":"https://api.github.com/repos/globaleaks/Tor2web/issues/254/labels{/name}","comments_url":"https://api.github.com/repos/globaleaks/Tor2web/issues/254/comments","events_url":"https://api.github.com/repos/globaleaks/Tor2web/issues/254/events","html_url":"https://github.com/globaleaks/Tor2web/issues/254","id":103072837,"number":254,"title":"Replace header \"X-Forwarded-For\" to standard header \"Forwarded\"","user":{"login":"virgil","id":81322,"avatar_url":"https://avatars.githubusercontent.com/u/81322?v=3","gravatar_id":"","url":"https://api.github.com/users/virgil","html_url":"https://github.com/virgil","followers_url":"https://api.github.com/users/virgil/followers","following_url":"https://api.github.com/users/virgil/following{/other_user}","gists_url":"https://api.github.com/users/virgil/gists{/gist_id}","starred_url":"https://api.github.com/users/virgil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virgil/subscriptions","organizations_url":"https://api.github.com/users/virgil/orgs","repos_url":"https://api.github.com/users/virgil/repos","events_url":"https://api.github.com/users/virgil/events{/privacy}","received_events_url":"https://api.github.com/users/virgil/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-25T17:03:54Z","updated_at":"2015-08-25T19:02:16Z","closed_at":null,"body":"See: https://en.wikipedia.org/wiki/X-Forwarded-For#.22Forwarded.22_Header\r\n\r\n<bountysource-plugin>\r\n---\r\nWant to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26167667-replace-header-x-forwarded-for-to-standard-header-forwarded?utm_campaign=plugin&utm_content=tracker%2F318575&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F318575&utm_medium=issues&utm_source=github).\r\n</bountysource-plugin>"},"comment":{"url":"https://api.github.com/repos/globaleaks/Tor2web/issues/comments/134702857","html_url":"https://github.com/globaleaks/Tor2web/issues/254#issuecomment-134702857","issue_url":"https://api.github.com/repos/globaleaks/Tor2web/issues/254","id":134702857,"user":{"login":"evilaliv3","id":217034,"avatar_url":"https://avatars.githubusercontent.com/u/217034?v=3","gravatar_id":"","url":"https://api.github.com/users/evilaliv3","html_url":"https://github.com/evilaliv3","followers_url":"https://api.github.com/users/evilaliv3/followers","following_url":"https://api.github.com/users/evilaliv3/following{/other_user}","gists_url":"https://api.github.com/users/evilaliv3/gists{/gist_id}","starred_url":"https://api.github.com/users/evilaliv3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilaliv3/subscriptions","organizations_url":"https://api.github.com/users/evilaliv3/orgs","repos_url":"https://api.github.com/users/evilaliv3/repos","events_url":"https://api.github.com/users/evilaliv3/events{/privacy}","received_events_url":"https://api.github.com/users/evilaliv3/received_events","type":"User","site_admin":false},"created_at":"2015-08-25T19:02:16Z","updated_at":"2015-08-25T19:02:16Z","body":"@virgil i do not think it will be a good idea to REPLACE, but we will simply \"EVALUATE BOT\".\r\n\r\nlet me clarify why and how we are using the x-forwarded-for as it is used in various ways and for varios reasons:\r\n1) tor2web makes use of the x-forwarded-for to recognize the user ip and detect if the user is coming from Tor\r\n2) tor2web deletes the x-forwarded-for header from the request in order to remove the ip of the admin; to be keep in mind that this can break some apps but it's important for us to try to protect the privacy of the user.\r\n\r\nin relation to both 1) and 2) we should evaluate the implementation of the new \"Forward\" header checks and eventually decide the priority order for 1) among the de facto standard and the new standard.\r\n\r\ni'm wondering if in relation to the privacy concern (point 2) we should always stript the ip removal by at least replacing always the ip address that we recognize for the user with \"\" in every header/upstream content; what do you think @fpietrosanti / @vecna / @hellais in relation to the globaleaks project?"}}