{"action":"created","issue":{"url":"https://api.github.com/repos/klokantech/iiifviewer/issues/8","labels_url":"https://api.github.com/repos/klokantech/iiifviewer/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/klokantech/iiifviewer/issues/8/comments","events_url":"https://api.github.com/repos/klokantech/iiifviewer/issues/8/events","html_url":"https://github.com/klokantech/iiifviewer/issues/8","id":57969771,"number":8,"title":"PDF print auto size","user":{"login":"klokan","id":59284,"avatar_url":"https://avatars.githubusercontent.com/u/59284?v=3","gravatar_id":"","url":"https://api.github.com/users/klokan","html_url":"https://github.com/klokan","followers_url":"https://api.github.com/users/klokan/followers","following_url":"https://api.github.com/users/klokan/following{/other_user}","gists_url":"https://api.github.com/users/klokan/gists{/gist_id}","starred_url":"https://api.github.com/users/klokan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klokan/subscriptions","organizations_url":"https://api.github.com/users/klokan/orgs","repos_url":"https://api.github.com/users/klokan/repos","events_url":"https://api.github.com/users/klokan/events{/privacy}","received_events_url":"https://api.github.com/users/klokan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/klokantech/iiifviewer/labels/@nls","name":"@nls","color":"bfdadc"},{"url":"https://api.github.com/repos/klokantech/iiifviewer/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/klokantech/iiifviewer/labels/URGENT","name":"URGENT","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"daliborjanak","id":1891090,"avatar_url":"https://avatars.githubusercontent.com/u/1891090?v=3","gravatar_id":"","url":"https://api.github.com/users/daliborjanak","html_url":"https://github.com/daliborjanak","followers_url":"https://api.github.com/users/daliborjanak/followers","following_url":"https://api.github.com/users/daliborjanak/following{/other_user}","gists_url":"https://api.github.com/users/daliborjanak/gists{/gist_id}","starred_url":"https://api.github.com/users/daliborjanak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daliborjanak/subscriptions","organizations_url":"https://api.github.com/users/daliborjanak/orgs","repos_url":"https://api.github.com/users/daliborjanak/repos","events_url":"https://api.github.com/users/daliborjanak/events{/privacy}","received_events_url":"https://api.github.com/users/daliborjanak/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-02-17T19:28:38Z","updated_at":"2015-02-18T13:48:56Z","closed_at":null,"body":"The PDF print to \"auto\" should use the size of the canvas element, not of the page.\r\nRight now it seems to be using the size of page which is wrong.\r\n\r\nIt runs fine for the demo at http://klokantech.github.io/iiifviewer/examples/print.html, because there the canvas has a size of the page, but otherwise it is wrong.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/klokantech/iiifviewer/issues/comments/74866007","html_url":"https://github.com/klokantech/iiifviewer/issues/8#issuecomment-74866007","issue_url":"https://api.github.com/repos/klokantech/iiifviewer/issues/8","id":74866007,"user":{"login":"clientportal","id":7993530,"avatar_url":"https://avatars.githubusercontent.com/u/7993530?v=3","gravatar_id":"","url":"https://api.github.com/users/clientportal","html_url":"https://github.com/clientportal","followers_url":"https://api.github.com/users/clientportal/followers","following_url":"https://api.github.com/users/clientportal/following{/other_user}","gists_url":"https://api.github.com/users/clientportal/gists{/gist_id}","starred_url":"https://api.github.com/users/clientportal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clientportal/subscriptions","organizations_url":"https://api.github.com/users/clientportal/orgs","repos_url":"https://api.github.com/users/clientportal/repos","events_url":"https://api.github.com/users/clientportal/events{/privacy}","received_events_url":"https://api.github.com/users/clientportal/received_events","type":"User","site_admin":false},"created_at":"2015-02-18T13:48:56Z","updated_at":"2015-02-18T13:48:56Z","body":"FROM:C.Fleet@nls.uk\nDalibor,\r\n\r\nI'm extremely grateful for this further work, which is even better functionality than expected for the PDF output! We now have the best of both worlds - a logo and text, but a way of filling the page with the map too by altering the aspect ratio - perfect, thankyou! \r\n\r\nI have implemented this in NLS at: http://geo.nls.uk/maps/dev/iiifviewer/index.html \r\n\r\nI hate saying there is something else... but now our Web Administrator, Tony Stuart, does not like the use of the inline <style> CSS, ie. this section\r\n\r\n<style>\r\n\r\n      .ol-overviewmap {\r\n        position: absolute;\r\n        right: 0;\r\n        bottom: 0;\r\n        background-color: #fff;\r\n      }\r\n      .ol-overviewmap .ol-overviewmap-map {\r\n        height: 150px;\r\n        margin: 2px;\r\n        width: 150px;\r\n        display: inline-block;\r\n      }\r\n      .ol-overviewmap-box {border: 1px solid #ee0000;}\r\n      .ol-overviewmap button{display: none;}\r\n      .ol-zoom button{display:block;margin:1px;padding:0;color:#fff;font-size:20px;font-weight:700;text-decoration:none;text-align:center;height:1.375em;width:1.375em;line-height:.4em;background-color:#7b98bc;background-color:#003;border:none;}\r\n      .ol-zoom button:hover{cursor: pointer;}\r\n      .ol-zoom{position:absolute;}\r\n      .ol-zoom{position: absolute; top: 100px; left:0;}\r\n      .browseralert{position: absolute; top: 125px; left: 10px; display: block;}\r\n\r\n</style>\r\n\r\nWhen we move this to a separate CSS, the printing still works fine in Chrome and FF, but not in IE. Tony has asked me to ask you about this, as he says using inline CSS is bad practice, it doesn't cache and is best avoided.\r\n\r\nIf you think nothing can be done very easily, please just say so and I will tell him. But he is not keen to implement the <style> within the HTML if possible."}}