{"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/36768296","id":36768296,"diff_hunk":"@@ -1076,34 +1078,82 @@ std::string item::info(bool showtext, std::vector<iteminfo> &dump_ref) const\n         it_tool* tool = dynamic_cast<it_tool*>(type);\n \n         if ((tool->max_charges)!=0) {\n-            std::string charges_line = _(\"Charges\"); //;\n+            int t_max;\n+            const std::string t_ammo_name = _(ammo_name(tool->ammo_id).c_str());","path":"src/item.cpp","position":26,"original_position":26,"commit_id":"385b772e3db0aeba2edb3d915b597a68b807c2af","original_commit_id":"385b772e3db0aeba2edb3d915b597a68b807c2af","user":{"login":"BevapDin","id":5095435,"avatar_url":"https://avatars.githubusercontent.com/u/5095435?v=3","gravatar_id":"","url":"https://api.github.com/users/BevapDin","html_url":"https://github.com/BevapDin","followers_url":"https://api.github.com/users/BevapDin/followers","following_url":"https://api.github.com/users/BevapDin/following{/other_user}","gists_url":"https://api.github.com/users/BevapDin/gists{/gist_id}","starred_url":"https://api.github.com/users/BevapDin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BevapDin/subscriptions","organizations_url":"https://api.github.com/users/BevapDin/orgs","repos_url":"https://api.github.com/users/BevapDin/repos","events_url":"https://api.github.com/users/BevapDin/events{/privacy}","received_events_url":"https://api.github.com/users/BevapDin/received_events","type":"User","site_admin":false},"body":"`ammo_name` should probably do the translation. I see at least 3 further calls to it where the result is not translated:\r\n\r\nsrc/game.cpp:\r\n```C++\r\nadd_msg(m_info, _(\"Out of %s!\"), ammo_name(tool->ammo_id).c_str());\r\n```\r\n\r\nsrc/npctalk.cpp:\r\n```C++\r\nphrase.replace(fa, l, ammo_name(me->weapon.ammo_type()) );\r\n```\r\n\r\nsrc/player.cpp:\r\n```C++\r\nadd_msg(m_info, _(\"That %s cannot be used on a %s.\"), used->tname().c_str(),\r\n                       ammo_name(guntype->ammo).c_str());\r\n```\r\n\r\nThat would also be kind of consistent with how `item::tname`, `monster::name`, etc. return a translated name.\r\n","created_at":"2015-08-11T16:49:47Z","updated_at":"2015-08-11T16:49:47Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13247#discussion_r36768296","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13247","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/36768296"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13247#discussion_r36768296"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13247"}}},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13247","id":42138064,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13247","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13247.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13247.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/13247","number":13247,"state":"open","locked":false,"title":"Translations bugfix and update","user":{"login":"VlasovVitaly","id":5244047,"avatar_url":"https://avatars.githubusercontent.com/u/5244047?v=3","gravatar_id":"","url":"https://api.github.com/users/VlasovVitaly","html_url":"https://github.com/VlasovVitaly","followers_url":"https://api.github.com/users/VlasovVitaly/followers","following_url":"https://api.github.com/users/VlasovVitaly/following{/other_user}","gists_url":"https://api.github.com/users/VlasovVitaly/gists{/gist_id}","starred_url":"https://api.github.com/users/VlasovVitaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VlasovVitaly/subscriptions","organizations_url":"https://api.github.com/users/VlasovVitaly/orgs","repos_url":"https://api.github.com/users/VlasovVitaly/repos","events_url":"https://api.github.com/users/VlasovVitaly/events{/privacy}","received_events_url":"https://api.github.com/users/VlasovVitaly/received_events","type":"User","site_admin":false},"body":"Bug fixed\r\n![u4eelfd](https://cloud.githubusercontent.com/assets/5244047/9200677/a81ceb22-4051-11e5-94b4-de852e319b03.png)\r\nAmmunition type was not translated.\r\n\r\nImproved code readability in this piece of file.\r\n\r\nAdded lots of helping comments for translators.","created_at":"2015-08-11T14:53:34Z","updated_at":"2015-08-11T16:49:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d4df78af7099697215d906122e5bc81a88ef872","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13247/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13247/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/13247/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/385b772e3db0aeba2edb3d915b597a68b807c2af","head":{"label":"VlasovVitaly:trans-bugfix-update","ref":"trans-bugfix-update","sha":"385b772e3db0aeba2edb3d915b597a68b807c2af","user":{"login":"VlasovVitaly","id":5244047,"avatar_url":"https://avatars.githubusercontent.com/u/5244047?v=3","gravatar_id":"","url":"https://api.github.com/users/VlasovVitaly","html_url":"https://github.com/VlasovVitaly","followers_url":"https://api.github.com/users/VlasovVitaly/followers","following_url":"https://api.github.com/users/VlasovVitaly/following{/other_user}","gists_url":"https://api.github.com/users/VlasovVitaly/gists{/gist_id}","starred_url":"https://api.github.com/users/VlasovVitaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VlasovVitaly/subscriptions","organizations_url":"https://api.github.com/users/VlasovVitaly/orgs","repos_url":"https://api.github.com/users/VlasovVitaly/repos","events_url":"https://api.github.com/users/VlasovVitaly/events{/privacy}","received_events_url":"https://api.github.com/users/VlasovVitaly/received_events","type":"User","site_admin":false},"repo":{"id":13641442,"name":"Cataclysm-DDA","full_name":"VlasovVitaly/Cataclysm-DDA","owner":{"login":"VlasovVitaly","id":5244047,"avatar_url":"https://avatars.githubusercontent.com/u/5244047?v=3","gravatar_id":"","url":"https://api.github.com/users/VlasovVitaly","html_url":"https://github.com/VlasovVitaly","followers_url":"https://api.github.com/users/VlasovVitaly/followers","following_url":"https://api.github.com/users/VlasovVitaly/following{/other_user}","gists_url":"https://api.github.com/users/VlasovVitaly/gists{/gist_id}","starred_url":"https://api.github.com/users/VlasovVitaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VlasovVitaly/subscriptions","organizations_url":"https://api.github.com/users/VlasovVitaly/orgs","repos_url":"https://api.github.com/users/VlasovVitaly/repos","events_url":"https://api.github.com/users/VlasovVitaly/events{/privacy}","received_events_url":"https://api.github.com/users/VlasovVitaly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VlasovVitaly/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA","forks_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/VlasovVitaly/Cataclysm-DDA/releases{/id}","created_at":"2013-10-17T06:59:22Z","updated_at":"2015-04-27T07:58:50Z","pushed_at":"2015-08-11T14:49:51Z","git_url":"git://github.com/VlasovVitaly/Cataclysm-DDA.git","ssh_url":"git@github.com:VlasovVitaly/Cataclysm-DDA.git","clone_url":"https://github.com/VlasovVitaly/Cataclysm-DDA.git","svn_url":"https://github.com/VlasovVitaly/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":493540,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"815df2b41ee7b26e6366fb35dccd00c673f14282","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","created_at":"2012-09-26T22:57:43Z","updated_at":"2015-08-08T22:16:19Z","pushed_at":"2015-08-11T14:53:35Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":788584,"stargazers_count":716,"watchers_count":716,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":749,"mirror_url":null,"open_issues_count":1043,"forks":749,"open_issues":1043,"watchers":716,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13247"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13247"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/13247"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/13247/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13247/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13247/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/385b772e3db0aeba2edb3d915b597a68b807c2af"}}}}