{"action":"created","comment":{"url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments/28903769","id":28903769,"diff_hunk":"@@ -441,3 +480,147 @@ Test(cq_msg, multi_read)\n \tfor (size_t j = 0; j < count; j++)\n \t\tassert_eq(entry[j].flags, (uint64_t) j);\n }\n+\n+TestSuite(cq_wait_obj, .fini = cq_teardown);\n+TestSuite(cq_wait_control, .fini = cq_teardown);\n+TestSuite(cq_wait_ops, .fini = cq_teardown);\n+\n+Test(cq_wait_obj, none, .init = cq_wait_none_setup)\n+{\n+\texpect(!wait_priv, \"wait_priv is not null.\");\n+}\n+\n+Test(cq_wait_obj, unspec, .init = cq_wait_unspec_setup)\n+{\n+\texpect_eq(wait_priv->type, FI_WAIT_FD);\n+\texpect_eq(wait_priv->type, cq_priv->attr.wait_obj);\n+\texpect_eq(wait_priv->type, cq_attr.wait_obj);\n+\texpect_eq(&wait_priv->fabric->fab_fid, fab);\n+\texpect_eq(wait_priv->cond_type, FI_CQ_COND_NONE);\n+}\n+\n+Test(cq_wait_obj, fd, .init = cq_wait_fd_setup)\n+{\n+\texpect_eq(wait_priv->type, FI_WAIT_FD);\n+\texpect_eq(wait_priv->type, cq_priv->attr.wait_obj);\n+\texpect_eq(wait_priv->type, cq_attr.wait_obj);\n+\texpect_eq(&wait_priv->fabric->fab_fid, fab);\n+\texpect_eq(wait_priv->cond_type, FI_CQ_COND_NONE);\n+}\n+\n+Test(cq_wait_obj, mutex_cond, .init = cq_wait_mutex_cond_setup)\n+{\n+\texpect_eq(wait_priv->type, FI_WAIT_MUTEX_COND);\n+\texpect_eq(wait_priv->type, cq_priv->attr.wait_obj);\n+\texpect_eq(wait_priv->type, cq_attr.wait_obj);\n+\texpect_eq(&wait_priv->fabric->fab_fid, fab);\n+\texpect_eq(wait_priv->cond_type, FI_CQ_COND_NONE);\n+}\n+\n+Test(cq_wait_control, none, .init = cq_wait_none_setup)\n+{\n+\tint ret;\n+\tint fd;\n+\n+\tret = fi_control(&cq_priv->cq_fid.fid, FI_GETWAIT, &fd);\n+\texpect_eq(-FI_ENOSYS, ret, \"fi_control exists for none.\");\n+}\n+\n+Test(cq_wait_control, unspec, .init = cq_wait_unspec_setup)\n+{\n+\tint ret;\n+\tint fd;\n+\n+\tret = fi_control(&cq_priv->cq_fid.fid, FI_GETWAIT, &fd);\n+\texpect_eq(FI_SUCCESS, ret, \"fi_control failed.\");\n+\n+\texpect_eq(wait_priv->fd[WAIT_READ], fd);\n+}\n+\n+Test(cq_wait_control, fd, .init = cq_wait_fd_setup)\n+{\n+\tint ret;\n+\tint fd;\n+\n+\tret = fi_control(&cq_priv->cq_fid.fid, FI_GETWAIT, &fd);\n+\texpect_eq(FI_SUCCESS, ret, \"fi_control failed.\");\n+\n+\texpect_eq(wait_priv->fd[WAIT_READ], fd);\n+}\n+\n+Test(cq_wait_control, mutex_cond, .init = cq_wait_mutex_cond_setup)\n+{\n+\tint ret;\n+\tstruct fi_mutex_cond mutex_cond;\n+\n+\tret = fi_control(&cq_priv->cq_fid.fid, FI_GETWAIT, &mutex_cond);\n+\texpect_eq(FI_SUCCESS, ret, \"fi_control failed.\");\n+\n+\tret = memcmp(&wait_priv->mutex, mutex_cond.mutex,\n+\t\t     sizeof(*mutex_cond.mutex));\n+\texpect_eq(0, ret, \"mutex compare failed.\");\n+\n+\tret = memcmp(&wait_priv->cond, mutex_cond.cond,\n+\t\t     sizeof(*mutex_cond.cond));\n+\texpect_eq(0, ret, \"cond compare failed.\");\n+}\n+\n+Test(cq_wait_ops, none, cq_wait_none_setup)","path":"prov/gni/test/cq.c","position":192,"original_position":192,"commit_id":"0efef94dd348dbc50e1cca8f6b20346ec12a8a90","original_commit_id":"0efef94dd348dbc50e1cca8f6b20346ec12a8a90","user":{"login":"hppritcha","id":7818666,"avatar_url":"https://avatars.githubusercontent.com/u/7818666?v=3","gravatar_id":"","url":"https://api.github.com/users/hppritcha","html_url":"https://github.com/hppritcha","followers_url":"https://api.github.com/users/hppritcha/followers","following_url":"https://api.github.com/users/hppritcha/following{/other_user}","gists_url":"https://api.github.com/users/hppritcha/gists{/gist_id}","starred_url":"https://api.github.com/users/hppritcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hppritcha/subscriptions","organizations_url":"https://api.github.com/users/hppritcha/orgs","repos_url":"https://api.github.com/users/hppritcha/repos","events_url":"https://api.github.com/users/hppritcha/events{/privacy}","received_events_url":"https://api.github.com/users/hppritcha/received_events","type":"User","site_admin":false},"body":"would you mind adding the .init = \r\npieces for these tests","created_at":"2015-04-22T18:59:34Z","updated_at":"2015-04-22T18:59:34Z","html_url":"https://github.com/ofi-cray/libfabric-cray/pull/109#discussion_r28903769","pull_request_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/109","_links":{"self":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments/28903769"},"html":{"href":"https://github.com/ofi-cray/libfabric-cray/pull/109#discussion_r28903769"},"pull_request":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/109","id":33881875,"html_url":"https://github.com/ofi-cray/libfabric-cray/pull/109","diff_url":"https://github.com/ofi-cray/libfabric-cray/pull/109.diff","patch_url":"https://github.com/ofi-cray/libfabric-cray/pull/109.patch","issue_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/109","number":109,"state":"open","locked":false,"title":"Topic/cq wait","user":{"login":"bturrubiates","id":2322856,"avatar_url":"https://avatars.githubusercontent.com/u/2322856?v=3","gravatar_id":"","url":"https://api.github.com/users/bturrubiates","html_url":"https://github.com/bturrubiates","followers_url":"https://api.github.com/users/bturrubiates/followers","following_url":"https://api.github.com/users/bturrubiates/following{/other_user}","gists_url":"https://api.github.com/users/bturrubiates/gists{/gist_id}","starred_url":"https://api.github.com/users/bturrubiates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bturrubiates/subscriptions","organizations_url":"https://api.github.com/users/bturrubiates/orgs","repos_url":"https://api.github.com/users/bturrubiates/repos","events_url":"https://api.github.com/users/bturrubiates/events{/privacy}","received_events_url":"https://api.github.com/users/bturrubiates/received_events","type":"User","site_admin":false},"body":"In another PR I will update EQ to also attach wait objects.\r\nI apologize for the size.\r\n\r\nFor now I solved the criterion issue by including it last and undefining assert before it gets included. Not sure how to handle this correctly. This seems like a problem that the criterion framework should tackle (like include the undef inside of criterion), I'll consider submitting an issue.\r\n\r\n@hppritcha @sungeunchoi @ztiffany ","created_at":"2015-04-22T17:34:01Z","updated_at":"2015-04-22T18:59:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c82504e53981e4061e7957e125779ac94015628","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/109/commits","review_comments_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/109/comments","review_comment_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/109/comments","statuses_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/statuses/0efef94dd348dbc50e1cca8f6b20346ec12a8a90","head":{"label":"bturrubiates:topic/cq-wait","ref":"topic/cq-wait","sha":"0efef94dd348dbc50e1cca8f6b20346ec12a8a90","user":{"login":"bturrubiates","id":2322856,"avatar_url":"https://avatars.githubusercontent.com/u/2322856?v=3","gravatar_id":"","url":"https://api.github.com/users/bturrubiates","html_url":"https://github.com/bturrubiates","followers_url":"https://api.github.com/users/bturrubiates/followers","following_url":"https://api.github.com/users/bturrubiates/following{/other_user}","gists_url":"https://api.github.com/users/bturrubiates/gists{/gist_id}","starred_url":"https://api.github.com/users/bturrubiates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bturrubiates/subscriptions","organizations_url":"https://api.github.com/users/bturrubiates/orgs","repos_url":"https://api.github.com/users/bturrubiates/repos","events_url":"https://api.github.com/users/bturrubiates/events{/privacy}","received_events_url":"https://api.github.com/users/bturrubiates/received_events","type":"User","site_admin":false},"repo":{"id":29930238,"name":"libfabric","full_name":"bturrubiates/libfabric","owner":{"login":"bturrubiates","id":2322856,"avatar_url":"https://avatars.githubusercontent.com/u/2322856?v=3","gravatar_id":"","url":"https://api.github.com/users/bturrubiates","html_url":"https://github.com/bturrubiates","followers_url":"https://api.github.com/users/bturrubiates/followers","following_url":"https://api.github.com/users/bturrubiates/following{/other_user}","gists_url":"https://api.github.com/users/bturrubiates/gists{/gist_id}","starred_url":"https://api.github.com/users/bturrubiates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bturrubiates/subscriptions","organizations_url":"https://api.github.com/users/bturrubiates/orgs","repos_url":"https://api.github.com/users/bturrubiates/repos","events_url":"https://api.github.com/users/bturrubiates/events{/privacy}","received_events_url":"https://api.github.com/users/bturrubiates/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bturrubiates/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/bturrubiates/libfabric","forks_url":"https://api.github.com/repos/bturrubiates/libfabric/forks","keys_url":"https://api.github.com/repos/bturrubiates/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bturrubiates/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bturrubiates/libfabric/teams","hooks_url":"https://api.github.com/repos/bturrubiates/libfabric/hooks","issue_events_url":"https://api.github.com/repos/bturrubiates/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/bturrubiates/libfabric/events","assignees_url":"https://api.github.com/repos/bturrubiates/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/bturrubiates/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/bturrubiates/libfabric/tags","blobs_url":"https://api.github.com/repos/bturrubiates/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bturrubiates/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bturrubiates/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/bturrubiates/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bturrubiates/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/bturrubiates/libfabric/languages","stargazers_url":"https://api.github.com/repos/bturrubiates/libfabric/stargazers","contributors_url":"https://api.github.com/repos/bturrubiates/libfabric/contributors","subscribers_url":"https://api.github.com/repos/bturrubiates/libfabric/subscribers","subscription_url":"https://api.github.com/repos/bturrubiates/libfabric/subscription","commits_url":"https://api.github.com/repos/bturrubiates/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/bturrubiates/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/bturrubiates/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/bturrubiates/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/bturrubiates/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/bturrubiates/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bturrubiates/libfabric/merges","archive_url":"https://api.github.com/repos/bturrubiates/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bturrubiates/libfabric/downloads","issues_url":"https://api.github.com/repos/bturrubiates/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/bturrubiates/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/bturrubiates/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/bturrubiates/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bturrubiates/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/bturrubiates/libfabric/releases{/id}","created_at":"2015-01-27T19:13:34Z","updated_at":"2015-03-28T20:58:44Z","pushed_at":"2015-04-22T17:32:14Z","git_url":"git://github.com/bturrubiates/libfabric.git","ssh_url":"git@github.com:bturrubiates/libfabric.git","clone_url":"https://github.com/bturrubiates/libfabric.git","svn_url":"https://github.com/bturrubiates/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":7129,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofi-cray:master","ref":"master","sha":"3a1c451589ad42e3806924fd22ecb6790b83dba3","user":{"login":"ofi-cray","id":10637979,"avatar_url":"https://avatars.githubusercontent.com/u/10637979?v=3","gravatar_id":"","url":"https://api.github.com/users/ofi-cray","html_url":"https://github.com/ofi-cray","followers_url":"https://api.github.com/users/ofi-cray/followers","following_url":"https://api.github.com/users/ofi-cray/following{/other_user}","gists_url":"https://api.github.com/users/ofi-cray/gists{/gist_id}","starred_url":"https://api.github.com/users/ofi-cray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofi-cray/subscriptions","organizations_url":"https://api.github.com/users/ofi-cray/orgs","repos_url":"https://api.github.com/users/ofi-cray/repos","events_url":"https://api.github.com/users/ofi-cray/events{/privacy}","received_events_url":"https://api.github.com/users/ofi-cray/received_events","type":"Organization","site_admin":false},"repo":{"id":29607348,"name":"libfabric-cray","full_name":"ofi-cray/libfabric-cray","owner":{"login":"ofi-cray","id":10637979,"avatar_url":"https://avatars.githubusercontent.com/u/10637979?v=3","gravatar_id":"","url":"https://api.github.com/users/ofi-cray","html_url":"https://github.com/ofi-cray","followers_url":"https://api.github.com/users/ofi-cray/followers","following_url":"https://api.github.com/users/ofi-cray/following{/other_user}","gists_url":"https://api.github.com/users/ofi-cray/gists{/gist_id}","starred_url":"https://api.github.com/users/ofi-cray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofi-cray/subscriptions","organizations_url":"https://api.github.com/users/ofi-cray/orgs","repos_url":"https://api.github.com/users/ofi-cray/repos","events_url":"https://api.github.com/users/ofi-cray/events{/privacy}","received_events_url":"https://api.github.com/users/ofi-cray/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofi-cray/libfabric-cray","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/ofi-cray/libfabric-cray","forks_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/forks","keys_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/teams","hooks_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/hooks","issue_events_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/events{/number}","events_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/events","assignees_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/assignees{/user}","branches_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/branches{/branch}","tags_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/tags","blobs_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/statuses/{sha}","languages_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/languages","stargazers_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/stargazers","contributors_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/contributors","subscribers_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/subscribers","subscription_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/subscription","commits_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/contents/{+path}","compare_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/merges","archive_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/downloads","issues_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues{/number}","pulls_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls{/number}","milestones_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/milestones{/number}","notifications_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/labels{/name}","releases_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/releases{/id}","created_at":"2015-01-21T19:30:52Z","updated_at":"2015-04-22T17:04:22Z","pushed_at":"2015-04-22T17:34:01Z","git_url":"git://github.com/ofi-cray/libfabric-cray.git","ssh_url":"git@github.com:ofi-cray/libfabric-cray.git","clone_url":"https://github.com/ofi-cray/libfabric-cray.git","svn_url":"https://github.com/ofi-cray/libfabric-cray","homepage":"http://ofiwg.github.io/libfabric/","size":10089,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":25,"forks":3,"open_issues":25,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/109"},"html":{"href":"https://github.com/ofi-cray/libfabric-cray/pull/109"},"issue":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/109"},"comments":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/statuses/0efef94dd348dbc50e1cca8f6b20346ec12a8a90"}}}}