{"action":"created","comment":{"url":"https://api.github.com/repos/dokku/dokku-redis/pulls/comments/38827253","id":38827253,"diff_hunk":"@@ -73,10 +74,7 @@ case \"$1\" in\n       dokku_log_verbose_quiet \"Deleting container data\"\n       docker exec -it \"$ID\" chmod -R 777 /data\n \n-      dokku_log_verbose_quiet \"Stopping container\"\n-      docker stop \"$ID\" > /dev/null\n-      docker kill \"$ID\" > /dev/null\n-      sleep 1\n+      service_stop \"$SERVICE\"","path":"commands","position":null,"original_position":26,"commit_id":"f1ac4bbe71b6942759feaa64370ea20946a547f9","original_commit_id":"16fb91cf16b35564fefa9aa9aae6839f86caf6ff","user":{"login":"Flink","id":5648,"avatar_url":"https://avatars.githubusercontent.com/u/5648?v=3","gravatar_id":"","url":"https://api.github.com/users/Flink","html_url":"https://github.com/Flink","followers_url":"https://api.github.com/users/Flink/followers","following_url":"https://api.github.com/users/Flink/following{/other_user}","gists_url":"https://api.github.com/users/Flink/gists{/gist_id}","starred_url":"https://api.github.com/users/Flink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flink/subscriptions","organizations_url":"https://api.github.com/users/Flink/orgs","repos_url":"https://api.github.com/users/Flink/repos","events_url":"https://api.github.com/users/Flink/events{/privacy}","received_events_url":"https://api.github.com/users/Flink/received_events","type":"User","site_admin":false},"body":"You don't need to kill the container since `docker stop` will do it after a grace period (10 seconds by default). And you can't kill a stopped container, docker will output an error. ","created_at":"2015-09-06T22:56:26Z","updated_at":"2015-09-06T22:56:26Z","html_url":"https://github.com/dokku/dokku-redis/pull/1#discussion_r38827253","pull_request_url":"https://api.github.com/repos/dokku/dokku-redis/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/dokku/dokku-redis/pulls/comments/38827253"},"html":{"href":"https://github.com/dokku/dokku-redis/pull/1#discussion_r38827253"},"pull_request":{"href":"https://api.github.com/repos/dokku/dokku-redis/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/dokku/dokku-redis/pulls/1","id":43800373,"html_url":"https://github.com/dokku/dokku-redis/pull/1","diff_url":"https://github.com/dokku/dokku-redis/pull/1.diff","patch_url":"https://github.com/dokku/dokku-redis/pull/1.patch","issue_url":"https://api.github.com/repos/dokku/dokku-redis/issues/1","number":1,"state":"open","locked":false,"title":"Service expose/unexpose","user":{"login":"josegonzalez","id":65675,"avatar_url":"https://avatars.githubusercontent.com/u/65675?v=3","gravatar_id":"","url":"https://api.github.com/users/josegonzalez","html_url":"https://github.com/josegonzalez","followers_url":"https://api.github.com/users/josegonzalez/followers","following_url":"https://api.github.com/users/josegonzalez/following{/other_user}","gists_url":"https://api.github.com/users/josegonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/josegonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josegonzalez/subscriptions","organizations_url":"https://api.github.com/users/josegonzalez/orgs","repos_url":"https://api.github.com/users/josegonzalez/repos","events_url":"https://api.github.com/users/josegonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/josegonzalez/received_events","type":"User","site_admin":false},"body":"This doesn't actually work because the iptables calls are wrong.\r\n\r\nWe should [link via an ambassador container](https://docs.docker.com/articles/ambassador_pattern_linking/).\r\n\r\n/cc @Flink ","created_at":"2015-08-31T19:30:24Z","updated_at":"2015-09-06T22:56:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bef0ad4e90a3b627163f29a85377dd82b1e404a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dokku/dokku-redis/pulls/1/commits","review_comments_url":"https://api.github.com/repos/dokku/dokku-redis/pulls/1/comments","review_comment_url":"https://api.github.com/repos/dokku/dokku-redis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dokku/dokku-redis/issues/1/comments","statuses_url":"https://api.github.com/repos/dokku/dokku-redis/statuses/f1ac4bbe71b6942759feaa64370ea20946a547f9","head":{"label":"dokku:service-expose","ref":"service-expose","sha":"f1ac4bbe71b6942759feaa64370ea20946a547f9","user":{"login":"dokku","id":13455795,"avatar_url":"https://avatars.githubusercontent.com/u/13455795?v=3","gravatar_id":"","url":"https://api.github.com/users/dokku","html_url":"https://github.com/dokku","followers_url":"https://api.github.com/users/dokku/followers","following_url":"https://api.github.com/users/dokku/following{/other_user}","gists_url":"https://api.github.com/users/dokku/gists{/gist_id}","starred_url":"https://api.github.com/users/dokku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dokku/subscriptions","organizations_url":"https://api.github.com/users/dokku/orgs","repos_url":"https://api.github.com/users/dokku/repos","events_url":"https://api.github.com/users/dokku/events{/privacy}","received_events_url":"https://api.github.com/users/dokku/received_events","type":"Organization","site_admin":false},"repo":{"id":41270722,"name":"dokku-redis","full_name":"dokku/dokku-redis","owner":{"login":"dokku","id":13455795,"avatar_url":"https://avatars.githubusercontent.com/u/13455795?v=3","gravatar_id":"","url":"https://api.github.com/users/dokku","html_url":"https://github.com/dokku","followers_url":"https://api.github.com/users/dokku/followers","following_url":"https://api.github.com/users/dokku/following{/other_user}","gists_url":"https://api.github.com/users/dokku/gists{/gist_id}","starred_url":"https://api.github.com/users/dokku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dokku/subscriptions","organizations_url":"https://api.github.com/users/dokku/orgs","repos_url":"https://api.github.com/users/dokku/repos","events_url":"https://api.github.com/users/dokku/events{/privacy}","received_events_url":"https://api.github.com/users/dokku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dokku/dokku-redis","description":"BETA: a redis plugin for dokku","fork":false,"url":"https://api.github.com/repos/dokku/dokku-redis","forks_url":"https://api.github.com/repos/dokku/dokku-redis/forks","keys_url":"https://api.github.com/repos/dokku/dokku-redis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dokku/dokku-redis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dokku/dokku-redis/teams","hooks_url":"https://api.github.com/repos/dokku/dokku-redis/hooks","issue_events_url":"https://api.github.com/repos/dokku/dokku-redis/issues/events{/number}","events_url":"https://api.github.com/repos/dokku/dokku-redis/events","assignees_url":"https://api.github.com/repos/dokku/dokku-redis/assignees{/user}","branches_url":"https://api.github.com/repos/dokku/dokku-redis/branches{/branch}","tags_url":"https://api.github.com/repos/dokku/dokku-redis/tags","blobs_url":"https://api.github.com/repos/dokku/dokku-redis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dokku/dokku-redis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dokku/dokku-redis/git/refs{/sha}","trees_url":"https://api.github.com/repos/dokku/dokku-redis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dokku/dokku-redis/statuses/{sha}","languages_url":"https://api.github.com/repos/dokku/dokku-redis/languages","stargazers_url":"https://api.github.com/repos/dokku/dokku-redis/stargazers","contributors_url":"https://api.github.com/repos/dokku/dokku-redis/contributors","subscribers_url":"https://api.github.com/repos/dokku/dokku-redis/subscribers","subscription_url":"https://api.github.com/repos/dokku/dokku-redis/subscription","commits_url":"https://api.github.com/repos/dokku/dokku-redis/commits{/sha}","git_commits_url":"https://api.github.com/repos/dokku/dokku-redis/git/commits{/sha}","comments_url":"https://api.github.com/repos/dokku/dokku-redis/comments{/number}","issue_comment_url":"https://api.github.com/repos/dokku/dokku-redis/issues/comments{/number}","contents_url":"https://api.github.com/repos/dokku/dokku-redis/contents/{+path}","compare_url":"https://api.github.com/repos/dokku/dokku-redis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dokku/dokku-redis/merges","archive_url":"https://api.github.com/repos/dokku/dokku-redis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dokku/dokku-redis/downloads","issues_url":"https://api.github.com/repos/dokku/dokku-redis/issues{/number}","pulls_url":"https://api.github.com/repos/dokku/dokku-redis/pulls{/number}","milestones_url":"https://api.github.com/repos/dokku/dokku-redis/milestones{/number}","notifications_url":"https://api.github.com/repos/dokku/dokku-redis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dokku/dokku-redis/labels{/name}","releases_url":"https://api.github.com/repos/dokku/dokku-redis/releases{/id}","created_at":"2015-08-23T22:51:30Z","updated_at":"2015-09-03T15:39:28Z","pushed_at":"2015-09-06T22:26:24Z","git_url":"git://github.com/dokku/dokku-redis.git","ssh_url":"git@github.com:dokku/dokku-redis.git","clone_url":"https://github.com/dokku/dokku-redis.git","svn_url":"https://github.com/dokku/dokku-redis","homepage":null,"size":164,"stargazers_count":5,"watchers_count":5,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":5,"default_branch":"master"}},"base":{"label":"dokku:master","ref":"master","sha":"075a39fe130fb116f0891eb50569af0ab17dc01f","user":{"login":"dokku","id":13455795,"avatar_url":"https://avatars.githubusercontent.com/u/13455795?v=3","gravatar_id":"","url":"https://api.github.com/users/dokku","html_url":"https://github.com/dokku","followers_url":"https://api.github.com/users/dokku/followers","following_url":"https://api.github.com/users/dokku/following{/other_user}","gists_url":"https://api.github.com/users/dokku/gists{/gist_id}","starred_url":"https://api.github.com/users/dokku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dokku/subscriptions","organizations_url":"https://api.github.com/users/dokku/orgs","repos_url":"https://api.github.com/users/dokku/repos","events_url":"https://api.github.com/users/dokku/events{/privacy}","received_events_url":"https://api.github.com/users/dokku/received_events","type":"Organization","site_admin":false},"repo":{"id":41270722,"name":"dokku-redis","full_name":"dokku/dokku-redis","owner":{"login":"dokku","id":13455795,"avatar_url":"https://avatars.githubusercontent.com/u/13455795?v=3","gravatar_id":"","url":"https://api.github.com/users/dokku","html_url":"https://github.com/dokku","followers_url":"https://api.github.com/users/dokku/followers","following_url":"https://api.github.com/users/dokku/following{/other_user}","gists_url":"https://api.github.com/users/dokku/gists{/gist_id}","starred_url":"https://api.github.com/users/dokku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dokku/subscriptions","organizations_url":"https://api.github.com/users/dokku/orgs","repos_url":"https://api.github.com/users/dokku/repos","events_url":"https://api.github.com/users/dokku/events{/privacy}","received_events_url":"https://api.github.com/users/dokku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dokku/dokku-redis","description":"BETA: a redis plugin for dokku","fork":false,"url":"https://api.github.com/repos/dokku/dokku-redis","forks_url":"https://api.github.com/repos/dokku/dokku-redis/forks","keys_url":"https://api.github.com/repos/dokku/dokku-redis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dokku/dokku-redis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dokku/dokku-redis/teams","hooks_url":"https://api.github.com/repos/dokku/dokku-redis/hooks","issue_events_url":"https://api.github.com/repos/dokku/dokku-redis/issues/events{/number}","events_url":"https://api.github.com/repos/dokku/dokku-redis/events","assignees_url":"https://api.github.com/repos/dokku/dokku-redis/assignees{/user}","branches_url":"https://api.github.com/repos/dokku/dokku-redis/branches{/branch}","tags_url":"https://api.github.com/repos/dokku/dokku-redis/tags","blobs_url":"https://api.github.com/repos/dokku/dokku-redis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dokku/dokku-redis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dokku/dokku-redis/git/refs{/sha}","trees_url":"https://api.github.com/repos/dokku/dokku-redis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dokku/dokku-redis/statuses/{sha}","languages_url":"https://api.github.com/repos/dokku/dokku-redis/languages","stargazers_url":"https://api.github.com/repos/dokku/dokku-redis/stargazers","contributors_url":"https://api.github.com/repos/dokku/dokku-redis/contributors","subscribers_url":"https://api.github.com/repos/dokku/dokku-redis/subscribers","subscription_url":"https://api.github.com/repos/dokku/dokku-redis/subscription","commits_url":"https://api.github.com/repos/dokku/dokku-redis/commits{/sha}","git_commits_url":"https://api.github.com/repos/dokku/dokku-redis/git/commits{/sha}","comments_url":"https://api.github.com/repos/dokku/dokku-redis/comments{/number}","issue_comment_url":"https://api.github.com/repos/dokku/dokku-redis/issues/comments{/number}","contents_url":"https://api.github.com/repos/dokku/dokku-redis/contents/{+path}","compare_url":"https://api.github.com/repos/dokku/dokku-redis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dokku/dokku-redis/merges","archive_url":"https://api.github.com/repos/dokku/dokku-redis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dokku/dokku-redis/downloads","issues_url":"https://api.github.com/repos/dokku/dokku-redis/issues{/number}","pulls_url":"https://api.github.com/repos/dokku/dokku-redis/pulls{/number}","milestones_url":"https://api.github.com/repos/dokku/dokku-redis/milestones{/number}","notifications_url":"https://api.github.com/repos/dokku/dokku-redis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dokku/dokku-redis/labels{/name}","releases_url":"https://api.github.com/repos/dokku/dokku-redis/releases{/id}","created_at":"2015-08-23T22:51:30Z","updated_at":"2015-09-03T15:39:28Z","pushed_at":"2015-09-06T22:26:24Z","git_url":"git://github.com/dokku/dokku-redis.git","ssh_url":"git@github.com:dokku/dokku-redis.git","clone_url":"https://github.com/dokku/dokku-redis.git","svn_url":"https://github.com/dokku/dokku-redis","homepage":null,"size":164,"stargazers_count":5,"watchers_count":5,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dokku/dokku-redis/pulls/1"},"html":{"href":"https://github.com/dokku/dokku-redis/pull/1"},"issue":{"href":"https://api.github.com/repos/dokku/dokku-redis/issues/1"},"comments":{"href":"https://api.github.com/repos/dokku/dokku-redis/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/dokku/dokku-redis/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/dokku/dokku-redis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dokku/dokku-redis/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/dokku/dokku-redis/statuses/f1ac4bbe71b6942759feaa64370ea20946a547f9"}}}}