{"action":"closed","number":3975,"pull_request":{"url":"https://api.github.com/repos/divio/django-cms/pulls/3975","id":32397263,"html_url":"https://github.com/divio/django-cms/pull/3975","diff_url":"https://github.com/divio/django-cms/pull/3975.diff","patch_url":"https://github.com/divio/django-cms/pull/3975.patch","issue_url":"https://api.github.com/repos/divio/django-cms/issues/3975","number":3975,"state":"closed","locked":false,"title":"Removed obsolete compatibility layer","user":{"login":"jrief","id":1132472,"avatar_url":"https://avatars.githubusercontent.com/u/1132472?v=3","gravatar_id":"","url":"https://api.github.com/users/jrief","html_url":"https://github.com/jrief","followers_url":"https://api.github.com/users/jrief/followers","following_url":"https://api.github.com/users/jrief/following{/other_user}","gists_url":"https://api.github.com/users/jrief/gists{/gist_id}","starred_url":"https://api.github.com/users/jrief/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrief/subscriptions","organizations_url":"https://api.github.com/users/jrief/orgs","repos_url":"https://api.github.com/users/jrief/repos","events_url":"https://api.github.com/users/jrief/events{/privacy}","received_events_url":"https://api.github.com/users/jrief/received_events","type":"User","site_admin":false},"body":"This compatibility layer added\r\n\r\n* *“sort of a hack”* (citation @yakky )\r\n* added non robust code ``importlib.import_module(app + \".models\")`` – this caused issue #3973\r\n* accessed private class members: ``User._meta.swapped``\r\n* duplicated code, available since Django-1.4\r\n\r\nI therefore would strongly suggest to do some code cleaning here\r\n","created_at":"2015-04-01T08:12:46Z","updated_at":"2015-04-10T13:14:04Z","closed_at":"2015-04-10T13:14:04Z","merged_at":null,"merge_commit_sha":"8ae209f607866c443aa7fe8a9acb21376261a0ad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/divio/django-cms/pulls/3975/commits","review_comments_url":"https://api.github.com/repos/divio/django-cms/pulls/3975/comments","review_comment_url":"https://api.github.com/repos/divio/django-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/divio/django-cms/issues/3975/comments","statuses_url":"https://api.github.com/repos/divio/django-cms/statuses/2acfe1c28c90a41b4ef388c37c9124f169d62431","head":{"label":"jrief:fix-issue-3973","ref":"fix-issue-3973","sha":"2acfe1c28c90a41b4ef388c37c9124f169d62431","user":{"login":"jrief","id":1132472,"avatar_url":"https://avatars.githubusercontent.com/u/1132472?v=3","gravatar_id":"","url":"https://api.github.com/users/jrief","html_url":"https://github.com/jrief","followers_url":"https://api.github.com/users/jrief/followers","following_url":"https://api.github.com/users/jrief/following{/other_user}","gists_url":"https://api.github.com/users/jrief/gists{/gist_id}","starred_url":"https://api.github.com/users/jrief/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrief/subscriptions","organizations_url":"https://api.github.com/users/jrief/orgs","repos_url":"https://api.github.com/users/jrief/repos","events_url":"https://api.github.com/users/jrief/events{/privacy}","received_events_url":"https://api.github.com/users/jrief/received_events","type":"User","site_admin":false},"repo":{"id":9099378,"name":"django-cms","full_name":"jrief/django-cms","owner":{"login":"jrief","id":1132472,"avatar_url":"https://avatars.githubusercontent.com/u/1132472?v=3","gravatar_id":"","url":"https://api.github.com/users/jrief","html_url":"https://github.com/jrief","followers_url":"https://api.github.com/users/jrief/followers","following_url":"https://api.github.com/users/jrief/following{/other_user}","gists_url":"https://api.github.com/users/jrief/gists{/gist_id}","starred_url":"https://api.github.com/users/jrief/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrief/subscriptions","organizations_url":"https://api.github.com/users/jrief/orgs","repos_url":"https://api.github.com/users/jrief/repos","events_url":"https://api.github.com/users/jrief/events{/privacy}","received_events_url":"https://api.github.com/users/jrief/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrief/django-cms","description":"The easy-to-use and developer-friendly CMS","fork":true,"url":"https://api.github.com/repos/jrief/django-cms","forks_url":"https://api.github.com/repos/jrief/django-cms/forks","keys_url":"https://api.github.com/repos/jrief/django-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrief/django-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrief/django-cms/teams","hooks_url":"https://api.github.com/repos/jrief/django-cms/hooks","issue_events_url":"https://api.github.com/repos/jrief/django-cms/issues/events{/number}","events_url":"https://api.github.com/repos/jrief/django-cms/events","assignees_url":"https://api.github.com/repos/jrief/django-cms/assignees{/user}","branches_url":"https://api.github.com/repos/jrief/django-cms/branches{/branch}","tags_url":"https://api.github.com/repos/jrief/django-cms/tags","blobs_url":"https://api.github.com/repos/jrief/django-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrief/django-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrief/django-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrief/django-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrief/django-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/jrief/django-cms/languages","stargazers_url":"https://api.github.com/repos/jrief/django-cms/stargazers","contributors_url":"https://api.github.com/repos/jrief/django-cms/contributors","subscribers_url":"https://api.github.com/repos/jrief/django-cms/subscribers","subscription_url":"https://api.github.com/repos/jrief/django-cms/subscription","commits_url":"https://api.github.com/repos/jrief/django-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrief/django-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrief/django-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrief/django-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrief/django-cms/contents/{+path}","compare_url":"https://api.github.com/repos/jrief/django-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrief/django-cms/merges","archive_url":"https://api.github.com/repos/jrief/django-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrief/django-cms/downloads","issues_url":"https://api.github.com/repos/jrief/django-cms/issues{/number}","pulls_url":"https://api.github.com/repos/jrief/django-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/jrief/django-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/jrief/django-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrief/django-cms/labels{/name}","releases_url":"https://api.github.com/repos/jrief/django-cms/releases{/id}","created_at":"2013-03-29T13:59:53Z","updated_at":"2014-11-18T14:50:15Z","pushed_at":"2015-04-10T13:12:17Z","git_url":"git://github.com/jrief/django-cms.git","ssh_url":"git@github.com:jrief/django-cms.git","clone_url":"https://github.com/jrief/django-cms.git","svn_url":"https://github.com/jrief/django-cms","homepage":"http://www.django-cms.org","size":41217,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"divio:support/3.0.x","ref":"support/3.0.x","sha":"0055edadb481233eef180aba22a5fec875817d45","user":{"login":"divio","id":117904,"avatar_url":"https://avatars.githubusercontent.com/u/117904?v=3","gravatar_id":"","url":"https://api.github.com/users/divio","html_url":"https://github.com/divio","followers_url":"https://api.github.com/users/divio/followers","following_url":"https://api.github.com/users/divio/following{/other_user}","gists_url":"https://api.github.com/users/divio/gists{/gist_id}","starred_url":"https://api.github.com/users/divio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divio/subscriptions","organizations_url":"https://api.github.com/users/divio/orgs","repos_url":"https://api.github.com/users/divio/repos","events_url":"https://api.github.com/users/divio/events{/privacy}","received_events_url":"https://api.github.com/users/divio/received_events","type":"Organization","site_admin":false},"repo":{"id":143580,"name":"django-cms","full_name":"divio/django-cms","owner":{"login":"divio","id":117904,"avatar_url":"https://avatars.githubusercontent.com/u/117904?v=3","gravatar_id":"","url":"https://api.github.com/users/divio","html_url":"https://github.com/divio","followers_url":"https://api.github.com/users/divio/followers","following_url":"https://api.github.com/users/divio/following{/other_user}","gists_url":"https://api.github.com/users/divio/gists{/gist_id}","starred_url":"https://api.github.com/users/divio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divio/subscriptions","organizations_url":"https://api.github.com/users/divio/orgs","repos_url":"https://api.github.com/users/divio/repos","events_url":"https://api.github.com/users/divio/events{/privacy}","received_events_url":"https://api.github.com/users/divio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/divio/django-cms","description":"The easy-to-use and developer-friendly CMS","fork":false,"url":"https://api.github.com/repos/divio/django-cms","forks_url":"https://api.github.com/repos/divio/django-cms/forks","keys_url":"https://api.github.com/repos/divio/django-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/divio/django-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/divio/django-cms/teams","hooks_url":"https://api.github.com/repos/divio/django-cms/hooks","issue_events_url":"https://api.github.com/repos/divio/django-cms/issues/events{/number}","events_url":"https://api.github.com/repos/divio/django-cms/events","assignees_url":"https://api.github.com/repos/divio/django-cms/assignees{/user}","branches_url":"https://api.github.com/repos/divio/django-cms/branches{/branch}","tags_url":"https://api.github.com/repos/divio/django-cms/tags","blobs_url":"https://api.github.com/repos/divio/django-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/divio/django-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/divio/django-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/divio/django-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/divio/django-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/divio/django-cms/languages","stargazers_url":"https://api.github.com/repos/divio/django-cms/stargazers","contributors_url":"https://api.github.com/repos/divio/django-cms/contributors","subscribers_url":"https://api.github.com/repos/divio/django-cms/subscribers","subscription_url":"https://api.github.com/repos/divio/django-cms/subscription","commits_url":"https://api.github.com/repos/divio/django-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/divio/django-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/divio/django-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/divio/django-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/divio/django-cms/contents/{+path}","compare_url":"https://api.github.com/repos/divio/django-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/divio/django-cms/merges","archive_url":"https://api.github.com/repos/divio/django-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/divio/django-cms/downloads","issues_url":"https://api.github.com/repos/divio/django-cms/issues{/number}","pulls_url":"https://api.github.com/repos/divio/django-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/divio/django-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/divio/django-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/divio/django-cms/labels{/name}","releases_url":"https://api.github.com/repos/divio/django-cms/releases{/id}","created_at":"2009-03-05T10:14:18Z","updated_at":"2015-04-10T09:14:20Z","pushed_at":"2015-04-10T13:12:18Z","git_url":"git://github.com/divio/django-cms.git","ssh_url":"git@github.com:divio/django-cms.git","clone_url":"https://github.com/divio/django-cms.git","svn_url":"https://github.com/divio/django-cms","homepage":"http://www.django-cms.org","size":58512,"stargazers_count":3333,"watchers_count":3333,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1285,"mirror_url":null,"open_issues_count":252,"forks":1285,"open_issues":252,"watchers":3333,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/divio/django-cms/pulls/3975"},"html":{"href":"https://github.com/divio/django-cms/pull/3975"},"issue":{"href":"https://api.github.com/repos/divio/django-cms/issues/3975"},"comments":{"href":"https://api.github.com/repos/divio/django-cms/issues/3975/comments"},"review_comments":{"href":"https://api.github.com/repos/divio/django-cms/pulls/3975/comments"},"review_comment":{"href":"https://api.github.com/repos/divio/django-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/divio/django-cms/pulls/3975/commits"},"statuses":{"href":"https://api.github.com/repos/divio/django-cms/statuses/2acfe1c28c90a41b4ef388c37c9124f169d62431"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":4,"review_comments":0,"commits":6,"additions":60,"deletions":62,"changed_files":6}}