{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6028","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6028/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6028/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6028/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/6028","id":122128891,"number":6028,"title":"Deprecated negative valued scorers","user":{"login":"lvrzhn","id":8726048,"avatar_url":"https://avatars.githubusercontent.com/u/8726048?v=3","gravatar_id":"","url":"https://api.github.com/users/lvrzhn","html_url":"https://github.com/lvrzhn","followers_url":"https://api.github.com/users/lvrzhn/followers","following_url":"https://api.github.com/users/lvrzhn/following{/other_user}","gists_url":"https://api.github.com/users/lvrzhn/gists{/gist_id}","starred_url":"https://api.github.com/users/lvrzhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvrzhn/subscriptions","organizations_url":"https://api.github.com/users/lvrzhn/orgs","repos_url":"https://api.github.com/users/lvrzhn/repos","events_url":"https://api.github.com/users/lvrzhn/events{/privacy}","received_events_url":"https://api.github.com/users/lvrzhn/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-12-14T20:53:23Z","updated_at":"2015-12-15T19:58:51Z","closed_at":"2015-12-15T15:47:38Z","pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6028","html_url":"https://github.com/scikit-learn/scikit-learn/pull/6028","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/6028.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/6028.patch"},"body":"1) deprecated X = mean_squared_error, mean_absolute_error, median_absolute_error, log_loss, when called, print \"Function returns negative of X so that greater=better. This function is deprecated in version\r\n0.18 and will be removed in a future version 0.20. Use neg_* instead\"\r\n\r\n2) replaced X_scorer by neg_X_scorer throughout scikit-learn source code as well as tests. Documented in doc/modules/model_evaluation.rst\r\n\r\nStill need to do:\r\n3) add a new test that checks if you use deprecated one you get deprecation warning and same behavior\r\n"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/164878773","html_url":"https://github.com/scikit-learn/scikit-learn/pull/6028#issuecomment-164878773","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6028","id":164878773,"user":{"login":"jnothman","id":78827,"avatar_url":"https://avatars.githubusercontent.com/u/78827?v=3","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"created_at":"2015-12-15T19:58:51Z","updated_at":"2015-12-15T19:58:51Z","body":"Sorry, I've lost that code. I think I may have defined a SCORER_DEPRECATION\ndict mapping name to deprecation warning text\n\nOn 16 December 2015 at 02:49, Andreas Mueller <notifications@github.com>\nwrote:\n\n> Closed #6028 <https://github.com/scikit-learn/scikit-learn/pull/6028>.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/scikit-learn/scikit-learn/pull/6028#event-492376737>.\n>\n"}}