{"action":"created","comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments/33289000","id":33289000,"diff_hunk":"@@ -1595,7 +1596,7 @@ namespace DXCoils {\n \n \t//     NOTICE\n \n-\t//     Copyright � 1996-2014 The Board of Trustees of the University of Illinois\n+\t//     Copyright � 1996-2014 The Board of Trustees of the University of Illinois","path":"src/EnergyPlus/DXCoils.hh","position":15,"original_position":15,"commit_id":"46e6fe14d12e6a0144f8fd424e99ae5754db472a","original_commit_id":"46e6fe14d12e6a0144f8fd424e99ae5754db472a","user":{"login":"rraustad","id":5778156,"avatar_url":"https://avatars.githubusercontent.com/u/5778156?v=3","gravatar_id":"","url":"https://api.github.com/users/rraustad","html_url":"https://github.com/rraustad","followers_url":"https://api.github.com/users/rraustad/followers","following_url":"https://api.github.com/users/rraustad/following{/other_user}","gists_url":"https://api.github.com/users/rraustad/gists{/gist_id}","starred_url":"https://api.github.com/users/rraustad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rraustad/subscriptions","organizations_url":"https://api.github.com/users/rraustad/orgs","repos_url":"https://api.github.com/users/rraustad/repos","events_url":"https://api.github.com/users/rraustad/events{/privacy}","received_events_url":"https://api.github.com/users/rraustad/received_events","type":"User","site_admin":false},"body":"Did you change the copyright symbol on purpose?","created_at":"2015-06-25T18:33:52Z","updated_at":"2015-06-25T18:33:52Z","html_url":"https://github.com/NREL/EnergyPlus/pull/4698#discussion_r33289000","pull_request_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/4698","_links":{"self":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments/33289000"},"html":{"href":"https://github.com/NREL/EnergyPlus/pull/4698#discussion_r33289000"},"pull_request":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/4698"}}},"pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/4698","id":28148881,"html_url":"https://github.com/NREL/EnergyPlus/pull/4698","diff_url":"https://github.com/NREL/EnergyPlus/pull/4698.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/4698.patch","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/4698","number":4698,"state":"open","locked":false,"title":"Residential Heat Pump Water Heater Improvements","user":{"login":"nmerket","id":5325034,"avatar_url":"https://avatars.githubusercontent.com/u/5325034?v=3","gravatar_id":"","url":"https://api.github.com/users/nmerket","html_url":"https://github.com/nmerket","followers_url":"https://api.github.com/users/nmerket/followers","following_url":"https://api.github.com/users/nmerket/following{/other_user}","gists_url":"https://api.github.com/users/nmerket/gists{/gist_id}","starred_url":"https://api.github.com/users/nmerket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmerket/subscriptions","organizations_url":"https://api.github.com/users/nmerket/orgs","repos_url":"https://api.github.com/users/nmerket/repos","events_url":"https://api.github.com/users/nmerket/events{/privacy}","received_events_url":"https://api.github.com/users/nmerket/received_events","type":"User","site_admin":false},"body":" - [x] Rename existing `WaterHeater:HeatPump` to `WaterHeater:HeatPumpPumpedCondenser`. \r\n - [x] Create a new idf object for residential heat pump water heaters called `WaterHeater:HeatPump:WrappedCondenser`. The new object will be different in the following ways:\r\n    - [x] `WaterHeater:HeatPump:WrappedCondenser` will only be compatible with a `WaterHeater:Stratified` tank (and `WaterHeater:HeatPump:PumpedCondenser` will only be compatible with a `WaterHeater:Mixed` tank)\r\n    - [x] Inputs relating to condenser water pumping will be removed.\r\n    - [x] Add inputs relating to the location of the condenser on the tank and change heat transfer calculation to allow for a distribution of heat to come in across several nodes.\r\n    - [x] ~~Include warnings if the timestep is too long for reasonable results. Also, warn if not using subhourly draw profiles.~~\r\n    - [x] Add an option to not allow the heat pump and element(s) to run simultaneously. This can be bool. The element(s) should be master (if both want to come on, the element gets priority).\r\n    - [x] ~~Add an option to allow heating cycles to complete with the heat pump. This can also be a separate bool input. If this is true, once the element comes on, it stays on until the heating cycle is over instead of switching back to the heat pump once the tank has partially recovered.~~\r\n - [x] Change `WaterHeater:Stratified` IDD to allow the maximum number of nodes to be 12\r\n - [x] Change `WaterHeater:HeatPump:PumpedCondenser` and `WaterHeater:HeatPump:WrappedCondenser` to:\r\n   - [x] Have a minimum air inlet temperature of -5 &deg;C\r\n   - [x] Create new maximum air inlet temperature input and choose appropriate bounds. Default to 120F.\r\n - [x] ~~Add default/example performance curves (biquadratic curves for heating capacity and COP) for residential HPWHs. NREL has developed generic performance curves based on [lab testing of three manufacturer’s residential HPWHs](http://www.osti.gov/scitech/biblio/1025650). Add to `PerfCurves.idf`~~ don't make sense on their own without the HPWH model.\r\n - [x] Unit tests\r\n - [x] Integration tests\r\n   - [x] Fix existing tests to reflect updated idd\r\n - [x] Documentation\r\n - [x] Talk to @Myoldmopar about how to work idd changes into the transition program.","created_at":"2015-01-27T22:05:44Z","updated_at":"2015-06-25T18:33:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa8baae116cea0509c63d2123acfb810ec8a576a","assignee":{"login":"nmerket","id":5325034,"avatar_url":"https://avatars.githubusercontent.com/u/5325034?v=3","gravatar_id":"","url":"https://api.github.com/users/nmerket","html_url":"https://github.com/nmerket","followers_url":"https://api.github.com/users/nmerket/followers","following_url":"https://api.github.com/users/nmerket/following{/other_user}","gists_url":"https://api.github.com/users/nmerket/gists{/gist_id}","starred_url":"https://api.github.com/users/nmerket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmerket/subscriptions","organizations_url":"https://api.github.com/users/nmerket/orgs","repos_url":"https://api.github.com/users/nmerket/repos","events_url":"https://api.github.com/users/nmerket/events{/privacy}","received_events_url":"https://api.github.com/users/nmerket/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/4698/commits","review_comments_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/4698/comments","review_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/4698/comments","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/46e6fe14d12e6a0144f8fd424e99ae5754db472a","head":{"label":"NREL:hpwh_residential","ref":"hpwh_residential","sha":"46e6fe14d12e6a0144f8fd424e99ae5754db472a","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":14620185,"name":"EnergyPlus","full_name":"NREL/EnergyPlus","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/EnergyPlus","description":"","fork":false,"url":"https://api.github.com/repos/NREL/EnergyPlus","forks_url":"https://api.github.com/repos/NREL/EnergyPlus/forks","keys_url":"https://api.github.com/repos/NREL/EnergyPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/EnergyPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/EnergyPlus/teams","hooks_url":"https://api.github.com/repos/NREL/EnergyPlus/hooks","issue_events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/EnergyPlus/events","assignees_url":"https://api.github.com/repos/NREL/EnergyPlus/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/EnergyPlus/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/EnergyPlus/tags","blobs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/EnergyPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/EnergyPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/EnergyPlus/languages","stargazers_url":"https://api.github.com/repos/NREL/EnergyPlus/stargazers","contributors_url":"https://api.github.com/repos/NREL/EnergyPlus/contributors","subscribers_url":"https://api.github.com/repos/NREL/EnergyPlus/subscribers","subscription_url":"https://api.github.com/repos/NREL/EnergyPlus/subscription","commits_url":"https://api.github.com/repos/NREL/EnergyPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/EnergyPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/EnergyPlus/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/EnergyPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/EnergyPlus/merges","archive_url":"https://api.github.com/repos/NREL/EnergyPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/EnergyPlus/downloads","issues_url":"https://api.github.com/repos/NREL/EnergyPlus/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/EnergyPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/labels{/name}","releases_url":"https://api.github.com/repos/NREL/EnergyPlus/releases{/id}","created_at":"2013-11-22T14:47:34Z","updated_at":"2015-06-18T15:27:19Z","pushed_at":"2015-06-25T17:03:28Z","git_url":"git://github.com/NREL/EnergyPlus.git","ssh_url":"git@github.com:NREL/EnergyPlus.git","clone_url":"https://github.com/NREL/EnergyPlus.git","svn_url":"https://github.com/NREL/EnergyPlus","homepage":null,"size":419221,"stargazers_count":54,"watchers_count":54,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"open_issues_count":428,"forks":41,"open_issues":428,"watchers":54,"default_branch":"develop"}},"base":{"label":"NREL:develop","ref":"develop","sha":"4848c02a5c67ec75853340d2596097b690d90a7f","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":14620185,"name":"EnergyPlus","full_name":"NREL/EnergyPlus","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/EnergyPlus","description":"","fork":false,"url":"https://api.github.com/repos/NREL/EnergyPlus","forks_url":"https://api.github.com/repos/NREL/EnergyPlus/forks","keys_url":"https://api.github.com/repos/NREL/EnergyPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/EnergyPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/EnergyPlus/teams","hooks_url":"https://api.github.com/repos/NREL/EnergyPlus/hooks","issue_events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/EnergyPlus/events","assignees_url":"https://api.github.com/repos/NREL/EnergyPlus/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/EnergyPlus/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/EnergyPlus/tags","blobs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/EnergyPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/EnergyPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/EnergyPlus/languages","stargazers_url":"https://api.github.com/repos/NREL/EnergyPlus/stargazers","contributors_url":"https://api.github.com/repos/NREL/EnergyPlus/contributors","subscribers_url":"https://api.github.com/repos/NREL/EnergyPlus/subscribers","subscription_url":"https://api.github.com/repos/NREL/EnergyPlus/subscription","commits_url":"https://api.github.com/repos/NREL/EnergyPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/EnergyPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/EnergyPlus/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/EnergyPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/EnergyPlus/merges","archive_url":"https://api.github.com/repos/NREL/EnergyPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/EnergyPlus/downloads","issues_url":"https://api.github.com/repos/NREL/EnergyPlus/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/EnergyPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/labels{/name}","releases_url":"https://api.github.com/repos/NREL/EnergyPlus/releases{/id}","created_at":"2013-11-22T14:47:34Z","updated_at":"2015-06-18T15:27:19Z","pushed_at":"2015-06-25T17:03:28Z","git_url":"git://github.com/NREL/EnergyPlus.git","ssh_url":"git@github.com:NREL/EnergyPlus.git","clone_url":"https://github.com/NREL/EnergyPlus.git","svn_url":"https://github.com/NREL/EnergyPlus","homepage":null,"size":419221,"stargazers_count":54,"watchers_count":54,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"open_issues_count":428,"forks":41,"open_issues":428,"watchers":54,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/4698"},"html":{"href":"https://github.com/NREL/EnergyPlus/pull/4698"},"issue":{"href":"https://api.github.com/repos/NREL/EnergyPlus/issues/4698"},"comments":{"href":"https://api.github.com/repos/NREL/EnergyPlus/issues/4698/comments"},"review_comments":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/4698/comments"},"review_comment":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/4698/commits"},"statuses":{"href":"https://api.github.com/repos/NREL/EnergyPlus/statuses/46e6fe14d12e6a0144f8fd424e99ae5754db472a"}}}}