{"action":"created","comment":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/28520896","id":28520896,"diff_hunk":"@@ -66,27 +81,32 @@ cleanall: FORCE\n clobber: FORCE\n \trm -rf build install $(GMP_SUBDIR)\n \n-$(GMP_UNPACKED_DIR):\n-\tcd $(GMP_DIR) && tar --bzip2 -xf $(GMP_TARBALL)\n-\n $(GMP_BUILD_SUBDIR):\n \tmkdir -p $@\n \n-gmp-config:\n-\t$(MAKE) $(GMP_MAKEFILE)\n-\n-$(GMP_MAKEFILE): $(GMP_BUILD_SUBDIR) $(GMP_UNPACKED_DIR)\n-\tcd $(GMP_BUILD_DIR) && $(GMP_SUBDIR)/configure CC='$(CC)' CFLAGS='$(CFLAGS) $(CHPL_GMP_CFLAGS)' CXX='$(CXX)' CXXFLAGS='$(CXXFLAGS) $(CHPL_GMP_CXXFLAGS)' $(CHPL_GMP_ABI_ARG) --prefix=$(GMP_INSTALL_DIR) $(CHPL_GMP_CFG_OPTIONS)\n+$(GMP_UNPACKED_DIR):\n+\tcd $(GMP_DIR) && tar --bzip2 -xf $(GMP_TARBALL)\n \n gmp-build:\n \t$(MAKE) $(GMP_H_FILE)\n \n-$(GMP_H_FILE): $(GMP_MAKEFILE)\n+$(GMP_H_FILE): $(GMP_BUILD_SUBDIR)\n+ifeq (yes, $(GMP_SPECULATIVE_CRAY_X_PGI))\n+\t@echo 'Speculative build of gmp squashed due to PGI target compiler on Cray X*.'","path":"third-party/gmp/Makefile","position":64,"original_position":64,"commit_id":"44732163b389516bdcec854ecb9d084930838930","original_commit_id":"44732163b389516bdcec854ecb9d084930838930","user":{"login":"thomasvandoren","id":530981,"avatar_url":"https://avatars.githubusercontent.com/u/530981?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasvandoren","html_url":"https://github.com/thomasvandoren","followers_url":"https://api.github.com/users/thomasvandoren/followers","following_url":"https://api.github.com/users/thomasvandoren/following{/other_user}","gists_url":"https://api.github.com/users/thomasvandoren/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasvandoren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasvandoren/subscriptions","organizations_url":"https://api.github.com/users/thomasvandoren/orgs","repos_url":"https://api.github.com/users/thomasvandoren/repos","events_url":"https://api.github.com/users/thomasvandoren/events{/privacy}","received_events_url":"https://api.github.com/users/thomasvandoren/received_events","type":"User","site_admin":false},"body":"Yeah, I find that a little annoying too, but I think it's ok.","created_at":"2015-04-16T15:37:49Z","updated_at":"2015-04-16T15:37:49Z","html_url":"https://github.com/chapel-lang/chapel/pull/1843#discussion_r28520896","pull_request_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/1843","_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/28520896"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/1843#discussion_r28520896"},"pull_request":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/1843"}}},"pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/1843","id":33459115,"html_url":"https://github.com/chapel-lang/chapel/pull/1843","diff_url":"https://github.com/chapel-lang/chapel/pull/1843.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/1843.patch","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/1843","number":1843,"state":"open","locked":false,"title":"Don't speculatively build with the PGI compiler on Cray X*.","user":{"login":"gbtitus","id":7740880,"avatar_url":"https://avatars.githubusercontent.com/u/7740880?v=3","gravatar_id":"","url":"https://api.github.com/users/gbtitus","html_url":"https://github.com/gbtitus","followers_url":"https://api.github.com/users/gbtitus/followers","following_url":"https://api.github.com/users/gbtitus/following{/other_user}","gists_url":"https://api.github.com/users/gbtitus/gists{/gist_id}","starred_url":"https://api.github.com/users/gbtitus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbtitus/subscriptions","organizations_url":"https://api.github.com/users/gbtitus/orgs","repos_url":"https://api.github.com/users/gbtitus/repos","events_url":"https://api.github.com/users/gbtitus/events{/privacy}","received_events_url":"https://api.github.com/users/gbtitus/received_events","type":"User","site_admin":false},"body":"We have problems involving alloca() in gmp when it's built with the PGI\r\ntarget compiler on Cray X* platforms.  So, don't speculatively build gmp\r\nin that situation.  The specific file changes are as follows:\r\n\r\nthird-party/Makefile:\r\nSet a GMP_SPECULATIVE make variable when invoking the third-party/gmp\r\nMakefile for a speculative build.\r\n\r\nthird-party/gmp/Makefile:\r\nFor speculative builds, squash them entirely and print a message when\r\ntarget=cray-x* and target compiler=*pgi.  For non-speculative builds\r\nwith this target and target compiler, warn that the resulting gmp may\r\nhave problems, but do the build anyway.\r\n\r\nWhile here, I also rearranged the make targets so that we don't unpack\r\nthe tar file or do the configure step unless we're going to build gmp.\r\nWith the previous arrangement, there wasn't a good place to squash the\r\nbuild until after the unpack and configure had been done, which take a\r\nbit of time.\r\n\r\nWhile here, for a 'clean', delete not only the configuration-specific\r\nbuild subdir but also the config-specific install subdir.  This makes\r\nthings a little easier when testing Makefile changes, since for the\r\nspeculatively built packages we depend not only on the build subdir but\r\nalso the install subdir (for the .h file, whose presence tells us that\r\nwe have already speculatively built).","created_at":"2015-04-16T14:56:12Z","updated_at":"2015-04-16T15:37:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1f7be1fc732a0ccd5d6dc693602bfc75551bb68","assignee":{"login":"thomasvandoren","id":530981,"avatar_url":"https://avatars.githubusercontent.com/u/530981?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasvandoren","html_url":"https://github.com/thomasvandoren","followers_url":"https://api.github.com/users/thomasvandoren/followers","following_url":"https://api.github.com/users/thomasvandoren/following{/other_user}","gists_url":"https://api.github.com/users/thomasvandoren/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasvandoren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasvandoren/subscriptions","organizations_url":"https://api.github.com/users/thomasvandoren/orgs","repos_url":"https://api.github.com/users/thomasvandoren/repos","events_url":"https://api.github.com/users/thomasvandoren/events{/privacy}","received_events_url":"https://api.github.com/users/thomasvandoren/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/1843/commits","review_comments_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/1843/comments","review_comment_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/1843/comments","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/44732163b389516bdcec854ecb9d084930838930","head":{"label":"gbtitus:gmp-cray-x-pgi","ref":"gmp-cray-x-pgi","sha":"44732163b389516bdcec854ecb9d084930838930","user":{"login":"gbtitus","id":7740880,"avatar_url":"https://avatars.githubusercontent.com/u/7740880?v=3","gravatar_id":"","url":"https://api.github.com/users/gbtitus","html_url":"https://github.com/gbtitus","followers_url":"https://api.github.com/users/gbtitus/followers","following_url":"https://api.github.com/users/gbtitus/following{/other_user}","gists_url":"https://api.github.com/users/gbtitus/gists{/gist_id}","starred_url":"https://api.github.com/users/gbtitus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbtitus/subscriptions","organizations_url":"https://api.github.com/users/gbtitus/orgs","repos_url":"https://api.github.com/users/gbtitus/repos","events_url":"https://api.github.com/users/gbtitus/events{/privacy}","received_events_url":"https://api.github.com/users/gbtitus/received_events","type":"User","site_admin":false},"repo":{"id":21912579,"name":"chapel","full_name":"gbtitus/chapel","owner":{"login":"gbtitus","id":7740880,"avatar_url":"https://avatars.githubusercontent.com/u/7740880?v=3","gravatar_id":"","url":"https://api.github.com/users/gbtitus","html_url":"https://github.com/gbtitus","followers_url":"https://api.github.com/users/gbtitus/followers","following_url":"https://api.github.com/users/gbtitus/following{/other_user}","gists_url":"https://api.github.com/users/gbtitus/gists{/gist_id}","starred_url":"https://api.github.com/users/gbtitus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbtitus/subscriptions","organizations_url":"https://api.github.com/users/gbtitus/orgs","repos_url":"https://api.github.com/users/gbtitus/repos","events_url":"https://api.github.com/users/gbtitus/events{/privacy}","received_events_url":"https://api.github.com/users/gbtitus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gbtitus/chapel","description":"a Productive Parallel Programming Language","fork":true,"url":"https://api.github.com/repos/gbtitus/chapel","forks_url":"https://api.github.com/repos/gbtitus/chapel/forks","keys_url":"https://api.github.com/repos/gbtitus/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gbtitus/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gbtitus/chapel/teams","hooks_url":"https://api.github.com/repos/gbtitus/chapel/hooks","issue_events_url":"https://api.github.com/repos/gbtitus/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/gbtitus/chapel/events","assignees_url":"https://api.github.com/repos/gbtitus/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/gbtitus/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/gbtitus/chapel/tags","blobs_url":"https://api.github.com/repos/gbtitus/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gbtitus/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gbtitus/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/gbtitus/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gbtitus/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/gbtitus/chapel/languages","stargazers_url":"https://api.github.com/repos/gbtitus/chapel/stargazers","contributors_url":"https://api.github.com/repos/gbtitus/chapel/contributors","subscribers_url":"https://api.github.com/repos/gbtitus/chapel/subscribers","subscription_url":"https://api.github.com/repos/gbtitus/chapel/subscription","commits_url":"https://api.github.com/repos/gbtitus/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/gbtitus/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/gbtitus/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/gbtitus/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/gbtitus/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/gbtitus/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gbtitus/chapel/merges","archive_url":"https://api.github.com/repos/gbtitus/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gbtitus/chapel/downloads","issues_url":"https://api.github.com/repos/gbtitus/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/gbtitus/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/gbtitus/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/gbtitus/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gbtitus/chapel/labels{/name}","releases_url":"https://api.github.com/repos/gbtitus/chapel/releases{/id}","created_at":"2014-07-16T18:39:09Z","updated_at":"2015-04-15T14:05:17Z","pushed_at":"2015-04-16T14:55:24Z","git_url":"git://github.com/gbtitus/chapel.git","ssh_url":"git@github.com:gbtitus/chapel.git","clone_url":"https://github.com/gbtitus/chapel.git","svn_url":"https://github.com/gbtitus/chapel","homepage":"http://chapel.cray.com/","size":292892,"stargazers_count":2,"watchers_count":2,"language":"Chapel","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"chapel-lang:master","ref":"master","sha":"512fa5a553e081cb5a71723a248db66f57947ff8","user":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars.githubusercontent.com/u/7597261?v=3","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":21663285,"name":"chapel","full_name":"chapel-lang/chapel","owner":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars.githubusercontent.com/u/7597261?v=3","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chapel-lang/chapel","description":"a Productive Parallel Programming Language","fork":false,"url":"https://api.github.com/repos/chapel-lang/chapel","forks_url":"https://api.github.com/repos/chapel-lang/chapel/forks","keys_url":"https://api.github.com/repos/chapel-lang/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chapel-lang/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chapel-lang/chapel/teams","hooks_url":"https://api.github.com/repos/chapel-lang/chapel/hooks","issue_events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/chapel-lang/chapel/events","assignees_url":"https://api.github.com/repos/chapel-lang/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/chapel-lang/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/chapel-lang/chapel/tags","blobs_url":"https://api.github.com/repos/chapel-lang/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chapel-lang/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chapel-lang/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/chapel-lang/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/chapel-lang/chapel/languages","stargazers_url":"https://api.github.com/repos/chapel-lang/chapel/stargazers","contributors_url":"https://api.github.com/repos/chapel-lang/chapel/contributors","subscribers_url":"https://api.github.com/repos/chapel-lang/chapel/subscribers","subscription_url":"https://api.github.com/repos/chapel-lang/chapel/subscription","commits_url":"https://api.github.com/repos/chapel-lang/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/chapel-lang/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/chapel-lang/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/chapel-lang/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chapel-lang/chapel/merges","archive_url":"https://api.github.com/repos/chapel-lang/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chapel-lang/chapel/downloads","issues_url":"https://api.github.com/repos/chapel-lang/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/chapel-lang/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/chapel-lang/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/chapel-lang/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chapel-lang/chapel/labels{/name}","releases_url":"https://api.github.com/repos/chapel-lang/chapel/releases{/id}","created_at":"2014-07-09T18:15:54Z","updated_at":"2015-04-15T22:07:34Z","pushed_at":"2015-04-16T14:56:12Z","git_url":"git://github.com/chapel-lang/chapel.git","ssh_url":"git@github.com:chapel-lang/chapel.git","clone_url":"https://github.com/chapel-lang/chapel.git","svn_url":"https://github.com/chapel-lang/chapel","homepage":"http://chapel.cray.com/","size":422358,"stargazers_count":97,"watchers_count":97,"language":"Chapel","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":12,"forks":41,"open_issues":12,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/1843"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/1843"},"issue":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/1843"},"comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/1843/comments"},"review_comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/1843/comments"},"review_comment":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/1843/commits"},"statuses":{"href":"https://api.github.com/repos/chapel-lang/chapel/statuses/44732163b389516bdcec854ecb9d084930838930"}}}}