{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/Diagnostics/issues/130","labels_url":"https://api.github.com/repos/aspnet/Diagnostics/issues/130/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/Diagnostics/issues/130/comments","events_url":"https://api.github.com/repos/aspnet/Diagnostics/issues/130/events","html_url":"https://github.com/aspnet/Diagnostics/issues/130","id":73677589,"number":130,"title":"UseErrorPage extension rationalization","user":{"login":"muratg","id":1808428,"avatar_url":"https://avatars.githubusercontent.com/u/1808428?v=3","gravatar_id":"","url":"https://api.github.com/users/muratg","html_url":"https://github.com/muratg","followers_url":"https://api.github.com/users/muratg/followers","following_url":"https://api.github.com/users/muratg/following{/other_user}","gists_url":"https://api.github.com/users/muratg/gists{/gist_id}","starred_url":"https://api.github.com/users/muratg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muratg/subscriptions","organizations_url":"https://api.github.com/users/muratg/orgs","repos_url":"https://api.github.com/users/muratg/repos","events_url":"https://api.github.com/users/muratg/events{/privacy}","received_events_url":"https://api.github.com/users/muratg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-06T16:57:24Z","updated_at":"2015-05-06T23:27:17Z","closed_at":null,"body":"Currently, templates check the environment, and if it's Development, UseErrorPage extension is called.\r\n\r\nHowever, there's a TODO comment in this extension method: https://github.com/aspnet/Diagnostics/blob/dev/src/Microsoft.AspNet.Diagnostics/ErrorPageExtensions.cs#L43\r\n\r\n```\r\n        public static IApplicationBuilder UseErrorPage(this IApplicationBuilder builder, ErrorPageOptions options)\r\n        {\r\n            if (builder == null)\r\n            {\r\n                throw new ArgumentNullException(\"builder\");\r\n            }\r\n            /* TODO: Development, Staging, or Production\r\n            string appMode = new AppProperties(builder.Properties).Get<string>(Constants.HostAppMode);\r\n            bool isDevMode = string.Equals(Constants.DevMode, appMode, StringComparison.Ordinal);*/\r\n            bool isDevMode = true;\r\n            return builder.Use(next => new ErrorPageMiddleware(next, options, isDevMode).Invoke);\r\n        }\r\n```\r\n\r\n\r\nWe either need to remove this comment from the method, or enable the check here, and remove UseErrorPage() in the Startup outside of Development env check."},"comment":{"url":"https://api.github.com/repos/aspnet/Diagnostics/issues/comments/99642849","html_url":"https://github.com/aspnet/Diagnostics/issues/130#issuecomment-99642849","issue_url":"https://api.github.com/repos/aspnet/Diagnostics/issues/130","id":99642849,"user":{"login":"muratg","id":1808428,"avatar_url":"https://avatars.githubusercontent.com/u/1808428?v=3","gravatar_id":"","url":"https://api.github.com/users/muratg","html_url":"https://github.com/muratg","followers_url":"https://api.github.com/users/muratg/followers","following_url":"https://api.github.com/users/muratg/following{/other_user}","gists_url":"https://api.github.com/users/muratg/gists{/gist_id}","starred_url":"https://api.github.com/users/muratg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muratg/subscriptions","organizations_url":"https://api.github.com/users/muratg/orgs","repos_url":"https://api.github.com/users/muratg/repos","events_url":"https://api.github.com/users/muratg/events{/privacy}","received_events_url":"https://api.github.com/users/muratg/received_events","type":"User","site_admin":false},"created_at":"2015-05-06T23:27:17Z","updated_at":"2015-05-06T23:27:17Z","body":"We had a chat with @DamianEdwards and @Eilon and decided to keep this as is.  If customers call UseErrorPage, we are not going to stop them from here.\r\n\r\nThus the work is removing the comments above."}}