{"action":"created","comment":{"url":"https://api.github.com/repos/zendesk/radar/pulls/comments/44600586","id":44600586,"diff_hunk":"@@ -51,15 +51,15 @@ PresenceManager.prototype.setup = function() {\n   this.sentryListener = function (sentry) {   \n     \n     var socketIds = store.socketsForSentry(sentry);","path":"core/lib/resources/presence/presence_manager.js","position":3,"original_position":3,"commit_id":"795b3cf2630e894b41b810d889580828c5eced53","original_commit_id":"795b3cf2630e894b41b810d889580828c5eced53","user":{"login":"jden","id":1106489,"avatar_url":"https://avatars.githubusercontent.com/u/1106489?v=3","gravatar_id":"","url":"https://api.github.com/users/jden","html_url":"https://github.com/jden","followers_url":"https://api.github.com/users/jden/followers","following_url":"https://api.github.com/users/jden/following{/other_user}","gists_url":"https://api.github.com/users/jden/gists{/gist_id}","starred_url":"https://api.github.com/users/jden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jden/subscriptions","organizations_url":"https://api.github.com/users/jden/orgs","repos_url":"https://api.github.com/users/jden/repos","events_url":"https://api.github.com/users/jden/events{/privacy}","received_events_url":"https://api.github.com/users/jden/received_events","type":"User","site_admin":false},"body":"they're not `undefined`, `socketIds` is an empty array, and `[].pop() => undefined`.","created_at":"2015-11-11T23:06:04Z","updated_at":"2015-11-11T23:06:04Z","html_url":"https://github.com/zendesk/radar/pull/189#discussion_r44600586","pull_request_url":"https://api.github.com/repos/zendesk/radar/pulls/189","_links":{"self":{"href":"https://api.github.com/repos/zendesk/radar/pulls/comments/44600586"},"html":{"href":"https://github.com/zendesk/radar/pull/189#discussion_r44600586"},"pull_request":{"href":"https://api.github.com/repos/zendesk/radar/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/zendesk/radar/pulls/189","id":50449296,"html_url":"https://github.com/zendesk/radar/pull/189","diff_url":"https://github.com/zendesk/radar/pull/189.diff","patch_url":"https://github.com/zendesk/radar/pull/189.patch","issue_url":"https://api.github.com/repos/zendesk/radar/issues/189","number":189,"state":"open","locked":false,"title":"Clean up sentry down logging in presence manager","user":{"login":"jden","id":1106489,"avatar_url":"https://avatars.githubusercontent.com/u/1106489?v=3","gravatar_id":"","url":"https://api.github.com/users/jden","html_url":"https://github.com/jden","followers_url":"https://api.github.com/users/jden/followers","following_url":"https://api.github.com/users/jden/following{/other_user}","gists_url":"https://api.github.com/users/jden/gists{/gist_id}","starred_url":"https://api.github.com/users/jden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jden/subscriptions","organizations_url":"https://api.github.com/users/jden/orgs","repos_url":"https://api.github.com/users/jden/repos","events_url":"https://api.github.com/users/jden/events{/privacy}","received_events_url":"https://api.github.com/users/jden/received_events","type":"User","site_admin":false},"body":"Removes extraneous and confusing log messages like \r\n```\r\n#presence - #sentry down chain exit: socketId:  , manager.destroying: false\r\n```\r\nwhen a sentry dies with no clients.\r\n\r\nrequired\r\n========\r\n- [ ] :+1: from team\r\n\r\nrisks\r\n======\r\nnone","created_at":"2015-11-11T23:02:04Z","updated_at":"2015-11-11T23:06:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6877e411c0bfeeed0793faf267add95b35c55b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zendesk/radar/pulls/189/commits","review_comments_url":"https://api.github.com/repos/zendesk/radar/pulls/189/comments","review_comment_url":"https://api.github.com/repos/zendesk/radar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendesk/radar/issues/189/comments","statuses_url":"https://api.github.com/repos/zendesk/radar/statuses/795b3cf2630e894b41b810d889580828c5eced53","head":{"label":"zendesk:jden/clean_sentry_logging","ref":"jden/clean_sentry_logging","sha":"795b3cf2630e894b41b810d889580828c5eced53","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":6050800,"name":"radar","full_name":"zendesk/radar","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/radar","description":"High level API and backend for writing web apps that use push messaging","fork":false,"url":"https://api.github.com/repos/zendesk/radar","forks_url":"https://api.github.com/repos/zendesk/radar/forks","keys_url":"https://api.github.com/repos/zendesk/radar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/radar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/radar/teams","hooks_url":"https://api.github.com/repos/zendesk/radar/hooks","issue_events_url":"https://api.github.com/repos/zendesk/radar/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/radar/events","assignees_url":"https://api.github.com/repos/zendesk/radar/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/radar/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/radar/tags","blobs_url":"https://api.github.com/repos/zendesk/radar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/radar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/radar/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/radar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/radar/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/radar/languages","stargazers_url":"https://api.github.com/repos/zendesk/radar/stargazers","contributors_url":"https://api.github.com/repos/zendesk/radar/contributors","subscribers_url":"https://api.github.com/repos/zendesk/radar/subscribers","subscription_url":"https://api.github.com/repos/zendesk/radar/subscription","commits_url":"https://api.github.com/repos/zendesk/radar/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/radar/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/radar/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/radar/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/radar/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/radar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/radar/merges","archive_url":"https://api.github.com/repos/zendesk/radar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/radar/downloads","issues_url":"https://api.github.com/repos/zendesk/radar/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/radar/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/radar/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/radar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/radar/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/radar/releases{/id}","created_at":"2012-10-02T20:15:07Z","updated_at":"2015-11-04T14:02:15Z","pushed_at":"2015-11-11T23:02:05Z","git_url":"git://github.com/zendesk/radar.git","ssh_url":"git@github.com:zendesk/radar.git","clone_url":"https://github.com/zendesk/radar.git","svn_url":"https://github.com/zendesk/radar","homepage":"http://radar.zendesk.com/","size":5676,"stargazers_count":165,"watchers_count":165,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":11,"forks":23,"open_issues":11,"watchers":165,"default_branch":"master"}},"base":{"label":"zendesk:master","ref":"master","sha":"dd647f42b8818f7fd23a9bcffcac96681412628c","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":6050800,"name":"radar","full_name":"zendesk/radar","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/radar","description":"High level API and backend for writing web apps that use push messaging","fork":false,"url":"https://api.github.com/repos/zendesk/radar","forks_url":"https://api.github.com/repos/zendesk/radar/forks","keys_url":"https://api.github.com/repos/zendesk/radar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/radar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/radar/teams","hooks_url":"https://api.github.com/repos/zendesk/radar/hooks","issue_events_url":"https://api.github.com/repos/zendesk/radar/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/radar/events","assignees_url":"https://api.github.com/repos/zendesk/radar/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/radar/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/radar/tags","blobs_url":"https://api.github.com/repos/zendesk/radar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/radar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/radar/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/radar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/radar/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/radar/languages","stargazers_url":"https://api.github.com/repos/zendesk/radar/stargazers","contributors_url":"https://api.github.com/repos/zendesk/radar/contributors","subscribers_url":"https://api.github.com/repos/zendesk/radar/subscribers","subscription_url":"https://api.github.com/repos/zendesk/radar/subscription","commits_url":"https://api.github.com/repos/zendesk/radar/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/radar/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/radar/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/radar/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/radar/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/radar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/radar/merges","archive_url":"https://api.github.com/repos/zendesk/radar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/radar/downloads","issues_url":"https://api.github.com/repos/zendesk/radar/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/radar/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/radar/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/radar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/radar/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/radar/releases{/id}","created_at":"2012-10-02T20:15:07Z","updated_at":"2015-11-04T14:02:15Z","pushed_at":"2015-11-11T23:02:05Z","git_url":"git://github.com/zendesk/radar.git","ssh_url":"git@github.com:zendesk/radar.git","clone_url":"https://github.com/zendesk/radar.git","svn_url":"https://github.com/zendesk/radar","homepage":"http://radar.zendesk.com/","size":5676,"stargazers_count":165,"watchers_count":165,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":11,"forks":23,"open_issues":11,"watchers":165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendesk/radar/pulls/189"},"html":{"href":"https://github.com/zendesk/radar/pull/189"},"issue":{"href":"https://api.github.com/repos/zendesk/radar/issues/189"},"comments":{"href":"https://api.github.com/repos/zendesk/radar/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/zendesk/radar/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/zendesk/radar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendesk/radar/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/zendesk/radar/statuses/795b3cf2630e894b41b810d889580828c5eced53"}}}}