{"action":"opened","issue":{"url":"https://api.github.com/repos/wilson0xb4/http-server/issues/7","labels_url":"https://api.github.com/repos/wilson0xb4/http-server/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/wilson0xb4/http-server/issues/7/comments","events_url":"https://api.github.com/repos/wilson0xb4/http-server/issues/7/events","html_url":"https://github.com/wilson0xb4/http-server/issues/7","id":93126599,"number":7,"title":"Refactor start_server for proper gevent integration","user":{"login":"jonathanstallings","id":10945369,"avatar_url":"https://avatars.githubusercontent.com/u/10945369?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanstallings","html_url":"https://github.com/jonathanstallings","followers_url":"https://api.github.com/users/jonathanstallings/followers","following_url":"https://api.github.com/users/jonathanstallings/following{/other_user}","gists_url":"https://api.github.com/users/jonathanstallings/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanstallings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanstallings/subscriptions","organizations_url":"https://api.github.com/users/jonathanstallings/orgs","repos_url":"https://api.github.com/users/jonathanstallings/repos","events_url":"https://api.github.com/users/jonathanstallings/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanstallings/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-07-05T17:02:59Z","updated_at":"2015-07-05T17:02:59Z","closed_at":null,"body":"See comment from Cris:\r\n\r\n>\r\nSince the gevent server is responsible for handling incoming connection requests, this outer loop and the try-except that allows using the keyboard to terminate the server is now useless. Your KeyboardInterrupt would never be caught by the handler because it's been shunted off to a separate greenlet. In fact, maintaining the loop here only ensures that each greenlet started by the gevent server to handle new connections will never terminate. That's not an outcome you want. Please fix this.\r\n"}}