{"action":"created","comment":{"url":"https://api.github.com/repos/lokalebasen/rconomic/pulls/comments/47008851","id":47008851,"diff_hunk":"@@ -8,6 +8,10 @@ class Economic::Endpoint\n   def_delegator \"client.globals\", :log_level, :log_level=\n   def_delegator \"client.globals\", :log, :log=\n \n+  def initialize(app_identifier = nil)","path":"lib/economic/endpoint.rb","position":4,"original_position":4,"commit_id":"15cb2f5cfdab1983a550e2c1f717612c8c4f6838","original_commit_id":"15cb2f5cfdab1983a550e2c1f717612c8c4f6838","user":{"login":"koppen","id":6480,"avatar_url":"https://avatars.githubusercontent.com/u/6480?v=3","gravatar_id":"","url":"https://api.github.com/users/koppen","html_url":"https://github.com/koppen","followers_url":"https://api.github.com/users/koppen/followers","following_url":"https://api.github.com/users/koppen/following{/other_user}","gists_url":"https://api.github.com/users/koppen/gists{/gist_id}","starred_url":"https://api.github.com/users/koppen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koppen/subscriptions","organizations_url":"https://api.github.com/users/koppen/orgs","repos_url":"https://api.github.com/users/koppen/repos","events_url":"https://api.github.com/users/koppen/events{/privacy}","received_events_url":"https://api.github.com/users/koppen/received_events","type":"User","site_admin":false},"body":"Can we add some documentation about what `app_identifier` is meant to be? Has E-conomic written something somewhere we can copy/paste and/or link to?","created_at":"2015-12-08T20:28:22Z","updated_at":"2015-12-08T20:28:22Z","html_url":"https://github.com/lokalebasen/rconomic/pull/42#discussion_r47008851","pull_request_url":"https://api.github.com/repos/lokalebasen/rconomic/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/lokalebasen/rconomic/pulls/comments/47008851"},"html":{"href":"https://github.com/lokalebasen/rconomic/pull/42#discussion_r47008851"},"pull_request":{"href":"https://api.github.com/repos/lokalebasen/rconomic/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/lokalebasen/rconomic/pulls/42","id":52947559,"html_url":"https://github.com/lokalebasen/rconomic/pull/42","diff_url":"https://github.com/lokalebasen/rconomic/pull/42.diff","patch_url":"https://github.com/lokalebasen/rconomic/pull/42.patch","issue_url":"https://api.github.com/repos/lokalebasen/rconomic/issues/42","number":42,"state":"open","locked":false,"title":"Initial support for X-EconomicAppIdentifier","user":{"login":"prognostikos","id":515254,"avatar_url":"https://avatars.githubusercontent.com/u/515254?v=3","gravatar_id":"","url":"https://api.github.com/users/prognostikos","html_url":"https://github.com/prognostikos","followers_url":"https://api.github.com/users/prognostikos/followers","following_url":"https://api.github.com/users/prognostikos/following{/other_user}","gists_url":"https://api.github.com/users/prognostikos/gists{/gist_id}","starred_url":"https://api.github.com/users/prognostikos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prognostikos/subscriptions","organizations_url":"https://api.github.com/users/prognostikos/orgs","repos_url":"https://api.github.com/users/prognostikos/repos","events_url":"https://api.github.com/users/prognostikos/events{/privacy}","received_events_url":"https://api.github.com/users/prognostikos/received_events","type":"User","site_admin":false},"body":"So here's a somewhat hacky solution.\r\n\r\nI couldn't easily see how to test if request headers are set when mocking requests, but I have run this on a production batch job that uses `connect_with_credentials` and it does work for me.","created_at":"2015-12-08T07:39:07Z","updated_at":"2015-12-08T20:28:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed7ddf723affb8618233259c165220648c5a272e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lokalebasen/rconomic/pulls/42/commits","review_comments_url":"https://api.github.com/repos/lokalebasen/rconomic/pulls/42/comments","review_comment_url":"https://api.github.com/repos/lokalebasen/rconomic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lokalebasen/rconomic/issues/42/comments","statuses_url":"https://api.github.com/repos/lokalebasen/rconomic/statuses/15cb2f5cfdab1983a550e2c1f717612c8c4f6838","head":{"label":"prognostikos:app-identifier","ref":"app-identifier","sha":"15cb2f5cfdab1983a550e2c1f717612c8c4f6838","user":{"login":"prognostikos","id":515254,"avatar_url":"https://avatars.githubusercontent.com/u/515254?v=3","gravatar_id":"","url":"https://api.github.com/users/prognostikos","html_url":"https://github.com/prognostikos","followers_url":"https://api.github.com/users/prognostikos/followers","following_url":"https://api.github.com/users/prognostikos/following{/other_user}","gists_url":"https://api.github.com/users/prognostikos/gists{/gist_id}","starred_url":"https://api.github.com/users/prognostikos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prognostikos/subscriptions","organizations_url":"https://api.github.com/users/prognostikos/orgs","repos_url":"https://api.github.com/users/prognostikos/repos","events_url":"https://api.github.com/users/prognostikos/events{/privacy}","received_events_url":"https://api.github.com/users/prognostikos/received_events","type":"User","site_admin":false},"repo":{"id":8872757,"name":"rconomic","full_name":"prognostikos/rconomic","owner":{"login":"prognostikos","id":515254,"avatar_url":"https://avatars.githubusercontent.com/u/515254?v=3","gravatar_id":"","url":"https://api.github.com/users/prognostikos","html_url":"https://github.com/prognostikos","followers_url":"https://api.github.com/users/prognostikos/followers","following_url":"https://api.github.com/users/prognostikos/following{/other_user}","gists_url":"https://api.github.com/users/prognostikos/gists{/gist_id}","starred_url":"https://api.github.com/users/prognostikos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prognostikos/subscriptions","organizations_url":"https://api.github.com/users/prognostikos/orgs","repos_url":"https://api.github.com/users/prognostikos/repos","events_url":"https://api.github.com/users/prognostikos/events{/privacy}","received_events_url":"https://api.github.com/users/prognostikos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prognostikos/rconomic","description":"Ruby wrapper for the e-conomic API - thankfully, integrating with e-conomic doesn't have to suck","fork":true,"url":"https://api.github.com/repos/prognostikos/rconomic","forks_url":"https://api.github.com/repos/prognostikos/rconomic/forks","keys_url":"https://api.github.com/repos/prognostikos/rconomic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prognostikos/rconomic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prognostikos/rconomic/teams","hooks_url":"https://api.github.com/repos/prognostikos/rconomic/hooks","issue_events_url":"https://api.github.com/repos/prognostikos/rconomic/issues/events{/number}","events_url":"https://api.github.com/repos/prognostikos/rconomic/events","assignees_url":"https://api.github.com/repos/prognostikos/rconomic/assignees{/user}","branches_url":"https://api.github.com/repos/prognostikos/rconomic/branches{/branch}","tags_url":"https://api.github.com/repos/prognostikos/rconomic/tags","blobs_url":"https://api.github.com/repos/prognostikos/rconomic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prognostikos/rconomic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prognostikos/rconomic/git/refs{/sha}","trees_url":"https://api.github.com/repos/prognostikos/rconomic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prognostikos/rconomic/statuses/{sha}","languages_url":"https://api.github.com/repos/prognostikos/rconomic/languages","stargazers_url":"https://api.github.com/repos/prognostikos/rconomic/stargazers","contributors_url":"https://api.github.com/repos/prognostikos/rconomic/contributors","subscribers_url":"https://api.github.com/repos/prognostikos/rconomic/subscribers","subscription_url":"https://api.github.com/repos/prognostikos/rconomic/subscription","commits_url":"https://api.github.com/repos/prognostikos/rconomic/commits{/sha}","git_commits_url":"https://api.github.com/repos/prognostikos/rconomic/git/commits{/sha}","comments_url":"https://api.github.com/repos/prognostikos/rconomic/comments{/number}","issue_comment_url":"https://api.github.com/repos/prognostikos/rconomic/issues/comments{/number}","contents_url":"https://api.github.com/repos/prognostikos/rconomic/contents/{+path}","compare_url":"https://api.github.com/repos/prognostikos/rconomic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prognostikos/rconomic/merges","archive_url":"https://api.github.com/repos/prognostikos/rconomic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prognostikos/rconomic/downloads","issues_url":"https://api.github.com/repos/prognostikos/rconomic/issues{/number}","pulls_url":"https://api.github.com/repos/prognostikos/rconomic/pulls{/number}","milestones_url":"https://api.github.com/repos/prognostikos/rconomic/milestones{/number}","notifications_url":"https://api.github.com/repos/prognostikos/rconomic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prognostikos/rconomic/labels{/name}","releases_url":"https://api.github.com/repos/prognostikos/rconomic/releases{/id}","created_at":"2013-03-19T07:04:32Z","updated_at":"2014-06-18T07:01:08Z","pushed_at":"2015-12-07T17:20:08Z","git_url":"git://github.com/prognostikos/rconomic.git","ssh_url":"git@github.com:prognostikos/rconomic.git","clone_url":"https://github.com/prognostikos/rconomic.git","svn_url":"https://github.com/prognostikos/rconomic","homepage":"","size":946,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lokalebasen:master","ref":"master","sha":"7f6ade9b86ed9fe89616bb159fc1c33782413ec0","user":{"login":"lokalebasen","id":33633,"avatar_url":"https://avatars.githubusercontent.com/u/33633?v=3","gravatar_id":"","url":"https://api.github.com/users/lokalebasen","html_url":"https://github.com/lokalebasen","followers_url":"https://api.github.com/users/lokalebasen/followers","following_url":"https://api.github.com/users/lokalebasen/following{/other_user}","gists_url":"https://api.github.com/users/lokalebasen/gists{/gist_id}","starred_url":"https://api.github.com/users/lokalebasen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lokalebasen/subscriptions","organizations_url":"https://api.github.com/users/lokalebasen/orgs","repos_url":"https://api.github.com/users/lokalebasen/repos","events_url":"https://api.github.com/users/lokalebasen/events{/privacy}","received_events_url":"https://api.github.com/users/lokalebasen/received_events","type":"Organization","site_admin":false},"repo":{"id":1911186,"name":"rconomic","full_name":"lokalebasen/rconomic","owner":{"login":"lokalebasen","id":33633,"avatar_url":"https://avatars.githubusercontent.com/u/33633?v=3","gravatar_id":"","url":"https://api.github.com/users/lokalebasen","html_url":"https://github.com/lokalebasen","followers_url":"https://api.github.com/users/lokalebasen/followers","following_url":"https://api.github.com/users/lokalebasen/following{/other_user}","gists_url":"https://api.github.com/users/lokalebasen/gists{/gist_id}","starred_url":"https://api.github.com/users/lokalebasen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lokalebasen/subscriptions","organizations_url":"https://api.github.com/users/lokalebasen/orgs","repos_url":"https://api.github.com/users/lokalebasen/repos","events_url":"https://api.github.com/users/lokalebasen/events{/privacy}","received_events_url":"https://api.github.com/users/lokalebasen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lokalebasen/rconomic","description":"Ruby wrapper for the e-conomic API - thankfully, integrating with e-conomic doesn't have to suck","fork":false,"url":"https://api.github.com/repos/lokalebasen/rconomic","forks_url":"https://api.github.com/repos/lokalebasen/rconomic/forks","keys_url":"https://api.github.com/repos/lokalebasen/rconomic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lokalebasen/rconomic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lokalebasen/rconomic/teams","hooks_url":"https://api.github.com/repos/lokalebasen/rconomic/hooks","issue_events_url":"https://api.github.com/repos/lokalebasen/rconomic/issues/events{/number}","events_url":"https://api.github.com/repos/lokalebasen/rconomic/events","assignees_url":"https://api.github.com/repos/lokalebasen/rconomic/assignees{/user}","branches_url":"https://api.github.com/repos/lokalebasen/rconomic/branches{/branch}","tags_url":"https://api.github.com/repos/lokalebasen/rconomic/tags","blobs_url":"https://api.github.com/repos/lokalebasen/rconomic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lokalebasen/rconomic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lokalebasen/rconomic/git/refs{/sha}","trees_url":"https://api.github.com/repos/lokalebasen/rconomic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lokalebasen/rconomic/statuses/{sha}","languages_url":"https://api.github.com/repos/lokalebasen/rconomic/languages","stargazers_url":"https://api.github.com/repos/lokalebasen/rconomic/stargazers","contributors_url":"https://api.github.com/repos/lokalebasen/rconomic/contributors","subscribers_url":"https://api.github.com/repos/lokalebasen/rconomic/subscribers","subscription_url":"https://api.github.com/repos/lokalebasen/rconomic/subscription","commits_url":"https://api.github.com/repos/lokalebasen/rconomic/commits{/sha}","git_commits_url":"https://api.github.com/repos/lokalebasen/rconomic/git/commits{/sha}","comments_url":"https://api.github.com/repos/lokalebasen/rconomic/comments{/number}","issue_comment_url":"https://api.github.com/repos/lokalebasen/rconomic/issues/comments{/number}","contents_url":"https://api.github.com/repos/lokalebasen/rconomic/contents/{+path}","compare_url":"https://api.github.com/repos/lokalebasen/rconomic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lokalebasen/rconomic/merges","archive_url":"https://api.github.com/repos/lokalebasen/rconomic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lokalebasen/rconomic/downloads","issues_url":"https://api.github.com/repos/lokalebasen/rconomic/issues{/number}","pulls_url":"https://api.github.com/repos/lokalebasen/rconomic/pulls{/number}","milestones_url":"https://api.github.com/repos/lokalebasen/rconomic/milestones{/number}","notifications_url":"https://api.github.com/repos/lokalebasen/rconomic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lokalebasen/rconomic/labels{/name}","releases_url":"https://api.github.com/repos/lokalebasen/rconomic/releases{/id}","created_at":"2011-06-17T13:52:00Z","updated_at":"2015-11-26T11:12:39Z","pushed_at":"2015-12-08T07:39:07Z","git_url":"git://github.com/lokalebasen/rconomic.git","ssh_url":"git@github.com:lokalebasen/rconomic.git","clone_url":"https://github.com/lokalebasen/rconomic.git","svn_url":"https://github.com/lokalebasen/rconomic","homepage":"","size":1689,"stargazers_count":21,"watchers_count":21,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":9,"forks":26,"open_issues":9,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lokalebasen/rconomic/pulls/42"},"html":{"href":"https://github.com/lokalebasen/rconomic/pull/42"},"issue":{"href":"https://api.github.com/repos/lokalebasen/rconomic/issues/42"},"comments":{"href":"https://api.github.com/repos/lokalebasen/rconomic/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/lokalebasen/rconomic/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/lokalebasen/rconomic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lokalebasen/rconomic/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/lokalebasen/rconomic/statuses/15cb2f5cfdab1983a550e2c1f717612c8c4f6838"}}}}