{"action":"created","issue":{"url":"https://api.github.com/repos/ambiata/icicle/issues/282","labels_url":"https://api.github.com/repos/ambiata/icicle/issues/282/labels{/name}","comments_url":"https://api.github.com/repos/ambiata/icicle/issues/282/comments","events_url":"https://api.github.com/repos/ambiata/icicle/issues/282/events","html_url":"https://github.com/ambiata/icicle/pull/282","id":120687788,"number":282,"title":"Text conversion cleanup","user":{"login":"jystic","id":134805,"avatar_url":"https://avatars.githubusercontent.com/u/134805?v=3","gravatar_id":"","url":"https://api.github.com/users/jystic","html_url":"https://github.com/jystic","followers_url":"https://api.github.com/users/jystic/followers","following_url":"https://api.github.com/users/jystic/following{/other_user}","gists_url":"https://api.github.com/users/jystic/gists{/gist_id}","starred_url":"https://api.github.com/users/jystic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jystic/subscriptions","organizations_url":"https://api.github.com/users/jystic/orgs","repos_url":"https://api.github.com/users/jystic/repos","events_url":"https://api.github.com/users/jystic/events{/privacy}","received_events_url":"https://api.github.com/users/jystic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-07T02:49:27Z","updated_at":"2015-12-07T08:11:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ambiata/icicle/pulls/282","html_url":"https://github.com/ambiata/icicle/pull/282","diff_url":"https://github.com/ambiata/icicle/pull/282.diff","patch_url":"https://github.com/ambiata/icicle/pull/282.patch"},"body":"I did a clean up of the current text conversion code to make it a bit easier to understand and more consistent. I thought it would be a good idea to do this before I start writing optimised versions of these functions."},"comment":{"url":"https://api.github.com/repos/ambiata/icicle/issues/comments/162444533","html_url":"https://github.com/ambiata/icicle/pull/282#issuecomment-162444533","issue_url":"https://api.github.com/repos/ambiata/icicle/issues/282","id":162444533,"user":{"login":"amosr","id":964498,"avatar_url":"https://avatars.githubusercontent.com/u/964498?v=3","gravatar_id":"","url":"https://api.github.com/users/amosr","html_url":"https://github.com/amosr","followers_url":"https://api.github.com/users/amosr/followers","following_url":"https://api.github.com/users/amosr/following{/other_user}","gists_url":"https://api.github.com/users/amosr/gists{/gist_id}","starred_url":"https://api.github.com/users/amosr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amosr/subscriptions","organizations_url":"https://api.github.com/users/amosr/orgs","repos_url":"https://api.github.com/users/amosr/repos","events_url":"https://api.github.com/users/amosr/events{/privacy}","received_events_url":"https://api.github.com/users/amosr/received_events","type":"User","site_admin":false},"created_at":"2015-12-07T08:11:15Z","updated_at":"2015-12-07T08:11:15Z","body":"somewhat unrelated, but while you're in there, perhaps make sure this time reading code won't dereference before the start of the buffer. (I guess you could also pad the start of the buffer if you wanted?)\r\nhttps://github.com/ambiata/icicle/blob/topic/text-conversion-cleanup/data/sea/52-psv.h#L116"}}