{"action":"closed","number":23,"pull_request":{"url":"https://api.github.com/repos/Teuniz/EDFbrowser/pulls/23","id":43126154,"html_url":"https://github.com/Teuniz/EDFbrowser/pull/23","diff_url":"https://github.com/Teuniz/EDFbrowser/pull/23.diff","patch_url":"https://github.com/Teuniz/EDFbrowser/pull/23.patch","issue_url":"https://api.github.com/repos/Teuniz/EDFbrowser/issues/23","number":23,"state":"closed","locked":false,"title":"Addition of the possibility to avoid filtering of channels when expor…","user":{"login":"Gijom","id":9466648,"avatar_url":"https://avatars.githubusercontent.com/u/9466648?v=3","gravatar_id":"","url":"https://api.github.com/users/Gijom","html_url":"https://github.com/Gijom","followers_url":"https://api.github.com/users/Gijom/followers","following_url":"https://api.github.com/users/Gijom/following{/other_user}","gists_url":"https://api.github.com/users/Gijom/gists{/gist_id}","starred_url":"https://api.github.com/users/Gijom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gijom/subscriptions","organizations_url":"https://api.github.com/users/Gijom/orgs","repos_url":"https://api.github.com/users/Gijom/repos","events_url":"https://api.github.com/users/Gijom/events{/privacy}","received_events_url":"https://api.github.com/users/Gijom/received_events","type":"User","site_admin":false},"body":"Adding the possibility to unselect channels to filter when converting from BDF to EDF\r\n- each channel filter can be unselected;\r\n- it results that this channel is not filtered and the filter cutoff it indicated as 0Hz in the EDF file.\r\n\r\n**Reason for the change:** I have BDF files from Biosemi Active II including a \"status\" channel. This channel should not be filtered since it contains triggers and other binary information which would be corrupted by the filter.\r\n\r\n**Main code changes:**\r\n- Addition of filter select boxes in the convert window (more precisely in `SignalsTablewidget`);\r\n- Extension of the window size to fit the new boxes, and adjustement of buttons, etc;\r\n- `filterlist` is set to NULL if the signal is not filtered, signals are filtered by default;\r\n- later if `filterlist` is NULL than no filter is applied and 0Hz is written in `scratchpad`.\r\n\r\n**Advantages:**\r\n- more flexibility for special signals (e.g. status channel but also other \"homemade\" sensors plugged in the front box of the Biosemi);\r\n- previously the result of the `createfilter` function was never tested althought it could return NULL in case of memory allocation problems This implementation solves potential crashes since in this case the signal would simply not be filtered.\r\n\r\n**Disavantage:** in the case the `createfilter` function returns NULL there would be no error/warning and the unfiltered signal output would go against user expectations. Note that this could be solved easily, it was just not the goal of this modification.\r\n\r\nI hope this could be of interest to you. Thanks for keeping me aware.\r\n","created_at":"2015-08-23T18:44:56Z","updated_at":"2015-08-24T11:18:17Z","closed_at":"2015-08-24T11:18:17Z","merged_at":null,"merge_commit_sha":"417f1fd62eff88de976ba948990e09b97af605b4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Teuniz/EDFbrowser/pulls/23/commits","review_comments_url":"https://api.github.com/repos/Teuniz/EDFbrowser/pulls/23/comments","review_comment_url":"https://api.github.com/repos/Teuniz/EDFbrowser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Teuniz/EDFbrowser/issues/23/comments","statuses_url":"https://api.github.com/repos/Teuniz/EDFbrowser/statuses/e7e6c18f77f4a0cefd59f468d91c4edc15f65df0","head":{"label":"Gijom:master","ref":"master","sha":"e7e6c18f77f4a0cefd59f468d91c4edc15f65df0","user":{"login":"Gijom","id":9466648,"avatar_url":"https://avatars.githubusercontent.com/u/9466648?v=3","gravatar_id":"","url":"https://api.github.com/users/Gijom","html_url":"https://github.com/Gijom","followers_url":"https://api.github.com/users/Gijom/followers","following_url":"https://api.github.com/users/Gijom/following{/other_user}","gists_url":"https://api.github.com/users/Gijom/gists{/gist_id}","starred_url":"https://api.github.com/users/Gijom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gijom/subscriptions","organizations_url":"https://api.github.com/users/Gijom/orgs","repos_url":"https://api.github.com/users/Gijom/repos","events_url":"https://api.github.com/users/Gijom/events{/privacy}","received_events_url":"https://api.github.com/users/Gijom/received_events","type":"User","site_admin":false},"repo":{"id":41261642,"name":"EDFbrowser","full_name":"Gijom/EDFbrowser","owner":{"login":"Gijom","id":9466648,"avatar_url":"https://avatars.githubusercontent.com/u/9466648?v=3","gravatar_id":"","url":"https://api.github.com/users/Gijom","html_url":"https://github.com/Gijom","followers_url":"https://api.github.com/users/Gijom/followers","following_url":"https://api.github.com/users/Gijom/following{/other_user}","gists_url":"https://api.github.com/users/Gijom/gists{/gist_id}","starred_url":"https://api.github.com/users/Gijom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gijom/subscriptions","organizations_url":"https://api.github.com/users/Gijom/orgs","repos_url":"https://api.github.com/users/Gijom/repos","events_url":"https://api.github.com/users/Gijom/events{/privacy}","received_events_url":"https://api.github.com/users/Gijom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Gijom/EDFbrowser","description":"A free, opensource, multiplatform, universal viewer and toolbox intended for, but not limited to, timeseries storage files like EEG, EMG, ECG, BioImpedance, etc.","fork":true,"url":"https://api.github.com/repos/Gijom/EDFbrowser","forks_url":"https://api.github.com/repos/Gijom/EDFbrowser/forks","keys_url":"https://api.github.com/repos/Gijom/EDFbrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gijom/EDFbrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gijom/EDFbrowser/teams","hooks_url":"https://api.github.com/repos/Gijom/EDFbrowser/hooks","issue_events_url":"https://api.github.com/repos/Gijom/EDFbrowser/issues/events{/number}","events_url":"https://api.github.com/repos/Gijom/EDFbrowser/events","assignees_url":"https://api.github.com/repos/Gijom/EDFbrowser/assignees{/user}","branches_url":"https://api.github.com/repos/Gijom/EDFbrowser/branches{/branch}","tags_url":"https://api.github.com/repos/Gijom/EDFbrowser/tags","blobs_url":"https://api.github.com/repos/Gijom/EDFbrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gijom/EDFbrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gijom/EDFbrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gijom/EDFbrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gijom/EDFbrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/Gijom/EDFbrowser/languages","stargazers_url":"https://api.github.com/repos/Gijom/EDFbrowser/stargazers","contributors_url":"https://api.github.com/repos/Gijom/EDFbrowser/contributors","subscribers_url":"https://api.github.com/repos/Gijom/EDFbrowser/subscribers","subscription_url":"https://api.github.com/repos/Gijom/EDFbrowser/subscription","commits_url":"https://api.github.com/repos/Gijom/EDFbrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gijom/EDFbrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gijom/EDFbrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gijom/EDFbrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gijom/EDFbrowser/contents/{+path}","compare_url":"https://api.github.com/repos/Gijom/EDFbrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gijom/EDFbrowser/merges","archive_url":"https://api.github.com/repos/Gijom/EDFbrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gijom/EDFbrowser/downloads","issues_url":"https://api.github.com/repos/Gijom/EDFbrowser/issues{/number}","pulls_url":"https://api.github.com/repos/Gijom/EDFbrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/Gijom/EDFbrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/Gijom/EDFbrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gijom/EDFbrowser/labels{/name}","releases_url":"https://api.github.com/repos/Gijom/EDFbrowser/releases{/id}","created_at":"2015-08-23T18:26:09Z","updated_at":"2015-08-23T18:26:10Z","pushed_at":"2015-08-23T18:28:49Z","git_url":"git://github.com/Gijom/EDFbrowser.git","ssh_url":"git@github.com:Gijom/EDFbrowser.git","clone_url":"https://github.com/Gijom/EDFbrowser.git","svn_url":"https://github.com/Gijom/EDFbrowser","homepage":null,"size":1658,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Teuniz:master","ref":"master","sha":"30e9eb55f9e6953076416e4e4c0fbe7852257901","user":{"login":"Teuniz","id":4106831,"avatar_url":"https://avatars.githubusercontent.com/u/4106831?v=3","gravatar_id":"","url":"https://api.github.com/users/Teuniz","html_url":"https://github.com/Teuniz","followers_url":"https://api.github.com/users/Teuniz/followers","following_url":"https://api.github.com/users/Teuniz/following{/other_user}","gists_url":"https://api.github.com/users/Teuniz/gists{/gist_id}","starred_url":"https://api.github.com/users/Teuniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teuniz/subscriptions","organizations_url":"https://api.github.com/users/Teuniz/orgs","repos_url":"https://api.github.com/users/Teuniz/repos","events_url":"https://api.github.com/users/Teuniz/events{/privacy}","received_events_url":"https://api.github.com/users/Teuniz/received_events","type":"User","site_admin":false},"repo":{"id":9328108,"name":"EDFbrowser","full_name":"Teuniz/EDFbrowser","owner":{"login":"Teuniz","id":4106831,"avatar_url":"https://avatars.githubusercontent.com/u/4106831?v=3","gravatar_id":"","url":"https://api.github.com/users/Teuniz","html_url":"https://github.com/Teuniz","followers_url":"https://api.github.com/users/Teuniz/followers","following_url":"https://api.github.com/users/Teuniz/following{/other_user}","gists_url":"https://api.github.com/users/Teuniz/gists{/gist_id}","starred_url":"https://api.github.com/users/Teuniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teuniz/subscriptions","organizations_url":"https://api.github.com/users/Teuniz/orgs","repos_url":"https://api.github.com/users/Teuniz/repos","events_url":"https://api.github.com/users/Teuniz/events{/privacy}","received_events_url":"https://api.github.com/users/Teuniz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Teuniz/EDFbrowser","description":"A free, opensource, multiplatform, universal viewer and toolbox intended for, but not limited to, timeseries storage files like EEG, EMG, ECG, BioImpedance, etc.","fork":false,"url":"https://api.github.com/repos/Teuniz/EDFbrowser","forks_url":"https://api.github.com/repos/Teuniz/EDFbrowser/forks","keys_url":"https://api.github.com/repos/Teuniz/EDFbrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Teuniz/EDFbrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Teuniz/EDFbrowser/teams","hooks_url":"https://api.github.com/repos/Teuniz/EDFbrowser/hooks","issue_events_url":"https://api.github.com/repos/Teuniz/EDFbrowser/issues/events{/number}","events_url":"https://api.github.com/repos/Teuniz/EDFbrowser/events","assignees_url":"https://api.github.com/repos/Teuniz/EDFbrowser/assignees{/user}","branches_url":"https://api.github.com/repos/Teuniz/EDFbrowser/branches{/branch}","tags_url":"https://api.github.com/repos/Teuniz/EDFbrowser/tags","blobs_url":"https://api.github.com/repos/Teuniz/EDFbrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Teuniz/EDFbrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Teuniz/EDFbrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/Teuniz/EDFbrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Teuniz/EDFbrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/Teuniz/EDFbrowser/languages","stargazers_url":"https://api.github.com/repos/Teuniz/EDFbrowser/stargazers","contributors_url":"https://api.github.com/repos/Teuniz/EDFbrowser/contributors","subscribers_url":"https://api.github.com/repos/Teuniz/EDFbrowser/subscribers","subscription_url":"https://api.github.com/repos/Teuniz/EDFbrowser/subscription","commits_url":"https://api.github.com/repos/Teuniz/EDFbrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/Teuniz/EDFbrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/Teuniz/EDFbrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/Teuniz/EDFbrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/Teuniz/EDFbrowser/contents/{+path}","compare_url":"https://api.github.com/repos/Teuniz/EDFbrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Teuniz/EDFbrowser/merges","archive_url":"https://api.github.com/repos/Teuniz/EDFbrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Teuniz/EDFbrowser/downloads","issues_url":"https://api.github.com/repos/Teuniz/EDFbrowser/issues{/number}","pulls_url":"https://api.github.com/repos/Teuniz/EDFbrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/Teuniz/EDFbrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/Teuniz/EDFbrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Teuniz/EDFbrowser/labels{/name}","releases_url":"https://api.github.com/repos/Teuniz/EDFbrowser/releases{/id}","created_at":"2013-04-09T18:10:41Z","updated_at":"2015-08-11T19:03:48Z","pushed_at":"2015-08-23T18:44:58Z","git_url":"git://github.com/Teuniz/EDFbrowser.git","ssh_url":"git@github.com:Teuniz/EDFbrowser.git","clone_url":"https://github.com/Teuniz/EDFbrowser.git","svn_url":"https://github.com/Teuniz/EDFbrowser","homepage":null,"size":6495,"stargazers_count":16,"watchers_count":16,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Teuniz/EDFbrowser/pulls/23"},"html":{"href":"https://github.com/Teuniz/EDFbrowser/pull/23"},"issue":{"href":"https://api.github.com/repos/Teuniz/EDFbrowser/issues/23"},"comments":{"href":"https://api.github.com/repos/Teuniz/EDFbrowser/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/Teuniz/EDFbrowser/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/Teuniz/EDFbrowser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Teuniz/EDFbrowser/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/Teuniz/EDFbrowser/statuses/e7e6c18f77f4a0cefd59f468d91c4edc15f65df0"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":34,"deletions":16,"changed_files":1}}