{"action":"created","issue":{"url":"https://api.github.com/repos/shpakovski/MASShortcut/issues/42","labels_url":"https://api.github.com/repos/shpakovski/MASShortcut/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/shpakovski/MASShortcut/issues/42/comments","events_url":"https://api.github.com/repos/shpakovski/MASShortcut/issues/42/events","html_url":"https://github.com/shpakovski/MASShortcut/pull/42","id":39526666,"number":42,"title":"Major library refactoring","user":{"login":"zoul","id":95329,"avatar_url":"https://avatars.githubusercontent.com/u/95329?v=3","gravatar_id":"","url":"https://api.github.com/users/zoul","html_url":"https://github.com/zoul","followers_url":"https://api.github.com/users/zoul/followers","following_url":"https://api.github.com/users/zoul/following{/other_user}","gists_url":"https://api.github.com/users/zoul/gists{/gist_id}","starred_url":"https://api.github.com/users/zoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoul/subscriptions","organizations_url":"https://api.github.com/users/zoul/orgs","repos_url":"https://api.github.com/users/zoul/repos","events_url":"https://api.github.com/users/zoul/events{/privacy}","received_events_url":"https://api.github.com/users/zoul/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2014-08-05T14:51:10Z","updated_at":"2015-01-05T16:12:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/shpakovski/MASShortcut/pulls/42","html_url":"https://github.com/shpakovski/MASShortcut/pull/42","diff_url":"https://github.com/shpakovski/MASShortcut/pull/42.diff","patch_url":"https://github.com/shpakovski/MASShortcut/pull/42.patch"},"body":"See the commit logs for a changelog and rationale. I hope that the changes improve code readability and maintainability and can be merged. It would be a shame for `MASShortcut` to evolve into the hairy ball that became of Shortcut Recorder.\r\n\r\nTo be done:\r\n\r\n- [x] Introduce a separate dispatcher class to bind shortcuts to actions?\r\n- [x] Introduce a separate class to persist bindings to user defaults?\r\n- [x] Add a convenience API to register default shortcuts.\r\n- [x] Write code to enable backward compatibility with Shortcut Recorder?\r\n- [x] Add a simple wrapper API atop the new classes to simplify usage?\r\n- [x] Update documentation\r\n- [x] Normalize whitespace\r\n\r\nIf there are any code style issues, I propose to resolve them later, after merging, preferably using an automated tool."},"comment":{"url":"https://api.github.com/repos/shpakovski/MASShortcut/issues/comments/68730282","html_url":"https://github.com/shpakovski/MASShortcut/pull/42#issuecomment-68730282","issue_url":"https://api.github.com/repos/shpakovski/MASShortcut/issues/42","id":68730282,"user":{"login":"zoul","id":95329,"avatar_url":"https://avatars.githubusercontent.com/u/95329?v=3","gravatar_id":"","url":"https://api.github.com/users/zoul","html_url":"https://github.com/zoul","followers_url":"https://api.github.com/users/zoul/followers","following_url":"https://api.github.com/users/zoul/following{/other_user}","gists_url":"https://api.github.com/users/zoul/gists{/gist_id}","starred_url":"https://api.github.com/users/zoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoul/subscriptions","organizations_url":"https://api.github.com/users/zoul/orgs","repos_url":"https://api.github.com/users/zoul/repos","events_url":"https://api.github.com/users/zoul/events{/privacy}","received_events_url":"https://api.github.com/users/zoul/received_events","type":"User","site_admin":false},"created_at":"2015-01-05T16:12:39Z","updated_at":"2015-01-05T16:12:39Z","body":"Is there any chance of this getting merged, possibly making a 2.0 release as discussed above? The proposed changes no longer apply, but right now I could put some more work to update them for your current master. If we don’t merge the code now, the codebases will soon diverge for good. I think that would be a pity, for both sides."}}