{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/29884180","id":29884180,"diff_hunk":"@@ -55,10 +55,27 @@ clone git github.com/docker/libtrust 230dfd18c232\n \n clone git github.com/Sirupsen/logrus v0.7.2\n \n-clone git github.com/go-fsnotify/fsnotify v1.2.0\n+clone git github.com/go-fsnotify/fsnotify v1.0.4","path":"hack/vendor.sh","position":5,"original_position":5,"commit_id":"87267458d544b63ab4daa91fe36c0b5fb0ef74f3","original_commit_id":"87267458d544b63ab4daa91fe36c0b5fb0ef74f3","user":{"login":"LK4D4","id":101445,"avatar_url":"https://avatars.githubusercontent.com/u/101445?v=3","gravatar_id":"","url":"https://api.github.com/users/LK4D4","html_url":"https://github.com/LK4D4","followers_url":"https://api.github.com/users/LK4D4/followers","following_url":"https://api.github.com/users/LK4D4/following{/other_user}","gists_url":"https://api.github.com/users/LK4D4/gists{/gist_id}","starred_url":"https://api.github.com/users/LK4D4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LK4D4/subscriptions","organizations_url":"https://api.github.com/users/LK4D4/orgs","repos_url":"https://api.github.com/users/LK4D4/repos","events_url":"https://api.github.com/users/LK4D4/events{/privacy}","received_events_url":"https://api.github.com/users/LK4D4/received_events","type":"User","site_admin":false},"body":"You downgraded fsnotify :)","created_at":"2015-05-07T18:56:11Z","updated_at":"2015-05-07T18:56:11Z","html_url":"https://github.com/docker/docker/pull/12876#discussion_r29884180","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/12876","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/29884180"},"html":{"href":"https://github.com/docker/docker/pull/12876#discussion_r29884180"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/12876"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/12876","id":34375444,"html_url":"https://github.com/docker/docker/pull/12876","diff_url":"https://github.com/docker/docker/pull/12876.diff","patch_url":"https://github.com/docker/docker/pull/12876.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/12876","number":12876,"state":"open","locked":false,"title":"Add new Logging driver \"fluentd\"","user":{"login":"tagomoris","id":230654,"avatar_url":"https://avatars.githubusercontent.com/u/230654?v=3","gravatar_id":"","url":"https://api.github.com/users/tagomoris","html_url":"https://github.com/tagomoris","followers_url":"https://api.github.com/users/tagomoris/followers","following_url":"https://api.github.com/users/tagomoris/following{/other_user}","gists_url":"https://api.github.com/users/tagomoris/gists{/gist_id}","starred_url":"https://api.github.com/users/tagomoris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tagomoris/subscriptions","organizations_url":"https://api.github.com/users/tagomoris/orgs","repos_url":"https://api.github.com/users/tagomoris/repos","events_url":"https://api.github.com/users/tagomoris/events{/privacy}","received_events_url":"https://api.github.com/users/tagomoris/received_events","type":"User","site_admin":false},"body":"This patch provides `fluentd` logging plugin for docker, which is mentioned at #12540.\r\n\r\nHow to confirm behavior of this patch/new logging driver.\r\n1. Setup dev docker container\r\n2. Build repository with this patch by `make BINDDIR=. binary`\r\n3. Copy binary and execute it in debug mode `docker -dD`\r\n4. Attach from external environment by `docker exec -it kickass_heisenberg /bin/bash`\r\n5. Build/execute another docker container from other console, built on Dockerfile and configuration file below:\r\n```\r\n# sh\r\n$ docker run --net=container:kickass_heisenberg tagomoris/docker-fluentd\r\n# Dockerfile\r\nFROM kiyoto/fluentd:0.10.56-2.1.1\r\nMAINTAINER kiyoto@treausure-data.com\r\nRUN mkdir /etc/fluent\r\nADD fluent.conf /etc/fluent/\r\nENTRYPOINT [\"/usr/local/bin/fluentd\", \"-c\", \"/etc/fluent/fluent.conf\"]\r\n# fluent.conf\r\n<source>\r\n  type forward\r\n</source>\r\n<match docker.**>\r\n  type stdout\r\n</match>\r\n```\r\n6. Execute hello-world container on attached environment: `docker run --log-driver=fluentd hello-world`\r\n7. Got logs\r\n```\r\n2015-04-20 09:32:27 +0000 [info]: starting fluentd-0.10.56\r\n2015-04-20 09:32:27 +0000 [info]: reading config file path=\"/etc/fluent/fluent.conf\"\r\n2015-04-20 09:32:27 +0000 [info]: gem 'fluentd' version '0.10.56'\r\n2015-04-20 09:32:27 +0000 [info]: using configuration file: <ROOT>\r\n  <source>\r\n    type forward\r\n  </source>\r\n  <match docker.**>\r\n    type stdout\r\n  </match>\r\n</ROOT>\r\n2015-04-20 09:32:27 +0000 [info]: adding source type=\"forward\"\r\n2015-04-20 09:32:27 +0000 [info]: adding match pattern=\"docker.**\" type=\"stdout\"\r\n2015-04-20 09:32:27 +0000 [info]: listening fluent socket on 0.0.0.0:24224\r\n2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {\"source\":\"stdout\",\"log\":\"Hello from Docker.\"}\r\n2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {\"source\":\"stdout\",\"log\":\"This message shows that your installation appears to be working correctly.\"}\r\n2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {\"log\":\"\",\"source\":\"stdout\"}\r\n2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {\"source\":\"stdout\",\"log\":\"To generate this message, Docker took the following steps:\"}\r\n2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {\"source\":\"stdout\",\"log\":\" 1. The Docker client contacted the Docker daemon.\"}\r\n2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {\"source\":\"stdout\",\"log\":\" 2. The Docker daemon pulled the \\\"hello-world\\\" image from the Docker Hub.\"}\r\n2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {\"source\":\"stdout\",\"log\":\"    (Assuming it was not already locally available.)\"}\r\n2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {\"source\":\"stdout\",\"log\":\" 3. The Docker daemon created a new container from that image which runs the\"}\r\n2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {\"source\":\"stdout\",\"log\":\"    executable that produces the output you are currently reading.\"}\r\n2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {\"source\":\"stdout\",\"log\":\" 4. The Docker daemon streamed that output to the Docker client, which sent it\"}\r\n2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {\"source\":\"stdout\",\"log\":\"    to your terminal.\"}\r\n2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {\"source\":\"stdout\",\"log\":\"\"}\r\n2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {\"source\":\"stdout\",\"log\":\"To try something more ambitious, you can run an Ubuntu container with:\"}\r\n2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {\"source\":\"stdout\",\"log\":\" $ docker run -it ubuntu bash\"}\r\n2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {\"source\":\"stdout\",\"log\":\"\"}\r\n2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {\"source\":\"stdout\",\"log\":\"For more examples and ideas, visit:\"}\r\n2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {\"source\":\"stdout\",\"log\":\" http://docs.docker.com/userguide/\"}\r\n```","created_at":"2015-04-29T15:35:08Z","updated_at":"2015-05-07T18:56:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d3eb76845de11bd1382c603638ffd1444162f36","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/12876/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/12876/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/12876/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/87267458d544b63ab4daa91fe36c0b5fb0ef74f3","head":{"label":"tagomoris:logger-driver-fluentd","ref":"logger-driver-fluentd","sha":"87267458d544b63ab4daa91fe36c0b5fb0ef74f3","user":{"login":"tagomoris","id":230654,"avatar_url":"https://avatars.githubusercontent.com/u/230654?v=3","gravatar_id":"","url":"https://api.github.com/users/tagomoris","html_url":"https://github.com/tagomoris","followers_url":"https://api.github.com/users/tagomoris/followers","following_url":"https://api.github.com/users/tagomoris/following{/other_user}","gists_url":"https://api.github.com/users/tagomoris/gists{/gist_id}","starred_url":"https://api.github.com/users/tagomoris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tagomoris/subscriptions","organizations_url":"https://api.github.com/users/tagomoris/orgs","repos_url":"https://api.github.com/users/tagomoris/repos","events_url":"https://api.github.com/users/tagomoris/events{/privacy}","received_events_url":"https://api.github.com/users/tagomoris/received_events","type":"User","site_admin":false},"repo":{"id":34241942,"name":"docker","full_name":"tagomoris/docker","owner":{"login":"tagomoris","id":230654,"avatar_url":"https://avatars.githubusercontent.com/u/230654?v=3","gravatar_id":"","url":"https://api.github.com/users/tagomoris","html_url":"https://github.com/tagomoris","followers_url":"https://api.github.com/users/tagomoris/followers","following_url":"https://api.github.com/users/tagomoris/following{/other_user}","gists_url":"https://api.github.com/users/tagomoris/gists{/gist_id}","starred_url":"https://api.github.com/users/tagomoris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tagomoris/subscriptions","organizations_url":"https://api.github.com/users/tagomoris/orgs","repos_url":"https://api.github.com/users/tagomoris/repos","events_url":"https://api.github.com/users/tagomoris/events{/privacy}","received_events_url":"https://api.github.com/users/tagomoris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tagomoris/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/tagomoris/docker","forks_url":"https://api.github.com/repos/tagomoris/docker/forks","keys_url":"https://api.github.com/repos/tagomoris/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tagomoris/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tagomoris/docker/teams","hooks_url":"https://api.github.com/repos/tagomoris/docker/hooks","issue_events_url":"https://api.github.com/repos/tagomoris/docker/issues/events{/number}","events_url":"https://api.github.com/repos/tagomoris/docker/events","assignees_url":"https://api.github.com/repos/tagomoris/docker/assignees{/user}","branches_url":"https://api.github.com/repos/tagomoris/docker/branches{/branch}","tags_url":"https://api.github.com/repos/tagomoris/docker/tags","blobs_url":"https://api.github.com/repos/tagomoris/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tagomoris/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tagomoris/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/tagomoris/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tagomoris/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/tagomoris/docker/languages","stargazers_url":"https://api.github.com/repos/tagomoris/docker/stargazers","contributors_url":"https://api.github.com/repos/tagomoris/docker/contributors","subscribers_url":"https://api.github.com/repos/tagomoris/docker/subscribers","subscription_url":"https://api.github.com/repos/tagomoris/docker/subscription","commits_url":"https://api.github.com/repos/tagomoris/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/tagomoris/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/tagomoris/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/tagomoris/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/tagomoris/docker/contents/{+path}","compare_url":"https://api.github.com/repos/tagomoris/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tagomoris/docker/merges","archive_url":"https://api.github.com/repos/tagomoris/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tagomoris/docker/downloads","issues_url":"https://api.github.com/repos/tagomoris/docker/issues{/number}","pulls_url":"https://api.github.com/repos/tagomoris/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/tagomoris/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/tagomoris/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tagomoris/docker/labels{/name}","releases_url":"https://api.github.com/repos/tagomoris/docker/releases{/id}","created_at":"2015-04-20T06:21:19Z","updated_at":"2015-04-21T03:35:33Z","pushed_at":"2015-05-05T05:20:48Z","git_url":"git://github.com/tagomoris/docker.git","ssh_url":"git@github.com:tagomoris/docker.git","clone_url":"https://github.com/tagomoris/docker.git","svn_url":"https://github.com/tagomoris/docker","homepage":"http://www.docker.com","size":52798,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"677b962642da7778105f68ecc64f34b9ea3b7f05","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-05-07T18:43:05Z","pushed_at":"2015-05-07T18:50:21Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":199830,"stargazers_count":21427,"watchers_count":21427,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5014,"mirror_url":null,"open_issues_count":965,"forks":5014,"open_issues":965,"watchers":21427,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/12876"},"html":{"href":"https://github.com/docker/docker/pull/12876"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/12876"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/12876/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/12876/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/12876/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/87267458d544b63ab4daa91fe36c0b5fb0ef74f3"}}}}