{"action":"created","comment":{"url":"https://api.github.com/repos/web-animations/web-animations-next/pulls/comments/23743303","id":23743303,"diff_hunk":"@@ -125,7 +126,6 @@\n       return player._inTimeline;\n     });\n \n-    pendingEffects.length = 0;\n     pendingEffects.push.apply(pendingEffects, newPendingClears);\n     pendingEffects.push.apply(pendingEffects, newPendingEffects);","path":"src/tick.js","position":14,"original_position":14,"commit_id":"21a0cd146bc0b881673d888bc55388906e405864","original_commit_id":"21a0cd146bc0b881673d888bc55388906e405864","user":{"login":"dstockwell","id":539597,"avatar_url":"https://avatars.githubusercontent.com/u/539597?v=3","gravatar_id":"","url":"https://api.github.com/users/dstockwell","html_url":"https://github.com/dstockwell","followers_url":"https://api.github.com/users/dstockwell/followers","following_url":"https://api.github.com/users/dstockwell/following{/other_user}","gists_url":"https://api.github.com/users/dstockwell/gists{/gist_id}","starred_url":"https://api.github.com/users/dstockwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dstockwell/subscriptions","organizations_url":"https://api.github.com/users/dstockwell/orgs","repos_url":"https://api.github.com/users/dstockwell/repos","events_url":"https://api.github.com/users/dstockwell/events{/privacy}","received_events_url":"https://api.github.com/users/dstockwell/received_events","type":"User","site_admin":false},"body":"It seems like we can end up with the same effects repeated multiple times in `pendingEffects`, can we dedupe this list before applying?","created_at":"2015-01-29T02:42:17Z","updated_at":"2015-01-29T02:42:17Z","html_url":"https://github.com/web-animations/web-animations-next/pull/282#discussion_r23743303","pull_request_url":"https://api.github.com/repos/web-animations/web-animations-next/pulls/282","_links":{"self":{"href":"https://api.github.com/repos/web-animations/web-animations-next/pulls/comments/23743303"},"html":{"href":"https://github.com/web-animations/web-animations-next/pull/282#discussion_r23743303"},"pull_request":{"href":"https://api.github.com/repos/web-animations/web-animations-next/pulls/282"}}},"pull_request":{"url":"https://api.github.com/repos/web-animations/web-animations-next/pulls/282","id":28249195,"html_url":"https://github.com/web-animations/web-animations-next/pull/282","diff_url":"https://github.com/web-animations/web-animations-next/pull/282.diff","patch_url":"https://github.com/web-animations/web-animations-next/pull/282.patch","issue_url":"https://api.github.com/repos/web-animations/web-animations-next/issues/282","number":282,"state":"open","locked":false,"title":"Only clear pending effects once they have been applied","user":{"login":"rjwright","id":4714151,"avatar_url":"https://avatars.githubusercontent.com/u/4714151?v=3","gravatar_id":"","url":"https://api.github.com/users/rjwright","html_url":"https://github.com/rjwright","followers_url":"https://api.github.com/users/rjwright/followers","following_url":"https://api.github.com/users/rjwright/following{/other_user}","gists_url":"https://api.github.com/users/rjwright/gists{/gist_id}","starred_url":"https://api.github.com/users/rjwright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjwright/subscriptions","organizations_url":"https://api.github.com/users/rjwright/orgs","repos_url":"https://api.github.com/users/rjwright/repos","events_url":"https://api.github.com/users/rjwright/events{/privacy}","received_events_url":"https://api.github.com/users/rjwright/received_events","type":"User","site_admin":false},"body":"This fixes a bug where a group who has fill none, and whose children also have fill none, doesn't cancel its effects when it finishes.","created_at":"2015-01-29T02:32:50Z","updated_at":"2015-01-29T02:42:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/web-animations/web-animations-next/pulls/282/commits","review_comments_url":"https://api.github.com/repos/web-animations/web-animations-next/pulls/282/comments","review_comment_url":"https://api.github.com/repos/web-animations/web-animations-next/pulls/comments/{number}","comments_url":"https://api.github.com/repos/web-animations/web-animations-next/issues/282/comments","statuses_url":"https://api.github.com/repos/web-animations/web-animations-next/statuses/21a0cd146bc0b881673d888bc55388906e405864","head":{"label":"rjwright:FixClearingPendingEffects","ref":"FixClearingPendingEffects","sha":"21a0cd146bc0b881673d888bc55388906e405864","user":{"login":"rjwright","id":4714151,"avatar_url":"https://avatars.githubusercontent.com/u/4714151?v=3","gravatar_id":"","url":"https://api.github.com/users/rjwright","html_url":"https://github.com/rjwright","followers_url":"https://api.github.com/users/rjwright/followers","following_url":"https://api.github.com/users/rjwright/following{/other_user}","gists_url":"https://api.github.com/users/rjwright/gists{/gist_id}","starred_url":"https://api.github.com/users/rjwright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjwright/subscriptions","organizations_url":"https://api.github.com/users/rjwright/orgs","repos_url":"https://api.github.com/users/rjwright/repos","events_url":"https://api.github.com/users/rjwright/events{/privacy}","received_events_url":"https://api.github.com/users/rjwright/received_events","type":"User","site_admin":false},"repo":{"id":20790385,"name":"web-animations-next","full_name":"rjwright/web-animations-next","owner":{"login":"rjwright","id":4714151,"avatar_url":"https://avatars.githubusercontent.com/u/4714151?v=3","gravatar_id":"","url":"https://api.github.com/users/rjwright","html_url":"https://github.com/rjwright","followers_url":"https://api.github.com/users/rjwright/followers","following_url":"https://api.github.com/users/rjwright/following{/other_user}","gists_url":"https://api.github.com/users/rjwright/gists{/gist_id}","starred_url":"https://api.github.com/users/rjwright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjwright/subscriptions","organizations_url":"https://api.github.com/users/rjwright/orgs","repos_url":"https://api.github.com/users/rjwright/repos","events_url":"https://api.github.com/users/rjwright/events{/privacy}","received_events_url":"https://api.github.com/users/rjwright/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rjwright/web-animations-next","description":"Soon to replace web-animations-js","fork":true,"url":"https://api.github.com/repos/rjwright/web-animations-next","forks_url":"https://api.github.com/repos/rjwright/web-animations-next/forks","keys_url":"https://api.github.com/repos/rjwright/web-animations-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rjwright/web-animations-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rjwright/web-animations-next/teams","hooks_url":"https://api.github.com/repos/rjwright/web-animations-next/hooks","issue_events_url":"https://api.github.com/repos/rjwright/web-animations-next/issues/events{/number}","events_url":"https://api.github.com/repos/rjwright/web-animations-next/events","assignees_url":"https://api.github.com/repos/rjwright/web-animations-next/assignees{/user}","branches_url":"https://api.github.com/repos/rjwright/web-animations-next/branches{/branch}","tags_url":"https://api.github.com/repos/rjwright/web-animations-next/tags","blobs_url":"https://api.github.com/repos/rjwright/web-animations-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rjwright/web-animations-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rjwright/web-animations-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/rjwright/web-animations-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rjwright/web-animations-next/statuses/{sha}","languages_url":"https://api.github.com/repos/rjwright/web-animations-next/languages","stargazers_url":"https://api.github.com/repos/rjwright/web-animations-next/stargazers","contributors_url":"https://api.github.com/repos/rjwright/web-animations-next/contributors","subscribers_url":"https://api.github.com/repos/rjwright/web-animations-next/subscribers","subscription_url":"https://api.github.com/repos/rjwright/web-animations-next/subscription","commits_url":"https://api.github.com/repos/rjwright/web-animations-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/rjwright/web-animations-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/rjwright/web-animations-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/rjwright/web-animations-next/issues/comments/{number}","contents_url":"https://api.github.com/repos/rjwright/web-animations-next/contents/{+path}","compare_url":"https://api.github.com/repos/rjwright/web-animations-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rjwright/web-animations-next/merges","archive_url":"https://api.github.com/repos/rjwright/web-animations-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rjwright/web-animations-next/downloads","issues_url":"https://api.github.com/repos/rjwright/web-animations-next/issues{/number}","pulls_url":"https://api.github.com/repos/rjwright/web-animations-next/pulls{/number}","milestones_url":"https://api.github.com/repos/rjwright/web-animations-next/milestones{/number}","notifications_url":"https://api.github.com/repos/rjwright/web-animations-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rjwright/web-animations-next/labels{/name}","releases_url":"https://api.github.com/repos/rjwright/web-animations-next/releases{/id}","created_at":"2014-06-13T03:01:47Z","updated_at":"2014-10-17T09:22:43Z","pushed_at":"2015-01-29T02:30:20Z","git_url":"git://github.com/rjwright/web-animations-next.git","ssh_url":"git@github.com:rjwright/web-animations-next.git","clone_url":"https://github.com/rjwright/web-animations-next.git","svn_url":"https://github.com/rjwright/web-animations-next","homepage":null,"size":1565,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"web-animations:master","ref":"master","sha":"3214ff2628baf1aa89798e3b707ded51b378fff1","user":{"login":"web-animations","id":2975912,"avatar_url":"https://avatars.githubusercontent.com/u/2975912?v=3","gravatar_id":"","url":"https://api.github.com/users/web-animations","html_url":"https://github.com/web-animations","followers_url":"https://api.github.com/users/web-animations/followers","following_url":"https://api.github.com/users/web-animations/following{/other_user}","gists_url":"https://api.github.com/users/web-animations/gists{/gist_id}","starred_url":"https://api.github.com/users/web-animations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/web-animations/subscriptions","organizations_url":"https://api.github.com/users/web-animations/orgs","repos_url":"https://api.github.com/users/web-animations/repos","events_url":"https://api.github.com/users/web-animations/events{/privacy}","received_events_url":"https://api.github.com/users/web-animations/received_events","type":"Organization","site_admin":false},"repo":{"id":20545443,"name":"web-animations-next","full_name":"web-animations/web-animations-next","owner":{"login":"web-animations","id":2975912,"avatar_url":"https://avatars.githubusercontent.com/u/2975912?v=3","gravatar_id":"","url":"https://api.github.com/users/web-animations","html_url":"https://github.com/web-animations","followers_url":"https://api.github.com/users/web-animations/followers","following_url":"https://api.github.com/users/web-animations/following{/other_user}","gists_url":"https://api.github.com/users/web-animations/gists{/gist_id}","starred_url":"https://api.github.com/users/web-animations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/web-animations/subscriptions","organizations_url":"https://api.github.com/users/web-animations/orgs","repos_url":"https://api.github.com/users/web-animations/repos","events_url":"https://api.github.com/users/web-animations/events{/privacy}","received_events_url":"https://api.github.com/users/web-animations/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/web-animations/web-animations-next","description":"Development repository for web-animations-js:","fork":false,"url":"https://api.github.com/repos/web-animations/web-animations-next","forks_url":"https://api.github.com/repos/web-animations/web-animations-next/forks","keys_url":"https://api.github.com/repos/web-animations/web-animations-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/web-animations/web-animations-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/web-animations/web-animations-next/teams","hooks_url":"https://api.github.com/repos/web-animations/web-animations-next/hooks","issue_events_url":"https://api.github.com/repos/web-animations/web-animations-next/issues/events{/number}","events_url":"https://api.github.com/repos/web-animations/web-animations-next/events","assignees_url":"https://api.github.com/repos/web-animations/web-animations-next/assignees{/user}","branches_url":"https://api.github.com/repos/web-animations/web-animations-next/branches{/branch}","tags_url":"https://api.github.com/repos/web-animations/web-animations-next/tags","blobs_url":"https://api.github.com/repos/web-animations/web-animations-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/web-animations/web-animations-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/web-animations/web-animations-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/web-animations/web-animations-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/web-animations/web-animations-next/statuses/{sha}","languages_url":"https://api.github.com/repos/web-animations/web-animations-next/languages","stargazers_url":"https://api.github.com/repos/web-animations/web-animations-next/stargazers","contributors_url":"https://api.github.com/repos/web-animations/web-animations-next/contributors","subscribers_url":"https://api.github.com/repos/web-animations/web-animations-next/subscribers","subscription_url":"https://api.github.com/repos/web-animations/web-animations-next/subscription","commits_url":"https://api.github.com/repos/web-animations/web-animations-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/web-animations/web-animations-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/web-animations/web-animations-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/web-animations/web-animations-next/issues/comments/{number}","contents_url":"https://api.github.com/repos/web-animations/web-animations-next/contents/{+path}","compare_url":"https://api.github.com/repos/web-animations/web-animations-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/web-animations/web-animations-next/merges","archive_url":"https://api.github.com/repos/web-animations/web-animations-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/web-animations/web-animations-next/downloads","issues_url":"https://api.github.com/repos/web-animations/web-animations-next/issues{/number}","pulls_url":"https://api.github.com/repos/web-animations/web-animations-next/pulls{/number}","milestones_url":"https://api.github.com/repos/web-animations/web-animations-next/milestones{/number}","notifications_url":"https://api.github.com/repos/web-animations/web-animations-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/web-animations/web-animations-next/labels{/name}","releases_url":"https://api.github.com/repos/web-animations/web-animations-next/releases{/id}","created_at":"2014-06-05T23:47:19Z","updated_at":"2015-01-28T05:51:55Z","pushed_at":"2015-01-28T05:51:55Z","git_url":"git://github.com/web-animations/web-animations-next.git","ssh_url":"git@github.com:web-animations/web-animations-next.git","clone_url":"https://github.com/web-animations/web-animations-next.git","svn_url":"https://github.com/web-animations/web-animations-next","homepage":"https://github.com/web-animations/web-animations-js","size":2487,"stargazers_count":54,"watchers_count":54,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":27,"forks":18,"open_issues":27,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/web-animations/web-animations-next/pulls/282"},"html":{"href":"https://github.com/web-animations/web-animations-next/pull/282"},"issue":{"href":"https://api.github.com/repos/web-animations/web-animations-next/issues/282"},"comments":{"href":"https://api.github.com/repos/web-animations/web-animations-next/issues/282/comments"},"review_comments":{"href":"https://api.github.com/repos/web-animations/web-animations-next/pulls/282/comments"},"review_comment":{"href":"https://api.github.com/repos/web-animations/web-animations-next/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/web-animations/web-animations-next/pulls/282/commits"},"statuses":{"href":"https://api.github.com/repos/web-animations/web-animations-next/statuses/21a0cd146bc0b881673d888bc55388906e405864"}}}}