{"action":"closed","issue":{"url":"https://api.github.com/repos/ga4gh/server/issues/222","labels_url":"https://api.github.com/repos/ga4gh/server/issues/222/labels{/name}","comments_url":"https://api.github.com/repos/ga4gh/server/issues/222/comments","events_url":"https://api.github.com/repos/ga4gh/server/issues/222/events","html_url":"https://github.com/ga4gh/server/issues/222","id":60384037,"number":222,"title":"Unit tests required for SimulatedBackend","user":{"login":"jeromekelleher","id":2664569,"avatar_url":"https://avatars.githubusercontent.com/u/2664569?v=3","gravatar_id":"","url":"https://api.github.com/users/jeromekelleher","html_url":"https://github.com/jeromekelleher","followers_url":"https://api.github.com/users/jeromekelleher/followers","following_url":"https://api.github.com/users/jeromekelleher/following{/other_user}","gists_url":"https://api.github.com/users/jeromekelleher/gists{/gist_id}","starred_url":"https://api.github.com/users/jeromekelleher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeromekelleher/subscriptions","organizations_url":"https://api.github.com/users/jeromekelleher/orgs","repos_url":"https://api.github.com/users/jeromekelleher/repos","events_url":"https://api.github.com/users/jeromekelleher/events{/privacy}","received_events_url":"https://api.github.com/users/jeromekelleher/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ga4gh/server/labels/help%20wanted","name":"help wanted","color":"159818"}],"state":"closed","locked":false,"assignee":{"login":"dcolligan","id":7422120,"avatar_url":"https://avatars.githubusercontent.com/u/7422120?v=3","gravatar_id":"","url":"https://api.github.com/users/dcolligan","html_url":"https://github.com/dcolligan","followers_url":"https://api.github.com/users/dcolligan/followers","following_url":"https://api.github.com/users/dcolligan/following{/other_user}","gists_url":"https://api.github.com/users/dcolligan/gists{/gist_id}","starred_url":"https://api.github.com/users/dcolligan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcolligan/subscriptions","organizations_url":"https://api.github.com/users/dcolligan/orgs","repos_url":"https://api.github.com/users/dcolligan/repos","events_url":"https://api.github.com/users/dcolligan/events{/privacy}","received_events_url":"https://api.github.com/users/dcolligan/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ga4gh/server/milestones/1","html_url":"https://github.com/ga4gh/server/milestones/0.1.0%20beta%20release","labels_url":"https://api.github.com/repos/ga4gh/server/milestones/1/labels","id":1016275,"number":1,"title":"0.1.0 beta release","description":"The reference server needs an initial release that can be deployed. For this we need\r\n\r\n1. Removal of the wormtable dependency as documented in #210.\r\n2. An updated README, with clear instructions for deployment on (say) Apache and Ubuntu.\r\n3. Solid VCF/BCF support.\r\n4. Initial support for reads and references.\r\n5. Good scores on the existing JS compliance test.\r\n\r\n","creator":{"login":"jeromekelleher","id":2664569,"avatar_url":"https://avatars.githubusercontent.com/u/2664569?v=3","gravatar_id":"","url":"https://api.github.com/users/jeromekelleher","html_url":"https://github.com/jeromekelleher","followers_url":"https://api.github.com/users/jeromekelleher/followers","following_url":"https://api.github.com/users/jeromekelleher/following{/other_user}","gists_url":"https://api.github.com/users/jeromekelleher/gists{/gist_id}","starred_url":"https://api.github.com/users/jeromekelleher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeromekelleher/subscriptions","organizations_url":"https://api.github.com/users/jeromekelleher/orgs","repos_url":"https://api.github.com/users/jeromekelleher/repos","events_url":"https://api.github.com/users/jeromekelleher/events{/privacy}","received_events_url":"https://api.github.com/users/jeromekelleher/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":2,"state":"open","created_at":"2015-03-11T12:07:32Z","updated_at":"2015-03-12T11:43:14Z","due_on":"2015-04-02T23:00:00Z","closed_at":null},"comments":1,"created_at":"2015-03-09T17:59:15Z","updated_at":"2015-03-12T11:43:14Z","closed_at":"2015-03-12T11:43:14Z","body":"We need some basic tests for the simulator, to ensure that it works reasonably sensibly. We should make a new test module, `tests/test_simulator.py`, and create a test class in there, `TestVariantSet`. This class should test (e.g.)\r\n\r\n1. The values passed into the constructor are stored correctly (after adding getter methods). For example, we'd want to check `self.assertEqual(seed, simulator.getRandomSeed()).\r\n2. The variants we generate have the required properties (i.e., `start` and `end` are in the correct range).\r\n3. The variants we generate are consistent. That is, if we allocate two simulators with the same seed and other parameters, they should produce identical variants when called on the same data.\r\n4. The variants produced are `self-consistent`. This means that if we run the same query on a variantset more than once, we get the same result back.\r\n\r\nThese tests should be run at the VariantSet level. That is, we allocate instances of `datamodel.variants.SimulatedVariantSet`; we do not allocate any instances of `Backend`."}}