{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/mercury/pulls/comments/29228923","id":29228923,"diff_hunk":"@@ -0,0 +1,58 @@\n+class AutoTab {\n+\tinput: HTMLInputElement;\n+\tform: HTMLFormElement;\n+\tmax: number;\n+\n+\tconstructor(input: HTMLInputElement) {\n+\t\tthis.input = input;\n+\t\tthis.form = input.form;\n+\t\tthis.max = parseInt(input.getAttribute('data-max-length'));\n+\t}\n+\n+\tpublic init(): void {","path":"front/scripts/auth/component/AutoTab.ts","position":12,"original_position":12,"commit_id":"698f8852e337a9d43a3eee9efe565ba6c2635218","original_commit_id":"657a173572ee65ba1e91c0297e4de162bcd56576","user":{"login":"bkoval","id":2035428,"avatar_url":"https://avatars.githubusercontent.com/u/2035428?v=3","gravatar_id":"","url":"https://api.github.com/users/bkoval","html_url":"https://github.com/bkoval","followers_url":"https://api.github.com/users/bkoval/followers","following_url":"https://api.github.com/users/bkoval/following{/other_user}","gists_url":"https://api.github.com/users/bkoval/gists{/gist_id}","starred_url":"https://api.github.com/users/bkoval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkoval/subscriptions","organizations_url":"https://api.github.com/users/bkoval/orgs","repos_url":"https://api.github.com/users/bkoval/repos","events_url":"https://api.github.com/users/bkoval/events{/privacy}","received_events_url":"https://api.github.com/users/bkoval/received_events","type":"User","site_admin":false},"body":"I agree with that, we should seperate instantiation of the object and any background actions to be taken by it.","created_at":"2015-04-28T10:02:11Z","updated_at":"2015-04-28T10:02:11Z","html_url":"https://github.com/Wikia/mercury/pull/712#discussion_r29228923","pull_request_url":"https://api.github.com/repos/Wikia/mercury/pulls/712","_links":{"self":{"href":"https://api.github.com/repos/Wikia/mercury/pulls/comments/29228923"},"html":{"href":"https://github.com/Wikia/mercury/pull/712#discussion_r29228923"},"pull_request":{"href":"https://api.github.com/repos/Wikia/mercury/pulls/712"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/mercury/pulls/712","id":33897970,"html_url":"https://github.com/Wikia/mercury/pull/712","diff_url":"https://github.com/Wikia/mercury/pull/712.diff","patch_url":"https://github.com/Wikia/mercury/pull/712.patch","issue_url":"https://api.github.com/repos/Wikia/mercury/issues/712","number":712,"state":"closed","locked":false,"title":"SOC-480 Internationalized birthdate input for the Login MVP","user":{"login":"lizlux","id":201367,"avatar_url":"https://avatars.githubusercontent.com/u/201367?v=3","gravatar_id":"","url":"https://api.github.com/users/lizlux","html_url":"https://github.com/lizlux","followers_url":"https://api.github.com/users/lizlux/followers","following_url":"https://api.github.com/users/lizlux/following{/other_user}","gists_url":"https://api.github.com/users/lizlux/gists{/gist_id}","starred_url":"https://api.github.com/users/lizlux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizlux/subscriptions","organizations_url":"https://api.github.com/users/lizlux/orgs","repos_url":"https://api.github.com/users/lizlux/repos","events_url":"https://api.github.com/users/lizlux/events{/privacy}","received_events_url":"https://api.github.com/users/lizlux/received_events","type":"User","site_admin":false},"body":"This adds a birthdate field that can be localized to the a user's language. Since the user is logged out, language will be gathered from the Accepts-Language header, \"lang\" cookie, or \"uselang\" param in the query string. It includes an auto-tab feature that will tab to the next input when a set max characters for an input is reached. \r\n\r\nNotes: \r\n* This doesn't include validation for when a user enters an invalid value. \r\n* The birthdate value is ultimately stored and the \"birthdate\" form input, so on submit, that is the value that should be stored in the DB. \r\n* The \"floating label\" interaction will be done with a separate ticket\r\n* There's some issues with the way hapi-i18next handles cookies so it's best to test this feature wtih `?uselang=xx` in the querystring rather than updating your cookies or Accepts-Language header, at least until https://github.com/kenkouot/hapi-i18next/pull/4 is merged. See `/front/locales/xx/auth.json` for supported languages, including different versions of English. \r\n\r\nTo do: \r\n* [ ] Create ticket for floating label interaction\r\n* [ ] Respond to feedback and merge https://github.com/kenkouot/hapi-i18next/pull/4, then updated dependency in mercury repo. \r\n* [ ] Double check for typescript errors","created_at":"2015-04-22T20:31:12Z","updated_at":"2015-04-28T10:02:11Z","closed_at":"2015-04-27T23:30:57Z","merged_at":null,"merge_commit_sha":"d92e40ce9197c0480f1216b76ac3a9f2c6681fac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/mercury/pulls/712/commits","review_comments_url":"https://api.github.com/repos/Wikia/mercury/pulls/712/comments","review_comment_url":"https://api.github.com/repos/Wikia/mercury/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/mercury/issues/712/comments","statuses_url":"https://api.github.com/repos/Wikia/mercury/statuses/698f8852e337a9d43a3eee9efe565ba6c2635218","head":{"label":"Wikia:SOC-480","ref":"SOC-480","sha":"698f8852e337a9d43a3eee9efe565ba6c2635218","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":16710430,"name":"mercury","full_name":"Wikia/mercury","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/mercury","description":"Wikia Web application","fork":false,"url":"https://api.github.com/repos/Wikia/mercury","forks_url":"https://api.github.com/repos/Wikia/mercury/forks","keys_url":"https://api.github.com/repos/Wikia/mercury/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/mercury/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/mercury/teams","hooks_url":"https://api.github.com/repos/Wikia/mercury/hooks","issue_events_url":"https://api.github.com/repos/Wikia/mercury/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/mercury/events","assignees_url":"https://api.github.com/repos/Wikia/mercury/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/mercury/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/mercury/tags","blobs_url":"https://api.github.com/repos/Wikia/mercury/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/mercury/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/mercury/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/mercury/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/mercury/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/mercury/languages","stargazers_url":"https://api.github.com/repos/Wikia/mercury/stargazers","contributors_url":"https://api.github.com/repos/Wikia/mercury/contributors","subscribers_url":"https://api.github.com/repos/Wikia/mercury/subscribers","subscription_url":"https://api.github.com/repos/Wikia/mercury/subscription","commits_url":"https://api.github.com/repos/Wikia/mercury/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/mercury/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/mercury/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/mercury/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/mercury/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/mercury/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/mercury/merges","archive_url":"https://api.github.com/repos/Wikia/mercury/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/mercury/downloads","issues_url":"https://api.github.com/repos/Wikia/mercury/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/mercury/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/mercury/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/mercury/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/mercury/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/mercury/releases{/id}","created_at":"2014-02-10T21:44:25Z","updated_at":"2015-04-28T00:09:25Z","pushed_at":"2015-04-28T06:42:11Z","git_url":"git://github.com/Wikia/mercury.git","ssh_url":"git@github.com:Wikia/mercury.git","clone_url":"https://github.com/Wikia/mercury.git","svn_url":"https://github.com/Wikia/mercury","homepage":"","size":21070,"stargazers_count":10,"watchers_count":10,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":10,"default_branch":"dev"}},"base":{"label":"Wikia:SOC-489","ref":"SOC-489","sha":"2e3e51a6a231a18023c0934937f7617fdbafb905","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":16710430,"name":"mercury","full_name":"Wikia/mercury","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/mercury","description":"Wikia Web application","fork":false,"url":"https://api.github.com/repos/Wikia/mercury","forks_url":"https://api.github.com/repos/Wikia/mercury/forks","keys_url":"https://api.github.com/repos/Wikia/mercury/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/mercury/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/mercury/teams","hooks_url":"https://api.github.com/repos/Wikia/mercury/hooks","issue_events_url":"https://api.github.com/repos/Wikia/mercury/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/mercury/events","assignees_url":"https://api.github.com/repos/Wikia/mercury/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/mercury/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/mercury/tags","blobs_url":"https://api.github.com/repos/Wikia/mercury/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/mercury/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/mercury/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/mercury/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/mercury/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/mercury/languages","stargazers_url":"https://api.github.com/repos/Wikia/mercury/stargazers","contributors_url":"https://api.github.com/repos/Wikia/mercury/contributors","subscribers_url":"https://api.github.com/repos/Wikia/mercury/subscribers","subscription_url":"https://api.github.com/repos/Wikia/mercury/subscription","commits_url":"https://api.github.com/repos/Wikia/mercury/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/mercury/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/mercury/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/mercury/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/mercury/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/mercury/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/mercury/merges","archive_url":"https://api.github.com/repos/Wikia/mercury/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/mercury/downloads","issues_url":"https://api.github.com/repos/Wikia/mercury/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/mercury/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/mercury/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/mercury/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/mercury/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/mercury/releases{/id}","created_at":"2014-02-10T21:44:25Z","updated_at":"2015-04-28T00:09:25Z","pushed_at":"2015-04-28T06:42:11Z","git_url":"git://github.com/Wikia/mercury.git","ssh_url":"git@github.com:Wikia/mercury.git","clone_url":"https://github.com/Wikia/mercury.git","svn_url":"https://github.com/Wikia/mercury","homepage":"","size":21070,"stargazers_count":10,"watchers_count":10,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":10,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/mercury/pulls/712"},"html":{"href":"https://github.com/Wikia/mercury/pull/712"},"issue":{"href":"https://api.github.com/repos/Wikia/mercury/issues/712"},"comments":{"href":"https://api.github.com/repos/Wikia/mercury/issues/712/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/mercury/pulls/712/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/mercury/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/mercury/pulls/712/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/mercury/statuses/698f8852e337a9d43a3eee9efe565ba6c2635218"}}}}