{"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/45531456","id":45531456,"diff_hunk":"@@ -289,63 +289,81 @@ class FE_DGPNonparametric : public FiniteElement<dim,spacedim>\n   requires_update_flags (const UpdateFlags update_flags) const;\n \n   /**\n-   * Return the value of the @p ith shape function at the point @p p. See the\n-   * FiniteElement base class for more information about the semantics of this\n-   * function.\n+   * This function is intended to return the value of a shape function\n+   * at a point on the reference cell. However, since the current element\n+   * does not implement shape functions by mapping from a reference cell,\n+   * no shape functions exist on the reference cell.\n+   *\n+   * Consequently, as discussed in the corresponding function in the base\n+   * class, FiniteElement::shape_value(), this function throws an exception\n+   * of type FiniteElement::ExcUnitShapeValuesDoNotExist.\n    */\n   virtual double shape_value (const unsigned int i,\n                               const Point<dim> &p) const;\n \n   /**\n-   * Return the value of the @p componentth vector component of the @p ith\n-   * shape function at the point @p p. See the FiniteElement base class for\n-   * more information about the semantics of this function.\n+   * This function is intended to return the value of a shape function","path":"include/deal.II/fe/fe_dgp_nonparametric.h","position":23,"original_position":23,"commit_id":"82559cb7fb43f2d05f79d775a22e48fb564f7cac","original_commit_id":"82559cb7fb43f2d05f79d775a22e48fb564f7cac","user":{"login":"davydden","id":8023934,"avatar_url":"https://avatars.githubusercontent.com/u/8023934?v=3","gravatar_id":"","url":"https://api.github.com/users/davydden","html_url":"https://github.com/davydden","followers_url":"https://api.github.com/users/davydden/followers","following_url":"https://api.github.com/users/davydden/following{/other_user}","gists_url":"https://api.github.com/users/davydden/gists{/gist_id}","starred_url":"https://api.github.com/users/davydden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davydden/subscriptions","organizations_url":"https://api.github.com/users/davydden/orgs","repos_url":"https://api.github.com/users/davydden/repos","events_url":"https://api.github.com/users/davydden/events{/privacy}","received_events_url":"https://api.github.com/users/davydden/received_events","type":"User","site_admin":false},"body":"should it not be something like:  \".. the @p componentth of a shape function...\" to make it different from the previous function?","created_at":"2015-11-20T23:16:35Z","updated_at":"2015-11-20T23:16:35Z","html_url":"https://github.com/dealii/dealii/pull/1891#discussion_r45531456","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/1891","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/45531456"},"html":{"href":"https://github.com/dealii/dealii/pull/1891#discussion_r45531456"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/1891"}}},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/1891","id":51418718,"html_url":"https://github.com/dealii/dealii/pull/1891","diff_url":"https://github.com/dealii/dealii/pull/1891.diff","patch_url":"https://github.com/dealii/dealii/pull/1891.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/1891","number":1891,"state":"open","locked":false,"title":"Adjust FE_DGPNonparametric to not return values on the reference cell.","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"body":"This is because the element does not define its shape functions by mapping\nfrom the reference cell, so evaluating anything on the reference cell\nmakes no sense. Fix this by throwing an exception, as discussed in\nthe documentation of the corresponding functions in the base class.\n\n\nThis fixes #1870. In reference to #1198 and #1864.","created_at":"2015-11-20T22:48:17Z","updated_at":"2015-11-20T23:16:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1efd86aa065079d928d185585dacca1fd9ceb47","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/1891/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/1891/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/1891/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/82559cb7fb43f2d05f79d775a22e48fb564f7cac","head":{"label":"bangerth:fix-FE_DGPNonparametric","ref":"fix-FE_DGPNonparametric","sha":"82559cb7fb43f2d05f79d775a22e48fb564f7cac","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"repo":{"id":22048720,"name":"dealii","full_name":"bangerth/dealii","owner":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bangerth/dealii","description":"","fork":true,"url":"https://api.github.com/repos/bangerth/dealii","forks_url":"https://api.github.com/repos/bangerth/dealii/forks","keys_url":"https://api.github.com/repos/bangerth/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bangerth/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bangerth/dealii/teams","hooks_url":"https://api.github.com/repos/bangerth/dealii/hooks","issue_events_url":"https://api.github.com/repos/bangerth/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/bangerth/dealii/events","assignees_url":"https://api.github.com/repos/bangerth/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/bangerth/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/bangerth/dealii/tags","blobs_url":"https://api.github.com/repos/bangerth/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bangerth/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bangerth/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/bangerth/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bangerth/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/bangerth/dealii/languages","stargazers_url":"https://api.github.com/repos/bangerth/dealii/stargazers","contributors_url":"https://api.github.com/repos/bangerth/dealii/contributors","subscribers_url":"https://api.github.com/repos/bangerth/dealii/subscribers","subscription_url":"https://api.github.com/repos/bangerth/dealii/subscription","commits_url":"https://api.github.com/repos/bangerth/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/bangerth/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/bangerth/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/bangerth/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/bangerth/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/bangerth/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bangerth/dealii/merges","archive_url":"https://api.github.com/repos/bangerth/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bangerth/dealii/downloads","issues_url":"https://api.github.com/repos/bangerth/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/bangerth/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/bangerth/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/bangerth/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bangerth/dealii/labels{/name}","releases_url":"https://api.github.com/repos/bangerth/dealii/releases{/id}","created_at":"2014-07-21T02:07:57Z","updated_at":"2015-05-08T16:15:38Z","pushed_at":"2015-11-20T22:46:59Z","git_url":"git://github.com/bangerth/dealii.git","ssh_url":"git@github.com:bangerth/dealii.git","clone_url":"https://github.com/bangerth/dealii.git","svn_url":"https://github.com/bangerth/dealii","homepage":null,"size":127249,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"47f796d0b4217b134ba5746e90aa5263b6e34592","user":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","created_at":"2014-07-17T14:00:26Z","updated_at":"2015-11-18T23:20:55Z","pushed_at":"2015-11-20T22:48:18Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"git@github.com:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":134923,"stargazers_count":103,"watchers_count":103,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":130,"mirror_url":null,"open_issues_count":138,"forks":130,"open_issues":138,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/1891"},"html":{"href":"https://github.com/dealii/dealii/pull/1891"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/1891"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/1891/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/1891/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/1891/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/82559cb7fb43f2d05f79d775a22e48fb564f7cac"}}}}