{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/23618779","id":23618779,"diff_hunk":"@@ -23,6 +23,8 @@ import (\n \t\"strings\"\n \t\"sync\"\n \n+\t\"github.com/cockroachdb/cockroach/gossip\"","path":"multiraft/transport.go","position":4,"original_position":4,"commit_id":"a772d48171e485199fa1db09c8e3a0bace7a7cda","original_commit_id":"a772d48171e485199fa1db09c8e3a0bace7a7cda","user":{"login":"bdarnell","id":160562,"avatar_url":"https://avatars.githubusercontent.com/u/160562?v=3","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},"body":"multiraft shouldn't import gossip (it is at least in principle independent from the rest of cockroach). This cockroach-specific RPCTransport should live elsewhere, probably either cockroach/rpc or cockroach/server.","created_at":"2015-01-27T16:08:08Z","updated_at":"2015-01-27T16:08:08Z","html_url":"https://github.com/cockroachdb/cockroach/pull/292#discussion_r23618779","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/292","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/23618779"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/292#discussion_r23618779"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/292"}}},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/292","id":28092768,"html_url":"https://github.com/cockroachdb/cockroach/pull/292","diff_url":"https://github.com/cockroachdb/cockroach/pull/292.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/292.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/292","number":292,"state":"open","locked":false,"title":"WIP: Add Multiraft transport implementation.","user":{"login":"tnachen","id":67244,"avatar_url":"https://avatars.githubusercontent.com/u/67244?v=3","gravatar_id":"","url":"https://api.github.com/users/tnachen","html_url":"https://github.com/tnachen","followers_url":"https://api.github.com/users/tnachen/followers","following_url":"https://api.github.com/users/tnachen/following{/other_user}","gists_url":"https://api.github.com/users/tnachen/gists{/gist_id}","starred_url":"https://api.github.com/users/tnachen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnachen/subscriptions","organizations_url":"https://api.github.com/users/tnachen/orgs","repos_url":"https://api.github.com/users/tnachen/repos","events_url":"https://api.github.com/users/tnachen/events{/privacy}","received_events_url":"https://api.github.com/users/tnachen/received_events","type":"User","site_admin":false},"body":"I haven't added any test, but this is my first patch for cockroach (and pretty much my foray into golang).\r\nSo want to put up a early review to make sure I'm not going down a wrong path.","created_at":"2015-01-27T09:04:29Z","updated_at":"2015-01-27T16:08:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3317110057082830c72391c6fed3db47deddf42a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/292/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/292/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/292/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/a772d48171e485199fa1db09c8e3a0bace7a7cda","head":{"label":"tnachen:raft_transport","ref":"raft_transport","sha":"a772d48171e485199fa1db09c8e3a0bace7a7cda","user":{"login":"tnachen","id":67244,"avatar_url":"https://avatars.githubusercontent.com/u/67244?v=3","gravatar_id":"","url":"https://api.github.com/users/tnachen","html_url":"https://github.com/tnachen","followers_url":"https://api.github.com/users/tnachen/followers","following_url":"https://api.github.com/users/tnachen/following{/other_user}","gists_url":"https://api.github.com/users/tnachen/gists{/gist_id}","starred_url":"https://api.github.com/users/tnachen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnachen/subscriptions","organizations_url":"https://api.github.com/users/tnachen/orgs","repos_url":"https://api.github.com/users/tnachen/repos","events_url":"https://api.github.com/users/tnachen/events{/privacy}","received_events_url":"https://api.github.com/users/tnachen/received_events","type":"User","site_admin":false},"repo":{"id":28047999,"name":"cockroach","full_name":"tnachen/cockroach","owner":{"login":"tnachen","id":67244,"avatar_url":"https://avatars.githubusercontent.com/u/67244?v=3","gravatar_id":"","url":"https://api.github.com/users/tnachen","html_url":"https://github.com/tnachen","followers_url":"https://api.github.com/users/tnachen/followers","following_url":"https://api.github.com/users/tnachen/following{/other_user}","gists_url":"https://api.github.com/users/tnachen/gists{/gist_id}","starred_url":"https://api.github.com/users/tnachen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnachen/subscriptions","organizations_url":"https://api.github.com/users/tnachen/orgs","repos_url":"https://api.github.com/users/tnachen/repos","events_url":"https://api.github.com/users/tnachen/events{/privacy}","received_events_url":"https://api.github.com/users/tnachen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tnachen/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":true,"url":"https://api.github.com/repos/tnachen/cockroach","forks_url":"https://api.github.com/repos/tnachen/cockroach/forks","keys_url":"https://api.github.com/repos/tnachen/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tnachen/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tnachen/cockroach/teams","hooks_url":"https://api.github.com/repos/tnachen/cockroach/hooks","issue_events_url":"https://api.github.com/repos/tnachen/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/tnachen/cockroach/events","assignees_url":"https://api.github.com/repos/tnachen/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/tnachen/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/tnachen/cockroach/tags","blobs_url":"https://api.github.com/repos/tnachen/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tnachen/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tnachen/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/tnachen/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tnachen/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/tnachen/cockroach/languages","stargazers_url":"https://api.github.com/repos/tnachen/cockroach/stargazers","contributors_url":"https://api.github.com/repos/tnachen/cockroach/contributors","subscribers_url":"https://api.github.com/repos/tnachen/cockroach/subscribers","subscription_url":"https://api.github.com/repos/tnachen/cockroach/subscription","commits_url":"https://api.github.com/repos/tnachen/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/tnachen/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/tnachen/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/tnachen/cockroach/issues/comments/{number}","contents_url":"https://api.github.com/repos/tnachen/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/tnachen/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tnachen/cockroach/merges","archive_url":"https://api.github.com/repos/tnachen/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tnachen/cockroach/downloads","issues_url":"https://api.github.com/repos/tnachen/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/tnachen/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/tnachen/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/tnachen/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tnachen/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/tnachen/cockroach/releases{/id}","created_at":"2014-12-15T17:32:42Z","updated_at":"2014-12-15T17:32:43Z","pushed_at":"2015-01-27T09:02:44Z","git_url":"git://github.com/tnachen/cockroach.git","ssh_url":"git@github.com:tnachen/cockroach.git","clone_url":"https://github.com/tnachen/cockroach.git","svn_url":"https://github.com/tnachen/cockroach","homepage":null,"size":8954,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"7d50d331a6f88a9cc364ccfe4ff2f3d7fec6d5c7","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/{number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","created_at":"2014-02-06T00:18:47Z","updated_at":"2015-01-27T13:49:56Z","pushed_at":"2015-01-26T17:26:36Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":null,"size":13539,"stargazers_count":2683,"watchers_count":2683,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":184,"mirror_url":null,"open_issues_count":27,"forks":184,"open_issues":27,"watchers":2683,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/292"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/292"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/292"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/292/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/292/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/292/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/a772d48171e485199fa1db09c8e3a0bace7a7cda"}}}}