{"action":"created","issue":{"url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1889","labels_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1889/labels{/name}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1889/comments","events_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1889/events","html_url":"https://github.com/ipfs/go-ipfs/pull/1889","id":112960199,"number":1889,"title":"fix bug in mirrorwriter removal","user":{"login":"whyrusleeping","id":1243164,"avatar_url":"https://avatars.githubusercontent.com/u/1243164?v=3","gravatar_id":"","url":"https://api.github.com/users/whyrusleeping","html_url":"https://github.com/whyrusleeping","followers_url":"https://api.github.com/users/whyrusleeping/followers","following_url":"https://api.github.com/users/whyrusleeping/following{/other_user}","gists_url":"https://api.github.com/users/whyrusleeping/gists{/gist_id}","starred_url":"https://api.github.com/users/whyrusleeping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyrusleeping/subscriptions","organizations_url":"https://api.github.com/users/whyrusleeping/orgs","repos_url":"https://api.github.com/users/whyrusleeping/repos","events_url":"https://api.github.com/users/whyrusleeping/events{/privacy}","received_events_url":"https://api.github.com/users/whyrusleeping/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ipfs/go-ipfs/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-23T06:11:56Z","updated_at":"2015-10-25T01:11:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1889","html_url":"https://github.com/ipfs/go-ipfs/pull/1889","diff_url":"https://github.com/ipfs/go-ipfs/pull/1889.diff","patch_url":"https://github.com/ipfs/go-ipfs/pull/1889.patch"},"body":"I remember writing the code for the mirror writer, but i dont remember it being the code that is there right now. And the code thats there right now just looks wrong to me. I'm fairly certain that its breaking, causing a panic, and that panic is getting eaten by something somewhere, leading to a lock not being released, and finally leading to this stack trace: http://sprunge.us/eYba (note the large number of calls to log waiting to acquire the lock for minutes on end, and nothing actually appearing to hold the lock).\r\n\r\nLicense: MIT\r\nSigned-off-by: Jeromy <jeromyj@gmail.com>"},"comment":{"url":"https://api.github.com/repos/ipfs/go-ipfs/issues/comments/150878442","html_url":"https://github.com/ipfs/go-ipfs/pull/1889#issuecomment-150878442","issue_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1889","id":150878442,"user":{"login":"whyrusleeping","id":1243164,"avatar_url":"https://avatars.githubusercontent.com/u/1243164?v=3","gravatar_id":"","url":"https://api.github.com/users/whyrusleeping","html_url":"https://github.com/whyrusleeping","followers_url":"https://api.github.com/users/whyrusleeping/followers","following_url":"https://api.github.com/users/whyrusleeping/following{/other_user}","gists_url":"https://api.github.com/users/whyrusleeping/gists{/gist_id}","starred_url":"https://api.github.com/users/whyrusleeping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyrusleeping/subscriptions","organizations_url":"https://api.github.com/users/whyrusleeping/orgs","repos_url":"https://api.github.com/users/whyrusleeping/repos","events_url":"https://api.github.com/users/whyrusleeping/events{/privacy}","received_events_url":"https://api.github.com/users/whyrusleeping/received_events","type":"User","site_admin":false},"created_at":"2015-10-25T01:11:50Z","updated_at":"2015-10-25T01:11:50Z","body":"alright, i figured that, while i was at it, i would fix #1893 #1874 and #1808 all at the same time."}}