{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/Logging/issues/319","labels_url":"https://api.github.com/repos/aspnet/Logging/issues/319/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/Logging/issues/319/comments","events_url":"https://api.github.com/repos/aspnet/Logging/issues/319/events","html_url":"https://github.com/aspnet/Logging/issues/319","id":121784865,"number":319,"title":"ILoggingFactory should not implement IDisposable","user":{"login":"dotnetjunkie","id":1506621,"avatar_url":"https://avatars.githubusercontent.com/u/1506621?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnetjunkie","html_url":"https://github.com/dotnetjunkie","followers_url":"https://api.github.com/users/dotnetjunkie/followers","following_url":"https://api.github.com/users/dotnetjunkie/following{/other_user}","gists_url":"https://api.github.com/users/dotnetjunkie/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnetjunkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnetjunkie/subscriptions","organizations_url":"https://api.github.com/users/dotnetjunkie/orgs","repos_url":"https://api.github.com/users/dotnetjunkie/repos","events_url":"https://api.github.com/users/dotnetjunkie/events{/privacy}","received_events_url":"https://api.github.com/users/dotnetjunkie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-11T20:21:56Z","updated_at":"2015-12-12T22:36:46Z","closed_at":null,"body":"A similar issue has been raised [here](https://github.com/aspnet/Mvc/issues/3726). Abstractions should not implement `IDisposable`, as @nblumhardt explained this very clearly almost six years ago (and quoted by @ploeh):\r\n\r\n> an interface [...] generally shouldn't be disposable. There's no way for the one defining an interface to foresee all possible implementations of it - you can always come up with a disposable implementation of practically any interface.\r\n\r\nWhile the default `LoggingFactory` implementation can (and probably must) be disposable, the interface shouldn't be."},"comment":{"url":"https://api.github.com/repos/aspnet/Logging/issues/comments/164199449","html_url":"https://github.com/aspnet/Logging/issues/319#issuecomment-164199449","issue_url":"https://api.github.com/repos/aspnet/Logging/issues/319","id":164199449,"user":{"login":"Eilon","id":202643,"avatar_url":"https://avatars.githubusercontent.com/u/202643?v=3","gravatar_id":"","url":"https://api.github.com/users/Eilon","html_url":"https://github.com/Eilon","followers_url":"https://api.github.com/users/Eilon/followers","following_url":"https://api.github.com/users/Eilon/following{/other_user}","gists_url":"https://api.github.com/users/Eilon/gists{/gist_id}","starred_url":"https://api.github.com/users/Eilon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eilon/subscriptions","organizations_url":"https://api.github.com/users/Eilon/orgs","repos_url":"https://api.github.com/users/Eilon/repos","events_url":"https://api.github.com/users/Eilon/events{/privacy}","received_events_url":"https://api.github.com/users/Eilon/received_events","type":"User","site_admin":false},"created_at":"2015-12-12T22:36:46Z","updated_at":"2015-12-12T22:36:46Z","body":"@lodejard thoughts on this?"}}