{"action":"created","issue":{"url":"https://api.github.com/repos/voldemort/voldemort/issues/308","labels_url":"https://api.github.com/repos/voldemort/voldemort/issues/308/labels{/name}","comments_url":"https://api.github.com/repos/voldemort/voldemort/issues/308/comments","events_url":"https://api.github.com/repos/voldemort/voldemort/issues/308/events","html_url":"https://github.com/voldemort/voldemort/pull/308","id":106366551,"number":308,"title":"Fix the RocksDB iteration logic for keys and entries.  The problems a…","user":{"login":"jwlent55","id":835248,"avatar_url":"https://avatars.githubusercontent.com/u/835248?v=3","gravatar_id":"","url":"https://api.github.com/users/jwlent55","html_url":"https://github.com/jwlent55","followers_url":"https://api.github.com/users/jwlent55/followers","following_url":"https://api.github.com/users/jwlent55/following{/other_user}","gists_url":"https://api.github.com/users/jwlent55/gists{/gist_id}","starred_url":"https://api.github.com/users/jwlent55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwlent55/subscriptions","organizations_url":"https://api.github.com/users/jwlent55/orgs","repos_url":"https://api.github.com/users/jwlent55/repos","events_url":"https://api.github.com/users/jwlent55/events{/privacy}","received_events_url":"https://api.github.com/users/jwlent55/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-09-14T15:26:29Z","updated_at":"2015-09-14T18:18:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/voldemort/voldemort/pulls/308","html_url":"https://github.com/voldemort/voldemort/pull/308","diff_url":"https://github.com/voldemort/voldemort/pull/308.diff","patch_url":"https://github.com/voldemort/voldemort/pull/308.patch"},"body":"…ddressed include:\r\n\r\n1) Key and entry iterators failed to strip prefix from keys (if required).\r\n2) RocksdbStorageEngineTest failed to test BdbStorageEngine (all tests).\r\n3) Both Key iterators would miss first entry and then iterate off the end.\r\nWith these changes I was able to remove the Ignore annotation from 2 tests."},"comment":{"url":"https://api.github.com/repos/voldemort/voldemort/issues/comments/140165157","html_url":"https://github.com/voldemort/voldemort/pull/308#issuecomment-140165157","issue_url":"https://api.github.com/repos/voldemort/voldemort/issues/308","id":140165157,"user":{"login":"jwlent55","id":835248,"avatar_url":"https://avatars.githubusercontent.com/u/835248?v=3","gravatar_id":"","url":"https://api.github.com/users/jwlent55","html_url":"https://github.com/jwlent55","followers_url":"https://api.github.com/users/jwlent55/followers","following_url":"https://api.github.com/users/jwlent55/following{/other_user}","gists_url":"https://api.github.com/users/jwlent55/gists{/gist_id}","starred_url":"https://api.github.com/users/jwlent55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwlent55/subscriptions","organizations_url":"https://api.github.com/users/jwlent55/orgs","repos_url":"https://api.github.com/users/jwlent55/repos","events_url":"https://api.github.com/users/jwlent55/events{/privacy}","received_events_url":"https://api.github.com/users/jwlent55/received_events","type":"User","site_admin":false},"created_at":"2015-09-14T18:18:56Z","updated_at":"2015-09-14T18:18:56Z","body":"Ooops.  Regarding the comment:\r\n\r\n2) RocksdbStorageEngineTest failed to test BdbStorageEngine (all tests).\r\n\r\nCut'n'paste error (and vague).  Let me try again with more details\r\n\r\n2) RocksdbStorageEngineTest failed to test RocksDbStorageEngine (all tests).  Instead both times the test suite runs I think it tests the subclass PartitionPrefixedRocksDbStorageEngine.\r\n\r\nThe current code defaults the rocksdbPrefixKeysWithPartitionId boolean to true:\r\n\r\nVoldemortConfig.java\r\n        this.rocksdbPrefixKeysWithPartitionId = props.getBoolean(\"rocksdb.prefix.keys.with.partitionid\",\r\n                                                                 true);\r\n\r\nBut in the unit test only overrides the value in the unit test suite if \"true\" was passed in:\r\n\r\nRocksdbStorageEngineTest.java\r\n\r\nif(this.prefixPartitionId) {\r\n            voldemortConfig.setRocksdbPrefixKeysWithPartitionId(true);\r\n        }\r\n\r\nI just changed this to always set the boolean based on what is passed in."}}