{"comment":{"url":"https://api.github.com/repos/blakepettersson/dashboard.aptible.com/comments/11654818","html_url":"https://github.com/blakepettersson/dashboard.aptible.com/commit/4a621f48e65217e6f03e807980f8110e1df0020a#commitcomment-11654818","id":11654818,"user":{"login":"fancyremarker","id":156030,"avatar_url":"https://avatars.githubusercontent.com/u/156030?v=3","gravatar_id":"","url":"https://api.github.com/users/fancyremarker","html_url":"https://github.com/fancyremarker","followers_url":"https://api.github.com/users/fancyremarker/followers","following_url":"https://api.github.com/users/fancyremarker/following{/other_user}","gists_url":"https://api.github.com/users/fancyremarker/gists{/gist_id}","starred_url":"https://api.github.com/users/fancyremarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fancyremarker/subscriptions","organizations_url":"https://api.github.com/users/fancyremarker/orgs","repos_url":"https://api.github.com/users/fancyremarker/repos","events_url":"https://api.github.com/users/fancyremarker/events{/privacy}","received_events_url":"https://api.github.com/users/fancyremarker/received_events","type":"User","site_admin":false},"position":17,"line":21,"path":"app/stack/log-drains/new/controller.js","commit_id":"4a621f48e65217e6f03e807980f8110e1df0020a","created_at":"2015-06-12T14:14:19Z","updated_at":"2015-06-12T14:14:19Z","body":"Nice catch on the PhantomJS error. This seems like a good fix.\r\n\r\nOne important note: instead of including the username/password in the `drainHost` string, we should set `drainUsername` and `drainPassword` separately, along with `{ drainType: 'elasticsearch' }` (see [app/models/log_drain.rb](https://github.com/aptible/api.aptible.com/blob/master/app/models/log_drain.rb) in API for context). This probably requires adding `drainUsername` and `drainPassword` to the attributes to the Ember model: [app/models/log_drain.rb](https://github.com/aptible/ember-cli-aptible-shared/blob/master/app/models/log_drain.js) in ember-cli-aptible-shared."}}