{"action":"created","comment":{"url":"https://api.github.com/repos/opscode/chef/pulls/comments/22739410","id":22739410,"diff_hunk":"@@ -118,6 +119,11 @@ def build_resource(type, name, created_at=nil, &resource_attrs_block)\n         # Evaluate resource attribute DSL\n         resource.instance_eval(&resource_attrs_block) if block_given?\n \n+        # emit a cloned resource warning if it is warranted\n+        if !trivial_prior_resource.nil? && ( !trivial_prior_resource || !resource.identicalish_resource?(cloned_resource))","path":"lib/chef/dsl/recipe.rb","position":15,"original_position":15,"commit_id":"d272a4e6e65ca8fb2986d77d3bb711f4f7f62528","original_commit_id":"d272a4e6e65ca8fb2986d77d3bb711f4f7f62528","user":{"login":"lamont-granquist","id":454857,"avatar_url":"https://avatars.githubusercontent.com/u/454857?v=3","gravatar_id":"","url":"https://api.github.com/users/lamont-granquist","html_url":"https://github.com/lamont-granquist","followers_url":"https://api.github.com/users/lamont-granquist/followers","following_url":"https://api.github.com/users/lamont-granquist/following{/other_user}","gists_url":"https://api.github.com/users/lamont-granquist/gists{/gist_id}","starred_url":"https://api.github.com/users/lamont-granquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamont-granquist/subscriptions","organizations_url":"https://api.github.com/users/lamont-granquist/orgs","repos_url":"https://api.github.com/users/lamont-granquist/repos","events_url":"https://api.github.com/users/lamont-granquist/events{/privacy}","received_events_url":"https://api.github.com/users/lamont-granquist/received_events","type":"User","site_admin":false},"body":"don't try to understand it right now, its a mess --  but this isn't the prior_resource its the return value of identicalish_resource?(prior_resource) check deep inside the load_prior_resource call.\r\n\r\ni sorta want to bust this out into its own class (ResourceBuilder or something) and extract all the code from the DSL and all the code from the resource, but the `@params` ivar will probably troll me. ","created_at":"2015-01-09T20:03:09Z","updated_at":"2015-01-09T20:03:09Z","html_url":"https://github.com/opscode/chef/pull/2624#discussion_r22739410","pull_request_url":"https://api.github.com/repos/opscode/chef/pulls/2624","_links":{"self":{"href":"https://api.github.com/repos/opscode/chef/pulls/comments/22739410"},"html":{"href":"https://github.com/opscode/chef/pull/2624#discussion_r22739410"},"pull_request":{"href":"https://api.github.com/repos/opscode/chef/pulls/2624"}}},"pull_request":{"url":"https://api.github.com/repos/opscode/chef/pulls/2624","id":25954183,"html_url":"https://github.com/opscode/chef/pull/2624","diff_url":"https://github.com/opscode/chef/pull/2624.diff","patch_url":"https://github.com/opscode/chef/pull/2624.patch","issue_url":"https://api.github.com/repos/opscode/chef/issues/2624","number":2624,"state":"open","locked":false,"title":"Skip 3694 warnings on trivial resource cloning","user":{"login":"lamont-granquist","id":454857,"avatar_url":"https://avatars.githubusercontent.com/u/454857?v=3","gravatar_id":"","url":"https://api.github.com/users/lamont-granquist","html_url":"https://github.com/lamont-granquist","followers_url":"https://api.github.com/users/lamont-granquist/followers","following_url":"https://api.github.com/users/lamont-granquist/following{/other_user}","gists_url":"https://api.github.com/users/lamont-granquist/gists{/gist_id}","starred_url":"https://api.github.com/users/lamont-granquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamont-granquist/subscriptions","organizations_url":"https://api.github.com/users/lamont-granquist/orgs","repos_url":"https://api.github.com/users/lamont-granquist/repos","events_url":"https://api.github.com/users/lamont-granquist/events{/privacy}","received_events_url":"https://api.github.com/users/lamont-granquist/received_events","type":"User","site_admin":false},"body":"Turns the 3694 warning into a debug message if the prior resource is\r\nidentical to the current resource.  Suggestion for opscode/chef-rfc#76","created_at":"2014-12-12T06:10:12Z","updated_at":"2015-01-09T20:03:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5a85ec32174a8b26163f776cf1b2e9c7da07a1d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opscode/chef/pulls/2624/commits","review_comments_url":"https://api.github.com/repos/opscode/chef/pulls/2624/comments","review_comment_url":"https://api.github.com/repos/opscode/chef/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opscode/chef/issues/2624/comments","statuses_url":"https://api.github.com/repos/opscode/chef/statuses/d272a4e6e65ca8fb2986d77d3bb711f4f7f62528","head":{"label":"opscode:lcg/suppress-3694","ref":"lcg/suppress-3694","sha":"d272a4e6e65ca8fb2986d77d3bb711f4f7f62528","user":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"repo":{"id":108278,"name":"chef","full_name":"opscode/chef","owner":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode/chef","description":"A systems integration framework, built to bring the benefits of configuration management to your entire infrastructure.","fork":false,"url":"https://api.github.com/repos/opscode/chef","forks_url":"https://api.github.com/repos/opscode/chef/forks","keys_url":"https://api.github.com/repos/opscode/chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode/chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode/chef/teams","hooks_url":"https://api.github.com/repos/opscode/chef/hooks","issue_events_url":"https://api.github.com/repos/opscode/chef/issues/events{/number}","events_url":"https://api.github.com/repos/opscode/chef/events","assignees_url":"https://api.github.com/repos/opscode/chef/assignees{/user}","branches_url":"https://api.github.com/repos/opscode/chef/branches{/branch}","tags_url":"https://api.github.com/repos/opscode/chef/tags","blobs_url":"https://api.github.com/repos/opscode/chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode/chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode/chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode/chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode/chef/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode/chef/languages","stargazers_url":"https://api.github.com/repos/opscode/chef/stargazers","contributors_url":"https://api.github.com/repos/opscode/chef/contributors","subscribers_url":"https://api.github.com/repos/opscode/chef/subscribers","subscription_url":"https://api.github.com/repos/opscode/chef/subscription","commits_url":"https://api.github.com/repos/opscode/chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode/chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode/chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode/chef/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode/chef/contents/{+path}","compare_url":"https://api.github.com/repos/opscode/chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode/chef/merges","archive_url":"https://api.github.com/repos/opscode/chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode/chef/downloads","issues_url":"https://api.github.com/repos/opscode/chef/issues{/number}","pulls_url":"https://api.github.com/repos/opscode/chef/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode/chef/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode/chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode/chef/labels{/name}","releases_url":"https://api.github.com/repos/opscode/chef/releases{/id}","created_at":"2009-01-15T20:40:48Z","updated_at":"2015-01-09T13:39:01Z","pushed_at":"2015-01-09T18:33:00Z","git_url":"git://github.com/opscode/chef.git","ssh_url":"git@github.com:opscode/chef.git","clone_url":"https://github.com/opscode/chef.git","svn_url":"https://github.com/opscode/chef","homepage":"http://www.getchef.com/chef/","size":157385,"stargazers_count":3285,"watchers_count":3285,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1325,"mirror_url":null,"open_issues_count":369,"forks":1325,"open_issues":369,"watchers":3285,"default_branch":"master"}},"base":{"label":"opscode:master","ref":"master","sha":"16b1b5f977f6858d914d5b1fe748b4d6a4cff7f4","user":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"repo":{"id":108278,"name":"chef","full_name":"opscode/chef","owner":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode/chef","description":"A systems integration framework, built to bring the benefits of configuration management to your entire infrastructure.","fork":false,"url":"https://api.github.com/repos/opscode/chef","forks_url":"https://api.github.com/repos/opscode/chef/forks","keys_url":"https://api.github.com/repos/opscode/chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode/chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode/chef/teams","hooks_url":"https://api.github.com/repos/opscode/chef/hooks","issue_events_url":"https://api.github.com/repos/opscode/chef/issues/events{/number}","events_url":"https://api.github.com/repos/opscode/chef/events","assignees_url":"https://api.github.com/repos/opscode/chef/assignees{/user}","branches_url":"https://api.github.com/repos/opscode/chef/branches{/branch}","tags_url":"https://api.github.com/repos/opscode/chef/tags","blobs_url":"https://api.github.com/repos/opscode/chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode/chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode/chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode/chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode/chef/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode/chef/languages","stargazers_url":"https://api.github.com/repos/opscode/chef/stargazers","contributors_url":"https://api.github.com/repos/opscode/chef/contributors","subscribers_url":"https://api.github.com/repos/opscode/chef/subscribers","subscription_url":"https://api.github.com/repos/opscode/chef/subscription","commits_url":"https://api.github.com/repos/opscode/chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode/chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode/chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode/chef/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode/chef/contents/{+path}","compare_url":"https://api.github.com/repos/opscode/chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode/chef/merges","archive_url":"https://api.github.com/repos/opscode/chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode/chef/downloads","issues_url":"https://api.github.com/repos/opscode/chef/issues{/number}","pulls_url":"https://api.github.com/repos/opscode/chef/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode/chef/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode/chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode/chef/labels{/name}","releases_url":"https://api.github.com/repos/opscode/chef/releases{/id}","created_at":"2009-01-15T20:40:48Z","updated_at":"2015-01-09T13:39:01Z","pushed_at":"2015-01-09T18:33:00Z","git_url":"git://github.com/opscode/chef.git","ssh_url":"git@github.com:opscode/chef.git","clone_url":"https://github.com/opscode/chef.git","svn_url":"https://github.com/opscode/chef","homepage":"http://www.getchef.com/chef/","size":157385,"stargazers_count":3285,"watchers_count":3285,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1325,"mirror_url":null,"open_issues_count":369,"forks":1325,"open_issues":369,"watchers":3285,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opscode/chef/pulls/2624"},"html":{"href":"https://github.com/opscode/chef/pull/2624"},"issue":{"href":"https://api.github.com/repos/opscode/chef/issues/2624"},"comments":{"href":"https://api.github.com/repos/opscode/chef/issues/2624/comments"},"review_comments":{"href":"https://api.github.com/repos/opscode/chef/pulls/2624/comments"},"review_comment":{"href":"https://api.github.com/repos/opscode/chef/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opscode/chef/pulls/2624/commits"},"statuses":{"href":"https://api.github.com/repos/opscode/chef/statuses/d272a4e6e65ca8fb2986d77d3bb711f4f7f62528"}}}}