{"action":"opened","number":11,"pull_request":{"url":"https://api.github.com/repos/leanovate/play-mockws/pulls/11","id":48303744,"html_url":"https://github.com/leanovate/play-mockws/pull/11","diff_url":"https://github.com/leanovate/play-mockws/pull/11.diff","patch_url":"https://github.com/leanovate/play-mockws/pull/11.patch","issue_url":"https://api.github.com/repos/leanovate/play-mockws/issues/11","number":11,"state":"open","locked":false,"title":"Replace mockito with a concrete implementation.","user":{"login":"htmldoug","id":663139,"avatar_url":"https://avatars.githubusercontent.com/u/663139?v=3","gravatar_id":"","url":"https://api.github.com/users/htmldoug","html_url":"https://github.com/htmldoug","followers_url":"https://api.github.com/users/htmldoug/followers","following_url":"https://api.github.com/users/htmldoug/following{/other_user}","gists_url":"https://api.github.com/users/htmldoug/gists{/gist_id}","starred_url":"https://api.github.com/users/htmldoug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmldoug/subscriptions","organizations_url":"https://api.github.com/users/htmldoug/orgs","repos_url":"https://api.github.com/users/htmldoug/repos","events_url":"https://api.github.com/users/htmldoug/events{/privacy}","received_events_url":"https://api.github.com/users/htmldoug/received_events","type":"User","site_admin":false},"body":"> Implementing WSRequest instead of using a mock would ensure that we do not forget any methods.\r\nIt is a good idea, but quite a rewrite of the actual code.\r\n\r\nThis PR resolves #8 by replacing mockito with a concrete implementation. MockWS definitely will not produce NPEs from missing stubs anymore!\r\n\r\nI added a bit more test coverage and also implemented request timeouts. All existing tests pass locally without any modification.","created_at":"2015-10-21T08:56:09Z","updated_at":"2015-10-21T08:56:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/leanovate/play-mockws/pulls/11/commits","review_comments_url":"https://api.github.com/repos/leanovate/play-mockws/pulls/11/comments","review_comment_url":"https://api.github.com/repos/leanovate/play-mockws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/leanovate/play-mockws/issues/11/comments","statuses_url":"https://api.github.com/repos/leanovate/play-mockws/statuses/9582d127c3c87cd1d671dc89706fb9040d6c20d6","head":{"label":"htmldoug:v2.3.x-fake","ref":"v2.3.x-fake","sha":"9582d127c3c87cd1d671dc89706fb9040d6c20d6","user":{"login":"htmldoug","id":663139,"avatar_url":"https://avatars.githubusercontent.com/u/663139?v=3","gravatar_id":"","url":"https://api.github.com/users/htmldoug","html_url":"https://github.com/htmldoug","followers_url":"https://api.github.com/users/htmldoug/followers","following_url":"https://api.github.com/users/htmldoug/following{/other_user}","gists_url":"https://api.github.com/users/htmldoug/gists{/gist_id}","starred_url":"https://api.github.com/users/htmldoug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmldoug/subscriptions","organizations_url":"https://api.github.com/users/htmldoug/orgs","repos_url":"https://api.github.com/users/htmldoug/repos","events_url":"https://api.github.com/users/htmldoug/events{/privacy}","received_events_url":"https://api.github.com/users/htmldoug/received_events","type":"User","site_admin":false},"repo":{"id":44584815,"name":"play-mockws","full_name":"htmldoug/play-mockws","owner":{"login":"htmldoug","id":663139,"avatar_url":"https://avatars.githubusercontent.com/u/663139?v=3","gravatar_id":"","url":"https://api.github.com/users/htmldoug","html_url":"https://github.com/htmldoug","followers_url":"https://api.github.com/users/htmldoug/followers","following_url":"https://api.github.com/users/htmldoug/following{/other_user}","gists_url":"https://api.github.com/users/htmldoug/gists{/gist_id}","starred_url":"https://api.github.com/users/htmldoug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmldoug/subscriptions","organizations_url":"https://api.github.com/users/htmldoug/orgs","repos_url":"https://api.github.com/users/htmldoug/repos","events_url":"https://api.github.com/users/htmldoug/events{/privacy}","received_events_url":"https://api.github.com/users/htmldoug/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/htmldoug/play-mockws","description":"Mock WS client for Play Framework","fork":true,"url":"https://api.github.com/repos/htmldoug/play-mockws","forks_url":"https://api.github.com/repos/htmldoug/play-mockws/forks","keys_url":"https://api.github.com/repos/htmldoug/play-mockws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmldoug/play-mockws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmldoug/play-mockws/teams","hooks_url":"https://api.github.com/repos/htmldoug/play-mockws/hooks","issue_events_url":"https://api.github.com/repos/htmldoug/play-mockws/issues/events{/number}","events_url":"https://api.github.com/repos/htmldoug/play-mockws/events","assignees_url":"https://api.github.com/repos/htmldoug/play-mockws/assignees{/user}","branches_url":"https://api.github.com/repos/htmldoug/play-mockws/branches{/branch}","tags_url":"https://api.github.com/repos/htmldoug/play-mockws/tags","blobs_url":"https://api.github.com/repos/htmldoug/play-mockws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmldoug/play-mockws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmldoug/play-mockws/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmldoug/play-mockws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmldoug/play-mockws/statuses/{sha}","languages_url":"https://api.github.com/repos/htmldoug/play-mockws/languages","stargazers_url":"https://api.github.com/repos/htmldoug/play-mockws/stargazers","contributors_url":"https://api.github.com/repos/htmldoug/play-mockws/contributors","subscribers_url":"https://api.github.com/repos/htmldoug/play-mockws/subscribers","subscription_url":"https://api.github.com/repos/htmldoug/play-mockws/subscription","commits_url":"https://api.github.com/repos/htmldoug/play-mockws/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmldoug/play-mockws/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmldoug/play-mockws/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmldoug/play-mockws/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmldoug/play-mockws/contents/{+path}","compare_url":"https://api.github.com/repos/htmldoug/play-mockws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmldoug/play-mockws/merges","archive_url":"https://api.github.com/repos/htmldoug/play-mockws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmldoug/play-mockws/downloads","issues_url":"https://api.github.com/repos/htmldoug/play-mockws/issues{/number}","pulls_url":"https://api.github.com/repos/htmldoug/play-mockws/pulls{/number}","milestones_url":"https://api.github.com/repos/htmldoug/play-mockws/milestones{/number}","notifications_url":"https://api.github.com/repos/htmldoug/play-mockws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmldoug/play-mockws/labels{/name}","releases_url":"https://api.github.com/repos/htmldoug/play-mockws/releases{/id}","created_at":"2015-10-20T05:46:21Z","updated_at":"2015-10-20T05:46:22Z","pushed_at":"2015-10-21T07:30:48Z","git_url":"git://github.com/htmldoug/play-mockws.git","ssh_url":"git@github.com:htmldoug/play-mockws.git","clone_url":"https://github.com/htmldoug/play-mockws.git","svn_url":"https://github.com/htmldoug/play-mockws","homepage":null,"size":189,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"leanovate:2.3.x","ref":"2.3.x","sha":"8ad1a2d8c2f820deebff331832c7021f84374eab","user":{"login":"leanovate","id":1934784,"avatar_url":"https://avatars.githubusercontent.com/u/1934784?v=3","gravatar_id":"","url":"https://api.github.com/users/leanovate","html_url":"https://github.com/leanovate","followers_url":"https://api.github.com/users/leanovate/followers","following_url":"https://api.github.com/users/leanovate/following{/other_user}","gists_url":"https://api.github.com/users/leanovate/gists{/gist_id}","starred_url":"https://api.github.com/users/leanovate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leanovate/subscriptions","organizations_url":"https://api.github.com/users/leanovate/orgs","repos_url":"https://api.github.com/users/leanovate/repos","events_url":"https://api.github.com/users/leanovate/events{/privacy}","received_events_url":"https://api.github.com/users/leanovate/received_events","type":"Organization","site_admin":false},"repo":{"id":23193156,"name":"play-mockws","full_name":"leanovate/play-mockws","owner":{"login":"leanovate","id":1934784,"avatar_url":"https://avatars.githubusercontent.com/u/1934784?v=3","gravatar_id":"","url":"https://api.github.com/users/leanovate","html_url":"https://github.com/leanovate","followers_url":"https://api.github.com/users/leanovate/followers","following_url":"https://api.github.com/users/leanovate/following{/other_user}","gists_url":"https://api.github.com/users/leanovate/gists{/gist_id}","starred_url":"https://api.github.com/users/leanovate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leanovate/subscriptions","organizations_url":"https://api.github.com/users/leanovate/orgs","repos_url":"https://api.github.com/users/leanovate/repos","events_url":"https://api.github.com/users/leanovate/events{/privacy}","received_events_url":"https://api.github.com/users/leanovate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/leanovate/play-mockws","description":"Mock WS client for Play Framework","fork":false,"url":"https://api.github.com/repos/leanovate/play-mockws","forks_url":"https://api.github.com/repos/leanovate/play-mockws/forks","keys_url":"https://api.github.com/repos/leanovate/play-mockws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leanovate/play-mockws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leanovate/play-mockws/teams","hooks_url":"https://api.github.com/repos/leanovate/play-mockws/hooks","issue_events_url":"https://api.github.com/repos/leanovate/play-mockws/issues/events{/number}","events_url":"https://api.github.com/repos/leanovate/play-mockws/events","assignees_url":"https://api.github.com/repos/leanovate/play-mockws/assignees{/user}","branches_url":"https://api.github.com/repos/leanovate/play-mockws/branches{/branch}","tags_url":"https://api.github.com/repos/leanovate/play-mockws/tags","blobs_url":"https://api.github.com/repos/leanovate/play-mockws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leanovate/play-mockws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leanovate/play-mockws/git/refs{/sha}","trees_url":"https://api.github.com/repos/leanovate/play-mockws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leanovate/play-mockws/statuses/{sha}","languages_url":"https://api.github.com/repos/leanovate/play-mockws/languages","stargazers_url":"https://api.github.com/repos/leanovate/play-mockws/stargazers","contributors_url":"https://api.github.com/repos/leanovate/play-mockws/contributors","subscribers_url":"https://api.github.com/repos/leanovate/play-mockws/subscribers","subscription_url":"https://api.github.com/repos/leanovate/play-mockws/subscription","commits_url":"https://api.github.com/repos/leanovate/play-mockws/commits{/sha}","git_commits_url":"https://api.github.com/repos/leanovate/play-mockws/git/commits{/sha}","comments_url":"https://api.github.com/repos/leanovate/play-mockws/comments{/number}","issue_comment_url":"https://api.github.com/repos/leanovate/play-mockws/issues/comments{/number}","contents_url":"https://api.github.com/repos/leanovate/play-mockws/contents/{+path}","compare_url":"https://api.github.com/repos/leanovate/play-mockws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leanovate/play-mockws/merges","archive_url":"https://api.github.com/repos/leanovate/play-mockws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leanovate/play-mockws/downloads","issues_url":"https://api.github.com/repos/leanovate/play-mockws/issues{/number}","pulls_url":"https://api.github.com/repos/leanovate/play-mockws/pulls{/number}","milestones_url":"https://api.github.com/repos/leanovate/play-mockws/milestones{/number}","notifications_url":"https://api.github.com/repos/leanovate/play-mockws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leanovate/play-mockws/labels{/name}","releases_url":"https://api.github.com/repos/leanovate/play-mockws/releases{/id}","created_at":"2014-08-21T15:46:57Z","updated_at":"2015-10-16T01:13:14Z","pushed_at":"2015-09-20T19:13:58Z","git_url":"git://github.com/leanovate/play-mockws.git","ssh_url":"git@github.com:leanovate/play-mockws.git","clone_url":"https://github.com/leanovate/play-mockws.git","svn_url":"https://github.com/leanovate/play-mockws","homepage":null,"size":417,"stargazers_count":42,"watchers_count":42,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":3,"forks":13,"open_issues":3,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/leanovate/play-mockws/pulls/11"},"html":{"href":"https://github.com/leanovate/play-mockws/pull/11"},"issue":{"href":"https://api.github.com/repos/leanovate/play-mockws/issues/11"},"comments":{"href":"https://api.github.com/repos/leanovate/play-mockws/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/leanovate/play-mockws/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/leanovate/play-mockws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/leanovate/play-mockws/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/leanovate/play-mockws/statuses/9582d127c3c87cd1d671dc89706fb9040d6c20d6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":411,"deletions":218,"changed_files":9}}