{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/membership-frontend/issues/522","labels_url":"https://api.github.com/repos/guardian/membership-frontend/issues/522/labels{/name}","comments_url":"https://api.github.com/repos/guardian/membership-frontend/issues/522/comments","events_url":"https://api.github.com/repos/guardian/membership-frontend/issues/522/events","html_url":"https://github.com/guardian/membership-frontend/pull/522","id":74379904,"number":522,"title":"Switch to node-sass","user":{"login":"davidrapson","id":123386,"avatar_url":"https://avatars.githubusercontent.com/u/123386?v=3","gravatar_id":"","url":"https://api.github.com/users/davidrapson","html_url":"https://github.com/davidrapson","followers_url":"https://api.github.com/users/davidrapson/followers","following_url":"https://api.github.com/users/davidrapson/following{/other_user}","gists_url":"https://api.github.com/users/davidrapson/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrapson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrapson/subscriptions","organizations_url":"https://api.github.com/users/davidrapson/orgs","repos_url":"https://api.github.com/users/davidrapson/repos","events_url":"https://api.github.com/users/davidrapson/events{/privacy}","received_events_url":"https://api.github.com/users/davidrapson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-05-08T14:24:23Z","updated_at":"2015-05-21T15:49:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/guardian/membership-frontend/pulls/522","html_url":"https://github.com/guardian/membership-frontend/pull/522","diff_url":"https://github.com/guardian/membership-frontend/pull/522.diff","patch_url":"https://github.com/guardian/membership-frontend/pull/522.patch"},"body":"After chatting to @sndrs I wanted to see what improvements we'd get from switching to `libsass`.\r\n\r\nFairly painless switch with the main benefit being shaving off a chunk of time from our build.\r\n\r\n## Build Time\r\n\r\n**Before**\r\n```\r\ngrunt compile --dev  15.33s user 0.81s system 166% cpu 9.688 total\r\n```\r\n\r\n**After**\r\n```\r\ngrunt compile --dev  8.54s user 0.52s system 124% cpu 7.299 total\r\n```\r\n\r\n## Diff\r\n\r\n**Spacing order:**\r\n```scss\r\nhtml input[type=\"button\"],\r\ninput[type=\"reset\"]\r\n```\r\nafter:\r\n``` scss\r\nhtml input[type=\"button\"], input[type=\"reset\"]\r\n```\r\n\r\n**Units**\r\n`padding: .3em 1em;` (ruby-sass) vs `padding: 0.3em 1em;` (libsass)\r\n\r\n**Webfont URLs**\r\nThis PR also adds explicit versioning of `guss` components, rather than just including **all** of guss. Only real change is upgrading the version of `guss-webfonts` but in terms of actual changes to the diff this just means we now use a versioned URL.\r\n\r\n```\r\npasteup.guim.co.uk/fonts/webfonts/hinting-on_kerning-on/original/GuardianTextEgyptianWeb/GuardianTextEgyptianWeb-Regular.woff2\r\n```\r\nafter:\r\n```\r\npasteup.guim.co.uk/fonts/1.0.0/hinting-cleartype/kerning-on/original/GuardianTextEgyptianWeb/GuardianTextEgyptianWeb-Regular.woff2\r\n```\r\n\r\n[Full diff available in this gist](https://gist.github.com/davidrapson/7c7a2f874e71ab5fecc6)\r\n\r\n---\r\n\r\n~~This change also means our only Ruby dependancy is `scss-lint`. It might be worth making the call to remove Ruby from our TeamCity builds as we probably don't need to run `scss-lint` as part of a TC build.~~\r\n\r\n**This PR also removes the Ruby dependency as `scss-lint` has since been removed**\r\n\r\nThoughts?\r\n\r\n@mattandrews "},"comment":{"url":"https://api.github.com/repos/guardian/membership-frontend/issues/comments/104327049","html_url":"https://github.com/guardian/membership-frontend/pull/522#issuecomment-104327049","issue_url":"https://api.github.com/repos/guardian/membership-frontend/issues/522","id":104327049,"user":{"login":"davidrapson","id":123386,"avatar_url":"https://avatars.githubusercontent.com/u/123386?v=3","gravatar_id":"","url":"https://api.github.com/users/davidrapson","html_url":"https://github.com/davidrapson","followers_url":"https://api.github.com/users/davidrapson/followers","following_url":"https://api.github.com/users/davidrapson/following{/other_user}","gists_url":"https://api.github.com/users/davidrapson/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrapson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrapson/subscriptions","organizations_url":"https://api.github.com/users/davidrapson/orgs","repos_url":"https://api.github.com/users/davidrapson/repos","events_url":"https://api.github.com/users/davidrapson/events{/privacy}","received_events_url":"https://api.github.com/users/davidrapson/received_events","type":"User","site_admin":false},"created_at":"2015-05-21T15:49:41Z","updated_at":"2015-05-21T15:49:41Z","body":"Verbal :+1: from @TesterSpike "}}