{"action":"created","comment":{"url":"https://api.github.com/repos/NuGet/NuGet3/pulls/comments/40688993","id":40688993,"diff_hunk":"@@ -11,6 +12,74 @@ namespace NuGet.Test\n     public class FrameworkReducerTests\n     {\n         [Theory]\n+        // Generation fall-through patterns of uap10.0: \n+        // 1. lib/uap10, ","path":"test/NuGet.Frameworks.Test/FrameworkReducerTests.cs","position":13,"original_position":13,"commit_id":"26d3ad0b51c9858d277482eeff44f6f05be1ab3b","original_commit_id":"26d3ad0b51c9858d277482eeff44f6f05be1ab3b","user":{"login":"anurse","id":7574,"avatar_url":"https://avatars.githubusercontent.com/u/7574?v=3","gravatar_id":"","url":"https://api.github.com/users/anurse","html_url":"https://github.com/anurse","followers_url":"https://api.github.com/users/anurse/followers","following_url":"https://api.github.com/users/anurse/following{/other_user}","gists_url":"https://api.github.com/users/anurse/gists{/gist_id}","starred_url":"https://api.github.com/users/anurse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anurse/subscriptions","organizations_url":"https://api.github.com/users/anurse/orgs","repos_url":"https://api.github.com/users/anurse/repos","events_url":"https://api.github.com/users/anurse/events{/privacy}","received_events_url":"https://api.github.com/users/anurse/received_events","type":"User","site_admin":false},"body":"nit: `uap10.0` (I know the source of this comment had `uap10` but that's `1.0` :P)","created_at":"2015-09-29T15:44:17Z","updated_at":"2015-09-29T15:44:17Z","html_url":"https://github.com/NuGet/NuGet3/pull/135#discussion_r40688993","pull_request_url":"https://api.github.com/repos/NuGet/NuGet3/pulls/135","_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet3/pulls/comments/40688993"},"html":{"href":"https://github.com/NuGet/NuGet3/pull/135#discussion_r40688993"},"pull_request":{"href":"https://api.github.com/repos/NuGet/NuGet3/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/NuGet/NuGet3/pulls/135","id":46243289,"html_url":"https://github.com/NuGet/NuGet3/pull/135","diff_url":"https://github.com/NuGet/NuGet3/pull/135.diff","patch_url":"https://github.com/NuGet/NuGet3/pull/135.patch","issue_url":"https://api.github.com/repos/NuGet/NuGet3/issues/135","number":135,"state":"open","locked":false,"title":"Dotnet generations support","user":{"login":"emgarten","id":6381138,"avatar_url":"https://avatars.githubusercontent.com/u/6381138?v=3","gravatar_id":"","url":"https://api.github.com/users/emgarten","html_url":"https://github.com/emgarten","followers_url":"https://api.github.com/users/emgarten/followers","following_url":"https://api.github.com/users/emgarten/following{/other_user}","gists_url":"https://api.github.com/users/emgarten/gists{/gist_id}","starred_url":"https://api.github.com/users/emgarten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emgarten/subscriptions","organizations_url":"https://api.github.com/users/emgarten/orgs","repos_url":"https://api.github.com/users/emgarten/repos","events_url":"https://api.github.com/users/emgarten/events{/privacy}","received_events_url":"https://api.github.com/users/emgarten/received_events","type":"User","site_admin":false},"body":"Adding dotnet generation support to NuGet.Frameworks.\r\n\r\n* Adding generation mappings\r\n* Removing old dotnet rules\r\n* Removing sl6 -> dotnet compatibility (it is not listed in the generations)\r\n* Support for writing the decimal by default into dotnet frameworks. ex: dotnet5.4\r\n* Remapped the default DNX to DNX 4.5 to match DNX's unit test\r\n* Package based frameworks came last but before PCLs in all current scenarios due to the compatibility rules, this rule is enforced during GetNearest() using IsPackageBased.\r\n\r\nXamarin frameworks will keep the previous behavior of having the same dotnet support as UAP. If there is a better generation to use please let me know.\r\n\r\n//cc @lodejard @davidfowl @anurse\r\n//cc @yishaigalatzer @deepakaravindr @MeniZalzman ","created_at":"2015-09-29T07:13:07Z","updated_at":"2015-09-29T15:44:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2bc55e43d4d32cb2bd44035d34f6fd8644e3829e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NuGet/NuGet3/pulls/135/commits","review_comments_url":"https://api.github.com/repos/NuGet/NuGet3/pulls/135/comments","review_comment_url":"https://api.github.com/repos/NuGet/NuGet3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NuGet/NuGet3/issues/135/comments","statuses_url":"https://api.github.com/repos/NuGet/NuGet3/statuses/26d3ad0b51c9858d277482eeff44f6f05be1ab3b","head":{"label":"NuGet:emgarten/generations","ref":"emgarten/generations","sha":"26d3ad0b51c9858d277482eeff44f6f05be1ab3b","user":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":31300058,"name":"NuGet3","full_name":"NuGet/NuGet3","owner":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet3","description":"","fork":false,"url":"https://api.github.com/repos/NuGet/NuGet3","forks_url":"https://api.github.com/repos/NuGet/NuGet3/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet3/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet3/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet3/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet3/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet3/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet3/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet3/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet3/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet3/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet3/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet3/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet3/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet3/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet3/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet3/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet3/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet3/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet3/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet3/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet3/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet3/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet3/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet3/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet3/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet3/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet3/releases{/id}","created_at":"2015-02-25T06:15:00Z","updated_at":"2015-09-25T19:57:02Z","pushed_at":"2015-09-29T07:33:03Z","git_url":"git://github.com/NuGet/NuGet3.git","ssh_url":"git@github.com:NuGet/NuGet3.git","clone_url":"https://github.com/NuGet/NuGet3.git","svn_url":"https://github.com/NuGet/NuGet3","homepage":null,"size":14686,"stargazers_count":51,"watchers_count":51,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":12,"forks":24,"open_issues":12,"watchers":51,"default_branch":"dev"}},"base":{"label":"NuGet:dev","ref":"dev","sha":"2ae84e2d251be26217bcc552501de6bad2e9eb7d","user":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":31300058,"name":"NuGet3","full_name":"NuGet/NuGet3","owner":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet3","description":"","fork":false,"url":"https://api.github.com/repos/NuGet/NuGet3","forks_url":"https://api.github.com/repos/NuGet/NuGet3/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet3/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet3/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet3/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet3/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet3/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet3/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet3/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet3/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet3/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet3/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet3/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet3/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet3/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet3/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet3/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet3/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet3/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet3/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet3/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet3/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet3/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet3/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet3/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet3/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet3/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet3/releases{/id}","created_at":"2015-02-25T06:15:00Z","updated_at":"2015-09-25T19:57:02Z","pushed_at":"2015-09-29T07:33:03Z","git_url":"git://github.com/NuGet/NuGet3.git","ssh_url":"git@github.com:NuGet/NuGet3.git","clone_url":"https://github.com/NuGet/NuGet3.git","svn_url":"https://github.com/NuGet/NuGet3","homepage":null,"size":14686,"stargazers_count":51,"watchers_count":51,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":12,"forks":24,"open_issues":12,"watchers":51,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet3/pulls/135"},"html":{"href":"https://github.com/NuGet/NuGet3/pull/135"},"issue":{"href":"https://api.github.com/repos/NuGet/NuGet3/issues/135"},"comments":{"href":"https://api.github.com/repos/NuGet/NuGet3/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/NuGet/NuGet3/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/NuGet/NuGet3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NuGet/NuGet3/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/NuGet/NuGet3/statuses/26d3ad0b51c9858d277482eeff44f6f05be1ab3b"}}}}