{"action":"created","issue":{"url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/2922","labels_url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/2922/labels{/name}","comments_url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/2922/comments","events_url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/2922/events","html_url":"https://github.com/adobe-photoshop/spaces-design/pull/2922","id":111201380,"number":2922,"title":"ExportList now uses autoSelect=false and changeOnBlur=false datalist params","user":{"login":"mcilroyc","id":1168110,"avatar_url":"https://avatars.githubusercontent.com/u/1168110?v=3","gravatar_id":"","url":"https://api.github.com/users/mcilroyc","html_url":"https://github.com/mcilroyc","followers_url":"https://api.github.com/users/mcilroyc/followers","following_url":"https://api.github.com/users/mcilroyc/following{/other_user}","gists_url":"https://api.github.com/users/mcilroyc/gists{/gist_id}","starred_url":"https://api.github.com/users/mcilroyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcilroyc/subscriptions","organizations_url":"https://api.github.com/users/mcilroyc/orgs","repos_url":"https://api.github.com/users/mcilroyc/repos","events_url":"https://api.github.com/users/mcilroyc/events{/privacy}","received_events_url":"https://api.github.com/users/mcilroyc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mcilroyc","id":1168110,"avatar_url":"https://avatars.githubusercontent.com/u/1168110?v=3","gravatar_id":"","url":"https://api.github.com/users/mcilroyc","html_url":"https://github.com/mcilroyc","followers_url":"https://api.github.com/users/mcilroyc/followers","following_url":"https://api.github.com/users/mcilroyc/following{/other_user}","gists_url":"https://api.github.com/users/mcilroyc/gists{/gist_id}","starred_url":"https://api.github.com/users/mcilroyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcilroyc/subscriptions","organizations_url":"https://api.github.com/users/mcilroyc/orgs","repos_url":"https://api.github.com/users/mcilroyc/repos","events_url":"https://api.github.com/users/mcilroyc/events{/privacy}","received_events_url":"https://api.github.com/users/mcilroyc/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-10-13T15:11:20Z","updated_at":"2015-10-14T17:20:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/adobe-photoshop/spaces-design/pulls/2922","html_url":"https://github.com/adobe-photoshop/spaces-design/pull/2922","diff_url":"https://github.com/adobe-photoshop/spaces-design/pull/2922.diff","patch_url":"https://github.com/adobe-photoshop/spaces-design/pull/2922.patch"},"body":"This addresses #2807, #2808, and an unreported issue: extra history state when committing a change to the \"format\" datalist of export asset configurations.\r\n\r\nThe default value of the `DataList` parameter `autoSelect` was `true`, and this was triggering a bug when hitting ESC.  Interestingly, even with that parameter defaulting to true, the datalist did not behave autoSelecty... so by setting this false, we aren't losing any functionality.  YES, I do believe there may still be a bug lurking deep inside DataList, but I wanted to keep this PR out of it, if at all possible.\r\n\r\nFWIW, there is still one annoying issue with these export inputs right now: after making a new selection in the datalist, the input losing focus.  This means that hitting tab will change layer selection, not tab to the next export input.\r\n\r\nUpdate: This PR also changes the way ESC key is handled in the case when the TextInput is focussed, but the Select List is closed (like when you first tab into the datalist, or after you've selected with a click).  There WAS a call to `onChange(null)` which seems to have been necessary for the SearchBar, which used that to trigger a close of the search dialog, but was otherwise dangerous.  I modified that specific codepath to just pass the key event to SearchBar (via the onKeyDown prop of DataList), which allows for NOT calling the aforementioned `onChange(null)`."},"comment":{"url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/comments/148124039","html_url":"https://github.com/adobe-photoshop/spaces-design/pull/2922#issuecomment-148124039","issue_url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/2922","id":148124039,"user":{"login":"mcilroyc","id":1168110,"avatar_url":"https://avatars.githubusercontent.com/u/1168110?v=3","gravatar_id":"","url":"https://api.github.com/users/mcilroyc","html_url":"https://github.com/mcilroyc","followers_url":"https://api.github.com/users/mcilroyc/followers","following_url":"https://api.github.com/users/mcilroyc/following{/other_user}","gists_url":"https://api.github.com/users/mcilroyc/gists{/gist_id}","starred_url":"https://api.github.com/users/mcilroyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcilroyc/subscriptions","organizations_url":"https://api.github.com/users/mcilroyc/orgs","repos_url":"https://api.github.com/users/mcilroyc/repos","events_url":"https://api.github.com/users/mcilroyc/events{/privacy}","received_events_url":"https://api.github.com/users/mcilroyc/received_events","type":"User","site_admin":false},"created_at":"2015-10-14T17:20:30Z","updated_at":"2015-10-14T17:20:30Z","body":"Thanks for catching that issue @pineapplespatula.  I've squashed it, I believe, so back to you."}}