{"action":"created","issue":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima/issues/750","labels_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/issues/750/labels{/name}","comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/issues/750/comments","events_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/issues/750/events","html_url":"https://github.com/IMA-WorldHealth/bhima/issues/750","id":107271382,"number":750,"title":"Optimize gulp build time","user":{"login":"jniles","id":896472,"avatar_url":"https://avatars.githubusercontent.com/u/896472?v=3","gravatar_id":"","url":"https://api.github.com/users/jniles","html_url":"https://github.com/jniles","followers_url":"https://api.github.com/users/jniles/followers","following_url":"https://api.github.com/users/jniles/following{/other_user}","gists_url":"https://api.github.com/users/jniles/gists{/gist_id}","starred_url":"https://api.github.com/users/jniles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jniles/subscriptions","organizations_url":"https://api.github.com/users/jniles/orgs","repos_url":"https://api.github.com/users/jniles/repos","events_url":"https://api.github.com/users/jniles/events{/privacy}","received_events_url":"https://api.github.com/users/jniles/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima/labels/build%20system","name":"build system","color":"fef2c0"},{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima/labels/discussion","name":"discussion","color":"d4c5f9"},{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima/labels/high%20priority","name":"high priority","color":"fad8c7"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-18T20:24:30Z","updated_at":"2015-12-15T08:45:53Z","closed_at":"2015-12-15T08:45:53Z","body":"It would be nice if we could optimize our build times a little more, without letting our standards (jshint. translations, etc) slip too significantly.\r\n\r\nI propose that we move utilities such as the JSON key validation @jmcameron built, jshint, and uglify out of the standard build.  For development, these are not critical, and we do a lot of development.  We can still expose these features for pre-PR checks by using a different gulp task (`gulp build-complete` or something).\r\n\r\nThe disadvantage with this proposal is that it will not enforce either balanced translations or keeping with jshint standards.  The reviewers of pull requests should probably validate that these check pass, or we could build it into a Travis build process.\r\n\r\nWhat do you all think? cc @IMA-WorldHealth/owners "},"comment":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima/issues/comments/164687855","html_url":"https://github.com/IMA-WorldHealth/bhima/issues/750#issuecomment-164687855","issue_url":"https://api.github.com/repos/IMA-WorldHealth/bhima/issues/750","id":164687855,"user":{"login":"jniles","id":896472,"avatar_url":"https://avatars.githubusercontent.com/u/896472?v=3","gravatar_id":"","url":"https://api.github.com/users/jniles","html_url":"https://github.com/jniles","followers_url":"https://api.github.com/users/jniles/followers","following_url":"https://api.github.com/users/jniles/following{/other_user}","gists_url":"https://api.github.com/users/jniles/gists{/gist_id}","starred_url":"https://api.github.com/users/jniles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jniles/subscriptions","organizations_url":"https://api.github.com/users/jniles/orgs","repos_url":"https://api.github.com/users/jniles/repos","events_url":"https://api.github.com/users/jniles/events{/privacy}","received_events_url":"https://api.github.com/users/jniles/received_events","type":"User","site_admin":false},"created_at":"2015-12-15T08:45:53Z","updated_at":"2015-12-15T08:45:53Z","body":"After some tests, the translation file linting was negligible.  The build has been optimized slightly by removing linting from the build, replaced by a warning to lint before submitting a PR.  I'll be working on a script for Travis to lint before approving a merge.\r\n\r\nClosing this since it has landed in development."}}