{"action":"created","issue":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/1529","labels_url":"https://api.github.com/repos/catapult-project/catapult/issues/1529/labels{/name}","comments_url":"https://api.github.com/repos/catapult-project/catapult/issues/1529/comments","events_url":"https://api.github.com/repos/catapult-project/catapult/issues/1529/events","html_url":"https://github.com/catapult-project/catapult/issues/1529","id":108290698,"number":1529,"title":"Feature proposal: \"Add to selection\" support","user":{"login":"petrcermak","id":2546601,"avatar_url":"https://avatars.githubusercontent.com/u/2546601?v=3","gravatar_id":"","url":"https://api.github.com/users/petrcermak","html_url":"https://github.com/petrcermak","followers_url":"https://api.github.com/users/petrcermak/followers","following_url":"https://api.github.com/users/petrcermak/following{/other_user}","gists_url":"https://api.github.com/users/petrcermak/gists{/gist_id}","starred_url":"https://api.github.com/users/petrcermak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrcermak/subscriptions","organizations_url":"https://api.github.com/users/petrcermak/orgs","repos_url":"https://api.github.com/users/petrcermak/repos","events_url":"https://api.github.com/users/petrcermak/events{/privacy}","received_events_url":"https://api.github.com/users/petrcermak/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/catapult-project/catapult/labels/Enhancement","name":"Enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/catapult-project/catapult/labels/Trace%20Viewer","name":"Trace Viewer","color":"fad8c7"},{"url":"https://api.github.com/repos/catapult-project/catapult/labels/UI","name":"UI","color":"006b75"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-25T09:19:12Z","updated_at":"2015-09-25T14:54:27Z","closed_at":null,"body":"I'm currently improving the analysis UI for multiple memory dumps (#1369). One of the main use cases will be to analyze how memory usage changed between two timestamps (i.e. diff). Since all manual selections in Trace Viewer must be contiguous (i.e. without \"gaps\"), the only way to provide a diff between two non-adjacent memory dumps is to make the user select the whole range of dumps between the two timestamps, which is not user-friendly.\r\n\r\nTherefore, I propose we **add support for adding events to the current selection**. The most natural thing would probably be (this seems to be the de facto standard):\r\n\r\n   * Click/drag a rectangle: Set new selection (existing behavior)\r\n   * _Ctrl_ + click/drag a rectangle: Add new selection to the current selection (new behavior)\r\n\r\nI think this would be very simple to implement. The only issue I see here is that we already use _Ctrl_ to toggle mouse mode to \"zoom\". I don't know how many people actually know/use it (I suppose only a couple of power users?). My suggestion would be to change the key for the \"zoom\" mode to _Alt_.\r\n\r\n@natduca, @dj2: WDYT?\r\n"},"comment":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/comments/143244352","html_url":"https://github.com/catapult-project/catapult/issues/1529#issuecomment-143244352","issue_url":"https://api.github.com/repos/catapult-project/catapult/issues/1529","id":143244352,"user":{"login":"natduca","id":412396,"avatar_url":"https://avatars.githubusercontent.com/u/412396?v=3","gravatar_id":"","url":"https://api.github.com/users/natduca","html_url":"https://github.com/natduca","followers_url":"https://api.github.com/users/natduca/followers","following_url":"https://api.github.com/users/natduca/following{/other_user}","gists_url":"https://api.github.com/users/natduca/gists{/gist_id}","starred_url":"https://api.github.com/users/natduca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natduca/subscriptions","organizations_url":"https://api.github.com/users/natduca/orgs","repos_url":"https://api.github.com/users/natduca/repos","events_url":"https://api.github.com/users/natduca/events{/privacy}","received_events_url":"https://api.github.com/users/natduca/received_events","type":"User","site_admin":false},"created_at":"2015-09-25T14:54:27Z","updated_at":"2015-09-25T14:54:27Z","body":"Love it."}}