{"action":"created","issue":{"url":"https://api.github.com/repos/racketlogger/tennis-rating/issues/1","labels_url":"https://api.github.com/repos/racketlogger/tennis-rating/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/racketlogger/tennis-rating/issues/1/comments","events_url":"https://api.github.com/repos/racketlogger/tennis-rating/issues/1/events","html_url":"https://github.com/racketlogger/tennis-rating/pull/1","id":63032133,"number":1,"title":"Tennis rating implement","user":{"login":"xw19","id":10752703,"avatar_url":"https://avatars.githubusercontent.com/u/10752703?v=3","gravatar_id":"","url":"https://api.github.com/users/xw19","html_url":"https://github.com/xw19","followers_url":"https://api.github.com/users/xw19/followers","following_url":"https://api.github.com/users/xw19/following{/other_user}","gists_url":"https://api.github.com/users/xw19/gists{/gist_id}","starred_url":"https://api.github.com/users/xw19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xw19/subscriptions","organizations_url":"https://api.github.com/users/xw19/orgs","repos_url":"https://api.github.com/users/xw19/repos","events_url":"https://api.github.com/users/xw19/events{/privacy}","received_events_url":"https://api.github.com/users/xw19/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-19T16:40:06Z","updated_at":"2015-03-20T03:13:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/racketlogger/tennis-rating/pulls/1","html_url":"https://github.com/racketlogger/tennis-rating/pull/1","diff_url":"https://github.com/racketlogger/tennis-rating/pull/1.diff","patch_url":"https://github.com/racketlogger/tennis-rating/pull/1.patch"},"body":"I tried to implement the rating system\r\nAssumption:  The scores are of individual match\r\nI have tried to keep it simple although it could be done in less amount of code.\r\nWhen I import the data from yaml file I get array a string containg match results. Now breaking the string and converting it into a array where each array represents a match and a subarray represents a set. For each wining set that is if 0th element is greater than the 1st two points are given minus the ratio of lost/won. The result is added for each set. "},"comment":{"url":"https://api.github.com/repos/racketlogger/tennis-rating/issues/comments/83869217","html_url":"https://github.com/racketlogger/tennis-rating/pull/1#issuecomment-83869217","issue_url":"https://api.github.com/repos/racketlogger/tennis-rating/issues/1","id":83869217,"user":{"login":"cpg","id":9907,"avatar_url":"https://avatars.githubusercontent.com/u/9907?v=3","gravatar_id":"","url":"https://api.github.com/users/cpg","html_url":"https://github.com/cpg","followers_url":"https://api.github.com/users/cpg/followers","following_url":"https://api.github.com/users/cpg/following{/other_user}","gists_url":"https://api.github.com/users/cpg/gists{/gist_id}","starred_url":"https://api.github.com/users/cpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpg/subscriptions","organizations_url":"https://api.github.com/users/cpg/orgs","repos_url":"https://api.github.com/users/cpg/repos","events_url":"https://api.github.com/users/cpg/events{/privacy}","received_events_url":"https://api.github.com/users/cpg/received_events","type":"User","site_admin":false},"created_at":"2015-03-20T03:13:16Z","updated_at":"2015-03-20T03:13:16Z","body":"It's a good start, but I was expecting a significant amount more.\r\n\r\ni think this should be in the form of a *method*, so we can tweak things.\r\n\r\nhowever, that is the least of the issues here.\r\n\r\n* the code does not use the tennis gem to analyze the score and do accounting based on the interface from the gem\r\n* it's structured in a rather not-so-readable way. it took me a bit of reading through the code to know what was going on\r\n* there is floating point arithmetic -- seems like an unnecessary thing to do\r\n* ultimately, it does not seem like the beginning of a framework to tune/test rating systems (e.g. against each other)\r\n\r\nI think the code does not seem stylistically very ruby-esque. Not a very very bad thing, but still, it reads off to a ruby person.\r\n\r\n"}}