{"action":"created","issue":{"url":"https://api.github.com/repos/resque/resque/issues/1165","labels_url":"https://api.github.com/repos/resque/resque/issues/1165/labels{/name}","comments_url":"https://api.github.com/repos/resque/resque/issues/1165/comments","events_url":"https://api.github.com/repos/resque/resque/issues/1165/events","html_url":"https://github.com/resque/resque/pull/1165","id":25194533,"number":1165,"title":"Refactor Resque::Worker#prune_dead_workers","user":{"login":"jaredonline","id":14482,"avatar_url":"https://avatars.githubusercontent.com/u/14482?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredonline","html_url":"https://github.com/jaredonline","followers_url":"https://api.github.com/users/jaredonline/followers","following_url":"https://api.github.com/users/jaredonline/following{/other_user}","gists_url":"https://api.github.com/users/jaredonline/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredonline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredonline/subscriptions","organizations_url":"https://api.github.com/users/jaredonline/orgs","repos_url":"https://api.github.com/users/jaredonline/repos","events_url":"https://api.github.com/users/jaredonline/events{/privacy}","received_events_url":"https://api.github.com/users/jaredonline/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":20,"created_at":"2014-01-07T20:23:37Z","updated_at":"2015-10-29T13:44:57Z","closed_at":"2015-10-29T13:44:57Z","pull_request":{"url":"https://api.github.com/repos/resque/resque/pulls/1165","html_url":"https://github.com/resque/resque/pull/1165","diff_url":"https://github.com/resque/resque/pull/1165.diff","patch_url":"https://github.com/resque/resque/pull/1165.patch"},"body":"I was looking through CodeClimate for bad methods and found this one so\r\nI decided I could refactor it.\r\n\r\nTesting it was the hardest part.\r\n\r\nI moved a lot of what was in #prune_dead_workers into some helper\r\nmethods to split up responsibility.\r\n\r\nI also the order of the arguments passed to `assert_equal` in the\r\nProcessCoordinator test because the error output was confusing.\r\n\r\nI tried my best to adhere to the style of the code I saw, but I'm more than happy to make any changes."},"comment":{"url":"https://api.github.com/repos/resque/resque/issues/comments/152183195","html_url":"https://github.com/resque/resque/pull/1165#issuecomment-152183195","issue_url":"https://api.github.com/repos/resque/resque/issues/1165","id":152183195,"user":{"login":"steveklabnik","id":27786,"avatar_url":"https://avatars.githubusercontent.com/u/27786?v=3","gravatar_id":"","url":"https://api.github.com/users/steveklabnik","html_url":"https://github.com/steveklabnik","followers_url":"https://api.github.com/users/steveklabnik/followers","following_url":"https://api.github.com/users/steveklabnik/following{/other_user}","gists_url":"https://api.github.com/users/steveklabnik/gists{/gist_id}","starred_url":"https://api.github.com/users/steveklabnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveklabnik/subscriptions","organizations_url":"https://api.github.com/users/steveklabnik/orgs","repos_url":"https://api.github.com/users/steveklabnik/repos","events_url":"https://api.github.com/users/steveklabnik/events{/privacy}","received_events_url":"https://api.github.com/users/steveklabnik/received_events","type":"User","site_admin":false},"created_at":"2015-10-29T13:44:56Z","updated_at":"2015-10-29T13:44:56Z","body":"Hey there!\r\n\r\nSorry that your PR has (probably) languished. Resque development has been on hold for a long time. That said, @hoffmanc and I (as well as others, hopefully!) are going to be getting back to it. Which brings me to this PR.\r\n\r\nResque 2.0 is basically on hold, forever. We'll be swapping the `1-x-stable` and `master` branches sometime next week. For more details, see here: http://words.steveklabnik.com/rescuing-resque-again\r\n\r\nAs such, `master` won't be taking any improvements at this time, as this redux is basically dying off. So, thank you for the pull request, but I'm going to give it a close. Sorry again about the wait. If you'd like to pitch in on the new stuff, we'd love to have you! Just let us know."}}