{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3030","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3030/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3030/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3030/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/3030","id":106163125,"number":3030,"title":"[WIP] Fix efb2tex for Sonic Riders: Zero Gravity","user":{"login":"phire","id":138484,"avatar_url":"https://avatars.githubusercontent.com/u/138484?v=3","gravatar_id":"","url":"https://api.github.com/users/phire","html_url":"https://github.com/phire","followers_url":"https://api.github.com/users/phire/followers","following_url":"https://api.github.com/users/phire/following{/other_user}","gists_url":"https://api.github.com/users/phire/gists{/gist_id}","starred_url":"https://api.github.com/users/phire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phire/subscriptions","organizations_url":"https://api.github.com/users/phire/orgs","repos_url":"https://api.github.com/users/phire/repos","events_url":"https://api.github.com/users/phire/events{/privacy}","received_events_url":"https://api.github.com/users/phire/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-09-12T14:29:53Z","updated_at":"2015-10-28T21:26:31Z","closed_at":"2015-10-28T21:26:31Z","pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3030","html_url":"https://github.com/dolphin-emu/dolphin/pull/3030","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3030.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3030.patch"},"body":"Was broken by #2960. Compared to the original code, this probably improves efb2ram quality at higher IRs.\r\n\r\nThe game was padding the size of the efb2ram copy from 640x480 to 1024x512 (power of 2), It didn't actually use the rest of the texture, just leaving it a solid pink color, so our current method of \"just give it the efb copy anyway no matter what dimensions, as long as the starting address and hash match\" works just fine. \r\n\r\nBut our efb copy code hashes a 1024x480 texture, while the texture loading code hashes a 1024x512 texture, so they get different results.\r\n\r\nThe new texture loading code checks the size of the efb copy hash and re-does it's hash to match,"},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/151996443","html_url":"https://github.com/dolphin-emu/dolphin/pull/3030#issuecomment-151996443","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3030","id":151996443,"user":{"login":"phire","id":138484,"avatar_url":"https://avatars.githubusercontent.com/u/138484?v=3","gravatar_id":"","url":"https://api.github.com/users/phire","html_url":"https://github.com/phire","followers_url":"https://api.github.com/users/phire/followers","following_url":"https://api.github.com/users/phire/following{/other_user}","gists_url":"https://api.github.com/users/phire/gists{/gist_id}","starred_url":"https://api.github.com/users/phire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phire/subscriptions","organizations_url":"https://api.github.com/users/phire/orgs","repos_url":"https://api.github.com/users/phire/repos","events_url":"https://api.github.com/users/phire/events{/privacy}","received_events_url":"https://api.github.com/users/phire/received_events","type":"User","site_admin":false},"created_at":"2015-10-28T21:26:31Z","updated_at":"2015-10-28T21:26:31Z","body":"This has been fixed by mimimi's PR"}}