{"action":"created","comment":{"url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/pulls/comments/44561136","id":44561136,"diff_hunk":"@@ -759,6 +743,30 @@ maybe_close(State) ->\n termination_kind(normal) -> controlled;\n termination_kind(_)      -> uncontrolled.\n \n+format_hard_error(#amqp_error{name = N, explanation = E, method = M}) ->\n+    io_lib:format(\"operation ~s caused a connection exception ~s: ~p\", [M, N, E]);\n+format_hard_error(Reason) ->\n+    Reason.\n+\n+log_connection_exception(Name, Ex) ->\n+  Severity = case Ex of","path":"src/rabbit_reader.erl","position":33,"original_position":33,"commit_id":"d6a9619223ef32e141cbc0c4425c255bd3cce667","original_commit_id":"d6a9619223ef32e141cbc0c4425c255bd3cce667","user":{"login":"michaelklishin","id":1090,"avatar_url":"https://avatars.githubusercontent.com/u/1090?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelklishin","html_url":"https://github.com/michaelklishin","followers_url":"https://api.github.com/users/michaelklishin/followers","following_url":"https://api.github.com/users/michaelklishin/following{/other_user}","gists_url":"https://api.github.com/users/michaelklishin/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelklishin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelklishin/subscriptions","organizations_url":"https://api.github.com/users/michaelklishin/orgs","repos_url":"https://api.github.com/users/michaelklishin/repos","events_url":"https://api.github.com/users/michaelklishin/events{/privacy}","received_events_url":"https://api.github.com/users/michaelklishin/received_events","type":"User","site_admin":false},"body":"Sure, I've forgotten to run formatting before committing.","created_at":"2015-11-11T17:40:34Z","updated_at":"2015-11-11T17:40:34Z","html_url":"https://github.com/rabbitmq/rabbitmq-common/pull/13#discussion_r44561136","pull_request_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-common/pulls/comments/44561136"},"html":{"href":"https://github.com/rabbitmq/rabbitmq-common/pull/13#discussion_r44561136"},"pull_request":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-common/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/pulls/13","id":50408471,"html_url":"https://github.com/rabbitmq/rabbitmq-common/pull/13","diff_url":"https://github.com/rabbitmq/rabbitmq-common/pull/13.diff","patch_url":"https://github.com/rabbitmq/rabbitmq-common/pull/13.patch","issue_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/issues/13","number":13,"state":"open","locked":false,"title":"More sensible error messages for connection-level exceptions on running connections","user":{"login":"michaelklishin","id":1090,"avatar_url":"https://avatars.githubusercontent.com/u/1090?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelklishin","html_url":"https://github.com/michaelklishin","followers_url":"https://api.github.com/users/michaelklishin/followers","following_url":"https://api.github.com/users/michaelklishin/following{/other_user}","gists_url":"https://api.github.com/users/michaelklishin/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelklishin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelklishin/subscriptions","organizations_url":"https://api.github.com/users/michaelklishin/orgs","repos_url":"https://api.github.com/users/michaelklishin/repos","events_url":"https://api.github.com/users/michaelklishin/events{/privacy}","received_events_url":"https://api.github.com/users/michaelklishin/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/rabbitmq/rabbitmq-server/issues/419, includes #9, #10, #11, #12.","created_at":"2015-11-11T17:05:34Z","updated_at":"2015-11-11T17:40:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7cdf2b9320c590056f4fe4946f53d603c488684","assignee":{"login":"dumbbell","id":159804,"avatar_url":"https://avatars.githubusercontent.com/u/159804?v=3","gravatar_id":"","url":"https://api.github.com/users/dumbbell","html_url":"https://github.com/dumbbell","followers_url":"https://api.github.com/users/dumbbell/followers","following_url":"https://api.github.com/users/dumbbell/following{/other_user}","gists_url":"https://api.github.com/users/dumbbell/gists{/gist_id}","starred_url":"https://api.github.com/users/dumbbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumbbell/subscriptions","organizations_url":"https://api.github.com/users/dumbbell/orgs","repos_url":"https://api.github.com/users/dumbbell/repos","events_url":"https://api.github.com/users/dumbbell/events{/privacy}","received_events_url":"https://api.github.com/users/dumbbell/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/milestones/5","html_url":"https://github.com/rabbitmq/rabbitmq-common/milestones/n/a","labels_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/milestones/5/labels","id":1282194,"number":5,"title":"n/a","description":"Not applicable to a specific release","creator":{"login":"dumbbell","id":159804,"avatar_url":"https://avatars.githubusercontent.com/u/159804?v=3","gravatar_id":"","url":"https://api.github.com/users/dumbbell","html_url":"https://github.com/dumbbell","followers_url":"https://api.github.com/users/dumbbell/followers","following_url":"https://api.github.com/users/dumbbell/following{/other_user}","gists_url":"https://api.github.com/users/dumbbell/gists{/gist_id}","starred_url":"https://api.github.com/users/dumbbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumbbell/subscriptions","organizations_url":"https://api.github.com/users/dumbbell/orgs","repos_url":"https://api.github.com/users/dumbbell/repos","events_url":"https://api.github.com/users/dumbbell/events{/privacy}","received_events_url":"https://api.github.com/users/dumbbell/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":5,"state":"closed","created_at":"2015-08-31T15:20:23Z","updated_at":"2015-11-11T17:05:34Z","due_on":null,"closed_at":"2015-08-31T15:20:23Z"},"commits_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/pulls/13/commits","review_comments_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/pulls/13/comments","review_comment_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/issues/13/comments","statuses_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/statuses/d6a9619223ef32e141cbc0c4425c255bd3cce667","head":{"label":"rabbitmq:rabbitmq-server-419","ref":"rabbitmq-server-419","sha":"d6a9619223ef32e141cbc0c4425c255bd3cce667","user":{"login":"rabbitmq","id":96669,"avatar_url":"https://avatars.githubusercontent.com/u/96669?v=3","gravatar_id":"","url":"https://api.github.com/users/rabbitmq","html_url":"https://github.com/rabbitmq","followers_url":"https://api.github.com/users/rabbitmq/followers","following_url":"https://api.github.com/users/rabbitmq/following{/other_user}","gists_url":"https://api.github.com/users/rabbitmq/gists{/gist_id}","starred_url":"https://api.github.com/users/rabbitmq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabbitmq/subscriptions","organizations_url":"https://api.github.com/users/rabbitmq/orgs","repos_url":"https://api.github.com/users/rabbitmq/repos","events_url":"https://api.github.com/users/rabbitmq/events{/privacy}","received_events_url":"https://api.github.com/users/rabbitmq/received_events","type":"Organization","site_admin":false},"repo":{"id":41556899,"name":"rabbitmq-common","full_name":"rabbitmq/rabbitmq-common","owner":{"login":"rabbitmq","id":96669,"avatar_url":"https://avatars.githubusercontent.com/u/96669?v=3","gravatar_id":"","url":"https://api.github.com/users/rabbitmq","html_url":"https://github.com/rabbitmq","followers_url":"https://api.github.com/users/rabbitmq/followers","following_url":"https://api.github.com/users/rabbitmq/following{/other_user}","gists_url":"https://api.github.com/users/rabbitmq/gists{/gist_id}","starred_url":"https://api.github.com/users/rabbitmq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabbitmq/subscriptions","organizations_url":"https://api.github.com/users/rabbitmq/orgs","repos_url":"https://api.github.com/users/rabbitmq/repos","events_url":"https://api.github.com/users/rabbitmq/events{/privacy}","received_events_url":"https://api.github.com/users/rabbitmq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rabbitmq/rabbitmq-common","description":"Common library used by rabbitmq-server and rabbitmq-erlang-client","fork":false,"url":"https://api.github.com/repos/rabbitmq/rabbitmq-common","forks_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/forks","keys_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/teams","hooks_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/hooks","issue_events_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/issues/events{/number}","events_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/events","assignees_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/assignees{/user}","branches_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/branches{/branch}","tags_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/tags","blobs_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/statuses/{sha}","languages_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/languages","stargazers_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/stargazers","contributors_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/contributors","subscribers_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/subscribers","subscription_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/subscription","commits_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/contents/{+path}","compare_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/merges","archive_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/downloads","issues_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/issues{/number}","pulls_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/pulls{/number}","milestones_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/milestones{/number}","notifications_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/labels{/name}","releases_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/releases{/id}","created_at":"2015-08-28T16:13:39Z","updated_at":"2015-11-11T15:01:37Z","pushed_at":"2015-11-11T17:05:36Z","git_url":"git://github.com/rabbitmq/rabbitmq-common.git","ssh_url":"git@github.com:rabbitmq/rabbitmq-common.git","clone_url":"https://github.com/rabbitmq/rabbitmq-common.git","svn_url":"https://github.com/rabbitmq/rabbitmq-common","homepage":"","size":663,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":6,"forks":4,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"rabbitmq:master","ref":"master","sha":"b2528d3a091aca1fb3d66e0de26e03200a9aa836","user":{"login":"rabbitmq","id":96669,"avatar_url":"https://avatars.githubusercontent.com/u/96669?v=3","gravatar_id":"","url":"https://api.github.com/users/rabbitmq","html_url":"https://github.com/rabbitmq","followers_url":"https://api.github.com/users/rabbitmq/followers","following_url":"https://api.github.com/users/rabbitmq/following{/other_user}","gists_url":"https://api.github.com/users/rabbitmq/gists{/gist_id}","starred_url":"https://api.github.com/users/rabbitmq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabbitmq/subscriptions","organizations_url":"https://api.github.com/users/rabbitmq/orgs","repos_url":"https://api.github.com/users/rabbitmq/repos","events_url":"https://api.github.com/users/rabbitmq/events{/privacy}","received_events_url":"https://api.github.com/users/rabbitmq/received_events","type":"Organization","site_admin":false},"repo":{"id":41556899,"name":"rabbitmq-common","full_name":"rabbitmq/rabbitmq-common","owner":{"login":"rabbitmq","id":96669,"avatar_url":"https://avatars.githubusercontent.com/u/96669?v=3","gravatar_id":"","url":"https://api.github.com/users/rabbitmq","html_url":"https://github.com/rabbitmq","followers_url":"https://api.github.com/users/rabbitmq/followers","following_url":"https://api.github.com/users/rabbitmq/following{/other_user}","gists_url":"https://api.github.com/users/rabbitmq/gists{/gist_id}","starred_url":"https://api.github.com/users/rabbitmq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabbitmq/subscriptions","organizations_url":"https://api.github.com/users/rabbitmq/orgs","repos_url":"https://api.github.com/users/rabbitmq/repos","events_url":"https://api.github.com/users/rabbitmq/events{/privacy}","received_events_url":"https://api.github.com/users/rabbitmq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rabbitmq/rabbitmq-common","description":"Common library used by rabbitmq-server and rabbitmq-erlang-client","fork":false,"url":"https://api.github.com/repos/rabbitmq/rabbitmq-common","forks_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/forks","keys_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/teams","hooks_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/hooks","issue_events_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/issues/events{/number}","events_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/events","assignees_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/assignees{/user}","branches_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/branches{/branch}","tags_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/tags","blobs_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/statuses/{sha}","languages_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/languages","stargazers_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/stargazers","contributors_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/contributors","subscribers_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/subscribers","subscription_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/subscription","commits_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/contents/{+path}","compare_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/merges","archive_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/downloads","issues_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/issues{/number}","pulls_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/pulls{/number}","milestones_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/milestones{/number}","notifications_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/labels{/name}","releases_url":"https://api.github.com/repos/rabbitmq/rabbitmq-common/releases{/id}","created_at":"2015-08-28T16:13:39Z","updated_at":"2015-11-11T15:01:37Z","pushed_at":"2015-11-11T17:05:36Z","git_url":"git://github.com/rabbitmq/rabbitmq-common.git","ssh_url":"git@github.com:rabbitmq/rabbitmq-common.git","clone_url":"https://github.com/rabbitmq/rabbitmq-common.git","svn_url":"https://github.com/rabbitmq/rabbitmq-common","homepage":"","size":663,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":6,"forks":4,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-common/pulls/13"},"html":{"href":"https://github.com/rabbitmq/rabbitmq-common/pull/13"},"issue":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-common/issues/13"},"comments":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-common/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-common/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-common/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-common/statuses/d6a9619223ef32e141cbc0c4425c255bd3cce667"}}}}