{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/39902903","id":39902903,"diff_hunk":"@@ -81,7 +81,7 @@ function shell_parse(raw::AbstractString, interp::Bool)\n                     if done(s,k)\n                         error(\"unterminated double quote\")\n                     end\n-                    if s[k] == '\"' || s[k] == '$'\n+                    if s[k] == '\"' || s[k] == '$' || s[k] == '\\\\'","path":"base/shell.jl","position":5,"original_position":5,"commit_id":"bf2f2d103a2cf2eb0d8f532ac30f22ab1e3a9d40","original_commit_id":"bf2f2d103a2cf2eb0d8f532ac30f22ab1e3a9d40","user":{"login":"StefanKarpinski","id":153596,"avatar_url":"https://avatars.githubusercontent.com/u/153596?v=3","gravatar_id":"","url":"https://api.github.com/users/StefanKarpinski","html_url":"https://github.com/StefanKarpinski","followers_url":"https://api.github.com/users/StefanKarpinski/followers","following_url":"https://api.github.com/users/StefanKarpinski/following{/other_user}","gists_url":"https://api.github.com/users/StefanKarpinski/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanKarpinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanKarpinski/subscriptions","organizations_url":"https://api.github.com/users/StefanKarpinski/orgs","repos_url":"https://api.github.com/users/StefanKarpinski/repos","events_url":"https://api.github.com/users/StefanKarpinski/events{/privacy}","received_events_url":"https://api.github.com/users/StefanKarpinski/received_events","type":"User","site_admin":false},"body":"Especially since that fix will need to be incorporated into @nolta's port of `shell_parse` to Scheme.","created_at":"2015-09-18T21:26:13Z","updated_at":"2015-09-18T21:26:13Z","html_url":"https://github.com/JuliaLang/julia/pull/13214#discussion_r39902903","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/13214","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/39902903"},"html":{"href":"https://github.com/JuliaLang/julia/pull/13214#discussion_r39902903"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/13214"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/13214","id":45445124,"html_url":"https://github.com/JuliaLang/julia/pull/13214","diff_url":"https://github.com/JuliaLang/julia/pull/13214.diff","patch_url":"https://github.com/JuliaLang/julia/pull/13214.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/13214","number":13214,"state":"open","locked":false,"title":"Correctly parse and quote shell commands","user":{"login":"eschnett","id":213514,"avatar_url":"https://avatars.githubusercontent.com/u/213514?v=3","gravatar_id":"","url":"https://api.github.com/users/eschnett","html_url":"https://github.com/eschnett","followers_url":"https://api.github.com/users/eschnett/followers","following_url":"https://api.github.com/users/eschnett/following{/other_user}","gists_url":"https://api.github.com/users/eschnett/gists{/gist_id}","starred_url":"https://api.github.com/users/eschnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eschnett/subscriptions","organizations_url":"https://api.github.com/users/eschnett/orgs","repos_url":"https://api.github.com/users/eschnett/repos","events_url":"https://api.github.com/users/eschnett/events{/privacy}","received_events_url":"https://api.github.com/users/eschnett/received_events","type":"User","site_admin":false},"body":"The quoting is now safe for Posix sh-like shells.\r\n\r\nThe algorithm tries several ways to quote words (via single or double quotes or backslashes), and then uses a scoring method to choose the \"best\" result. The current scoring chooses the shortest string, and adds additional penalties for backslashes.","created_at":"2015-09-18T19:46:21Z","updated_at":"2015-09-18T21:26:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b284dad61a474fe475a2f39cb4dd4d076acb2b35","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/13214/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/13214/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/13214/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/bf2f2d103a2cf2eb0d8f532ac30f22ab1e3a9d40","head":{"label":"eschnett:shell_escape","ref":"shell_escape","sha":"bf2f2d103a2cf2eb0d8f532ac30f22ab1e3a9d40","user":{"login":"eschnett","id":213514,"avatar_url":"https://avatars.githubusercontent.com/u/213514?v=3","gravatar_id":"","url":"https://api.github.com/users/eschnett","html_url":"https://github.com/eschnett","followers_url":"https://api.github.com/users/eschnett/followers","following_url":"https://api.github.com/users/eschnett/following{/other_user}","gists_url":"https://api.github.com/users/eschnett/gists{/gist_id}","starred_url":"https://api.github.com/users/eschnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eschnett/subscriptions","organizations_url":"https://api.github.com/users/eschnett/orgs","repos_url":"https://api.github.com/users/eschnett/repos","events_url":"https://api.github.com/users/eschnett/events{/privacy}","received_events_url":"https://api.github.com/users/eschnett/received_events","type":"User","site_admin":false},"repo":{"id":23268889,"name":"julia","full_name":"eschnett/julia","owner":{"login":"eschnett","id":213514,"avatar_url":"https://avatars.githubusercontent.com/u/213514?v=3","gravatar_id":"","url":"https://api.github.com/users/eschnett","html_url":"https://github.com/eschnett","followers_url":"https://api.github.com/users/eschnett/followers","following_url":"https://api.github.com/users/eschnett/following{/other_user}","gists_url":"https://api.github.com/users/eschnett/gists{/gist_id}","starred_url":"https://api.github.com/users/eschnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eschnett/subscriptions","organizations_url":"https://api.github.com/users/eschnett/orgs","repos_url":"https://api.github.com/users/eschnett/repos","events_url":"https://api.github.com/users/eschnett/events{/privacy}","received_events_url":"https://api.github.com/users/eschnett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eschnett/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/eschnett/julia","forks_url":"https://api.github.com/repos/eschnett/julia/forks","keys_url":"https://api.github.com/repos/eschnett/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eschnett/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eschnett/julia/teams","hooks_url":"https://api.github.com/repos/eschnett/julia/hooks","issue_events_url":"https://api.github.com/repos/eschnett/julia/issues/events{/number}","events_url":"https://api.github.com/repos/eschnett/julia/events","assignees_url":"https://api.github.com/repos/eschnett/julia/assignees{/user}","branches_url":"https://api.github.com/repos/eschnett/julia/branches{/branch}","tags_url":"https://api.github.com/repos/eschnett/julia/tags","blobs_url":"https://api.github.com/repos/eschnett/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eschnett/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eschnett/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/eschnett/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eschnett/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/eschnett/julia/languages","stargazers_url":"https://api.github.com/repos/eschnett/julia/stargazers","contributors_url":"https://api.github.com/repos/eschnett/julia/contributors","subscribers_url":"https://api.github.com/repos/eschnett/julia/subscribers","subscription_url":"https://api.github.com/repos/eschnett/julia/subscription","commits_url":"https://api.github.com/repos/eschnett/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/eschnett/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/eschnett/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/eschnett/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/eschnett/julia/contents/{+path}","compare_url":"https://api.github.com/repos/eschnett/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eschnett/julia/merges","archive_url":"https://api.github.com/repos/eschnett/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eschnett/julia/downloads","issues_url":"https://api.github.com/repos/eschnett/julia/issues{/number}","pulls_url":"https://api.github.com/repos/eschnett/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/eschnett/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/eschnett/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eschnett/julia/labels{/name}","releases_url":"https://api.github.com/repos/eschnett/julia/releases{/id}","created_at":"2014-08-23T23:50:07Z","updated_at":"2015-02-03T13:25:37Z","pushed_at":"2015-09-18T20:59:17Z","git_url":"git://github.com/eschnett/julia.git","ssh_url":"git@github.com:eschnett/julia.git","clone_url":"https://github.com/eschnett/julia.git","svn_url":"https://github.com/eschnett/julia","homepage":"http://julialang.org/","size":89349,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"92aa1a60ab9c3f9772ebe266e9012084d9342173","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","created_at":"2011-04-21T07:01:50Z","updated_at":"2015-09-18T20:05:37Z","pushed_at":"2015-09-18T21:24:12Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":226318,"stargazers_count":5992,"watchers_count":5992,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1321,"mirror_url":null,"open_issues_count":1396,"forks":1321,"open_issues":1396,"watchers":5992,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/13214"},"html":{"href":"https://github.com/JuliaLang/julia/pull/13214"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/13214"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/13214/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/13214/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/13214/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/bf2f2d103a2cf2eb0d8f532ac30f22ab1e3a9d40"}}}}