{"action":"created","comment":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/44588351","id":44588351,"diff_hunk":"@@ -8,25 +8,36 @@ class Robot\n   def initialize(args = {})\n     @@registry ||= []\n     @name_generator = args[:name_generator]\n+    generate_name\n+  end\n+\n+  def alpha_char\n+    ('A'..'Z').to_a.sample\n+  end\n+\n+  def digit\n+    rand(10)\n+  end\n \n-    if @name_generator\n-      @name = @name_generator.call\n-    else\n-      generate_char = -> { ('A'..'Z').to_a.sample }\n-      generate_num = -> { rand(10) }\n+  def invalid_name?\n+    !(name =~ /[[:alpha:]]{2}[[:digit:]]{3}/) || @@registry.include?(name)\n+  end\n \n-      @name = \"#{generate_char.call}#{generate_char.call}#{generate_num.call}#{generate_num.call}#{generate_num.call}\"\n-    end\n+  def rand_name_generator\n+    @name = \"#{alpha_char}#{alpha_char}#{digit}#{digit}#{digit}\"\n+    return @name unless invalid_name?\n+    raise NameCollisionError, \"There was a problem generating the robot name!\"\n+  end\n \n-    raise NameCollisionError, 'There was a problem generating the robot name!' if !(name =~ /[[:alpha:]]{2}[[:digit:]]{3}/) || @@registry.include?(name)\n+  def generate_name\n+    @name = @name_generator ? name_generator.call : rand_name_generator\n     @@registry << @name\n   end\n end\n \n-robot = Robot.new\n+robot = RobotName.new","path":"robot_name/robot_name.rb","position":49,"original_position":49,"commit_id":"75bced507e7c27f83cf64f6f92c67fc7e76a3fa9","original_commit_id":"75bced507e7c27f83cf64f6f92c67fc7e76a3fa9","user":{"login":"ochagata","id":4699540,"avatar_url":"https://avatars.githubusercontent.com/u/4699540?v=3","gravatar_id":"","url":"https://api.github.com/users/ochagata","html_url":"https://github.com/ochagata","followers_url":"https://api.github.com/users/ochagata/followers","following_url":"https://api.github.com/users/ochagata/following{/other_user}","gists_url":"https://api.github.com/users/ochagata/gists{/gist_id}","starred_url":"https://api.github.com/users/ochagata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ochagata/subscriptions","organizations_url":"https://api.github.com/users/ochagata/orgs","repos_url":"https://api.github.com/users/ochagata/repos","events_url":"https://api.github.com/users/ochagata/events{/privacy}","received_events_url":"https://api.github.com/users/ochagata/received_events","type":"User","site_admin":false},"body":"Once you have tests, you can remove this from the base file","created_at":"2015-11-11T21:24:58Z","updated_at":"2015-11-11T21:24:58Z","html_url":"https://github.com/jmmastey/level_up_exercises/pull/1050#discussion_r44588351","pull_request_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1050","_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/44588351"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/1050#discussion_r44588351"},"pull_request":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1050"}}},"pull_request":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1050","id":50181512,"html_url":"https://github.com/jmmastey/level_up_exercises/pull/1050","diff_url":"https://github.com/jmmastey/level_up_exercises/pull/1050.diff","patch_url":"https://github.com/jmmastey/level_up_exercises/pull/1050.patch","issue_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/1050","number":1050,"state":"open","locked":false,"title":"Arrowhead & Robot Name - Iteration 1","user":{"login":"creativisionist","id":10764566,"avatar_url":"https://avatars.githubusercontent.com/u/10764566?v=3","gravatar_id":"","url":"https://api.github.com/users/creativisionist","html_url":"https://github.com/creativisionist","followers_url":"https://api.github.com/users/creativisionist/followers","following_url":"https://api.github.com/users/creativisionist/following{/other_user}","gists_url":"https://api.github.com/users/creativisionist/gists{/gist_id}","starred_url":"https://api.github.com/users/creativisionist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creativisionist/subscriptions","organizations_url":"https://api.github.com/users/creativisionist/orgs","repos_url":"https://api.github.com/users/creativisionist/repos","events_url":"https://api.github.com/users/creativisionist/events{/privacy}","received_events_url":"https://api.github.com/users/creativisionist/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-09T21:39:47Z","updated_at":"2015-11-11T21:24:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59cf903635552d00378574c8914cbeaef492b9ba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1050/commits","review_comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1050/comments","review_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/1050/comments","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/75bced507e7c27f83cf64f6f92c67fc7e76a3fa9","head":{"label":"creativisionist:an-ruby","ref":"an-ruby","sha":"75bced507e7c27f83cf64f6f92c67fc7e76a3fa9","user":{"login":"creativisionist","id":10764566,"avatar_url":"https://avatars.githubusercontent.com/u/10764566?v=3","gravatar_id":"","url":"https://api.github.com/users/creativisionist","html_url":"https://github.com/creativisionist","followers_url":"https://api.github.com/users/creativisionist/followers","following_url":"https://api.github.com/users/creativisionist/following{/other_user}","gists_url":"https://api.github.com/users/creativisionist/gists{/gist_id}","starred_url":"https://api.github.com/users/creativisionist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creativisionist/subscriptions","organizations_url":"https://api.github.com/users/creativisionist/orgs","repos_url":"https://api.github.com/users/creativisionist/repos","events_url":"https://api.github.com/users/creativisionist/events{/privacy}","received_events_url":"https://api.github.com/users/creativisionist/received_events","type":"User","site_admin":false},"repo":{"id":45402867,"name":"level_up_exercises","full_name":"creativisionist/level_up_exercises","owner":{"login":"creativisionist","id":10764566,"avatar_url":"https://avatars.githubusercontent.com/u/10764566?v=3","gravatar_id":"","url":"https://api.github.com/users/creativisionist","html_url":"https://github.com/creativisionist","followers_url":"https://api.github.com/users/creativisionist/followers","following_url":"https://api.github.com/users/creativisionist/following{/other_user}","gists_url":"https://api.github.com/users/creativisionist/gists{/gist_id}","starred_url":"https://api.github.com/users/creativisionist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creativisionist/subscriptions","organizations_url":"https://api.github.com/users/creativisionist/orgs","repos_url":"https://api.github.com/users/creativisionist/repos","events_url":"https://api.github.com/users/creativisionist/events{/privacy}","received_events_url":"https://api.github.com/users/creativisionist/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/creativisionist/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":true,"url":"https://api.github.com/repos/creativisionist/level_up_exercises","forks_url":"https://api.github.com/repos/creativisionist/level_up_exercises/forks","keys_url":"https://api.github.com/repos/creativisionist/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/creativisionist/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/creativisionist/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/creativisionist/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/creativisionist/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/creativisionist/level_up_exercises/events","assignees_url":"https://api.github.com/repos/creativisionist/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/creativisionist/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/creativisionist/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/creativisionist/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/creativisionist/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/creativisionist/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/creativisionist/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/creativisionist/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/creativisionist/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/creativisionist/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/creativisionist/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/creativisionist/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/creativisionist/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/creativisionist/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/creativisionist/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/creativisionist/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/creativisionist/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/creativisionist/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/creativisionist/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/creativisionist/level_up_exercises/merges","archive_url":"https://api.github.com/repos/creativisionist/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/creativisionist/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/creativisionist/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/creativisionist/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/creativisionist/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/creativisionist/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/creativisionist/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/creativisionist/level_up_exercises/releases{/id}","created_at":"2015-11-02T15:24:51Z","updated_at":"2015-11-02T15:24:51Z","pushed_at":"2015-11-10T20:21:35Z","git_url":"git://github.com/creativisionist/level_up_exercises.git","ssh_url":"git@github.com:creativisionist/level_up_exercises.git","clone_url":"https://github.com/creativisionist/level_up_exercises.git","svn_url":"https://github.com/creativisionist/level_up_exercises","homepage":"https://leveluprails.com","size":331,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmmastey:master","ref":"master","sha":"ee878bc2c9a3337ffa3372654f508733dd2f66c1","user":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"repo":{"id":20705648,"name":"level_up_exercises","full_name":"jmmastey/level_up_exercises","owner":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmastey/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":false,"url":"https://api.github.com/repos/jmmastey/level_up_exercises","forks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/forks","keys_url":"https://api.github.com/repos/jmmastey/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmastey/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmastey/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/events","assignees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/jmmastey/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmastey/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/jmmastey/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmastey/level_up_exercises/merges","archive_url":"https://api.github.com/repos/jmmastey/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmastey/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmastey/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmastey/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmastey/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/jmmastey/level_up_exercises/releases{/id}","created_at":"2014-06-10T23:42:24Z","updated_at":"2015-11-05T01:28:26Z","pushed_at":"2015-11-10T20:21:36Z","git_url":"git://github.com/jmmastey/level_up_exercises.git","ssh_url":"git@github.com:jmmastey/level_up_exercises.git","clone_url":"https://github.com/jmmastey/level_up_exercises.git","svn_url":"https://github.com/jmmastey/level_up_exercises","homepage":"https://leveluprails.com","size":230991,"stargazers_count":31,"watchers_count":31,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":153,"mirror_url":null,"open_issues_count":4,"forks":153,"open_issues":4,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1050"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/1050"},"issue":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/1050"},"comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/1050/comments"},"review_comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1050/comments"},"review_comment":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1050/commits"},"statuses":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/75bced507e7c27f83cf64f6f92c67fc7e76a3fa9"}}}}