{"action":"opened","number":759,"pull_request":{"url":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/759","id":37028577,"html_url":"https://github.com/cjohansen/Sinon.JS/pull/759","diff_url":"https://github.com/cjohansen/Sinon.JS/pull/759.diff","patch_url":"https://github.com/cjohansen/Sinon.JS/pull/759.patch","issue_url":"https://api.github.com/repos/cjohansen/Sinon.JS/issues/759","number":759,"state":"open","locked":false,"title":"Add support for responseType=json","user":{"login":"anatomic","id":152841,"avatar_url":"https://avatars.githubusercontent.com/u/152841?v=3","gravatar_id":"","url":"https://api.github.com/users/anatomic","html_url":"https://github.com/anatomic","followers_url":"https://api.github.com/users/anatomic/followers","following_url":"https://api.github.com/users/anatomic/following{/other_user}","gists_url":"https://api.github.com/users/anatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/anatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anatomic/subscriptions","organizations_url":"https://api.github.com/users/anatomic/orgs","repos_url":"https://api.github.com/users/anatomic/repos","events_url":"https://api.github.com/users/anatomic/events{/privacy}","received_events_url":"https://api.github.com/users/anatomic/received_events","type":"User","site_admin":false},"body":"When working with FakeXMLHttpRequest I found that there were several instances where my tests were failing because xhr.response wasn't correctly parsed as JSON.\r\n\r\nI have added code to support setting responseType = \"json\" and return a response inline with the spec here: https://xhr.spec.whatwg.org/#dom-xmlhttprequest-responsetype\r\n\r\nThere are tests around this new functionality and nothing else is reporting as a fail.\r\n\r\nThanks for the great package!","created_at":"2015-06-05T12:56:45Z","updated_at":"2015-06-05T12:56:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/759/commits","review_comments_url":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/759/comments","review_comment_url":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cjohansen/Sinon.JS/issues/759/comments","statuses_url":"https://api.github.com/repos/cjohansen/Sinon.JS/statuses/ff103929ca84a460e0ceed56dedb2690207de97d","head":{"label":"anatomic:master","ref":"master","sha":"ff103929ca84a460e0ceed56dedb2690207de97d","user":{"login":"anatomic","id":152841,"avatar_url":"https://avatars.githubusercontent.com/u/152841?v=3","gravatar_id":"","url":"https://api.github.com/users/anatomic","html_url":"https://github.com/anatomic","followers_url":"https://api.github.com/users/anatomic/followers","following_url":"https://api.github.com/users/anatomic/following{/other_user}","gists_url":"https://api.github.com/users/anatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/anatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anatomic/subscriptions","organizations_url":"https://api.github.com/users/anatomic/orgs","repos_url":"https://api.github.com/users/anatomic/repos","events_url":"https://api.github.com/users/anatomic/events{/privacy}","received_events_url":"https://api.github.com/users/anatomic/received_events","type":"User","site_admin":false},"repo":{"id":36927545,"name":"Sinon.JS","full_name":"anatomic/Sinon.JS","owner":{"login":"anatomic","id":152841,"avatar_url":"https://avatars.githubusercontent.com/u/152841?v=3","gravatar_id":"","url":"https://api.github.com/users/anatomic","html_url":"https://github.com/anatomic","followers_url":"https://api.github.com/users/anatomic/followers","following_url":"https://api.github.com/users/anatomic/following{/other_user}","gists_url":"https://api.github.com/users/anatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/anatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anatomic/subscriptions","organizations_url":"https://api.github.com/users/anatomic/orgs","repos_url":"https://api.github.com/users/anatomic/repos","events_url":"https://api.github.com/users/anatomic/events{/privacy}","received_events_url":"https://api.github.com/users/anatomic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anatomic/Sinon.JS","description":"Test spies, stubs and mocks for JavaScript.","fork":true,"url":"https://api.github.com/repos/anatomic/Sinon.JS","forks_url":"https://api.github.com/repos/anatomic/Sinon.JS/forks","keys_url":"https://api.github.com/repos/anatomic/Sinon.JS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anatomic/Sinon.JS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anatomic/Sinon.JS/teams","hooks_url":"https://api.github.com/repos/anatomic/Sinon.JS/hooks","issue_events_url":"https://api.github.com/repos/anatomic/Sinon.JS/issues/events{/number}","events_url":"https://api.github.com/repos/anatomic/Sinon.JS/events","assignees_url":"https://api.github.com/repos/anatomic/Sinon.JS/assignees{/user}","branches_url":"https://api.github.com/repos/anatomic/Sinon.JS/branches{/branch}","tags_url":"https://api.github.com/repos/anatomic/Sinon.JS/tags","blobs_url":"https://api.github.com/repos/anatomic/Sinon.JS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anatomic/Sinon.JS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anatomic/Sinon.JS/git/refs{/sha}","trees_url":"https://api.github.com/repos/anatomic/Sinon.JS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anatomic/Sinon.JS/statuses/{sha}","languages_url":"https://api.github.com/repos/anatomic/Sinon.JS/languages","stargazers_url":"https://api.github.com/repos/anatomic/Sinon.JS/stargazers","contributors_url":"https://api.github.com/repos/anatomic/Sinon.JS/contributors","subscribers_url":"https://api.github.com/repos/anatomic/Sinon.JS/subscribers","subscription_url":"https://api.github.com/repos/anatomic/Sinon.JS/subscription","commits_url":"https://api.github.com/repos/anatomic/Sinon.JS/commits{/sha}","git_commits_url":"https://api.github.com/repos/anatomic/Sinon.JS/git/commits{/sha}","comments_url":"https://api.github.com/repos/anatomic/Sinon.JS/comments{/number}","issue_comment_url":"https://api.github.com/repos/anatomic/Sinon.JS/issues/comments{/number}","contents_url":"https://api.github.com/repos/anatomic/Sinon.JS/contents/{+path}","compare_url":"https://api.github.com/repos/anatomic/Sinon.JS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anatomic/Sinon.JS/merges","archive_url":"https://api.github.com/repos/anatomic/Sinon.JS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anatomic/Sinon.JS/downloads","issues_url":"https://api.github.com/repos/anatomic/Sinon.JS/issues{/number}","pulls_url":"https://api.github.com/repos/anatomic/Sinon.JS/pulls{/number}","milestones_url":"https://api.github.com/repos/anatomic/Sinon.JS/milestones{/number}","notifications_url":"https://api.github.com/repos/anatomic/Sinon.JS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anatomic/Sinon.JS/labels{/name}","releases_url":"https://api.github.com/repos/anatomic/Sinon.JS/releases{/id}","created_at":"2015-06-05T10:45:13Z","updated_at":"2015-06-05T10:45:13Z","pushed_at":"2015-06-05T12:54:28Z","git_url":"git://github.com/anatomic/Sinon.JS.git","ssh_url":"git@github.com:anatomic/Sinon.JS.git","clone_url":"https://github.com/anatomic/Sinon.JS.git","svn_url":"https://github.com/anatomic/Sinon.JS","homepage":"http://sinonjs.org/","size":5009,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cjohansen:master","ref":"master","sha":"2ea4f483bbfc8e12ad87edd35f3a78a6a691e853","user":{"login":"cjohansen","id":32871,"avatar_url":"https://avatars.githubusercontent.com/u/32871?v=3","gravatar_id":"","url":"https://api.github.com/users/cjohansen","html_url":"https://github.com/cjohansen","followers_url":"https://api.github.com/users/cjohansen/followers","following_url":"https://api.github.com/users/cjohansen/following{/other_user}","gists_url":"https://api.github.com/users/cjohansen/gists{/gist_id}","starred_url":"https://api.github.com/users/cjohansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjohansen/subscriptions","organizations_url":"https://api.github.com/users/cjohansen/orgs","repos_url":"https://api.github.com/users/cjohansen/repos","events_url":"https://api.github.com/users/cjohansen/events{/privacy}","received_events_url":"https://api.github.com/users/cjohansen/received_events","type":"User","site_admin":false},"repo":{"id":747698,"name":"Sinon.JS","full_name":"cjohansen/Sinon.JS","owner":{"login":"cjohansen","id":32871,"avatar_url":"https://avatars.githubusercontent.com/u/32871?v=3","gravatar_id":"","url":"https://api.github.com/users/cjohansen","html_url":"https://github.com/cjohansen","followers_url":"https://api.github.com/users/cjohansen/followers","following_url":"https://api.github.com/users/cjohansen/following{/other_user}","gists_url":"https://api.github.com/users/cjohansen/gists{/gist_id}","starred_url":"https://api.github.com/users/cjohansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjohansen/subscriptions","organizations_url":"https://api.github.com/users/cjohansen/orgs","repos_url":"https://api.github.com/users/cjohansen/repos","events_url":"https://api.github.com/users/cjohansen/events{/privacy}","received_events_url":"https://api.github.com/users/cjohansen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjohansen/Sinon.JS","description":"Test spies, stubs and mocks for JavaScript.","fork":false,"url":"https://api.github.com/repos/cjohansen/Sinon.JS","forks_url":"https://api.github.com/repos/cjohansen/Sinon.JS/forks","keys_url":"https://api.github.com/repos/cjohansen/Sinon.JS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjohansen/Sinon.JS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjohansen/Sinon.JS/teams","hooks_url":"https://api.github.com/repos/cjohansen/Sinon.JS/hooks","issue_events_url":"https://api.github.com/repos/cjohansen/Sinon.JS/issues/events{/number}","events_url":"https://api.github.com/repos/cjohansen/Sinon.JS/events","assignees_url":"https://api.github.com/repos/cjohansen/Sinon.JS/assignees{/user}","branches_url":"https://api.github.com/repos/cjohansen/Sinon.JS/branches{/branch}","tags_url":"https://api.github.com/repos/cjohansen/Sinon.JS/tags","blobs_url":"https://api.github.com/repos/cjohansen/Sinon.JS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjohansen/Sinon.JS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjohansen/Sinon.JS/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjohansen/Sinon.JS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjohansen/Sinon.JS/statuses/{sha}","languages_url":"https://api.github.com/repos/cjohansen/Sinon.JS/languages","stargazers_url":"https://api.github.com/repos/cjohansen/Sinon.JS/stargazers","contributors_url":"https://api.github.com/repos/cjohansen/Sinon.JS/contributors","subscribers_url":"https://api.github.com/repos/cjohansen/Sinon.JS/subscribers","subscription_url":"https://api.github.com/repos/cjohansen/Sinon.JS/subscription","commits_url":"https://api.github.com/repos/cjohansen/Sinon.JS/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjohansen/Sinon.JS/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjohansen/Sinon.JS/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjohansen/Sinon.JS/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjohansen/Sinon.JS/contents/{+path}","compare_url":"https://api.github.com/repos/cjohansen/Sinon.JS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjohansen/Sinon.JS/merges","archive_url":"https://api.github.com/repos/cjohansen/Sinon.JS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjohansen/Sinon.JS/downloads","issues_url":"https://api.github.com/repos/cjohansen/Sinon.JS/issues{/number}","pulls_url":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls{/number}","milestones_url":"https://api.github.com/repos/cjohansen/Sinon.JS/milestones{/number}","notifications_url":"https://api.github.com/repos/cjohansen/Sinon.JS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjohansen/Sinon.JS/labels{/name}","releases_url":"https://api.github.com/repos/cjohansen/Sinon.JS/releases{/id}","created_at":"2010-06-29T21:15:32Z","updated_at":"2015-06-05T12:49:22Z","pushed_at":"2015-05-30T07:51:49Z","git_url":"git://github.com/cjohansen/Sinon.JS.git","ssh_url":"git@github.com:cjohansen/Sinon.JS.git","clone_url":"https://github.com/cjohansen/Sinon.JS.git","svn_url":"https://github.com/cjohansen/Sinon.JS","homepage":"http://sinonjs.org/","size":5009,"stargazers_count":2074,"watchers_count":2074,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":328,"mirror_url":null,"open_issues_count":91,"forks":328,"open_issues":91,"watchers":2074,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/759"},"html":{"href":"https://github.com/cjohansen/Sinon.JS/pull/759"},"issue":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/issues/759"},"comments":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/issues/759/comments"},"review_comments":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/759/comments"},"review_comment":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/pulls/759/commits"},"statuses":{"href":"https://api.github.com/repos/cjohansen/Sinon.JS/statuses/ff103929ca84a460e0ceed56dedb2690207de97d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":110,"deletions":0,"changed_files":2}}