{"action":"opened","number":9,"pull_request":{"url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/pulls/9","id":50770952,"html_url":"https://github.com/fire/SensibleEditorSourceCodeAccess/pull/9","diff_url":"https://github.com/fire/SensibleEditorSourceCodeAccess/pull/9.diff","patch_url":"https://github.com/fire/SensibleEditorSourceCodeAccess/pull/9.patch","issue_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/issues/9","number":9,"state":"open","locked":false,"title":"  Fix compile error on 4.10","user":{"login":"cpburnz","id":2126043,"avatar_url":"https://avatars.githubusercontent.com/u/2126043?v=3","gravatar_id":"","url":"https://api.github.com/users/cpburnz","html_url":"https://github.com/cpburnz","followers_url":"https://api.github.com/users/cpburnz/followers","following_url":"https://api.github.com/users/cpburnz/following{/other_user}","gists_url":"https://api.github.com/users/cpburnz/gists{/gist_id}","starred_url":"https://api.github.com/users/cpburnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpburnz/subscriptions","organizations_url":"https://api.github.com/users/cpburnz/orgs","repos_url":"https://api.github.com/users/cpburnz/repos","events_url":"https://api.github.com/users/cpburnz/events{/privacy}","received_events_url":"https://api.github.com/users/cpburnz/received_events","type":"User","site_admin":false},"body":"When compiling UE4Editor v4.10, I get the following error:\r\n\r\n```\r\n[601/792] Compile Module.SensibleEditorSourceCodeAccess.cpp\r\nIn file included from /mnt/data/home/caleb/Downloads/UnrealEngineTest/Engine/Plugins/Developer/SensibleEditorSourceCodeAccess/Intermediate/Build/Linux/x86_64-unknown-linux-gnu/UE4Editor/Development/SensibleEditorSourceCodeAccess/Module.SensibleEditorSourceCodeAccess.cpp:2:\r\nIn file included from /mnt/data/home/caleb/Downloads/UnrealEngineTest/Engine/Plugins/Developer/SensibleEditorSourceCodeAccess/Source/SensibleEditorSourceCodeAccess/Private/SensibleEditorSourceCodeAccessModule.cpp:24:\r\n/mnt/data/home/caleb/Downloads/UnrealEngineTest/Engine/Plugins/Developer/SensibleEditorSourceCodeAccess/Source/SensibleEditorSourceCodeAccess/Private/SensibleEditorSourceCodeAccessModule.h:35:33: error: field type 'FSensibleSourceCodeAccessor' is an abstract class\r\n    FSensibleSourceCodeAccessor SensibleEditorSourceCodeAccessor;\r\n                                ^\r\nDeveloper/SourceCodeAccess/Public/ISourceCodeAccessor.h:18:15: note: unimplemented pure virtual method 'RefreshAvailability' in 'FSensibleSourceCodeAccessor'\r\n        virtual void RefreshAvailability() = 0;\r\n                     ^\r\nIn file included from /mnt/data/home/caleb/Downloads/UnrealEngineTest/Engine/Plugins/Developer/SensibleEditorSourceCodeAccess/Intermediate/Build/Linux/x86_64-unknown-linux-gnu/UE4Editor/Development/SensibleEditorSourceCodeAccess/Module.SensibleEditorSourceCodeAccess.cpp:2:\r\n/mnt/data/home/caleb/Downloads/UnrealEngineTest/Engine/Plugins/Developer/SensibleEditorSourceCodeAccess/Source/SensibleEditorSourceCodeAccess/Private/SensibleEditorSourceCodeAccessModule.cpp:26:1: error: cannot initialize return object of type 'IModuleInterface *' with an rvalue of type 'FSensibleSourceCodeAccessModule *'\r\nIMPLEMENT_MODULE( FSensibleSourceCodeAccessModule, SensibleEditorSourceCodeAccess );\r\n^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\nRuntime/Core/Public/Modules/ModuleManager.h:683:11: note: expanded from macro 'IMPLEMENT_MODULE'\r\n                        return new ModuleImplClass(); \\\r\n                               ^~~~~~~~~~~~~~~~~~~~~\r\n```\r\n\r\n`ISourceCodeAccessor` appears to have a new unimplemented virtual method:\r\n\r\n```cpp\r\nvirtual void RefreshAvailability() = 0;\r\n```\r\n\r\nThe `NullSourceCodeAccess` implementation simply defines the method as:\r\n\r\n```cpp\r\nvirtual void RefreshAvailability() override { }\r\n```\r\n\r\nAdding this method to `FSensibleSourceCodeAccessor` fixes the issue, and compiles properly. NOTE: This fix will likely cause SensibleEditorSourceCodeAccess to fail to compile on earlier versions of UE4Editor because the new method is overridden.","created_at":"2015-11-16T04:42:51Z","updated_at":"2015-11-16T04:42:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/pulls/9/commits","review_comments_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/pulls/9/comments","review_comment_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/issues/9/comments","statuses_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/statuses/7cd784f253e3385e6df3aae0582595a9fe587a9b","head":{"label":"cpburnz:master","ref":"master","sha":"7cd784f253e3385e6df3aae0582595a9fe587a9b","user":{"login":"cpburnz","id":2126043,"avatar_url":"https://avatars.githubusercontent.com/u/2126043?v=3","gravatar_id":"","url":"https://api.github.com/users/cpburnz","html_url":"https://github.com/cpburnz","followers_url":"https://api.github.com/users/cpburnz/followers","following_url":"https://api.github.com/users/cpburnz/following{/other_user}","gists_url":"https://api.github.com/users/cpburnz/gists{/gist_id}","starred_url":"https://api.github.com/users/cpburnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpburnz/subscriptions","organizations_url":"https://api.github.com/users/cpburnz/orgs","repos_url":"https://api.github.com/users/cpburnz/repos","events_url":"https://api.github.com/users/cpburnz/events{/privacy}","received_events_url":"https://api.github.com/users/cpburnz/received_events","type":"User","site_admin":false},"repo":{"id":46196566,"name":"SensibleEditorSourceCodeAccess","full_name":"cpburnz/SensibleEditorSourceCodeAccess","owner":{"login":"cpburnz","id":2126043,"avatar_url":"https://avatars.githubusercontent.com/u/2126043?v=3","gravatar_id":"","url":"https://api.github.com/users/cpburnz","html_url":"https://github.com/cpburnz","followers_url":"https://api.github.com/users/cpburnz/followers","following_url":"https://api.github.com/users/cpburnz/following{/other_user}","gists_url":"https://api.github.com/users/cpburnz/gists{/gist_id}","starred_url":"https://api.github.com/users/cpburnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpburnz/subscriptions","organizations_url":"https://api.github.com/users/cpburnz/orgs","repos_url":"https://api.github.com/users/cpburnz/repos","events_url":"https://api.github.com/users/cpburnz/events{/privacy}","received_events_url":"https://api.github.com/users/cpburnz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cpburnz/SensibleEditorSourceCodeAccess","description":"","fork":true,"url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess","forks_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/forks","keys_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/teams","hooks_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/hooks","issue_events_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/issues/events{/number}","events_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/events","assignees_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/assignees{/user}","branches_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/branches{/branch}","tags_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/tags","blobs_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/statuses/{sha}","languages_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/languages","stargazers_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/stargazers","contributors_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/contributors","subscribers_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/subscribers","subscription_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/subscription","commits_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/contents/{+path}","compare_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/merges","archive_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/downloads","issues_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/issues{/number}","pulls_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/pulls{/number}","milestones_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/milestones{/number}","notifications_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/labels{/name}","releases_url":"https://api.github.com/repos/cpburnz/SensibleEditorSourceCodeAccess/releases{/id}","created_at":"2015-11-14T23:30:16Z","updated_at":"2015-11-14T23:30:16Z","pushed_at":"2015-11-14T23:33:20Z","git_url":"git://github.com/cpburnz/SensibleEditorSourceCodeAccess.git","ssh_url":"git@github.com:cpburnz/SensibleEditorSourceCodeAccess.git","clone_url":"https://github.com/cpburnz/SensibleEditorSourceCodeAccess.git","svn_url":"https://github.com/cpburnz/SensibleEditorSourceCodeAccess","homepage":null,"size":318,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fire:master","ref":"master","sha":"5ce1024c113bf3504485278ba1c157b7df3db10f","user":{"login":"fire","id":32321,"avatar_url":"https://avatars.githubusercontent.com/u/32321?v=3","gravatar_id":"","url":"https://api.github.com/users/fire","html_url":"https://github.com/fire","followers_url":"https://api.github.com/users/fire/followers","following_url":"https://api.github.com/users/fire/following{/other_user}","gists_url":"https://api.github.com/users/fire/gists{/gist_id}","starred_url":"https://api.github.com/users/fire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fire/subscriptions","organizations_url":"https://api.github.com/users/fire/orgs","repos_url":"https://api.github.com/users/fire/repos","events_url":"https://api.github.com/users/fire/events{/privacy}","received_events_url":"https://api.github.com/users/fire/received_events","type":"User","site_admin":false},"repo":{"id":21854411,"name":"SensibleEditorSourceCodeAccess","full_name":"fire/SensibleEditorSourceCodeAccess","owner":{"login":"fire","id":32321,"avatar_url":"https://avatars.githubusercontent.com/u/32321?v=3","gravatar_id":"","url":"https://api.github.com/users/fire","html_url":"https://github.com/fire","followers_url":"https://api.github.com/users/fire/followers","following_url":"https://api.github.com/users/fire/following{/other_user}","gists_url":"https://api.github.com/users/fire/gists{/gist_id}","starred_url":"https://api.github.com/users/fire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fire/subscriptions","organizations_url":"https://api.github.com/users/fire/orgs","repos_url":"https://api.github.com/users/fire/repos","events_url":"https://api.github.com/users/fire/events{/privacy}","received_events_url":"https://api.github.com/users/fire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fire/SensibleEditorSourceCodeAccess","description":"","fork":false,"url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess","forks_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/forks","keys_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/teams","hooks_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/hooks","issue_events_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/issues/events{/number}","events_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/events","assignees_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/assignees{/user}","branches_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/branches{/branch}","tags_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/tags","blobs_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/git/refs{/sha}","trees_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/statuses/{sha}","languages_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/languages","stargazers_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/stargazers","contributors_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/contributors","subscribers_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/subscribers","subscription_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/subscription","commits_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/commits{/sha}","git_commits_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/git/commits{/sha}","comments_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/comments{/number}","issue_comment_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/issues/comments{/number}","contents_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/contents/{+path}","compare_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/merges","archive_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/downloads","issues_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/issues{/number}","pulls_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/pulls{/number}","milestones_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/milestones{/number}","notifications_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/labels{/name}","releases_url":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/releases{/id}","created_at":"2014-07-15T09:41:56Z","updated_at":"2015-10-19T01:12:02Z","pushed_at":"2015-10-06T18:47:02Z","git_url":"git://github.com/fire/SensibleEditorSourceCodeAccess.git","ssh_url":"git@github.com:fire/SensibleEditorSourceCodeAccess.git","clone_url":"https://github.com/fire/SensibleEditorSourceCodeAccess.git","svn_url":"https://github.com/fire/SensibleEditorSourceCodeAccess","homepage":null,"size":318,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/pulls/9"},"html":{"href":"https://github.com/fire/SensibleEditorSourceCodeAccess/pull/9"},"issue":{"href":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/issues/9"},"comments":{"href":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/fire/SensibleEditorSourceCodeAccess/statuses/7cd784f253e3385e6df3aae0582595a9fe587a9b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":3,"changed_files":2}}