{"action":"created","comment":{"url":"https://api.github.com/repos/auth0/lock/pulls/comments/35234611","id":35234611,"diff_hunk":"@@ -349,11 +351,19 @@ SigninPanel.prototype.onsubmit = function(e) {\n   if (!widget._ignoreEmailValidations(email_input)) {\n     if (!email_parsed && !email_empty) {\n       ok = false || (validate_username && username_parsed);\n-      if(!ok) widget._focusError(email_input, options.i18n.t('invalid'));\n+\n+      if (validate_username && !username_parsed) {\n+        widget.emit('signin error', new ValidationError('username invalid'));\n+      } else if (!ok) {\n+        widget.emit('signin error', new ValidationError('email invalid'));\n+      }\n+\n+      if (!ok) { widget._focusError(email_input, options.i18n.t('invalid')); }\n     }\n   }\n \n   if (password_empty && password_required && !password_disabled) {\n+    widget.emit('signin error', new ValidationError('password empty'));","path":"lib/mode-signin/index.js","position":33,"original_position":33,"commit_id":"9a74680c48309d685cad38dc364cd9ab463f1d4e","original_commit_id":"9a74680c48309d685cad38dc364cd9ab463f1d4e","user":{"login":"cristiandouce","id":367429,"avatar_url":"https://avatars.githubusercontent.com/u/367429?v=3","gravatar_id":"","url":"https://api.github.com/users/cristiandouce","html_url":"https://github.com/cristiandouce","followers_url":"https://api.github.com/users/cristiandouce/followers","following_url":"https://api.github.com/users/cristiandouce/following{/other_user}","gists_url":"https://api.github.com/users/cristiandouce/gists{/gist_id}","starred_url":"https://api.github.com/users/cristiandouce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristiandouce/subscriptions","organizations_url":"https://api.github.com/users/cristiandouce/orgs","repos_url":"https://api.github.com/users/cristiandouce/repos","events_url":"https://api.github.com/users/cristiandouce/events{/privacy}","received_events_url":"https://api.github.com/users/cristiandouce/received_events","type":"User","site_admin":false},"body":"same as reset... save the Error and emit on the end of this validate method","created_at":"2015-07-22T16:44:18Z","updated_at":"2015-07-22T16:44:18Z","html_url":"https://github.com/auth0/lock/pull/196#discussion_r35234611","pull_request_url":"https://api.github.com/repos/auth0/lock/pulls/196","_links":{"self":{"href":"https://api.github.com/repos/auth0/lock/pulls/comments/35234611"},"html":{"href":"https://github.com/auth0/lock/pull/196#discussion_r35234611"},"pull_request":{"href":"https://api.github.com/repos/auth0/lock/pulls/196"}}},"pull_request":{"url":"https://api.github.com/repos/auth0/lock/pulls/196","id":40396987,"html_url":"https://github.com/auth0/lock/pull/196","diff_url":"https://github.com/auth0/lock/pull/196.diff","patch_url":"https://github.com/auth0/lock/pull/196.patch","issue_url":"https://api.github.com/repos/auth0/lock/issues/196","number":196,"state":"open","locked":false,"title":"Added Lifecycle events","user":{"login":"tehsis","id":354324,"avatar_url":"https://avatars.githubusercontent.com/u/354324?v=3","gravatar_id":"","url":"https://api.github.com/users/tehsis","html_url":"https://github.com/tehsis","followers_url":"https://api.github.com/users/tehsis/followers","following_url":"https://api.github.com/users/tehsis/following{/other_user}","gists_url":"https://api.github.com/users/tehsis/gists{/gist_id}","starred_url":"https://api.github.com/users/tehsis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tehsis/subscriptions","organizations_url":"https://api.github.com/users/tehsis/orgs","repos_url":"https://api.github.com/users/tehsis/repos","events_url":"https://api.github.com/users/tehsis/events{/privacy}","received_events_url":"https://api.github.com/users/tehsis/received_events","type":"User","site_admin":false},"body":"### Brief\r\n\r\nThis PR add the lifecycle events for our modes:\r\n\r\nSignin, signup, reset now has events for: `ready` `submit` `success` and `error`\r\n\r\nDocs PR: - pending -","created_at":"2015-07-20T21:04:11Z","updated_at":"2015-07-22T16:44:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0218c7bb253d39fb1197bba2dff9d2470546e15","assignee":{"login":"cristiandouce","id":367429,"avatar_url":"https://avatars.githubusercontent.com/u/367429?v=3","gravatar_id":"","url":"https://api.github.com/users/cristiandouce","html_url":"https://github.com/cristiandouce","followers_url":"https://api.github.com/users/cristiandouce/followers","following_url":"https://api.github.com/users/cristiandouce/following{/other_user}","gists_url":"https://api.github.com/users/cristiandouce/gists{/gist_id}","starred_url":"https://api.github.com/users/cristiandouce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristiandouce/subscriptions","organizations_url":"https://api.github.com/users/cristiandouce/orgs","repos_url":"https://api.github.com/users/cristiandouce/repos","events_url":"https://api.github.com/users/cristiandouce/events{/privacy}","received_events_url":"https://api.github.com/users/cristiandouce/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/auth0/lock/pulls/196/commits","review_comments_url":"https://api.github.com/repos/auth0/lock/pulls/196/comments","review_comment_url":"https://api.github.com/repos/auth0/lock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/auth0/lock/issues/196/comments","statuses_url":"https://api.github.com/repos/auth0/lock/statuses/9a74680c48309d685cad38dc364cd9ab463f1d4e","head":{"label":"tehsis:issues/82-events","ref":"issues/82-events","sha":"9a74680c48309d685cad38dc364cd9ab463f1d4e","user":{"login":"tehsis","id":354324,"avatar_url":"https://avatars.githubusercontent.com/u/354324?v=3","gravatar_id":"","url":"https://api.github.com/users/tehsis","html_url":"https://github.com/tehsis","followers_url":"https://api.github.com/users/tehsis/followers","following_url":"https://api.github.com/users/tehsis/following{/other_user}","gists_url":"https://api.github.com/users/tehsis/gists{/gist_id}","starred_url":"https://api.github.com/users/tehsis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tehsis/subscriptions","organizations_url":"https://api.github.com/users/tehsis/orgs","repos_url":"https://api.github.com/users/tehsis/repos","events_url":"https://api.github.com/users/tehsis/events{/privacy}","received_events_url":"https://api.github.com/users/tehsis/received_events","type":"User","site_admin":false},"repo":{"id":30061190,"name":"lock","full_name":"tehsis/lock","owner":{"login":"tehsis","id":354324,"avatar_url":"https://avatars.githubusercontent.com/u/354324?v=3","gravatar_id":"","url":"https://api.github.com/users/tehsis","html_url":"https://github.com/tehsis","followers_url":"https://api.github.com/users/tehsis/followers","following_url":"https://api.github.com/users/tehsis/following{/other_user}","gists_url":"https://api.github.com/users/tehsis/gists{/gist_id}","starred_url":"https://api.github.com/users/tehsis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tehsis/subscriptions","organizations_url":"https://api.github.com/users/tehsis/orgs","repos_url":"https://api.github.com/users/tehsis/repos","events_url":"https://api.github.com/users/tehsis/events{/privacy}","received_events_url":"https://api.github.com/users/tehsis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tehsis/lock","description":"Auth0's signin solution","fork":true,"url":"https://api.github.com/repos/tehsis/lock","forks_url":"https://api.github.com/repos/tehsis/lock/forks","keys_url":"https://api.github.com/repos/tehsis/lock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tehsis/lock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tehsis/lock/teams","hooks_url":"https://api.github.com/repos/tehsis/lock/hooks","issue_events_url":"https://api.github.com/repos/tehsis/lock/issues/events{/number}","events_url":"https://api.github.com/repos/tehsis/lock/events","assignees_url":"https://api.github.com/repos/tehsis/lock/assignees{/user}","branches_url":"https://api.github.com/repos/tehsis/lock/branches{/branch}","tags_url":"https://api.github.com/repos/tehsis/lock/tags","blobs_url":"https://api.github.com/repos/tehsis/lock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tehsis/lock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tehsis/lock/git/refs{/sha}","trees_url":"https://api.github.com/repos/tehsis/lock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tehsis/lock/statuses/{sha}","languages_url":"https://api.github.com/repos/tehsis/lock/languages","stargazers_url":"https://api.github.com/repos/tehsis/lock/stargazers","contributors_url":"https://api.github.com/repos/tehsis/lock/contributors","subscribers_url":"https://api.github.com/repos/tehsis/lock/subscribers","subscription_url":"https://api.github.com/repos/tehsis/lock/subscription","commits_url":"https://api.github.com/repos/tehsis/lock/commits{/sha}","git_commits_url":"https://api.github.com/repos/tehsis/lock/git/commits{/sha}","comments_url":"https://api.github.com/repos/tehsis/lock/comments{/number}","issue_comment_url":"https://api.github.com/repos/tehsis/lock/issues/comments{/number}","contents_url":"https://api.github.com/repos/tehsis/lock/contents/{+path}","compare_url":"https://api.github.com/repos/tehsis/lock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tehsis/lock/merges","archive_url":"https://api.github.com/repos/tehsis/lock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tehsis/lock/downloads","issues_url":"https://api.github.com/repos/tehsis/lock/issues{/number}","pulls_url":"https://api.github.com/repos/tehsis/lock/pulls{/number}","milestones_url":"https://api.github.com/repos/tehsis/lock/milestones{/number}","notifications_url":"https://api.github.com/repos/tehsis/lock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tehsis/lock/labels{/name}","releases_url":"https://api.github.com/repos/tehsis/lock/releases{/id}","created_at":"2015-01-30T07:22:22Z","updated_at":"2015-03-13T14:18:32Z","pushed_at":"2015-07-22T02:34:00Z","git_url":"git://github.com/tehsis/lock.git","ssh_url":"git@github.com:tehsis/lock.git","clone_url":"https://github.com/tehsis/lock.git","svn_url":"https://github.com/tehsis/lock","homepage":"https://github.com/auth0/lock","size":47021,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"auth0:master","ref":"master","sha":"067f5f9c2fec61e82fb5eff0a785b38c7e3f3384","user":{"login":"auth0","id":2824157,"avatar_url":"https://avatars.githubusercontent.com/u/2824157?v=3","gravatar_id":"","url":"https://api.github.com/users/auth0","html_url":"https://github.com/auth0","followers_url":"https://api.github.com/users/auth0/followers","following_url":"https://api.github.com/users/auth0/following{/other_user}","gists_url":"https://api.github.com/users/auth0/gists{/gist_id}","starred_url":"https://api.github.com/users/auth0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auth0/subscriptions","organizations_url":"https://api.github.com/users/auth0/orgs","repos_url":"https://api.github.com/users/auth0/repos","events_url":"https://api.github.com/users/auth0/events{/privacy}","received_events_url":"https://api.github.com/users/auth0/received_events","type":"Organization","site_admin":false},"repo":{"id":22887863,"name":"lock","full_name":"auth0/lock","owner":{"login":"auth0","id":2824157,"avatar_url":"https://avatars.githubusercontent.com/u/2824157?v=3","gravatar_id":"","url":"https://api.github.com/users/auth0","html_url":"https://github.com/auth0","followers_url":"https://api.github.com/users/auth0/followers","following_url":"https://api.github.com/users/auth0/following{/other_user}","gists_url":"https://api.github.com/users/auth0/gists{/gist_id}","starred_url":"https://api.github.com/users/auth0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auth0/subscriptions","organizations_url":"https://api.github.com/users/auth0/orgs","repos_url":"https://api.github.com/users/auth0/repos","events_url":"https://api.github.com/users/auth0/events{/privacy}","received_events_url":"https://api.github.com/users/auth0/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/auth0/lock","description":"Auth0's signin solution","fork":false,"url":"https://api.github.com/repos/auth0/lock","forks_url":"https://api.github.com/repos/auth0/lock/forks","keys_url":"https://api.github.com/repos/auth0/lock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/auth0/lock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/auth0/lock/teams","hooks_url":"https://api.github.com/repos/auth0/lock/hooks","issue_events_url":"https://api.github.com/repos/auth0/lock/issues/events{/number}","events_url":"https://api.github.com/repos/auth0/lock/events","assignees_url":"https://api.github.com/repos/auth0/lock/assignees{/user}","branches_url":"https://api.github.com/repos/auth0/lock/branches{/branch}","tags_url":"https://api.github.com/repos/auth0/lock/tags","blobs_url":"https://api.github.com/repos/auth0/lock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/auth0/lock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/auth0/lock/git/refs{/sha}","trees_url":"https://api.github.com/repos/auth0/lock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/auth0/lock/statuses/{sha}","languages_url":"https://api.github.com/repos/auth0/lock/languages","stargazers_url":"https://api.github.com/repos/auth0/lock/stargazers","contributors_url":"https://api.github.com/repos/auth0/lock/contributors","subscribers_url":"https://api.github.com/repos/auth0/lock/subscribers","subscription_url":"https://api.github.com/repos/auth0/lock/subscription","commits_url":"https://api.github.com/repos/auth0/lock/commits{/sha}","git_commits_url":"https://api.github.com/repos/auth0/lock/git/commits{/sha}","comments_url":"https://api.github.com/repos/auth0/lock/comments{/number}","issue_comment_url":"https://api.github.com/repos/auth0/lock/issues/comments{/number}","contents_url":"https://api.github.com/repos/auth0/lock/contents/{+path}","compare_url":"https://api.github.com/repos/auth0/lock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/auth0/lock/merges","archive_url":"https://api.github.com/repos/auth0/lock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/auth0/lock/downloads","issues_url":"https://api.github.com/repos/auth0/lock/issues{/number}","pulls_url":"https://api.github.com/repos/auth0/lock/pulls{/number}","milestones_url":"https://api.github.com/repos/auth0/lock/milestones{/number}","notifications_url":"https://api.github.com/repos/auth0/lock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/auth0/lock/labels{/name}","releases_url":"https://api.github.com/repos/auth0/lock/releases{/id}","created_at":"2014-08-12T18:28:41Z","updated_at":"2015-07-21T10:38:56Z","pushed_at":"2015-07-22T02:34:01Z","git_url":"git://github.com/auth0/lock.git","ssh_url":"git@github.com:auth0/lock.git","clone_url":"https://github.com/auth0/lock.git","svn_url":"https://github.com/auth0/lock","homepage":"https://auth0.com/docs/libraries/lock","size":57052,"stargazers_count":103,"watchers_count":103,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":55,"forks":41,"open_issues":55,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/auth0/lock/pulls/196"},"html":{"href":"https://github.com/auth0/lock/pull/196"},"issue":{"href":"https://api.github.com/repos/auth0/lock/issues/196"},"comments":{"href":"https://api.github.com/repos/auth0/lock/issues/196/comments"},"review_comments":{"href":"https://api.github.com/repos/auth0/lock/pulls/196/comments"},"review_comment":{"href":"https://api.github.com/repos/auth0/lock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/auth0/lock/pulls/196/commits"},"statuses":{"href":"https://api.github.com/repos/auth0/lock/statuses/9a74680c48309d685cad38dc364cd9ab463f1d4e"}}}}