{"action":"created","comment":{"url":"https://api.github.com/repos/aodn/aodn-portal/pulls/comments/25830115","id":25830115,"diff_hunk":"@@ -102,9 +102,7 @@ OpenLayers.Layer.NcWMS = OpenLayers.Class(OpenLayers.Layer.WMS, {\n         });\n     },\n \n-    _timeSeriesDatesLoaded: function(datesWithData) {","path":"web-app/js/portal/ui/openlayers/layer/NcWMS.js","position":4,"original_position":4,"commit_id":"ab9cf1e823fc8999c840fc76f2935aab4d574900","original_commit_id":"761919589f52474812365187d434e37559dc2ba4","user":{"login":"danfruehauf","id":830676,"avatar_url":"https://avatars.githubusercontent.com/u/830676?v=3","gravatar_id":"","url":"https://api.github.com/users/danfruehauf","html_url":"https://github.com/danfruehauf","followers_url":"https://api.github.com/users/danfruehauf/followers","following_url":"https://api.github.com/users/danfruehauf/following{/other_user}","gists_url":"https://api.github.com/users/danfruehauf/gists{/gist_id}","starred_url":"https://api.github.com/users/danfruehauf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danfruehauf/subscriptions","organizations_url":"https://api.github.com/users/danfruehauf/orgs","repos_url":"https://api.github.com/users/danfruehauf/repos","events_url":"https://api.github.com/users/danfruehauf/events{/privacy}","received_events_url":"https://api.github.com/users/danfruehauf/received_events","type":"User","site_admin":false},"body":"About decoupling the first/last day into a different class, I think it should be decoupled in such a way that the interface will decide what to fetch s.t. the interface can fetch all dates, then decide what days to fetch. It will not be a 5 minute job unfortunately...","created_at":"2015-03-05T00:41:21Z","updated_at":"2015-03-05T00:41:21Z","html_url":"https://github.com/aodn/aodn-portal/pull/1606#discussion_r25830115","pull_request_url":"https://api.github.com/repos/aodn/aodn-portal/pulls/1606","_links":{"self":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/comments/25830115"},"html":{"href":"https://github.com/aodn/aodn-portal/pull/1606#discussion_r25830115"},"pull_request":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/1606"}}},"pull_request":{"url":"https://api.github.com/repos/aodn/aodn-portal/pulls/1606","id":30442873,"html_url":"https://github.com/aodn/aodn-portal/pull/1606","diff_url":"https://github.com/aodn/aodn-portal/pull/1606.diff","patch_url":"https://github.com/aodn/aodn-portal/pull/1606.patch","issue_url":"https://api.github.com/repos/aodn/aodn-portal/issues/1606","number":1606,"state":"open","locked":false,"title":"Issue 1603","user":{"login":"danfruehauf","id":830676,"avatar_url":"https://avatars.githubusercontent.com/u/830676?v=3","gravatar_id":"","url":"https://api.github.com/users/danfruehauf","html_url":"https://github.com/danfruehauf","followers_url":"https://api.github.com/users/danfruehauf/followers","following_url":"https://api.github.com/users/danfruehauf/following{/other_user}","gists_url":"https://api.github.com/users/danfruehauf/gists{/gist_id}","starred_url":"https://api.github.com/users/danfruehauf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danfruehauf/subscriptions","organizations_url":"https://api.github.com/users/danfruehauf/orgs","repos_url":"https://api.github.com/users/danfruehauf/repos","events_url":"https://api.github.com/users/danfruehauf/events{/privacy}","received_events_url":"https://api.github.com/users/danfruehauf/received_events","type":"User","site_admin":false},"body":"Fixes #1603\r\n\r\nThe issue became apparent as SRS layers have many days defined (1992-2015). In particular the functions `getFirstDay()` and `getLastDay()` were scanning a big hash. They were modified to return a fixed variables which is calculated every time a new date is being added. This is addressed at a6160c7.\r\n\r\nAnother problem was the inline addition of dates. When many dates are defined this proves to be a problem. This is now done in an interleaved manner which doesn't jam the UI. This is addressed in 924a871.\r\n\r\nAltogether the UI experience is **much** snappier now when choosing NcWMS layers and it is very apparent.","created_at":"2015-03-04T07:08:23Z","updated_at":"2015-03-05T00:41:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"facf5bdddce1a202f15d6719b772e2380df0855f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aodn/aodn-portal/pulls/1606/commits","review_comments_url":"https://api.github.com/repos/aodn/aodn-portal/pulls/1606/comments","review_comment_url":"https://api.github.com/repos/aodn/aodn-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aodn/aodn-portal/issues/1606/comments","statuses_url":"https://api.github.com/repos/aodn/aodn-portal/statuses/ab9cf1e823fc8999c840fc76f2935aab4d574900","head":{"label":"aodn:issue_1603","ref":"issue_1603","sha":"ab9cf1e823fc8999c840fc76f2935aab4d574900","user":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"repo":{"id":6806252,"name":"aodn-portal","full_name":"aodn/aodn-portal","owner":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aodn/aodn-portal","description":"AODN Open Geospatial Portal","fork":false,"url":"https://api.github.com/repos/aodn/aodn-portal","forks_url":"https://api.github.com/repos/aodn/aodn-portal/forks","keys_url":"https://api.github.com/repos/aodn/aodn-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aodn/aodn-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aodn/aodn-portal/teams","hooks_url":"https://api.github.com/repos/aodn/aodn-portal/hooks","issue_events_url":"https://api.github.com/repos/aodn/aodn-portal/issues/events{/number}","events_url":"https://api.github.com/repos/aodn/aodn-portal/events","assignees_url":"https://api.github.com/repos/aodn/aodn-portal/assignees{/user}","branches_url":"https://api.github.com/repos/aodn/aodn-portal/branches{/branch}","tags_url":"https://api.github.com/repos/aodn/aodn-portal/tags","blobs_url":"https://api.github.com/repos/aodn/aodn-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aodn/aodn-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aodn/aodn-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/aodn/aodn-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aodn/aodn-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/aodn/aodn-portal/languages","stargazers_url":"https://api.github.com/repos/aodn/aodn-portal/stargazers","contributors_url":"https://api.github.com/repos/aodn/aodn-portal/contributors","subscribers_url":"https://api.github.com/repos/aodn/aodn-portal/subscribers","subscription_url":"https://api.github.com/repos/aodn/aodn-portal/subscription","commits_url":"https://api.github.com/repos/aodn/aodn-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/aodn/aodn-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/aodn/aodn-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/aodn/aodn-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/aodn/aodn-portal/contents/{+path}","compare_url":"https://api.github.com/repos/aodn/aodn-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aodn/aodn-portal/merges","archive_url":"https://api.github.com/repos/aodn/aodn-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aodn/aodn-portal/downloads","issues_url":"https://api.github.com/repos/aodn/aodn-portal/issues{/number}","pulls_url":"https://api.github.com/repos/aodn/aodn-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/aodn/aodn-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/aodn/aodn-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aodn/aodn-portal/labels{/name}","releases_url":"https://api.github.com/repos/aodn/aodn-portal/releases{/id}","created_at":"2012-11-22T01:42:50Z","updated_at":"2015-03-05T00:00:04Z","pushed_at":"2015-03-05T00:21:04Z","git_url":"git://github.com/aodn/aodn-portal.git","ssh_url":"git@github.com:aodn/aodn-portal.git","clone_url":"https://github.com/aodn/aodn-portal.git","svn_url":"https://github.com/aodn/aodn-portal","homepage":"","size":67497,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":79,"forks":10,"open_issues":79,"watchers":3,"default_branch":"master"}},"base":{"label":"aodn:master","ref":"master","sha":"ff73df774197b4c3630dc27c7f3b1317916c4f52","user":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"repo":{"id":6806252,"name":"aodn-portal","full_name":"aodn/aodn-portal","owner":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aodn/aodn-portal","description":"AODN Open Geospatial Portal","fork":false,"url":"https://api.github.com/repos/aodn/aodn-portal","forks_url":"https://api.github.com/repos/aodn/aodn-portal/forks","keys_url":"https://api.github.com/repos/aodn/aodn-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aodn/aodn-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aodn/aodn-portal/teams","hooks_url":"https://api.github.com/repos/aodn/aodn-portal/hooks","issue_events_url":"https://api.github.com/repos/aodn/aodn-portal/issues/events{/number}","events_url":"https://api.github.com/repos/aodn/aodn-portal/events","assignees_url":"https://api.github.com/repos/aodn/aodn-portal/assignees{/user}","branches_url":"https://api.github.com/repos/aodn/aodn-portal/branches{/branch}","tags_url":"https://api.github.com/repos/aodn/aodn-portal/tags","blobs_url":"https://api.github.com/repos/aodn/aodn-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aodn/aodn-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aodn/aodn-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/aodn/aodn-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aodn/aodn-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/aodn/aodn-portal/languages","stargazers_url":"https://api.github.com/repos/aodn/aodn-portal/stargazers","contributors_url":"https://api.github.com/repos/aodn/aodn-portal/contributors","subscribers_url":"https://api.github.com/repos/aodn/aodn-portal/subscribers","subscription_url":"https://api.github.com/repos/aodn/aodn-portal/subscription","commits_url":"https://api.github.com/repos/aodn/aodn-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/aodn/aodn-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/aodn/aodn-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/aodn/aodn-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/aodn/aodn-portal/contents/{+path}","compare_url":"https://api.github.com/repos/aodn/aodn-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aodn/aodn-portal/merges","archive_url":"https://api.github.com/repos/aodn/aodn-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aodn/aodn-portal/downloads","issues_url":"https://api.github.com/repos/aodn/aodn-portal/issues{/number}","pulls_url":"https://api.github.com/repos/aodn/aodn-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/aodn/aodn-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/aodn/aodn-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aodn/aodn-portal/labels{/name}","releases_url":"https://api.github.com/repos/aodn/aodn-portal/releases{/id}","created_at":"2012-11-22T01:42:50Z","updated_at":"2015-03-05T00:00:04Z","pushed_at":"2015-03-05T00:21:04Z","git_url":"git://github.com/aodn/aodn-portal.git","ssh_url":"git@github.com:aodn/aodn-portal.git","clone_url":"https://github.com/aodn/aodn-portal.git","svn_url":"https://github.com/aodn/aodn-portal","homepage":"","size":67497,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":79,"forks":10,"open_issues":79,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/1606"},"html":{"href":"https://github.com/aodn/aodn-portal/pull/1606"},"issue":{"href":"https://api.github.com/repos/aodn/aodn-portal/issues/1606"},"comments":{"href":"https://api.github.com/repos/aodn/aodn-portal/issues/1606/comments"},"review_comments":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/1606/comments"},"review_comment":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/1606/commits"},"statuses":{"href":"https://api.github.com/repos/aodn/aodn-portal/statuses/ab9cf1e823fc8999c840fc76f2935aab4d574900"}}}}