{"push_id":595511594,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"6bc138c87a32f7f707e40eaf006128936792bb0b","before":"758ee3dc899ecd7b0de9179fc4d4d7a88e05d27e","commits":[{"sha":"6bc138c87a32f7f707e40eaf006128936792bb0b","author":{"email":"4b8373d016f277527198385ba72fda0feb5da015@lekensteyn.nl","name":"Peter Wu"},"message":"Qt: fix heap use-after-free wrt. data sources\n\nWhen a different packet is changed, the packet scoped memory for tvbuff\nis freed before clearing data source tabs. This results in\nheap-use-after free when resizeEvent is called as a result of clearing\ntabs for data sources.\n\nAvoid resize events by hiding the tabs.\n\nCaught with ASAN:\n\n    ==18816==ERROR: AddressSanitizer: heap-use-after-free on address 0x6060004cd970 at pc 0x7fffebf46618 bp 0x7fffffffbb10 sp 0x7fffffffbb00\n    READ of size 4 at 0x6060004cd970 thread T0\n        #0 0x7fffebf46617 in tvb_captured_length epan/tvbuff.c:423\n        #1 0x773062 in ByteViewText::updateScrollbars() ui/qt/byte_view_text.cpp:489\n        #2 0x76f307 in ByteViewText::resizeEvent(QResizeEvent*) ui/qt/byte_view_text.cpp:197\n        ...\n        #24 0x9f2348 in ByteViewText::~ByteViewText() ui/qt/byte_view_text.h:46\n        #25 0x9f23f5 in ByteViewText::~ByteViewText() ui/qt/byte_view_text.h:46\n        #26 0x76b9d6 in ByteViewTab::clear() ui/qt/byte_view_tab.cpp:54\n        #27 0x5de685 in PacketList::selectionChanged(QItemSelection const&, QItemSelection const&) ui/qt/packet_list.cpp:477\n        ...\n\n    freed by thread T0 here:\n        ...\n        #5 0x53d763 in cf_select_packet file.c:3827\n        #6 0x5ddfa5 in PacketList::selectionChanged(QItemSelection const&, QItemSelection const&) ui/qt/packet_list.cpp:454\n        #7 0x7fffe58ec980 (/usr/lib/libQt5Widgets.so.5+0x3bc980)\n        #8 0x7fffe4d55dd6 in QItemSelectionModel::selectionChanged(QItemSelection const&, QItemSelection const&) (/usr/lib/libQt5Core.so.5+0x23fdd6)\n        ...\n\nChange-Id: I9c1c01398713389de58259d13ebbaddd2d6e5c52\nReviewed-on: https://code.wireshark.org/review/7589\nReviewed-by: Peter Wu <peter@lekensteyn.nl>\nReviewed-by: Gerald Combs <gerald@wireshark.org>","distinct":true,"url":"https://api.github.com/repos/wireshark/wireshark/commits/6bc138c87a32f7f707e40eaf006128936792bb0b"}]}