{"action":"created","comment":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/comments/26591063","id":26591063,"diff_hunk":"@@ -498,7 +498,7 @@ function mightCauseHorizontallyOverlappingBubbles(element) {\n     //we can be very conservative and say that if the text\n     //box isn't taking up the whole width, it *might* cause\n     //an overlap\n-    if(element.hasClass('bloom-alwaysShowBubble')) {\n+    if((element.hasClass) && element.hasClass('bloom-alwaysShowBubble')) {","path":"src/BloomBrowserUI/bookEdit/js/bloomEditing.js","position":5,"original_position":5,"commit_id":"bf7d06c8658ba301c11a2c8e9115eee8ade5ead0","original_commit_id":"bf7d06c8658ba301c11a2c8e9115eee8ade5ead0","user":{"login":"gmartin7","id":2300551,"avatar_url":"https://avatars.githubusercontent.com/u/2300551?v=3","gravatar_id":"","url":"https://api.github.com/users/gmartin7","html_url":"https://github.com/gmartin7","followers_url":"https://api.github.com/users/gmartin7/followers","following_url":"https://api.github.com/users/gmartin7/following{/other_user}","gists_url":"https://api.github.com/users/gmartin7/gists{/gist_id}","starred_url":"https://api.github.com/users/gmartin7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmartin7/subscriptions","organizations_url":"https://api.github.com/users/gmartin7/orgs","repos_url":"https://api.github.com/users/gmartin7/repos","events_url":"https://api.github.com/users/gmartin7/events{/privacy}","received_events_url":"https://api.github.com/users/gmartin7/received_events","type":"User","site_admin":false},"body":"I've fixed the bug in my latest PR (since I added this bit to mightCauseHorizontallyOverlappingBubbles()) both by making sure all callers pass the right thing AND by using $(element).hasClass instead of the bare element.hasClass. The bare form worked when I passed a JQuery item and not when the other caller passed an HTMLElement. (Oh the benefits of TypeScript!)","created_at":"2015-03-17T16:49:05Z","updated_at":"2015-03-17T16:49:05Z","html_url":"https://github.com/BloomBooks/BloomDesktop/pull/332#discussion_r26591063","pull_request_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/332","_links":{"self":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/comments/26591063"},"html":{"href":"https://github.com/BloomBooks/BloomDesktop/pull/332#discussion_r26591063"},"pull_request":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/332"}}},"pull_request":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/332","id":31256351,"html_url":"https://github.com/BloomBooks/BloomDesktop/pull/332","diff_url":"https://github.com/BloomBooks/BloomDesktop/pull/332.diff","patch_url":"https://github.com/BloomBooks/BloomDesktop/pull/332.patch","issue_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/332","number":332,"state":"open","locked":false,"title":"Fixes a problem that was causing fatal memory access exception","user":{"login":"phillip-hopper","id":5262964,"avatar_url":"https://avatars.githubusercontent.com/u/5262964?v=3","gravatar_id":"","url":"https://api.github.com/users/phillip-hopper","html_url":"https://github.com/phillip-hopper","followers_url":"https://api.github.com/users/phillip-hopper/followers","following_url":"https://api.github.com/users/phillip-hopper/following{/other_user}","gists_url":"https://api.github.com/users/phillip-hopper/gists{/gist_id}","starred_url":"https://api.github.com/users/phillip-hopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillip-hopper/subscriptions","organizations_url":"https://api.github.com/users/phillip-hopper/orgs","repos_url":"https://api.github.com/users/phillip-hopper/repos","events_url":"https://api.github.com/users/phillip-hopper/events{/privacy}","received_events_url":"https://api.github.com/users/phillip-hopper/received_events","type":"User","site_admin":false},"body":"This may actually be the bug that was causing the exception in BL-1030.\r\n\r\nThe javascript error was \"element.hasClass is not a function.\"","created_at":"2015-03-16T15:55:43Z","updated_at":"2015-03-17T16:49:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fee33ec9285c3ef24573b67b9754ab5547ae14b3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/332/commits","review_comments_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/332/comments","review_comment_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/332/comments","statuses_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/statuses/bf7d06c8658ba301c11a2c8e9115eee8ade5ead0","head":{"label":"phillip-hopper:FixJavascriptError","ref":"FixJavascriptError","sha":"bf7d06c8658ba301c11a2c8e9115eee8ade5ead0","user":{"login":"phillip-hopper","id":5262964,"avatar_url":"https://avatars.githubusercontent.com/u/5262964?v=3","gravatar_id":"","url":"https://api.github.com/users/phillip-hopper","html_url":"https://github.com/phillip-hopper","followers_url":"https://api.github.com/users/phillip-hopper/followers","following_url":"https://api.github.com/users/phillip-hopper/following{/other_user}","gists_url":"https://api.github.com/users/phillip-hopper/gists{/gist_id}","starred_url":"https://api.github.com/users/phillip-hopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillip-hopper/subscriptions","organizations_url":"https://api.github.com/users/phillip-hopper/orgs","repos_url":"https://api.github.com/users/phillip-hopper/repos","events_url":"https://api.github.com/users/phillip-hopper/events{/privacy}","received_events_url":"https://api.github.com/users/phillip-hopper/received_events","type":"User","site_admin":false},"repo":{"id":24845983,"name":"BloomDesktop","full_name":"phillip-hopper/BloomDesktop","owner":{"login":"phillip-hopper","id":5262964,"avatar_url":"https://avatars.githubusercontent.com/u/5262964?v=3","gravatar_id":"","url":"https://api.github.com/users/phillip-hopper","html_url":"https://github.com/phillip-hopper","followers_url":"https://api.github.com/users/phillip-hopper/followers","following_url":"https://api.github.com/users/phillip-hopper/following{/other_user}","gists_url":"https://api.github.com/users/phillip-hopper/gists{/gist_id}","starred_url":"https://api.github.com/users/phillip-hopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillip-hopper/subscriptions","organizations_url":"https://api.github.com/users/phillip-hopper/orgs","repos_url":"https://api.github.com/users/phillip-hopper/repos","events_url":"https://api.github.com/users/phillip-hopper/events{/privacy}","received_events_url":"https://api.github.com/users/phillip-hopper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phillip-hopper/BloomDesktop","description":"This is a working fork, not the main repository.","fork":true,"url":"https://api.github.com/repos/phillip-hopper/BloomDesktop","forks_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/forks","keys_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/teams","hooks_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/hooks","issue_events_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/issues/events{/number}","events_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/events","assignees_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/assignees{/user}","branches_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/branches{/branch}","tags_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/tags","blobs_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/statuses/{sha}","languages_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/languages","stargazers_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/stargazers","contributors_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/contributors","subscribers_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/subscribers","subscription_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/subscription","commits_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/contents/{+path}","compare_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/merges","archive_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/downloads","issues_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/issues{/number}","pulls_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/pulls{/number}","milestones_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/milestones{/number}","notifications_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/labels{/name}","releases_url":"https://api.github.com/repos/phillip-hopper/BloomDesktop/releases{/id}","created_at":"2014-10-06T13:04:44Z","updated_at":"2014-10-23T13:18:39Z","pushed_at":"2015-03-17T15:39:37Z","git_url":"git://github.com/phillip-hopper/BloomDesktop.git","ssh_url":"git@github.com:phillip-hopper/BloomDesktop.git","clone_url":"https://github.com/phillip-hopper/BloomDesktop.git","svn_url":"https://github.com/phillip-hopper/BloomDesktop","homepage":"http://bloomlibrary.org/","size":41082,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BloomBooks:master","ref":"master","sha":"1b251ed0ce877a6929a95ffe7d9d8b633dda2c5b","user":{"login":"BloomBooks","id":5853716,"avatar_url":"https://avatars.githubusercontent.com/u/5853716?v=3","gravatar_id":"","url":"https://api.github.com/users/BloomBooks","html_url":"https://github.com/BloomBooks","followers_url":"https://api.github.com/users/BloomBooks/followers","following_url":"https://api.github.com/users/BloomBooks/following{/other_user}","gists_url":"https://api.github.com/users/BloomBooks/gists{/gist_id}","starred_url":"https://api.github.com/users/BloomBooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BloomBooks/subscriptions","organizations_url":"https://api.github.com/users/BloomBooks/orgs","repos_url":"https://api.github.com/users/BloomBooks/repos","events_url":"https://api.github.com/users/BloomBooks/events{/privacy}","received_events_url":"https://api.github.com/users/BloomBooks/received_events","type":"Organization","site_admin":false},"repo":{"id":14133680,"name":"BloomDesktop","full_name":"BloomBooks/BloomDesktop","owner":{"login":"BloomBooks","id":5853716,"avatar_url":"https://avatars.githubusercontent.com/u/5853716?v=3","gravatar_id":"","url":"https://api.github.com/users/BloomBooks","html_url":"https://github.com/BloomBooks","followers_url":"https://api.github.com/users/BloomBooks/followers","following_url":"https://api.github.com/users/BloomBooks/following{/other_user}","gists_url":"https://api.github.com/users/BloomBooks/gists{/gist_id}","starred_url":"https://api.github.com/users/BloomBooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BloomBooks/subscriptions","organizations_url":"https://api.github.com/users/BloomBooks/orgs","repos_url":"https://api.github.com/users/BloomBooks/repos","events_url":"https://api.github.com/users/BloomBooks/events{/privacy}","received_events_url":"https://api.github.com/users/BloomBooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BloomBooks/BloomDesktop","description":"Bloom Desktop is a hybrid c#/javascript/html/css Windows application that dramatically \"lowers the bar\" for language communities who want books in their own languages. Bloom delivers a low-training, high-output system where mother tongue speakers and their advocates work together to foster both community authorship and access to external material in the vernacular.","fork":false,"url":"https://api.github.com/repos/BloomBooks/BloomDesktop","forks_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/forks","keys_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/teams","hooks_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/hooks","issue_events_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/events{/number}","events_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/events","assignees_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/assignees{/user}","branches_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/branches{/branch}","tags_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/tags","blobs_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/statuses/{sha}","languages_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/languages","stargazers_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/stargazers","contributors_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/contributors","subscribers_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/subscribers","subscription_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/subscription","commits_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/contents/{+path}","compare_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/merges","archive_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/downloads","issues_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues{/number}","pulls_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls{/number}","milestones_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/milestones{/number}","notifications_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/labels{/name}","releases_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/releases{/id}","created_at":"2013-11-05T06:12:57Z","updated_at":"2015-03-17T16:24:39Z","pushed_at":"2015-03-17T16:24:38Z","git_url":"git://github.com/BloomBooks/BloomDesktop.git","ssh_url":"git@github.com:BloomBooks/BloomDesktop.git","clone_url":"https://github.com/BloomBooks/BloomDesktop.git","svn_url":"https://github.com/BloomBooks/BloomDesktop","homepage":"http://bloomlibrary.org/","size":56920,"stargazers_count":5,"watchers_count":5,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":4,"forks":9,"open_issues":4,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/332"},"html":{"href":"https://github.com/BloomBooks/BloomDesktop/pull/332"},"issue":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/332"},"comments":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/332/comments"},"review_comments":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/332/comments"},"review_comment":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/332/commits"},"statuses":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/statuses/bf7d06c8658ba301c11a2c8e9115eee8ade5ead0"}}}}