{"action":"created","comment":{"url":"https://api.github.com/repos/jspm/jspm-cli/pulls/comments/33426812","id":33426812,"diff_hunk":"@@ -471,9 +471,21 @@ exports.download = function(pkg, options, installDeps) {\n \n         // get the override\n         if (endpoint.getOverride) {\n-          if (!override && config.pjson.overrides[pkg.exactName])\n-            ui.log('warn', 'Using local override for `' + pkg.exactName + '`');\n-          return endpoint.getOverride(pkg.registry, pkg.package, pkg.version, override || config.pjson.overrides[pkg.exactName]);\n+          if (!override) {\n+            for (var overrideName in config.pjson.overrides) {\n+              if (overrideName.indexOf(pkg.name) !== -1) {\n+                var overrideVersion = overrideName.split('@')[1];","path":"lib/package.js","position":10,"original_position":10,"commit_id":"f5b2d5b20da65f20d495b5c3401fd0e0cb66f73e","original_commit_id":"f5b2d5b20da65f20d495b5c3401fd0e0cb66f73e","user":{"login":"guybedford","id":598730,"avatar_url":"https://avatars.githubusercontent.com/u/598730?v=3","gravatar_id":"","url":"https://api.github.com/users/guybedford","html_url":"https://github.com/guybedford","followers_url":"https://api.github.com/users/guybedford/followers","following_url":"https://api.github.com/users/guybedford/following{/other_user}","gists_url":"https://api.github.com/users/guybedford/gists{/gist_id}","starred_url":"https://api.github.com/users/guybedford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guybedford/subscriptions","organizations_url":"https://api.github.com/users/guybedford/orgs","repos_url":"https://api.github.com/users/guybedford/repos","events_url":"https://api.github.com/users/guybedford/events{/privacy}","received_events_url":"https://api.github.com/users/guybedford/received_events","type":"User","site_admin":false},"body":"Or `overrideName.split('@').pop()`.","created_at":"2015-06-28T20:55:32Z","updated_at":"2015-06-28T20:55:32Z","html_url":"https://github.com/jspm/jspm-cli/pull/891#discussion_r33426812","pull_request_url":"https://api.github.com/repos/jspm/jspm-cli/pulls/891","_links":{"self":{"href":"https://api.github.com/repos/jspm/jspm-cli/pulls/comments/33426812"},"html":{"href":"https://github.com/jspm/jspm-cli/pull/891#discussion_r33426812"},"pull_request":{"href":"https://api.github.com/repos/jspm/jspm-cli/pulls/891"}}},"pull_request":{"url":"https://api.github.com/repos/jspm/jspm-cli/pulls/891","id":38730663,"html_url":"https://github.com/jspm/jspm-cli/pull/891","diff_url":"https://github.com/jspm/jspm-cli/pull/891.diff","patch_url":"https://github.com/jspm/jspm-cli/pull/891.patch","issue_url":"https://api.github.com/repos/jspm/jspm-cli/issues/891","number":891,"state":"open","locked":false,"title":"Apply overrides to semver compatible versions","user":{"login":"OrKoN","id":399150,"avatar_url":"https://avatars.githubusercontent.com/u/399150?v=3","gravatar_id":"","url":"https://api.github.com/users/OrKoN","html_url":"https://github.com/OrKoN","followers_url":"https://api.github.com/users/OrKoN/followers","following_url":"https://api.github.com/users/OrKoN/following{/other_user}","gists_url":"https://api.github.com/users/OrKoN/gists{/gist_id}","starred_url":"https://api.github.com/users/OrKoN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrKoN/subscriptions","organizations_url":"https://api.github.com/users/OrKoN/orgs","repos_url":"https://api.github.com/users/OrKoN/repos","events_url":"https://api.github.com/users/OrKoN/events{/privacy}","received_events_url":"https://api.github.com/users/OrKoN/received_events","type":"User","site_admin":false},"body":"See https://github.com/jspm/jspm-cli/issues/882. Does this require a unit test? I have not found an existing test.","created_at":"2015-06-28T19:40:42Z","updated_at":"2015-06-28T20:55:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6aed5b1bee3bb21cfa1bf50d7b76248f91de99d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jspm/jspm-cli/pulls/891/commits","review_comments_url":"https://api.github.com/repos/jspm/jspm-cli/pulls/891/comments","review_comment_url":"https://api.github.com/repos/jspm/jspm-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jspm/jspm-cli/issues/891/comments","statuses_url":"https://api.github.com/repos/jspm/jspm-cli/statuses/f5b2d5b20da65f20d495b5c3401fd0e0cb66f73e","head":{"label":"OrKoN:master","ref":"master","sha":"f5b2d5b20da65f20d495b5c3401fd0e0cb66f73e","user":{"login":"OrKoN","id":399150,"avatar_url":"https://avatars.githubusercontent.com/u/399150?v=3","gravatar_id":"","url":"https://api.github.com/users/OrKoN","html_url":"https://github.com/OrKoN","followers_url":"https://api.github.com/users/OrKoN/followers","following_url":"https://api.github.com/users/OrKoN/following{/other_user}","gists_url":"https://api.github.com/users/OrKoN/gists{/gist_id}","starred_url":"https://api.github.com/users/OrKoN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrKoN/subscriptions","organizations_url":"https://api.github.com/users/OrKoN/orgs","repos_url":"https://api.github.com/users/OrKoN/repos","events_url":"https://api.github.com/users/OrKoN/events{/privacy}","received_events_url":"https://api.github.com/users/OrKoN/received_events","type":"User","site_admin":false},"repo":{"id":38209971,"name":"jspm-cli","full_name":"OrKoN/jspm-cli","owner":{"login":"OrKoN","id":399150,"avatar_url":"https://avatars.githubusercontent.com/u/399150?v=3","gravatar_id":"","url":"https://api.github.com/users/OrKoN","html_url":"https://github.com/OrKoN","followers_url":"https://api.github.com/users/OrKoN/followers","following_url":"https://api.github.com/users/OrKoN/following{/other_user}","gists_url":"https://api.github.com/users/OrKoN/gists{/gist_id}","starred_url":"https://api.github.com/users/OrKoN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrKoN/subscriptions","organizations_url":"https://api.github.com/users/OrKoN/orgs","repos_url":"https://api.github.com/users/OrKoN/repos","events_url":"https://api.github.com/users/OrKoN/events{/privacy}","received_events_url":"https://api.github.com/users/OrKoN/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OrKoN/jspm-cli","description":"Package management CLI","fork":true,"url":"https://api.github.com/repos/OrKoN/jspm-cli","forks_url":"https://api.github.com/repos/OrKoN/jspm-cli/forks","keys_url":"https://api.github.com/repos/OrKoN/jspm-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OrKoN/jspm-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OrKoN/jspm-cli/teams","hooks_url":"https://api.github.com/repos/OrKoN/jspm-cli/hooks","issue_events_url":"https://api.github.com/repos/OrKoN/jspm-cli/issues/events{/number}","events_url":"https://api.github.com/repos/OrKoN/jspm-cli/events","assignees_url":"https://api.github.com/repos/OrKoN/jspm-cli/assignees{/user}","branches_url":"https://api.github.com/repos/OrKoN/jspm-cli/branches{/branch}","tags_url":"https://api.github.com/repos/OrKoN/jspm-cli/tags","blobs_url":"https://api.github.com/repos/OrKoN/jspm-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OrKoN/jspm-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OrKoN/jspm-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/OrKoN/jspm-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OrKoN/jspm-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/OrKoN/jspm-cli/languages","stargazers_url":"https://api.github.com/repos/OrKoN/jspm-cli/stargazers","contributors_url":"https://api.github.com/repos/OrKoN/jspm-cli/contributors","subscribers_url":"https://api.github.com/repos/OrKoN/jspm-cli/subscribers","subscription_url":"https://api.github.com/repos/OrKoN/jspm-cli/subscription","commits_url":"https://api.github.com/repos/OrKoN/jspm-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/OrKoN/jspm-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/OrKoN/jspm-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/OrKoN/jspm-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/OrKoN/jspm-cli/contents/{+path}","compare_url":"https://api.github.com/repos/OrKoN/jspm-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OrKoN/jspm-cli/merges","archive_url":"https://api.github.com/repos/OrKoN/jspm-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OrKoN/jspm-cli/downloads","issues_url":"https://api.github.com/repos/OrKoN/jspm-cli/issues{/number}","pulls_url":"https://api.github.com/repos/OrKoN/jspm-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/OrKoN/jspm-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/OrKoN/jspm-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OrKoN/jspm-cli/labels{/name}","releases_url":"https://api.github.com/repos/OrKoN/jspm-cli/releases{/id}","created_at":"2015-06-28T18:46:52Z","updated_at":"2015-06-28T18:46:53Z","pushed_at":"2015-06-28T19:39:32Z","git_url":"git://github.com/OrKoN/jspm-cli.git","ssh_url":"git@github.com:OrKoN/jspm-cli.git","clone_url":"https://github.com/OrKoN/jspm-cli.git","svn_url":"https://github.com/OrKoN/jspm-cli","homepage":"https://jspm.io","size":5374,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jspm:master","ref":"master","sha":"a9c6e5c2c40f3f1e5c2ab4b4f5f134889f0570ed","user":{"login":"jspm","id":3802108,"avatar_url":"https://avatars.githubusercontent.com/u/3802108?v=3","gravatar_id":"","url":"https://api.github.com/users/jspm","html_url":"https://github.com/jspm","followers_url":"https://api.github.com/users/jspm/followers","following_url":"https://api.github.com/users/jspm/following{/other_user}","gists_url":"https://api.github.com/users/jspm/gists{/gist_id}","starred_url":"https://api.github.com/users/jspm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspm/subscriptions","organizations_url":"https://api.github.com/users/jspm/orgs","repos_url":"https://api.github.com/users/jspm/repos","events_url":"https://api.github.com/users/jspm/events{/privacy}","received_events_url":"https://api.github.com/users/jspm/received_events","type":"Organization","site_admin":false},"repo":{"id":8962829,"name":"jspm-cli","full_name":"jspm/jspm-cli","owner":{"login":"jspm","id":3802108,"avatar_url":"https://avatars.githubusercontent.com/u/3802108?v=3","gravatar_id":"","url":"https://api.github.com/users/jspm","html_url":"https://github.com/jspm","followers_url":"https://api.github.com/users/jspm/followers","following_url":"https://api.github.com/users/jspm/following{/other_user}","gists_url":"https://api.github.com/users/jspm/gists{/gist_id}","starred_url":"https://api.github.com/users/jspm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspm/subscriptions","organizations_url":"https://api.github.com/users/jspm/orgs","repos_url":"https://api.github.com/users/jspm/repos","events_url":"https://api.github.com/users/jspm/events{/privacy}","received_events_url":"https://api.github.com/users/jspm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jspm/jspm-cli","description":"Package management CLI","fork":false,"url":"https://api.github.com/repos/jspm/jspm-cli","forks_url":"https://api.github.com/repos/jspm/jspm-cli/forks","keys_url":"https://api.github.com/repos/jspm/jspm-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jspm/jspm-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jspm/jspm-cli/teams","hooks_url":"https://api.github.com/repos/jspm/jspm-cli/hooks","issue_events_url":"https://api.github.com/repos/jspm/jspm-cli/issues/events{/number}","events_url":"https://api.github.com/repos/jspm/jspm-cli/events","assignees_url":"https://api.github.com/repos/jspm/jspm-cli/assignees{/user}","branches_url":"https://api.github.com/repos/jspm/jspm-cli/branches{/branch}","tags_url":"https://api.github.com/repos/jspm/jspm-cli/tags","blobs_url":"https://api.github.com/repos/jspm/jspm-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jspm/jspm-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jspm/jspm-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/jspm/jspm-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jspm/jspm-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/jspm/jspm-cli/languages","stargazers_url":"https://api.github.com/repos/jspm/jspm-cli/stargazers","contributors_url":"https://api.github.com/repos/jspm/jspm-cli/contributors","subscribers_url":"https://api.github.com/repos/jspm/jspm-cli/subscribers","subscription_url":"https://api.github.com/repos/jspm/jspm-cli/subscription","commits_url":"https://api.github.com/repos/jspm/jspm-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/jspm/jspm-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/jspm/jspm-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/jspm/jspm-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/jspm/jspm-cli/contents/{+path}","compare_url":"https://api.github.com/repos/jspm/jspm-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jspm/jspm-cli/merges","archive_url":"https://api.github.com/repos/jspm/jspm-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jspm/jspm-cli/downloads","issues_url":"https://api.github.com/repos/jspm/jspm-cli/issues{/number}","pulls_url":"https://api.github.com/repos/jspm/jspm-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/jspm/jspm-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/jspm/jspm-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jspm/jspm-cli/labels{/name}","releases_url":"https://api.github.com/repos/jspm/jspm-cli/releases{/id}","created_at":"2013-03-22T23:20:12Z","updated_at":"2015-06-28T16:18:06Z","pushed_at":"2015-06-28T19:40:43Z","git_url":"git://github.com/jspm/jspm-cli.git","ssh_url":"git@github.com:jspm/jspm-cli.git","clone_url":"https://github.com/jspm/jspm-cli.git","svn_url":"https://github.com/jspm/jspm-cli","homepage":"https://jspm.io","size":5374,"stargazers_count":1604,"watchers_count":1604,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":47,"forks":95,"open_issues":47,"watchers":1604,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jspm/jspm-cli/pulls/891"},"html":{"href":"https://github.com/jspm/jspm-cli/pull/891"},"issue":{"href":"https://api.github.com/repos/jspm/jspm-cli/issues/891"},"comments":{"href":"https://api.github.com/repos/jspm/jspm-cli/issues/891/comments"},"review_comments":{"href":"https://api.github.com/repos/jspm/jspm-cli/pulls/891/comments"},"review_comment":{"href":"https://api.github.com/repos/jspm/jspm-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jspm/jspm-cli/pulls/891/commits"},"statuses":{"href":"https://api.github.com/repos/jspm/jspm-cli/statuses/f5b2d5b20da65f20d495b5c3401fd0e0cb66f73e"}}}}