{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/47903545","id":47903545,"diff_hunk":"@@ -32,24 +32,24 @@\n abstract class DoctrineType extends AbstractType\n {\n     /**\n-     * @var ManagerRegistry\n+     * @var DoctrineChoiceLoader[]\n      */\n-    protected $registry;\n+    private static $choiceLoaders = array();","path":"src/Symfony/Bridge/Doctrine/Form/Type/DoctrineType.php","position":8,"original_position":8,"commit_id":"eacffffacddb762a398a165568eb40de2b70c435","original_commit_id":"eacffffacddb762a398a165568eb40de2b70c435","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"well, see my previous comments (on the hidden discussion): making it static brings no benefit (as several instances will not share the same cache keys), and will leak memory by keeping the cached loaders in memory until the end of the process rather than until the instance is destroyed (which can make a huge difference in tests, where each test gets a new container, and so a different set of cached data)","created_at":"2015-12-17T13:14:50Z","updated_at":"2015-12-17T13:14:50Z","html_url":"https://github.com/symfony/symfony/pull/16747#discussion_r47903545","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/16747","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/47903545"},"html":{"href":"https://github.com/symfony/symfony/pull/16747#discussion_r47903545"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/16747"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/16747","id":52069598,"html_url":"https://github.com/symfony/symfony/pull/16747","diff_url":"https://github.com/symfony/symfony/pull/16747.diff","patch_url":"https://github.com/symfony/symfony/pull/16747.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/16747","number":16747,"state":"open","locked":false,"title":"[Form] Improved performance of ChoiceType and its subtypes","user":{"login":"webmozart","id":176399,"avatar_url":"https://avatars.githubusercontent.com/u/176399?v=3","gravatar_id":"","url":"https://api.github.com/users/webmozart","html_url":"https://github.com/webmozart","followers_url":"https://api.github.com/users/webmozart/followers","following_url":"https://api.github.com/users/webmozart/following{/other_user}","gists_url":"https://api.github.com/users/webmozart/gists{/gist_id}","starred_url":"https://api.github.com/users/webmozart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmozart/subscriptions","organizations_url":"https://api.github.com/users/webmozart/orgs","repos_url":"https://api.github.com/users/webmozart/repos","events_url":"https://api.github.com/users/webmozart/events{/privacy}","received_events_url":"https://api.github.com/users/webmozart/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | -\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\nI found out today that, although CachingFactoryDecorator is part of Symfony 2.7, it is not configured to be used in the DI configuration. This simple in-memory cache improved the page load by 50% for one considerably large form with many (~600) choice/entity fields that I was working on today.\r\n\r\nAlso, caching of query builders with parameters was broken, since the parameters are represented by objects. PHP's object hashes were used to calculate the cache keys, hence the cache always missed. I converted parameters to arrays for calculating the cache keys to fix this problem.","created_at":"2015-11-29T20:03:53Z","updated_at":"2015-12-17T13:14:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5593429d3c3bab0b5d720c3a7761e15d4d265bae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/16747/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/16747/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/16747/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/eacffffacddb762a398a165568eb40de2b70c435","head":{"label":"webmozart:choice-performance","ref":"choice-performance","sha":"eacffffacddb762a398a165568eb40de2b70c435","user":{"login":"webmozart","id":176399,"avatar_url":"https://avatars.githubusercontent.com/u/176399?v=3","gravatar_id":"","url":"https://api.github.com/users/webmozart","html_url":"https://github.com/webmozart","followers_url":"https://api.github.com/users/webmozart/followers","following_url":"https://api.github.com/users/webmozart/following{/other_user}","gists_url":"https://api.github.com/users/webmozart/gists{/gist_id}","starred_url":"https://api.github.com/users/webmozart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmozart/subscriptions","organizations_url":"https://api.github.com/users/webmozart/orgs","repos_url":"https://api.github.com/users/webmozart/repos","events_url":"https://api.github.com/users/webmozart/events{/privacy}","received_events_url":"https://api.github.com/users/webmozart/received_events","type":"User","site_admin":false},"repo":{"id":1402087,"name":"symfony","full_name":"webmozart/symfony","owner":{"login":"webmozart","id":176399,"avatar_url":"https://avatars.githubusercontent.com/u/176399?v=3","gravatar_id":"","url":"https://api.github.com/users/webmozart","html_url":"https://github.com/webmozart","followers_url":"https://api.github.com/users/webmozart/followers","following_url":"https://api.github.com/users/webmozart/following{/other_user}","gists_url":"https://api.github.com/users/webmozart/gists{/gist_id}","starred_url":"https://api.github.com/users/webmozart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmozart/subscriptions","organizations_url":"https://api.github.com/users/webmozart/orgs","repos_url":"https://api.github.com/users/webmozart/repos","events_url":"https://api.github.com/users/webmozart/events{/privacy}","received_events_url":"https://api.github.com/users/webmozart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/webmozart/symfony","description":"The Symfony2 PHP framework (PHP 5.3 only -- not yet stable) -- documentation for master is at http://docs.symfony-reloaded.org/master/","fork":true,"url":"https://api.github.com/repos/webmozart/symfony","forks_url":"https://api.github.com/repos/webmozart/symfony/forks","keys_url":"https://api.github.com/repos/webmozart/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webmozart/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webmozart/symfony/teams","hooks_url":"https://api.github.com/repos/webmozart/symfony/hooks","issue_events_url":"https://api.github.com/repos/webmozart/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/webmozart/symfony/events","assignees_url":"https://api.github.com/repos/webmozart/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/webmozart/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/webmozart/symfony/tags","blobs_url":"https://api.github.com/repos/webmozart/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webmozart/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webmozart/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/webmozart/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webmozart/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/webmozart/symfony/languages","stargazers_url":"https://api.github.com/repos/webmozart/symfony/stargazers","contributors_url":"https://api.github.com/repos/webmozart/symfony/contributors","subscribers_url":"https://api.github.com/repos/webmozart/symfony/subscribers","subscription_url":"https://api.github.com/repos/webmozart/symfony/subscription","commits_url":"https://api.github.com/repos/webmozart/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/webmozart/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/webmozart/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/webmozart/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/webmozart/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/webmozart/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webmozart/symfony/merges","archive_url":"https://api.github.com/repos/webmozart/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webmozart/symfony/downloads","issues_url":"https://api.github.com/repos/webmozart/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/webmozart/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/webmozart/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/webmozart/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webmozart/symfony/labels{/name}","releases_url":"https://api.github.com/repos/webmozart/symfony/releases{/id}","created_at":"2011-02-23T12:20:24Z","updated_at":"2015-11-08T11:59:34Z","pushed_at":"2015-11-30T21:59:24Z","git_url":"git://github.com/webmozart/symfony.git","ssh_url":"git@github.com:webmozart/symfony.git","clone_url":"https://github.com/webmozart/symfony.git","svn_url":"https://github.com/webmozart/symfony","homepage":"http://www.symfony-reloaded.org/","size":64525,"stargazers_count":15,"watchers_count":15,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":15,"default_branch":"master"}},"base":{"label":"symfony:2.7","ref":"2.7","sha":"13fda1c7c575008d0de14a685f0277381710ca3a","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-12-17T07:31:10Z","pushed_at":"2015-12-17T13:05:54Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":97599,"stargazers_count":11337,"watchers_count":11337,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4472,"mirror_url":null,"open_issues_count":910,"forks":4472,"open_issues":910,"watchers":11337,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/16747"},"html":{"href":"https://github.com/symfony/symfony/pull/16747"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/16747"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/16747/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/16747/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/16747/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/eacffffacddb762a398a165568eb40de2b70c435"}}}}