{"action":"closed","number":198,"pull_request":{"url":"https://api.github.com/repos/mspnp/iot-journey/pulls/198","id":39107926,"html_url":"https://github.com/mspnp/iot-journey/pull/198","diff_url":"https://github.com/mspnp/iot-journey/pull/198.diff","patch_url":"https://github.com/mspnp/iot-journey/pull/198.patch","issue_url":"https://api.github.com/repos/mspnp/iot-journey/issues/198","number":198,"state":"closed","locked":false,"title":"fixed jitter and added unit test to validate","user":{"login":"lbrader","id":1919914,"avatar_url":"https://avatars.githubusercontent.com/u/1919914?v=3","gravatar_id":"","url":"https://api.github.com/users/lbrader","html_url":"https://github.com/lbrader","followers_url":"https://api.github.com/users/lbrader/followers","following_url":"https://api.github.com/users/lbrader/following{/other_user}","gists_url":"https://api.github.com/users/lbrader/gists{/gist_id}","starred_url":"https://api.github.com/users/lbrader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbrader/subscriptions","organizations_url":"https://api.github.com/users/lbrader/orgs","repos_url":"https://api.github.com/users/lbrader/repos","events_url":"https://api.github.com/users/lbrader/events{/privacy}","received_events_url":"https://api.github.com/users/lbrader/received_events","type":"User","site_admin":false},"body":"connects to #175 \r\n\r\nThe frequency jitter in the simulation was implemented incorrectly.  It only was additive to the frequency causing a positive bias which caused a delay in our message sending.  This appeared as 25% decrease in our throughput. \r\n\r\nIn addition to fixing the jitter.  Added a unit test to validate we do oscillate around the frequency, which reflects what's expected in realistic jitter. ","created_at":"2015-07-02T17:43:03Z","updated_at":"2015-07-09T19:01:29Z","closed_at":"2015-07-09T19:01:29Z","merged_at":"2015-07-09T19:01:29Z","merge_commit_sha":"39351c32f42c27e734528f0834c84f818d10cf6c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mspnp/iot-journey/pulls/198/commits","review_comments_url":"https://api.github.com/repos/mspnp/iot-journey/pulls/198/comments","review_comment_url":"https://api.github.com/repos/mspnp/iot-journey/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mspnp/iot-journey/issues/198/comments","statuses_url":"https://api.github.com/repos/mspnp/iot-journey/statuses/d319b4e49564617f4bb0566a6d3c2b50df6a3c13","head":{"label":"mspnp:larry/fix-jitter","ref":"larry/fix-jitter","sha":"d319b4e49564617f4bb0566a6d3c2b50df6a3c13","user":{"login":"mspnp","id":1373420,"avatar_url":"https://avatars.githubusercontent.com/u/1373420?v=3","gravatar_id":"","url":"https://api.github.com/users/mspnp","html_url":"https://github.com/mspnp","followers_url":"https://api.github.com/users/mspnp/followers","following_url":"https://api.github.com/users/mspnp/following{/other_user}","gists_url":"https://api.github.com/users/mspnp/gists{/gist_id}","starred_url":"https://api.github.com/users/mspnp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mspnp/subscriptions","organizations_url":"https://api.github.com/users/mspnp/orgs","repos_url":"https://api.github.com/users/mspnp/repos","events_url":"https://api.github.com/users/mspnp/events{/privacy}","received_events_url":"https://api.github.com/users/mspnp/received_events","type":"Organization","site_admin":false},"repo":{"id":34227406,"name":"iot-journey","full_name":"mspnp/iot-journey","owner":{"login":"mspnp","id":1373420,"avatar_url":"https://avatars.githubusercontent.com/u/1373420?v=3","gravatar_id":"","url":"https://api.github.com/users/mspnp","html_url":"https://github.com/mspnp","followers_url":"https://api.github.com/users/mspnp/followers","following_url":"https://api.github.com/users/mspnp/following{/other_user}","gists_url":"https://api.github.com/users/mspnp/gists{/gist_id}","starred_url":"https://api.github.com/users/mspnp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mspnp/subscriptions","organizations_url":"https://api.github.com/users/mspnp/orgs","repos_url":"https://api.github.com/users/mspnp/repos","events_url":"https://api.github.com/users/mspnp/events{/privacy}","received_events_url":"https://api.github.com/users/mspnp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mspnp/iot-journey","description":"a guidance project for implementing an IoT solution on Azure","fork":false,"url":"https://api.github.com/repos/mspnp/iot-journey","forks_url":"https://api.github.com/repos/mspnp/iot-journey/forks","keys_url":"https://api.github.com/repos/mspnp/iot-journey/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mspnp/iot-journey/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mspnp/iot-journey/teams","hooks_url":"https://api.github.com/repos/mspnp/iot-journey/hooks","issue_events_url":"https://api.github.com/repos/mspnp/iot-journey/issues/events{/number}","events_url":"https://api.github.com/repos/mspnp/iot-journey/events","assignees_url":"https://api.github.com/repos/mspnp/iot-journey/assignees{/user}","branches_url":"https://api.github.com/repos/mspnp/iot-journey/branches{/branch}","tags_url":"https://api.github.com/repos/mspnp/iot-journey/tags","blobs_url":"https://api.github.com/repos/mspnp/iot-journey/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mspnp/iot-journey/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mspnp/iot-journey/git/refs{/sha}","trees_url":"https://api.github.com/repos/mspnp/iot-journey/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mspnp/iot-journey/statuses/{sha}","languages_url":"https://api.github.com/repos/mspnp/iot-journey/languages","stargazers_url":"https://api.github.com/repos/mspnp/iot-journey/stargazers","contributors_url":"https://api.github.com/repos/mspnp/iot-journey/contributors","subscribers_url":"https://api.github.com/repos/mspnp/iot-journey/subscribers","subscription_url":"https://api.github.com/repos/mspnp/iot-journey/subscription","commits_url":"https://api.github.com/repos/mspnp/iot-journey/commits{/sha}","git_commits_url":"https://api.github.com/repos/mspnp/iot-journey/git/commits{/sha}","comments_url":"https://api.github.com/repos/mspnp/iot-journey/comments{/number}","issue_comment_url":"https://api.github.com/repos/mspnp/iot-journey/issues/comments{/number}","contents_url":"https://api.github.com/repos/mspnp/iot-journey/contents/{+path}","compare_url":"https://api.github.com/repos/mspnp/iot-journey/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mspnp/iot-journey/merges","archive_url":"https://api.github.com/repos/mspnp/iot-journey/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mspnp/iot-journey/downloads","issues_url":"https://api.github.com/repos/mspnp/iot-journey/issues{/number}","pulls_url":"https://api.github.com/repos/mspnp/iot-journey/pulls{/number}","milestones_url":"https://api.github.com/repos/mspnp/iot-journey/milestones{/number}","notifications_url":"https://api.github.com/repos/mspnp/iot-journey/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mspnp/iot-journey/labels{/name}","releases_url":"https://api.github.com/repos/mspnp/iot-journey/releases{/id}","created_at":"2015-04-19T22:49:18Z","updated_at":"2015-07-09T02:50:09Z","pushed_at":"2015-07-09T19:01:29Z","git_url":"git://github.com/mspnp/iot-journey.git","ssh_url":"git@github.com:mspnp/iot-journey.git","clone_url":"https://github.com/mspnp/iot-journey.git","svn_url":"https://github.com/mspnp/iot-journey","homepage":"","size":5469,"stargazers_count":21,"watchers_count":21,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":58,"forks":10,"open_issues":58,"watchers":21,"default_branch":"master"}},"base":{"label":"mspnp:master","ref":"master","sha":"465749e65c7f22e0a76059c022feebd3155b2e83","user":{"login":"mspnp","id":1373420,"avatar_url":"https://avatars.githubusercontent.com/u/1373420?v=3","gravatar_id":"","url":"https://api.github.com/users/mspnp","html_url":"https://github.com/mspnp","followers_url":"https://api.github.com/users/mspnp/followers","following_url":"https://api.github.com/users/mspnp/following{/other_user}","gists_url":"https://api.github.com/users/mspnp/gists{/gist_id}","starred_url":"https://api.github.com/users/mspnp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mspnp/subscriptions","organizations_url":"https://api.github.com/users/mspnp/orgs","repos_url":"https://api.github.com/users/mspnp/repos","events_url":"https://api.github.com/users/mspnp/events{/privacy}","received_events_url":"https://api.github.com/users/mspnp/received_events","type":"Organization","site_admin":false},"repo":{"id":34227406,"name":"iot-journey","full_name":"mspnp/iot-journey","owner":{"login":"mspnp","id":1373420,"avatar_url":"https://avatars.githubusercontent.com/u/1373420?v=3","gravatar_id":"","url":"https://api.github.com/users/mspnp","html_url":"https://github.com/mspnp","followers_url":"https://api.github.com/users/mspnp/followers","following_url":"https://api.github.com/users/mspnp/following{/other_user}","gists_url":"https://api.github.com/users/mspnp/gists{/gist_id}","starred_url":"https://api.github.com/users/mspnp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mspnp/subscriptions","organizations_url":"https://api.github.com/users/mspnp/orgs","repos_url":"https://api.github.com/users/mspnp/repos","events_url":"https://api.github.com/users/mspnp/events{/privacy}","received_events_url":"https://api.github.com/users/mspnp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mspnp/iot-journey","description":"a guidance project for implementing an IoT solution on Azure","fork":false,"url":"https://api.github.com/repos/mspnp/iot-journey","forks_url":"https://api.github.com/repos/mspnp/iot-journey/forks","keys_url":"https://api.github.com/repos/mspnp/iot-journey/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mspnp/iot-journey/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mspnp/iot-journey/teams","hooks_url":"https://api.github.com/repos/mspnp/iot-journey/hooks","issue_events_url":"https://api.github.com/repos/mspnp/iot-journey/issues/events{/number}","events_url":"https://api.github.com/repos/mspnp/iot-journey/events","assignees_url":"https://api.github.com/repos/mspnp/iot-journey/assignees{/user}","branches_url":"https://api.github.com/repos/mspnp/iot-journey/branches{/branch}","tags_url":"https://api.github.com/repos/mspnp/iot-journey/tags","blobs_url":"https://api.github.com/repos/mspnp/iot-journey/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mspnp/iot-journey/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mspnp/iot-journey/git/refs{/sha}","trees_url":"https://api.github.com/repos/mspnp/iot-journey/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mspnp/iot-journey/statuses/{sha}","languages_url":"https://api.github.com/repos/mspnp/iot-journey/languages","stargazers_url":"https://api.github.com/repos/mspnp/iot-journey/stargazers","contributors_url":"https://api.github.com/repos/mspnp/iot-journey/contributors","subscribers_url":"https://api.github.com/repos/mspnp/iot-journey/subscribers","subscription_url":"https://api.github.com/repos/mspnp/iot-journey/subscription","commits_url":"https://api.github.com/repos/mspnp/iot-journey/commits{/sha}","git_commits_url":"https://api.github.com/repos/mspnp/iot-journey/git/commits{/sha}","comments_url":"https://api.github.com/repos/mspnp/iot-journey/comments{/number}","issue_comment_url":"https://api.github.com/repos/mspnp/iot-journey/issues/comments{/number}","contents_url":"https://api.github.com/repos/mspnp/iot-journey/contents/{+path}","compare_url":"https://api.github.com/repos/mspnp/iot-journey/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mspnp/iot-journey/merges","archive_url":"https://api.github.com/repos/mspnp/iot-journey/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mspnp/iot-journey/downloads","issues_url":"https://api.github.com/repos/mspnp/iot-journey/issues{/number}","pulls_url":"https://api.github.com/repos/mspnp/iot-journey/pulls{/number}","milestones_url":"https://api.github.com/repos/mspnp/iot-journey/milestones{/number}","notifications_url":"https://api.github.com/repos/mspnp/iot-journey/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mspnp/iot-journey/labels{/name}","releases_url":"https://api.github.com/repos/mspnp/iot-journey/releases{/id}","created_at":"2015-04-19T22:49:18Z","updated_at":"2015-07-09T02:50:09Z","pushed_at":"2015-07-09T19:01:29Z","git_url":"git://github.com/mspnp/iot-journey.git","ssh_url":"git@github.com:mspnp/iot-journey.git","clone_url":"https://github.com/mspnp/iot-journey.git","svn_url":"https://github.com/mspnp/iot-journey","homepage":"","size":5469,"stargazers_count":21,"watchers_count":21,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":58,"forks":10,"open_issues":58,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mspnp/iot-journey/pulls/198"},"html":{"href":"https://github.com/mspnp/iot-journey/pull/198"},"issue":{"href":"https://api.github.com/repos/mspnp/iot-journey/issues/198"},"comments":{"href":"https://api.github.com/repos/mspnp/iot-journey/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/mspnp/iot-journey/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/mspnp/iot-journey/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mspnp/iot-journey/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/mspnp/iot-journey/statuses/d319b4e49564617f4bb0566a6d3c2b50df6a3c13"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bennage","id":118161,"avatar_url":"https://avatars.githubusercontent.com/u/118161?v=3","gravatar_id":"","url":"https://api.github.com/users/bennage","html_url":"https://github.com/bennage","followers_url":"https://api.github.com/users/bennage/followers","following_url":"https://api.github.com/users/bennage/following{/other_user}","gists_url":"https://api.github.com/users/bennage/gists{/gist_id}","starred_url":"https://api.github.com/users/bennage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bennage/subscriptions","organizations_url":"https://api.github.com/users/bennage/orgs","repos_url":"https://api.github.com/users/bennage/repos","events_url":"https://api.github.com/users/bennage/events{/privacy}","received_events_url":"https://api.github.com/users/bennage/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":68,"deletions":1,"changed_files":2}}