{"action":"created","comment":{"url":"https://api.github.com/repos/OCA/connector-telephony/pulls/comments/24094025","id":24094025,"diff_hunk":"@@ -170,7 +170,7 @@ def _reformat_number(\n         assert(country_code), 'Missing country on company'\n         _logger.debug('Country code = %s' % country_code)\n         to_dial_number = phonenumbers.format_out_of_country_calling_number(\n-            parsed_num, country_code.upper()).replace(' ', '').replace('-', '')\n+            parsed_num, country_code.upper()).replace(' ', '').replace('-', '').replace('.','').replace('(', '').replace(')','')","path":"asterisk_click2dial/asterisk_click2dial.py","position":5,"original_position":5,"commit_id":"941b2184b379cda9de37f7f6a97bd6f6c9a3312f","original_commit_id":"941b2184b379cda9de37f7f6a97bd6f6c9a3312f","user":{"login":"yvaucher","id":4158438,"avatar_url":"https://avatars.githubusercontent.com/u/4158438?v=3","gravatar_id":"","url":"https://api.github.com/users/yvaucher","html_url":"https://github.com/yvaucher","followers_url":"https://api.github.com/users/yvaucher/followers","following_url":"https://api.github.com/users/yvaucher/following{/other_user}","gists_url":"https://api.github.com/users/yvaucher/gists{/gist_id}","starred_url":"https://api.github.com/users/yvaucher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yvaucher/subscriptions","organizations_url":"https://api.github.com/users/yvaucher/orgs","repos_url":"https://api.github.com/users/yvaucher/repos","events_url":"https://api.github.com/users/yvaucher/events{/privacy}","received_events_url":"https://api.github.com/users/yvaucher/received_events","type":"User","site_admin":false},"body":"@alex2grad regexp is quite slow and for stripping compared to translate\r\nYou must not strip `+` sign as it is valid if it is the first character","created_at":"2015-02-04T16:07:11Z","updated_at":"2015-02-04T16:07:11Z","html_url":"https://github.com/OCA/connector-telephony/pull/16#discussion_r24094025","pull_request_url":"https://api.github.com/repos/OCA/connector-telephony/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/OCA/connector-telephony/pulls/comments/24094025"},"html":{"href":"https://github.com/OCA/connector-telephony/pull/16#discussion_r24094025"},"pull_request":{"href":"https://api.github.com/repos/OCA/connector-telephony/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/OCA/connector-telephony/pulls/16","id":26961808,"html_url":"https://github.com/OCA/connector-telephony/pull/16","diff_url":"https://github.com/OCA/connector-telephony/pull/16.diff","patch_url":"https://github.com/OCA/connector-telephony/pull/16.patch","issue_url":"https://api.github.com/repos/OCA/connector-telephony/issues/16","number":16,"state":"open","locked":false,"title":"Strip more characters from phone numbers sent to Asterisk","user":{"login":"pmatis","id":5515738,"avatar_url":"https://avatars.githubusercontent.com/u/5515738?v=3","gravatar_id":"","url":"https://api.github.com/users/pmatis","html_url":"https://github.com/pmatis","followers_url":"https://api.github.com/users/pmatis/followers","following_url":"https://api.github.com/users/pmatis/following{/other_user}","gists_url":"https://api.github.com/users/pmatis/gists{/gist_id}","starred_url":"https://api.github.com/users/pmatis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmatis/subscriptions","organizations_url":"https://api.github.com/users/pmatis/orgs","repos_url":"https://api.github.com/users/pmatis/repos","events_url":"https://api.github.com/users/pmatis/events{/privacy}","received_events_url":"https://api.github.com/users/pmatis/received_events","type":"User","site_admin":false},"body":"Strip more characters from phone numbers to allow for US formatted numbers to be properly sent to Asterisk.","created_at":"2015-01-07T14:55:59Z","updated_at":"2015-02-04T16:07:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ed49206a90e124b8cdefde7a66a7afd7244aed3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OCA/connector-telephony/pulls/16/commits","review_comments_url":"https://api.github.com/repos/OCA/connector-telephony/pulls/16/comments","review_comment_url":"https://api.github.com/repos/OCA/connector-telephony/pulls/comments/{number}","comments_url":"https://api.github.com/repos/OCA/connector-telephony/issues/16/comments","statuses_url":"https://api.github.com/repos/OCA/connector-telephony/statuses/941b2184b379cda9de37f7f6a97bd6f6c9a3312f","head":{"label":"pmatis:8.0-number-format-US","ref":"8.0-number-format-US","sha":"941b2184b379cda9de37f7f6a97bd6f6c9a3312f","user":{"login":"pmatis","id":5515738,"avatar_url":"https://avatars.githubusercontent.com/u/5515738?v=3","gravatar_id":"","url":"https://api.github.com/users/pmatis","html_url":"https://github.com/pmatis","followers_url":"https://api.github.com/users/pmatis/followers","following_url":"https://api.github.com/users/pmatis/following{/other_user}","gists_url":"https://api.github.com/users/pmatis/gists{/gist_id}","starred_url":"https://api.github.com/users/pmatis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmatis/subscriptions","organizations_url":"https://api.github.com/users/pmatis/orgs","repos_url":"https://api.github.com/users/pmatis/repos","events_url":"https://api.github.com/users/pmatis/events{/privacy}","received_events_url":"https://api.github.com/users/pmatis/received_events","type":"User","site_admin":false},"repo":{"id":28918608,"name":"connector-telephony","full_name":"pmatis/connector-telephony","owner":{"login":"pmatis","id":5515738,"avatar_url":"https://avatars.githubusercontent.com/u/5515738?v=3","gravatar_id":"","url":"https://api.github.com/users/pmatis","html_url":"https://github.com/pmatis","followers_url":"https://api.github.com/users/pmatis/followers","following_url":"https://api.github.com/users/pmatis/following{/other_user}","gists_url":"https://api.github.com/users/pmatis/gists{/gist_id}","starred_url":"https://api.github.com/users/pmatis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmatis/subscriptions","organizations_url":"https://api.github.com/users/pmatis/orgs","repos_url":"https://api.github.com/users/pmatis/repos","events_url":"https://api.github.com/users/pmatis/events{/privacy}","received_events_url":"https://api.github.com/users/pmatis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmatis/connector-telephony","description":"Odoo modules for telephony integration","fork":true,"url":"https://api.github.com/repos/pmatis/connector-telephony","forks_url":"https://api.github.com/repos/pmatis/connector-telephony/forks","keys_url":"https://api.github.com/repos/pmatis/connector-telephony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmatis/connector-telephony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmatis/connector-telephony/teams","hooks_url":"https://api.github.com/repos/pmatis/connector-telephony/hooks","issue_events_url":"https://api.github.com/repos/pmatis/connector-telephony/issues/events{/number}","events_url":"https://api.github.com/repos/pmatis/connector-telephony/events","assignees_url":"https://api.github.com/repos/pmatis/connector-telephony/assignees{/user}","branches_url":"https://api.github.com/repos/pmatis/connector-telephony/branches{/branch}","tags_url":"https://api.github.com/repos/pmatis/connector-telephony/tags","blobs_url":"https://api.github.com/repos/pmatis/connector-telephony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmatis/connector-telephony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmatis/connector-telephony/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmatis/connector-telephony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmatis/connector-telephony/statuses/{sha}","languages_url":"https://api.github.com/repos/pmatis/connector-telephony/languages","stargazers_url":"https://api.github.com/repos/pmatis/connector-telephony/stargazers","contributors_url":"https://api.github.com/repos/pmatis/connector-telephony/contributors","subscribers_url":"https://api.github.com/repos/pmatis/connector-telephony/subscribers","subscription_url":"https://api.github.com/repos/pmatis/connector-telephony/subscription","commits_url":"https://api.github.com/repos/pmatis/connector-telephony/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmatis/connector-telephony/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmatis/connector-telephony/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmatis/connector-telephony/issues/comments/{number}","contents_url":"https://api.github.com/repos/pmatis/connector-telephony/contents/{+path}","compare_url":"https://api.github.com/repos/pmatis/connector-telephony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmatis/connector-telephony/merges","archive_url":"https://api.github.com/repos/pmatis/connector-telephony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmatis/connector-telephony/downloads","issues_url":"https://api.github.com/repos/pmatis/connector-telephony/issues{/number}","pulls_url":"https://api.github.com/repos/pmatis/connector-telephony/pulls{/number}","milestones_url":"https://api.github.com/repos/pmatis/connector-telephony/milestones{/number}","notifications_url":"https://api.github.com/repos/pmatis/connector-telephony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmatis/connector-telephony/labels{/name}","releases_url":"https://api.github.com/repos/pmatis/connector-telephony/releases{/id}","created_at":"2015-01-07T14:47:55Z","updated_at":"2015-01-07T14:47:57Z","pushed_at":"2015-01-07T14:54:32Z","git_url":"git://github.com/pmatis/connector-telephony.git","ssh_url":"git@github.com:pmatis/connector-telephony.git","clone_url":"https://github.com/pmatis/connector-telephony.git","svn_url":"https://github.com/pmatis/connector-telephony","homepage":null,"size":1206,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.0"}},"base":{"label":"OCA:8.0","ref":"8.0","sha":"f2efbde732100c3df5b978a4d0d2026d217e807d","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":26191306,"name":"connector-telephony","full_name":"OCA/connector-telephony","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/connector-telephony","description":"Odoo modules for telephony integration","fork":false,"url":"https://api.github.com/repos/OCA/connector-telephony","forks_url":"https://api.github.com/repos/OCA/connector-telephony/forks","keys_url":"https://api.github.com/repos/OCA/connector-telephony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/connector-telephony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/connector-telephony/teams","hooks_url":"https://api.github.com/repos/OCA/connector-telephony/hooks","issue_events_url":"https://api.github.com/repos/OCA/connector-telephony/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/connector-telephony/events","assignees_url":"https://api.github.com/repos/OCA/connector-telephony/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/connector-telephony/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/connector-telephony/tags","blobs_url":"https://api.github.com/repos/OCA/connector-telephony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/connector-telephony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/connector-telephony/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/connector-telephony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/connector-telephony/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/connector-telephony/languages","stargazers_url":"https://api.github.com/repos/OCA/connector-telephony/stargazers","contributors_url":"https://api.github.com/repos/OCA/connector-telephony/contributors","subscribers_url":"https://api.github.com/repos/OCA/connector-telephony/subscribers","subscription_url":"https://api.github.com/repos/OCA/connector-telephony/subscription","commits_url":"https://api.github.com/repos/OCA/connector-telephony/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/connector-telephony/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/connector-telephony/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/connector-telephony/issues/comments/{number}","contents_url":"https://api.github.com/repos/OCA/connector-telephony/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/connector-telephony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/connector-telephony/merges","archive_url":"https://api.github.com/repos/OCA/connector-telephony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/connector-telephony/downloads","issues_url":"https://api.github.com/repos/OCA/connector-telephony/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/connector-telephony/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/connector-telephony/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/connector-telephony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/connector-telephony/labels{/name}","releases_url":"https://api.github.com/repos/OCA/connector-telephony/releases{/id}","created_at":"2014-11-04T22:18:03Z","updated_at":"2015-01-22T14:15:43Z","pushed_at":"2015-01-22T14:15:43Z","git_url":"git://github.com/OCA/connector-telephony.git","ssh_url":"git@github.com:OCA/connector-telephony.git","clone_url":"https://github.com/OCA/connector-telephony.git","svn_url":"https://github.com/OCA/connector-telephony","homepage":null,"size":1512,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":7,"forks":23,"open_issues":7,"watchers":13,"default_branch":"8.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/connector-telephony/pulls/16"},"html":{"href":"https://github.com/OCA/connector-telephony/pull/16"},"issue":{"href":"https://api.github.com/repos/OCA/connector-telephony/issues/16"},"comments":{"href":"https://api.github.com/repos/OCA/connector-telephony/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/connector-telephony/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/connector-telephony/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/OCA/connector-telephony/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/connector-telephony/statuses/941b2184b379cda9de37f7f6a97bd6f6c9a3312f"}}}}