{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/45561380","id":45561380,"diff_hunk":"@@ -107,31 +107,23 @@ namespace android\n       m_androidDefResScope = \"fwr\";\n     else if (flavor.find(\"google\") == 0)\n       m_androidDefResScope = \"ferw\";\n-    else if (flavor.find(\"amazon\") == 0 || flavor.find(\"samsung\") == 0)\n+    else if (flavor.find(\"amazon\") == 0 || flavor.find(\"samsung\") == 0) // optimization to read World mwm-s faster","path":"android/jni/com/mapswithme/platform/Platform.cpp","position":14,"original_position":14,"commit_id":"7fe43a4cef94026fe521ced095e1eb123410ef7e","original_commit_id":"7fe43a4cef94026fe521ced095e1eb123410ef7e","user":{"login":"deathbaba","id":170263,"avatar_url":"https://avatars.githubusercontent.com/u/170263?v=3","gravatar_id":"","url":"https://api.github.com/users/deathbaba","html_url":"https://github.com/deathbaba","followers_url":"https://api.github.com/users/deathbaba/followers","following_url":"https://api.github.com/users/deathbaba/following{/other_user}","gists_url":"https://api.github.com/users/deathbaba/gists{/gist_id}","starred_url":"https://api.github.com/users/deathbaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deathbaba/subscriptions","organizations_url":"https://api.github.com/users/deathbaba/orgs","repos_url":"https://api.github.com/users/deathbaba/repos","events_url":"https://api.github.com/users/deathbaba/events{/privacy}","received_events_url":"https://api.github.com/users/deathbaba/received_events","type":"User","site_admin":false},"body":"Напиши тогда еще туду на выпилить или доработать как нужно.\n\n> On Nov 22, 2015, at 09:06, Dmitry Yunitsky <notifications@github.com> wrote:\n> \n> In android/jni/com/mapswithme/platform/Platform.cpp <https://github.com/mapsme/omim/pull/435#discussion_r45561274>:\n> \n> > @@ -107,31 +107,23 @@ namespace android\n> >        m_androidDefResScope = \"fwr\";\n> >      else if (flavor.find(\"google\") == 0)\n> >        m_androidDefResScope = \"ferw\";\n> > -    else if (flavor.find(\"amazon\") == 0 || flavor.find(\"samsung\") == 0)\n> > +    else if (flavor.find(\"amazon\") == 0 || flavor.find(\"samsung\") == 0) // optimization to read World mwm-s faster\n> Может и можно, здесь я только коммент добавил, чтобы было понятно что и зачем это. Реквест не про это. И Витя говорит, что это не так важно и выпилено будет скорее всего.\n> … <x-msg://17/#>\n> —\n> Reply to this email directly or view it on GitHub.\n> \n>  <https://github.com/mapsme/omim/pull/435#discussion_r45538873> <https://github.com/mapsme/omim/pull/435/files#r45538873>\n> —\n> Reply to this email directly or view it on GitHub <https://github.com/mapsme/omim/pull/435/files#r45561274>.\n> \n\n","created_at":"2015-11-22T17:13:57Z","updated_at":"2015-11-22T17:13:57Z","html_url":"https://github.com/mapsme/omim/pull/435#discussion_r45561380","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/435","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/45561380"},"html":{"href":"https://github.com/mapsme/omim/pull/435#discussion_r45561380"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/435"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/435","id":49456486,"html_url":"https://github.com/mapsme/omim/pull/435","diff_url":"https://github.com/mapsme/omim/pull/435.diff","patch_url":"https://github.com/mapsme/omim/pull/435.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/435","number":435,"state":"open","locked":false,"title":"[android] [DO NOT MERGE] Dialog for unavailable sdcard.","user":{"login":"yunikkk","id":2265924,"avatar_url":"https://avatars.githubusercontent.com/u/2265924?v=3","gravatar_id":"","url":"https://api.github.com/users/yunikkk","html_url":"https://github.com/yunikkk","followers_url":"https://api.github.com/users/yunikkk/followers","following_url":"https://api.github.com/users/yunikkk/following{/other_user}","gists_url":"https://api.github.com/users/yunikkk/gists{/gist_id}","starred_url":"https://api.github.com/users/yunikkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunikkk/subscriptions","organizations_url":"https://api.github.com/users/yunikkk/orgs","repos_url":"https://api.github.com/users/yunikkk/repos","events_url":"https://api.github.com/users/yunikkk/events{/privacy}","received_events_url":"https://api.github.com/users/yunikkk/received_events","type":"User","site_admin":false},"body":"В этом реквесте:\r\n1. Исправлен порядок инициализации сеттингов и стораджа с фреймворком, что приводило к сбросу стораджа в дефолтный.\r\n2. Добавил диалог для информирования юзера о недоступной для записи флешки. C кнопками \"повторить\" и \"отмена\". При этом пока не до конца релиазована логика по переносу карт-шрифтов в первичный сторадж (поэтому спрятана кнопка \"использовать первичный сторадж\"), поэтому пока DO NOT MERGE.","created_at":"2015-11-02T16:56:26Z","updated_at":"2015-11-22T17:13:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb8a45735246a9252698fad2de425bc4f38ee17b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/435/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/435/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/435/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/7fe43a4cef94026fe521ced095e1eb123410ef7e","head":{"label":"yunikkk:sdcard-unavailable-fixes","ref":"sdcard-unavailable-fixes","sha":"7fe43a4cef94026fe521ced095e1eb123410ef7e","user":{"login":"yunikkk","id":2265924,"avatar_url":"https://avatars.githubusercontent.com/u/2265924?v=3","gravatar_id":"","url":"https://api.github.com/users/yunikkk","html_url":"https://github.com/yunikkk","followers_url":"https://api.github.com/users/yunikkk/followers","following_url":"https://api.github.com/users/yunikkk/following{/other_user}","gists_url":"https://api.github.com/users/yunikkk/gists{/gist_id}","starred_url":"https://api.github.com/users/yunikkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunikkk/subscriptions","organizations_url":"https://api.github.com/users/yunikkk/orgs","repos_url":"https://api.github.com/users/yunikkk/repos","events_url":"https://api.github.com/users/yunikkk/events{/privacy}","received_events_url":"https://api.github.com/users/yunikkk/received_events","type":"User","site_admin":false},"repo":{"id":44106681,"name":"omim","full_name":"yunikkk/omim","owner":{"login":"yunikkk","id":2265924,"avatar_url":"https://avatars.githubusercontent.com/u/2265924?v=3","gravatar_id":"","url":"https://api.github.com/users/yunikkk","html_url":"https://github.com/yunikkk","followers_url":"https://api.github.com/users/yunikkk/followers","following_url":"https://api.github.com/users/yunikkk/following{/other_user}","gists_url":"https://api.github.com/users/yunikkk/gists{/gist_id}","starred_url":"https://api.github.com/users/yunikkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunikkk/subscriptions","organizations_url":"https://api.github.com/users/yunikkk/orgs","repos_url":"https://api.github.com/users/yunikkk/repos","events_url":"https://api.github.com/users/yunikkk/events{/privacy}","received_events_url":"https://api.github.com/users/yunikkk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yunikkk/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/yunikkk/omim","forks_url":"https://api.github.com/repos/yunikkk/omim/forks","keys_url":"https://api.github.com/repos/yunikkk/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yunikkk/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yunikkk/omim/teams","hooks_url":"https://api.github.com/repos/yunikkk/omim/hooks","issue_events_url":"https://api.github.com/repos/yunikkk/omim/issues/events{/number}","events_url":"https://api.github.com/repos/yunikkk/omim/events","assignees_url":"https://api.github.com/repos/yunikkk/omim/assignees{/user}","branches_url":"https://api.github.com/repos/yunikkk/omim/branches{/branch}","tags_url":"https://api.github.com/repos/yunikkk/omim/tags","blobs_url":"https://api.github.com/repos/yunikkk/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yunikkk/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yunikkk/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/yunikkk/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yunikkk/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/yunikkk/omim/languages","stargazers_url":"https://api.github.com/repos/yunikkk/omim/stargazers","contributors_url":"https://api.github.com/repos/yunikkk/omim/contributors","subscribers_url":"https://api.github.com/repos/yunikkk/omim/subscribers","subscription_url":"https://api.github.com/repos/yunikkk/omim/subscription","commits_url":"https://api.github.com/repos/yunikkk/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/yunikkk/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/yunikkk/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/yunikkk/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/yunikkk/omim/contents/{+path}","compare_url":"https://api.github.com/repos/yunikkk/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yunikkk/omim/merges","archive_url":"https://api.github.com/repos/yunikkk/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yunikkk/omim/downloads","issues_url":"https://api.github.com/repos/yunikkk/omim/issues{/number}","pulls_url":"https://api.github.com/repos/yunikkk/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/yunikkk/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/yunikkk/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yunikkk/omim/labels{/name}","releases_url":"https://api.github.com/repos/yunikkk/omim/releases{/id}","created_at":"2015-10-12T12:41:54Z","updated_at":"2015-10-12T12:44:08Z","pushed_at":"2015-11-20T15:55:23Z","git_url":"git://github.com/yunikkk/omim.git","ssh_url":"git@github.com:yunikkk/omim.git","clone_url":"https://github.com/yunikkk/omim.git","svn_url":"https://github.com/yunikkk/omim","homepage":null,"size":1880491,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"00e6e567f6e428ae4c8a05a94b877eafdf7878c2","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","created_at":"2015-09-20T02:57:13Z","updated_at":"2015-11-22T09:43:46Z","pushed_at":"2015-11-22T08:18:16Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":null,"size":1899412,"stargazers_count":1489,"watchers_count":1489,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":175,"mirror_url":null,"open_issues_count":66,"forks":175,"open_issues":66,"watchers":1489,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/435"},"html":{"href":"https://github.com/mapsme/omim/pull/435"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/435"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/435/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/435/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/435/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/7fe43a4cef94026fe521ced095e1eb123410ef7e"}}}}