{"action":"opened","number":257,"pull_request":{"url":"https://api.github.com/repos/localshred/protobuf/pulls/257","id":33989463,"html_url":"https://github.com/localshred/protobuf/pull/257","diff_url":"https://github.com/localshred/protobuf/pull/257.diff","patch_url":"https://github.com/localshred/protobuf/pull/257.patch","issue_url":"https://api.github.com/repos/localshred/protobuf/issues/257","number":257,"state":"open","locked":false,"title":"Move input file expansion into Ruby","user":{"login":"BBonifield","id":182615,"avatar_url":"https://avatars.githubusercontent.com/u/182615?v=3","gravatar_id":"","url":"https://api.github.com/users/BBonifield","html_url":"https://github.com/BBonifield","followers_url":"https://api.github.com/users/BBonifield/followers","following_url":"https://api.github.com/users/BBonifield/following{/other_user}","gists_url":"https://api.github.com/users/BBonifield/gists{/gist_id}","starred_url":"https://api.github.com/users/BBonifield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBonifield/subscriptions","organizations_url":"https://api.github.com/users/BBonifield/orgs","repos_url":"https://api.github.com/users/BBonifield/repos","events_url":"https://api.github.com/users/BBonifield/events{/privacy}","received_events_url":"https://api.github.com/users/BBonifield/received_events","type":"User","site_admin":false},"body":"#### What's this PR do?\r\n\r\nThe `rake protobuf:compile` task previously made an assumption about the implementing project having proto files directly under the package root as well as in some sub-directories.  If your system shell is configured as `bash`, the directory expansion would fail, resulting an an error message from `protoc`.\r\n\r\n```\r\n$ bundle exec rake protobuf:compile['package']\r\nprotoc --ruby_out=lib -I definitions definitions/package/*.proto definitions/package/**/*.proto\r\ndefinitions/package/**/*.proto: No such file or directory\r\n```\r\n\r\nThis PR adjusts the rake task to do the globing in Ruby, bypassing the shortcomings of `bash` and providing a more future-proof solution.\r\n\r\n#### How should this be manually tested?\r\n\r\nAdjust your system shell to bash.  Create a sandbox project with a single `.proto` file in the package directory.  Run `rake protobuf:compile` and ensure that the `protoc` command succeeds.\r\n\r\n#### Any additional context you want to provide?\r\n\r\n:heart: protobufs \r\n\r\nWe wanted to add some unit tests for this, but didn't as of the submission of this PR since our approach would be to extract the functionality behind the `protobuf:compile` task to an object, then test that object directly and invoke that object from the rake task. We weren't sure if that was a refactor / stance you cared to introduce, so we just wanted to ask about it first before doing the work.\r\n\r\n\\+ @jtrim","created_at":"2015-04-23T19:43:36Z","updated_at":"2015-04-23T19:43:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/localshred/protobuf/pulls/257/commits","review_comments_url":"https://api.github.com/repos/localshred/protobuf/pulls/257/comments","review_comment_url":"https://api.github.com/repos/localshred/protobuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/localshred/protobuf/issues/257/comments","statuses_url":"https://api.github.com/repos/localshred/protobuf/statuses/bcef5bc4faa1f02dbaf08d6fc7d65e3cb518788d","head":{"label":"ello:bb-jt-compiler-globing","ref":"bb-jt-compiler-globing","sha":"bcef5bc4faa1f02dbaf08d6fc7d65e3cb518788d","user":{"login":"ello","id":9370718,"avatar_url":"https://avatars.githubusercontent.com/u/9370718?v=3","gravatar_id":"","url":"https://api.github.com/users/ello","html_url":"https://github.com/ello","followers_url":"https://api.github.com/users/ello/followers","following_url":"https://api.github.com/users/ello/following{/other_user}","gists_url":"https://api.github.com/users/ello/gists{/gist_id}","starred_url":"https://api.github.com/users/ello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ello/subscriptions","organizations_url":"https://api.github.com/users/ello/orgs","repos_url":"https://api.github.com/users/ello/repos","events_url":"https://api.github.com/users/ello/events{/privacy}","received_events_url":"https://api.github.com/users/ello/received_events","type":"Organization","site_admin":false},"repo":{"id":34476639,"name":"protobuf","full_name":"ello/protobuf","owner":{"login":"ello","id":9370718,"avatar_url":"https://avatars.githubusercontent.com/u/9370718?v=3","gravatar_id":"","url":"https://api.github.com/users/ello","html_url":"https://github.com/ello","followers_url":"https://api.github.com/users/ello/followers","following_url":"https://api.github.com/users/ello/following{/other_user}","gists_url":"https://api.github.com/users/ello/gists{/gist_id}","starred_url":"https://api.github.com/users/ello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ello/subscriptions","organizations_url":"https://api.github.com/users/ello/orgs","repos_url":"https://api.github.com/users/ello/repos","events_url":"https://api.github.com/users/ello/events{/privacy}","received_events_url":"https://api.github.com/users/ello/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ello/protobuf","description":"Ruby implementation for Protocol Buffers","fork":true,"url":"https://api.github.com/repos/ello/protobuf","forks_url":"https://api.github.com/repos/ello/protobuf/forks","keys_url":"https://api.github.com/repos/ello/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ello/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ello/protobuf/teams","hooks_url":"https://api.github.com/repos/ello/protobuf/hooks","issue_events_url":"https://api.github.com/repos/ello/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/ello/protobuf/events","assignees_url":"https://api.github.com/repos/ello/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/ello/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/ello/protobuf/tags","blobs_url":"https://api.github.com/repos/ello/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ello/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ello/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/ello/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ello/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/ello/protobuf/languages","stargazers_url":"https://api.github.com/repos/ello/protobuf/stargazers","contributors_url":"https://api.github.com/repos/ello/protobuf/contributors","subscribers_url":"https://api.github.com/repos/ello/protobuf/subscribers","subscription_url":"https://api.github.com/repos/ello/protobuf/subscription","commits_url":"https://api.github.com/repos/ello/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/ello/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/ello/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/ello/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/ello/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/ello/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ello/protobuf/merges","archive_url":"https://api.github.com/repos/ello/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ello/protobuf/downloads","issues_url":"https://api.github.com/repos/ello/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/ello/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/ello/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/ello/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ello/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/ello/protobuf/releases{/id}","created_at":"2015-04-23T19:21:49Z","updated_at":"2015-04-23T19:21:50Z","pushed_at":"2015-04-23T19:39:30Z","git_url":"git://github.com/ello/protobuf.git","ssh_url":"git@github.com:ello/protobuf.git","clone_url":"https://github.com/ello/protobuf.git","svn_url":"https://github.com/ello/protobuf","homepage":"github.com/localshred","size":2529,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"localshred:2-8-stable","ref":"2-8-stable","sha":"ffd21585f0def3bb8f31f30cd893f66f61831428","user":{"login":"localshred","id":47752,"avatar_url":"https://avatars.githubusercontent.com/u/47752?v=3","gravatar_id":"","url":"https://api.github.com/users/localshred","html_url":"https://github.com/localshred","followers_url":"https://api.github.com/users/localshred/followers","following_url":"https://api.github.com/users/localshred/following{/other_user}","gists_url":"https://api.github.com/users/localshred/gists{/gist_id}","starred_url":"https://api.github.com/users/localshred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/localshred/subscriptions","organizations_url":"https://api.github.com/users/localshred/orgs","repos_url":"https://api.github.com/users/localshred/repos","events_url":"https://api.github.com/users/localshred/events{/privacy}","received_events_url":"https://api.github.com/users/localshred/received_events","type":"User","site_admin":false},"repo":{"id":2724591,"name":"protobuf","full_name":"localshred/protobuf","owner":{"login":"localshred","id":47752,"avatar_url":"https://avatars.githubusercontent.com/u/47752?v=3","gravatar_id":"","url":"https://api.github.com/users/localshred","html_url":"https://github.com/localshred","followers_url":"https://api.github.com/users/localshred/followers","following_url":"https://api.github.com/users/localshred/following{/other_user}","gists_url":"https://api.github.com/users/localshred/gists{/gist_id}","starred_url":"https://api.github.com/users/localshred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/localshred/subscriptions","organizations_url":"https://api.github.com/users/localshred/orgs","repos_url":"https://api.github.com/users/localshred/repos","events_url":"https://api.github.com/users/localshred/events{/privacy}","received_events_url":"https://api.github.com/users/localshred/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/localshred/protobuf","description":"Ruby implementation for Protocol Buffers","fork":false,"url":"https://api.github.com/repos/localshred/protobuf","forks_url":"https://api.github.com/repos/localshred/protobuf/forks","keys_url":"https://api.github.com/repos/localshred/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/localshred/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/localshred/protobuf/teams","hooks_url":"https://api.github.com/repos/localshred/protobuf/hooks","issue_events_url":"https://api.github.com/repos/localshred/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/localshred/protobuf/events","assignees_url":"https://api.github.com/repos/localshred/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/localshred/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/localshred/protobuf/tags","blobs_url":"https://api.github.com/repos/localshred/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/localshred/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/localshred/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/localshred/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/localshred/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/localshred/protobuf/languages","stargazers_url":"https://api.github.com/repos/localshred/protobuf/stargazers","contributors_url":"https://api.github.com/repos/localshred/protobuf/contributors","subscribers_url":"https://api.github.com/repos/localshred/protobuf/subscribers","subscription_url":"https://api.github.com/repos/localshred/protobuf/subscription","commits_url":"https://api.github.com/repos/localshred/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/localshred/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/localshred/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/localshred/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/localshred/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/localshred/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/localshred/protobuf/merges","archive_url":"https://api.github.com/repos/localshred/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/localshred/protobuf/downloads","issues_url":"https://api.github.com/repos/localshred/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/localshred/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/localshred/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/localshred/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/localshred/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/localshred/protobuf/releases{/id}","created_at":"2011-11-07T06:52:37Z","updated_at":"2015-04-14T02:39:38Z","pushed_at":"2015-04-16T04:49:33Z","git_url":"git://github.com/localshred/protobuf.git","ssh_url":"git@github.com:localshred/protobuf.git","clone_url":"https://github.com/localshred/protobuf.git","svn_url":"https://github.com/localshred/protobuf","homepage":"github.com/localshred","size":5773,"stargazers_count":127,"watchers_count":127,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":23,"forks":42,"open_issues":23,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/localshred/protobuf/pulls/257"},"html":{"href":"https://github.com/localshred/protobuf/pull/257"},"issue":{"href":"https://api.github.com/repos/localshred/protobuf/issues/257"},"comments":{"href":"https://api.github.com/repos/localshred/protobuf/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/localshred/protobuf/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/localshred/protobuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/localshred/protobuf/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/localshred/protobuf/statuses/bcef5bc4faa1f02dbaf08d6fc7d65e3cb518788d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":2,"changed_files":1}}