{"action":"created","comment":{"url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/comments/24654015","id":24654015,"diff_hunk":"@@ -0,0 +1,74 @@\n+/*\n+ * SonarQube Java\n+ * Copyright (C) 2012 SonarSource\n+ * dev@sonar.codehaus.org\n+ *\n+ * This program is free software; you can redistribute it and/or\n+ * modify it under the terms of the GNU Lesser General Public\n+ * License as published by the Free Software Foundation; either\n+ * version 3 of the License, or (at your option) any later version.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU\n+ * Lesser General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU Lesser General Public\n+ * License along with this program; if not, write to the Free Software\n+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02\n+ */\n+package org.sonar.java.checks;\n+\n+import com.google.common.collect.ImmutableList;\n+import org.sonar.api.server.rule.RulesDefinition;\n+import org.sonar.check.Priority;\n+import org.sonar.check.Rule;\n+import org.sonar.java.checks.methods.MethodInvocationMatcher;\n+import org.sonar.java.resolve.Symbol;\n+import org.sonar.plugins.java.api.tree.AssignmentExpressionTree;\n+import org.sonar.plugins.java.api.tree.IdentifierTree;\n+import org.sonar.plugins.java.api.tree.Tree;\n+import org.sonar.squidbridge.annotations.SqaleConstantRemediation;\n+import org.sonar.squidbridge.annotations.SqaleSubCharacteristic;\n+\n+import java.util.List;\n+\n+@Rule(\n+  key = \"S2444\",\n+  name = \"Lazy initialization of \\\"static\\\" fields should be \\\"synchronized\\\"\",\n+  tags = {\"bug\", \"multi-threading\"},\n+  priority = Priority.CRITICAL)\n+@SqaleSubCharacteristic(RulesDefinition.SubCharacteristics.SYNCHRONIZATION_RELIABILITY)\n+@SqaleConstantRemediation(\"30min\")\n+public class StaticFieldInitializationCheck extends AbstractInSynchronizeChecker {\n+\n+  @Override\n+  public List<Tree.Kind> nodesToVisit() {\n+    return ImmutableList.of(Tree.Kind.ASSIGNMENT, Tree.Kind.METHOD, Tree.Kind.METHOD_INVOCATION, Tree.Kind.SYNCHRONIZED_STATEMENT);","path":"java-checks/src/main/java/org/sonar/java/checks/StaticFieldInitializationCheck.java","position":47,"original_position":47,"commit_id":"ef2abcd62f8774d377aa0759ecfc3205a731e465","original_commit_id":"ef2abcd62f8774d377aa0759ecfc3205a731e465","user":{"login":"m-g-sonar","id":10588758,"avatar_url":"https://avatars.githubusercontent.com/u/10588758?v=3","gravatar_id":"","url":"https://api.github.com/users/m-g-sonar","html_url":"https://github.com/m-g-sonar","followers_url":"https://api.github.com/users/m-g-sonar/followers","following_url":"https://api.github.com/users/m-g-sonar/following{/other_user}","gists_url":"https://api.github.com/users/m-g-sonar/gists{/gist_id}","starred_url":"https://api.github.com/users/m-g-sonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-g-sonar/subscriptions","organizations_url":"https://api.github.com/users/m-g-sonar/orgs","repos_url":"https://api.github.com/users/m-g-sonar/repos","events_url":"https://api.github.com/users/m-g-sonar/events{/privacy}","received_events_url":"https://api.github.com/users/m-g-sonar/received_events","type":"User","site_admin":false},"body":"Why METHOD, METHOD_INVOCATION and SYNCHRONIZED_STATEMENT if only visited in case of ASSIGNMENT?","created_at":"2015-02-13T10:01:36Z","updated_at":"2015-02-13T10:01:36Z","html_url":"https://github.com/SonarSource/sonar-java/pull/62#discussion_r24654015","pull_request_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/comments/24654015"},"html":{"href":"https://github.com/SonarSource/sonar-java/pull/62#discussion_r24654015"},"pull_request":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/62","id":29249100,"html_url":"https://github.com/SonarSource/sonar-java/pull/62","diff_url":"https://github.com/SonarSource/sonar-java/pull/62.diff","patch_url":"https://github.com/SonarSource/sonar-java/pull/62.patch","issue_url":"https://api.github.com/repos/SonarSource/sonar-java/issues/62","number":62,"state":"open","locked":false,"title":"SONARJAVA-904 RSPEC-2444 lazy static field initialization","user":{"login":"benzonico","id":1199708,"avatar_url":"https://avatars.githubusercontent.com/u/1199708?v=3","gravatar_id":"","url":"https://api.github.com/users/benzonico","html_url":"https://github.com/benzonico","followers_url":"https://api.github.com/users/benzonico/followers","following_url":"https://api.github.com/users/benzonico/following{/other_user}","gists_url":"https://api.github.com/users/benzonico/gists{/gist_id}","starred_url":"https://api.github.com/users/benzonico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benzonico/subscriptions","organizations_url":"https://api.github.com/users/benzonico/orgs","repos_url":"https://api.github.com/users/benzonico/repos","events_url":"https://api.github.com/users/benzonico/events{/privacy}","received_events_url":"https://api.github.com/users/benzonico/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-02-13T09:02:29Z","updated_at":"2015-02-13T10:01:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b621b1b6bc22aeb58247cde76a756520cf8e9f2","assignee":{"login":"m-g-sonar","id":10588758,"avatar_url":"https://avatars.githubusercontent.com/u/10588758?v=3","gravatar_id":"","url":"https://api.github.com/users/m-g-sonar","html_url":"https://github.com/m-g-sonar","followers_url":"https://api.github.com/users/m-g-sonar/followers","following_url":"https://api.github.com/users/m-g-sonar/following{/other_user}","gists_url":"https://api.github.com/users/m-g-sonar/gists{/gist_id}","starred_url":"https://api.github.com/users/m-g-sonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-g-sonar/subscriptions","organizations_url":"https://api.github.com/users/m-g-sonar/orgs","repos_url":"https://api.github.com/users/m-g-sonar/repos","events_url":"https://api.github.com/users/m-g-sonar/events{/privacy}","received_events_url":"https://api.github.com/users/m-g-sonar/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/62/commits","review_comments_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/62/comments","review_comment_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SonarSource/sonar-java/issues/62/comments","statuses_url":"https://api.github.com/repos/SonarSource/sonar-java/statuses/ef2abcd62f8774d377aa0759ecfc3205a731e465","head":{"label":"benzonico:SONARJAVA-904","ref":"SONARJAVA-904","sha":"ef2abcd62f8774d377aa0759ecfc3205a731e465","user":{"login":"benzonico","id":1199708,"avatar_url":"https://avatars.githubusercontent.com/u/1199708?v=3","gravatar_id":"","url":"https://api.github.com/users/benzonico","html_url":"https://github.com/benzonico","followers_url":"https://api.github.com/users/benzonico/followers","following_url":"https://api.github.com/users/benzonico/following{/other_user}","gists_url":"https://api.github.com/users/benzonico/gists{/gist_id}","starred_url":"https://api.github.com/users/benzonico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benzonico/subscriptions","organizations_url":"https://api.github.com/users/benzonico/orgs","repos_url":"https://api.github.com/users/benzonico/repos","events_url":"https://api.github.com/users/benzonico/events{/privacy}","received_events_url":"https://api.github.com/users/benzonico/received_events","type":"User","site_admin":false},"repo":{"id":16585446,"name":"sonar-java","full_name":"benzonico/sonar-java","owner":{"login":"benzonico","id":1199708,"avatar_url":"https://avatars.githubusercontent.com/u/1199708?v=3","gravatar_id":"","url":"https://api.github.com/users/benzonico","html_url":"https://github.com/benzonico","followers_url":"https://api.github.com/users/benzonico/followers","following_url":"https://api.github.com/users/benzonico/following{/other_user}","gists_url":"https://api.github.com/users/benzonico/gists{/gist_id}","starred_url":"https://api.github.com/users/benzonico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benzonico/subscriptions","organizations_url":"https://api.github.com/users/benzonico/orgs","repos_url":"https://api.github.com/users/benzonico/repos","events_url":"https://api.github.com/users/benzonico/events{/privacy}","received_events_url":"https://api.github.com/users/benzonico/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benzonico/sonar-java","description":"","fork":true,"url":"https://api.github.com/repos/benzonico/sonar-java","forks_url":"https://api.github.com/repos/benzonico/sonar-java/forks","keys_url":"https://api.github.com/repos/benzonico/sonar-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benzonico/sonar-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benzonico/sonar-java/teams","hooks_url":"https://api.github.com/repos/benzonico/sonar-java/hooks","issue_events_url":"https://api.github.com/repos/benzonico/sonar-java/issues/events{/number}","events_url":"https://api.github.com/repos/benzonico/sonar-java/events","assignees_url":"https://api.github.com/repos/benzonico/sonar-java/assignees{/user}","branches_url":"https://api.github.com/repos/benzonico/sonar-java/branches{/branch}","tags_url":"https://api.github.com/repos/benzonico/sonar-java/tags","blobs_url":"https://api.github.com/repos/benzonico/sonar-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benzonico/sonar-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benzonico/sonar-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/benzonico/sonar-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benzonico/sonar-java/statuses/{sha}","languages_url":"https://api.github.com/repos/benzonico/sonar-java/languages","stargazers_url":"https://api.github.com/repos/benzonico/sonar-java/stargazers","contributors_url":"https://api.github.com/repos/benzonico/sonar-java/contributors","subscribers_url":"https://api.github.com/repos/benzonico/sonar-java/subscribers","subscription_url":"https://api.github.com/repos/benzonico/sonar-java/subscription","commits_url":"https://api.github.com/repos/benzonico/sonar-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/benzonico/sonar-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/benzonico/sonar-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/benzonico/sonar-java/issues/comments/{number}","contents_url":"https://api.github.com/repos/benzonico/sonar-java/contents/{+path}","compare_url":"https://api.github.com/repos/benzonico/sonar-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benzonico/sonar-java/merges","archive_url":"https://api.github.com/repos/benzonico/sonar-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benzonico/sonar-java/downloads","issues_url":"https://api.github.com/repos/benzonico/sonar-java/issues{/number}","pulls_url":"https://api.github.com/repos/benzonico/sonar-java/pulls{/number}","milestones_url":"https://api.github.com/repos/benzonico/sonar-java/milestones{/number}","notifications_url":"https://api.github.com/repos/benzonico/sonar-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benzonico/sonar-java/labels{/name}","releases_url":"https://api.github.com/repos/benzonico/sonar-java/releases{/id}","created_at":"2014-02-06T16:29:39Z","updated_at":"2014-08-11T16:38:33Z","pushed_at":"2015-02-13T09:01:51Z","git_url":"git://github.com/benzonico/sonar-java.git","ssh_url":"git@github.com:benzonico/sonar-java.git","clone_url":"https://github.com/benzonico/sonar-java.git","svn_url":"https://github.com/benzonico/sonar-java","homepage":"","size":10629,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SonarSource:master","ref":"master","sha":"2c0b7f00d5524187d19deb6eac883ae0504be786","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":5674787,"name":"sonar-java","full_name":"SonarSource/sonar-java","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonar-java","description":"","fork":false,"url":"https://api.github.com/repos/SonarSource/sonar-java","forks_url":"https://api.github.com/repos/SonarSource/sonar-java/forks","keys_url":"https://api.github.com/repos/SonarSource/sonar-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonar-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonar-java/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonar-java/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonar-java/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonar-java/events","assignees_url":"https://api.github.com/repos/SonarSource/sonar-java/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonar-java/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonar-java/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonar-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonar-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonar-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonar-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonar-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonar-java/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonar-java/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonar-java/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonar-java/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonar-java/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonar-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonar-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonar-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonar-java/issues/comments/{number}","contents_url":"https://api.github.com/repos/SonarSource/sonar-java/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonar-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonar-java/merges","archive_url":"https://api.github.com/repos/SonarSource/sonar-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonar-java/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonar-java/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonar-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonar-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonar-java/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonar-java/releases{/id}","created_at":"2012-09-04T15:53:13Z","updated_at":"2015-02-12T17:43:35Z","pushed_at":"2015-02-12T17:43:35Z","git_url":"git://github.com/SonarSource/sonar-java.git","ssh_url":"git@github.com:SonarSource/sonar-java.git","clone_url":"https://github.com/SonarSource/sonar-java.git","svn_url":"https://github.com/SonarSource/sonar-java","homepage":"","size":26255,"stargazers_count":32,"watchers_count":32,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":2,"forks":59,"open_issues":2,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/62"},"html":{"href":"https://github.com/SonarSource/sonar-java/pull/62"},"issue":{"href":"https://api.github.com/repos/SonarSource/sonar-java/issues/62"},"comments":{"href":"https://api.github.com/repos/SonarSource/sonar-java/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/SonarSource/sonar-java/statuses/ef2abcd62f8774d377aa0759ecfc3205a731e465"}}}}