{"action":"created","comment":{"url":"https://api.github.com/repos/vivisect/vivisect/pulls/comments/27213175","id":27213175,"diff_hunk":"@@ -68,6 +68,21 @@ def reprargs(trace, fmt, args):\n         r.append(rstr)\n     return r\n \n+def getArgs(trace, args):\n+    '''\n+    Assuming we are at the instruction after\n+    a call, grab the argument at the specified\n+    index (skipping the saved instruction pointer).\n+    '''\n+    cc = trace.getEmulator().getCallingConvention(\"stdcall\")\n+    if \"64\" in trace.getMeta(\"Architecture\"):\n+        if trace.getMeta(\"Platform\") == \"windows\":\n+            cc = trace.getEmulator().getCallingConvention(\"msx64call\")\n+        else: trace.getEmulator().getCallingConvention(\"sysvamd64call\")","path":"vdb/recon/__init__.py","position":23,"original_position":23,"commit_id":"d493791e954ef31a926acb99530c5f0d35884168","original_commit_id":"d493791e954ef31a926acb99530c5f0d35884168","user":{"login":"invisig0th","id":2624245,"avatar_url":"https://avatars.githubusercontent.com/u/2624245?v=3","gravatar_id":"","url":"https://api.github.com/users/invisig0th","html_url":"https://github.com/invisig0th","followers_url":"https://api.github.com/users/invisig0th/followers","following_url":"https://api.github.com/users/invisig0th/following{/other_user}","gists_url":"https://api.github.com/users/invisig0th/gists{/gist_id}","starred_url":"https://api.github.com/users/invisig0th/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invisig0th/subscriptions","organizations_url":"https://api.github.com/users/invisig0th/orgs","repos_url":"https://api.github.com/users/invisig0th/repos","events_url":"https://api.github.com/users/invisig0th/events{/privacy}","received_events_url":"https://api.github.com/users/invisig0th/received_events","type":"User","site_admin":false},"body":"inline \"else: foo\" is not style compatible with the rest of the code, i know it's a nit but if we dont try to \"dig up\" the code base will only become more inconsistent :)","created_at":"2015-03-26T13:47:04Z","updated_at":"2015-03-26T13:47:04Z","html_url":"https://github.com/vivisect/vivisect/pull/56#discussion_r27213175","pull_request_url":"https://api.github.com/repos/vivisect/vivisect/pulls/56","_links":{"self":{"href":"https://api.github.com/repos/vivisect/vivisect/pulls/comments/27213175"},"html":{"href":"https://github.com/vivisect/vivisect/pull/56#discussion_r27213175"},"pull_request":{"href":"https://api.github.com/repos/vivisect/vivisect/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/vivisect/vivisect/pulls/56","id":31383379,"html_url":"https://github.com/vivisect/vivisect/pull/56","diff_url":"https://github.com/vivisect/vivisect/pull/56.diff","patch_url":"https://github.com/vivisect/vivisect/pull/56.patch","issue_url":"https://api.github.com/repos/vivisect/vivisect/issues/56","number":56,"state":"open","locked":false,"title":"Recon x64","user":{"login":"cmaruti","id":2283072,"avatar_url":"https://avatars.githubusercontent.com/u/2283072?v=3","gravatar_id":"","url":"https://api.github.com/users/cmaruti","html_url":"https://github.com/cmaruti","followers_url":"https://api.github.com/users/cmaruti/followers","following_url":"https://api.github.com/users/cmaruti/following{/other_user}","gists_url":"https://api.github.com/users/cmaruti/gists{/gist_id}","starred_url":"https://api.github.com/users/cmaruti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmaruti/subscriptions","organizations_url":"https://api.github.com/users/cmaruti/orgs","repos_url":"https://api.github.com/users/cmaruti/repos","events_url":"https://api.github.com/users/cmaruti/events{/privacy}","received_events_url":"https://api.github.com/users/cmaruti/received_events","type":"User","site_admin":false},"body":"Improved support for x64 systems","created_at":"2015-03-17T22:12:46Z","updated_at":"2015-03-26T13:47:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05a5742f91fcb716507ca7c806a62f27e09feaa3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vivisect/vivisect/pulls/56/commits","review_comments_url":"https://api.github.com/repos/vivisect/vivisect/pulls/56/comments","review_comment_url":"https://api.github.com/repos/vivisect/vivisect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vivisect/vivisect/issues/56/comments","statuses_url":"https://api.github.com/repos/vivisect/vivisect/statuses/d493791e954ef31a926acb99530c5f0d35884168","head":{"label":"cmaruti:cm_recon_x64","ref":"cm_recon_x64","sha":"d493791e954ef31a926acb99530c5f0d35884168","user":{"login":"cmaruti","id":2283072,"avatar_url":"https://avatars.githubusercontent.com/u/2283072?v=3","gravatar_id":"","url":"https://api.github.com/users/cmaruti","html_url":"https://github.com/cmaruti","followers_url":"https://api.github.com/users/cmaruti/followers","following_url":"https://api.github.com/users/cmaruti/following{/other_user}","gists_url":"https://api.github.com/users/cmaruti/gists{/gist_id}","starred_url":"https://api.github.com/users/cmaruti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmaruti/subscriptions","organizations_url":"https://api.github.com/users/cmaruti/orgs","repos_url":"https://api.github.com/users/cmaruti/repos","events_url":"https://api.github.com/users/cmaruti/events{/privacy}","received_events_url":"https://api.github.com/users/cmaruti/received_events","type":"User","site_admin":false},"repo":{"id":27390980,"name":"vivisect","full_name":"cmaruti/vivisect","owner":{"login":"cmaruti","id":2283072,"avatar_url":"https://avatars.githubusercontent.com/u/2283072?v=3","gravatar_id":"","url":"https://api.github.com/users/cmaruti","html_url":"https://github.com/cmaruti","followers_url":"https://api.github.com/users/cmaruti/followers","following_url":"https://api.github.com/users/cmaruti/following{/other_user}","gists_url":"https://api.github.com/users/cmaruti/gists{/gist_id}","starred_url":"https://api.github.com/users/cmaruti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmaruti/subscriptions","organizations_url":"https://api.github.com/users/cmaruti/orgs","repos_url":"https://api.github.com/users/cmaruti/repos","events_url":"https://api.github.com/users/cmaruti/events{/privacy}","received_events_url":"https://api.github.com/users/cmaruti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmaruti/vivisect","description":"","fork":true,"url":"https://api.github.com/repos/cmaruti/vivisect","forks_url":"https://api.github.com/repos/cmaruti/vivisect/forks","keys_url":"https://api.github.com/repos/cmaruti/vivisect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmaruti/vivisect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmaruti/vivisect/teams","hooks_url":"https://api.github.com/repos/cmaruti/vivisect/hooks","issue_events_url":"https://api.github.com/repos/cmaruti/vivisect/issues/events{/number}","events_url":"https://api.github.com/repos/cmaruti/vivisect/events","assignees_url":"https://api.github.com/repos/cmaruti/vivisect/assignees{/user}","branches_url":"https://api.github.com/repos/cmaruti/vivisect/branches{/branch}","tags_url":"https://api.github.com/repos/cmaruti/vivisect/tags","blobs_url":"https://api.github.com/repos/cmaruti/vivisect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmaruti/vivisect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmaruti/vivisect/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmaruti/vivisect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmaruti/vivisect/statuses/{sha}","languages_url":"https://api.github.com/repos/cmaruti/vivisect/languages","stargazers_url":"https://api.github.com/repos/cmaruti/vivisect/stargazers","contributors_url":"https://api.github.com/repos/cmaruti/vivisect/contributors","subscribers_url":"https://api.github.com/repos/cmaruti/vivisect/subscribers","subscription_url":"https://api.github.com/repos/cmaruti/vivisect/subscription","commits_url":"https://api.github.com/repos/cmaruti/vivisect/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmaruti/vivisect/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmaruti/vivisect/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmaruti/vivisect/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmaruti/vivisect/contents/{+path}","compare_url":"https://api.github.com/repos/cmaruti/vivisect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmaruti/vivisect/merges","archive_url":"https://api.github.com/repos/cmaruti/vivisect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmaruti/vivisect/downloads","issues_url":"https://api.github.com/repos/cmaruti/vivisect/issues{/number}","pulls_url":"https://api.github.com/repos/cmaruti/vivisect/pulls{/number}","milestones_url":"https://api.github.com/repos/cmaruti/vivisect/milestones{/number}","notifications_url":"https://api.github.com/repos/cmaruti/vivisect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmaruti/vivisect/labels{/name}","releases_url":"https://api.github.com/repos/cmaruti/vivisect/releases{/id}","created_at":"2014-12-01T17:30:37Z","updated_at":"2015-03-10T15:57:30Z","pushed_at":"2015-03-18T15:24:33Z","git_url":"git://github.com/cmaruti/vivisect.git","ssh_url":"git@github.com:cmaruti/vivisect.git","clone_url":"https://github.com/cmaruti/vivisect.git","svn_url":"https://github.com/cmaruti/vivisect","homepage":"","size":3029,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vivisect:master","ref":"master","sha":"8e59cba34b03f147f28dd33434fc1e122fceae34","user":{"login":"vivisect","id":9749998,"avatar_url":"https://avatars.githubusercontent.com/u/9749998?v=3","gravatar_id":"","url":"https://api.github.com/users/vivisect","html_url":"https://github.com/vivisect","followers_url":"https://api.github.com/users/vivisect/followers","following_url":"https://api.github.com/users/vivisect/following{/other_user}","gists_url":"https://api.github.com/users/vivisect/gists{/gist_id}","starred_url":"https://api.github.com/users/vivisect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivisect/subscriptions","organizations_url":"https://api.github.com/users/vivisect/orgs","repos_url":"https://api.github.com/users/vivisect/repos","events_url":"https://api.github.com/users/vivisect/events{/privacy}","received_events_url":"https://api.github.com/users/vivisect/received_events","type":"Organization","site_admin":false},"repo":{"id":26651759,"name":"vivisect","full_name":"vivisect/vivisect","owner":{"login":"vivisect","id":9749998,"avatar_url":"https://avatars.githubusercontent.com/u/9749998?v=3","gravatar_id":"","url":"https://api.github.com/users/vivisect","html_url":"https://github.com/vivisect","followers_url":"https://api.github.com/users/vivisect/followers","following_url":"https://api.github.com/users/vivisect/following{/other_user}","gists_url":"https://api.github.com/users/vivisect/gists{/gist_id}","starred_url":"https://api.github.com/users/vivisect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivisect/subscriptions","organizations_url":"https://api.github.com/users/vivisect/orgs","repos_url":"https://api.github.com/users/vivisect/repos","events_url":"https://api.github.com/users/vivisect/events{/privacy}","received_events_url":"https://api.github.com/users/vivisect/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vivisect/vivisect","description":"","fork":false,"url":"https://api.github.com/repos/vivisect/vivisect","forks_url":"https://api.github.com/repos/vivisect/vivisect/forks","keys_url":"https://api.github.com/repos/vivisect/vivisect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vivisect/vivisect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vivisect/vivisect/teams","hooks_url":"https://api.github.com/repos/vivisect/vivisect/hooks","issue_events_url":"https://api.github.com/repos/vivisect/vivisect/issues/events{/number}","events_url":"https://api.github.com/repos/vivisect/vivisect/events","assignees_url":"https://api.github.com/repos/vivisect/vivisect/assignees{/user}","branches_url":"https://api.github.com/repos/vivisect/vivisect/branches{/branch}","tags_url":"https://api.github.com/repos/vivisect/vivisect/tags","blobs_url":"https://api.github.com/repos/vivisect/vivisect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vivisect/vivisect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vivisect/vivisect/git/refs{/sha}","trees_url":"https://api.github.com/repos/vivisect/vivisect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vivisect/vivisect/statuses/{sha}","languages_url":"https://api.github.com/repos/vivisect/vivisect/languages","stargazers_url":"https://api.github.com/repos/vivisect/vivisect/stargazers","contributors_url":"https://api.github.com/repos/vivisect/vivisect/contributors","subscribers_url":"https://api.github.com/repos/vivisect/vivisect/subscribers","subscription_url":"https://api.github.com/repos/vivisect/vivisect/subscription","commits_url":"https://api.github.com/repos/vivisect/vivisect/commits{/sha}","git_commits_url":"https://api.github.com/repos/vivisect/vivisect/git/commits{/sha}","comments_url":"https://api.github.com/repos/vivisect/vivisect/comments{/number}","issue_comment_url":"https://api.github.com/repos/vivisect/vivisect/issues/comments{/number}","contents_url":"https://api.github.com/repos/vivisect/vivisect/contents/{+path}","compare_url":"https://api.github.com/repos/vivisect/vivisect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vivisect/vivisect/merges","archive_url":"https://api.github.com/repos/vivisect/vivisect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vivisect/vivisect/downloads","issues_url":"https://api.github.com/repos/vivisect/vivisect/issues{/number}","pulls_url":"https://api.github.com/repos/vivisect/vivisect/pulls{/number}","milestones_url":"https://api.github.com/repos/vivisect/vivisect/milestones{/number}","notifications_url":"https://api.github.com/repos/vivisect/vivisect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vivisect/vivisect/labels{/name}","releases_url":"https://api.github.com/repos/vivisect/vivisect/releases{/id}","created_at":"2014-11-14T18:28:47Z","updated_at":"2015-03-25T17:58:20Z","pushed_at":"2015-03-25T17:58:18Z","git_url":"git://github.com/vivisect/vivisect.git","ssh_url":"git@github.com:vivisect/vivisect.git","clone_url":"https://github.com/vivisect/vivisect.git","svn_url":"https://github.com/vivisect/vivisect","homepage":null,"size":4361,"stargazers_count":107,"watchers_count":107,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":6,"forks":27,"open_issues":6,"watchers":107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vivisect/vivisect/pulls/56"},"html":{"href":"https://github.com/vivisect/vivisect/pull/56"},"issue":{"href":"https://api.github.com/repos/vivisect/vivisect/issues/56"},"comments":{"href":"https://api.github.com/repos/vivisect/vivisect/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/vivisect/vivisect/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/vivisect/vivisect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vivisect/vivisect/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/vivisect/vivisect/statuses/d493791e954ef31a926acb99530c5f0d35884168"}}}}