{"action":"created","issue":{"url":"https://api.github.com/repos/vispy/vispy/issues/833","labels_url":"https://api.github.com/repos/vispy/vispy/issues/833/labels{/name}","comments_url":"https://api.github.com/repos/vispy/vispy/issues/833/comments","events_url":"https://api.github.com/repos/vispy/vispy/issues/833/events","html_url":"https://github.com/vispy/vispy/pull/833","id":64969790,"number":833,"title":"Fixed a TubeVisual bug and rearranged doc","user":{"login":"inclement","id":1265819,"avatar_url":"https://avatars.githubusercontent.com/u/1265819?v=3","gravatar_id":"","url":"https://api.github.com/users/inclement","html_url":"https://github.com/inclement","followers_url":"https://api.github.com/users/inclement/followers","following_url":"https://api.github.com/users/inclement/following{/other_user}","gists_url":"https://api.github.com/users/inclement/gists{/gist_id}","starred_url":"https://api.github.com/users/inclement/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inclement/subscriptions","organizations_url":"https://api.github.com/users/inclement/orgs","repos_url":"https://api.github.com/users/inclement/repos","events_url":"https://api.github.com/users/inclement/events{/privacy}","received_events_url":"https://api.github.com/users/inclement/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-28T17:50:04Z","updated_at":"2015-03-29T10:51:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vispy/vispy/pulls/833","html_url":"https://github.com/vispy/vispy/pull/833","diff_url":"https://github.com/vispy/vispy/pull/833.diff","patch_url":"https://github.com/vispy/vispy/pull/833.patch"},"body":"Previously the tube tangents were calculated assuming the tube was closed, which messed up the first and last tangent values unless they happened to match anyway. The problem is shown in the images below. I also rearranged the doc (and added a missing parameter) to emphasise the main arguments.\r\n\r\nExample tubes before this PR:\r\n![tubes_problem_orig](https://cloud.githubusercontent.com/assets/1265819/6882107/b1a926c8-d572-11e4-8b2b-b4b1ec9ef02d.png)\r\n\r\nAnd after:\r\n![tubes_problem_fixed](https://cloud.githubusercontent.com/assets/1265819/6882106/b1a2dfac-d572-11e4-830b-cf7fbf9228cd.png)\r\n"},"comment":{"url":"https://api.github.com/repos/vispy/vispy/issues/comments/87391018","html_url":"https://github.com/vispy/vispy/pull/833#issuecomment-87391018","issue_url":"https://api.github.com/repos/vispy/vispy/issues/833","id":87391018,"user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"created_at":"2015-03-29T10:51:20Z","updated_at":"2015-03-29T10:51:20Z","body":"@inclement are you on latest master? We did some refactoring of the transformation system, and I just wanted to make sure that the normals were still calculated correctly. If they aren't, could you fix as part of this PR?"}}