{"action":"created","comment":{"url":"https://api.github.com/repos/wso2/andes/pulls/comments/42583459","id":42583459,"diff_hunk":"@@ -55,6 +55,9 @@\n     //keep if the underlying subscription is active\n     private boolean isActive;\n \n+    // Should this subscriber act as a durable one\n+    private boolean isDurable;","path":"modules/andes-core/broker/src/main/java/org/wso2/andes/mqtt/MQTTLocalSubscription.java","position":5,"original_position":5,"commit_id":"19ca8683a90ed40530f38c31f59ad96a02b1b243","original_commit_id":"19ca8683a90ed40530f38c31f59ad96a02b1b243","user":{"login":"a5anka","id":1148405,"avatar_url":"https://avatars.githubusercontent.com/u/1148405?v=3","gravatar_id":"","url":"https://api.github.com/users/a5anka","html_url":"https://github.com/a5anka","followers_url":"https://api.github.com/users/a5anka/followers","following_url":"https://api.github.com/users/a5anka/following{/other_user}","gists_url":"https://api.github.com/users/a5anka/gists{/gist_id}","starred_url":"https://api.github.com/users/a5anka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a5anka/subscriptions","organizations_url":"https://api.github.com/users/a5anka/orgs","repos_url":"https://api.github.com/users/a5anka/repos","events_url":"https://api.github.com/users/a5anka/events{/privacy}","received_events_url":"https://api.github.com/users/a5anka/received_events","type":"User","site_admin":false},"body":"Shouldn't we use following syntax for doc comments.\r\n```java\r\n/** \r\n * Should this subscriber act as a durable one\r\n */\r\n```","created_at":"2015-10-21T04:59:00Z","updated_at":"2015-10-21T04:59:00Z","html_url":"https://github.com/wso2/andes/pull/432#discussion_r42583459","pull_request_url":"https://api.github.com/repos/wso2/andes/pulls/432","_links":{"self":{"href":"https://api.github.com/repos/wso2/andes/pulls/comments/42583459"},"html":{"href":"https://github.com/wso2/andes/pull/432#discussion_r42583459"},"pull_request":{"href":"https://api.github.com/repos/wso2/andes/pulls/432"}}},"pull_request":{"url":"https://api.github.com/repos/wso2/andes/pulls/432","id":48177248,"html_url":"https://github.com/wso2/andes/pull/432","diff_url":"https://github.com/wso2/andes/pull/432.diff","patch_url":"https://github.com/wso2/andes/pull/432.patch","issue_url":"https://api.github.com/repos/wso2/andes/issues/432","number":432,"state":"open","locked":false,"title":"Consider durability in mqtt with regards to qos and clean session","user":{"login":"akalankapagoda","id":1322058,"avatar_url":"https://avatars.githubusercontent.com/u/1322058?v=3","gravatar_id":"","url":"https://api.github.com/users/akalankapagoda","html_url":"https://github.com/akalankapagoda","followers_url":"https://api.github.com/users/akalankapagoda/followers","following_url":"https://api.github.com/users/akalankapagoda/following{/other_user}","gists_url":"https://api.github.com/users/akalankapagoda/gists{/gist_id}","starred_url":"https://api.github.com/users/akalankapagoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akalankapagoda/subscriptions","organizations_url":"https://api.github.com/users/akalankapagoda/orgs","repos_url":"https://api.github.com/users/akalankapagoda/repos","events_url":"https://api.github.com/users/akalankapagoda/events{/privacy}","received_events_url":"https://api.github.com/users/akalankapagoda/received_events","type":"User","site_admin":false},"body":"In MQTT subscribers, it is consider as durable where clean session is false and qos is greater than 0. Use this logic in locations where MQTT durability is in required.","created_at":"2015-10-20T09:40:37Z","updated_at":"2015-10-21T04:59:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5fb69204ca7dfd821863e822b083b0d780d6698","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wso2/andes/pulls/432/commits","review_comments_url":"https://api.github.com/repos/wso2/andes/pulls/432/comments","review_comment_url":"https://api.github.com/repos/wso2/andes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/andes/issues/432/comments","statuses_url":"https://api.github.com/repos/wso2/andes/statuses/19ca8683a90ed40530f38c31f59ad96a02b1b243","head":{"label":"akalankapagoda:MQTTDurabilityFix","ref":"MQTTDurabilityFix","sha":"19ca8683a90ed40530f38c31f59ad96a02b1b243","user":{"login":"akalankapagoda","id":1322058,"avatar_url":"https://avatars.githubusercontent.com/u/1322058?v=3","gravatar_id":"","url":"https://api.github.com/users/akalankapagoda","html_url":"https://github.com/akalankapagoda","followers_url":"https://api.github.com/users/akalankapagoda/followers","following_url":"https://api.github.com/users/akalankapagoda/following{/other_user}","gists_url":"https://api.github.com/users/akalankapagoda/gists{/gist_id}","starred_url":"https://api.github.com/users/akalankapagoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akalankapagoda/subscriptions","organizations_url":"https://api.github.com/users/akalankapagoda/orgs","repos_url":"https://api.github.com/users/akalankapagoda/repos","events_url":"https://api.github.com/users/akalankapagoda/events{/privacy}","received_events_url":"https://api.github.com/users/akalankapagoda/received_events","type":"User","site_admin":false},"repo":{"id":22331598,"name":"andes","full_name":"akalankapagoda/andes","owner":{"login":"akalankapagoda","id":1322058,"avatar_url":"https://avatars.githubusercontent.com/u/1322058?v=3","gravatar_id":"","url":"https://api.github.com/users/akalankapagoda","html_url":"https://github.com/akalankapagoda","followers_url":"https://api.github.com/users/akalankapagoda/followers","following_url":"https://api.github.com/users/akalankapagoda/following{/other_user}","gists_url":"https://api.github.com/users/akalankapagoda/gists{/gist_id}","starred_url":"https://api.github.com/users/akalankapagoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akalankapagoda/subscriptions","organizations_url":"https://api.github.com/users/akalankapagoda/orgs","repos_url":"https://api.github.com/users/akalankapagoda/repos","events_url":"https://api.github.com/users/akalankapagoda/events{/privacy}","received_events_url":"https://api.github.com/users/akalankapagoda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akalankapagoda/andes","description":"","fork":true,"url":"https://api.github.com/repos/akalankapagoda/andes","forks_url":"https://api.github.com/repos/akalankapagoda/andes/forks","keys_url":"https://api.github.com/repos/akalankapagoda/andes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akalankapagoda/andes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akalankapagoda/andes/teams","hooks_url":"https://api.github.com/repos/akalankapagoda/andes/hooks","issue_events_url":"https://api.github.com/repos/akalankapagoda/andes/issues/events{/number}","events_url":"https://api.github.com/repos/akalankapagoda/andes/events","assignees_url":"https://api.github.com/repos/akalankapagoda/andes/assignees{/user}","branches_url":"https://api.github.com/repos/akalankapagoda/andes/branches{/branch}","tags_url":"https://api.github.com/repos/akalankapagoda/andes/tags","blobs_url":"https://api.github.com/repos/akalankapagoda/andes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akalankapagoda/andes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akalankapagoda/andes/git/refs{/sha}","trees_url":"https://api.github.com/repos/akalankapagoda/andes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akalankapagoda/andes/statuses/{sha}","languages_url":"https://api.github.com/repos/akalankapagoda/andes/languages","stargazers_url":"https://api.github.com/repos/akalankapagoda/andes/stargazers","contributors_url":"https://api.github.com/repos/akalankapagoda/andes/contributors","subscribers_url":"https://api.github.com/repos/akalankapagoda/andes/subscribers","subscription_url":"https://api.github.com/repos/akalankapagoda/andes/subscription","commits_url":"https://api.github.com/repos/akalankapagoda/andes/commits{/sha}","git_commits_url":"https://api.github.com/repos/akalankapagoda/andes/git/commits{/sha}","comments_url":"https://api.github.com/repos/akalankapagoda/andes/comments{/number}","issue_comment_url":"https://api.github.com/repos/akalankapagoda/andes/issues/comments{/number}","contents_url":"https://api.github.com/repos/akalankapagoda/andes/contents/{+path}","compare_url":"https://api.github.com/repos/akalankapagoda/andes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akalankapagoda/andes/merges","archive_url":"https://api.github.com/repos/akalankapagoda/andes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akalankapagoda/andes/downloads","issues_url":"https://api.github.com/repos/akalankapagoda/andes/issues{/number}","pulls_url":"https://api.github.com/repos/akalankapagoda/andes/pulls{/number}","milestones_url":"https://api.github.com/repos/akalankapagoda/andes/milestones{/number}","notifications_url":"https://api.github.com/repos/akalankapagoda/andes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akalankapagoda/andes/labels{/name}","releases_url":"https://api.github.com/repos/akalankapagoda/andes/releases{/id}","created_at":"2014-07-28T05:11:24Z","updated_at":"2015-09-10T08:37:53Z","pushed_at":"2015-10-21T04:54:46Z","git_url":"git://github.com/akalankapagoda/andes.git","ssh_url":"git@github.com:akalankapagoda/andes.git","clone_url":"https://github.com/akalankapagoda/andes.git","svn_url":"https://github.com/akalankapagoda/andes","homepage":null,"size":66918,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:master","ref":"master","sha":"5a96809e0971d952df02e8c02656b1ffecd86611","user":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":20559270,"name":"andes","full_name":"wso2/andes","owner":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2/andes","description":"","fork":false,"url":"https://api.github.com/repos/wso2/andes","forks_url":"https://api.github.com/repos/wso2/andes/forks","keys_url":"https://api.github.com/repos/wso2/andes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/andes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/andes/teams","hooks_url":"https://api.github.com/repos/wso2/andes/hooks","issue_events_url":"https://api.github.com/repos/wso2/andes/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/andes/events","assignees_url":"https://api.github.com/repos/wso2/andes/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/andes/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/andes/tags","blobs_url":"https://api.github.com/repos/wso2/andes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/andes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/andes/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/andes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/andes/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/andes/languages","stargazers_url":"https://api.github.com/repos/wso2/andes/stargazers","contributors_url":"https://api.github.com/repos/wso2/andes/contributors","subscribers_url":"https://api.github.com/repos/wso2/andes/subscribers","subscription_url":"https://api.github.com/repos/wso2/andes/subscription","commits_url":"https://api.github.com/repos/wso2/andes/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/andes/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/andes/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/andes/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/andes/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/andes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/andes/merges","archive_url":"https://api.github.com/repos/wso2/andes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/andes/downloads","issues_url":"https://api.github.com/repos/wso2/andes/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/andes/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/andes/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/andes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/andes/labels{/name}","releases_url":"https://api.github.com/repos/wso2/andes/releases{/id}","created_at":"2014-06-06T10:04:24Z","updated_at":"2015-05-05T14:31:31Z","pushed_at":"2015-10-21T04:58:18Z","git_url":"git://github.com/wso2/andes.git","ssh_url":"git@github.com:wso2/andes.git","clone_url":"https://github.com/wso2/andes.git","svn_url":"https://github.com/wso2/andes","homepage":null,"size":70418,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":4,"forks":38,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/andes/pulls/432"},"html":{"href":"https://github.com/wso2/andes/pull/432"},"issue":{"href":"https://api.github.com/repos/wso2/andes/issues/432"},"comments":{"href":"https://api.github.com/repos/wso2/andes/issues/432/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/andes/pulls/432/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/andes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/andes/pulls/432/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/andes/statuses/19ca8683a90ed40530f38c31f59ad96a02b1b243"}}}}