{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/21998","labels_url":"https://api.github.com/repos/saltstack/salt/issues/21998/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/21998/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/21998/events","html_url":"https://github.com/saltstack/salt/issues/21998","id":64334665,"number":21998,"title":"yum pkgrepo.managed basedir should default to reposdir location as specified in /etc/yum.conf","user":{"login":"tjstansell","id":5217454,"avatar_url":"https://avatars.githubusercontent.com/u/5217454?v=3","gravatar_id":"","url":"https://api.github.com/users/tjstansell","html_url":"https://github.com/tjstansell","followers_url":"https://api.github.com/users/tjstansell/followers","following_url":"https://api.github.com/users/tjstansell/following{/other_user}","gists_url":"https://api.github.com/users/tjstansell/gists{/gist_id}","starred_url":"https://api.github.com/users/tjstansell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjstansell/subscriptions","organizations_url":"https://api.github.com/users/tjstansell/orgs","repos_url":"https://api.github.com/users/tjstansell/repos","events_url":"https://api.github.com/users/tjstansell/events{/privacy}","received_events_url":"https://api.github.com/users/tjstansell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/saltstack/salt/labels/Feature","name":"Feature","color":"009800"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/saltstack/salt/milestones/13","html_url":"https://github.com/saltstack/salt/milestones/Approved","labels_url":"https://api.github.com/repos/saltstack/salt/milestones/13/labels","id":9265,"number":13,"title":"Approved","description":"All issues that are ready to be worked on, both bugs and features.","creator":{"login":"thatch45","id":507599,"avatar_url":"https://avatars.githubusercontent.com/u/507599?v=3","gravatar_id":"","url":"https://api.github.com/users/thatch45","html_url":"https://github.com/thatch45","followers_url":"https://api.github.com/users/thatch45/followers","following_url":"https://api.github.com/users/thatch45/following{/other_user}","gists_url":"https://api.github.com/users/thatch45/gists{/gist_id}","starred_url":"https://api.github.com/users/thatch45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thatch45/subscriptions","organizations_url":"https://api.github.com/users/thatch45/orgs","repos_url":"https://api.github.com/users/thatch45/repos","events_url":"https://api.github.com/users/thatch45/events{/privacy}","received_events_url":"https://api.github.com/users/thatch45/received_events","type":"User","site_admin":false},"open_issues":2137,"closed_issues":1813,"state":"open","created_at":"2011-05-14T04:00:56Z","updated_at":"2015-04-16T20:46:13Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2015-03-25T17:59:54Z","updated_at":"2015-04-16T20:46:13Z","closed_at":"2015-04-16T20:46:13Z","body":"When specifying pkgrepo.managed entries, the default basedir should come from the reposdir parameter in yum.conf, if it is specified.  Currently it is hardcoded to /etc/yum.repos.d, which is fine if it is not overridden in the yum.conf, since that is yum's default.  This allows the user to change the reposdir setting in yum.conf and have salt manage repos in the proper directories.  Since the reposdir setting is actually a list of repositories, salt should ideally be aware of that whole list.  When adding new entries, it could simply add it to the first directory that exists, but when checking if the repo already exists, it should look at all directories specified in reposdir, just as yum does.  The yum-config-manager script looks for the first directory in reposdir that exists and uses that when adding a repo.\r\n\r\nYum actually provides a bunch of python libraries in /usr/share/yum-cli that some of it's utilities use (at least on Centos 6 and 7).  I'm not sure if it would be better to change some of the yumpkg.py to use this to better align with the way the system tools are implemented or if managing things separately is better."},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/93835959","html_url":"https://github.com/saltstack/salt/issues/21998#issuecomment-93835959","issue_url":"https://api.github.com/repos/saltstack/salt/issues/21998","id":93835959,"user":{"login":"tjstansell","id":5217454,"avatar_url":"https://avatars.githubusercontent.com/u/5217454?v=3","gravatar_id":"","url":"https://api.github.com/users/tjstansell","html_url":"https://github.com/tjstansell","followers_url":"https://api.github.com/users/tjstansell/followers","following_url":"https://api.github.com/users/tjstansell/following{/other_user}","gists_url":"https://api.github.com/users/tjstansell/gists{/gist_id}","starred_url":"https://api.github.com/users/tjstansell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjstansell/subscriptions","organizations_url":"https://api.github.com/users/tjstansell/orgs","repos_url":"https://api.github.com/users/tjstansell/repos","events_url":"https://api.github.com/users/tjstansell/events{/privacy}","received_events_url":"https://api.github.com/users/tjstansell/received_events","type":"User","site_admin":false},"created_at":"2015-04-16T20:46:13Z","updated_at":"2015-04-16T20:46:13Z","body":"This has been merged, so closing."}}