{"action":"created","issue":{"url":"https://api.github.com/repos/clojure-emacs/cider/issues/984","labels_url":"https://api.github.com/repos/clojure-emacs/cider/issues/984/labels{/name}","comments_url":"https://api.github.com/repos/clojure-emacs/cider/issues/984/comments","events_url":"https://api.github.com/repos/clojure-emacs/cider/issues/984/events","html_url":"https://github.com/clojure-emacs/cider/pull/984","id":58477413,"number":984,"title":"Allow the prompt to be tailored","user":{"login":"simon-katz","id":823295,"avatar_url":"https://avatars.githubusercontent.com/u/823295?v=3","gravatar_id":"","url":"https://api.github.com/users/simon-katz","html_url":"https://github.com/simon-katz","followers_url":"https://api.github.com/users/simon-katz/followers","following_url":"https://api.github.com/users/simon-katz/following{/other_user}","gists_url":"https://api.github.com/users/simon-katz/gists{/gist_id}","starred_url":"https://api.github.com/users/simon-katz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon-katz/subscriptions","organizations_url":"https://api.github.com/users/simon-katz/orgs","repos_url":"https://api.github.com/users/simon-katz/repos","events_url":"https://api.github.com/users/simon-katz/events{/privacy}","received_events_url":"https://api.github.com/users/simon-katz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-02-21T22:14:31Z","updated_at":"2015-02-22T10:01:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/clojure-emacs/cider/pulls/984","html_url":"https://github.com/clojure-emacs/cider/pull/984","diff_url":"https://github.com/clojure-emacs/cider/pull/984.diff","patch_url":"https://github.com/clojure-emacs/cider/pull/984.patch"},"body":"The prompt string is currently hidden in `cider-repl--insert-prompt`, and so it cannot be tailored.\r\n\r\nThis pull request adds `cider-repl--prompt-function` and `cider-repl--default-prompt`. This allows the prompt to be tailored, either by setting `cider-repl--prompt-function` or perhaps by advising `cider-repl--default-prompt`.\r\n\r\nIf it's a good idea, I'm happy to update the README to describe this. I think I would probably only describe setting `cider-repl--prompt-function`, and not the possibility of using advice. (But maybe that would just be cluttering the README with something that most people wouldn't be interested in.)"},"comment":{"url":"https://api.github.com/repos/clojure-emacs/cider/issues/comments/75428107","html_url":"https://github.com/clojure-emacs/cider/pull/984#issuecomment-75428107","issue_url":"https://api.github.com/repos/clojure-emacs/cider/issues/984","id":75428107,"user":{"login":"simon-katz","id":823295,"avatar_url":"https://avatars.githubusercontent.com/u/823295?v=3","gravatar_id":"","url":"https://api.github.com/users/simon-katz","html_url":"https://github.com/simon-katz","followers_url":"https://api.github.com/users/simon-katz/followers","following_url":"https://api.github.com/users/simon-katz/following{/other_user}","gists_url":"https://api.github.com/users/simon-katz/gists{/gist_id}","starred_url":"https://api.github.com/users/simon-katz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon-katz/subscriptions","organizations_url":"https://api.github.com/users/simon-katz/orgs","repos_url":"https://api.github.com/users/simon-katz/repos","events_url":"https://api.github.com/users/simon-katz/events{/privacy}","received_events_url":"https://api.github.com/users/simon-katz/received_events","type":"User","site_admin":false},"created_at":"2015-02-22T10:01:08Z","updated_at":"2015-02-22T10:01:08Z","body":"I'll make `cider-repl--prompt-function` a defcustom.\r\n\r\nRegarding the args to `cider-repl--prompt-function`: I could make the args `(NAMESPACE &REST OPTIONS)`; that would make the simple case unchanged from now and allow options to be added in future. Would that be a good compromise?\r\n\r\n(And looking for some guidance on how to do things... should I make separate commits for each little change, or wrap things up into a single tidy-up commit?)"}}