{"action":"created","issue":{"url":"https://api.github.com/repos/cjlin1/libsvm/issues/33","labels_url":"https://api.github.com/repos/cjlin1/libsvm/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/cjlin1/libsvm/issues/33/comments","events_url":"https://api.github.com/repos/cjlin1/libsvm/issues/33/events","html_url":"https://github.com/cjlin1/libsvm/pull/33","id":76162111,"number":33,"title":"Clean up the makefile","user":{"login":"kousu","id":987487,"avatar_url":"https://avatars.githubusercontent.com/u/987487?v=3","gravatar_id":"","url":"https://api.github.com/users/kousu","html_url":"https://github.com/kousu","followers_url":"https://api.github.com/users/kousu/followers","following_url":"https://api.github.com/users/kousu/following{/other_user}","gists_url":"https://api.github.com/users/kousu/gists{/gist_id}","starred_url":"https://api.github.com/users/kousu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kousu/subscriptions","organizations_url":"https://api.github.com/users/kousu/orgs","repos_url":"https://api.github.com/users/kousu/repos","events_url":"https://api.github.com/users/kousu/events{/privacy}","received_events_url":"https://api.github.com/users/kousu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-13T23:34:31Z","updated_at":"2015-05-13T23:49:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cjlin1/libsvm/pulls/33","html_url":"https://github.com/cjlin1/libsvm/pull/33","diff_url":"https://github.com/cjlin1/libsvm/pull/33.diff","patch_url":"https://github.com/cjlin1/libsvm/pull/33.patch"},"body":"- build the lib by default\r\n- use make's features to get the platform detection out of the shell script\r\n- make the library file a real target: now use 'make libsvm.so.2' instead of 'make lib' (but the latter is still there for backwards compatibility)\r\n- Build the static library\r\n- don't explicitly embed -soname (Linux) or -install_name (OS X); rather, let the platform decide.\r\n  Because of this, the target is built with its final name and then linked to its versioned name, instead of the other way around.\r\nOS X auto-embeds -install_name:\r\n```\r\nsasgradmac:libsvm nguenthe$ otool -L libsvm.dylib\r\nlibsvm.dylib:\r\n\tlibsvm.dylib (compatibility version 0.0.0, current version 0.0.0)\r\n\t/usr/lib/libstdc++.6.dylib (compatibility version 7.0.0, current version 56.0.0)\r\n\t/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 169.3.0)\r\n```\r\nLinux doesn't (but maybe it should??):\r\n```\r\n[kousu@galleon libsvm]$ readelf -d libsvm.so\r\n\r\nDynamic section at offset 0x103d8 contains 27 entries:\r\n  Tag        Type                         Name/Value\r\n 0x0000000000000001 (NEEDED)             Shared library: [libstdc++.so.6]\r\n 0x0000000000000001 (NEEDED)             Shared library: [libm.so.6]\r\n 0x0000000000000001 (NEEDED)             Shared library: [libgcc_s.so.1]\r\n 0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]\r\n 0x000000000000000c (INIT)               0x2f18\r\n 0x000000000000000d (FINI)               0xe728\r\n 0x0000000000000019 (INIT_ARRAY)         0x2100c0\r\n 0x000000000000001b (INIT_ARRAYSZ)       8 (bytes)\r\n 0x000000000000001a (FINI_ARRAY)         0x2100c8\r\n 0x000000000000001c (FINI_ARRAYSZ)       8 (bytes)\r\n 0x000000006ffffef5 (GNU_HASH)           0x1b8\r\n 0x0000000000000005 (STRTAB)             0x13c0\r\n 0x0000000000000006 (SYMTAB)             0x568\r\n 0x000000000000000a (STRSZ)              2742 (bytes)\r\n 0x000000000000000b (SYMENT)             24 (bytes)\r\n 0x0000000000000003 (PLTGOT)             0x210658\r\n 0x0000000000000002 (PLTRELSZ)           1632 (bytes)\r\n 0x0000000000000014 (PLTREL)             RELA\r\n 0x0000000000000017 (JMPREL)             0x28b8\r\n 0x0000000000000007 (RELA)               0x2048\r\n 0x0000000000000008 (RELASZ)             2160 (bytes)\r\n 0x0000000000000009 (RELAENT)            24 (bytes)\r\n 0x000000006ffffffe (VERNEED)            0x1fa8\r\n 0x000000006fffffff (VERNEEDNUM)         4\r\n 0x000000006ffffff0 (VERSYM)             0x1e76\r\n 0x000000006ffffff9 (RELACOUNT)          14\r\n 0x0000000000000000 (NULL)               0x0\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/cjlin1/libsvm/issues/comments/101851701","html_url":"https://github.com/cjlin1/libsvm/pull/33#issuecomment-101851701","issue_url":"https://api.github.com/repos/cjlin1/libsvm/issues/33","id":101851701,"user":{"login":"kousu","id":987487,"avatar_url":"https://avatars.githubusercontent.com/u/987487?v=3","gravatar_id":"","url":"https://api.github.com/users/kousu","html_url":"https://github.com/kousu","followers_url":"https://api.github.com/users/kousu/followers","following_url":"https://api.github.com/users/kousu/following{/other_user}","gists_url":"https://api.github.com/users/kousu/gists{/gist_id}","starred_url":"https://api.github.com/users/kousu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kousu/subscriptions","organizations_url":"https://api.github.com/users/kousu/orgs","repos_url":"https://api.github.com/users/kousu/repos","events_url":"https://api.github.com/users/kousu/events{/privacy}","received_events_url":"https://api.github.com/users/kousu/received_events","type":"User","site_admin":false},"created_at":"2015-05-13T23:49:13Z","updated_at":"2015-05-13T23:49:13Z","body":"I am not entirely sold on the idea of removing -soname, but the other changes are important, especially for packagers."}}