{"action":"created","comment":{"url":"https://api.github.com/repos/openSUSE/osem/pulls/comments/37742932","id":37742932,"diff_hunk":"@@ -13,17 +13,32 @@\n         %ul.nav.navbar-nav#splash-nav\n           = content_for :splash_nav\n       -if user_signed_in?\n-        %ul.nav.navbar-nav.navbar-right\n-          %li.dropdown\n-            %a.dropdown-toggle{\"data-toggle\" => \"dropdown\", :href => \"#\", id: \"current-user-detail\"}\n-              - if not current_user.name.blank?\n-                #{current_user.name}\n-              -else\n-                #{current_user.email}\n-              = image_tag(current_user.gravatar_url(size: '18'), title: \"Yo #{current_user.name}!\", :alt => '')\n-              %b.caret\n-            %ul.dropdown-menu\n-              = render 'layouts/user_menu'\n+        .btn-group.pull-right\n+          %ul.nav.navbar-nav.navbar-right\n+            %li.dropdown\n+              %a.dropdown-toggle{\"data-toggle\" => \"dropdown\", :href => \"#\", id: \"current-user-detail\"}\n+                - if not current_user.name.blank?\n+                  #{current_user.name}\n+                -else\n+                  #{current_user.email}\n+                = image_tag(current_user.gravatar_url(size: '18'), title: \"Yo #{current_user.name}!\", :alt => '')\n+                %b.caret\n+              %ul.dropdown-menu\n+                = render 'layouts/user_menu'\n+          - if can? :manage, Conference","path":"app/views/layouts/_navigation.html.haml","position":27,"original_position":27,"commit_id":"38e8be8793dd9eb4045bd60c471cbdc9c0654f0d","original_commit_id":"38e8be8793dd9eb4045bd60c471cbdc9c0654f0d","user":{"login":"differentreality","id":4322737,"avatar_url":"https://avatars.githubusercontent.com/u/4322737?v=3","gravatar_id":"","url":"https://api.github.com/users/differentreality","html_url":"https://github.com/differentreality","followers_url":"https://api.github.com/users/differentreality/followers","following_url":"https://api.github.com/users/differentreality/following{/other_user}","gists_url":"https://api.github.com/users/differentreality/gists{/gist_id}","starred_url":"https://api.github.com/users/differentreality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/differentreality/subscriptions","organizations_url":"https://api.github.com/users/differentreality/orgs","repos_url":"https://api.github.com/users/differentreality/repos","events_url":"https://api.github.com/users/differentreality/events{/privacy}","received_events_url":"https://api.github.com/users/differentreality/received_events","type":"User","site_admin":false},"body":"Yes, there is a cfp role too.\r\n\r\nBased on the changes in models/ability.rb we want users with the role **organizer** and the role **cfp** to be able to manage comments. Is that right @raluka ?\r\n\r\n\"if can? :manage, Conference\" means *if the user can manage some conference (any conference)*. That makes sense to cover the users with the role **organizer** but not the ones with the **cfp** role.\r\n\r\nMoreover roles' abilities may change eventually, and this statement depends on the roles that the organizer or a cfp team member has. But what we really care about here is if the user can manage comments, right @raluka ? (regardless of the user's role or ability to manage or not manage a conference)\r\nSo I would suggest to check about that:\r\n- if can? :manage, Comment\r\n\r\nI also have concerns about the **manage** ability.\r\nIsn't this reallly about being able to **show** the comments? Just because you get the notification and you can see the comment, it doesn't necessarily mean you can delete the comment or edit the comment or even create a new comment. But this is something we can work on afterworks too, as it doesn't directly affect any operation in OSEM.","created_at":"2015-08-24T11:50:31Z","updated_at":"2015-08-24T11:50:31Z","html_url":"https://github.com/openSUSE/osem/pull/699#discussion_r37742932","pull_request_url":"https://api.github.com/repos/openSUSE/osem/pulls/699","_links":{"self":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/comments/37742932"},"html":{"href":"https://github.com/openSUSE/osem/pull/699#discussion_r37742932"},"pull_request":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/699"}}},"pull_request":{"url":"https://api.github.com/repos/openSUSE/osem/pulls/699","id":40677731,"html_url":"https://github.com/openSUSE/osem/pull/699","diff_url":"https://github.com/openSUSE/osem/pull/699.diff","patch_url":"https://github.com/openSUSE/osem/pull/699.patch","issue_url":"https://api.github.com/repos/openSUSE/osem/issues/699","number":699,"state":"open","locked":false,"title":"comment notification","user":{"login":"raluka","id":4012836,"avatar_url":"https://avatars.githubusercontent.com/u/4012836?v=3","gravatar_id":"","url":"https://api.github.com/users/raluka","html_url":"https://github.com/raluka","followers_url":"https://api.github.com/users/raluka/followers","following_url":"https://api.github.com/users/raluka/following{/other_user}","gists_url":"https://api.github.com/users/raluka/gists{/gist_id}","starred_url":"https://api.github.com/users/raluka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raluka/subscriptions","organizations_url":"https://api.github.com/users/raluka/orgs","repos_url":"https://api.github.com/users/raluka/repos","events_url":"https://api.github.com/users/raluka/events{/privacy}","received_events_url":"https://api.github.com/users/raluka/received_events","type":"User","site_admin":false},"body":"Sending comment notification to specific users. Please give us your opinion.","created_at":"2015-07-23T14:28:28Z","updated_at":"2015-08-24T11:50:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"868a31d393bb410b605db39d90cbe6c4c5e5fb08","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openSUSE/osem/pulls/699/commits","review_comments_url":"https://api.github.com/repos/openSUSE/osem/pulls/699/comments","review_comment_url":"https://api.github.com/repos/openSUSE/osem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openSUSE/osem/issues/699/comments","statuses_url":"https://api.github.com/repos/openSUSE/osem/statuses/38e8be8793dd9eb4045bd60c471cbdc9c0654f0d","head":{"label":"raluka:view_comment_notification","ref":"view_comment_notification","sha":"38e8be8793dd9eb4045bd60c471cbdc9c0654f0d","user":{"login":"raluka","id":4012836,"avatar_url":"https://avatars.githubusercontent.com/u/4012836?v=3","gravatar_id":"","url":"https://api.github.com/users/raluka","html_url":"https://github.com/raluka","followers_url":"https://api.github.com/users/raluka/followers","following_url":"https://api.github.com/users/raluka/following{/other_user}","gists_url":"https://api.github.com/users/raluka/gists{/gist_id}","starred_url":"https://api.github.com/users/raluka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raluka/subscriptions","organizations_url":"https://api.github.com/users/raluka/orgs","repos_url":"https://api.github.com/users/raluka/repos","events_url":"https://api.github.com/users/raluka/events{/privacy}","received_events_url":"https://api.github.com/users/raluka/received_events","type":"User","site_admin":false},"repo":{"id":38361509,"name":"osem","full_name":"raluka/osem","owner":{"login":"raluka","id":4012836,"avatar_url":"https://avatars.githubusercontent.com/u/4012836?v=3","gravatar_id":"","url":"https://api.github.com/users/raluka","html_url":"https://github.com/raluka","followers_url":"https://api.github.com/users/raluka/followers","following_url":"https://api.github.com/users/raluka/following{/other_user}","gists_url":"https://api.github.com/users/raluka/gists{/gist_id}","starred_url":"https://api.github.com/users/raluka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raluka/subscriptions","organizations_url":"https://api.github.com/users/raluka/orgs","repos_url":"https://api.github.com/users/raluka/repos","events_url":"https://api.github.com/users/raluka/events{/privacy}","received_events_url":"https://api.github.com/users/raluka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/raluka/osem","description":"Open Source Event Manager. An event management tool tailored to Free and Open Source Software conferences.","fork":true,"url":"https://api.github.com/repos/raluka/osem","forks_url":"https://api.github.com/repos/raluka/osem/forks","keys_url":"https://api.github.com/repos/raluka/osem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raluka/osem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raluka/osem/teams","hooks_url":"https://api.github.com/repos/raluka/osem/hooks","issue_events_url":"https://api.github.com/repos/raluka/osem/issues/events{/number}","events_url":"https://api.github.com/repos/raluka/osem/events","assignees_url":"https://api.github.com/repos/raluka/osem/assignees{/user}","branches_url":"https://api.github.com/repos/raluka/osem/branches{/branch}","tags_url":"https://api.github.com/repos/raluka/osem/tags","blobs_url":"https://api.github.com/repos/raluka/osem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raluka/osem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raluka/osem/git/refs{/sha}","trees_url":"https://api.github.com/repos/raluka/osem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raluka/osem/statuses/{sha}","languages_url":"https://api.github.com/repos/raluka/osem/languages","stargazers_url":"https://api.github.com/repos/raluka/osem/stargazers","contributors_url":"https://api.github.com/repos/raluka/osem/contributors","subscribers_url":"https://api.github.com/repos/raluka/osem/subscribers","subscription_url":"https://api.github.com/repos/raluka/osem/subscription","commits_url":"https://api.github.com/repos/raluka/osem/commits{/sha}","git_commits_url":"https://api.github.com/repos/raluka/osem/git/commits{/sha}","comments_url":"https://api.github.com/repos/raluka/osem/comments{/number}","issue_comment_url":"https://api.github.com/repos/raluka/osem/issues/comments{/number}","contents_url":"https://api.github.com/repos/raluka/osem/contents/{+path}","compare_url":"https://api.github.com/repos/raluka/osem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raluka/osem/merges","archive_url":"https://api.github.com/repos/raluka/osem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raluka/osem/downloads","issues_url":"https://api.github.com/repos/raluka/osem/issues{/number}","pulls_url":"https://api.github.com/repos/raluka/osem/pulls{/number}","milestones_url":"https://api.github.com/repos/raluka/osem/milestones{/number}","notifications_url":"https://api.github.com/repos/raluka/osem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raluka/osem/labels{/name}","releases_url":"https://api.github.com/repos/raluka/osem/releases{/id}","created_at":"2015-07-01T09:14:23Z","updated_at":"2015-07-14T16:09:24Z","pushed_at":"2015-08-24T10:55:16Z","git_url":"git://github.com/raluka/osem.git","ssh_url":"git@github.com:raluka/osem.git","clone_url":"https://github.com/raluka/osem.git","svn_url":"https://github.com/raluka/osem","homepage":"http://osem.io","size":20591,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openSUSE:master","ref":"master","sha":"c2af760baf5f1f2b4a4d29b0870f59d58e17be14","user":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars.githubusercontent.com/u/623819?v=3","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":5911225,"name":"osem","full_name":"openSUSE/osem","owner":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars.githubusercontent.com/u/623819?v=3","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openSUSE/osem","description":"Open Source Event Manager. An event management tool tailored to Free and Open Source Software conferences.","fork":false,"url":"https://api.github.com/repos/openSUSE/osem","forks_url":"https://api.github.com/repos/openSUSE/osem/forks","keys_url":"https://api.github.com/repos/openSUSE/osem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openSUSE/osem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openSUSE/osem/teams","hooks_url":"https://api.github.com/repos/openSUSE/osem/hooks","issue_events_url":"https://api.github.com/repos/openSUSE/osem/issues/events{/number}","events_url":"https://api.github.com/repos/openSUSE/osem/events","assignees_url":"https://api.github.com/repos/openSUSE/osem/assignees{/user}","branches_url":"https://api.github.com/repos/openSUSE/osem/branches{/branch}","tags_url":"https://api.github.com/repos/openSUSE/osem/tags","blobs_url":"https://api.github.com/repos/openSUSE/osem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openSUSE/osem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openSUSE/osem/git/refs{/sha}","trees_url":"https://api.github.com/repos/openSUSE/osem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openSUSE/osem/statuses/{sha}","languages_url":"https://api.github.com/repos/openSUSE/osem/languages","stargazers_url":"https://api.github.com/repos/openSUSE/osem/stargazers","contributors_url":"https://api.github.com/repos/openSUSE/osem/contributors","subscribers_url":"https://api.github.com/repos/openSUSE/osem/subscribers","subscription_url":"https://api.github.com/repos/openSUSE/osem/subscription","commits_url":"https://api.github.com/repos/openSUSE/osem/commits{/sha}","git_commits_url":"https://api.github.com/repos/openSUSE/osem/git/commits{/sha}","comments_url":"https://api.github.com/repos/openSUSE/osem/comments{/number}","issue_comment_url":"https://api.github.com/repos/openSUSE/osem/issues/comments{/number}","contents_url":"https://api.github.com/repos/openSUSE/osem/contents/{+path}","compare_url":"https://api.github.com/repos/openSUSE/osem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openSUSE/osem/merges","archive_url":"https://api.github.com/repos/openSUSE/osem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openSUSE/osem/downloads","issues_url":"https://api.github.com/repos/openSUSE/osem/issues{/number}","pulls_url":"https://api.github.com/repos/openSUSE/osem/pulls{/number}","milestones_url":"https://api.github.com/repos/openSUSE/osem/milestones{/number}","notifications_url":"https://api.github.com/repos/openSUSE/osem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openSUSE/osem/labels{/name}","releases_url":"https://api.github.com/repos/openSUSE/osem/releases{/id}","created_at":"2012-09-22T07:40:18Z","updated_at":"2015-08-18T16:53:53Z","pushed_at":"2015-08-24T11:12:28Z","git_url":"git://github.com/openSUSE/osem.git","ssh_url":"git@github.com:openSUSE/osem.git","clone_url":"https://github.com/openSUSE/osem.git","svn_url":"https://github.com/openSUSE/osem","homepage":"http://osem.io","size":24557,"stargazers_count":67,"watchers_count":67,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":54,"mirror_url":null,"open_issues_count":87,"forks":54,"open_issues":87,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/699"},"html":{"href":"https://github.com/openSUSE/osem/pull/699"},"issue":{"href":"https://api.github.com/repos/openSUSE/osem/issues/699"},"comments":{"href":"https://api.github.com/repos/openSUSE/osem/issues/699/comments"},"review_comments":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/699/comments"},"review_comment":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/699/commits"},"statuses":{"href":"https://api.github.com/repos/openSUSE/osem/statuses/38e8be8793dd9eb4045bd60c471cbdc9c0654f0d"}}}}