{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/13528","labels_url":"https://api.github.com/repos/owncloud/core/issues/13528/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/13528/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/13528/events","html_url":"https://github.com/owncloud/core/pull/13528","id":54930237,"number":13528,"title":"Added confirm delete of single file and selected files","user":{"login":"ShamimIslam","id":3057742,"avatar_url":"https://avatars.githubusercontent.com/u/3057742?v=3","gravatar_id":"","url":"https://api.github.com/users/ShamimIslam","html_url":"https://github.com/ShamimIslam","followers_url":"https://api.github.com/users/ShamimIslam/followers","following_url":"https://api.github.com/users/ShamimIslam/following{/other_user}","gists_url":"https://api.github.com/users/ShamimIslam/gists{/gist_id}","starred_url":"https://api.github.com/users/ShamimIslam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShamimIslam/subscriptions","organizations_url":"https://api.github.com/users/ShamimIslam/orgs","repos_url":"https://api.github.com/users/ShamimIslam/repos","events_url":"https://api.github.com/users/ShamimIslam/events{/privacy}","received_events_url":"https://api.github.com/users/ShamimIslam/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/31","labels_url":"https://api.github.com/repos/owncloud/core/milestones/31/labels","id":912160,"number":31,"title":"8.1-next","description":"","creator":{"login":"MorrisJobke","id":245432,"avatar_url":"https://avatars.githubusercontent.com/u/245432?v=3","gravatar_id":"","url":"https://api.github.com/users/MorrisJobke","html_url":"https://github.com/MorrisJobke","followers_url":"https://api.github.com/users/MorrisJobke/followers","following_url":"https://api.github.com/users/MorrisJobke/following{/other_user}","gists_url":"https://api.github.com/users/MorrisJobke/gists{/gist_id}","starred_url":"https://api.github.com/users/MorrisJobke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorrisJobke/subscriptions","organizations_url":"https://api.github.com/users/MorrisJobke/orgs","repos_url":"https://api.github.com/users/MorrisJobke/repos","events_url":"https://api.github.com/users/MorrisJobke/events{/privacy}","received_events_url":"https://api.github.com/users/MorrisJobke/received_events","type":"User","site_admin":false},"open_issues":286,"closed_issues":0,"state":"open","created_at":"2014-12-22T12:04:01Z","updated_at":"2015-01-28T11:45:54Z","due_on":"2015-04-02T22:00:00Z","closed_at":null},"comments":8,"created_at":"2015-01-20T19:50:36Z","updated_at":"2015-01-28T11:48:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/13528","html_url":"https://github.com/owncloud/core/pull/13528","diff_url":"https://github.com/owncloud/core/pull/13528.diff","patch_url":"https://github.com/owncloud/core/pull/13528.patch"},"body":"Implements proper delete confirm using OwnCloud tools. Required for large-scale file/users use. Delete icon is next to scroll elevator and is subject to accidental clicking (click on user menu, click on elevator). Delete loses sharing attributes. Restore does not restore sharing. Better to prevent the problem than to create an undo for a simple problem. Alternatively, this option can be turned into configurable feature. Best option would be a double push like the Apple Store \"buy\" or the Amazon music buy - first click primes the action. Second click creates the action. Primed action times out after 5s or some timeout. This is the simple fix. This topic has been discussed a number of times, but the \"undo\" does not resolve the problems that the \"automatic delete\" creates. Until the \"undo\" works correctly, this is the correct solution.\r\n\r\nThis contribution is MIT licensed."},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/71822089","html_url":"https://github.com/owncloud/core/pull/13528#issuecomment-71822089","issue_url":"https://api.github.com/repos/owncloud/core/issues/13528","id":71822089,"user":{"login":"jancborchardt","id":925062,"avatar_url":"https://avatars.githubusercontent.com/u/925062?v=3","gravatar_id":"","url":"https://api.github.com/users/jancborchardt","html_url":"https://github.com/jancborchardt","followers_url":"https://api.github.com/users/jancborchardt/followers","following_url":"https://api.github.com/users/jancborchardt/following{/other_user}","gists_url":"https://api.github.com/users/jancborchardt/gists{/gist_id}","starred_url":"https://api.github.com/users/jancborchardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jancborchardt/subscriptions","organizations_url":"https://api.github.com/users/jancborchardt/orgs","repos_url":"https://api.github.com/users/jancborchardt/repos","events_url":"https://api.github.com/users/jancborchardt/events{/privacy}","received_events_url":"https://api.github.com/users/jancborchardt/received_events","type":"User","site_admin":false},"created_at":"2015-01-28T11:48:20Z","updated_at":"2015-01-28T11:48:20Z","body":"@ShamimIslam And about the accidental clicking because of the delete icon position: Totally agree on that as well!\r\n\r\nWe need to put the file actions (except sharing) in an extra dropdown in the row. The issue for that is https://github.com/owncloud/core/issues/12081\r\n\r\nThat will also take care of that problem, and do for way better mobile usability. Ok?"}}