{"action":"closed","number":3030,"pull_request":{"url":"https://api.github.com/repos/emberjs/data/pulls/3030","id":34213545,"html_url":"https://github.com/emberjs/data/pull/3030","diff_url":"https://github.com/emberjs/data/pull/3030.diff","patch_url":"https://github.com/emberjs/data/pull/3030.patch","issue_url":"https://api.github.com/repos/emberjs/data/issues/3030","number":3030,"state":"closed","locked":false,"title":"ActiveModelAdapter camelizes keys for errors on 422","user":{"login":"bdvholmes","id":831043,"avatar_url":"https://avatars.githubusercontent.com/u/831043?v=3","gravatar_id":"","url":"https://api.github.com/users/bdvholmes","html_url":"https://github.com/bdvholmes","followers_url":"https://api.github.com/users/bdvholmes/followers","following_url":"https://api.github.com/users/bdvholmes/following{/other_user}","gists_url":"https://api.github.com/users/bdvholmes/gists{/gist_id}","starred_url":"https://api.github.com/users/bdvholmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdvholmes/subscriptions","organizations_url":"https://api.github.com/users/bdvholmes/orgs","repos_url":"https://api.github.com/users/bdvholmes/repos","events_url":"https://api.github.com/users/bdvholmes/events{/privacy}","received_events_url":"https://api.github.com/users/bdvholmes/received_events","type":"User","site_admin":false},"body":"Fields are not currently camelized in the model's errors object e.g.\r\n\r\n    pilot.errors.first_name\r\n\r\nshould be\r\n\r\n    pilot.errors.firstName\r\n\r\nThere is already test for this behavior but because of the way `InvalidError` and `Ember.inspect` are implemented the test passes when it shouldn't do.\r\n\r\nActiveModelAdapter now passes the errors hash directly to `InvalidError` as is expected according to the docs. This assumes that the 422 provides JSON of the form\r\n\r\n    {\r\n      errors: {\r\n        first_name: ['is too long']\r\n      }\r\n    }\r\n\r\nas is standard in active model. If `errors` is not present in the JSON response, active model adapter will continue to behave as it did before.","created_at":"2015-04-27T21:42:06Z","updated_at":"2015-04-29T21:56:26Z","closed_at":"2015-04-29T21:56:26Z","merged_at":"2015-04-29T21:56:26Z","merge_commit_sha":"1f70aa6f0e53c47ddc22b0d6ddde4ea2c6373968","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/data/pulls/3030/commits","review_comments_url":"https://api.github.com/repos/emberjs/data/pulls/3030/comments","review_comment_url":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/data/issues/3030/comments","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/c947e254ac6df93bd8b1b836e526fbd7b648f8ba","head":{"label":"bdvholmes:ams_camelized_errors","ref":"ams_camelized_errors","sha":"c947e254ac6df93bd8b1b836e526fbd7b648f8ba","user":{"login":"bdvholmes","id":831043,"avatar_url":"https://avatars.githubusercontent.com/u/831043?v=3","gravatar_id":"","url":"https://api.github.com/users/bdvholmes","html_url":"https://github.com/bdvholmes","followers_url":"https://api.github.com/users/bdvholmes/followers","following_url":"https://api.github.com/users/bdvholmes/following{/other_user}","gists_url":"https://api.github.com/users/bdvholmes/gists{/gist_id}","starred_url":"https://api.github.com/users/bdvholmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdvholmes/subscriptions","organizations_url":"https://api.github.com/users/bdvholmes/orgs","repos_url":"https://api.github.com/users/bdvholmes/repos","events_url":"https://api.github.com/users/bdvholmes/events{/privacy}","received_events_url":"https://api.github.com/users/bdvholmes/received_events","type":"User","site_admin":false},"repo":{"id":34692146,"name":"data","full_name":"bdvholmes/data","owner":{"login":"bdvholmes","id":831043,"avatar_url":"https://avatars.githubusercontent.com/u/831043?v=3","gravatar_id":"","url":"https://api.github.com/users/bdvholmes","html_url":"https://github.com/bdvholmes","followers_url":"https://api.github.com/users/bdvholmes/followers","following_url":"https://api.github.com/users/bdvholmes/following{/other_user}","gists_url":"https://api.github.com/users/bdvholmes/gists{/gist_id}","starred_url":"https://api.github.com/users/bdvholmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdvholmes/subscriptions","organizations_url":"https://api.github.com/users/bdvholmes/orgs","repos_url":"https://api.github.com/users/bdvholmes/repos","events_url":"https://api.github.com/users/bdvholmes/events{/privacy}","received_events_url":"https://api.github.com/users/bdvholmes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bdvholmes/data","description":"A data persistence library for Ember.js.","fork":true,"url":"https://api.github.com/repos/bdvholmes/data","forks_url":"https://api.github.com/repos/bdvholmes/data/forks","keys_url":"https://api.github.com/repos/bdvholmes/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bdvholmes/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bdvholmes/data/teams","hooks_url":"https://api.github.com/repos/bdvholmes/data/hooks","issue_events_url":"https://api.github.com/repos/bdvholmes/data/issues/events{/number}","events_url":"https://api.github.com/repos/bdvholmes/data/events","assignees_url":"https://api.github.com/repos/bdvholmes/data/assignees{/user}","branches_url":"https://api.github.com/repos/bdvholmes/data/branches{/branch}","tags_url":"https://api.github.com/repos/bdvholmes/data/tags","blobs_url":"https://api.github.com/repos/bdvholmes/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bdvholmes/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bdvholmes/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/bdvholmes/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bdvholmes/data/statuses/{sha}","languages_url":"https://api.github.com/repos/bdvholmes/data/languages","stargazers_url":"https://api.github.com/repos/bdvholmes/data/stargazers","contributors_url":"https://api.github.com/repos/bdvholmes/data/contributors","subscribers_url":"https://api.github.com/repos/bdvholmes/data/subscribers","subscription_url":"https://api.github.com/repos/bdvholmes/data/subscription","commits_url":"https://api.github.com/repos/bdvholmes/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/bdvholmes/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/bdvholmes/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/bdvholmes/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/bdvholmes/data/contents/{+path}","compare_url":"https://api.github.com/repos/bdvholmes/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bdvholmes/data/merges","archive_url":"https://api.github.com/repos/bdvholmes/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bdvholmes/data/downloads","issues_url":"https://api.github.com/repos/bdvholmes/data/issues{/number}","pulls_url":"https://api.github.com/repos/bdvholmes/data/pulls{/number}","milestones_url":"https://api.github.com/repos/bdvholmes/data/milestones{/number}","notifications_url":"https://api.github.com/repos/bdvholmes/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bdvholmes/data/labels{/name}","releases_url":"https://api.github.com/repos/bdvholmes/data/releases{/id}","created_at":"2015-04-27T21:26:28Z","updated_at":"2015-04-27T21:26:30Z","pushed_at":"2015-04-27T21:27:08Z","git_url":"git://github.com/bdvholmes/data.git","ssh_url":"git@github.com:bdvholmes/data.git","clone_url":"https://github.com/bdvholmes/data.git","svn_url":"https://github.com/bdvholmes/data","homepage":"","size":26786,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"e77538d95d7ffc2cdbfade6e5e1889c6f2120300","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":3016562,"name":"data","full_name":"emberjs/data","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/data","description":"A data persistence library for Ember.js.","fork":false,"url":"https://api.github.com/repos/emberjs/data","forks_url":"https://api.github.com/repos/emberjs/data/forks","keys_url":"https://api.github.com/repos/emberjs/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/data/teams","hooks_url":"https://api.github.com/repos/emberjs/data/hooks","issue_events_url":"https://api.github.com/repos/emberjs/data/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/data/events","assignees_url":"https://api.github.com/repos/emberjs/data/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/data/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/data/tags","blobs_url":"https://api.github.com/repos/emberjs/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/data/languages","stargazers_url":"https://api.github.com/repos/emberjs/data/stargazers","contributors_url":"https://api.github.com/repos/emberjs/data/contributors","subscribers_url":"https://api.github.com/repos/emberjs/data/subscribers","subscription_url":"https://api.github.com/repos/emberjs/data/subscription","commits_url":"https://api.github.com/repos/emberjs/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/data/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/data/merges","archive_url":"https://api.github.com/repos/emberjs/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/data/downloads","issues_url":"https://api.github.com/repos/emberjs/data/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/data/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/data/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/data/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/data/releases{/id}","created_at":"2011-12-20T01:50:40Z","updated_at":"2015-04-29T21:44:58Z","pushed_at":"2015-04-29T21:56:26Z","git_url":"git://github.com/emberjs/data.git","ssh_url":"git@github.com:emberjs/data.git","clone_url":"https://github.com/emberjs/data.git","svn_url":"https://github.com/emberjs/data","homepage":"","size":26786,"stargazers_count":2338,"watchers_count":2338,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":892,"mirror_url":null,"open_issues_count":271,"forks":892,"open_issues":271,"watchers":2338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/3030"},"html":{"href":"https://github.com/emberjs/data/pull/3030"},"issue":{"href":"https://api.github.com/repos/emberjs/data/issues/3030"},"comments":{"href":"https://api.github.com/repos/emberjs/data/issues/3030/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/data/pulls/3030/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/data/pulls/3030/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/data/statuses/c947e254ac6df93bd8b1b836e526fbd7b648f8ba"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"fivetanley","id":1275021,"avatar_url":"https://avatars.githubusercontent.com/u/1275021?v=3","gravatar_id":"","url":"https://api.github.com/users/fivetanley","html_url":"https://github.com/fivetanley","followers_url":"https://api.github.com/users/fivetanley/followers","following_url":"https://api.github.com/users/fivetanley/following{/other_user}","gists_url":"https://api.github.com/users/fivetanley/gists{/gist_id}","starred_url":"https://api.github.com/users/fivetanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fivetanley/subscriptions","organizations_url":"https://api.github.com/users/fivetanley/orgs","repos_url":"https://api.github.com/users/fivetanley/repos","events_url":"https://api.github.com/users/fivetanley/events{/privacy}","received_events_url":"https://api.github.com/users/fivetanley/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":27,"deletions":3,"changed_files":2}}