{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/esprima/pulls/comments/28609695","id":28609695,"diff_hunk":"@@ -4636,10 +4755,12 @@\n         lookahead = null;\n         state = {\n             allowIn: true,\n+            allowYield: false,\n             labelSet: {},\n             inFunctionBody: false,\n             inIteration: false,\n             inSwitch: false,\n+            isGenerator: false,","path":"esprima.js","position":391,"original_position":391,"commit_id":"6c7c7875d1290b9b9ef80fc88cd686a6f29d826b","original_commit_id":"6c7c7875d1290b9b9ef80fc88cd686a6f29d826b","user":{"login":"jeffmo","id":498293,"avatar_url":"https://avatars.githubusercontent.com/u/498293?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmo","html_url":"https://github.com/jeffmo","followers_url":"https://api.github.com/users/jeffmo/followers","following_url":"https://api.github.com/users/jeffmo/following{/other_user}","gists_url":"https://api.github.com/users/jeffmo/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmo/subscriptions","organizations_url":"https://api.github.com/users/jeffmo/orgs","repos_url":"https://api.github.com/users/jeffmo/repos","events_url":"https://api.github.com/users/jeffmo/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmo/received_events","type":"User","site_admin":false},"body":"same","created_at":"2015-04-17T16:39:32Z","updated_at":"2015-04-17T16:39:32Z","html_url":"https://github.com/jquery/esprima/pull/1158#discussion_r28609695","pull_request_url":"https://api.github.com/repos/jquery/esprima/pulls/1158","_links":{"self":{"href":"https://api.github.com/repos/jquery/esprima/pulls/comments/28609695"},"html":{"href":"https://github.com/jquery/esprima/pull/1158#discussion_r28609695"},"pull_request":{"href":"https://api.github.com/repos/jquery/esprima/pulls/1158"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/esprima/pulls/1158","id":32249515,"html_url":"https://github.com/jquery/esprima/pull/1158","diff_url":"https://github.com/jquery/esprima/pull/1158.diff","patch_url":"https://github.com/jquery/esprima/pull/1158.patch","issue_url":"https://api.github.com/repos/jquery/esprima/issues/1158","number":1158,"state":"open","locked":false,"title":"ES6: Add support for generators","user":{"login":"dhe128","id":472528,"avatar_url":"https://avatars.githubusercontent.com/u/472528?v=3","gravatar_id":"","url":"https://api.github.com/users/dhe128","html_url":"https://github.com/dhe128","followers_url":"https://api.github.com/users/dhe128/followers","following_url":"https://api.github.com/users/dhe128/following{/other_user}","gists_url":"https://api.github.com/users/dhe128/gists{/gist_id}","starred_url":"https://api.github.com/users/dhe128/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhe128/subscriptions","organizations_url":"https://api.github.com/users/dhe128/orgs","repos_url":"https://api.github.com/users/dhe128/repos","events_url":"https://api.github.com/users/dhe128/events{/privacy}","received_events_url":"https://api.github.com/users/dhe128/received_events","type":"User","site_admin":false},"body":"This pull request allows esprima to generate ASTs of generators and yield expressions.\r\n\r\nOne thing I noticed is that yield is reserved in esprima even in non-strict mode. It follows that:\r\n1. There's no need to distinguish BindingIdentifier and BindingIdentifier_Yield\r\n2. There's no need to distinguish x and x_GeneratorParameter, for all productions x. Because except for BindingIdentifier_Yield, _Yield carries enough information so that _GeneratorParameter is not needed.\r\n\r\nThis pull request relies on yield being reserved in non-strict mode. It tracks state.allowYield but not state.isGenerator. It would be great if you can double check that this is the correct approach.\r\n\r\n\r\nThere's no way to produce ClassExpression_Yield and ClassExpression_GeneratorExpression in the spec. So I ignored it.\r\n\r\n\r\n\r\nresolves #1033 \r\n","created_at":"2015-03-30T17:42:54Z","updated_at":"2015-04-17T16:39:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b0848655a7a8e34d53baddef301f0a180e785a1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jquery/esprima/pulls/1158/commits","review_comments_url":"https://api.github.com/repos/jquery/esprima/pulls/1158/comments","review_comment_url":"https://api.github.com/repos/jquery/esprima/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquery/esprima/issues/1158/comments","statuses_url":"https://api.github.com/repos/jquery/esprima/statuses/6c7c7875d1290b9b9ef80fc88cd686a6f29d826b","head":{"label":"dhe128:generator","ref":"generator","sha":"6c7c7875d1290b9b9ef80fc88cd686a6f29d826b","user":{"login":"dhe128","id":472528,"avatar_url":"https://avatars.githubusercontent.com/u/472528?v=3","gravatar_id":"","url":"https://api.github.com/users/dhe128","html_url":"https://github.com/dhe128","followers_url":"https://api.github.com/users/dhe128/followers","following_url":"https://api.github.com/users/dhe128/following{/other_user}","gists_url":"https://api.github.com/users/dhe128/gists{/gist_id}","starred_url":"https://api.github.com/users/dhe128/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhe128/subscriptions","organizations_url":"https://api.github.com/users/dhe128/orgs","repos_url":"https://api.github.com/users/dhe128/repos","events_url":"https://api.github.com/users/dhe128/events{/privacy}","received_events_url":"https://api.github.com/users/dhe128/received_events","type":"User","site_admin":false},"repo":{"id":32353248,"name":"esprima","full_name":"dhe128/esprima","owner":{"login":"dhe128","id":472528,"avatar_url":"https://avatars.githubusercontent.com/u/472528?v=3","gravatar_id":"","url":"https://api.github.com/users/dhe128","html_url":"https://github.com/dhe128","followers_url":"https://api.github.com/users/dhe128/followers","following_url":"https://api.github.com/users/dhe128/following{/other_user}","gists_url":"https://api.github.com/users/dhe128/gists{/gist_id}","starred_url":"https://api.github.com/users/dhe128/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhe128/subscriptions","organizations_url":"https://api.github.com/users/dhe128/orgs","repos_url":"https://api.github.com/users/dhe128/repos","events_url":"https://api.github.com/users/dhe128/events{/privacy}","received_events_url":"https://api.github.com/users/dhe128/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhe128/esprima","description":"ECMAScript parsing infrastructure for multipurpose analysis","fork":true,"url":"https://api.github.com/repos/dhe128/esprima","forks_url":"https://api.github.com/repos/dhe128/esprima/forks","keys_url":"https://api.github.com/repos/dhe128/esprima/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhe128/esprima/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhe128/esprima/teams","hooks_url":"https://api.github.com/repos/dhe128/esprima/hooks","issue_events_url":"https://api.github.com/repos/dhe128/esprima/issues/events{/number}","events_url":"https://api.github.com/repos/dhe128/esprima/events","assignees_url":"https://api.github.com/repos/dhe128/esprima/assignees{/user}","branches_url":"https://api.github.com/repos/dhe128/esprima/branches{/branch}","tags_url":"https://api.github.com/repos/dhe128/esprima/tags","blobs_url":"https://api.github.com/repos/dhe128/esprima/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhe128/esprima/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhe128/esprima/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhe128/esprima/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhe128/esprima/statuses/{sha}","languages_url":"https://api.github.com/repos/dhe128/esprima/languages","stargazers_url":"https://api.github.com/repos/dhe128/esprima/stargazers","contributors_url":"https://api.github.com/repos/dhe128/esprima/contributors","subscribers_url":"https://api.github.com/repos/dhe128/esprima/subscribers","subscription_url":"https://api.github.com/repos/dhe128/esprima/subscription","commits_url":"https://api.github.com/repos/dhe128/esprima/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhe128/esprima/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhe128/esprima/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhe128/esprima/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhe128/esprima/contents/{+path}","compare_url":"https://api.github.com/repos/dhe128/esprima/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhe128/esprima/merges","archive_url":"https://api.github.com/repos/dhe128/esprima/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhe128/esprima/downloads","issues_url":"https://api.github.com/repos/dhe128/esprima/issues{/number}","pulls_url":"https://api.github.com/repos/dhe128/esprima/pulls{/number}","milestones_url":"https://api.github.com/repos/dhe128/esprima/milestones{/number}","notifications_url":"https://api.github.com/repos/dhe128/esprima/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhe128/esprima/labels{/name}","releases_url":"https://api.github.com/repos/dhe128/esprima/releases{/id}","created_at":"2015-03-16T21:11:22Z","updated_at":"2015-03-30T17:19:51Z","pushed_at":"2015-03-30T17:21:13Z","git_url":"git://github.com/dhe128/esprima.git","ssh_url":"git@github.com:dhe128/esprima.git","clone_url":"https://github.com/dhe128/esprima.git","svn_url":"https://github.com/dhe128/esprima","homepage":"http://esprima.org","size":45937,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"dfe21bb67a602ef40a9a98cec029b90431e3f4db","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":2833537,"name":"esprima","full_name":"jquery/esprima","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/esprima","description":"ECMAScript parsing infrastructure for multipurpose analysis","fork":false,"url":"https://api.github.com/repos/jquery/esprima","forks_url":"https://api.github.com/repos/jquery/esprima/forks","keys_url":"https://api.github.com/repos/jquery/esprima/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/esprima/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/esprima/teams","hooks_url":"https://api.github.com/repos/jquery/esprima/hooks","issue_events_url":"https://api.github.com/repos/jquery/esprima/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/esprima/events","assignees_url":"https://api.github.com/repos/jquery/esprima/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/esprima/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/esprima/tags","blobs_url":"https://api.github.com/repos/jquery/esprima/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/esprima/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/esprima/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/esprima/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/esprima/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/esprima/languages","stargazers_url":"https://api.github.com/repos/jquery/esprima/stargazers","contributors_url":"https://api.github.com/repos/jquery/esprima/contributors","subscribers_url":"https://api.github.com/repos/jquery/esprima/subscribers","subscription_url":"https://api.github.com/repos/jquery/esprima/subscription","commits_url":"https://api.github.com/repos/jquery/esprima/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/esprima/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/esprima/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/esprima/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquery/esprima/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/esprima/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/esprima/merges","archive_url":"https://api.github.com/repos/jquery/esprima/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/esprima/downloads","issues_url":"https://api.github.com/repos/jquery/esprima/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/esprima/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/esprima/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/esprima/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/esprima/labels{/name}","releases_url":"https://api.github.com/repos/jquery/esprima/releases{/id}","created_at":"2011-11-23T05:36:43Z","updated_at":"2015-04-17T07:05:52Z","pushed_at":"2015-04-17T13:44:36Z","git_url":"git://github.com/jquery/esprima.git","ssh_url":"git@github.com:jquery/esprima.git","clone_url":"https://github.com/jquery/esprima.git","svn_url":"https://github.com/jquery/esprima","homepage":"http://esprima.org","size":49664,"stargazers_count":2383,"watchers_count":2383,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":397,"mirror_url":null,"open_issues_count":54,"forks":397,"open_issues":54,"watchers":2383,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/esprima/pulls/1158"},"html":{"href":"https://github.com/jquery/esprima/pull/1158"},"issue":{"href":"https://api.github.com/repos/jquery/esprima/issues/1158"},"comments":{"href":"https://api.github.com/repos/jquery/esprima/issues/1158/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/esprima/pulls/1158/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/esprima/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquery/esprima/pulls/1158/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/esprima/statuses/6c7c7875d1290b9b9ef80fc88cd686a6f29d826b"}}}}