{"action":"created","issue":{"url":"https://api.github.com/repos/d5h/ios_yelp/issues/1","labels_url":"https://api.github.com/repos/d5h/ios_yelp/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/d5h/ios_yelp/issues/1/comments","events_url":"https://api.github.com/repos/d5h/ios_yelp/issues/1/events","html_url":"https://github.com/d5h/ios_yelp/issues/1","id":57752183,"number":1,"title":"[Intro to iOS] Yelp","user":{"login":"d5h","id":271529,"avatar_url":"https://avatars.githubusercontent.com/u/271529?v=3","gravatar_id":"","url":"https://api.github.com/users/d5h","html_url":"https://github.com/d5h","followers_url":"https://api.github.com/users/d5h/followers","following_url":"https://api.github.com/users/d5h/following{/other_user}","gists_url":"https://api.github.com/users/d5h/gists{/gist_id}","starred_url":"https://api.github.com/users/d5h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d5h/subscriptions","organizations_url":"https://api.github.com/users/d5h/orgs","repos_url":"https://api.github.com/users/d5h/repos","events_url":"https://api.github.com/users/d5h/events{/privacy}","received_events_url":"https://api.github.com/users/d5h/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-15T23:41:54Z","updated_at":"2015-02-18T21:40:11Z","closed_at":null,"body":"Finished required elements plus some styling.  /cc @codepathreview @codepath\r\n\r\nIf I had more time to spend, I'd like to style the filter table settings more nicely.  I couldn't figure out how Yelp gets the nice table cells in each section, white on gray background, with rounded top and bottom.\r\n\r\nNote that I didn't include every category because people said the long list was slowing down Xcode on the FB page.  It didn't seem like including every category changed the implementation at all.\r\n\r\nThanks for reviewing!"},"comment":{"url":"https://api.github.com/repos/d5h/ios_yelp/issues/comments/74953799","html_url":"https://github.com/d5h/ios_yelp/issues/1#issuecomment-74953799","issue_url":"https://api.github.com/repos/d5h/ios_yelp/issues/1","id":74953799,"user":{"login":"codepathreview","id":7917093,"avatar_url":"https://avatars.githubusercontent.com/u/7917093?v=3","gravatar_id":"","url":"https://api.github.com/users/codepathreview","html_url":"https://github.com/codepathreview","followers_url":"https://api.github.com/users/codepathreview/followers","following_url":"https://api.github.com/users/codepathreview/following{/other_user}","gists_url":"https://api.github.com/users/codepathreview/gists{/gist_id}","starred_url":"https://api.github.com/users/codepathreview/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codepathreview/subscriptions","organizations_url":"https://api.github.com/users/codepathreview/orgs","repos_url":"https://api.github.com/users/codepathreview/repos","events_url":"https://api.github.com/users/codepathreview/events{/privacy}","received_events_url":"https://api.github.com/users/codepathreview/received_events","type":"User","site_admin":false},"created_at":"2015-02-18T21:40:11Z","updated_at":"2015-02-18T21:40:11Z","body":":+1: nice work. The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints. For each point in the homework feedback checklist, I'll either confirm that you're on the right track with the implementation, or I'll provide some feedback:\r\n\r\n* For the restaurant cell, nice work encapsulating the properties into the private class extension.\r\n* Nice work specifying the Auto Layout constraints.\r\n* your dequeueing in `FilterViewController` is great\r\n* Nice work linking the filter model with the controls. See this [popular form library](https://github.com/nicklockwood/FXForms) for an alternative to implementing forms manually.\r\n* Nice work connecting the view controllers via the custom filter delegate. This is a popular pattern for handling events between view controllers.\r\n\r\nThis was a challenging assignment, congrats on completing it successfully!\r\n\r\n-- dirk"}}