{"action":"closed","number":24454,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/24454","id":37047656,"html_url":"https://github.com/saltstack/salt/pull/24454","diff_url":"https://github.com/saltstack/salt/pull/24454.diff","patch_url":"https://github.com/saltstack/salt/pull/24454.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/24454","number":24454,"state":"closed","locked":false,"title":"Strip extraneous newline character added in last environment variable","user":{"login":"rhertzog","id":1013915,"avatar_url":"https://avatars.githubusercontent.com/u/1013915?v=3","gravatar_id":"","url":"https://api.github.com/users/rhertzog","html_url":"https://github.com/rhertzog","followers_url":"https://api.github.com/users/rhertzog/followers","following_url":"https://api.github.com/users/rhertzog/following{/other_user}","gists_url":"https://api.github.com/users/rhertzog/gists{/gist_id}","starred_url":"https://api.github.com/users/rhertzog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhertzog/subscriptions","organizations_url":"https://api.github.com/users/rhertzog/orgs","repos_url":"https://api.github.com/users/rhertzog/repos","events_url":"https://api.github.com/users/rhertzog/events{/privacy}","received_events_url":"https://api.github.com/users/rhertzog/received_events","type":"User","site_admin":false},"body":"The print statement used to dump the environment associated to the 'runas'\r\nuser adds a trailing newline at the end of the string. This newline is\r\nkept and injected in the value of the last environment variable. Most of\r\nthe time, it is innocuous but in some cases it can have serious\r\nconsequences.\r\n\r\nIn my case, the last variable was HOME and the trailing newline broke the\r\ncommand that salt was executing because it was not able to create a file\r\nin the home directory (which was non-existing).\r\n\r\nNOTE: This commit should really be included in the 2015.05 branch too.\r\nI have been bitten by this issue when I upgraded from 2014.07 to 2015.05\r\nso it's a regression for me.","created_at":"2015-06-05T16:31:36Z","updated_at":"2015-06-06T23:15:26Z","closed_at":"2015-06-06T23:15:26Z","merged_at":"2015-06-06T23:15:26Z","merge_commit_sha":"dcec22d9b952f708d286673f3e2b1d9b2432a327","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/24454/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/24454/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/24454/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/b9c950bc2f6e1eb507d28aee2b92480c4011a2e4","head":{"label":"rhertzog:rhertzog-patch-1","ref":"rhertzog-patch-1","sha":"b9c950bc2f6e1eb507d28aee2b92480c4011a2e4","user":{"login":"rhertzog","id":1013915,"avatar_url":"https://avatars.githubusercontent.com/u/1013915?v=3","gravatar_id":"","url":"https://api.github.com/users/rhertzog","html_url":"https://github.com/rhertzog","followers_url":"https://api.github.com/users/rhertzog/followers","following_url":"https://api.github.com/users/rhertzog/following{/other_user}","gists_url":"https://api.github.com/users/rhertzog/gists{/gist_id}","starred_url":"https://api.github.com/users/rhertzog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhertzog/subscriptions","organizations_url":"https://api.github.com/users/rhertzog/orgs","repos_url":"https://api.github.com/users/rhertzog/repos","events_url":"https://api.github.com/users/rhertzog/events{/privacy}","received_events_url":"https://api.github.com/users/rhertzog/received_events","type":"User","site_admin":false},"repo":{"id":36942404,"name":"salt","full_name":"rhertzog/salt","owner":{"login":"rhertzog","id":1013915,"avatar_url":"https://avatars.githubusercontent.com/u/1013915?v=3","gravatar_id":"","url":"https://api.github.com/users/rhertzog","html_url":"https://github.com/rhertzog","followers_url":"https://api.github.com/users/rhertzog/followers","following_url":"https://api.github.com/users/rhertzog/following{/other_user}","gists_url":"https://api.github.com/users/rhertzog/gists{/gist_id}","starred_url":"https://api.github.com/users/rhertzog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhertzog/subscriptions","organizations_url":"https://api.github.com/users/rhertzog/orgs","repos_url":"https://api.github.com/users/rhertzog/repos","events_url":"https://api.github.com/users/rhertzog/events{/privacy}","received_events_url":"https://api.github.com/users/rhertzog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhertzog/salt","description":"Infrastructure automation and management system","fork":true,"url":"https://api.github.com/repos/rhertzog/salt","forks_url":"https://api.github.com/repos/rhertzog/salt/forks","keys_url":"https://api.github.com/repos/rhertzog/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhertzog/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhertzog/salt/teams","hooks_url":"https://api.github.com/repos/rhertzog/salt/hooks","issue_events_url":"https://api.github.com/repos/rhertzog/salt/issues/events{/number}","events_url":"https://api.github.com/repos/rhertzog/salt/events","assignees_url":"https://api.github.com/repos/rhertzog/salt/assignees{/user}","branches_url":"https://api.github.com/repos/rhertzog/salt/branches{/branch}","tags_url":"https://api.github.com/repos/rhertzog/salt/tags","blobs_url":"https://api.github.com/repos/rhertzog/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhertzog/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhertzog/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhertzog/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhertzog/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/rhertzog/salt/languages","stargazers_url":"https://api.github.com/repos/rhertzog/salt/stargazers","contributors_url":"https://api.github.com/repos/rhertzog/salt/contributors","subscribers_url":"https://api.github.com/repos/rhertzog/salt/subscribers","subscription_url":"https://api.github.com/repos/rhertzog/salt/subscription","commits_url":"https://api.github.com/repos/rhertzog/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhertzog/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhertzog/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhertzog/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhertzog/salt/contents/{+path}","compare_url":"https://api.github.com/repos/rhertzog/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhertzog/salt/merges","archive_url":"https://api.github.com/repos/rhertzog/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhertzog/salt/downloads","issues_url":"https://api.github.com/repos/rhertzog/salt/issues{/number}","pulls_url":"https://api.github.com/repos/rhertzog/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/rhertzog/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/rhertzog/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhertzog/salt/labels{/name}","releases_url":"https://api.github.com/repos/rhertzog/salt/releases{/id}","created_at":"2015-06-05T16:12:27Z","updated_at":"2015-06-05T16:32:25Z","pushed_at":"2015-06-05T18:13:53Z","git_url":"git://github.com/rhertzog/salt.git","ssh_url":"git@github.com:rhertzog/salt.git","clone_url":"https://github.com/rhertzog/salt.git","svn_url":"https://github.com/rhertzog/salt","homepage":"saltstack.com","size":109466,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"98608c8a78e205c5de3b58bcdcec2b4442ecd347","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Infrastructure automation and management system","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","created_at":"2011-02-20T20:16:56Z","updated_at":"2015-06-06T21:30:40Z","pushed_at":"2015-06-06T23:15:27Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"saltstack.com","size":221702,"stargazers_count":5259,"watchers_count":5259,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2220,"mirror_url":null,"open_issues_count":2693,"forks":2220,"open_issues":2693,"watchers":5259,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/24454"},"html":{"href":"https://github.com/saltstack/salt/pull/24454"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/24454"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/24454/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/24454/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/24454/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/b9c950bc2f6e1eb507d28aee2b92480c4011a2e4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jfindlay","id":702905,"avatar_url":"https://avatars.githubusercontent.com/u/702905?v=3","gravatar_id":"","url":"https://api.github.com/users/jfindlay","html_url":"https://github.com/jfindlay","followers_url":"https://api.github.com/users/jfindlay/followers","following_url":"https://api.github.com/users/jfindlay/following{/other_user}","gists_url":"https://api.github.com/users/jfindlay/gists{/gist_id}","starred_url":"https://api.github.com/users/jfindlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfindlay/subscriptions","organizations_url":"https://api.github.com/users/jfindlay/orgs","repos_url":"https://api.github.com/users/jfindlay/repos","events_url":"https://api.github.com/users/jfindlay/events{/privacy}","received_events_url":"https://api.github.com/users/jfindlay/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}