{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/41340659","id":41340659,"diff_hunk":"@@ -208,14 +208,15 @@ public void testValidateValueMismatchStructWrongNestedSchema() {\n     @Test\n     public void testPrimitiveEquality() {\n         // Test that primitive types, which only need to consider all the type & metadata fields, handle equality correctly\n-        CopycatSchema s1 = new CopycatSchema(Schema.Type.INT8, false, null, \"name\", 2, \"doc\", null, null, null);\n-        CopycatSchema s2 = new CopycatSchema(Schema.Type.INT8, false, null, \"name\", 2, \"doc\", null, null, null);\n-        CopycatSchema differentType = new CopycatSchema(Schema.Type.INT16, false, null, \"name\", 2, \"doc\", null, null, null);\n-        CopycatSchema differentOptional = new CopycatSchema(Schema.Type.INT8, true, null, \"name\", 2, \"doc\", null, null, null);\n-        CopycatSchema differentDefault = new CopycatSchema(Schema.Type.INT8, false, true, \"name\", 2, \"doc\", null, null, null);\n-        CopycatSchema differentName = new CopycatSchema(Schema.Type.INT8, false, null, \"otherName\", 2, \"doc\", null, null, null);\n-        CopycatSchema differentVersion = new CopycatSchema(Schema.Type.INT8, false, null, \"name\", 4, \"doc\", null, null, null);\n-        CopycatSchema differentDoc = new CopycatSchema(Schema.Type.INT8, false, null, \"name\", 2, \"other doc\", null, null, null);\n+        CopycatSchema s1 = new CopycatSchema(Schema.Type.INT8, false, null, \"name\", 2, \"doc\", null, null, null, null);","path":"copycat/api/src/test/java/org/apache/kafka/copycat/data/CopycatSchemaTest.java","position":12,"original_position":12,"commit_id":"a97ff2f3d9ccce878d34036a8ce4e6ca35cbe08c","original_commit_id":"a97ff2f3d9ccce878d34036a8ce4e6ca35cbe08c","user":{"login":"guozhangwang","id":10729597,"avatar_url":"https://avatars.githubusercontent.com/u/10729597?v=3","gravatar_id":"","url":"https://api.github.com/users/guozhangwang","html_url":"https://github.com/guozhangwang","followers_url":"https://api.github.com/users/guozhangwang/followers","following_url":"https://api.github.com/users/guozhangwang/following{/other_user}","gists_url":"https://api.github.com/users/guozhangwang/gists{/gist_id}","starred_url":"https://api.github.com/users/guozhangwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guozhangwang/subscriptions","organizations_url":"https://api.github.com/users/guozhangwang/orgs","repos_url":"https://api.github.com/users/guozhangwang/repos","events_url":"https://api.github.com/users/guozhangwang/events{/privacy}","received_events_url":"https://api.github.com/users/guozhangwang/received_events","type":"User","site_admin":false},"body":"Could we have additional CopycatSchema constructors that put default field values as null?","created_at":"2015-10-07T00:40:57Z","updated_at":"2015-10-07T00:40:57Z","html_url":"https://github.com/apache/kafka/pull/281#discussion_r41340659","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/281","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/41340659"},"html":{"href":"https://github.com/apache/kafka/pull/281#discussion_r41340659"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/281"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/281","id":46933509,"html_url":"https://github.com/apache/kafka/pull/281","diff_url":"https://github.com/apache/kafka/pull/281.diff","patch_url":"https://github.com/apache/kafka/pull/281.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/281","number":281,"state":"open","locked":false,"title":"KAFKA-2476: Add Decimal, Date, and Timestamp logical types.","user":{"login":"ewencp","id":47366,"avatar_url":"https://avatars.githubusercontent.com/u/47366?v=3","gravatar_id":"","url":"https://api.github.com/users/ewencp","html_url":"https://github.com/ewencp","followers_url":"https://api.github.com/users/ewencp/followers","following_url":"https://api.github.com/users/ewencp/following{/other_user}","gists_url":"https://api.github.com/users/ewencp/gists{/gist_id}","starred_url":"https://api.github.com/users/ewencp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewencp/subscriptions","organizations_url":"https://api.github.com/users/ewencp/orgs","repos_url":"https://api.github.com/users/ewencp/repos","events_url":"https://api.github.com/users/ewencp/events{/privacy}","received_events_url":"https://api.github.com/users/ewencp/received_events","type":"User","site_admin":false},"body":"To support Decimal, this also adds support for schema parameters, which is an\r\nextra set of String key value pairs which provide extra information about the\r\nschema. For Decimal, this is used to encode the scale parameter, which is part\r\nof the schema instead of being passed with every value.","created_at":"2015-10-06T17:38:05Z","updated_at":"2015-10-07T00:40:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d94c56c848f469d501ebaf788ebf7bc4f01068f7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/281/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/281/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/281/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/a97ff2f3d9ccce878d34036a8ce4e6ca35cbe08c","head":{"label":"ewencp:kafka-2476-copycat-logical-types","ref":"kafka-2476-copycat-logical-types","sha":"a97ff2f3d9ccce878d34036a8ce4e6ca35cbe08c","user":{"login":"ewencp","id":47366,"avatar_url":"https://avatars.githubusercontent.com/u/47366?v=3","gravatar_id":"","url":"https://api.github.com/users/ewencp","html_url":"https://github.com/ewencp","followers_url":"https://api.github.com/users/ewencp/followers","following_url":"https://api.github.com/users/ewencp/following{/other_user}","gists_url":"https://api.github.com/users/ewencp/gists{/gist_id}","starred_url":"https://api.github.com/users/ewencp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewencp/subscriptions","organizations_url":"https://api.github.com/users/ewencp/orgs","repos_url":"https://api.github.com/users/ewencp/repos","events_url":"https://api.github.com/users/ewencp/events{/privacy}","received_events_url":"https://api.github.com/users/ewencp/received_events","type":"User","site_admin":false},"repo":{"id":31331021,"name":"kafka","full_name":"ewencp/kafka","owner":{"login":"ewencp","id":47366,"avatar_url":"https://avatars.githubusercontent.com/u/47366?v=3","gravatar_id":"","url":"https://api.github.com/users/ewencp","html_url":"https://github.com/ewencp","followers_url":"https://api.github.com/users/ewencp/followers","following_url":"https://api.github.com/users/ewencp/following{/other_user}","gists_url":"https://api.github.com/users/ewencp/gists{/gist_id}","starred_url":"https://api.github.com/users/ewencp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewencp/subscriptions","organizations_url":"https://api.github.com/users/ewencp/orgs","repos_url":"https://api.github.com/users/ewencp/repos","events_url":"https://api.github.com/users/ewencp/events{/privacy}","received_events_url":"https://api.github.com/users/ewencp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ewencp/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/ewencp/kafka","forks_url":"https://api.github.com/repos/ewencp/kafka/forks","keys_url":"https://api.github.com/repos/ewencp/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ewencp/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ewencp/kafka/teams","hooks_url":"https://api.github.com/repos/ewencp/kafka/hooks","issue_events_url":"https://api.github.com/repos/ewencp/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/ewencp/kafka/events","assignees_url":"https://api.github.com/repos/ewencp/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/ewencp/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/ewencp/kafka/tags","blobs_url":"https://api.github.com/repos/ewencp/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ewencp/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ewencp/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/ewencp/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ewencp/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/ewencp/kafka/languages","stargazers_url":"https://api.github.com/repos/ewencp/kafka/stargazers","contributors_url":"https://api.github.com/repos/ewencp/kafka/contributors","subscribers_url":"https://api.github.com/repos/ewencp/kafka/subscribers","subscription_url":"https://api.github.com/repos/ewencp/kafka/subscription","commits_url":"https://api.github.com/repos/ewencp/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/ewencp/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/ewencp/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/ewencp/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/ewencp/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/ewencp/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ewencp/kafka/merges","archive_url":"https://api.github.com/repos/ewencp/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ewencp/kafka/downloads","issues_url":"https://api.github.com/repos/ewencp/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/ewencp/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/ewencp/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/ewencp/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ewencp/kafka/labels{/name}","releases_url":"https://api.github.com/repos/ewencp/kafka/releases{/id}","created_at":"2015-02-25T19:10:48Z","updated_at":"2015-02-25T19:10:51Z","pushed_at":"2015-10-06T21:57:34Z","git_url":"git://github.com/ewencp/kafka.git","ssh_url":"git@github.com:ewencp/kafka.git","clone_url":"https://github.com/ewencp/kafka.git","svn_url":"https://github.com/ewencp/kafka","homepage":null,"size":22753,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.8.2"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"726e23ef491637e03b0ba90c21992a639dcd158d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","created_at":"2011-08-15T18:06:16Z","updated_at":"2015-10-06T22:33:30Z","pushed_at":"2015-10-06T22:56:02Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":34112,"stargazers_count":2011,"watchers_count":2011,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1203,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":95,"forks":1203,"open_issues":95,"watchers":2011,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/281"},"html":{"href":"https://github.com/apache/kafka/pull/281"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/281"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/281/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/281/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/281/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/a97ff2f3d9ccce878d34036a8ce4e6ca35cbe08c"}}}}