{"action":"created","comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments/37419965","id":37419965,"diff_hunk":"@@ -11397,6 +11775,76 @@ namespace HVACUnitarySystem {\n \t}\n \n \tReal64\n+\tTESIceStorageCoilOutletResidual(\n+\t\tReal64 PartLoadRatio, // compressor cycling ratio (1.0 is continuous, 0.0 is off)\n+\t\tArray1< Real64 > const & Par // data array\n+\t)\n+\t{\n+\n+\t\t// FUNCTION INFORMATION:\n+\t\t//       AUTHOR        Richard Raustad, FSEC\n+\t\t//       DATE WRITTEN   August 2015\n+\t\t//       MODIFIED\n+\t\t//       RE-ENGINEERED\n+\n+\t\t// PURPOSE OF THIS FUNCTION:\n+\t\t// Calculates residual function (desired outlet temp - actual outlet temp)\n+\t\t// Coil output depends on the part load ratio which is being varied to zero the residual.\n+\n+\t\t// METHODOLOGY EMPLOYED:\n+\t\t// Calls SimWatertoAirHP or SimWatertoAirHPSimple to get outlet humidity ratio at the given cycling ratio\n+\t\t// and calculates the residual as defined above\n+\n+\t\t// REFERENCES:\n+\n+\t\t// Using/Aliasing\n+\t\tusing PackagedThermalStorageCoil::SimTESCoil;\n+\n+\t\t// Return value\n+\t\tReal64 Residuum; // residual to be minimized to zero\n+\n+\t\t// Argument array dimensioning\n+\n+\t\t// Locals\n+\t\t// SUBROUTINE ARGUMENT DEFINITIONS:\n+\t\t// Par( 1 ) = double( UnitarySysNum );\n+\t\t// Par( 2 ) = DesOutTemp;\n+\t\t// Par( 3 ) = 0.0; // DesOutHumRat; set to 0 if temp controlled\n+\n+\t\t// FUNCTION PARAMETER DEFINITIONS:\n+\t\t// na\n+\n+\t\t// INTERFACE BLOCK SPECIFICATIONS\n+\t\t// na\n+\n+\t\t// DERIVED TYPE DEFINITIONS\n+\t\t// na\n+\n+\t\t// FUNCTION LOCAL VARIABLE DECLARATIONS:\n+\t\tint UnitarySysNum; // index of this coil\n+\t\tReal64 DesiredOutletTemp; // temperature control point\n+\t\tReal64 DesiredOutletHumRat; // humidity ratio control point\n+\t\tReal64 OutletAirTemp; // outlet air temperature [C]\n+\t\tReal64 OutletAirHumRat; // outlet air humidity ratio [kg/kg]\n+\n+\t\tUnitarySysNum = int( Par( 1 ) );\n+\t\tDesiredOutletTemp = Par( 2 );\n+\t\tDesiredOutletHumRat = Par( 3 );\n+\n+\t\tSimTESCoil( UnitarySystem( UnitarySysNum ).CoolingCoilName, UnitarySystem( UnitarySysNum ).CoolingCoilIndex, UnitarySystem( UnitarySysNum ).FanOpMode, UnitarySystem( UnitarySysNum ).TESOpMode, PartLoadRatio );\n+\n+\t\tif ( DesiredOutletHumRat > 0.0 ) {\n+\t\t\tOutletAirHumRat = Node( UnitarySystem( UnitarySysNum ).CoolCoilOutletNodeNum ).HumRat;\n+\t\t\tResiduum = OutletAirHumRat - DesiredOutletHumRat;","path":"src/EnergyPlus/HVACUnitarySystem.cc","position":1606,"original_position":1606,"commit_id":"bebb641c98b25df7e7d2e4950312670214e10a0f","original_commit_id":"bebb641c98b25df7e7d2e4950312670214e10a0f","user":{"login":"rraustad","id":5778156,"avatar_url":"https://avatars.githubusercontent.com/u/5778156?v=3","gravatar_id":"","url":"https://api.github.com/users/rraustad","html_url":"https://github.com/rraustad","followers_url":"https://api.github.com/users/rraustad/followers","following_url":"https://api.github.com/users/rraustad/following{/other_user}","gists_url":"https://api.github.com/users/rraustad/gists{/gist_id}","starred_url":"https://api.github.com/users/rraustad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rraustad/subscriptions","organizations_url":"https://api.github.com/users/rraustad/orgs","repos_url":"https://api.github.com/users/rraustad/repos","events_url":"https://api.github.com/users/rraustad/events{/privacy}","received_events_url":"https://api.github.com/users/rraustad/received_events","type":"User","site_admin":false},"body":"wondering if this will converge well with a tolerance of 0.001 since the residual is the difference between humidity ratios.","created_at":"2015-08-19T14:25:04Z","updated_at":"2015-08-19T14:25:04Z","html_url":"https://github.com/NREL/EnergyPlus/pull/5107#discussion_r37419965","pull_request_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5107","_links":{"self":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments/37419965"},"html":{"href":"https://github.com/NREL/EnergyPlus/pull/5107#discussion_r37419965"},"pull_request":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5107"}}},"pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5107","id":42483133,"html_url":"https://github.com/NREL/EnergyPlus/pull/5107","diff_url":"https://github.com/NREL/EnergyPlus/pull/5107.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/5107.patch","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5107","number":5107,"state":"open","locked":false,"title":"97215920   fill gaps in hvac components   initial code","user":{"login":"rraustad","id":5778156,"avatar_url":"https://avatars.githubusercontent.com/u/5778156?v=3","gravatar_id":"","url":"https://api.github.com/users/rraustad","html_url":"https://github.com/rraustad","followers_url":"https://api.github.com/users/rraustad/followers","following_url":"https://api.github.com/users/rraustad/following{/other_user}","gists_url":"https://api.github.com/users/rraustad/gists{/gist_id}","starred_url":"https://api.github.com/users/rraustad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rraustad/subscriptions","organizations_url":"https://api.github.com/users/rraustad/orgs","repos_url":"https://api.github.com/users/rraustad/repos","events_url":"https://api.github.com/users/rraustad/events{/privacy}","received_events_url":"https://api.github.com/users/rraustad/received_events","type":"User","site_admin":false},"body":"Ready for review.\r\n\r\n- added Coil:Cooling:DX:SingleSpeed:ThermalStorage and Coil:UserDefined to UnitarySystems\r\n- added Coil:Heating:Electric to fan coil units\r\n- added Fan:ComponentModel to UnitarySystems\r\n- added unit test to call SimUnitarySystem and compare system output to RemainingOutputRequired.\r\n- fixed DataHVACGlobals coil type numbering. WaterCoils had a hard-coded coil type (e.g., cAllCoilTypes(15)). After fixing this, renumbering worked as expected. This will cause merge conflicts in Rongpeng and Bereket's branch.\r\n- fixed one unit test that fails now when it ran before (yet I don't see how it ran before)\r\n- one unit test runs in debugger yet fails in release version (ConfirmUnitarySystemSizingTest). Check if this is the case on CI.\r\n- IO Ref and Eng Ref docs updated\r\n- IDD updated\r\n","created_at":"2015-08-14T18:20:52Z","updated_at":"2015-08-19T14:25:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60fab6eedea6282e58e41127313138da142787cf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5107/commits","review_comments_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5107/comments","review_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5107/comments","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/bebb641c98b25df7e7d2e4950312670214e10a0f","head":{"label":"NREL:97215920---Fill-Gaps-in-HVAC-Components---Initial-Code","ref":"97215920---Fill-Gaps-in-HVAC-Components---Initial-Code","sha":"bebb641c98b25df7e7d2e4950312670214e10a0f","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":14620185,"name":"EnergyPlus","full_name":"NREL/EnergyPlus","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/EnergyPlus","description":"","fork":false,"url":"https://api.github.com/repos/NREL/EnergyPlus","forks_url":"https://api.github.com/repos/NREL/EnergyPlus/forks","keys_url":"https://api.github.com/repos/NREL/EnergyPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/EnergyPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/EnergyPlus/teams","hooks_url":"https://api.github.com/repos/NREL/EnergyPlus/hooks","issue_events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/EnergyPlus/events","assignees_url":"https://api.github.com/repos/NREL/EnergyPlus/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/EnergyPlus/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/EnergyPlus/tags","blobs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/EnergyPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/EnergyPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/EnergyPlus/languages","stargazers_url":"https://api.github.com/repos/NREL/EnergyPlus/stargazers","contributors_url":"https://api.github.com/repos/NREL/EnergyPlus/contributors","subscribers_url":"https://api.github.com/repos/NREL/EnergyPlus/subscribers","subscription_url":"https://api.github.com/repos/NREL/EnergyPlus/subscription","commits_url":"https://api.github.com/repos/NREL/EnergyPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/EnergyPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/EnergyPlus/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/EnergyPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/EnergyPlus/merges","archive_url":"https://api.github.com/repos/NREL/EnergyPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/EnergyPlus/downloads","issues_url":"https://api.github.com/repos/NREL/EnergyPlus/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/EnergyPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/labels{/name}","releases_url":"https://api.github.com/repos/NREL/EnergyPlus/releases{/id}","created_at":"2013-11-22T14:47:34Z","updated_at":"2015-08-03T15:15:40Z","pushed_at":"2015-08-19T14:07:04Z","git_url":"git://github.com/NREL/EnergyPlus.git","ssh_url":"git@github.com:NREL/EnergyPlus.git","clone_url":"https://github.com/NREL/EnergyPlus.git","svn_url":"https://github.com/NREL/EnergyPlus","homepage":null,"size":430684,"stargazers_count":58,"watchers_count":58,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":43,"mirror_url":null,"open_issues_count":423,"forks":43,"open_issues":423,"watchers":58,"default_branch":"develop"}},"base":{"label":"NREL:develop","ref":"develop","sha":"1bf3863c8072694ba1b5566e8fca0cc0ebbcfa0e","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":14620185,"name":"EnergyPlus","full_name":"NREL/EnergyPlus","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/EnergyPlus","description":"","fork":false,"url":"https://api.github.com/repos/NREL/EnergyPlus","forks_url":"https://api.github.com/repos/NREL/EnergyPlus/forks","keys_url":"https://api.github.com/repos/NREL/EnergyPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/EnergyPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/EnergyPlus/teams","hooks_url":"https://api.github.com/repos/NREL/EnergyPlus/hooks","issue_events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/EnergyPlus/events","assignees_url":"https://api.github.com/repos/NREL/EnergyPlus/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/EnergyPlus/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/EnergyPlus/tags","blobs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/EnergyPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/EnergyPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/EnergyPlus/languages","stargazers_url":"https://api.github.com/repos/NREL/EnergyPlus/stargazers","contributors_url":"https://api.github.com/repos/NREL/EnergyPlus/contributors","subscribers_url":"https://api.github.com/repos/NREL/EnergyPlus/subscribers","subscription_url":"https://api.github.com/repos/NREL/EnergyPlus/subscription","commits_url":"https://api.github.com/repos/NREL/EnergyPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/EnergyPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/EnergyPlus/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/EnergyPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/EnergyPlus/merges","archive_url":"https://api.github.com/repos/NREL/EnergyPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/EnergyPlus/downloads","issues_url":"https://api.github.com/repos/NREL/EnergyPlus/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/EnergyPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/labels{/name}","releases_url":"https://api.github.com/repos/NREL/EnergyPlus/releases{/id}","created_at":"2013-11-22T14:47:34Z","updated_at":"2015-08-03T15:15:40Z","pushed_at":"2015-08-19T14:07:04Z","git_url":"git://github.com/NREL/EnergyPlus.git","ssh_url":"git@github.com:NREL/EnergyPlus.git","clone_url":"https://github.com/NREL/EnergyPlus.git","svn_url":"https://github.com/NREL/EnergyPlus","homepage":null,"size":430684,"stargazers_count":58,"watchers_count":58,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":43,"mirror_url":null,"open_issues_count":423,"forks":43,"open_issues":423,"watchers":58,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5107"},"html":{"href":"https://github.com/NREL/EnergyPlus/pull/5107"},"issue":{"href":"https://api.github.com/repos/NREL/EnergyPlus/issues/5107"},"comments":{"href":"https://api.github.com/repos/NREL/EnergyPlus/issues/5107/comments"},"review_comments":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5107/comments"},"review_comment":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5107/commits"},"statuses":{"href":"https://api.github.com/repos/NREL/EnergyPlus/statuses/bebb641c98b25df7e7d2e4950312670214e10a0f"}}}}