{"action":"created","comment":{"url":"https://api.github.com/repos/cujojs/when/pulls/comments/26631584","id":26631584,"diff_hunk":"@@ -72,16 +72,20 @@ define(function(require) {\n \t\t\t\t// IE8 has console.log and JSON, so we can make a\n \t\t\t\t// reasonably useful warn() from those.\n \t\t\t\t// Credit to webpro (https://github.com/webpro) for this idea\n-\t\t\t\tif (typeof localConsole.log ==='function'\n-\t\t\t\t\t&& typeof JSON !== 'undefined') {\n-\t\t\t\t\tlog = warn = function (x) {\n-\t\t\t\t\t\tif(typeof x !== 'string') {\n+\t\t\t\t// typeof localConsole.log will return 'object' in IE8, so can't test it with === 'function'\n+\t\t\t\t// Since this is more of a corner case for IE8, I'm ok to check it with !== 'undefined' to reduce complexity\n+\t\t\t\tif (typeof localConsole.log !== 'undefined' && typeof JSON !== 'undefined') {","path":"monitor/ConsoleReporter.js","position":10,"original_position":10,"commit_id":"c718c54633bd2c9bb2d047c1d40989c006f399ca","original_commit_id":"c718c54633bd2c9bb2d047c1d40989c006f399ca","user":{"login":"briancavalier","id":90518,"avatar_url":"https://avatars.githubusercontent.com/u/90518?v=3","gravatar_id":"","url":"https://api.github.com/users/briancavalier","html_url":"https://github.com/briancavalier","followers_url":"https://api.github.com/users/briancavalier/followers","following_url":"https://api.github.com/users/briancavalier/following{/other_user}","gists_url":"https://api.github.com/users/briancavalier/gists{/gist_id}","starred_url":"https://api.github.com/users/briancavalier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briancavalier/subscriptions","organizations_url":"https://api.github.com/users/briancavalier/orgs","repos_url":"https://api.github.com/users/briancavalier/repos","events_url":"https://api.github.com/users/briancavalier/events{/privacy}","received_events_url":"https://api.github.com/users/briancavalier/received_events","type":"User","site_admin":false},"body":"@sompylasar Do you have a link to some info on that?  I'm not aware of a case where IE would throw on `console` property access (unless of course, `console` is undefined, which is already covered).  I certainly wouldn't put it past IE doing something crazy :D but I'd like to verify.  Thanks!","created_at":"2015-03-18T01:15:01Z","updated_at":"2015-03-18T01:15:01Z","html_url":"https://github.com/cujojs/when/pull/436#discussion_r26631584","pull_request_url":"https://api.github.com/repos/cujojs/when/pulls/436","_links":{"self":{"href":"https://api.github.com/repos/cujojs/when/pulls/comments/26631584"},"html":{"href":"https://github.com/cujojs/when/pull/436#discussion_r26631584"},"pull_request":{"href":"https://api.github.com/repos/cujojs/when/pulls/436"}}},"pull_request":{"url":"https://api.github.com/repos/cujojs/when/pulls/436","id":31164071,"html_url":"https://github.com/cujojs/when/pull/436","diff_url":"https://github.com/cujojs/when/pull/436.diff","patch_url":"https://github.com/cujojs/when/pull/436.patch","issue_url":"https://api.github.com/repos/cujojs/when/issues/436","number":436,"state":"open","locked":false,"title":"Fix console for ie8","user":{"login":"unional","id":3254987,"avatar_url":"https://avatars.githubusercontent.com/u/3254987?v=3","gravatar_id":"","url":"https://api.github.com/users/unional","html_url":"https://github.com/unional","followers_url":"https://api.github.com/users/unional/followers","following_url":"https://api.github.com/users/unional/following{/other_user}","gists_url":"https://api.github.com/users/unional/gists{/gist_id}","starred_url":"https://api.github.com/users/unional/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unional/subscriptions","organizations_url":"https://api.github.com/users/unional/orgs","repos_url":"https://api.github.com/users/unional/repos","events_url":"https://api.github.com/users/unional/events{/privacy}","received_events_url":"https://api.github.com/users/unional/received_events","type":"User","site_admin":false},"body":"IE8 typeof returns \"object\" instead of \"function\", so checking for \"function\" doesn't work.","created_at":"2015-03-13T21:09:15Z","updated_at":"2015-03-18T01:15:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f02781a2b005a251942fa60352f478c5c20c8dcc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cujojs/when/pulls/436/commits","review_comments_url":"https://api.github.com/repos/cujojs/when/pulls/436/comments","review_comment_url":"https://api.github.com/repos/cujojs/when/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cujojs/when/issues/436/comments","statuses_url":"https://api.github.com/repos/cujojs/when/statuses/c718c54633bd2c9bb2d047c1d40989c006f399ca","head":{"label":"unional:master","ref":"master","sha":"c718c54633bd2c9bb2d047c1d40989c006f399ca","user":{"login":"unional","id":3254987,"avatar_url":"https://avatars.githubusercontent.com/u/3254987?v=3","gravatar_id":"","url":"https://api.github.com/users/unional","html_url":"https://github.com/unional","followers_url":"https://api.github.com/users/unional/followers","following_url":"https://api.github.com/users/unional/following{/other_user}","gists_url":"https://api.github.com/users/unional/gists{/gist_id}","starred_url":"https://api.github.com/users/unional/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unional/subscriptions","organizations_url":"https://api.github.com/users/unional/orgs","repos_url":"https://api.github.com/users/unional/repos","events_url":"https://api.github.com/users/unional/events{/privacy}","received_events_url":"https://api.github.com/users/unional/received_events","type":"User","site_admin":false},"repo":{"id":32180918,"name":"when","full_name":"unional/when","owner":{"login":"unional","id":3254987,"avatar_url":"https://avatars.githubusercontent.com/u/3254987?v=3","gravatar_id":"","url":"https://api.github.com/users/unional","html_url":"https://github.com/unional","followers_url":"https://api.github.com/users/unional/followers","following_url":"https://api.github.com/users/unional/following{/other_user}","gists_url":"https://api.github.com/users/unional/gists{/gist_id}","starred_url":"https://api.github.com/users/unional/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unional/subscriptions","organizations_url":"https://api.github.com/users/unional/orgs","repos_url":"https://api.github.com/users/unional/repos","events_url":"https://api.github.com/users/unional/events{/privacy}","received_events_url":"https://api.github.com/users/unional/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/unional/when","description":"A solid, fast Promises/A+ and when() implementation, plus other async goodies.","fork":true,"url":"https://api.github.com/repos/unional/when","forks_url":"https://api.github.com/repos/unional/when/forks","keys_url":"https://api.github.com/repos/unional/when/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unional/when/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unional/when/teams","hooks_url":"https://api.github.com/repos/unional/when/hooks","issue_events_url":"https://api.github.com/repos/unional/when/issues/events{/number}","events_url":"https://api.github.com/repos/unional/when/events","assignees_url":"https://api.github.com/repos/unional/when/assignees{/user}","branches_url":"https://api.github.com/repos/unional/when/branches{/branch}","tags_url":"https://api.github.com/repos/unional/when/tags","blobs_url":"https://api.github.com/repos/unional/when/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unional/when/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unional/when/git/refs{/sha}","trees_url":"https://api.github.com/repos/unional/when/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unional/when/statuses/{sha}","languages_url":"https://api.github.com/repos/unional/when/languages","stargazers_url":"https://api.github.com/repos/unional/when/stargazers","contributors_url":"https://api.github.com/repos/unional/when/contributors","subscribers_url":"https://api.github.com/repos/unional/when/subscribers","subscription_url":"https://api.github.com/repos/unional/when/subscription","commits_url":"https://api.github.com/repos/unional/when/commits{/sha}","git_commits_url":"https://api.github.com/repos/unional/when/git/commits{/sha}","comments_url":"https://api.github.com/repos/unional/when/comments{/number}","issue_comment_url":"https://api.github.com/repos/unional/when/issues/comments{/number}","contents_url":"https://api.github.com/repos/unional/when/contents/{+path}","compare_url":"https://api.github.com/repos/unional/when/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unional/when/merges","archive_url":"https://api.github.com/repos/unional/when/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unional/when/downloads","issues_url":"https://api.github.com/repos/unional/when/issues{/number}","pulls_url":"https://api.github.com/repos/unional/when/pulls{/number}","milestones_url":"https://api.github.com/repos/unional/when/milestones{/number}","notifications_url":"https://api.github.com/repos/unional/when/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unional/when/labels{/name}","releases_url":"https://api.github.com/repos/unional/when/releases{/id}","created_at":"2015-03-13T21:05:52Z","updated_at":"2015-03-15T22:58:24Z","pushed_at":"2015-03-15T22:58:23Z","git_url":"git://github.com/unional/when.git","ssh_url":"git@github.com:unional/when.git","clone_url":"https://github.com/unional/when.git","svn_url":"https://github.com/unional/when","homepage":"","size":2494,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cujojs:master","ref":"master","sha":"72a06833db1d842a2de70faf30c3d228c13bea64","user":{"login":"cujojs","id":1211266,"avatar_url":"https://avatars.githubusercontent.com/u/1211266?v=3","gravatar_id":"","url":"https://api.github.com/users/cujojs","html_url":"https://github.com/cujojs","followers_url":"https://api.github.com/users/cujojs/followers","following_url":"https://api.github.com/users/cujojs/following{/other_user}","gists_url":"https://api.github.com/users/cujojs/gists{/gist_id}","starred_url":"https://api.github.com/users/cujojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cujojs/subscriptions","organizations_url":"https://api.github.com/users/cujojs/orgs","repos_url":"https://api.github.com/users/cujojs/repos","events_url":"https://api.github.com/users/cujojs/events{/privacy}","received_events_url":"https://api.github.com/users/cujojs/received_events","type":"Organization","site_admin":false},"repo":{"id":1545869,"name":"when","full_name":"cujojs/when","owner":{"login":"cujojs","id":1211266,"avatar_url":"https://avatars.githubusercontent.com/u/1211266?v=3","gravatar_id":"","url":"https://api.github.com/users/cujojs","html_url":"https://github.com/cujojs","followers_url":"https://api.github.com/users/cujojs/followers","following_url":"https://api.github.com/users/cujojs/following{/other_user}","gists_url":"https://api.github.com/users/cujojs/gists{/gist_id}","starred_url":"https://api.github.com/users/cujojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cujojs/subscriptions","organizations_url":"https://api.github.com/users/cujojs/orgs","repos_url":"https://api.github.com/users/cujojs/repos","events_url":"https://api.github.com/users/cujojs/events{/privacy}","received_events_url":"https://api.github.com/users/cujojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cujojs/when","description":"A solid, fast Promises/A+ and when() implementation, plus other async goodies.","fork":false,"url":"https://api.github.com/repos/cujojs/when","forks_url":"https://api.github.com/repos/cujojs/when/forks","keys_url":"https://api.github.com/repos/cujojs/when/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cujojs/when/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cujojs/when/teams","hooks_url":"https://api.github.com/repos/cujojs/when/hooks","issue_events_url":"https://api.github.com/repos/cujojs/when/issues/events{/number}","events_url":"https://api.github.com/repos/cujojs/when/events","assignees_url":"https://api.github.com/repos/cujojs/when/assignees{/user}","branches_url":"https://api.github.com/repos/cujojs/when/branches{/branch}","tags_url":"https://api.github.com/repos/cujojs/when/tags","blobs_url":"https://api.github.com/repos/cujojs/when/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cujojs/when/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cujojs/when/git/refs{/sha}","trees_url":"https://api.github.com/repos/cujojs/when/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cujojs/when/statuses/{sha}","languages_url":"https://api.github.com/repos/cujojs/when/languages","stargazers_url":"https://api.github.com/repos/cujojs/when/stargazers","contributors_url":"https://api.github.com/repos/cujojs/when/contributors","subscribers_url":"https://api.github.com/repos/cujojs/when/subscribers","subscription_url":"https://api.github.com/repos/cujojs/when/subscription","commits_url":"https://api.github.com/repos/cujojs/when/commits{/sha}","git_commits_url":"https://api.github.com/repos/cujojs/when/git/commits{/sha}","comments_url":"https://api.github.com/repos/cujojs/when/comments{/number}","issue_comment_url":"https://api.github.com/repos/cujojs/when/issues/comments{/number}","contents_url":"https://api.github.com/repos/cujojs/when/contents/{+path}","compare_url":"https://api.github.com/repos/cujojs/when/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cujojs/when/merges","archive_url":"https://api.github.com/repos/cujojs/when/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cujojs/when/downloads","issues_url":"https://api.github.com/repos/cujojs/when/issues{/number}","pulls_url":"https://api.github.com/repos/cujojs/when/pulls{/number}","milestones_url":"https://api.github.com/repos/cujojs/when/milestones{/number}","notifications_url":"https://api.github.com/repos/cujojs/when/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cujojs/when/labels{/name}","releases_url":"https://api.github.com/repos/cujojs/when/releases{/id}","created_at":"2011-03-30T11:52:09Z","updated_at":"2015-03-17T02:07:17Z","pushed_at":"2015-03-12T12:49:13Z","git_url":"git://github.com/cujojs/when.git","ssh_url":"git@github.com:cujojs/when.git","clone_url":"https://github.com/cujojs/when.git","svn_url":"https://github.com/cujojs/when","homepage":"","size":6497,"stargazers_count":2309,"watchers_count":2309,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":265,"mirror_url":null,"open_issues_count":43,"forks":265,"open_issues":43,"watchers":2309,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cujojs/when/pulls/436"},"html":{"href":"https://github.com/cujojs/when/pull/436"},"issue":{"href":"https://api.github.com/repos/cujojs/when/issues/436"},"comments":{"href":"https://api.github.com/repos/cujojs/when/issues/436/comments"},"review_comments":{"href":"https://api.github.com/repos/cujojs/when/pulls/436/comments"},"review_comment":{"href":"https://api.github.com/repos/cujojs/when/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cujojs/when/pulls/436/commits"},"statuses":{"href":"https://api.github.com/repos/cujojs/when/statuses/c718c54633bd2c9bb2d047c1d40989c006f399ca"}}}}