{"action":"opened","number":4697,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/4697","id":45163168,"html_url":"https://github.com/openshift/origin/pull/4697","diff_url":"https://github.com/openshift/origin/pull/4697.diff","patch_url":"https://github.com/openshift/origin/pull/4697.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/4697","number":4697,"state":"open","locked":false,"title":"Fix URL handling of the reverse proxy and add test for it","user":{"login":"burmanm","id":562574,"avatar_url":"https://avatars.githubusercontent.com/u/562574?v=3","gravatar_id":"","url":"https://api.github.com/users/burmanm","html_url":"https://github.com/burmanm","followers_url":"https://api.github.com/users/burmanm/followers","following_url":"https://api.github.com/users/burmanm/following{/other_user}","gists_url":"https://api.github.com/users/burmanm/gists{/gist_id}","starred_url":"https://api.github.com/users/burmanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burmanm/subscriptions","organizations_url":"https://api.github.com/users/burmanm/orgs","repos_url":"https://api.github.com/users/burmanm/repos","events_url":"https://api.github.com/users/burmanm/events{/privacy}","received_events_url":"https://api.github.com/users/burmanm/received_events","type":"User","site_admin":false},"body":"Due to issues noticed when handling Hawkular-Metrics + Heapster deployed to the Openshift, this PR fixes the URL handling to avoid http.NewRequest which uses url.Parse (and breaks %2F). Uses url.Opaque and http.Request.RequestURI instead to pass through an unmodified URL to the backend server.\r\n\r\nAlso a small unit test that verifies the functionality.","created_at":"2015-09-16T12:08:43Z","updated_at":"2015-09-16T12:08:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/4697/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/4697/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/4697/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/3957588466334c432a1e4e617f45b9b597d626c1","head":{"label":"burmanm:2F_path","ref":"2F_path","sha":"3957588466334c432a1e4e617f45b9b597d626c1","user":{"login":"burmanm","id":562574,"avatar_url":"https://avatars.githubusercontent.com/u/562574?v=3","gravatar_id":"","url":"https://api.github.com/users/burmanm","html_url":"https://github.com/burmanm","followers_url":"https://api.github.com/users/burmanm/followers","following_url":"https://api.github.com/users/burmanm/following{/other_user}","gists_url":"https://api.github.com/users/burmanm/gists{/gist_id}","starred_url":"https://api.github.com/users/burmanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burmanm/subscriptions","organizations_url":"https://api.github.com/users/burmanm/orgs","repos_url":"https://api.github.com/users/burmanm/repos","events_url":"https://api.github.com/users/burmanm/events{/privacy}","received_events_url":"https://api.github.com/users/burmanm/received_events","type":"User","site_admin":false},"repo":{"id":29536617,"name":"origin","full_name":"burmanm/origin","owner":{"login":"burmanm","id":562574,"avatar_url":"https://avatars.githubusercontent.com/u/562574?v=3","gravatar_id":"","url":"https://api.github.com/users/burmanm","html_url":"https://github.com/burmanm","followers_url":"https://api.github.com/users/burmanm/followers","following_url":"https://api.github.com/users/burmanm/following{/other_user}","gists_url":"https://api.github.com/users/burmanm/gists{/gist_id}","starred_url":"https://api.github.com/users/burmanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burmanm/subscriptions","organizations_url":"https://api.github.com/users/burmanm/orgs","repos_url":"https://api.github.com/users/burmanm/repos","events_url":"https://api.github.com/users/burmanm/events{/privacy}","received_events_url":"https://api.github.com/users/burmanm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/burmanm/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/burmanm/origin","forks_url":"https://api.github.com/repos/burmanm/origin/forks","keys_url":"https://api.github.com/repos/burmanm/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/burmanm/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/burmanm/origin/teams","hooks_url":"https://api.github.com/repos/burmanm/origin/hooks","issue_events_url":"https://api.github.com/repos/burmanm/origin/issues/events{/number}","events_url":"https://api.github.com/repos/burmanm/origin/events","assignees_url":"https://api.github.com/repos/burmanm/origin/assignees{/user}","branches_url":"https://api.github.com/repos/burmanm/origin/branches{/branch}","tags_url":"https://api.github.com/repos/burmanm/origin/tags","blobs_url":"https://api.github.com/repos/burmanm/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/burmanm/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/burmanm/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/burmanm/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/burmanm/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/burmanm/origin/languages","stargazers_url":"https://api.github.com/repos/burmanm/origin/stargazers","contributors_url":"https://api.github.com/repos/burmanm/origin/contributors","subscribers_url":"https://api.github.com/repos/burmanm/origin/subscribers","subscription_url":"https://api.github.com/repos/burmanm/origin/subscription","commits_url":"https://api.github.com/repos/burmanm/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/burmanm/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/burmanm/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/burmanm/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/burmanm/origin/contents/{+path}","compare_url":"https://api.github.com/repos/burmanm/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/burmanm/origin/merges","archive_url":"https://api.github.com/repos/burmanm/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/burmanm/origin/downloads","issues_url":"https://api.github.com/repos/burmanm/origin/issues{/number}","pulls_url":"https://api.github.com/repos/burmanm/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/burmanm/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/burmanm/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/burmanm/origin/labels{/name}","releases_url":"https://api.github.com/repos/burmanm/origin/releases{/id}","created_at":"2015-01-20T15:29:59Z","updated_at":"2015-01-20T15:30:00Z","pushed_at":"2015-09-16T12:05:37Z","git_url":"git://github.com/burmanm/origin.git","ssh_url":"git@github.com:burmanm/origin.git","clone_url":"https://github.com/burmanm/origin.git","svn_url":"https://github.com/burmanm/origin","homepage":"https://openshift.github.io","size":135779,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"489995cbb508b121222b7884afc6cd134949dd04","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-09-15T16:17:31Z","pushed_at":"2015-09-16T12:08:43Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":222923,"stargazers_count":682,"watchers_count":682,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":411,"mirror_url":null,"open_issues_count":537,"forks":411,"open_issues":537,"watchers":682,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/4697"},"html":{"href":"https://github.com/openshift/origin/pull/4697"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/4697"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/4697/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/4697/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/4697/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/3957588466334c432a1e4e617f45b9b597d626c1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":77,"deletions":11,"changed_files":2}}