{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/Affiliates-Tests/pulls/comments/40585956","id":40585956,"diff_hunk":"@@ -62,49 +37,31 @@ def test_edit_profiles_website(self, mozwebqa, existing_user):\n \n         # update profile website to include a timestamp\n         profile_page.update_profile_website(new_url)\n-        actual_website = profile_page.profile_website\n-\n-        Assert.equal(actual_website, new_url,\n-                     \"update to website on profile edit page. \\\n-                     Expected '%s' but returned '%s'\" %\n-                     (new_url, actual_website))\n+        assert new_url == profile_page.profile_website, 'Website did not update'\n \n         # verify username persists after logging out and then logging back in\n         logged_out = profile_page.logout()\n         home_page = logged_out.login(existing_user['email'], existing_user['password'])\n         profile_page = home_page.click_profile()\n-\n-        actual_website = profile_page.profile_website\n-\n-        Assert.equal(actual_website, new_url,\n-                     \"update to website did not persist after logout. \\\n-                     Expected '%s', but returned '%s'\" %\n-                     (new_url, actual_website))\n+        assert new_url == profile_page.profile_website, 'Website change did not persist after logout'\n \n         # verify user can leave website field empty\n         profile_page.update_profile_website(\"\")\n-        actual_website = profile_page.profile_website\n-\n-        Assert.equal(actual_website, \"\",\n-                     \"user can't set website URL to an empty string. \"\n-                     \"Expected '', returned '%s'\" % actual_website)\n+        assert '' == profile_page.profile_website, 'Blank website was not accepted'\n \n-    @destructive\n     def test_verify_layout_logged_in_user(self, mozwebqa, existing_user):\n         start_page = StartPage(mozwebqa)\n         home_page = start_page.login(existing_user['email'], existing_user['password'])\n         edit_page = home_page.click_profile()\n+        assert edit_page.is_stats_section_visible()","path":"tests/test_profile.py","position":103,"original_position":103,"commit_id":"99d03304fdf6f496a7552ad7dc99b114364b266f","original_commit_id":"99d03304fdf6f496a7552ad7dc99b114364b266f","user":{"login":"bobsilverberg","id":142755,"avatar_url":"https://avatars.githubusercontent.com/u/142755?v=3","gravatar_id":"","url":"https://api.github.com/users/bobsilverberg","html_url":"https://github.com/bobsilverberg","followers_url":"https://api.github.com/users/bobsilverberg/followers","following_url":"https://api.github.com/users/bobsilverberg/following{/other_user}","gists_url":"https://api.github.com/users/bobsilverberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bobsilverberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobsilverberg/subscriptions","organizations_url":"https://api.github.com/users/bobsilverberg/orgs","repos_url":"https://api.github.com/users/bobsilverberg/repos","events_url":"https://api.github.com/users/bobsilverberg/events{/privacy}","received_events_url":"https://api.github.com/users/bobsilverberg/received_events","type":"User","site_admin":false},"body":"I'm not sure we want to address this nit, but I notice that in other cases (e.g., `is_the_current_page` and `is_user_logged_in`) the boolean check functions are properties, but on this page all of these `is_x` checks are not.","created_at":"2015-09-28T18:17:30Z","updated_at":"2015-09-28T18:17:30Z","html_url":"https://github.com/mozilla/Affiliates-Tests/pull/130#discussion_r40585956","pull_request_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/pulls/130","_links":{"self":{"href":"https://api.github.com/repos/mozilla/Affiliates-Tests/pulls/comments/40585956"},"html":{"href":"https://github.com/mozilla/Affiliates-Tests/pull/130#discussion_r40585956"},"pull_request":{"href":"https://api.github.com/repos/mozilla/Affiliates-Tests/pulls/130"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/Affiliates-Tests/pulls/130","id":45840270,"html_url":"https://github.com/mozilla/Affiliates-Tests/pull/130","diff_url":"https://github.com/mozilla/Affiliates-Tests/pull/130.diff","patch_url":"https://github.com/mozilla/Affiliates-Tests/pull/130.patch","issue_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/issues/130","number":130,"state":"open","locked":false,"title":"Switch to native asserts and a few other cleanups","user":{"login":"davehunt","id":122800,"avatar_url":"https://avatars.githubusercontent.com/u/122800?v=3","gravatar_id":"","url":"https://api.github.com/users/davehunt","html_url":"https://github.com/davehunt","followers_url":"https://api.github.com/users/davehunt/followers","following_url":"https://api.github.com/users/davehunt/following{/other_user}","gists_url":"https://api.github.com/users/davehunt/gists{/gist_id}","starred_url":"https://api.github.com/users/davehunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davehunt/subscriptions","organizations_url":"https://api.github.com/users/davehunt/orgs","repos_url":"https://api.github.com/users/davehunt/repos","events_url":"https://api.github.com/users/davehunt/events{/privacy}","received_events_url":"https://api.github.com/users/davehunt/received_events","type":"User","site_admin":false},"body":"Pinging @bobsilverberg and @m8ttyB for review.","created_at":"2015-09-23T22:35:04Z","updated_at":"2015-09-28T18:17:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15e697e06982d6e8f96e568c7a46543509d41dc4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/pulls/130/commits","review_comments_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/pulls/130/comments","review_comment_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/issues/130/comments","statuses_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/statuses/99d03304fdf6f496a7552ad7dc99b114364b266f","head":{"label":"davehunt:cleanup","ref":"cleanup","sha":"99d03304fdf6f496a7552ad7dc99b114364b266f","user":{"login":"davehunt","id":122800,"avatar_url":"https://avatars.githubusercontent.com/u/122800?v=3","gravatar_id":"","url":"https://api.github.com/users/davehunt","html_url":"https://github.com/davehunt","followers_url":"https://api.github.com/users/davehunt/followers","following_url":"https://api.github.com/users/davehunt/following{/other_user}","gists_url":"https://api.github.com/users/davehunt/gists{/gist_id}","starred_url":"https://api.github.com/users/davehunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davehunt/subscriptions","organizations_url":"https://api.github.com/users/davehunt/orgs","repos_url":"https://api.github.com/users/davehunt/repos","events_url":"https://api.github.com/users/davehunt/events{/privacy}","received_events_url":"https://api.github.com/users/davehunt/received_events","type":"User","site_admin":false},"repo":{"id":3260115,"name":"Affiliates-Tests","full_name":"davehunt/Affiliates-Tests","owner":{"login":"davehunt","id":122800,"avatar_url":"https://avatars.githubusercontent.com/u/122800?v=3","gravatar_id":"","url":"https://api.github.com/users/davehunt","html_url":"https://github.com/davehunt","followers_url":"https://api.github.com/users/davehunt/followers","following_url":"https://api.github.com/users/davehunt/following{/other_user}","gists_url":"https://api.github.com/users/davehunt/gists{/gist_id}","starred_url":"https://api.github.com/users/davehunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davehunt/subscriptions","organizations_url":"https://api.github.com/users/davehunt/orgs","repos_url":"https://api.github.com/users/davehunt/repos","events_url":"https://api.github.com/users/davehunt/events{/privacy}","received_events_url":"https://api.github.com/users/davehunt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davehunt/Affiliates-Tests","description":"Tests for Mozilla Affiliates","fork":true,"url":"https://api.github.com/repos/davehunt/Affiliates-Tests","forks_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/forks","keys_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/teams","hooks_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/hooks","issue_events_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/issues/events{/number}","events_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/events","assignees_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/assignees{/user}","branches_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/branches{/branch}","tags_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/tags","blobs_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/statuses/{sha}","languages_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/languages","stargazers_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/stargazers","contributors_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/contributors","subscribers_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/subscribers","subscription_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/subscription","commits_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/contents/{+path}","compare_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/merges","archive_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/downloads","issues_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/issues{/number}","pulls_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/pulls{/number}","milestones_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/milestones{/number}","notifications_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/labels{/name}","releases_url":"https://api.github.com/repos/davehunt/Affiliates-Tests/releases{/id}","created_at":"2012-01-24T21:48:14Z","updated_at":"2015-05-20T14:24:59Z","pushed_at":"2015-09-23T22:34:00Z","git_url":"git://github.com/davehunt/Affiliates-Tests.git","ssh_url":"git@github.com:davehunt/Affiliates-Tests.git","clone_url":"https://github.com/davehunt/Affiliates-Tests.git","svn_url":"https://github.com/davehunt/Affiliates-Tests","homepage":"https://affiliates-dev.allizom.org/en-US/","size":262,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"c9f937d469e406f5be6c48e9e53174b513b8b307","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":2535828,"name":"Affiliates-Tests","full_name":"mozilla/Affiliates-Tests","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/Affiliates-Tests","description":"Tests for Mozilla Affiliates","fork":false,"url":"https://api.github.com/repos/mozilla/Affiliates-Tests","forks_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/forks","keys_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/teams","hooks_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/hooks","issue_events_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/events","assignees_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/tags","blobs_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/languages","stargazers_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/stargazers","contributors_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/contributors","subscribers_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/subscribers","subscription_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/subscription","commits_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/merges","archive_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/downloads","issues_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/Affiliates-Tests/releases{/id}","created_at":"2011-10-07T23:01:17Z","updated_at":"2015-09-28T17:11:39Z","pushed_at":"2015-09-23T22:35:04Z","git_url":"git://github.com/mozilla/Affiliates-Tests.git","ssh_url":"git@github.com:mozilla/Affiliates-Tests.git","clone_url":"https://github.com/mozilla/Affiliates-Tests.git","svn_url":"https://github.com/mozilla/Affiliates-Tests","homepage":"https://affiliates-dev.allizom.org/en-US/","size":584,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":1,"forks":35,"open_issues":1,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/Affiliates-Tests/pulls/130"},"html":{"href":"https://github.com/mozilla/Affiliates-Tests/pull/130"},"issue":{"href":"https://api.github.com/repos/mozilla/Affiliates-Tests/issues/130"},"comments":{"href":"https://api.github.com/repos/mozilla/Affiliates-Tests/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/Affiliates-Tests/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/Affiliates-Tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/Affiliates-Tests/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/Affiliates-Tests/statuses/99d03304fdf6f496a7552ad7dc99b114364b266f"}}}}