{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/638","labels_url":"https://api.github.com/repos/apple/swift/issues/638/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/638/comments","events_url":"https://api.github.com/repos/apple/swift/issues/638/events","html_url":"https://github.com/apple/swift/pull/638","id":122900834,"number":638,"title":"[cmpcodesize][2] Begin extracting regular expressions","user":{"login":"modocache","id":552921,"avatar_url":"https://avatars.githubusercontent.com/u/552921?v=3","gravatar_id":"","url":"https://api.github.com/users/modocache","html_url":"https://github.com/modocache","followers_url":"https://api.github.com/users/modocache/followers","following_url":"https://api.github.com/users/modocache/following{/other_user}","gists_url":"https://api.github.com/users/modocache/gists{/gist_id}","starred_url":"https://api.github.com/users/modocache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modocache/subscriptions","organizations_url":"https://api.github.com/users/modocache/orgs","repos_url":"https://api.github.com/users/modocache/repos","events_url":"https://api.github.com/users/modocache/events{/privacy}","received_events_url":"https://api.github.com/users/modocache/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-12-18T08:00:24Z","updated_at":"2015-12-29T20:57:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/638","html_url":"https://github.com/apple/swift/pull/638","diff_url":"https://github.com/apple/swift/pull/638.diff","patch_url":"https://github.com/apple/swift/pull/638.patch"},"body":"**This pull request should be reviewed *after* #636 is merged. Sorry for any confusion. I split up the pull requests to make code review easier.**\r\n\r\n## What's in this pull request?\r\n\r\n`cmpcodesize.compare` has a few responsibilities: matching regular expressions on otool output, and storing the results of those matches in dictionaries.\r\n\r\nThis pull request begins extracting the regular expression matching into a separate file, `cmpcodesize/regex.py`.\r\n\r\n## Why merge this pull request?\r\n\r\n- Extracting the regex logic makes the code more modular, and allows for finer-grained unit tests.\r\n- These changes, which include unit tests, improves test coverage.\r\n\r\n## What downsides are there to merging this pull request?\r\n\r\nThe migration process is not completely done. You'll notice a `FIXME` for the other regex's still in `compare.py`. I'd like to address those in future pull requests, but the maintainers may prefer to do it all in one pull request."},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/167876190","html_url":"https://github.com/apple/swift/pull/638#issuecomment-167876190","issue_url":"https://api.github.com/repos/apple/swift/issues/638","id":167876190,"user":{"login":"nadavrot","id":8635342,"avatar_url":"https://avatars.githubusercontent.com/u/8635342?v=3","gravatar_id":"","url":"https://api.github.com/users/nadavrot","html_url":"https://github.com/nadavrot","followers_url":"https://api.github.com/users/nadavrot/followers","following_url":"https://api.github.com/users/nadavrot/following{/other_user}","gists_url":"https://api.github.com/users/nadavrot/gists{/gist_id}","starred_url":"https://api.github.com/users/nadavrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadavrot/subscriptions","organizations_url":"https://api.github.com/users/nadavrot/orgs","repos_url":"https://api.github.com/users/nadavrot/repos","events_url":"https://api.github.com/users/nadavrot/events{/privacy}","received_events_url":"https://api.github.com/users/nadavrot/received_events","type":"User","site_admin":false},"created_at":"2015-12-29T20:57:02Z","updated_at":"2015-12-29T20:57:02Z","body":"@modocache Are you planning to work on making the output CSV?  It is annoying to manually copy-and-paste values from the current format. "}}