{"action":"created","comment":{"url":"https://api.github.com/repos/MitocGroup/deep-framework/pulls/comments/45164224","id":45164224,"diff_hunk":"@@ -37,42 +65,57 @@ suite('Validation', function() {\n     chai.expect(validation.immutable).to.be.equal(false);\n   });\n \n-  test(`Check set() method sets models[\\'${modelName}\\']=${modelSchema} for immutable=false`, function() {\n-    validation.set(modelName, modelSchema);\n-    chai.expect(validation.get(modelName)).to.be.eql(modelSchema);\n-  });\n-\n-  test(`Check setRaw() method sets models[\\'${rawModelName}\\']=${rawModelSchema} for immutable=false`, function() {\n-    validation.setRaw(rawModelName, rawModelSchema);\n-    let actualResult = validation.get(rawModelName);\n-    chai.expect(actualResult.username._type).to.be.equal(rawModelSchema.username);\n-    chai.expect(actualResult.username.isJoi).to.be.equal(true);\n-  });\n+  test(\n+    `Check set() method sets models[\\'${modelName}\\']=${modelSchema} for immutable=false`,\n+    function() {\n+      validation.set(modelName, modelSchema);\n+      chai.expect(validation.get(modelName)).to.be.eql(modelSchema);\n+    }\n+  );\n \n-  test('Check get() method returns values for existed modelNames', function() {\n-    chai.expect(validation.get(modelName)).to.be.equal(modelSchema);\n-  });\n+  test(`Check setRaw() method sets models[\\'${rawModelName}\\']=${rawModelSchema} for immutable=false`,\n+    function() {\n+      validation.setRaw(rawModelName, rawModelSchema);\n \n-  test('Check has() method returns [false] for unexisted modelNames', function() {\n-    chai.expect(validation.has()).to.be.equal(false);\n-    chai.expect(validation.has('exist')).to.be.equal(false);\n-  });\n+      let actualResult = validation.get(rawModelName);\n \n-  test('Check has() method returns [true] for existed modelNames', function() {\n-    chai.expect(validation.has(modelName)).to.be.equal(true);\n-  });\n+      chai.expect(actualResult.username._type).to.be.equal(\n+        rawModelSchema.username\n+      );\n+      chai.expect(actualResult.username.isJoi).to.be.equal(true);\n+    }\n+  );\n \n-  test('Check get() method throws ModelNotFoundException', function() {\n-    let error = null;\n-    try {\n-      validation.get('invalidModelKey');\n-    } catch (e) {\n-      error = e;\n+  test('Check get() method returns values for existed modelNames',\n+    function() {\n+      chai.expect(validation.get(modelName)).to.be.equal(modelSchema);\n     }\n+  );\n \n-    chai.expect(error).to.be.not.equal(null);\n-    chai.expect(error).to.be.an.instanceOf(ModelNotFoundException);\n-  });\n+  test('Check has() method returns [false] for unexisted modelNames',","path":"src/deep-validation/test/Validation.js","position":120,"original_position":120,"commit_id":"c632ed5bbfb49f4c1cfdd2cc6cebe13b4f00527c","original_commit_id":"c632ed5bbfb49f4c1cfdd2cc6cebe13b4f00527c","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"'test' is not defined.","created_at":"2015-11-18T06:32:09Z","updated_at":"2015-11-18T06:32:09Z","html_url":"https://github.com/MitocGroup/deep-framework/pull/98#discussion_r45164224","pull_request_url":"https://api.github.com/repos/MitocGroup/deep-framework/pulls/98","_links":{"self":{"href":"https://api.github.com/repos/MitocGroup/deep-framework/pulls/comments/45164224"},"html":{"href":"https://github.com/MitocGroup/deep-framework/pull/98#discussion_r45164224"},"pull_request":{"href":"https://api.github.com/repos/MitocGroup/deep-framework/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/MitocGroup/deep-framework/pulls/98","id":50760788,"html_url":"https://github.com/MitocGroup/deep-framework/pull/98","diff_url":"https://github.com/MitocGroup/deep-framework/pull/98.diff","patch_url":"https://github.com/MitocGroup/deep-framework/pull/98.patch","issue_url":"https://api.github.com/repos/MitocGroup/deep-framework/issues/98","number":98,"state":"open","locked":false,"title":"Refactor unit tests for deep validation","user":{"login":"vcernomschi","id":10863276,"avatar_url":"https://avatars.githubusercontent.com/u/10863276?v=3","gravatar_id":"","url":"https://api.github.com/users/vcernomschi","html_url":"https://github.com/vcernomschi","followers_url":"https://api.github.com/users/vcernomschi/followers","following_url":"https://api.github.com/users/vcernomschi/following{/other_user}","gists_url":"https://api.github.com/users/vcernomschi/gists{/gist_id}","starred_url":"https://api.github.com/users/vcernomschi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcernomschi/subscriptions","organizations_url":"https://api.github.com/users/vcernomschi/orgs","repos_url":"https://api.github.com/users/vcernomschi/repos","events_url":"https://api.github.com/users/vcernomschi/events{/privacy}","received_events_url":"https://api.github.com/users/vcernomschi/received_events","type":"User","site_admin":false},"body":"Refactor unit tests for deep validation","created_at":"2015-11-16T00:01:57Z","updated_at":"2015-11-18T06:32:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d09c18fb5e8ee0d2994402800b8774f251501782","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MitocGroup/deep-framework/pulls/98/commits","review_comments_url":"https://api.github.com/repos/MitocGroup/deep-framework/pulls/98/comments","review_comment_url":"https://api.github.com/repos/MitocGroup/deep-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MitocGroup/deep-framework/issues/98/comments","statuses_url":"https://api.github.com/repos/MitocGroup/deep-framework/statuses/c632ed5bbfb49f4c1cfdd2cc6cebe13b4f00527c","head":{"label":"MitocGroup:refactor_deep_validation","ref":"refactor_deep_validation","sha":"c632ed5bbfb49f4c1cfdd2cc6cebe13b4f00527c","user":{"login":"MitocGroup","id":8398780,"avatar_url":"https://avatars.githubusercontent.com/u/8398780?v=3","gravatar_id":"","url":"https://api.github.com/users/MitocGroup","html_url":"https://github.com/MitocGroup","followers_url":"https://api.github.com/users/MitocGroup/followers","following_url":"https://api.github.com/users/MitocGroup/following{/other_user}","gists_url":"https://api.github.com/users/MitocGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/MitocGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MitocGroup/subscriptions","organizations_url":"https://api.github.com/users/MitocGroup/orgs","repos_url":"https://api.github.com/users/MitocGroup/repos","events_url":"https://api.github.com/users/MitocGroup/events{/privacy}","received_events_url":"https://api.github.com/users/MitocGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":43718196,"name":"deep-framework","full_name":"MitocGroup/deep-framework","owner":{"login":"MitocGroup","id":8398780,"avatar_url":"https://avatars.githubusercontent.com/u/8398780?v=3","gravatar_id":"","url":"https://api.github.com/users/MitocGroup","html_url":"https://github.com/MitocGroup","followers_url":"https://api.github.com/users/MitocGroup/followers","following_url":"https://api.github.com/users/MitocGroup/following{/other_user}","gists_url":"https://api.github.com/users/MitocGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/MitocGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MitocGroup/subscriptions","organizations_url":"https://api.github.com/users/MitocGroup/orgs","repos_url":"https://api.github.com/users/MitocGroup/repos","events_url":"https://api.github.com/users/MitocGroup/events{/privacy}","received_events_url":"https://api.github.com/users/MitocGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MitocGroup/deep-framework","description":"Serverless Web Framework for Cloud-Native Applications and Platforms using Microservices Architecture","fork":false,"url":"https://api.github.com/repos/MitocGroup/deep-framework","forks_url":"https://api.github.com/repos/MitocGroup/deep-framework/forks","keys_url":"https://api.github.com/repos/MitocGroup/deep-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MitocGroup/deep-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MitocGroup/deep-framework/teams","hooks_url":"https://api.github.com/repos/MitocGroup/deep-framework/hooks","issue_events_url":"https://api.github.com/repos/MitocGroup/deep-framework/issues/events{/number}","events_url":"https://api.github.com/repos/MitocGroup/deep-framework/events","assignees_url":"https://api.github.com/repos/MitocGroup/deep-framework/assignees{/user}","branches_url":"https://api.github.com/repos/MitocGroup/deep-framework/branches{/branch}","tags_url":"https://api.github.com/repos/MitocGroup/deep-framework/tags","blobs_url":"https://api.github.com/repos/MitocGroup/deep-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MitocGroup/deep-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MitocGroup/deep-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/MitocGroup/deep-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MitocGroup/deep-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/MitocGroup/deep-framework/languages","stargazers_url":"https://api.github.com/repos/MitocGroup/deep-framework/stargazers","contributors_url":"https://api.github.com/repos/MitocGroup/deep-framework/contributors","subscribers_url":"https://api.github.com/repos/MitocGroup/deep-framework/subscribers","subscription_url":"https://api.github.com/repos/MitocGroup/deep-framework/subscription","commits_url":"https://api.github.com/repos/MitocGroup/deep-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/MitocGroup/deep-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/MitocGroup/deep-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/MitocGroup/deep-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/MitocGroup/deep-framework/contents/{+path}","compare_url":"https://api.github.com/repos/MitocGroup/deep-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MitocGroup/deep-framework/merges","archive_url":"https://api.github.com/repos/MitocGroup/deep-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MitocGroup/deep-framework/downloads","issues_url":"https://api.github.com/repos/MitocGroup/deep-framework/issues{/number}","pulls_url":"https://api.github.com/repos/MitocGroup/deep-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/MitocGroup/deep-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/MitocGroup/deep-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MitocGroup/deep-framework/labels{/name}","releases_url":"https://api.github.com/repos/MitocGroup/deep-framework/releases{/id}","created_at":"2015-10-05T22:48:47Z","updated_at":"2015-11-17T12:32:24Z","pushed_at":"2015-11-18T06:31:57Z","git_url":"git://github.com/MitocGroup/deep-framework.git","ssh_url":"git@github.com:MitocGroup/deep-framework.git","clone_url":"https://github.com/MitocGroup/deep-framework.git","svn_url":"https://github.com/MitocGroup/deep-framework","homepage":"http://docs.deep.mg","size":4996,"stargazers_count":80,"watchers_count":80,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":18,"forks":2,"open_issues":18,"watchers":80,"default_branch":"master"}},"base":{"label":"MitocGroup:dev","ref":"dev","sha":"e06e8cb367e6e0c694bda80577b5078b8c3df52d","user":{"login":"MitocGroup","id":8398780,"avatar_url":"https://avatars.githubusercontent.com/u/8398780?v=3","gravatar_id":"","url":"https://api.github.com/users/MitocGroup","html_url":"https://github.com/MitocGroup","followers_url":"https://api.github.com/users/MitocGroup/followers","following_url":"https://api.github.com/users/MitocGroup/following{/other_user}","gists_url":"https://api.github.com/users/MitocGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/MitocGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MitocGroup/subscriptions","organizations_url":"https://api.github.com/users/MitocGroup/orgs","repos_url":"https://api.github.com/users/MitocGroup/repos","events_url":"https://api.github.com/users/MitocGroup/events{/privacy}","received_events_url":"https://api.github.com/users/MitocGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":43718196,"name":"deep-framework","full_name":"MitocGroup/deep-framework","owner":{"login":"MitocGroup","id":8398780,"avatar_url":"https://avatars.githubusercontent.com/u/8398780?v=3","gravatar_id":"","url":"https://api.github.com/users/MitocGroup","html_url":"https://github.com/MitocGroup","followers_url":"https://api.github.com/users/MitocGroup/followers","following_url":"https://api.github.com/users/MitocGroup/following{/other_user}","gists_url":"https://api.github.com/users/MitocGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/MitocGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MitocGroup/subscriptions","organizations_url":"https://api.github.com/users/MitocGroup/orgs","repos_url":"https://api.github.com/users/MitocGroup/repos","events_url":"https://api.github.com/users/MitocGroup/events{/privacy}","received_events_url":"https://api.github.com/users/MitocGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MitocGroup/deep-framework","description":"Serverless Web Framework for Cloud-Native Applications and Platforms using Microservices Architecture","fork":false,"url":"https://api.github.com/repos/MitocGroup/deep-framework","forks_url":"https://api.github.com/repos/MitocGroup/deep-framework/forks","keys_url":"https://api.github.com/repos/MitocGroup/deep-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MitocGroup/deep-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MitocGroup/deep-framework/teams","hooks_url":"https://api.github.com/repos/MitocGroup/deep-framework/hooks","issue_events_url":"https://api.github.com/repos/MitocGroup/deep-framework/issues/events{/number}","events_url":"https://api.github.com/repos/MitocGroup/deep-framework/events","assignees_url":"https://api.github.com/repos/MitocGroup/deep-framework/assignees{/user}","branches_url":"https://api.github.com/repos/MitocGroup/deep-framework/branches{/branch}","tags_url":"https://api.github.com/repos/MitocGroup/deep-framework/tags","blobs_url":"https://api.github.com/repos/MitocGroup/deep-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MitocGroup/deep-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MitocGroup/deep-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/MitocGroup/deep-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MitocGroup/deep-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/MitocGroup/deep-framework/languages","stargazers_url":"https://api.github.com/repos/MitocGroup/deep-framework/stargazers","contributors_url":"https://api.github.com/repos/MitocGroup/deep-framework/contributors","subscribers_url":"https://api.github.com/repos/MitocGroup/deep-framework/subscribers","subscription_url":"https://api.github.com/repos/MitocGroup/deep-framework/subscription","commits_url":"https://api.github.com/repos/MitocGroup/deep-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/MitocGroup/deep-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/MitocGroup/deep-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/MitocGroup/deep-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/MitocGroup/deep-framework/contents/{+path}","compare_url":"https://api.github.com/repos/MitocGroup/deep-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MitocGroup/deep-framework/merges","archive_url":"https://api.github.com/repos/MitocGroup/deep-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MitocGroup/deep-framework/downloads","issues_url":"https://api.github.com/repos/MitocGroup/deep-framework/issues{/number}","pulls_url":"https://api.github.com/repos/MitocGroup/deep-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/MitocGroup/deep-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/MitocGroup/deep-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MitocGroup/deep-framework/labels{/name}","releases_url":"https://api.github.com/repos/MitocGroup/deep-framework/releases{/id}","created_at":"2015-10-05T22:48:47Z","updated_at":"2015-11-17T12:32:24Z","pushed_at":"2015-11-18T06:31:57Z","git_url":"git://github.com/MitocGroup/deep-framework.git","ssh_url":"git@github.com:MitocGroup/deep-framework.git","clone_url":"https://github.com/MitocGroup/deep-framework.git","svn_url":"https://github.com/MitocGroup/deep-framework","homepage":"http://docs.deep.mg","size":4996,"stargazers_count":80,"watchers_count":80,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":18,"forks":2,"open_issues":18,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MitocGroup/deep-framework/pulls/98"},"html":{"href":"https://github.com/MitocGroup/deep-framework/pull/98"},"issue":{"href":"https://api.github.com/repos/MitocGroup/deep-framework/issues/98"},"comments":{"href":"https://api.github.com/repos/MitocGroup/deep-framework/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/MitocGroup/deep-framework/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/MitocGroup/deep-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MitocGroup/deep-framework/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/MitocGroup/deep-framework/statuses/c632ed5bbfb49f4c1cfdd2cc6cebe13b4f00527c"}}}}