{"action":"created","comment":{"url":"https://api.github.com/repos/swcarpentry/amy/pulls/comments/42931787","id":42931787,"diff_hunk":"@@ -118,6 +109,16 @@\n         {% endif %}\n         </td>\n     </tr>\n+    <tr><th colspan=\"3\" class=\"text-center\">Additional information (not being saved to the database)</th></tr>","path":"workshops/templates/workshops/profileupdaterequest.html","position":57,"original_position":57,"commit_id":"d6cbb5625d8ec8c3433e92aec6356c19f3a9d26f","original_commit_id":"d6cbb5625d8ec8c3433e92aec6356c19f3a9d26f","user":{"login":"pbanaszkiewicz","id":72821,"avatar_url":"https://avatars.githubusercontent.com/u/72821?v=3","gravatar_id":"","url":"https://api.github.com/users/pbanaszkiewicz","html_url":"https://github.com/pbanaszkiewicz","followers_url":"https://api.github.com/users/pbanaszkiewicz/followers","following_url":"https://api.github.com/users/pbanaszkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/pbanaszkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/pbanaszkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbanaszkiewicz/subscriptions","organizations_url":"https://api.github.com/users/pbanaszkiewicz/orgs","repos_url":"https://api.github.com/users/pbanaszkiewicz/repos","events_url":"https://api.github.com/users/pbanaszkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/pbanaszkiewicz/received_events","type":"User","site_admin":false},"body":"Because neither ORCID ID or Occupation is being stored in Person record.\r\n\r\nThe \"Has instructor badge\" is rather a property that can only be calculated from Person record.","created_at":"2015-10-24T08:08:03Z","updated_at":"2015-10-24T08:08:03Z","html_url":"https://github.com/swcarpentry/amy/pull/542#discussion_r42931787","pull_request_url":"https://api.github.com/repos/swcarpentry/amy/pulls/542","_links":{"self":{"href":"https://api.github.com/repos/swcarpentry/amy/pulls/comments/42931787"},"html":{"href":"https://github.com/swcarpentry/amy/pull/542#discussion_r42931787"},"pull_request":{"href":"https://api.github.com/repos/swcarpentry/amy/pulls/542"}}},"pull_request":{"url":"https://api.github.com/repos/swcarpentry/amy/pulls/542","id":47700844,"html_url":"https://github.com/swcarpentry/amy/pull/542","diff_url":"https://github.com/swcarpentry/amy/pull/542.diff","patch_url":"https://github.com/swcarpentry/amy/pull/542.patch","issue_url":"https://api.github.com/repos/swcarpentry/amy/issues/542","number":542,"state":"open","locked":false,"title":"Profile update request view: fix couple of issues","user":{"login":"pbanaszkiewicz","id":72821,"avatar_url":"https://avatars.githubusercontent.com/u/72821?v=3","gravatar_id":"","url":"https://api.github.com/users/pbanaszkiewicz","html_url":"https://github.com/pbanaszkiewicz","followers_url":"https://api.github.com/users/pbanaszkiewicz/followers","following_url":"https://api.github.com/users/pbanaszkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/pbanaszkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/pbanaszkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbanaszkiewicz/subscriptions","organizations_url":"https://api.github.com/users/pbanaszkiewicz/orgs","repos_url":"https://api.github.com/users/pbanaszkiewicz/repos","events_url":"https://api.github.com/users/pbanaszkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/pbanaszkiewicz/received_events","type":"User","site_admin":false},"body":"1. Move fields not being saved to DB to the bottom of the form\r\n2. Separate these fields with long horizontal row saying\r\n   \"These aren't saved\"\r\n3. Change \"N/A\" to \"<em>Not available</em>\"\r\n4. Add some '|default:\"—\"' to the fields that didn't have this filter\r\n\r\nThis fixes #538 but in a different way (see attachment).\r\n\r\n![screenshot from 2015-10-14 21 02 35](https://cloud.githubusercontent.com/assets/72821/10494491/ed3ab4e0-72b6-11e5-8d8a-d38c8d30dc6f.png)\r\n\r\nThis PR will cause conflict once #528 is merged.","created_at":"2015-10-14T19:03:38Z","updated_at":"2015-10-24T08:08:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bd63131b3c7fea024e4830a25f6e3d9b2b84860","assignee":{"login":"gvwilson","id":911566,"avatar_url":"https://avatars.githubusercontent.com/u/911566?v=3","gravatar_id":"","url":"https://api.github.com/users/gvwilson","html_url":"https://github.com/gvwilson","followers_url":"https://api.github.com/users/gvwilson/followers","following_url":"https://api.github.com/users/gvwilson/following{/other_user}","gists_url":"https://api.github.com/users/gvwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/gvwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvwilson/subscriptions","organizations_url":"https://api.github.com/users/gvwilson/orgs","repos_url":"https://api.github.com/users/gvwilson/repos","events_url":"https://api.github.com/users/gvwilson/events{/privacy}","received_events_url":"https://api.github.com/users/gvwilson/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/swcarpentry/amy/milestones/14","html_url":"https://github.com/swcarpentry/amy/milestones/v1.1","labels_url":"https://api.github.com/repos/swcarpentry/amy/milestones/14/labels","id":1340803,"number":14,"title":"v1.1","description":"Admins decided what we should include here.","creator":{"login":"pbanaszkiewicz","id":72821,"avatar_url":"https://avatars.githubusercontent.com/u/72821?v=3","gravatar_id":"","url":"https://api.github.com/users/pbanaszkiewicz","html_url":"https://github.com/pbanaszkiewicz","followers_url":"https://api.github.com/users/pbanaszkiewicz/followers","following_url":"https://api.github.com/users/pbanaszkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/pbanaszkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/pbanaszkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbanaszkiewicz/subscriptions","organizations_url":"https://api.github.com/users/pbanaszkiewicz/orgs","repos_url":"https://api.github.com/users/pbanaszkiewicz/repos","events_url":"https://api.github.com/users/pbanaszkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/pbanaszkiewicz/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":11,"state":"open","created_at":"2015-10-06T17:13:16Z","updated_at":"2015-10-23T20:49:44Z","due_on":"2015-10-30T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/swcarpentry/amy/pulls/542/commits","review_comments_url":"https://api.github.com/repos/swcarpentry/amy/pulls/542/comments","review_comment_url":"https://api.github.com/repos/swcarpentry/amy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swcarpentry/amy/issues/542/comments","statuses_url":"https://api.github.com/repos/swcarpentry/amy/statuses/d6cbb5625d8ec8c3433e92aec6356c19f3a9d26f","head":{"label":"pbanaszkiewicz:better-profile-update-request-view","ref":"better-profile-update-request-view","sha":"d6cbb5625d8ec8c3433e92aec6356c19f3a9d26f","user":{"login":"pbanaszkiewicz","id":72821,"avatar_url":"https://avatars.githubusercontent.com/u/72821?v=3","gravatar_id":"","url":"https://api.github.com/users/pbanaszkiewicz","html_url":"https://github.com/pbanaszkiewicz","followers_url":"https://api.github.com/users/pbanaszkiewicz/followers","following_url":"https://api.github.com/users/pbanaszkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/pbanaszkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/pbanaszkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbanaszkiewicz/subscriptions","organizations_url":"https://api.github.com/users/pbanaszkiewicz/orgs","repos_url":"https://api.github.com/users/pbanaszkiewicz/repos","events_url":"https://api.github.com/users/pbanaszkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/pbanaszkiewicz/received_events","type":"User","site_admin":false},"repo":{"id":28005098,"name":"amy","full_name":"pbanaszkiewicz/amy","owner":{"login":"pbanaszkiewicz","id":72821,"avatar_url":"https://avatars.githubusercontent.com/u/72821?v=3","gravatar_id":"","url":"https://api.github.com/users/pbanaszkiewicz","html_url":"https://github.com/pbanaszkiewicz","followers_url":"https://api.github.com/users/pbanaszkiewicz/followers","following_url":"https://api.github.com/users/pbanaszkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/pbanaszkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/pbanaszkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbanaszkiewicz/subscriptions","organizations_url":"https://api.github.com/users/pbanaszkiewicz/orgs","repos_url":"https://api.github.com/users/pbanaszkiewicz/repos","events_url":"https://api.github.com/users/pbanaszkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/pbanaszkiewicz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pbanaszkiewicz/amy","description":"A web-based workshop administration application built using Django.","fork":true,"url":"https://api.github.com/repos/pbanaszkiewicz/amy","forks_url":"https://api.github.com/repos/pbanaszkiewicz/amy/forks","keys_url":"https://api.github.com/repos/pbanaszkiewicz/amy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pbanaszkiewicz/amy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pbanaszkiewicz/amy/teams","hooks_url":"https://api.github.com/repos/pbanaszkiewicz/amy/hooks","issue_events_url":"https://api.github.com/repos/pbanaszkiewicz/amy/issues/events{/number}","events_url":"https://api.github.com/repos/pbanaszkiewicz/amy/events","assignees_url":"https://api.github.com/repos/pbanaszkiewicz/amy/assignees{/user}","branches_url":"https://api.github.com/repos/pbanaszkiewicz/amy/branches{/branch}","tags_url":"https://api.github.com/repos/pbanaszkiewicz/amy/tags","blobs_url":"https://api.github.com/repos/pbanaszkiewicz/amy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pbanaszkiewicz/amy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pbanaszkiewicz/amy/git/refs{/sha}","trees_url":"https://api.github.com/repos/pbanaszkiewicz/amy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pbanaszkiewicz/amy/statuses/{sha}","languages_url":"https://api.github.com/repos/pbanaszkiewicz/amy/languages","stargazers_url":"https://api.github.com/repos/pbanaszkiewicz/amy/stargazers","contributors_url":"https://api.github.com/repos/pbanaszkiewicz/amy/contributors","subscribers_url":"https://api.github.com/repos/pbanaszkiewicz/amy/subscribers","subscription_url":"https://api.github.com/repos/pbanaszkiewicz/amy/subscription","commits_url":"https://api.github.com/repos/pbanaszkiewicz/amy/commits{/sha}","git_commits_url":"https://api.github.com/repos/pbanaszkiewicz/amy/git/commits{/sha}","comments_url":"https://api.github.com/repos/pbanaszkiewicz/amy/comments{/number}","issue_comment_url":"https://api.github.com/repos/pbanaszkiewicz/amy/issues/comments{/number}","contents_url":"https://api.github.com/repos/pbanaszkiewicz/amy/contents/{+path}","compare_url":"https://api.github.com/repos/pbanaszkiewicz/amy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pbanaszkiewicz/amy/merges","archive_url":"https://api.github.com/repos/pbanaszkiewicz/amy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pbanaszkiewicz/amy/downloads","issues_url":"https://api.github.com/repos/pbanaszkiewicz/amy/issues{/number}","pulls_url":"https://api.github.com/repos/pbanaszkiewicz/amy/pulls{/number}","milestones_url":"https://api.github.com/repos/pbanaszkiewicz/amy/milestones{/number}","notifications_url":"https://api.github.com/repos/pbanaszkiewicz/amy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pbanaszkiewicz/amy/labels{/name}","releases_url":"https://api.github.com/repos/pbanaszkiewicz/amy/releases{/id}","created_at":"2014-12-14T19:25:22Z","updated_at":"2015-05-08T17:10:25Z","pushed_at":"2015-10-23T20:49:24Z","git_url":"git://github.com/pbanaszkiewicz/amy.git","ssh_url":"git@github.com:pbanaszkiewicz/amy.git","clone_url":"https://github.com/pbanaszkiewicz/amy.git","svn_url":"https://github.com/pbanaszkiewicz/amy","homepage":null,"size":11268,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"swcarpentry:develop","ref":"develop","sha":"2919e0e90a5edd5ffdc72910f1e09016d95624a0","user":{"login":"swcarpentry","id":2238358,"avatar_url":"https://avatars.githubusercontent.com/u/2238358?v=3","gravatar_id":"","url":"https://api.github.com/users/swcarpentry","html_url":"https://github.com/swcarpentry","followers_url":"https://api.github.com/users/swcarpentry/followers","following_url":"https://api.github.com/users/swcarpentry/following{/other_user}","gists_url":"https://api.github.com/users/swcarpentry/gists{/gist_id}","starred_url":"https://api.github.com/users/swcarpentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcarpentry/subscriptions","organizations_url":"https://api.github.com/users/swcarpentry/orgs","repos_url":"https://api.github.com/users/swcarpentry/repos","events_url":"https://api.github.com/users/swcarpentry/events{/privacy}","received_events_url":"https://api.github.com/users/swcarpentry/received_events","type":"Organization","site_admin":false},"repo":{"id":27387287,"name":"amy","full_name":"swcarpentry/amy","owner":{"login":"swcarpentry","id":2238358,"avatar_url":"https://avatars.githubusercontent.com/u/2238358?v=3","gravatar_id":"","url":"https://api.github.com/users/swcarpentry","html_url":"https://github.com/swcarpentry","followers_url":"https://api.github.com/users/swcarpentry/followers","following_url":"https://api.github.com/users/swcarpentry/following{/other_user}","gists_url":"https://api.github.com/users/swcarpentry/gists{/gist_id}","starred_url":"https://api.github.com/users/swcarpentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcarpentry/subscriptions","organizations_url":"https://api.github.com/users/swcarpentry/orgs","repos_url":"https://api.github.com/users/swcarpentry/repos","events_url":"https://api.github.com/users/swcarpentry/events{/privacy}","received_events_url":"https://api.github.com/users/swcarpentry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swcarpentry/amy","description":"A web-based workshop administration application built using Django.","fork":false,"url":"https://api.github.com/repos/swcarpentry/amy","forks_url":"https://api.github.com/repos/swcarpentry/amy/forks","keys_url":"https://api.github.com/repos/swcarpentry/amy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swcarpentry/amy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swcarpentry/amy/teams","hooks_url":"https://api.github.com/repos/swcarpentry/amy/hooks","issue_events_url":"https://api.github.com/repos/swcarpentry/amy/issues/events{/number}","events_url":"https://api.github.com/repos/swcarpentry/amy/events","assignees_url":"https://api.github.com/repos/swcarpentry/amy/assignees{/user}","branches_url":"https://api.github.com/repos/swcarpentry/amy/branches{/branch}","tags_url":"https://api.github.com/repos/swcarpentry/amy/tags","blobs_url":"https://api.github.com/repos/swcarpentry/amy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swcarpentry/amy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swcarpentry/amy/git/refs{/sha}","trees_url":"https://api.github.com/repos/swcarpentry/amy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swcarpentry/amy/statuses/{sha}","languages_url":"https://api.github.com/repos/swcarpentry/amy/languages","stargazers_url":"https://api.github.com/repos/swcarpentry/amy/stargazers","contributors_url":"https://api.github.com/repos/swcarpentry/amy/contributors","subscribers_url":"https://api.github.com/repos/swcarpentry/amy/subscribers","subscription_url":"https://api.github.com/repos/swcarpentry/amy/subscription","commits_url":"https://api.github.com/repos/swcarpentry/amy/commits{/sha}","git_commits_url":"https://api.github.com/repos/swcarpentry/amy/git/commits{/sha}","comments_url":"https://api.github.com/repos/swcarpentry/amy/comments{/number}","issue_comment_url":"https://api.github.com/repos/swcarpentry/amy/issues/comments{/number}","contents_url":"https://api.github.com/repos/swcarpentry/amy/contents/{+path}","compare_url":"https://api.github.com/repos/swcarpentry/amy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swcarpentry/amy/merges","archive_url":"https://api.github.com/repos/swcarpentry/amy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swcarpentry/amy/downloads","issues_url":"https://api.github.com/repos/swcarpentry/amy/issues{/number}","pulls_url":"https://api.github.com/repos/swcarpentry/amy/pulls{/number}","milestones_url":"https://api.github.com/repos/swcarpentry/amy/milestones{/number}","notifications_url":"https://api.github.com/repos/swcarpentry/amy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swcarpentry/amy/labels{/name}","releases_url":"https://api.github.com/repos/swcarpentry/amy/releases{/id}","created_at":"2014-12-01T16:07:14Z","updated_at":"2015-10-12T06:31:18Z","pushed_at":"2015-10-24T08:03:17Z","git_url":"git://github.com/swcarpentry/amy.git","ssh_url":"git@github.com:swcarpentry/amy.git","clone_url":"https://github.com/swcarpentry/amy.git","svn_url":"https://github.com/swcarpentry/amy","homepage":null,"size":13488,"stargazers_count":27,"watchers_count":27,"language":"PLpgSQL","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":63,"forks":32,"open_issues":63,"watchers":27,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/swcarpentry/amy/pulls/542"},"html":{"href":"https://github.com/swcarpentry/amy/pull/542"},"issue":{"href":"https://api.github.com/repos/swcarpentry/amy/issues/542"},"comments":{"href":"https://api.github.com/repos/swcarpentry/amy/issues/542/comments"},"review_comments":{"href":"https://api.github.com/repos/swcarpentry/amy/pulls/542/comments"},"review_comment":{"href":"https://api.github.com/repos/swcarpentry/amy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swcarpentry/amy/pulls/542/commits"},"statuses":{"href":"https://api.github.com/repos/swcarpentry/amy/statuses/d6cbb5625d8ec8c3433e92aec6356c19f3a9d26f"}}}}