{"action":"created","issue":{"url":"https://api.github.com/repos/BD2KGenomics/toil/issues/492","labels_url":"https://api.github.com/repos/BD2KGenomics/toil/issues/492/labels{/name}","comments_url":"https://api.github.com/repos/BD2KGenomics/toil/issues/492/comments","events_url":"https://api.github.com/repos/BD2KGenomics/toil/issues/492/events","html_url":"https://github.com/BD2KGenomics/toil/pull/492","id":111329845,"number":492,"title":"Implemented FIFO as cache ejection strategy + tests (resolves #490)","user":{"login":"arkal","id":11653944,"avatar_url":"https://avatars.githubusercontent.com/u/11653944?v=3","gravatar_id":"","url":"https://api.github.com/users/arkal","html_url":"https://github.com/arkal","followers_url":"https://api.github.com/users/arkal/followers","following_url":"https://api.github.com/users/arkal/following{/other_user}","gists_url":"https://api.github.com/users/arkal/gists{/gist_id}","starred_url":"https://api.github.com/users/arkal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arkal/subscriptions","organizations_url":"https://api.github.com/users/arkal/orgs","repos_url":"https://api.github.com/users/arkal/repos","events_url":"https://api.github.com/users/arkal/events{/privacy}","received_events_url":"https://api.github.com/users/arkal/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/BD2KGenomics/toil/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-10-14T05:59:14Z","updated_at":"2015-10-14T07:49:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BD2KGenomics/toil/pulls/492","html_url":"https://github.com/BD2KGenomics/toil/pull/492","diff_url":"https://github.com/BD2KGenomics/toil/pull/492.diff","patch_url":"https://github.com/BD2KGenomics/toil/pull/492.patch"},"body":"As mentioned, First In First Out (FIFO) was implemented as the cache ejection strategy if cache will be overfull at the end of a writeGlobalFile.  Wrote a unittest that tests the event.\r\n\r\nResolves #490"},"comment":{"url":"https://api.github.com/repos/BD2KGenomics/toil/issues/comments/147965356","html_url":"https://github.com/BD2KGenomics/toil/pull/492#issuecomment-147965356","issue_url":"https://api.github.com/repos/BD2KGenomics/toil/issues/492","id":147965356,"user":{"login":"hannes-ucsc","id":5143256,"avatar_url":"https://avatars.githubusercontent.com/u/5143256?v=3","gravatar_id":"","url":"https://api.github.com/users/hannes-ucsc","html_url":"https://github.com/hannes-ucsc","followers_url":"https://api.github.com/users/hannes-ucsc/followers","following_url":"https://api.github.com/users/hannes-ucsc/following{/other_user}","gists_url":"https://api.github.com/users/hannes-ucsc/gists{/gist_id}","starred_url":"https://api.github.com/users/hannes-ucsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannes-ucsc/subscriptions","organizations_url":"https://api.github.com/users/hannes-ucsc/orgs","repos_url":"https://api.github.com/users/hannes-ucsc/repos","events_url":"https://api.github.com/users/hannes-ucsc/events{/privacy}","received_events_url":"https://api.github.com/users/hannes-ucsc/received_events","type":"User","site_admin":false},"created_at":"2015-10-14T07:49:16Z","updated_at":"2015-10-14T07:49:16Z","body":"To be precise, the code needs to be changed to either not create the log file, or to clean the log file up (either in teardown() or a `finally:` clause).\r\n\r\nThe commented out code needs to be removed or put into `if False:`\r\n\r\nThe commits that achieve the above should to be squashed into the first one.\r\n\r\nIdeally, the other comments should be addressed.\r\n\r\nIf @arkal does not have the time to do this, I can assign someone else."}}