{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmsdist/issues/1174","labels_url":"https://api.github.com/repos/cms-sw/cmsdist/issues/1174/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmsdist/issues/1174/comments","events_url":"https://api.github.com/repos/cms-sw/cmsdist/issues/1174/events","html_url":"https://github.com/cms-sw/cmsdist/issues/1174","id":48250742,"number":1174,"title":"[73X] Update LLVM/Clang","user":{"login":"davidlt","id":197091,"avatar_url":"https://avatars.githubusercontent.com/u/197091?v=3","gravatar_id":"","url":"https://api.github.com/users/davidlt","html_url":"https://github.com/davidlt","followers_url":"https://api.github.com/users/davidlt/followers","following_url":"https://api.github.com/users/davidlt/following{/other_user}","gists_url":"https://api.github.com/users/davidlt/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlt/subscriptions","organizations_url":"https://api.github.com/users/davidlt/orgs","repos_url":"https://api.github.com/users/davidlt/repos","events_url":"https://api.github.com/users/davidlt/events{/privacy}","received_events_url":"https://api.github.com/users/davidlt/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"davidlt","id":197091,"avatar_url":"https://avatars.githubusercontent.com/u/197091?v=3","gravatar_id":"","url":"https://api.github.com/users/davidlt","html_url":"https://github.com/davidlt","followers_url":"https://api.github.com/users/davidlt/followers","following_url":"https://api.github.com/users/davidlt/following{/other_user}","gists_url":"https://api.github.com/users/davidlt/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlt/subscriptions","organizations_url":"https://api.github.com/users/davidlt/orgs","repos_url":"https://api.github.com/users/davidlt/repos","events_url":"https://api.github.com/users/davidlt/events{/privacy}","received_events_url":"https://api.github.com/users/davidlt/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2014-11-10T10:36:53Z","updated_at":"2015-01-14T09:22:56Z","closed_at":"2015-01-14T09:22:56Z","body":"`RecoEgamma/EgammaIsolationAlgos` package is ICE'ing the Clang and `RecoVertex/AdaptiveVertexFit` is capturing non-POD VLAs in lambda. The latter [landed in Clang](http://reviews.llvm.org/D4368) after 3.5.0 release.\r\n\r\nBoth of these are resolved in newer Clang versions.\r\n\r\nThe following seems to resolve it.\r\n\r\n```\r\ndiff --git a/llvm.spec b/llvm.spec\r\nindex dc1532e..e44600a 100644\r\n--- a/llvm.spec\r\n+++ b/llvm.spec\r\n@@ -4,11 +4,12 @@\r\n BuildRequires: python\r\n Requires: gcc\r\n\r\n-%define llvmCommit f55c17bc339\r\n-%define clangCommit 656aa83af0b\r\n-%define branch cms/v%realversion\r\n-Source0: git+https://github.com/cms-externals/llvm.git?obj=%{branch}/%{llvmCommit}&export=llvm-%{realversion}-%{llvmCommit}&module=llvm-%realversion-%llvmCommit&output=/llvm-%{real\r\n-Source1: git+https://github.com/cms-externals/clang.git?obj=%{branch}/%{clangCommit}&export=clang-%{realversion}-%{clangCommit}&module=clang-%realversion-%clangCommit&output=/clang\r\n+%define llvmCommit e1e1392e13ef3f5e97fbdd15ca8d60d63f69a862\r\n+%define clangCommit 097068701d2c7fff58866059b1e3ebcac2728f7a\r\n+%define llvmBranch cms/e1e1392\r\n+%define clangBranch cms/9443d04\r\n+Source0: git+https://github.com/davidlt/llvm.git?obj=%{llvmBranch}/%{llvmCommit}&export=llvm-%{realversion}-%{llvmCommit}&module=llvm-%realversion-%llvmCommit&output=/llvm-%{realve\r\n+Source1: git+https://github.com/davidlt/clang.git?obj=%{clangBranch}/%{clangCommit}&export=clang-%{realversion}-%{clangCommit}&module=clang-%realversion-%clangCommit&output=/clang-\r\n\r\n # Still need forward porting.\r\n %define keep_archives true\r\n```\r\nLLVM upstream commit `e1e1392e13ef3f5e97fbdd15ca8d60d63f69a862`\r\nClang upstream commit `9443d047e89e716928fd87d277fca673afc2ec43`\r\n\r\nThis is a working item for me to find and propose working LLVM and Clang commits for the update.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmsdist/issues/comments/69889289","html_url":"https://github.com/cms-sw/cmsdist/issues/1174#issuecomment-69889289","issue_url":"https://api.github.com/repos/cms-sw/cmsdist/issues/1174","id":69889289,"user":{"login":"davidlt","id":197091,"avatar_url":"https://avatars.githubusercontent.com/u/197091?v=3","gravatar_id":"","url":"https://api.github.com/users/davidlt","html_url":"https://github.com/davidlt","followers_url":"https://api.github.com/users/davidlt/followers","following_url":"https://api.github.com/users/davidlt/following{/other_user}","gists_url":"https://api.github.com/users/davidlt/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlt/subscriptions","organizations_url":"https://api.github.com/users/davidlt/orgs","repos_url":"https://api.github.com/users/davidlt/repos","events_url":"https://api.github.com/users/davidlt/events{/privacy}","received_events_url":"https://api.github.com/users/davidlt/received_events","type":"User","site_admin":false},"created_at":"2015-01-14T09:22:56Z","updated_at":"2015-01-14T09:22:56Z","body":"The new LLVM/Clang is in DEVEL_X for the last ~6 weeks I believe, but compiling of CMSSW with Clang was completely broken after we added some thread safety patches in ROOT. I sent RFC patch to Philippe, which was a double fix. He did commit it and Chris recently requested it backported into our own fork, which I believe was done recently.\r\n\r\nAfter that I haven't continued looking in CMSSW  + Clang, but I should as 3.6 is close to be released.\r\n\r\nClosing as goal of PR is achieved."}}