{"action":"created","issue":{"url":"https://api.github.com/repos/gnachman/iTerm2/issues/201","labels_url":"https://api.github.com/repos/gnachman/iTerm2/issues/201/labels{/name}","comments_url":"https://api.github.com/repos/gnachman/iTerm2/issues/201/comments","events_url":"https://api.github.com/repos/gnachman/iTerm2/issues/201/events","html_url":"https://github.com/gnachman/iTerm2/pull/201","id":60916368,"number":201,"title":"Background transparency","user":{"login":"nathanrobinson","id":2867254,"avatar_url":"https://avatars.githubusercontent.com/u/2867254?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanrobinson","html_url":"https://github.com/nathanrobinson","followers_url":"https://api.github.com/users/nathanrobinson/followers","following_url":"https://api.github.com/users/nathanrobinson/following{/other_user}","gists_url":"https://api.github.com/users/nathanrobinson/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanrobinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanrobinson/subscriptions","organizations_url":"https://api.github.com/users/nathanrobinson/orgs","repos_url":"https://api.github.com/users/nathanrobinson/repos","events_url":"https://api.github.com/users/nathanrobinson/events{/privacy}","received_events_url":"https://api.github.com/users/nathanrobinson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-12T22:00:54Z","updated_at":"2015-03-17T18:53:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gnachman/iTerm2/pulls/201","html_url":"https://github.com/gnachman/iTerm2/pull/201","diff_url":"https://github.com/gnachman/iTerm2/pull/201.diff","patch_url":"https://github.com/gnachman/iTerm2/pull/201.patch"},"body":"This fork allows setting different transparency and blur values for background windows."},"comment":{"url":"https://api.github.com/repos/gnachman/iTerm2/issues/comments/82526538","html_url":"https://github.com/gnachman/iTerm2/pull/201#issuecomment-82526538","issue_url":"https://api.github.com/repos/gnachman/iTerm2/issues/201","id":82526538,"user":{"login":"gnachman","id":427546,"avatar_url":"https://avatars.githubusercontent.com/u/427546?v=3","gravatar_id":"","url":"https://api.github.com/users/gnachman","html_url":"https://github.com/gnachman","followers_url":"https://api.github.com/users/gnachman/followers","following_url":"https://api.github.com/users/gnachman/following{/other_user}","gists_url":"https://api.github.com/users/gnachman/gists{/gist_id}","starred_url":"https://api.github.com/users/gnachman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnachman/subscriptions","organizations_url":"https://api.github.com/users/gnachman/orgs","repos_url":"https://api.github.com/users/gnachman/repos","events_url":"https://api.github.com/users/gnachman/events{/privacy}","received_events_url":"https://api.github.com/users/gnachman/received_events","type":"User","site_admin":false},"created_at":"2015-03-17T18:53:58Z","updated_at":"2015-03-17T18:53:58Z","body":"I haven't dug in super deep but I think these comments cover most of the issues:\r\n\r\n- The transparency for background windows doesn't affect the margins (they seem to always use the foreground setting)\r\n- The prefs dialog is starting to look (more) like the controls on the space shuttle. How about moving the blur and transparency controls into a modal sheet, like the settings in the prefs>advanced panel? Leave behind a button labeled \"Transparency and Blur…\" that opens the sheet.\r\n- I saw a few places where \"bool\" and \"true\" and \"false\" were used instead of BOOL and YES/NO; looks like some old wrong code. Instead of being consistent, would you mind fixing those?\r\n- There's an \"Inactivate transparency\" label below the \"Inactive transparency\" checkbox. The label should be removed.\r\n- Don't use abbreviations except in extreme cases. KEY_BACKGROUND_TRANS and KEY_USE_BACKGROUND_TRANS should spell out TRANSPARENCY, even if it messes up the alignment of the source code.\r\n- Names in code (for example, useBackgroundTransparency) should match what we see in the UI (where “inactive” is used, not “background”).\r\n- Minor style issue: new code should use this format for methods:\r\n\r\n   ` - (void)foo {`\r\n\r\nrather than\r\n\r\n    - (void)foo\r\n    {\r\n\r\n- Always put a space between an `if` statement and the opening paren of its condition (e.g., in `recheckBlur`)\r\n\r\n- The use of Hungarian notation is being phased out. Avoid names like \"fVal\" (e.g., in `setBackgroundTransparency:`). In the case of setters, the preferred name matches the property name (so, `- (void)setBackgroundTransparency:(double)backgroundTransparency {` would be correct).\r\n- Why the `+ 10` in `-[ProfilePreferencesViewController awakeFromNib]`? Looks fine without it to me.\r\n- The `/////// Background transparency` comments in ProfilesWindowPreferencesViewController.m should be removed or improved (if you keep them, don't use lots of /s, just the two that are required)\r\n- In general, avoid lines over 100 characters, unless it would compromise readability. For example, in ProfilesWindowPreferencesViewController.m:94\r\n"}}