{"push_id":872841782,"size":12,"distinct_size":1,"ref":"refs/heads/nimullen/razor.thctho.358","head":"a91c5d19d05a398b626ed75d9fb4544cc4067605","before":"5aea8372e0d2cbd08e3d0adb721a5f7de52f0681","commits":[{"sha":"349b2f3963c515e854a09c492f64c270ff8110e1","author":{"email":"2375fa63e2908bb2df59f606483a3aa92321db7a@krymets.com","name":"Pavel Krymets"},"message":"Add HttpContextAccessor because Hostring doesn't do it by default","distinct":false,"url":"https://api.github.com/repos/aspnet/Mvc/commits/349b2f3963c515e854a09c492f64c270ff8110e1"},{"sha":"08dd77d8c7a00e4282dff599ca180f16b32f359c","author":{"email":"5d776ea9396d98a140d5ae5e892e751bebdb8bfb@microsoft.com","name":"Doug Bunting"},"message":"Add relative view path support\n- #3307\n- relative paths are now supported in `View()` calls from components and view components,\n  `Html.PartialAsync()` and similar calls, and `RazorPage.Layout` settings.\n  - support absolute paths, relative paths, and view location lookups consistently / everywhere\n  - support view paths in `TemplateRenderer` e.g. passing an absolute path to `Html.EditorFor()`\n- take a big swing at the `IRazorViewEngine` and `IViewEngine` interfaces\n  - split lookups (view names) from navigation (view paths)\n  - remove `Partial` separation; use parameters to set `IsPartial` properties\n- correct `ViewContext` copy constructor and add unit test\n- extend unit tests to cover relative paths\n  - fix existing tests to handle newly-required extension in an absolute path\n- add functional test that chains relative paths\n\nnits:\n- remove some YOLO line wrapping\n- `\"\"` -> `string.Empty`","distinct":false,"url":"https://api.github.com/repos/aspnet/Mvc/commits/08dd77d8c7a00e4282dff599ca180f16b32f359c"},{"sha":"d1fe824b5d5e50d51c3be182342d632022bd666c","author":{"email":"5d776ea9396d98a140d5ae5e892e751bebdb8bfb@microsoft.com","name":"Doug Bunting"},"message":"Improve `SearchLocations` handling\n- do not blindly use `FindPage()` / `FindView()` result in `Exception.Message` or returned results\n  - failure scenarios involve new `Any()` calls but rarely additional `List<string>()` allocations\n- change `ViewEngine_ViewNotFound` resource to be consistent with similar errors\n  - remove trailing period at end of searched locations list\n\nnit: remove remaining `null` checks of `SearchedLocations` in not found cases; never `null` then","distinct":false,"url":"https://api.github.com/repos/aspnet/Mvc/commits/d1fe824b5d5e50d51c3be182342d632022bd666c"},{"sha":"cf30bb730fdcbd8df51dad26a920ba8f4ecc757a","author":{"email":"5d776ea9396d98a140d5ae5e892e751bebdb8bfb@microsoft.com","name":"Doug Bunting"},"message":"PR comments and some smallish cleanup\n- `IRazorViewEngine.MakePathAbsolute()` -> `GetAbsolutePath()`\n- set `IsPartial` on all `IRazorPage` instances\n- improve consistency of methods in `HtmlHelperPartialExtensions`\n  - a couple unnecessarily passed `htmlHelper.ViewData`\n  - add missing tests of these extension methods\n- restore parameter checks in `CompositeViewEngine`\n- reduce `List<string>` and remove enumerator allocations in `CompositeViewEngine`\n\nnits:\n- correct a few comments\n- use `<seealso/>`","distinct":false,"url":"https://api.github.com/repos/aspnet/Mvc/commits/cf30bb730fdcbd8df51dad26a920ba8f4ecc757a"},{"sha":"3be6167aa093033a71ab6822fbc9199b4731a030","author":{"email":"5d776ea9396d98a140d5ae5e892e751bebdb8bfb@microsoft.com","name":"Doug Bunting"},"message":"Switch concepts from misnamed `isPartial` to `isMainPage`\n- `true` has the opposite meaning now but most changes are due to new parameters names in `IViewEngine`\n  - use name names in `Microsoft.AspNet.Mvc.ViewFound` and not found events\n- remove `IRazorPage.IsPartial` and `RazorView.IsPartial`\n  - remove `IsPartial` properties from `Microsoft.AspNet.Mvc.Razor.BeginInstrumentationContext` and end events\n- add parameter checks to `RazorView` constructor; instances are not retrieved from DI\n\nnits:\n- remove unused `cacheKey` parameter from `RazorViewEngine.CreateCacheResult()`\n- correct duplicate test names in `RazorPageTest`\n  - also `...OnPageExecutionListenerContext` -> `...OnPageExecutionContext`","distinct":false,"url":"https://api.github.com/repos/aspnet/Mvc/commits/3be6167aa093033a71ab6822fbc9199b4731a030"},{"sha":"95b3d2c1ddc7491ccc9bf297f7a8688cde5d8ae2","author":{"email":"5d776ea9396d98a140d5ae5e892e751bebdb8bfb@microsoft.com","name":"Doug Bunting"},"message":"Address PR comments\n- removed `isMainPage` parameter to `GetPage()` and `FindPage()`","distinct":false,"url":"https://api.github.com/repos/aspnet/Mvc/commits/95b3d2c1ddc7491ccc9bf297f7a8688cde5d8ae2"},{"sha":"155bde0fcf54f7e1c602957ea380b09bfb4f6b29","author":{"email":"ffb1c3cb43d4d3339a9d45f1dd93330c25cd9aa1@hotmail.com","name":"Pranav K"},"message":"Pass in the area name instead of the view name to a parameter that\nrequires an area name.\n\nFixes #3556","distinct":false,"url":"https://api.github.com/repos/aspnet/Mvc/commits/155bde0fcf54f7e1c602957ea380b09bfb4f6b29"},{"sha":"d6bda0ec11d7d29782cb19b09073ea67710ce8a5","author":{"email":"9ee1eb54eabc39e905f4364545c101eb73de15aa@gmail.com","name":"Ryan Nowak"},"message":"CompilerCache should not compile multiple assemblies for the same page.\n\nFixes #3469","distinct":false,"url":"https://api.github.com/repos/aspnet/Mvc/commits/d6bda0ec11d7d29782cb19b09073ea67710ce8a5"},{"sha":"79d74127b92ff5cabd6a9a047b07cb0cdb9e2c90","author":{"email":"5d776ea9396d98a140d5ae5e892e751bebdb8bfb@microsoft.com","name":"Doug Bunting"},"message":"Add temporary workarounds for aspnet/External#50 and aspnet/Mvc#3587","distinct":false,"url":"https://api.github.com/repos/aspnet/Mvc/commits/79d74127b92ff5cabd6a9a047b07cb0cdb9e2c90"},{"sha":"f25aab8df7ef935a6d4c67a0ba112de6621ad29d","author":{"email":"2375fa63e2908bb2df59f606483a3aa92321db7a@krymets.com","name":"Pavel Krymets"},"message":"React to hosting changes","distinct":false,"url":"https://api.github.com/repos/aspnet/Mvc/commits/f25aab8df7ef935a6d4c67a0ba112de6621ad29d"},{"sha":"46cd4ac1f00316fe5b5badf385aef0d4c2c8fa60","author":{"email":"f5b5abaed3fa04b0b61785994c278d4851fcc90b@mail.utoronto.ca","name":"John Luo"},"message":"Reacting to ApplicationServices removal from HttpContext","distinct":false,"url":"https://api.github.com/repos/aspnet/Mvc/commits/46cd4ac1f00316fe5b5badf385aef0d4c2c8fa60"},{"sha":"a91c5d19d05a398b626ed75d9fb4544cc4067605","author":{"email":"2dd1590fd832a5e1c8567d718938b5e15c0e595b@microsoft.com","name":"N. Taylor Mullen"},"message":"React to aspnet/Razor#358.\n\n- Removed `WriteTagHelperAsync` methods from `RazorPage`.\n- Moved `WriteTagHelperAsync` tests into Razor since `TagHelperOutput` is now an `IHtmlContent`.\n- Updated code generation test files.\n\naspnet/Razor#358","distinct":true,"url":"https://api.github.com/repos/aspnet/Mvc/commits/a91c5d19d05a398b626ed75d9fb4544cc4067605"}]}