{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/650","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/650/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/650/comments","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/650/events","html_url":"https://github.com/cfpb/cfgov-refresh/pull/650","id":87843036,"number":650,"title":"Updates activity feed macros structure + adds cfpb_report type","user":{"login":"anselmbradford","id":704760,"avatar_url":"https://avatars.githubusercontent.com/u/704760?v=3","gravatar_id":"","url":"https://api.github.com/users/anselmbradford","html_url":"https://github.com/anselmbradford","followers_url":"https://api.github.com/users/anselmbradford/followers","following_url":"https://api.github.com/users/anselmbradford/following{/other_user}","gists_url":"https://api.github.com/users/anselmbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/anselmbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anselmbradford/subscriptions","organizations_url":"https://api.github.com/users/anselmbradford/orgs","repos_url":"https://api.github.com/users/anselmbradford/repos","events_url":"https://api.github.com/users/anselmbradford/events{/privacy}","received_events_url":"https://api.github.com/users/anselmbradford/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-06-12T20:35:36Z","updated_at":"2015-06-12T21:59:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/650","html_url":"https://github.com/cfpb/cfgov-refresh/pull/650","diff_url":"https://github.com/cfpb/cfgov-refresh/pull/650.diff","patch_url":"https://github.com/cfpb/cfgov-refresh/pull/650.patch"},"body":"Updates activity feed and related macros to use structure in https://github.com/cfpb/cfgov-refresh/issues/597\r\n\r\n## Additions\r\n\r\n- Added `cfpb_report` activity type to activities feed macro.\r\n\r\n## Changes\r\n\r\nMoved `activity_snippets` macro from `post-macros.html` to `macros/activity-snippet.html`\r\n  and adds render method.\r\n- Made `activity_snippet` macro private.\r\n- Moved `category_icon` macro from `post-macros.html` to `macros/category-icon.html`\r\n  and adds render method.\r\n- Moved `string_length` macro from `macros.html` to `macros/util/text.html`.\r\n\r\n## Testing\r\n\r\n- /offices/* and /sub_pages/* should display activities feeds as expected. \r\n\r\n## Review\r\n\r\n- @KimberlyMunoz \r\n- @jimmynotjim \r\n- @sebworks \r\n- @kurtw \r\n\r\n## Notes\r\n\r\n- Reports should show up when those are available in WP.\r\n- Since it's hard to see the changes to the macros, they are as follows:\r\n  - `cfpb_reports` activity type being added to https://github.com/cfpb/cfgov-refresh/pull/650/files#diff-5fedd58294eea4b46fe2e524f52ad20dR20, \r\n  - activity_snippet made private (also code comment on L:43 is updated) https://github.com/cfpb/cfgov-refresh/pull/650/files#diff-5fedd58294eea4b46fe2e524f52ad20dR37\r\n  - activity_snippets update to use render method like other macros that spit out HTML templates https://github.com/cfpb/cfgov-refresh/pull/650/files#diff-5fedd58294eea4b46fe2e524f52ad20dR20"},"comment":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments/111629015","html_url":"https://github.com/cfpb/cfgov-refresh/pull/650#issuecomment-111629015","issue_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/650","id":111629015,"user":{"login":"sebworks","id":1696212,"avatar_url":"https://avatars.githubusercontent.com/u/1696212?v=3","gravatar_id":"","url":"https://api.github.com/users/sebworks","html_url":"https://github.com/sebworks","followers_url":"https://api.github.com/users/sebworks/followers","following_url":"https://api.github.com/users/sebworks/following{/other_user}","gists_url":"https://api.github.com/users/sebworks/gists{/gist_id}","starred_url":"https://api.github.com/users/sebworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebworks/subscriptions","organizations_url":"https://api.github.com/users/sebworks/orgs","repos_url":"https://api.github.com/users/sebworks/repos","events_url":"https://api.github.com/users/sebworks/events{/privacy}","received_events_url":"https://api.github.com/users/sebworks/received_events","type":"User","site_admin":false},"created_at":"2015-06-12T21:59:46Z","updated_at":"2015-06-12T21:59:46Z","body":":+1: , not sure on the cfpb_reports actvity type but I would suggest just creating an issue for it and we can talk with @kurtw on Monday. Merge at will."}}