{"action":"opened","number":259,"pull_request":{"url":"https://api.github.com/repos/pynbody/pynbody/pulls/259","id":41099087,"html_url":"https://github.com/pynbody/pynbody/pull/259","diff_url":"https://github.com/pynbody/pynbody/pull/259.diff","patch_url":"https://github.com/pynbody/pynbody/pull/259.patch","issue_url":"https://api.github.com/repos/pynbody/pynbody/issues/259","number":259,"state":"open","locked":false,"title":"added family check when returning loadable arrays","user":{"login":"rokroskar","id":3353586,"avatar_url":"https://avatars.githubusercontent.com/u/3353586?v=3","gravatar_id":"","url":"https://api.github.com/users/rokroskar","html_url":"https://github.com/rokroskar","followers_url":"https://api.github.com/users/rokroskar/followers","following_url":"https://api.github.com/users/rokroskar/following{/other_user}","gists_url":"https://api.github.com/users/rokroskar/gists{/gist_id}","starred_url":"https://api.github.com/users/rokroskar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rokroskar/subscriptions","organizations_url":"https://api.github.com/users/rokroskar/orgs","repos_url":"https://api.github.com/users/rokroskar/repos","events_url":"https://api.github.com/users/rokroskar/events{/privacy}","received_events_url":"https://api.github.com/users/rokroskar/received_events","type":"User","site_admin":false},"body":"we omitted a check for family arrays when constructing loadable keys as reported in #256 -- this PR adds the few lines from gadget.py to make it work properly. Output is now: \r\n```ipython\r\nIn [1]: import pynbody\r\n\r\nIn [2]: s =pynbody.load('python_src/pynbody/nose/testdata/Test_NOSN_NOZCOOL_L010N0128/data/snapshot_103/snap_103.hdf5')\r\n\r\nIn [3]: s.loadable_keys()\r\nOut[3]: ['pos', 'phi', 'mass', 'vel', 'iord']\r\n\r\nIn [4]: s.g.loadable_keys()\r\nOut[4]:\r\n['temp',\r\n u'SmoothedElementAbundance/Helium',\r\n 'rho',\r\n 'Fe',\r\n u'AExpMaximumEntropy',\r\n 'pos',\r\n 'H',\r\n 'phi',\r\n u'SmoothedElementAbundance/Oxygen',\r\n u'SmoothedElementAbundance/Hydrogen',\r\n 'O',\r\n 'Ne',\r\n u'AExpMaximumTemperature',\r\n u'InternalEnergy',\r\n u'SmoothedElementAbundance/Iron',\r\n 'smooth',\r\n 'metals',\r\n 'C',\r\n u'MetallicityWeightedRedshift',\r\n u'SmoothedElementAbundance/Carbon',\r\n 'smetals',\r\n u'StarFormationRate',\r\n 'N',\r\n 'mass',\r\n u'WindFlag',\r\n 'vel',\r\n 'Mg',\r\n u'SmoothedElementAbundance/Nitrogen',\r\n u'MaximumTemperature',\r\n 'Si',\r\n 'He',\r\n u'MaximumEntropy',\r\n u'SmoothedElementAbundance/Neon',\r\n u'SmoothedIronFromSNIa',\r\n u'IronFromSNIa',\r\n u'SmoothedElementAbundance/Magnesium',\r\n u'OnEquationOfState',\r\n u'SmoothedElementAbundance/Silicon',\r\n 'iord']\r\n\r\nIn [5]: s.d.loadable_keys()\r\nOut[5]: ['pos', 'phi', 'mass', 'vel', 'iord']\r\n\r\nIn [6]: s.s.loadable_keys()\r\nOut[6]:\r\n[u'SmoothedElementAbundance/Helium',\r\n 'rho',\r\n 'Fe',\r\n u'AExpMaximumEntropy',\r\n 'pos',\r\n u'InitialMass',\r\n 'H',\r\n 'phi',\r\n u'SmoothedElementAbundance/Oxygen',\r\n u'SmoothedElementAbundance/Hydrogen',\r\n 'O',\r\n 'Ne',\r\n u'AExpMaximumTemperature',\r\n u'SmoothedElementAbundance/Iron',\r\n 'tform',\r\n 'smooth',\r\n 'metals',\r\n 'C',\r\n u'MetallicityWeightedRedshift',\r\n u'SmoothedElementAbundance/Carbon',\r\n 'smetals',\r\n 'N',\r\n 'mass',\r\n u'WindFlag',\r\n 'vel',\r\n 'Mg',\r\n u'SmoothedElementAbundance/Nitrogen',\r\n u'MaximumTemperature',\r\n 'Si',\r\n 'He',\r\n u'MaximumEntropy',\r\n u'SmoothedElementAbundance/Neon',\r\n u'SmoothedIronFromSNIa',\r\n u'IronFromSNIa',\r\n u'SmoothedElementAbundance/Magnesium',\r\n u'SmoothedElementAbundance/Silicon',\r\n 'iord']\r\n```","created_at":"2015-07-29T08:39:26Z","updated_at":"2015-07-29T08:39:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pynbody/pynbody/pulls/259/commits","review_comments_url":"https://api.github.com/repos/pynbody/pynbody/pulls/259/comments","review_comment_url":"https://api.github.com/repos/pynbody/pynbody/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pynbody/pynbody/issues/259/comments","statuses_url":"https://api.github.com/repos/pynbody/pynbody/statuses/ca7f739e6468b6544ba3a37eae7749797d554edb","head":{"label":"pynbody:fix_hdf_loadable_keys","ref":"fix_hdf_loadable_keys","sha":"ca7f739e6468b6544ba3a37eae7749797d554edb","user":{"login":"pynbody","id":4417908,"avatar_url":"https://avatars.githubusercontent.com/u/4417908?v=3","gravatar_id":"","url":"https://api.github.com/users/pynbody","html_url":"https://github.com/pynbody","followers_url":"https://api.github.com/users/pynbody/followers","following_url":"https://api.github.com/users/pynbody/following{/other_user}","gists_url":"https://api.github.com/users/pynbody/gists{/gist_id}","starred_url":"https://api.github.com/users/pynbody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pynbody/subscriptions","organizations_url":"https://api.github.com/users/pynbody/orgs","repos_url":"https://api.github.com/users/pynbody/repos","events_url":"https://api.github.com/users/pynbody/events{/privacy}","received_events_url":"https://api.github.com/users/pynbody/received_events","type":"Organization","site_admin":false},"repo":{"id":10058773,"name":"pynbody","full_name":"pynbody/pynbody","owner":{"login":"pynbody","id":4417908,"avatar_url":"https://avatars.githubusercontent.com/u/4417908?v=3","gravatar_id":"","url":"https://api.github.com/users/pynbody","html_url":"https://github.com/pynbody","followers_url":"https://api.github.com/users/pynbody/followers","following_url":"https://api.github.com/users/pynbody/following{/other_user}","gists_url":"https://api.github.com/users/pynbody/gists{/gist_id}","starred_url":"https://api.github.com/users/pynbody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pynbody/subscriptions","organizations_url":"https://api.github.com/users/pynbody/orgs","repos_url":"https://api.github.com/users/pynbody/repos","events_url":"https://api.github.com/users/pynbody/events{/privacy}","received_events_url":"https://api.github.com/users/pynbody/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pynbody/pynbody","description":"N-body and hydro analysis tools for python 2 and 3","fork":false,"url":"https://api.github.com/repos/pynbody/pynbody","forks_url":"https://api.github.com/repos/pynbody/pynbody/forks","keys_url":"https://api.github.com/repos/pynbody/pynbody/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pynbody/pynbody/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pynbody/pynbody/teams","hooks_url":"https://api.github.com/repos/pynbody/pynbody/hooks","issue_events_url":"https://api.github.com/repos/pynbody/pynbody/issues/events{/number}","events_url":"https://api.github.com/repos/pynbody/pynbody/events","assignees_url":"https://api.github.com/repos/pynbody/pynbody/assignees{/user}","branches_url":"https://api.github.com/repos/pynbody/pynbody/branches{/branch}","tags_url":"https://api.github.com/repos/pynbody/pynbody/tags","blobs_url":"https://api.github.com/repos/pynbody/pynbody/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pynbody/pynbody/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pynbody/pynbody/git/refs{/sha}","trees_url":"https://api.github.com/repos/pynbody/pynbody/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pynbody/pynbody/statuses/{sha}","languages_url":"https://api.github.com/repos/pynbody/pynbody/languages","stargazers_url":"https://api.github.com/repos/pynbody/pynbody/stargazers","contributors_url":"https://api.github.com/repos/pynbody/pynbody/contributors","subscribers_url":"https://api.github.com/repos/pynbody/pynbody/subscribers","subscription_url":"https://api.github.com/repos/pynbody/pynbody/subscription","commits_url":"https://api.github.com/repos/pynbody/pynbody/commits{/sha}","git_commits_url":"https://api.github.com/repos/pynbody/pynbody/git/commits{/sha}","comments_url":"https://api.github.com/repos/pynbody/pynbody/comments{/number}","issue_comment_url":"https://api.github.com/repos/pynbody/pynbody/issues/comments{/number}","contents_url":"https://api.github.com/repos/pynbody/pynbody/contents/{+path}","compare_url":"https://api.github.com/repos/pynbody/pynbody/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pynbody/pynbody/merges","archive_url":"https://api.github.com/repos/pynbody/pynbody/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pynbody/pynbody/downloads","issues_url":"https://api.github.com/repos/pynbody/pynbody/issues{/number}","pulls_url":"https://api.github.com/repos/pynbody/pynbody/pulls{/number}","milestones_url":"https://api.github.com/repos/pynbody/pynbody/milestones{/number}","notifications_url":"https://api.github.com/repos/pynbody/pynbody/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pynbody/pynbody/labels{/name}","releases_url":"https://api.github.com/repos/pynbody/pynbody/releases{/id}","created_at":"2013-05-14T15:46:59Z","updated_at":"2015-07-25T08:05:05Z","pushed_at":"2015-07-29T08:36:39Z","git_url":"git://github.com/pynbody/pynbody.git","ssh_url":"git@github.com:pynbody/pynbody.git","clone_url":"https://github.com/pynbody/pynbody.git","svn_url":"https://github.com/pynbody/pynbody","homepage":"http://pynbody.github.io/pynbody/index.html","size":208319,"stargazers_count":41,"watchers_count":41,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":35,"forks":23,"open_issues":35,"watchers":41,"default_branch":"master"}},"base":{"label":"pynbody:master","ref":"master","sha":"4ec5edfd4783c96948a999c5bc2fdff414142da0","user":{"login":"pynbody","id":4417908,"avatar_url":"https://avatars.githubusercontent.com/u/4417908?v=3","gravatar_id":"","url":"https://api.github.com/users/pynbody","html_url":"https://github.com/pynbody","followers_url":"https://api.github.com/users/pynbody/followers","following_url":"https://api.github.com/users/pynbody/following{/other_user}","gists_url":"https://api.github.com/users/pynbody/gists{/gist_id}","starred_url":"https://api.github.com/users/pynbody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pynbody/subscriptions","organizations_url":"https://api.github.com/users/pynbody/orgs","repos_url":"https://api.github.com/users/pynbody/repos","events_url":"https://api.github.com/users/pynbody/events{/privacy}","received_events_url":"https://api.github.com/users/pynbody/received_events","type":"Organization","site_admin":false},"repo":{"id":10058773,"name":"pynbody","full_name":"pynbody/pynbody","owner":{"login":"pynbody","id":4417908,"avatar_url":"https://avatars.githubusercontent.com/u/4417908?v=3","gravatar_id":"","url":"https://api.github.com/users/pynbody","html_url":"https://github.com/pynbody","followers_url":"https://api.github.com/users/pynbody/followers","following_url":"https://api.github.com/users/pynbody/following{/other_user}","gists_url":"https://api.github.com/users/pynbody/gists{/gist_id}","starred_url":"https://api.github.com/users/pynbody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pynbody/subscriptions","organizations_url":"https://api.github.com/users/pynbody/orgs","repos_url":"https://api.github.com/users/pynbody/repos","events_url":"https://api.github.com/users/pynbody/events{/privacy}","received_events_url":"https://api.github.com/users/pynbody/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pynbody/pynbody","description":"N-body and hydro analysis tools for python 2 and 3","fork":false,"url":"https://api.github.com/repos/pynbody/pynbody","forks_url":"https://api.github.com/repos/pynbody/pynbody/forks","keys_url":"https://api.github.com/repos/pynbody/pynbody/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pynbody/pynbody/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pynbody/pynbody/teams","hooks_url":"https://api.github.com/repos/pynbody/pynbody/hooks","issue_events_url":"https://api.github.com/repos/pynbody/pynbody/issues/events{/number}","events_url":"https://api.github.com/repos/pynbody/pynbody/events","assignees_url":"https://api.github.com/repos/pynbody/pynbody/assignees{/user}","branches_url":"https://api.github.com/repos/pynbody/pynbody/branches{/branch}","tags_url":"https://api.github.com/repos/pynbody/pynbody/tags","blobs_url":"https://api.github.com/repos/pynbody/pynbody/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pynbody/pynbody/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pynbody/pynbody/git/refs{/sha}","trees_url":"https://api.github.com/repos/pynbody/pynbody/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pynbody/pynbody/statuses/{sha}","languages_url":"https://api.github.com/repos/pynbody/pynbody/languages","stargazers_url":"https://api.github.com/repos/pynbody/pynbody/stargazers","contributors_url":"https://api.github.com/repos/pynbody/pynbody/contributors","subscribers_url":"https://api.github.com/repos/pynbody/pynbody/subscribers","subscription_url":"https://api.github.com/repos/pynbody/pynbody/subscription","commits_url":"https://api.github.com/repos/pynbody/pynbody/commits{/sha}","git_commits_url":"https://api.github.com/repos/pynbody/pynbody/git/commits{/sha}","comments_url":"https://api.github.com/repos/pynbody/pynbody/comments{/number}","issue_comment_url":"https://api.github.com/repos/pynbody/pynbody/issues/comments{/number}","contents_url":"https://api.github.com/repos/pynbody/pynbody/contents/{+path}","compare_url":"https://api.github.com/repos/pynbody/pynbody/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pynbody/pynbody/merges","archive_url":"https://api.github.com/repos/pynbody/pynbody/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pynbody/pynbody/downloads","issues_url":"https://api.github.com/repos/pynbody/pynbody/issues{/number}","pulls_url":"https://api.github.com/repos/pynbody/pynbody/pulls{/number}","milestones_url":"https://api.github.com/repos/pynbody/pynbody/milestones{/number}","notifications_url":"https://api.github.com/repos/pynbody/pynbody/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pynbody/pynbody/labels{/name}","releases_url":"https://api.github.com/repos/pynbody/pynbody/releases{/id}","created_at":"2013-05-14T15:46:59Z","updated_at":"2015-07-25T08:05:05Z","pushed_at":"2015-07-29T08:36:39Z","git_url":"git://github.com/pynbody/pynbody.git","ssh_url":"git@github.com:pynbody/pynbody.git","clone_url":"https://github.com/pynbody/pynbody.git","svn_url":"https://github.com/pynbody/pynbody","homepage":"http://pynbody.github.io/pynbody/index.html","size":208319,"stargazers_count":41,"watchers_count":41,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":35,"forks":23,"open_issues":35,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pynbody/pynbody/pulls/259"},"html":{"href":"https://github.com/pynbody/pynbody/pull/259"},"issue":{"href":"https://api.github.com/repos/pynbody/pynbody/issues/259"},"comments":{"href":"https://api.github.com/repos/pynbody/pynbody/issues/259/comments"},"review_comments":{"href":"https://api.github.com/repos/pynbody/pynbody/pulls/259/comments"},"review_comment":{"href":"https://api.github.com/repos/pynbody/pynbody/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pynbody/pynbody/pulls/259/commits"},"statuses":{"href":"https://api.github.com/repos/pynbody/pynbody/statuses/ca7f739e6468b6544ba3a37eae7749797d554edb"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":1,"changed_files":1}}