{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/ripple-lib/pulls/comments/46863460","id":46863460,"diff_hunk":"@@ -5,7 +5,8 @@\n   \"properties\": {\n     \"ledger\": {\n       \"$ref\": \"getLedger\",\n-      \"description\": \"The ledger header to hash.\"\n+      \"description\": \"The ledger header to hash.\",\n+      \"position\": 0","path":"src/common/schemas/input/compute-ledger-hash.json","position":6,"original_position":6,"commit_id":"181767ee3e489df969d6631d99e969ce8a4c85c3","original_commit_id":"181767ee3e489df969d6631d99e969ce8a4c85c3","user":{"login":"clark800","id":1238722,"avatar_url":"https://avatars.githubusercontent.com/u/1238722?v=3","gravatar_id":"","url":"https://api.github.com/users/clark800","html_url":"https://github.com/clark800","followers_url":"https://api.github.com/users/clark800/followers","following_url":"https://api.github.com/users/clark800/following{/other_user}","gists_url":"https://api.github.com/users/clark800/gists{/gist_id}","starred_url":"https://api.github.com/users/clark800/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clark800/subscriptions","organizations_url":"https://api.github.com/users/clark800/orgs","repos_url":"https://api.github.com/users/clark800/repos","events_url":"https://api.github.com/users/clark800/events{/privacy}","received_events_url":"https://api.github.com/users/clark800/received_events","type":"User","site_admin":false},"body":"This is not a very robust solution because it can get out of sync with the actual method signatures. I think it would be better to use the same technique that jayson uses to get the method parameter ordering.","created_at":"2015-12-07T19:21:05Z","updated_at":"2015-12-07T19:21:05Z","html_url":"https://github.com/ripple/ripple-lib/pull/663#discussion_r46863460","pull_request_url":"https://api.github.com/repos/ripple/ripple-lib/pulls/663","_links":{"self":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/comments/46863460"},"html":{"href":"https://github.com/ripple/ripple-lib/pull/663#discussion_r46863460"},"pull_request":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/663"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/ripple-lib/pulls/663","id":52615684,"html_url":"https://github.com/ripple/ripple-lib/pull/663","diff_url":"https://github.com/ripple/ripple-lib/pull/663.diff","patch_url":"https://github.com/ripple/ripple-lib/pull/663.patch","issue_url":"https://api.github.com/repos/ripple/ripple-lib/issues/663","number":663,"state":"open","locked":false,"title":"http server example","user":{"login":"darkdarkdragon","id":2035357,"avatar_url":"https://avatars.githubusercontent.com/u/2035357?v=3","gravatar_id":"","url":"https://api.github.com/users/darkdarkdragon","html_url":"https://github.com/darkdarkdragon","followers_url":"https://api.github.com/users/darkdarkdragon/followers","following_url":"https://api.github.com/users/darkdarkdragon/following{/other_user}","gists_url":"https://api.github.com/users/darkdarkdragon/gists{/gist_id}","starred_url":"https://api.github.com/users/darkdarkdragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkdarkdragon/subscriptions","organizations_url":"https://api.github.com/users/darkdarkdragon/orgs","repos_url":"https://api.github.com/users/darkdarkdragon/repos","events_url":"https://api.github.com/users/darkdarkdragon/events{/privacy}","received_events_url":"https://api.github.com/users/darkdarkdragon/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-04T00:47:01Z","updated_at":"2015-12-07T19:21:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f546191d826790d31743fbf456c97c7b1dd76a6d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ripple/ripple-lib/pulls/663/commits","review_comments_url":"https://api.github.com/repos/ripple/ripple-lib/pulls/663/comments","review_comment_url":"https://api.github.com/repos/ripple/ripple-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/ripple-lib/issues/663/comments","statuses_url":"https://api.github.com/repos/ripple/ripple-lib/statuses/181767ee3e489df969d6631d99e969ce8a4c85c3","head":{"label":"darkdarkdragon:develop-http-server","ref":"develop-http-server","sha":"181767ee3e489df969d6631d99e969ce8a4c85c3","user":{"login":"darkdarkdragon","id":2035357,"avatar_url":"https://avatars.githubusercontent.com/u/2035357?v=3","gravatar_id":"","url":"https://api.github.com/users/darkdarkdragon","html_url":"https://github.com/darkdarkdragon","followers_url":"https://api.github.com/users/darkdarkdragon/followers","following_url":"https://api.github.com/users/darkdarkdragon/following{/other_user}","gists_url":"https://api.github.com/users/darkdarkdragon/gists{/gist_id}","starred_url":"https://api.github.com/users/darkdarkdragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkdarkdragon/subscriptions","organizations_url":"https://api.github.com/users/darkdarkdragon/orgs","repos_url":"https://api.github.com/users/darkdarkdragon/repos","events_url":"https://api.github.com/users/darkdarkdragon/events{/privacy}","received_events_url":"https://api.github.com/users/darkdarkdragon/received_events","type":"User","site_admin":false},"repo":{"id":29372989,"name":"ripple-lib","full_name":"darkdarkdragon/ripple-lib","owner":{"login":"darkdarkdragon","id":2035357,"avatar_url":"https://avatars.githubusercontent.com/u/2035357?v=3","gravatar_id":"","url":"https://api.github.com/users/darkdarkdragon","html_url":"https://github.com/darkdarkdragon","followers_url":"https://api.github.com/users/darkdarkdragon/followers","following_url":"https://api.github.com/users/darkdarkdragon/following{/other_user}","gists_url":"https://api.github.com/users/darkdarkdragon/gists{/gist_id}","starred_url":"https://api.github.com/users/darkdarkdragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkdarkdragon/subscriptions","organizations_url":"https://api.github.com/users/darkdarkdragon/orgs","repos_url":"https://api.github.com/users/darkdarkdragon/repos","events_url":"https://api.github.com/users/darkdarkdragon/events{/privacy}","received_events_url":"https://api.github.com/users/darkdarkdragon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darkdarkdragon/ripple-lib","description":"A JavaScript API for interacting with Ripple in Node.js and the browser","fork":true,"url":"https://api.github.com/repos/darkdarkdragon/ripple-lib","forks_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/forks","keys_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/teams","hooks_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/hooks","issue_events_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/issues/events{/number}","events_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/events","assignees_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/assignees{/user}","branches_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/branches{/branch}","tags_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/tags","blobs_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/languages","stargazers_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/stargazers","contributors_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/contributors","subscribers_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/subscribers","subscription_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/subscription","commits_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/contents/{+path}","compare_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/merges","archive_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/downloads","issues_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/issues{/number}","pulls_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/labels{/name}","releases_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/releases{/id}","created_at":"2015-01-16T23:42:55Z","updated_at":"2015-04-23T21:59:17Z","pushed_at":"2015-12-07T11:12:05Z","git_url":"git://github.com/darkdarkdragon/ripple-lib.git","ssh_url":"git@github.com:darkdarkdragon/ripple-lib.git","clone_url":"https://github.com/darkdarkdragon/ripple-lib.git","svn_url":"https://github.com/darkdarkdragon/ripple-lib","homepage":"","size":12928,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"8d8a850864ce258dfc7fe93e991846b1779bd005","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":9681561,"name":"ripple-lib","full_name":"ripple/ripple-lib","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/ripple-lib","description":"A JavaScript API for interacting with Ripple in Node.js and the browser","fork":false,"url":"https://api.github.com/repos/ripple/ripple-lib","forks_url":"https://api.github.com/repos/ripple/ripple-lib/forks","keys_url":"https://api.github.com/repos/ripple/ripple-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/ripple-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/ripple-lib/teams","hooks_url":"https://api.github.com/repos/ripple/ripple-lib/hooks","issue_events_url":"https://api.github.com/repos/ripple/ripple-lib/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/ripple-lib/events","assignees_url":"https://api.github.com/repos/ripple/ripple-lib/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/ripple-lib/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/ripple-lib/tags","blobs_url":"https://api.github.com/repos/ripple/ripple-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/ripple-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/ripple-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/ripple-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/ripple-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/ripple-lib/languages","stargazers_url":"https://api.github.com/repos/ripple/ripple-lib/stargazers","contributors_url":"https://api.github.com/repos/ripple/ripple-lib/contributors","subscribers_url":"https://api.github.com/repos/ripple/ripple-lib/subscribers","subscription_url":"https://api.github.com/repos/ripple/ripple-lib/subscription","commits_url":"https://api.github.com/repos/ripple/ripple-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/ripple-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/ripple-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/ripple-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/ripple-lib/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/ripple-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/ripple-lib/merges","archive_url":"https://api.github.com/repos/ripple/ripple-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/ripple-lib/downloads","issues_url":"https://api.github.com/repos/ripple/ripple-lib/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/ripple-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/ripple-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/ripple-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/ripple-lib/labels{/name}","releases_url":"https://api.github.com/repos/ripple/ripple-lib/releases{/id}","created_at":"2013-04-25T21:17:19Z","updated_at":"2015-12-06T11:43:51Z","pushed_at":"2015-12-07T11:12:06Z","git_url":"git://github.com/ripple/ripple-lib.git","ssh_url":"git@github.com:ripple/ripple-lib.git","clone_url":"https://github.com/ripple/ripple-lib.git","svn_url":"https://github.com/ripple/ripple-lib","homepage":"","size":13510,"stargazers_count":429,"watchers_count":429,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":162,"mirror_url":null,"open_issues_count":1,"forks":162,"open_issues":1,"watchers":429,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/663"},"html":{"href":"https://github.com/ripple/ripple-lib/pull/663"},"issue":{"href":"https://api.github.com/repos/ripple/ripple-lib/issues/663"},"comments":{"href":"https://api.github.com/repos/ripple/ripple-lib/issues/663/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/663/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/663/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/ripple-lib/statuses/181767ee3e489df969d6631d99e969ce8a4c85c3"}}}}