{"action":"created","issue":{"url":"https://api.github.com/repos/ChrisHonniball/ember-chosen/issues/6","labels_url":"https://api.github.com/repos/ChrisHonniball/ember-chosen/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/ChrisHonniball/ember-chosen/issues/6/comments","events_url":"https://api.github.com/repos/ChrisHonniball/ember-chosen/issues/6/events","html_url":"https://github.com/ChrisHonniball/ember-chosen/issues/6","id":104159916,"number":6,"title":"Use of Ember instead of lodash","user":{"login":"gentlefox","id":1613772,"avatar_url":"https://avatars.githubusercontent.com/u/1613772?v=3","gravatar_id":"","url":"https://api.github.com/users/gentlefox","html_url":"https://github.com/gentlefox","followers_url":"https://api.github.com/users/gentlefox/followers","following_url":"https://api.github.com/users/gentlefox/following{/other_user}","gists_url":"https://api.github.com/users/gentlefox/gists{/gist_id}","starred_url":"https://api.github.com/users/gentlefox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentlefox/subscriptions","organizations_url":"https://api.github.com/users/gentlefox/orgs","repos_url":"https://api.github.com/users/gentlefox/repos","events_url":"https://api.github.com/users/gentlefox/events{/privacy}","received_events_url":"https://api.github.com/users/gentlefox/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-01T00:35:08Z","updated_at":"2015-09-10T19:41:58Z","closed_at":"2015-09-10T19:41:58Z","body":"Curious why you are using lodash instead of in-built methods available in Ember. :interrobang: \r\n\r\nie:\r\n\r\n    // line 146\r\n    groups = _.uniq(groupNames);\r\n    // could be:\r\n    groups = Ember.computed.uniq(groupNames);\r\n\r\nThe other use of lodash, while more efficient, barely warrants the inclusion of a whole library.\r\n\r\n    // line 372\r\n    var found = _.indexOf(optionValue);\r\n    // becomes:\r\n    var found = value.indexOf(optionValue);\r\n\r\nAlso \"Unless Ember.EXTEND_PROTOTYPES.String is false these methods will also be added to the String.prototype as well.\", meaning anything using \"Ember.String\" can use String. In this case I understand it is for greater compatibility for those not using EXTEND_PROTOTYPES."},"comment":{"url":"https://api.github.com/repos/ChrisHonniball/ember-chosen/issues/comments/139357329","html_url":"https://github.com/ChrisHonniball/ember-chosen/issues/6#issuecomment-139357329","issue_url":"https://api.github.com/repos/ChrisHonniball/ember-chosen/issues/6","id":139357329,"user":{"login":"ChrisHonniball","id":3345374,"avatar_url":"https://avatars.githubusercontent.com/u/3345374?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisHonniball","html_url":"https://github.com/ChrisHonniball","followers_url":"https://api.github.com/users/ChrisHonniball/followers","following_url":"https://api.github.com/users/ChrisHonniball/following{/other_user}","gists_url":"https://api.github.com/users/ChrisHonniball/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisHonniball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisHonniball/subscriptions","organizations_url":"https://api.github.com/users/ChrisHonniball/orgs","repos_url":"https://api.github.com/users/ChrisHonniball/repos","events_url":"https://api.github.com/users/ChrisHonniball/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisHonniball/received_events","type":"User","site_admin":false},"created_at":"2015-09-10T19:41:58Z","updated_at":"2015-09-10T19:41:58Z","body":":+1: Lodash dependency removed."}}