{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/43284683","id":43284683,"diff_hunk":"@@ -694,17 +738,25 @@ def destroy(name, call=None):\n     data = show_instance(name, call='action')\n     node = query(method='droplets', droplet_id=data['id'], http_method='delete')\n \n-    delete_record = config.get_cloud_config_value(\n-        'delete_dns_record', get_configured_provider(), __opts__, search_global=False, default=None,\n-    )\n+    ## This is all terribly optomistic:\n+    # vm_ = get_vm_config(name=name)\n+    # delete_dns_record = config.get_cloud_config_value(\n+    #     'delete_dns_record', vm_, __opts__, search_global=False, default=None,\n+    # )\n+    delete_dns_record = True\n \n-    if delete_record and not isinstance(delete_record, bool):\n+    if delete_dns_record and not isinstance(delete_dns_record, bool):","path":"salt/cloud/clouds/digital_ocean.py","position":84,"original_position":84,"commit_id":"6c63c58c5a26ffad69fda95cc88b5a3a5d0c48bf","original_commit_id":"6c63c58c5a26ffad69fda95cc88b5a3a5d0c48bf","user":{"login":"aphor","id":232123,"avatar_url":"https://avatars.githubusercontent.com/u/232123?v=3","gravatar_id":"","url":"https://api.github.com/users/aphor","html_url":"https://github.com/aphor","followers_url":"https://api.github.com/users/aphor/followers","following_url":"https://api.github.com/users/aphor/following{/other_user}","gists_url":"https://api.github.com/users/aphor/gists{/gist_id}","starred_url":"https://api.github.com/users/aphor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aphor/subscriptions","organizations_url":"https://api.github.com/users/aphor/orgs","repos_url":"https://api.github.com/users/aphor/repos","events_url":"https://api.github.com/users/aphor/events{/privacy}","received_events_url":"https://api.github.com/users/aphor/received_events","type":"User","site_admin":false},"body":"The explanation/fix for this also applies to the next comment.","created_at":"2015-10-28T16:57:35Z","updated_at":"2015-10-28T16:57:35Z","html_url":"https://github.com/saltstack/salt/pull/28180#discussion_r43284683","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/28180","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/43284683"},"html":{"href":"https://github.com/saltstack/salt/pull/28180#discussion_r43284683"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/28180"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/28180","id":48378832,"html_url":"https://github.com/saltstack/salt/pull/28180","diff_url":"https://github.com/saltstack/salt/pull/28180.diff","patch_url":"https://github.com/saltstack/salt/pull/28180.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/28180","number":28180,"state":"open","locked":false,"title":"Digital ocean saltcloud dns record creation and deletion implemented","user":{"login":"aphor","id":232123,"avatar_url":"https://avatars.githubusercontent.com/u/232123?v=3","gravatar_id":"","url":"https://api.github.com/users/aphor","html_url":"https://github.com/aphor","followers_url":"https://api.github.com/users/aphor/followers","following_url":"https://api.github.com/users/aphor/following{/other_user}","gists_url":"https://api.github.com/users/aphor/gists{/gist_id}","starred_url":"https://api.github.com/users/aphor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aphor/subscriptions","organizations_url":"https://api.github.com/users/aphor/orgs","repos_url":"https://api.github.com/users/aphor/repos","events_url":"https://api.github.com/users/aphor/events{/privacy}","received_events_url":"https://api.github.com/users/aphor/received_events","type":"User","site_admin":false},"body":"Due to design problems in salt-cloud (no way to make configuration data available to destroy methods), DNS record deletion unconditionally deletes all DNS records matching the given FQDN if it can.","created_at":"2015-10-21T19:50:59Z","updated_at":"2015-10-28T16:57:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"febda8af40745ce94965311af0e5f6c8d9606819","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/28180/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/28180/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/28180/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/6c63c58c5a26ffad69fda95cc88b5a3a5d0c48bf","head":{"label":"aphor:digital_ocean_saltcloud_dns","ref":"digital_ocean_saltcloud_dns","sha":"6c63c58c5a26ffad69fda95cc88b5a3a5d0c48bf","user":{"login":"aphor","id":232123,"avatar_url":"https://avatars.githubusercontent.com/u/232123?v=3","gravatar_id":"","url":"https://api.github.com/users/aphor","html_url":"https://github.com/aphor","followers_url":"https://api.github.com/users/aphor/followers","following_url":"https://api.github.com/users/aphor/following{/other_user}","gists_url":"https://api.github.com/users/aphor/gists{/gist_id}","starred_url":"https://api.github.com/users/aphor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aphor/subscriptions","organizations_url":"https://api.github.com/users/aphor/orgs","repos_url":"https://api.github.com/users/aphor/repos","events_url":"https://api.github.com/users/aphor/events{/privacy}","received_events_url":"https://api.github.com/users/aphor/received_events","type":"User","site_admin":false},"repo":{"id":44411797,"name":"salt","full_name":"aphor/salt","owner":{"login":"aphor","id":232123,"avatar_url":"https://avatars.githubusercontent.com/u/232123?v=3","gravatar_id":"","url":"https://api.github.com/users/aphor","html_url":"https://github.com/aphor","followers_url":"https://api.github.com/users/aphor/followers","following_url":"https://api.github.com/users/aphor/following{/other_user}","gists_url":"https://api.github.com/users/aphor/gists{/gist_id}","starred_url":"https://api.github.com/users/aphor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aphor/subscriptions","organizations_url":"https://api.github.com/users/aphor/orgs","repos_url":"https://api.github.com/users/aphor/repos","events_url":"https://api.github.com/users/aphor/events{/privacy}","received_events_url":"https://api.github.com/users/aphor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aphor/salt","description":"Infrastructure automation and management system","fork":true,"url":"https://api.github.com/repos/aphor/salt","forks_url":"https://api.github.com/repos/aphor/salt/forks","keys_url":"https://api.github.com/repos/aphor/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aphor/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aphor/salt/teams","hooks_url":"https://api.github.com/repos/aphor/salt/hooks","issue_events_url":"https://api.github.com/repos/aphor/salt/issues/events{/number}","events_url":"https://api.github.com/repos/aphor/salt/events","assignees_url":"https://api.github.com/repos/aphor/salt/assignees{/user}","branches_url":"https://api.github.com/repos/aphor/salt/branches{/branch}","tags_url":"https://api.github.com/repos/aphor/salt/tags","blobs_url":"https://api.github.com/repos/aphor/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aphor/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aphor/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/aphor/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aphor/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/aphor/salt/languages","stargazers_url":"https://api.github.com/repos/aphor/salt/stargazers","contributors_url":"https://api.github.com/repos/aphor/salt/contributors","subscribers_url":"https://api.github.com/repos/aphor/salt/subscribers","subscription_url":"https://api.github.com/repos/aphor/salt/subscription","commits_url":"https://api.github.com/repos/aphor/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/aphor/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/aphor/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/aphor/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/aphor/salt/contents/{+path}","compare_url":"https://api.github.com/repos/aphor/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aphor/salt/merges","archive_url":"https://api.github.com/repos/aphor/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aphor/salt/downloads","issues_url":"https://api.github.com/repos/aphor/salt/issues{/number}","pulls_url":"https://api.github.com/repos/aphor/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/aphor/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/aphor/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aphor/salt/labels{/name}","releases_url":"https://api.github.com/repos/aphor/salt/releases{/id}","created_at":"2015-10-16T21:36:09Z","updated_at":"2015-10-16T21:36:37Z","pushed_at":"2015-10-23T20:46:52Z","git_url":"git://github.com/aphor/salt.git","ssh_url":"git@github.com:aphor/salt.git","clone_url":"https://github.com/aphor/salt.git","svn_url":"https://github.com/aphor/salt","homepage":"saltstack.com","size":125630,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"625a1294457069f086468ef2efb3bc404e0ebac9","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Infrastructure automation and management system","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","created_at":"2011-02-20T20:16:56Z","updated_at":"2015-10-28T14:24:23Z","pushed_at":"2015-10-28T16:44:20Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"saltstack.com","size":256077,"stargazers_count":5800,"watchers_count":5800,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2475,"mirror_url":null,"open_issues_count":3049,"forks":2475,"open_issues":3049,"watchers":5800,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/28180"},"html":{"href":"https://github.com/saltstack/salt/pull/28180"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/28180"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/28180/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/28180/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/28180/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/6c63c58c5a26ffad69fda95cc88b5a3a5d0c48bf"}}}}