{"action":"opened","issue":{"url":"https://api.github.com/repos/sosol/sosol/issues/129","labels_url":"https://api.github.com/repos/sosol/sosol/issues/129/labels{/name}","comments_url":"https://api.github.com/repos/sosol/sosol/issues/129/comments","events_url":"https://api.github.com/repos/sosol/sosol/issues/129/events","html_url":"https://github.com/sosol/sosol/issues/129","id":116865792,"number":129,"title":"epi_cts_identifier.preprocess_for_finalization should return false","user":{"login":"balmas","id":644870,"avatar_url":"https://avatars.githubusercontent.com/u/644870?v=3","gravatar_id":"","url":"https://api.github.com/users/balmas","html_url":"https://github.com/balmas","followers_url":"https://api.github.com/users/balmas/followers","following_url":"https://api.github.com/users/balmas/following{/other_user}","gists_url":"https://api.github.com/users/balmas/gists{/gist_id}","starred_url":"https://api.github.com/users/balmas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balmas/subscriptions","organizations_url":"https://api.github.com/users/balmas/orgs","repos_url":"https://api.github.com/users/balmas/repos","events_url":"https://api.github.com/users/balmas/events{/privacy}","received_events_url":"https://api.github.com/users/balmas/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sosol/sosol/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/sosol/sosol/labels/CTS%20Identifiers","name":"CTS Identifiers","color":"eb6420"},{"url":"https://api.github.com/repos/sosol/sosol/labels/Perseids%20Features","name":"Perseids Features","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"balmas","id":644870,"avatar_url":"https://avatars.githubusercontent.com/u/644870?v=3","gravatar_id":"","url":"https://api.github.com/users/balmas","html_url":"https://github.com/balmas","followers_url":"https://api.github.com/users/balmas/followers","following_url":"https://api.github.com/users/balmas/following{/other_user}","gists_url":"https://api.github.com/users/balmas/gists{/gist_id}","starred_url":"https://api.github.com/users/balmas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balmas/subscriptions","organizations_url":"https://api.github.com/users/balmas/orgs","repos_url":"https://api.github.com/users/balmas/repos","events_url":"https://api.github.com/users/balmas/events{/privacy}","received_events_url":"https://api.github.com/users/balmas/received_events","type":"User","site_admin":false},"milestone":null,"comments":0,"created_at":"2015-11-13T22:27:22Z","updated_at":"2015-11-13T22:27:22Z","closed_at":null,"body":"the preprocess_for_finalization method in the epi_cts_identifier model class checks to see if the identifier content comes from an external agent, and if so, it calls agent-specific handling to post the content to the agent before continuing with the finalization step.\r\n\r\nThis will probably be refactored (see #128)  in the upcoming communities and boards rewrite because the logic really belongs there and not on the identifier class.\r\n\r\nBut in the meantime, we need to return false from this method because we aren't actually  modifying the identifier, and for a publication with multiple identifiers it causes the handling in publications controller to fail, because it returns true with an unmodified identifier, and causes a looping error"}}