{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/31941648","id":31941648,"diff_hunk":"@@ -921,11 +921,65 @@ private bool ScanInteger()\n             return start < TextWindow.Position;\n         }\n \n+        // Allows underscores in integers, except at beginning and end\n+        private void ScanNumericLiteralSingleInteger(StringBuilder builder, ref bool underscoreInWrongPlace, bool isHex, bool isBinary)\n+        {\n+            if (TextWindow.PeekChar() == '_')\n+            {\n+                underscoreInWrongPlace = true;\n+            }\n+\n+            char ch;\n+            var lastCharWasUnderscore = false;\n+            while (true)\n+            {\n+                ch = TextWindow.PeekChar();\n+                if (ch == '_')\n+                {\n+                    CheckFeatureAvailability(MessageID.IDS_FeatureDigitSeparator);","path":"src/Compilers/CSharp/Portable/Parser/Lexer.cs","position":19,"original_position":19,"commit_id":"fd77862673c1c6e4c66d99d44d1c8fcf44de16f6","original_commit_id":"fd77862673c1c6e4c66d99d44d1c8fcf44de16f6","user":{"login":"gafter","id":3804346,"avatar_url":"https://avatars.githubusercontent.com/u/3804346?v=3","gravatar_id":"","url":"https://api.github.com/users/gafter","html_url":"https://github.com/gafter","followers_url":"https://api.github.com/users/gafter/followers","following_url":"https://api.github.com/users/gafter/following{/other_user}","gists_url":"https://api.github.com/users/gafter/gists{/gist_id}","starred_url":"https://api.github.com/users/gafter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gafter/subscriptions","organizations_url":"https://api.github.com/users/gafter/orgs","repos_url":"https://api.github.com/users/gafter/repos","events_url":"https://api.github.com/users/gafter/events{/privacy}","received_events_url":"https://api.github.com/users/gafter/received_events","type":"User","site_admin":false},"body":"This should probably be done once rather than on every `_`, as it appears in the VB implementation.","created_at":"2015-06-08T18:01:05Z","updated_at":"2015-06-08T18:01:05Z","html_url":"https://github.com/dotnet/roslyn/pull/2950#discussion_r31941648","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2950","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/31941648"},"html":{"href":"https://github.com/dotnet/roslyn/pull/2950#discussion_r31941648"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2950"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/2950","id":35869427,"html_url":"https://github.com/dotnet/roslyn/pull/2950","diff_url":"https://github.com/dotnet/roslyn/pull/2950.diff","patch_url":"https://github.com/dotnet/roslyn/pull/2950.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/2950","number":2950,"state":"open","locked":false,"title":"Numeric literals (binary and digit separators)","user":{"login":"khyperia","id":953151,"avatar_url":"https://avatars.githubusercontent.com/u/953151?v=3","gravatar_id":"","url":"https://api.github.com/users/khyperia","html_url":"https://github.com/khyperia","followers_url":"https://api.github.com/users/khyperia/followers","following_url":"https://api.github.com/users/khyperia/following{/other_user}","gists_url":"https://api.github.com/users/khyperia/gists{/gist_id}","starred_url":"https://api.github.com/users/khyperia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khyperia/subscriptions","organizations_url":"https://api.github.com/users/khyperia/orgs","repos_url":"https://api.github.com/users/khyperia/repos","events_url":"https://api.github.com/users/khyperia/events{/privacy}","received_events_url":"https://api.github.com/users/khyperia/received_events","type":"User","site_admin":false},"body":"This PR implements binary literals for C# and VB, as well as digit separators (underscores) for both C# and VB. It also implements a feature check and two /features flags for binary literals and digit separators, again for both C# and VB.\r\n\r\nThis implements proposals #215 and #216\r\n\r\nOriginal PR [here](https://github.com/dotnet/roslyn/pull/2730), closed due to branching reorganization.\r\n\r\n@gafter @jaredpar @VSadov @AlekseyTs @agocke Please review","created_at":"2015-05-20T19:55:16Z","updated_at":"2015-06-08T18:01:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34c4bec6a4bb28056f3e4df0a0b6845f5f096cc1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2950/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2950/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/2950/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/fd77862673c1c6e4c66d99d44d1c8fcf44de16f6","head":{"label":"khyperia:NumericLiterals","ref":"NumericLiterals","sha":"fd77862673c1c6e4c66d99d44d1c8fcf44de16f6","user":{"login":"khyperia","id":953151,"avatar_url":"https://avatars.githubusercontent.com/u/953151?v=3","gravatar_id":"","url":"https://api.github.com/users/khyperia","html_url":"https://github.com/khyperia","followers_url":"https://api.github.com/users/khyperia/followers","following_url":"https://api.github.com/users/khyperia/following{/other_user}","gists_url":"https://api.github.com/users/khyperia/gists{/gist_id}","starred_url":"https://api.github.com/users/khyperia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khyperia/subscriptions","organizations_url":"https://api.github.com/users/khyperia/orgs","repos_url":"https://api.github.com/users/khyperia/repos","events_url":"https://api.github.com/users/khyperia/events{/privacy}","received_events_url":"https://api.github.com/users/khyperia/received_events","type":"User","site_admin":false},"repo":{"id":35454040,"name":"roslyn","full_name":"khyperia/roslyn","owner":{"login":"khyperia","id":953151,"avatar_url":"https://avatars.githubusercontent.com/u/953151?v=3","gravatar_id":"","url":"https://api.github.com/users/khyperia","html_url":"https://github.com/khyperia","followers_url":"https://api.github.com/users/khyperia/followers","following_url":"https://api.github.com/users/khyperia/following{/other_user}","gists_url":"https://api.github.com/users/khyperia/gists{/gist_id}","starred_url":"https://api.github.com/users/khyperia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khyperia/subscriptions","organizations_url":"https://api.github.com/users/khyperia/orgs","repos_url":"https://api.github.com/users/khyperia/repos","events_url":"https://api.github.com/users/khyperia/events{/privacy}","received_events_url":"https://api.github.com/users/khyperia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/khyperia/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/khyperia/roslyn","forks_url":"https://api.github.com/repos/khyperia/roslyn/forks","keys_url":"https://api.github.com/repos/khyperia/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khyperia/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khyperia/roslyn/teams","hooks_url":"https://api.github.com/repos/khyperia/roslyn/hooks","issue_events_url":"https://api.github.com/repos/khyperia/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/khyperia/roslyn/events","assignees_url":"https://api.github.com/repos/khyperia/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/khyperia/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/khyperia/roslyn/tags","blobs_url":"https://api.github.com/repos/khyperia/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khyperia/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khyperia/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/khyperia/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khyperia/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/khyperia/roslyn/languages","stargazers_url":"https://api.github.com/repos/khyperia/roslyn/stargazers","contributors_url":"https://api.github.com/repos/khyperia/roslyn/contributors","subscribers_url":"https://api.github.com/repos/khyperia/roslyn/subscribers","subscription_url":"https://api.github.com/repos/khyperia/roslyn/subscription","commits_url":"https://api.github.com/repos/khyperia/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/khyperia/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/khyperia/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/khyperia/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/khyperia/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/khyperia/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khyperia/roslyn/merges","archive_url":"https://api.github.com/repos/khyperia/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khyperia/roslyn/downloads","issues_url":"https://api.github.com/repos/khyperia/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/khyperia/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/khyperia/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/khyperia/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khyperia/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/khyperia/roslyn/releases{/id}","created_at":"2015-05-11T22:43:33Z","updated_at":"2015-05-11T22:44:02Z","pushed_at":"2015-06-08T16:32:23Z","git_url":"git://github.com/khyperia/roslyn.git","ssh_url":"git@github.com:khyperia/roslyn.git","clone_url":"https://github.com/khyperia/roslyn.git","svn_url":"https://github.com/khyperia/roslyn","homepage":"","size":82579,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:future","ref":"future","sha":"b7ae5c349b3c2c5539be415556adbf2b642d6160","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-06-08T17:34:41Z","pushed_at":"2015-06-08T17:51:54Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":138323,"stargazers_count":2459,"watchers_count":2459,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":530,"mirror_url":null,"open_issues_count":930,"forks":530,"open_issues":930,"watchers":2459,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2950"},"html":{"href":"https://github.com/dotnet/roslyn/pull/2950"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/2950"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/2950/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2950/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2950/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/fd77862673c1c6e4c66d99d44d1c8fcf44de16f6"}}}}