{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph-deploy/pulls/comments/31047144","id":31047144,"diff_hunk":"@@ -19,6 +21,18 @@ def test_help(tmpdir, cli):\n     assert 'optional arguments' in result\n \n \n+def test_bad_no_mon(tmpdir, cli):\n+    with pytest.raises(cli.Failed) as err:\n+        with cli(\n+            args=['ceph-deploy', 'new'],\n+            stderr=subprocess.PIPE,\n+            ) as p:\n+            result = p.stderr.read()\n+    assert 'usage: ceph-deploy new' in result","path":"ceph_deploy/tests/test_cli_new.py","position":29,"original_position":29,"commit_id":"060c4c38f8d4a260cb63b9e336e9f2a9e362ca21","original_commit_id":"060c4c38f8d4a260cb63b9e336e9f2a9e362ca21","user":{"login":"trhoden","id":1627176,"avatar_url":"https://avatars.githubusercontent.com/u/1627176?v=3","gravatar_id":"","url":"https://api.github.com/users/trhoden","html_url":"https://github.com/trhoden","followers_url":"https://api.github.com/users/trhoden/followers","following_url":"https://api.github.com/users/trhoden/following{/other_user}","gists_url":"https://api.github.com/users/trhoden/gists{/gist_id}","starred_url":"https://api.github.com/users/trhoden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trhoden/subscriptions","organizations_url":"https://api.github.com/users/trhoden/orgs","repos_url":"https://api.github.com/users/trhoden/repos","events_url":"https://api.github.com/users/trhoden/events{/privacy}","received_events_url":"https://api.github.com/users/trhoden/received_events","type":"User","site_admin":false},"body":"@alfredodeza yeah, good point.  An excellent area to clean up.  I took the multiple asserts directly from the existing tests for ``--help``, e.g. https://github.com/ceph/ceph-deploy/blob/master/ceph_deploy/tests/test_cli_install.py#L11-L13","created_at":"2015-05-26T15:36:09Z","updated_at":"2015-05-26T15:36:09Z","html_url":"https://github.com/ceph/ceph-deploy/pull/301#discussion_r31047144","pull_request_url":"https://api.github.com/repos/ceph/ceph-deploy/pulls/301","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-deploy/pulls/comments/31047144"},"html":{"href":"https://github.com/ceph/ceph-deploy/pull/301#discussion_r31047144"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph-deploy/pulls/301"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph-deploy/pulls/301","id":36143528,"html_url":"https://github.com/ceph/ceph-deploy/pull/301","diff_url":"https://github.com/ceph/ceph-deploy/pull/301.diff","patch_url":"https://github.com/ceph/ceph-deploy/pull/301.patch","issue_url":"https://api.github.com/repos/ceph/ceph-deploy/issues/301","number":301,"state":"open","locked":false,"title":"Some test cleanup","user":{"login":"trhoden","id":1627176,"avatar_url":"https://avatars.githubusercontent.com/u/1627176?v=3","gravatar_id":"","url":"https://api.github.com/users/trhoden","html_url":"https://github.com/trhoden","followers_url":"https://api.github.com/users/trhoden/followers","following_url":"https://api.github.com/users/trhoden/following{/other_user}","gists_url":"https://api.github.com/users/trhoden/gists{/gist_id}","starred_url":"https://api.github.com/users/trhoden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trhoden/subscriptions","organizations_url":"https://api.github.com/users/trhoden/orgs","repos_url":"https://api.github.com/users/trhoden/repos","events_url":"https://api.github.com/users/trhoden/events{/privacy}","received_events_url":"https://api.github.com/users/trhoden/received_events","type":"User","site_admin":false},"body":"First round of cleanup for tests that I've wanted to do.  Mostly just cleaning up some imports, and renaming some tests to reflect what they actually do.\r\n\r\nAdded a few new ones for consistency between the CLI commands.\r\n\r\nWant to see this run through Tox to see that py26 is okay with my changes.","created_at":"2015-05-25T14:43:07Z","updated_at":"2015-05-26T15:36:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6d8eb49a34785f4fb29e39e73060c2564d72a8a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph-deploy/pulls/301/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph-deploy/pulls/301/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph-deploy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph-deploy/issues/301/comments","statuses_url":"https://api.github.com/repos/ceph/ceph-deploy/statuses/060c4c38f8d4a260cb63b9e336e9f2a9e362ca21","head":{"label":"trhoden:RM-11742-test-cleanup","ref":"RM-11742-test-cleanup","sha":"060c4c38f8d4a260cb63b9e336e9f2a9e362ca21","user":{"login":"trhoden","id":1627176,"avatar_url":"https://avatars.githubusercontent.com/u/1627176?v=3","gravatar_id":"","url":"https://api.github.com/users/trhoden","html_url":"https://github.com/trhoden","followers_url":"https://api.github.com/users/trhoden/followers","following_url":"https://api.github.com/users/trhoden/following{/other_user}","gists_url":"https://api.github.com/users/trhoden/gists{/gist_id}","starred_url":"https://api.github.com/users/trhoden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trhoden/subscriptions","organizations_url":"https://api.github.com/users/trhoden/orgs","repos_url":"https://api.github.com/users/trhoden/repos","events_url":"https://api.github.com/users/trhoden/events{/privacy}","received_events_url":"https://api.github.com/users/trhoden/received_events","type":"User","site_admin":false},"repo":{"id":10270179,"name":"ceph-deploy","full_name":"trhoden/ceph-deploy","owner":{"login":"trhoden","id":1627176,"avatar_url":"https://avatars.githubusercontent.com/u/1627176?v=3","gravatar_id":"","url":"https://api.github.com/users/trhoden","html_url":"https://github.com/trhoden","followers_url":"https://api.github.com/users/trhoden/followers","following_url":"https://api.github.com/users/trhoden/following{/other_user}","gists_url":"https://api.github.com/users/trhoden/gists{/gist_id}","starred_url":"https://api.github.com/users/trhoden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trhoden/subscriptions","organizations_url":"https://api.github.com/users/trhoden/orgs","repos_url":"https://api.github.com/users/trhoden/repos","events_url":"https://api.github.com/users/trhoden/events{/privacy}","received_events_url":"https://api.github.com/users/trhoden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trhoden/ceph-deploy","description":"Deploy Ceph with minimal infrastructure, using just SSH access","fork":true,"url":"https://api.github.com/repos/trhoden/ceph-deploy","forks_url":"https://api.github.com/repos/trhoden/ceph-deploy/forks","keys_url":"https://api.github.com/repos/trhoden/ceph-deploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trhoden/ceph-deploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trhoden/ceph-deploy/teams","hooks_url":"https://api.github.com/repos/trhoden/ceph-deploy/hooks","issue_events_url":"https://api.github.com/repos/trhoden/ceph-deploy/issues/events{/number}","events_url":"https://api.github.com/repos/trhoden/ceph-deploy/events","assignees_url":"https://api.github.com/repos/trhoden/ceph-deploy/assignees{/user}","branches_url":"https://api.github.com/repos/trhoden/ceph-deploy/branches{/branch}","tags_url":"https://api.github.com/repos/trhoden/ceph-deploy/tags","blobs_url":"https://api.github.com/repos/trhoden/ceph-deploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trhoden/ceph-deploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trhoden/ceph-deploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/trhoden/ceph-deploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trhoden/ceph-deploy/statuses/{sha}","languages_url":"https://api.github.com/repos/trhoden/ceph-deploy/languages","stargazers_url":"https://api.github.com/repos/trhoden/ceph-deploy/stargazers","contributors_url":"https://api.github.com/repos/trhoden/ceph-deploy/contributors","subscribers_url":"https://api.github.com/repos/trhoden/ceph-deploy/subscribers","subscription_url":"https://api.github.com/repos/trhoden/ceph-deploy/subscription","commits_url":"https://api.github.com/repos/trhoden/ceph-deploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/trhoden/ceph-deploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/trhoden/ceph-deploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/trhoden/ceph-deploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/trhoden/ceph-deploy/contents/{+path}","compare_url":"https://api.github.com/repos/trhoden/ceph-deploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trhoden/ceph-deploy/merges","archive_url":"https://api.github.com/repos/trhoden/ceph-deploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trhoden/ceph-deploy/downloads","issues_url":"https://api.github.com/repos/trhoden/ceph-deploy/issues{/number}","pulls_url":"https://api.github.com/repos/trhoden/ceph-deploy/pulls{/number}","milestones_url":"https://api.github.com/repos/trhoden/ceph-deploy/milestones{/number}","notifications_url":"https://api.github.com/repos/trhoden/ceph-deploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trhoden/ceph-deploy/labels{/name}","releases_url":"https://api.github.com/repos/trhoden/ceph-deploy/releases{/id}","created_at":"2013-05-24T16:11:47Z","updated_at":"2015-05-07T20:50:13Z","pushed_at":"2015-05-25T16:04:05Z","git_url":"git://github.com/trhoden/ceph-deploy.git","ssh_url":"git@github.com:trhoden/ceph-deploy.git","clone_url":"https://github.com/trhoden/ceph-deploy.git","svn_url":"https://github.com/trhoden/ceph-deploy","homepage":null,"size":2271,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"10a0a3525d30a4e28f99675154a7d0bec847fa30","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":5786856,"name":"ceph-deploy","full_name":"ceph/ceph-deploy","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph-deploy","description":"Deploy Ceph with minimal infrastructure, using just SSH access","fork":false,"url":"https://api.github.com/repos/ceph/ceph-deploy","forks_url":"https://api.github.com/repos/ceph/ceph-deploy/forks","keys_url":"https://api.github.com/repos/ceph/ceph-deploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-deploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-deploy/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-deploy/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-deploy/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-deploy/events","assignees_url":"https://api.github.com/repos/ceph/ceph-deploy/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-deploy/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-deploy/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-deploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-deploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-deploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-deploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-deploy/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-deploy/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-deploy/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-deploy/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-deploy/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-deploy/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-deploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-deploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-deploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-deploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-deploy/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-deploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-deploy/merges","archive_url":"https://api.github.com/repos/ceph/ceph-deploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-deploy/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-deploy/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-deploy/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-deploy/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-deploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-deploy/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-deploy/releases{/id}","created_at":"2012-09-12T22:30:24Z","updated_at":"2015-05-18T11:14:56Z","pushed_at":"2015-05-26T15:21:00Z","git_url":"git://github.com/ceph/ceph-deploy.git","ssh_url":"git@github.com:ceph/ceph-deploy.git","clone_url":"https://github.com/ceph/ceph-deploy.git","svn_url":"https://github.com/ceph/ceph-deploy","homepage":null,"size":5350,"stargazers_count":100,"watchers_count":100,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":98,"mirror_url":null,"open_issues_count":7,"forks":98,"open_issues":7,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-deploy/pulls/301"},"html":{"href":"https://github.com/ceph/ceph-deploy/pull/301"},"issue":{"href":"https://api.github.com/repos/ceph/ceph-deploy/issues/301"},"comments":{"href":"https://api.github.com/repos/ceph/ceph-deploy/issues/301/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph-deploy/pulls/301/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph-deploy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph-deploy/pulls/301/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph-deploy/statuses/060c4c38f8d4a260cb63b9e336e9f2a9e362ca21"}}}}