{"action":"opened","number":941,"pull_request":{"url":"https://api.github.com/repos/wro4j/wro4j/pulls/941","id":34795976,"html_url":"https://github.com/wro4j/wro4j/pull/941","diff_url":"https://github.com/wro4j/wro4j/pull/941.diff","patch_url":"https://github.com/wro4j/wro4j/pull/941.patch","issue_url":"https://api.github.com/repos/wro4j/wro4j/issues/941","number":941,"state":"open","locked":false,"title":"Raise log level to avoid exceptions going unnoticed","user":{"login":"marcelstoer","id":624195,"avatar_url":"https://avatars.githubusercontent.com/u/624195?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelstoer","html_url":"https://github.com/marcelstoer","followers_url":"https://api.github.com/users/marcelstoer/followers","following_url":"https://api.github.com/users/marcelstoer/following{/other_user}","gists_url":"https://api.github.com/users/marcelstoer/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelstoer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelstoer/subscriptions","organizations_url":"https://api.github.com/users/marcelstoer/orgs","repos_url":"https://api.github.com/users/marcelstoer/repos","events_url":"https://api.github.com/users/marcelstoer/events{/privacy}","received_events_url":"https://api.github.com/users/marcelstoer/received_events","type":"User","site_admin":false},"body":"I don't think I understand the reasoning behind the existing code. I just spent 2h digging through Spring Web MVC Code that was invoked because `WroFilter` failed with an exception that went unnoticed. So, `WroFilter` failed and later something further down the processing chain (filters or servlets) failed.\r\nAdditional remarks:\r\n- I would even claim that if `WroFilter` fails with an exception it shouldn't continue processing the filter chain. I don't see how something useful could ever come out of the chain if wro4j processing failed.\r\n- I don't understand the comment in the `catch` block. My thinking is exactly opposite...particularly _because_ something should never happen I'd want to see this logged on ERROR level.","created_at":"2015-05-06T08:13:01Z","updated_at":"2015-05-06T08:13:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wro4j/wro4j/pulls/941/commits","review_comments_url":"https://api.github.com/repos/wro4j/wro4j/pulls/941/comments","review_comment_url":"https://api.github.com/repos/wro4j/wro4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wro4j/wro4j/issues/941/comments","statuses_url":"https://api.github.com/repos/wro4j/wro4j/statuses/8de70582afe1cc0616ca91ade7865eeb6ea8f1cd","head":{"label":"marcelstoer:WroFilter-logging-fix","ref":"WroFilter-logging-fix","sha":"8de70582afe1cc0616ca91ade7865eeb6ea8f1cd","user":{"login":"marcelstoer","id":624195,"avatar_url":"https://avatars.githubusercontent.com/u/624195?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelstoer","html_url":"https://github.com/marcelstoer","followers_url":"https://api.github.com/users/marcelstoer/followers","following_url":"https://api.github.com/users/marcelstoer/following{/other_user}","gists_url":"https://api.github.com/users/marcelstoer/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelstoer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelstoer/subscriptions","organizations_url":"https://api.github.com/users/marcelstoer/orgs","repos_url":"https://api.github.com/users/marcelstoer/repos","events_url":"https://api.github.com/users/marcelstoer/events{/privacy}","received_events_url":"https://api.github.com/users/marcelstoer/received_events","type":"User","site_admin":false},"repo":{"id":35146366,"name":"wro4j","full_name":"marcelstoer/wro4j","owner":{"login":"marcelstoer","id":624195,"avatar_url":"https://avatars.githubusercontent.com/u/624195?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelstoer","html_url":"https://github.com/marcelstoer","followers_url":"https://api.github.com/users/marcelstoer/followers","following_url":"https://api.github.com/users/marcelstoer/following{/other_user}","gists_url":"https://api.github.com/users/marcelstoer/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelstoer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelstoer/subscriptions","organizations_url":"https://api.github.com/users/marcelstoer/orgs","repos_url":"https://api.github.com/users/marcelstoer/repos","events_url":"https://api.github.com/users/marcelstoer/events{/privacy}","received_events_url":"https://api.github.com/users/marcelstoer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcelstoer/wro4j","description":"Free and Open Source Java project which brings together almost all the modern web tools: JsHint, CssLint, JsMin, Google Closure compressor, YUI Compressor, UglifyJs, Dojo Shrinksafe, Css Variables Support, JSON Compression, Less, Sass, CoffeeScript and much more. In the same time, the aim is to keep it as simple as possible and as extensible as possible in order to be easily adapted to application specific needs.","fork":true,"url":"https://api.github.com/repos/marcelstoer/wro4j","forks_url":"https://api.github.com/repos/marcelstoer/wro4j/forks","keys_url":"https://api.github.com/repos/marcelstoer/wro4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcelstoer/wro4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcelstoer/wro4j/teams","hooks_url":"https://api.github.com/repos/marcelstoer/wro4j/hooks","issue_events_url":"https://api.github.com/repos/marcelstoer/wro4j/issues/events{/number}","events_url":"https://api.github.com/repos/marcelstoer/wro4j/events","assignees_url":"https://api.github.com/repos/marcelstoer/wro4j/assignees{/user}","branches_url":"https://api.github.com/repos/marcelstoer/wro4j/branches{/branch}","tags_url":"https://api.github.com/repos/marcelstoer/wro4j/tags","blobs_url":"https://api.github.com/repos/marcelstoer/wro4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcelstoer/wro4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcelstoer/wro4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcelstoer/wro4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcelstoer/wro4j/statuses/{sha}","languages_url":"https://api.github.com/repos/marcelstoer/wro4j/languages","stargazers_url":"https://api.github.com/repos/marcelstoer/wro4j/stargazers","contributors_url":"https://api.github.com/repos/marcelstoer/wro4j/contributors","subscribers_url":"https://api.github.com/repos/marcelstoer/wro4j/subscribers","subscription_url":"https://api.github.com/repos/marcelstoer/wro4j/subscription","commits_url":"https://api.github.com/repos/marcelstoer/wro4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcelstoer/wro4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcelstoer/wro4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcelstoer/wro4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcelstoer/wro4j/contents/{+path}","compare_url":"https://api.github.com/repos/marcelstoer/wro4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcelstoer/wro4j/merges","archive_url":"https://api.github.com/repos/marcelstoer/wro4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcelstoer/wro4j/downloads","issues_url":"https://api.github.com/repos/marcelstoer/wro4j/issues{/number}","pulls_url":"https://api.github.com/repos/marcelstoer/wro4j/pulls{/number}","milestones_url":"https://api.github.com/repos/marcelstoer/wro4j/milestones{/number}","notifications_url":"https://api.github.com/repos/marcelstoer/wro4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcelstoer/wro4j/labels{/name}","releases_url":"https://api.github.com/repos/marcelstoer/wro4j/releases{/id}","created_at":"2015-05-06T07:54:45Z","updated_at":"2015-05-06T07:54:48Z","pushed_at":"2015-05-06T08:04:36Z","git_url":"git://github.com/marcelstoer/wro4j.git","ssh_url":"git@github.com:marcelstoer/wro4j.git","clone_url":"https://github.com/marcelstoer/wro4j.git","svn_url":"https://github.com/marcelstoer/wro4j","homepage":"http://wro4j.github.com/wro4j/","size":110853,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.7.x"}},"base":{"label":"wro4j:1.7.x","ref":"1.7.x","sha":"890131eff2880bc1af9a2714ea6e2682ea663412","user":{"login":"wro4j","id":2199088,"avatar_url":"https://avatars.githubusercontent.com/u/2199088?v=3","gravatar_id":"","url":"https://api.github.com/users/wro4j","html_url":"https://github.com/wro4j","followers_url":"https://api.github.com/users/wro4j/followers","following_url":"https://api.github.com/users/wro4j/following{/other_user}","gists_url":"https://api.github.com/users/wro4j/gists{/gist_id}","starred_url":"https://api.github.com/users/wro4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wro4j/subscriptions","organizations_url":"https://api.github.com/users/wro4j/orgs","repos_url":"https://api.github.com/users/wro4j/repos","events_url":"https://api.github.com/users/wro4j/events{/privacy}","received_events_url":"https://api.github.com/users/wro4j/received_events","type":"Organization","site_admin":false},"repo":{"id":32803313,"name":"wro4j","full_name":"wro4j/wro4j","owner":{"login":"wro4j","id":2199088,"avatar_url":"https://avatars.githubusercontent.com/u/2199088?v=3","gravatar_id":"","url":"https://api.github.com/users/wro4j","html_url":"https://github.com/wro4j","followers_url":"https://api.github.com/users/wro4j/followers","following_url":"https://api.github.com/users/wro4j/following{/other_user}","gists_url":"https://api.github.com/users/wro4j/gists{/gist_id}","starred_url":"https://api.github.com/users/wro4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wro4j/subscriptions","organizations_url":"https://api.github.com/users/wro4j/orgs","repos_url":"https://api.github.com/users/wro4j/repos","events_url":"https://api.github.com/users/wro4j/events{/privacy}","received_events_url":"https://api.github.com/users/wro4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wro4j/wro4j","description":"Free and Open Source Java project which brings together almost all the modern web tools: JsHint, CssLint, JsMin, Google Closure compressor, YUI Compressor, UglifyJs, Dojo Shrinksafe, Css Variables Support, JSON Compression, Less, Sass, CoffeeScript and much more. In the same time, the aim is to keep it as simple as possible and as extensible as possible in order to be easily adapted to application specific needs.","fork":false,"url":"https://api.github.com/repos/wro4j/wro4j","forks_url":"https://api.github.com/repos/wro4j/wro4j/forks","keys_url":"https://api.github.com/repos/wro4j/wro4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wro4j/wro4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wro4j/wro4j/teams","hooks_url":"https://api.github.com/repos/wro4j/wro4j/hooks","issue_events_url":"https://api.github.com/repos/wro4j/wro4j/issues/events{/number}","events_url":"https://api.github.com/repos/wro4j/wro4j/events","assignees_url":"https://api.github.com/repos/wro4j/wro4j/assignees{/user}","branches_url":"https://api.github.com/repos/wro4j/wro4j/branches{/branch}","tags_url":"https://api.github.com/repos/wro4j/wro4j/tags","blobs_url":"https://api.github.com/repos/wro4j/wro4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wro4j/wro4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wro4j/wro4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/wro4j/wro4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wro4j/wro4j/statuses/{sha}","languages_url":"https://api.github.com/repos/wro4j/wro4j/languages","stargazers_url":"https://api.github.com/repos/wro4j/wro4j/stargazers","contributors_url":"https://api.github.com/repos/wro4j/wro4j/contributors","subscribers_url":"https://api.github.com/repos/wro4j/wro4j/subscribers","subscription_url":"https://api.github.com/repos/wro4j/wro4j/subscription","commits_url":"https://api.github.com/repos/wro4j/wro4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/wro4j/wro4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/wro4j/wro4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/wro4j/wro4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/wro4j/wro4j/contents/{+path}","compare_url":"https://api.github.com/repos/wro4j/wro4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wro4j/wro4j/merges","archive_url":"https://api.github.com/repos/wro4j/wro4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wro4j/wro4j/downloads","issues_url":"https://api.github.com/repos/wro4j/wro4j/issues{/number}","pulls_url":"https://api.github.com/repos/wro4j/wro4j/pulls{/number}","milestones_url":"https://api.github.com/repos/wro4j/wro4j/milestones{/number}","notifications_url":"https://api.github.com/repos/wro4j/wro4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wro4j/wro4j/labels{/name}","releases_url":"https://api.github.com/repos/wro4j/wro4j/releases{/id}","created_at":"2015-03-24T14:21:00Z","updated_at":"2015-05-06T07:55:17Z","pushed_at":"2015-05-04T20:30:48Z","git_url":"git://github.com/wro4j/wro4j.git","ssh_url":"git@github.com:wro4j/wro4j.git","clone_url":"https://github.com/wro4j/wro4j.git","svn_url":"https://github.com/wro4j/wro4j","homepage":"http://wro4j.github.com/wro4j/","size":110853,"stargazers_count":27,"watchers_count":27,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":199,"forks":4,"open_issues":199,"watchers":27,"default_branch":"1.7.x"}},"_links":{"self":{"href":"https://api.github.com/repos/wro4j/wro4j/pulls/941"},"html":{"href":"https://github.com/wro4j/wro4j/pull/941"},"issue":{"href":"https://api.github.com/repos/wro4j/wro4j/issues/941"},"comments":{"href":"https://api.github.com/repos/wro4j/wro4j/issues/941/comments"},"review_comments":{"href":"https://api.github.com/repos/wro4j/wro4j/pulls/941/comments"},"review_comment":{"href":"https://api.github.com/repos/wro4j/wro4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wro4j/wro4j/pulls/941/commits"},"statuses":{"href":"https://api.github.com/repos/wro4j/wro4j/statuses/8de70582afe1cc0616ca91ade7865eeb6ea8f1cd"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":1}}