{"push_id":886744255,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"4ee48598c9be4af5e128db3f5cb0fffb4646e546","before":"a2b342369d2df7b9388460702ba4edd3701b6c60","commits":[{"sha":"4ee48598c9be4af5e128db3f5cb0fffb4646e546","author":{"email":"65d9c9c5b47c3d658914094a5e7a0cffc6353a37@chromium.org","name":"guoweis"},"message":"Reenable test cases for IP policy handling.\n\nPreviously, to workaround the problem that demo page loses connectivity when enforcing the IP policy, we use empty ice server array [] as a hint to generate loopback candidate. The design has since changed. Now, we will always provide the associated default local candidate when permission is denied. However, users could set preference to \"public interface only\" to disable this behavior.\n\nThe change is to modify the previously disabled test cases to reflect this behavior. Since it's no easy way to add fake interface in chrome test cases, loopback address is now used as the \"non-default\" local address, hence should only become one of candidates if the permission is granted and the IP policy is \"default\". (This is the opposite of previous behavior).\n\nSo the behavior is\n1. WebRtcBrowserTest::GatherLocalCandidatesWithPermissionGranted: when the permission is granted, AND policy is \"default\", we should have candidates and see the loopback address, ie. the non-default local address\n2. WebRtcBrowserIPPermissionDeniedTest: when the permission is denied, even if policy is \"default\", we should have candidate but not see the loopback address.\n3. WebRtcBrowserIPPolicyPublicAndPrivateInterfacesTest: when the ip policy is \"public and private interfaces\" (this is the same behavior as permission denied), even permission is granted, we should have candidate but not see the loopback address.\n4. WebRtcBrowserIPPolicyPublicInterfaceOnlyTest: when the ip policy is \"public interface only\", even permission is granted, we should not have any candidate since there is no stun server to discover the public interface.\n\nBUG=520101\n\nReview URL: https://codereview.chromium.org/1470303002\n\nCr-Commit-Position: refs/heads/master@{#362646}","distinct":true,"url":"https://api.github.com/repos/dstockwell/chromium/commits/4ee48598c9be4af5e128db3f5cb0fffb4646e546"}]}