{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/9870","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9870/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9870/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9870/events","html_url":"https://github.com/cms-sw/cmssw/pull/9870","id":90754197,"number":9870,"title":"Remove function getCentralityBinsFromDB","user":{"login":"wddgit","id":4295891,"avatar_url":"https://avatars.githubusercontent.com/u/4295891?v=3","gravatar_id":"","url":"https://api.github.com/users/wddgit","html_url":"https://github.com/wddgit","followers_url":"https://api.github.com/users/wddgit/followers","following_url":"https://api.github.com/users/wddgit/following{/other_user}","gists_url":"https://api.github.com/users/wddgit/gists{/gist_id}","starred_url":"https://api.github.com/users/wddgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wddgit/subscriptions","organizations_url":"https://api.github.com/users/wddgit/orgs","repos_url":"https://api.github.com/users/wddgit/repos","events_url":"https://api.github.com/users/wddgit/events{/privacy}","received_events_url":"https://api.github.com/users/wddgit/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fef2c0"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_6_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55/labels","id":1176788,"number":55,"title":"Next CMSSW_7_6_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":70,"closed_issues":31,"state":"open","created_at":"2015-06-23T07:27:04Z","updated_at":"2015-06-25T15:53:53Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2015-06-24T18:30:16Z","updated_at":"2015-06-25T16:40:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/9870","html_url":"https://github.com/cms-sw/cmssw/pull/9870","diff_url":"https://github.com/cms-sw/cmssw/pull/9870.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/9870.patch"},"body":"Remove function getCentralityBinsFromDB\r\nbecause it uses getProcessParameterSet.\r\ngetProcessParameterSet is a Framework function\r\nbeing removed from CMSSW because it does\r\nnot work in SubProcesses and causes issues\r\nfor multithreading. Note that\r\ngetCentralityBinsFromDB is being removed\r\ninstead of being repaired to use an alternative\r\nfor the following reasons.\r\n\r\nFirst, nothing in the release calls it. The\r\nonly thing that references it is one commented\r\nout line of code.\r\n\r\nThe function is in a DataFormats package and\r\naccesses the EventSetup. This dependence is\r\nnot allowed.\r\n\r\nThe function is used in modules and pulls\r\nconfiguration parameters from the top level\r\nparameter set instead of from the parameter\r\nset of the module that uses it. This is only\r\nallowed in very special cases. If this function\r\nwas to be repaired in the future it should be\r\nredesigned to get its configuration parameters\r\nfrom the module in some way.\r\n\r\nAlso made related fixes to the header includes."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/115318914","html_url":"https://github.com/cms-sw/cmssw/pull/9870#issuecomment-115318914","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9870","id":115318914,"user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"created_at":"2015-06-25T16:40:48Z","updated_at":"2015-06-25T16:40:48Z","body":"+1\r\n\r\nfor https://github.com/cms-sw/cmssw/pull/9870\t446ed69\r\n- code changes are as expected ; jenkins tests completed (compilation is enough in this case, in fact)"}}