{"action":"created","issue":{"url":"https://api.github.com/repos/nasa/PyAMPR/issues/3","labels_url":"https://api.github.com/repos/nasa/PyAMPR/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/nasa/PyAMPR/issues/3/comments","events_url":"https://api.github.com/repos/nasa/PyAMPR/issues/3/events","html_url":"https://github.com/nasa/PyAMPR/issues/3","id":74981731,"number":3,"title":"Add test suite","user":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars.githubusercontent.com/u/314716?v=3","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-05-10T19:18:13Z","updated_at":"2015-06-03T15:24:05Z","closed_at":"2015-06-03T15:24:05Z","body":"It would be good to have a test suite, even small, with an example file, which can be run to make sure that things are working correctly. This will be needed to ensure that any Python 3 transition does not break Python 2 compatibility (see #2). Once the test suite is written, a Continuous integration service like Travis can be used. Ping me if you would like advice on setting up Travis!"},"comment":{"url":"https://api.github.com/repos/nasa/PyAMPR/issues/comments/108481670","html_url":"https://github.com/nasa/PyAMPR/issues/3#issuecomment-108481670","issue_url":"https://api.github.com/repos/nasa/PyAMPR/issues/3","id":108481670,"user":{"login":"tjlang","id":3036387,"avatar_url":"https://avatars.githubusercontent.com/u/3036387?v=3","gravatar_id":"","url":"https://api.github.com/users/tjlang","html_url":"https://github.com/tjlang","followers_url":"https://api.github.com/users/tjlang/followers","following_url":"https://api.github.com/users/tjlang/following{/other_user}","gists_url":"https://api.github.com/users/tjlang/gists{/gist_id}","starred_url":"https://api.github.com/users/tjlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjlang/subscriptions","organizations_url":"https://api.github.com/users/tjlang/orgs","repos_url":"https://api.github.com/users/tjlang/repos","events_url":"https://api.github.com/users/tjlang/events{/privacy}","received_events_url":"https://api.github.com/users/tjlang/received_events","type":"User","site_admin":false},"created_at":"2015-06-03T15:24:05Z","updated_at":"2015-06-03T15:24:05Z","body":"I looked into writing unit tests. I am just not sure they are that useful to PyAMPR, since a healthy chunk of the code relates to plotting data. Moreover, Just about every unit test tutorial I've seen is not relevant to scientific applications. The testing modules are not particularly intuitive or easy to use either. \r\n\r\nWhat does make sense to me is an additional testing notebook with sample images to compare against, to make sure key PyAMPR elements do not get broken by future upgrades. So that is what I have provided in the latest commit. This notebook is complementary to the demonstration notebook. Taken together, they provide a way to test various components of the package using real data. It's not as formalized as focused unit tests, but I think it is way more intuitive approach for a science user of the package."}}