{"action":"closed","number":140,"pull_request":{"url":"https://api.github.com/repos/specta/expecta/pulls/140","id":32783966,"html_url":"https://github.com/specta/expecta/pull/140","diff_url":"https://github.com/specta/expecta/pull/140.diff","patch_url":"https://github.com/specta/expecta/pull/140.patch","issue_url":"https://api.github.com/repos/specta/expecta/issues/140","number":140,"state":"closed","locked":false,"title":"Create separate framework test targets","user":{"login":"erichoracek","id":438313,"avatar_url":"https://avatars.githubusercontent.com/u/438313?v=3","gravatar_id":"","url":"https://api.github.com/users/erichoracek","html_url":"https://github.com/erichoracek","followers_url":"https://api.github.com/users/erichoracek/followers","following_url":"https://api.github.com/users/erichoracek/following{/other_user}","gists_url":"https://api.github.com/users/erichoracek/gists{/gist_id}","starred_url":"https://api.github.com/users/erichoracek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erichoracek/subscriptions","organizations_url":"https://api.github.com/users/erichoracek/orgs","repos_url":"https://api.github.com/users/erichoracek/repos","events_url":"https://api.github.com/users/erichoracek/events{/privacy}","received_events_url":"https://api.github.com/users/erichoracek/received_events","type":"User","site_admin":false},"body":"When you attempt to build the Expecta-iOS framework scheme via the following command with the iOS 7.1 Simulator installed:\r\n\r\n```\r\nxcodebuild build -scheme 'Expecta-iOS'\r\n```\r\n\r\nYou'll receive the following error:\r\n\r\n```\r\nxcodebuild: error: Failed to build project Expecta with scheme Expecta-iOS.\r\n\tReason: The run destination iPad 2 is not valid for Running the scheme 'Expecta-iOS'.\r\n```\r\n\r\nThis is due to the fact that the `Expecta-iOS` framework scheme is currently configured to run tests using the `Expecta-iOSTests` target. However, this is an incorrect configuration, as the `Expecta-iOSTests` target does not actually depend on the framework target, but rather depends on the static library target. As such, running the Expecta-iOSTests target will not actually test the framework target. To fix this, I've:\r\n\r\n- Renamed the old test targets as `libExpectaTests` and `libExpectaTests-iOS`\r\n- Created new test targets `ExpectaTests` and `ExpectaTests-iOS` for the framework targets, to ensure that both integration options (framework or static library) can be properly tested","created_at":"2015-04-07T17:00:29Z","updated_at":"2015-04-07T17:54:50Z","closed_at":"2015-04-07T17:54:50Z","merged_at":"2015-04-07T17:54:50Z","merge_commit_sha":"341225a725f32860ca702565e39c70e5c031ca7c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/specta/expecta/pulls/140/commits","review_comments_url":"https://api.github.com/repos/specta/expecta/pulls/140/comments","review_comment_url":"https://api.github.com/repos/specta/expecta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/specta/expecta/issues/140/comments","statuses_url":"https://api.github.com/repos/specta/expecta/statuses/9011f36a5bc8811dd9d0af9ba8402796dc11e311","head":{"label":"erichoracek:create-framework-test-targets","ref":"create-framework-test-targets","sha":"9011f36a5bc8811dd9d0af9ba8402796dc11e311","user":{"login":"erichoracek","id":438313,"avatar_url":"https://avatars.githubusercontent.com/u/438313?v=3","gravatar_id":"","url":"https://api.github.com/users/erichoracek","html_url":"https://github.com/erichoracek","followers_url":"https://api.github.com/users/erichoracek/followers","following_url":"https://api.github.com/users/erichoracek/following{/other_user}","gists_url":"https://api.github.com/users/erichoracek/gists{/gist_id}","starred_url":"https://api.github.com/users/erichoracek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erichoracek/subscriptions","organizations_url":"https://api.github.com/users/erichoracek/orgs","repos_url":"https://api.github.com/users/erichoracek/repos","events_url":"https://api.github.com/users/erichoracek/events{/privacy}","received_events_url":"https://api.github.com/users/erichoracek/received_events","type":"User","site_admin":false},"repo":{"id":33556355,"name":"expecta","full_name":"erichoracek/expecta","owner":{"login":"erichoracek","id":438313,"avatar_url":"https://avatars.githubusercontent.com/u/438313?v=3","gravatar_id":"","url":"https://api.github.com/users/erichoracek","html_url":"https://github.com/erichoracek","followers_url":"https://api.github.com/users/erichoracek/followers","following_url":"https://api.github.com/users/erichoracek/following{/other_user}","gists_url":"https://api.github.com/users/erichoracek/gists{/gist_id}","starred_url":"https://api.github.com/users/erichoracek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erichoracek/subscriptions","organizations_url":"https://api.github.com/users/erichoracek/orgs","repos_url":"https://api.github.com/users/erichoracek/repos","events_url":"https://api.github.com/users/erichoracek/events{/privacy}","received_events_url":"https://api.github.com/users/erichoracek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erichoracek/expecta","description":"A Matcher Framework for Objective-C/Cocoa","fork":true,"url":"https://api.github.com/repos/erichoracek/expecta","forks_url":"https://api.github.com/repos/erichoracek/expecta/forks","keys_url":"https://api.github.com/repos/erichoracek/expecta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erichoracek/expecta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erichoracek/expecta/teams","hooks_url":"https://api.github.com/repos/erichoracek/expecta/hooks","issue_events_url":"https://api.github.com/repos/erichoracek/expecta/issues/events{/number}","events_url":"https://api.github.com/repos/erichoracek/expecta/events","assignees_url":"https://api.github.com/repos/erichoracek/expecta/assignees{/user}","branches_url":"https://api.github.com/repos/erichoracek/expecta/branches{/branch}","tags_url":"https://api.github.com/repos/erichoracek/expecta/tags","blobs_url":"https://api.github.com/repos/erichoracek/expecta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erichoracek/expecta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erichoracek/expecta/git/refs{/sha}","trees_url":"https://api.github.com/repos/erichoracek/expecta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erichoracek/expecta/statuses/{sha}","languages_url":"https://api.github.com/repos/erichoracek/expecta/languages","stargazers_url":"https://api.github.com/repos/erichoracek/expecta/stargazers","contributors_url":"https://api.github.com/repos/erichoracek/expecta/contributors","subscribers_url":"https://api.github.com/repos/erichoracek/expecta/subscribers","subscription_url":"https://api.github.com/repos/erichoracek/expecta/subscription","commits_url":"https://api.github.com/repos/erichoracek/expecta/commits{/sha}","git_commits_url":"https://api.github.com/repos/erichoracek/expecta/git/commits{/sha}","comments_url":"https://api.github.com/repos/erichoracek/expecta/comments{/number}","issue_comment_url":"https://api.github.com/repos/erichoracek/expecta/issues/comments{/number}","contents_url":"https://api.github.com/repos/erichoracek/expecta/contents/{+path}","compare_url":"https://api.github.com/repos/erichoracek/expecta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erichoracek/expecta/merges","archive_url":"https://api.github.com/repos/erichoracek/expecta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erichoracek/expecta/downloads","issues_url":"https://api.github.com/repos/erichoracek/expecta/issues{/number}","pulls_url":"https://api.github.com/repos/erichoracek/expecta/pulls{/number}","milestones_url":"https://api.github.com/repos/erichoracek/expecta/milestones{/number}","notifications_url":"https://api.github.com/repos/erichoracek/expecta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erichoracek/expecta/labels{/name}","releases_url":"https://api.github.com/repos/erichoracek/expecta/releases{/id}","created_at":"2015-04-07T16:58:33Z","updated_at":"2015-04-07T16:58:33Z","pushed_at":"2015-04-07T17:42:33Z","git_url":"git://github.com/erichoracek/expecta.git","ssh_url":"git@github.com:erichoracek/expecta.git","clone_url":"https://github.com/erichoracek/expecta.git","svn_url":"https://github.com/erichoracek/expecta","homepage":"","size":1341,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"specta:master","ref":"master","sha":"7c076ace3951adee0caeb8b66deab6b3d2b03980","user":{"login":"specta","id":5076323,"avatar_url":"https://avatars.githubusercontent.com/u/5076323?v=3","gravatar_id":"","url":"https://api.github.com/users/specta","html_url":"https://github.com/specta","followers_url":"https://api.github.com/users/specta/followers","following_url":"https://api.github.com/users/specta/following{/other_user}","gists_url":"https://api.github.com/users/specta/gists{/gist_id}","starred_url":"https://api.github.com/users/specta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/specta/subscriptions","organizations_url":"https://api.github.com/users/specta/orgs","repos_url":"https://api.github.com/users/specta/repos","events_url":"https://api.github.com/users/specta/events{/privacy}","received_events_url":"https://api.github.com/users/specta/received_events","type":"Organization","site_admin":false},"repo":{"id":1716469,"name":"expecta","full_name":"specta/expecta","owner":{"login":"specta","id":5076323,"avatar_url":"https://avatars.githubusercontent.com/u/5076323?v=3","gravatar_id":"","url":"https://api.github.com/users/specta","html_url":"https://github.com/specta","followers_url":"https://api.github.com/users/specta/followers","following_url":"https://api.github.com/users/specta/following{/other_user}","gists_url":"https://api.github.com/users/specta/gists{/gist_id}","starred_url":"https://api.github.com/users/specta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/specta/subscriptions","organizations_url":"https://api.github.com/users/specta/orgs","repos_url":"https://api.github.com/users/specta/repos","events_url":"https://api.github.com/users/specta/events{/privacy}","received_events_url":"https://api.github.com/users/specta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/specta/expecta","description":"A Matcher Framework for Objective-C/Cocoa","fork":false,"url":"https://api.github.com/repos/specta/expecta","forks_url":"https://api.github.com/repos/specta/expecta/forks","keys_url":"https://api.github.com/repos/specta/expecta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/specta/expecta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/specta/expecta/teams","hooks_url":"https://api.github.com/repos/specta/expecta/hooks","issue_events_url":"https://api.github.com/repos/specta/expecta/issues/events{/number}","events_url":"https://api.github.com/repos/specta/expecta/events","assignees_url":"https://api.github.com/repos/specta/expecta/assignees{/user}","branches_url":"https://api.github.com/repos/specta/expecta/branches{/branch}","tags_url":"https://api.github.com/repos/specta/expecta/tags","blobs_url":"https://api.github.com/repos/specta/expecta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/specta/expecta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/specta/expecta/git/refs{/sha}","trees_url":"https://api.github.com/repos/specta/expecta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/specta/expecta/statuses/{sha}","languages_url":"https://api.github.com/repos/specta/expecta/languages","stargazers_url":"https://api.github.com/repos/specta/expecta/stargazers","contributors_url":"https://api.github.com/repos/specta/expecta/contributors","subscribers_url":"https://api.github.com/repos/specta/expecta/subscribers","subscription_url":"https://api.github.com/repos/specta/expecta/subscription","commits_url":"https://api.github.com/repos/specta/expecta/commits{/sha}","git_commits_url":"https://api.github.com/repos/specta/expecta/git/commits{/sha}","comments_url":"https://api.github.com/repos/specta/expecta/comments{/number}","issue_comment_url":"https://api.github.com/repos/specta/expecta/issues/comments{/number}","contents_url":"https://api.github.com/repos/specta/expecta/contents/{+path}","compare_url":"https://api.github.com/repos/specta/expecta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/specta/expecta/merges","archive_url":"https://api.github.com/repos/specta/expecta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/specta/expecta/downloads","issues_url":"https://api.github.com/repos/specta/expecta/issues{/number}","pulls_url":"https://api.github.com/repos/specta/expecta/pulls{/number}","milestones_url":"https://api.github.com/repos/specta/expecta/milestones{/number}","notifications_url":"https://api.github.com/repos/specta/expecta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/specta/expecta/labels{/name}","releases_url":"https://api.github.com/repos/specta/expecta/releases{/id}","created_at":"2011-05-07T19:32:50Z","updated_at":"2015-04-07T12:06:09Z","pushed_at":"2015-04-07T17:54:50Z","git_url":"git://github.com/specta/expecta.git","ssh_url":"git@github.com:specta/expecta.git","clone_url":"https://github.com/specta/expecta.git","svn_url":"https://github.com/specta/expecta","homepage":"","size":1341,"stargazers_count":848,"watchers_count":848,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":116,"mirror_url":null,"open_issues_count":9,"forks":116,"open_issues":9,"watchers":848,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/specta/expecta/pulls/140"},"html":{"href":"https://github.com/specta/expecta/pull/140"},"issue":{"href":"https://api.github.com/repos/specta/expecta/issues/140"},"comments":{"href":"https://api.github.com/repos/specta/expecta/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/specta/expecta/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/specta/expecta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/specta/expecta/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/specta/expecta/statuses/9011f36a5bc8811dd9d0af9ba8402796dc11e311"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"orta","id":49038,"avatar_url":"https://avatars.githubusercontent.com/u/49038?v=3","gravatar_id":"","url":"https://api.github.com/users/orta","html_url":"https://github.com/orta","followers_url":"https://api.github.com/users/orta/followers","following_url":"https://api.github.com/users/orta/following{/other_user}","gists_url":"https://api.github.com/users/orta/gists{/gist_id}","starred_url":"https://api.github.com/users/orta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orta/subscriptions","organizations_url":"https://api.github.com/users/orta/orgs","repos_url":"https://api.github.com/users/orta/repos","events_url":"https://api.github.com/users/orta/events{/privacy}","received_events_url":"https://api.github.com/users/orta/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":3,"additions":451,"deletions":34,"changed_files":5}}