{"action":"created","comment":{"url":"https://api.github.com/repos/simphony/simphony-jyulb/pulls/comments/33042030","id":33042030,"diff_hunk":"@@ -5,34 +5,50 @@ Internal and file-IO based JYU-LB engine-wrappers for the SimPhoNy framework.\n \n .. image:: https://travis-ci.org/simphony/simphony-jyulb.svg?branch=master\n     :target: https://travis-ci.org/simphony/simphony-jyulb\n-      :alt: Build status\n \n .. image:: https://coveralls.io/repos/simphony/simphony-jyulb/badge.svg\n    :target: https://coveralls.io/r/simphony/simphony-jyulb\n-      :alt: Test coverage\n \n Repository\n ----------\n \n-simphony-jyulb is hosted on github: https://github.com/simphony/simphony-jyulb\n+Simphony-jyulb is hosted on github: https://github.com/simphony/simphony-jyulb\n \n Requirements\n ------------\n- - `simphony-common`_ >= 0.1.1 \n+- `simphony-common`_ >= 0.1.1\n \n .. _simphony-common: https://github.com/simphony/simphony-common\n \n+- `cython`_\n+\n+.. _cython: https://pypi.python.org/pypi/Cython/\n+\n+- `JYU-LB`_ >= 0.1.1\n+\n+.. _JYU-LB: https://github.com/simphony/JYU-LB\n+\n .. note::\n   simphony-jyulb uses keywords (COLLISION_OPERATOR, REFERENCE_DENSITY, GRAVITY,\n   FLOW_TYPE, EXTERNAL_FORCING) which currently do not belong to the CUBA-keywords.\n \n   simphony-jyulb treats the BC data component as a dummy variable (currently there\n-  is no SimPhoNy definition for BC).  \n+  is no SimPhoNy definition for BC).\n \n Installation\n ------------\n \n-The package requires python 2.7.x. Installation is based on setuptools::\n+The package requires python 2.7.x, cython and JYU-LB header files along with\n+`simphony-common` package to build and install cython extension. To get the","path":"README.rst","position":44,"original_position":44,"commit_id":"e3673af3bf1afef78049b337f7a6bf3db78502ac","original_commit_id":"e3673af3bf1afef78049b337f7a6bf3db78502ac","user":{"login":"nathanfranklin","id":8287580,"avatar_url":"https://avatars.githubusercontent.com/u/8287580?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanfranklin","html_url":"https://github.com/nathanfranklin","followers_url":"https://api.github.com/users/nathanfranklin/followers","following_url":"https://api.github.com/users/nathanfranklin/following{/other_user}","gists_url":"https://api.github.com/users/nathanfranklin/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanfranklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanfranklin/subscriptions","organizations_url":"https://api.github.com/users/nathanfranklin/orgs","repos_url":"https://api.github.com/users/nathanfranklin/repos","events_url":"https://api.github.com/users/nathanfranklin/events{/privacy}","received_events_url":"https://api.github.com/users/nathanfranklin/received_events","type":"User","site_admin":false},"body":"@mehdisadeghi ","created_at":"2015-06-23T13:48:26Z","updated_at":"2015-06-23T13:48:26Z","html_url":"https://github.com/simphony/simphony-jyulb/pull/23#discussion_r33042030","pull_request_url":"https://api.github.com/repos/simphony/simphony-jyulb/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/simphony/simphony-jyulb/pulls/comments/33042030"},"html":{"href":"https://github.com/simphony/simphony-jyulb/pull/23#discussion_r33042030"},"pull_request":{"href":"https://api.github.com/repos/simphony/simphony-jyulb/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/simphony/simphony-jyulb/pulls/23","id":38227763,"html_url":"https://github.com/simphony/simphony-jyulb/pull/23","diff_url":"https://github.com/simphony/simphony-jyulb/pull/23.diff","patch_url":"https://github.com/simphony/simphony-jyulb/pull/23.patch","issue_url":"https://api.github.com/repos/simphony/simphony-jyulb/issues/23","number":23,"state":"open","locked":false,"title":"Improving installation","user":{"login":"mehdisadeghi","id":3101557,"avatar_url":"https://avatars.githubusercontent.com/u/3101557?v=3","gravatar_id":"","url":"https://api.github.com/users/mehdisadeghi","html_url":"https://github.com/mehdisadeghi","followers_url":"https://api.github.com/users/mehdisadeghi/followers","following_url":"https://api.github.com/users/mehdisadeghi/following{/other_user}","gists_url":"https://api.github.com/users/mehdisadeghi/gists{/gist_id}","starred_url":"https://api.github.com/users/mehdisadeghi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehdisadeghi/subscriptions","organizations_url":"https://api.github.com/users/mehdisadeghi/orgs","repos_url":"https://api.github.com/users/mehdisadeghi/repos","events_url":"https://api.github.com/users/mehdisadeghi/events{/privacy}","received_events_url":"https://api.github.com/users/mehdisadeghi/received_events","type":"User","site_admin":false},"body":"This PR addresses a few issues in #18 and #21 and some minor improvements:\r\n\r\n1. The installation instructions are improved to explicitly cover installation of required header files.\r\n2. External installation script changed to allow users to specify a custom location for installation\r\n3. JYU-LB added as a sub-module with corresponding document update.\r\n4. A requirements.txt (non-dev) file added along with corresponding document update.\r\n5. Fixes travis links.","created_at":"2015-06-22T12:46:03Z","updated_at":"2015-06-23T13:48:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e959ab980e59dcd27669073167bc11a951651cf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/simphony/simphony-jyulb/pulls/23/commits","review_comments_url":"https://api.github.com/repos/simphony/simphony-jyulb/pulls/23/comments","review_comment_url":"https://api.github.com/repos/simphony/simphony-jyulb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simphony/simphony-jyulb/issues/23/comments","statuses_url":"https://api.github.com/repos/simphony/simphony-jyulb/statuses/e3673af3bf1afef78049b337f7a6bf3db78502ac","head":{"label":"simphony:improving_installation","ref":"improving_installation","sha":"e3673af3bf1afef78049b337f7a6bf3db78502ac","user":{"login":"simphony","id":8048249,"avatar_url":"https://avatars.githubusercontent.com/u/8048249?v=3","gravatar_id":"","url":"https://api.github.com/users/simphony","html_url":"https://github.com/simphony","followers_url":"https://api.github.com/users/simphony/followers","following_url":"https://api.github.com/users/simphony/following{/other_user}","gists_url":"https://api.github.com/users/simphony/gists{/gist_id}","starred_url":"https://api.github.com/users/simphony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simphony/subscriptions","organizations_url":"https://api.github.com/users/simphony/orgs","repos_url":"https://api.github.com/users/simphony/repos","events_url":"https://api.github.com/users/simphony/events{/privacy}","received_events_url":"https://api.github.com/users/simphony/received_events","type":"Organization","site_admin":false},"repo":{"id":30918597,"name":"simphony-jyulb","full_name":"simphony/simphony-jyulb","owner":{"login":"simphony","id":8048249,"avatar_url":"https://avatars.githubusercontent.com/u/8048249?v=3","gravatar_id":"","url":"https://api.github.com/users/simphony","html_url":"https://github.com/simphony","followers_url":"https://api.github.com/users/simphony/followers","following_url":"https://api.github.com/users/simphony/following{/other_user}","gists_url":"https://api.github.com/users/simphony/gists{/gist_id}","starred_url":"https://api.github.com/users/simphony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simphony/subscriptions","organizations_url":"https://api.github.com/users/simphony/orgs","repos_url":"https://api.github.com/users/simphony/repos","events_url":"https://api.github.com/users/simphony/events{/privacy}","received_events_url":"https://api.github.com/users/simphony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simphony/simphony-jyulb","description":"SimPhoNy Wrapper for the JYU-LB code. ","fork":false,"url":"https://api.github.com/repos/simphony/simphony-jyulb","forks_url":"https://api.github.com/repos/simphony/simphony-jyulb/forks","keys_url":"https://api.github.com/repos/simphony/simphony-jyulb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simphony/simphony-jyulb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simphony/simphony-jyulb/teams","hooks_url":"https://api.github.com/repos/simphony/simphony-jyulb/hooks","issue_events_url":"https://api.github.com/repos/simphony/simphony-jyulb/issues/events{/number}","events_url":"https://api.github.com/repos/simphony/simphony-jyulb/events","assignees_url":"https://api.github.com/repos/simphony/simphony-jyulb/assignees{/user}","branches_url":"https://api.github.com/repos/simphony/simphony-jyulb/branches{/branch}","tags_url":"https://api.github.com/repos/simphony/simphony-jyulb/tags","blobs_url":"https://api.github.com/repos/simphony/simphony-jyulb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simphony/simphony-jyulb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simphony/simphony-jyulb/git/refs{/sha}","trees_url":"https://api.github.com/repos/simphony/simphony-jyulb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simphony/simphony-jyulb/statuses/{sha}","languages_url":"https://api.github.com/repos/simphony/simphony-jyulb/languages","stargazers_url":"https://api.github.com/repos/simphony/simphony-jyulb/stargazers","contributors_url":"https://api.github.com/repos/simphony/simphony-jyulb/contributors","subscribers_url":"https://api.github.com/repos/simphony/simphony-jyulb/subscribers","subscription_url":"https://api.github.com/repos/simphony/simphony-jyulb/subscription","commits_url":"https://api.github.com/repos/simphony/simphony-jyulb/commits{/sha}","git_commits_url":"https://api.github.com/repos/simphony/simphony-jyulb/git/commits{/sha}","comments_url":"https://api.github.com/repos/simphony/simphony-jyulb/comments{/number}","issue_comment_url":"https://api.github.com/repos/simphony/simphony-jyulb/issues/comments{/number}","contents_url":"https://api.github.com/repos/simphony/simphony-jyulb/contents/{+path}","compare_url":"https://api.github.com/repos/simphony/simphony-jyulb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simphony/simphony-jyulb/merges","archive_url":"https://api.github.com/repos/simphony/simphony-jyulb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simphony/simphony-jyulb/downloads","issues_url":"https://api.github.com/repos/simphony/simphony-jyulb/issues{/number}","pulls_url":"https://api.github.com/repos/simphony/simphony-jyulb/pulls{/number}","milestones_url":"https://api.github.com/repos/simphony/simphony-jyulb/milestones{/number}","notifications_url":"https://api.github.com/repos/simphony/simphony-jyulb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simphony/simphony-jyulb/labels{/name}","releases_url":"https://api.github.com/repos/simphony/simphony-jyulb/releases{/id}","created_at":"2015-02-17T13:42:45Z","updated_at":"2015-04-14T12:23:03Z","pushed_at":"2015-06-23T06:28:17Z","git_url":"git://github.com/simphony/simphony-jyulb.git","ssh_url":"git@github.com:simphony/simphony-jyulb.git","clone_url":"https://github.com/simphony/simphony-jyulb.git","svn_url":"https://github.com/simphony/simphony-jyulb","homepage":"","size":440,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"simphony:master","ref":"master","sha":"9c79191a574785cc28d742c21cd470a5bc029580","user":{"login":"simphony","id":8048249,"avatar_url":"https://avatars.githubusercontent.com/u/8048249?v=3","gravatar_id":"","url":"https://api.github.com/users/simphony","html_url":"https://github.com/simphony","followers_url":"https://api.github.com/users/simphony/followers","following_url":"https://api.github.com/users/simphony/following{/other_user}","gists_url":"https://api.github.com/users/simphony/gists{/gist_id}","starred_url":"https://api.github.com/users/simphony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simphony/subscriptions","organizations_url":"https://api.github.com/users/simphony/orgs","repos_url":"https://api.github.com/users/simphony/repos","events_url":"https://api.github.com/users/simphony/events{/privacy}","received_events_url":"https://api.github.com/users/simphony/received_events","type":"Organization","site_admin":false},"repo":{"id":30918597,"name":"simphony-jyulb","full_name":"simphony/simphony-jyulb","owner":{"login":"simphony","id":8048249,"avatar_url":"https://avatars.githubusercontent.com/u/8048249?v=3","gravatar_id":"","url":"https://api.github.com/users/simphony","html_url":"https://github.com/simphony","followers_url":"https://api.github.com/users/simphony/followers","following_url":"https://api.github.com/users/simphony/following{/other_user}","gists_url":"https://api.github.com/users/simphony/gists{/gist_id}","starred_url":"https://api.github.com/users/simphony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simphony/subscriptions","organizations_url":"https://api.github.com/users/simphony/orgs","repos_url":"https://api.github.com/users/simphony/repos","events_url":"https://api.github.com/users/simphony/events{/privacy}","received_events_url":"https://api.github.com/users/simphony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simphony/simphony-jyulb","description":"SimPhoNy Wrapper for the JYU-LB code. ","fork":false,"url":"https://api.github.com/repos/simphony/simphony-jyulb","forks_url":"https://api.github.com/repos/simphony/simphony-jyulb/forks","keys_url":"https://api.github.com/repos/simphony/simphony-jyulb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simphony/simphony-jyulb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simphony/simphony-jyulb/teams","hooks_url":"https://api.github.com/repos/simphony/simphony-jyulb/hooks","issue_events_url":"https://api.github.com/repos/simphony/simphony-jyulb/issues/events{/number}","events_url":"https://api.github.com/repos/simphony/simphony-jyulb/events","assignees_url":"https://api.github.com/repos/simphony/simphony-jyulb/assignees{/user}","branches_url":"https://api.github.com/repos/simphony/simphony-jyulb/branches{/branch}","tags_url":"https://api.github.com/repos/simphony/simphony-jyulb/tags","blobs_url":"https://api.github.com/repos/simphony/simphony-jyulb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simphony/simphony-jyulb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simphony/simphony-jyulb/git/refs{/sha}","trees_url":"https://api.github.com/repos/simphony/simphony-jyulb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simphony/simphony-jyulb/statuses/{sha}","languages_url":"https://api.github.com/repos/simphony/simphony-jyulb/languages","stargazers_url":"https://api.github.com/repos/simphony/simphony-jyulb/stargazers","contributors_url":"https://api.github.com/repos/simphony/simphony-jyulb/contributors","subscribers_url":"https://api.github.com/repos/simphony/simphony-jyulb/subscribers","subscription_url":"https://api.github.com/repos/simphony/simphony-jyulb/subscription","commits_url":"https://api.github.com/repos/simphony/simphony-jyulb/commits{/sha}","git_commits_url":"https://api.github.com/repos/simphony/simphony-jyulb/git/commits{/sha}","comments_url":"https://api.github.com/repos/simphony/simphony-jyulb/comments{/number}","issue_comment_url":"https://api.github.com/repos/simphony/simphony-jyulb/issues/comments{/number}","contents_url":"https://api.github.com/repos/simphony/simphony-jyulb/contents/{+path}","compare_url":"https://api.github.com/repos/simphony/simphony-jyulb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simphony/simphony-jyulb/merges","archive_url":"https://api.github.com/repos/simphony/simphony-jyulb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simphony/simphony-jyulb/downloads","issues_url":"https://api.github.com/repos/simphony/simphony-jyulb/issues{/number}","pulls_url":"https://api.github.com/repos/simphony/simphony-jyulb/pulls{/number}","milestones_url":"https://api.github.com/repos/simphony/simphony-jyulb/milestones{/number}","notifications_url":"https://api.github.com/repos/simphony/simphony-jyulb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simphony/simphony-jyulb/labels{/name}","releases_url":"https://api.github.com/repos/simphony/simphony-jyulb/releases{/id}","created_at":"2015-02-17T13:42:45Z","updated_at":"2015-04-14T12:23:03Z","pushed_at":"2015-06-23T06:28:17Z","git_url":"git://github.com/simphony/simphony-jyulb.git","ssh_url":"git@github.com:simphony/simphony-jyulb.git","clone_url":"https://github.com/simphony/simphony-jyulb.git","svn_url":"https://github.com/simphony/simphony-jyulb","homepage":"","size":440,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simphony/simphony-jyulb/pulls/23"},"html":{"href":"https://github.com/simphony/simphony-jyulb/pull/23"},"issue":{"href":"https://api.github.com/repos/simphony/simphony-jyulb/issues/23"},"comments":{"href":"https://api.github.com/repos/simphony/simphony-jyulb/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/simphony/simphony-jyulb/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/simphony/simphony-jyulb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simphony/simphony-jyulb/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/simphony/simphony-jyulb/statuses/e3673af3bf1afef78049b337f7a6bf3db78502ac"}}}}