{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5207","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5207/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5207/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5207/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/5207","id":104591142,"number":5207,"title":"AdaBoostRegressor does not pass sample_weights to the base estimator","user":{"login":"MechCoder","id":1867024,"avatar_url":"https://avatars.githubusercontent.com/u/1867024?v=3","gravatar_id":"","url":"https://api.github.com/users/MechCoder","html_url":"https://github.com/MechCoder","followers_url":"https://api.github.com/users/MechCoder/followers","following_url":"https://api.github.com/users/MechCoder/following{/other_user}","gists_url":"https://api.github.com/users/MechCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/MechCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MechCoder/subscriptions","organizations_url":"https://api.github.com/users/MechCoder/orgs","repos_url":"https://api.github.com/users/MechCoder/repos","events_url":"https://api.github.com/users/MechCoder/events{/privacy}","received_events_url":"https://api.github.com/users/MechCoder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-09-02T23:21:05Z","updated_at":"2015-09-03T17:56:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5207","html_url":"https://github.com/scikit-learn/scikit-learn/pull/5207","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/5207.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/5207.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/137528080","html_url":"https://github.com/scikit-learn/scikit-learn/pull/5207#issuecomment-137528080","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5207","id":137528080,"user":{"login":"MechCoder","id":1867024,"avatar_url":"https://avatars.githubusercontent.com/u/1867024?v=3","gravatar_id":"","url":"https://api.github.com/users/MechCoder","html_url":"https://github.com/MechCoder","followers_url":"https://api.github.com/users/MechCoder/followers","following_url":"https://api.github.com/users/MechCoder/following{/other_user}","gists_url":"https://api.github.com/users/MechCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/MechCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MechCoder/subscriptions","organizations_url":"https://api.github.com/users/MechCoder/orgs","repos_url":"https://api.github.com/users/MechCoder/repos","events_url":"https://api.github.com/users/MechCoder/events{/privacy}","received_events_url":"https://api.github.com/users/MechCoder/received_events","type":"User","site_admin":false},"created_at":"2015-09-03T17:56:14Z","updated_at":"2015-09-03T17:56:14Z","body":"I think the idea is to raise an error or not support base estimators which do not have sample_weights. However, I suppose an error should be raised only when sample_weights is not None for these cases?\r\n\r\nAnyhow, the checks for LogisticRegression can be removed in the other PR or the solver can be explicitly set to liblinear since that should also raise a ValueError (although in a different part of the code)"}}