{"action":"created","issue":{"url":"https://api.github.com/repos/github/android/issues/661","labels_url":"https://api.github.com/repos/github/android/issues/661/labels{/name}","comments_url":"https://api.github.com/repos/github/android/issues/661/comments","events_url":"https://api.github.com/repos/github/android/issues/661/events","html_url":"https://github.com/github/android/pull/661","id":53358406,"number":661,"title":"Switch from ActionBarSherlock to AppCompat","user":{"login":"hzsweers","id":1361086,"avatar_url":"https://avatars.githubusercontent.com/u/1361086?v=3","gravatar_id":"","url":"https://api.github.com/users/hzsweers","html_url":"https://github.com/hzsweers","followers_url":"https://api.github.com/users/hzsweers/followers","following_url":"https://api.github.com/users/hzsweers/following{/other_user}","gists_url":"https://api.github.com/users/hzsweers/gists{/gist_id}","starred_url":"https://api.github.com/users/hzsweers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzsweers/subscriptions","organizations_url":"https://api.github.com/users/hzsweers/orgs","repos_url":"https://api.github.com/users/hzsweers/repos","events_url":"https://api.github.com/users/hzsweers/events{/privacy}","received_events_url":"https://api.github.com/users/hzsweers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2015-01-05T02:22:37Z","updated_at":"2015-01-06T05:02:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/github/android/pulls/661","html_url":"https://github.com/github/android/pull/661","diff_url":"https://github.com/github/android/pull/661.diff","patch_url":"https://github.com/github/android/pull/661.patch"},"body":"This should set the foundation to really allow developers to start digging in to implementing material design.\r\n\r\n* Removes ActionBarSherlock and the RoboSherlock library supporting it\r\n* Adds AppCompat and wrapper classes for `ActionBarActivity` that provide what RoboSherlock provided for ABS\r\n  * This still uses RoboGuice 2.0. 3.0 would be nice, as it has 1st party support for these wrapper classes.\r\n  * This also requires setting minSDK to 11, which in turn means we can really bump it up to 15. 15 still covers 90+% of all Android users, and almost certainly close to 100% of the tech savvy ones that use the Github app.\r\n* Set basic color palette (you guys can change this to whatever you like, I just went with a safe option of the grey primaryColor, darker version for primaryColorDark, and the blue for accentColor\r\n* Use AppCompat's new searchview UI (including using its new icon, which allows us to remove the old one)\r\n* Improved `.gitignore` (my IDE kept wanting to commit IntelliJ files...)\r\n* Removed unnecessary declarations from AndroidManifest\r\n\r\nThe actionbar cuts over the tab pager a little, but I don't think that's a new bug having seen it in the store version prior to this.\r\n\r\nYou guys should update your current actionbar items to fully-white versions of their new Material alternatives. They're available for free come google [here](https://github.com/google/material-design-icons), or I can add them in this pull request as well if you want.\r\n\r\nThis addresses #658 \r\n\r\nScreenshots album: http://imgur.com/a/x76xf\r\n\r\nCouple screen records of the new UI:\r\n* https://www.dropbox.com/s/7yoh831834u7nlm/device-2015-01-04-180254.mp4?dl=0\r\n* https://www.dropbox.com/s/68oy4v2lo1dv29c/device-2015-01-04-180455.mp4?dl=0"},"comment":{"url":"https://api.github.com/repos/github/android/issues/comments/68826492","html_url":"https://github.com/github/android/pull/661#issuecomment-68826492","issue_url":"https://api.github.com/repos/github/android/issues/661","id":68826492,"user":{"login":"fadils","id":6204776,"avatar_url":"https://avatars.githubusercontent.com/u/6204776?v=3","gravatar_id":"","url":"https://api.github.com/users/fadils","html_url":"https://github.com/fadils","followers_url":"https://api.github.com/users/fadils/followers","following_url":"https://api.github.com/users/fadils/following{/other_user}","gists_url":"https://api.github.com/users/fadils/gists{/gist_id}","starred_url":"https://api.github.com/users/fadils/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fadils/subscriptions","organizations_url":"https://api.github.com/users/fadils/orgs","repos_url":"https://api.github.com/users/fadils/repos","events_url":"https://api.github.com/users/fadils/events{/privacy}","received_events_url":"https://api.github.com/users/fadils/received_events","type":"User","site_admin":false},"created_at":"2015-01-06T05:02:09Z","updated_at":"2015-01-06T05:02:09Z","body":"@hzsweers Same with @jonanp, I think it's good.\r\n\r\nSeveral things:\r\n![screenshot_2015-01-06-11-06-39](https://cloud.githubusercontent.com/assets/6204776/5624461/48ca9804-9598-11e4-968c-cb29ab13654e.png)\r\n\r\nThe menu is a bit tight so that the item's name is cut off.\r\n\r\nRegarding the arrow, with your name (hzsweers) then the arrow right after the name. But if the username's is a bit shorter such as \"fadils\" or \"github\", then there is a big gap afterwards, and thus the arrow still be seen a bit after the menu is expanded.\r\n\r\nThese two things to maintain the consistencies between ABS and AppCompat.\r\nAnd preferably solved in this PR, if that doesn't bother you too much @hzsweers =)\r\n\r\nOther issues such as color, animation, etc.. then we can continue afterwards."}}