{"action":"created","issue":{"url":"https://api.github.com/repos/opencog/atomspace/issues/99","labels_url":"https://api.github.com/repos/opencog/atomspace/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/opencog/atomspace/issues/99/comments","events_url":"https://api.github.com/repos/opencog/atomspace/issues/99/events","html_url":"https://github.com/opencog/atomspace/pull/99","id":89508530,"number":99,"title":"URE misc improvements","user":{"login":"ngeiswei","id":819225,"avatar_url":"https://avatars.githubusercontent.com/u/819225?v=3","gravatar_id":"","url":"https://api.github.com/users/ngeiswei","html_url":"https://github.com/ngeiswei","followers_url":"https://api.github.com/users/ngeiswei/followers","following_url":"https://api.github.com/users/ngeiswei/following{/other_user}","gists_url":"https://api.github.com/users/ngeiswei/gists{/gist_id}","starred_url":"https://api.github.com/users/ngeiswei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngeiswei/subscriptions","organizations_url":"https://api.github.com/users/ngeiswei/orgs","repos_url":"https://api.github.com/users/ngeiswei/repos","events_url":"https://api.github.com/users/ngeiswei/events{/privacy}","received_events_url":"https://api.github.com/users/ngeiswei/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-06-19T08:46:13Z","updated_at":"2015-06-19T11:07:51Z","closed_at":"2015-06-19T08:46:20Z","pull_request":{"url":"https://api.github.com/repos/opencog/atomspace/pulls/99","html_url":"https://github.com/opencog/atomspace/pull/99","diff_url":"https://github.com/opencog/atomspace/pull/99.diff","patch_url":"https://github.com/opencog/atomspace/pull/99.patch"},"body":"Mainly make the API between the FC and BC more consistent, so they look more like each other. In particular, but not only, have the BC take the rule-base system config atom in constructor argument."},"comment":{"url":"https://api.github.com/repos/opencog/atomspace/issues/comments/113474993","html_url":"https://github.com/opencog/atomspace/pull/99#issuecomment-113474993","issue_url":"https://api.github.com/repos/opencog/atomspace/issues/99","id":113474993,"user":{"login":"ngeiswei","id":819225,"avatar_url":"https://avatars.githubusercontent.com/u/819225?v=3","gravatar_id":"","url":"https://api.github.com/users/ngeiswei","html_url":"https://github.com/ngeiswei","followers_url":"https://api.github.com/users/ngeiswei/followers","following_url":"https://api.github.com/users/ngeiswei/following{/other_user}","gists_url":"https://api.github.com/users/ngeiswei/gists{/gist_id}","starred_url":"https://api.github.com/users/ngeiswei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngeiswei/subscriptions","organizations_url":"https://api.github.com/users/ngeiswei/orgs","repos_url":"https://api.github.com/users/ngeiswei/repos","events_url":"https://api.github.com/users/ngeiswei/events{/privacy}","received_events_url":"https://api.github.com/users/ngeiswei/received_events","type":"User","site_admin":false},"created_at":"2015-06-19T11:07:51Z","updated_at":"2015-06-19T11:07:51Z","body":"The way I see it, is that parameters that differ between FC and BC would still be tied to the same rule-based system concept node. And since it doesn't make much sense to use a chainer without specifying a rule-based system why not putting at construction time. Having said that we could still have a set_config method, it comes down to whether we consider useful to change the rule-based system on the same chainer object.\r\n\r\nAlso I'm not sure whether a chainer should take the rbs node, or a C++ structure with all the parameters fetched from that rbs node.\r\n\r\nAnyway I'm willing to let it that way for now, and after gathering more experience."}}