{"action":"created","comment":{"url":"https://api.github.com/repos/bazaarvoice/scoutfile/pulls/comments/28460900","id":28460900,"diff_hunk":"@@ -73,6 +73,26 @@ module.exports = {\n               test.done();\n             }, test.done);\n           }\n+        },\n+        'options.appConfig': {\n+          'enables config module': function (test) {\n+            scout.generate({\n+              appModules: [{\n+                path: './test/fixtures/lib/index/app-config',\n+                name: 'app-config'\n+              }],\n+              appConfig: {\n+                myAppConfig: true\n+              }\n+            }).\n+            then(function (src) {\n+              test.ok(\n+                src.indexOf('myAppConfig') > -1,\n+                'app config should be included'\n+              );","path":"test/unit/lib/index.js","position":20,"original_position":20,"commit_id":"666e3416d1e7778f74227a9e89912493da224b6e","original_commit_id":"666e3416d1e7778f74227a9e89912493da224b6e","user":{"login":"lawnsea","id":296238,"avatar_url":"https://avatars.githubusercontent.com/u/296238?v=3","gravatar_id":"","url":"https://api.github.com/users/lawnsea","html_url":"https://github.com/lawnsea","followers_url":"https://api.github.com/users/lawnsea/followers","following_url":"https://api.github.com/users/lawnsea/following{/other_user}","gists_url":"https://api.github.com/users/lawnsea/gists{/gist_id}","starred_url":"https://api.github.com/users/lawnsea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lawnsea/subscriptions","organizations_url":"https://api.github.com/users/lawnsea/orgs","repos_url":"https://api.github.com/users/lawnsea/repos","events_url":"https://api.github.com/users/lawnsea/events{/privacy}","received_events_url":"https://api.github.com/users/lawnsea/received_events","type":"User","site_admin":false},"body":"This tests the mechanism - `DefinePlugin` - not the `appConfig` API. This test should verify that when an app module requires `scoutfile/lib/browser/appConfig`, the resulting bundle includes the value of `appConfig`.\r\n\r\nIdeally, we should also verify that `require('scoutfile/lib/browser/appConfig')` returns the expected value, but I'm not sure the tests are set up to do so.","created_at":"2015-04-15T20:44:57Z","updated_at":"2015-04-15T20:44:57Z","html_url":"https://github.com/bazaarvoice/scoutfile/pull/12#discussion_r28460900","pull_request_url":"https://api.github.com/repos/bazaarvoice/scoutfile/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/bazaarvoice/scoutfile/pulls/comments/28460900"},"html":{"href":"https://github.com/bazaarvoice/scoutfile/pull/12#discussion_r28460900"},"pull_request":{"href":"https://api.github.com/repos/bazaarvoice/scoutfile/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/bazaarvoice/scoutfile/pulls/12","id":33386296,"html_url":"https://github.com/bazaarvoice/scoutfile/pull/12","diff_url":"https://github.com/bazaarvoice/scoutfile/pull/12.diff","patch_url":"https://github.com/bazaarvoice/scoutfile/pull/12.patch","issue_url":"https://api.github.com/repos/bazaarvoice/scoutfile/issues/12","number":12,"state":"open","locked":false,"title":"Provide ability to pass app config to generator","user":{"login":"rmurphey","id":58987,"avatar_url":"https://avatars.githubusercontent.com/u/58987?v=3","gravatar_id":"","url":"https://api.github.com/users/rmurphey","html_url":"https://github.com/rmurphey","followers_url":"https://api.github.com/users/rmurphey/followers","following_url":"https://api.github.com/users/rmurphey/following{/other_user}","gists_url":"https://api.github.com/users/rmurphey/gists{/gist_id}","starred_url":"https://api.github.com/users/rmurphey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmurphey/subscriptions","organizations_url":"https://api.github.com/users/rmurphey/orgs","repos_url":"https://api.github.com/users/rmurphey/repos","events_url":"https://api.github.com/users/rmurphey/events{/privacy}","received_events_url":"https://api.github.com/users/rmurphey/received_events","type":"User","site_admin":false},"body":"It's common that we need to include in our scout file in-memory configuration information that doesn't exist anywhere on the filesystem. This pull request allows us to do the following:\r\n\r\n```js\r\nscout.generate({\r\n  // ...\r\n  appConfig: {\r\n    reviews: true\r\n  }\r\n});\r\n```\r\n\r\nThen, in our application's portion of the scout file, we can do:\r\n\r\n```js\r\nvar appConfig = require('scoutfile/lib/appConfig);\r\n```","created_at":"2015-04-15T19:07:34Z","updated_at":"2015-04-15T20:44:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f39901452f2abceca90d2d5e731e4128f3120dfd","assignee":{"login":"lawnsea","id":296238,"avatar_url":"https://avatars.githubusercontent.com/u/296238?v=3","gravatar_id":"","url":"https://api.github.com/users/lawnsea","html_url":"https://github.com/lawnsea","followers_url":"https://api.github.com/users/lawnsea/followers","following_url":"https://api.github.com/users/lawnsea/following{/other_user}","gists_url":"https://api.github.com/users/lawnsea/gists{/gist_id}","starred_url":"https://api.github.com/users/lawnsea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lawnsea/subscriptions","organizations_url":"https://api.github.com/users/lawnsea/orgs","repos_url":"https://api.github.com/users/lawnsea/repos","events_url":"https://api.github.com/users/lawnsea/events{/privacy}","received_events_url":"https://api.github.com/users/lawnsea/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/bazaarvoice/scoutfile/pulls/12/commits","review_comments_url":"https://api.github.com/repos/bazaarvoice/scoutfile/pulls/12/comments","review_comment_url":"https://api.github.com/repos/bazaarvoice/scoutfile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bazaarvoice/scoutfile/issues/12/comments","statuses_url":"https://api.github.com/repos/bazaarvoice/scoutfile/statuses/666e3416d1e7778f74227a9e89912493da224b6e","head":{"label":"rmurphey:config-module","ref":"config-module","sha":"666e3416d1e7778f74227a9e89912493da224b6e","user":{"login":"rmurphey","id":58987,"avatar_url":"https://avatars.githubusercontent.com/u/58987?v=3","gravatar_id":"","url":"https://api.github.com/users/rmurphey","html_url":"https://github.com/rmurphey","followers_url":"https://api.github.com/users/rmurphey/followers","following_url":"https://api.github.com/users/rmurphey/following{/other_user}","gists_url":"https://api.github.com/users/rmurphey/gists{/gist_id}","starred_url":"https://api.github.com/users/rmurphey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmurphey/subscriptions","organizations_url":"https://api.github.com/users/rmurphey/orgs","repos_url":"https://api.github.com/users/rmurphey/repos","events_url":"https://api.github.com/users/rmurphey/events{/privacy}","received_events_url":"https://api.github.com/users/rmurphey/received_events","type":"User","site_admin":false},"repo":{"id":32414758,"name":"scoutfile","full_name":"rmurphey/scoutfile","owner":{"login":"rmurphey","id":58987,"avatar_url":"https://avatars.githubusercontent.com/u/58987?v=3","gravatar_id":"","url":"https://api.github.com/users/rmurphey","html_url":"https://github.com/rmurphey","followers_url":"https://api.github.com/users/rmurphey/followers","following_url":"https://api.github.com/users/rmurphey/following{/other_user}","gists_url":"https://api.github.com/users/rmurphey/gists{/gist_id}","starred_url":"https://api.github.com/users/rmurphey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmurphey/subscriptions","organizations_url":"https://api.github.com/users/rmurphey/orgs","repos_url":"https://api.github.com/users/rmurphey/repos","events_url":"https://api.github.com/users/rmurphey/events{/privacy}","received_events_url":"https://api.github.com/users/rmurphey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rmurphey/scoutfile","description":"A Node module for generating a scout file for a client-side JS app","fork":true,"url":"https://api.github.com/repos/rmurphey/scoutfile","forks_url":"https://api.github.com/repos/rmurphey/scoutfile/forks","keys_url":"https://api.github.com/repos/rmurphey/scoutfile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rmurphey/scoutfile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rmurphey/scoutfile/teams","hooks_url":"https://api.github.com/repos/rmurphey/scoutfile/hooks","issue_events_url":"https://api.github.com/repos/rmurphey/scoutfile/issues/events{/number}","events_url":"https://api.github.com/repos/rmurphey/scoutfile/events","assignees_url":"https://api.github.com/repos/rmurphey/scoutfile/assignees{/user}","branches_url":"https://api.github.com/repos/rmurphey/scoutfile/branches{/branch}","tags_url":"https://api.github.com/repos/rmurphey/scoutfile/tags","blobs_url":"https://api.github.com/repos/rmurphey/scoutfile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rmurphey/scoutfile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rmurphey/scoutfile/git/refs{/sha}","trees_url":"https://api.github.com/repos/rmurphey/scoutfile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rmurphey/scoutfile/statuses/{sha}","languages_url":"https://api.github.com/repos/rmurphey/scoutfile/languages","stargazers_url":"https://api.github.com/repos/rmurphey/scoutfile/stargazers","contributors_url":"https://api.github.com/repos/rmurphey/scoutfile/contributors","subscribers_url":"https://api.github.com/repos/rmurphey/scoutfile/subscribers","subscription_url":"https://api.github.com/repos/rmurphey/scoutfile/subscription","commits_url":"https://api.github.com/repos/rmurphey/scoutfile/commits{/sha}","git_commits_url":"https://api.github.com/repos/rmurphey/scoutfile/git/commits{/sha}","comments_url":"https://api.github.com/repos/rmurphey/scoutfile/comments{/number}","issue_comment_url":"https://api.github.com/repos/rmurphey/scoutfile/issues/comments{/number}","contents_url":"https://api.github.com/repos/rmurphey/scoutfile/contents/{+path}","compare_url":"https://api.github.com/repos/rmurphey/scoutfile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rmurphey/scoutfile/merges","archive_url":"https://api.github.com/repos/rmurphey/scoutfile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rmurphey/scoutfile/downloads","issues_url":"https://api.github.com/repos/rmurphey/scoutfile/issues{/number}","pulls_url":"https://api.github.com/repos/rmurphey/scoutfile/pulls{/number}","milestones_url":"https://api.github.com/repos/rmurphey/scoutfile/milestones{/number}","notifications_url":"https://api.github.com/repos/rmurphey/scoutfile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rmurphey/scoutfile/labels{/name}","releases_url":"https://api.github.com/repos/rmurphey/scoutfile/releases{/id}","created_at":"2015-03-17T19:18:33Z","updated_at":"2015-03-17T19:18:33Z","pushed_at":"2015-04-15T19:07:32Z","git_url":"git://github.com/rmurphey/scoutfile.git","ssh_url":"git@github.com:rmurphey/scoutfile.git","clone_url":"https://github.com/rmurphey/scoutfile.git","svn_url":"https://github.com/rmurphey/scoutfile","homepage":"","size":151,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bazaarvoice:master","ref":"master","sha":"ce36a9054a84f146b11242380dfef6b43bded55f","user":{"login":"bazaarvoice","id":152469,"avatar_url":"https://avatars.githubusercontent.com/u/152469?v=3","gravatar_id":"","url":"https://api.github.com/users/bazaarvoice","html_url":"https://github.com/bazaarvoice","followers_url":"https://api.github.com/users/bazaarvoice/followers","following_url":"https://api.github.com/users/bazaarvoice/following{/other_user}","gists_url":"https://api.github.com/users/bazaarvoice/gists{/gist_id}","starred_url":"https://api.github.com/users/bazaarvoice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazaarvoice/subscriptions","organizations_url":"https://api.github.com/users/bazaarvoice/orgs","repos_url":"https://api.github.com/users/bazaarvoice/repos","events_url":"https://api.github.com/users/bazaarvoice/events{/privacy}","received_events_url":"https://api.github.com/users/bazaarvoice/received_events","type":"Organization","site_admin":false},"repo":{"id":31616647,"name":"scoutfile","full_name":"bazaarvoice/scoutfile","owner":{"login":"bazaarvoice","id":152469,"avatar_url":"https://avatars.githubusercontent.com/u/152469?v=3","gravatar_id":"","url":"https://api.github.com/users/bazaarvoice","html_url":"https://github.com/bazaarvoice","followers_url":"https://api.github.com/users/bazaarvoice/followers","following_url":"https://api.github.com/users/bazaarvoice/following{/other_user}","gists_url":"https://api.github.com/users/bazaarvoice/gists{/gist_id}","starred_url":"https://api.github.com/users/bazaarvoice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazaarvoice/subscriptions","organizations_url":"https://api.github.com/users/bazaarvoice/orgs","repos_url":"https://api.github.com/users/bazaarvoice/repos","events_url":"https://api.github.com/users/bazaarvoice/events{/privacy}","received_events_url":"https://api.github.com/users/bazaarvoice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bazaarvoice/scoutfile","description":"A Node module for generating a scout file for a client-side JS app","fork":false,"url":"https://api.github.com/repos/bazaarvoice/scoutfile","forks_url":"https://api.github.com/repos/bazaarvoice/scoutfile/forks","keys_url":"https://api.github.com/repos/bazaarvoice/scoutfile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bazaarvoice/scoutfile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bazaarvoice/scoutfile/teams","hooks_url":"https://api.github.com/repos/bazaarvoice/scoutfile/hooks","issue_events_url":"https://api.github.com/repos/bazaarvoice/scoutfile/issues/events{/number}","events_url":"https://api.github.com/repos/bazaarvoice/scoutfile/events","assignees_url":"https://api.github.com/repos/bazaarvoice/scoutfile/assignees{/user}","branches_url":"https://api.github.com/repos/bazaarvoice/scoutfile/branches{/branch}","tags_url":"https://api.github.com/repos/bazaarvoice/scoutfile/tags","blobs_url":"https://api.github.com/repos/bazaarvoice/scoutfile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bazaarvoice/scoutfile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bazaarvoice/scoutfile/git/refs{/sha}","trees_url":"https://api.github.com/repos/bazaarvoice/scoutfile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bazaarvoice/scoutfile/statuses/{sha}","languages_url":"https://api.github.com/repos/bazaarvoice/scoutfile/languages","stargazers_url":"https://api.github.com/repos/bazaarvoice/scoutfile/stargazers","contributors_url":"https://api.github.com/repos/bazaarvoice/scoutfile/contributors","subscribers_url":"https://api.github.com/repos/bazaarvoice/scoutfile/subscribers","subscription_url":"https://api.github.com/repos/bazaarvoice/scoutfile/subscription","commits_url":"https://api.github.com/repos/bazaarvoice/scoutfile/commits{/sha}","git_commits_url":"https://api.github.com/repos/bazaarvoice/scoutfile/git/commits{/sha}","comments_url":"https://api.github.com/repos/bazaarvoice/scoutfile/comments{/number}","issue_comment_url":"https://api.github.com/repos/bazaarvoice/scoutfile/issues/comments{/number}","contents_url":"https://api.github.com/repos/bazaarvoice/scoutfile/contents/{+path}","compare_url":"https://api.github.com/repos/bazaarvoice/scoutfile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bazaarvoice/scoutfile/merges","archive_url":"https://api.github.com/repos/bazaarvoice/scoutfile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bazaarvoice/scoutfile/downloads","issues_url":"https://api.github.com/repos/bazaarvoice/scoutfile/issues{/number}","pulls_url":"https://api.github.com/repos/bazaarvoice/scoutfile/pulls{/number}","milestones_url":"https://api.github.com/repos/bazaarvoice/scoutfile/milestones{/number}","notifications_url":"https://api.github.com/repos/bazaarvoice/scoutfile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bazaarvoice/scoutfile/labels{/name}","releases_url":"https://api.github.com/repos/bazaarvoice/scoutfile/releases{/id}","created_at":"2015-03-03T19:23:07Z","updated_at":"2015-04-06T13:58:37Z","pushed_at":"2015-04-15T19:07:34Z","git_url":"git://github.com/bazaarvoice/scoutfile.git","ssh_url":"git@github.com:bazaarvoice/scoutfile.git","clone_url":"https://github.com/bazaarvoice/scoutfile.git","svn_url":"https://github.com/bazaarvoice/scoutfile","homepage":"","size":354,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":9,"forks":4,"open_issues":9,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bazaarvoice/scoutfile/pulls/12"},"html":{"href":"https://github.com/bazaarvoice/scoutfile/pull/12"},"issue":{"href":"https://api.github.com/repos/bazaarvoice/scoutfile/issues/12"},"comments":{"href":"https://api.github.com/repos/bazaarvoice/scoutfile/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/bazaarvoice/scoutfile/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/bazaarvoice/scoutfile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bazaarvoice/scoutfile/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/bazaarvoice/scoutfile/statuses/666e3416d1e7778f74227a9e89912493da224b6e"}}}}