{"action":"created","comment":{"url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/pulls/comments/41629405","id":41629405,"diff_hunk":"@@ -44,8 +45,20 @@ object ChatBuild extends Build {\n             .map((f1, f2) => Seq(f1.data, f2.data)),\n         watchSources <++= (watchSources in frontend)\n       )\n+      .dependsOn(sharedJvm)\n+\n+  lazy val shared = (crossProject.crossType(CrossType.Pure) in file (\"shared\")).\n+    settings(\n+      scalaVersion:=scalaV,\n+      libraryDependencies +=\"org.scala-js\" %% \"scalajs-stubs\" % scalaJSVersion % \"provided\"","path":"project/ChatBuild.scala","position":17,"original_position":17,"commit_id":"37027f5b62ad8a8a236a468b52b2ff056e76a962","original_commit_id":"37027f5b62ad8a8a236a468b52b2ff056e76a962","user":{"login":"cridmann","id":4443056,"avatar_url":"https://avatars.githubusercontent.com/u/4443056?v=3","gravatar_id":"","url":"https://api.github.com/users/cridmann","html_url":"https://github.com/cridmann","followers_url":"https://api.github.com/users/cridmann/followers","following_url":"https://api.github.com/users/cridmann/following{/other_user}","gists_url":"https://api.github.com/users/cridmann/gists{/gist_id}","starred_url":"https://api.github.com/users/cridmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cridmann/subscriptions","organizations_url":"https://api.github.com/users/cridmann/orgs","repos_url":"https://api.github.com/users/cridmann/repos","events_url":"https://api.github.com/users/cridmann/events{/privacy}","received_events_url":"https://api.github.com/users/cridmann/received_events","type":"User","site_admin":false},"body":"Cool.  PS `libraryDependencies +=\"org.scala-js\" %% \"scalajs-stubs\" % scalaJSVersion % \"provided\"` is useful if you ever need to use ScalaJS export annotations in the shared code, as I've run into [this issue](http://stackoverflow.com/questions/28413266/how-to-export-properties-of-shared-case-classes) before.  No need for it in this project yet, but just keep it in the back of your mind if you ever need it.","created_at":"2015-10-09T13:29:42Z","updated_at":"2015-10-09T13:29:42Z","html_url":"https://github.com/jrudolph/akka-http-scala-js-websocket-chat/pull/8#discussion_r41629405","pull_request_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/pulls/comments/41629405"},"html":{"href":"https://github.com/jrudolph/akka-http-scala-js-websocket-chat/pull/8#discussion_r41629405"},"pull_request":{"href":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/pulls/8","id":47104833,"html_url":"https://github.com/jrudolph/akka-http-scala-js-websocket-chat/pull/8","diff_url":"https://github.com/jrudolph/akka-http-scala-js-websocket-chat/pull/8.diff","patch_url":"https://github.com/jrudolph/akka-http-scala-js-websocket-chat/pull/8.patch","issue_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/issues/8","number":8,"state":"closed","locked":false,"title":"change project structure to allow shared code between client and server","user":{"login":"cridmann","id":4443056,"avatar_url":"https://avatars.githubusercontent.com/u/4443056?v=3","gravatar_id":"","url":"https://api.github.com/users/cridmann","html_url":"https://github.com/cridmann","followers_url":"https://api.github.com/users/cridmann/followers","following_url":"https://api.github.com/users/cridmann/following{/other_user}","gists_url":"https://api.github.com/users/cridmann/gists{/gist_id}","starred_url":"https://api.github.com/users/cridmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cridmann/subscriptions","organizations_url":"https://api.github.com/users/cridmann/orgs","repos_url":"https://api.github.com/users/cridmann/repos","events_url":"https://api.github.com/users/cridmann/events{/privacy}","received_events_url":"https://api.github.com/users/cridmann/received_events","type":"User","site_admin":false},"body":"Fixes #7 ","created_at":"2015-10-08T02:15:48Z","updated_at":"2015-10-09T13:29:42Z","closed_at":"2015-10-09T09:41:52Z","merged_at":"2015-10-09T09:41:52Z","merge_commit_sha":"b69dcafcd5781e0163503baa915dccf72b273b95","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/pulls/8/commits","review_comments_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/pulls/8/comments","review_comment_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/issues/8/comments","statuses_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/statuses/37027f5b62ad8a8a236a468b52b2ff056e76a962","head":{"label":"cridmann:master","ref":"master","sha":"37027f5b62ad8a8a236a468b52b2ff056e76a962","user":{"login":"cridmann","id":4443056,"avatar_url":"https://avatars.githubusercontent.com/u/4443056?v=3","gravatar_id":"","url":"https://api.github.com/users/cridmann","html_url":"https://github.com/cridmann","followers_url":"https://api.github.com/users/cridmann/followers","following_url":"https://api.github.com/users/cridmann/following{/other_user}","gists_url":"https://api.github.com/users/cridmann/gists{/gist_id}","starred_url":"https://api.github.com/users/cridmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cridmann/subscriptions","organizations_url":"https://api.github.com/users/cridmann/orgs","repos_url":"https://api.github.com/users/cridmann/repos","events_url":"https://api.github.com/users/cridmann/events{/privacy}","received_events_url":"https://api.github.com/users/cridmann/received_events","type":"User","site_admin":false},"repo":{"id":43856221,"name":"akka-http-scala-js-websocket-chat","full_name":"cridmann/akka-http-scala-js-websocket-chat","owner":{"login":"cridmann","id":4443056,"avatar_url":"https://avatars.githubusercontent.com/u/4443056?v=3","gravatar_id":"","url":"https://api.github.com/users/cridmann","html_url":"https://github.com/cridmann","followers_url":"https://api.github.com/users/cridmann/followers","following_url":"https://api.github.com/users/cridmann/following{/other_user}","gists_url":"https://api.github.com/users/cridmann/gists{/gist_id}","starred_url":"https://api.github.com/users/cridmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cridmann/subscriptions","organizations_url":"https://api.github.com/users/cridmann/orgs","repos_url":"https://api.github.com/users/cridmann/repos","events_url":"https://api.github.com/users/cridmann/events{/privacy}","received_events_url":"https://api.github.com/users/cridmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cridmann/akka-http-scala-js-websocket-chat","description":"An example app that integrates akka-http and scala-js to implement a websocket chat","fork":true,"url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat","forks_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/forks","keys_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/teams","hooks_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/hooks","issue_events_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/issues/events{/number}","events_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/events","assignees_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/assignees{/user}","branches_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/branches{/branch}","tags_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/tags","blobs_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/git/refs{/sha}","trees_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/statuses/{sha}","languages_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/languages","stargazers_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/stargazers","contributors_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/contributors","subscribers_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/subscribers","subscription_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/subscription","commits_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/commits{/sha}","git_commits_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/git/commits{/sha}","comments_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/comments{/number}","issue_comment_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/issues/comments{/number}","contents_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/contents/{+path}","compare_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/merges","archive_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/downloads","issues_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/issues{/number}","pulls_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/pulls{/number}","milestones_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/milestones{/number}","notifications_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/labels{/name}","releases_url":"https://api.github.com/repos/cridmann/akka-http-scala-js-websocket-chat/releases{/id}","created_at":"2015-10-08T01:59:48Z","updated_at":"2015-10-08T01:59:48Z","pushed_at":"2015-10-08T02:08:29Z","git_url":"git://github.com/cridmann/akka-http-scala-js-websocket-chat.git","ssh_url":"git@github.com:cridmann/akka-http-scala-js-websocket-chat.git","clone_url":"https://github.com/cridmann/akka-http-scala-js-websocket-chat.git","svn_url":"https://github.com/cridmann/akka-http-scala-js-websocket-chat","homepage":null,"size":249,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jrudolph:master","ref":"master","sha":"56fb8fcd0a260a4f6916726c83ff12055f2365fc","user":{"login":"jrudolph","id":9868,"avatar_url":"https://avatars.githubusercontent.com/u/9868?v=3","gravatar_id":"","url":"https://api.github.com/users/jrudolph","html_url":"https://github.com/jrudolph","followers_url":"https://api.github.com/users/jrudolph/followers","following_url":"https://api.github.com/users/jrudolph/following{/other_user}","gists_url":"https://api.github.com/users/jrudolph/gists{/gist_id}","starred_url":"https://api.github.com/users/jrudolph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrudolph/subscriptions","organizations_url":"https://api.github.com/users/jrudolph/orgs","repos_url":"https://api.github.com/users/jrudolph/repos","events_url":"https://api.github.com/users/jrudolph/events{/privacy}","received_events_url":"https://api.github.com/users/jrudolph/received_events","type":"User","site_admin":false},"repo":{"id":34672342,"name":"akka-http-scala-js-websocket-chat","full_name":"jrudolph/akka-http-scala-js-websocket-chat","owner":{"login":"jrudolph","id":9868,"avatar_url":"https://avatars.githubusercontent.com/u/9868?v=3","gravatar_id":"","url":"https://api.github.com/users/jrudolph","html_url":"https://github.com/jrudolph","followers_url":"https://api.github.com/users/jrudolph/followers","following_url":"https://api.github.com/users/jrudolph/following{/other_user}","gists_url":"https://api.github.com/users/jrudolph/gists{/gist_id}","starred_url":"https://api.github.com/users/jrudolph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrudolph/subscriptions","organizations_url":"https://api.github.com/users/jrudolph/orgs","repos_url":"https://api.github.com/users/jrudolph/repos","events_url":"https://api.github.com/users/jrudolph/events{/privacy}","received_events_url":"https://api.github.com/users/jrudolph/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrudolph/akka-http-scala-js-websocket-chat","description":"An example app that integrates akka-http and scala-js to implement a websocket chat","fork":false,"url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat","forks_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/forks","keys_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/teams","hooks_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/hooks","issue_events_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/issues/events{/number}","events_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/events","assignees_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/assignees{/user}","branches_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/branches{/branch}","tags_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/tags","blobs_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/statuses/{sha}","languages_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/languages","stargazers_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/stargazers","contributors_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/contributors","subscribers_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/subscribers","subscription_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/subscription","commits_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/contents/{+path}","compare_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/merges","archive_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/downloads","issues_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/issues{/number}","pulls_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/pulls{/number}","milestones_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/milestones{/number}","notifications_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/labels{/name}","releases_url":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/releases{/id}","created_at":"2015-04-27T14:43:34Z","updated_at":"2015-10-08T07:47:27Z","pushed_at":"2015-10-09T09:41:52Z","git_url":"git://github.com/jrudolph/akka-http-scala-js-websocket-chat.git","ssh_url":"git@github.com:jrudolph/akka-http-scala-js-websocket-chat.git","clone_url":"https://github.com/jrudolph/akka-http-scala-js-websocket-chat.git","svn_url":"https://github.com/jrudolph/akka-http-scala-js-websocket-chat","homepage":null,"size":249,"stargazers_count":89,"watchers_count":89,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":1,"forks":16,"open_issues":1,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/pulls/8"},"html":{"href":"https://github.com/jrudolph/akka-http-scala-js-websocket-chat/pull/8"},"issue":{"href":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/issues/8"},"comments":{"href":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/jrudolph/akka-http-scala-js-websocket-chat/statuses/37027f5b62ad8a8a236a468b52b2ff056e76a962"}}}}