{"action":"created","issue":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/656","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/656/labels{/name}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/656/comments","events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/656/events","html_url":"https://github.com/mixxxdj/mixxx/pull/656","id":95966348,"number":656,"title":"simplify ControllerEngine::connectControl","user":{"login":"Be-ing","id":9455094,"avatar_url":"https://avatars.githubusercontent.com/u/9455094?v=3","gravatar_id":"","url":"https://api.github.com/users/Be-ing","html_url":"https://github.com/Be-ing","followers_url":"https://api.github.com/users/Be-ing/followers","following_url":"https://api.github.com/users/Be-ing/following{/other_user}","gists_url":"https://api.github.com/users/Be-ing/gists{/gist_id}","starred_url":"https://api.github.com/users/Be-ing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Be-ing/subscriptions","organizations_url":"https://api.github.com/users/Be-ing/orgs","repos_url":"https://api.github.com/users/Be-ing/repos","events_url":"https://api.github.com/users/Be-ing/events{/privacy}","received_events_url":"https://api.github.com/users/Be-ing/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-07-20T01:31:14Z","updated_at":"2015-07-20T21:07:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/656","html_url":"https://github.com/mixxxdj/mixxx/pull/656","diff_url":"https://github.com/mixxxdj/mixxx/pull/656.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/656.patch"},"body":"also make debugging and error messages more descriptive\r\n\r\nThis fixes https://bugs.launchpad.net/mixxx/+bug/1458264:\r\nengine.connectionControl(group, control, function, true) connects control to a function rather than removes connection)\r\n\r\nI tried writing a test to demonstrate the above bug but couldn't get the test to fail (on a branch without this commit of course). I did see that the bug was there because the test output showed the connection being made twice, but the logic of the test did not fail when this happened."},"comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments/123039504","html_url":"https://github.com/mixxxdj/mixxx/pull/656#issuecomment-123039504","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/656","id":123039504,"user":{"login":"daschuer","id":1777442,"avatar_url":"https://avatars.githubusercontent.com/u/1777442?v=3","gravatar_id":"","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"created_at":"2015-07-20T21:07:41Z","updated_at":"2015-07-20T21:07:41Z","body":"> I'm not clear about the purpose of this clause ...\r\n\r\nThis should be a short cut to re-connect a stored \"conn\" object. \r\nIf you change the return value to boolean, this condition is useless. "}}