{"action":"created","comment":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments/33544114","id":33544114,"diff_hunk":"@@ -170,6 +169,28 @@ angular.module('ui.bootstrap.typeahead', ['ui.bootstrap.position', 'ui.bootstrap\n         });\n       };\n \n+      // bind events only if appendToBody params exist - performance feature\n+      if ( appendToBody ) {\n+        angular.element( $window ).bind( 'resize', fireRecalculating );\n+        angular.element( document.body ).bind( 'scroll', fireRecalculating );","path":"src/typeahead/typeahead.js","position":28,"original_position":28,"commit_id":"215561021081f2fbcc76dd45ac724e535e7bfd71","original_commit_id":"215561021081f2fbcc76dd45ac724e535e7bfd71","user":{"login":"wesleycho","id":1703387,"avatar_url":"https://avatars.githubusercontent.com/u/1703387?v=3","gravatar_id":"","url":"https://api.github.com/users/wesleycho","html_url":"https://github.com/wesleycho","followers_url":"https://api.github.com/users/wesleycho/followers","following_url":"https://api.github.com/users/wesleycho/following{/other_user}","gists_url":"https://api.github.com/users/wesleycho/gists{/gist_id}","starred_url":"https://api.github.com/users/wesleycho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesleycho/subscriptions","organizations_url":"https://api.github.com/users/wesleycho/orgs","repos_url":"https://api.github.com/users/wesleycho/repos","events_url":"https://api.github.com/users/wesleycho/events{/privacy}","received_events_url":"https://api.github.com/users/wesleycho/received_events","type":"User","site_admin":false},"body":"These bindings should be throttled.\r\n\r\nAlso you can use $document.find('body') instead.","created_at":"2015-06-30T06:41:41Z","updated_at":"2015-06-30T06:41:41Z","html_url":"https://github.com/angular-ui/bootstrap/pull/3874#discussion_r33544114","pull_request_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3874","_links":{"self":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments/33544114"},"html":{"href":"https://github.com/angular-ui/bootstrap/pull/3874#discussion_r33544114"},"pull_request":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3874"}}},"pull_request":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3874","id":38846682,"html_url":"https://github.com/angular-ui/bootstrap/pull/3874","diff_url":"https://github.com/angular-ui/bootstrap/pull/3874.diff","patch_url":"https://github.com/angular-ui/bootstrap/pull/3874.patch","issue_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/3874","number":3874,"state":"open","locked":false,"title":"Typeahead popup position","user":{"login":"davidrus","id":1128128,"avatar_url":"https://avatars.githubusercontent.com/u/1128128?v=3","gravatar_id":"","url":"https://api.github.com/users/davidrus","html_url":"https://github.com/davidrus","followers_url":"https://api.github.com/users/davidrus/followers","following_url":"https://api.github.com/users/davidrus/following{/other_user}","gists_url":"https://api.github.com/users/davidrus/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrus/subscriptions","organizations_url":"https://api.github.com/users/davidrus/orgs","repos_url":"https://api.github.com/users/davidrus/repos","events_url":"https://api.github.com/users/davidrus/events{/privacy}","received_events_url":"https://api.github.com/users/davidrus/received_events","type":"User","site_admin":false},"body":"## Append-to-body dropdown position \r\nAdd support for typeahead-dropdown position after scroll and resize events. \r\n\r\n### Scenario 1\r\n* Type some text into input (show dropdown appended to body)\r\n* Scroll down\r\n* We need dropdown in right place after input\r\n\r\n### Scenario 2\r\n* Type some text into input (show dropdown appended to body)\r\n* Resize after breakpoint in media query (change position of input)\r\n* We need dropdown in right place after input\r\n\r\nThanks","created_at":"2015-06-30T06:38:55Z","updated_at":"2015-06-30T06:41:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2490c2bdfc5dcaf1abe0fa6a30b729c225529436","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3874/commits","review_comments_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3874/comments","review_comment_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/3874/comments","statuses_url":"https://api.github.com/repos/angular-ui/bootstrap/statuses/215561021081f2fbcc76dd45ac724e535e7bfd71","head":{"label":"davidrus:typeahead-popup-position","ref":"typeahead-popup-position","sha":"215561021081f2fbcc76dd45ac724e535e7bfd71","user":{"login":"davidrus","id":1128128,"avatar_url":"https://avatars.githubusercontent.com/u/1128128?v=3","gravatar_id":"","url":"https://api.github.com/users/davidrus","html_url":"https://github.com/davidrus","followers_url":"https://api.github.com/users/davidrus/followers","following_url":"https://api.github.com/users/davidrus/following{/other_user}","gists_url":"https://api.github.com/users/davidrus/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrus/subscriptions","organizations_url":"https://api.github.com/users/davidrus/orgs","repos_url":"https://api.github.com/users/davidrus/repos","events_url":"https://api.github.com/users/davidrus/events{/privacy}","received_events_url":"https://api.github.com/users/davidrus/received_events","type":"User","site_admin":false},"repo":{"id":38252621,"name":"bootstrap","full_name":"davidrus/bootstrap","owner":{"login":"davidrus","id":1128128,"avatar_url":"https://avatars.githubusercontent.com/u/1128128?v=3","gravatar_id":"","url":"https://api.github.com/users/davidrus","html_url":"https://github.com/davidrus","followers_url":"https://api.github.com/users/davidrus/followers","following_url":"https://api.github.com/users/davidrus/following{/other_user}","gists_url":"https://api.github.com/users/davidrus/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrus/subscriptions","organizations_url":"https://api.github.com/users/davidrus/orgs","repos_url":"https://api.github.com/users/davidrus/repos","events_url":"https://api.github.com/users/davidrus/events{/privacy}","received_events_url":"https://api.github.com/users/davidrus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidrus/bootstrap","description":"Native AngularJS (Angular) directives for Bootstrap. Small footprint (5kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!","fork":true,"url":"https://api.github.com/repos/davidrus/bootstrap","forks_url":"https://api.github.com/repos/davidrus/bootstrap/forks","keys_url":"https://api.github.com/repos/davidrus/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidrus/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidrus/bootstrap/teams","hooks_url":"https://api.github.com/repos/davidrus/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/davidrus/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/davidrus/bootstrap/events","assignees_url":"https://api.github.com/repos/davidrus/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/davidrus/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/davidrus/bootstrap/tags","blobs_url":"https://api.github.com/repos/davidrus/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidrus/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidrus/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidrus/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidrus/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/davidrus/bootstrap/languages","stargazers_url":"https://api.github.com/repos/davidrus/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/davidrus/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/davidrus/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/davidrus/bootstrap/subscription","commits_url":"https://api.github.com/repos/davidrus/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidrus/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidrus/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidrus/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidrus/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/davidrus/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidrus/bootstrap/merges","archive_url":"https://api.github.com/repos/davidrus/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidrus/bootstrap/downloads","issues_url":"https://api.github.com/repos/davidrus/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/davidrus/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/davidrus/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/davidrus/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidrus/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/davidrus/bootstrap/releases{/id}","created_at":"2015-06-29T14:40:52Z","updated_at":"2015-06-29T14:40:54Z","pushed_at":"2015-06-30T06:34:20Z","git_url":"git://github.com/davidrus/bootstrap.git","ssh_url":"git@github.com:davidrus/bootstrap.git","clone_url":"https://github.com/davidrus/bootstrap.git","svn_url":"https://github.com/davidrus/bootstrap","homepage":"http://angular-ui.github.io/bootstrap/","size":19595,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular-ui:master","ref":"master","sha":"7fb3840f2f4748883f2ee9818278bc3479523373","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":6094683,"name":"bootstrap","full_name":"angular-ui/bootstrap","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/bootstrap","description":"Native AngularJS (Angular) directives for Bootstrap. Small footprint (5kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!","fork":false,"url":"https://api.github.com/repos/angular-ui/bootstrap","forks_url":"https://api.github.com/repos/angular-ui/bootstrap/forks","keys_url":"https://api.github.com/repos/angular-ui/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/bootstrap/teams","hooks_url":"https://api.github.com/repos/angular-ui/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/bootstrap/events","assignees_url":"https://api.github.com/repos/angular-ui/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/bootstrap/tags","blobs_url":"https://api.github.com/repos/angular-ui/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/bootstrap/languages","stargazers_url":"https://api.github.com/repos/angular-ui/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/bootstrap/subscription","commits_url":"https://api.github.com/repos/angular-ui/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular-ui/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/bootstrap/merges","archive_url":"https://api.github.com/repos/angular-ui/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/bootstrap/downloads","issues_url":"https://api.github.com/repos/angular-ui/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/bootstrap/releases{/id}","created_at":"2012-10-05T18:27:01Z","updated_at":"2015-06-30T05:54:25Z","pushed_at":"2015-06-30T06:38:55Z","git_url":"git://github.com/angular-ui/bootstrap.git","ssh_url":"git@github.com:angular-ui/bootstrap.git","clone_url":"https://github.com/angular-ui/bootstrap.git","svn_url":"https://github.com/angular-ui/bootstrap","homepage":"http://angular-ui.github.io/bootstrap/","size":19595,"stargazers_count":9325,"watchers_count":9325,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4879,"mirror_url":null,"open_issues_count":549,"forks":4879,"open_issues":549,"watchers":9325,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3874"},"html":{"href":"https://github.com/angular-ui/bootstrap/pull/3874"},"issue":{"href":"https://api.github.com/repos/angular-ui/bootstrap/issues/3874"},"comments":{"href":"https://api.github.com/repos/angular-ui/bootstrap/issues/3874/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3874/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3874/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/bootstrap/statuses/215561021081f2fbcc76dd45ac724e535e7bfd71"}}}}