{"action":"created","comment":{"url":"https://api.github.com/repos/camptocamp/cgxp/pulls/comments/26110659","id":26110659,"diff_hunk":"@@ -152,12 +152,14 @@ cgxp.plugins.ContextualData = Ext.extend(gxp.plugins.Tool, {\n      */\n     handleServerData: function(data) {\n         var result = {};\n-        Ext.each(data, function(key) {\n-            if (['mnt', 'mns'].indexOf(key) < 0) {\n-                result[key + '_value'] = data[key];\n-                result[key + '_label'] = OpenLayers.i18n(key);\n+        for (var key in data) {\n+            if (data.hasOwnProperty(key)) {\n+                if (['mnt', 'mns'].indexOf(key) < 0) {","path":"core/src/script/CGXP/plugins/ContextualData.js","position":10,"original_position":10,"commit_id":"528f00a3b8ec08ad73304674f5831382ffdb13fe","original_commit_id":"528f00a3b8ec08ad73304674f5831382ffdb13fe","user":{"login":"asaunier","id":1192331,"avatar_url":"https://avatars.githubusercontent.com/u/1192331?v=3","gravatar_id":"","url":"https://api.github.com/users/asaunier","html_url":"https://github.com/asaunier","followers_url":"https://api.github.com/users/asaunier/followers","following_url":"https://api.github.com/users/asaunier/following{/other_user}","gists_url":"https://api.github.com/users/asaunier/gists{/gist_id}","starred_url":"https://api.github.com/users/asaunier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asaunier/subscriptions","organizations_url":"https://api.github.com/users/asaunier/orgs","repos_url":"https://api.github.com/users/asaunier/repos","events_url":"https://api.github.com/users/asaunier/events{/privacy}","received_events_url":"https://api.github.com/users/asaunier/received_events","type":"User","site_admin":false},"body":"Using basic operators is easier to read. Testing among 2 values does not require using indexOf.","created_at":"2015-03-10T10:27:30Z","updated_at":"2015-03-10T10:27:30Z","html_url":"https://github.com/camptocamp/cgxp/pull/920#discussion_r26110659","pull_request_url":"https://api.github.com/repos/camptocamp/cgxp/pulls/920","_links":{"self":{"href":"https://api.github.com/repos/camptocamp/cgxp/pulls/comments/26110659"},"html":{"href":"https://github.com/camptocamp/cgxp/pull/920#discussion_r26110659"},"pull_request":{"href":"https://api.github.com/repos/camptocamp/cgxp/pulls/920"}}},"pull_request":{"url":"https://api.github.com/repos/camptocamp/cgxp/pulls/920","id":30752140,"html_url":"https://github.com/camptocamp/cgxp/pull/920","diff_url":"https://github.com/camptocamp/cgxp/pull/920.diff","patch_url":"https://github.com/camptocamp/cgxp/pull/920.patch","issue_url":"https://api.github.com/repos/camptocamp/cgxp/issues/920","number":920,"state":"open","locked":false,"title":"Fix extra raster key handling","user":{"login":"sbrunner","id":353872,"avatar_url":"https://avatars.githubusercontent.com/u/353872?v=3","gravatar_id":"","url":"https://api.github.com/users/sbrunner","html_url":"https://github.com/sbrunner","followers_url":"https://api.github.com/users/sbrunner/followers","following_url":"https://api.github.com/users/sbrunner/following{/other_user}","gists_url":"https://api.github.com/users/sbrunner/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrunner/subscriptions","organizations_url":"https://api.github.com/users/sbrunner/orgs","repos_url":"https://api.github.com/users/sbrunner/repos","events_url":"https://api.github.com/users/sbrunner/events{/privacy}","received_events_url":"https://api.github.com/users/sbrunner/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-09T11:14:58Z","updated_at":"2015-03-10T10:27:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"453dc9405f1afe8b0efc37cdf93b76967b31dd89","assignee":null,"milestone":{"url":"https://api.github.com/repos/camptocamp/cgxp/milestones/19","html_url":"https://github.com/camptocamp/cgxp/milestones/1.6","labels_url":"https://api.github.com/repos/camptocamp/cgxp/milestones/19/labels","id":697059,"number":19,"title":"1.6","description":null,"creator":{"login":"sbrunner","id":353872,"avatar_url":"https://avatars.githubusercontent.com/u/353872?v=3","gravatar_id":"","url":"https://api.github.com/users/sbrunner","html_url":"https://github.com/sbrunner","followers_url":"https://api.github.com/users/sbrunner/followers","following_url":"https://api.github.com/users/sbrunner/following{/other_user}","gists_url":"https://api.github.com/users/sbrunner/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrunner/subscriptions","organizations_url":"https://api.github.com/users/sbrunner/orgs","repos_url":"https://api.github.com/users/sbrunner/repos","events_url":"https://api.github.com/users/sbrunner/events{/privacy}","received_events_url":"https://api.github.com/users/sbrunner/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":10,"state":"open","created_at":"2014-06-20T18:24:30Z","updated_at":"2015-03-10T09:09:32Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/camptocamp/cgxp/pulls/920/commits","review_comments_url":"https://api.github.com/repos/camptocamp/cgxp/pulls/920/comments","review_comment_url":"https://api.github.com/repos/camptocamp/cgxp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/camptocamp/cgxp/issues/920/comments","statuses_url":"https://api.github.com/repos/camptocamp/cgxp/statuses/528f00a3b8ec08ad73304674f5831382ffdb13fe","head":{"label":"camptocamp:ContextualData","ref":"ContextualData","sha":"528f00a3b8ec08ad73304674f5831382ffdb13fe","user":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars.githubusercontent.com/u/28109?v=3","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"repo":{"id":2780345,"name":"cgxp","full_name":"camptocamp/cgxp","owner":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars.githubusercontent.com/u/28109?v=3","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/camptocamp/cgxp","description":"","fork":false,"url":"https://api.github.com/repos/camptocamp/cgxp","forks_url":"https://api.github.com/repos/camptocamp/cgxp/forks","keys_url":"https://api.github.com/repos/camptocamp/cgxp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/camptocamp/cgxp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/camptocamp/cgxp/teams","hooks_url":"https://api.github.com/repos/camptocamp/cgxp/hooks","issue_events_url":"https://api.github.com/repos/camptocamp/cgxp/issues/events{/number}","events_url":"https://api.github.com/repos/camptocamp/cgxp/events","assignees_url":"https://api.github.com/repos/camptocamp/cgxp/assignees{/user}","branches_url":"https://api.github.com/repos/camptocamp/cgxp/branches{/branch}","tags_url":"https://api.github.com/repos/camptocamp/cgxp/tags","blobs_url":"https://api.github.com/repos/camptocamp/cgxp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/camptocamp/cgxp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/camptocamp/cgxp/git/refs{/sha}","trees_url":"https://api.github.com/repos/camptocamp/cgxp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/camptocamp/cgxp/statuses/{sha}","languages_url":"https://api.github.com/repos/camptocamp/cgxp/languages","stargazers_url":"https://api.github.com/repos/camptocamp/cgxp/stargazers","contributors_url":"https://api.github.com/repos/camptocamp/cgxp/contributors","subscribers_url":"https://api.github.com/repos/camptocamp/cgxp/subscribers","subscription_url":"https://api.github.com/repos/camptocamp/cgxp/subscription","commits_url":"https://api.github.com/repos/camptocamp/cgxp/commits{/sha}","git_commits_url":"https://api.github.com/repos/camptocamp/cgxp/git/commits{/sha}","comments_url":"https://api.github.com/repos/camptocamp/cgxp/comments{/number}","issue_comment_url":"https://api.github.com/repos/camptocamp/cgxp/issues/comments{/number}","contents_url":"https://api.github.com/repos/camptocamp/cgxp/contents/{+path}","compare_url":"https://api.github.com/repos/camptocamp/cgxp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/camptocamp/cgxp/merges","archive_url":"https://api.github.com/repos/camptocamp/cgxp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/camptocamp/cgxp/downloads","issues_url":"https://api.github.com/repos/camptocamp/cgxp/issues{/number}","pulls_url":"https://api.github.com/repos/camptocamp/cgxp/pulls{/number}","milestones_url":"https://api.github.com/repos/camptocamp/cgxp/milestones{/number}","notifications_url":"https://api.github.com/repos/camptocamp/cgxp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/camptocamp/cgxp/labels{/name}","releases_url":"https://api.github.com/repos/camptocamp/cgxp/releases{/id}","created_at":"2011-11-15T13:57:41Z","updated_at":"2015-03-04T10:48:45Z","pushed_at":"2015-03-09T11:14:15Z","git_url":"git://github.com/camptocamp/cgxp.git","ssh_url":"git@github.com:camptocamp/cgxp.git","clone_url":"https://github.com/camptocamp/cgxp.git","svn_url":"https://github.com/camptocamp/cgxp","homepage":"","size":28202,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":40,"forks":21,"open_issues":40,"watchers":19,"default_branch":"master"}},"base":{"label":"camptocamp:master","ref":"master","sha":"dc9153e0221620b19b6b97e7c8424e7617b2e5d2","user":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars.githubusercontent.com/u/28109?v=3","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"repo":{"id":2780345,"name":"cgxp","full_name":"camptocamp/cgxp","owner":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars.githubusercontent.com/u/28109?v=3","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/camptocamp/cgxp","description":"","fork":false,"url":"https://api.github.com/repos/camptocamp/cgxp","forks_url":"https://api.github.com/repos/camptocamp/cgxp/forks","keys_url":"https://api.github.com/repos/camptocamp/cgxp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/camptocamp/cgxp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/camptocamp/cgxp/teams","hooks_url":"https://api.github.com/repos/camptocamp/cgxp/hooks","issue_events_url":"https://api.github.com/repos/camptocamp/cgxp/issues/events{/number}","events_url":"https://api.github.com/repos/camptocamp/cgxp/events","assignees_url":"https://api.github.com/repos/camptocamp/cgxp/assignees{/user}","branches_url":"https://api.github.com/repos/camptocamp/cgxp/branches{/branch}","tags_url":"https://api.github.com/repos/camptocamp/cgxp/tags","blobs_url":"https://api.github.com/repos/camptocamp/cgxp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/camptocamp/cgxp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/camptocamp/cgxp/git/refs{/sha}","trees_url":"https://api.github.com/repos/camptocamp/cgxp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/camptocamp/cgxp/statuses/{sha}","languages_url":"https://api.github.com/repos/camptocamp/cgxp/languages","stargazers_url":"https://api.github.com/repos/camptocamp/cgxp/stargazers","contributors_url":"https://api.github.com/repos/camptocamp/cgxp/contributors","subscribers_url":"https://api.github.com/repos/camptocamp/cgxp/subscribers","subscription_url":"https://api.github.com/repos/camptocamp/cgxp/subscription","commits_url":"https://api.github.com/repos/camptocamp/cgxp/commits{/sha}","git_commits_url":"https://api.github.com/repos/camptocamp/cgxp/git/commits{/sha}","comments_url":"https://api.github.com/repos/camptocamp/cgxp/comments{/number}","issue_comment_url":"https://api.github.com/repos/camptocamp/cgxp/issues/comments{/number}","contents_url":"https://api.github.com/repos/camptocamp/cgxp/contents/{+path}","compare_url":"https://api.github.com/repos/camptocamp/cgxp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/camptocamp/cgxp/merges","archive_url":"https://api.github.com/repos/camptocamp/cgxp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/camptocamp/cgxp/downloads","issues_url":"https://api.github.com/repos/camptocamp/cgxp/issues{/number}","pulls_url":"https://api.github.com/repos/camptocamp/cgxp/pulls{/number}","milestones_url":"https://api.github.com/repos/camptocamp/cgxp/milestones{/number}","notifications_url":"https://api.github.com/repos/camptocamp/cgxp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/camptocamp/cgxp/labels{/name}","releases_url":"https://api.github.com/repos/camptocamp/cgxp/releases{/id}","created_at":"2011-11-15T13:57:41Z","updated_at":"2015-03-04T10:48:45Z","pushed_at":"2015-03-09T11:14:15Z","git_url":"git://github.com/camptocamp/cgxp.git","ssh_url":"git@github.com:camptocamp/cgxp.git","clone_url":"https://github.com/camptocamp/cgxp.git","svn_url":"https://github.com/camptocamp/cgxp","homepage":"","size":28202,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":40,"forks":21,"open_issues":40,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/camptocamp/cgxp/pulls/920"},"html":{"href":"https://github.com/camptocamp/cgxp/pull/920"},"issue":{"href":"https://api.github.com/repos/camptocamp/cgxp/issues/920"},"comments":{"href":"https://api.github.com/repos/camptocamp/cgxp/issues/920/comments"},"review_comments":{"href":"https://api.github.com/repos/camptocamp/cgxp/pulls/920/comments"},"review_comment":{"href":"https://api.github.com/repos/camptocamp/cgxp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/camptocamp/cgxp/pulls/920/commits"},"statuses":{"href":"https://api.github.com/repos/camptocamp/cgxp/statuses/528f00a3b8ec08ad73304674f5831382ffdb13fe"}}}}