{"action":"created","comment":{"url":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/comments/41620390","id":41620390,"diff_hunk":"@@ -33,8 +33,8 @@ class DocumentProviderPlugin : public QObject\n     Q_PROPERTY(QObject *model READ model NOTIFY modelChanged)\n     Q_PROPERTY(bool ready READ isReady NOTIFY readyChanged)\n     Q_PROPERTY(QUrl page READ page WRITE setPage NOTIFY pageChanged)\n-    Q_PROPERTY(QString setupPageUrl READ setupPageUrl NOTIFY titleChanged);\n-    Q_PROPERTY(bool needsSetup READ needsSetup NOTIFY needsSetupChanged);\n+    Q_PROPERTY(QString setupPageUrl READ setupPageUrl NOTIFY titleChanged)\n+    Q_PROPERTY(bool needsSetup READ needsSetup NOTIFY needsSetupChanged)","path":"models/documentproviderplugin.h","position":7,"original_position":7,"commit_id":"2edd0b84d8402b2a96a0d5c0f808504857122c81","original_commit_id":"2edd0b84d8402b2a96a0d5c0f808504857122c81","user":{"login":"rainemak","id":3470958,"avatar_url":"https://avatars.githubusercontent.com/u/3470958?v=3","gravatar_id":"","url":"https://api.github.com/users/rainemak","html_url":"https://github.com/rainemak","followers_url":"https://api.github.com/users/rainemak/followers","following_url":"https://api.github.com/users/rainemak/following{/other_user}","gists_url":"https://api.github.com/users/rainemak/gists{/gist_id}","starred_url":"https://api.github.com/users/rainemak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainemak/subscriptions","organizations_url":"https://api.github.com/users/rainemak/orgs","repos_url":"https://api.github.com/users/rainemak/repos","events_url":"https://api.github.com/users/rainemak/events{/privacy}","received_events_url":"https://api.github.com/users/rainemak/received_events","type":"User","site_admin":false},"body":"I'd assume that all of these could be declared as ```FINAL``` e.i. nobody overrides these properties. ","created_at":"2015-10-09T11:23:22Z","updated_at":"2015-10-09T11:23:22Z","html_url":"https://github.com/sailfishos/sailfish-office/pull/46#discussion_r41620390","pull_request_url":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/comments/41620390"},"html":{"href":"https://github.com/sailfishos/sailfish-office/pull/46#discussion_r41620390"},"pull_request":{"href":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/46","id":45551548,"html_url":"https://github.com/sailfishos/sailfish-office/pull/46","diff_url":"https://github.com/sailfishos/sailfish-office/pull/46.diff","patch_url":"https://github.com/sailfishos/sailfish-office/pull/46.patch","issue_url":"https://api.github.com/repos/sailfishos/sailfish-office/issues/46","number":46,"state":"open","locked":false,"title":"Adjust style, redundant code, deprecated property etc","user":{"login":"pvuorela","id":2478615,"avatar_url":"https://avatars.githubusercontent.com/u/2478615?v=3","gravatar_id":"","url":"https://api.github.com/users/pvuorela","html_url":"https://github.com/pvuorela","followers_url":"https://api.github.com/users/pvuorela/followers","following_url":"https://api.github.com/users/pvuorela/following{/other_user}","gists_url":"https://api.github.com/users/pvuorela/gists{/gist_id}","starred_url":"https://api.github.com/users/pvuorela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvuorela/subscriptions","organizations_url":"https://api.github.com/users/pvuorela/orgs","repos_url":"https://api.github.com/users/pvuorela/repos","events_url":"https://api.github.com/users/pvuorela/events{/privacy}","received_events_url":"https://api.github.com/users/pvuorela/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-21T13:58:35Z","updated_at":"2015-10-09T11:23:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a8d758fe4c4536867e80e569eaa6da1a3500fbb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/46/commits","review_comments_url":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/46/comments","review_comment_url":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sailfishos/sailfish-office/issues/46/comments","statuses_url":"https://api.github.com/repos/sailfishos/sailfish-office/statuses/2edd0b84d8402b2a96a0d5c0f808504857122c81","head":{"label":"pvuorela:master","ref":"master","sha":"2edd0b84d8402b2a96a0d5c0f808504857122c81","user":{"login":"pvuorela","id":2478615,"avatar_url":"https://avatars.githubusercontent.com/u/2478615?v=3","gravatar_id":"","url":"https://api.github.com/users/pvuorela","html_url":"https://github.com/pvuorela","followers_url":"https://api.github.com/users/pvuorela/followers","following_url":"https://api.github.com/users/pvuorela/following{/other_user}","gists_url":"https://api.github.com/users/pvuorela/gists{/gist_id}","starred_url":"https://api.github.com/users/pvuorela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvuorela/subscriptions","organizations_url":"https://api.github.com/users/pvuorela/orgs","repos_url":"https://api.github.com/users/pvuorela/repos","events_url":"https://api.github.com/users/pvuorela/events{/privacy}","received_events_url":"https://api.github.com/users/pvuorela/received_events","type":"User","site_admin":false},"repo":{"id":23704031,"name":"sailfish-office","full_name":"pvuorela/sailfish-office","owner":{"login":"pvuorela","id":2478615,"avatar_url":"https://avatars.githubusercontent.com/u/2478615?v=3","gravatar_id":"","url":"https://api.github.com/users/pvuorela","html_url":"https://github.com/pvuorela","followers_url":"https://api.github.com/users/pvuorela/followers","following_url":"https://api.github.com/users/pvuorela/following{/other_user}","gists_url":"https://api.github.com/users/pvuorela/gists{/gist_id}","starred_url":"https://api.github.com/users/pvuorela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvuorela/subscriptions","organizations_url":"https://api.github.com/users/pvuorela/orgs","repos_url":"https://api.github.com/users/pvuorela/repos","events_url":"https://api.github.com/users/pvuorela/events{/privacy}","received_events_url":"https://api.github.com/users/pvuorela/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pvuorela/sailfish-office","description":"Sailfish Office","fork":true,"url":"https://api.github.com/repos/pvuorela/sailfish-office","forks_url":"https://api.github.com/repos/pvuorela/sailfish-office/forks","keys_url":"https://api.github.com/repos/pvuorela/sailfish-office/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pvuorela/sailfish-office/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pvuorela/sailfish-office/teams","hooks_url":"https://api.github.com/repos/pvuorela/sailfish-office/hooks","issue_events_url":"https://api.github.com/repos/pvuorela/sailfish-office/issues/events{/number}","events_url":"https://api.github.com/repos/pvuorela/sailfish-office/events","assignees_url":"https://api.github.com/repos/pvuorela/sailfish-office/assignees{/user}","branches_url":"https://api.github.com/repos/pvuorela/sailfish-office/branches{/branch}","tags_url":"https://api.github.com/repos/pvuorela/sailfish-office/tags","blobs_url":"https://api.github.com/repos/pvuorela/sailfish-office/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pvuorela/sailfish-office/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pvuorela/sailfish-office/git/refs{/sha}","trees_url":"https://api.github.com/repos/pvuorela/sailfish-office/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pvuorela/sailfish-office/statuses/{sha}","languages_url":"https://api.github.com/repos/pvuorela/sailfish-office/languages","stargazers_url":"https://api.github.com/repos/pvuorela/sailfish-office/stargazers","contributors_url":"https://api.github.com/repos/pvuorela/sailfish-office/contributors","subscribers_url":"https://api.github.com/repos/pvuorela/sailfish-office/subscribers","subscription_url":"https://api.github.com/repos/pvuorela/sailfish-office/subscription","commits_url":"https://api.github.com/repos/pvuorela/sailfish-office/commits{/sha}","git_commits_url":"https://api.github.com/repos/pvuorela/sailfish-office/git/commits{/sha}","comments_url":"https://api.github.com/repos/pvuorela/sailfish-office/comments{/number}","issue_comment_url":"https://api.github.com/repos/pvuorela/sailfish-office/issues/comments{/number}","contents_url":"https://api.github.com/repos/pvuorela/sailfish-office/contents/{+path}","compare_url":"https://api.github.com/repos/pvuorela/sailfish-office/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pvuorela/sailfish-office/merges","archive_url":"https://api.github.com/repos/pvuorela/sailfish-office/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pvuorela/sailfish-office/downloads","issues_url":"https://api.github.com/repos/pvuorela/sailfish-office/issues{/number}","pulls_url":"https://api.github.com/repos/pvuorela/sailfish-office/pulls{/number}","milestones_url":"https://api.github.com/repos/pvuorela/sailfish-office/milestones{/number}","notifications_url":"https://api.github.com/repos/pvuorela/sailfish-office/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pvuorela/sailfish-office/labels{/name}","releases_url":"https://api.github.com/repos/pvuorela/sailfish-office/releases{/id}","created_at":"2014-09-05T13:32:27Z","updated_at":"2014-09-05T13:33:48Z","pushed_at":"2015-10-06T11:45:32Z","git_url":"git://github.com/pvuorela/sailfish-office.git","ssh_url":"git@github.com:pvuorela/sailfish-office.git","clone_url":"https://github.com/pvuorela/sailfish-office.git","svn_url":"https://github.com/pvuorela/sailfish-office","homepage":null,"size":531,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sailfishos:master","ref":"master","sha":"6afe4c82aa927aa25213dc90fe2d8ad225155c9a","user":{"login":"sailfishos","id":6198659,"avatar_url":"https://avatars.githubusercontent.com/u/6198659?v=3","gravatar_id":"","url":"https://api.github.com/users/sailfishos","html_url":"https://github.com/sailfishos","followers_url":"https://api.github.com/users/sailfishos/followers","following_url":"https://api.github.com/users/sailfishos/following{/other_user}","gists_url":"https://api.github.com/users/sailfishos/gists{/gist_id}","starred_url":"https://api.github.com/users/sailfishos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sailfishos/subscriptions","organizations_url":"https://api.github.com/users/sailfishos/orgs","repos_url":"https://api.github.com/users/sailfishos/repos","events_url":"https://api.github.com/users/sailfishos/events{/privacy}","received_events_url":"https://api.github.com/users/sailfishos/received_events","type":"Organization","site_admin":false},"repo":{"id":20478568,"name":"sailfish-office","full_name":"sailfishos/sailfish-office","owner":{"login":"sailfishos","id":6198659,"avatar_url":"https://avatars.githubusercontent.com/u/6198659?v=3","gravatar_id":"","url":"https://api.github.com/users/sailfishos","html_url":"https://github.com/sailfishos","followers_url":"https://api.github.com/users/sailfishos/followers","following_url":"https://api.github.com/users/sailfishos/following{/other_user}","gists_url":"https://api.github.com/users/sailfishos/gists{/gist_id}","starred_url":"https://api.github.com/users/sailfishos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sailfishos/subscriptions","organizations_url":"https://api.github.com/users/sailfishos/orgs","repos_url":"https://api.github.com/users/sailfishos/repos","events_url":"https://api.github.com/users/sailfishos/events{/privacy}","received_events_url":"https://api.github.com/users/sailfishos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sailfishos/sailfish-office","description":"Sailfish Office","fork":false,"url":"https://api.github.com/repos/sailfishos/sailfish-office","forks_url":"https://api.github.com/repos/sailfishos/sailfish-office/forks","keys_url":"https://api.github.com/repos/sailfishos/sailfish-office/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sailfishos/sailfish-office/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sailfishos/sailfish-office/teams","hooks_url":"https://api.github.com/repos/sailfishos/sailfish-office/hooks","issue_events_url":"https://api.github.com/repos/sailfishos/sailfish-office/issues/events{/number}","events_url":"https://api.github.com/repos/sailfishos/sailfish-office/events","assignees_url":"https://api.github.com/repos/sailfishos/sailfish-office/assignees{/user}","branches_url":"https://api.github.com/repos/sailfishos/sailfish-office/branches{/branch}","tags_url":"https://api.github.com/repos/sailfishos/sailfish-office/tags","blobs_url":"https://api.github.com/repos/sailfishos/sailfish-office/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sailfishos/sailfish-office/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sailfishos/sailfish-office/git/refs{/sha}","trees_url":"https://api.github.com/repos/sailfishos/sailfish-office/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sailfishos/sailfish-office/statuses/{sha}","languages_url":"https://api.github.com/repos/sailfishos/sailfish-office/languages","stargazers_url":"https://api.github.com/repos/sailfishos/sailfish-office/stargazers","contributors_url":"https://api.github.com/repos/sailfishos/sailfish-office/contributors","subscribers_url":"https://api.github.com/repos/sailfishos/sailfish-office/subscribers","subscription_url":"https://api.github.com/repos/sailfishos/sailfish-office/subscription","commits_url":"https://api.github.com/repos/sailfishos/sailfish-office/commits{/sha}","git_commits_url":"https://api.github.com/repos/sailfishos/sailfish-office/git/commits{/sha}","comments_url":"https://api.github.com/repos/sailfishos/sailfish-office/comments{/number}","issue_comment_url":"https://api.github.com/repos/sailfishos/sailfish-office/issues/comments{/number}","contents_url":"https://api.github.com/repos/sailfishos/sailfish-office/contents/{+path}","compare_url":"https://api.github.com/repos/sailfishos/sailfish-office/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sailfishos/sailfish-office/merges","archive_url":"https://api.github.com/repos/sailfishos/sailfish-office/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sailfishos/sailfish-office/downloads","issues_url":"https://api.github.com/repos/sailfishos/sailfish-office/issues{/number}","pulls_url":"https://api.github.com/repos/sailfishos/sailfish-office/pulls{/number}","milestones_url":"https://api.github.com/repos/sailfishos/sailfish-office/milestones{/number}","notifications_url":"https://api.github.com/repos/sailfishos/sailfish-office/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sailfishos/sailfish-office/labels{/name}","releases_url":"https://api.github.com/repos/sailfishos/sailfish-office/releases{/id}","created_at":"2014-06-04T10:08:14Z","updated_at":"2015-09-03T19:11:07Z","pushed_at":"2015-10-08T12:44:00Z","git_url":"git://github.com/sailfishos/sailfish-office.git","ssh_url":"git@github.com:sailfishos/sailfish-office.git","clone_url":"https://github.com/sailfishos/sailfish-office.git","svn_url":"https://github.com/sailfishos/sailfish-office","homepage":null,"size":1056,"stargazers_count":30,"watchers_count":30,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":9,"forks":17,"open_issues":9,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/46"},"html":{"href":"https://github.com/sailfishos/sailfish-office/pull/46"},"issue":{"href":"https://api.github.com/repos/sailfishos/sailfish-office/issues/46"},"comments":{"href":"https://api.github.com/repos/sailfishos/sailfish-office/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/sailfishos/sailfish-office/statuses/2edd0b84d8402b2a96a0d5c0f808504857122c81"}}}}