{"action":"created","comment":{"url":"https://api.github.com/repos/projecthydra/sufia/pulls/comments/23644053","id":23644053,"diff_hunk":"@@ -32,5 +36,12 @@ def initialize_fields(file)\n     file.initialize_fields\n   end\n \n+  def uploading_on_behalf_of? batch\n+    return false if batch.generic_files.count == 0  \n+    on_behalf_of = batch.generic_files[0].on_behalf_of\n+    return false if on_behalf_of == nil or on_behalf_of.empty?\n+    current_user.email != batch.generic_files[0].on_behalf_of","path":"app/controllers/batch_controller.rb","position":null,"original_position":21,"commit_id":"55ea35db29c5bb68feac107d7c516ddc5d438063","original_commit_id":"19df50dcfa303fea1e3305fb03bf734ba5a2d32d","user":{"login":"hectorcorrea","id":568286,"avatar_url":"https://avatars.githubusercontent.com/u/568286?v=3","gravatar_id":"","url":"https://api.github.com/users/hectorcorrea","html_url":"https://github.com/hectorcorrea","followers_url":"https://api.github.com/users/hectorcorrea/followers","following_url":"https://api.github.com/users/hectorcorrea/following{/other_user}","gists_url":"https://api.github.com/users/hectorcorrea/gists{/gist_id}","starred_url":"https://api.github.com/users/hectorcorrea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hectorcorrea/subscriptions","organizations_url":"https://api.github.com/users/hectorcorrea/orgs","repos_url":"https://api.github.com/users/hectorcorrea/repos","events_url":"https://api.github.com/users/hectorcorrea/events{/privacy}","received_events_url":"https://api.github.com/users/hectorcorrea/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2015-01-27T21:22:27Z","updated_at":"2015-01-27T21:22:27Z","html_url":"https://github.com/projecthydra/sufia/pull/879#discussion_r23644053","pull_request_url":"https://api.github.com/repos/projecthydra/sufia/pulls/879","_links":{"self":{"href":"https://api.github.com/repos/projecthydra/sufia/pulls/comments/23644053"},"html":{"href":"https://github.com/projecthydra/sufia/pull/879#discussion_r23644053"},"pull_request":{"href":"https://api.github.com/repos/projecthydra/sufia/pulls/879"}}},"pull_request":{"url":"https://api.github.com/repos/projecthydra/sufia/pulls/879","id":28138976,"html_url":"https://github.com/projecthydra/sufia/pull/879","diff_url":"https://github.com/projecthydra/sufia/pull/879.diff","patch_url":"https://github.com/projecthydra/sufia/pull/879.patch","issue_url":"https://api.github.com/repos/projecthydra/sufia/issues/879","number":879,"state":"open","locked":false,"title":"Redirects to 'my shares' when submiting files on behalf of somebody else","user":{"login":"hectorcorrea","id":568286,"avatar_url":"https://avatars.githubusercontent.com/u/568286?v=3","gravatar_id":"","url":"https://api.github.com/users/hectorcorrea","html_url":"https://github.com/hectorcorrea","followers_url":"https://api.github.com/users/hectorcorrea/followers","following_url":"https://api.github.com/users/hectorcorrea/following{/other_user}","gists_url":"https://api.github.com/users/hectorcorrea/gists{/gist_id}","starred_url":"https://api.github.com/users/hectorcorrea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hectorcorrea/subscriptions","organizations_url":"https://api.github.com/users/hectorcorrea/orgs","repos_url":"https://api.github.com/users/hectorcorrea/repos","events_url":"https://api.github.com/users/hectorcorrea/events{/privacy}","received_events_url":"https://api.github.com/users/hectorcorrea/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-01-27T19:53:40Z","updated_at":"2015-01-27T21:22:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4dfc936ef09494efb388ba3244de354171fd278","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projecthydra/sufia/pulls/879/commits","review_comments_url":"https://api.github.com/repos/projecthydra/sufia/pulls/879/comments","review_comment_url":"https://api.github.com/repos/projecthydra/sufia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/projecthydra/sufia/issues/879/comments","statuses_url":"https://api.github.com/repos/projecthydra/sufia/statuses/55ea35db29c5bb68feac107d7c516ddc5d438063","head":{"label":"projecthydra:add_on_behalf_of","ref":"add_on_behalf_of","sha":"55ea35db29c5bb68feac107d7c516ddc5d438063","user":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"repo":{"id":7653178,"name":"sufia","full_name":"projecthydra/sufia","owner":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecthydra/sufia","description":"Sufia is a Rails engine for creating a self-deposit institutional repository. A web application for ingest, curation, search, and display of digital assets. Powered by Hydra technologies (Rails, Hydra-head, Blacklight, Solr, Fedora Commons, etc.)","fork":false,"url":"https://api.github.com/repos/projecthydra/sufia","forks_url":"https://api.github.com/repos/projecthydra/sufia/forks","keys_url":"https://api.github.com/repos/projecthydra/sufia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecthydra/sufia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecthydra/sufia/teams","hooks_url":"https://api.github.com/repos/projecthydra/sufia/hooks","issue_events_url":"https://api.github.com/repos/projecthydra/sufia/issues/events{/number}","events_url":"https://api.github.com/repos/projecthydra/sufia/events","assignees_url":"https://api.github.com/repos/projecthydra/sufia/assignees{/user}","branches_url":"https://api.github.com/repos/projecthydra/sufia/branches{/branch}","tags_url":"https://api.github.com/repos/projecthydra/sufia/tags","blobs_url":"https://api.github.com/repos/projecthydra/sufia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecthydra/sufia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecthydra/sufia/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecthydra/sufia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecthydra/sufia/statuses/{sha}","languages_url":"https://api.github.com/repos/projecthydra/sufia/languages","stargazers_url":"https://api.github.com/repos/projecthydra/sufia/stargazers","contributors_url":"https://api.github.com/repos/projecthydra/sufia/contributors","subscribers_url":"https://api.github.com/repos/projecthydra/sufia/subscribers","subscription_url":"https://api.github.com/repos/projecthydra/sufia/subscription","commits_url":"https://api.github.com/repos/projecthydra/sufia/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecthydra/sufia/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecthydra/sufia/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecthydra/sufia/issues/comments/{number}","contents_url":"https://api.github.com/repos/projecthydra/sufia/contents/{+path}","compare_url":"https://api.github.com/repos/projecthydra/sufia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecthydra/sufia/merges","archive_url":"https://api.github.com/repos/projecthydra/sufia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecthydra/sufia/downloads","issues_url":"https://api.github.com/repos/projecthydra/sufia/issues{/number}","pulls_url":"https://api.github.com/repos/projecthydra/sufia/pulls{/number}","milestones_url":"https://api.github.com/repos/projecthydra/sufia/milestones{/number}","notifications_url":"https://api.github.com/repos/projecthydra/sufia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecthydra/sufia/labels{/name}","releases_url":"https://api.github.com/repos/projecthydra/sufia/releases{/id}","created_at":"2013-01-16T20:23:18Z","updated_at":"2015-01-27T19:43:18Z","pushed_at":"2015-01-27T21:21:52Z","git_url":"git://github.com/projecthydra/sufia.git","ssh_url":"git@github.com:projecthydra/sufia.git","clone_url":"https://github.com/projecthydra/sufia.git","svn_url":"https://github.com/projecthydra/sufia","homepage":"","size":58581,"stargazers_count":50,"watchers_count":50,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":47,"forks":40,"open_issues":47,"watchers":50,"default_branch":"master"}},"base":{"label":"projecthydra:master","ref":"master","sha":"77cd9dfc9bf8ecf32bf3269db360cb85c5b70662","user":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"repo":{"id":7653178,"name":"sufia","full_name":"projecthydra/sufia","owner":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecthydra/sufia","description":"Sufia is a Rails engine for creating a self-deposit institutional repository. A web application for ingest, curation, search, and display of digital assets. Powered by Hydra technologies (Rails, Hydra-head, Blacklight, Solr, Fedora Commons, etc.)","fork":false,"url":"https://api.github.com/repos/projecthydra/sufia","forks_url":"https://api.github.com/repos/projecthydra/sufia/forks","keys_url":"https://api.github.com/repos/projecthydra/sufia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecthydra/sufia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecthydra/sufia/teams","hooks_url":"https://api.github.com/repos/projecthydra/sufia/hooks","issue_events_url":"https://api.github.com/repos/projecthydra/sufia/issues/events{/number}","events_url":"https://api.github.com/repos/projecthydra/sufia/events","assignees_url":"https://api.github.com/repos/projecthydra/sufia/assignees{/user}","branches_url":"https://api.github.com/repos/projecthydra/sufia/branches{/branch}","tags_url":"https://api.github.com/repos/projecthydra/sufia/tags","blobs_url":"https://api.github.com/repos/projecthydra/sufia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecthydra/sufia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecthydra/sufia/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecthydra/sufia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecthydra/sufia/statuses/{sha}","languages_url":"https://api.github.com/repos/projecthydra/sufia/languages","stargazers_url":"https://api.github.com/repos/projecthydra/sufia/stargazers","contributors_url":"https://api.github.com/repos/projecthydra/sufia/contributors","subscribers_url":"https://api.github.com/repos/projecthydra/sufia/subscribers","subscription_url":"https://api.github.com/repos/projecthydra/sufia/subscription","commits_url":"https://api.github.com/repos/projecthydra/sufia/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecthydra/sufia/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecthydra/sufia/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecthydra/sufia/issues/comments/{number}","contents_url":"https://api.github.com/repos/projecthydra/sufia/contents/{+path}","compare_url":"https://api.github.com/repos/projecthydra/sufia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecthydra/sufia/merges","archive_url":"https://api.github.com/repos/projecthydra/sufia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecthydra/sufia/downloads","issues_url":"https://api.github.com/repos/projecthydra/sufia/issues{/number}","pulls_url":"https://api.github.com/repos/projecthydra/sufia/pulls{/number}","milestones_url":"https://api.github.com/repos/projecthydra/sufia/milestones{/number}","notifications_url":"https://api.github.com/repos/projecthydra/sufia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecthydra/sufia/labels{/name}","releases_url":"https://api.github.com/repos/projecthydra/sufia/releases{/id}","created_at":"2013-01-16T20:23:18Z","updated_at":"2015-01-27T19:43:18Z","pushed_at":"2015-01-27T21:21:52Z","git_url":"git://github.com/projecthydra/sufia.git","ssh_url":"git@github.com:projecthydra/sufia.git","clone_url":"https://github.com/projecthydra/sufia.git","svn_url":"https://github.com/projecthydra/sufia","homepage":"","size":58581,"stargazers_count":50,"watchers_count":50,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":47,"forks":40,"open_issues":47,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projecthydra/sufia/pulls/879"},"html":{"href":"https://github.com/projecthydra/sufia/pull/879"},"issue":{"href":"https://api.github.com/repos/projecthydra/sufia/issues/879"},"comments":{"href":"https://api.github.com/repos/projecthydra/sufia/issues/879/comments"},"review_comments":{"href":"https://api.github.com/repos/projecthydra/sufia/pulls/879/comments"},"review_comment":{"href":"https://api.github.com/repos/projecthydra/sufia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/projecthydra/sufia/pulls/879/commits"},"statuses":{"href":"https://api.github.com/repos/projecthydra/sufia/statuses/55ea35db29c5bb68feac107d7c516ddc5d438063"}}}}