{"push_id":696542315,"size":2,"distinct_size":1,"ref":"refs/heads/issue/pup-2315/argument-mismatch-errors","head":"5aea18783d21bb2af9765a2a2a9d46d5b6fce215","before":"95d39cfc68268382e913fdf5908e0dbbd9887ec0","commits":[{"sha":"eda388313fc43c67bccbd46dcef2324037f9c205","author":{"email":"5f50a84c1fa3bcff146405017f36aec1a10a9e38@tada.se","name":"Thomas Hallgren"},"message":"DO NOT MERGE: (PUP-4458) Refactor validation of parameter signatures\n\nThis commit unifies how parameters are validated so that instantiations\nof nodes, classes, and definitions use a validatio logic that has more\nin common with the validation of lambda invocations and function calls.\n\nThe commit is based on top of PUP-4702 (not yet merged).","distinct":false,"url":"https://api.github.com/repos/thallgren/puppet/commits/eda388313fc43c67bccbd46dcef2324037f9c205"},{"sha":"5aea18783d21bb2af9765a2a2a9d46d5b6fce215","author":{"email":"5f50a84c1fa3bcff146405017f36aec1a10a9e38@tada.se","name":"Thomas Hallgren"},"message":"DO NOT MERGE: (PUP-2315) - Type validation error messages\n\nThis commit introduces a number of improvements to error messages\nissued when validating call signatures. Improvements include:\n\n- Unification\n  Instantiations of nodes, classes, resources, and user defined types\n  share the same validation logic as calls to lambdas, functions, and\n  methods.\n- Issue message by priority\n  Report only one issue and not all issues that might or might not be\n  a consequence of the reported issue. Examples include:\n  - Argument count mismatch\n  - Required but missing block\n  - Unexpected block\n- Suppress repeated messages\n- Shorten type descriptions when possible\n  When type names differ, leave out the type details. Does not apply\n  when String is validated using Pattern or Enum\n- Shorten Variant output to text like \"one of T1, T2, or T3\"\n- Appoint details using paths into complex types instead of reporting\n  large blobs of very similar texts\n\nThis commit builds on work in PUP-4458 (not yet merged)","distinct":true,"url":"https://api.github.com/repos/thallgren/puppet/commits/5aea18783d21bb2af9765a2a2a9d46d5b6fce215"}]}