{"action":"created","issue":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/582","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/582/labels{/name}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/582/comments","events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/582/events","html_url":"https://github.com/mixxxdj/mixxx/pull/582","id":75123056,"number":582,"title":"Facelift FFmpeg code quality","user":{"login":"illuusio","id":1902756,"avatar_url":"https://avatars.githubusercontent.com/u/1902756?v=3","gravatar_id":"","url":"https://api.github.com/users/illuusio","html_url":"https://github.com/illuusio","followers_url":"https://api.github.com/users/illuusio/followers","following_url":"https://api.github.com/users/illuusio/following{/other_user}","gists_url":"https://api.github.com/users/illuusio/gists{/gist_id}","starred_url":"https://api.github.com/users/illuusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illuusio/subscriptions","organizations_url":"https://api.github.com/users/illuusio/orgs","repos_url":"https://api.github.com/users/illuusio/repos","events_url":"https://api.github.com/users/illuusio/events{/privacy}","received_events_url":"https://api.github.com/users/illuusio/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-05-11T07:39:09Z","updated_at":"2015-06-29T13:40:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/582","html_url":"https://github.com/mixxxdj/mixxx/pull/582","diff_url":"https://github.com/mixxxdj/mixxx/pull/582.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/582.patch"},"body":"There have been several function deprecations since FFmpeg version 1.1. Those generate warning so remove them with #ifdef-them out.\r\nXiph family (Vorbis, Opus, FLAC and probably others) seeking backward wasn't working as expected so fix that on working towards not crashing test suite.\r\nThis is for head (1.13) but those OGG seeking things should be also applied in version 1.12."},"comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments/116663227","html_url":"https://github.com/mixxxdj/mixxx/pull/582#issuecomment-116663227","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/582","id":116663227,"user":{"login":"daschuer","id":1777442,"avatar_url":"https://avatars.githubusercontent.com/u/1777442?v=3","gravatar_id":"","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"created_at":"2015-06-29T13:40:27Z","updated_at":"2015-06-29T13:40:27Z","body":"Is there something special for compiling with Ubuntu Trusty? \r\nHere is the tail of my console output \r\n\r\n```\r\nsrc/encoder/encoderffmpegresample.cpp: In destructor ‘EncoderFfmpegResample::~EncoderFfmpegResample()’:\r\nsrc/encoder/encoderffmpegresample.cpp:37:9: warning: ‘void audio_resample_close(ReSampleContext*)’ is deprecated (declared at /usr/include/libavcodec/avcodec.h:4126) [-Wdeprecated-declarations]\r\n         audio_resample_close(m_pSwrCtx);\r\n         ^\r\nsrc/encoder/encoderffmpegresample.cpp:37:39: warning: ‘void audio_resample_close(ReSampleContext*)’ is deprecated (declared at /usr/include/libavcodec/avcodec.h:4126) [-Wdeprecated-declarations]\r\n         audio_resample_close(m_pSwrCtx);\r\n                                       ^\r\nsrc/encoder/encoderffmpegresample.cpp: In member function ‘int EncoderFfmpegResample::open(AVSampleFormat, AVSampleFormat)’:\r\nsrc/encoder/encoderffmpegresample.cpp:50:39: error: ‘AV_CH_LAYOUT_STEREO’ was not declared in this scope\r\n         m_pCodecCtx->channel_layout = AV_CH_LAYOUT_STEREO;\r\n                                       ^\r\nsrc/encoder/encoderffmpegresample.cpp:52:39: error: ‘AV_CH_LAYOUT_MONO’ was not declared in this scope\r\n         m_pCodecCtx->channel_layout = AV_CH_LAYOUT_MONO;\r\n                                       ^\r\nsrc/encoder/encoderffmpegresample.cpp:54:39: error: ‘AV_CH_LAYOUT_STEREO’ was not declared in this scope\r\n         m_pCodecCtx->channel_layout = AV_CH_LAYOUT_STEREO;\r\n                                       ^\r\nsrc/encoder/encoderffmpegresample.cpp:68:44: error: ‘AV_CH_LAYOUT_STEREO’ was not declared in this scope\r\n             m_pCodecCtx->channel_layout != AV_CH_LAYOUT_STEREO) && m_pSwrCtx == NULL) {\r\n                                            ^\r\nsrc/encoder/encoderffmpegresample.cpp:83:13: warning: ‘void audio_resample_close(ReSampleContext*)’ is deprecated (declared at /usr/include/libavcodec/avcodec.h:4126) [-Wdeprecated-declarations]\r\n             audio_resample_close(m_pSwrCtx);\r\n             ^\r\nsrc/encoder/encoderffmpegresample.cpp:83:43: warning: ‘void audio_resample_close(ReSampleContext*)’ is deprecated (declared at /usr/include/libavcodec/avcodec.h:4126) [-Wdeprecated-declarations]\r\n             audio_resample_close(m_pSwrCtx);\r\n                                           ^\r\nsrc/encoder/encoderffmpegresample.cpp:109:21: warning: ‘ReSampleContext* av_audio_resample_init(int, int, int, int, AVSampleFormat, AVSampleFormat, int, int, int, double)’ is deprecated (declared at /usr/include/libavcodec/avcodec.h:4109) [-Wdeprecated-declarations]\r\n         m_pSwrCtx = av_audio_resample_init(m_pCodecCtx->channels,\r\n                     ^\r\nsrc/encoder/encoderffmpegresample.cpp:118:47: warning: ‘ReSampleContext* av_audio_resample_init(int, int, int, int, AVSampleFormat, AVSampleFormat, int, int, int, double)’ is deprecated (declared at /usr/include/libavcodec/avcodec.h:4109) [-Wdeprecated-declarations]\r\n                                            0.8);\r\n                                               ^\r\nsrc/encoder/encoderffmpegresample.cpp: In member function ‘unsigned int EncoderFfmpegResample::reSample(AVFrame*, quint8**)’:\r\nsrc/encoder/encoderffmpegresample.cpp:228:19: error: cannot convert ‘short int*’ to ‘quint8** {aka unsigned char**}’ in assignment\r\n         outbuffer = (short *)malloc(l_iOutBytes * 2);\r\n                   ^\r\nsrc/encoder/encoderffmpegresample.cpp:257:18: warning: ‘int audio_resample(ReSampleContext*, short int*, short int*, int)’ is deprecated (declared at /usr/include/libavcodec/avcodec.h:4117) [-Wdeprecated-declarations]\r\n         l_iLen = audio_resample(m_pSwrCtx,\r\n                  ^\r\nsrc/encoder/encoderffmpegresample.cpp:259:52: warning: ‘int audio_resample(ReSampleContext*, short int*, short int*, int)’ is deprecated (declared at /usr/include/libavcodec/avcodec.h:4117) [-Wdeprecated-declarations]\r\n                                 inframe->nb_samples);\r\n                                                    ^\r\nsrc/encoder/encoderffmpegresample.cpp:190:16: warning: unused variable ‘l_lInReadBytes’ [-Wunused-variable]\r\n         qint64 l_lInReadBytes = av_samples_get_buffer_size(NULL, m_pCodecCtx->channels,\r\n                ^\r\nscons: *** [lin64_build/encoder/encoderffmpegresample.o] Error 1\r\nscons: building terminated because of errors.\r\n```"}}