{"action":"created","comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/43001247","id":43001247,"diff_hunk":"@@ -1491,6 +1491,17 @@ def verify_test_dependencies():\n     if not os.path.isdir(os.path.join(os.path.dirname(__file__), 'tests')):\n         raise ImportError(\"matplotlib test data is not installed\")\n \n+    # The version of freetype to install locally for running the\n+    # tests.  This must match the value in `setupext.py`\n+    LOCAL_FREETYPE_VERSION = '2.5.2'\n+\n+    from matplotlib import ft2font\n+    if (ft2font.__freetype_version__ != LOCAL_FREETYPE_VERSION or\n+        ft2font.__freetype_build_type__ != 'local'):\n+        raise ImportError(","path":"lib/matplotlib/__init__.py","position":11,"original_position":11,"commit_id":"532a06e03bb58e085cb7ebc6c0f6aa8d38b83266","original_commit_id":"532a06e03bb58e085cb7ebc6c0f6aa8d38b83266","user":{"login":"mdboom","id":38294,"avatar_url":"https://avatars.githubusercontent.com/u/38294?v=3","gravatar_id":"","url":"https://api.github.com/users/mdboom","html_url":"https://github.com/mdboom","followers_url":"https://api.github.com/users/mdboom/followers","following_url":"https://api.github.com/users/mdboom/following{/other_user}","gists_url":"https://api.github.com/users/mdboom/gists{/gist_id}","starred_url":"https://api.github.com/users/mdboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdboom/subscriptions","organizations_url":"https://api.github.com/users/mdboom/orgs","repos_url":"https://api.github.com/users/mdboom/repos","events_url":"https://api.github.com/users/mdboom/events{/privacy}","received_events_url":"https://api.github.com/users/mdboom/received_events","type":"User","site_admin":false},"body":"@QuLogic: You don't need a specific version of freetype installed.  You need to build matplotlib with the special \"local_freetype\" option, which will download and build against a particular version of freetype for you.\r\n\r\n@jkseppan: Maybe a warning is the right thing to do -- but knownfail doesn't always communicate \"the test run you just ran should give you very little confidence that anything is working\" which is really the situation we would have here.  What about a warning + real failures?","created_at":"2015-10-26T14:41:20Z","updated_at":"2015-10-26T14:41:20Z","html_url":"https://github.com/matplotlib/matplotlib/pull/5306#discussion_r43001247","pull_request_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5306","_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/43001247"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/5306#discussion_r43001247"},"pull_request":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5306"}}},"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5306","id":48601249,"html_url":"https://github.com/matplotlib/matplotlib/pull/5306","diff_url":"https://github.com/matplotlib/matplotlib/pull/5306.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/5306.patch","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/5306","number":5306,"state":"open","locked":false,"title":"Use a specific version of Freetype for testing","user":{"login":"mdboom","id":38294,"avatar_url":"https://avatars.githubusercontent.com/u/38294?v=3","gravatar_id":"","url":"https://api.github.com/users/mdboom","html_url":"https://github.com/mdboom","followers_url":"https://api.github.com/users/mdboom/followers","following_url":"https://api.github.com/users/mdboom/following{/other_user}","gists_url":"https://api.github.com/users/mdboom/gists{/gist_id}","starred_url":"https://api.github.com/users/mdboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdboom/subscriptions","organizations_url":"https://api.github.com/users/mdboom/orgs","repos_url":"https://api.github.com/users/mdboom/repos","events_url":"https://api.github.com/users/mdboom/events{/privacy}","received_events_url":"https://api.github.com/users/mdboom/received_events","type":"User","site_admin":false},"body":"This should theoretically allow us to turn down the tolerance on image comparison tests.\r\n\r\nIf all is going well, this should pass Travis-CI, which is now using a locally-built freetype.","created_at":"2015-10-23T16:31:21Z","updated_at":"2015-10-26T14:41:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8186f9bd097c69365564f886f34f75a5cce54acb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5306/commits","review_comments_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5306/comments","review_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/5306/comments","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/532a06e03bb58e085cb7ebc6c0f6aa8d38b83266","head":{"label":"mdboom:local-freetype","ref":"local-freetype","sha":"532a06e03bb58e085cb7ebc6c0f6aa8d38b83266","user":{"login":"mdboom","id":38294,"avatar_url":"https://avatars.githubusercontent.com/u/38294?v=3","gravatar_id":"","url":"https://api.github.com/users/mdboom","html_url":"https://github.com/mdboom","followers_url":"https://api.github.com/users/mdboom/followers","following_url":"https://api.github.com/users/mdboom/following{/other_user}","gists_url":"https://api.github.com/users/mdboom/gists{/gist_id}","starred_url":"https://api.github.com/users/mdboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdboom/subscriptions","organizations_url":"https://api.github.com/users/mdboom/orgs","repos_url":"https://api.github.com/users/mdboom/repos","events_url":"https://api.github.com/users/mdboom/events{/privacy}","received_events_url":"https://api.github.com/users/mdboom/received_events","type":"User","site_admin":false},"repo":{"id":1389427,"name":"matplotlib","full_name":"mdboom/matplotlib","owner":{"login":"mdboom","id":38294,"avatar_url":"https://avatars.githubusercontent.com/u/38294?v=3","gravatar_id":"","url":"https://api.github.com/users/mdboom","html_url":"https://github.com/mdboom","followers_url":"https://api.github.com/users/mdboom/followers","following_url":"https://api.github.com/users/mdboom/following{/other_user}","gists_url":"https://api.github.com/users/mdboom/gists{/gist_id}","starred_url":"https://api.github.com/users/mdboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdboom/subscriptions","organizations_url":"https://api.github.com/users/mdboom/orgs","repos_url":"https://api.github.com/users/mdboom/repos","events_url":"https://api.github.com/users/mdboom/events{/privacy}","received_events_url":"https://api.github.com/users/mdboom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdboom/matplotlib","description":"","fork":true,"url":"https://api.github.com/repos/mdboom/matplotlib","forks_url":"https://api.github.com/repos/mdboom/matplotlib/forks","keys_url":"https://api.github.com/repos/mdboom/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdboom/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdboom/matplotlib/teams","hooks_url":"https://api.github.com/repos/mdboom/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/mdboom/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/mdboom/matplotlib/events","assignees_url":"https://api.github.com/repos/mdboom/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/mdboom/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/mdboom/matplotlib/tags","blobs_url":"https://api.github.com/repos/mdboom/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdboom/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdboom/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdboom/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdboom/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/mdboom/matplotlib/languages","stargazers_url":"https://api.github.com/repos/mdboom/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/mdboom/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/mdboom/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/mdboom/matplotlib/subscription","commits_url":"https://api.github.com/repos/mdboom/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdboom/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdboom/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdboom/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdboom/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/mdboom/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdboom/matplotlib/merges","archive_url":"https://api.github.com/repos/mdboom/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdboom/matplotlib/downloads","issues_url":"https://api.github.com/repos/mdboom/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/mdboom/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/mdboom/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/mdboom/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdboom/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/mdboom/matplotlib/releases{/id}","created_at":"2011-02-20T15:17:10Z","updated_at":"2015-03-03T18:29:21Z","pushed_at":"2015-10-24T13:07:44Z","git_url":"git://github.com/mdboom/matplotlib.git","ssh_url":"git@github.com:mdboom/matplotlib.git","clone_url":"https://github.com/mdboom/matplotlib.git","svn_url":"https://github.com/mdboom/matplotlib","homepage":"","size":252151,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":6,"default_branch":"master"}},"base":{"label":"matplotlib:master","ref":"master","sha":"8000e2f9580a31f9d78ab2eb4dcfadb08482af91","user":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?v=3","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"repo":{"id":1385122,"name":"matplotlib","full_name":"matplotlib/matplotlib","owner":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?v=3","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matplotlib/matplotlib","description":"matplotlib: plotting with Python","fork":false,"url":"https://api.github.com/repos/matplotlib/matplotlib","forks_url":"https://api.github.com/repos/matplotlib/matplotlib/forks","keys_url":"https://api.github.com/repos/matplotlib/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matplotlib/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matplotlib/matplotlib/teams","hooks_url":"https://api.github.com/repos/matplotlib/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matplotlib/matplotlib/events","assignees_url":"https://api.github.com/repos/matplotlib/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matplotlib/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matplotlib/matplotlib/tags","blobs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matplotlib/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matplotlib/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matplotlib/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matplotlib/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matplotlib/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matplotlib/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matplotlib/matplotlib/subscription","commits_url":"https://api.github.com/repos/matplotlib/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matplotlib/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/matplotlib/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matplotlib/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matplotlib/matplotlib/merges","archive_url":"https://api.github.com/repos/matplotlib/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matplotlib/matplotlib/downloads","issues_url":"https://api.github.com/repos/matplotlib/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matplotlib/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matplotlib/matplotlib/releases{/id}","created_at":"2011-02-19T03:17:12Z","updated_at":"2015-10-26T13:40:10Z","pushed_at":"2015-10-26T13:22:48Z","git_url":"git://github.com/matplotlib/matplotlib.git","ssh_url":"git@github.com:matplotlib/matplotlib.git","clone_url":"https://github.com/matplotlib/matplotlib.git","svn_url":"https://github.com/matplotlib/matplotlib","homepage":"http://matplotlib.org/","size":313242,"stargazers_count":2946,"watchers_count":2946,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1494,"mirror_url":null,"open_issues_count":695,"forks":1494,"open_issues":695,"watchers":2946,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5306"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/5306"},"issue":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/5306"},"comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/5306/comments"},"review_comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5306/comments"},"review_comment":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5306/commits"},"statuses":{"href":"https://api.github.com/repos/matplotlib/matplotlib/statuses/532a06e03bb58e085cb7ebc6c0f6aa8d38b83266"}}}}