{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/35399489","id":35399489,"diff_hunk":"@@ -96,6 +96,53 @@ case class Ands(predicates: List[Predicate]) extends Predicate {\n   override def atoms: Seq[Predicate] = predicates\n }\n \n+case class AndedPropertyComparablePredicates(ident: Identifier, prop: Property, comparables: NonEmptyList[ComparablePredicate]) extends Predicate {\n+\n+  def symbolTableDependencies: Set[String] = comparables.foldLeft(prop.symbolTableDependencies) {\n+    case (acc, predicate) => acc ++ predicate.symbolTableDependencies\n+  }\n+\n+  def containsIsNull: Boolean = comparables.exists(_.containsIsNull)\n+\n+  def isMatch(m: ExecutionContext)(implicit state: QueryState): Option[Boolean] = {","path":"community/cypher/cypher-compiler-2.3/src/main/scala/org/neo4j/cypher/internal/compiler/v2_3/commands/Predicate.scala","position":25,"original_position":25,"commit_id":"0d11c24cf582154cc4389e66c924db2f0184face","original_commit_id":"0d11c24cf582154cc4389e66c924db2f0184face","user":{"login":"Mats-SX","id":2419675,"avatar_url":"https://avatars.githubusercontent.com/u/2419675?v=3","gravatar_id":"","url":"https://api.github.com/users/Mats-SX","html_url":"https://github.com/Mats-SX","followers_url":"https://api.github.com/users/Mats-SX/followers","following_url":"https://api.github.com/users/Mats-SX/following{/other_user}","gists_url":"https://api.github.com/users/Mats-SX/gists{/gist_id}","starred_url":"https://api.github.com/users/Mats-SX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mats-SX/subscriptions","organizations_url":"https://api.github.com/users/Mats-SX/orgs","repos_url":"https://api.github.com/users/Mats-SX/repos","events_url":"https://api.github.com/users/Mats-SX/events{/privacy}","received_events_url":"https://api.github.com/users/Mats-SX/received_events","type":"User","site_admin":false},"body":"This code was simply copied from above, lines 70-90. I would like to not touch it.\r\n\r\nOne idea would be to let this class `AndedPropertyComparablePredicates` extend `Ands` instead of being a sibling-copy, but there's a disadvantage to that in that instances may then match on pattern-matches using `Ands`, and we do not want that. However, I am unsure on how plausible this disadvantage is, ie how often such a match would actually occur.","created_at":"2015-07-24T06:55:55Z","updated_at":"2015-07-24T06:55:55Z","html_url":"https://github.com/neo4j/neo4j/pull/5012#discussion_r35399489","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/5012","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/35399489"},"html":{"href":"https://github.com/neo4j/neo4j/pull/5012#discussion_r35399489"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/5012"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/5012","id":40459736,"html_url":"https://github.com/neo4j/neo4j/pull/5012","diff_url":"https://github.com/neo4j/neo4j/pull/5012.diff","patch_url":"https://github.com/neo4j/neo4j/pull/5012.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/5012","number":5012,"state":"open","locked":false,"title":"Range queries for rule planner","user":{"login":"Mats-SX","id":2419675,"avatar_url":"https://avatars.githubusercontent.com/u/2419675?v=3","gravatar_id":"","url":"https://api.github.com/users/Mats-SX","html_url":"https://github.com/Mats-SX","followers_url":"https://api.github.com/users/Mats-SX/followers","following_url":"https://api.github.com/users/Mats-SX/following{/other_user}","gists_url":"https://api.github.com/users/Mats-SX/gists{/gist_id}","starred_url":"https://api.github.com/users/Mats-SX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mats-SX/subscriptions","organizations_url":"https://api.github.com/users/Mats-SX/orgs","repos_url":"https://api.github.com/users/Mats-SX/repos","events_url":"https://api.github.com/users/Mats-SX/events{/privacy}","received_events_url":"https://api.github.com/users/Mats-SX/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-21T13:57:37Z","updated_at":"2015-07-24T06:55:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07b215c1eaacdf4db7704044c9cb5e7baccdc606","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/5012/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/5012/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/5012/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/0d11c24cf582154cc4389e66c924db2f0184face","head":{"label":"Mats-SX:2.3-legacy-range-queries","ref":"2.3-legacy-range-queries","sha":"0d11c24cf582154cc4389e66c924db2f0184face","user":{"login":"Mats-SX","id":2419675,"avatar_url":"https://avatars.githubusercontent.com/u/2419675?v=3","gravatar_id":"","url":"https://api.github.com/users/Mats-SX","html_url":"https://github.com/Mats-SX","followers_url":"https://api.github.com/users/Mats-SX/followers","following_url":"https://api.github.com/users/Mats-SX/following{/other_user}","gists_url":"https://api.github.com/users/Mats-SX/gists{/gist_id}","starred_url":"https://api.github.com/users/Mats-SX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mats-SX/subscriptions","organizations_url":"https://api.github.com/users/Mats-SX/orgs","repos_url":"https://api.github.com/users/Mats-SX/repos","events_url":"https://api.github.com/users/Mats-SX/events{/privacy}","received_events_url":"https://api.github.com/users/Mats-SX/received_events","type":"User","site_admin":false},"repo":{"id":32784893,"name":"neo4j","full_name":"Mats-SX/neo4j","owner":{"login":"Mats-SX","id":2419675,"avatar_url":"https://avatars.githubusercontent.com/u/2419675?v=3","gravatar_id":"","url":"https://api.github.com/users/Mats-SX","html_url":"https://github.com/Mats-SX","followers_url":"https://api.github.com/users/Mats-SX/followers","following_url":"https://api.github.com/users/Mats-SX/following{/other_user}","gists_url":"https://api.github.com/users/Mats-SX/gists{/gist_id}","starred_url":"https://api.github.com/users/Mats-SX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mats-SX/subscriptions","organizations_url":"https://api.github.com/users/Mats-SX/orgs","repos_url":"https://api.github.com/users/Mats-SX/repos","events_url":"https://api.github.com/users/Mats-SX/events{/privacy}","received_events_url":"https://api.github.com/users/Mats-SX/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mats-SX/neo4j","description":"Graphs for Everyone","fork":true,"url":"https://api.github.com/repos/Mats-SX/neo4j","forks_url":"https://api.github.com/repos/Mats-SX/neo4j/forks","keys_url":"https://api.github.com/repos/Mats-SX/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mats-SX/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mats-SX/neo4j/teams","hooks_url":"https://api.github.com/repos/Mats-SX/neo4j/hooks","issue_events_url":"https://api.github.com/repos/Mats-SX/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/Mats-SX/neo4j/events","assignees_url":"https://api.github.com/repos/Mats-SX/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/Mats-SX/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/Mats-SX/neo4j/tags","blobs_url":"https://api.github.com/repos/Mats-SX/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mats-SX/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mats-SX/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mats-SX/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mats-SX/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/Mats-SX/neo4j/languages","stargazers_url":"https://api.github.com/repos/Mats-SX/neo4j/stargazers","contributors_url":"https://api.github.com/repos/Mats-SX/neo4j/contributors","subscribers_url":"https://api.github.com/repos/Mats-SX/neo4j/subscribers","subscription_url":"https://api.github.com/repos/Mats-SX/neo4j/subscription","commits_url":"https://api.github.com/repos/Mats-SX/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mats-SX/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mats-SX/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mats-SX/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mats-SX/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/Mats-SX/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mats-SX/neo4j/merges","archive_url":"https://api.github.com/repos/Mats-SX/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mats-SX/neo4j/downloads","issues_url":"https://api.github.com/repos/Mats-SX/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/Mats-SX/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/Mats-SX/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/Mats-SX/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mats-SX/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/Mats-SX/neo4j/releases{/id}","created_at":"2015-03-24T08:02:04Z","updated_at":"2015-03-24T08:02:47Z","pushed_at":"2015-07-23T09:01:09Z","git_url":"git://github.com/Mats-SX/neo4j.git","ssh_url":"git@github.com:Mats-SX/neo4j.git","clone_url":"https://github.com/Mats-SX/neo4j.git","svn_url":"https://github.com/Mats-SX/neo4j","homepage":"http://neo4j.com","size":202973,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.3"}},"base":{"label":"neo4j:2.3","ref":"2.3","sha":"18da34ae935315274b2e34e11b47e4f46d4d2fd9","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","created_at":"2012-11-12T08:46:15Z","updated_at":"2015-07-24T04:25:53Z","pushed_at":"2015-07-24T05:51:09Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":478628,"stargazers_count":1842,"watchers_count":1842,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":718,"mirror_url":null,"open_issues_count":470,"forks":718,"open_issues":470,"watchers":1842,"default_branch":"2.3"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/5012"},"html":{"href":"https://github.com/neo4j/neo4j/pull/5012"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/5012"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/5012/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/5012/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/5012/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/0d11c24cf582154cc4389e66c924db2f0184face"}}}}