{"action":"created","issue":{"url":"https://api.github.com/repos/strongloop/loopback/issues/1301","labels_url":"https://api.github.com/repos/strongloop/loopback/issues/1301/labels{/name}","comments_url":"https://api.github.com/repos/strongloop/loopback/issues/1301/comments","events_url":"https://api.github.com/repos/strongloop/loopback/issues/1301/events","html_url":"https://github.com/strongloop/loopback/pull/1301","id":68504340,"number":1301,"title":"Set disableInclude for User->AccessToken relation","user":{"login":"raymondfeng","id":540892,"avatar_url":"https://avatars.githubusercontent.com/u/540892?v=3","gravatar_id":"","url":"https://api.github.com/users/raymondfeng","html_url":"https://github.com/raymondfeng","followers_url":"https://api.github.com/users/raymondfeng/followers","following_url":"https://api.github.com/users/raymondfeng/following{/other_user}","gists_url":"https://api.github.com/users/raymondfeng/gists{/gist_id}","starred_url":"https://api.github.com/users/raymondfeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raymondfeng/subscriptions","organizations_url":"https://api.github.com/users/raymondfeng/orgs","repos_url":"https://api.github.com/users/raymondfeng/repos","events_url":"https://api.github.com/users/raymondfeng/events{/privacy}","received_events_url":"https://api.github.com/users/raymondfeng/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/strongloop/loopback/labels/%23review","name":"#review","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"raymondfeng","id":540892,"avatar_url":"https://avatars.githubusercontent.com/u/540892?v=3","gravatar_id":"","url":"https://api.github.com/users/raymondfeng","html_url":"https://github.com/raymondfeng","followers_url":"https://api.github.com/users/raymondfeng/followers","following_url":"https://api.github.com/users/raymondfeng/following{/other_user}","gists_url":"https://api.github.com/users/raymondfeng/gists{/gist_id}","starred_url":"https://api.github.com/users/raymondfeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raymondfeng/subscriptions","organizations_url":"https://api.github.com/users/raymondfeng/orgs","repos_url":"https://api.github.com/users/raymondfeng/repos","events_url":"https://api.github.com/users/raymondfeng/events{/privacy}","received_events_url":"https://api.github.com/users/raymondfeng/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2015-04-14T21:37:30Z","updated_at":"2015-04-20T16:02:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/strongloop/loopback/pulls/1301","html_url":"https://github.com/strongloop/loopback/pull/1301","diff_url":"https://github.com/strongloop/loopback/pull/1301.diff","patch_url":"https://github.com/strongloop/loopback/pull/1301.patch"},"body":"/to @bajtos \r\n/cc @ritch \r\n\r\nSee https://github.com/strongloop/loopback/issues/386"},"comment":{"url":"https://api.github.com/repos/strongloop/loopback/issues/comments/94493712","html_url":"https://github.com/strongloop/loopback/pull/1301#issuecomment-94493712","issue_url":"https://api.github.com/repos/strongloop/loopback/issues/1301","id":94493712,"user":{"login":"bajtos","id":1140553,"avatar_url":"https://avatars.githubusercontent.com/u/1140553?v=3","gravatar_id":"","url":"https://api.github.com/users/bajtos","html_url":"https://github.com/bajtos","followers_url":"https://api.github.com/users/bajtos/followers","following_url":"https://api.github.com/users/bajtos/following{/other_user}","gists_url":"https://api.github.com/users/bajtos/gists{/gist_id}","starred_url":"https://api.github.com/users/bajtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajtos/subscriptions","organizations_url":"https://api.github.com/users/bajtos/orgs","repos_url":"https://api.github.com/users/bajtos/repos","events_url":"https://api.github.com/users/bajtos/events{/privacy}","received_events_url":"https://api.github.com/users/bajtos/received_events","type":"User","site_admin":false},"created_at":"2015-04-20T16:02:15Z","updated_at":"2015-04-20T16:02:15Z","body":"> The project already has dependency on loopback-boot before the PR. I simply upgrade the fixtures to 2.x layout.\r\n\r\n> Migrating from 1.x to 2.x is not a main concern any more. I think it's better to use 2.x layout as developers sometimes try to follow what we do. If you feel strongly about removing the test fixtures, we can discuss that as a separate issue.\r\n\r\n> With 1.x layout, there is no way to use the base class such as User for REST. The test is meant to cover our main stream - LB 2.x.\r\n\r\nI dig up the commit that added the dependency on loopback-boot - see c896c78d. It seems the change was made purely in order to support test fixtures booting the app via `loopback.boot()`, in which case I agree with you that it's ok to upgrade loopback-boot to 2.x.\r\n\r\nHowever, I still believe that we should keep the number of fixtures as small as possible, create loopback apps inside the tests purely code-wise and keep these apps as small as possibly."}}