{"action":"closed","number":5226,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5226","id":49442342,"html_url":"https://github.com/ManageIQ/manageiq/pull/5226","diff_url":"https://github.com/ManageIQ/manageiq/pull/5226.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/5226.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5226","number":5226,"state":"closed","locked":false,"title":"Remove miq_ae_dialog_spec.rb","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"body":"We don't actually build dialogs this way, instead using the dialogs\r\nstored as yaml files in the miq_dialogs table.  This test was only\r\nserving as a legacy performance test, so it's not needed.  This saves 15\r\nseconds, and also removes the most database intensive test (11664 SQL\r\nstatements)\r\n\r\n@gmcculloug Please review\r\ncc @jrafanie  :scissors: ","created_at":"2015-11-02T15:10:49Z","updated_at":"2015-11-02T17:03:15Z","closed_at":"2015-11-02T17:03:15Z","merged_at":"2015-11-02T17:03:15Z","merge_commit_sha":"ac73b2628e5bee9f41bf550638afa0fe2a94c39a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5226/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5226/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5226/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/f5a9185d608620930d775e834ac5f26bd58f45ed","head":{"label":"Fryguy:remove_miq_ae_dialog_spec","ref":"remove_miq_ae_dialog_spec","sha":"f5a9185d608620930d775e834ac5f26bd58f45ed","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"repo":{"id":20789885,"name":"manageiq","full_name":"Fryguy/manageiq","owner":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fryguy/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/Fryguy/manageiq","forks_url":"https://api.github.com/repos/Fryguy/manageiq/forks","keys_url":"https://api.github.com/repos/Fryguy/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fryguy/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fryguy/manageiq/teams","hooks_url":"https://api.github.com/repos/Fryguy/manageiq/hooks","issue_events_url":"https://api.github.com/repos/Fryguy/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/Fryguy/manageiq/events","assignees_url":"https://api.github.com/repos/Fryguy/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/Fryguy/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/Fryguy/manageiq/tags","blobs_url":"https://api.github.com/repos/Fryguy/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fryguy/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fryguy/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fryguy/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fryguy/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/Fryguy/manageiq/languages","stargazers_url":"https://api.github.com/repos/Fryguy/manageiq/stargazers","contributors_url":"https://api.github.com/repos/Fryguy/manageiq/contributors","subscribers_url":"https://api.github.com/repos/Fryguy/manageiq/subscribers","subscription_url":"https://api.github.com/repos/Fryguy/manageiq/subscription","commits_url":"https://api.github.com/repos/Fryguy/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fryguy/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fryguy/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fryguy/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fryguy/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/Fryguy/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fryguy/manageiq/merges","archive_url":"https://api.github.com/repos/Fryguy/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fryguy/manageiq/downloads","issues_url":"https://api.github.com/repos/Fryguy/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/Fryguy/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/Fryguy/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/Fryguy/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fryguy/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/Fryguy/manageiq/releases{/id}","created_at":"2014-06-13T02:37:50Z","updated_at":"2014-07-02T02:07:48Z","pushed_at":"2015-11-02T16:58:44Z","git_url":"git://github.com/Fryguy/manageiq.git","ssh_url":"git@github.com:Fryguy/manageiq.git","clone_url":"https://github.com/Fryguy/manageiq.git","svn_url":"https://github.com/Fryguy/manageiq","homepage":null,"size":94160,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"dbcaadae398e55591d1cd46bf88aa10629cc87a1","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-10-30T09:21:30Z","pushed_at":"2015-11-02T17:03:15Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":182952,"stargazers_count":165,"watchers_count":165,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":174,"mirror_url":null,"open_issues_count":423,"forks":174,"open_issues":423,"watchers":165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5226"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/5226"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/5226"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/5226/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5226/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5226/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/f5a9185d608620930d775e834ac5f26bd58f45ed"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":0,"deletions":10500,"changed_files":858}}