{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/rippled/pulls/comments/25987828","id":25987828,"diff_hunk":"@@ -33,6 +34,7 @@ struct KeyPair\n };\n \n KeyPair keypairForSignature (Json::Value const& params, Json::Value& error);","path":"src/ripple/rpc/impl/KeypairForSignature.h","position":11,"original_position":11,"commit_id":"a0fca78ca5908b20039d7e3dc179513b7e22365e","original_commit_id":"1288bf6640ecf8cb502f90b99ee490a8dee2dcdb","user":{"login":"ximinez","id":6757714,"avatar_url":"https://avatars.githubusercontent.com/u/6757714?v=3","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"body":"It looks like it's _possible_, but overly complicated, and not worth it for such a simple struct. https://stackoverflow.com/questions/26276943/make-custom-type-tie-able-compatible-with-stdtie\r\n\r\nHowever, the more I think about it, the more I think it would be sufficient if generateKeyPair had a descriptive comment in the header and/or implementation: ```\r\n// .first is the public key. .second is the secret key.\r\n```\r\nThe first thing someone unfamiliar with the function is going to do is look at the definition anyway, and that comment probably answers the question as quickly as the struct.\r\n","created_at":"2015-03-06T23:44:18Z","updated_at":"2015-03-06T23:44:18Z","html_url":"https://github.com/ripple/rippled/pull/907#discussion_r25987828","pull_request_url":"https://api.github.com/repos/ripple/rippled/pulls/907","_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/25987828"},"html":{"href":"https://github.com/ripple/rippled/pull/907#discussion_r25987828"},"pull_request":{"href":"https://api.github.com/repos/ripple/rippled/pulls/907"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/907","id":30344409,"html_url":"https://github.com/ripple/rippled/pull/907","diff_url":"https://github.com/ripple/rippled/pull/907.diff","patch_url":"https://github.com/ripple/rippled/pull/907.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/907","number":907,"state":"open","locked":false,"title":"Implement Ed25519 key generation and signatures","user":{"login":"josh-ripple","id":9122244,"avatar_url":"https://avatars.githubusercontent.com/u/9122244?v=3","gravatar_id":"","url":"https://api.github.com/users/josh-ripple","html_url":"https://github.com/josh-ripple","followers_url":"https://api.github.com/users/josh-ripple/followers","following_url":"https://api.github.com/users/josh-ripple/following{/other_user}","gists_url":"https://api.github.com/users/josh-ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/josh-ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh-ripple/subscriptions","organizations_url":"https://api.github.com/users/josh-ripple/orgs","repos_url":"https://api.github.com/users/josh-ripple/repos","events_url":"https://api.github.com/users/josh-ripple/events{/privacy}","received_events_url":"https://api.github.com/users/josh-ripple/received_events","type":"User","site_admin":false},"body":"* Support Ed25519 in RippleAddress\r\n* Add `key_type` parameter to `wallet_propose` and `sign`/`submit`\r\n* Add unit tests","created_at":"2015-03-03T03:43:39Z","updated_at":"2015-03-06T23:44:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90b93efc042d15c5bbd1791cb52243b0a1c84f26","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/907/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/907/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/907/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/a0fca78ca5908b20039d7e3dc179513b7e22365e","head":{"label":"josh-ripple:ed25519-keys","ref":"ed25519-keys","sha":"a0fca78ca5908b20039d7e3dc179513b7e22365e","user":{"login":"josh-ripple","id":9122244,"avatar_url":"https://avatars.githubusercontent.com/u/9122244?v=3","gravatar_id":"","url":"https://api.github.com/users/josh-ripple","html_url":"https://github.com/josh-ripple","followers_url":"https://api.github.com/users/josh-ripple/followers","following_url":"https://api.github.com/users/josh-ripple/following{/other_user}","gists_url":"https://api.github.com/users/josh-ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/josh-ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh-ripple/subscriptions","organizations_url":"https://api.github.com/users/josh-ripple/orgs","repos_url":"https://api.github.com/users/josh-ripple/repos","events_url":"https://api.github.com/users/josh-ripple/events{/privacy}","received_events_url":"https://api.github.com/users/josh-ripple/received_events","type":"User","site_admin":false},"repo":{"id":25010049,"name":"rippled","full_name":"josh-ripple/rippled","owner":{"login":"josh-ripple","id":9122244,"avatar_url":"https://avatars.githubusercontent.com/u/9122244?v=3","gravatar_id":"","url":"https://api.github.com/users/josh-ripple","html_url":"https://github.com/josh-ripple","followers_url":"https://api.github.com/users/josh-ripple/followers","following_url":"https://api.github.com/users/josh-ripple/following{/other_user}","gists_url":"https://api.github.com/users/josh-ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/josh-ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh-ripple/subscriptions","organizations_url":"https://api.github.com/users/josh-ripple/orgs","repos_url":"https://api.github.com/users/josh-ripple/repos","events_url":"https://api.github.com/users/josh-ripple/events{/privacy}","received_events_url":"https://api.github.com/users/josh-ripple/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/josh-ripple/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/josh-ripple/rippled","forks_url":"https://api.github.com/repos/josh-ripple/rippled/forks","keys_url":"https://api.github.com/repos/josh-ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josh-ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josh-ripple/rippled/teams","hooks_url":"https://api.github.com/repos/josh-ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/josh-ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/josh-ripple/rippled/events","assignees_url":"https://api.github.com/repos/josh-ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/josh-ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/josh-ripple/rippled/tags","blobs_url":"https://api.github.com/repos/josh-ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josh-ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josh-ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/josh-ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josh-ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/josh-ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/josh-ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/josh-ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/josh-ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/josh-ripple/rippled/subscription","commits_url":"https://api.github.com/repos/josh-ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/josh-ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/josh-ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/josh-ripple/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/josh-ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/josh-ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josh-ripple/rippled/merges","archive_url":"https://api.github.com/repos/josh-ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josh-ripple/rippled/downloads","issues_url":"https://api.github.com/repos/josh-ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/josh-ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/josh-ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/josh-ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josh-ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/josh-ripple/rippled/releases{/id}","created_at":"2014-10-09T21:50:27Z","updated_at":"2015-02-23T21:17:21Z","pushed_at":"2015-03-06T22:54:17Z","git_url":"git://github.com/josh-ripple/rippled.git","ssh_url":"git@github.com:josh-ripple/rippled.git","clone_url":"https://github.com/josh-ripple/rippled.git","svn_url":"https://github.com/josh-ripple/rippled","homepage":"https://ripple.com","size":50338,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"607e983f3736f5ffb854e52305081365c8137218","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"name":"rippled","full_name":"ripple/rippled","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/rippled","description":"Ripple peer-to-peer network daemon","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","created_at":"2011-11-07T04:40:15Z","updated_at":"2015-03-04T16:40:53Z","pushed_at":"2015-03-03T23:57:16Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com","size":106332,"stargazers_count":914,"watchers_count":914,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":252,"mirror_url":null,"open_issues_count":137,"forks":252,"open_issues":137,"watchers":914,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/907"},"html":{"href":"https://github.com/ripple/rippled/pull/907"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/907"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/907/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/907/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/907/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/a0fca78ca5908b20039d7e3dc179513b7e22365e"}}}}