{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/22851235","id":22851235,"diff_hunk":"@@ -391,10 +395,13 @@ constraint, have several configuration options available. Suppose that the\n \n             public static function loadValidatorMetadata(ClassMetadata $metadata)\n             {\n-                $metadata->addPropertyConstraint('gender', new Choice(array(","path":"book/validation.rst","position":57,"original_position":46,"commit_id":"59673ae3042fa0e217d10df17ebbe2027eee21e9","original_commit_id":"15bfb64271739f4f030ce6634d5c6fe95b2c77e5","user":{"login":"ifdattic","id":966877,"avatar_url":"https://avatars.githubusercontent.com/u/966877?v=3","gravatar_id":"","url":"https://api.github.com/users/ifdattic","html_url":"https://github.com/ifdattic","followers_url":"https://api.github.com/users/ifdattic/followers","following_url":"https://api.github.com/users/ifdattic/following{/other_user}","gists_url":"https://api.github.com/users/ifdattic/gists{/gist_id}","starred_url":"https://api.github.com/users/ifdattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifdattic/subscriptions","organizations_url":"https://api.github.com/users/ifdattic/orgs","repos_url":"https://api.github.com/users/ifdattic/repos","events_url":"https://api.github.com/users/ifdattic/events{/privacy}","received_events_url":"https://api.github.com/users/ifdattic/received_events","type":"User","site_admin":false},"body":"Yes, at the moment there are not horizontal scrollbars, but after PR 4779 will be applied the `Choice` will become `Assert\\Choice` which will make the line too long and it's a 99% chance it will lead to horizontal scrollbar.","created_at":"2015-01-13T09:35:14Z","updated_at":"2015-01-13T09:35:14Z","html_url":"https://github.com/symfony/symfony-docs/pull/4789#discussion_r22851235","pull_request_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4789","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/22851235"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/4789#discussion_r22851235"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4789"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4789","id":26951654,"html_url":"https://github.com/symfony/symfony-docs/pull/4789","diff_url":"https://github.com/symfony/symfony-docs/pull/4789.diff","patch_url":"https://github.com/symfony/symfony-docs/pull/4789.patch","issue_url":"https://api.github.com/repos/symfony/symfony-docs/issues/4789","number":4789,"state":"open","locked":false,"title":"Update validation.rst","user":{"login":"ifdattic","id":966877,"avatar_url":"https://avatars.githubusercontent.com/u/966877?v=3","gravatar_id":"","url":"https://api.github.com/users/ifdattic","html_url":"https://github.com/ifdattic","followers_url":"https://api.github.com/users/ifdattic/followers","following_url":"https://api.github.com/users/ifdattic/following{/other_user}","gists_url":"https://api.github.com/users/ifdattic/gists{/gist_id}","starred_url":"https://api.github.com/users/ifdattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifdattic/subscriptions","organizations_url":"https://api.github.com/users/ifdattic/orgs","repos_url":"https://api.github.com/users/ifdattic/repos","events_url":"https://api.github.com/users/ifdattic/events{/privacy}","received_events_url":"https://api.github.com/users/ifdattic/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Doc fix?      | yes\r\n| New docs?     | no\r\n| Applies to    | 2.3\r\n| Fixed tickets | \r\n\r\nSome fixes can be a bit \"controversial\".\r\n\r\nDue to PR https://github.com/symfony/symfony-docs/pull/4779/files not all changes were made.\r\n\r\nSomething to keep in mind is what due to https://github.com/symfony/symfony-docs/pull/4779/files using `Assert\\...` if arguments are kept on the same line the possibility of horizontal scrollbar (especially on the smaller screens) is quite high.\r\n\r\nAlso for most use cases I think adding PHP constraints is better if arguments are on different lines (\"easier to read\" and easier to spot errors","created_at":"2015-01-07T11:24:39Z","updated_at":"2015-01-13T09:35:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"838676aebcab0d71854614ad57e310f7313af38d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4789/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4789/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/issues/4789/comments","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/59673ae3042fa0e217d10df17ebbe2027eee21e9","head":{"label":"ifdattic:patch-10","ref":"patch-10","sha":"59673ae3042fa0e217d10df17ebbe2027eee21e9","user":{"login":"ifdattic","id":966877,"avatar_url":"https://avatars.githubusercontent.com/u/966877?v=3","gravatar_id":"","url":"https://api.github.com/users/ifdattic","html_url":"https://github.com/ifdattic","followers_url":"https://api.github.com/users/ifdattic/followers","following_url":"https://api.github.com/users/ifdattic/following{/other_user}","gists_url":"https://api.github.com/users/ifdattic/gists{/gist_id}","starred_url":"https://api.github.com/users/ifdattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifdattic/subscriptions","organizations_url":"https://api.github.com/users/ifdattic/orgs","repos_url":"https://api.github.com/users/ifdattic/repos","events_url":"https://api.github.com/users/ifdattic/events{/privacy}","received_events_url":"https://api.github.com/users/ifdattic/received_events","type":"User","site_admin":false},"repo":{"id":28569056,"name":"symfony-docs","full_name":"ifdattic/symfony-docs","owner":{"login":"ifdattic","id":966877,"avatar_url":"https://avatars.githubusercontent.com/u/966877?v=3","gravatar_id":"","url":"https://api.github.com/users/ifdattic","html_url":"https://github.com/ifdattic","followers_url":"https://api.github.com/users/ifdattic/followers","following_url":"https://api.github.com/users/ifdattic/following{/other_user}","gists_url":"https://api.github.com/users/ifdattic/gists{/gist_id}","starred_url":"https://api.github.com/users/ifdattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifdattic/subscriptions","organizations_url":"https://api.github.com/users/ifdattic/orgs","repos_url":"https://api.github.com/users/ifdattic/repos","events_url":"https://api.github.com/users/ifdattic/events{/privacy}","received_events_url":"https://api.github.com/users/ifdattic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ifdattic/symfony-docs","description":"The Symfony2 documentation","fork":true,"url":"https://api.github.com/repos/ifdattic/symfony-docs","forks_url":"https://api.github.com/repos/ifdattic/symfony-docs/forks","keys_url":"https://api.github.com/repos/ifdattic/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ifdattic/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ifdattic/symfony-docs/teams","hooks_url":"https://api.github.com/repos/ifdattic/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/ifdattic/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/ifdattic/symfony-docs/events","assignees_url":"https://api.github.com/repos/ifdattic/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/ifdattic/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/ifdattic/symfony-docs/tags","blobs_url":"https://api.github.com/repos/ifdattic/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ifdattic/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ifdattic/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ifdattic/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ifdattic/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/ifdattic/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/ifdattic/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/ifdattic/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/ifdattic/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/ifdattic/symfony-docs/subscription","commits_url":"https://api.github.com/repos/ifdattic/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ifdattic/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ifdattic/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ifdattic/symfony-docs/issues/comments/{number}","contents_url":"https://api.github.com/repos/ifdattic/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/ifdattic/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ifdattic/symfony-docs/merges","archive_url":"https://api.github.com/repos/ifdattic/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ifdattic/symfony-docs/downloads","issues_url":"https://api.github.com/repos/ifdattic/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/ifdattic/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/ifdattic/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/ifdattic/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ifdattic/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/ifdattic/symfony-docs/releases{/id}","created_at":"2014-12-28T18:58:06Z","updated_at":"2014-12-28T18:58:09Z","pushed_at":"2015-01-13T09:11:00Z","git_url":"git://github.com/ifdattic/symfony-docs.git","ssh_url":"git@github.com:ifdattic/symfony-docs.git","clone_url":"https://github.com/ifdattic/symfony-docs.git","svn_url":"https://github.com/ifdattic/symfony-docs","homepage":"http://symfony.com/doc/current/","size":25188,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.3","ref":"2.3","sha":"1972757afc62c7ade55d3775988dae654d88a16f","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":521583,"name":"symfony-docs","full_name":"symfony/symfony-docs","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony-docs","description":"The Symfony2 documentation","fork":false,"url":"https://api.github.com/repos/symfony/symfony-docs","forks_url":"https://api.github.com/repos/symfony/symfony-docs/forks","keys_url":"https://api.github.com/repos/symfony/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony-docs/teams","hooks_url":"https://api.github.com/repos/symfony/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony-docs/events","assignees_url":"https://api.github.com/repos/symfony/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony-docs/tags","blobs_url":"https://api.github.com/repos/symfony/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony-docs/subscription","commits_url":"https://api.github.com/repos/symfony/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony-docs/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony-docs/merges","archive_url":"https://api.github.com/repos/symfony/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony-docs/downloads","issues_url":"https://api.github.com/repos/symfony/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony-docs/releases{/id}","created_at":"2010-02-17T08:43:51Z","updated_at":"2015-01-12T20:48:29Z","pushed_at":"2015-01-09T01:01:01Z","git_url":"git://github.com/symfony/symfony-docs.git","ssh_url":"git@github.com:symfony/symfony-docs.git","clone_url":"https://github.com/symfony/symfony-docs.git","svn_url":"https://github.com/symfony/symfony-docs","homepage":"http://symfony.com/doc/current/","size":52395,"stargazers_count":943,"watchers_count":943,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1645,"mirror_url":null,"open_issues_count":272,"forks":1645,"open_issues":272,"watchers":943,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4789"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/4789"},"issue":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/4789"},"comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/4789/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4789/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4789/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony-docs/statuses/59673ae3042fa0e217d10df17ebbe2027eee21e9"}}}}