{"action":"created","comment":{"url":"https://api.github.com/repos/google/certificate-transparency/pulls/comments/44669883","id":44669883,"diff_hunk":"@@ -213,13 +215,27 @@ cpp_server_ct_mirror_LDADD = \\\n \t$(leveldb_LIBS) \\\n \t-lprotobuf -lsqlite3\n cpp_server_ct_mirror_SOURCES = \\\n-  cpp/client/async_log_client.cc \\\n+        cpp/client/async_log_client.cc \\\n \tcpp/server/ct-mirror.cc \\\n \tcpp/server/certificate_handler.cc \\\n \tcpp/server/handler.cc \\\n \tcpp/server/json_output.cc \\\n \tcpp/server/server_helper.cc\n \n+cpp_server_ct_mirror_v2_LDADD = \\\n+\tcpp/libcore.a \\\n+\t$(json_c_LIBS) \\\n+\t$(libevent_LIBS) \\\n+\t$(leveldb_LIBS) \\\n+\t-lprotobuf -lsqlite3\n+cpp_server_ct_mirror_v2_SOURCES = \\\n+        cpp/client/async_log_client.cc \\","path":"Makefile.am","position":29,"original_position":29,"commit_id":"a78f2b4c92eaa668e42a1f4ba4ae2f6b922b655a","original_commit_id":"a78f2b4c92eaa668e42a1f4ba4ae2f6b922b655a","user":{"login":"pphaneuf","id":40400,"avatar_url":"https://avatars.githubusercontent.com/u/40400?v=3","gravatar_id":"","url":"https://api.github.com/users/pphaneuf","html_url":"https://github.com/pphaneuf","followers_url":"https://api.github.com/users/pphaneuf/followers","following_url":"https://api.github.com/users/pphaneuf/following{/other_user}","gists_url":"https://api.github.com/users/pphaneuf/gists{/gist_id}","starred_url":"https://api.github.com/users/pphaneuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pphaneuf/subscriptions","organizations_url":"https://api.github.com/users/pphaneuf/orgs","repos_url":"https://api.github.com/users/pphaneuf/repos","events_url":"https://api.github.com/users/pphaneuf/events{/privacy}","received_events_url":"https://api.github.com/users/pphaneuf/received_events","type":"User","site_admin":false},"body":"This one is still odd?","created_at":"2015-11-12T15:28:42Z","updated_at":"2015-11-12T15:28:42Z","html_url":"https://github.com/google/certificate-transparency/pull/1047#discussion_r44669883","pull_request_url":"https://api.github.com/repos/google/certificate-transparency/pulls/1047","_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/comments/44669883"},"html":{"href":"https://github.com/google/certificate-transparency/pull/1047#discussion_r44669883"},"pull_request":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/1047"}}},"pull_request":{"url":"https://api.github.com/repos/google/certificate-transparency/pulls/1047","id":50511269,"html_url":"https://github.com/google/certificate-transparency/pull/1047","diff_url":"https://github.com/google/certificate-transparency/pull/1047.diff","patch_url":"https://github.com/google/certificate-transparency/pull/1047.patch","issue_url":"https://api.github.com/repos/google/certificate-transparency/issues/1047","number":1047,"state":"open","locked":false,"title":"Add the infrastructure for v2 versions of ct-server and ct-mirror ","user":{"login":"Martin2112","id":13366863,"avatar_url":"https://avatars.githubusercontent.com/u/13366863?v=3","gravatar_id":"","url":"https://api.github.com/users/Martin2112","html_url":"https://github.com/Martin2112","followers_url":"https://api.github.com/users/Martin2112/followers","following_url":"https://api.github.com/users/Martin2112/following{/other_user}","gists_url":"https://api.github.com/users/Martin2112/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin2112/subscriptions","organizations_url":"https://api.github.com/users/Martin2112/orgs","repos_url":"https://api.github.com/users/Martin2112/repos","events_url":"https://api.github.com/users/Martin2112/events{/privacy}","received_events_url":"https://api.github.com/users/Martin2112/received_events","type":"User","site_admin":false},"body":"This registers v2 request handlers but they reject all requests with HTTP_NOTIMPLEMENTED.\r\n\r\nAt the moment there seems to be no good alternative than duplicating the handlers as it's not yet clear how much of the code will remain in common with v1. Hopefully, there will be some common code that can be refactored out.","created_at":"2015-11-12T13:38:41Z","updated_at":"2015-11-12T15:28:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5dd18ecabd942f16f079ce861ba569b91d905146","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/certificate-transparency/pulls/1047/commits","review_comments_url":"https://api.github.com/repos/google/certificate-transparency/pulls/1047/comments","review_comment_url":"https://api.github.com/repos/google/certificate-transparency/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/certificate-transparency/issues/1047/comments","statuses_url":"https://api.github.com/repos/google/certificate-transparency/statuses/a78f2b4c92eaa668e42a1f4ba4ae2f6b922b655a","head":{"label":"Martin2112:v2_skeleton","ref":"v2_skeleton","sha":"a78f2b4c92eaa668e42a1f4ba4ae2f6b922b655a","user":{"login":"Martin2112","id":13366863,"avatar_url":"https://avatars.githubusercontent.com/u/13366863?v=3","gravatar_id":"","url":"https://api.github.com/users/Martin2112","html_url":"https://github.com/Martin2112","followers_url":"https://api.github.com/users/Martin2112/followers","following_url":"https://api.github.com/users/Martin2112/following{/other_user}","gists_url":"https://api.github.com/users/Martin2112/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin2112/subscriptions","organizations_url":"https://api.github.com/users/Martin2112/orgs","repos_url":"https://api.github.com/users/Martin2112/repos","events_url":"https://api.github.com/users/Martin2112/events{/privacy}","received_events_url":"https://api.github.com/users/Martin2112/received_events","type":"User","site_admin":false},"repo":{"id":39995539,"name":"certificate-transparency","full_name":"Martin2112/certificate-transparency","owner":{"login":"Martin2112","id":13366863,"avatar_url":"https://avatars.githubusercontent.com/u/13366863?v=3","gravatar_id":"","url":"https://api.github.com/users/Martin2112","html_url":"https://github.com/Martin2112","followers_url":"https://api.github.com/users/Martin2112/followers","following_url":"https://api.github.com/users/Martin2112/following{/other_user}","gists_url":"https://api.github.com/users/Martin2112/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin2112/subscriptions","organizations_url":"https://api.github.com/users/Martin2112/orgs","repos_url":"https://api.github.com/users/Martin2112/repos","events_url":"https://api.github.com/users/Martin2112/events{/privacy}","received_events_url":"https://api.github.com/users/Martin2112/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Martin2112/certificate-transparency","description":"Auditing for TLS certificates.","fork":true,"url":"https://api.github.com/repos/Martin2112/certificate-transparency","forks_url":"https://api.github.com/repos/Martin2112/certificate-transparency/forks","keys_url":"https://api.github.com/repos/Martin2112/certificate-transparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Martin2112/certificate-transparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Martin2112/certificate-transparency/teams","hooks_url":"https://api.github.com/repos/Martin2112/certificate-transparency/hooks","issue_events_url":"https://api.github.com/repos/Martin2112/certificate-transparency/issues/events{/number}","events_url":"https://api.github.com/repos/Martin2112/certificate-transparency/events","assignees_url":"https://api.github.com/repos/Martin2112/certificate-transparency/assignees{/user}","branches_url":"https://api.github.com/repos/Martin2112/certificate-transparency/branches{/branch}","tags_url":"https://api.github.com/repos/Martin2112/certificate-transparency/tags","blobs_url":"https://api.github.com/repos/Martin2112/certificate-transparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Martin2112/certificate-transparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Martin2112/certificate-transparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/Martin2112/certificate-transparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Martin2112/certificate-transparency/statuses/{sha}","languages_url":"https://api.github.com/repos/Martin2112/certificate-transparency/languages","stargazers_url":"https://api.github.com/repos/Martin2112/certificate-transparency/stargazers","contributors_url":"https://api.github.com/repos/Martin2112/certificate-transparency/contributors","subscribers_url":"https://api.github.com/repos/Martin2112/certificate-transparency/subscribers","subscription_url":"https://api.github.com/repos/Martin2112/certificate-transparency/subscription","commits_url":"https://api.github.com/repos/Martin2112/certificate-transparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/Martin2112/certificate-transparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/Martin2112/certificate-transparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/Martin2112/certificate-transparency/issues/comments{/number}","contents_url":"https://api.github.com/repos/Martin2112/certificate-transparency/contents/{+path}","compare_url":"https://api.github.com/repos/Martin2112/certificate-transparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Martin2112/certificate-transparency/merges","archive_url":"https://api.github.com/repos/Martin2112/certificate-transparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Martin2112/certificate-transparency/downloads","issues_url":"https://api.github.com/repos/Martin2112/certificate-transparency/issues{/number}","pulls_url":"https://api.github.com/repos/Martin2112/certificate-transparency/pulls{/number}","milestones_url":"https://api.github.com/repos/Martin2112/certificate-transparency/milestones{/number}","notifications_url":"https://api.github.com/repos/Martin2112/certificate-transparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Martin2112/certificate-transparency/labels{/name}","releases_url":"https://api.github.com/repos/Martin2112/certificate-transparency/releases{/id}","created_at":"2015-07-31T08:37:21Z","updated_at":"2015-07-31T08:37:23Z","pushed_at":"2015-11-12T15:23:56Z","git_url":"git://github.com/Martin2112/certificate-transparency.git","ssh_url":"git@github.com:Martin2112/certificate-transparency.git","clone_url":"https://github.com/Martin2112/certificate-transparency.git","svn_url":"https://github.com/Martin2112/certificate-transparency","homepage":"http://www.certificate-transparency.org/","size":20214,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"d41415825e2a14aa77319907a91497a08ce481ae","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":19989605,"name":"certificate-transparency","full_name":"google/certificate-transparency","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/certificate-transparency","description":"Auditing for TLS certificates.","fork":false,"url":"https://api.github.com/repos/google/certificate-transparency","forks_url":"https://api.github.com/repos/google/certificate-transparency/forks","keys_url":"https://api.github.com/repos/google/certificate-transparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/certificate-transparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/certificate-transparency/teams","hooks_url":"https://api.github.com/repos/google/certificate-transparency/hooks","issue_events_url":"https://api.github.com/repos/google/certificate-transparency/issues/events{/number}","events_url":"https://api.github.com/repos/google/certificate-transparency/events","assignees_url":"https://api.github.com/repos/google/certificate-transparency/assignees{/user}","branches_url":"https://api.github.com/repos/google/certificate-transparency/branches{/branch}","tags_url":"https://api.github.com/repos/google/certificate-transparency/tags","blobs_url":"https://api.github.com/repos/google/certificate-transparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/certificate-transparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/certificate-transparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/certificate-transparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/certificate-transparency/statuses/{sha}","languages_url":"https://api.github.com/repos/google/certificate-transparency/languages","stargazers_url":"https://api.github.com/repos/google/certificate-transparency/stargazers","contributors_url":"https://api.github.com/repos/google/certificate-transparency/contributors","subscribers_url":"https://api.github.com/repos/google/certificate-transparency/subscribers","subscription_url":"https://api.github.com/repos/google/certificate-transparency/subscription","commits_url":"https://api.github.com/repos/google/certificate-transparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/certificate-transparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/certificate-transparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/certificate-transparency/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/certificate-transparency/contents/{+path}","compare_url":"https://api.github.com/repos/google/certificate-transparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/certificate-transparency/merges","archive_url":"https://api.github.com/repos/google/certificate-transparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/certificate-transparency/downloads","issues_url":"https://api.github.com/repos/google/certificate-transparency/issues{/number}","pulls_url":"https://api.github.com/repos/google/certificate-transparency/pulls{/number}","milestones_url":"https://api.github.com/repos/google/certificate-transparency/milestones{/number}","notifications_url":"https://api.github.com/repos/google/certificate-transparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/certificate-transparency/labels{/name}","releases_url":"https://api.github.com/repos/google/certificate-transparency/releases{/id}","created_at":"2014-05-20T17:03:47Z","updated_at":"2015-11-10T14:39:20Z","pushed_at":"2015-11-12T15:23:57Z","git_url":"git://github.com/google/certificate-transparency.git","ssh_url":"git@github.com:google/certificate-transparency.git","clone_url":"https://github.com/google/certificate-transparency.git","svn_url":"https://github.com/google/certificate-transparency","homepage":"http://www.certificate-transparency.org/","size":27510,"stargazers_count":189,"watchers_count":189,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":64,"forks":71,"open_issues":64,"watchers":189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/1047"},"html":{"href":"https://github.com/google/certificate-transparency/pull/1047"},"issue":{"href":"https://api.github.com/repos/google/certificate-transparency/issues/1047"},"comments":{"href":"https://api.github.com/repos/google/certificate-transparency/issues/1047/comments"},"review_comments":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/1047/comments"},"review_comment":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/1047/commits"},"statuses":{"href":"https://api.github.com/repos/google/certificate-transparency/statuses/a78f2b4c92eaa668e42a1f4ba4ae2f6b922b655a"}}}}