{"action":"created","comment":{"url":"https://api.github.com/repos/i3/i3/pulls/comments/39662931","id":39662931,"diff_hunk":"@@ -274,3 +274,39 @@ xcb_visualid_t get_visualid_by_depth(uint16_t depth) {\n     }\n     return 0;\n }\n+\n+/*\n+ * Add an atom to a list of atoms the given property defines.\n+ * This is useful, for example, for manipulating _NET_WM_STATE.\n+ *\n+ */\n+void xcb_add_property_atom(xcb_connection_t *conn, xcb_window_t window, xcb_atom_t property, xcb_atom_t atom) {\n+    xcb_change_property(conn, XCB_PROP_MODE_APPEND, window, property, XCB_ATOM_ATOM, 32, 1, (uint32_t[]){atom});\n+}\n+\n+/*\n+ * Remove an atom from a list of atoms the given property defines without\n+ * removing any other potentially set atoms.  This is useful, for example, for\n+ * manipulating _NET_WM_STATE.\n+ *\n+ */\n+void xcb_remove_property_atom(xcb_connection_t *conn, xcb_window_t window, xcb_atom_t property, xcb_atom_t atom) {","path":"src/xcb.c","position":20,"original_position":20,"commit_id":"665a0259cf78062da385e76f42ad885f5d63beb7","original_commit_id":"665a0259cf78062da385e76f42ad885f5d63beb7","user":{"login":"stapelberg","id":55506,"avatar_url":"https://avatars.githubusercontent.com/u/55506?v=3","gravatar_id":"","url":"https://api.github.com/users/stapelberg","html_url":"https://github.com/stapelberg","followers_url":"https://api.github.com/users/stapelberg/followers","following_url":"https://api.github.com/users/stapelberg/following{/other_user}","gists_url":"https://api.github.com/users/stapelberg/gists{/gist_id}","starred_url":"https://api.github.com/users/stapelberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stapelberg/subscriptions","organizations_url":"https://api.github.com/users/stapelberg/orgs","repos_url":"https://api.github.com/users/stapelberg/repos","events_url":"https://api.github.com/users/stapelberg/events{/privacy}","received_events_url":"https://api.github.com/users/stapelberg/received_events","type":"User","site_admin":false},"body":"This function is not atomic, but I think it should be. Can you add `xcb_grab_server()` calls please?","created_at":"2015-09-16T17:55:37Z","updated_at":"2015-09-16T17:55:37Z","html_url":"https://github.com/i3/i3/pull/1920#discussion_r39662931","pull_request_url":"https://api.github.com/repos/i3/i3/pulls/1920","_links":{"self":{"href":"https://api.github.com/repos/i3/i3/pulls/comments/39662931"},"html":{"href":"https://github.com/i3/i3/pull/1920#discussion_r39662931"},"pull_request":{"href":"https://api.github.com/repos/i3/i3/pulls/1920"}}},"pull_request":{"url":"https://api.github.com/repos/i3/i3/pulls/1920","id":44919629,"html_url":"https://github.com/i3/i3/pull/1920","diff_url":"https://github.com/i3/i3/pull/1920.diff","patch_url":"https://github.com/i3/i3/pull/1920.patch","issue_url":"https://api.github.com/repos/i3/i3/issues/1920","number":1920,"state":"open","locked":false,"title":"Set and unset individual atoms in _NET_WM_STATE","user":{"login":"Airblader","id":2392216,"avatar_url":"https://avatars.githubusercontent.com/u/2392216?v=3","gravatar_id":"","url":"https://api.github.com/users/Airblader","html_url":"https://github.com/Airblader","followers_url":"https://api.github.com/users/Airblader/followers","following_url":"https://api.github.com/users/Airblader/following{/other_user}","gists_url":"https://api.github.com/users/Airblader/gists{/gist_id}","starred_url":"https://api.github.com/users/Airblader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Airblader/subscriptions","organizations_url":"https://api.github.com/users/Airblader/orgs","repos_url":"https://api.github.com/users/Airblader/repos","events_url":"https://api.github.com/users/Airblader/events{/privacy}","received_events_url":"https://api.github.com/users/Airblader/received_events","type":"User","site_admin":false},"body":"fixes #1873","created_at":"2015-09-14T11:35:10Z","updated_at":"2015-09-16T17:55:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b8abe41b2af6896bd915ec372e68927d16aab36","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/i3/i3/pulls/1920/commits","review_comments_url":"https://api.github.com/repos/i3/i3/pulls/1920/comments","review_comment_url":"https://api.github.com/repos/i3/i3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/i3/i3/issues/1920/comments","statuses_url":"https://api.github.com/repos/i3/i3/statuses/665a0259cf78062da385e76f42ad885f5d63beb7","head":{"label":"Airblader:feature-1873","ref":"feature-1873","sha":"665a0259cf78062da385e76f42ad885f5d63beb7","user":{"login":"Airblader","id":2392216,"avatar_url":"https://avatars.githubusercontent.com/u/2392216?v=3","gravatar_id":"","url":"https://api.github.com/users/Airblader","html_url":"https://github.com/Airblader","followers_url":"https://api.github.com/users/Airblader/followers","following_url":"https://api.github.com/users/Airblader/following{/other_user}","gists_url":"https://api.github.com/users/Airblader/gists{/gist_id}","starred_url":"https://api.github.com/users/Airblader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Airblader/subscriptions","organizations_url":"https://api.github.com/users/Airblader/orgs","repos_url":"https://api.github.com/users/Airblader/repos","events_url":"https://api.github.com/users/Airblader/events{/privacy}","received_events_url":"https://api.github.com/users/Airblader/received_events","type":"User","site_admin":false},"repo":{"id":30594072,"name":"i3-original","full_name":"Airblader/i3-original","owner":{"login":"Airblader","id":2392216,"avatar_url":"https://avatars.githubusercontent.com/u/2392216?v=3","gravatar_id":"","url":"https://api.github.com/users/Airblader","html_url":"https://github.com/Airblader","followers_url":"https://api.github.com/users/Airblader/followers","following_url":"https://api.github.com/users/Airblader/following{/other_user}","gists_url":"https://api.github.com/users/Airblader/gists{/gist_id}","starred_url":"https://api.github.com/users/Airblader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Airblader/subscriptions","organizations_url":"https://api.github.com/users/Airblader/orgs","repos_url":"https://api.github.com/users/Airblader/repos","events_url":"https://api.github.com/users/Airblader/events{/privacy}","received_events_url":"https://api.github.com/users/Airblader/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Airblader/i3-original","description":"Plain fork of vanilla i3 to submit pull requests","fork":true,"url":"https://api.github.com/repos/Airblader/i3-original","forks_url":"https://api.github.com/repos/Airblader/i3-original/forks","keys_url":"https://api.github.com/repos/Airblader/i3-original/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Airblader/i3-original/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Airblader/i3-original/teams","hooks_url":"https://api.github.com/repos/Airblader/i3-original/hooks","issue_events_url":"https://api.github.com/repos/Airblader/i3-original/issues/events{/number}","events_url":"https://api.github.com/repos/Airblader/i3-original/events","assignees_url":"https://api.github.com/repos/Airblader/i3-original/assignees{/user}","branches_url":"https://api.github.com/repos/Airblader/i3-original/branches{/branch}","tags_url":"https://api.github.com/repos/Airblader/i3-original/tags","blobs_url":"https://api.github.com/repos/Airblader/i3-original/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Airblader/i3-original/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Airblader/i3-original/git/refs{/sha}","trees_url":"https://api.github.com/repos/Airblader/i3-original/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Airblader/i3-original/statuses/{sha}","languages_url":"https://api.github.com/repos/Airblader/i3-original/languages","stargazers_url":"https://api.github.com/repos/Airblader/i3-original/stargazers","contributors_url":"https://api.github.com/repos/Airblader/i3-original/contributors","subscribers_url":"https://api.github.com/repos/Airblader/i3-original/subscribers","subscription_url":"https://api.github.com/repos/Airblader/i3-original/subscription","commits_url":"https://api.github.com/repos/Airblader/i3-original/commits{/sha}","git_commits_url":"https://api.github.com/repos/Airblader/i3-original/git/commits{/sha}","comments_url":"https://api.github.com/repos/Airblader/i3-original/comments{/number}","issue_comment_url":"https://api.github.com/repos/Airblader/i3-original/issues/comments{/number}","contents_url":"https://api.github.com/repos/Airblader/i3-original/contents/{+path}","compare_url":"https://api.github.com/repos/Airblader/i3-original/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Airblader/i3-original/merges","archive_url":"https://api.github.com/repos/Airblader/i3-original/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Airblader/i3-original/downloads","issues_url":"https://api.github.com/repos/Airblader/i3-original/issues{/number}","pulls_url":"https://api.github.com/repos/Airblader/i3-original/pulls{/number}","milestones_url":"https://api.github.com/repos/Airblader/i3-original/milestones{/number}","notifications_url":"https://api.github.com/repos/Airblader/i3-original/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Airblader/i3-original/labels{/name}","releases_url":"https://api.github.com/repos/Airblader/i3-original/releases{/id}","created_at":"2015-02-10T13:49:15Z","updated_at":"2015-05-02T20:20:17Z","pushed_at":"2015-09-16T17:52:13Z","git_url":"git://github.com/Airblader/i3-original.git","ssh_url":"git@github.com:Airblader/i3-original.git","clone_url":"https://github.com/Airblader/i3-original.git","svn_url":"https://github.com/Airblader/i3-original","homepage":"","size":8924,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"next"}},"base":{"label":"i3:next","ref":"next","sha":"7de15b38156a0019222d014ab23b612699c277dd","user":{"login":"i3","id":7904352,"avatar_url":"https://avatars.githubusercontent.com/u/7904352?v=3","gravatar_id":"","url":"https://api.github.com/users/i3","html_url":"https://github.com/i3","followers_url":"https://api.github.com/users/i3/followers","following_url":"https://api.github.com/users/i3/following{/other_user}","gists_url":"https://api.github.com/users/i3/gists{/gist_id}","starred_url":"https://api.github.com/users/i3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i3/subscriptions","organizations_url":"https://api.github.com/users/i3/orgs","repos_url":"https://api.github.com/users/i3/repos","events_url":"https://api.github.com/users/i3/events{/privacy}","received_events_url":"https://api.github.com/users/i3/received_events","type":"Organization","site_admin":false},"repo":{"id":30291090,"name":"i3","full_name":"i3/i3","owner":{"login":"i3","id":7904352,"avatar_url":"https://avatars.githubusercontent.com/u/7904352?v=3","gravatar_id":"","url":"https://api.github.com/users/i3","html_url":"https://github.com/i3","followers_url":"https://api.github.com/users/i3/followers","following_url":"https://api.github.com/users/i3/following{/other_user}","gists_url":"https://api.github.com/users/i3/gists{/gist_id}","starred_url":"https://api.github.com/users/i3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i3/subscriptions","organizations_url":"https://api.github.com/users/i3/orgs","repos_url":"https://api.github.com/users/i3/repos","events_url":"https://api.github.com/users/i3/events{/privacy}","received_events_url":"https://api.github.com/users/i3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/i3/i3","description":"A better tiling and dynamic window manager","fork":false,"url":"https://api.github.com/repos/i3/i3","forks_url":"https://api.github.com/repos/i3/i3/forks","keys_url":"https://api.github.com/repos/i3/i3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/i3/i3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/i3/i3/teams","hooks_url":"https://api.github.com/repos/i3/i3/hooks","issue_events_url":"https://api.github.com/repos/i3/i3/issues/events{/number}","events_url":"https://api.github.com/repos/i3/i3/events","assignees_url":"https://api.github.com/repos/i3/i3/assignees{/user}","branches_url":"https://api.github.com/repos/i3/i3/branches{/branch}","tags_url":"https://api.github.com/repos/i3/i3/tags","blobs_url":"https://api.github.com/repos/i3/i3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/i3/i3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/i3/i3/git/refs{/sha}","trees_url":"https://api.github.com/repos/i3/i3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/i3/i3/statuses/{sha}","languages_url":"https://api.github.com/repos/i3/i3/languages","stargazers_url":"https://api.github.com/repos/i3/i3/stargazers","contributors_url":"https://api.github.com/repos/i3/i3/contributors","subscribers_url":"https://api.github.com/repos/i3/i3/subscribers","subscription_url":"https://api.github.com/repos/i3/i3/subscription","commits_url":"https://api.github.com/repos/i3/i3/commits{/sha}","git_commits_url":"https://api.github.com/repos/i3/i3/git/commits{/sha}","comments_url":"https://api.github.com/repos/i3/i3/comments{/number}","issue_comment_url":"https://api.github.com/repos/i3/i3/issues/comments{/number}","contents_url":"https://api.github.com/repos/i3/i3/contents/{+path}","compare_url":"https://api.github.com/repos/i3/i3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/i3/i3/merges","archive_url":"https://api.github.com/repos/i3/i3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/i3/i3/downloads","issues_url":"https://api.github.com/repos/i3/i3/issues{/number}","pulls_url":"https://api.github.com/repos/i3/i3/pulls{/number}","milestones_url":"https://api.github.com/repos/i3/i3/milestones{/number}","notifications_url":"https://api.github.com/repos/i3/i3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/i3/i3/labels{/name}","releases_url":"https://api.github.com/repos/i3/i3/releases{/id}","created_at":"2015-02-04T09:23:51Z","updated_at":"2015-09-16T14:29:38Z","pushed_at":"2015-09-16T17:52:14Z","git_url":"git://github.com/i3/i3.git","ssh_url":"git@github.com:i3/i3.git","clone_url":"https://github.com/i3/i3.git","svn_url":"https://github.com/i3/i3","homepage":"http://i3wm.org/","size":9869,"stargazers_count":644,"watchers_count":644,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":87,"mirror_url":null,"open_issues_count":80,"forks":87,"open_issues":80,"watchers":644,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/i3/i3/pulls/1920"},"html":{"href":"https://github.com/i3/i3/pull/1920"},"issue":{"href":"https://api.github.com/repos/i3/i3/issues/1920"},"comments":{"href":"https://api.github.com/repos/i3/i3/issues/1920/comments"},"review_comments":{"href":"https://api.github.com/repos/i3/i3/pulls/1920/comments"},"review_comment":{"href":"https://api.github.com/repos/i3/i3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/i3/i3/pulls/1920/commits"},"statuses":{"href":"https://api.github.com/repos/i3/i3/statuses/665a0259cf78062da385e76f42ad885f5d63beb7"}}}}