{"action":"created","comment":{"url":"https://api.github.com/repos/joyent/node/pulls/comments/34841679","id":34841679,"diff_hunk":"@@ -134,7 +134,18 @@ exports.createCredentials = function(options, context) {\n \n   if (options.cert) c.context.setCert(options.cert);\n \n-  if (options.ciphers) c.context.setCiphers(options.ciphers);\n+  if (options.ciphers) {\n+    c.context.setCiphers(options.ciphers);\n+  } else if (!(tls.usingV1038Ciphers() && options.ciphers === undefined)) {","path":"lib/crypto.js","position":null,"original_position":23,"commit_id":"bd74d90a1adcb51f27f32a7d30a3996793d40335","original_commit_id":"809b970cdfda1e25c50f292b19255f42204fa6c7","user":{"login":"misterdjules","id":811047,"avatar_url":"https://avatars.githubusercontent.com/u/811047?v=3","gravatar_id":"","url":"https://api.github.com/users/misterdjules","html_url":"https://github.com/misterdjules","followers_url":"https://api.github.com/users/misterdjules/followers","following_url":"https://api.github.com/users/misterdjules/following{/other_user}","gists_url":"https://api.github.com/users/misterdjules/gists{/gist_id}","starred_url":"https://api.github.com/users/misterdjules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterdjules/subscriptions","organizations_url":"https://api.github.com/users/misterdjules/orgs","repos_url":"https://api.github.com/users/misterdjules/repos","events_url":"https://api.github.com/users/misterdjules/events{/privacy}","received_events_url":"https://api.github.com/users/misterdjules/received_events","type":"User","site_admin":false},"body":"@jasnell Actually, this is specific to v0.10.x versions, so we won't have to maintain it in the v0.12.x branch and later. If we're on the same page regarding this then I'm fine with it.","created_at":"2015-07-16T21:47:21Z","updated_at":"2015-07-16T21:47:21Z","html_url":"https://github.com/joyent/node/pull/25603#discussion_r34841679","pull_request_url":"https://api.github.com/repos/joyent/node/pulls/25603","_links":{"self":{"href":"https://api.github.com/repos/joyent/node/pulls/comments/34841679"},"html":{"href":"https://github.com/joyent/node/pull/25603#discussion_r34841679"},"pull_request":{"href":"https://api.github.com/repos/joyent/node/pulls/25603"}}},"pull_request":{"url":"https://api.github.com/repos/joyent/node/pulls/25603","id":38932433,"html_url":"https://github.com/joyent/node/pull/25603","diff_url":"https://github.com/joyent/node/pull/25603.diff","patch_url":"https://github.com/joyent/node/pull/25603.patch","issue_url":"https://api.github.com/repos/joyent/node/issues/25603","number":25603,"state":"open","locked":false,"title":"Deprecate RC4 ciphers from the default ciphers list","user":{"login":"misterdjules","id":811047,"avatar_url":"https://avatars.githubusercontent.com/u/811047?v=3","gravatar_id":"","url":"https://api.github.com/users/misterdjules","html_url":"https://github.com/misterdjules","followers_url":"https://api.github.com/users/misterdjules/followers","following_url":"https://api.github.com/users/misterdjules/following{/other_user}","gists_url":"https://api.github.com/users/misterdjules/gists{/gist_id}","starred_url":"https://api.github.com/users/misterdjules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterdjules/subscriptions","organizations_url":"https://api.github.com/users/misterdjules/orgs","repos_url":"https://api.github.com/users/misterdjules/repos","events_url":"https://api.github.com/users/misterdjules/events{/privacy}","received_events_url":"https://api.github.com/users/misterdjules/received_events","type":"User","site_admin":false},"body":"This PR consolidates previous PRs from @jasnell (https://github.com/joyent/node/pull/14413, https://github.com/joyent/node/pull/14572) and myself (https://github.com/joyent/node/pull/23947) and allows us to have one single place where we can take a look at the current status of deprecating RC4 from the default ciphers list used by node v0.10.x, discuss it, and make changes.\r\n\r\nThe list of commits hasn't been squashed to preserve the history behind these changes. If this PR lands, its commits will be squashed. Before that, we want to make sure we understand all the implications of these changes.","created_at":"2015-06-30T22:43:18Z","updated_at":"2015-07-16T21:47:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28e416add4ae892b0bb0691db1f2b7cc125b020b","assignee":null,"milestone":{"url":"https://api.github.com/repos/joyent/node/milestones/40","html_url":"https://github.com/joyent/node/milestones/0.10.41","labels_url":"https://api.github.com/repos/joyent/node/milestones/40/labels","id":1176398,"number":40,"title":"0.10.41","description":"","creator":{"login":"misterdjules","id":811047,"avatar_url":"https://avatars.githubusercontent.com/u/811047?v=3","gravatar_id":"","url":"https://api.github.com/users/misterdjules","html_url":"https://github.com/misterdjules","followers_url":"https://api.github.com/users/misterdjules/followers","following_url":"https://api.github.com/users/misterdjules/following{/other_user}","gists_url":"https://api.github.com/users/misterdjules/gists{/gist_id}","starred_url":"https://api.github.com/users/misterdjules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterdjules/subscriptions","organizations_url":"https://api.github.com/users/misterdjules/orgs","repos_url":"https://api.github.com/users/misterdjules/repos","events_url":"https://api.github.com/users/misterdjules/events{/privacy}","received_events_url":"https://api.github.com/users/misterdjules/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":0,"state":"open","created_at":"2015-06-22T23:46:33Z","updated_at":"2015-07-14T00:05:37Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/joyent/node/pulls/25603/commits","review_comments_url":"https://api.github.com/repos/joyent/node/pulls/25603/comments","review_comment_url":"https://api.github.com/repos/joyent/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joyent/node/issues/25603/comments","statuses_url":"https://api.github.com/repos/joyent/node/statuses/bd74d90a1adcb51f27f32a7d30a3996793d40335","head":{"label":"misterdjules:RC4-not-in-default-ciphers-0-10","ref":"RC4-not-in-default-ciphers-0-10","sha":"bd74d90a1adcb51f27f32a7d30a3996793d40335","user":{"login":"misterdjules","id":811047,"avatar_url":"https://avatars.githubusercontent.com/u/811047?v=3","gravatar_id":"","url":"https://api.github.com/users/misterdjules","html_url":"https://github.com/misterdjules","followers_url":"https://api.github.com/users/misterdjules/followers","following_url":"https://api.github.com/users/misterdjules/following{/other_user}","gists_url":"https://api.github.com/users/misterdjules/gists{/gist_id}","starred_url":"https://api.github.com/users/misterdjules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterdjules/subscriptions","organizations_url":"https://api.github.com/users/misterdjules/orgs","repos_url":"https://api.github.com/users/misterdjules/repos","events_url":"https://api.github.com/users/misterdjules/events{/privacy}","received_events_url":"https://api.github.com/users/misterdjules/received_events","type":"User","site_admin":false},"repo":{"id":22083156,"name":"node","full_name":"misterdjules/node","owner":{"login":"misterdjules","id":811047,"avatar_url":"https://avatars.githubusercontent.com/u/811047?v=3","gravatar_id":"","url":"https://api.github.com/users/misterdjules","html_url":"https://github.com/misterdjules","followers_url":"https://api.github.com/users/misterdjules/followers","following_url":"https://api.github.com/users/misterdjules/following{/other_user}","gists_url":"https://api.github.com/users/misterdjules/gists{/gist_id}","starred_url":"https://api.github.com/users/misterdjules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterdjules/subscriptions","organizations_url":"https://api.github.com/users/misterdjules/orgs","repos_url":"https://api.github.com/users/misterdjules/repos","events_url":"https://api.github.com/users/misterdjules/events{/privacy}","received_events_url":"https://api.github.com/users/misterdjules/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/misterdjules/node","description":"evented I/O for v8 javascript","fork":true,"url":"https://api.github.com/repos/misterdjules/node","forks_url":"https://api.github.com/repos/misterdjules/node/forks","keys_url":"https://api.github.com/repos/misterdjules/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/misterdjules/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/misterdjules/node/teams","hooks_url":"https://api.github.com/repos/misterdjules/node/hooks","issue_events_url":"https://api.github.com/repos/misterdjules/node/issues/events{/number}","events_url":"https://api.github.com/repos/misterdjules/node/events","assignees_url":"https://api.github.com/repos/misterdjules/node/assignees{/user}","branches_url":"https://api.github.com/repos/misterdjules/node/branches{/branch}","tags_url":"https://api.github.com/repos/misterdjules/node/tags","blobs_url":"https://api.github.com/repos/misterdjules/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/misterdjules/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/misterdjules/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/misterdjules/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/misterdjules/node/statuses/{sha}","languages_url":"https://api.github.com/repos/misterdjules/node/languages","stargazers_url":"https://api.github.com/repos/misterdjules/node/stargazers","contributors_url":"https://api.github.com/repos/misterdjules/node/contributors","subscribers_url":"https://api.github.com/repos/misterdjules/node/subscribers","subscription_url":"https://api.github.com/repos/misterdjules/node/subscription","commits_url":"https://api.github.com/repos/misterdjules/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/misterdjules/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/misterdjules/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/misterdjules/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/misterdjules/node/contents/{+path}","compare_url":"https://api.github.com/repos/misterdjules/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/misterdjules/node/merges","archive_url":"https://api.github.com/repos/misterdjules/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/misterdjules/node/downloads","issues_url":"https://api.github.com/repos/misterdjules/node/issues{/number}","pulls_url":"https://api.github.com/repos/misterdjules/node/pulls{/number}","milestones_url":"https://api.github.com/repos/misterdjules/node/milestones{/number}","notifications_url":"https://api.github.com/repos/misterdjules/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/misterdjules/node/labels{/name}","releases_url":"https://api.github.com/repos/misterdjules/node/releases{/id}","created_at":"2014-07-21T22:55:09Z","updated_at":"2015-04-01T19:01:34Z","pushed_at":"2015-07-16T21:46:12Z","git_url":"git://github.com/misterdjules/node.git","ssh_url":"git@github.com:misterdjules/node.git","clone_url":"https://github.com/misterdjules/node.git","svn_url":"https://github.com/misterdjules/node","homepage":"http://nodejs.org/","size":129035,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joyent:v0.10","ref":"v0.10","sha":"e5aaa34ba0c2d3aa54c6f48e3f9ddd0b7b4ce2fb","user":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=3","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"repo":{"id":211666,"name":"node","full_name":"joyent/node","owner":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=3","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joyent/node","description":"evented I/O for v8 javascript","fork":false,"url":"https://api.github.com/repos/joyent/node","forks_url":"https://api.github.com/repos/joyent/node/forks","keys_url":"https://api.github.com/repos/joyent/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joyent/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joyent/node/teams","hooks_url":"https://api.github.com/repos/joyent/node/hooks","issue_events_url":"https://api.github.com/repos/joyent/node/issues/events{/number}","events_url":"https://api.github.com/repos/joyent/node/events","assignees_url":"https://api.github.com/repos/joyent/node/assignees{/user}","branches_url":"https://api.github.com/repos/joyent/node/branches{/branch}","tags_url":"https://api.github.com/repos/joyent/node/tags","blobs_url":"https://api.github.com/repos/joyent/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joyent/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joyent/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/joyent/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joyent/node/statuses/{sha}","languages_url":"https://api.github.com/repos/joyent/node/languages","stargazers_url":"https://api.github.com/repos/joyent/node/stargazers","contributors_url":"https://api.github.com/repos/joyent/node/contributors","subscribers_url":"https://api.github.com/repos/joyent/node/subscribers","subscription_url":"https://api.github.com/repos/joyent/node/subscription","commits_url":"https://api.github.com/repos/joyent/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/joyent/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/joyent/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/joyent/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/joyent/node/contents/{+path}","compare_url":"https://api.github.com/repos/joyent/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joyent/node/merges","archive_url":"https://api.github.com/repos/joyent/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joyent/node/downloads","issues_url":"https://api.github.com/repos/joyent/node/issues{/number}","pulls_url":"https://api.github.com/repos/joyent/node/pulls{/number}","milestones_url":"https://api.github.com/repos/joyent/node/milestones{/number}","notifications_url":"https://api.github.com/repos/joyent/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joyent/node/labels{/name}","releases_url":"https://api.github.com/repos/joyent/node/releases{/id}","created_at":"2009-05-27T16:29:46Z","updated_at":"2015-07-16T21:22:57Z","pushed_at":"2015-07-16T21:46:26Z","git_url":"git://github.com/joyent/node.git","ssh_url":"git@github.com:joyent/node.git","clone_url":"https://github.com/joyent/node.git","svn_url":"https://github.com/joyent/node","homepage":"http://nodejs.org/","size":357655,"stargazers_count":37292,"watchers_count":37292,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":8447,"mirror_url":null,"open_issues_count":1012,"forks":8447,"open_issues":1012,"watchers":37292,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joyent/node/pulls/25603"},"html":{"href":"https://github.com/joyent/node/pull/25603"},"issue":{"href":"https://api.github.com/repos/joyent/node/issues/25603"},"comments":{"href":"https://api.github.com/repos/joyent/node/issues/25603/comments"},"review_comments":{"href":"https://api.github.com/repos/joyent/node/pulls/25603/comments"},"review_comment":{"href":"https://api.github.com/repos/joyent/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joyent/node/pulls/25603/commits"},"statuses":{"href":"https://api.github.com/repos/joyent/node/statuses/bd74d90a1adcb51f27f32a7d30a3996793d40335"}}}}