{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/25220394","id":25220394,"diff_hunk":"@@ -439,9 +434,21 @@ internal static DkmCustomUIVisualizerInfo[] GetDebuggerCustomUIVisualizerInfo(th\n             return result;\n         }\n \n-        private static string EvaluateDebuggerDisplayString(DkmClrValue value, string str)\n+        internal static void EvaluateDebuggerDisplayStringAndContinue(this DkmClrValue value, DkmWorkList workList, DkmInspectionContext inspectionContext, DkmClrType targetType, string str, DkmCompletionRoutine<DkmEvaluateDebuggerDisplayStringAsyncResult> completionRoutine)\n+        {\n+            if (str == null)\n+            {\n+                completionRoutine(default(DkmEvaluateDebuggerDisplayStringAsyncResult));\n+            }\n+            else\n+            {\n+                value.EvaluateDebuggerDisplayString(workList, inspectionContext, targetType, str, completionRoutine);\n+            }\n+        }\n+\n+        internal static string GetResult(this DkmEvaluateDebuggerDisplayStringAsyncResult asyncResult)\n         {\n-            return str == null ? null : value.EvaluateDebuggerDisplayString(str);\n+            return !asyncResult.Equals(default(DkmEvaluateDebuggerDisplayStringAsyncResult)) ? asyncResult.Result : null;","path":"src/ExpressionEvaluator/Core/Source/ResultProvider/Helpers/TypeHelpers.cs","position":null,"original_position":70,"commit_id":"2f3f97905e03042515847b47a4a0219be37f6303","original_commit_id":"ae6b64a4d5b0eedd2f30d9d0e37fedcf2c872186","user":{"login":"KevinH-MS","id":6464209,"avatar_url":"https://avatars.githubusercontent.com/u/6464209?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinH-MS","html_url":"https://github.com/KevinH-MS","followers_url":"https://api.github.com/users/KevinH-MS/followers","following_url":"https://api.github.com/users/KevinH-MS/following{/other_user}","gists_url":"https://api.github.com/users/KevinH-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinH-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinH-MS/subscriptions","organizations_url":"https://api.github.com/users/KevinH-MS/orgs","repos_url":"https://api.github.com/users/KevinH-MS/repos","events_url":"https://api.github.com/users/KevinH-MS/events{/privacy}","received_events_url":"https://api.github.com/users/KevinH-MS/received_events","type":"User","site_admin":false},"body":"Never mind--per offline discussion, I'll just remove the method and call .Result on the default(struct).","created_at":"2015-02-24T01:15:49Z","updated_at":"2015-02-24T01:15:49Z","html_url":"https://github.com/dotnet/roslyn/pull/727#discussion_r25220394","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/727","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/25220394"},"html":{"href":"https://github.com/dotnet/roslyn/pull/727#discussion_r25220394"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/727"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/727","id":29718220,"html_url":"https://github.com/dotnet/roslyn/pull/727","diff_url":"https://github.com/dotnet/roslyn/pull/727.diff","patch_url":"https://github.com/dotnet/roslyn/pull/727.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/727","number":727,"state":"open","locked":false,"title":"Refactor ResultProvider (incorporating Concord API changes)...","user":{"login":"KevinH-MS","id":6464209,"avatar_url":"https://avatars.githubusercontent.com/u/6464209?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinH-MS","html_url":"https://github.com/KevinH-MS","followers_url":"https://api.github.com/users/KevinH-MS/followers","following_url":"https://api.github.com/users/KevinH-MS/following{/other_user}","gists_url":"https://api.github.com/users/KevinH-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinH-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinH-MS/subscriptions","organizations_url":"https://api.github.com/users/KevinH-MS/orgs","repos_url":"https://api.github.com/users/KevinH-MS/repos","events_url":"https://api.github.com/users/KevinH-MS/events{/privacy}","received_events_url":"https://api.github.com/users/KevinH-MS/received_events","type":"User","site_admin":false},"body":"1.  DkmClrValue.InspectionContext has been removed, so a separate instance needs to be passed to all the methods that need it.\r\n2.  DkmClrValue.EvaluateDebuggerDisplayString is now async.  In order to avoid complicated plumbing of completion routines through result expansion, I've moved the creation of DkmEvaluationResults from *Expansion to the ResultProvider.  Expansion now produces EvalResultDataItems that contain all the information necessary to produce DkmEvaluatoinResults in a single place, just before returning from the ResultProvider entry points.  New async plumbing/Exception handling is localized to the entry points.\r\n3.  There are several places that the API now allows passing format specifiers.  We do not intend to support those scenarios in C#/VB, so we will ignore them.","created_at":"2015-02-20T18:22:16Z","updated_at":"2015-02-24T01:15:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"164b3def1c40aa45b15800b4276385af013112f3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/727/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/727/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/727/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/2f3f97905e03042515847b47a4a0219be37f6303","head":{"label":"KevinH-MS:ResultProviderAPIChanges","ref":"ResultProviderAPIChanges","sha":"2f3f97905e03042515847b47a4a0219be37f6303","user":{"login":"KevinH-MS","id":6464209,"avatar_url":"https://avatars.githubusercontent.com/u/6464209?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinH-MS","html_url":"https://github.com/KevinH-MS","followers_url":"https://api.github.com/users/KevinH-MS/followers","following_url":"https://api.github.com/users/KevinH-MS/following{/other_user}","gists_url":"https://api.github.com/users/KevinH-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinH-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinH-MS/subscriptions","organizations_url":"https://api.github.com/users/KevinH-MS/orgs","repos_url":"https://api.github.com/users/KevinH-MS/repos","events_url":"https://api.github.com/users/KevinH-MS/events{/privacy}","received_events_url":"https://api.github.com/users/KevinH-MS/received_events","type":"User","site_admin":false},"repo":{"id":30554696,"name":"roslyn","full_name":"KevinH-MS/roslyn","owner":{"login":"KevinH-MS","id":6464209,"avatar_url":"https://avatars.githubusercontent.com/u/6464209?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinH-MS","html_url":"https://github.com/KevinH-MS","followers_url":"https://api.github.com/users/KevinH-MS/followers","following_url":"https://api.github.com/users/KevinH-MS/following{/other_user}","gists_url":"https://api.github.com/users/KevinH-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinH-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinH-MS/subscriptions","organizations_url":"https://api.github.com/users/KevinH-MS/orgs","repos_url":"https://api.github.com/users/KevinH-MS/repos","events_url":"https://api.github.com/users/KevinH-MS/events{/privacy}","received_events_url":"https://api.github.com/users/KevinH-MS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KevinH-MS/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/KevinH-MS/roslyn","forks_url":"https://api.github.com/repos/KevinH-MS/roslyn/forks","keys_url":"https://api.github.com/repos/KevinH-MS/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KevinH-MS/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KevinH-MS/roslyn/teams","hooks_url":"https://api.github.com/repos/KevinH-MS/roslyn/hooks","issue_events_url":"https://api.github.com/repos/KevinH-MS/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/KevinH-MS/roslyn/events","assignees_url":"https://api.github.com/repos/KevinH-MS/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/KevinH-MS/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/KevinH-MS/roslyn/tags","blobs_url":"https://api.github.com/repos/KevinH-MS/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KevinH-MS/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KevinH-MS/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/KevinH-MS/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KevinH-MS/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/KevinH-MS/roslyn/languages","stargazers_url":"https://api.github.com/repos/KevinH-MS/roslyn/stargazers","contributors_url":"https://api.github.com/repos/KevinH-MS/roslyn/contributors","subscribers_url":"https://api.github.com/repos/KevinH-MS/roslyn/subscribers","subscription_url":"https://api.github.com/repos/KevinH-MS/roslyn/subscription","commits_url":"https://api.github.com/repos/KevinH-MS/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/KevinH-MS/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/KevinH-MS/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/KevinH-MS/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/KevinH-MS/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/KevinH-MS/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KevinH-MS/roslyn/merges","archive_url":"https://api.github.com/repos/KevinH-MS/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KevinH-MS/roslyn/downloads","issues_url":"https://api.github.com/repos/KevinH-MS/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/KevinH-MS/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/KevinH-MS/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/KevinH-MS/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KevinH-MS/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/KevinH-MS/roslyn/releases{/id}","created_at":"2015-02-09T19:43:41Z","updated_at":"2015-02-17T00:50:10Z","pushed_at":"2015-02-24T01:14:22Z","git_url":"git://github.com/KevinH-MS/roslyn.git","ssh_url":"git@github.com:KevinH-MS/roslyn.git","clone_url":"https://github.com/KevinH-MS/roslyn.git","svn_url":"https://github.com/KevinH-MS/roslyn","homepage":"","size":51168,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"de93c18d33205c101fb401cfabf01a1469b6b61a","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-02-24T00:58:53Z","pushed_at":"2015-02-24T00:30:02Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":74942,"stargazers_count":1280,"watchers_count":1280,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":244,"mirror_url":null,"open_issues_count":436,"forks":244,"open_issues":436,"watchers":1280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/727"},"html":{"href":"https://github.com/dotnet/roslyn/pull/727"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/727"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/727/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/727/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/727/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/2f3f97905e03042515847b47a4a0219be37f6303"}}}}