{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/2678","labels_url":"https://api.github.com/repos/nodejs/node/issues/2678/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/2678/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/2678/events","html_url":"https://github.com/nodejs/node/pull/2678","id":104704958,"number":2678,"title":"src: increment NODE_MODULE_VERSION to 46","user":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars.githubusercontent.com/u/79017?v=3","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/v8","name":"v8","color":"0052cc"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/nodejs/node/milestones/10","html_url":"https://github.com/nodejs/node/milestones/4.0.0","labels_url":"https://api.github.com/repos/nodejs/node/milestones/10/labels","id":1232256,"number":10,"title":"4.0.0","description":"","creator":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":27,"state":"open","created_at":"2015-07-29T19:30:25Z","updated_at":"2015-09-03T23:07:57Z","due_on":"2015-09-03T04:00:00Z","closed_at":null},"comments":3,"created_at":"2015-09-03T14:16:11Z","updated_at":"2015-09-04T00:15:17Z","closed_at":"2015-09-03T21:17:23Z","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/2678","html_url":"https://github.com/nodejs/node/pull/2678","diff_url":"https://github.com/nodejs/node/pull/2678.diff","patch_url":"https://github.com/nodejs/node/pull/2678.patch"},"body":"Trying to get this into `vee-eight-4.5` before the PR to master.\r\n\r\n[V8 4.5 C++ API changes](https://docs.google.com/document/d/1g8JFi8T_oAE_7uAri7Njtig7fKaPDfotU6huOa1alds/edit?hl=en&forcehl=1) that warrant this:\r\n* Remove deprecated v8::Object::TurnOnAccessCheck API\r\n* Remove obsolete options in ScriptCompiler::CompileOptions\r\n* Remove v8::Private\r\n\r\nR=@rvagg, @nodejs/v8 "},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/137606348","html_url":"https://github.com/nodejs/node/pull/2678#issuecomment-137606348","issue_url":"https://api.github.com/repos/nodejs/node/issues/2678","id":137606348,"user":{"login":"rvagg","id":495647,"avatar_url":"https://avatars.githubusercontent.com/u/495647?v=3","gravatar_id":"","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"created_at":"2015-09-04T00:15:17Z","updated_at":"2015-09-04T00:15:17Z","body":"Hmmm, normally we'd do this as part of the stable release process rather than coupling it with landing V8. We're going to have to figure out how this fits in with our master/canary/unstable \"release\" process, I for one don't want to see this number incremented every time a `semver-major` lands in master."}}