{"action":"created","comment":{"url":"https://api.github.com/repos/uchicago-sg/caravel/pulls/comments/48405894","id":48405894,"diff_hunk":"@@ -33,11 +33,11 @@ class ListingForm(flask_wtf.Form):\n     \n \n class NewListingForm(ListingForm):\n-    principal = PrincipalField(\"Seller\",\n-        validators=[DataRequired(), OnlyValid()])\n+    principal = PrincipalField(\"Seller\", validators=[DataRequired()])","path":"caravel/controllers/forms.py","position":15,"original_position":15,"commit_id":"d457a3421f5067a1f88b2c12f64bc5c2f6dd4308","original_commit_id":"ee437aba6497197ad42e1a35804db3978a9d58b7","user":{"login":"georgeteo","id":12107160,"avatar_url":"https://avatars.githubusercontent.com/u/12107160?v=3","gravatar_id":"","url":"https://api.github.com/users/georgeteo","html_url":"https://github.com/georgeteo","followers_url":"https://api.github.com/users/georgeteo/followers","following_url":"https://api.github.com/users/georgeteo/following{/other_user}","gists_url":"https://api.github.com/users/georgeteo/gists{/gist_id}","starred_url":"https://api.github.com/users/georgeteo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgeteo/subscriptions","organizations_url":"https://api.github.com/users/georgeteo/orgs","repos_url":"https://api.github.com/users/georgeteo/repos","events_url":"https://api.github.com/users/georgeteo/events{/privacy}","received_events_url":"https://api.github.com/users/georgeteo/received_events","type":"User","site_admin":false},"body":"I see two issue with that:\r\n1. Would we reconcile the two? i.e., if someone uses Shibboleth to login as \"foo@uchicago.edu\" then later posts a listing as \"foo@uchicago.edu\" we need to reconcile them. \r\n2. Does not prevent a malicious attacker from impersonating a \"uchicago.edu\" email address. Or rather, it makes the question of authenticating users (person A is really person A) our problem instead of trying to abstract it out to Shibboleth. ","created_at":"2015-12-24T09:41:24Z","updated_at":"2015-12-24T09:41:24Z","html_url":"https://github.com/uchicago-sg/caravel/pull/193#discussion_r48405894","pull_request_url":"https://api.github.com/repos/uchicago-sg/caravel/pulls/193","_links":{"self":{"href":"https://api.github.com/repos/uchicago-sg/caravel/pulls/comments/48405894"},"html":{"href":"https://github.com/uchicago-sg/caravel/pull/193#discussion_r48405894"},"pull_request":{"href":"https://api.github.com/repos/uchicago-sg/caravel/pulls/193"}}},"pull_request":{"url":"https://api.github.com/repos/uchicago-sg/caravel/pulls/193","id":54145108,"html_url":"https://github.com/uchicago-sg/caravel/pull/193","diff_url":"https://github.com/uchicago-sg/caravel/pull/193.diff","patch_url":"https://github.com/uchicago-sg/caravel/pull/193.patch","issue_url":"https://api.github.com/repos/uchicago-sg/caravel/issues/193","number":193,"state":"open","locked":false,"title":"Add support for the edit button","user":{"login":"fatlotus","id":14364,"avatar_url":"https://avatars.githubusercontent.com/u/14364?v=3","gravatar_id":"","url":"https://api.github.com/users/fatlotus","html_url":"https://github.com/fatlotus","followers_url":"https://api.github.com/users/fatlotus/followers","following_url":"https://api.github.com/users/fatlotus/following{/other_user}","gists_url":"https://api.github.com/users/fatlotus/gists{/gist_id}","starred_url":"https://api.github.com/users/fatlotus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatlotus/subscriptions","organizations_url":"https://api.github.com/users/fatlotus/orgs","repos_url":"https://api.github.com/users/fatlotus/repos","events_url":"https://api.github.com/users/fatlotus/events{/privacy}","received_events_url":"https://api.github.com/users/fatlotus/received_events","type":"User","site_admin":false},"body":"Allows unauthenticated users to post and to edit listings.","created_at":"2015-12-18T20:15:02Z","updated_at":"2015-12-24T09:41:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5b63b6e3fa0a55a19216d537107fcc56baa32bf","assignee":{"login":"georgeteo","id":12107160,"avatar_url":"https://avatars.githubusercontent.com/u/12107160?v=3","gravatar_id":"","url":"https://api.github.com/users/georgeteo","html_url":"https://github.com/georgeteo","followers_url":"https://api.github.com/users/georgeteo/followers","following_url":"https://api.github.com/users/georgeteo/following{/other_user}","gists_url":"https://api.github.com/users/georgeteo/gists{/gist_id}","starred_url":"https://api.github.com/users/georgeteo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgeteo/subscriptions","organizations_url":"https://api.github.com/users/georgeteo/orgs","repos_url":"https://api.github.com/users/georgeteo/repos","events_url":"https://api.github.com/users/georgeteo/events{/privacy}","received_events_url":"https://api.github.com/users/georgeteo/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/uchicago-sg/caravel/pulls/193/commits","review_comments_url":"https://api.github.com/repos/uchicago-sg/caravel/pulls/193/comments","review_comment_url":"https://api.github.com/repos/uchicago-sg/caravel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uchicago-sg/caravel/issues/193/comments","statuses_url":"https://api.github.com/repos/uchicago-sg/caravel/statuses/d457a3421f5067a1f88b2c12f64bc5c2f6dd4308","head":{"label":"uchicago-sg:add-edit-button","ref":"add-edit-button","sha":"d457a3421f5067a1f88b2c12f64bc5c2f6dd4308","user":{"login":"uchicago-sg","id":7650247,"avatar_url":"https://avatars.githubusercontent.com/u/7650247?v=3","gravatar_id":"","url":"https://api.github.com/users/uchicago-sg","html_url":"https://github.com/uchicago-sg","followers_url":"https://api.github.com/users/uchicago-sg/followers","following_url":"https://api.github.com/users/uchicago-sg/following{/other_user}","gists_url":"https://api.github.com/users/uchicago-sg/gists{/gist_id}","starred_url":"https://api.github.com/users/uchicago-sg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uchicago-sg/subscriptions","organizations_url":"https://api.github.com/users/uchicago-sg/orgs","repos_url":"https://api.github.com/users/uchicago-sg/repos","events_url":"https://api.github.com/users/uchicago-sg/events{/privacy}","received_events_url":"https://api.github.com/users/uchicago-sg/received_events","type":"Organization","site_admin":false},"repo":{"id":41097022,"name":"caravel","full_name":"uchicago-sg/caravel","owner":{"login":"uchicago-sg","id":7650247,"avatar_url":"https://avatars.githubusercontent.com/u/7650247?v=3","gravatar_id":"","url":"https://api.github.com/users/uchicago-sg","html_url":"https://github.com/uchicago-sg","followers_url":"https://api.github.com/users/uchicago-sg/followers","following_url":"https://api.github.com/users/uchicago-sg/following{/other_user}","gists_url":"https://api.github.com/users/uchicago-sg/gists{/gist_id}","starred_url":"https://api.github.com/users/uchicago-sg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uchicago-sg/subscriptions","organizations_url":"https://api.github.com/users/uchicago-sg/orgs","repos_url":"https://api.github.com/users/uchicago-sg/repos","events_url":"https://api.github.com/users/uchicago-sg/events{/privacy}","received_events_url":"https://api.github.com/users/uchicago-sg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uchicago-sg/caravel","description":"A Re-Re-Refresh the UChicago Marketplace","fork":false,"url":"https://api.github.com/repos/uchicago-sg/caravel","forks_url":"https://api.github.com/repos/uchicago-sg/caravel/forks","keys_url":"https://api.github.com/repos/uchicago-sg/caravel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uchicago-sg/caravel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uchicago-sg/caravel/teams","hooks_url":"https://api.github.com/repos/uchicago-sg/caravel/hooks","issue_events_url":"https://api.github.com/repos/uchicago-sg/caravel/issues/events{/number}","events_url":"https://api.github.com/repos/uchicago-sg/caravel/events","assignees_url":"https://api.github.com/repos/uchicago-sg/caravel/assignees{/user}","branches_url":"https://api.github.com/repos/uchicago-sg/caravel/branches{/branch}","tags_url":"https://api.github.com/repos/uchicago-sg/caravel/tags","blobs_url":"https://api.github.com/repos/uchicago-sg/caravel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uchicago-sg/caravel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uchicago-sg/caravel/git/refs{/sha}","trees_url":"https://api.github.com/repos/uchicago-sg/caravel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uchicago-sg/caravel/statuses/{sha}","languages_url":"https://api.github.com/repos/uchicago-sg/caravel/languages","stargazers_url":"https://api.github.com/repos/uchicago-sg/caravel/stargazers","contributors_url":"https://api.github.com/repos/uchicago-sg/caravel/contributors","subscribers_url":"https://api.github.com/repos/uchicago-sg/caravel/subscribers","subscription_url":"https://api.github.com/repos/uchicago-sg/caravel/subscription","commits_url":"https://api.github.com/repos/uchicago-sg/caravel/commits{/sha}","git_commits_url":"https://api.github.com/repos/uchicago-sg/caravel/git/commits{/sha}","comments_url":"https://api.github.com/repos/uchicago-sg/caravel/comments{/number}","issue_comment_url":"https://api.github.com/repos/uchicago-sg/caravel/issues/comments{/number}","contents_url":"https://api.github.com/repos/uchicago-sg/caravel/contents/{+path}","compare_url":"https://api.github.com/repos/uchicago-sg/caravel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uchicago-sg/caravel/merges","archive_url":"https://api.github.com/repos/uchicago-sg/caravel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uchicago-sg/caravel/downloads","issues_url":"https://api.github.com/repos/uchicago-sg/caravel/issues{/number}","pulls_url":"https://api.github.com/repos/uchicago-sg/caravel/pulls{/number}","milestones_url":"https://api.github.com/repos/uchicago-sg/caravel/milestones{/number}","notifications_url":"https://api.github.com/repos/uchicago-sg/caravel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uchicago-sg/caravel/labels{/name}","releases_url":"https://api.github.com/repos/uchicago-sg/caravel/releases{/id}","created_at":"2015-08-20T13:25:36Z","updated_at":"2015-12-14T06:34:59Z","pushed_at":"2015-12-22T20:00:41Z","git_url":"git://github.com/uchicago-sg/caravel.git","ssh_url":"git@github.com:uchicago-sg/caravel.git","clone_url":"https://github.com/uchicago-sg/caravel.git","svn_url":"https://github.com/uchicago-sg/caravel","homepage":"https://marketplace.uchicago.edu","size":4264,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":11,"forks":3,"open_issues":11,"watchers":8,"default_branch":"master"}},"base":{"label":"uchicago-sg:master","ref":"master","sha":"1a472891f13b7194d6343fc51bb594a8fde34134","user":{"login":"uchicago-sg","id":7650247,"avatar_url":"https://avatars.githubusercontent.com/u/7650247?v=3","gravatar_id":"","url":"https://api.github.com/users/uchicago-sg","html_url":"https://github.com/uchicago-sg","followers_url":"https://api.github.com/users/uchicago-sg/followers","following_url":"https://api.github.com/users/uchicago-sg/following{/other_user}","gists_url":"https://api.github.com/users/uchicago-sg/gists{/gist_id}","starred_url":"https://api.github.com/users/uchicago-sg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uchicago-sg/subscriptions","organizations_url":"https://api.github.com/users/uchicago-sg/orgs","repos_url":"https://api.github.com/users/uchicago-sg/repos","events_url":"https://api.github.com/users/uchicago-sg/events{/privacy}","received_events_url":"https://api.github.com/users/uchicago-sg/received_events","type":"Organization","site_admin":false},"repo":{"id":41097022,"name":"caravel","full_name":"uchicago-sg/caravel","owner":{"login":"uchicago-sg","id":7650247,"avatar_url":"https://avatars.githubusercontent.com/u/7650247?v=3","gravatar_id":"","url":"https://api.github.com/users/uchicago-sg","html_url":"https://github.com/uchicago-sg","followers_url":"https://api.github.com/users/uchicago-sg/followers","following_url":"https://api.github.com/users/uchicago-sg/following{/other_user}","gists_url":"https://api.github.com/users/uchicago-sg/gists{/gist_id}","starred_url":"https://api.github.com/users/uchicago-sg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uchicago-sg/subscriptions","organizations_url":"https://api.github.com/users/uchicago-sg/orgs","repos_url":"https://api.github.com/users/uchicago-sg/repos","events_url":"https://api.github.com/users/uchicago-sg/events{/privacy}","received_events_url":"https://api.github.com/users/uchicago-sg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uchicago-sg/caravel","description":"A Re-Re-Refresh the UChicago Marketplace","fork":false,"url":"https://api.github.com/repos/uchicago-sg/caravel","forks_url":"https://api.github.com/repos/uchicago-sg/caravel/forks","keys_url":"https://api.github.com/repos/uchicago-sg/caravel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uchicago-sg/caravel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uchicago-sg/caravel/teams","hooks_url":"https://api.github.com/repos/uchicago-sg/caravel/hooks","issue_events_url":"https://api.github.com/repos/uchicago-sg/caravel/issues/events{/number}","events_url":"https://api.github.com/repos/uchicago-sg/caravel/events","assignees_url":"https://api.github.com/repos/uchicago-sg/caravel/assignees{/user}","branches_url":"https://api.github.com/repos/uchicago-sg/caravel/branches{/branch}","tags_url":"https://api.github.com/repos/uchicago-sg/caravel/tags","blobs_url":"https://api.github.com/repos/uchicago-sg/caravel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uchicago-sg/caravel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uchicago-sg/caravel/git/refs{/sha}","trees_url":"https://api.github.com/repos/uchicago-sg/caravel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uchicago-sg/caravel/statuses/{sha}","languages_url":"https://api.github.com/repos/uchicago-sg/caravel/languages","stargazers_url":"https://api.github.com/repos/uchicago-sg/caravel/stargazers","contributors_url":"https://api.github.com/repos/uchicago-sg/caravel/contributors","subscribers_url":"https://api.github.com/repos/uchicago-sg/caravel/subscribers","subscription_url":"https://api.github.com/repos/uchicago-sg/caravel/subscription","commits_url":"https://api.github.com/repos/uchicago-sg/caravel/commits{/sha}","git_commits_url":"https://api.github.com/repos/uchicago-sg/caravel/git/commits{/sha}","comments_url":"https://api.github.com/repos/uchicago-sg/caravel/comments{/number}","issue_comment_url":"https://api.github.com/repos/uchicago-sg/caravel/issues/comments{/number}","contents_url":"https://api.github.com/repos/uchicago-sg/caravel/contents/{+path}","compare_url":"https://api.github.com/repos/uchicago-sg/caravel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uchicago-sg/caravel/merges","archive_url":"https://api.github.com/repos/uchicago-sg/caravel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uchicago-sg/caravel/downloads","issues_url":"https://api.github.com/repos/uchicago-sg/caravel/issues{/number}","pulls_url":"https://api.github.com/repos/uchicago-sg/caravel/pulls{/number}","milestones_url":"https://api.github.com/repos/uchicago-sg/caravel/milestones{/number}","notifications_url":"https://api.github.com/repos/uchicago-sg/caravel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uchicago-sg/caravel/labels{/name}","releases_url":"https://api.github.com/repos/uchicago-sg/caravel/releases{/id}","created_at":"2015-08-20T13:25:36Z","updated_at":"2015-12-14T06:34:59Z","pushed_at":"2015-12-22T20:00:41Z","git_url":"git://github.com/uchicago-sg/caravel.git","ssh_url":"git@github.com:uchicago-sg/caravel.git","clone_url":"https://github.com/uchicago-sg/caravel.git","svn_url":"https://github.com/uchicago-sg/caravel","homepage":"https://marketplace.uchicago.edu","size":4264,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":11,"forks":3,"open_issues":11,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uchicago-sg/caravel/pulls/193"},"html":{"href":"https://github.com/uchicago-sg/caravel/pull/193"},"issue":{"href":"https://api.github.com/repos/uchicago-sg/caravel/issues/193"},"comments":{"href":"https://api.github.com/repos/uchicago-sg/caravel/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/uchicago-sg/caravel/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/uchicago-sg/caravel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uchicago-sg/caravel/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/uchicago-sg/caravel/statuses/d457a3421f5067a1f88b2c12f64bc5c2f6dd4308"}}}}