{"action":"created","comment":{"url":"https://api.github.com/repos/purescript/purescript/pulls/comments/42814885","id":42814885,"diff_hunk":"@@ -687,6 +691,11 @@ prettyPrintSingleError full level e = prettyPrintErrorMessage . positionHintsFir\n       paras [ line \"An exhaustivity check was abandoned due to too many possible cases.\"\n             , line \"You may want to decomposing your data types into smaller types.\"\n             ]\n+    renderSimpleErrorMessage (UnusedImport name) =\n+      line $ \"Unused import of module \" ++ runModuleName name\n+\n+    renderSimpleErrorMessage (UnusedExplicitImport name names) =\n+      line $ \"Unused identifiers in import of module \" ++ runModuleName name ++ \": \" ++ intercalate \", \" names","path":"src/Language/PureScript/Errors.hs","position":28,"original_position":28,"commit_id":"e8833b28a835c0220a5fe26cded27d7b770aad1b","original_commit_id":"e8833b28a835c0220a5fe26cded27d7b770aad1b","user":{"login":"paf31","id":630306,"avatar_url":"https://avatars.githubusercontent.com/u/630306?v=3","gravatar_id":"","url":"https://api.github.com/users/paf31","html_url":"https://github.com/paf31","followers_url":"https://api.github.com/users/paf31/followers","following_url":"https://api.github.com/users/paf31/following{/other_user}","gists_url":"https://api.github.com/users/paf31/gists{/gist_id}","starred_url":"https://api.github.com/users/paf31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paf31/subscriptions","organizations_url":"https://api.github.com/users/paf31/orgs","repos_url":"https://api.github.com/users/paf31/repos","events_url":"https://api.github.com/users/paf31/events{/privacy}","received_events_url":"https://api.github.com/users/paf31/received_events","type":"User","site_admin":false},"body":"I would prefer to put the names in an indented block with each name on its own line, to make use of the space.","created_at":"2015-10-22T22:31:51Z","updated_at":"2015-10-22T22:31:51Z","html_url":"https://github.com/purescript/purescript/pull/1545#discussion_r42814885","pull_request_url":"https://api.github.com/repos/purescript/purescript/pulls/1545","_links":{"self":{"href":"https://api.github.com/repos/purescript/purescript/pulls/comments/42814885"},"html":{"href":"https://github.com/purescript/purescript/pull/1545#discussion_r42814885"},"pull_request":{"href":"https://api.github.com/repos/purescript/purescript/pulls/1545"}}},"pull_request":{"url":"https://api.github.com/repos/purescript/purescript/pulls/1545","id":48381787,"html_url":"https://github.com/purescript/purescript/pull/1545","diff_url":"https://github.com/purescript/purescript/pull/1545.diff","patch_url":"https://github.com/purescript/purescript/pull/1545.patch","issue_url":"https://api.github.com/repos/purescript/purescript/issues/1545","number":1545,"state":"open","locked":false,"title":"Give warnings on unused imports (implicit and explicit)","user":{"login":"nwolverson","id":2770891,"avatar_url":"https://avatars.githubusercontent.com/u/2770891?v=3","gravatar_id":"","url":"https://api.github.com/users/nwolverson","html_url":"https://github.com/nwolverson","followers_url":"https://api.github.com/users/nwolverson/followers","following_url":"https://api.github.com/users/nwolverson/following{/other_user}","gists_url":"https://api.github.com/users/nwolverson/gists{/gist_id}","starred_url":"https://api.github.com/users/nwolverson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwolverson/subscriptions","organizations_url":"https://api.github.com/users/nwolverson/orgs","repos_url":"https://api.github.com/users/nwolverson/repos","events_url":"https://api.github.com/users/nwolverson/events{/privacy}","received_events_url":"https://api.github.com/users/nwolverson/received_events","type":"User","site_admin":false},"body":"WIP presented for comments/direction. Still to do:\r\n\r\n- [x] Exclude `Prim`!\r\n- [x] `bind` - anything else from desugaring?\r\n- [x] Qualified imports excluded (should be easy)\r\n- [x] Re-exports\r\n- [ ] Tests - is there a way to test warnings are generated?\r\n\r\nOriginally was more self-contained but working out usages is a little interesting.","created_at":"2015-10-21T20:15:59Z","updated_at":"2015-10-22T22:31:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"579237e034a8f0cc1097df445fb5fc820ff453da","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/purescript/purescript/pulls/1545/commits","review_comments_url":"https://api.github.com/repos/purescript/purescript/pulls/1545/comments","review_comment_url":"https://api.github.com/repos/purescript/purescript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/purescript/purescript/issues/1545/comments","statuses_url":"https://api.github.com/repos/purescript/purescript/statuses/e8833b28a835c0220a5fe26cded27d7b770aad1b","head":{"label":"nwolverson:unused-imports","ref":"unused-imports","sha":"e8833b28a835c0220a5fe26cded27d7b770aad1b","user":{"login":"nwolverson","id":2770891,"avatar_url":"https://avatars.githubusercontent.com/u/2770891?v=3","gravatar_id":"","url":"https://api.github.com/users/nwolverson","html_url":"https://github.com/nwolverson","followers_url":"https://api.github.com/users/nwolverson/followers","following_url":"https://api.github.com/users/nwolverson/following{/other_user}","gists_url":"https://api.github.com/users/nwolverson/gists{/gist_id}","starred_url":"https://api.github.com/users/nwolverson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwolverson/subscriptions","organizations_url":"https://api.github.com/users/nwolverson/orgs","repos_url":"https://api.github.com/users/nwolverson/repos","events_url":"https://api.github.com/users/nwolverson/events{/privacy}","received_events_url":"https://api.github.com/users/nwolverson/received_events","type":"User","site_admin":false},"repo":{"id":44700334,"name":"purescript","full_name":"nwolverson/purescript","owner":{"login":"nwolverson","id":2770891,"avatar_url":"https://avatars.githubusercontent.com/u/2770891?v=3","gravatar_id":"","url":"https://api.github.com/users/nwolverson","html_url":"https://github.com/nwolverson","followers_url":"https://api.github.com/users/nwolverson/followers","following_url":"https://api.github.com/users/nwolverson/following{/other_user}","gists_url":"https://api.github.com/users/nwolverson/gists{/gist_id}","starred_url":"https://api.github.com/users/nwolverson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwolverson/subscriptions","organizations_url":"https://api.github.com/users/nwolverson/orgs","repos_url":"https://api.github.com/users/nwolverson/repos","events_url":"https://api.github.com/users/nwolverson/events{/privacy}","received_events_url":"https://api.github.com/users/nwolverson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nwolverson/purescript","description":"A small strongly typed language that compiles to Javascript","fork":true,"url":"https://api.github.com/repos/nwolverson/purescript","forks_url":"https://api.github.com/repos/nwolverson/purescript/forks","keys_url":"https://api.github.com/repos/nwolverson/purescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nwolverson/purescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nwolverson/purescript/teams","hooks_url":"https://api.github.com/repos/nwolverson/purescript/hooks","issue_events_url":"https://api.github.com/repos/nwolverson/purescript/issues/events{/number}","events_url":"https://api.github.com/repos/nwolverson/purescript/events","assignees_url":"https://api.github.com/repos/nwolverson/purescript/assignees{/user}","branches_url":"https://api.github.com/repos/nwolverson/purescript/branches{/branch}","tags_url":"https://api.github.com/repos/nwolverson/purescript/tags","blobs_url":"https://api.github.com/repos/nwolverson/purescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nwolverson/purescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nwolverson/purescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/nwolverson/purescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nwolverson/purescript/statuses/{sha}","languages_url":"https://api.github.com/repos/nwolverson/purescript/languages","stargazers_url":"https://api.github.com/repos/nwolverson/purescript/stargazers","contributors_url":"https://api.github.com/repos/nwolverson/purescript/contributors","subscribers_url":"https://api.github.com/repos/nwolverson/purescript/subscribers","subscription_url":"https://api.github.com/repos/nwolverson/purescript/subscription","commits_url":"https://api.github.com/repos/nwolverson/purescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/nwolverson/purescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/nwolverson/purescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/nwolverson/purescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/nwolverson/purescript/contents/{+path}","compare_url":"https://api.github.com/repos/nwolverson/purescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nwolverson/purescript/merges","archive_url":"https://api.github.com/repos/nwolverson/purescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nwolverson/purescript/downloads","issues_url":"https://api.github.com/repos/nwolverson/purescript/issues{/number}","pulls_url":"https://api.github.com/repos/nwolverson/purescript/pulls{/number}","milestones_url":"https://api.github.com/repos/nwolverson/purescript/milestones{/number}","notifications_url":"https://api.github.com/repos/nwolverson/purescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nwolverson/purescript/labels{/name}","releases_url":"https://api.github.com/repos/nwolverson/purescript/releases{/id}","created_at":"2015-10-21T19:50:16Z","updated_at":"2015-10-21T19:50:17Z","pushed_at":"2015-10-22T22:15:39Z","git_url":"git://github.com/nwolverson/purescript.git","ssh_url":"git@github.com:nwolverson/purescript.git","clone_url":"https://github.com/nwolverson/purescript.git","svn_url":"https://github.com/nwolverson/purescript","homepage":"http://purescript.org","size":13175,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"purescript:master","ref":"master","sha":"8178604c9350821078c4b701f6f3763a3395d8e8","user":{"login":"purescript","id":6556677,"avatar_url":"https://avatars.githubusercontent.com/u/6556677?v=3","gravatar_id":"","url":"https://api.github.com/users/purescript","html_url":"https://github.com/purescript","followers_url":"https://api.github.com/users/purescript/followers","following_url":"https://api.github.com/users/purescript/following{/other_user}","gists_url":"https://api.github.com/users/purescript/gists{/gist_id}","starred_url":"https://api.github.com/users/purescript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purescript/subscriptions","organizations_url":"https://api.github.com/users/purescript/orgs","repos_url":"https://api.github.com/users/purescript/repos","events_url":"https://api.github.com/users/purescript/events{/privacy}","received_events_url":"https://api.github.com/users/purescript/received_events","type":"Organization","site_admin":false},"repo":{"id":13206906,"name":"purescript","full_name":"purescript/purescript","owner":{"login":"purescript","id":6556677,"avatar_url":"https://avatars.githubusercontent.com/u/6556677?v=3","gravatar_id":"","url":"https://api.github.com/users/purescript","html_url":"https://github.com/purescript","followers_url":"https://api.github.com/users/purescript/followers","following_url":"https://api.github.com/users/purescript/following{/other_user}","gists_url":"https://api.github.com/users/purescript/gists{/gist_id}","starred_url":"https://api.github.com/users/purescript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purescript/subscriptions","organizations_url":"https://api.github.com/users/purescript/orgs","repos_url":"https://api.github.com/users/purescript/repos","events_url":"https://api.github.com/users/purescript/events{/privacy}","received_events_url":"https://api.github.com/users/purescript/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/purescript/purescript","description":"A small strongly typed language that compiles to Javascript","fork":false,"url":"https://api.github.com/repos/purescript/purescript","forks_url":"https://api.github.com/repos/purescript/purescript/forks","keys_url":"https://api.github.com/repos/purescript/purescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/purescript/purescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/purescript/purescript/teams","hooks_url":"https://api.github.com/repos/purescript/purescript/hooks","issue_events_url":"https://api.github.com/repos/purescript/purescript/issues/events{/number}","events_url":"https://api.github.com/repos/purescript/purescript/events","assignees_url":"https://api.github.com/repos/purescript/purescript/assignees{/user}","branches_url":"https://api.github.com/repos/purescript/purescript/branches{/branch}","tags_url":"https://api.github.com/repos/purescript/purescript/tags","blobs_url":"https://api.github.com/repos/purescript/purescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/purescript/purescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/purescript/purescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/purescript/purescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/purescript/purescript/statuses/{sha}","languages_url":"https://api.github.com/repos/purescript/purescript/languages","stargazers_url":"https://api.github.com/repos/purescript/purescript/stargazers","contributors_url":"https://api.github.com/repos/purescript/purescript/contributors","subscribers_url":"https://api.github.com/repos/purescript/purescript/subscribers","subscription_url":"https://api.github.com/repos/purescript/purescript/subscription","commits_url":"https://api.github.com/repos/purescript/purescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/purescript/purescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/purescript/purescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/purescript/purescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/purescript/purescript/contents/{+path}","compare_url":"https://api.github.com/repos/purescript/purescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/purescript/purescript/merges","archive_url":"https://api.github.com/repos/purescript/purescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/purescript/purescript/downloads","issues_url":"https://api.github.com/repos/purescript/purescript/issues{/number}","pulls_url":"https://api.github.com/repos/purescript/purescript/pulls{/number}","milestones_url":"https://api.github.com/repos/purescript/purescript/milestones{/number}","notifications_url":"https://api.github.com/repos/purescript/purescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/purescript/purescript/labels{/name}","releases_url":"https://api.github.com/repos/purescript/purescript/releases{/id}","created_at":"2013-09-30T05:29:23Z","updated_at":"2015-10-22T16:17:51Z","pushed_at":"2015-10-22T22:15:39Z","git_url":"git://github.com/purescript/purescript.git","ssh_url":"git@github.com:purescript/purescript.git","clone_url":"https://github.com/purescript/purescript.git","svn_url":"https://github.com/purescript/purescript","homepage":"http://purescript.org","size":13175,"stargazers_count":1856,"watchers_count":1856,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"open_issues_count":193,"forks":165,"open_issues":193,"watchers":1856,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/purescript/purescript/pulls/1545"},"html":{"href":"https://github.com/purescript/purescript/pull/1545"},"issue":{"href":"https://api.github.com/repos/purescript/purescript/issues/1545"},"comments":{"href":"https://api.github.com/repos/purescript/purescript/issues/1545/comments"},"review_comments":{"href":"https://api.github.com/repos/purescript/purescript/pulls/1545/comments"},"review_comment":{"href":"https://api.github.com/repos/purescript/purescript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/purescript/purescript/pulls/1545/commits"},"statuses":{"href":"https://api.github.com/repos/purescript/purescript/statuses/e8833b28a835c0220a5fe26cded27d7b770aad1b"}}}}