{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/issues/225","labels_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/issues/225/labels{/name}","comments_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/issues/225/comments","events_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/issues/225/events","html_url":"https://github.com/JuliaStats/TimeSeries.jl/issues/225","id":114419038,"number":225,"title":"Value types for percentchange","user":{"login":"GordStephen","id":2753264,"avatar_url":"https://avatars.githubusercontent.com/u/2753264?v=3","gravatar_id":"","url":"https://api.github.com/users/GordStephen","html_url":"https://github.com/GordStephen","followers_url":"https://api.github.com/users/GordStephen/followers","following_url":"https://api.github.com/users/GordStephen/following{/other_user}","gists_url":"https://api.github.com/users/GordStephen/gists{/gist_id}","starred_url":"https://api.github.com/users/GordStephen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordStephen/subscriptions","organizations_url":"https://api.github.com/users/GordStephen/orgs","repos_url":"https://api.github.com/users/GordStephen/repos","events_url":"https://api.github.com/users/GordStephen/events{/privacy}","received_events_url":"https://api.github.com/users/GordStephen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-31T16:15:07Z","updated_at":"2015-10-31T18:05:56Z","closed_at":null,"body":"The various merge methods have been implemented to dispatch on a value type (e.g. `merge(ta1, ta2, Val{:left})`) - should `percentchange` follow this pattern?\r\n\r\nFor example, the API would change from\r\n\r\n```julia\r\npercentchange(ta, method=\"log\")\r\n```\r\n\r\nto \r\n\r\n```julia\r\npercentchange(ta, Val{:log})\r\n```\r\n\r\nThis would avoid the need to evaluate the method kwarg at runtime and clean up the source.\r\n\r\nI actually already implemented this in https://github.com/JuliaStats/TimeSeries.jl/commit/7d9398f6ecc1fc39e69983cd50013438dc1b72a7#diff-fcecd393d0e9b533ae6e5f1143cded5bR150, but can switch it back if the preference is to stick to the status quo."},"comment":{"url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/issues/comments/152756989","html_url":"https://github.com/JuliaStats/TimeSeries.jl/issues/225#issuecomment-152756989","issue_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/issues/225","id":152756989,"user":{"login":"milktrader","id":324836,"avatar_url":"https://avatars.githubusercontent.com/u/324836?v=3","gravatar_id":"","url":"https://api.github.com/users/milktrader","html_url":"https://github.com/milktrader","followers_url":"https://api.github.com/users/milktrader/followers","following_url":"https://api.github.com/users/milktrader/following{/other_user}","gists_url":"https://api.github.com/users/milktrader/gists{/gist_id}","starred_url":"https://api.github.com/users/milktrader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milktrader/subscriptions","organizations_url":"https://api.github.com/users/milktrader/orgs","repos_url":"https://api.github.com/users/milktrader/repos","events_url":"https://api.github.com/users/milktrader/events{/privacy}","received_events_url":"https://api.github.com/users/milktrader/received_events","type":"User","site_admin":false},"created_at":"2015-10-31T18:05:56Z","updated_at":"2015-10-31T18:05:56Z","body":"Hmm, I need to think about this. You're saying this new interface should be faster?\r\n\r\nI need to read up on what this `Val{:log}` means. "}}