{"action":"opened","number":81,"pull_request":{"url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls/81","id":40592726,"html_url":"https://github.com/mgbellemare/Arcade-Learning-Environment/pull/81","diff_url":"https://github.com/mgbellemare/Arcade-Learning-Environment/pull/81.diff","patch_url":"https://github.com/mgbellemare/Arcade-Learning-Environment/pull/81.patch","issue_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/issues/81","number":81,"state":"open","locked":false,"title":"Change ptrs fix segfault","user":{"login":"DoctorTeeth","id":200533,"avatar_url":"https://avatars.githubusercontent.com/u/200533?v=3","gravatar_id":"","url":"https://api.github.com/users/DoctorTeeth","html_url":"https://github.com/DoctorTeeth","followers_url":"https://api.github.com/users/DoctorTeeth/followers","following_url":"https://api.github.com/users/DoctorTeeth/following{/other_user}","gists_url":"https://api.github.com/users/DoctorTeeth/gists{/gist_id}","starred_url":"https://api.github.com/users/DoctorTeeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoctorTeeth/subscriptions","organizations_url":"https://api.github.com/users/DoctorTeeth/orgs","repos_url":"https://api.github.com/users/DoctorTeeth/repos","events_url":"https://api.github.com/users/DoctorTeeth/events{/privacy}","received_events_url":"https://api.github.com/users/DoctorTeeth/received_events","type":"User","site_admin":false},"body":"This does the following 2 things. \r\n\r\n1. Replace auto_ptr with unique_ptr.\r\nI think it's a good idea to do this now because:\r\na) auto_ptr has been deprecated, and will actually be deleted in the future, according to Herb Sutter: \r\nhttp://herbsutter.com/2014/11/24/updates-to-my-trip-report/\r\n\r\nb) Right now it's still a drop-in replacement. unique_ptr has move-only semantics, but you're not doing any copying of auto_ptrs right now. In the future, if you try to do copying of ptrs, the compiler will stop you. If you then still want to do copying, you can switch to shared_ptr. \r\n\r\n2. Instead of segfaulting if someone tries to e.g. get the list of legal actions before a ROM has been loaded, just exit with a message. I think that this is a good change because \r\na) segfaulting is always bad\r\nb) this change would have saved me 5-10 minutes of debugging time, so I expect a similar thing might be true for other people.\r\n","created_at":"2015-07-22T17:54:06Z","updated_at":"2015-07-22T17:54:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls/81/commits","review_comments_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls/81/comments","review_comment_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/issues/81/comments","statuses_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/statuses/9f9789e58bb4d804a86d9ee50e3355d7ef07e8b6","head":{"label":"DoctorTeeth:change-ptrs-fix-segfault","ref":"change-ptrs-fix-segfault","sha":"9f9789e58bb4d804a86d9ee50e3355d7ef07e8b6","user":{"login":"DoctorTeeth","id":200533,"avatar_url":"https://avatars.githubusercontent.com/u/200533?v=3","gravatar_id":"","url":"https://api.github.com/users/DoctorTeeth","html_url":"https://github.com/DoctorTeeth","followers_url":"https://api.github.com/users/DoctorTeeth/followers","following_url":"https://api.github.com/users/DoctorTeeth/following{/other_user}","gists_url":"https://api.github.com/users/DoctorTeeth/gists{/gist_id}","starred_url":"https://api.github.com/users/DoctorTeeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoctorTeeth/subscriptions","organizations_url":"https://api.github.com/users/DoctorTeeth/orgs","repos_url":"https://api.github.com/users/DoctorTeeth/repos","events_url":"https://api.github.com/users/DoctorTeeth/events{/privacy}","received_events_url":"https://api.github.com/users/DoctorTeeth/received_events","type":"User","site_admin":false},"repo":{"id":38389561,"name":"Arcade-Learning-Environment","full_name":"DoctorTeeth/Arcade-Learning-Environment","owner":{"login":"DoctorTeeth","id":200533,"avatar_url":"https://avatars.githubusercontent.com/u/200533?v=3","gravatar_id":"","url":"https://api.github.com/users/DoctorTeeth","html_url":"https://github.com/DoctorTeeth","followers_url":"https://api.github.com/users/DoctorTeeth/followers","following_url":"https://api.github.com/users/DoctorTeeth/following{/other_user}","gists_url":"https://api.github.com/users/DoctorTeeth/gists{/gist_id}","starred_url":"https://api.github.com/users/DoctorTeeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoctorTeeth/subscriptions","organizations_url":"https://api.github.com/users/DoctorTeeth/orgs","repos_url":"https://api.github.com/users/DoctorTeeth/repos","events_url":"https://api.github.com/users/DoctorTeeth/events{/privacy}","received_events_url":"https://api.github.com/users/DoctorTeeth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DoctorTeeth/Arcade-Learning-Environment","description":"The Arcade Learning Environment (ALE) -- a platform for AI research.","fork":true,"url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment","forks_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/forks","keys_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/teams","hooks_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/hooks","issue_events_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/issues/events{/number}","events_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/events","assignees_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/assignees{/user}","branches_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/branches{/branch}","tags_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/tags","blobs_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/statuses/{sha}","languages_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/languages","stargazers_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/stargazers","contributors_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/contributors","subscribers_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/subscribers","subscription_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/subscription","commits_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/contents/{+path}","compare_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/merges","archive_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/downloads","issues_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/issues{/number}","pulls_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/pulls{/number}","milestones_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/milestones{/number}","notifications_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/labels{/name}","releases_url":"https://api.github.com/repos/DoctorTeeth/Arcade-Learning-Environment/releases{/id}","created_at":"2015-07-01T19:03:45Z","updated_at":"2015-07-01T19:03:46Z","pushed_at":"2015-07-22T17:34:28Z","git_url":"git://github.com/DoctorTeeth/Arcade-Learning-Environment.git","ssh_url":"git@github.com:DoctorTeeth/Arcade-Learning-Environment.git","clone_url":"https://github.com/DoctorTeeth/Arcade-Learning-Environment.git","svn_url":"https://github.com/DoctorTeeth/Arcade-Learning-Environment","homepage":null,"size":4561,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mgbellemare:master","ref":"master","sha":"ff2995407e42b1f359478604d01177425065a5b4","user":{"login":"mgbellemare","id":2350286,"avatar_url":"https://avatars.githubusercontent.com/u/2350286?v=3","gravatar_id":"","url":"https://api.github.com/users/mgbellemare","html_url":"https://github.com/mgbellemare","followers_url":"https://api.github.com/users/mgbellemare/followers","following_url":"https://api.github.com/users/mgbellemare/following{/other_user}","gists_url":"https://api.github.com/users/mgbellemare/gists{/gist_id}","starred_url":"https://api.github.com/users/mgbellemare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgbellemare/subscriptions","organizations_url":"https://api.github.com/users/mgbellemare/orgs","repos_url":"https://api.github.com/users/mgbellemare/repos","events_url":"https://api.github.com/users/mgbellemare/events{/privacy}","received_events_url":"https://api.github.com/users/mgbellemare/received_events","type":"User","site_admin":false},"repo":{"id":5816654,"name":"Arcade-Learning-Environment","full_name":"mgbellemare/Arcade-Learning-Environment","owner":{"login":"mgbellemare","id":2350286,"avatar_url":"https://avatars.githubusercontent.com/u/2350286?v=3","gravatar_id":"","url":"https://api.github.com/users/mgbellemare","html_url":"https://github.com/mgbellemare","followers_url":"https://api.github.com/users/mgbellemare/followers","following_url":"https://api.github.com/users/mgbellemare/following{/other_user}","gists_url":"https://api.github.com/users/mgbellemare/gists{/gist_id}","starred_url":"https://api.github.com/users/mgbellemare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgbellemare/subscriptions","organizations_url":"https://api.github.com/users/mgbellemare/orgs","repos_url":"https://api.github.com/users/mgbellemare/repos","events_url":"https://api.github.com/users/mgbellemare/events{/privacy}","received_events_url":"https://api.github.com/users/mgbellemare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgbellemare/Arcade-Learning-Environment","description":"The Arcade Learning Environment (ALE) -- a platform for AI research.","fork":false,"url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment","forks_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/forks","keys_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/teams","hooks_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/hooks","issue_events_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/issues/events{/number}","events_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/events","assignees_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/assignees{/user}","branches_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/branches{/branch}","tags_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/tags","blobs_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/statuses/{sha}","languages_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/languages","stargazers_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/stargazers","contributors_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/contributors","subscribers_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/subscribers","subscription_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/subscription","commits_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/contents/{+path}","compare_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/merges","archive_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/downloads","issues_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/issues{/number}","pulls_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls{/number}","milestones_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/milestones{/number}","notifications_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/labels{/name}","releases_url":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/releases{/id}","created_at":"2012-09-15T01:42:13Z","updated_at":"2015-07-18T18:55:16Z","pushed_at":"2015-07-18T15:55:37Z","git_url":"git://github.com/mgbellemare/Arcade-Learning-Environment.git","ssh_url":"git@github.com:mgbellemare/Arcade-Learning-Environment.git","clone_url":"https://github.com/mgbellemare/Arcade-Learning-Environment.git","svn_url":"https://github.com/mgbellemare/Arcade-Learning-Environment","homepage":null,"size":5174,"stargazers_count":66,"watchers_count":66,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":9,"forks":36,"open_issues":9,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls/81"},"html":{"href":"https://github.com/mgbellemare/Arcade-Learning-Environment/pull/81"},"issue":{"href":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/issues/81"},"comments":{"href":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/mgbellemare/Arcade-Learning-Environment/statuses/9f9789e58bb4d804a86d9ee50e3355d7ef07e8b6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":21,"deletions":18,"changed_files":6}}