{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments/42246937","id":42246937,"diff_hunk":"@@ -36,12 +36,9 @@ PIDFile::PIDFile(const std::string& dir_path_)\n                                    + \"' is not a directory\" };\n         }\n     } else {\n-        LOG_INFO(\"Creating PID directory '%1%'\", dir_path);\n-        try {\n-            fs::create_directories(dir_path);\n-        } catch (const fs::filesystem_error& e) {\n-            throw PIDFile::Error { e.what() };\n-        }\n+        std::string err_msg { \"'\" + dir_path + \"' doesn't exist. Cannot create PID file\" };\n+        LOG_ERROR(err_msg);","path":"lib/src/util/posix/pid_file.cc","position":11,"original_position":11,"commit_id":"33bfcb80379b9e75820469e9c9fa9b605824c4e6","original_commit_id":"33bfcb80379b9e75820469e9c9fa9b605824c4e6","user":{"login":"parisiale","id":7150922,"avatar_url":"https://avatars.githubusercontent.com/u/7150922?v=3","gravatar_id":"","url":"https://api.github.com/users/parisiale","html_url":"https://github.com/parisiale","followers_url":"https://api.github.com/users/parisiale/followers","following_url":"https://api.github.com/users/parisiale/following{/other_user}","gists_url":"https://api.github.com/users/parisiale/gists{/gist_id}","starred_url":"https://api.github.com/users/parisiale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parisiale/subscriptions","organizations_url":"https://api.github.com/users/parisiale/orgs","repos_url":"https://api.github.com/users/parisiale/repos","events_url":"https://api.github.com/users/parisiale/events{/privacy}","received_events_url":"https://api.github.com/users/parisiale/received_events","type":"User","site_admin":false},"body":"Do we need to log here? I think it will be logged again in main.exe.","created_at":"2015-10-16T14:16:50Z","updated_at":"2015-10-16T14:16:50Z","html_url":"https://github.com/puppetlabs/pxp-agent/pull/152#discussion_r42246937","pull_request_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/152","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments/42246937"},"html":{"href":"https://github.com/puppetlabs/pxp-agent/pull/152#discussion_r42246937"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/152","id":47903105,"html_url":"https://github.com/puppetlabs/pxp-agent/pull/152","diff_url":"https://github.com/puppetlabs/pxp-agent/pull/152.diff","patch_url":"https://github.com/puppetlabs/pxp-agent/pull/152.patch","issue_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/152","number":152,"state":"open","locked":false,"title":"(PCP-77) Don't create directories ","user":{"login":"ploubser","id":282369,"avatar_url":"https://avatars.githubusercontent.com/u/282369?v=3","gravatar_id":"","url":"https://api.github.com/users/ploubser","html_url":"https://github.com/ploubser","followers_url":"https://api.github.com/users/ploubser/followers","following_url":"https://api.github.com/users/ploubser/following{/other_user}","gists_url":"https://api.github.com/users/ploubser/gists{/gist_id}","starred_url":"https://api.github.com/users/ploubser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ploubser/subscriptions","organizations_url":"https://api.github.com/users/ploubser/orgs","repos_url":"https://api.github.com/users/ploubser/repos","events_url":"https://api.github.com/users/ploubser/events{/privacy}","received_events_url":"https://api.github.com/users/ploubser/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-16T12:17:29Z","updated_at":"2015-10-16T14:16:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"963d53f85c753ca81fcaf7840085b8633bf5c54e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/152/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/152/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/152/comments","statuses_url":"https://api.github.com/repos/puppetlabs/pxp-agent/statuses/33bfcb80379b9e75820469e9c9fa9b605824c4e6","head":{"label":"ploubser:PCP-77","ref":"PCP-77","sha":"33bfcb80379b9e75820469e9c9fa9b605824c4e6","user":{"login":"ploubser","id":282369,"avatar_url":"https://avatars.githubusercontent.com/u/282369?v=3","gravatar_id":"","url":"https://api.github.com/users/ploubser","html_url":"https://github.com/ploubser","followers_url":"https://api.github.com/users/ploubser/followers","following_url":"https://api.github.com/users/ploubser/following{/other_user}","gists_url":"https://api.github.com/users/ploubser/gists{/gist_id}","starred_url":"https://api.github.com/users/ploubser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ploubser/subscriptions","organizations_url":"https://api.github.com/users/ploubser/orgs","repos_url":"https://api.github.com/users/ploubser/repos","events_url":"https://api.github.com/users/ploubser/events{/privacy}","received_events_url":"https://api.github.com/users/ploubser/received_events","type":"User","site_admin":false},"repo":{"id":43750470,"name":"pxp-agent","full_name":"ploubser/pxp-agent","owner":{"login":"ploubser","id":282369,"avatar_url":"https://avatars.githubusercontent.com/u/282369?v=3","gravatar_id":"","url":"https://api.github.com/users/ploubser","html_url":"https://github.com/ploubser","followers_url":"https://api.github.com/users/ploubser/followers","following_url":"https://api.github.com/users/ploubser/following{/other_user}","gists_url":"https://api.github.com/users/ploubser/gists{/gist_id}","starred_url":"https://api.github.com/users/ploubser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ploubser/subscriptions","organizations_url":"https://api.github.com/users/ploubser/orgs","repos_url":"https://api.github.com/users/ploubser/repos","events_url":"https://api.github.com/users/ploubser/events{/privacy}","received_events_url":"https://api.github.com/users/ploubser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ploubser/pxp-agent","description":"Puppet eXecution Protocol Agent","fork":true,"url":"https://api.github.com/repos/ploubser/pxp-agent","forks_url":"https://api.github.com/repos/ploubser/pxp-agent/forks","keys_url":"https://api.github.com/repos/ploubser/pxp-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ploubser/pxp-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ploubser/pxp-agent/teams","hooks_url":"https://api.github.com/repos/ploubser/pxp-agent/hooks","issue_events_url":"https://api.github.com/repos/ploubser/pxp-agent/issues/events{/number}","events_url":"https://api.github.com/repos/ploubser/pxp-agent/events","assignees_url":"https://api.github.com/repos/ploubser/pxp-agent/assignees{/user}","branches_url":"https://api.github.com/repos/ploubser/pxp-agent/branches{/branch}","tags_url":"https://api.github.com/repos/ploubser/pxp-agent/tags","blobs_url":"https://api.github.com/repos/ploubser/pxp-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ploubser/pxp-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ploubser/pxp-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/ploubser/pxp-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ploubser/pxp-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/ploubser/pxp-agent/languages","stargazers_url":"https://api.github.com/repos/ploubser/pxp-agent/stargazers","contributors_url":"https://api.github.com/repos/ploubser/pxp-agent/contributors","subscribers_url":"https://api.github.com/repos/ploubser/pxp-agent/subscribers","subscription_url":"https://api.github.com/repos/ploubser/pxp-agent/subscription","commits_url":"https://api.github.com/repos/ploubser/pxp-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/ploubser/pxp-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/ploubser/pxp-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/ploubser/pxp-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/ploubser/pxp-agent/contents/{+path}","compare_url":"https://api.github.com/repos/ploubser/pxp-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ploubser/pxp-agent/merges","archive_url":"https://api.github.com/repos/ploubser/pxp-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ploubser/pxp-agent/downloads","issues_url":"https://api.github.com/repos/ploubser/pxp-agent/issues{/number}","pulls_url":"https://api.github.com/repos/ploubser/pxp-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/ploubser/pxp-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/ploubser/pxp-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ploubser/pxp-agent/labels{/name}","releases_url":"https://api.github.com/repos/ploubser/pxp-agent/releases{/id}","created_at":"2015-10-06T12:53:36Z","updated_at":"2015-10-06T12:53:37Z","pushed_at":"2015-10-16T14:09:59Z","git_url":"git://github.com/ploubser/pxp-agent.git","ssh_url":"git@github.com:ploubser/pxp-agent.git","clone_url":"https://github.com/ploubser/pxp-agent.git","svn_url":"https://github.com/ploubser/pxp-agent","homepage":"","size":8533,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"89b34c9a3ab695793d5e209d9fef45211b7918d7","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":23231786,"name":"pxp-agent","full_name":"puppetlabs/pxp-agent","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/pxp-agent","description":"PCP eXecution Protocol Agent","fork":false,"url":"https://api.github.com/repos/puppetlabs/pxp-agent","forks_url":"https://api.github.com/repos/puppetlabs/pxp-agent/forks","keys_url":"https://api.github.com/repos/puppetlabs/pxp-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/pxp-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/pxp-agent/teams","hooks_url":"https://api.github.com/repos/puppetlabs/pxp-agent/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/pxp-agent/events","assignees_url":"https://api.github.com/repos/puppetlabs/pxp-agent/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/pxp-agent/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/pxp-agent/tags","blobs_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/pxp-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/pxp-agent/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/pxp-agent/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/pxp-agent/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/pxp-agent/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/pxp-agent/subscription","commits_url":"https://api.github.com/repos/puppetlabs/pxp-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/pxp-agent/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/pxp-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/pxp-agent/merges","archive_url":"https://api.github.com/repos/puppetlabs/pxp-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/pxp-agent/downloads","issues_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/pxp-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/pxp-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/pxp-agent/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/pxp-agent/releases{/id}","created_at":"2014-08-22T16:25:01Z","updated_at":"2015-10-14T17:31:50Z","pushed_at":"2015-10-16T14:10:34Z","git_url":"git://github.com/puppetlabs/pxp-agent.git","ssh_url":"git@github.com:puppetlabs/pxp-agent.git","clone_url":"https://github.com/puppetlabs/pxp-agent.git","svn_url":"https://github.com/puppetlabs/pxp-agent","homepage":"","size":9828,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":3,"forks":8,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/152"},"html":{"href":"https://github.com/puppetlabs/pxp-agent/pull/152"},"issue":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/152"},"comments":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/statuses/33bfcb80379b9e75820469e9c9fa9b605824c4e6"}}}}