{"action":"opened","number":245,"pull_request":{"url":"https://api.github.com/repos/SpongePowered/Sponge/pulls/245","id":33607751,"html_url":"https://github.com/SpongePowered/Sponge/pull/245","diff_url":"https://github.com/SpongePowered/Sponge/pull/245.diff","patch_url":"https://github.com/SpongePowered/Sponge/pull/245.patch","issue_url":"https://api.github.com/repos/SpongePowered/Sponge/issues/245","number":245,"state":"open","locked":false,"title":"Unify Forge and Vanilla implementation v3","user":{"login":"Minecrell","id":3035868,"avatar_url":"https://avatars.githubusercontent.com/u/3035868?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecrell","html_url":"https://github.com/Minecrell","followers_url":"https://api.github.com/users/Minecrell/followers","following_url":"https://api.github.com/users/Minecrell/following{/other_user}","gists_url":"https://api.github.com/users/Minecrell/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecrell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecrell/subscriptions","organizations_url":"https://api.github.com/users/Minecrell/orgs","repos_url":"https://api.github.com/users/Minecrell/repos","events_url":"https://api.github.com/users/Minecrell/events{/privacy}","received_events_url":"https://api.github.com/users/Minecrell/received_events","type":"User","site_admin":false},"body":"See #232 for more information.\r\n\r\nThis is pretty much complete, and moves most code into the Common module which is currently still in the [`common2`](https://github.com/SpongePowered/Sponge/tree/common2) branch, but is going to be in a dedicated repository when merged.\r\n\r\nA lot of mixins are currently Forge-only because they depend on Forge in one or another way, we can probably go through them later and separate some shared things into additional mixins.\r\n\r\n#### TODO\r\n- [ ] Update to latest master\r\n- [ ] Fix a few Gradle bugs (wrong project name, Sponge version)\r\n\r\n@SpongePowered/developers Looking for feedback on this so we can get this merged in the next few days.","created_at":"2015-04-18T19:53:59Z","updated_at":"2015-04-18T19:54:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"Minecrell","id":3035868,"avatar_url":"https://avatars.githubusercontent.com/u/3035868?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecrell","html_url":"https://github.com/Minecrell","followers_url":"https://api.github.com/users/Minecrell/followers","following_url":"https://api.github.com/users/Minecrell/following{/other_user}","gists_url":"https://api.github.com/users/Minecrell/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecrell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecrell/subscriptions","organizations_url":"https://api.github.com/users/Minecrell/orgs","repos_url":"https://api.github.com/users/Minecrell/repos","events_url":"https://api.github.com/users/Minecrell/events{/privacy}","received_events_url":"https://api.github.com/users/Minecrell/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/SpongePowered/Sponge/pulls/245/commits","review_comments_url":"https://api.github.com/repos/SpongePowered/Sponge/pulls/245/comments","review_comment_url":"https://api.github.com/repos/SpongePowered/Sponge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpongePowered/Sponge/issues/245/comments","statuses_url":"https://api.github.com/repos/SpongePowered/Sponge/statuses/111b25611868ac901d7b684d65286ca226e28cbf","head":{"label":"SpongePowered:feature/unify2","ref":"feature/unify2","sha":"111b25611868ac901d7b684d65286ca226e28cbf","user":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":23774298,"name":"Sponge","full_name":"SpongePowered/Sponge","owner":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpongePowered/Sponge","description":"A Forge mod that implements SpongeAPI","fork":false,"url":"https://api.github.com/repos/SpongePowered/Sponge","forks_url":"https://api.github.com/repos/SpongePowered/Sponge/forks","keys_url":"https://api.github.com/repos/SpongePowered/Sponge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/Sponge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/Sponge/teams","hooks_url":"https://api.github.com/repos/SpongePowered/Sponge/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/Sponge/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/Sponge/events","assignees_url":"https://api.github.com/repos/SpongePowered/Sponge/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/Sponge/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/Sponge/tags","blobs_url":"https://api.github.com/repos/SpongePowered/Sponge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/Sponge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/Sponge/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/Sponge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/Sponge/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/Sponge/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/Sponge/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/Sponge/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/Sponge/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/Sponge/subscription","commits_url":"https://api.github.com/repos/SpongePowered/Sponge/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/Sponge/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/Sponge/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/Sponge/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpongePowered/Sponge/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/Sponge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/Sponge/merges","archive_url":"https://api.github.com/repos/SpongePowered/Sponge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/Sponge/downloads","issues_url":"https://api.github.com/repos/SpongePowered/Sponge/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/Sponge/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/Sponge/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/Sponge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/Sponge/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/Sponge/releases{/id}","created_at":"2014-09-08T00:01:33Z","updated_at":"2015-04-18T19:13:49Z","pushed_at":"2015-04-18T19:13:49Z","git_url":"git://github.com/SpongePowered/Sponge.git","ssh_url":"git@github.com:SpongePowered/Sponge.git","clone_url":"https://github.com/SpongePowered/Sponge.git","svn_url":"https://github.com/SpongePowered/Sponge","homepage":"http://www.spongepowered.org/","size":12902,"stargazers_count":771,"watchers_count":771,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":331,"mirror_url":null,"open_issues_count":25,"forks":331,"open_issues":25,"watchers":771,"default_branch":"master"}},"base":{"label":"SpongePowered:master","ref":"master","sha":"dc856493f44bab6cc7b2779de5e9362214bd39c6","user":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":23774298,"name":"Sponge","full_name":"SpongePowered/Sponge","owner":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpongePowered/Sponge","description":"A Forge mod that implements SpongeAPI","fork":false,"url":"https://api.github.com/repos/SpongePowered/Sponge","forks_url":"https://api.github.com/repos/SpongePowered/Sponge/forks","keys_url":"https://api.github.com/repos/SpongePowered/Sponge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/Sponge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/Sponge/teams","hooks_url":"https://api.github.com/repos/SpongePowered/Sponge/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/Sponge/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/Sponge/events","assignees_url":"https://api.github.com/repos/SpongePowered/Sponge/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/Sponge/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/Sponge/tags","blobs_url":"https://api.github.com/repos/SpongePowered/Sponge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/Sponge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/Sponge/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/Sponge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/Sponge/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/Sponge/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/Sponge/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/Sponge/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/Sponge/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/Sponge/subscription","commits_url":"https://api.github.com/repos/SpongePowered/Sponge/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/Sponge/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/Sponge/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/Sponge/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpongePowered/Sponge/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/Sponge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/Sponge/merges","archive_url":"https://api.github.com/repos/SpongePowered/Sponge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/Sponge/downloads","issues_url":"https://api.github.com/repos/SpongePowered/Sponge/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/Sponge/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/Sponge/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/Sponge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/Sponge/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/Sponge/releases{/id}","created_at":"2014-09-08T00:01:33Z","updated_at":"2015-04-18T19:13:49Z","pushed_at":"2015-04-18T19:13:49Z","git_url":"git://github.com/SpongePowered/Sponge.git","ssh_url":"git@github.com:SpongePowered/Sponge.git","clone_url":"https://github.com/SpongePowered/Sponge.git","svn_url":"https://github.com/SpongePowered/Sponge","homepage":"http://www.spongepowered.org/","size":12902,"stargazers_count":771,"watchers_count":771,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":331,"mirror_url":null,"open_issues_count":25,"forks":331,"open_issues":25,"watchers":771,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/Sponge/pulls/245"},"html":{"href":"https://github.com/SpongePowered/Sponge/pull/245"},"issue":{"href":"https://api.github.com/repos/SpongePowered/Sponge/issues/245"},"comments":{"href":"https://api.github.com/repos/SpongePowered/Sponge/issues/245/comments"},"review_comments":{"href":"https://api.github.com/repos/SpongePowered/Sponge/pulls/245/comments"},"review_comment":{"href":"https://api.github.com/repos/SpongePowered/Sponge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpongePowered/Sponge/pulls/245/commits"},"statuses":{"href":"https://api.github.com/repos/SpongePowered/Sponge/statuses/111b25611868ac901d7b684d65286ca226e28cbf"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":23,"additions":951,"deletions":22171,"changed_files":286}}