{"action":"closed","number":60,"pull_request":{"url":"https://api.github.com/repos/go-amz/amz/pulls/60","id":41968159,"html_url":"https://github.com/go-amz/amz/pull/60","diff_url":"https://github.com/go-amz/amz/pull/60.diff","patch_url":"https://github.com/go-amz/amz/pull/60.patch","issue_url":"https://api.github.com/repos/go-amz/amz/issues/60","number":60,"state":"closed","locked":false,"title":"Discovery of Internet Gateways, RouteTables; ec2test improvements","user":{"login":"dimitern","id":619986,"avatar_url":"https://avatars.githubusercontent.com/u/619986?v=3","gravatar_id":"","url":"https://api.github.com/users/dimitern","html_url":"https://github.com/dimitern","followers_url":"https://api.github.com/users/dimitern/followers","following_url":"https://api.github.com/users/dimitern/following{/other_user}","gists_url":"https://api.github.com/users/dimitern/gists{/gist_id}","starred_url":"https://api.github.com/users/dimitern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimitern/subscriptions","organizations_url":"https://api.github.com/users/dimitern/orgs","repos_url":"https://api.github.com/users/dimitern/repos","events_url":"https://api.github.com/users/dimitern/events{/privacy}","received_events_url":"https://api.github.com/users/dimitern/received_events","type":"User","site_admin":false},"body":"Building on the previous PR, this one improves ec2test server and adds tests for some of its features (more in a follow-up). Added support to pre-configure ec2test servers with:\r\n\r\n* SetInitialAttributes() got **renamed** to SetAccountAttributes(), and the behavior of treating \"default-vpc\" specially has been dropped in favor of AddDefaultVPCAndSubnets() below. In order not to break existing tests code using ec2test (if any), SetInitialAttributes() is an alias of SetAccountAttributes(), but to simulate a default VPC in ec2test such tests need to start calling AddDefaultVPCAndSubnets() instead.\r\n* *VPCs*: AddVPC(), UpdateVPC(), RemoveVPC()\r\n* AddDefaultVPCAndSubnets() - a convenient helper to add a default VPC, one default subnet per AZ (with MapPublicIPOnLaunch set), an Internet Gateway (IGW) connected to the VPC, a main route table for the VPC with routes for local VPC traffic and a default route to the IGW, finally calling SetAccountAttributes() to announce the default VPC and make it discoverable.\r\n* *Subnets*: AddSubnet(), UpdateSubnet(), RemoveSubnet()\r\n* *Internet Gateways*: AddInternetGateway(), UpdateInternetGateway(), RemoveInternetGateway()\r\n* *Route Tables*: AddRouteTable(), UpdateRouteTable(), RemoveRouteTable()\r\n* SetAvailabilityZones() now **removes** any subnets which have the zone in their AvailZone field.\r\n* Reset() method added to ec2test, which takes a withoutZonesOrGroups flag - when `true` everything stored in the test server is reset, including counters, but the listener is kept. A value of `false` will add default AZ and security groups after resetting. \r\n\r\nIn the ec2 package, added support for the DescribeInternetGateways and DescribeRouteTables AWS APIs, with more or less complete filtering support except for tags.\r\n\r\nFinally, this PR includes a number of fixes around live tests to make them more robust and reliable.\r\nTested with different combinations of: `go test -check.v -test.timeout=1200m -amazon -race -coverprofile=cover -covermode=atomic`","created_at":"2015-08-09T10:01:39Z","updated_at":"2015-08-10T14:29:16Z","closed_at":"2015-08-10T14:29:16Z","merged_at":"2015-08-10T14:29:16Z","merge_commit_sha":"e0dc373df9d7903cbb8077dd16f3f3bc7b469573","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/go-amz/amz/pulls/60/commits","review_comments_url":"https://api.github.com/repos/go-amz/amz/pulls/60/comments","review_comment_url":"https://api.github.com/repos/go-amz/amz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-amz/amz/issues/60/comments","statuses_url":"https://api.github.com/repos/go-amz/amz/statuses/19a2b2c40c9d99eb54a77975eca661da67e4b907","head":{"label":"dimitern:describe-igw-and-routes-take-2","ref":"describe-igw-and-routes-take-2","sha":"19a2b2c40c9d99eb54a77975eca661da67e4b907","user":{"login":"dimitern","id":619986,"avatar_url":"https://avatars.githubusercontent.com/u/619986?v=3","gravatar_id":"","url":"https://api.github.com/users/dimitern","html_url":"https://github.com/dimitern","followers_url":"https://api.github.com/users/dimitern/followers","following_url":"https://api.github.com/users/dimitern/following{/other_user}","gists_url":"https://api.github.com/users/dimitern/gists{/gist_id}","starred_url":"https://api.github.com/users/dimitern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimitern/subscriptions","organizations_url":"https://api.github.com/users/dimitern/orgs","repos_url":"https://api.github.com/users/dimitern/repos","events_url":"https://api.github.com/users/dimitern/events{/privacy}","received_events_url":"https://api.github.com/users/dimitern/received_events","type":"User","site_admin":false},"repo":{"id":27930312,"name":"amz","full_name":"dimitern/amz","owner":{"login":"dimitern","id":619986,"avatar_url":"https://avatars.githubusercontent.com/u/619986?v=3","gravatar_id":"","url":"https://api.github.com/users/dimitern","html_url":"https://github.com/dimitern","followers_url":"https://api.github.com/users/dimitern/followers","following_url":"https://api.github.com/users/dimitern/following{/other_user}","gists_url":"https://api.github.com/users/dimitern/gists{/gist_id}","starred_url":"https://api.github.com/users/dimitern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimitern/subscriptions","organizations_url":"https://api.github.com/users/dimitern/orgs","repos_url":"https://api.github.com/users/dimitern/repos","events_url":"https://api.github.com/users/dimitern/events{/privacy}","received_events_url":"https://api.github.com/users/dimitern/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dimitern/amz","description":"Go package to interact with Amazon Web Services","fork":true,"url":"https://api.github.com/repos/dimitern/amz","forks_url":"https://api.github.com/repos/dimitern/amz/forks","keys_url":"https://api.github.com/repos/dimitern/amz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimitern/amz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimitern/amz/teams","hooks_url":"https://api.github.com/repos/dimitern/amz/hooks","issue_events_url":"https://api.github.com/repos/dimitern/amz/issues/events{/number}","events_url":"https://api.github.com/repos/dimitern/amz/events","assignees_url":"https://api.github.com/repos/dimitern/amz/assignees{/user}","branches_url":"https://api.github.com/repos/dimitern/amz/branches{/branch}","tags_url":"https://api.github.com/repos/dimitern/amz/tags","blobs_url":"https://api.github.com/repos/dimitern/amz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimitern/amz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimitern/amz/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimitern/amz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimitern/amz/statuses/{sha}","languages_url":"https://api.github.com/repos/dimitern/amz/languages","stargazers_url":"https://api.github.com/repos/dimitern/amz/stargazers","contributors_url":"https://api.github.com/repos/dimitern/amz/contributors","subscribers_url":"https://api.github.com/repos/dimitern/amz/subscribers","subscription_url":"https://api.github.com/repos/dimitern/amz/subscription","commits_url":"https://api.github.com/repos/dimitern/amz/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimitern/amz/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimitern/amz/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimitern/amz/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimitern/amz/contents/{+path}","compare_url":"https://api.github.com/repos/dimitern/amz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimitern/amz/merges","archive_url":"https://api.github.com/repos/dimitern/amz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimitern/amz/downloads","issues_url":"https://api.github.com/repos/dimitern/amz/issues{/number}","pulls_url":"https://api.github.com/repos/dimitern/amz/pulls{/number}","milestones_url":"https://api.github.com/repos/dimitern/amz/milestones{/number}","notifications_url":"https://api.github.com/repos/dimitern/amz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimitern/amz/labels{/name}","releases_url":"https://api.github.com/repos/dimitern/amz/releases{/id}","created_at":"2014-12-12T17:23:26Z","updated_at":"2015-03-01T12:46:23Z","pushed_at":"2015-08-10T14:24:38Z","git_url":"git://github.com/dimitern/amz.git","ssh_url":"git@github.com:dimitern/amz.git","clone_url":"https://github.com/dimitern/amz.git","svn_url":"https://github.com/dimitern/amz","homepage":"https://wiki.ubuntu.com/goamz","size":742,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v1"}},"base":{"label":"go-amz:v3","ref":"v3","sha":"03a3d381eab5afff2d2eebc7bf59313ce6f4b23c","user":{"login":"go-amz","id":8137365,"avatar_url":"https://avatars.githubusercontent.com/u/8137365?v=3","gravatar_id":"","url":"https://api.github.com/users/go-amz","html_url":"https://github.com/go-amz","followers_url":"https://api.github.com/users/go-amz/followers","following_url":"https://api.github.com/users/go-amz/following{/other_user}","gists_url":"https://api.github.com/users/go-amz/gists{/gist_id}","starred_url":"https://api.github.com/users/go-amz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-amz/subscriptions","organizations_url":"https://api.github.com/users/go-amz/orgs","repos_url":"https://api.github.com/users/go-amz/repos","events_url":"https://api.github.com/users/go-amz/events{/privacy}","received_events_url":"https://api.github.com/users/go-amz/received_events","type":"Organization","site_admin":false},"repo":{"id":27928684,"name":"amz","full_name":"go-amz/amz","owner":{"login":"go-amz","id":8137365,"avatar_url":"https://avatars.githubusercontent.com/u/8137365?v=3","gravatar_id":"","url":"https://api.github.com/users/go-amz","html_url":"https://github.com/go-amz","followers_url":"https://api.github.com/users/go-amz/followers","following_url":"https://api.github.com/users/go-amz/following{/other_user}","gists_url":"https://api.github.com/users/go-amz/gists{/gist_id}","starred_url":"https://api.github.com/users/go-amz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-amz/subscriptions","organizations_url":"https://api.github.com/users/go-amz/orgs","repos_url":"https://api.github.com/users/go-amz/repos","events_url":"https://api.github.com/users/go-amz/events{/privacy}","received_events_url":"https://api.github.com/users/go-amz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-amz/amz","description":"Go package to interact with Amazon Web Services","fork":false,"url":"https://api.github.com/repos/go-amz/amz","forks_url":"https://api.github.com/repos/go-amz/amz/forks","keys_url":"https://api.github.com/repos/go-amz/amz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-amz/amz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-amz/amz/teams","hooks_url":"https://api.github.com/repos/go-amz/amz/hooks","issue_events_url":"https://api.github.com/repos/go-amz/amz/issues/events{/number}","events_url":"https://api.github.com/repos/go-amz/amz/events","assignees_url":"https://api.github.com/repos/go-amz/amz/assignees{/user}","branches_url":"https://api.github.com/repos/go-amz/amz/branches{/branch}","tags_url":"https://api.github.com/repos/go-amz/amz/tags","blobs_url":"https://api.github.com/repos/go-amz/amz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-amz/amz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-amz/amz/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-amz/amz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-amz/amz/statuses/{sha}","languages_url":"https://api.github.com/repos/go-amz/amz/languages","stargazers_url":"https://api.github.com/repos/go-amz/amz/stargazers","contributors_url":"https://api.github.com/repos/go-amz/amz/contributors","subscribers_url":"https://api.github.com/repos/go-amz/amz/subscribers","subscription_url":"https://api.github.com/repos/go-amz/amz/subscription","commits_url":"https://api.github.com/repos/go-amz/amz/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-amz/amz/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-amz/amz/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-amz/amz/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-amz/amz/contents/{+path}","compare_url":"https://api.github.com/repos/go-amz/amz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-amz/amz/merges","archive_url":"https://api.github.com/repos/go-amz/amz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-amz/amz/downloads","issues_url":"https://api.github.com/repos/go-amz/amz/issues{/number}","pulls_url":"https://api.github.com/repos/go-amz/amz/pulls{/number}","milestones_url":"https://api.github.com/repos/go-amz/amz/milestones{/number}","notifications_url":"https://api.github.com/repos/go-amz/amz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-amz/amz/labels{/name}","releases_url":"https://api.github.com/repos/go-amz/amz/releases{/id}","created_at":"2014-12-12T16:38:44Z","updated_at":"2015-08-08T05:23:37Z","pushed_at":"2015-08-10T14:29:16Z","git_url":"git://github.com/go-amz/amz.git","ssh_url":"git@github.com:go-amz/amz.git","clone_url":"https://github.com/go-amz/amz.git","svn_url":"https://github.com/go-amz/amz","homepage":"https://wiki.ubuntu.com/goamz","size":1036,"stargazers_count":63,"watchers_count":63,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":6,"forks":25,"open_issues":6,"watchers":63,"default_branch":"v1"}},"_links":{"self":{"href":"https://api.github.com/repos/go-amz/amz/pulls/60"},"html":{"href":"https://github.com/go-amz/amz/pull/60"},"issue":{"href":"https://api.github.com/repos/go-amz/amz/issues/60"},"comments":{"href":"https://api.github.com/repos/go-amz/amz/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/go-amz/amz/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/go-amz/amz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-amz/amz/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/go-amz/amz/statuses/19a2b2c40c9d99eb54a77975eca661da67e4b907"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dimitern","id":619986,"avatar_url":"https://avatars.githubusercontent.com/u/619986?v=3","gravatar_id":"","url":"https://api.github.com/users/dimitern","html_url":"https://github.com/dimitern","followers_url":"https://api.github.com/users/dimitern/followers","following_url":"https://api.github.com/users/dimitern/following{/other_user}","gists_url":"https://api.github.com/users/dimitern/gists{/gist_id}","starred_url":"https://api.github.com/users/dimitern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimitern/subscriptions","organizations_url":"https://api.github.com/users/dimitern/orgs","repos_url":"https://api.github.com/users/dimitern/repos","events_url":"https://api.github.com/users/dimitern/events{/privacy}","received_events_url":"https://api.github.com/users/dimitern/received_events","type":"User","site_admin":false},"comments":3,"review_comments":18,"commits":15,"additions":1999,"deletions":150,"changed_files":23}}