{"action":"closed","number":986,"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/986","id":27748913,"html_url":"https://github.com/magento/magento2/pull/986","diff_url":"https://github.com/magento/magento2/pull/986.diff","patch_url":"https://github.com/magento/magento2/pull/986.patch","issue_url":"https://api.github.com/repos/magento/magento2/issues/986","number":986,"state":"closed","locked":false,"title":"Make it possible to exclude classes (directories) for compilation","user":{"login":"Flyingmana","id":237319,"avatar_url":"https://avatars.githubusercontent.com/u/237319?v=3","gravatar_id":"","url":"https://api.github.com/users/Flyingmana","html_url":"https://github.com/Flyingmana","followers_url":"https://api.github.com/users/Flyingmana/followers","following_url":"https://api.github.com/users/Flyingmana/following{/other_user}","gists_url":"https://api.github.com/users/Flyingmana/gists{/gist_id}","starred_url":"https://api.github.com/users/Flyingmana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flyingmana/subscriptions","organizations_url":"https://api.github.com/users/Flyingmana/orgs","repos_url":"https://api.github.com/users/Flyingmana/repos","events_url":"https://api.github.com/users/Flyingmana/events{/privacy}","received_events_url":"https://api.github.com/users/Flyingmana/received_events","type":"User","site_admin":false},"body":"Reason is:\r\nA single module which is working for Magento 1.x and 2.x\r\nthe 2.x specific files are not problem for 1.x, but the 1.x specific files will get parsed from the compiler causing two errors.\r\n1. they are not part of the autoloading, which causes a first error\r\n2. they extend from classes not existent in 2.x anymore \r\n\r\nTo prevent this errors this patch allows to specify an ignore pattern with `/m1/` as default, so everything a module places in a m1 directory, is not parsed from the compiler anymore.\r\n\r\n\r\nI will provide documentation after this get merged, not sure about tests yet, but  will see later how to add some for it","created_at":"2015-01-21T10:26:42Z","updated_at":"2015-02-27T13:58:46Z","closed_at":"2015-02-27T13:58:46Z","merged_at":"2015-02-27T13:58:46Z","merge_commit_sha":"7e3c6ef99a3a0e82ee769ff29b5bdfbb7a624561","assignee":{"login":"vpelipenko","id":3816369,"avatar_url":"https://avatars.githubusercontent.com/u/3816369?v=3","gravatar_id":"","url":"https://api.github.com/users/vpelipenko","html_url":"https://github.com/vpelipenko","followers_url":"https://api.github.com/users/vpelipenko/followers","following_url":"https://api.github.com/users/vpelipenko/following{/other_user}","gists_url":"https://api.github.com/users/vpelipenko/gists{/gist_id}","starred_url":"https://api.github.com/users/vpelipenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpelipenko/subscriptions","organizations_url":"https://api.github.com/users/vpelipenko/orgs","repos_url":"https://api.github.com/users/vpelipenko/repos","events_url":"https://api.github.com/users/vpelipenko/events{/privacy}","received_events_url":"https://api.github.com/users/vpelipenko/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/magento/magento2/pulls/986/commits","review_comments_url":"https://api.github.com/repos/magento/magento2/pulls/986/comments","review_comment_url":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/magento2/issues/986/comments","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/ab3f17900f3b93a8b8b474497cc3b88e2368210c","head":{"label":"Flyingmana:patch-6","ref":"patch-6","sha":"ab3f17900f3b93a8b8b474497cc3b88e2368210c","user":{"login":"Flyingmana","id":237319,"avatar_url":"https://avatars.githubusercontent.com/u/237319?v=3","gravatar_id":"","url":"https://api.github.com/users/Flyingmana","html_url":"https://github.com/Flyingmana","followers_url":"https://api.github.com/users/Flyingmana/followers","following_url":"https://api.github.com/users/Flyingmana/following{/other_user}","gists_url":"https://api.github.com/users/Flyingmana/gists{/gist_id}","starred_url":"https://api.github.com/users/Flyingmana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flyingmana/subscriptions","organizations_url":"https://api.github.com/users/Flyingmana/orgs","repos_url":"https://api.github.com/users/Flyingmana/repos","events_url":"https://api.github.com/users/Flyingmana/events{/privacy}","received_events_url":"https://api.github.com/users/Flyingmana/received_events","type":"User","site_admin":false},"repo":{"id":28343053,"name":"magento2","full_name":"Flyingmana/magento2","owner":{"login":"Flyingmana","id":237319,"avatar_url":"https://avatars.githubusercontent.com/u/237319?v=3","gravatar_id":"","url":"https://api.github.com/users/Flyingmana","html_url":"https://github.com/Flyingmana","followers_url":"https://api.github.com/users/Flyingmana/followers","following_url":"https://api.github.com/users/Flyingmana/following{/other_user}","gists_url":"https://api.github.com/users/Flyingmana/gists{/gist_id}","starred_url":"https://api.github.com/users/Flyingmana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flyingmana/subscriptions","organizations_url":"https://api.github.com/users/Flyingmana/orgs","repos_url":"https://api.github.com/users/Flyingmana/repos","events_url":"https://api.github.com/users/Flyingmana/events{/privacy}","received_events_url":"https://api.github.com/users/Flyingmana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Flyingmana/magento2","description":"All Submissions you make to Magento, an eBay Inc. company (“Magento”) through GitHub are subject to the following terms and conditions: (1)\tYou grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable      license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission”) you submit through GitHub. (2)\tYour Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3)\tYou agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":true,"url":"https://api.github.com/repos/Flyingmana/magento2","forks_url":"https://api.github.com/repos/Flyingmana/magento2/forks","keys_url":"https://api.github.com/repos/Flyingmana/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Flyingmana/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Flyingmana/magento2/teams","hooks_url":"https://api.github.com/repos/Flyingmana/magento2/hooks","issue_events_url":"https://api.github.com/repos/Flyingmana/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/Flyingmana/magento2/events","assignees_url":"https://api.github.com/repos/Flyingmana/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/Flyingmana/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/Flyingmana/magento2/tags","blobs_url":"https://api.github.com/repos/Flyingmana/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Flyingmana/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Flyingmana/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Flyingmana/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Flyingmana/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/Flyingmana/magento2/languages","stargazers_url":"https://api.github.com/repos/Flyingmana/magento2/stargazers","contributors_url":"https://api.github.com/repos/Flyingmana/magento2/contributors","subscribers_url":"https://api.github.com/repos/Flyingmana/magento2/subscribers","subscription_url":"https://api.github.com/repos/Flyingmana/magento2/subscription","commits_url":"https://api.github.com/repos/Flyingmana/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Flyingmana/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Flyingmana/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Flyingmana/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Flyingmana/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/Flyingmana/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Flyingmana/magento2/merges","archive_url":"https://api.github.com/repos/Flyingmana/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Flyingmana/magento2/downloads","issues_url":"https://api.github.com/repos/Flyingmana/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/Flyingmana/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/Flyingmana/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/Flyingmana/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Flyingmana/magento2/labels{/name}","releases_url":"https://api.github.com/repos/Flyingmana/magento2/releases{/id}","created_at":"2014-12-22T15:03:52Z","updated_at":"2014-12-22T15:04:22Z","pushed_at":"2015-02-24T21:24:59Z","git_url":"git://github.com/Flyingmana/magento2.git","ssh_url":"git@github.com:Flyingmana/magento2.git","clone_url":"https://github.com/Flyingmana/magento2.git","svn_url":"https://github.com/Flyingmana/magento2","homepage":"http://www.magento.com","size":169782,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"magento:develop","ref":"develop","sha":"3fc64554465282177ba7fbcb3d225a8997484e39","user":{"login":"magento","id":168457,"avatar_url":"https://avatars.githubusercontent.com/u/168457?v=3","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":2884111,"name":"magento2","full_name":"magento/magento2","owner":{"login":"magento","id":168457,"avatar_url":"https://avatars.githubusercontent.com/u/168457?v=3","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento/magento2","description":"All Submissions you make to Magento, an eBay Inc. company (“Magento”) through GitHub are subject to the following terms and conditions: (1)\tYou grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable      license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission”) you submit through GitHub. (2)\tYour Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3)\tYou agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":false,"url":"https://api.github.com/repos/magento/magento2","forks_url":"https://api.github.com/repos/magento/magento2/forks","keys_url":"https://api.github.com/repos/magento/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/magento2/teams","hooks_url":"https://api.github.com/repos/magento/magento2/hooks","issue_events_url":"https://api.github.com/repos/magento/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/magento/magento2/events","assignees_url":"https://api.github.com/repos/magento/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/magento/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/magento/magento2/tags","blobs_url":"https://api.github.com/repos/magento/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/magento2/languages","stargazers_url":"https://api.github.com/repos/magento/magento2/stargazers","contributors_url":"https://api.github.com/repos/magento/magento2/contributors","subscribers_url":"https://api.github.com/repos/magento/magento2/subscribers","subscription_url":"https://api.github.com/repos/magento/magento2/subscription","commits_url":"https://api.github.com/repos/magento/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/magento/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/magento2/merges","archive_url":"https://api.github.com/repos/magento/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/magento2/downloads","issues_url":"https://api.github.com/repos/magento/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/magento/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/magento2/labels{/name}","releases_url":"https://api.github.com/repos/magento/magento2/releases{/id}","created_at":"2011-11-30T15:30:13Z","updated_at":"2015-02-27T10:05:58Z","pushed_at":"2015-02-27T13:58:46Z","git_url":"git://github.com/magento/magento2.git","ssh_url":"git@github.com:magento/magento2.git","clone_url":"https://github.com/magento/magento2.git","svn_url":"https://github.com/magento/magento2","homepage":"http://www.magento.com","size":374979,"stargazers_count":2134,"watchers_count":2134,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1163,"mirror_url":null,"open_issues_count":190,"forks":1163,"open_issues":190,"watchers":2134,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/986"},"html":{"href":"https://github.com/magento/magento2/pull/986"},"issue":{"href":"https://api.github.com/repos/magento/magento2/issues/986"},"comments":{"href":"https://api.github.com/repos/magento/magento2/issues/986/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/magento2/pulls/986/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/magento2/pulls/986/commits"},"statuses":{"href":"https://api.github.com/repos/magento/magento2/statuses/ab3f17900f3b93a8b8b474497cc3b88e2368210c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"vpelipenko","id":3816369,"avatar_url":"https://avatars.githubusercontent.com/u/3816369?v=3","gravatar_id":"","url":"https://api.github.com/users/vpelipenko","html_url":"https://github.com/vpelipenko","followers_url":"https://api.github.com/users/vpelipenko/followers","following_url":"https://api.github.com/users/vpelipenko/following{/other_user}","gists_url":"https://api.github.com/users/vpelipenko/gists{/gist_id}","starred_url":"https://api.github.com/users/vpelipenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpelipenko/subscriptions","organizations_url":"https://api.github.com/users/vpelipenko/orgs","repos_url":"https://api.github.com/users/vpelipenko/repos","events_url":"https://api.github.com/users/vpelipenko/events{/privacy}","received_events_url":"https://api.github.com/users/vpelipenko/received_events","type":"User","site_admin":false},"comments":11,"review_comments":2,"commits":4,"additions":37,"deletions":4,"changed_files":3}}