{"action":"created","comment":{"url":"https://api.github.com/repos/SeanDolphin/bqschema/pulls/comments/28735350","id":28735350,"diff_hunk":"@@ -1,10 +1,10 @@\n-package bqschema_test\n+package bqschema","path":"bqschema_suite_test.go","position":2,"original_position":2,"commit_id":"2877109cf9d230f37c19d043c407463269a8b2a6","original_commit_id":"2877109cf9d230f37c19d043c407463269a8b2a6","user":{"login":"cee-dub","id":1292,"avatar_url":"https://avatars.githubusercontent.com/u/1292?v=3","gravatar_id":"","url":"https://api.github.com/users/cee-dub","html_url":"https://github.com/cee-dub","followers_url":"https://api.github.com/users/cee-dub/followers","following_url":"https://api.github.com/users/cee-dub/following{/other_user}","gists_url":"https://api.github.com/users/cee-dub/gists{/gist_id}","starred_url":"https://api.github.com/users/cee-dub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cee-dub/subscriptions","organizations_url":"https://api.github.com/users/cee-dub/orgs","repos_url":"https://api.github.com/users/cee-dub/repos","events_url":"https://api.github.com/users/cee-dub/events{/privacy}","received_events_url":"https://api.github.com/users/cee-dub/received_events","type":"User","site_admin":false},"body":"I have the above commit ready, but I chose not to push it pending further discussion.","created_at":"2015-04-20T22:20:43Z","updated_at":"2015-04-20T22:20:43Z","html_url":"https://github.com/SeanDolphin/bqschema/pull/2#discussion_r28735350","pull_request_url":"https://api.github.com/repos/SeanDolphin/bqschema/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/SeanDolphin/bqschema/pulls/comments/28735350"},"html":{"href":"https://github.com/SeanDolphin/bqschema/pull/2#discussion_r28735350"},"pull_request":{"href":"https://api.github.com/repos/SeanDolphin/bqschema/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/SeanDolphin/bqschema/pulls/2","id":33611809,"html_url":"https://github.com/SeanDolphin/bqschema/pull/2","diff_url":"https://github.com/SeanDolphin/bqschema/pull/2.diff","patch_url":"https://github.com/SeanDolphin/bqschema/pull/2.patch","issue_url":"https://api.github.com/repos/SeanDolphin/bqschema/issues/2","number":2,"state":"open","locked":false,"title":"Prevent null element in schemas with ignored fields","user":{"login":"cee-dub","id":1292,"avatar_url":"https://avatars.githubusercontent.com/u/1292?v=3","gravatar_id":"","url":"https://api.github.com/users/cee-dub","html_url":"https://github.com/cee-dub","followers_url":"https://api.github.com/users/cee-dub/followers","following_url":"https://api.github.com/users/cee-dub/following{/other_user}","gists_url":"https://api.github.com/users/cee-dub/gists{/gist_id}","starred_url":"https://api.github.com/users/cee-dub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cee-dub/subscriptions","organizations_url":"https://api.github.com/users/cee-dub/orgs","repos_url":"https://api.github.com/users/cee-dub/repos","events_url":"https://api.github.com/users/cee-dub/events{/privacy}","received_events_url":"https://api.github.com/users/cee-dub/received_events","type":"User","site_admin":false},"body":"Hi, thanks for your library! I'm finding it very helpful.\r\n\r\nI needed to include a helper object into a struct from which I was creating a schema. On this field, I added the tag `json:\"-\"` to allow both `encoding/json` and `bqschema` to ignore it. Unfortunately, the JSON output of the schema then includes a `null` in the `\"fields\"` array corresponding to this ignored field.\r\n\r\nI fixed this behavior in `8fa16a0` and made a few minor cleanups in the following commit. (They prevent needing to import the package in the tests.)\r\n\r\nHoping you'll find these changes amenable.\r\n\r\nCheers,\r\n**—cw**","created_at":"2015-04-19T01:22:51Z","updated_at":"2015-04-20T22:20:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e01de92eae377ae6f99f652937c6af2d04933937","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SeanDolphin/bqschema/pulls/2/commits","review_comments_url":"https://api.github.com/repos/SeanDolphin/bqschema/pulls/2/comments","review_comment_url":"https://api.github.com/repos/SeanDolphin/bqschema/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SeanDolphin/bqschema/issues/2/comments","statuses_url":"https://api.github.com/repos/SeanDolphin/bqschema/statuses/2877109cf9d230f37c19d043c407463269a8b2a6","head":{"label":"nbio:master","ref":"master","sha":"2877109cf9d230f37c19d043c407463269a8b2a6","user":{"login":"nbio","id":7267891,"avatar_url":"https://avatars.githubusercontent.com/u/7267891?v=3","gravatar_id":"","url":"https://api.github.com/users/nbio","html_url":"https://github.com/nbio","followers_url":"https://api.github.com/users/nbio/followers","following_url":"https://api.github.com/users/nbio/following{/other_user}","gists_url":"https://api.github.com/users/nbio/gists{/gist_id}","starred_url":"https://api.github.com/users/nbio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbio/subscriptions","organizations_url":"https://api.github.com/users/nbio/orgs","repos_url":"https://api.github.com/users/nbio/repos","events_url":"https://api.github.com/users/nbio/events{/privacy}","received_events_url":"https://api.github.com/users/nbio/received_events","type":"Organization","site_admin":false},"repo":{"id":34188292,"name":"bqschema","full_name":"nbio/bqschema","owner":{"login":"nbio","id":7267891,"avatar_url":"https://avatars.githubusercontent.com/u/7267891?v=3","gravatar_id":"","url":"https://api.github.com/users/nbio","html_url":"https://github.com/nbio","followers_url":"https://api.github.com/users/nbio/followers","following_url":"https://api.github.com/users/nbio/following{/other_user}","gists_url":"https://api.github.com/users/nbio/gists{/gist_id}","starred_url":"https://api.github.com/users/nbio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbio/subscriptions","organizations_url":"https://api.github.com/users/nbio/orgs","repos_url":"https://api.github.com/users/nbio/repos","events_url":"https://api.github.com/users/nbio/events{/privacy}","received_events_url":"https://api.github.com/users/nbio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nbio/bqschema","description":"","fork":true,"url":"https://api.github.com/repos/nbio/bqschema","forks_url":"https://api.github.com/repos/nbio/bqschema/forks","keys_url":"https://api.github.com/repos/nbio/bqschema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nbio/bqschema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nbio/bqschema/teams","hooks_url":"https://api.github.com/repos/nbio/bqschema/hooks","issue_events_url":"https://api.github.com/repos/nbio/bqschema/issues/events{/number}","events_url":"https://api.github.com/repos/nbio/bqschema/events","assignees_url":"https://api.github.com/repos/nbio/bqschema/assignees{/user}","branches_url":"https://api.github.com/repos/nbio/bqschema/branches{/branch}","tags_url":"https://api.github.com/repos/nbio/bqschema/tags","blobs_url":"https://api.github.com/repos/nbio/bqschema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nbio/bqschema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nbio/bqschema/git/refs{/sha}","trees_url":"https://api.github.com/repos/nbio/bqschema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nbio/bqschema/statuses/{sha}","languages_url":"https://api.github.com/repos/nbio/bqschema/languages","stargazers_url":"https://api.github.com/repos/nbio/bqschema/stargazers","contributors_url":"https://api.github.com/repos/nbio/bqschema/contributors","subscribers_url":"https://api.github.com/repos/nbio/bqschema/subscribers","subscription_url":"https://api.github.com/repos/nbio/bqschema/subscription","commits_url":"https://api.github.com/repos/nbio/bqschema/commits{/sha}","git_commits_url":"https://api.github.com/repos/nbio/bqschema/git/commits{/sha}","comments_url":"https://api.github.com/repos/nbio/bqschema/comments{/number}","issue_comment_url":"https://api.github.com/repos/nbio/bqschema/issues/comments{/number}","contents_url":"https://api.github.com/repos/nbio/bqschema/contents/{+path}","compare_url":"https://api.github.com/repos/nbio/bqschema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nbio/bqschema/merges","archive_url":"https://api.github.com/repos/nbio/bqschema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nbio/bqschema/downloads","issues_url":"https://api.github.com/repos/nbio/bqschema/issues{/number}","pulls_url":"https://api.github.com/repos/nbio/bqschema/pulls{/number}","milestones_url":"https://api.github.com/repos/nbio/bqschema/milestones{/number}","notifications_url":"https://api.github.com/repos/nbio/bqschema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nbio/bqschema/labels{/name}","releases_url":"https://api.github.com/repos/nbio/bqschema/releases{/id}","created_at":"2015-04-19T00:40:19Z","updated_at":"2015-04-19T01:15:15Z","pushed_at":"2015-04-19T01:15:15Z","git_url":"git://github.com/nbio/bqschema.git","ssh_url":"git@github.com:nbio/bqschema.git","clone_url":"https://github.com/nbio/bqschema.git","svn_url":"https://github.com/nbio/bqschema","homepage":null,"size":103,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SeanDolphin:master","ref":"master","sha":"4aed53b9a03e12eca308b6be573777e26841e30b","user":{"login":"SeanDolphin","id":5703162,"avatar_url":"https://avatars.githubusercontent.com/u/5703162?v=3","gravatar_id":"","url":"https://api.github.com/users/SeanDolphin","html_url":"https://github.com/SeanDolphin","followers_url":"https://api.github.com/users/SeanDolphin/followers","following_url":"https://api.github.com/users/SeanDolphin/following{/other_user}","gists_url":"https://api.github.com/users/SeanDolphin/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanDolphin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanDolphin/subscriptions","organizations_url":"https://api.github.com/users/SeanDolphin/orgs","repos_url":"https://api.github.com/users/SeanDolphin/repos","events_url":"https://api.github.com/users/SeanDolphin/events{/privacy}","received_events_url":"https://api.github.com/users/SeanDolphin/received_events","type":"User","site_admin":false},"repo":{"id":20746606,"name":"bqschema","full_name":"SeanDolphin/bqschema","owner":{"login":"SeanDolphin","id":5703162,"avatar_url":"https://avatars.githubusercontent.com/u/5703162?v=3","gravatar_id":"","url":"https://api.github.com/users/SeanDolphin","html_url":"https://github.com/SeanDolphin","followers_url":"https://api.github.com/users/SeanDolphin/followers","following_url":"https://api.github.com/users/SeanDolphin/following{/other_user}","gists_url":"https://api.github.com/users/SeanDolphin/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanDolphin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanDolphin/subscriptions","organizations_url":"https://api.github.com/users/SeanDolphin/orgs","repos_url":"https://api.github.com/users/SeanDolphin/repos","events_url":"https://api.github.com/users/SeanDolphin/events{/privacy}","received_events_url":"https://api.github.com/users/SeanDolphin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SeanDolphin/bqschema","description":"","fork":false,"url":"https://api.github.com/repos/SeanDolphin/bqschema","forks_url":"https://api.github.com/repos/SeanDolphin/bqschema/forks","keys_url":"https://api.github.com/repos/SeanDolphin/bqschema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeanDolphin/bqschema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeanDolphin/bqschema/teams","hooks_url":"https://api.github.com/repos/SeanDolphin/bqschema/hooks","issue_events_url":"https://api.github.com/repos/SeanDolphin/bqschema/issues/events{/number}","events_url":"https://api.github.com/repos/SeanDolphin/bqschema/events","assignees_url":"https://api.github.com/repos/SeanDolphin/bqschema/assignees{/user}","branches_url":"https://api.github.com/repos/SeanDolphin/bqschema/branches{/branch}","tags_url":"https://api.github.com/repos/SeanDolphin/bqschema/tags","blobs_url":"https://api.github.com/repos/SeanDolphin/bqschema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeanDolphin/bqschema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeanDolphin/bqschema/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeanDolphin/bqschema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeanDolphin/bqschema/statuses/{sha}","languages_url":"https://api.github.com/repos/SeanDolphin/bqschema/languages","stargazers_url":"https://api.github.com/repos/SeanDolphin/bqschema/stargazers","contributors_url":"https://api.github.com/repos/SeanDolphin/bqschema/contributors","subscribers_url":"https://api.github.com/repos/SeanDolphin/bqschema/subscribers","subscription_url":"https://api.github.com/repos/SeanDolphin/bqschema/subscription","commits_url":"https://api.github.com/repos/SeanDolphin/bqschema/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeanDolphin/bqschema/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeanDolphin/bqschema/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeanDolphin/bqschema/issues/comments{/number}","contents_url":"https://api.github.com/repos/SeanDolphin/bqschema/contents/{+path}","compare_url":"https://api.github.com/repos/SeanDolphin/bqschema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeanDolphin/bqschema/merges","archive_url":"https://api.github.com/repos/SeanDolphin/bqschema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeanDolphin/bqschema/downloads","issues_url":"https://api.github.com/repos/SeanDolphin/bqschema/issues{/number}","pulls_url":"https://api.github.com/repos/SeanDolphin/bqschema/pulls{/number}","milestones_url":"https://api.github.com/repos/SeanDolphin/bqschema/milestones{/number}","notifications_url":"https://api.github.com/repos/SeanDolphin/bqschema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeanDolphin/bqschema/labels{/name}","releases_url":"https://api.github.com/repos/SeanDolphin/bqschema/releases{/id}","created_at":"2014-06-11T22:32:16Z","updated_at":"2015-04-02T10:47:06Z","pushed_at":"2015-04-19T01:22:51Z","git_url":"git://github.com/SeanDolphin/bqschema.git","ssh_url":"git@github.com:SeanDolphin/bqschema.git","clone_url":"https://github.com/SeanDolphin/bqschema.git","svn_url":"https://github.com/SeanDolphin/bqschema","homepage":null,"size":230,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SeanDolphin/bqschema/pulls/2"},"html":{"href":"https://github.com/SeanDolphin/bqschema/pull/2"},"issue":{"href":"https://api.github.com/repos/SeanDolphin/bqschema/issues/2"},"comments":{"href":"https://api.github.com/repos/SeanDolphin/bqschema/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/SeanDolphin/bqschema/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/SeanDolphin/bqschema/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SeanDolphin/bqschema/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/SeanDolphin/bqschema/statuses/2877109cf9d230f37c19d043c407463269a8b2a6"}}}}