{"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/openstreetmap/osmosis/pulls/18","id":32988247,"html_url":"https://github.com/openstreetmap/osmosis/pull/18","diff_url":"https://github.com/openstreetmap/osmosis/pull/18.diff","patch_url":"https://github.com/openstreetmap/osmosis/pull/18.patch","issue_url":"https://api.github.com/repos/openstreetmap/osmosis/issues/18","number":18,"state":"closed","locked":false,"title":"Fix query for retrieving relation members and preventing duplicate WayNodes in Ways","user":{"login":"jeffreyerikson","id":176448,"avatar_url":"https://avatars.githubusercontent.com/u/176448?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffreyerikson","html_url":"https://github.com/jeffreyerikson","followers_url":"https://api.github.com/users/jeffreyerikson/followers","following_url":"https://api.github.com/users/jeffreyerikson/following{/other_user}","gists_url":"https://api.github.com/users/jeffreyerikson/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffreyerikson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffreyerikson/subscriptions","organizations_url":"https://api.github.com/users/jeffreyerikson/orgs","repos_url":"https://api.github.com/users/jeffreyerikson/repos","events_url":"https://api.github.com/users/jeffreyerikson/events{/privacy}","received_events_url":"https://api.github.com/users/jeffreyerikson/received_events","type":"User","site_admin":false},"body":"A couple more fixes as we've further used the pgsnapshot module.  The first fix changes the name of the field used for the relation ID in the SQL statement since PostgreSQL doesn't like aliased fields being used in the query criteria.  \r\n\r\nThe second fix prevents way nodes from being duplicated when a Way is retrieved.  We were seeing the proper WayNodes being added to the list, then fetched again and tacked on to the end of the list.\r\n\r\nI'm not sure if there would ever be a case where the nodes would not be returned when the Way is initially loaded by the call to super.getEntity() in WayDao.java, so I've added a check to see if the node list is already populated before trying to populate it again.  There very well may be a better way to handle this, but this logic prevents duplicate nodes from appearing given our use-case.\r\n\r\nNote, I don't seem to be able to run the test suite here . . . failing tests in the apidb module.  Is there any documentation for setting up an environment for testing?\r\n\r\nThanks!","created_at":"2015-04-09T19:32:09Z","updated_at":"2015-05-07T10:41:29Z","closed_at":"2015-05-07T10:41:29Z","merged_at":"2015-05-07T10:41:29Z","merge_commit_sha":"579909d2171cb1a8832bb0141960c04012e681c3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openstreetmap/osmosis/pulls/18/commits","review_comments_url":"https://api.github.com/repos/openstreetmap/osmosis/pulls/18/comments","review_comment_url":"https://api.github.com/repos/openstreetmap/osmosis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openstreetmap/osmosis/issues/18/comments","statuses_url":"https://api.github.com/repos/openstreetmap/osmosis/statuses/16ced2b416ed19630ad2d3bd9e9389f55be70224","head":{"label":"jeffreyerikson:master","ref":"master","sha":"16ced2b416ed19630ad2d3bd9e9389f55be70224","user":{"login":"jeffreyerikson","id":176448,"avatar_url":"https://avatars.githubusercontent.com/u/176448?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffreyerikson","html_url":"https://github.com/jeffreyerikson","followers_url":"https://api.github.com/users/jeffreyerikson/followers","following_url":"https://api.github.com/users/jeffreyerikson/following{/other_user}","gists_url":"https://api.github.com/users/jeffreyerikson/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffreyerikson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffreyerikson/subscriptions","organizations_url":"https://api.github.com/users/jeffreyerikson/orgs","repos_url":"https://api.github.com/users/jeffreyerikson/repos","events_url":"https://api.github.com/users/jeffreyerikson/events{/privacy}","received_events_url":"https://api.github.com/users/jeffreyerikson/received_events","type":"User","site_admin":false},"repo":{"id":24376498,"name":"osmosis","full_name":"jeffreyerikson/osmosis","owner":{"login":"jeffreyerikson","id":176448,"avatar_url":"https://avatars.githubusercontent.com/u/176448?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffreyerikson","html_url":"https://github.com/jeffreyerikson","followers_url":"https://api.github.com/users/jeffreyerikson/followers","following_url":"https://api.github.com/users/jeffreyerikson/following{/other_user}","gists_url":"https://api.github.com/users/jeffreyerikson/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffreyerikson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffreyerikson/subscriptions","organizations_url":"https://api.github.com/users/jeffreyerikson/orgs","repos_url":"https://api.github.com/users/jeffreyerikson/repos","events_url":"https://api.github.com/users/jeffreyerikson/events{/privacy}","received_events_url":"https://api.github.com/users/jeffreyerikson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeffreyerikson/osmosis","description":"Osmosis is a command line Java application for processing OSM data.","fork":true,"url":"https://api.github.com/repos/jeffreyerikson/osmosis","forks_url":"https://api.github.com/repos/jeffreyerikson/osmosis/forks","keys_url":"https://api.github.com/repos/jeffreyerikson/osmosis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffreyerikson/osmosis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffreyerikson/osmosis/teams","hooks_url":"https://api.github.com/repos/jeffreyerikson/osmosis/hooks","issue_events_url":"https://api.github.com/repos/jeffreyerikson/osmosis/issues/events{/number}","events_url":"https://api.github.com/repos/jeffreyerikson/osmosis/events","assignees_url":"https://api.github.com/repos/jeffreyerikson/osmosis/assignees{/user}","branches_url":"https://api.github.com/repos/jeffreyerikson/osmosis/branches{/branch}","tags_url":"https://api.github.com/repos/jeffreyerikson/osmosis/tags","blobs_url":"https://api.github.com/repos/jeffreyerikson/osmosis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffreyerikson/osmosis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffreyerikson/osmosis/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffreyerikson/osmosis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffreyerikson/osmosis/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffreyerikson/osmosis/languages","stargazers_url":"https://api.github.com/repos/jeffreyerikson/osmosis/stargazers","contributors_url":"https://api.github.com/repos/jeffreyerikson/osmosis/contributors","subscribers_url":"https://api.github.com/repos/jeffreyerikson/osmosis/subscribers","subscription_url":"https://api.github.com/repos/jeffreyerikson/osmosis/subscription","commits_url":"https://api.github.com/repos/jeffreyerikson/osmosis/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffreyerikson/osmosis/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffreyerikson/osmosis/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffreyerikson/osmosis/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffreyerikson/osmosis/contents/{+path}","compare_url":"https://api.github.com/repos/jeffreyerikson/osmosis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffreyerikson/osmosis/merges","archive_url":"https://api.github.com/repos/jeffreyerikson/osmosis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffreyerikson/osmosis/downloads","issues_url":"https://api.github.com/repos/jeffreyerikson/osmosis/issues{/number}","pulls_url":"https://api.github.com/repos/jeffreyerikson/osmosis/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffreyerikson/osmosis/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffreyerikson/osmosis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffreyerikson/osmosis/labels{/name}","releases_url":"https://api.github.com/repos/jeffreyerikson/osmosis/releases{/id}","created_at":"2014-09-23T15:11:39Z","updated_at":"2015-04-09T19:21:14Z","pushed_at":"2015-04-09T19:21:14Z","git_url":"git://github.com/jeffreyerikson/osmosis.git","ssh_url":"git@github.com:jeffreyerikson/osmosis.git","clone_url":"https://github.com/jeffreyerikson/osmosis.git","svn_url":"https://github.com/jeffreyerikson/osmosis","homepage":"http://wiki.openstreetmap.org/wiki/Osmosis","size":14168,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openstreetmap:master","ref":"master","sha":"cd86c4434242da3afb2ee3b084673bfb9c7583b5","user":{"login":"openstreetmap","id":261431,"avatar_url":"https://avatars.githubusercontent.com/u/261431?v=3","gravatar_id":"","url":"https://api.github.com/users/openstreetmap","html_url":"https://github.com/openstreetmap","followers_url":"https://api.github.com/users/openstreetmap/followers","following_url":"https://api.github.com/users/openstreetmap/following{/other_user}","gists_url":"https://api.github.com/users/openstreetmap/gists{/gist_id}","starred_url":"https://api.github.com/users/openstreetmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstreetmap/subscriptions","organizations_url":"https://api.github.com/users/openstreetmap/orgs","repos_url":"https://api.github.com/users/openstreetmap/repos","events_url":"https://api.github.com/users/openstreetmap/events{/privacy}","received_events_url":"https://api.github.com/users/openstreetmap/received_events","type":"Organization","site_admin":false},"repo":{"id":2564522,"name":"osmosis","full_name":"openstreetmap/osmosis","owner":{"login":"openstreetmap","id":261431,"avatar_url":"https://avatars.githubusercontent.com/u/261431?v=3","gravatar_id":"","url":"https://api.github.com/users/openstreetmap","html_url":"https://github.com/openstreetmap","followers_url":"https://api.github.com/users/openstreetmap/followers","following_url":"https://api.github.com/users/openstreetmap/following{/other_user}","gists_url":"https://api.github.com/users/openstreetmap/gists{/gist_id}","starred_url":"https://api.github.com/users/openstreetmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstreetmap/subscriptions","organizations_url":"https://api.github.com/users/openstreetmap/orgs","repos_url":"https://api.github.com/users/openstreetmap/repos","events_url":"https://api.github.com/users/openstreetmap/events{/privacy}","received_events_url":"https://api.github.com/users/openstreetmap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openstreetmap/osmosis","description":"Osmosis is a command line Java application for processing OSM data.","fork":false,"url":"https://api.github.com/repos/openstreetmap/osmosis","forks_url":"https://api.github.com/repos/openstreetmap/osmosis/forks","keys_url":"https://api.github.com/repos/openstreetmap/osmosis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openstreetmap/osmosis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openstreetmap/osmosis/teams","hooks_url":"https://api.github.com/repos/openstreetmap/osmosis/hooks","issue_events_url":"https://api.github.com/repos/openstreetmap/osmosis/issues/events{/number}","events_url":"https://api.github.com/repos/openstreetmap/osmosis/events","assignees_url":"https://api.github.com/repos/openstreetmap/osmosis/assignees{/user}","branches_url":"https://api.github.com/repos/openstreetmap/osmosis/branches{/branch}","tags_url":"https://api.github.com/repos/openstreetmap/osmosis/tags","blobs_url":"https://api.github.com/repos/openstreetmap/osmosis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openstreetmap/osmosis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openstreetmap/osmosis/git/refs{/sha}","trees_url":"https://api.github.com/repos/openstreetmap/osmosis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openstreetmap/osmosis/statuses/{sha}","languages_url":"https://api.github.com/repos/openstreetmap/osmosis/languages","stargazers_url":"https://api.github.com/repos/openstreetmap/osmosis/stargazers","contributors_url":"https://api.github.com/repos/openstreetmap/osmosis/contributors","subscribers_url":"https://api.github.com/repos/openstreetmap/osmosis/subscribers","subscription_url":"https://api.github.com/repos/openstreetmap/osmosis/subscription","commits_url":"https://api.github.com/repos/openstreetmap/osmosis/commits{/sha}","git_commits_url":"https://api.github.com/repos/openstreetmap/osmosis/git/commits{/sha}","comments_url":"https://api.github.com/repos/openstreetmap/osmosis/comments{/number}","issue_comment_url":"https://api.github.com/repos/openstreetmap/osmosis/issues/comments{/number}","contents_url":"https://api.github.com/repos/openstreetmap/osmosis/contents/{+path}","compare_url":"https://api.github.com/repos/openstreetmap/osmosis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openstreetmap/osmosis/merges","archive_url":"https://api.github.com/repos/openstreetmap/osmosis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openstreetmap/osmosis/downloads","issues_url":"https://api.github.com/repos/openstreetmap/osmosis/issues{/number}","pulls_url":"https://api.github.com/repos/openstreetmap/osmosis/pulls{/number}","milestones_url":"https://api.github.com/repos/openstreetmap/osmosis/milestones{/number}","notifications_url":"https://api.github.com/repos/openstreetmap/osmosis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openstreetmap/osmosis/labels{/name}","releases_url":"https://api.github.com/repos/openstreetmap/osmosis/releases{/id}","created_at":"2011-10-12T18:48:02Z","updated_at":"2015-05-06T13:38:13Z","pushed_at":"2015-05-07T10:41:28Z","git_url":"git://github.com/openstreetmap/osmosis.git","ssh_url":"git@github.com:openstreetmap/osmosis.git","clone_url":"https://github.com/openstreetmap/osmosis.git","svn_url":"https://github.com/openstreetmap/osmosis","homepage":"http://wiki.openstreetmap.org/wiki/Osmosis","size":17261,"stargazers_count":158,"watchers_count":158,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":2,"forks":59,"open_issues":2,"watchers":158,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openstreetmap/osmosis/pulls/18"},"html":{"href":"https://github.com/openstreetmap/osmosis/pull/18"},"issue":{"href":"https://api.github.com/repos/openstreetmap/osmosis/issues/18"},"comments":{"href":"https://api.github.com/repos/openstreetmap/osmosis/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/openstreetmap/osmosis/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/openstreetmap/osmosis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openstreetmap/osmosis/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/openstreetmap/osmosis/statuses/16ced2b416ed19630ad2d3bd9e9389f55be70224"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"brettch","id":1034364,"avatar_url":"https://avatars.githubusercontent.com/u/1034364?v=3","gravatar_id":"","url":"https://api.github.com/users/brettch","html_url":"https://github.com/brettch","followers_url":"https://api.github.com/users/brettch/followers","following_url":"https://api.github.com/users/brettch/following{/other_user}","gists_url":"https://api.github.com/users/brettch/gists{/gist_id}","starred_url":"https://api.github.com/users/brettch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettch/subscriptions","organizations_url":"https://api.github.com/users/brettch/orgs","repos_url":"https://api.github.com/users/brettch/repos","events_url":"https://api.github.com/users/brettch/events{/privacy}","received_events_url":"https://api.github.com/users/brettch/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":4,"additions":4,"deletions":2,"changed_files":2}}