{"action":"created","issue":{"url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/6455","labels_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/6455/labels{/name}","comments_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/6455/comments","events_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/6455/events","html_url":"https://github.com/borisyankov/DefinitelyTyped/pull/6455","id":113463260,"number":6455,"title":"Add support for Child Mappings","user":{"login":"richardlawley","id":1608083,"avatar_url":"https://avatars.githubusercontent.com/u/1608083?v=3","gravatar_id":"","url":"https://api.github.com/users/richardlawley","html_url":"https://github.com/richardlawley","followers_url":"https://api.github.com/users/richardlawley/followers","following_url":"https://api.github.com/users/richardlawley/following{/other_user}","gists_url":"https://api.github.com/users/richardlawley/gists{/gist_id}","starred_url":"https://api.github.com/users/richardlawley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardlawley/subscriptions","organizations_url":"https://api.github.com/users/richardlawley/orgs","repos_url":"https://api.github.com/users/richardlawley/repos","events_url":"https://api.github.com/users/richardlawley/events{/privacy}","received_events_url":"https://api.github.com/users/richardlawley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-26T22:18:50Z","updated_at":"2015-10-26T23:19:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/6455","html_url":"https://github.com/borisyankov/DefinitelyTyped/pull/6455","diff_url":"https://github.com/borisyankov/DefinitelyTyped/pull/6455.diff","patch_url":"https://github.com/borisyankov/DefinitelyTyped/pull/6455.patch"},"body":"This handles the following scenario from the Knockout Mapping tutorial:\r\n\r\n```\r\nvar mapping = {\r\n    'children': {\r\n        key: function(data) {\r\n            return ko.utils.unwrapObservable(data.id);\r\n        }\r\n    }\r\n}\r\n```\r\n\r\nWith the current version, this mapping cannot be compiled under Typescript 1.6.  My change allows this to be compiled.  I've updated the test to force a type in order to demonstrate the compile error if the change is removed.\r\n\r\nI'm aware that the indexed type is not properly typed (using any), but I'm unsure if this is possible with TS or not."},"comment":{"url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/comments/151311824","html_url":"https://github.com/borisyankov/DefinitelyTyped/pull/6455#issuecomment-151311824","issue_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/issues/6455","id":151311824,"user":{"login":"vvakame","id":125332,"avatar_url":"https://avatars.githubusercontent.com/u/125332?v=3","gravatar_id":"","url":"https://api.github.com/users/vvakame","html_url":"https://github.com/vvakame","followers_url":"https://api.github.com/users/vvakame/followers","following_url":"https://api.github.com/users/vvakame/following{/other_user}","gists_url":"https://api.github.com/users/vvakame/gists{/gist_id}","starred_url":"https://api.github.com/users/vvakame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvakame/subscriptions","organizations_url":"https://api.github.com/users/vvakame/orgs","repos_url":"https://api.github.com/users/vvakame/repos","events_url":"https://api.github.com/users/vvakame/events{/privacy}","received_events_url":"https://api.github.com/users/vvakame/received_events","type":"User","site_admin":false},"created_at":"2015-10-26T23:19:17Z","updated_at":"2015-10-26T23:19:17Z","body":"*knockout.mapping/knockout.mapping.d.ts*\r\n\r\nto author(@borisyankov). could you review this PR?\r\n:+1: or :-1:?\r\n\r\ncheck list\r\n\r\n* [ ] pass the Travic-CI test?\r\n"}}