{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/33674456","id":33674456,"diff_hunk":"@@ -258,6 +258,40 @@ bool CPVRClients::GetClientName(int iClientId, std::string &strName) const\n   return bReturn;\n }\n \n+std::vector<SBackend> CPVRClients::GetBackendProperties() const\n+{\n+  std::vector<SBackend> backendProperties;\n+  CSingleLock lock(m_critSection);\n+\n+  for (const auto &entry : m_clientMap)\n+  {\n+    const auto &client = entry.second;\n+    \n+    if (!client->ReadyToUse())\n+      continue;\n+\n+    SBackend properties;","path":"xbmc/pvr/addons/PVRClients.cpp","position":16,"original_position":16,"commit_id":"9c3adb5a9f390ad73c52469ed79de297dad68d80","original_commit_id":"282de7a9158df90b5c56e0fbc096833ae83db0b5","user":{"login":"Jalle19","id":1106133,"avatar_url":"https://avatars.githubusercontent.com/u/1106133?v=3","gravatar_id":"","url":"https://api.github.com/users/Jalle19","html_url":"https://github.com/Jalle19","followers_url":"https://api.github.com/users/Jalle19/followers","following_url":"https://api.github.com/users/Jalle19/following{/other_user}","gists_url":"https://api.github.com/users/Jalle19/gists{/gist_id}","starred_url":"https://api.github.com/users/Jalle19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jalle19/subscriptions","organizations_url":"https://api.github.com/users/Jalle19/orgs","repos_url":"https://api.github.com/users/Jalle19/repos","events_url":"https://api.github.com/users/Jalle19/events{/privacy}","received_events_url":"https://api.github.com/users/Jalle19/received_events","type":"User","site_admin":false},"body":"Basically because SBackendProperties would be one object, but what would you call a vector of those? You can't write `properties'` like in standard English.","created_at":"2015-07-01T12:49:00Z","updated_at":"2015-07-01T12:49:00Z","html_url":"https://github.com/xbmc/xbmc/pull/7291#discussion_r33674456","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7291","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/33674456"},"html":{"href":"https://github.com/xbmc/xbmc/pull/7291#discussion_r33674456"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7291"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/7291","id":37795868,"html_url":"https://github.com/xbmc/xbmc/pull/7291","diff_url":"https://github.com/xbmc/xbmc/pull/7291.diff","patch_url":"https://github.com/xbmc/xbmc/pull/7291.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/7291","number":7291,"state":"open","locked":false,"title":"[pvr] third blind attempt to fix trac #15942","user":{"login":"Jalle19","id":1106133,"avatar_url":"https://avatars.githubusercontent.com/u/1106133?v=3","gravatar_id":"","url":"https://api.github.com/users/Jalle19","html_url":"https://github.com/Jalle19","followers_url":"https://api.github.com/users/Jalle19/followers","following_url":"https://api.github.com/users/Jalle19/following{/other_user}","gists_url":"https://api.github.com/users/Jalle19/gists{/gist_id}","starred_url":"https://api.github.com/users/Jalle19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jalle19/subscriptions","organizations_url":"https://api.github.com/users/Jalle19/orgs","repos_url":"https://api.github.com/users/Jalle19/repos","events_url":"https://api.github.com/users/Jalle19/events{/privacy}","received_events_url":"https://api.github.com/users/Jalle19/received_events","type":"User","site_admin":false},"body":"ping @ksooo \r\n\r\nBasically this explicitly checks that the iterator is valid and that the pointer inside it is valid. I have no idea if it actually fixes anything or not.","created_at":"2015-06-16T13:42:54Z","updated_at":"2015-07-01T12:49:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"759db0c66fba90d078bfeec67b4bc611d2ae6cc2","assignee":null,"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/62","html_url":"https://github.com/xbmc/xbmc/milestones/Isengard%2015.0-rc1","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/62/labels","id":1101492,"number":62,"title":"Isengard 15.0-rc1","description":"","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars.githubusercontent.com/u/907436?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":75,"state":"open","created_at":"2015-05-08T07:50:40Z","updated_at":"2015-07-01T12:27:26Z","due_on":"2015-06-27T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7291/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7291/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/7291/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/9c3adb5a9f390ad73c52469ed79de297dad68d80","head":{"label":"Jalle19:pvrguinfo-sigh","ref":"pvrguinfo-sigh","sha":"9c3adb5a9f390ad73c52469ed79de297dad68d80","user":{"login":"Jalle19","id":1106133,"avatar_url":"https://avatars.githubusercontent.com/u/1106133?v=3","gravatar_id":"","url":"https://api.github.com/users/Jalle19","html_url":"https://github.com/Jalle19","followers_url":"https://api.github.com/users/Jalle19/followers","following_url":"https://api.github.com/users/Jalle19/following{/other_user}","gists_url":"https://api.github.com/users/Jalle19/gists{/gist_id}","starred_url":"https://api.github.com/users/Jalle19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jalle19/subscriptions","organizations_url":"https://api.github.com/users/Jalle19/orgs","repos_url":"https://api.github.com/users/Jalle19/repos","events_url":"https://api.github.com/users/Jalle19/events{/privacy}","received_events_url":"https://api.github.com/users/Jalle19/received_events","type":"User","site_admin":false},"repo":{"id":12298671,"name":"xbmc","full_name":"Jalle19/xbmc","owner":{"login":"Jalle19","id":1106133,"avatar_url":"https://avatars.githubusercontent.com/u/1106133?v=3","gravatar_id":"","url":"https://api.github.com/users/Jalle19","html_url":"https://github.com/Jalle19","followers_url":"https://api.github.com/users/Jalle19/followers","following_url":"https://api.github.com/users/Jalle19/following{/other_user}","gists_url":"https://api.github.com/users/Jalle19/gists{/gist_id}","starred_url":"https://api.github.com/users/Jalle19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jalle19/subscriptions","organizations_url":"https://api.github.com/users/Jalle19/orgs","repos_url":"https://api.github.com/users/Jalle19/repos","events_url":"https://api.github.com/users/Jalle19/events{/privacy}","received_events_url":"https://api.github.com/users/Jalle19/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jalle19/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/Jalle19/xbmc","forks_url":"https://api.github.com/repos/Jalle19/xbmc/forks","keys_url":"https://api.github.com/repos/Jalle19/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jalle19/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jalle19/xbmc/teams","hooks_url":"https://api.github.com/repos/Jalle19/xbmc/hooks","issue_events_url":"https://api.github.com/repos/Jalle19/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/Jalle19/xbmc/events","assignees_url":"https://api.github.com/repos/Jalle19/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/Jalle19/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/Jalle19/xbmc/tags","blobs_url":"https://api.github.com/repos/Jalle19/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jalle19/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jalle19/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jalle19/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jalle19/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/Jalle19/xbmc/languages","stargazers_url":"https://api.github.com/repos/Jalle19/xbmc/stargazers","contributors_url":"https://api.github.com/repos/Jalle19/xbmc/contributors","subscribers_url":"https://api.github.com/repos/Jalle19/xbmc/subscribers","subscription_url":"https://api.github.com/repos/Jalle19/xbmc/subscription","commits_url":"https://api.github.com/repos/Jalle19/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jalle19/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jalle19/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jalle19/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jalle19/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/Jalle19/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jalle19/xbmc/merges","archive_url":"https://api.github.com/repos/Jalle19/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jalle19/xbmc/downloads","issues_url":"https://api.github.com/repos/Jalle19/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/Jalle19/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/Jalle19/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/Jalle19/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jalle19/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/Jalle19/xbmc/releases{/id}","created_at":"2013-08-22T14:14:12Z","updated_at":"2015-05-04T07:37:16Z","pushed_at":"2015-07-01T12:44:26Z","git_url":"git://github.com/Jalle19/xbmc.git","ssh_url":"git@github.com:Jalle19/xbmc.git","clone_url":"https://github.com/Jalle19/xbmc.git","svn_url":"https://github.com/Jalle19/xbmc","homepage":"http://xbmc.org","size":520673,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"45f5f096d06a5877a874ddfd90fbbe78fc4120a9","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-06-30T13:56:34Z","pushed_at":"2015-07-01T12:44:29Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1856766,"stargazers_count":3980,"watchers_count":3980,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2899,"mirror_url":null,"open_issues_count":252,"forks":2899,"open_issues":252,"watchers":3980,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7291"},"html":{"href":"https://github.com/xbmc/xbmc/pull/7291"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7291"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7291/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7291/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7291/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/9c3adb5a9f390ad73c52469ed79de297dad68d80"}}}}