{"action":"created","comment":{"url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/pulls/comments/29280687","id":29280687,"diff_hunk":"@@ -1,41 +1,57 @@\n-<!--\n-\n-http://portal.ifbyphone.local/dom/map/index.html?st-t=localhost\n-\n--->\n <!DOCTYPE html>\n <html>\n <head lang=\"en\">\n     <meta charset=\"UTF-8\">\n-    <title>foo & bar</title>\n+    <title>Code Example</title>\n </head>\n-<html>\n <body>\n-    <div>\n-        <input type=\"text\" placeholder=\"zip code\" class=\"zip\" />\n-        <input type=\"button\" id=\"showmarkers\" value=\"search\" />\n-    </div>\n+    <!-- DIV element that map will render to. -->\n+    <div class=\"section\" id=\"map\" style=\"height: 500px; width: 600px;\"></div>\n \n-    <div id=\"map\"></div>\n+    <!-- Include Google Maps Javascript API -->\n+    <script src=\"http://maps.google.com/maps/api/js?sensor=false\"></script>\n \n-    <script type=\"text/javascript\" src=\"http://maps.google.com/maps/api/js?sensor=false\"></script>\n-    <script type=\"text/javascript\" src=\"js/jquery-1.4.1.min.js\"></script>\n-    <script type=\"text/javascript\" src=\"js/markers.js\"></script>\n+    <!-- Include example map code with SourceTrak Dynamic Number Replacement -->\n+    <script src=\"js/markers.js\"></script>\n \n+    <!-- SourceTrak Snippet -->\n     <script type=\"text/javascript\">\n-        var _stk = \"6c9a4a04484c46f8055c9cb7e6a72964e6da82d3\";\n-\n-        var _st_num_url = \"http://portal.ifbyphone.local/st\";\n-        var _st_log_url = \"http://portal.ifbyphone.local/st/log\";\n-        var _st_locations_url = \"http://portal.ifbyphone.local/st/locations\";\n+        var _stk = \"replace with your _stk value\";\n \n         (function(){\n             var a=document, b=a.createElement(\"script\"); b.type=\"text/javascript\";\n             b.async=!0; b.src=('https:'==document.location.protocol ? 'https://' :\n-                    'http://') + 'portal.ifbyphone.local/assets/st/js/st.js';\n+            'http://') + 'd31y97ze264gaa.cloudfront.net/assets/st/js/st.js';\n             a=a.getElementsByTagName(\"script\")[0]; a.parentNode.insertBefore(b,a);\n         })();\n     </script>\n \n+    <!-- Example script to create map and map marker -->\n+    <script>\n+        /*********************************************************************************\n+         * Create a Google Map using simpleMap and place a map marker with a phone number\n+         * on the map. When the marker is clicked, the phone number on the marker will be\n+         * automatically swapped with a dynamic SourceTrak tracking phone number.\n+         *********************************************************************************/\n+\n+        // Create a custom map and render it within an specified element on the page.\n+        var myMap = new simpleMap({\n+            mapElementId: 'map',\n+            lat: \"37.09024\",\n+            lng: \"-95.712891\"\n+        });\n+\n+        // Place a marker on the map, which when clicked will display (above the marker)\n+        // an information window with details such as name, address, and phone number.\n+        myMap.placeMarker({","path":"US6145-map_javascript_cleanup/index.html","position":67,"original_position":67,"commit_id":"dbd9d4ac2844ff85005ce3381baf50a9e69c7d19","original_commit_id":"4fd617388918c32c1a37991c0e32856d9298c477","user":{"login":"tdupreeibp","id":1301419,"avatar_url":"https://avatars.githubusercontent.com/u/1301419?v=3","gravatar_id":"","url":"https://api.github.com/users/tdupreeibp","html_url":"https://github.com/tdupreeibp","followers_url":"https://api.github.com/users/tdupreeibp/followers","following_url":"https://api.github.com/users/tdupreeibp/following{/other_user}","gists_url":"https://api.github.com/users/tdupreeibp/gists{/gist_id}","starred_url":"https://api.github.com/users/tdupreeibp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdupreeibp/subscriptions","organizations_url":"https://api.github.com/users/tdupreeibp/orgs","repos_url":"https://api.github.com/users/tdupreeibp/repos","events_url":"https://api.github.com/users/tdupreeibp/events{/privacy}","received_events_url":"https://api.github.com/users/tdupreeibp/received_events","type":"User","site_admin":false},"body":"note: we talked, we will just leave it as is for now (no multiple makers, no normal number on page)","created_at":"2015-04-28T19:44:56Z","updated_at":"2015-04-28T19:44:56Z","html_url":"https://github.com/cnoconibp/Miscellaneous-Tasks/pull/4#discussion_r29280687","pull_request_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/pulls/comments/29280687"},"html":{"href":"https://github.com/cnoconibp/Miscellaneous-Tasks/pull/4#discussion_r29280687"},"pull_request":{"href":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/pulls/4","id":34073274,"html_url":"https://github.com/cnoconibp/Miscellaneous-Tasks/pull/4","diff_url":"https://github.com/cnoconibp/Miscellaneous-Tasks/pull/4.diff","patch_url":"https://github.com/cnoconibp/Miscellaneous-Tasks/pull/4.patch","issue_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/issues/4","number":4,"state":"open","locked":false,"title":"US6145-Map-Javascript-Cleanup","user":{"login":"cnoconibp","id":8159433,"avatar_url":"https://avatars.githubusercontent.com/u/8159433?v=3","gravatar_id":"","url":"https://api.github.com/users/cnoconibp","html_url":"https://github.com/cnoconibp","followers_url":"https://api.github.com/users/cnoconibp/followers","following_url":"https://api.github.com/users/cnoconibp/following{/other_user}","gists_url":"https://api.github.com/users/cnoconibp/gists{/gist_id}","starred_url":"https://api.github.com/users/cnoconibp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnoconibp/subscriptions","organizations_url":"https://api.github.com/users/cnoconibp/orgs","repos_url":"https://api.github.com/users/cnoconibp/repos","events_url":"https://api.github.com/users/cnoconibp/events{/privacy}","received_events_url":"https://api.github.com/users/cnoconibp/received_events","type":"User","site_admin":false},"body":"Please review  @dscandinaro and @tdupreeibp. \r\n\r\nThe `master` branch contains a folder named `US6145-map_javascript_cleanup` that contains the original version of the files. \r\n\r\nOn this branch, `US6145-Map_Javascript_Cleanup_UPDATED`, that same folder contains the updates I made to those files.  \r\n\r\nPlease let me know if anything concerns you!  Thanks!\r\n<hr>\r\n## 1. Summary of changes to `index.html`:\r\n\r\n* Moved styles for the `#map` element into the head of this file, and out of the `markers.js` file.\r\n* Moved JS script sources to the head of the document. I believe developers will make many different decisions about the order of the resources, so I just aimed to make it easier to read.\r\n* Changed script source for jQuery to a jQuery's CDN. If the developer wants to store it locally instead of making that request, that's up to them.\r\n* Removed a redundant second opening `html` tag.\r\n* Changed the `#showmarkers` id to `#show-markers` to reflect html style conventions (adding a dash between words).\r\n* Added more descriptive placeholder text.\r\n* Added a comment above the var declarations in the ST Snippet\r\n* Spacing and alignment changes for a polished look.\r\n\r\n## 2. Summary of changes to `markers.js`:\r\n\r\n* Removed the CSS for the map size (and put it in the head of the `index.html` file instead).\r\n* Updated the references to `#showmarkers` ID so they reflected the changed `#show-markers`.\r\n* Changed multiple var definitions into a more consolidated format.\r\n* Spacing and alignment changes for a polished look and adherence to style conventions.\r\n\r\n","created_at":"2015-04-24T18:21:44Z","updated_at":"2015-04-28T19:44:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51a6d223f55c62c71be3debb931971c6cb9e8db1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/pulls/4/commits","review_comments_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/pulls/4/comments","review_comment_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/issues/4/comments","statuses_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/statuses/dbd9d4ac2844ff85005ce3381baf50a9e69c7d19","head":{"label":"cnoconibp:US6145-Map_Javascript_Cleanup_UPDATED","ref":"US6145-Map_Javascript_Cleanup_UPDATED","sha":"dbd9d4ac2844ff85005ce3381baf50a9e69c7d19","user":{"login":"cnoconibp","id":8159433,"avatar_url":"https://avatars.githubusercontent.com/u/8159433?v=3","gravatar_id":"","url":"https://api.github.com/users/cnoconibp","html_url":"https://github.com/cnoconibp","followers_url":"https://api.github.com/users/cnoconibp/followers","following_url":"https://api.github.com/users/cnoconibp/following{/other_user}","gists_url":"https://api.github.com/users/cnoconibp/gists{/gist_id}","starred_url":"https://api.github.com/users/cnoconibp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnoconibp/subscriptions","organizations_url":"https://api.github.com/users/cnoconibp/orgs","repos_url":"https://api.github.com/users/cnoconibp/repos","events_url":"https://api.github.com/users/cnoconibp/events{/privacy}","received_events_url":"https://api.github.com/users/cnoconibp/received_events","type":"User","site_admin":false},"repo":{"id":34483722,"name":"Miscellaneous-Tasks","full_name":"cnoconibp/Miscellaneous-Tasks","owner":{"login":"cnoconibp","id":8159433,"avatar_url":"https://avatars.githubusercontent.com/u/8159433?v=3","gravatar_id":"","url":"https://api.github.com/users/cnoconibp","html_url":"https://github.com/cnoconibp","followers_url":"https://api.github.com/users/cnoconibp/followers","following_url":"https://api.github.com/users/cnoconibp/following{/other_user}","gists_url":"https://api.github.com/users/cnoconibp/gists{/gist_id}","starred_url":"https://api.github.com/users/cnoconibp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnoconibp/subscriptions","organizations_url":"https://api.github.com/users/cnoconibp/orgs","repos_url":"https://api.github.com/users/cnoconibp/repos","events_url":"https://api.github.com/users/cnoconibp/events{/privacy}","received_events_url":"https://api.github.com/users/cnoconibp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cnoconibp/Miscellaneous-Tasks","description":"Dom's code before I touched it.","fork":false,"url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks","forks_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/forks","keys_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/teams","hooks_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/hooks","issue_events_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/issues/events{/number}","events_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/events","assignees_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/assignees{/user}","branches_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/branches{/branch}","tags_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/tags","blobs_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/languages","stargazers_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/stargazers","contributors_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/contributors","subscribers_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/subscribers","subscription_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/subscription","commits_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/contents/{+path}","compare_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/merges","archive_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/downloads","issues_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/issues{/number}","pulls_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/labels{/name}","releases_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/releases{/id}","created_at":"2015-04-23T21:59:19Z","updated_at":"2015-04-27T17:43:54Z","pushed_at":"2015-04-28T19:41:55Z","git_url":"git://github.com/cnoconibp/Miscellaneous-Tasks.git","ssh_url":"git@github.com:cnoconibp/Miscellaneous-Tasks.git","clone_url":"https://github.com/cnoconibp/Miscellaneous-Tasks.git","svn_url":"https://github.com/cnoconibp/Miscellaneous-Tasks","homepage":null,"size":340,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"cnoconibp:master","ref":"master","sha":"29eab5043afb57d04a59771dc3204ff7eb02717e","user":{"login":"cnoconibp","id":8159433,"avatar_url":"https://avatars.githubusercontent.com/u/8159433?v=3","gravatar_id":"","url":"https://api.github.com/users/cnoconibp","html_url":"https://github.com/cnoconibp","followers_url":"https://api.github.com/users/cnoconibp/followers","following_url":"https://api.github.com/users/cnoconibp/following{/other_user}","gists_url":"https://api.github.com/users/cnoconibp/gists{/gist_id}","starred_url":"https://api.github.com/users/cnoconibp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnoconibp/subscriptions","organizations_url":"https://api.github.com/users/cnoconibp/orgs","repos_url":"https://api.github.com/users/cnoconibp/repos","events_url":"https://api.github.com/users/cnoconibp/events{/privacy}","received_events_url":"https://api.github.com/users/cnoconibp/received_events","type":"User","site_admin":false},"repo":{"id":34483722,"name":"Miscellaneous-Tasks","full_name":"cnoconibp/Miscellaneous-Tasks","owner":{"login":"cnoconibp","id":8159433,"avatar_url":"https://avatars.githubusercontent.com/u/8159433?v=3","gravatar_id":"","url":"https://api.github.com/users/cnoconibp","html_url":"https://github.com/cnoconibp","followers_url":"https://api.github.com/users/cnoconibp/followers","following_url":"https://api.github.com/users/cnoconibp/following{/other_user}","gists_url":"https://api.github.com/users/cnoconibp/gists{/gist_id}","starred_url":"https://api.github.com/users/cnoconibp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnoconibp/subscriptions","organizations_url":"https://api.github.com/users/cnoconibp/orgs","repos_url":"https://api.github.com/users/cnoconibp/repos","events_url":"https://api.github.com/users/cnoconibp/events{/privacy}","received_events_url":"https://api.github.com/users/cnoconibp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cnoconibp/Miscellaneous-Tasks","description":"Dom's code before I touched it.","fork":false,"url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks","forks_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/forks","keys_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/teams","hooks_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/hooks","issue_events_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/issues/events{/number}","events_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/events","assignees_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/assignees{/user}","branches_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/branches{/branch}","tags_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/tags","blobs_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/languages","stargazers_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/stargazers","contributors_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/contributors","subscribers_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/subscribers","subscription_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/subscription","commits_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/contents/{+path}","compare_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/merges","archive_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/downloads","issues_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/issues{/number}","pulls_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/labels{/name}","releases_url":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/releases{/id}","created_at":"2015-04-23T21:59:19Z","updated_at":"2015-04-27T17:43:54Z","pushed_at":"2015-04-28T19:41:55Z","git_url":"git://github.com/cnoconibp/Miscellaneous-Tasks.git","ssh_url":"git@github.com:cnoconibp/Miscellaneous-Tasks.git","clone_url":"https://github.com/cnoconibp/Miscellaneous-Tasks.git","svn_url":"https://github.com/cnoconibp/Miscellaneous-Tasks","homepage":null,"size":340,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/pulls/4"},"html":{"href":"https://github.com/cnoconibp/Miscellaneous-Tasks/pull/4"},"issue":{"href":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/issues/4"},"comments":{"href":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/cnoconibp/Miscellaneous-Tasks/statuses/dbd9d4ac2844ff85005ce3381baf50a9e69c7d19"}}}}