{"action":"created","comment":{"url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/comments/38464858","id":38464858,"diff_hunk":"@@ -40,3 +43,4 @@\n <link rel=\"import\" href=\"labrad-server.html\">\n <link rel=\"import\" href=\"menu-button.html\">\n <link rel=\"import\" href=\"selectable-table.html\">\n+<link rel=\"import\" href=\"expandable-input.html\">","path":"client-js/app/elements/elements.html","position":26,"original_position":26,"commit_id":"4a269ff6c3c034381a0d065c7ced5e4a0c927a26","original_commit_id":"4a269ff6c3c034381a0d065c7ced5e4a0c927a26","user":{"login":"joshmutus","id":8173925,"avatar_url":"https://avatars.githubusercontent.com/u/8173925?v=3","gravatar_id":"","url":"https://api.github.com/users/joshmutus","html_url":"https://github.com/joshmutus","followers_url":"https://api.github.com/users/joshmutus/followers","following_url":"https://api.github.com/users/joshmutus/following{/other_user}","gists_url":"https://api.github.com/users/joshmutus/gists{/gist_id}","starred_url":"https://api.github.com/users/joshmutus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshmutus/subscriptions","organizations_url":"https://api.github.com/users/joshmutus/orgs","repos_url":"https://api.github.com/users/joshmutus/repos","events_url":"https://api.github.com/users/joshmutus/events{/privacy}","received_events_url":"https://api.github.com/users/joshmutus/received_events","type":"User","site_admin":false},"body":"Agreed. I had no idea where this convention came from, I has just following suit.","created_at":"2015-09-01T20:06:07Z","updated_at":"2015-09-01T20:06:07Z","html_url":"https://github.com/labrad/scalabrad-web/pull/37#discussion_r38464858","pull_request_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/comments/38464858"},"html":{"href":"https://github.com/labrad/scalabrad-web/pull/37#discussion_r38464858"},"pull_request":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/37","id":43834886,"html_url":"https://github.com/labrad/scalabrad-web/pull/37","diff_url":"https://github.com/labrad/scalabrad-web/pull/37.diff","patch_url":"https://github.com/labrad/scalabrad-web/pull/37.patch","issue_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/37","number":37,"state":"open","locked":false,"title":"Creat expandable dialog","user":{"login":"joshmutus","id":8173925,"avatar_url":"https://avatars.githubusercontent.com/u/8173925?v=3","gravatar_id":"","url":"https://api.github.com/users/joshmutus","html_url":"https://github.com/joshmutus","followers_url":"https://api.github.com/users/joshmutus/followers","following_url":"https://api.github.com/users/joshmutus/following{/other_user}","gists_url":"https://api.github.com/users/joshmutus/gists{/gist_id}","starred_url":"https://api.github.com/users/joshmutus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshmutus/subscriptions","organizations_url":"https://api.github.com/users/joshmutus/orgs","repos_url":"https://api.github.com/users/joshmutus/repos","events_url":"https://api.github.com/users/joshmutus/events{/privacy}","received_events_url":"https://api.github.com/users/joshmutus/received_events","type":"User","site_admin":false},"body":"***Have to update Polymer to 1.1.2*** ``` $ bower update ``` should do the trick\r\n\r\nThis fixes https://github.com/labrad/scalabrad-web/issues/32 \r\nAdds a new component which displays shortened value for really long values. When clicked on this reveals a mutli-line input dialog which is in focus. Submits with 'enter' key. \r\n\r\nIt's a simple enough component that I left the logic as inline javascript, could convert to ts if need be. \r\n\r\nThere are a few lame behaviours that need to be ironed out: enter, still briefly adds a newline which is ignored; formatting is different than other \"Material design\" stuff. But popular opinion is that we should move away from this, so I'm leaving it for now.\r\n\r\n","created_at":"2015-09-01T03:50:31Z","updated_at":"2015-09-01T20:06:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b4651f41b93421be07b048722107bcc8aeae49a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/37/commits","review_comments_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/37/comments","review_comment_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/37/comments","statuses_url":"https://api.github.com/repos/labrad/scalabrad-web/statuses/4a269ff6c3c034381a0d065c7ced5e4a0c927a26","head":{"label":"labrad:32-expandable-dialog","ref":"32-expandable-dialog","sha":"4a269ff6c3c034381a0d065c7ced5e4a0c927a26","user":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"repo":{"id":32440005,"name":"scalabrad-web","full_name":"labrad/scalabrad-web","owner":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/labrad/scalabrad-web","description":"A web interface for labrad","fork":false,"url":"https://api.github.com/repos/labrad/scalabrad-web","forks_url":"https://api.github.com/repos/labrad/scalabrad-web/forks","keys_url":"https://api.github.com/repos/labrad/scalabrad-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/labrad/scalabrad-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/labrad/scalabrad-web/teams","hooks_url":"https://api.github.com/repos/labrad/scalabrad-web/hooks","issue_events_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/events{/number}","events_url":"https://api.github.com/repos/labrad/scalabrad-web/events","assignees_url":"https://api.github.com/repos/labrad/scalabrad-web/assignees{/user}","branches_url":"https://api.github.com/repos/labrad/scalabrad-web/branches{/branch}","tags_url":"https://api.github.com/repos/labrad/scalabrad-web/tags","blobs_url":"https://api.github.com/repos/labrad/scalabrad-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/labrad/scalabrad-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/labrad/scalabrad-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/labrad/scalabrad-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/labrad/scalabrad-web/statuses/{sha}","languages_url":"https://api.github.com/repos/labrad/scalabrad-web/languages","stargazers_url":"https://api.github.com/repos/labrad/scalabrad-web/stargazers","contributors_url":"https://api.github.com/repos/labrad/scalabrad-web/contributors","subscribers_url":"https://api.github.com/repos/labrad/scalabrad-web/subscribers","subscription_url":"https://api.github.com/repos/labrad/scalabrad-web/subscription","commits_url":"https://api.github.com/repos/labrad/scalabrad-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/labrad/scalabrad-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/labrad/scalabrad-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/labrad/scalabrad-web/contents/{+path}","compare_url":"https://api.github.com/repos/labrad/scalabrad-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/labrad/scalabrad-web/merges","archive_url":"https://api.github.com/repos/labrad/scalabrad-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/labrad/scalabrad-web/downloads","issues_url":"https://api.github.com/repos/labrad/scalabrad-web/issues{/number}","pulls_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls{/number}","milestones_url":"https://api.github.com/repos/labrad/scalabrad-web/milestones{/number}","notifications_url":"https://api.github.com/repos/labrad/scalabrad-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/labrad/scalabrad-web/labels{/name}","releases_url":"https://api.github.com/repos/labrad/scalabrad-web/releases{/id}","created_at":"2015-03-18T05:34:53Z","updated_at":"2015-07-21T20:46:06Z","pushed_at":"2015-09-01T03:50:31Z","git_url":"git://github.com/labrad/scalabrad-web.git","ssh_url":"git@github.com:labrad/scalabrad-web.git","clone_url":"https://github.com/labrad/scalabrad-web.git","svn_url":"https://github.com/labrad/scalabrad-web","homepage":"","size":1064,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"labrad:master","ref":"master","sha":"ecb8d772ad6169ff0be40b86ceb2770ee949b0aa","user":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"repo":{"id":32440005,"name":"scalabrad-web","full_name":"labrad/scalabrad-web","owner":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/labrad/scalabrad-web","description":"A web interface for labrad","fork":false,"url":"https://api.github.com/repos/labrad/scalabrad-web","forks_url":"https://api.github.com/repos/labrad/scalabrad-web/forks","keys_url":"https://api.github.com/repos/labrad/scalabrad-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/labrad/scalabrad-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/labrad/scalabrad-web/teams","hooks_url":"https://api.github.com/repos/labrad/scalabrad-web/hooks","issue_events_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/events{/number}","events_url":"https://api.github.com/repos/labrad/scalabrad-web/events","assignees_url":"https://api.github.com/repos/labrad/scalabrad-web/assignees{/user}","branches_url":"https://api.github.com/repos/labrad/scalabrad-web/branches{/branch}","tags_url":"https://api.github.com/repos/labrad/scalabrad-web/tags","blobs_url":"https://api.github.com/repos/labrad/scalabrad-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/labrad/scalabrad-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/labrad/scalabrad-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/labrad/scalabrad-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/labrad/scalabrad-web/statuses/{sha}","languages_url":"https://api.github.com/repos/labrad/scalabrad-web/languages","stargazers_url":"https://api.github.com/repos/labrad/scalabrad-web/stargazers","contributors_url":"https://api.github.com/repos/labrad/scalabrad-web/contributors","subscribers_url":"https://api.github.com/repos/labrad/scalabrad-web/subscribers","subscription_url":"https://api.github.com/repos/labrad/scalabrad-web/subscription","commits_url":"https://api.github.com/repos/labrad/scalabrad-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/labrad/scalabrad-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/labrad/scalabrad-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/labrad/scalabrad-web/contents/{+path}","compare_url":"https://api.github.com/repos/labrad/scalabrad-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/labrad/scalabrad-web/merges","archive_url":"https://api.github.com/repos/labrad/scalabrad-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/labrad/scalabrad-web/downloads","issues_url":"https://api.github.com/repos/labrad/scalabrad-web/issues{/number}","pulls_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls{/number}","milestones_url":"https://api.github.com/repos/labrad/scalabrad-web/milestones{/number}","notifications_url":"https://api.github.com/repos/labrad/scalabrad-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/labrad/scalabrad-web/labels{/name}","releases_url":"https://api.github.com/repos/labrad/scalabrad-web/releases{/id}","created_at":"2015-03-18T05:34:53Z","updated_at":"2015-07-21T20:46:06Z","pushed_at":"2015-09-01T03:50:31Z","git_url":"git://github.com/labrad/scalabrad-web.git","ssh_url":"git@github.com:labrad/scalabrad-web.git","clone_url":"https://github.com/labrad/scalabrad-web.git","svn_url":"https://github.com/labrad/scalabrad-web","homepage":"","size":1064,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/37"},"html":{"href":"https://github.com/labrad/scalabrad-web/pull/37"},"issue":{"href":"https://api.github.com/repos/labrad/scalabrad-web/issues/37"},"comments":{"href":"https://api.github.com/repos/labrad/scalabrad-web/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/labrad/scalabrad-web/statuses/4a269ff6c3c034381a0d065c7ced5e4a0c927a26"}}}}