{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/47097075","id":47097075,"diff_hunk":"@@ -34,35 +34,20 @@ def self.find(cnt, *args)\n       .to_a\n   end\n \n-  def self.default_time_profile(ext_options)\n-    if (tz = Metric::Helper.get_time_zone(ext_options))\n-      # Determine if this search falls into an existing valid TimeProfile\n-      TimeProfile.rollup_daily_metrics.find_all_with_entire_tz.detect { |p| p.tz_or_default == tz }\n-    end\n-  end\n-\n   def self.find_entries(ext_options)\n     ext_options ||= {}\n-    ext_options[:time_profile] ||= default_time_profile(ext_options)\n-\n-    find_by_time_profile(ext_options)\n+    find_by_time_profile(ext_options[:class], ext_options[:time_profile], ext_options[:tz])\n   end\n \n-  def self.find_by_time_profile(ext_options)\n-    klass = ext_options[:class] || MetricRollup\n-\n-    # Support for multi-region DB. We need to try to find a time profile in each\n-    # region that matches the selected profile to ensure that we get results for\n-    # all the regions in the database. We only want one match from each region\n-    # otherwise we'll end up with duplicate daily rows.\n-    if (tp = ext_options[:time_profile]) && tp.rollup_daily_metrics\n-      tps = TimeProfile.rollup_daily_metrics.select { |p| p.profile == tp.profile }.group_by(&:region_id).values.flatten\n-      tp_ids = tps.collect(&:id)\n+  # @param klass [Class] class for metrics (default: MetricRollup)\n+  # @param tp [TimeProfile]\n+  # @param tz [Timezone] (default: DEFUULTf)\n+  def self.find_by_time_profile(klass, time_profile, tz = nil)","path":"app/models/vim_performance_daily.rb","position":41,"original_position":41,"commit_id":"79ce87b2a098e2f27fb4033dcf4c367fde9678ba","original_commit_id":"79ce87b2a098e2f27fb4033dcf4c367fde9678ba","user":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"body":"1. I did not feel comfortable changing the signature of `find_entries`\r\n2. I was hoping that people would use this more like a scope, and we got rid `ext_options`.\r\n\r\nI Guess I was thinking that if we can get rid of `ext_options` and `find`, then that will make sure we are using associations and not using find or legacy accessors.","created_at":"2015-12-09T14:35:48Z","updated_at":"2015-12-09T14:35:48Z","html_url":"https://github.com/ManageIQ/manageiq/pull/5763#discussion_r47097075","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5763","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/47097075"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/5763#discussion_r47097075"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5763"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5763","id":53049036,"html_url":"https://github.com/ManageIQ/manageiq/pull/5763","diff_url":"https://github.com/ManageIQ/manageiq/pull/5763.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/5763.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5763","number":5763,"state":"open","locked":false,"title":"vim_performance_daily extract time_profile options","user":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"body":"High level: Use scopes/relations and get away from `find`\r\n\r\nvim_performance_daily extract time_profile options\r\n\r\nIntroduce a scope so it can be used as a traditional AR scope / model\r\n\r\n/cc @matthewd rails5 love (and performance too)","created_at":"2015-12-08T22:31:18Z","updated_at":"2015-12-09T14:35:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49db919bc45245acc7e1c62021ff9f08754b8f47","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5763/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5763/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5763/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/79ce87b2a098e2f27fb4033dcf4c367fde9678ba","head":{"label":"kbrock:vim_performance_daily_fixup","ref":"vim_performance_daily_fixup","sha":"79ce87b2a098e2f27fb4033dcf4c367fde9678ba","user":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"repo":{"id":20886492,"name":"manageiq","full_name":"kbrock/manageiq","owner":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kbrock/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/kbrock/manageiq","forks_url":"https://api.github.com/repos/kbrock/manageiq/forks","keys_url":"https://api.github.com/repos/kbrock/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbrock/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbrock/manageiq/teams","hooks_url":"https://api.github.com/repos/kbrock/manageiq/hooks","issue_events_url":"https://api.github.com/repos/kbrock/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/kbrock/manageiq/events","assignees_url":"https://api.github.com/repos/kbrock/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/kbrock/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/kbrock/manageiq/tags","blobs_url":"https://api.github.com/repos/kbrock/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbrock/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbrock/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbrock/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbrock/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/kbrock/manageiq/languages","stargazers_url":"https://api.github.com/repos/kbrock/manageiq/stargazers","contributors_url":"https://api.github.com/repos/kbrock/manageiq/contributors","subscribers_url":"https://api.github.com/repos/kbrock/manageiq/subscribers","subscription_url":"https://api.github.com/repos/kbrock/manageiq/subscription","commits_url":"https://api.github.com/repos/kbrock/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbrock/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbrock/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbrock/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbrock/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/kbrock/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbrock/manageiq/merges","archive_url":"https://api.github.com/repos/kbrock/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbrock/manageiq/downloads","issues_url":"https://api.github.com/repos/kbrock/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/kbrock/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/kbrock/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/kbrock/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbrock/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/kbrock/manageiq/releases{/id}","created_at":"2014-06-16T13:49:17Z","updated_at":"2015-05-07T20:40:10Z","pushed_at":"2015-12-09T04:53:09Z","git_url":"git://github.com/kbrock/manageiq.git","ssh_url":"git@github.com:kbrock/manageiq.git","clone_url":"https://github.com/kbrock/manageiq.git","svn_url":"https://github.com/kbrock/manageiq","homepage":null,"size":97115,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"a918d3d3f67849397ac4d81e749537f1e12d2be2","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-12-08T16:36:03Z","pushed_at":"2015-12-09T14:15:33Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":131647,"stargazers_count":175,"watchers_count":175,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":192,"mirror_url":null,"open_issues_count":469,"forks":192,"open_issues":469,"watchers":175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5763"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/5763"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/5763"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/5763/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5763/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5763/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/79ce87b2a098e2f27fb4033dcf4c367fde9678ba"}}}}