{"action":"created","comment":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments/35231944","id":35231944,"diff_hunk":"@@ -8,6 +8,7 @@ The `$modal` service has only one method: `open(options)` where available option\n * `scope` - a scope instance to be used for the modal's content (actually the `$modal` service is going to create a child scope of a provided scope). Defaults to `$rootScope`\n * `controller` - a controller for a modal instance - it can initialize scope used by modal. Accepts the \"controller-as\" syntax in the form 'SomeCtrl as myctrl'; can be injected with `$modalInstance`\n * `controllerAs` - an alternative to the controller-as syntax, matching the API of directive definitions. Requires the `controller` option to be provided as well\n+* `bindToController` - when used with `controllerAs` & set to `true`, it will bind the controller properties onto the `$scope` directly","path":"src/modal/docs/readme.md","position":4,"original_position":4,"commit_id":"cabf4b92475e9c5488b66ae5ece8310e56a6d53e","original_commit_id":"cabf4b92475e9c5488b66ae5ece8310e56a6d53e","user":{"login":"Foxandxss","id":1087957,"avatar_url":"https://avatars.githubusercontent.com/u/1087957?v=3","gravatar_id":"","url":"https://api.github.com/users/Foxandxss","html_url":"https://github.com/Foxandxss","followers_url":"https://api.github.com/users/Foxandxss/followers","following_url":"https://api.github.com/users/Foxandxss/following{/other_user}","gists_url":"https://api.github.com/users/Foxandxss/gists{/gist_id}","starred_url":"https://api.github.com/users/Foxandxss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Foxandxss/subscriptions","organizations_url":"https://api.github.com/users/Foxandxss/orgs","repos_url":"https://api.github.com/users/Foxandxss/repos","events_url":"https://api.github.com/users/Foxandxss/events{/privacy}","received_events_url":"https://api.github.com/users/Foxandxss/received_events","type":"User","site_admin":false},"body":"onto the `$scope` or onto `this.` ?","created_at":"2015-07-22T16:20:10Z","updated_at":"2015-07-22T16:20:10Z","html_url":"https://github.com/angular-ui/bootstrap/pull/3965#discussion_r35231944","pull_request_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3965","_links":{"self":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments/35231944"},"html":{"href":"https://github.com/angular-ui/bootstrap/pull/3965#discussion_r35231944"},"pull_request":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3965"}}},"pull_request":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3965","id":40305405,"html_url":"https://github.com/angular-ui/bootstrap/pull/3965","diff_url":"https://github.com/angular-ui/bootstrap/pull/3965.diff","patch_url":"https://github.com/angular-ui/bootstrap/pull/3965.patch","issue_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/3965","number":3965,"state":"open","locked":false,"title":"feat(modal): add support for bindToController","user":{"login":"wesleycho","id":1703387,"avatar_url":"https://avatars.githubusercontent.com/u/1703387?v=3","gravatar_id":"","url":"https://api.github.com/users/wesleycho","html_url":"https://github.com/wesleycho","followers_url":"https://api.github.com/users/wesleycho/followers","following_url":"https://api.github.com/users/wesleycho/following{/other_user}","gists_url":"https://api.github.com/users/wesleycho/gists{/gist_id}","starred_url":"https://api.github.com/users/wesleycho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesleycho/subscriptions","organizations_url":"https://api.github.com/users/wesleycho/orgs","repos_url":"https://api.github.com/users/wesleycho/repos","events_url":"https://api.github.com/users/wesleycho/events{/privacy}","received_events_url":"https://api.github.com/users/wesleycho/received_events","type":"User","site_admin":false},"body":"- Add `bindToController` support in modal options\r\n\r\nThis implements #3404.","created_at":"2015-07-19T09:02:43Z","updated_at":"2015-07-22T16:20:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99b163d6e4aefe56632e7a514ed689ce7e459f5b","assignee":null,"milestone":{"url":"https://api.github.com/repos/angular-ui/bootstrap/milestones/20","html_url":"https://github.com/angular-ui/bootstrap/milestones/0.13.1%20(Performance)","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/milestones/20/labels","id":1040683,"number":20,"title":"0.13.1 (Performance)","description":"Performance tweaks and fixes for 0.13 .","creator":{"login":"chrisirhc","id":132584,"avatar_url":"https://avatars.githubusercontent.com/u/132584?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisirhc","html_url":"https://github.com/chrisirhc","followers_url":"https://api.github.com/users/chrisirhc/followers","following_url":"https://api.github.com/users/chrisirhc/following{/other_user}","gists_url":"https://api.github.com/users/chrisirhc/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisirhc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisirhc/subscriptions","organizations_url":"https://api.github.com/users/chrisirhc/orgs","repos_url":"https://api.github.com/users/chrisirhc/repos","events_url":"https://api.github.com/users/chrisirhc/events{/privacy}","received_events_url":"https://api.github.com/users/chrisirhc/received_events","type":"User","site_admin":false},"open_issues":54,"closed_issues":72,"state":"open","created_at":"2015-03-26T20:06:14Z","updated_at":"2015-07-22T13:26:24Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3965/commits","review_comments_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3965/comments","review_comment_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/3965/comments","statuses_url":"https://api.github.com/repos/angular-ui/bootstrap/statuses/cabf4b92475e9c5488b66ae5ece8310e56a6d53e","head":{"label":"wesleycho:feat/modal-bindToController","ref":"feat/modal-bindToController","sha":"cabf4b92475e9c5488b66ae5ece8310e56a6d53e","user":{"login":"wesleycho","id":1703387,"avatar_url":"https://avatars.githubusercontent.com/u/1703387?v=3","gravatar_id":"","url":"https://api.github.com/users/wesleycho","html_url":"https://github.com/wesleycho","followers_url":"https://api.github.com/users/wesleycho/followers","following_url":"https://api.github.com/users/wesleycho/following{/other_user}","gists_url":"https://api.github.com/users/wesleycho/gists{/gist_id}","starred_url":"https://api.github.com/users/wesleycho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesleycho/subscriptions","organizations_url":"https://api.github.com/users/wesleycho/orgs","repos_url":"https://api.github.com/users/wesleycho/repos","events_url":"https://api.github.com/users/wesleycho/events{/privacy}","received_events_url":"https://api.github.com/users/wesleycho/received_events","type":"User","site_admin":false},"repo":{"id":16161459,"name":"bootstrap","full_name":"wesleycho/bootstrap","owner":{"login":"wesleycho","id":1703387,"avatar_url":"https://avatars.githubusercontent.com/u/1703387?v=3","gravatar_id":"","url":"https://api.github.com/users/wesleycho","html_url":"https://github.com/wesleycho","followers_url":"https://api.github.com/users/wesleycho/followers","following_url":"https://api.github.com/users/wesleycho/following{/other_user}","gists_url":"https://api.github.com/users/wesleycho/gists{/gist_id}","starred_url":"https://api.github.com/users/wesleycho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesleycho/subscriptions","organizations_url":"https://api.github.com/users/wesleycho/orgs","repos_url":"https://api.github.com/users/wesleycho/repos","events_url":"https://api.github.com/users/wesleycho/events{/privacy}","received_events_url":"https://api.github.com/users/wesleycho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wesleycho/bootstrap","description":"Native AngularJS (Angular) directives for Twitter's Bootstrap. Small footprint (5kB gzipped!), no 3rd party JS dependencies (jQuery, bootstrap JS) required!","fork":true,"url":"https://api.github.com/repos/wesleycho/bootstrap","forks_url":"https://api.github.com/repos/wesleycho/bootstrap/forks","keys_url":"https://api.github.com/repos/wesleycho/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wesleycho/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wesleycho/bootstrap/teams","hooks_url":"https://api.github.com/repos/wesleycho/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/wesleycho/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/wesleycho/bootstrap/events","assignees_url":"https://api.github.com/repos/wesleycho/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/wesleycho/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/wesleycho/bootstrap/tags","blobs_url":"https://api.github.com/repos/wesleycho/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wesleycho/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wesleycho/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/wesleycho/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wesleycho/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/wesleycho/bootstrap/languages","stargazers_url":"https://api.github.com/repos/wesleycho/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/wesleycho/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/wesleycho/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/wesleycho/bootstrap/subscription","commits_url":"https://api.github.com/repos/wesleycho/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/wesleycho/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/wesleycho/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/wesleycho/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/wesleycho/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/wesleycho/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wesleycho/bootstrap/merges","archive_url":"https://api.github.com/repos/wesleycho/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wesleycho/bootstrap/downloads","issues_url":"https://api.github.com/repos/wesleycho/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/wesleycho/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/wesleycho/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/wesleycho/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wesleycho/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/wesleycho/bootstrap/releases{/id}","created_at":"2014-01-23T03:43:26Z","updated_at":"2015-03-15T14:40:20Z","pushed_at":"2015-07-20T13:34:25Z","git_url":"git://github.com/wesleycho/bootstrap.git","ssh_url":"git@github.com:wesleycho/bootstrap.git","clone_url":"https://github.com/wesleycho/bootstrap.git","svn_url":"https://github.com/wesleycho/bootstrap","homepage":"http://angular-ui.github.io/bootstrap/","size":4285,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular-ui:master","ref":"master","sha":"92551342cc36c0f655a4b47bda4c46d196736d83","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":6094683,"name":"bootstrap","full_name":"angular-ui/bootstrap","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/bootstrap","description":"Native AngularJS (Angular) directives for Bootstrap. Small footprint (5kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!","fork":false,"url":"https://api.github.com/repos/angular-ui/bootstrap","forks_url":"https://api.github.com/repos/angular-ui/bootstrap/forks","keys_url":"https://api.github.com/repos/angular-ui/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/bootstrap/teams","hooks_url":"https://api.github.com/repos/angular-ui/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/bootstrap/events","assignees_url":"https://api.github.com/repos/angular-ui/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/bootstrap/tags","blobs_url":"https://api.github.com/repos/angular-ui/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/bootstrap/languages","stargazers_url":"https://api.github.com/repos/angular-ui/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/bootstrap/subscription","commits_url":"https://api.github.com/repos/angular-ui/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular-ui/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/bootstrap/merges","archive_url":"https://api.github.com/repos/angular-ui/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/bootstrap/downloads","issues_url":"https://api.github.com/repos/angular-ui/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/bootstrap/releases{/id}","created_at":"2012-10-05T18:27:01Z","updated_at":"2015-07-22T09:07:51Z","pushed_at":"2015-07-22T13:26:16Z","git_url":"git://github.com/angular-ui/bootstrap.git","ssh_url":"git@github.com:angular-ui/bootstrap.git","clone_url":"https://github.com/angular-ui/bootstrap.git","svn_url":"https://github.com/angular-ui/bootstrap","homepage":"http://angular-ui.github.io/bootstrap/","size":21953,"stargazers_count":9567,"watchers_count":9567,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5021,"mirror_url":null,"open_issues_count":571,"forks":5021,"open_issues":571,"watchers":9567,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3965"},"html":{"href":"https://github.com/angular-ui/bootstrap/pull/3965"},"issue":{"href":"https://api.github.com/repos/angular-ui/bootstrap/issues/3965"},"comments":{"href":"https://api.github.com/repos/angular-ui/bootstrap/issues/3965/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3965/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3965/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/bootstrap/statuses/cabf4b92475e9c5488b66ae5ece8310e56a6d53e"}}}}