{"action":"created","comment":{"url":"https://api.github.com/repos/divolte/divolte-collector/pulls/comments/26033950","id":26033950,"diff_hunk":"@@ -49,20 +45,20 @@\n     private final Optional<KafkaFlushingPool> kafkaPool;\n     private final Optional<HdfsFlushingPool> hdfsPool;\n \n-    public IncomingRequestProcessingPool() {\n-        this(ConfigFactory.load(), (e,b,r) -> {});\n-    }\n+//    public IncomingRequestProcessingPool() {\n+//        this(ConfigFactory.load(), (e,b,r) -> {});\n+//    }","path":"src/main/java/io/divolte/server/IncomingRequestProcessingPool.java","position":27,"original_position":27,"commit_id":"e7124574c8fac31bce069bdc2142a7f08084b74b","original_commit_id":"e7124574c8fac31bce069bdc2142a7f08084b74b","user":{"login":"friso","id":273638,"avatar_url":"https://avatars.githubusercontent.com/u/273638?v=3","gravatar_id":"","url":"https://api.github.com/users/friso","html_url":"https://github.com/friso","followers_url":"https://api.github.com/users/friso/followers","following_url":"https://api.github.com/users/friso/following{/other_user}","gists_url":"https://api.github.com/users/friso/gists{/gist_id}","starred_url":"https://api.github.com/users/friso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friso/subscriptions","organizations_url":"https://api.github.com/users/friso/orgs","repos_url":"https://api.github.com/users/friso/repos","events_url":"https://api.github.com/users/friso/events{/privacy}","received_events_url":"https://api.github.com/users/friso/received_events","type":"User","site_admin":false},"body":"Hmm... It is apparently untouched and the build is green, so I think it's\nout.\n\nOn Mon, Mar 9, 2015 at 1:56 PM, Andrew Snare <notifications@github.com>\nwrote:\n\n> In src/main/java/io/divolte/server/IncomingRequestProcessingPool.java\n> <https://github.com/divolte/divolte-collector/pull/85#discussion_r26032804>\n> :\n>\n> > @@ -49,20 +45,20 @@\n> >      private final Optional<KafkaFlushingPool> kafkaPool;\n> >      private final Optional<HdfsFlushingPool> hdfsPool;\n> >\n> > -    public IncomingRequestProcessingPool() {\n> > -        this(ConfigFactory.load(), (e,b,r) -> {});\n> > -    }\n> > +//    public IncomingRequestProcessingPool() {\n> > +//        this(ConfigFactory.load(), (e,b,r) -> {});\n> > +//    }\n>\n> Is this code in or out? :)\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/divolte/divolte-collector/pull/85/files#r26032804>.\n>\n","created_at":"2015-03-09T13:17:03Z","updated_at":"2015-03-09T13:17:03Z","html_url":"https://github.com/divolte/divolte-collector/pull/85#discussion_r26033950","pull_request_url":"https://api.github.com/repos/divolte/divolte-collector/pulls/85","_links":{"self":{"href":"https://api.github.com/repos/divolte/divolte-collector/pulls/comments/26033950"},"html":{"href":"https://github.com/divolte/divolte-collector/pull/85#discussion_r26033950"},"pull_request":{"href":"https://api.github.com/repos/divolte/divolte-collector/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/divolte/divolte-collector/pulls/85","id":30756558,"html_url":"https://github.com/divolte/divolte-collector/pull/85","diff_url":"https://github.com/divolte/divolte-collector/pull/85.diff","patch_url":"https://github.com/divolte/divolte-collector/pull/85.patch","issue_url":"https://api.github.com/repos/divolte/divolte-collector/issues/85","number":85,"state":"open","locked":false,"title":"Configuration wrapper object with validation.","user":{"login":"friso","id":273638,"avatar_url":"https://avatars.githubusercontent.com/u/273638?v=3","gravatar_id":"","url":"https://api.github.com/users/friso","html_url":"https://github.com/friso","followers_url":"https://api.github.com/users/friso/followers","following_url":"https://api.github.com/users/friso/following{/other_user}","gists_url":"https://api.github.com/users/friso/gists{/gist_id}","starred_url":"https://api.github.com/users/friso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friso/subscriptions","organizations_url":"https://api.github.com/users/friso/orgs","repos_url":"https://api.github.com/users/friso/repos","events_url":"https://api.github.com/users/friso/events{/privacy}","received_events_url":"https://api.github.com/users/friso/received_events","type":"User","site_admin":false},"body":"This also removes the configuration based mapping entirely.\r\n\r\nBuild passes.\r\n","created_at":"2015-03-09T12:34:12Z","updated_at":"2015-03-09T13:17:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed38f146ba27d3876caf6276ec71627b2a8f92ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/divolte/divolte-collector/pulls/85/commits","review_comments_url":"https://api.github.com/repos/divolte/divolte-collector/pulls/85/comments","review_comment_url":"https://api.github.com/repos/divolte/divolte-collector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/divolte/divolte-collector/issues/85/comments","statuses_url":"https://api.github.com/repos/divolte/divolte-collector/statuses/e7124574c8fac31bce069bdc2142a7f08084b74b","head":{"label":"divolte:dev/config-object","ref":"dev/config-object","sha":"e7124574c8fac31bce069bdc2142a7f08084b74b","user":{"login":"divolte","id":7335595,"avatar_url":"https://avatars.githubusercontent.com/u/7335595?v=3","gravatar_id":"","url":"https://api.github.com/users/divolte","html_url":"https://github.com/divolte","followers_url":"https://api.github.com/users/divolte/followers","following_url":"https://api.github.com/users/divolte/following{/other_user}","gists_url":"https://api.github.com/users/divolte/gists{/gist_id}","starred_url":"https://api.github.com/users/divolte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divolte/subscriptions","organizations_url":"https://api.github.com/users/divolte/orgs","repos_url":"https://api.github.com/users/divolte/repos","events_url":"https://api.github.com/users/divolte/events{/privacy}","received_events_url":"https://api.github.com/users/divolte/received_events","type":"Organization","site_admin":false},"repo":{"id":22206807,"name":"divolte-collector","full_name":"divolte/divolte-collector","owner":{"login":"divolte","id":7335595,"avatar_url":"https://avatars.githubusercontent.com/u/7335595?v=3","gravatar_id":"","url":"https://api.github.com/users/divolte","html_url":"https://github.com/divolte","followers_url":"https://api.github.com/users/divolte/followers","following_url":"https://api.github.com/users/divolte/following{/other_user}","gists_url":"https://api.github.com/users/divolte/gists{/gist_id}","starred_url":"https://api.github.com/users/divolte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divolte/subscriptions","organizations_url":"https://api.github.com/users/divolte/orgs","repos_url":"https://api.github.com/users/divolte/repos","events_url":"https://api.github.com/users/divolte/events{/privacy}","received_events_url":"https://api.github.com/users/divolte/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/divolte/divolte-collector","description":"Divolte data collector","fork":false,"url":"https://api.github.com/repos/divolte/divolte-collector","forks_url":"https://api.github.com/repos/divolte/divolte-collector/forks","keys_url":"https://api.github.com/repos/divolte/divolte-collector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/divolte/divolte-collector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/divolte/divolte-collector/teams","hooks_url":"https://api.github.com/repos/divolte/divolte-collector/hooks","issue_events_url":"https://api.github.com/repos/divolte/divolte-collector/issues/events{/number}","events_url":"https://api.github.com/repos/divolte/divolte-collector/events","assignees_url":"https://api.github.com/repos/divolte/divolte-collector/assignees{/user}","branches_url":"https://api.github.com/repos/divolte/divolte-collector/branches{/branch}","tags_url":"https://api.github.com/repos/divolte/divolte-collector/tags","blobs_url":"https://api.github.com/repos/divolte/divolte-collector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/divolte/divolte-collector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/divolte/divolte-collector/git/refs{/sha}","trees_url":"https://api.github.com/repos/divolte/divolte-collector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/divolte/divolte-collector/statuses/{sha}","languages_url":"https://api.github.com/repos/divolte/divolte-collector/languages","stargazers_url":"https://api.github.com/repos/divolte/divolte-collector/stargazers","contributors_url":"https://api.github.com/repos/divolte/divolte-collector/contributors","subscribers_url":"https://api.github.com/repos/divolte/divolte-collector/subscribers","subscription_url":"https://api.github.com/repos/divolte/divolte-collector/subscription","commits_url":"https://api.github.com/repos/divolte/divolte-collector/commits{/sha}","git_commits_url":"https://api.github.com/repos/divolte/divolte-collector/git/commits{/sha}","comments_url":"https://api.github.com/repos/divolte/divolte-collector/comments{/number}","issue_comment_url":"https://api.github.com/repos/divolte/divolte-collector/issues/comments{/number}","contents_url":"https://api.github.com/repos/divolte/divolte-collector/contents/{+path}","compare_url":"https://api.github.com/repos/divolte/divolte-collector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/divolte/divolte-collector/merges","archive_url":"https://api.github.com/repos/divolte/divolte-collector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/divolte/divolte-collector/downloads","issues_url":"https://api.github.com/repos/divolte/divolte-collector/issues{/number}","pulls_url":"https://api.github.com/repos/divolte/divolte-collector/pulls{/number}","milestones_url":"https://api.github.com/repos/divolte/divolte-collector/milestones{/number}","notifications_url":"https://api.github.com/repos/divolte/divolte-collector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/divolte/divolte-collector/labels{/name}","releases_url":"https://api.github.com/repos/divolte/divolte-collector/releases{/id}","created_at":"2014-07-24T09:15:03Z","updated_at":"2015-03-05T12:45:48Z","pushed_at":"2015-03-09T12:32:44Z","git_url":"git://github.com/divolte/divolte-collector.git","ssh_url":"git@github.com:divolte/divolte-collector.git","clone_url":"https://github.com/divolte/divolte-collector.git","svn_url":"https://github.com/divolte/divolte-collector","homepage":null,"size":5817,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":14,"forks":2,"open_issues":14,"watchers":13,"default_branch":"master"}},"base":{"label":"divolte:master","ref":"master","sha":"c49bf318cc3bacfab13743ca9086f366d0705b27","user":{"login":"divolte","id":7335595,"avatar_url":"https://avatars.githubusercontent.com/u/7335595?v=3","gravatar_id":"","url":"https://api.github.com/users/divolte","html_url":"https://github.com/divolte","followers_url":"https://api.github.com/users/divolte/followers","following_url":"https://api.github.com/users/divolte/following{/other_user}","gists_url":"https://api.github.com/users/divolte/gists{/gist_id}","starred_url":"https://api.github.com/users/divolte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divolte/subscriptions","organizations_url":"https://api.github.com/users/divolte/orgs","repos_url":"https://api.github.com/users/divolte/repos","events_url":"https://api.github.com/users/divolte/events{/privacy}","received_events_url":"https://api.github.com/users/divolte/received_events","type":"Organization","site_admin":false},"repo":{"id":22206807,"name":"divolte-collector","full_name":"divolte/divolte-collector","owner":{"login":"divolte","id":7335595,"avatar_url":"https://avatars.githubusercontent.com/u/7335595?v=3","gravatar_id":"","url":"https://api.github.com/users/divolte","html_url":"https://github.com/divolte","followers_url":"https://api.github.com/users/divolte/followers","following_url":"https://api.github.com/users/divolte/following{/other_user}","gists_url":"https://api.github.com/users/divolte/gists{/gist_id}","starred_url":"https://api.github.com/users/divolte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divolte/subscriptions","organizations_url":"https://api.github.com/users/divolte/orgs","repos_url":"https://api.github.com/users/divolte/repos","events_url":"https://api.github.com/users/divolte/events{/privacy}","received_events_url":"https://api.github.com/users/divolte/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/divolte/divolte-collector","description":"Divolte data collector","fork":false,"url":"https://api.github.com/repos/divolte/divolte-collector","forks_url":"https://api.github.com/repos/divolte/divolte-collector/forks","keys_url":"https://api.github.com/repos/divolte/divolte-collector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/divolte/divolte-collector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/divolte/divolte-collector/teams","hooks_url":"https://api.github.com/repos/divolte/divolte-collector/hooks","issue_events_url":"https://api.github.com/repos/divolte/divolte-collector/issues/events{/number}","events_url":"https://api.github.com/repos/divolte/divolte-collector/events","assignees_url":"https://api.github.com/repos/divolte/divolte-collector/assignees{/user}","branches_url":"https://api.github.com/repos/divolte/divolte-collector/branches{/branch}","tags_url":"https://api.github.com/repos/divolte/divolte-collector/tags","blobs_url":"https://api.github.com/repos/divolte/divolte-collector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/divolte/divolte-collector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/divolte/divolte-collector/git/refs{/sha}","trees_url":"https://api.github.com/repos/divolte/divolte-collector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/divolte/divolte-collector/statuses/{sha}","languages_url":"https://api.github.com/repos/divolte/divolte-collector/languages","stargazers_url":"https://api.github.com/repos/divolte/divolte-collector/stargazers","contributors_url":"https://api.github.com/repos/divolte/divolte-collector/contributors","subscribers_url":"https://api.github.com/repos/divolte/divolte-collector/subscribers","subscription_url":"https://api.github.com/repos/divolte/divolte-collector/subscription","commits_url":"https://api.github.com/repos/divolte/divolte-collector/commits{/sha}","git_commits_url":"https://api.github.com/repos/divolte/divolte-collector/git/commits{/sha}","comments_url":"https://api.github.com/repos/divolte/divolte-collector/comments{/number}","issue_comment_url":"https://api.github.com/repos/divolte/divolte-collector/issues/comments{/number}","contents_url":"https://api.github.com/repos/divolte/divolte-collector/contents/{+path}","compare_url":"https://api.github.com/repos/divolte/divolte-collector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/divolte/divolte-collector/merges","archive_url":"https://api.github.com/repos/divolte/divolte-collector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/divolte/divolte-collector/downloads","issues_url":"https://api.github.com/repos/divolte/divolte-collector/issues{/number}","pulls_url":"https://api.github.com/repos/divolte/divolte-collector/pulls{/number}","milestones_url":"https://api.github.com/repos/divolte/divolte-collector/milestones{/number}","notifications_url":"https://api.github.com/repos/divolte/divolte-collector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/divolte/divolte-collector/labels{/name}","releases_url":"https://api.github.com/repos/divolte/divolte-collector/releases{/id}","created_at":"2014-07-24T09:15:03Z","updated_at":"2015-03-05T12:45:48Z","pushed_at":"2015-03-09T12:32:44Z","git_url":"git://github.com/divolte/divolte-collector.git","ssh_url":"git@github.com:divolte/divolte-collector.git","clone_url":"https://github.com/divolte/divolte-collector.git","svn_url":"https://github.com/divolte/divolte-collector","homepage":null,"size":5817,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":14,"forks":2,"open_issues":14,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/divolte/divolte-collector/pulls/85"},"html":{"href":"https://github.com/divolte/divolte-collector/pull/85"},"issue":{"href":"https://api.github.com/repos/divolte/divolte-collector/issues/85"},"comments":{"href":"https://api.github.com/repos/divolte/divolte-collector/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/divolte/divolte-collector/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/divolte/divolte-collector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/divolte/divolte-collector/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/divolte/divolte-collector/statuses/e7124574c8fac31bce069bdc2142a7f08084b74b"}}}}