{"action":"closed","number":643,"pull_request":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/643","id":41185855,"html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/643","diff_url":"https://github.com/WikiWatershed/model-my-watershed/pull/643.diff","patch_url":"https://github.com/WikiWatershed/model-my-watershed/pull/643.patch","issue_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/643","number":643,"state":"closed","locked":false,"title":"Preserve original ordering of Collections","user":{"login":"rajadain","id":1430060,"avatar_url":"https://avatars.githubusercontent.com/u/1430060?v=3","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"body":"For the purpose of producing consistent MD5 hashes for caching, #567\r\nadded code for keeping many Collections in an internally sorted order\r\nin 220a6e8. The actual order (usually the order in which they were added\r\nto the collection) was not meaningful at the time.\r\n\r\nNow, however, we are solving problems which do require us to respect the\r\norder in which models are added to the collection, e.g. #641. Thus, we\r\nundo automatic sorting and also remove tests for it. We adjust some more\r\ntests to respect the order of models within a collection, but still test\r\nthat models with differently sorted keys are still evaluated the same.\r\n\r\nSince Collections are stringified to Arrays and not Objects in JSON, the\r\nsorting there should be preserved automatically, without us having to\r\nsort each Collection. Thus, this change should not affect the stability\r\nof our caching approach.\r\n\r\nConnects #624 \r\nConnects #641 ","created_at":"2015-07-30T00:00:15Z","updated_at":"2015-07-30T15:00:16Z","closed_at":"2015-07-30T15:00:15Z","merged_at":"2015-07-30T15:00:15Z","merge_commit_sha":"3f6f52eeb8336d4c4f66b7f894954f2f51fd5ea2","assignee":{"login":"rajadain","id":1430060,"avatar_url":"https://avatars.githubusercontent.com/u/1430060?v=3","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/643/commits","review_comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/643/comments","review_comment_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/643/comments","statuses_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/statuses/c37c27bdd143101c856c2de773ddd3f996683a48","head":{"label":"rajadain:refactor/preserve-modification-order","ref":"refactor/preserve-modification-order","sha":"c37c27bdd143101c856c2de773ddd3f996683a48","user":{"login":"rajadain","id":1430060,"avatar_url":"https://avatars.githubusercontent.com/u/1430060?v=3","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"repo":{"id":36075102,"name":"model-my-watershed","full_name":"rajadain/model-my-watershed","owner":{"login":"rajadain","id":1430060,"avatar_url":"https://avatars.githubusercontent.com/u/1430060?v=3","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rajadain/model-my-watershed","description":"The web application front end for Model My Watershed.","fork":true,"url":"https://api.github.com/repos/rajadain/model-my-watershed","forks_url":"https://api.github.com/repos/rajadain/model-my-watershed/forks","keys_url":"https://api.github.com/repos/rajadain/model-my-watershed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rajadain/model-my-watershed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rajadain/model-my-watershed/teams","hooks_url":"https://api.github.com/repos/rajadain/model-my-watershed/hooks","issue_events_url":"https://api.github.com/repos/rajadain/model-my-watershed/issues/events{/number}","events_url":"https://api.github.com/repos/rajadain/model-my-watershed/events","assignees_url":"https://api.github.com/repos/rajadain/model-my-watershed/assignees{/user}","branches_url":"https://api.github.com/repos/rajadain/model-my-watershed/branches{/branch}","tags_url":"https://api.github.com/repos/rajadain/model-my-watershed/tags","blobs_url":"https://api.github.com/repos/rajadain/model-my-watershed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rajadain/model-my-watershed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rajadain/model-my-watershed/git/refs{/sha}","trees_url":"https://api.github.com/repos/rajadain/model-my-watershed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rajadain/model-my-watershed/statuses/{sha}","languages_url":"https://api.github.com/repos/rajadain/model-my-watershed/languages","stargazers_url":"https://api.github.com/repos/rajadain/model-my-watershed/stargazers","contributors_url":"https://api.github.com/repos/rajadain/model-my-watershed/contributors","subscribers_url":"https://api.github.com/repos/rajadain/model-my-watershed/subscribers","subscription_url":"https://api.github.com/repos/rajadain/model-my-watershed/subscription","commits_url":"https://api.github.com/repos/rajadain/model-my-watershed/commits{/sha}","git_commits_url":"https://api.github.com/repos/rajadain/model-my-watershed/git/commits{/sha}","comments_url":"https://api.github.com/repos/rajadain/model-my-watershed/comments{/number}","issue_comment_url":"https://api.github.com/repos/rajadain/model-my-watershed/issues/comments{/number}","contents_url":"https://api.github.com/repos/rajadain/model-my-watershed/contents/{+path}","compare_url":"https://api.github.com/repos/rajadain/model-my-watershed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rajadain/model-my-watershed/merges","archive_url":"https://api.github.com/repos/rajadain/model-my-watershed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rajadain/model-my-watershed/downloads","issues_url":"https://api.github.com/repos/rajadain/model-my-watershed/issues{/number}","pulls_url":"https://api.github.com/repos/rajadain/model-my-watershed/pulls{/number}","milestones_url":"https://api.github.com/repos/rajadain/model-my-watershed/milestones{/number}","notifications_url":"https://api.github.com/repos/rajadain/model-my-watershed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rajadain/model-my-watershed/labels{/name}","releases_url":"https://api.github.com/repos/rajadain/model-my-watershed/releases{/id}","created_at":"2015-05-22T13:58:22Z","updated_at":"2015-06-11T19:30:05Z","pushed_at":"2015-07-30T14:32:27Z","git_url":"git://github.com/rajadain/model-my-watershed.git","ssh_url":"git@github.com:rajadain/model-my-watershed.git","clone_url":"https://github.com/rajadain/model-my-watershed.git","svn_url":"https://github.com/rajadain/model-my-watershed","homepage":null,"size":14572,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"WikiWatershed:develop","ref":"develop","sha":"3f10316979ffd85824522819bc306d1129402f82","user":{"login":"WikiWatershed","id":8520008,"avatar_url":"https://avatars.githubusercontent.com/u/8520008?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiWatershed","html_url":"https://github.com/WikiWatershed","followers_url":"https://api.github.com/users/WikiWatershed/followers","following_url":"https://api.github.com/users/WikiWatershed/following{/other_user}","gists_url":"https://api.github.com/users/WikiWatershed/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiWatershed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiWatershed/subscriptions","organizations_url":"https://api.github.com/users/WikiWatershed/orgs","repos_url":"https://api.github.com/users/WikiWatershed/repos","events_url":"https://api.github.com/users/WikiWatershed/events{/privacy}","received_events_url":"https://api.github.com/users/WikiWatershed/received_events","type":"Organization","site_admin":false},"repo":{"id":32742922,"name":"model-my-watershed","full_name":"WikiWatershed/model-my-watershed","owner":{"login":"WikiWatershed","id":8520008,"avatar_url":"https://avatars.githubusercontent.com/u/8520008?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiWatershed","html_url":"https://github.com/WikiWatershed","followers_url":"https://api.github.com/users/WikiWatershed/followers","following_url":"https://api.github.com/users/WikiWatershed/following{/other_user}","gists_url":"https://api.github.com/users/WikiWatershed/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiWatershed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiWatershed/subscriptions","organizations_url":"https://api.github.com/users/WikiWatershed/orgs","repos_url":"https://api.github.com/users/WikiWatershed/repos","events_url":"https://api.github.com/users/WikiWatershed/events{/privacy}","received_events_url":"https://api.github.com/users/WikiWatershed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WikiWatershed/model-my-watershed","description":"The web application front end for Model My Watershed.","fork":false,"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed","forks_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/forks","keys_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/teams","hooks_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/hooks","issue_events_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/events{/number}","events_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/events","assignees_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/assignees{/user}","branches_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/branches{/branch}","tags_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/tags","blobs_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/refs{/sha}","trees_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/statuses/{sha}","languages_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/languages","stargazers_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/stargazers","contributors_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/contributors","subscribers_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/subscribers","subscription_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/subscription","commits_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/commits{/sha}","git_commits_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/commits{/sha}","comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/comments{/number}","issue_comment_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/comments{/number}","contents_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/contents/{+path}","compare_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/merges","archive_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/downloads","issues_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues{/number}","pulls_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls{/number}","milestones_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/milestones{/number}","notifications_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/labels{/name}","releases_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/releases{/id}","created_at":"2015-03-23T16:02:55Z","updated_at":"2015-07-16T03:33:25Z","pushed_at":"2015-07-30T15:00:16Z","git_url":"git://github.com/WikiWatershed/model-my-watershed.git","ssh_url":"git@github.com:WikiWatershed/model-my-watershed.git","clone_url":"https://github.com/WikiWatershed/model-my-watershed.git","svn_url":"https://github.com/WikiWatershed/model-my-watershed","homepage":null,"size":17357,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":125,"forks":11,"open_issues":125,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/643"},"html":{"href":"https://github.com/WikiWatershed/model-my-watershed/pull/643"},"issue":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/643"},"comments":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/643/comments"},"review_comments":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/643/comments"},"review_comment":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/643/commits"},"statuses":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/statuses/c37c27bdd143101c856c2de773ddd3f996683a48"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rajadain","id":1430060,"avatar_url":"https://avatars.githubusercontent.com/u/1430060?v=3","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":6,"deletions":45,"changed_files":3}}