{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/jobConfigHistory-plugin/issues/49","labels_url":"https://api.github.com/repos/jenkinsci/jobConfigHistory-plugin/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/jobConfigHistory-plugin/issues/49/comments","events_url":"https://api.github.com/repos/jenkinsci/jobConfigHistory-plugin/issues/49/events","html_url":"https://github.com/jenkinsci/jobConfigHistory-plugin/pull/49","id":98221414,"number":49,"title":"Alter module visibility to facilitate package separation.","user":{"login":"bdkoepke","id":1332146,"avatar_url":"https://avatars.githubusercontent.com/u/1332146?v=3","gravatar_id":"","url":"https://api.github.com/users/bdkoepke","html_url":"https://github.com/bdkoepke","followers_url":"https://api.github.com/users/bdkoepke/followers","following_url":"https://api.github.com/users/bdkoepke/following{/other_user}","gists_url":"https://api.github.com/users/bdkoepke/gists{/gist_id}","starred_url":"https://api.github.com/users/bdkoepke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdkoepke/subscriptions","organizations_url":"https://api.github.com/users/bdkoepke/orgs","repos_url":"https://api.github.com/users/bdkoepke/repos","events_url":"https://api.github.com/users/bdkoepke/events{/privacy}","received_events_url":"https://api.github.com/users/bdkoepke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-30T17:28:43Z","updated_at":"2015-08-01T20:16:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jobConfigHistory-plugin/pulls/49","html_url":"https://github.com/jenkinsci/jobConfigHistory-plugin/pull/49","diff_url":"https://github.com/jenkinsci/jobConfigHistory-plugin/pull/49.diff","patch_url":"https://github.com/jenkinsci/jobConfigHistory-plugin/pull/49.patch"},"body":"Attempting to find module boundaries by separating FileHistoryDao and it's dependencies into a separate package.\r\n\r\nThe current files that I believe are part of the 'File' backend and not the jobConfigHistory central package are:\r\n\r\nConfigInfoCollector\r\nDeletedFileFilter\r\nFileHistoryDao\r\nHistoryDescrToConfigInfo\r\nHistoryFileFilter\r\nJobConfigHistoryPurger\r\nJobConfigHistoryRootAction?\r\nJobConfigHistoryProjectAction?\r\nNonDeletedFileFilter\r\nPurgeable\r\n\r\nBefore merging this request I would like some feedback into which of these should actually be part of the main file backend and which should be part of the central jobConfigHistory interface. Once that is done I will do the remaining work to separate the packages correctly."},"comment":{"url":"https://api.github.com/repos/jenkinsci/jobConfigHistory-plugin/issues/comments/126949799","html_url":"https://github.com/jenkinsci/jobConfigHistory-plugin/pull/49#issuecomment-126949799","issue_url":"https://api.github.com/repos/jenkinsci/jobConfigHistory-plugin/issues/49","id":126949799,"user":{"login":"mfriedenhagen","id":125281,"avatar_url":"https://avatars.githubusercontent.com/u/125281?v=3","gravatar_id":"","url":"https://api.github.com/users/mfriedenhagen","html_url":"https://github.com/mfriedenhagen","followers_url":"https://api.github.com/users/mfriedenhagen/followers","following_url":"https://api.github.com/users/mfriedenhagen/following{/other_user}","gists_url":"https://api.github.com/users/mfriedenhagen/gists{/gist_id}","starred_url":"https://api.github.com/users/mfriedenhagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfriedenhagen/subscriptions","organizations_url":"https://api.github.com/users/mfriedenhagen/orgs","repos_url":"https://api.github.com/users/mfriedenhagen/repos","events_url":"https://api.github.com/users/mfriedenhagen/events{/privacy}","received_events_url":"https://api.github.com/users/mfriedenhagen/received_events","type":"User","site_admin":false},"created_at":"2015-08-01T20:16:36Z","updated_at":"2015-08-01T20:16:36Z","body":"@bdkoepke, right now you only widened the visibility, right? And want to create a new package `filehistorydao`? Great, after introducing the unit tests I was somewhat exhausted, so go for it!"}}