{"action":"created","issue":{"url":"https://api.github.com/repos/laravel/framework/issues/9396","labels_url":"https://api.github.com/repos/laravel/framework/issues/9396/labels{/name}","comments_url":"https://api.github.com/repos/laravel/framework/issues/9396/comments","events_url":"https://api.github.com/repos/laravel/framework/issues/9396/events","html_url":"https://github.com/laravel/framework/pull/9396","id":90624006,"number":9396,"title":"[5.1] Add cookies to http call methods in CrawlerTrait","user":{"login":"max-me","id":467159,"avatar_url":"https://avatars.githubusercontent.com/u/467159?v=3","gravatar_id":"","url":"https://api.github.com/users/max-me","html_url":"https://github.com/max-me","followers_url":"https://api.github.com/users/max-me/followers","following_url":"https://api.github.com/users/max-me/following{/other_user}","gists_url":"https://api.github.com/users/max-me/gists{/gist_id}","starred_url":"https://api.github.com/users/max-me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/max-me/subscriptions","organizations_url":"https://api.github.com/users/max-me/orgs","repos_url":"https://api.github.com/users/max-me/repos","events_url":"https://api.github.com/users/max-me/events{/privacy}","received_events_url":"https://api.github.com/users/max-me/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-24T09:32:20Z","updated_at":"2015-06-24T17:43:48Z","closed_at":"2015-06-24T14:11:01Z","pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/9396","html_url":"https://github.com/laravel/framework/pull/9396","diff_url":"https://github.com/laravel/framework/pull/9396.diff","patch_url":"https://github.com/laravel/framework/pull/9396.patch"},"body":"CrawlerTrait's `call()` method can accept `$cookies` array, but all http methods such as `get()`, `post()`, etc that utilise this method don't use it. So it becomes quite tricky to send cookies in test HTTP calls.\r\n\r\nI added an optional `$cookie` parameter to all this http methods. This change doesn't break anything, just extends current functionality and makes http calls with cookies easier and more readable."},"comment":{"url":"https://api.github.com/repos/laravel/framework/issues/comments/114951693","html_url":"https://github.com/laravel/framework/pull/9396#issuecomment-114951693","issue_url":"https://api.github.com/repos/laravel/framework/issues/9396","id":114951693,"user":{"login":"taylorotwell","id":463230,"avatar_url":"https://avatars.githubusercontent.com/u/463230?v=3","gravatar_id":"","url":"https://api.github.com/users/taylorotwell","html_url":"https://github.com/taylorotwell","followers_url":"https://api.github.com/users/taylorotwell/followers","following_url":"https://api.github.com/users/taylorotwell/following{/other_user}","gists_url":"https://api.github.com/users/taylorotwell/gists{/gist_id}","starred_url":"https://api.github.com/users/taylorotwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylorotwell/subscriptions","organizations_url":"https://api.github.com/users/taylorotwell/orgs","repos_url":"https://api.github.com/users/taylorotwell/repos","events_url":"https://api.github.com/users/taylorotwell/events{/privacy}","received_events_url":"https://api.github.com/users/taylorotwell/received_events","type":"User","site_admin":false},"created_at":"2015-06-24T17:43:48Z","updated_at":"2015-06-24T17:43:48Z","body":"Because adding parameters to a method is a big decision. It means we can\nnever change that 3rd parameter for years... even if a more helpful idea\ncomes along. That's why we have to be very cautious and not just merge\neverything that seems helpful. If there is an easy work-round (calling\n`call` directly), I would rather take that route for now.\n\nOn Wed, Jun 24, 2015 at 10:20 AM, Maxim Lanin <notifications@github.com>\nwrote:\n\n> @taylorotwell <https://github.com/taylorotwell> of course I can call it\n> directly. But then what for are these methods are made? As far as I\n> understand they are made for easy and readable calls. Then why not make\n> them slightly more helpful? It doesn't break anything\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/laravel/framework/pull/9396#issuecomment-114906427>.\n>\n"}}