{"action":"created","comment":{"url":"https://api.github.com/repos/IQSS/dataverse/pulls/comments/40429815","id":40429815,"diff_hunk":"@@ -489,7 +489,7 @@ public String getSolrSchema() {\n             sb.append(\"   <field name=\\\"\" + nameSearchable + \"\\\" type=\\\"\" + type + \"\\\" multiValued=\\\"\" + multivalued + \"\\\" stored=\\\"true\\\" indexed=\\\"true\\\"/>\\n\");\n         }\n \n-        List<String> listOfStaticFields = new ArrayList();\n+        List<String> listOfStaticFields = new ArrayList<>();","path":"src/main/java/edu/harvard/iq/dataverse/api/Index.java","position":5,"original_position":5,"commit_id":"13c1be6ffc184107ad7c33292431790400dcd0bf","original_commit_id":"13c1be6ffc184107ad7c33292431790400dcd0bf","user":{"login":"pdurbin","id":21006,"avatar_url":"https://avatars.githubusercontent.com/u/21006?v=3","gravatar_id":"","url":"https://api.github.com/users/pdurbin","html_url":"https://github.com/pdurbin","followers_url":"https://api.github.com/users/pdurbin/followers","following_url":"https://api.github.com/users/pdurbin/following{/other_user}","gists_url":"https://api.github.com/users/pdurbin/gists{/gist_id}","starred_url":"https://api.github.com/users/pdurbin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdurbin/subscriptions","organizations_url":"https://api.github.com/users/pdurbin/orgs","repos_url":"https://api.github.com/users/pdurbin/repos","events_url":"https://api.github.com/users/pdurbin/events{/privacy}","received_events_url":"https://api.github.com/users/pdurbin/received_events","type":"User","site_admin":false},"body":"@bencomp you're certainly right that this is a type safety issue but the default settings from Netbeans apparently don't provide developers the typical yellow warning indicators:\r\n\r\n![screen shot 2015-09-25 at 9 35 47 am](https://cloud.githubusercontent.com/assets/21006/10101853/2a816dba-6369-11e5-9cb6-f0bde0020573.png)\r\n\r\nIf you could please share the Netbeans settings you are using, I'd appreciate it. You could even add it to the Google Doc linked from http://guides.dataverse.org/en/latest/developers/coding-style.html","created_at":"2015-09-25T13:39:24Z","updated_at":"2015-09-25T13:39:24Z","html_url":"https://github.com/IQSS/dataverse/pull/2589#discussion_r40429815","pull_request_url":"https://api.github.com/repos/IQSS/dataverse/pulls/2589","_links":{"self":{"href":"https://api.github.com/repos/IQSS/dataverse/pulls/comments/40429815"},"html":{"href":"https://github.com/IQSS/dataverse/pull/2589#discussion_r40429815"},"pull_request":{"href":"https://api.github.com/repos/IQSS/dataverse/pulls/2589"}}},"pull_request":{"url":"https://api.github.com/repos/IQSS/dataverse/pulls/2589","id":45959201,"html_url":"https://github.com/IQSS/dataverse/pull/2589","diff_url":"https://github.com/IQSS/dataverse/pull/2589.diff","patch_url":"https://github.com/IQSS/dataverse/pull/2589.patch","issue_url":"https://api.github.com/repos/IQSS/dataverse/issues/2589","number":2589,"state":"open","locked":false,"title":"Fix some raw type references","user":{"login":"bencomp","id":1303898,"avatar_url":"https://avatars.githubusercontent.com/u/1303898?v=3","gravatar_id":"","url":"https://api.github.com/users/bencomp","html_url":"https://github.com/bencomp","followers_url":"https://api.github.com/users/bencomp/followers","following_url":"https://api.github.com/users/bencomp/following{/other_user}","gists_url":"https://api.github.com/users/bencomp/gists{/gist_id}","starred_url":"https://api.github.com/users/bencomp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bencomp/subscriptions","organizations_url":"https://api.github.com/users/bencomp/orgs","repos_url":"https://api.github.com/users/bencomp/repos","events_url":"https://api.github.com/users/bencomp/events{/privacy}","received_events_url":"https://api.github.com/users/bencomp/received_events","type":"User","site_admin":false},"body":"In an effort to get the number of Java compiler warnings about unchecked references and casts (see #2574) I added diamonds to a few classes.\r\n\r\nThis is work in progress.","created_at":"2015-09-24T22:43:54Z","updated_at":"2015-09-25T13:39:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd9b225c851cedaf86b8baa5bce657eb581ea165","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/IQSS/dataverse/pulls/2589/commits","review_comments_url":"https://api.github.com/repos/IQSS/dataverse/pulls/2589/comments","review_comment_url":"https://api.github.com/repos/IQSS/dataverse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IQSS/dataverse/issues/2589/comments","statuses_url":"https://api.github.com/repos/IQSS/dataverse/statuses/13c1be6ffc184107ad7c33292431790400dcd0bf","head":{"label":"bencomp:2574-code-style-raw-type","ref":"2574-code-style-raw-type","sha":"13c1be6ffc184107ad7c33292431790400dcd0bf","user":{"login":"bencomp","id":1303898,"avatar_url":"https://avatars.githubusercontent.com/u/1303898?v=3","gravatar_id":"","url":"https://api.github.com/users/bencomp","html_url":"https://github.com/bencomp","followers_url":"https://api.github.com/users/bencomp/followers","following_url":"https://api.github.com/users/bencomp/following{/other_user}","gists_url":"https://api.github.com/users/bencomp/gists{/gist_id}","starred_url":"https://api.github.com/users/bencomp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bencomp/subscriptions","organizations_url":"https://api.github.com/users/bencomp/orgs","repos_url":"https://api.github.com/users/bencomp/repos","events_url":"https://api.github.com/users/bencomp/events{/privacy}","received_events_url":"https://api.github.com/users/bencomp/received_events","type":"User","site_admin":false},"repo":{"id":24332085,"name":"dataverse","full_name":"bencomp/dataverse","owner":{"login":"bencomp","id":1303898,"avatar_url":"https://avatars.githubusercontent.com/u/1303898?v=3","gravatar_id":"","url":"https://api.github.com/users/bencomp","html_url":"https://github.com/bencomp","followers_url":"https://api.github.com/users/bencomp/followers","following_url":"https://api.github.com/users/bencomp/following{/other_user}","gists_url":"https://api.github.com/users/bencomp/gists{/gist_id}","starred_url":"https://api.github.com/users/bencomp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bencomp/subscriptions","organizations_url":"https://api.github.com/users/bencomp/orgs","repos_url":"https://api.github.com/users/bencomp/repos","events_url":"https://api.github.com/users/bencomp/events{/privacy}","received_events_url":"https://api.github.com/users/bencomp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bencomp/dataverse","description":"A data repository framework to share and publish research data.","fork":true,"url":"https://api.github.com/repos/bencomp/dataverse","forks_url":"https://api.github.com/repos/bencomp/dataverse/forks","keys_url":"https://api.github.com/repos/bencomp/dataverse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bencomp/dataverse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bencomp/dataverse/teams","hooks_url":"https://api.github.com/repos/bencomp/dataverse/hooks","issue_events_url":"https://api.github.com/repos/bencomp/dataverse/issues/events{/number}","events_url":"https://api.github.com/repos/bencomp/dataverse/events","assignees_url":"https://api.github.com/repos/bencomp/dataverse/assignees{/user}","branches_url":"https://api.github.com/repos/bencomp/dataverse/branches{/branch}","tags_url":"https://api.github.com/repos/bencomp/dataverse/tags","blobs_url":"https://api.github.com/repos/bencomp/dataverse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bencomp/dataverse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bencomp/dataverse/git/refs{/sha}","trees_url":"https://api.github.com/repos/bencomp/dataverse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bencomp/dataverse/statuses/{sha}","languages_url":"https://api.github.com/repos/bencomp/dataverse/languages","stargazers_url":"https://api.github.com/repos/bencomp/dataverse/stargazers","contributors_url":"https://api.github.com/repos/bencomp/dataverse/contributors","subscribers_url":"https://api.github.com/repos/bencomp/dataverse/subscribers","subscription_url":"https://api.github.com/repos/bencomp/dataverse/subscription","commits_url":"https://api.github.com/repos/bencomp/dataverse/commits{/sha}","git_commits_url":"https://api.github.com/repos/bencomp/dataverse/git/commits{/sha}","comments_url":"https://api.github.com/repos/bencomp/dataverse/comments{/number}","issue_comment_url":"https://api.github.com/repos/bencomp/dataverse/issues/comments{/number}","contents_url":"https://api.github.com/repos/bencomp/dataverse/contents/{+path}","compare_url":"https://api.github.com/repos/bencomp/dataverse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bencomp/dataverse/merges","archive_url":"https://api.github.com/repos/bencomp/dataverse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bencomp/dataverse/downloads","issues_url":"https://api.github.com/repos/bencomp/dataverse/issues{/number}","pulls_url":"https://api.github.com/repos/bencomp/dataverse/pulls{/number}","milestones_url":"https://api.github.com/repos/bencomp/dataverse/milestones{/number}","notifications_url":"https://api.github.com/repos/bencomp/dataverse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bencomp/dataverse/labels{/name}","releases_url":"https://api.github.com/repos/bencomp/dataverse/releases{/id}","created_at":"2014-09-22T14:34:19Z","updated_at":"2015-01-14T15:19:50Z","pushed_at":"2015-09-25T00:35:18Z","git_url":"git://github.com/bencomp/dataverse.git","ssh_url":"git@github.com:bencomp/dataverse.git","clone_url":"https://github.com/bencomp/dataverse.git","svn_url":"https://github.com/bencomp/dataverse","homepage":"http://thedata.org","size":25934,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IQSS:4.3","ref":"4.3","sha":"846934a48438e525db333e6f11d4ec1360e77cae","user":{"login":"IQSS","id":675237,"avatar_url":"https://avatars.githubusercontent.com/u/675237?v=3","gravatar_id":"","url":"https://api.github.com/users/IQSS","html_url":"https://github.com/IQSS","followers_url":"https://api.github.com/users/IQSS/followers","following_url":"https://api.github.com/users/IQSS/following{/other_user}","gists_url":"https://api.github.com/users/IQSS/gists{/gist_id}","starred_url":"https://api.github.com/users/IQSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IQSS/subscriptions","organizations_url":"https://api.github.com/users/IQSS/orgs","repos_url":"https://api.github.com/users/IQSS/repos","events_url":"https://api.github.com/users/IQSS/events{/privacy}","received_events_url":"https://api.github.com/users/IQSS/received_events","type":"Organization","site_admin":false},"repo":{"id":14051004,"name":"dataverse","full_name":"IQSS/dataverse","owner":{"login":"IQSS","id":675237,"avatar_url":"https://avatars.githubusercontent.com/u/675237?v=3","gravatar_id":"","url":"https://api.github.com/users/IQSS","html_url":"https://github.com/IQSS","followers_url":"https://api.github.com/users/IQSS/followers","following_url":"https://api.github.com/users/IQSS/following{/other_user}","gists_url":"https://api.github.com/users/IQSS/gists{/gist_id}","starred_url":"https://api.github.com/users/IQSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IQSS/subscriptions","organizations_url":"https://api.github.com/users/IQSS/orgs","repos_url":"https://api.github.com/users/IQSS/repos","events_url":"https://api.github.com/users/IQSS/events{/privacy}","received_events_url":"https://api.github.com/users/IQSS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IQSS/dataverse","description":"A data repository framework to share and publish research data.","fork":false,"url":"https://api.github.com/repos/IQSS/dataverse","forks_url":"https://api.github.com/repos/IQSS/dataverse/forks","keys_url":"https://api.github.com/repos/IQSS/dataverse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IQSS/dataverse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IQSS/dataverse/teams","hooks_url":"https://api.github.com/repos/IQSS/dataverse/hooks","issue_events_url":"https://api.github.com/repos/IQSS/dataverse/issues/events{/number}","events_url":"https://api.github.com/repos/IQSS/dataverse/events","assignees_url":"https://api.github.com/repos/IQSS/dataverse/assignees{/user}","branches_url":"https://api.github.com/repos/IQSS/dataverse/branches{/branch}","tags_url":"https://api.github.com/repos/IQSS/dataverse/tags","blobs_url":"https://api.github.com/repos/IQSS/dataverse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IQSS/dataverse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IQSS/dataverse/git/refs{/sha}","trees_url":"https://api.github.com/repos/IQSS/dataverse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IQSS/dataverse/statuses/{sha}","languages_url":"https://api.github.com/repos/IQSS/dataverse/languages","stargazers_url":"https://api.github.com/repos/IQSS/dataverse/stargazers","contributors_url":"https://api.github.com/repos/IQSS/dataverse/contributors","subscribers_url":"https://api.github.com/repos/IQSS/dataverse/subscribers","subscription_url":"https://api.github.com/repos/IQSS/dataverse/subscription","commits_url":"https://api.github.com/repos/IQSS/dataverse/commits{/sha}","git_commits_url":"https://api.github.com/repos/IQSS/dataverse/git/commits{/sha}","comments_url":"https://api.github.com/repos/IQSS/dataverse/comments{/number}","issue_comment_url":"https://api.github.com/repos/IQSS/dataverse/issues/comments{/number}","contents_url":"https://api.github.com/repos/IQSS/dataverse/contents/{+path}","compare_url":"https://api.github.com/repos/IQSS/dataverse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IQSS/dataverse/merges","archive_url":"https://api.github.com/repos/IQSS/dataverse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IQSS/dataverse/downloads","issues_url":"https://api.github.com/repos/IQSS/dataverse/issues{/number}","pulls_url":"https://api.github.com/repos/IQSS/dataverse/pulls{/number}","milestones_url":"https://api.github.com/repos/IQSS/dataverse/milestones{/number}","notifications_url":"https://api.github.com/repos/IQSS/dataverse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IQSS/dataverse/labels{/name}","releases_url":"https://api.github.com/repos/IQSS/dataverse/releases{/id}","created_at":"2013-11-01T18:47:39Z","updated_at":"2015-09-24T09:30:42Z","pushed_at":"2015-09-25T00:35:19Z","git_url":"git://github.com/IQSS/dataverse.git","ssh_url":"git@github.com:IQSS/dataverse.git","clone_url":"https://github.com/IQSS/dataverse.git","svn_url":"https://github.com/IQSS/dataverse","homepage":"http://dataverse.org","size":40955,"stargazers_count":59,"watchers_count":59,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":705,"forks":28,"open_issues":705,"watchers":59,"default_branch":"4.3"}},"_links":{"self":{"href":"https://api.github.com/repos/IQSS/dataverse/pulls/2589"},"html":{"href":"https://github.com/IQSS/dataverse/pull/2589"},"issue":{"href":"https://api.github.com/repos/IQSS/dataverse/issues/2589"},"comments":{"href":"https://api.github.com/repos/IQSS/dataverse/issues/2589/comments"},"review_comments":{"href":"https://api.github.com/repos/IQSS/dataverse/pulls/2589/comments"},"review_comment":{"href":"https://api.github.com/repos/IQSS/dataverse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IQSS/dataverse/pulls/2589/commits"},"statuses":{"href":"https://api.github.com/repos/IQSS/dataverse/statuses/13c1be6ffc184107ad7c33292431790400dcd0bf"}}}}