{"action":"created","issue":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/24242","labels_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/24242/labels{/name}","comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/24242/comments","events_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/24242/events","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/24242","id":58620597,"number":24242,"title":"LPS-53636 Revert all changes to ProxyUtil","user":{"login":"shuyangzhou","id":173369,"avatar_url":"https://avatars.githubusercontent.com/u/173369?v=3","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-23T17:40:07Z","updated_at":"2015-02-23T18:05:48Z","closed_at":"2015-02-23T18:05:48Z","pull_request":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/24242","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/24242","diff_url":"https://github.com/brianchandotcom/liferay-portal/pull/24242.diff","patch_url":"https://github.com/brianchandotcom/liferay-portal/pull/24242.patch"},"body":"CC @csierra and @migue\r\n\r\nThe changes to ProxyUtil in this ticket does not really make sense.\r\n\r\nThe Class -> Constructor map is weaked on key already, there is no reason to also weak it on value.\r\nAs long as the class is still alive, its constructor will be alive too. Killing the reference from the cache map is just releasing a reference, not freeing it from heap.\r\n\r\nThis cache serves the purpose of binding constructor's lifecycle to its class, so that on next constructor fetching, we won't reflect again. Even all strong references to the constructor are gone, as long as the class is still alive, someone might request the constructor again later, eagerly freeing the constructor does not save us much memory, but increase the chance of doing more reflection work.\r\n"},"comment":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/comments/75596880","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/24242#issuecomment-75596880","issue_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/24242","id":75596880,"user":{"login":"shuyangzhou","id":173369,"avatar_url":"https://avatars.githubusercontent.com/u/173369?v=3","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"created_at":"2015-02-23T18:05:48Z","updated_at":"2015-02-23T18:05:48Z","body":"Ok, I see, that part we can do a full refernece based map, like example in ConstantsBeanFactoryImpl.\r\n\r\nI will apply that solution and resend, please retest on your end with my next pull.\r\n\r\nThanks"}}