{"action":"created","issue":{"url":"https://api.github.com/repos/angular-ui/ng-grid/issues/3120","labels_url":"https://api.github.com/repos/angular-ui/ng-grid/issues/3120/labels{/name}","comments_url":"https://api.github.com/repos/angular-ui/ng-grid/issues/3120/comments","events_url":"https://api.github.com/repos/angular-ui/ng-grid/issues/3120/events","html_url":"https://github.com/angular-ui/ng-grid/pull/3120","id":64572655,"number":3120,"title":"refactor(core): Change scrolling events. Various performance improvement...","user":{"login":"swalters","id":195646,"avatar_url":"https://avatars.githubusercontent.com/u/195646?v=3","gravatar_id":"","url":"https://api.github.com/users/swalters","html_url":"https://github.com/swalters","followers_url":"https://api.github.com/users/swalters/followers","following_url":"https://api.github.com/users/swalters/following{/other_user}","gists_url":"https://api.github.com/users/swalters/gists{/gist_id}","starred_url":"https://api.github.com/users/swalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swalters/subscriptions","organizations_url":"https://api.github.com/users/swalters/orgs","repos_url":"https://api.github.com/users/swalters/repos","events_url":"https://api.github.com/users/swalters/events{/privacy}","received_events_url":"https://api.github.com/users/swalters/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-26T16:25:32Z","updated_at":"2015-06-17T21:28:35Z","closed_at":"2015-04-01T16:31:42Z","pull_request":{"url":"https://api.github.com/repos/angular-ui/ng-grid/pulls/3120","html_url":"https://github.com/angular-ui/ng-grid/pull/3120","diff_url":"https://github.com/angular-ui/ng-grid/pull/3120.diff","patch_url":"https://github.com/angular-ui/ng-grid/pull/3120.patch"},"body":"...s in scrolling\r\n\r\nBefore this change, scrolling Events were being fire for each render container.  Now, a ScrollBegin and ScrollEnd event is fired once for the grid.  ScrollTo methods were moved from cellNav into core and also changed to return a promise.\r\n\r\n BREAKING CHANGE:\r\n Two events are now emitted on scroll:\r\n\r\n grid.api.core.ScrollBegin\r\n grid.api.core.ScrollEnd\r\n\r\n Before:\r\n grid.api.core.ScrollEvent\r\n After:\r\ngrid.api.core.ScrollBegin\r\n\r\nScrollToIfNecessary and ScrollTo moved from cellNav to core and grid removed from arguments\r\nBefore:\r\ngrid.api.cellNav.ScrollToIfNecessary(grid, gridRow, gridCol)\r\ngrid.api.cellNav.ScrollTo(grid, rowEntity, colDef)\r\n\r\nAfter:\r\ngrid.api.core.ScrollToIfNecessary(gridRow, gridCol)\r\ngrid.api.core.ScrollTo(rowEntity, colDef)\r\n\r\nGridEdit/cellNav\r\nWhen using cellNav, a cell no longer receives focus.  Instead the viewport always receives focus.  This eliminated many bugs associated with scrolling and focus.\r\n\r\nIf you have a custom editor, you will no longer receive keyDown/Up events from the readonly cell.  Use the cellNav api viewPortKeyDown to capture any needed keydown events.  see GridEdit.js for an example"},"comment":{"url":"https://api.github.com/repos/angular-ui/ng-grid/issues/comments/112954599","html_url":"https://github.com/angular-ui/ng-grid/pull/3120#issuecomment-112954599","issue_url":"https://api.github.com/repos/angular-ui/ng-grid/issues/3120","id":112954599,"user":{"login":"rkilarski","id":8093793,"avatar_url":"https://avatars.githubusercontent.com/u/8093793?v=3","gravatar_id":"","url":"https://api.github.com/users/rkilarski","html_url":"https://github.com/rkilarski","followers_url":"https://api.github.com/users/rkilarski/followers","following_url":"https://api.github.com/users/rkilarski/following{/other_user}","gists_url":"https://api.github.com/users/rkilarski/gists{/gist_id}","starred_url":"https://api.github.com/users/rkilarski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkilarski/subscriptions","organizations_url":"https://api.github.com/users/rkilarski/orgs","repos_url":"https://api.github.com/users/rkilarski/repos","events_url":"https://api.github.com/users/rkilarski/events{/privacy}","received_events_url":"https://api.github.com/users/rkilarski/received_events","type":"User","site_admin":false},"created_at":"2015-06-17T21:28:35Z","updated_at":"2015-06-17T21:28:35Z","body":"Hello!  You said:\r\n\r\n<blockquote>If you have a custom editor, you will no longer receive keyDown/Up events from the readonly cell. Use the cellNav api viewPortKeyDown to capture any needed keydown events.</blockquote>\r\n\r\nThe keys I need to capture are the Enter and right/left arrows.  Since those are considered navigation keys in uiGridCtrl.cellNav.handleKeyDown(), they aren't emitted via viewPortKeyDown.\r\n\r\nWhat can I do in order to allow handling Enter and the horizontal arrows?\r\n\r\nRich"}}