{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar/pulls/comments/38742297","id":38742297,"diff_hunk":"@@ -774,31 +774,20 @@ if [ -n \"$CROWBAR_FROM_GIT\" ]; then\n     touch /opt/dell/crowbar_framework/app/views/barclamp/git/_pfsdeps.html.haml\n fi\n \n-#\n-# Take care that the barclamps are installed in the right order (as expressed\n-# in cookbook dependencies)\n-#\n-required_barclamps=\"crowbar deployer dns ipmi logging network ntp provisioner\"\n+required_components=\"core\"\n \n if is_ses ; then\n-    required_barclamps+=\" suse-enterprise-storage ceph\"\n+    required_components+=\" suse-enterprise-storage ceph\"\n else\n-    required_barclamps+=\" pacemaker database rabbitmq openstack keystone\n-        swift ceph glance cinder neutron nova nova_dashboard\"\n+    required_components+=\" openstack ha ceph\"\n fi\n \n-for i in $required_barclamps ; do\n-    /opt/dell/bin/barclamp_install.rb $BARCLAMP_INSTALL_OPTS $BARCLAMP_SRC/$i\n-done\n-\n-# Install optional barclamps if they're present\n-for i in updater suse-manager-client nfs_client \\\n-    cisco-ucs hyperv heat ceilometer manila trove tempest ; do\n-    if test -d $BARCLAMP_SRC/$i; then\n-        /opt/dell/bin/barclamp_install.rb $BARCLAMP_INSTALL_OPTS $BARCLAMP_SRC/$i\n-    fi\n-done\n+/opt/dell/bin/barclamp_install.rb $BARCLAMP_INSTALL_OPTS $required_components\n \n+# Install optional components if they're present\n+if test -d $BARCLAMP_SRC/hyperv; then\n+    /opt/dell/bin/barclamp_install.rb $BARCLAMP_INSTALL_OPTS $i","path":"scripts/install-chef-suse.sh","position":35,"original_position":35,"commit_id":"d003063332e504cf4a97e7421eceb9efda534af4","original_commit_id":"d003063332e504cf4a97e7421eceb9efda534af4","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"body":"You're not doing a loop here, so `$i` won't work ;-)","created_at":"2015-09-04T11:23:24Z","updated_at":"2015-09-04T11:23:24Z","html_url":"https://github.com/crowbar/crowbar/pull/2146#discussion_r38742297","pull_request_url":"https://api.github.com/repos/crowbar/crowbar/pulls/2146","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar/pulls/comments/38742297"},"html":{"href":"https://github.com/crowbar/crowbar/pull/2146#discussion_r38742297"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar/pulls/2146"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar/pulls/2146","id":44120115,"html_url":"https://github.com/crowbar/crowbar/pull/2146","diff_url":"https://github.com/crowbar/crowbar/pull/2146.diff","patch_url":"https://github.com/crowbar/crowbar/pull/2146.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar/issues/2146","number":2146,"state":"open","locked":false,"title":"Adapt the barclamp installation to handle components","user":{"login":"rsalevsky","id":4128547,"avatar_url":"https://avatars.githubusercontent.com/u/4128547?v=3","gravatar_id":"","url":"https://api.github.com/users/rsalevsky","html_url":"https://github.com/rsalevsky","followers_url":"https://api.github.com/users/rsalevsky/followers","following_url":"https://api.github.com/users/rsalevsky/following{/other_user}","gists_url":"https://api.github.com/users/rsalevsky/gists{/gist_id}","starred_url":"https://api.github.com/users/rsalevsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsalevsky/subscriptions","organizations_url":"https://api.github.com/users/rsalevsky/orgs","repos_url":"https://api.github.com/users/rsalevsky/repos","events_url":"https://api.github.com/users/rsalevsky/events{/privacy}","received_events_url":"https://api.github.com/users/rsalevsky/received_events","type":"User","site_admin":false},"body":"Please note that the gating will fail because we have some workarounds in the packages which needs to be removed after the merge.","created_at":"2015-09-03T15:20:32Z","updated_at":"2015-09-04T11:23:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c395a5e82c5a887648fe8aeb0ca868741533b4c7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar/pulls/2146/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar/pulls/2146/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar/issues/2146/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar/statuses/d003063332e504cf4a97e7421eceb9efda534af4","head":{"label":"rsalevsky:fix_barclamp_install","ref":"fix_barclamp_install","sha":"d003063332e504cf4a97e7421eceb9efda534af4","user":{"login":"rsalevsky","id":4128547,"avatar_url":"https://avatars.githubusercontent.com/u/4128547?v=3","gravatar_id":"","url":"https://api.github.com/users/rsalevsky","html_url":"https://github.com/rsalevsky","followers_url":"https://api.github.com/users/rsalevsky/followers","following_url":"https://api.github.com/users/rsalevsky/following{/other_user}","gists_url":"https://api.github.com/users/rsalevsky/gists{/gist_id}","starred_url":"https://api.github.com/users/rsalevsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsalevsky/subscriptions","organizations_url":"https://api.github.com/users/rsalevsky/orgs","repos_url":"https://api.github.com/users/rsalevsky/repos","events_url":"https://api.github.com/users/rsalevsky/events{/privacy}","received_events_url":"https://api.github.com/users/rsalevsky/received_events","type":"User","site_admin":false},"repo":{"id":30867324,"name":"crowbar","full_name":"rsalevsky/crowbar","owner":{"login":"rsalevsky","id":4128547,"avatar_url":"https://avatars.githubusercontent.com/u/4128547?v=3","gravatar_id":"","url":"https://api.github.com/users/rsalevsky","html_url":"https://github.com/rsalevsky","followers_url":"https://api.github.com/users/rsalevsky/followers","following_url":"https://api.github.com/users/rsalevsky/following{/other_user}","gists_url":"https://api.github.com/users/rsalevsky/gists{/gist_id}","starred_url":"https://api.github.com/users/rsalevsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsalevsky/subscriptions","organizations_url":"https://api.github.com/users/rsalevsky/orgs","repos_url":"https://api.github.com/users/rsalevsky/repos","events_url":"https://api.github.com/users/rsalevsky/events{/privacy}","received_events_url":"https://api.github.com/users/rsalevsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rsalevsky/crowbar","description":"Cloud Operations Platform","fork":true,"url":"https://api.github.com/repos/rsalevsky/crowbar","forks_url":"https://api.github.com/repos/rsalevsky/crowbar/forks","keys_url":"https://api.github.com/repos/rsalevsky/crowbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsalevsky/crowbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsalevsky/crowbar/teams","hooks_url":"https://api.github.com/repos/rsalevsky/crowbar/hooks","issue_events_url":"https://api.github.com/repos/rsalevsky/crowbar/issues/events{/number}","events_url":"https://api.github.com/repos/rsalevsky/crowbar/events","assignees_url":"https://api.github.com/repos/rsalevsky/crowbar/assignees{/user}","branches_url":"https://api.github.com/repos/rsalevsky/crowbar/branches{/branch}","tags_url":"https://api.github.com/repos/rsalevsky/crowbar/tags","blobs_url":"https://api.github.com/repos/rsalevsky/crowbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsalevsky/crowbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsalevsky/crowbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsalevsky/crowbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsalevsky/crowbar/statuses/{sha}","languages_url":"https://api.github.com/repos/rsalevsky/crowbar/languages","stargazers_url":"https://api.github.com/repos/rsalevsky/crowbar/stargazers","contributors_url":"https://api.github.com/repos/rsalevsky/crowbar/contributors","subscribers_url":"https://api.github.com/repos/rsalevsky/crowbar/subscribers","subscription_url":"https://api.github.com/repos/rsalevsky/crowbar/subscription","commits_url":"https://api.github.com/repos/rsalevsky/crowbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsalevsky/crowbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsalevsky/crowbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsalevsky/crowbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsalevsky/crowbar/contents/{+path}","compare_url":"https://api.github.com/repos/rsalevsky/crowbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsalevsky/crowbar/merges","archive_url":"https://api.github.com/repos/rsalevsky/crowbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsalevsky/crowbar/downloads","issues_url":"https://api.github.com/repos/rsalevsky/crowbar/issues{/number}","pulls_url":"https://api.github.com/repos/rsalevsky/crowbar/pulls{/number}","milestones_url":"https://api.github.com/repos/rsalevsky/crowbar/milestones{/number}","notifications_url":"https://api.github.com/repos/rsalevsky/crowbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsalevsky/crowbar/labels{/name}","releases_url":"https://api.github.com/repos/rsalevsky/crowbar/releases{/id}","created_at":"2015-02-16T12:28:13Z","updated_at":"2015-02-16T12:28:16Z","pushed_at":"2015-09-04T11:16:06Z","git_url":"git://github.com/rsalevsky/crowbar.git","ssh_url":"git@github.com:rsalevsky/crowbar.git","clone_url":"https://github.com/rsalevsky/crowbar.git","svn_url":"https://github.com/rsalevsky/crowbar","homepage":"https://github.com/crowbar/crowbar","size":32702,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"4750e4329154567e1b5253170a65ffea7c473e87","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":2040151,"name":"crowbar","full_name":"crowbar/crowbar","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar","description":"Cloud Operations Platform","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar","forks_url":"https://api.github.com/repos/crowbar/crowbar/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar/releases{/id}","created_at":"2011-07-13T05:02:51Z","updated_at":"2015-09-02T00:42:31Z","pushed_at":"2015-09-04T08:28:44Z","git_url":"git://github.com/crowbar/crowbar.git","ssh_url":"git@github.com:crowbar/crowbar.git","clone_url":"https://github.com/crowbar/crowbar.git","svn_url":"https://github.com/crowbar/crowbar","homepage":"https://github.com/crowbar/crowbar","size":53050,"stargazers_count":694,"watchers_count":694,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":277,"mirror_url":null,"open_issues_count":49,"forks":277,"open_issues":49,"watchers":694,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar/pulls/2146"},"html":{"href":"https://github.com/crowbar/crowbar/pull/2146"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar/issues/2146"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar/issues/2146/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar/pulls/2146/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar/pulls/2146/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar/statuses/d003063332e504cf4a97e7421eceb9efda534af4"}}}}