{"action":"created","comment":{"url":"https://api.github.com/repos/druid-io/druid/pulls/comments/46869929","id":46869929,"diff_hunk":"@@ -35,9 +35,10 @@\n \n   private final Set<QueryableDruidServer> servers = Sets.newHashSet();\n \n-  private final DataSegment segment;\n   private final TierSelectorStrategy strategy;\n \n+  private DataSegment segment;","path":"server/src/main/java/io/druid/client/selector/ServerSelector.java","position":null,"original_position":7,"commit_id":"970b9cfcaadaa309a9dc5890ed1361ce0a9b3650","original_commit_id":"17b1e2637df4d7c650368c83b144df5e43cdc4bd","user":{"login":"guobingkun","id":11789051,"avatar_url":"https://avatars.githubusercontent.com/u/11789051?v=3","gravatar_id":"","url":"https://api.github.com/users/guobingkun","html_url":"https://github.com/guobingkun","followers_url":"https://api.github.com/users/guobingkun/followers","following_url":"https://api.github.com/users/guobingkun/following{/other_user}","gists_url":"https://api.github.com/users/guobingkun/gists{/gist_id}","starred_url":"https://api.github.com/users/guobingkun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guobingkun/subscriptions","organizations_url":"https://api.github.com/users/guobingkun/orgs","repos_url":"https://api.github.com/users/guobingkun/repos","events_url":"https://api.github.com/users/guobingkun/events{/privacy}","received_events_url":"https://api.github.com/users/guobingkun/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2015-12-07T20:07:05Z","updated_at":"2015-12-07T20:07:05Z","html_url":"https://github.com/druid-io/druid/pull/2056#discussion_r46869929","pull_request_url":"https://api.github.com/repos/druid-io/druid/pulls/2056","_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments/46869929"},"html":{"href":"https://github.com/druid-io/druid/pull/2056#discussion_r46869929"},"pull_request":{"href":"https://api.github.com/repos/druid-io/druid/pulls/2056"}}},"pull_request":{"url":"https://api.github.com/repos/druid-io/druid/pulls/2056","id":52865783,"html_url":"https://github.com/druid-io/druid/pull/2056","diff_url":"https://github.com/druid-io/druid/pull/2056.diff","patch_url":"https://github.com/druid-io/druid/pull/2056.patch","issue_url":"https://api.github.com/repos/druid-io/druid/issues/2056","number":2056,"state":"open","locked":false,"title":"Bug fix: stale segment in ServerSelector","user":{"login":"guobingkun","id":11789051,"avatar_url":"https://avatars.githubusercontent.com/u/11789051?v=3","gravatar_id":"","url":"https://api.github.com/users/guobingkun","html_url":"https://github.com/guobingkun","followers_url":"https://api.github.com/users/guobingkun/followers","following_url":"https://api.github.com/users/guobingkun/following{/other_user}","gists_url":"https://api.github.com/users/guobingkun/gists{/gist_id}","starred_url":"https://api.github.com/users/guobingkun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guobingkun/subscriptions","organizations_url":"https://api.github.com/users/guobingkun/orgs","repos_url":"https://api.github.com/users/guobingkun/repos","events_url":"https://api.github.com/users/guobingkun/events{/privacy}","received_events_url":"https://api.github.com/users/guobingkun/received_events","type":"User","site_admin":false},"body":"reopen of #2053\r\nWhen a realtime node announces a segment, it doesn't put dimensions information in the segment metadata. After that segment is handed off to historical, ServerSelector still holds the old segment metadata that doesn't contain dimensions information. \r\n\r\nThis PR makes ServerSelector update segment metadata each time some realtime/historical node announces that segment.","created_at":"2015-12-07T16:22:17Z","updated_at":"2015-12-07T20:07:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7e74b5743bfc1216b5feb18d049eb4ee812dd3c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/druid-io/druid/pulls/2056/commits","review_comments_url":"https://api.github.com/repos/druid-io/druid/pulls/2056/comments","review_comment_url":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druid-io/druid/issues/2056/comments","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/970b9cfcaadaa309a9dc5890ed1361ce0a9b3650","head":{"label":"guobingkun:fix_server_selector2","ref":"fix_server_selector2","sha":"970b9cfcaadaa309a9dc5890ed1361ce0a9b3650","user":{"login":"guobingkun","id":11789051,"avatar_url":"https://avatars.githubusercontent.com/u/11789051?v=3","gravatar_id":"","url":"https://api.github.com/users/guobingkun","html_url":"https://github.com/guobingkun","followers_url":"https://api.github.com/users/guobingkun/followers","following_url":"https://api.github.com/users/guobingkun/following{/other_user}","gists_url":"https://api.github.com/users/guobingkun/gists{/gist_id}","starred_url":"https://api.github.com/users/guobingkun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guobingkun/subscriptions","organizations_url":"https://api.github.com/users/guobingkun/orgs","repos_url":"https://api.github.com/users/guobingkun/repos","events_url":"https://api.github.com/users/guobingkun/events{/privacy}","received_events_url":"https://api.github.com/users/guobingkun/received_events","type":"User","site_admin":false},"repo":{"id":33376574,"name":"druid","full_name":"guobingkun/druid","owner":{"login":"guobingkun","id":11789051,"avatar_url":"https://avatars.githubusercontent.com/u/11789051?v=3","gravatar_id":"","url":"https://api.github.com/users/guobingkun","html_url":"https://github.com/guobingkun","followers_url":"https://api.github.com/users/guobingkun/followers","following_url":"https://api.github.com/users/guobingkun/following{/other_user}","gists_url":"https://api.github.com/users/guobingkun/gists{/gist_id}","starred_url":"https://api.github.com/users/guobingkun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guobingkun/subscriptions","organizations_url":"https://api.github.com/users/guobingkun/orgs","repos_url":"https://api.github.com/users/guobingkun/repos","events_url":"https://api.github.com/users/guobingkun/events{/privacy}","received_events_url":"https://api.github.com/users/guobingkun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guobingkun/druid","description":"Real²time Exploratory Analytics on Large Datasets","fork":true,"url":"https://api.github.com/repos/guobingkun/druid","forks_url":"https://api.github.com/repos/guobingkun/druid/forks","keys_url":"https://api.github.com/repos/guobingkun/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guobingkun/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guobingkun/druid/teams","hooks_url":"https://api.github.com/repos/guobingkun/druid/hooks","issue_events_url":"https://api.github.com/repos/guobingkun/druid/issues/events{/number}","events_url":"https://api.github.com/repos/guobingkun/druid/events","assignees_url":"https://api.github.com/repos/guobingkun/druid/assignees{/user}","branches_url":"https://api.github.com/repos/guobingkun/druid/branches{/branch}","tags_url":"https://api.github.com/repos/guobingkun/druid/tags","blobs_url":"https://api.github.com/repos/guobingkun/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guobingkun/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guobingkun/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/guobingkun/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guobingkun/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/guobingkun/druid/languages","stargazers_url":"https://api.github.com/repos/guobingkun/druid/stargazers","contributors_url":"https://api.github.com/repos/guobingkun/druid/contributors","subscribers_url":"https://api.github.com/repos/guobingkun/druid/subscribers","subscription_url":"https://api.github.com/repos/guobingkun/druid/subscription","commits_url":"https://api.github.com/repos/guobingkun/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/guobingkun/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/guobingkun/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/guobingkun/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/guobingkun/druid/contents/{+path}","compare_url":"https://api.github.com/repos/guobingkun/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guobingkun/druid/merges","archive_url":"https://api.github.com/repos/guobingkun/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guobingkun/druid/downloads","issues_url":"https://api.github.com/repos/guobingkun/druid/issues{/number}","pulls_url":"https://api.github.com/repos/guobingkun/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/guobingkun/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/guobingkun/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guobingkun/druid/labels{/name}","releases_url":"https://api.github.com/repos/guobingkun/druid/releases{/id}","created_at":"2015-04-03T18:24:06Z","updated_at":"2015-05-07T19:33:13Z","pushed_at":"2015-12-07T20:04:45Z","git_url":"git://github.com/guobingkun/druid.git","ssh_url":"git@github.com:guobingkun/druid.git","clone_url":"https://github.com/guobingkun/druid.git","svn_url":"https://github.com/guobingkun/druid","homepage":"http://druid.io","size":100616,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"druid-io:master","ref":"master","sha":"cacd8f7a27df817a16d8bec711777f5269dd4b8a","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"name":"druid","full_name":"druid-io/druid","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":false,"url":"https://api.github.com/repos/druid-io/druid","forks_url":"https://api.github.com/repos/druid-io/druid/forks","keys_url":"https://api.github.com/repos/druid-io/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/druid/teams","hooks_url":"https://api.github.com/repos/druid-io/druid/hooks","issue_events_url":"https://api.github.com/repos/druid-io/druid/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/druid/events","assignees_url":"https://api.github.com/repos/druid-io/druid/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/druid/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/druid/tags","blobs_url":"https://api.github.com/repos/druid-io/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/druid/languages","stargazers_url":"https://api.github.com/repos/druid-io/druid/stargazers","contributors_url":"https://api.github.com/repos/druid-io/druid/contributors","subscribers_url":"https://api.github.com/repos/druid-io/druid/subscribers","subscription_url":"https://api.github.com/repos/druid-io/druid/subscription","commits_url":"https://api.github.com/repos/druid-io/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/druid-io/druid/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/druid/merges","archive_url":"https://api.github.com/repos/druid-io/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/druid/downloads","issues_url":"https://api.github.com/repos/druid-io/druid/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/druid/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/druid/releases{/id}","created_at":"2012-10-23T19:08:07Z","updated_at":"2015-12-07T16:48:45Z","pushed_at":"2015-12-07T20:04:45Z","git_url":"git://github.com/druid-io/druid.git","ssh_url":"git@github.com:druid-io/druid.git","clone_url":"https://github.com/druid-io/druid.git","svn_url":"https://github.com/druid-io/druid","homepage":"http://druid.io","size":109484,"stargazers_count":2260,"watchers_count":2260,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":528,"mirror_url":null,"open_issues_count":252,"forks":528,"open_issues":252,"watchers":2260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/2056"},"html":{"href":"https://github.com/druid-io/druid/pull/2056"},"issue":{"href":"https://api.github.com/repos/druid-io/druid/issues/2056"},"comments":{"href":"https://api.github.com/repos/druid-io/druid/issues/2056/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/druid/pulls/2056/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druid-io/druid/pulls/2056/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/druid/statuses/970b9cfcaadaa309a9dc5890ed1361ce0a9b3650"}}}}