{"action":"created","comment":{"url":"https://api.github.com/repos/paulmillr/es6-shim/pulls/comments/31718604","id":31718604,"diff_hunk":"@@ -337,8 +349,9 @@\n         // special case support for `arguments`\n         return new ArrayIterator(o, 'value');\n       }\n-      var itFn = o[$iterator$];\n+      var itFn = ES.GetMethod(o, $iterator$);\n       if (!ES.IsCallable(itFn)) {","path":"es6-shim.js","position":42,"original_position":42,"commit_id":"62e813d913428f434dea184ba98e16a2956a4ee7","original_commit_id":"62e813d913428f434dea184ba98e16a2956a4ee7","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"body":"is this check needed now, since it's in `GetMethod`?","created_at":"2015-06-04T13:21:36Z","updated_at":"2015-06-04T13:21:36Z","html_url":"https://github.com/paulmillr/es6-shim/pull/345#discussion_r31718604","pull_request_url":"https://api.github.com/repos/paulmillr/es6-shim/pulls/345","_links":{"self":{"href":"https://api.github.com/repos/paulmillr/es6-shim/pulls/comments/31718604"},"html":{"href":"https://github.com/paulmillr/es6-shim/pull/345#discussion_r31718604"},"pull_request":{"href":"https://api.github.com/repos/paulmillr/es6-shim/pulls/345"}}},"pull_request":{"url":"https://api.github.com/repos/paulmillr/es6-shim/pulls/345","id":36902159,"html_url":"https://github.com/paulmillr/es6-shim/pull/345","diff_url":"https://github.com/paulmillr/es6-shim/pull/345.diff","patch_url":"https://github.com/paulmillr/es6-shim/pull/345.patch","issue_url":"https://api.github.com/repos/paulmillr/es6-shim/issues/345","number":345,"state":"open","locked":false,"title":"Update Promise implementation to match latest ES6 spec.","user":{"login":"cscott","id":156080,"avatar_url":"https://avatars.githubusercontent.com/u/156080?v=3","gravatar_id":"","url":"https://api.github.com/users/cscott","html_url":"https://github.com/cscott","followers_url":"https://api.github.com/users/cscott/followers","following_url":"https://api.github.com/users/cscott/following{/other_user}","gists_url":"https://api.github.com/users/cscott/gists{/gist_id}","starred_url":"https://api.github.com/users/cscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cscott/subscriptions","organizations_url":"https://api.github.com/users/cscott/orgs","repos_url":"https://api.github.com/users/cscott/repos","events_url":"https://api.github.com/users/cscott/events{/privacy}","received_events_url":"https://api.github.com/users/cscott/received_events","type":"User","site_admin":false},"body":"Includes the erratum for Promise.resolve discussed in #344.\r\n\r\nAlso fixes the Map/Set constructors, since the spec uses [[Construct]] now instead of a hidden create method, and the previous version misapplied `Symbol.species` in this role.\r\n\r\nAlso added ES.IteratorClose and updated a number of places where that is used in the latest spec, including in the implementation of `Array.from`.\r\n\r\nFixes issue #239 and #344.\r\n","created_at":"2015-06-04T04:53:17Z","updated_at":"2015-06-04T13:21:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ebf0c19eca5f2ec30ac527bcf705f1bf88dc646","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/paulmillr/es6-shim/pulls/345/commits","review_comments_url":"https://api.github.com/repos/paulmillr/es6-shim/pulls/345/comments","review_comment_url":"https://api.github.com/repos/paulmillr/es6-shim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paulmillr/es6-shim/issues/345/comments","statuses_url":"https://api.github.com/repos/paulmillr/es6-shim/statuses/62e813d913428f434dea184ba98e16a2956a4ee7","head":{"label":"cscott:promise-update","ref":"promise-update","sha":"62e813d913428f434dea184ba98e16a2956a4ee7","user":{"login":"cscott","id":156080,"avatar_url":"https://avatars.githubusercontent.com/u/156080?v=3","gravatar_id":"","url":"https://api.github.com/users/cscott","html_url":"https://github.com/cscott","followers_url":"https://api.github.com/users/cscott/followers","following_url":"https://api.github.com/users/cscott/following{/other_user}","gists_url":"https://api.github.com/users/cscott/gists{/gist_id}","starred_url":"https://api.github.com/users/cscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cscott/subscriptions","organizations_url":"https://api.github.com/users/cscott/orgs","repos_url":"https://api.github.com/users/cscott/repos","events_url":"https://api.github.com/users/cscott/events{/privacy}","received_events_url":"https://api.github.com/users/cscott/received_events","type":"User","site_admin":false},"repo":{"id":13394431,"name":"es6-shim","full_name":"cscott/es6-shim","owner":{"login":"cscott","id":156080,"avatar_url":"https://avatars.githubusercontent.com/u/156080?v=3","gravatar_id":"","url":"https://api.github.com/users/cscott","html_url":"https://github.com/cscott","followers_url":"https://api.github.com/users/cscott/followers","following_url":"https://api.github.com/users/cscott/following{/other_user}","gists_url":"https://api.github.com/users/cscott/gists{/gist_id}","starred_url":"https://api.github.com/users/cscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cscott/subscriptions","organizations_url":"https://api.github.com/users/cscott/orgs","repos_url":"https://api.github.com/users/cscott/repos","events_url":"https://api.github.com/users/cscott/events{/privacy}","received_events_url":"https://api.github.com/users/cscott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cscott/es6-shim","description":"ECMAScript 6 (Harmony) compatibility shims for legacy JavaScript engines","fork":true,"url":"https://api.github.com/repos/cscott/es6-shim","forks_url":"https://api.github.com/repos/cscott/es6-shim/forks","keys_url":"https://api.github.com/repos/cscott/es6-shim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cscott/es6-shim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cscott/es6-shim/teams","hooks_url":"https://api.github.com/repos/cscott/es6-shim/hooks","issue_events_url":"https://api.github.com/repos/cscott/es6-shim/issues/events{/number}","events_url":"https://api.github.com/repos/cscott/es6-shim/events","assignees_url":"https://api.github.com/repos/cscott/es6-shim/assignees{/user}","branches_url":"https://api.github.com/repos/cscott/es6-shim/branches{/branch}","tags_url":"https://api.github.com/repos/cscott/es6-shim/tags","blobs_url":"https://api.github.com/repos/cscott/es6-shim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cscott/es6-shim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cscott/es6-shim/git/refs{/sha}","trees_url":"https://api.github.com/repos/cscott/es6-shim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cscott/es6-shim/statuses/{sha}","languages_url":"https://api.github.com/repos/cscott/es6-shim/languages","stargazers_url":"https://api.github.com/repos/cscott/es6-shim/stargazers","contributors_url":"https://api.github.com/repos/cscott/es6-shim/contributors","subscribers_url":"https://api.github.com/repos/cscott/es6-shim/subscribers","subscription_url":"https://api.github.com/repos/cscott/es6-shim/subscription","commits_url":"https://api.github.com/repos/cscott/es6-shim/commits{/sha}","git_commits_url":"https://api.github.com/repos/cscott/es6-shim/git/commits{/sha}","comments_url":"https://api.github.com/repos/cscott/es6-shim/comments{/number}","issue_comment_url":"https://api.github.com/repos/cscott/es6-shim/issues/comments{/number}","contents_url":"https://api.github.com/repos/cscott/es6-shim/contents/{+path}","compare_url":"https://api.github.com/repos/cscott/es6-shim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cscott/es6-shim/merges","archive_url":"https://api.github.com/repos/cscott/es6-shim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cscott/es6-shim/downloads","issues_url":"https://api.github.com/repos/cscott/es6-shim/issues{/number}","pulls_url":"https://api.github.com/repos/cscott/es6-shim/pulls{/number}","milestones_url":"https://api.github.com/repos/cscott/es6-shim/milestones{/number}","notifications_url":"https://api.github.com/repos/cscott/es6-shim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cscott/es6-shim/labels{/name}","releases_url":"https://api.github.com/repos/cscott/es6-shim/releases{/id}","created_at":"2013-10-07T20:09:34Z","updated_at":"2014-06-04T18:01:22Z","pushed_at":"2015-06-04T04:51:05Z","git_url":"git://github.com/cscott/es6-shim.git","ssh_url":"git@github.com:cscott/es6-shim.git","clone_url":"https://github.com/cscott/es6-shim.git","svn_url":"https://github.com/cscott/es6-shim","homepage":"http://paulmillr.com","size":2020,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"testling-cscott"}},"base":{"label":"paulmillr:master","ref":"master","sha":"804954646ff21b323b217e39e8d188a107e2e794","user":{"login":"paulmillr","id":574696,"avatar_url":"https://avatars.githubusercontent.com/u/574696?v=3","gravatar_id":"","url":"https://api.github.com/users/paulmillr","html_url":"https://github.com/paulmillr","followers_url":"https://api.github.com/users/paulmillr/followers","following_url":"https://api.github.com/users/paulmillr/following{/other_user}","gists_url":"https://api.github.com/users/paulmillr/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmillr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmillr/subscriptions","organizations_url":"https://api.github.com/users/paulmillr/orgs","repos_url":"https://api.github.com/users/paulmillr/repos","events_url":"https://api.github.com/users/paulmillr/events{/privacy}","received_events_url":"https://api.github.com/users/paulmillr/received_events","type":"User","site_admin":false},"repo":{"id":3046507,"name":"es6-shim","full_name":"paulmillr/es6-shim","owner":{"login":"paulmillr","id":574696,"avatar_url":"https://avatars.githubusercontent.com/u/574696?v=3","gravatar_id":"","url":"https://api.github.com/users/paulmillr","html_url":"https://github.com/paulmillr","followers_url":"https://api.github.com/users/paulmillr/followers","following_url":"https://api.github.com/users/paulmillr/following{/other_user}","gists_url":"https://api.github.com/users/paulmillr/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmillr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmillr/subscriptions","organizations_url":"https://api.github.com/users/paulmillr/orgs","repos_url":"https://api.github.com/users/paulmillr/repos","events_url":"https://api.github.com/users/paulmillr/events{/privacy}","received_events_url":"https://api.github.com/users/paulmillr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulmillr/es6-shim","description":"ECMAScript 6 (Harmony) compatibility shims for legacy JavaScript engines","fork":false,"url":"https://api.github.com/repos/paulmillr/es6-shim","forks_url":"https://api.github.com/repos/paulmillr/es6-shim/forks","keys_url":"https://api.github.com/repos/paulmillr/es6-shim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulmillr/es6-shim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulmillr/es6-shim/teams","hooks_url":"https://api.github.com/repos/paulmillr/es6-shim/hooks","issue_events_url":"https://api.github.com/repos/paulmillr/es6-shim/issues/events{/number}","events_url":"https://api.github.com/repos/paulmillr/es6-shim/events","assignees_url":"https://api.github.com/repos/paulmillr/es6-shim/assignees{/user}","branches_url":"https://api.github.com/repos/paulmillr/es6-shim/branches{/branch}","tags_url":"https://api.github.com/repos/paulmillr/es6-shim/tags","blobs_url":"https://api.github.com/repos/paulmillr/es6-shim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulmillr/es6-shim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulmillr/es6-shim/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulmillr/es6-shim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulmillr/es6-shim/statuses/{sha}","languages_url":"https://api.github.com/repos/paulmillr/es6-shim/languages","stargazers_url":"https://api.github.com/repos/paulmillr/es6-shim/stargazers","contributors_url":"https://api.github.com/repos/paulmillr/es6-shim/contributors","subscribers_url":"https://api.github.com/repos/paulmillr/es6-shim/subscribers","subscription_url":"https://api.github.com/repos/paulmillr/es6-shim/subscription","commits_url":"https://api.github.com/repos/paulmillr/es6-shim/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulmillr/es6-shim/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulmillr/es6-shim/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulmillr/es6-shim/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulmillr/es6-shim/contents/{+path}","compare_url":"https://api.github.com/repos/paulmillr/es6-shim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulmillr/es6-shim/merges","archive_url":"https://api.github.com/repos/paulmillr/es6-shim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulmillr/es6-shim/downloads","issues_url":"https://api.github.com/repos/paulmillr/es6-shim/issues{/number}","pulls_url":"https://api.github.com/repos/paulmillr/es6-shim/pulls{/number}","milestones_url":"https://api.github.com/repos/paulmillr/es6-shim/milestones{/number}","notifications_url":"https://api.github.com/repos/paulmillr/es6-shim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulmillr/es6-shim/labels{/name}","releases_url":"https://api.github.com/repos/paulmillr/es6-shim/releases{/id}","created_at":"2011-12-25T00:29:07Z","updated_at":"2015-06-04T12:03:25Z","pushed_at":"2015-06-04T04:53:18Z","git_url":"git://github.com/paulmillr/es6-shim.git","ssh_url":"git@github.com:paulmillr/es6-shim.git","clone_url":"https://github.com/paulmillr/es6-shim.git","svn_url":"https://github.com/paulmillr/es6-shim","homepage":"http://paulmillr.com","size":4979,"stargazers_count":1179,"watchers_count":1179,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":90,"mirror_url":null,"open_issues_count":22,"forks":90,"open_issues":22,"watchers":1179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paulmillr/es6-shim/pulls/345"},"html":{"href":"https://github.com/paulmillr/es6-shim/pull/345"},"issue":{"href":"https://api.github.com/repos/paulmillr/es6-shim/issues/345"},"comments":{"href":"https://api.github.com/repos/paulmillr/es6-shim/issues/345/comments"},"review_comments":{"href":"https://api.github.com/repos/paulmillr/es6-shim/pulls/345/comments"},"review_comment":{"href":"https://api.github.com/repos/paulmillr/es6-shim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paulmillr/es6-shim/pulls/345/commits"},"statuses":{"href":"https://api.github.com/repos/paulmillr/es6-shim/statuses/62e813d913428f434dea184ba98e16a2956a4ee7"}}}}