{"action":"created","comment":{"url":"https://api.github.com/repos/democracyworks/election-authority-works/pulls/comments/42524001","id":42524001,"diff_hunk":"@@ -86,6 +126,31 @@\n                [(:instruction/type inst)\n                 (:instruction/text inst)]))))\n \n+(defn entity->field\n+  [{:keys [field/name\n+           field/requirement]}]\n+  [name requirement])\n+\n+(defn entity->form\n+  [{:keys [form/name\n+           form/field]}]\n+  {:name name\n+   :fields (into {} (map entity->field field))})\n+\n+(defn entity->voter-registration-method\n+  [{:keys [voter-registration-method/type\n+           voter-registration-method/instructions\n+           voter-registration-method/url\n+           voter-registration-method/supports-iframe\n+           voter-registration-method/acceptable-form]}]\n+  (db/dissoc-optional-nil-values\n+   {:type type\n+    :instructions (not-empty (set (map entity->instructions instructions)))","path":"src/election_authority_works/entities/authority.clj","position":82,"original_position":82,"commit_id":"407b67c15eafe53ad1aa9438c833c84c72c53c5c","original_commit_id":"407b67c15eafe53ad1aa9438c833c84c72c53c5c","user":{"login":"ericnormand","id":116172,"avatar_url":"https://avatars.githubusercontent.com/u/116172?v=3","gravatar_id":"","url":"https://api.github.com/users/ericnormand","html_url":"https://github.com/ericnormand","followers_url":"https://api.github.com/users/ericnormand/followers","following_url":"https://api.github.com/users/ericnormand/following{/other_user}","gists_url":"https://api.github.com/users/ericnormand/gists{/gist_id}","starred_url":"https://api.github.com/users/ericnormand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericnormand/subscriptions","organizations_url":"https://api.github.com/users/ericnormand/orgs","repos_url":"https://api.github.com/users/ericnormand/repos","events_url":"https://api.github.com/users/ericnormand/events{/privacy}","received_events_url":"https://api.github.com/users/ericnormand/received_events","type":"User","site_admin":false},"body":"I assumed we were making a set of these, but it looks like yours is a map of type to text. Can you change that, @cap10morgan ?","created_at":"2015-10-20T17:10:37Z","updated_at":"2015-10-20T17:10:37Z","html_url":"https://github.com/democracyworks/election-authority-works/pull/9#discussion_r42524001","pull_request_url":"https://api.github.com/repos/democracyworks/election-authority-works/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/democracyworks/election-authority-works/pulls/comments/42524001"},"html":{"href":"https://github.com/democracyworks/election-authority-works/pull/9#discussion_r42524001"},"pull_request":{"href":"https://api.github.com/repos/democracyworks/election-authority-works/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/democracyworks/election-authority-works/pulls/9","id":47947878,"html_url":"https://github.com/democracyworks/election-authority-works/pull/9","diff_url":"https://github.com/democracyworks/election-authority-works/pull/9.diff","patch_url":"https://github.com/democracyworks/election-authority-works/pull/9.patch","issue_url":"https://api.github.com/repos/democracyworks/election-authority-works/issues/9","number":9,"state":"open","locked":false,"title":"Default voter registration methods","user":{"login":"ericnormand","id":116172,"avatar_url":"https://avatars.githubusercontent.com/u/116172?v=3","gravatar_id":"","url":"https://api.github.com/users/ericnormand","html_url":"https://github.com/ericnormand","followers_url":"https://api.github.com/users/ericnormand/followers","following_url":"https://api.github.com/users/ericnormand/following{/other_user}","gists_url":"https://api.github.com/users/ericnormand/gists{/gist_id}","starred_url":"https://api.github.com/users/ericnormand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericnormand/subscriptions","organizations_url":"https://api.github.com/users/ericnormand/orgs","repos_url":"https://api.github.com/users/ericnormand/repos","events_url":"https://api.github.com/users/ericnormand/events{/privacy}","received_events_url":"https://api.github.com/users/ericnormand/received_events","type":"User","site_admin":false},"body":"Hello!!\r\n\r\n[Pivotal Card](https://www.pivotaltracker.com/story/show/103450168)\r\n\r\nWould you like to see the wonders of this PR? Well, step right up!!\r\n\r\nDid you know that election authorities have *default voter-registration-methods*? You know that whenever they hold an election, that election **inherits the default voter-registration-methods from the authority** that handles registration?\r\n\r\nWell, we needed a place to store those registration methods on our authorities, and that's what this does.\r\n\r\nWe can write election authorities and read them back in. We've got tests for that!","created_at":"2015-10-16T19:04:17Z","updated_at":"2015-10-20T17:10:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1a9182fe0bca841cd3c0fd333686cf387a2002e","assignee":{"login":"danielglauser","id":102263,"avatar_url":"https://avatars.githubusercontent.com/u/102263?v=3","gravatar_id":"","url":"https://api.github.com/users/danielglauser","html_url":"https://github.com/danielglauser","followers_url":"https://api.github.com/users/danielglauser/followers","following_url":"https://api.github.com/users/danielglauser/following{/other_user}","gists_url":"https://api.github.com/users/danielglauser/gists{/gist_id}","starred_url":"https://api.github.com/users/danielglauser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielglauser/subscriptions","organizations_url":"https://api.github.com/users/danielglauser/orgs","repos_url":"https://api.github.com/users/danielglauser/repos","events_url":"https://api.github.com/users/danielglauser/events{/privacy}","received_events_url":"https://api.github.com/users/danielglauser/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/democracyworks/election-authority-works/pulls/9/commits","review_comments_url":"https://api.github.com/repos/democracyworks/election-authority-works/pulls/9/comments","review_comment_url":"https://api.github.com/repos/democracyworks/election-authority-works/pulls/comments{/number}","comments_url":"https://api.github.com/repos/democracyworks/election-authority-works/issues/9/comments","statuses_url":"https://api.github.com/repos/democracyworks/election-authority-works/statuses/407b67c15eafe53ad1aa9438c833c84c72c53c5c","head":{"label":"democracyworks:default-voter-registration-methods","ref":"default-voter-registration-methods","sha":"407b67c15eafe53ad1aa9438c833c84c72c53c5c","user":{"login":"democracyworks","id":1373557,"avatar_url":"https://avatars.githubusercontent.com/u/1373557?v=3","gravatar_id":"","url":"https://api.github.com/users/democracyworks","html_url":"https://github.com/democracyworks","followers_url":"https://api.github.com/users/democracyworks/followers","following_url":"https://api.github.com/users/democracyworks/following{/other_user}","gists_url":"https://api.github.com/users/democracyworks/gists{/gist_id}","starred_url":"https://api.github.com/users/democracyworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/democracyworks/subscriptions","organizations_url":"https://api.github.com/users/democracyworks/orgs","repos_url":"https://api.github.com/users/democracyworks/repos","events_url":"https://api.github.com/users/democracyworks/events{/privacy}","received_events_url":"https://api.github.com/users/democracyworks/received_events","type":"Organization","site_admin":false},"repo":{"id":37270076,"name":"election-authority-works","full_name":"democracyworks/election-authority-works","owner":{"login":"democracyworks","id":1373557,"avatar_url":"https://avatars.githubusercontent.com/u/1373557?v=3","gravatar_id":"","url":"https://api.github.com/users/democracyworks","html_url":"https://github.com/democracyworks","followers_url":"https://api.github.com/users/democracyworks/followers","following_url":"https://api.github.com/users/democracyworks/following{/other_user}","gists_url":"https://api.github.com/users/democracyworks/gists{/gist_id}","starred_url":"https://api.github.com/users/democracyworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/democracyworks/subscriptions","organizations_url":"https://api.github.com/users/democracyworks/orgs","repos_url":"https://api.github.com/users/democracyworks/repos","events_url":"https://api.github.com/users/democracyworks/events{/privacy}","received_events_url":"https://api.github.com/users/democracyworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/democracyworks/election-authority-works","description":"","fork":false,"url":"https://api.github.com/repos/democracyworks/election-authority-works","forks_url":"https://api.github.com/repos/democracyworks/election-authority-works/forks","keys_url":"https://api.github.com/repos/democracyworks/election-authority-works/keys{/key_id}","collaborators_url":"https://api.github.com/repos/democracyworks/election-authority-works/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/democracyworks/election-authority-works/teams","hooks_url":"https://api.github.com/repos/democracyworks/election-authority-works/hooks","issue_events_url":"https://api.github.com/repos/democracyworks/election-authority-works/issues/events{/number}","events_url":"https://api.github.com/repos/democracyworks/election-authority-works/events","assignees_url":"https://api.github.com/repos/democracyworks/election-authority-works/assignees{/user}","branches_url":"https://api.github.com/repos/democracyworks/election-authority-works/branches{/branch}","tags_url":"https://api.github.com/repos/democracyworks/election-authority-works/tags","blobs_url":"https://api.github.com/repos/democracyworks/election-authority-works/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/democracyworks/election-authority-works/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/democracyworks/election-authority-works/git/refs{/sha}","trees_url":"https://api.github.com/repos/democracyworks/election-authority-works/git/trees{/sha}","statuses_url":"https://api.github.com/repos/democracyworks/election-authority-works/statuses/{sha}","languages_url":"https://api.github.com/repos/democracyworks/election-authority-works/languages","stargazers_url":"https://api.github.com/repos/democracyworks/election-authority-works/stargazers","contributors_url":"https://api.github.com/repos/democracyworks/election-authority-works/contributors","subscribers_url":"https://api.github.com/repos/democracyworks/election-authority-works/subscribers","subscription_url":"https://api.github.com/repos/democracyworks/election-authority-works/subscription","commits_url":"https://api.github.com/repos/democracyworks/election-authority-works/commits{/sha}","git_commits_url":"https://api.github.com/repos/democracyworks/election-authority-works/git/commits{/sha}","comments_url":"https://api.github.com/repos/democracyworks/election-authority-works/comments{/number}","issue_comment_url":"https://api.github.com/repos/democracyworks/election-authority-works/issues/comments{/number}","contents_url":"https://api.github.com/repos/democracyworks/election-authority-works/contents/{+path}","compare_url":"https://api.github.com/repos/democracyworks/election-authority-works/compare/{base}...{head}","merges_url":"https://api.github.com/repos/democracyworks/election-authority-works/merges","archive_url":"https://api.github.com/repos/democracyworks/election-authority-works/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/democracyworks/election-authority-works/downloads","issues_url":"https://api.github.com/repos/democracyworks/election-authority-works/issues{/number}","pulls_url":"https://api.github.com/repos/democracyworks/election-authority-works/pulls{/number}","milestones_url":"https://api.github.com/repos/democracyworks/election-authority-works/milestones{/number}","notifications_url":"https://api.github.com/repos/democracyworks/election-authority-works/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/democracyworks/election-authority-works/labels{/name}","releases_url":"https://api.github.com/repos/democracyworks/election-authority-works/releases{/id}","created_at":"2015-06-11T15:38:40Z","updated_at":"2015-06-11T15:38:53Z","pushed_at":"2015-10-20T16:40:47Z","git_url":"git://github.com/democracyworks/election-authority-works.git","ssh_url":"git@github.com:democracyworks/election-authority-works.git","clone_url":"https://github.com/democracyworks/election-authority-works.git","svn_url":"https://github.com/democracyworks/election-authority-works","homepage":null,"size":272,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"democracyworks:master","ref":"master","sha":"ffdcd785a91da75fa4bc74620a517674f81dd7a3","user":{"login":"democracyworks","id":1373557,"avatar_url":"https://avatars.githubusercontent.com/u/1373557?v=3","gravatar_id":"","url":"https://api.github.com/users/democracyworks","html_url":"https://github.com/democracyworks","followers_url":"https://api.github.com/users/democracyworks/followers","following_url":"https://api.github.com/users/democracyworks/following{/other_user}","gists_url":"https://api.github.com/users/democracyworks/gists{/gist_id}","starred_url":"https://api.github.com/users/democracyworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/democracyworks/subscriptions","organizations_url":"https://api.github.com/users/democracyworks/orgs","repos_url":"https://api.github.com/users/democracyworks/repos","events_url":"https://api.github.com/users/democracyworks/events{/privacy}","received_events_url":"https://api.github.com/users/democracyworks/received_events","type":"Organization","site_admin":false},"repo":{"id":37270076,"name":"election-authority-works","full_name":"democracyworks/election-authority-works","owner":{"login":"democracyworks","id":1373557,"avatar_url":"https://avatars.githubusercontent.com/u/1373557?v=3","gravatar_id":"","url":"https://api.github.com/users/democracyworks","html_url":"https://github.com/democracyworks","followers_url":"https://api.github.com/users/democracyworks/followers","following_url":"https://api.github.com/users/democracyworks/following{/other_user}","gists_url":"https://api.github.com/users/democracyworks/gists{/gist_id}","starred_url":"https://api.github.com/users/democracyworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/democracyworks/subscriptions","organizations_url":"https://api.github.com/users/democracyworks/orgs","repos_url":"https://api.github.com/users/democracyworks/repos","events_url":"https://api.github.com/users/democracyworks/events{/privacy}","received_events_url":"https://api.github.com/users/democracyworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/democracyworks/election-authority-works","description":"","fork":false,"url":"https://api.github.com/repos/democracyworks/election-authority-works","forks_url":"https://api.github.com/repos/democracyworks/election-authority-works/forks","keys_url":"https://api.github.com/repos/democracyworks/election-authority-works/keys{/key_id}","collaborators_url":"https://api.github.com/repos/democracyworks/election-authority-works/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/democracyworks/election-authority-works/teams","hooks_url":"https://api.github.com/repos/democracyworks/election-authority-works/hooks","issue_events_url":"https://api.github.com/repos/democracyworks/election-authority-works/issues/events{/number}","events_url":"https://api.github.com/repos/democracyworks/election-authority-works/events","assignees_url":"https://api.github.com/repos/democracyworks/election-authority-works/assignees{/user}","branches_url":"https://api.github.com/repos/democracyworks/election-authority-works/branches{/branch}","tags_url":"https://api.github.com/repos/democracyworks/election-authority-works/tags","blobs_url":"https://api.github.com/repos/democracyworks/election-authority-works/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/democracyworks/election-authority-works/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/democracyworks/election-authority-works/git/refs{/sha}","trees_url":"https://api.github.com/repos/democracyworks/election-authority-works/git/trees{/sha}","statuses_url":"https://api.github.com/repos/democracyworks/election-authority-works/statuses/{sha}","languages_url":"https://api.github.com/repos/democracyworks/election-authority-works/languages","stargazers_url":"https://api.github.com/repos/democracyworks/election-authority-works/stargazers","contributors_url":"https://api.github.com/repos/democracyworks/election-authority-works/contributors","subscribers_url":"https://api.github.com/repos/democracyworks/election-authority-works/subscribers","subscription_url":"https://api.github.com/repos/democracyworks/election-authority-works/subscription","commits_url":"https://api.github.com/repos/democracyworks/election-authority-works/commits{/sha}","git_commits_url":"https://api.github.com/repos/democracyworks/election-authority-works/git/commits{/sha}","comments_url":"https://api.github.com/repos/democracyworks/election-authority-works/comments{/number}","issue_comment_url":"https://api.github.com/repos/democracyworks/election-authority-works/issues/comments{/number}","contents_url":"https://api.github.com/repos/democracyworks/election-authority-works/contents/{+path}","compare_url":"https://api.github.com/repos/democracyworks/election-authority-works/compare/{base}...{head}","merges_url":"https://api.github.com/repos/democracyworks/election-authority-works/merges","archive_url":"https://api.github.com/repos/democracyworks/election-authority-works/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/democracyworks/election-authority-works/downloads","issues_url":"https://api.github.com/repos/democracyworks/election-authority-works/issues{/number}","pulls_url":"https://api.github.com/repos/democracyworks/election-authority-works/pulls{/number}","milestones_url":"https://api.github.com/repos/democracyworks/election-authority-works/milestones{/number}","notifications_url":"https://api.github.com/repos/democracyworks/election-authority-works/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/democracyworks/election-authority-works/labels{/name}","releases_url":"https://api.github.com/repos/democracyworks/election-authority-works/releases{/id}","created_at":"2015-06-11T15:38:40Z","updated_at":"2015-06-11T15:38:53Z","pushed_at":"2015-10-20T16:40:47Z","git_url":"git://github.com/democracyworks/election-authority-works.git","ssh_url":"git@github.com:democracyworks/election-authority-works.git","clone_url":"https://github.com/democracyworks/election-authority-works.git","svn_url":"https://github.com/democracyworks/election-authority-works","homepage":null,"size":272,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/democracyworks/election-authority-works/pulls/9"},"html":{"href":"https://github.com/democracyworks/election-authority-works/pull/9"},"issue":{"href":"https://api.github.com/repos/democracyworks/election-authority-works/issues/9"},"comments":{"href":"https://api.github.com/repos/democracyworks/election-authority-works/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/democracyworks/election-authority-works/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/democracyworks/election-authority-works/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/democracyworks/election-authority-works/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/democracyworks/election-authority-works/statuses/407b67c15eafe53ad1aa9438c833c84c72c53c5c"}}}}