{"action":"created","issue":{"url":"https://api.github.com/repos/kreft/iDynoMiCS/issues/58","labels_url":"https://api.github.com/repos/kreft/iDynoMiCS/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/kreft/iDynoMiCS/issues/58/comments","events_url":"https://api.github.com/repos/kreft/iDynoMiCS/issues/58/events","html_url":"https://github.com/kreft/iDynoMiCS/issues/58","id":54171324,"number":58,"title":"Dealing with padding","user":{"login":"roughhawkbit","id":3294753,"avatar_url":"https://avatars.githubusercontent.com/u/3294753?v=3","gravatar_id":"","url":"https://api.github.com/users/roughhawkbit","html_url":"https://github.com/roughhawkbit","followers_url":"https://api.github.com/users/roughhawkbit/followers","following_url":"https://api.github.com/users/roughhawkbit/following{/other_user}","gists_url":"https://api.github.com/users/roughhawkbit/gists{/gist_id}","starred_url":"https://api.github.com/users/roughhawkbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roughhawkbit/subscriptions","organizations_url":"https://api.github.com/users/roughhawkbit/orgs","repos_url":"https://api.github.com/users/roughhawkbit/repos","events_url":"https://api.github.com/users/roughhawkbit/events{/privacy}","received_events_url":"https://api.github.com/users/roughhawkbit/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-13T10:05:57Z","updated_at":"2015-01-13T10:40:22Z","closed_at":null,"body":"Potential inconsistency between `SpatialGrid.isValid(DiscreteVector dC)` (1) and `SpatialGrid.isValidOrPadded(int i, int j, int k)` (2). The comment for (1) claims that it excludes padding, whereas (2) is commented as including padding. (1) allows values for 0 <= i < nI, 0 <= j < nJ, 0 <= k < nK and (2) allows values for 0 <= i <= nI, 0 <= j <= nJ, 0 <= k <= nK. So, while there is a difference in how the two deal with nI/nJ/nK values, they deal with 0 values identically.\r\n\r\nA third, unused, method `SpatialGrid.isValidOrPadded(DiscreteVector dC)` allowed values for -1 <= i < nI, -1 <= j < nJ, -1 <= k < nK. This will be removed.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/kreft/iDynoMiCS/issues/comments/69725746","html_url":"https://github.com/kreft/iDynoMiCS/issues/58#issuecomment-69725746","issue_url":"https://api.github.com/repos/kreft/iDynoMiCS/issues/58","id":69725746,"user":{"login":"roughhawkbit","id":3294753,"avatar_url":"https://avatars.githubusercontent.com/u/3294753?v=3","gravatar_id":"","url":"https://api.github.com/users/roughhawkbit","html_url":"https://github.com/roughhawkbit","followers_url":"https://api.github.com/users/roughhawkbit/followers","following_url":"https://api.github.com/users/roughhawkbit/following{/other_user}","gists_url":"https://api.github.com/users/roughhawkbit/gists{/gist_id}","starred_url":"https://api.github.com/users/roughhawkbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roughhawkbit/subscriptions","organizations_url":"https://api.github.com/users/roughhawkbit/orgs","repos_url":"https://api.github.com/users/roughhawkbit/repos","events_url":"https://api.github.com/users/roughhawkbit/events{/privacy}","received_events_url":"https://api.github.com/users/roughhawkbit/received_events","type":"User","site_admin":false},"created_at":"2015-01-13T10:40:22Z","updated_at":"2015-01-13T10:40:22Z","body":"Also worth noting that `DiscreteVector(ContinuousVector cV, Double res)` uses `Math.ceil` of `cV.x/res`, etc, whereas `SpatialGrid.getDiscreteCoordinates(ContinuousVector cC)` uses `Math.floor`. "}}