{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest/issues/439","labels_url":"https://api.github.com/repos/minetest/minetest/issues/439/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/439/comments","events_url":"https://api.github.com/repos/minetest/minetest/issues/439/events","html_url":"https://github.com/minetest/minetest/pull/439","id":10243115,"number":439,"title":"Add missing faces for flowing liquids and liquid sources.","user":{"login":"doserj","id":2903193,"avatar_url":"https://avatars.githubusercontent.com/u/2903193?v=3","gravatar_id":"","url":"https://api.github.com/users/doserj","html_url":"https://github.com/doserj","followers_url":"https://api.github.com/users/doserj/followers","following_url":"https://api.github.com/users/doserj/following{/other_user}","gists_url":"https://api.github.com/users/doserj/gists{/gist_id}","starred_url":"https://api.github.com/users/doserj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doserj/subscriptions","organizations_url":"https://api.github.com/users/doserj/orgs","repos_url":"https://api.github.com/users/doserj/repos","events_url":"https://api.github.com/users/doserj/events{/privacy}","received_events_url":"https://api.github.com/users/doserj/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/minetest/minetest/labels/@%20Client%20/%20Audiovisuals","name":"@ Client / Audiovisuals","color":"009800"},{"url":"https://api.github.com/repos/minetest/minetest/labels/rebase%20needed","name":"rebase needed","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2013-01-23T17:55:28Z","updated_at":"2015-02-07T21:37:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/439","html_url":"https://github.com/minetest/minetest/pull/439","diff_url":"https://github.com/minetest/minetest/pull/439.diff","patch_url":"https://github.com/minetest/minetest/pull/439.patch"},"body":"1. Draw the bottom face of a flowing liquid node if the node below is not\r\nthe same liquid, and not solid.\r\n\r\n2. Change the texture to draw for top and bottom faces to the source\r\nliquid texture when the liquid flows straight down, so the liquid\r\ndoesn't appear to flow in some random direction.\r\n\r\n3. Include backface_culling flag in serialization format for TileDefs. \r\nThis way flowing liquids actually show the backface when specified to\r\ndo so. Without this, TileDefs where by default initialized with\r\nbackface_culling = true and never set otherwise.\r\n\r\n4. Draw face between liquid sources of different kinds.\r\nThis is not the ideal way to do it. Ideally, we would take the\r\ntextures from both kinds of liquids, and show them on the opposite\r\nsides, with backface_culling enabled. That would involve further\r\nchanges in the code, though.\r\n\r\nWith this patch, we take the texture from one liquid and show it on\r\nboth sides, i.e., with backface_culling disabled,"},"comment":{"url":"https://api.github.com/repos/minetest/minetest/issues/comments/73384370","html_url":"https://github.com/minetest/minetest/pull/439#issuecomment-73384370","issue_url":"https://api.github.com/repos/minetest/minetest/issues/439","id":73384370,"user":{"login":"HybridDog","id":3192173,"avatar_url":"https://avatars.githubusercontent.com/u/3192173?v=3","gravatar_id":"","url":"https://api.github.com/users/HybridDog","html_url":"https://github.com/HybridDog","followers_url":"https://api.github.com/users/HybridDog/followers","following_url":"https://api.github.com/users/HybridDog/following{/other_user}","gists_url":"https://api.github.com/users/HybridDog/gists{/gist_id}","starred_url":"https://api.github.com/users/HybridDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HybridDog/subscriptions","organizations_url":"https://api.github.com/users/HybridDog/orgs","repos_url":"https://api.github.com/users/HybridDog/repos","events_url":"https://api.github.com/users/HybridDog/events{/privacy}","received_events_url":"https://api.github.com/users/HybridDog/received_events","type":"User","site_admin":false},"created_at":"2015-02-07T21:37:07Z","updated_at":"2015-02-07T21:37:07Z","body":"This can be closed, can't it?"}}