{"action":"created","comment":{"url":"https://api.github.com/repos/ymatsukawa/custom_lodge/pulls/comments/34796340","id":34796340,"diff_hunk":"@@ -24,6 +45,67 @@\n   password_confirmation:  PASSWORD_CONFIRMATION,\n }\n \n+VALID_ARTICLE_RESOURCE = {\n+  title:              TITLE,\n+  body:               BODY,\n+  tag_list:           TAG_LIST,\n+  is_public_editable: IS_PUBLIC_EDITABLE,\n+  lock_version:       LOCK_VERSION,\n+  user_id:            'pass resource in test case',\n+}\n+\n VALID_USERS_REQUEST_PARAMS = {\n   user: VALID_USERS_RESOURCE\n }\n+\n+INVALID_USERS_REQUEST_PARAMS_LIST = [\n+  { name:                   INVALID_NAME                  },\n+  { email:                  INVALID_EMAIL                 },\n+  { notice_mail_send_state: INVALID_MAIL_SEND_STATE       },\n+  { current_password:       INVALID_CURRENT_PASSWORD      },\n+  { password:               INVALID_PASSWORD              },\n+  { password_confirmation:  INVALID_PASSWORD_CONFIRMATION },\n+  { current_password:       INVALID_CURRENT_PASSWORD,\n+    password:               INVALID_PASSWORD              },\n+  { current_password:       INVALID_CURRENT_PASSWORD,\n+    password_confirmation:  INVALID_PASSWORD_CONFIRMATION },\n+  { password:               INVALID_PASSWORD,\n+    password_confirmation:  INVALID_PASSWORD_CONFIRMATION },\n+  { current_password:       INVALID_CURRENT_PASSWORD,\n+    password:               INVALID_PASSWORD,\n+    password_confirmation:  INVALID_PASSWORD_CONFIRMATION },\n+]\n+\n+VALID_ARTICLE_REQUEST_PARAMS = {\n+  article: VALID_ARTICLE_RESOURCE\n+}\n+\n+INVALID_ARTICLE_REQUEST_PARAMS_LIST = [\n+  { title:              INVALID_TITLE },\n+  { body:               INVALID_BODY  },\n+  # below is success case, check after customize\n+  ## { is_public_editable: INVALID_IS_PUBLIC_EDITABLE },\n+  ## { lock_version:       INVALID_LOCK_VERSION       },\n+  ## { user_id:            INVALID_USER_ID            },\n+]\n+\n+VALID_ARTICLE_CONTROLLER_PARAMS        = VALID_ARTICLE_REQUEST_PARAMS\n+INVALID_ARTICLE_CONTROLLER_PARAMS_LIST = INVALID_ARTICLE_REQUEST_PARAMS_LIST\n+\n+VALID_COMMENTS_RESOURCE = {\n+  body:       COMMENT_BODY,\n+  user_id:    'pass resource at test',","path":"spec/support/support_datas.rb","position":96,"original_position":96,"commit_id":"31c2c5b6ac4082284c3a612b39f7f1ede7ebe69f","original_commit_id":"31c2c5b6ac4082284c3a612b39f7f1ede7ebe69f","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Unnecessary spacing detected.<br>Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2015-07-16T14:57:16Z","updated_at":"2015-07-16T14:57:16Z","html_url":"https://github.com/ymatsukawa/custom_lodge/pull/2#discussion_r34796340","pull_request_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/ymatsukawa/custom_lodge/pulls/comments/34796340"},"html":{"href":"https://github.com/ymatsukawa/custom_lodge/pull/2#discussion_r34796340"},"pull_request":{"href":"https://api.github.com/repos/ymatsukawa/custom_lodge/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/ymatsukawa/custom_lodge/pulls/2","id":40138293,"html_url":"https://github.com/ymatsukawa/custom_lodge/pull/2","diff_url":"https://github.com/ymatsukawa/custom_lodge/pull/2.diff","patch_url":"https://github.com/ymatsukawa/custom_lodge/pull/2.patch","issue_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/issues/2","number":2,"state":"open","locked":false,"title":"user will (or will not) receive notice-email when article-comment post","user":{"login":"ymatsukawa","id":3273466,"avatar_url":"https://avatars.githubusercontent.com/u/3273466?v=3","gravatar_id":"","url":"https://api.github.com/users/ymatsukawa","html_url":"https://github.com/ymatsukawa","followers_url":"https://api.github.com/users/ymatsukawa/followers","following_url":"https://api.github.com/users/ymatsukawa/following{/other_user}","gists_url":"https://api.github.com/users/ymatsukawa/gists{/gist_id}","starred_url":"https://api.github.com/users/ymatsukawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymatsukawa/subscriptions","organizations_url":"https://api.github.com/users/ymatsukawa/orgs","repos_url":"https://api.github.com/users/ymatsukawa/repos","events_url":"https://api.github.com/users/ymatsukawa/events{/privacy}","received_events_url":"https://api.github.com/users/ymatsukawa/received_events","type":"User","site_admin":false},"body":"セルフレビュープルリク\r\n\r\n# 追加・修正点\r\n\r\nユーザーが記事投稿・コメント投稿したときに\r\n「メールお知らせ状態」を「オン」にしているユーザーへメール送信する\r\n(モジュールレベルでの結合テストを実施, サービスレベルでは結合テスト未実施)\r\n\r\n* サービス観点\r\n  * 上記要点通り\r\n* プロダクション観点\r\n  * ActiveJob の導入 → メール送信時に発生する O(n) 問題解決\r\n  * daemons gem 導入(production 環境構築に向けて)\r\n  * HoundCI  導入\r\n  * model のロジックを今後以下の方針にて実施(自分が加筆訂正するモジュールだけ)\r\n    * data access は dao モジュール直下のファイルに限定\r\n    * ビジネスロジックは models 直下の ファイルに限定\r\n* テスト観点\r\n  * request spec は status code と、redirection があれば location の expect のみに留める\r\n  * controller spec は request spec とリクエストが重複し<br>ロジック分岐だけにテストが留まるならば対応しない\r\n* データ観点\r\n  * なし\r\n\r\n# セルフレビュー後について\r\n\r\n* 対応が終わったら squash せずに 1 コミットで修正 push するように\r\n  * プルリクコメント消えるので","created_at":"2015-07-16T14:57:05Z","updated_at":"2015-07-16T14:57:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48a6bff5e5c986d9cb744148b686a0e811887d34","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/issues/2/comments","statuses_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/statuses/31c2c5b6ac4082284c3a612b39f7f1ede7ebe69f","head":{"label":"ymatsukawa:enable_to_send_notice_email","ref":"enable_to_send_notice_email","sha":"31c2c5b6ac4082284c3a612b39f7f1ede7ebe69f","user":{"login":"ymatsukawa","id":3273466,"avatar_url":"https://avatars.githubusercontent.com/u/3273466?v=3","gravatar_id":"","url":"https://api.github.com/users/ymatsukawa","html_url":"https://github.com/ymatsukawa","followers_url":"https://api.github.com/users/ymatsukawa/followers","following_url":"https://api.github.com/users/ymatsukawa/following{/other_user}","gists_url":"https://api.github.com/users/ymatsukawa/gists{/gist_id}","starred_url":"https://api.github.com/users/ymatsukawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymatsukawa/subscriptions","organizations_url":"https://api.github.com/users/ymatsukawa/orgs","repos_url":"https://api.github.com/users/ymatsukawa/repos","events_url":"https://api.github.com/users/ymatsukawa/events{/privacy}","received_events_url":"https://api.github.com/users/ymatsukawa/received_events","type":"User","site_admin":false},"repo":{"id":38691419,"name":"custom_lodge","full_name":"ymatsukawa/custom_lodge","owner":{"login":"ymatsukawa","id":3273466,"avatar_url":"https://avatars.githubusercontent.com/u/3273466?v=3","gravatar_id":"","url":"https://api.github.com/users/ymatsukawa","html_url":"https://github.com/ymatsukawa","followers_url":"https://api.github.com/users/ymatsukawa/followers","following_url":"https://api.github.com/users/ymatsukawa/following{/other_user}","gists_url":"https://api.github.com/users/ymatsukawa/gists{/gist_id}","starred_url":"https://api.github.com/users/ymatsukawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymatsukawa/subscriptions","organizations_url":"https://api.github.com/users/ymatsukawa/orgs","repos_url":"https://api.github.com/users/ymatsukawa/repos","events_url":"https://api.github.com/users/ymatsukawa/events{/privacy}","received_events_url":"https://api.github.com/users/ymatsukawa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ymatsukawa/custom_lodge","description":"本家のLodge は右 URI にございます https://github.com/lodge/lodge    本リポジトリには MIT  ライセンスに遵守したカスタマイズ版の Lodge を置いています(showing respect to m-yamashita -san, kakusuke -san)","fork":false,"url":"https://api.github.com/repos/ymatsukawa/custom_lodge","forks_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/forks","keys_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/teams","hooks_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/hooks","issue_events_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/issues/events{/number}","events_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/events","assignees_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/assignees{/user}","branches_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/branches{/branch}","tags_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/tags","blobs_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/git/refs{/sha}","trees_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/statuses/{sha}","languages_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/languages","stargazers_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/stargazers","contributors_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/contributors","subscribers_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/subscribers","subscription_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/subscription","commits_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/commits{/sha}","git_commits_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/git/commits{/sha}","comments_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/comments{/number}","issue_comment_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/issues/comments{/number}","contents_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/contents/{+path}","compare_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/merges","archive_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/downloads","issues_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/issues{/number}","pulls_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/pulls{/number}","milestones_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/milestones{/number}","notifications_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/labels{/name}","releases_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/releases{/id}","created_at":"2015-07-07T14:02:37Z","updated_at":"2015-07-08T14:37:36Z","pushed_at":"2015-07-16T14:57:06Z","git_url":"git://github.com/ymatsukawa/custom_lodge.git","ssh_url":"git@github.com:ymatsukawa/custom_lodge.git","clone_url":"https://github.com/ymatsukawa/custom_lodge.git","svn_url":"https://github.com/ymatsukawa/custom_lodge","homepage":"","size":2576,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"feature_custom_001"}},"base":{"label":"ymatsukawa:feature_custom_001","ref":"feature_custom_001","sha":"0f19cadea0ad33f1a2dff67ca06d1969ee3b8fc3","user":{"login":"ymatsukawa","id":3273466,"avatar_url":"https://avatars.githubusercontent.com/u/3273466?v=3","gravatar_id":"","url":"https://api.github.com/users/ymatsukawa","html_url":"https://github.com/ymatsukawa","followers_url":"https://api.github.com/users/ymatsukawa/followers","following_url":"https://api.github.com/users/ymatsukawa/following{/other_user}","gists_url":"https://api.github.com/users/ymatsukawa/gists{/gist_id}","starred_url":"https://api.github.com/users/ymatsukawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymatsukawa/subscriptions","organizations_url":"https://api.github.com/users/ymatsukawa/orgs","repos_url":"https://api.github.com/users/ymatsukawa/repos","events_url":"https://api.github.com/users/ymatsukawa/events{/privacy}","received_events_url":"https://api.github.com/users/ymatsukawa/received_events","type":"User","site_admin":false},"repo":{"id":38691419,"name":"custom_lodge","full_name":"ymatsukawa/custom_lodge","owner":{"login":"ymatsukawa","id":3273466,"avatar_url":"https://avatars.githubusercontent.com/u/3273466?v=3","gravatar_id":"","url":"https://api.github.com/users/ymatsukawa","html_url":"https://github.com/ymatsukawa","followers_url":"https://api.github.com/users/ymatsukawa/followers","following_url":"https://api.github.com/users/ymatsukawa/following{/other_user}","gists_url":"https://api.github.com/users/ymatsukawa/gists{/gist_id}","starred_url":"https://api.github.com/users/ymatsukawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymatsukawa/subscriptions","organizations_url":"https://api.github.com/users/ymatsukawa/orgs","repos_url":"https://api.github.com/users/ymatsukawa/repos","events_url":"https://api.github.com/users/ymatsukawa/events{/privacy}","received_events_url":"https://api.github.com/users/ymatsukawa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ymatsukawa/custom_lodge","description":"本家のLodge は右 URI にございます https://github.com/lodge/lodge    本リポジトリには MIT  ライセンスに遵守したカスタマイズ版の Lodge を置いています(showing respect to m-yamashita -san, kakusuke -san)","fork":false,"url":"https://api.github.com/repos/ymatsukawa/custom_lodge","forks_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/forks","keys_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/teams","hooks_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/hooks","issue_events_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/issues/events{/number}","events_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/events","assignees_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/assignees{/user}","branches_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/branches{/branch}","tags_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/tags","blobs_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/git/refs{/sha}","trees_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/statuses/{sha}","languages_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/languages","stargazers_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/stargazers","contributors_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/contributors","subscribers_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/subscribers","subscription_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/subscription","commits_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/commits{/sha}","git_commits_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/git/commits{/sha}","comments_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/comments{/number}","issue_comment_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/issues/comments{/number}","contents_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/contents/{+path}","compare_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/merges","archive_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/downloads","issues_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/issues{/number}","pulls_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/pulls{/number}","milestones_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/milestones{/number}","notifications_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/labels{/name}","releases_url":"https://api.github.com/repos/ymatsukawa/custom_lodge/releases{/id}","created_at":"2015-07-07T14:02:37Z","updated_at":"2015-07-08T14:37:36Z","pushed_at":"2015-07-16T14:57:06Z","git_url":"git://github.com/ymatsukawa/custom_lodge.git","ssh_url":"git@github.com:ymatsukawa/custom_lodge.git","clone_url":"https://github.com/ymatsukawa/custom_lodge.git","svn_url":"https://github.com/ymatsukawa/custom_lodge","homepage":"","size":2576,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"feature_custom_001"}},"_links":{"self":{"href":"https://api.github.com/repos/ymatsukawa/custom_lodge/pulls/2"},"html":{"href":"https://github.com/ymatsukawa/custom_lodge/pull/2"},"issue":{"href":"https://api.github.com/repos/ymatsukawa/custom_lodge/issues/2"},"comments":{"href":"https://api.github.com/repos/ymatsukawa/custom_lodge/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ymatsukawa/custom_lodge/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ymatsukawa/custom_lodge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ymatsukawa/custom_lodge/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ymatsukawa/custom_lodge/statuses/31c2c5b6ac4082284c3a612b39f7f1ede7ebe69f"}}}}