{"comment":{"url":"https://api.github.com/repos/ashwinstar/gpdb/comments/14247224","html_url":"https://github.com/ashwinstar/gpdb/commit/5792763ded7b6d3c19993f36bbdb885c938577ae#commitcomment-14247224","id":14247224,"user":{"login":"ashwinstar","id":11396815,"avatar_url":"https://avatars.githubusercontent.com/u/11396815?v=3","gravatar_id":"","url":"https://api.github.com/users/ashwinstar","html_url":"https://github.com/ashwinstar","followers_url":"https://api.github.com/users/ashwinstar/followers","following_url":"https://api.github.com/users/ashwinstar/following{/other_user}","gists_url":"https://api.github.com/users/ashwinstar/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwinstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwinstar/subscriptions","organizations_url":"https://api.github.com/users/ashwinstar/orgs","repos_url":"https://api.github.com/users/ashwinstar/repos","events_url":"https://api.github.com/users/ashwinstar/events{/privacy}","received_events_url":"https://api.github.com/users/ashwinstar/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"5792763ded7b6d3c19993f36bbdb885c938577ae","created_at":"2015-11-06T17:21:18Z","updated_at":"2015-11-06T17:21:18Z","body":"On Fri, Nov 6, 2015 at 1:17 AM, Heikki Linnakangas <notifications@github.com\n> wrote:\n\n> Hmm, so the caller that passes a NULL stmt argument is in cdbsreh.c. Why\n> are we not seeing crashes because of this? Is the calling function in\n> cdbsreh.c not exercised by any regression test?\n>\nWas trying to find the same yesterday but with so much redness around,\nsuper difficult to spot one. The call relates to ErrorTable something which\nis planned to be deprecated for 5.0.\nWe provided alternative functionality in 4.3 but didn't remove the feature\nas some potential customers were using it.\nNot fully sure when new functionality was added, tests for old one was\nremoved or never existed, curious as well will dig-in.\n\n\n—\n> Reply to this email directly or view it on GitHub\n> <https://github.com/ashwinstar/gpdb/commit/5792763ded7b6d3c19993f36bbdb885c938577ae#commitcomment-14236166>\n> .\n>\n"}}