{"action":"created","comment":{"url":"https://api.github.com/repos/SciRuby/nmatrix/pulls/comments/38104757","id":38104757,"diff_hunk":"@@ -1045,4 +1086,53 @@ def dtype_for_floor_or_ceil\n       self.__dense_map__ { |l| l.send(op,rhs) }\n     end\n   end\n+\n+  # Norm calculation methods\n+  # Frobenius norm: the Euclidean norm of the matrix, treated as if it were a vector\n+  def fro_norm\n+    #float64 has to be used in any case, since nrm2 will not yield correct result for float32","path":"lib/nmatrix/math.rb","position":295,"original_position":295,"commit_id":"a06ec6052b3dc992f35fdef8c64202ba336dc6b3","original_commit_id":"8dff478ab395f55d5d209c457259d5f64f5cb41e","user":{"login":"wlevine","id":7783548,"avatar_url":"https://avatars.githubusercontent.com/u/7783548?v=3","gravatar_id":"","url":"https://api.github.com/users/wlevine","html_url":"https://github.com/wlevine","followers_url":"https://api.github.com/users/wlevine/followers","following_url":"https://api.github.com/users/wlevine/following{/other_user}","gists_url":"https://api.github.com/users/wlevine/gists{/gist_id}","starred_url":"https://api.github.com/users/wlevine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wlevine/subscriptions","organizations_url":"https://api.github.com/users/wlevine/orgs","repos_url":"https://api.github.com/users/wlevine/repos","events_url":"https://api.github.com/users/wlevine/events{/privacy}","received_events_url":"https://api.github.com/users/wlevine/received_events","type":"User","site_admin":false},"body":"What is the problem with nrm2? Can you file a bug on this? Maybe you should avoid using nrm2 since it doesn't work for complex types either (#389).","created_at":"2015-08-27T14:56:13Z","updated_at":"2015-08-27T14:56:13Z","html_url":"https://github.com/SciRuby/nmatrix/pull/400#discussion_r38104757","pull_request_url":"https://api.github.com/repos/SciRuby/nmatrix/pulls/400","_links":{"self":{"href":"https://api.github.com/repos/SciRuby/nmatrix/pulls/comments/38104757"},"html":{"href":"https://github.com/SciRuby/nmatrix/pull/400#discussion_r38104757"},"pull_request":{"href":"https://api.github.com/repos/SciRuby/nmatrix/pulls/400"}}},"pull_request":{"url":"https://api.github.com/repos/SciRuby/nmatrix/pulls/400","id":43470757,"html_url":"https://github.com/SciRuby/nmatrix/pull/400","diff_url":"https://github.com/SciRuby/nmatrix/pull/400.diff","patch_url":"https://github.com/SciRuby/nmatrix/pull/400.patch","issue_url":"https://api.github.com/repos/SciRuby/nmatrix/issues/400","number":400,"state":"open","locked":false,"title":"Norms","user":{"login":"yoongkang","id":4401925,"avatar_url":"https://avatars.githubusercontent.com/u/4401925?v=3","gravatar_id":"","url":"https://api.github.com/users/yoongkang","html_url":"https://github.com/yoongkang","followers_url":"https://api.github.com/users/yoongkang/followers","following_url":"https://api.github.com/users/yoongkang/following{/other_user}","gists_url":"https://api.github.com/users/yoongkang/gists{/gist_id}","starred_url":"https://api.github.com/users/yoongkang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoongkang/subscriptions","organizations_url":"https://api.github.com/users/yoongkang/orgs","repos_url":"https://api.github.com/users/yoongkang/repos","events_url":"https://api.github.com/users/yoongkang/events{/privacy}","received_events_url":"https://api.github.com/users/yoongkang/received_events","type":"User","site_admin":false},"body":"I'm trying to pick up where @MpoMP left off with #204. Basically minor modifications to the specs because I don't feel there is much of a point of comparing exact values of floating point numbers.","created_at":"2015-08-27T01:28:13Z","updated_at":"2015-08-27T14:56:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a705cbe6acaea4815c8a27facf311d9099a653b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SciRuby/nmatrix/pulls/400/commits","review_comments_url":"https://api.github.com/repos/SciRuby/nmatrix/pulls/400/comments","review_comment_url":"https://api.github.com/repos/SciRuby/nmatrix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SciRuby/nmatrix/issues/400/comments","statuses_url":"https://api.github.com/repos/SciRuby/nmatrix/statuses/a06ec6052b3dc992f35fdef8c64202ba336dc6b3","head":{"label":"yoongkang:norms","ref":"norms","sha":"a06ec6052b3dc992f35fdef8c64202ba336dc6b3","user":{"login":"yoongkang","id":4401925,"avatar_url":"https://avatars.githubusercontent.com/u/4401925?v=3","gravatar_id":"","url":"https://api.github.com/users/yoongkang","html_url":"https://github.com/yoongkang","followers_url":"https://api.github.com/users/yoongkang/followers","following_url":"https://api.github.com/users/yoongkang/following{/other_user}","gists_url":"https://api.github.com/users/yoongkang/gists{/gist_id}","starred_url":"https://api.github.com/users/yoongkang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoongkang/subscriptions","organizations_url":"https://api.github.com/users/yoongkang/orgs","repos_url":"https://api.github.com/users/yoongkang/repos","events_url":"https://api.github.com/users/yoongkang/events{/privacy}","received_events_url":"https://api.github.com/users/yoongkang/received_events","type":"User","site_admin":false},"repo":{"id":22211640,"name":"nmatrix","full_name":"yoongkang/nmatrix","owner":{"login":"yoongkang","id":4401925,"avatar_url":"https://avatars.githubusercontent.com/u/4401925?v=3","gravatar_id":"","url":"https://api.github.com/users/yoongkang","html_url":"https://github.com/yoongkang","followers_url":"https://api.github.com/users/yoongkang/followers","following_url":"https://api.github.com/users/yoongkang/following{/other_user}","gists_url":"https://api.github.com/users/yoongkang/gists{/gist_id}","starred_url":"https://api.github.com/users/yoongkang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoongkang/subscriptions","organizations_url":"https://api.github.com/users/yoongkang/orgs","repos_url":"https://api.github.com/users/yoongkang/repos","events_url":"https://api.github.com/users/yoongkang/events{/privacy}","received_events_url":"https://api.github.com/users/yoongkang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yoongkang/nmatrix","description":"Dense and sparse linear algebra library for Ruby via SciRuby","fork":true,"url":"https://api.github.com/repos/yoongkang/nmatrix","forks_url":"https://api.github.com/repos/yoongkang/nmatrix/forks","keys_url":"https://api.github.com/repos/yoongkang/nmatrix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yoongkang/nmatrix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yoongkang/nmatrix/teams","hooks_url":"https://api.github.com/repos/yoongkang/nmatrix/hooks","issue_events_url":"https://api.github.com/repos/yoongkang/nmatrix/issues/events{/number}","events_url":"https://api.github.com/repos/yoongkang/nmatrix/events","assignees_url":"https://api.github.com/repos/yoongkang/nmatrix/assignees{/user}","branches_url":"https://api.github.com/repos/yoongkang/nmatrix/branches{/branch}","tags_url":"https://api.github.com/repos/yoongkang/nmatrix/tags","blobs_url":"https://api.github.com/repos/yoongkang/nmatrix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yoongkang/nmatrix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yoongkang/nmatrix/git/refs{/sha}","trees_url":"https://api.github.com/repos/yoongkang/nmatrix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yoongkang/nmatrix/statuses/{sha}","languages_url":"https://api.github.com/repos/yoongkang/nmatrix/languages","stargazers_url":"https://api.github.com/repos/yoongkang/nmatrix/stargazers","contributors_url":"https://api.github.com/repos/yoongkang/nmatrix/contributors","subscribers_url":"https://api.github.com/repos/yoongkang/nmatrix/subscribers","subscription_url":"https://api.github.com/repos/yoongkang/nmatrix/subscription","commits_url":"https://api.github.com/repos/yoongkang/nmatrix/commits{/sha}","git_commits_url":"https://api.github.com/repos/yoongkang/nmatrix/git/commits{/sha}","comments_url":"https://api.github.com/repos/yoongkang/nmatrix/comments{/number}","issue_comment_url":"https://api.github.com/repos/yoongkang/nmatrix/issues/comments{/number}","contents_url":"https://api.github.com/repos/yoongkang/nmatrix/contents/{+path}","compare_url":"https://api.github.com/repos/yoongkang/nmatrix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yoongkang/nmatrix/merges","archive_url":"https://api.github.com/repos/yoongkang/nmatrix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yoongkang/nmatrix/downloads","issues_url":"https://api.github.com/repos/yoongkang/nmatrix/issues{/number}","pulls_url":"https://api.github.com/repos/yoongkang/nmatrix/pulls{/number}","milestones_url":"https://api.github.com/repos/yoongkang/nmatrix/milestones{/number}","notifications_url":"https://api.github.com/repos/yoongkang/nmatrix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yoongkang/nmatrix/labels{/name}","releases_url":"https://api.github.com/repos/yoongkang/nmatrix/releases{/id}","created_at":"2014-07-24T12:13:52Z","updated_at":"2015-04-17T14:20:21Z","pushed_at":"2015-08-27T14:54:59Z","git_url":"git://github.com/yoongkang/nmatrix.git","ssh_url":"git@github.com:yoongkang/nmatrix.git","clone_url":"https://github.com/yoongkang/nmatrix.git","svn_url":"https://github.com/yoongkang/nmatrix","homepage":"","size":6944,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SciRuby:master","ref":"master","sha":"ea3a544fc72dd614bb964053b89be476e45e5428","user":{"login":"SciRuby","id":550805,"avatar_url":"https://avatars.githubusercontent.com/u/550805?v=3","gravatar_id":"","url":"https://api.github.com/users/SciRuby","html_url":"https://github.com/SciRuby","followers_url":"https://api.github.com/users/SciRuby/followers","following_url":"https://api.github.com/users/SciRuby/following{/other_user}","gists_url":"https://api.github.com/users/SciRuby/gists{/gist_id}","starred_url":"https://api.github.com/users/SciRuby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciRuby/subscriptions","organizations_url":"https://api.github.com/users/SciRuby/orgs","repos_url":"https://api.github.com/users/SciRuby/repos","events_url":"https://api.github.com/users/SciRuby/events{/privacy}","received_events_url":"https://api.github.com/users/SciRuby/received_events","type":"Organization","site_admin":false},"repo":{"id":3988087,"name":"nmatrix","full_name":"SciRuby/nmatrix","owner":{"login":"SciRuby","id":550805,"avatar_url":"https://avatars.githubusercontent.com/u/550805?v=3","gravatar_id":"","url":"https://api.github.com/users/SciRuby","html_url":"https://github.com/SciRuby","followers_url":"https://api.github.com/users/SciRuby/followers","following_url":"https://api.github.com/users/SciRuby/following{/other_user}","gists_url":"https://api.github.com/users/SciRuby/gists{/gist_id}","starred_url":"https://api.github.com/users/SciRuby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciRuby/subscriptions","organizations_url":"https://api.github.com/users/SciRuby/orgs","repos_url":"https://api.github.com/users/SciRuby/repos","events_url":"https://api.github.com/users/SciRuby/events{/privacy}","received_events_url":"https://api.github.com/users/SciRuby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SciRuby/nmatrix","description":"Dense and sparse linear algebra library for Ruby via SciRuby","fork":true,"url":"https://api.github.com/repos/SciRuby/nmatrix","forks_url":"https://api.github.com/repos/SciRuby/nmatrix/forks","keys_url":"https://api.github.com/repos/SciRuby/nmatrix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SciRuby/nmatrix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SciRuby/nmatrix/teams","hooks_url":"https://api.github.com/repos/SciRuby/nmatrix/hooks","issue_events_url":"https://api.github.com/repos/SciRuby/nmatrix/issues/events{/number}","events_url":"https://api.github.com/repos/SciRuby/nmatrix/events","assignees_url":"https://api.github.com/repos/SciRuby/nmatrix/assignees{/user}","branches_url":"https://api.github.com/repos/SciRuby/nmatrix/branches{/branch}","tags_url":"https://api.github.com/repos/SciRuby/nmatrix/tags","blobs_url":"https://api.github.com/repos/SciRuby/nmatrix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SciRuby/nmatrix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SciRuby/nmatrix/git/refs{/sha}","trees_url":"https://api.github.com/repos/SciRuby/nmatrix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SciRuby/nmatrix/statuses/{sha}","languages_url":"https://api.github.com/repos/SciRuby/nmatrix/languages","stargazers_url":"https://api.github.com/repos/SciRuby/nmatrix/stargazers","contributors_url":"https://api.github.com/repos/SciRuby/nmatrix/contributors","subscribers_url":"https://api.github.com/repos/SciRuby/nmatrix/subscribers","subscription_url":"https://api.github.com/repos/SciRuby/nmatrix/subscription","commits_url":"https://api.github.com/repos/SciRuby/nmatrix/commits{/sha}","git_commits_url":"https://api.github.com/repos/SciRuby/nmatrix/git/commits{/sha}","comments_url":"https://api.github.com/repos/SciRuby/nmatrix/comments{/number}","issue_comment_url":"https://api.github.com/repos/SciRuby/nmatrix/issues/comments{/number}","contents_url":"https://api.github.com/repos/SciRuby/nmatrix/contents/{+path}","compare_url":"https://api.github.com/repos/SciRuby/nmatrix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SciRuby/nmatrix/merges","archive_url":"https://api.github.com/repos/SciRuby/nmatrix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SciRuby/nmatrix/downloads","issues_url":"https://api.github.com/repos/SciRuby/nmatrix/issues{/number}","pulls_url":"https://api.github.com/repos/SciRuby/nmatrix/pulls{/number}","milestones_url":"https://api.github.com/repos/SciRuby/nmatrix/milestones{/number}","notifications_url":"https://api.github.com/repos/SciRuby/nmatrix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SciRuby/nmatrix/labels{/name}","releases_url":"https://api.github.com/repos/SciRuby/nmatrix/releases{/id}","created_at":"2012-04-10T23:05:34Z","updated_at":"2015-08-25T20:49:31Z","pushed_at":"2015-08-27T14:55:00Z","git_url":"git://github.com/SciRuby/nmatrix.git","ssh_url":"git@github.com:SciRuby/nmatrix.git","clone_url":"https://github.com/SciRuby/nmatrix.git","svn_url":"https://github.com/SciRuby/nmatrix","homepage":"","size":10012,"stargazers_count":265,"watchers_count":265,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":62,"forks":75,"open_issues":62,"watchers":265,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SciRuby/nmatrix/pulls/400"},"html":{"href":"https://github.com/SciRuby/nmatrix/pull/400"},"issue":{"href":"https://api.github.com/repos/SciRuby/nmatrix/issues/400"},"comments":{"href":"https://api.github.com/repos/SciRuby/nmatrix/issues/400/comments"},"review_comments":{"href":"https://api.github.com/repos/SciRuby/nmatrix/pulls/400/comments"},"review_comment":{"href":"https://api.github.com/repos/SciRuby/nmatrix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SciRuby/nmatrix/pulls/400/commits"},"statuses":{"href":"https://api.github.com/repos/SciRuby/nmatrix/statuses/a06ec6052b3dc992f35fdef8c64202ba336dc6b3"}}}}