{"action":"created","issue":{"url":"https://api.github.com/repos/bmuller/kademlia/issues/15","labels_url":"https://api.github.com/repos/bmuller/kademlia/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/bmuller/kademlia/issues/15/comments","events_url":"https://api.github.com/repos/bmuller/kademlia/issues/15/events","html_url":"https://github.com/bmuller/kademlia/pull/15","id":123954337,"number":15,"title":"Fix unicode issue with printable characters in log","user":{"login":"robertsdotpm","id":7320766,"avatar_url":"https://avatars.githubusercontent.com/u/7320766?v=3","gravatar_id":"","url":"https://api.github.com/users/robertsdotpm","html_url":"https://github.com/robertsdotpm","followers_url":"https://api.github.com/users/robertsdotpm/followers","following_url":"https://api.github.com/users/robertsdotpm/following{/other_user}","gists_url":"https://api.github.com/users/robertsdotpm/gists{/gist_id}","starred_url":"https://api.github.com/users/robertsdotpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertsdotpm/subscriptions","organizations_url":"https://api.github.com/users/robertsdotpm/orgs","repos_url":"https://api.github.com/users/robertsdotpm/repos","events_url":"https://api.github.com/users/robertsdotpm/events{/privacy}","received_events_url":"https://api.github.com/users/robertsdotpm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-27T00:16:22Z","updated_at":"2015-12-27T01:20:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bmuller/kademlia/pulls/15","html_url":"https://github.com/bmuller/kademlia/pull/15","diff_url":"https://github.com/bmuller/kademlia/pull/15.diff","patch_url":"https://github.com/bmuller/kademlia/pull/15.patch"},"body":"The current code in network.py output the key name and the value to the log on store requests which can garble and crash the terminal on certain character sequences.\r\n\r\nMy fix is to only write ASCII characters to the log with non-ascii characters encoded as hex (and indicated as such.)"},"comment":{"url":"https://api.github.com/repos/bmuller/kademlia/issues/comments/167374371","html_url":"https://github.com/bmuller/kademlia/pull/15#issuecomment-167374371","issue_url":"https://api.github.com/repos/bmuller/kademlia/issues/15","id":167374371,"user":{"login":"bmuller","id":182344,"avatar_url":"https://avatars.githubusercontent.com/u/182344?v=3","gravatar_id":"","url":"https://api.github.com/users/bmuller","html_url":"https://github.com/bmuller","followers_url":"https://api.github.com/users/bmuller/followers","following_url":"https://api.github.com/users/bmuller/following{/other_user}","gists_url":"https://api.github.com/users/bmuller/gists{/gist_id}","starred_url":"https://api.github.com/users/bmuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmuller/subscriptions","organizations_url":"https://api.github.com/users/bmuller/orgs","repos_url":"https://api.github.com/users/bmuller/repos","events_url":"https://api.github.com/users/bmuller/events{/privacy}","received_events_url":"https://api.github.com/users/bmuller/received_events","type":"User","site_admin":false},"created_at":"2015-12-27T01:20:19Z","updated_at":"2015-12-27T01:20:19Z","body":"Makes sense.  What if the `debug` method just encoded to ascii (ignoring any non-convertable characters) prior to printing?"}}