{"action":"created","comment":{"url":"https://api.github.com/repos/hadley/devtools/pulls/comments/38552863","id":38552863,"diff_hunk":"@@ -0,0 +1,86 @@\n+---\n+title: \"Devtools Remote Dependencies\"","path":"vignettes/dependencies.Rmd","position":2,"original_position":2,"commit_id":"e43e46ef158c7b60ff57b86b17a4ca96e1ab0eee","original_commit_id":"e43e46ef158c7b60ff57b86b17a4ca96e1ab0eee","user":{"login":"hadley","id":4196,"avatar_url":"https://avatars.githubusercontent.com/u/4196?v=3","gravatar_id":"","url":"https://api.github.com/users/hadley","html_url":"https://github.com/hadley","followers_url":"https://api.github.com/users/hadley/followers","following_url":"https://api.github.com/users/hadley/following{/other_user}","gists_url":"https://api.github.com/users/hadley/gists{/gist_id}","starred_url":"https://api.github.com/users/hadley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadley/subscriptions","organizations_url":"https://api.github.com/users/hadley/orgs","repos_url":"https://api.github.com/users/hadley/repos","events_url":"https://api.github.com/users/hadley/events{/privacy}","received_events_url":"https://api.github.com/users/hadley/received_events","type":"User","site_admin":false},"body":"Could we just make this \"Devtools dependencies\" and include remote versions as a section?","created_at":"2015-09-02T16:22:51Z","updated_at":"2015-09-02T16:22:51Z","html_url":"https://github.com/hadley/devtools/pull/902#discussion_r38552863","pull_request_url":"https://api.github.com/repos/hadley/devtools/pulls/902","_links":{"self":{"href":"https://api.github.com/repos/hadley/devtools/pulls/comments/38552863"},"html":{"href":"https://github.com/hadley/devtools/pull/902#discussion_r38552863"},"pull_request":{"href":"https://api.github.com/repos/hadley/devtools/pulls/902"}}},"pull_request":{"url":"https://api.github.com/repos/hadley/devtools/pulls/902","id":43298424,"html_url":"https://github.com/hadley/devtools/pull/902","diff_url":"https://github.com/hadley/devtools/pull/902.diff","patch_url":"https://github.com/hadley/devtools/pull/902.patch","issue_url":"https://api.github.com/repos/hadley/devtools/issues/902","number":902,"state":"open","locked":false,"title":"DevPackage Dependencies","user":{"login":"jimhester","id":205275,"avatar_url":"https://avatars.githubusercontent.com/u/205275?v=3","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"body":"This allows package authors to specify DevPackage in their DESCRIPTION,\r\nwhich devtools will use to install development versions of the\r\ndependencies prior to looking for them in normal repositories.  The\r\nformat is 'type|user/repo', where type is optional (default github)\r\ndefining the install_type to use, e.g. (git, gitorious, svn, ect.).\r\n\r\nAn example description would be (for the ggplot2 book for instance)\r\n```\r\nPackage: ggbook2\r\nTitle: ggbook2 is not really an R package, but this is here to list the dependencies for building the ggplot2 book.\r\nVersion: 0.1\r\nAuthors@R: person(\"First\", \"Last\", email = \"first.last@example.com\",\r\n                  role = c(\"aut\", \"cre\"))\r\nDepends: R (>= 3.1.0)\r\nURL: https://github.com/hadley/ggplot2-book\r\nImports:\r\n  lubridate,\r\n  rvest,\r\n  magrittr,\r\n  dplyr,\r\n  plyr,\r\n  tidyr,\r\n  xtable,\r\n  nlme,\r\n  effects,\r\n  broom,\r\n  hexbin,\r\n  maps,\r\n  Hmisc,\r\n  devtools,\r\n  readr,\r\n  rmarkdown,\r\n  Lahman,\r\n  ggmap,\r\n  directlabels,\r\n  wesanderson,\r\n  babynames\r\nDevPackage:\r\n  hadley/bookdown,\r\n  hadley/scales, \r\n  hadley/ggplot2,\r\n  hadley/ggplot2movies,\r\n  hadley/tidyr,\r\n  hadley/directlabels, \r\n  jrnold/ggthemes\r\nSystemRequirements: pandoc (>= 1.12.3) - http://johnmacfarlane.net/pandoc\r\n```\r\nThis would allow people to install it with simply\r\n```r\r\ndevtools::install_github(\"hadley/ggplot2-book\")\r\n```\r\n\r\nThis implementation seems to work fine as-is, but I had a few questions as far as the API\r\n\r\n1. Is this useful (I think it is)!\r\n2. Is `DevPackage` a good name for this or should we use something else?\r\n3. is `|` a good delimiter for the type?  I picked it because it should not appear in URLs or user/repository names.  Using `/` or `:` seem like they would require more complicated logic to parse properly in all cases.\r\n4. Where is the best place to document/popularize this feature?  The functions to implement are all non-exported.\r\n5. What is the best way to test this, just mock the install functions and verify we are passing them the correct parameters?","created_at":"2015-08-25T15:16:21Z","updated_at":"2015-09-02T16:22:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b558dbeac17dd36325d633ffa298cd93a87889ee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hadley/devtools/pulls/902/commits","review_comments_url":"https://api.github.com/repos/hadley/devtools/pulls/902/comments","review_comment_url":"https://api.github.com/repos/hadley/devtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hadley/devtools/issues/902/comments","statuses_url":"https://api.github.com/repos/hadley/devtools/statuses/e43e46ef158c7b60ff57b86b17a4ca96e1ab0eee","head":{"label":"jimhester:GitHubRepo","ref":"GitHubRepo","sha":"e43e46ef158c7b60ff57b86b17a4ca96e1ab0eee","user":{"login":"jimhester","id":205275,"avatar_url":"https://avatars.githubusercontent.com/u/205275?v=3","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"repo":{"id":25137194,"name":"devtools","full_name":"jimhester/devtools","owner":{"login":"jimhester","id":205275,"avatar_url":"https://avatars.githubusercontent.com/u/205275?v=3","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimhester/devtools","description":"Tools to make an R developer's life easier","fork":true,"url":"https://api.github.com/repos/jimhester/devtools","forks_url":"https://api.github.com/repos/jimhester/devtools/forks","keys_url":"https://api.github.com/repos/jimhester/devtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimhester/devtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimhester/devtools/teams","hooks_url":"https://api.github.com/repos/jimhester/devtools/hooks","issue_events_url":"https://api.github.com/repos/jimhester/devtools/issues/events{/number}","events_url":"https://api.github.com/repos/jimhester/devtools/events","assignees_url":"https://api.github.com/repos/jimhester/devtools/assignees{/user}","branches_url":"https://api.github.com/repos/jimhester/devtools/branches{/branch}","tags_url":"https://api.github.com/repos/jimhester/devtools/tags","blobs_url":"https://api.github.com/repos/jimhester/devtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimhester/devtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimhester/devtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimhester/devtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimhester/devtools/statuses/{sha}","languages_url":"https://api.github.com/repos/jimhester/devtools/languages","stargazers_url":"https://api.github.com/repos/jimhester/devtools/stargazers","contributors_url":"https://api.github.com/repos/jimhester/devtools/contributors","subscribers_url":"https://api.github.com/repos/jimhester/devtools/subscribers","subscription_url":"https://api.github.com/repos/jimhester/devtools/subscription","commits_url":"https://api.github.com/repos/jimhester/devtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimhester/devtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimhester/devtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimhester/devtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimhester/devtools/contents/{+path}","compare_url":"https://api.github.com/repos/jimhester/devtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimhester/devtools/merges","archive_url":"https://api.github.com/repos/jimhester/devtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimhester/devtools/downloads","issues_url":"https://api.github.com/repos/jimhester/devtools/issues{/number}","pulls_url":"https://api.github.com/repos/jimhester/devtools/pulls{/number}","milestones_url":"https://api.github.com/repos/jimhester/devtools/milestones{/number}","notifications_url":"https://api.github.com/repos/jimhester/devtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimhester/devtools/labels{/name}","releases_url":"https://api.github.com/repos/jimhester/devtools/releases{/id}","created_at":"2014-10-13T00:56:25Z","updated_at":"2015-01-15T19:20:47Z","pushed_at":"2015-08-31T17:04:30Z","git_url":"git://github.com/jimhester/devtools.git","ssh_url":"git@github.com:jimhester/devtools.git","clone_url":"https://github.com/jimhester/devtools.git","svn_url":"https://github.com/jimhester/devtools","homepage":"","size":3417,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hadley:master","ref":"master","sha":"76ada1dffd4335611adb78b9cf0c233d5127c6a7","user":{"login":"hadley","id":4196,"avatar_url":"https://avatars.githubusercontent.com/u/4196?v=3","gravatar_id":"","url":"https://api.github.com/users/hadley","html_url":"https://github.com/hadley","followers_url":"https://api.github.com/users/hadley/followers","following_url":"https://api.github.com/users/hadley/following{/other_user}","gists_url":"https://api.github.com/users/hadley/gists{/gist_id}","starred_url":"https://api.github.com/users/hadley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadley/subscriptions","organizations_url":"https://api.github.com/users/hadley/orgs","repos_url":"https://api.github.com/users/hadley/repos","events_url":"https://api.github.com/users/hadley/events{/privacy}","received_events_url":"https://api.github.com/users/hadley/received_events","type":"User","site_admin":false},"repo":{"id":643909,"name":"devtools","full_name":"hadley/devtools","owner":{"login":"hadley","id":4196,"avatar_url":"https://avatars.githubusercontent.com/u/4196?v=3","gravatar_id":"","url":"https://api.github.com/users/hadley","html_url":"https://github.com/hadley","followers_url":"https://api.github.com/users/hadley/followers","following_url":"https://api.github.com/users/hadley/following{/other_user}","gists_url":"https://api.github.com/users/hadley/gists{/gist_id}","starred_url":"https://api.github.com/users/hadley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadley/subscriptions","organizations_url":"https://api.github.com/users/hadley/orgs","repos_url":"https://api.github.com/users/hadley/repos","events_url":"https://api.github.com/users/hadley/events{/privacy}","received_events_url":"https://api.github.com/users/hadley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hadley/devtools","description":"Tools to make an R developer's life easier","fork":false,"url":"https://api.github.com/repos/hadley/devtools","forks_url":"https://api.github.com/repos/hadley/devtools/forks","keys_url":"https://api.github.com/repos/hadley/devtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hadley/devtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hadley/devtools/teams","hooks_url":"https://api.github.com/repos/hadley/devtools/hooks","issue_events_url":"https://api.github.com/repos/hadley/devtools/issues/events{/number}","events_url":"https://api.github.com/repos/hadley/devtools/events","assignees_url":"https://api.github.com/repos/hadley/devtools/assignees{/user}","branches_url":"https://api.github.com/repos/hadley/devtools/branches{/branch}","tags_url":"https://api.github.com/repos/hadley/devtools/tags","blobs_url":"https://api.github.com/repos/hadley/devtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hadley/devtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hadley/devtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/hadley/devtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hadley/devtools/statuses/{sha}","languages_url":"https://api.github.com/repos/hadley/devtools/languages","stargazers_url":"https://api.github.com/repos/hadley/devtools/stargazers","contributors_url":"https://api.github.com/repos/hadley/devtools/contributors","subscribers_url":"https://api.github.com/repos/hadley/devtools/subscribers","subscription_url":"https://api.github.com/repos/hadley/devtools/subscription","commits_url":"https://api.github.com/repos/hadley/devtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/hadley/devtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/hadley/devtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/hadley/devtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/hadley/devtools/contents/{+path}","compare_url":"https://api.github.com/repos/hadley/devtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hadley/devtools/merges","archive_url":"https://api.github.com/repos/hadley/devtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hadley/devtools/downloads","issues_url":"https://api.github.com/repos/hadley/devtools/issues{/number}","pulls_url":"https://api.github.com/repos/hadley/devtools/pulls{/number}","milestones_url":"https://api.github.com/repos/hadley/devtools/milestones{/number}","notifications_url":"https://api.github.com/repos/hadley/devtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hadley/devtools/labels{/name}","releases_url":"https://api.github.com/repos/hadley/devtools/releases{/id}","created_at":"2010-05-03T04:08:49Z","updated_at":"2015-09-01T18:09:32Z","pushed_at":"2015-09-02T16:20:30Z","git_url":"git://github.com/hadley/devtools.git","ssh_url":"git@github.com:hadley/devtools.git","clone_url":"https://github.com/hadley/devtools.git","svn_url":"https://github.com/hadley/devtools","homepage":"","size":8979,"stargazers_count":1092,"watchers_count":1092,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":327,"mirror_url":null,"open_issues_count":45,"forks":327,"open_issues":45,"watchers":1092,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hadley/devtools/pulls/902"},"html":{"href":"https://github.com/hadley/devtools/pull/902"},"issue":{"href":"https://api.github.com/repos/hadley/devtools/issues/902"},"comments":{"href":"https://api.github.com/repos/hadley/devtools/issues/902/comments"},"review_comments":{"href":"https://api.github.com/repos/hadley/devtools/pulls/902/comments"},"review_comment":{"href":"https://api.github.com/repos/hadley/devtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hadley/devtools/pulls/902/commits"},"statuses":{"href":"https://api.github.com/repos/hadley/devtools/statuses/e43e46ef158c7b60ff57b86b17a4ca96e1ab0eee"}}}}