{"action":"created","issue":{"url":"https://api.github.com/repos/wesnoth/wesnoth/issues/449","labels_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/449/labels{/name}","comments_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/449/comments","events_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/449/events","html_url":"https://github.com/wesnoth/wesnoth/pull/449","id":100055736,"number":449,"title":"Added password hashing to campaignd","user":{"login":"JohnAnthony","id":436859,"avatar_url":"https://avatars.githubusercontent.com/u/436859?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnAnthony","html_url":"https://github.com/JohnAnthony","followers_url":"https://api.github.com/users/JohnAnthony/followers","following_url":"https://api.github.com/users/JohnAnthony/following{/other_user}","gists_url":"https://api.github.com/users/JohnAnthony/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnAnthony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnAnthony/subscriptions","organizations_url":"https://api.github.com/users/JohnAnthony/orgs","repos_url":"https://api.github.com/users/JohnAnthony/repos","events_url":"https://api.github.com/users/JohnAnthony/events{/privacy}","received_events_url":"https://api.github.com/users/JohnAnthony/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"shikadilord","id":489895,"avatar_url":"https://avatars.githubusercontent.com/u/489895?v=3","gravatar_id":"","url":"https://api.github.com/users/shikadilord","html_url":"https://github.com/shikadilord","followers_url":"https://api.github.com/users/shikadilord/followers","following_url":"https://api.github.com/users/shikadilord/following{/other_user}","gists_url":"https://api.github.com/users/shikadilord/gists{/gist_id}","starred_url":"https://api.github.com/users/shikadilord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shikadilord/subscriptions","organizations_url":"https://api.github.com/users/shikadilord/orgs","repos_url":"https://api.github.com/users/shikadilord/repos","events_url":"https://api.github.com/users/shikadilord/events{/privacy}","received_events_url":"https://api.github.com/users/shikadilord/received_events","type":"User","site_admin":false},"milestone":null,"comments":9,"created_at":"2015-08-10T12:51:59Z","updated_at":"2015-08-17T08:02:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wesnoth/wesnoth/pulls/449","html_url":"https://github.com/wesnoth/wesnoth/pull/449","diff_url":"https://github.com/wesnoth/wesnoth/pull/449.diff","patch_url":"https://github.com/wesnoth/wesnoth/pull/449.patch"},"body":"As suggested here:\r\n\r\nhttp://wiki.wesnoth.org/NotSoEasyCoding#Passphrase_hashing\r\n\r\nCurrently the hashing function is 10-iteration MD5, but should really be something like scrypt (best) or bcrypt (acceptable), but it means pulling in a dependency and Wesnoth already includes an MD5 utility."},"comment":{"url":"https://api.github.com/repos/wesnoth/wesnoth/issues/comments/131722709","html_url":"https://github.com/wesnoth/wesnoth/pull/449#issuecomment-131722709","issue_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/449","id":131722709,"user":{"login":"shikadilord","id":489895,"avatar_url":"https://avatars.githubusercontent.com/u/489895?v=3","gravatar_id":"","url":"https://api.github.com/users/shikadilord","html_url":"https://github.com/shikadilord","followers_url":"https://api.github.com/users/shikadilord/followers","following_url":"https://api.github.com/users/shikadilord/following{/other_user}","gists_url":"https://api.github.com/users/shikadilord/gists{/gist_id}","starred_url":"https://api.github.com/users/shikadilord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shikadilord/subscriptions","organizations_url":"https://api.github.com/users/shikadilord/orgs","repos_url":"https://api.github.com/users/shikadilord/repos","events_url":"https://api.github.com/users/shikadilord/events{/privacy}","received_events_url":"https://api.github.com/users/shikadilord/received_events","type":"User","site_admin":false},"created_at":"2015-08-17T08:02:23Z","updated_at":"2015-08-17T08:02:23Z","body":"The line is still there, though.\r\n\r\nI don't think it's a problem to have the server scan for plain text passphrases on startup, since it's not supposed to be restarted very often anyway."}}