{"action":"created","issue":{"url":"https://api.github.com/repos/WebAssembly/spec/issues/82","labels_url":"https://api.github.com/repos/WebAssembly/spec/issues/82/labels{/name}","comments_url":"https://api.github.com/repos/WebAssembly/spec/issues/82/comments","events_url":"https://api.github.com/repos/WebAssembly/spec/issues/82/events","html_url":"https://github.com/WebAssembly/spec/pull/82","id":107574045,"number":82,"title":"Factor out i32 and i64 from arithmetic.ml; implement wasm-compatible semantics","user":{"login":"sunfishcode","id":4503403,"avatar_url":"https://avatars.githubusercontent.com/u/4503403?v=3","gravatar_id":"","url":"https://api.github.com/users/sunfishcode","html_url":"https://github.com/sunfishcode","followers_url":"https://api.github.com/users/sunfishcode/followers","following_url":"https://api.github.com/users/sunfishcode/following{/other_user}","gists_url":"https://api.github.com/users/sunfishcode/gists{/gist_id}","starred_url":"https://api.github.com/users/sunfishcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunfishcode/subscriptions","organizations_url":"https://api.github.com/users/sunfishcode/orgs","repos_url":"https://api.github.com/users/sunfishcode/repos","events_url":"https://api.github.com/users/sunfishcode/events{/privacy}","received_events_url":"https://api.github.com/users/sunfishcode/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-21T18:47:32Z","updated_at":"2015-09-22T18:13:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/WebAssembly/spec/pulls/82","html_url":"https://github.com/WebAssembly/spec/pull/82","diff_url":"https://github.com/WebAssembly/spec/pull/82.diff","patch_url":"https://github.com/WebAssembly/spec/pull/82.patch"},"body":"This factors out the integer computation out of spec/arithmetic.ml and moves it into i32 and i64 modules under given, similar to the floating point types. It also is a first draft of design-compatible integer semantics, complete with trapping as appropriate.\r\n\r\nThis adds tests for all the plain integer operations, but the conversions are not yet tested. I am working on tests for them, though there are some floating point parsing issues that need to be resolved first, and [assert_eq_bits and assert_nan](https://github.com/WebAssembly/spec/issues/70) would be useful.\r\n"},"comment":{"url":"https://api.github.com/repos/WebAssembly/spec/issues/comments/142369165","html_url":"https://github.com/WebAssembly/spec/pull/82#issuecomment-142369165","issue_url":"https://api.github.com/repos/WebAssembly/spec/issues/82","id":142369165,"user":{"login":"rossberg-chromium","id":4247099,"avatar_url":"https://avatars.githubusercontent.com/u/4247099?v=3","gravatar_id":"","url":"https://api.github.com/users/rossberg-chromium","html_url":"https://github.com/rossberg-chromium","followers_url":"https://api.github.com/users/rossberg-chromium/followers","following_url":"https://api.github.com/users/rossberg-chromium/following{/other_user}","gists_url":"https://api.github.com/users/rossberg-chromium/gists{/gist_id}","starred_url":"https://api.github.com/users/rossberg-chromium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossberg-chromium/subscriptions","organizations_url":"https://api.github.com/users/rossberg-chromium/orgs","repos_url":"https://api.github.com/users/rossberg-chromium/repos","events_url":"https://api.github.com/users/rossberg-chromium/events{/privacy}","received_events_url":"https://api.github.com/users/rossberg-chromium/received_events","type":"User","site_admin":false},"created_at":"2015-09-22T18:13:52Z","updated_at":"2015-09-22T18:13:52Z","body":"Looks good, although I haven't checked all the details.\r\n\r\nI wonder if it's still adequate to put these modules into given/, considering that they implement rather Wasm-specific interfaces and semantics now. They are arguably in the same equivalence class as Memory.\r\n\r\nAny reason you defunctorised & duplicated the existing code in arithmetic?"}}