{"comment":{"url":"https://api.github.com/repos/bunnei/citra/comments/12372842","html_url":"https://github.com/bunnei/citra/commit/b6b4537013cc98ee3f742d375c055c82e463aad9#commitcomment-12372842","id":12372842,"user":{"login":"yuriks","id":341401,"avatar_url":"https://avatars.githubusercontent.com/u/341401?v=3","gravatar_id":"","url":"https://api.github.com/users/yuriks","html_url":"https://github.com/yuriks","followers_url":"https://api.github.com/users/yuriks/followers","following_url":"https://api.github.com/users/yuriks/following{/other_user}","gists_url":"https://api.github.com/users/yuriks/gists{/gist_id}","starred_url":"https://api.github.com/users/yuriks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuriks/subscriptions","organizations_url":"https://api.github.com/users/yuriks/orgs","repos_url":"https://api.github.com/users/yuriks/repos","events_url":"https://api.github.com/users/yuriks/events{/privacy}","received_events_url":"https://api.github.com/users/yuriks/received_events","type":"User","site_admin":false},"position":31,"line":106,"path":"src/video_core/shader/shader.h","commit_id":"b6b4537013cc98ee3f742d375c055c82e463aad9","created_at":"2015-07-27T13:59:17Z","updated_at":"2015-07-27T13:59:17Z","body":"This *might* be off-topic for this PR, but this is redundant. If you look at shader_bytecode.h, the only thing `GetRegisterType` does is check if the register id is in some range. `GetIndex` does the same, subtracting the base. And then the only thing this does is add back the same base (in the form of the separate register arrays.) These arrays should be unified in a single one with all registers, and then the id can just be used directly."}}