{"action":"closed","number":118,"pull_request":{"url":"https://api.github.com/repos/eggheads/eggdrop/pulls/118","id":48414426,"html_url":"https://github.com/eggheads/eggdrop/pull/118","diff_url":"https://github.com/eggheads/eggdrop/pull/118.diff","patch_url":"https://github.com/eggheads/eggdrop/pull/118.patch","issue_url":"https://api.github.com/repos/eggheads/eggdrop/issues/118","number":118,"state":"closed","locked":false,"title":"Reply to server CTCPs","user":{"login":"vanosg","id":2440369,"avatar_url":"https://avatars.githubusercontent.com/u/2440369?v=3","gravatar_id":"","url":"https://api.github.com/users/vanosg","html_url":"https://github.com/vanosg","followers_url":"https://api.github.com/users/vanosg/followers","following_url":"https://api.github.com/users/vanosg/following{/other_user}","gists_url":"https://api.github.com/users/vanosg/gists{/gist_id}","starred_url":"https://api.github.com/users/vanosg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanosg/subscriptions","organizations_url":"https://api.github.com/users/vanosg/orgs","repos_url":"https://api.github.com/users/vanosg/repos","events_url":"https://api.github.com/users/vanosg/events{/privacy}","received_events_url":"https://api.github.com/users/vanosg/received_events","type":"User","site_admin":false},"body":"A user had a unique situation where a server was sending CTCP requests to\r\neggdrop. While it was determined in discussion there was no particular need\r\nto have eggdrop reply to a server CTCP (because it just feels dirty), the\r\ncode does contain a bug where if the uhost sent is not in a standard\r\nnick!ident at hostname.com <mailto:nick!ident at hostname.com>  format (like a\r\nserver would appear in the format \"I.am.a.server\"), it uses \"\" as the CTCP\r\nreply nick, and the code ends up using the intended reply string as the\r\nnickname\r\n \r\nIn this case, user!foo at bar.com <mailto:user!foo at bar.com>  versioned the bot,\r\nthis is what it sends back:\r\n[h->] NOTICE user :VERSION eggdrop v1.8.0+preinit\r\n \r\nNow, the server I.Am.A.Server versions the bot:\r\n[h->] NOTICE  :VERSION eggdrop v1.8.0+preinit\r\n \r\nAlas, no user! \r\n \r\nThis patch checks to see if a nick is extracted from the hostmask that sent\r\nthe CTCP request and, if not, uses the entire hostmask as the reply\r\ndestination. \r\n","created_at":"2015-10-22T03:37:17Z","updated_at":"2015-10-22T11:54:14Z","closed_at":"2015-10-22T11:54:13Z","merged_at":"2015-10-22T11:54:13Z","merge_commit_sha":"7af37ab1a34f8531c231cbd2800bd4a6a8ee6c0f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eggheads/eggdrop/pulls/118/commits","review_comments_url":"https://api.github.com/repos/eggheads/eggdrop/pulls/118/comments","review_comment_url":"https://api.github.com/repos/eggheads/eggdrop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eggheads/eggdrop/issues/118/comments","statuses_url":"https://api.github.com/repos/eggheads/eggdrop/statuses/8d7a306456cfe231cb6db038b6491f4e40d3599e","head":{"label":"vanosg:CTCPServerReply","ref":"CTCPServerReply","sha":"8d7a306456cfe231cb6db038b6491f4e40d3599e","user":{"login":"vanosg","id":2440369,"avatar_url":"https://avatars.githubusercontent.com/u/2440369?v=3","gravatar_id":"","url":"https://api.github.com/users/vanosg","html_url":"https://github.com/vanosg","followers_url":"https://api.github.com/users/vanosg/followers","following_url":"https://api.github.com/users/vanosg/following{/other_user}","gists_url":"https://api.github.com/users/vanosg/gists{/gist_id}","starred_url":"https://api.github.com/users/vanosg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanosg/subscriptions","organizations_url":"https://api.github.com/users/vanosg/orgs","repos_url":"https://api.github.com/users/vanosg/repos","events_url":"https://api.github.com/users/vanosg/events{/privacy}","received_events_url":"https://api.github.com/users/vanosg/received_events","type":"User","site_admin":false},"repo":{"id":44719392,"name":"eggdrop","full_name":"vanosg/eggdrop","owner":{"login":"vanosg","id":2440369,"avatar_url":"https://avatars.githubusercontent.com/u/2440369?v=3","gravatar_id":"","url":"https://api.github.com/users/vanosg","html_url":"https://github.com/vanosg","followers_url":"https://api.github.com/users/vanosg/followers","following_url":"https://api.github.com/users/vanosg/following{/other_user}","gists_url":"https://api.github.com/users/vanosg/gists{/gist_id}","starred_url":"https://api.github.com/users/vanosg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanosg/subscriptions","organizations_url":"https://api.github.com/users/vanosg/orgs","repos_url":"https://api.github.com/users/vanosg/repos","events_url":"https://api.github.com/users/vanosg/events{/privacy}","received_events_url":"https://api.github.com/users/vanosg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vanosg/eggdrop","description":"The Eggdrop IRC Bot","fork":true,"url":"https://api.github.com/repos/vanosg/eggdrop","forks_url":"https://api.github.com/repos/vanosg/eggdrop/forks","keys_url":"https://api.github.com/repos/vanosg/eggdrop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanosg/eggdrop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanosg/eggdrop/teams","hooks_url":"https://api.github.com/repos/vanosg/eggdrop/hooks","issue_events_url":"https://api.github.com/repos/vanosg/eggdrop/issues/events{/number}","events_url":"https://api.github.com/repos/vanosg/eggdrop/events","assignees_url":"https://api.github.com/repos/vanosg/eggdrop/assignees{/user}","branches_url":"https://api.github.com/repos/vanosg/eggdrop/branches{/branch}","tags_url":"https://api.github.com/repos/vanosg/eggdrop/tags","blobs_url":"https://api.github.com/repos/vanosg/eggdrop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanosg/eggdrop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanosg/eggdrop/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanosg/eggdrop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanosg/eggdrop/statuses/{sha}","languages_url":"https://api.github.com/repos/vanosg/eggdrop/languages","stargazers_url":"https://api.github.com/repos/vanosg/eggdrop/stargazers","contributors_url":"https://api.github.com/repos/vanosg/eggdrop/contributors","subscribers_url":"https://api.github.com/repos/vanosg/eggdrop/subscribers","subscription_url":"https://api.github.com/repos/vanosg/eggdrop/subscription","commits_url":"https://api.github.com/repos/vanosg/eggdrop/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanosg/eggdrop/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanosg/eggdrop/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanosg/eggdrop/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanosg/eggdrop/contents/{+path}","compare_url":"https://api.github.com/repos/vanosg/eggdrop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanosg/eggdrop/merges","archive_url":"https://api.github.com/repos/vanosg/eggdrop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanosg/eggdrop/downloads","issues_url":"https://api.github.com/repos/vanosg/eggdrop/issues{/number}","pulls_url":"https://api.github.com/repos/vanosg/eggdrop/pulls{/number}","milestones_url":"https://api.github.com/repos/vanosg/eggdrop/milestones{/number}","notifications_url":"https://api.github.com/repos/vanosg/eggdrop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanosg/eggdrop/labels{/name}","releases_url":"https://api.github.com/repos/vanosg/eggdrop/releases{/id}","created_at":"2015-10-22T03:17:01Z","updated_at":"2015-10-22T03:17:05Z","pushed_at":"2015-10-22T04:12:08Z","git_url":"git://github.com/vanosg/eggdrop.git","ssh_url":"git@github.com:vanosg/eggdrop.git","clone_url":"https://github.com/vanosg/eggdrop.git","svn_url":"https://github.com/vanosg/eggdrop","homepage":null,"size":10762,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v1.8"}},"base":{"label":"eggheads:v1.8","ref":"v1.8","sha":"d7853683f11c64f28ddefdb94e88f490fda76e52","user":{"login":"eggheads","id":1483260,"avatar_url":"https://avatars.githubusercontent.com/u/1483260?v=3","gravatar_id":"","url":"https://api.github.com/users/eggheads","html_url":"https://github.com/eggheads","followers_url":"https://api.github.com/users/eggheads/followers","following_url":"https://api.github.com/users/eggheads/following{/other_user}","gists_url":"https://api.github.com/users/eggheads/gists{/gist_id}","starred_url":"https://api.github.com/users/eggheads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggheads/subscriptions","organizations_url":"https://api.github.com/users/eggheads/orgs","repos_url":"https://api.github.com/users/eggheads/repos","events_url":"https://api.github.com/users/eggheads/events{/privacy}","received_events_url":"https://api.github.com/users/eggheads/received_events","type":"Organization","site_admin":false},"repo":{"id":44209137,"name":"eggdrop","full_name":"eggheads/eggdrop","owner":{"login":"eggheads","id":1483260,"avatar_url":"https://avatars.githubusercontent.com/u/1483260?v=3","gravatar_id":"","url":"https://api.github.com/users/eggheads","html_url":"https://github.com/eggheads","followers_url":"https://api.github.com/users/eggheads/followers","following_url":"https://api.github.com/users/eggheads/following{/other_user}","gists_url":"https://api.github.com/users/eggheads/gists{/gist_id}","starred_url":"https://api.github.com/users/eggheads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggheads/subscriptions","organizations_url":"https://api.github.com/users/eggheads/orgs","repos_url":"https://api.github.com/users/eggheads/repos","events_url":"https://api.github.com/users/eggheads/events{/privacy}","received_events_url":"https://api.github.com/users/eggheads/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eggheads/eggdrop","description":"The Eggdrop IRC Bot","fork":false,"url":"https://api.github.com/repos/eggheads/eggdrop","forks_url":"https://api.github.com/repos/eggheads/eggdrop/forks","keys_url":"https://api.github.com/repos/eggheads/eggdrop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eggheads/eggdrop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eggheads/eggdrop/teams","hooks_url":"https://api.github.com/repos/eggheads/eggdrop/hooks","issue_events_url":"https://api.github.com/repos/eggheads/eggdrop/issues/events{/number}","events_url":"https://api.github.com/repos/eggheads/eggdrop/events","assignees_url":"https://api.github.com/repos/eggheads/eggdrop/assignees{/user}","branches_url":"https://api.github.com/repos/eggheads/eggdrop/branches{/branch}","tags_url":"https://api.github.com/repos/eggheads/eggdrop/tags","blobs_url":"https://api.github.com/repos/eggheads/eggdrop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eggheads/eggdrop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eggheads/eggdrop/git/refs{/sha}","trees_url":"https://api.github.com/repos/eggheads/eggdrop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eggheads/eggdrop/statuses/{sha}","languages_url":"https://api.github.com/repos/eggheads/eggdrop/languages","stargazers_url":"https://api.github.com/repos/eggheads/eggdrop/stargazers","contributors_url":"https://api.github.com/repos/eggheads/eggdrop/contributors","subscribers_url":"https://api.github.com/repos/eggheads/eggdrop/subscribers","subscription_url":"https://api.github.com/repos/eggheads/eggdrop/subscription","commits_url":"https://api.github.com/repos/eggheads/eggdrop/commits{/sha}","git_commits_url":"https://api.github.com/repos/eggheads/eggdrop/git/commits{/sha}","comments_url":"https://api.github.com/repos/eggheads/eggdrop/comments{/number}","issue_comment_url":"https://api.github.com/repos/eggheads/eggdrop/issues/comments{/number}","contents_url":"https://api.github.com/repos/eggheads/eggdrop/contents/{+path}","compare_url":"https://api.github.com/repos/eggheads/eggdrop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eggheads/eggdrop/merges","archive_url":"https://api.github.com/repos/eggheads/eggdrop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eggheads/eggdrop/downloads","issues_url":"https://api.github.com/repos/eggheads/eggdrop/issues{/number}","pulls_url":"https://api.github.com/repos/eggheads/eggdrop/pulls{/number}","milestones_url":"https://api.github.com/repos/eggheads/eggdrop/milestones{/number}","notifications_url":"https://api.github.com/repos/eggheads/eggdrop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eggheads/eggdrop/labels{/name}","releases_url":"https://api.github.com/repos/eggheads/eggdrop/releases{/id}","created_at":"2015-10-13T22:26:59Z","updated_at":"2015-10-19T06:18:45Z","pushed_at":"2015-10-22T11:54:14Z","git_url":"git://github.com/eggheads/eggdrop.git","ssh_url":"git@github.com:eggheads/eggdrop.git","clone_url":"https://github.com/eggheads/eggdrop.git","svn_url":"https://github.com/eggheads/eggdrop","homepage":null,"size":10762,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":60,"forks":2,"open_issues":60,"watchers":2,"default_branch":"v1.8"}},"_links":{"self":{"href":"https://api.github.com/repos/eggheads/eggdrop/pulls/118"},"html":{"href":"https://github.com/eggheads/eggdrop/pull/118"},"issue":{"href":"https://api.github.com/repos/eggheads/eggdrop/issues/118"},"comments":{"href":"https://api.github.com/repos/eggheads/eggdrop/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/eggheads/eggdrop/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/eggheads/eggdrop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eggheads/eggdrop/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/eggheads/eggdrop/statuses/8d7a306456cfe231cb6db038b6491f4e40d3599e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"thommey","id":614832,"avatar_url":"https://avatars.githubusercontent.com/u/614832?v=3","gravatar_id":"","url":"https://api.github.com/users/thommey","html_url":"https://github.com/thommey","followers_url":"https://api.github.com/users/thommey/followers","following_url":"https://api.github.com/users/thommey/following{/other_user}","gists_url":"https://api.github.com/users/thommey/gists{/gist_id}","starred_url":"https://api.github.com/users/thommey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thommey/subscriptions","organizations_url":"https://api.github.com/users/thommey/orgs","repos_url":"https://api.github.com/users/thommey/repos","events_url":"https://api.github.com/users/thommey/events{/privacy}","received_events_url":"https://api.github.com/users/thommey/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":0,"changed_files":1}}