{"action":"created","comment":{"url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/comments/46960984","id":46960984,"diff_hunk":"@@ -130,46 +130,72 @@\n   #---------------------------------------------------------------------------#\n   # Configure BGP IPv4 Neighbors\n   #---------------------------------------------------------------------------#\n+\n+  $capability_negotiation = $operatingsystem ? {\n+    'nexus' => true,\n+    default => undef\n+  }\n+  $dynamic_capability = $operatingsystem ? {\n+    'nexus' => true,\n+    default => undef\n+  }\n+  $log_neighbor_changes = $operatingsystem ? {\n+    'nexus' => disable,\n+    default => undef\n+  }\n+  $low_memory_exempt = $operatingsystem ? {\n+    'nexus' => false,\n+    default => undef\n+  }\n+  $remove_private_as = $operatingsystem ? {\n+    'nexus' => 'all',\n+    default => undef\n+  }\n+  $update_source = $operatingsystem ? {\n+    'nexus' => 'ethernet1/1',\n+    default => 'fastethernet1/1/1/1'\n+  }\n+\n   cisco_bgp_neighbor {'55.77 blue 1.1.1.1':\n     ensure                 => present,\n \n     #Properties\n     description            => 'my description',\n     connected_check        => true,\n-    capability_negotiation => true,\n-    dynamic_capability     => true,\n+    capability_negotiation => $capability_negotiation,\n+    dynamic_capability     => $dynamic_capability,\n     ebgp_multihop          => 2,\n-    local_as               => 55.77,\n-    log_neighbor_changes   => disable,\n-    low_memory_exempt      => false,\n+    local_as               => 55.88,","path":"examples/demo_bgp.pp","position":44,"original_position":44,"commit_id":"32f3a9371a85f191bb6f67fc5e1498fb91a47fd5","original_commit_id":"32f3a9371a85f191bb6f67fc5e1498fb91a47fd5","user":{"login":"ceburkett","id":862510,"avatar_url":"https://avatars.githubusercontent.com/u/862510?v=3","gravatar_id":"","url":"https://api.github.com/users/ceburkett","html_url":"https://github.com/ceburkett","followers_url":"https://api.github.com/users/ceburkett/followers","following_url":"https://api.github.com/users/ceburkett/following{/other_user}","gists_url":"https://api.github.com/users/ceburkett/gists{/gist_id}","starred_url":"https://api.github.com/users/ceburkett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceburkett/subscriptions","organizations_url":"https://api.github.com/users/ceburkett/orgs","repos_url":"https://api.github.com/users/ceburkett/repos","events_url":"https://api.github.com/users/ceburkett/events{/privacy}","received_events_url":"https://api.github.com/users/ceburkett/received_events","type":"User","site_admin":false},"body":"Yes.  XR doesn't allow a neighbor local_as to be the same as the BGP AS, so I just changed it for both XR and NX.","created_at":"2015-12-08T14:48:12Z","updated_at":"2015-12-08T14:48:12Z","html_url":"https://github.com/cisco/cisco-network-puppet-module/pull/97#discussion_r46960984","pull_request_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/comments/46960984"},"html":{"href":"https://github.com/cisco/cisco-network-puppet-module/pull/97#discussion_r46960984"},"pull_request":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/97","id":52684786,"html_url":"https://github.com/cisco/cisco-network-puppet-module/pull/97","diff_url":"https://github.com/cisco/cisco-network-puppet-module/pull/97.diff","patch_url":"https://github.com/cisco/cisco-network-puppet-module/pull/97.patch","issue_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/97","number":97,"state":"open","locked":false,"title":"BGP neighbor puppet support for XR","user":{"login":"chburket","id":15893389,"avatar_url":"https://avatars.githubusercontent.com/u/15893389?v=3","gravatar_id":"","url":"https://api.github.com/users/chburket","html_url":"https://github.com/chburket","followers_url":"https://api.github.com/users/chburket/followers","following_url":"https://api.github.com/users/chburket/following{/other_user}","gists_url":"https://api.github.com/users/chburket/gists{/gist_id}","starred_url":"https://api.github.com/users/chburket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chburket/subscriptions","organizations_url":"https://api.github.com/users/chburket/orgs","repos_url":"https://api.github.com/users/chburket/repos","events_url":"https://api.github.com/users/chburket/events{/privacy}","received_events_url":"https://api.github.com/users/chburket/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-04T15:47:03Z","updated_at":"2015-12-08T14:48:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28fa9b19c3dc6ecc64db486392cb20f0d356b621","assignee":{"login":"glennmatthews","id":5603551,"avatar_url":"https://avatars.githubusercontent.com/u/5603551?v=3","gravatar_id":"","url":"https://api.github.com/users/glennmatthews","html_url":"https://github.com/glennmatthews","followers_url":"https://api.github.com/users/glennmatthews/followers","following_url":"https://api.github.com/users/glennmatthews/following{/other_user}","gists_url":"https://api.github.com/users/glennmatthews/gists{/gist_id}","starred_url":"https://api.github.com/users/glennmatthews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennmatthews/subscriptions","organizations_url":"https://api.github.com/users/glennmatthews/orgs","repos_url":"https://api.github.com/users/glennmatthews/repos","events_url":"https://api.github.com/users/glennmatthews/events{/privacy}","received_events_url":"https://api.github.com/users/glennmatthews/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/97/commits","review_comments_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/97/comments","review_comment_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/97/comments","statuses_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/statuses/32f3a9371a85f191bb6f67fc5e1498fb91a47fd5","head":{"label":"chburket:feature/grpc","ref":"feature/grpc","sha":"32f3a9371a85f191bb6f67fc5e1498fb91a47fd5","user":{"login":"chburket","id":15893389,"avatar_url":"https://avatars.githubusercontent.com/u/15893389?v=3","gravatar_id":"","url":"https://api.github.com/users/chburket","html_url":"https://github.com/chburket","followers_url":"https://api.github.com/users/chburket/followers","following_url":"https://api.github.com/users/chburket/following{/other_user}","gists_url":"https://api.github.com/users/chburket/gists{/gist_id}","starred_url":"https://api.github.com/users/chburket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chburket/subscriptions","organizations_url":"https://api.github.com/users/chburket/orgs","repos_url":"https://api.github.com/users/chburket/repos","events_url":"https://api.github.com/users/chburket/events{/privacy}","received_events_url":"https://api.github.com/users/chburket/received_events","type":"User","site_admin":false},"repo":{"id":46367138,"name":"cisco-network-puppet-module","full_name":"chburket/cisco-network-puppet-module","owner":{"login":"chburket","id":15893389,"avatar_url":"https://avatars.githubusercontent.com/u/15893389?v=3","gravatar_id":"","url":"https://api.github.com/users/chburket","html_url":"https://github.com/chburket","followers_url":"https://api.github.com/users/chburket/followers","following_url":"https://api.github.com/users/chburket/following{/other_user}","gists_url":"https://api.github.com/users/chburket/gists{/gist_id}","starred_url":"https://api.github.com/users/chburket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chburket/subscriptions","organizations_url":"https://api.github.com/users/chburket/orgs","repos_url":"https://api.github.com/users/chburket/repos","events_url":"https://api.github.com/users/chburket/events{/privacy}","received_events_url":"https://api.github.com/users/chburket/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chburket/cisco-network-puppet-module","description":"","fork":true,"url":"https://api.github.com/repos/chburket/cisco-network-puppet-module","forks_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/forks","keys_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/teams","hooks_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/hooks","issue_events_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/issues/events{/number}","events_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/events","assignees_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/assignees{/user}","branches_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/branches{/branch}","tags_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/tags","blobs_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/statuses/{sha}","languages_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/languages","stargazers_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/stargazers","contributors_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/contributors","subscribers_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/subscribers","subscription_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/subscription","commits_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/contents/{+path}","compare_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/merges","archive_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/downloads","issues_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/issues{/number}","pulls_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/pulls{/number}","milestones_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/milestones{/number}","notifications_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/labels{/name}","releases_url":"https://api.github.com/repos/chburket/cisco-network-puppet-module/releases{/id}","created_at":"2015-11-17T18:33:40Z","updated_at":"2015-11-17T18:33:42Z","pushed_at":"2015-12-08T03:22:58Z","git_url":"git://github.com/chburket/cisco-network-puppet-module.git","ssh_url":"git@github.com:chburket/cisco-network-puppet-module.git","clone_url":"https://github.com/chburket/cisco-network-puppet-module.git","svn_url":"https://github.com/chburket/cisco-network-puppet-module","homepage":null,"size":1102,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"cisco:feature/grpc","ref":"feature/grpc","sha":"7ee9c9264126e41f73e71c89bb3d44cfb28358ab","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":39565139,"name":"cisco-network-puppet-module","full_name":"cisco/cisco-network-puppet-module","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/cisco-network-puppet-module","description":"","fork":false,"url":"https://api.github.com/repos/cisco/cisco-network-puppet-module","forks_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/forks","keys_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/teams","hooks_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/hooks","issue_events_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/events","assignees_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/tags","blobs_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/languages","stargazers_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/stargazers","contributors_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/contributors","subscribers_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/subscribers","subscription_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/subscription","commits_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/merges","archive_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/downloads","issues_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/labels{/name}","releases_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/releases{/id}","created_at":"2015-07-23T12:06:48Z","updated_at":"2015-11-16T19:52:07Z","pushed_at":"2015-12-08T07:20:57Z","git_url":"git://github.com/cisco/cisco-network-puppet-module.git","ssh_url":"git@github.com:cisco/cisco-network-puppet-module.git","clone_url":"https://github.com/cisco/cisco-network-puppet-module.git","svn_url":"https://github.com/cisco/cisco-network-puppet-module","homepage":null,"size":1680,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":7,"forks":20,"open_issues":7,"watchers":8,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/97"},"html":{"href":"https://github.com/cisco/cisco-network-puppet-module/pull/97"},"issue":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/97"},"comments":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/statuses/32f3a9371a85f191bb6f67fc5e1498fb91a47fd5"}}}}