{"action":"opened","number":339,"pull_request":{"url":"https://api.github.com/repos/10up/ElasticPress/pulls/339","id":43726693,"html_url":"https://github.com/10up/ElasticPress/pull/339","diff_url":"https://github.com/10up/ElasticPress/pull/339.diff","patch_url":"https://github.com/10up/ElasticPress/pull/339.patch","issue_url":"https://api.github.com/repos/10up/ElasticPress/issues/339","number":339,"state":"open","locked":false,"title":"Add configuration to choose to index all attachments at index time","user":{"login":"sambonner","id":1644716,"avatar_url":"https://avatars.githubusercontent.com/u/1644716?v=3","gravatar_id":"","url":"https://api.github.com/users/sambonner","html_url":"https://github.com/sambonner","followers_url":"https://api.github.com/users/sambonner/followers","following_url":"https://api.github.com/users/sambonner/following{/other_user}","gists_url":"https://api.github.com/users/sambonner/gists{/gist_id}","starred_url":"https://api.github.com/users/sambonner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambonner/subscriptions","organizations_url":"https://api.github.com/users/sambonner/orgs","repos_url":"https://api.github.com/users/sambonner/repos","events_url":"https://api.github.com/users/sambonner/events{/privacy}","received_events_url":"https://api.github.com/users/sambonner/received_events","type":"User","site_admin":false},"body":"Hi, my apologies if this patch should be applied within https://github.com/10up/ElasticPress/pull/319, I wasn't sure as I see that it has already been merged.\r\n\r\nAnyway, this patch essentially just adds a new ElasticPress config  (EP_INDEX_ATTACHMENTS) that, if defined in wp-config.php will cause all attachments to indexed on initial ElasticSearch index. I believe something like this was discussed here - https://github.com/10up/ElasticPress/pull/319#commitcomment-12347070\r\n\r\nI'm unclear if this is actually the appropriate place to be checking runtime configuration, so suggestions happily accepted.\r\n\r\nThanks,\r\nSam","created_at":"2015-08-31T02:12:51Z","updated_at":"2015-08-31T02:12:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/10up/ElasticPress/pulls/339/commits","review_comments_url":"https://api.github.com/repos/10up/ElasticPress/pulls/339/comments","review_comment_url":"https://api.github.com/repos/10up/ElasticPress/pulls/comments{/number}","comments_url":"https://api.github.com/repos/10up/ElasticPress/issues/339/comments","statuses_url":"https://api.github.com/repos/10up/ElasticPress/statuses/26879e41f18dee1da1883451d8a3dd11285dc53b","head":{"label":"sambonner:feature/index-all-attachments","ref":"feature/index-all-attachments","sha":"26879e41f18dee1da1883451d8a3dd11285dc53b","user":{"login":"sambonner","id":1644716,"avatar_url":"https://avatars.githubusercontent.com/u/1644716?v=3","gravatar_id":"","url":"https://api.github.com/users/sambonner","html_url":"https://github.com/sambonner","followers_url":"https://api.github.com/users/sambonner/followers","following_url":"https://api.github.com/users/sambonner/following{/other_user}","gists_url":"https://api.github.com/users/sambonner/gists{/gist_id}","starred_url":"https://api.github.com/users/sambonner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambonner/subscriptions","organizations_url":"https://api.github.com/users/sambonner/orgs","repos_url":"https://api.github.com/users/sambonner/repos","events_url":"https://api.github.com/users/sambonner/events{/privacy}","received_events_url":"https://api.github.com/users/sambonner/received_events","type":"User","site_admin":false},"repo":{"id":41649593,"name":"ElasticPress","full_name":"sambonner/ElasticPress","owner":{"login":"sambonner","id":1644716,"avatar_url":"https://avatars.githubusercontent.com/u/1644716?v=3","gravatar_id":"","url":"https://api.github.com/users/sambonner","html_url":"https://github.com/sambonner","followers_url":"https://api.github.com/users/sambonner/followers","following_url":"https://api.github.com/users/sambonner/following{/other_user}","gists_url":"https://api.github.com/users/sambonner/gists{/gist_id}","starred_url":"https://api.github.com/users/sambonner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambonner/subscriptions","organizations_url":"https://api.github.com/users/sambonner/orgs","repos_url":"https://api.github.com/users/sambonner/repos","events_url":"https://api.github.com/users/sambonner/events{/privacy}","received_events_url":"https://api.github.com/users/sambonner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sambonner/ElasticPress","description":"A plugin for integrating WordPress with Elasticsearch","fork":true,"url":"https://api.github.com/repos/sambonner/ElasticPress","forks_url":"https://api.github.com/repos/sambonner/ElasticPress/forks","keys_url":"https://api.github.com/repos/sambonner/ElasticPress/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sambonner/ElasticPress/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sambonner/ElasticPress/teams","hooks_url":"https://api.github.com/repos/sambonner/ElasticPress/hooks","issue_events_url":"https://api.github.com/repos/sambonner/ElasticPress/issues/events{/number}","events_url":"https://api.github.com/repos/sambonner/ElasticPress/events","assignees_url":"https://api.github.com/repos/sambonner/ElasticPress/assignees{/user}","branches_url":"https://api.github.com/repos/sambonner/ElasticPress/branches{/branch}","tags_url":"https://api.github.com/repos/sambonner/ElasticPress/tags","blobs_url":"https://api.github.com/repos/sambonner/ElasticPress/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sambonner/ElasticPress/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sambonner/ElasticPress/git/refs{/sha}","trees_url":"https://api.github.com/repos/sambonner/ElasticPress/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sambonner/ElasticPress/statuses/{sha}","languages_url":"https://api.github.com/repos/sambonner/ElasticPress/languages","stargazers_url":"https://api.github.com/repos/sambonner/ElasticPress/stargazers","contributors_url":"https://api.github.com/repos/sambonner/ElasticPress/contributors","subscribers_url":"https://api.github.com/repos/sambonner/ElasticPress/subscribers","subscription_url":"https://api.github.com/repos/sambonner/ElasticPress/subscription","commits_url":"https://api.github.com/repos/sambonner/ElasticPress/commits{/sha}","git_commits_url":"https://api.github.com/repos/sambonner/ElasticPress/git/commits{/sha}","comments_url":"https://api.github.com/repos/sambonner/ElasticPress/comments{/number}","issue_comment_url":"https://api.github.com/repos/sambonner/ElasticPress/issues/comments{/number}","contents_url":"https://api.github.com/repos/sambonner/ElasticPress/contents/{+path}","compare_url":"https://api.github.com/repos/sambonner/ElasticPress/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sambonner/ElasticPress/merges","archive_url":"https://api.github.com/repos/sambonner/ElasticPress/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sambonner/ElasticPress/downloads","issues_url":"https://api.github.com/repos/sambonner/ElasticPress/issues{/number}","pulls_url":"https://api.github.com/repos/sambonner/ElasticPress/pulls{/number}","milestones_url":"https://api.github.com/repos/sambonner/ElasticPress/milestones{/number}","notifications_url":"https://api.github.com/repos/sambonner/ElasticPress/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sambonner/ElasticPress/labels{/name}","releases_url":"https://api.github.com/repos/sambonner/ElasticPress/releases{/id}","created_at":"2015-08-31T01:33:38Z","updated_at":"2015-08-31T01:33:39Z","pushed_at":"2015-08-31T01:52:15Z","git_url":"git://github.com/sambonner/ElasticPress.git","ssh_url":"git@github.com:sambonner/ElasticPress.git","clone_url":"https://github.com/sambonner/ElasticPress.git","svn_url":"https://github.com/sambonner/ElasticPress","homepage":"","size":2528,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"10up:develop","ref":"develop","sha":"91d3157a8fc3a41d3b8ca79137cdfc564844c17f","user":{"login":"10up","id":3358927,"avatar_url":"https://avatars.githubusercontent.com/u/3358927?v=3","gravatar_id":"","url":"https://api.github.com/users/10up","html_url":"https://github.com/10up","followers_url":"https://api.github.com/users/10up/followers","following_url":"https://api.github.com/users/10up/following{/other_user}","gists_url":"https://api.github.com/users/10up/gists{/gist_id}","starred_url":"https://api.github.com/users/10up/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/10up/subscriptions","organizations_url":"https://api.github.com/users/10up/orgs","repos_url":"https://api.github.com/users/10up/repos","events_url":"https://api.github.com/users/10up/events{/privacy}","received_events_url":"https://api.github.com/users/10up/received_events","type":"Organization","site_admin":false},"repo":{"id":20672392,"name":"ElasticPress","full_name":"10up/ElasticPress","owner":{"login":"10up","id":3358927,"avatar_url":"https://avatars.githubusercontent.com/u/3358927?v=3","gravatar_id":"","url":"https://api.github.com/users/10up","html_url":"https://github.com/10up","followers_url":"https://api.github.com/users/10up/followers","following_url":"https://api.github.com/users/10up/following{/other_user}","gists_url":"https://api.github.com/users/10up/gists{/gist_id}","starred_url":"https://api.github.com/users/10up/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/10up/subscriptions","organizations_url":"https://api.github.com/users/10up/orgs","repos_url":"https://api.github.com/users/10up/repos","events_url":"https://api.github.com/users/10up/events{/privacy}","received_events_url":"https://api.github.com/users/10up/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/10up/ElasticPress","description":"A plugin for integrating WordPress with Elasticsearch","fork":false,"url":"https://api.github.com/repos/10up/ElasticPress","forks_url":"https://api.github.com/repos/10up/ElasticPress/forks","keys_url":"https://api.github.com/repos/10up/ElasticPress/keys{/key_id}","collaborators_url":"https://api.github.com/repos/10up/ElasticPress/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/10up/ElasticPress/teams","hooks_url":"https://api.github.com/repos/10up/ElasticPress/hooks","issue_events_url":"https://api.github.com/repos/10up/ElasticPress/issues/events{/number}","events_url":"https://api.github.com/repos/10up/ElasticPress/events","assignees_url":"https://api.github.com/repos/10up/ElasticPress/assignees{/user}","branches_url":"https://api.github.com/repos/10up/ElasticPress/branches{/branch}","tags_url":"https://api.github.com/repos/10up/ElasticPress/tags","blobs_url":"https://api.github.com/repos/10up/ElasticPress/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/10up/ElasticPress/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/10up/ElasticPress/git/refs{/sha}","trees_url":"https://api.github.com/repos/10up/ElasticPress/git/trees{/sha}","statuses_url":"https://api.github.com/repos/10up/ElasticPress/statuses/{sha}","languages_url":"https://api.github.com/repos/10up/ElasticPress/languages","stargazers_url":"https://api.github.com/repos/10up/ElasticPress/stargazers","contributors_url":"https://api.github.com/repos/10up/ElasticPress/contributors","subscribers_url":"https://api.github.com/repos/10up/ElasticPress/subscribers","subscription_url":"https://api.github.com/repos/10up/ElasticPress/subscription","commits_url":"https://api.github.com/repos/10up/ElasticPress/commits{/sha}","git_commits_url":"https://api.github.com/repos/10up/ElasticPress/git/commits{/sha}","comments_url":"https://api.github.com/repos/10up/ElasticPress/comments{/number}","issue_comment_url":"https://api.github.com/repos/10up/ElasticPress/issues/comments{/number}","contents_url":"https://api.github.com/repos/10up/ElasticPress/contents/{+path}","compare_url":"https://api.github.com/repos/10up/ElasticPress/compare/{base}...{head}","merges_url":"https://api.github.com/repos/10up/ElasticPress/merges","archive_url":"https://api.github.com/repos/10up/ElasticPress/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/10up/ElasticPress/downloads","issues_url":"https://api.github.com/repos/10up/ElasticPress/issues{/number}","pulls_url":"https://api.github.com/repos/10up/ElasticPress/pulls{/number}","milestones_url":"https://api.github.com/repos/10up/ElasticPress/milestones{/number}","notifications_url":"https://api.github.com/repos/10up/ElasticPress/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/10up/ElasticPress/labels{/name}","releases_url":"https://api.github.com/repos/10up/ElasticPress/releases{/id}","created_at":"2014-06-10T04:29:30Z","updated_at":"2015-08-26T08:50:09Z","pushed_at":"2015-08-31T02:12:51Z","git_url":"git://github.com/10up/ElasticPress.git","ssh_url":"git@github.com:10up/ElasticPress.git","clone_url":"https://github.com/10up/ElasticPress.git","svn_url":"https://github.com/10up/ElasticPress","homepage":"","size":2528,"stargazers_count":189,"watchers_count":189,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":40,"forks":48,"open_issues":40,"watchers":189,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/10up/ElasticPress/pulls/339"},"html":{"href":"https://github.com/10up/ElasticPress/pull/339"},"issue":{"href":"https://api.github.com/repos/10up/ElasticPress/issues/339"},"comments":{"href":"https://api.github.com/repos/10up/ElasticPress/issues/339/comments"},"review_comments":{"href":"https://api.github.com/repos/10up/ElasticPress/pulls/339/comments"},"review_comment":{"href":"https://api.github.com/repos/10up/ElasticPress/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/10up/ElasticPress/pulls/339/commits"},"statuses":{"href":"https://api.github.com/repos/10up/ElasticPress/statuses/26879e41f18dee1da1883451d8a3dd11285dc53b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":1,"changed_files":1}}