{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/37377633","id":37377633,"diff_hunk":"@@ -638,22 +638,110 @@ unsigned int LimitOrphanTxSize(unsigned int nMaxOrphans) EXCLUSIVE_LOCKS_REQUIRE\n     return nEvicted;\n }\n \n-bool IsFinalTx(const CTransaction &tx, int nBlockHeight, int64_t nBlockTime)\n+int64_t LockTime(const CTransaction &tx, int flags, const CCoinsView* pCoinsView, int nBlockHeight, int64_t nBlockTime)","path":"src/main.cpp","position":5,"original_position":5,"commit_id":"246d456476119d464adfb8fa2e938b6def13ad50","original_commit_id":"246d456476119d464adfb8fa2e938b6def13ad50","user":{"login":"maaku","id":69154,"avatar_url":"https://avatars.githubusercontent.com/u/69154?v=3","gravatar_id":"","url":"https://api.github.com/users/maaku","html_url":"https://github.com/maaku","followers_url":"https://api.github.com/users/maaku/followers","following_url":"https://api.github.com/users/maaku/following{/other_user}","gists_url":"https://api.github.com/users/maaku/gists{/gist_id}","starred_url":"https://api.github.com/users/maaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maaku/subscriptions","organizations_url":"https://api.github.com/users/maaku/orgs","repos_url":"https://api.github.com/users/maaku/repos","events_url":"https://api.github.com/users/maaku/events{/privacy}","received_events_url":"https://api.github.com/users/maaku/received_events","type":"User","site_admin":false},"body":"No it switches to opposite meaning -- zero indicates tx is final, nonzero\nindicates when it will become final.\nOn Aug 18, 2015 8:24 PM, \"Luke-Jr\" <notifications@github.com> wrote:\n\n> In src/main.cpp\n> <https://github.com/bitcoin/bitcoin/pull/6312#discussion_r37376960>:\n>\n> > @@ -638,22 +638,110 @@ unsigned int LimitOrphanTxSize(unsigned int nMaxOrphans) EXCLUSIVE_LOCKS_REQUIRE\n> >      return nEvicted;\n> >  }\n> >\n> > -bool IsFinalTx(const CTransaction &tx, int nBlockHeight, int64_t nBlockTime)\n> > +int64_t LockTime(const CTransaction &tx, int flags, const CCoinsView* pCoinsView, int nBlockHeight, int64_t nBlockTime)\n>\n> You mean because it returns int64_t instead of bool? But unless I missed a\n> spot, the return value is only ever *used* as a bool in the same sense...\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/bitcoin/bitcoin/pull/6312/files#r37376960>.\n>\n","created_at":"2015-08-19T03:42:44Z","updated_at":"2015-08-19T03:42:44Z","html_url":"https://github.com/bitcoin/bitcoin/pull/6312#discussion_r37377633","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6312","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/37377633"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/6312#discussion_r37377633"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6312"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6312","id":38159730,"html_url":"https://github.com/bitcoin/bitcoin/pull/6312","diff_url":"https://github.com/bitcoin/bitcoin/pull/6312.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/6312.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6312","number":6312,"state":"open","locked":false,"title":"Mempool-only sequence number constraint verification (BIP 68)","user":{"login":"maaku","id":69154,"avatar_url":"https://avatars.githubusercontent.com/u/69154?v=3","gravatar_id":"","url":"https://api.github.com/users/maaku","html_url":"https://github.com/maaku","followers_url":"https://api.github.com/users/maaku/followers","following_url":"https://api.github.com/users/maaku/following{/other_user}","gists_url":"https://api.github.com/users/maaku/gists{/gist_id}","starred_url":"https://api.github.com/users/maaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maaku/subscriptions","organizations_url":"https://api.github.com/users/maaku/orgs","repos_url":"https://api.github.com/users/maaku/repos","events_url":"https://api.github.com/users/maaku/events{/privacy}","received_events_url":"https://api.github.com/users/maaku/received_events","type":"User","site_admin":false},"body":"Essentially enforces sequence numbers as a relative lock-time as an IsStandard() rule to make it easy to test applications using it; blocks containing transactions with invalid sequence numbers given the age of their inputs per BIP 68 are still accepted.\r\n\r\nThis pull-req is *not* a soft-fork nor does it contain any code to start that process.\r\n\r\nThis pull request builds on top of #6177.\r\n\r\nBackground: [BIP 68, Consensus-enforced transaction replacement signalled via sequence numbers](https://github.com/maaku/bips/blob/bip68/bip-0068.mediawiki)","created_at":"2015-06-20T00:55:58Z","updated_at":"2015-08-19T03:42:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6280becc7369a9841cc5b9ccd71b33ee82dc44ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6312/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6312/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6312/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/246d456476119d464adfb8fa2e938b6def13ad50","head":{"label":"maaku:sequencenumbers","ref":"sequencenumbers","sha":"246d456476119d464adfb8fa2e938b6def13ad50","user":{"login":"maaku","id":69154,"avatar_url":"https://avatars.githubusercontent.com/u/69154?v=3","gravatar_id":"","url":"https://api.github.com/users/maaku","html_url":"https://github.com/maaku","followers_url":"https://api.github.com/users/maaku/followers","following_url":"https://api.github.com/users/maaku/following{/other_user}","gists_url":"https://api.github.com/users/maaku/gists{/gist_id}","starred_url":"https://api.github.com/users/maaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maaku/subscriptions","organizations_url":"https://api.github.com/users/maaku/orgs","repos_url":"https://api.github.com/users/maaku/repos","events_url":"https://api.github.com/users/maaku/events{/privacy}","received_events_url":"https://api.github.com/users/maaku/received_events","type":"User","site_admin":false},"repo":{"id":14071785,"name":"bitcoin","full_name":"maaku/bitcoin","owner":{"login":"maaku","id":69154,"avatar_url":"https://avatars.githubusercontent.com/u/69154?v=3","gravatar_id":"","url":"https://api.github.com/users/maaku","html_url":"https://github.com/maaku","followers_url":"https://api.github.com/users/maaku/followers","following_url":"https://api.github.com/users/maaku/following{/other_user}","gists_url":"https://api.github.com/users/maaku/gists{/gist_id}","starred_url":"https://api.github.com/users/maaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maaku/subscriptions","organizations_url":"https://api.github.com/users/maaku/orgs","repos_url":"https://api.github.com/users/maaku/repos","events_url":"https://api.github.com/users/maaku/events{/privacy}","received_events_url":"https://api.github.com/users/maaku/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maaku/bitcoin","description":"Bitcoin integration/staging tree","fork":true,"url":"https://api.github.com/repos/maaku/bitcoin","forks_url":"https://api.github.com/repos/maaku/bitcoin/forks","keys_url":"https://api.github.com/repos/maaku/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maaku/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maaku/bitcoin/teams","hooks_url":"https://api.github.com/repos/maaku/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/maaku/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/maaku/bitcoin/events","assignees_url":"https://api.github.com/repos/maaku/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/maaku/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/maaku/bitcoin/tags","blobs_url":"https://api.github.com/repos/maaku/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maaku/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maaku/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/maaku/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maaku/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/maaku/bitcoin/languages","stargazers_url":"https://api.github.com/repos/maaku/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/maaku/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/maaku/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/maaku/bitcoin/subscription","commits_url":"https://api.github.com/repos/maaku/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/maaku/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/maaku/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/maaku/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/maaku/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/maaku/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maaku/bitcoin/merges","archive_url":"https://api.github.com/repos/maaku/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maaku/bitcoin/downloads","issues_url":"https://api.github.com/repos/maaku/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/maaku/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/maaku/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/maaku/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maaku/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/maaku/bitcoin/releases{/id}","created_at":"2013-11-02T18:08:23Z","updated_at":"2015-04-06T15:21:53Z","pushed_at":"2015-08-19T01:16:13Z","git_url":"git://github.com/maaku/bitcoin.git","ssh_url":"git@github.com:maaku/bitcoin.git","clone_url":"https://github.com/maaku/bitcoin.git","svn_url":"https://github.com/maaku/bitcoin","homepage":"http://www.bitcoin.org","size":51657,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"1e92b275406e3fbc7ab59d2ada1c882ca15fb36f","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","created_at":"2010-12-19T15:16:43Z","updated_at":"2015-08-19T02:45:24Z","pushed_at":"2015-08-19T01:16:18Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":131747,"stargazers_count":7341,"watchers_count":7341,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5094,"mirror_url":null,"open_issues_count":443,"forks":5094,"open_issues":443,"watchers":7341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6312"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/6312"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/6312"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/6312/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6312/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6312/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/246d456476119d464adfb8fa2e938b6def13ad50"}}}}