{"action":"created","comment":{"url":"https://api.github.com/repos/Addepar/ember-charts/pulls/comments/45933166","id":45933166,"diff_hunk":"@@ -367,10 +359,85 @@ export default ChartComponent.extend(FloatingTooltipMixin,\n     return this.get('yAxis').attr(this.get('axisAttrs'));\n   },\n \n+  /**\n+   * Given the list of elements for the group labels and value labels,\n+   * determine the width of the largest label on either side of the chart.","path":"addon/components/horizontal-bar-chart.js","position":98,"original_position":98,"commit_id":"8512cb69634932f7ea4fdb1be095792db5b8dad9","original_commit_id":"8512cb69634932f7ea4fdb1be095792db5b8dad9","user":{"login":"philpee2","id":2244653,"avatar_url":"https://avatars.githubusercontent.com/u/2244653?v=3","gravatar_id":"","url":"https://api.github.com/users/philpee2","html_url":"https://github.com/philpee2","followers_url":"https://api.github.com/users/philpee2/followers","following_url":"https://api.github.com/users/philpee2/following{/other_user}","gists_url":"https://api.github.com/users/philpee2/gists{/gist_id}","starred_url":"https://api.github.com/users/philpee2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philpee2/subscriptions","organizations_url":"https://api.github.com/users/philpee2/orgs","repos_url":"https://api.github.com/users/philpee2/repos","events_url":"https://api.github.com/users/philpee2/events{/privacy}","received_events_url":"https://api.github.com/users/philpee2/received_events","type":"User","site_admin":false},"body":"No, it returns the label width on both sides of the chart. That's what `determine the width of the largest label on either side of the chart` means. ","created_at":"2015-11-26T00:08:15Z","updated_at":"2015-11-26T00:08:15Z","html_url":"https://github.com/Addepar/ember-charts/pull/134#discussion_r45933166","pull_request_url":"https://api.github.com/repos/Addepar/ember-charts/pulls/134","_links":{"self":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/comments/45933166"},"html":{"href":"https://github.com/Addepar/ember-charts/pull/134#discussion_r45933166"},"pull_request":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/134"}}},"pull_request":{"url":"https://api.github.com/repos/Addepar/ember-charts/pulls/134","id":51855972,"html_url":"https://github.com/Addepar/ember-charts/pull/134","diff_url":"https://github.com/Addepar/ember-charts/pull/134.diff","patch_url":"https://github.com/Addepar/ember-charts/pull/134.patch","issue_url":"https://api.github.com/repos/Addepar/ember-charts/issues/134","number":134,"state":"open","locked":false,"title":"Make labels in horizontal bar charts flush with edges","user":{"login":"philpee2","id":2244653,"avatar_url":"https://avatars.githubusercontent.com/u/2244653?v=3","gravatar_id":"","url":"https://api.github.com/users/philpee2","html_url":"https://github.com/philpee2","followers_url":"https://api.github.com/users/philpee2/followers","following_url":"https://api.github.com/users/philpee2/following{/other_user}","gists_url":"https://api.github.com/users/philpee2/gists{/gist_id}","starred_url":"https://api.github.com/users/philpee2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philpee2/subscriptions","organizations_url":"https://api.github.com/users/philpee2/orgs","repos_url":"https://api.github.com/users/philpee2/repos","events_url":"https://api.github.com/users/philpee2/events{/privacy}","received_events_url":"https://api.github.com/users/philpee2/received_events","type":"User","site_admin":false},"body":"This basically reverts 485001bfb93b4341df57723eb8ba3a4bf8d9050c for horizontal bar charts, but leaves it\r\nfor pie charts. Instead of having a configurable `labelWidthMultiplier`, which\r\nwas used to determine the horizontal margin on both sides of the chart,\r\nthe left and right margins are now computed based on the longest label on\r\neither side of the chart. This means that the labels should always be close\r\nto flush with the edges of the chart container.\r\n\r\n@Addepar/fire \r\n\r\nBlue highlight to show how close to flush it is\r\n![image](https://cloud.githubusercontent.com/assets/2244653/11411581/34c114e0-9386-11e5-832b-0f31a7a6492d.png)\r\n\r\nWith Y axis title\r\n![image](https://cloud.githubusercontent.com/assets/2244653/11411585/3c936330-9386-11e5-8db8-b12f3c4a589a.png)\r\n\r\nPositive and negative values\r\n![image](https://cloud.githubusercontent.com/assets/2244653/11411592/46ad4a34-9386-11e5-94b5-28fe002ea5aa.png)\r\n\r\nAll negative values\r\n![image](https://cloud.githubusercontent.com/assets/2244653/11411596/4e14a59c-9386-11e5-8e55-967c9a1cb11b.png)\r\n\r\nLong label\r\n![image](https://cloud.githubusercontent.com/assets/2244653/11411606/68489acc-9386-11e5-8c91-ec1824360da4.png)\r\n","created_at":"2015-11-25T23:05:40Z","updated_at":"2015-11-26T00:08:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4967724b06ee5f682bf74b1c58429ab5ea226695","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Addepar/ember-charts/pulls/134/commits","review_comments_url":"https://api.github.com/repos/Addepar/ember-charts/pulls/134/comments","review_comment_url":"https://api.github.com/repos/Addepar/ember-charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Addepar/ember-charts/issues/134/comments","statuses_url":"https://api.github.com/repos/Addepar/ember-charts/statuses/8512cb69634932f7ea4fdb1be095792db5b8dad9","head":{"label":"Addepar:philn/horizontal-bar-labels","ref":"philn/horizontal-bar-labels","sha":"8512cb69634932f7ea4fdb1be095792db5b8dad9","user":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"repo":{"id":13790555,"name":"ember-charts","full_name":"Addepar/ember-charts","owner":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Addepar/ember-charts","description":"","fork":false,"url":"https://api.github.com/repos/Addepar/ember-charts","forks_url":"https://api.github.com/repos/Addepar/ember-charts/forks","keys_url":"https://api.github.com/repos/Addepar/ember-charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Addepar/ember-charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Addepar/ember-charts/teams","hooks_url":"https://api.github.com/repos/Addepar/ember-charts/hooks","issue_events_url":"https://api.github.com/repos/Addepar/ember-charts/issues/events{/number}","events_url":"https://api.github.com/repos/Addepar/ember-charts/events","assignees_url":"https://api.github.com/repos/Addepar/ember-charts/assignees{/user}","branches_url":"https://api.github.com/repos/Addepar/ember-charts/branches{/branch}","tags_url":"https://api.github.com/repos/Addepar/ember-charts/tags","blobs_url":"https://api.github.com/repos/Addepar/ember-charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Addepar/ember-charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Addepar/ember-charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/Addepar/ember-charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Addepar/ember-charts/statuses/{sha}","languages_url":"https://api.github.com/repos/Addepar/ember-charts/languages","stargazers_url":"https://api.github.com/repos/Addepar/ember-charts/stargazers","contributors_url":"https://api.github.com/repos/Addepar/ember-charts/contributors","subscribers_url":"https://api.github.com/repos/Addepar/ember-charts/subscribers","subscription_url":"https://api.github.com/repos/Addepar/ember-charts/subscription","commits_url":"https://api.github.com/repos/Addepar/ember-charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/Addepar/ember-charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/Addepar/ember-charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/Addepar/ember-charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/Addepar/ember-charts/contents/{+path}","compare_url":"https://api.github.com/repos/Addepar/ember-charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Addepar/ember-charts/merges","archive_url":"https://api.github.com/repos/Addepar/ember-charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Addepar/ember-charts/downloads","issues_url":"https://api.github.com/repos/Addepar/ember-charts/issues{/number}","pulls_url":"https://api.github.com/repos/Addepar/ember-charts/pulls{/number}","milestones_url":"https://api.github.com/repos/Addepar/ember-charts/milestones{/number}","notifications_url":"https://api.github.com/repos/Addepar/ember-charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Addepar/ember-charts/labels{/name}","releases_url":"https://api.github.com/repos/Addepar/ember-charts/releases{/id}","created_at":"2013-10-23T01:27:05Z","updated_at":"2015-11-25T05:18:17Z","pushed_at":"2015-11-25T23:53:34Z","git_url":"git://github.com/Addepar/ember-charts.git","ssh_url":"git@github.com:Addepar/ember-charts.git","clone_url":"https://github.com/Addepar/ember-charts.git","svn_url":"https://github.com/Addepar/ember-charts","homepage":null,"size":8895,"stargazers_count":669,"watchers_count":669,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":99,"mirror_url":null,"open_issues_count":18,"forks":99,"open_issues":18,"watchers":669,"default_branch":"master"}},"base":{"label":"Addepar:master","ref":"master","sha":"1bb8837621bc0a757e96bfef97693a392797bb65","user":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"repo":{"id":13790555,"name":"ember-charts","full_name":"Addepar/ember-charts","owner":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Addepar/ember-charts","description":"","fork":false,"url":"https://api.github.com/repos/Addepar/ember-charts","forks_url":"https://api.github.com/repos/Addepar/ember-charts/forks","keys_url":"https://api.github.com/repos/Addepar/ember-charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Addepar/ember-charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Addepar/ember-charts/teams","hooks_url":"https://api.github.com/repos/Addepar/ember-charts/hooks","issue_events_url":"https://api.github.com/repos/Addepar/ember-charts/issues/events{/number}","events_url":"https://api.github.com/repos/Addepar/ember-charts/events","assignees_url":"https://api.github.com/repos/Addepar/ember-charts/assignees{/user}","branches_url":"https://api.github.com/repos/Addepar/ember-charts/branches{/branch}","tags_url":"https://api.github.com/repos/Addepar/ember-charts/tags","blobs_url":"https://api.github.com/repos/Addepar/ember-charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Addepar/ember-charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Addepar/ember-charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/Addepar/ember-charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Addepar/ember-charts/statuses/{sha}","languages_url":"https://api.github.com/repos/Addepar/ember-charts/languages","stargazers_url":"https://api.github.com/repos/Addepar/ember-charts/stargazers","contributors_url":"https://api.github.com/repos/Addepar/ember-charts/contributors","subscribers_url":"https://api.github.com/repos/Addepar/ember-charts/subscribers","subscription_url":"https://api.github.com/repos/Addepar/ember-charts/subscription","commits_url":"https://api.github.com/repos/Addepar/ember-charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/Addepar/ember-charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/Addepar/ember-charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/Addepar/ember-charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/Addepar/ember-charts/contents/{+path}","compare_url":"https://api.github.com/repos/Addepar/ember-charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Addepar/ember-charts/merges","archive_url":"https://api.github.com/repos/Addepar/ember-charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Addepar/ember-charts/downloads","issues_url":"https://api.github.com/repos/Addepar/ember-charts/issues{/number}","pulls_url":"https://api.github.com/repos/Addepar/ember-charts/pulls{/number}","milestones_url":"https://api.github.com/repos/Addepar/ember-charts/milestones{/number}","notifications_url":"https://api.github.com/repos/Addepar/ember-charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Addepar/ember-charts/labels{/name}","releases_url":"https://api.github.com/repos/Addepar/ember-charts/releases{/id}","created_at":"2013-10-23T01:27:05Z","updated_at":"2015-11-25T05:18:17Z","pushed_at":"2015-11-25T23:53:34Z","git_url":"git://github.com/Addepar/ember-charts.git","ssh_url":"git@github.com:Addepar/ember-charts.git","clone_url":"https://github.com/Addepar/ember-charts.git","svn_url":"https://github.com/Addepar/ember-charts","homepage":null,"size":8895,"stargazers_count":669,"watchers_count":669,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":99,"mirror_url":null,"open_issues_count":18,"forks":99,"open_issues":18,"watchers":669,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/134"},"html":{"href":"https://github.com/Addepar/ember-charts/pull/134"},"issue":{"href":"https://api.github.com/repos/Addepar/ember-charts/issues/134"},"comments":{"href":"https://api.github.com/repos/Addepar/ember-charts/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/Addepar/ember-charts/statuses/8512cb69634932f7ea4fdb1be095792db5b8dad9"}}}}