{"action":"created","issue":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/746","labels_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/746/labels{/name}","comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/746/comments","events_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/746/events","html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/746","id":116025335,"number":746,"title":"Remove adc.readvdd33() limitation.","user":{"login":"jmattsson","id":869607,"avatar_url":"https://avatars.githubusercontent.com/u/869607?v=3","gravatar_id":"","url":"https://api.github.com/users/jmattsson","html_url":"https://github.com/jmattsson","followers_url":"https://api.github.com/users/jmattsson/followers","following_url":"https://api.github.com/users/jmattsson/following{/other_user}","gists_url":"https://api.github.com/users/jmattsson/gists{/gist_id}","starred_url":"https://api.github.com/users/jmattsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmattsson/subscriptions","organizations_url":"https://api.github.com/users/jmattsson/orgs","repos_url":"https://api.github.com/users/jmattsson/repos","events_url":"https://api.github.com/users/jmattsson/events{/privacy}","received_events_url":"https://api.github.com/users/jmattsson/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2015-11-10T04:47:14Z","updated_at":"2015-12-19T06:19:46Z","closed_at":"2015-12-01T23:37:53Z","pull_request":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/746","html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/746","diff_url":"https://github.com/nodemcu/nodemcu-firmware/pull/746.diff","patch_url":"https://github.com/nodemcu/nodemcu-firmware/pull/746.patch"},"body":"With the change to use the new system_get_vdd33() function for reading vdd33, it became possible to read it while connected to WiFi. As such, the explicit prevention of doing so is no longer needed nor wanted. Getting vdd33 is now possible regardless of whether the WiFi is connected (since system_get_vdd33 internally suspends WiFi while reading the vdd).\r\n\r\nNote that system_get_vdd33() checks byte 107 of esp_init_data_default.bin, so this byte MUST be changed to 0xFF to get actual ADC readings (otherwise you'll only see 65535 returned). For whatever reason the SDK-provided esp_init_data_default.bin does not have this set.\r\n\r\nThis should thoroughly close #433, btw."},"comment":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/comments/165953079","html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/746#issuecomment-165953079","issue_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/746","id":165953079,"user":{"login":"eyaleb","id":8308047,"avatar_url":"https://avatars.githubusercontent.com/u/8308047?v=3","gravatar_id":"","url":"https://api.github.com/users/eyaleb","html_url":"https://github.com/eyaleb","followers_url":"https://api.github.com/users/eyaleb/followers","following_url":"https://api.github.com/users/eyaleb/following{/other_user}","gists_url":"https://api.github.com/users/eyaleb/gists{/gist_id}","starred_url":"https://api.github.com/users/eyaleb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyaleb/subscriptions","organizations_url":"https://api.github.com/users/eyaleb/orgs","repos_url":"https://api.github.com/users/eyaleb/repos","events_url":"https://api.github.com/users/eyaleb/events{/privacy}","received_events_url":"https://api.github.com/users/eyaleb/received_events","type":"User","site_admin":false},"created_at":"2015-12-19T06:19:46Z","updated_at":"2015-12-19T06:19:46Z","body":"As I was investigating issues with OW (https://github.com/nodemcu/nodemcu-firmware/issues/859) I slowly reverted my changes (there was only one) and now it looks like the abovementioned call to `readvdd33()` is the cause of the problem (bad ow readings).\r\n\r\nI do not know enough about the internals of the SDK (or the hwr) but not calling this function made my `ds18b20` readings reliable.\r\n\r\nIn short: do not proceed with the above proposal. I still need a way to read both `vdd33` and `tout`.\r\n\r\n\r\n"}}