{"action":"opened","number":3146,"pull_request":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/3146","id":27807329,"html_url":"https://github.com/kripken/emscripten/pull/3146","diff_url":"https://github.com/kripken/emscripten/pull/3146.diff","patch_url":"https://github.com/kripken/emscripten/pull/3146.patch","issue_url":"https://api.github.com/repos/kripken/emscripten/issues/3146","number":3146,"state":"open","locked":false,"title":"Attempt to clarify INCLUDE_FULL_LIBRARY comments","user":{"login":"aidanhs","id":1050652,"avatar_url":"https://avatars.githubusercontent.com/u/1050652?v=3","gravatar_id":"","url":"https://api.github.com/users/aidanhs","html_url":"https://github.com/aidanhs","followers_url":"https://api.github.com/users/aidanhs/followers","following_url":"https://api.github.com/users/aidanhs/following{/other_user}","gists_url":"https://api.github.com/users/aidanhs/gists{/gist_id}","starred_url":"https://api.github.com/users/aidanhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidanhs/subscriptions","organizations_url":"https://api.github.com/users/aidanhs/orgs","repos_url":"https://api.github.com/users/aidanhs/repos","events_url":"https://api.github.com/users/aidanhs/events{/privacy}","received_events_url":"https://api.github.com/users/aidanhs/received_events","type":"User","site_admin":false},"body":"Unfortunately the following is still opaque to me, so not ready to merge yet:\r\n\r\n> For example, if a library uses malloc or new, you will\r\n> need to use those in the main file too to link in dlmalloc.\r\n\r\nShould 'library' in the above be 'module'? That aside, I just don't understand this sentence. If you want to link in dlmalloc, why do you need to use malloc and/or new in the main module so other modules can use it? Should it actually be saying 'if you want have a module use dlmalloc, you must link it into your main module'?","created_at":"2015-01-22T00:07:57Z","updated_at":"2015-01-22T00:07:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kripken/emscripten/pulls/3146/commits","review_comments_url":"https://api.github.com/repos/kripken/emscripten/pulls/3146/comments","review_comment_url":"https://api.github.com/repos/kripken/emscripten/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kripken/emscripten/issues/3146/comments","statuses_url":"https://api.github.com/repos/kripken/emscripten/statuses/2784ba184b65c4ad98443565701674ccaa49c627","head":{"label":"aidanhs:aphs-clarify-include-full-library","ref":"aphs-clarify-include-full-library","sha":"2784ba184b65c4ad98443565701674ccaa49c627","user":{"login":"aidanhs","id":1050652,"avatar_url":"https://avatars.githubusercontent.com/u/1050652?v=3","gravatar_id":"","url":"https://api.github.com/users/aidanhs","html_url":"https://github.com/aidanhs","followers_url":"https://api.github.com/users/aidanhs/followers","following_url":"https://api.github.com/users/aidanhs/following{/other_user}","gists_url":"https://api.github.com/users/aidanhs/gists{/gist_id}","starred_url":"https://api.github.com/users/aidanhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidanhs/subscriptions","organizations_url":"https://api.github.com/users/aidanhs/orgs","repos_url":"https://api.github.com/users/aidanhs/repos","events_url":"https://api.github.com/users/aidanhs/events{/privacy}","received_events_url":"https://api.github.com/users/aidanhs/received_events","type":"User","site_admin":false},"repo":{"id":25492754,"name":"emscripten","full_name":"aidanhs/emscripten","owner":{"login":"aidanhs","id":1050652,"avatar_url":"https://avatars.githubusercontent.com/u/1050652?v=3","gravatar_id":"","url":"https://api.github.com/users/aidanhs","html_url":"https://github.com/aidanhs","followers_url":"https://api.github.com/users/aidanhs/followers","following_url":"https://api.github.com/users/aidanhs/following{/other_user}","gists_url":"https://api.github.com/users/aidanhs/gists{/gist_id}","starred_url":"https://api.github.com/users/aidanhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidanhs/subscriptions","organizations_url":"https://api.github.com/users/aidanhs/orgs","repos_url":"https://api.github.com/users/aidanhs/repos","events_url":"https://api.github.com/users/aidanhs/events{/privacy}","received_events_url":"https://api.github.com/users/aidanhs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aidanhs/emscripten","description":"Emscripten: An LLVM-to-JavaScript Compiler","fork":true,"url":"https://api.github.com/repos/aidanhs/emscripten","forks_url":"https://api.github.com/repos/aidanhs/emscripten/forks","keys_url":"https://api.github.com/repos/aidanhs/emscripten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aidanhs/emscripten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aidanhs/emscripten/teams","hooks_url":"https://api.github.com/repos/aidanhs/emscripten/hooks","issue_events_url":"https://api.github.com/repos/aidanhs/emscripten/issues/events{/number}","events_url":"https://api.github.com/repos/aidanhs/emscripten/events","assignees_url":"https://api.github.com/repos/aidanhs/emscripten/assignees{/user}","branches_url":"https://api.github.com/repos/aidanhs/emscripten/branches{/branch}","tags_url":"https://api.github.com/repos/aidanhs/emscripten/tags","blobs_url":"https://api.github.com/repos/aidanhs/emscripten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aidanhs/emscripten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aidanhs/emscripten/git/refs{/sha}","trees_url":"https://api.github.com/repos/aidanhs/emscripten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aidanhs/emscripten/statuses/{sha}","languages_url":"https://api.github.com/repos/aidanhs/emscripten/languages","stargazers_url":"https://api.github.com/repos/aidanhs/emscripten/stargazers","contributors_url":"https://api.github.com/repos/aidanhs/emscripten/contributors","subscribers_url":"https://api.github.com/repos/aidanhs/emscripten/subscribers","subscription_url":"https://api.github.com/repos/aidanhs/emscripten/subscription","commits_url":"https://api.github.com/repos/aidanhs/emscripten/commits{/sha}","git_commits_url":"https://api.github.com/repos/aidanhs/emscripten/git/commits{/sha}","comments_url":"https://api.github.com/repos/aidanhs/emscripten/comments{/number}","issue_comment_url":"https://api.github.com/repos/aidanhs/emscripten/issues/comments/{number}","contents_url":"https://api.github.com/repos/aidanhs/emscripten/contents/{+path}","compare_url":"https://api.github.com/repos/aidanhs/emscripten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aidanhs/emscripten/merges","archive_url":"https://api.github.com/repos/aidanhs/emscripten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aidanhs/emscripten/downloads","issues_url":"https://api.github.com/repos/aidanhs/emscripten/issues{/number}","pulls_url":"https://api.github.com/repos/aidanhs/emscripten/pulls{/number}","milestones_url":"https://api.github.com/repos/aidanhs/emscripten/milestones{/number}","notifications_url":"https://api.github.com/repos/aidanhs/emscripten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aidanhs/emscripten/labels{/name}","releases_url":"https://api.github.com/repos/aidanhs/emscripten/releases{/id}","created_at":"2014-10-21T00:05:56Z","updated_at":"2014-10-20T22:46:28Z","pushed_at":"2015-01-22T00:03:34Z","git_url":"git://github.com/aidanhs/emscripten.git","ssh_url":"git@github.com:aidanhs/emscripten.git","clone_url":"https://github.com/aidanhs/emscripten.git","svn_url":"https://github.com/aidanhs/emscripten","homepage":"","size":111523,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kripken:incoming","ref":"incoming","sha":"91f12a43425e1bf122744c364e3f57a847e90957","user":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"repo":{"id":1357796,"name":"emscripten","full_name":"kripken/emscripten","owner":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kripken/emscripten","description":"Emscripten: An LLVM-to-JavaScript Compiler","fork":false,"url":"https://api.github.com/repos/kripken/emscripten","forks_url":"https://api.github.com/repos/kripken/emscripten/forks","keys_url":"https://api.github.com/repos/kripken/emscripten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kripken/emscripten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kripken/emscripten/teams","hooks_url":"https://api.github.com/repos/kripken/emscripten/hooks","issue_events_url":"https://api.github.com/repos/kripken/emscripten/issues/events{/number}","events_url":"https://api.github.com/repos/kripken/emscripten/events","assignees_url":"https://api.github.com/repos/kripken/emscripten/assignees{/user}","branches_url":"https://api.github.com/repos/kripken/emscripten/branches{/branch}","tags_url":"https://api.github.com/repos/kripken/emscripten/tags","blobs_url":"https://api.github.com/repos/kripken/emscripten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kripken/emscripten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kripken/emscripten/git/refs{/sha}","trees_url":"https://api.github.com/repos/kripken/emscripten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kripken/emscripten/statuses/{sha}","languages_url":"https://api.github.com/repos/kripken/emscripten/languages","stargazers_url":"https://api.github.com/repos/kripken/emscripten/stargazers","contributors_url":"https://api.github.com/repos/kripken/emscripten/contributors","subscribers_url":"https://api.github.com/repos/kripken/emscripten/subscribers","subscription_url":"https://api.github.com/repos/kripken/emscripten/subscription","commits_url":"https://api.github.com/repos/kripken/emscripten/commits{/sha}","git_commits_url":"https://api.github.com/repos/kripken/emscripten/git/commits{/sha}","comments_url":"https://api.github.com/repos/kripken/emscripten/comments{/number}","issue_comment_url":"https://api.github.com/repos/kripken/emscripten/issues/comments/{number}","contents_url":"https://api.github.com/repos/kripken/emscripten/contents/{+path}","compare_url":"https://api.github.com/repos/kripken/emscripten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kripken/emscripten/merges","archive_url":"https://api.github.com/repos/kripken/emscripten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kripken/emscripten/downloads","issues_url":"https://api.github.com/repos/kripken/emscripten/issues{/number}","pulls_url":"https://api.github.com/repos/kripken/emscripten/pulls{/number}","milestones_url":"https://api.github.com/repos/kripken/emscripten/milestones{/number}","notifications_url":"https://api.github.com/repos/kripken/emscripten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kripken/emscripten/labels{/name}","releases_url":"https://api.github.com/repos/kripken/emscripten/releases{/id}","created_at":"2011-02-12T05:23:30Z","updated_at":"2015-01-21T19:03:57Z","pushed_at":"2015-01-21T23:52:29Z","git_url":"git://github.com/kripken/emscripten.git","ssh_url":"git@github.com:kripken/emscripten.git","clone_url":"https://github.com/kripken/emscripten.git","svn_url":"https://github.com/kripken/emscripten","homepage":"","size":193217,"stargazers_count":7721,"watchers_count":7721,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":846,"mirror_url":null,"open_issues_count":532,"forks":846,"open_issues":532,"watchers":7721,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/3146"},"html":{"href":"https://github.com/kripken/emscripten/pull/3146"},"issue":{"href":"https://api.github.com/repos/kripken/emscripten/issues/3146"},"comments":{"href":"https://api.github.com/repos/kripken/emscripten/issues/3146/comments"},"review_comments":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/3146/comments"},"review_comment":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/3146/commits"},"statuses":{"href":"https://api.github.com/repos/kripken/emscripten/statuses/2784ba184b65c4ad98443565701674ccaa49c627"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":7,"changed_files":1}}