{"action":"created","comment":{"url":"https://api.github.com/repos/Zentyal/zentyal/pulls/comments/28220365","id":28220365,"diff_hunk":"@@ -259,7 +260,19 @@ sub request {\n     $ua->agent(\"ZentyalServer $version\");\n     $ua->ssl_opts('verify_hostname' => EBox::Config::boolean('rs_verify_servers'));\n     # Set HTTP proxy if it is globally set as environment variable\n-    $ua->proxy('https', $ENV{HTTP_PROXY}) if (exists $ENV{HTTP_PROXY});\n+\n+    my $proxy =  $ENV{HTTP_PROXY};\n+    if (not $proxy) {\n+        # check that if we have proxy set in network RO\n+        my $network = EBox::Global->getInstance(1)->modInstance('network');\n+        $proxy = $network->proxySettings(1);","path":"main/remoteservices/src/EBox/RemoteServices/RESTClient.pm","position":18,"original_position":18,"commit_id":"4c4b29beacef198704108202f7ff50bab454ac2a","original_commit_id":"6c0624b7d2a09c371953566ac26bee6fdc205088","user":{"login":"sixstone-qq","id":440508,"avatar_url":"https://avatars.githubusercontent.com/u/440508?v=3","gravatar_id":"","url":"https://api.github.com/users/sixstone-qq","html_url":"https://github.com/sixstone-qq","followers_url":"https://api.github.com/users/sixstone-qq/followers","following_url":"https://api.github.com/users/sixstone-qq/following{/other_user}","gists_url":"https://api.github.com/users/sixstone-qq/gists{/gist_id}","starred_url":"https://api.github.com/users/sixstone-qq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sixstone-qq/subscriptions","organizations_url":"https://api.github.com/users/sixstone-qq/orgs","repos_url":"https://api.github.com/users/sixstone-qq/repos","events_url":"https://api.github.com/users/sixstone-qq/events{/privacy}","received_events_url":"https://api.github.com/users/sixstone-qq/received_events","type":"User","site_admin":false},"body":"Yes, I agree on those terms. The personal style is not a blocker.","created_at":"2015-04-13T08:04:57Z","updated_at":"2015-04-13T08:04:57Z","html_url":"https://github.com/Zentyal/zentyal/pull/1738#discussion_r28220365","pull_request_url":"https://api.github.com/repos/Zentyal/zentyal/pulls/1738","_links":{"self":{"href":"https://api.github.com/repos/Zentyal/zentyal/pulls/comments/28220365"},"html":{"href":"https://github.com/Zentyal/zentyal/pull/1738#discussion_r28220365"},"pull_request":{"href":"https://api.github.com/repos/Zentyal/zentyal/pulls/1738"}}},"pull_request":{"url":"https://api.github.com/repos/Zentyal/zentyal/pulls/1738","id":33068983,"html_url":"https://github.com/Zentyal/zentyal/pull/1738","diff_url":"https://github.com/Zentyal/zentyal/pull/1738.diff","patch_url":"https://github.com/Zentyal/zentyal/pull/1738.patch","issue_url":"https://api.github.com/repos/Zentyal/zentyal/issues/1738","number":1738,"state":"open","locked":false,"title":"Fixes to allow proxy in REST calls","user":{"login":"javierag","id":2778038,"avatar_url":"https://avatars.githubusercontent.com/u/2778038?v=3","gravatar_id":"","url":"https://api.github.com/users/javierag","html_url":"https://github.com/javierag","followers_url":"https://api.github.com/users/javierag/followers","following_url":"https://api.github.com/users/javierag/following{/other_user}","gists_url":"https://api.github.com/users/javierag/gists{/gist_id}","starred_url":"https://api.github.com/users/javierag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierag/subscriptions","organizations_url":"https://api.github.com/users/javierag/orgs","repos_url":"https://api.github.com/users/javierag/repos","events_url":"https://api.github.com/users/javierag/events{/privacy}","received_events_url":"https://api.github.com/users/javierag/received_events","type":"User","site_admin":false},"body":"- Fixed some error setting up proxy parameters\r\n- Using liblwp-protocol-connect-perl to allow correct https connections through proxy","created_at":"2015-04-10T18:00:18Z","updated_at":"2015-04-13T08:04:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"922d0efdc9a00f4b6f21a0fcb466b2766bebbf8a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Zentyal/zentyal/pulls/1738/commits","review_comments_url":"https://api.github.com/repos/Zentyal/zentyal/pulls/1738/comments","review_comment_url":"https://api.github.com/repos/Zentyal/zentyal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Zentyal/zentyal/issues/1738/comments","statuses_url":"https://api.github.com/repos/Zentyal/zentyal/statuses/4c4b29beacef198704108202f7ff50bab454ac2a","head":{"label":"Zentyal:jag/rest-over-proxy","ref":"jag/rest-over-proxy","sha":"4c4b29beacef198704108202f7ff50bab454ac2a","user":{"login":"Zentyal","id":491690,"avatar_url":"https://avatars.githubusercontent.com/u/491690?v=3","gravatar_id":"","url":"https://api.github.com/users/Zentyal","html_url":"https://github.com/Zentyal","followers_url":"https://api.github.com/users/Zentyal/followers","following_url":"https://api.github.com/users/Zentyal/following{/other_user}","gists_url":"https://api.github.com/users/Zentyal/gists{/gist_id}","starred_url":"https://api.github.com/users/Zentyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zentyal/subscriptions","organizations_url":"https://api.github.com/users/Zentyal/orgs","repos_url":"https://api.github.com/users/Zentyal/repos","events_url":"https://api.github.com/users/Zentyal/events{/privacy}","received_events_url":"https://api.github.com/users/Zentyal/received_events","type":"Organization","site_admin":false},"repo":{"id":6679556,"name":"zentyal","full_name":"Zentyal/zentyal","owner":{"login":"Zentyal","id":491690,"avatar_url":"https://avatars.githubusercontent.com/u/491690?v=3","gravatar_id":"","url":"https://api.github.com/users/Zentyal","html_url":"https://github.com/Zentyal","followers_url":"https://api.github.com/users/Zentyal/followers","following_url":"https://api.github.com/users/Zentyal/following{/other_user}","gists_url":"https://api.github.com/users/Zentyal/gists{/gist_id}","starred_url":"https://api.github.com/users/Zentyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zentyal/subscriptions","organizations_url":"https://api.github.com/users/Zentyal/orgs","repos_url":"https://api.github.com/users/Zentyal/repos","events_url":"https://api.github.com/users/Zentyal/events{/privacy}","received_events_url":"https://api.github.com/users/Zentyal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Zentyal/zentyal","description":"Linux Small Business Server","fork":false,"url":"https://api.github.com/repos/Zentyal/zentyal","forks_url":"https://api.github.com/repos/Zentyal/zentyal/forks","keys_url":"https://api.github.com/repos/Zentyal/zentyal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zentyal/zentyal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zentyal/zentyal/teams","hooks_url":"https://api.github.com/repos/Zentyal/zentyal/hooks","issue_events_url":"https://api.github.com/repos/Zentyal/zentyal/issues/events{/number}","events_url":"https://api.github.com/repos/Zentyal/zentyal/events","assignees_url":"https://api.github.com/repos/Zentyal/zentyal/assignees{/user}","branches_url":"https://api.github.com/repos/Zentyal/zentyal/branches{/branch}","tags_url":"https://api.github.com/repos/Zentyal/zentyal/tags","blobs_url":"https://api.github.com/repos/Zentyal/zentyal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zentyal/zentyal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zentyal/zentyal/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zentyal/zentyal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zentyal/zentyal/statuses/{sha}","languages_url":"https://api.github.com/repos/Zentyal/zentyal/languages","stargazers_url":"https://api.github.com/repos/Zentyal/zentyal/stargazers","contributors_url":"https://api.github.com/repos/Zentyal/zentyal/contributors","subscribers_url":"https://api.github.com/repos/Zentyal/zentyal/subscribers","subscription_url":"https://api.github.com/repos/Zentyal/zentyal/subscription","commits_url":"https://api.github.com/repos/Zentyal/zentyal/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zentyal/zentyal/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zentyal/zentyal/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zentyal/zentyal/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zentyal/zentyal/contents/{+path}","compare_url":"https://api.github.com/repos/Zentyal/zentyal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zentyal/zentyal/merges","archive_url":"https://api.github.com/repos/Zentyal/zentyal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zentyal/zentyal/downloads","issues_url":"https://api.github.com/repos/Zentyal/zentyal/issues{/number}","pulls_url":"https://api.github.com/repos/Zentyal/zentyal/pulls{/number}","milestones_url":"https://api.github.com/repos/Zentyal/zentyal/milestones{/number}","notifications_url":"https://api.github.com/repos/Zentyal/zentyal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zentyal/zentyal/labels{/name}","releases_url":"https://api.github.com/repos/Zentyal/zentyal/releases{/id}","created_at":"2012-11-13T23:26:41Z","updated_at":"2015-04-11T16:29:59Z","pushed_at":"2015-04-13T07:52:11Z","git_url":"git://github.com/Zentyal/zentyal.git","ssh_url":"git@github.com:Zentyal/zentyal.git","clone_url":"https://github.com/Zentyal/zentyal.git","svn_url":"https://github.com/Zentyal/zentyal","homepage":null,"size":659850,"stargazers_count":151,"watchers_count":151,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":9,"forks":55,"open_issues":9,"watchers":151,"default_branch":"master"}},"base":{"label":"Zentyal:3.0-nss","ref":"3.0-nss","sha":"a26afd78ab0b338dcb7f63fb935a7d1f69ba8294","user":{"login":"Zentyal","id":491690,"avatar_url":"https://avatars.githubusercontent.com/u/491690?v=3","gravatar_id":"","url":"https://api.github.com/users/Zentyal","html_url":"https://github.com/Zentyal","followers_url":"https://api.github.com/users/Zentyal/followers","following_url":"https://api.github.com/users/Zentyal/following{/other_user}","gists_url":"https://api.github.com/users/Zentyal/gists{/gist_id}","starred_url":"https://api.github.com/users/Zentyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zentyal/subscriptions","organizations_url":"https://api.github.com/users/Zentyal/orgs","repos_url":"https://api.github.com/users/Zentyal/repos","events_url":"https://api.github.com/users/Zentyal/events{/privacy}","received_events_url":"https://api.github.com/users/Zentyal/received_events","type":"Organization","site_admin":false},"repo":{"id":6679556,"name":"zentyal","full_name":"Zentyal/zentyal","owner":{"login":"Zentyal","id":491690,"avatar_url":"https://avatars.githubusercontent.com/u/491690?v=3","gravatar_id":"","url":"https://api.github.com/users/Zentyal","html_url":"https://github.com/Zentyal","followers_url":"https://api.github.com/users/Zentyal/followers","following_url":"https://api.github.com/users/Zentyal/following{/other_user}","gists_url":"https://api.github.com/users/Zentyal/gists{/gist_id}","starred_url":"https://api.github.com/users/Zentyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zentyal/subscriptions","organizations_url":"https://api.github.com/users/Zentyal/orgs","repos_url":"https://api.github.com/users/Zentyal/repos","events_url":"https://api.github.com/users/Zentyal/events{/privacy}","received_events_url":"https://api.github.com/users/Zentyal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Zentyal/zentyal","description":"Linux Small Business Server","fork":false,"url":"https://api.github.com/repos/Zentyal/zentyal","forks_url":"https://api.github.com/repos/Zentyal/zentyal/forks","keys_url":"https://api.github.com/repos/Zentyal/zentyal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zentyal/zentyal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zentyal/zentyal/teams","hooks_url":"https://api.github.com/repos/Zentyal/zentyal/hooks","issue_events_url":"https://api.github.com/repos/Zentyal/zentyal/issues/events{/number}","events_url":"https://api.github.com/repos/Zentyal/zentyal/events","assignees_url":"https://api.github.com/repos/Zentyal/zentyal/assignees{/user}","branches_url":"https://api.github.com/repos/Zentyal/zentyal/branches{/branch}","tags_url":"https://api.github.com/repos/Zentyal/zentyal/tags","blobs_url":"https://api.github.com/repos/Zentyal/zentyal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zentyal/zentyal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zentyal/zentyal/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zentyal/zentyal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zentyal/zentyal/statuses/{sha}","languages_url":"https://api.github.com/repos/Zentyal/zentyal/languages","stargazers_url":"https://api.github.com/repos/Zentyal/zentyal/stargazers","contributors_url":"https://api.github.com/repos/Zentyal/zentyal/contributors","subscribers_url":"https://api.github.com/repos/Zentyal/zentyal/subscribers","subscription_url":"https://api.github.com/repos/Zentyal/zentyal/subscription","commits_url":"https://api.github.com/repos/Zentyal/zentyal/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zentyal/zentyal/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zentyal/zentyal/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zentyal/zentyal/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zentyal/zentyal/contents/{+path}","compare_url":"https://api.github.com/repos/Zentyal/zentyal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zentyal/zentyal/merges","archive_url":"https://api.github.com/repos/Zentyal/zentyal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zentyal/zentyal/downloads","issues_url":"https://api.github.com/repos/Zentyal/zentyal/issues{/number}","pulls_url":"https://api.github.com/repos/Zentyal/zentyal/pulls{/number}","milestones_url":"https://api.github.com/repos/Zentyal/zentyal/milestones{/number}","notifications_url":"https://api.github.com/repos/Zentyal/zentyal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zentyal/zentyal/labels{/name}","releases_url":"https://api.github.com/repos/Zentyal/zentyal/releases{/id}","created_at":"2012-11-13T23:26:41Z","updated_at":"2015-04-11T16:29:59Z","pushed_at":"2015-04-13T07:52:11Z","git_url":"git://github.com/Zentyal/zentyal.git","ssh_url":"git@github.com:Zentyal/zentyal.git","clone_url":"https://github.com/Zentyal/zentyal.git","svn_url":"https://github.com/Zentyal/zentyal","homepage":null,"size":659850,"stargazers_count":151,"watchers_count":151,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":9,"forks":55,"open_issues":9,"watchers":151,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Zentyal/zentyal/pulls/1738"},"html":{"href":"https://github.com/Zentyal/zentyal/pull/1738"},"issue":{"href":"https://api.github.com/repos/Zentyal/zentyal/issues/1738"},"comments":{"href":"https://api.github.com/repos/Zentyal/zentyal/issues/1738/comments"},"review_comments":{"href":"https://api.github.com/repos/Zentyal/zentyal/pulls/1738/comments"},"review_comment":{"href":"https://api.github.com/repos/Zentyal/zentyal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Zentyal/zentyal/pulls/1738/commits"},"statuses":{"href":"https://api.github.com/repos/Zentyal/zentyal/statuses/4c4b29beacef198704108202f7ff50bab454ac2a"}}}}