{"action":"created","issue":{"url":"https://api.github.com/repos/sam-github/modern-syslog/issues/1","labels_url":"https://api.github.com/repos/sam-github/modern-syslog/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/sam-github/modern-syslog/issues/1/comments","events_url":"https://api.github.com/repos/sam-github/modern-syslog/issues/1/events","html_url":"https://github.com/sam-github/modern-syslog/pull/1","id":60573316,"number":1,"title":"Initial","user":{"login":"sam-github","id":17607,"avatar_url":"https://avatars.githubusercontent.com/u/17607?v=3","gravatar_id":"","url":"https://api.github.com/users/sam-github","html_url":"https://github.com/sam-github","followers_url":"https://api.github.com/users/sam-github/followers","following_url":"https://api.github.com/users/sam-github/following{/other_user}","gists_url":"https://api.github.com/users/sam-github/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-github/subscriptions","organizations_url":"https://api.github.com/users/sam-github/orgs","repos_url":"https://api.github.com/users/sam-github/repos","events_url":"https://api.github.com/users/sam-github/events{/privacy}","received_events_url":"https://api.github.com/users/sam-github/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-10T21:34:14Z","updated_at":"2015-03-19T22:52:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sam-github/modern-syslog/pulls/1","html_url":"https://github.com/sam-github/modern-syslog/pull/1","diff_url":"https://github.com/sam-github/modern-syslog/pull/1.diff","patch_url":"https://github.com/sam-github/modern-syslog/pull/1.patch"},"body":"@bnoordhuis PTAL In particular at core.cc.\r\n\r\nI'm wondering if I should be implementing two versions of `core.syslog`, one that takes a buffer, one that takes a String, and then dispatching between them like [fs does](https://github.com/iojs/io.js/blob/v1.x/lib/fs.js#L620-L646). Is that the right way? I thought I'd be able to find out if the [msg](https://github.com/sam-github/modern-syslog/blob/initial/core.cc#L65) argument was a Buffer in C++, and do it there, but I'm not successfully figuring out how to do that.\r\n\r\nThe `syslog()` core function is most likely going to get called with a String mostly, but in the case of a writeable [stream](https://github.com/sam-github/modern-syslog/blob/initial/index.js#L99-L101), it will be a Buffer. I could ask the stream base to not convert strings to buffers, then I could get either String or Buffer and treat them differently - should I do that?"},"comment":{"url":"https://api.github.com/repos/sam-github/modern-syslog/issues/comments/83790490","html_url":"https://github.com/sam-github/modern-syslog/pull/1#issuecomment-83790490","issue_url":"https://api.github.com/repos/sam-github/modern-syslog/issues/1","id":83790490,"user":{"login":"rmg","id":17978,"avatar_url":"https://avatars.githubusercontent.com/u/17978?v=3","gravatar_id":"","url":"https://api.github.com/users/rmg","html_url":"https://github.com/rmg","followers_url":"https://api.github.com/users/rmg/followers","following_url":"https://api.github.com/users/rmg/following{/other_user}","gists_url":"https://api.github.com/users/rmg/gists{/gist_id}","starred_url":"https://api.github.com/users/rmg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmg/subscriptions","organizations_url":"https://api.github.com/users/rmg/orgs","repos_url":"https://api.github.com/users/rmg/repos","events_url":"https://api.github.com/users/rmg/events{/privacy}","received_events_url":"https://api.github.com/users/rmg/received_events","type":"User","site_admin":false},"created_at":"2015-03-19T22:52:26Z","updated_at":"2015-03-19T22:52:26Z","body":"You should add a test or two with multi-line input to see what it does."}}