{"action":"opened","number":3386,"pull_request":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/3386","id":28948628,"html_url":"https://github.com/phpbb/phpbb/pull/3386","diff_url":"https://github.com/phpbb/phpbb/pull/3386.diff","patch_url":"https://github.com/phpbb/phpbb/pull/3386.patch","issue_url":"https://api.github.com/repos/phpbb/phpbb/issues/3386","number":3386,"state":"open","locked":false,"title":"[ticket/12559] Add forum setting to limit subforums legend to direct children only","user":{"login":"PayBas","id":3015760,"avatar_url":"https://avatars.githubusercontent.com/u/3015760?v=3","gravatar_id":"","url":"https://api.github.com/users/PayBas","html_url":"https://github.com/PayBas","followers_url":"https://api.github.com/users/PayBas/followers","following_url":"https://api.github.com/users/PayBas/following{/other_user}","gists_url":"https://api.github.com/users/PayBas/gists{/gist_id}","starred_url":"https://api.github.com/users/PayBas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PayBas/subscriptions","organizations_url":"https://api.github.com/users/PayBas/orgs","repos_url":"https://api.github.com/users/PayBas/repos","events_url":"https://api.github.com/users/PayBas/events{/privacy}","received_events_url":"https://api.github.com/users/PayBas/received_events","type":"User","site_admin":false},"body":"https://tracker.phpbb.com/browse/PHPBB3-12559\r\nhttp://area51.phpbb.com/phpBB/viewtopic.php?f=108&t=45585\r\nPHPBB3-12559\r\n\r\n>Actually, adding this as an option for categories in the ACP module is very tricky. There isn't really any place for a unique setting that is shared by forums & categories, but not links. We can't simply duplicate form components for obvious reasons, and introducing yet another table column for categories which does exactly the same thing as the forum version... that's just silly.\r\n\r\n>So I'm going to leave it as is. If admins really want to limit subforums for categories, they can change the forum type to \"forum\", change the setting, and change the type back to \"category\".\r\n\r\n>Not ideal, but it's the cleanest way, code-wise.\r\n\r\nCopied from the original PR https://github.com/phpbb/phpbb/pull/2473\r\n\r\n>please rebase onto develop and replace your request_var() calls by $request->variable()\r\nBut it would be the only one, all other settings seem to use the old `request_var()` method.\r\n\r\nDone","created_at":"2015-02-09T19:25:19Z","updated_at":"2015-02-09T19:25:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a326724a5ec0ad44071e0776f6057b0d956bf29","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phpbb/phpbb/pulls/3386/commits","review_comments_url":"https://api.github.com/repos/phpbb/phpbb/pulls/3386/comments","review_comment_url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/{number}","comments_url":"https://api.github.com/repos/phpbb/phpbb/issues/3386/comments","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/5294f654926b032c728de3c99205c0f0715fae22","head":{"label":"PayBas:ticket/12559","ref":"ticket/12559","sha":"5294f654926b032c728de3c99205c0f0715fae22","user":{"login":"PayBas","id":3015760,"avatar_url":"https://avatars.githubusercontent.com/u/3015760?v=3","gravatar_id":"","url":"https://api.github.com/users/PayBas","html_url":"https://github.com/PayBas","followers_url":"https://api.github.com/users/PayBas/followers","following_url":"https://api.github.com/users/PayBas/following{/other_user}","gists_url":"https://api.github.com/users/PayBas/gists{/gist_id}","starred_url":"https://api.github.com/users/PayBas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PayBas/subscriptions","organizations_url":"https://api.github.com/users/PayBas/orgs","repos_url":"https://api.github.com/users/PayBas/repos","events_url":"https://api.github.com/users/PayBas/events{/privacy}","received_events_url":"https://api.github.com/users/PayBas/received_events","type":"User","site_admin":false},"repo":{"id":18152363,"name":"phpbb","full_name":"PayBas/phpbb","owner":{"login":"PayBas","id":3015760,"avatar_url":"https://avatars.githubusercontent.com/u/3015760?v=3","gravatar_id":"","url":"https://api.github.com/users/PayBas","html_url":"https://github.com/PayBas","followers_url":"https://api.github.com/users/PayBas/followers","following_url":"https://api.github.com/users/PayBas/following{/other_user}","gists_url":"https://api.github.com/users/PayBas/gists{/gist_id}","starred_url":"https://api.github.com/users/PayBas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PayBas/subscriptions","organizations_url":"https://api.github.com/users/PayBas/orgs","repos_url":"https://api.github.com/users/PayBas/repos","events_url":"https://api.github.com/users/PayBas/events{/privacy}","received_events_url":"https://api.github.com/users/PayBas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PayBas/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":true,"url":"https://api.github.com/repos/PayBas/phpbb","forks_url":"https://api.github.com/repos/PayBas/phpbb/forks","keys_url":"https://api.github.com/repos/PayBas/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PayBas/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PayBas/phpbb/teams","hooks_url":"https://api.github.com/repos/PayBas/phpbb/hooks","issue_events_url":"https://api.github.com/repos/PayBas/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/PayBas/phpbb/events","assignees_url":"https://api.github.com/repos/PayBas/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/PayBas/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/PayBas/phpbb/tags","blobs_url":"https://api.github.com/repos/PayBas/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PayBas/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PayBas/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/PayBas/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PayBas/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/PayBas/phpbb/languages","stargazers_url":"https://api.github.com/repos/PayBas/phpbb/stargazers","contributors_url":"https://api.github.com/repos/PayBas/phpbb/contributors","subscribers_url":"https://api.github.com/repos/PayBas/phpbb/subscribers","subscription_url":"https://api.github.com/repos/PayBas/phpbb/subscription","commits_url":"https://api.github.com/repos/PayBas/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/PayBas/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/PayBas/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/PayBas/phpbb/issues/comments/{number}","contents_url":"https://api.github.com/repos/PayBas/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/PayBas/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PayBas/phpbb/merges","archive_url":"https://api.github.com/repos/PayBas/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PayBas/phpbb/downloads","issues_url":"https://api.github.com/repos/PayBas/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/PayBas/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/PayBas/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/PayBas/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PayBas/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/PayBas/phpbb/releases{/id}","created_at":"2014-03-26T20:13:36Z","updated_at":"2015-02-09T14:15:20Z","pushed_at":"2015-02-09T19:22:55Z","git_url":"git://github.com/PayBas/phpbb.git","ssh_url":"git@github.com:PayBas/phpbb.git","clone_url":"https://github.com/PayBas/phpbb.git","svn_url":"https://github.com/PayBas/phpbb","homepage":"http://www.phpbb.com","size":51777,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"develop-ascraeus"}},"base":{"label":"phpbb:develop","ref":"develop","sha":"acf3744297303324490c484156f0bf808e532883","user":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"repo":{"id":541983,"name":"phpbb","full_name":"phpbb/phpbb","owner":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpbb/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":false,"url":"https://api.github.com/repos/phpbb/phpbb","forks_url":"https://api.github.com/repos/phpbb/phpbb/forks","keys_url":"https://api.github.com/repos/phpbb/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpbb/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpbb/phpbb/teams","hooks_url":"https://api.github.com/repos/phpbb/phpbb/hooks","issue_events_url":"https://api.github.com/repos/phpbb/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/phpbb/phpbb/events","assignees_url":"https://api.github.com/repos/phpbb/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/phpbb/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/phpbb/phpbb/tags","blobs_url":"https://api.github.com/repos/phpbb/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpbb/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpbb/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpbb/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/phpbb/phpbb/languages","stargazers_url":"https://api.github.com/repos/phpbb/phpbb/stargazers","contributors_url":"https://api.github.com/repos/phpbb/phpbb/contributors","subscribers_url":"https://api.github.com/repos/phpbb/phpbb/subscribers","subscription_url":"https://api.github.com/repos/phpbb/phpbb/subscription","commits_url":"https://api.github.com/repos/phpbb/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpbb/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpbb/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpbb/phpbb/issues/comments/{number}","contents_url":"https://api.github.com/repos/phpbb/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/phpbb/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpbb/phpbb/merges","archive_url":"https://api.github.com/repos/phpbb/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpbb/phpbb/downloads","issues_url":"https://api.github.com/repos/phpbb/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/phpbb/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/phpbb/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/phpbb/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpbb/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/phpbb/phpbb/releases{/id}","created_at":"2010-03-01T22:33:17Z","updated_at":"2015-02-09T16:14:01Z","pushed_at":"2015-02-09T16:14:00Z","git_url":"git://github.com/phpbb/phpbb.git","ssh_url":"git@github.com:phpbb/phpbb.git","clone_url":"https://github.com/phpbb/phpbb.git","svn_url":"https://github.com/phpbb/phpbb","homepage":"http://www.phpbb.com","size":101840,"stargazers_count":714,"watchers_count":714,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":420,"mirror_url":null,"open_issues_count":67,"forks":420,"open_issues":67,"watchers":714,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/3386"},"html":{"href":"https://github.com/phpbb/phpbb/pull/3386"},"issue":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/3386"},"comments":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/3386/comments"},"review_comments":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/3386/comments"},"review_comment":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/3386/commits"},"statuses":{"href":"https://api.github.com/repos/phpbb/phpbb/statuses/5294f654926b032c728de3c99205c0f0715fae22"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":62,"deletions":1,"changed_files":5}}