{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/membership-frontend/issues/189","labels_url":"https://api.github.com/repos/guardian/membership-frontend/issues/189/labels{/name}","comments_url":"https://api.github.com/repos/guardian/membership-frontend/issues/189/comments","events_url":"https://api.github.com/repos/guardian/membership-frontend/issues/189/events","html_url":"https://github.com/guardian/membership-frontend/pull/189","id":57461452,"number":189,"title":"Remove code to stop partners from upgrading from events","user":{"login":"davidrapson","id":123386,"avatar_url":"https://avatars.githubusercontent.com/u/123386?v=3","gravatar_id":"","url":"https://api.github.com/users/davidrapson","html_url":"https://github.com/davidrapson","followers_url":"https://api.github.com/users/davidrapson/followers","following_url":"https://api.github.com/users/davidrapson/following{/other_user}","gists_url":"https://api.github.com/users/davidrapson/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrapson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrapson/subscriptions","organizations_url":"https://api.github.com/users/davidrapson/orgs","repos_url":"https://api.github.com/users/davidrapson/repos","events_url":"https://api.github.com/users/davidrapson/events{/privacy}","received_events_url":"https://api.github.com/users/davidrapson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-12T13:43:27Z","updated_at":"2015-02-16T15:33:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/guardian/membership-frontend/pulls/189","html_url":"https://github.com/guardian/membership-frontend/pull/189","diff_url":"https://github.com/guardian/membership-frontend/pull/189.diff","patch_url":"https://github.com/guardian/membership-frontend/pull/189.patch"},"body":"**Dependant on PR** https://github.com/guardian/membership-frontend/pull/181\r\n\r\n- Removes code to stop partners from upgrading from events\r\n- Fixes a bug where the become a member / upgrade button didn't show in the header (button was only available in the sidebar)\r\n\r\nScreenshots are from a test event which is only available to Patrons\r\n\r\n**Signed out**\r\n\r\n![signed-out](https://cloud.githubusercontent.com/assets/123386/6168353/8e4339ea-b2bc-11e4-9514-181945b126b1.png)\r\n\r\n**Signed in as partner**\r\n![partner](https://cloud.githubusercontent.com/assets/123386/6168392/e7cdf2de-b2bc-11e4-9f6e-3271adc56830.png)\r\n\r\n**Signed in as patron**\r\n![patron](https://cloud.githubusercontent.com/assets/123386/6168396/ef5d2c90-b2bc-11e4-8e0e-da0a5678b88d.png)\r\n\r\nLooking through this code, I think the approach in the JS could be simplified to only manipulate one button (rather than the two needed now) and to remove some of the coupling to specific tiers, possibly remove `component` too. It feels like there's a simpler way to reason about this.\r\n\r\nThis PR, however, makes the minimum changes to remove the upgrade restriction."},"comment":{"url":"https://api.github.com/repos/guardian/membership-frontend/issues/comments/74525687","html_url":"https://github.com/guardian/membership-frontend/pull/189#issuecomment-74525687","issue_url":"https://api.github.com/repos/guardian/membership-frontend/issues/189","id":74525687,"user":{"login":"feedmypixel","id":2305016,"avatar_url":"https://avatars.githubusercontent.com/u/2305016?v=3","gravatar_id":"","url":"https://api.github.com/users/feedmypixel","html_url":"https://github.com/feedmypixel","followers_url":"https://api.github.com/users/feedmypixel/followers","following_url":"https://api.github.com/users/feedmypixel/following{/other_user}","gists_url":"https://api.github.com/users/feedmypixel/gists{/gist_id}","starred_url":"https://api.github.com/users/feedmypixel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedmypixel/subscriptions","organizations_url":"https://api.github.com/users/feedmypixel/orgs","repos_url":"https://api.github.com/users/feedmypixel/repos","events_url":"https://api.github.com/users/feedmypixel/events{/privacy}","received_events_url":"https://api.github.com/users/feedmypixel/received_events","type":"User","site_admin":false},"created_at":"2015-02-16T15:33:53Z","updated_at":"2015-02-16T15:33:53Z","body":":+1: good tidy up"}}