{"action":"created","comment":{"url":"https://api.github.com/repos/atom/atom-shell/pulls/comments/22748864","id":22748864,"diff_hunk":"@@ -74,11 +74,13 @@ app.once 'ready', ->\n \n   BrowserWindow.addDevToolsExtension = (srcDirectory) ->\n     extensionInfo = getExtensionInfoFromPath srcDirectory\n-    window._loadDevToolsExtensions [extensionInfo] for window in BrowserWindow.getAllWindows()\n-    extensionInfo.name\n+    if extensionInfo\n+      window._loadDevToolsExtensions [extensionInfo] for window in BrowserWindow.getAllWindows()\n+      return extensionInfo.name\n \n   BrowserWindow.removeDevToolsExtension = (name) ->\n     delete extensionInfoMap[name]\n+    extensionInfoMap = extensionInfoMap","path":"atom/browser/lib/chrome-extension.coffee","position":null,"original_position":21,"commit_id":"c0f0f4cdc6d169e0f98ba3d95adf0e7f8495e4a4","original_commit_id":"d987af24b65963a8511afbe5f939a64cb84e605b","user":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"body":"missed to remove that while doing some logging.. thanks","created_at":"2015-01-09T22:45:12Z","updated_at":"2015-01-09T22:45:12Z","html_url":"https://github.com/atom/atom-shell/pull/990#discussion_r22748864","pull_request_url":"https://api.github.com/repos/atom/atom-shell/pulls/990","_links":{"self":{"href":"https://api.github.com/repos/atom/atom-shell/pulls/comments/22748864"},"html":{"href":"https://github.com/atom/atom-shell/pull/990#discussion_r22748864"},"pull_request":{"href":"https://api.github.com/repos/atom/atom-shell/pulls/990"}}},"pull_request":{"url":"https://api.github.com/repos/atom/atom-shell/pulls/990","id":27099293,"html_url":"https://github.com/atom/atom-shell/pull/990","diff_url":"https://github.com/atom/atom-shell/pull/990.diff","patch_url":"https://github.com/atom/atom-shell/pull/990.patch","issue_url":"https://api.github.com/repos/atom/atom-shell/issues/990","number":990,"state":"open","locked":false,"title":"ensuring single instance for loading and unloading extension","user":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"body":"Fixes #988 Also extensions were not unloaded previously after calling `removeDevToolsExtension` . Works now.","created_at":"2015-01-09T13:22:21Z","updated_at":"2015-01-09T22:45:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4561292df4ccab900b1d38e6ae9447ada32c4899","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/atom-shell/pulls/990/commits","review_comments_url":"https://api.github.com/repos/atom/atom-shell/pulls/990/comments","review_comment_url":"https://api.github.com/repos/atom/atom-shell/pulls/comments/{number}","comments_url":"https://api.github.com/repos/atom/atom-shell/issues/990/comments","statuses_url":"https://api.github.com/repos/atom/atom-shell/statuses/c0f0f4cdc6d169e0f98ba3d95adf0e7f8495e4a4","head":{"label":"deepak1556:chrome_extension_patch","ref":"chrome_extension_patch","sha":"c0f0f4cdc6d169e0f98ba3d95adf0e7f8495e4a4","user":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"repo":{"id":19500833,"name":"atom-shell","full_name":"deepak1556/atom-shell","owner":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deepak1556/atom-shell","description":"Cross-platform desktop application shell","fork":true,"url":"https://api.github.com/repos/deepak1556/atom-shell","forks_url":"https://api.github.com/repos/deepak1556/atom-shell/forks","keys_url":"https://api.github.com/repos/deepak1556/atom-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deepak1556/atom-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deepak1556/atom-shell/teams","hooks_url":"https://api.github.com/repos/deepak1556/atom-shell/hooks","issue_events_url":"https://api.github.com/repos/deepak1556/atom-shell/issues/events{/number}","events_url":"https://api.github.com/repos/deepak1556/atom-shell/events","assignees_url":"https://api.github.com/repos/deepak1556/atom-shell/assignees{/user}","branches_url":"https://api.github.com/repos/deepak1556/atom-shell/branches{/branch}","tags_url":"https://api.github.com/repos/deepak1556/atom-shell/tags","blobs_url":"https://api.github.com/repos/deepak1556/atom-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deepak1556/atom-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deepak1556/atom-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/deepak1556/atom-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deepak1556/atom-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/deepak1556/atom-shell/languages","stargazers_url":"https://api.github.com/repos/deepak1556/atom-shell/stargazers","contributors_url":"https://api.github.com/repos/deepak1556/atom-shell/contributors","subscribers_url":"https://api.github.com/repos/deepak1556/atom-shell/subscribers","subscription_url":"https://api.github.com/repos/deepak1556/atom-shell/subscription","commits_url":"https://api.github.com/repos/deepak1556/atom-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/deepak1556/atom-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/deepak1556/atom-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/deepak1556/atom-shell/issues/comments/{number}","contents_url":"https://api.github.com/repos/deepak1556/atom-shell/contents/{+path}","compare_url":"https://api.github.com/repos/deepak1556/atom-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deepak1556/atom-shell/merges","archive_url":"https://api.github.com/repos/deepak1556/atom-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deepak1556/atom-shell/downloads","issues_url":"https://api.github.com/repos/deepak1556/atom-shell/issues{/number}","pulls_url":"https://api.github.com/repos/deepak1556/atom-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/deepak1556/atom-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/deepak1556/atom-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deepak1556/atom-shell/labels{/name}","releases_url":"https://api.github.com/repos/deepak1556/atom-shell/releases{/id}","created_at":"2014-05-06T15:58:25Z","updated_at":"2015-01-09T13:15:44Z","pushed_at":"2015-01-09T22:43:11Z","git_url":"git://github.com/deepak1556/atom-shell.git","ssh_url":"git@github.com:deepak1556/atom-shell.git","clone_url":"https://github.com/deepak1556/atom-shell.git","svn_url":"https://github.com/deepak1556/atom-shell","homepage":"","size":2961,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"b83f042363a91736862381b52b6b4d061da39a84","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"name":"atom-shell","full_name":"atom/atom-shell","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/atom-shell","description":"Cross-platform desktop application shell","fork":false,"url":"https://api.github.com/repos/atom/atom-shell","forks_url":"https://api.github.com/repos/atom/atom-shell/forks","keys_url":"https://api.github.com/repos/atom/atom-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/atom-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/atom-shell/teams","hooks_url":"https://api.github.com/repos/atom/atom-shell/hooks","issue_events_url":"https://api.github.com/repos/atom/atom-shell/issues/events{/number}","events_url":"https://api.github.com/repos/atom/atom-shell/events","assignees_url":"https://api.github.com/repos/atom/atom-shell/assignees{/user}","branches_url":"https://api.github.com/repos/atom/atom-shell/branches{/branch}","tags_url":"https://api.github.com/repos/atom/atom-shell/tags","blobs_url":"https://api.github.com/repos/atom/atom-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/atom-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/atom-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/atom-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/atom-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/atom-shell/languages","stargazers_url":"https://api.github.com/repos/atom/atom-shell/stargazers","contributors_url":"https://api.github.com/repos/atom/atom-shell/contributors","subscribers_url":"https://api.github.com/repos/atom/atom-shell/subscribers","subscription_url":"https://api.github.com/repos/atom/atom-shell/subscription","commits_url":"https://api.github.com/repos/atom/atom-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/atom-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/atom-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/atom-shell/issues/comments/{number}","contents_url":"https://api.github.com/repos/atom/atom-shell/contents/{+path}","compare_url":"https://api.github.com/repos/atom/atom-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/atom-shell/merges","archive_url":"https://api.github.com/repos/atom/atom-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/atom-shell/downloads","issues_url":"https://api.github.com/repos/atom/atom-shell/issues{/number}","pulls_url":"https://api.github.com/repos/atom/atom-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/atom-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/atom-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/atom-shell/labels{/name}","releases_url":"https://api.github.com/repos/atom/atom-shell/releases{/id}","created_at":"2013-04-12T01:47:36Z","updated_at":"2015-01-09T20:47:01Z","pushed_at":"2015-01-08T21:12:16Z","git_url":"git://github.com/atom/atom-shell.git","ssh_url":"git@github.com:atom/atom-shell.git","clone_url":"https://github.com/atom/atom-shell.git","svn_url":"https://github.com/atom/atom-shell","homepage":"","size":13661,"stargazers_count":5000,"watchers_count":5000,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":379,"mirror_url":null,"open_issues_count":104,"forks":379,"open_issues":104,"watchers":5000,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/atom-shell/pulls/990"},"html":{"href":"https://github.com/atom/atom-shell/pull/990"},"issue":{"href":"https://api.github.com/repos/atom/atom-shell/issues/990"},"comments":{"href":"https://api.github.com/repos/atom/atom-shell/issues/990/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/atom-shell/pulls/990/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/atom-shell/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/atom/atom-shell/pulls/990/commits"},"statuses":{"href":"https://api.github.com/repos/atom/atom-shell/statuses/c0f0f4cdc6d169e0f98ba3d95adf0e7f8495e4a4"}}}}