{"action":"created","issue":{"url":"https://api.github.com/repos/acdlite/flummox/issues/181","labels_url":"https://api.github.com/repos/acdlite/flummox/issues/181/labels{/name}","comments_url":"https://api.github.com/repos/acdlite/flummox/issues/181/comments","events_url":"https://api.github.com/repos/acdlite/flummox/issues/181/events","html_url":"https://github.com/acdlite/flummox/pull/181","id":74001996,"number":181,"title":"Support for React Native","user":{"login":"acdlite","id":3624098,"avatar_url":"https://avatars.githubusercontent.com/u/3624098?v=3","gravatar_id":"","url":"https://api.github.com/users/acdlite","html_url":"https://github.com/acdlite","followers_url":"https://api.github.com/users/acdlite/followers","following_url":"https://api.github.com/users/acdlite/following{/other_user}","gists_url":"https://api.github.com/users/acdlite/gists{/gist_id}","starred_url":"https://api.github.com/users/acdlite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdlite/subscriptions","organizations_url":"https://api.github.com/users/acdlite/orgs","repos_url":"https://api.github.com/users/acdlite/repos","events_url":"https://api.github.com/users/acdlite/events{/privacy}","received_events_url":"https://api.github.com/users/acdlite/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-07T14:15:35Z","updated_at":"2015-05-07T20:28:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/acdlite/flummox/pulls/181","html_url":"https://github.com/acdlite/flummox/pull/181","diff_url":"https://github.com/acdlite/flummox/pull/181.diff","patch_url":"https://github.com/acdlite/flummox/pull/181.patch"},"body":"Addons that depend on React need to work for either React or React Native. To support both, addons have been refactored to export a function that takes React as a parameter and returns the addon.\r\n\r\n(Edit: to clarify, the wrapping function is only used internally. The module exposed to the consumer exports the addon itself, as expected.)\r\n\r\nAddons should now be imported like so:\r\n\r\n```js\r\nimport { FluxComponent } from 'flummox/addons/react';\r\nimport { FluxComponent } from 'flummox/addons/react-native';\r\n```\r\n\r\nFor convenience, addons for regular React can still be imported the old way using `flummox/component`, `flummox/mixin`, etc."},"comment":{"url":"https://api.github.com/repos/acdlite/flummox/issues/comments/100008794","html_url":"https://github.com/acdlite/flummox/pull/181#issuecomment-100008794","issue_url":"https://api.github.com/repos/acdlite/flummox/issues/181","id":100008794,"user":{"login":"johanneslumpe","id":3470207,"avatar_url":"https://avatars.githubusercontent.com/u/3470207?v=3","gravatar_id":"","url":"https://api.github.com/users/johanneslumpe","html_url":"https://github.com/johanneslumpe","followers_url":"https://api.github.com/users/johanneslumpe/followers","following_url":"https://api.github.com/users/johanneslumpe/following{/other_user}","gists_url":"https://api.github.com/users/johanneslumpe/gists{/gist_id}","starred_url":"https://api.github.com/users/johanneslumpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanneslumpe/subscriptions","organizations_url":"https://api.github.com/users/johanneslumpe/orgs","repos_url":"https://api.github.com/users/johanneslumpe/repos","events_url":"https://api.github.com/users/johanneslumpe/events{/privacy}","received_events_url":"https://api.github.com/users/johanneslumpe/received_events","type":"User","site_admin":false},"created_at":"2015-05-07T20:28:03Z","updated_at":"2015-05-07T20:28:03Z","body":"Ok so I tried and got it running now, but a few things:\r\n\r\nDuring `npm install` it will also install `react`, which leads to issues. As this only happens when cloning from Github it it probably a non-issue, just wanted to mention it here. Only after manually removing the folder again, it started to work - somewhat.\r\n\r\nI had to import/require the `FluxComponent` from `flummox/lib/addons/react-native` instead of the proposed `flummox/addons/react-native` - that might have been an issue on my part not properly checking the correct paths when opening up the PR for rn-support.\r\n\r\nAnd then there is this tiny Typo, where `fluxMixin` is written with an uppercase F instead of lowercase. I'll also mark that in the diff.\r\n\r\nApart from that it seems that this works :) :+1: I could at least run my dummy app and it loaded data into stores just fine etc. Also the FluxComponent was working fine.\r\n"}}