{"action":"closed","number":25,"pull_request":{"url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/pulls/25","id":31127791,"html_url":"https://github.com/dwilhelm89/LeafletSlider/pull/25","diff_url":"https://github.com/dwilhelm89/LeafletSlider/pull/25.diff","patch_url":"https://github.com/dwilhelm89/LeafletSlider/pull/25.patch","issue_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/issues/25","number":25,"state":"closed","locked":false,"title":"Fix markers array's indexes and slider bounds","user":{"login":"juliensoret","id":9967599,"avatar_url":"https://avatars.githubusercontent.com/u/9967599?v=3","gravatar_id":"","url":"https://api.github.com/users/juliensoret","html_url":"https://github.com/juliensoret","followers_url":"https://api.github.com/users/juliensoret/followers","following_url":"https://api.github.com/users/juliensoret/following{/other_user}","gists_url":"https://api.github.com/users/juliensoret/gists{/gist_id}","starred_url":"https://api.github.com/users/juliensoret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliensoret/subscriptions","organizations_url":"https://api.github.com/users/juliensoret/orgs","repos_url":"https://api.github.com/users/juliensoret/repos","events_url":"https://api.github.com/users/juliensoret/events{/privacy}","received_events_url":"https://api.github.com/users/juliensoret/received_events","type":"User","site_admin":false},"body":"The problem was\r\nThe slider first step was the first marker. But the next step didn't display any. ( mentioned here : https://github.com/dwilhelm89/LeafletSlider/issues/20 )\r\nThat's because the indexes of the options.markers[ ] are 24 to 24+X (with X=markers number) but with 25 empty. \r\nI changed it to 0 to X-1 like a normal array by incrementing a variable. No hole in the array anymore.\r\n\r\nCurrent version : http://kara.62.free.fr/slider_fixbounds/old.html\r\nDemo with fix : http://kara.62.free.fr/slider_fixbounds/","created_at":"2015-03-13T14:01:44Z","updated_at":"2015-03-13T16:42:28Z","closed_at":"2015-03-13T16:42:28Z","merged_at":"2015-03-13T16:42:28Z","merge_commit_sha":"9865e5e5d96843f9db66558c792d0f61c3e401b4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/pulls/25/commits","review_comments_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/pulls/25/comments","review_comment_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/issues/25/comments","statuses_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/statuses/d75bf2097c49ddcc2729d7941b6861ab01794b44","head":{"label":"juliensoret:fixSliderBounds","ref":"fixSliderBounds","sha":"d75bf2097c49ddcc2729d7941b6861ab01794b44","user":{"login":"juliensoret","id":9967599,"avatar_url":"https://avatars.githubusercontent.com/u/9967599?v=3","gravatar_id":"","url":"https://api.github.com/users/juliensoret","html_url":"https://github.com/juliensoret","followers_url":"https://api.github.com/users/juliensoret/followers","following_url":"https://api.github.com/users/juliensoret/following{/other_user}","gists_url":"https://api.github.com/users/juliensoret/gists{/gist_id}","starred_url":"https://api.github.com/users/juliensoret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliensoret/subscriptions","organizations_url":"https://api.github.com/users/juliensoret/orgs","repos_url":"https://api.github.com/users/juliensoret/repos","events_url":"https://api.github.com/users/juliensoret/events{/privacy}","received_events_url":"https://api.github.com/users/juliensoret/received_events","type":"User","site_admin":false},"repo":{"id":30544026,"name":"LeafletSlider","full_name":"juliensoret/LeafletSlider","owner":{"login":"juliensoret","id":9967599,"avatar_url":"https://avatars.githubusercontent.com/u/9967599?v=3","gravatar_id":"","url":"https://api.github.com/users/juliensoret","html_url":"https://github.com/juliensoret","followers_url":"https://api.github.com/users/juliensoret/followers","following_url":"https://api.github.com/users/juliensoret/following{/other_user}","gists_url":"https://api.github.com/users/juliensoret/gists{/gist_id}","starred_url":"https://api.github.com/users/juliensoret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliensoret/subscriptions","organizations_url":"https://api.github.com/users/juliensoret/orgs","repos_url":"https://api.github.com/users/juliensoret/repos","events_url":"https://api.github.com/users/juliensoret/events{/privacy}","received_events_url":"https://api.github.com/users/juliensoret/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juliensoret/LeafletSlider","description":"LeafletSlider","fork":true,"url":"https://api.github.com/repos/juliensoret/LeafletSlider","forks_url":"https://api.github.com/repos/juliensoret/LeafletSlider/forks","keys_url":"https://api.github.com/repos/juliensoret/LeafletSlider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juliensoret/LeafletSlider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juliensoret/LeafletSlider/teams","hooks_url":"https://api.github.com/repos/juliensoret/LeafletSlider/hooks","issue_events_url":"https://api.github.com/repos/juliensoret/LeafletSlider/issues/events{/number}","events_url":"https://api.github.com/repos/juliensoret/LeafletSlider/events","assignees_url":"https://api.github.com/repos/juliensoret/LeafletSlider/assignees{/user}","branches_url":"https://api.github.com/repos/juliensoret/LeafletSlider/branches{/branch}","tags_url":"https://api.github.com/repos/juliensoret/LeafletSlider/tags","blobs_url":"https://api.github.com/repos/juliensoret/LeafletSlider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juliensoret/LeafletSlider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juliensoret/LeafletSlider/git/refs{/sha}","trees_url":"https://api.github.com/repos/juliensoret/LeafletSlider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juliensoret/LeafletSlider/statuses/{sha}","languages_url":"https://api.github.com/repos/juliensoret/LeafletSlider/languages","stargazers_url":"https://api.github.com/repos/juliensoret/LeafletSlider/stargazers","contributors_url":"https://api.github.com/repos/juliensoret/LeafletSlider/contributors","subscribers_url":"https://api.github.com/repos/juliensoret/LeafletSlider/subscribers","subscription_url":"https://api.github.com/repos/juliensoret/LeafletSlider/subscription","commits_url":"https://api.github.com/repos/juliensoret/LeafletSlider/commits{/sha}","git_commits_url":"https://api.github.com/repos/juliensoret/LeafletSlider/git/commits{/sha}","comments_url":"https://api.github.com/repos/juliensoret/LeafletSlider/comments{/number}","issue_comment_url":"https://api.github.com/repos/juliensoret/LeafletSlider/issues/comments{/number}","contents_url":"https://api.github.com/repos/juliensoret/LeafletSlider/contents/{+path}","compare_url":"https://api.github.com/repos/juliensoret/LeafletSlider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juliensoret/LeafletSlider/merges","archive_url":"https://api.github.com/repos/juliensoret/LeafletSlider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juliensoret/LeafletSlider/downloads","issues_url":"https://api.github.com/repos/juliensoret/LeafletSlider/issues{/number}","pulls_url":"https://api.github.com/repos/juliensoret/LeafletSlider/pulls{/number}","milestones_url":"https://api.github.com/repos/juliensoret/LeafletSlider/milestones{/number}","notifications_url":"https://api.github.com/repos/juliensoret/LeafletSlider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juliensoret/LeafletSlider/labels{/name}","releases_url":"https://api.github.com/repos/juliensoret/LeafletSlider/releases{/id}","created_at":"2015-02-09T15:59:24Z","updated_at":"2015-03-13T15:37:04Z","pushed_at":"2015-03-13T15:45:12Z","git_url":"git://github.com/juliensoret/LeafletSlider.git","ssh_url":"git@github.com:juliensoret/LeafletSlider.git","clone_url":"https://github.com/juliensoret/LeafletSlider.git","svn_url":"https://github.com/juliensoret/LeafletSlider","homepage":null,"size":175,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dwilhelm89:master","ref":"master","sha":"e96858a685e6ab44dca060a9cd3ff70d04ab0fdb","user":{"login":"dwilhelm89","id":1424069,"avatar_url":"https://avatars.githubusercontent.com/u/1424069?v=3","gravatar_id":"","url":"https://api.github.com/users/dwilhelm89","html_url":"https://github.com/dwilhelm89","followers_url":"https://api.github.com/users/dwilhelm89/followers","following_url":"https://api.github.com/users/dwilhelm89/following{/other_user}","gists_url":"https://api.github.com/users/dwilhelm89/gists{/gist_id}","starred_url":"https://api.github.com/users/dwilhelm89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwilhelm89/subscriptions","organizations_url":"https://api.github.com/users/dwilhelm89/orgs","repos_url":"https://api.github.com/users/dwilhelm89/repos","events_url":"https://api.github.com/users/dwilhelm89/events{/privacy}","received_events_url":"https://api.github.com/users/dwilhelm89/received_events","type":"User","site_admin":false},"repo":{"id":10176967,"name":"LeafletSlider","full_name":"dwilhelm89/LeafletSlider","owner":{"login":"dwilhelm89","id":1424069,"avatar_url":"https://avatars.githubusercontent.com/u/1424069?v=3","gravatar_id":"","url":"https://api.github.com/users/dwilhelm89","html_url":"https://github.com/dwilhelm89","followers_url":"https://api.github.com/users/dwilhelm89/followers","following_url":"https://api.github.com/users/dwilhelm89/following{/other_user}","gists_url":"https://api.github.com/users/dwilhelm89/gists{/gist_id}","starred_url":"https://api.github.com/users/dwilhelm89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwilhelm89/subscriptions","organizations_url":"https://api.github.com/users/dwilhelm89/orgs","repos_url":"https://api.github.com/users/dwilhelm89/repos","events_url":"https://api.github.com/users/dwilhelm89/events{/privacy}","received_events_url":"https://api.github.com/users/dwilhelm89/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dwilhelm89/LeafletSlider","description":"LeafletSlider","fork":false,"url":"https://api.github.com/repos/dwilhelm89/LeafletSlider","forks_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/forks","keys_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/teams","hooks_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/hooks","issue_events_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/issues/events{/number}","events_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/events","assignees_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/assignees{/user}","branches_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/branches{/branch}","tags_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/tags","blobs_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/statuses/{sha}","languages_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/languages","stargazers_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/stargazers","contributors_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/contributors","subscribers_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/subscribers","subscription_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/subscription","commits_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/contents/{+path}","compare_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/merges","archive_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/downloads","issues_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/issues{/number}","pulls_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/pulls{/number}","milestones_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/milestones{/number}","notifications_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/labels{/name}","releases_url":"https://api.github.com/repos/dwilhelm89/LeafletSlider/releases{/id}","created_at":"2013-05-20T16:31:55Z","updated_at":"2015-03-11T20:39:50Z","pushed_at":"2015-03-13T16:42:28Z","git_url":"git://github.com/dwilhelm89/LeafletSlider.git","ssh_url":"git@github.com:dwilhelm89/LeafletSlider.git","clone_url":"https://github.com/dwilhelm89/LeafletSlider.git","svn_url":"https://github.com/dwilhelm89/LeafletSlider","homepage":null,"size":303,"stargazers_count":56,"watchers_count":56,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":2,"forks":38,"open_issues":2,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dwilhelm89/LeafletSlider/pulls/25"},"html":{"href":"https://github.com/dwilhelm89/LeafletSlider/pull/25"},"issue":{"href":"https://api.github.com/repos/dwilhelm89/LeafletSlider/issues/25"},"comments":{"href":"https://api.github.com/repos/dwilhelm89/LeafletSlider/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/dwilhelm89/LeafletSlider/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/dwilhelm89/LeafletSlider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dwilhelm89/LeafletSlider/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/dwilhelm89/LeafletSlider/statuses/d75bf2097c49ddcc2729d7941b6861ab01794b44"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dwilhelm89","id":1424069,"avatar_url":"https://avatars.githubusercontent.com/u/1424069?v=3","gravatar_id":"","url":"https://api.github.com/users/dwilhelm89","html_url":"https://github.com/dwilhelm89","followers_url":"https://api.github.com/users/dwilhelm89/followers","following_url":"https://api.github.com/users/dwilhelm89/following{/other_user}","gists_url":"https://api.github.com/users/dwilhelm89/gists{/gist_id}","starred_url":"https://api.github.com/users/dwilhelm89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwilhelm89/subscriptions","organizations_url":"https://api.github.com/users/dwilhelm89/orgs","repos_url":"https://api.github.com/users/dwilhelm89/repos","events_url":"https://api.github.com/users/dwilhelm89/events{/privacy}","received_events_url":"https://api.github.com/users/dwilhelm89/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":8,"changed_files":1}}