{"action":"created","issue":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/29405","labels_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/29405/labels{/name}","comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/29405/comments","events_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/29405/events","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/29405","id":101744968,"number":29405,"title":"LPS-55355 Shopping portlet fixes","user":{"login":"peterfellwock","id":7771558,"avatar_url":"https://avatars.githubusercontent.com/u/7771558?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfellwock","html_url":"https://github.com/peterfellwock","followers_url":"https://api.github.com/users/peterfellwock/followers","following_url":"https://api.github.com/users/peterfellwock/following{/other_user}","gists_url":"https://api.github.com/users/peterfellwock/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfellwock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfellwock/subscriptions","organizations_url":"https://api.github.com/users/peterfellwock/orgs","repos_url":"https://api.github.com/users/peterfellwock/repos","events_url":"https://api.github.com/users/peterfellwock/events{/privacy}","received_events_url":"https://api.github.com/users/peterfellwock/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-18T20:46:09Z","updated_at":"2015-08-18T21:54:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/29405","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/29405","diff_url":"https://github.com/brianchandotcom/liferay-portal/pull/29405.diff","patch_url":"https://github.com/brianchandotcom/liferay-portal/pull/29405.patch"},"body":"Fixes from [https://github.com/brianchandotcom/liferay-portal/pull/29090]\r\n\r\n1.) 5cba644 removed logic that would remove Shopping data when a group or user is deleted. See UserModelListener and GroupModelListener in calendar-service.\r\n\r\n2.) 368142e has the wrong portlet id. See bookmarks-web on how we fully namespace it.\r\n\r\n3.) ShoppingGroupServiceSettingsOverride and ShoppingGroupServiceSettingsOverrideImpl both have the same constants declared. Please check with other existing use cases. If no one is using the static constants except the impl, keep it private.\r\n\r\n4.) You removed 2 tests in 0212e59 that should not have been removed. See BookmarksEntryPermissionCheckerTest .\r\n\r\n5.) portlet.properties custom.sql.configs= doesn't match any of our other portlets\r\n\r\n6.) We don't have any ConfigurationActionImpl. They're named something else."},"comment":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/comments/132367539","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/29405#issuecomment-132367539","issue_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/29405","id":132367539,"user":{"login":"peterfellwock","id":7771558,"avatar_url":"https://avatars.githubusercontent.com/u/7771558?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfellwock","html_url":"https://github.com/peterfellwock","followers_url":"https://api.github.com/users/peterfellwock/followers","following_url":"https://api.github.com/users/peterfellwock/following{/other_user}","gists_url":"https://api.github.com/users/peterfellwock/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfellwock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfellwock/subscriptions","organizations_url":"https://api.github.com/users/peterfellwock/orgs","repos_url":"https://api.github.com/users/peterfellwock/repos","events_url":"https://api.github.com/users/peterfellwock/events{/privacy}","received_events_url":"https://api.github.com/users/peterfellwock/received_events","type":"User","site_admin":false},"created_at":"2015-08-18T21:54:03Z","updated_at":"2015-08-18T21:54:03Z","body":"ci:retest"}}