{"action":"created","issue":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4550","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4550/labels{/name}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4550/comments","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4550/events","html_url":"https://github.com/silverstripe/silverstripe-framework/issues/4550","id":103552310,"number":4550,"title":"NumericField number type not accept comma value","user":{"login":"hutlim","id":11241138,"avatar_url":"https://avatars.githubusercontent.com/u/11241138?v=3","gravatar_id":"","url":"https://api.github.com/users/hutlim","html_url":"https://github.com/hutlim","followers_url":"https://api.github.com/users/hutlim/followers","following_url":"https://api.github.com/users/hutlim/following{/other_user}","gists_url":"https://api.github.com/users/hutlim/gists{/gist_id}","starred_url":"https://api.github.com/users/hutlim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hutlim/subscriptions","organizations_url":"https://api.github.com/users/hutlim/orgs","repos_url":"https://api.github.com/users/hutlim/repos","events_url":"https://api.github.com/users/hutlim/events{/privacy}","received_events_url":"https://api.github.com/users/hutlim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-27T16:58:22Z","updated_at":"2015-08-27T17:00:41Z","closed_at":null,"body":"After change input type to number, it's unable to display the value which contain the comma like 1,000.00\r\n\r\n```\r\npublic function setValue($value, $data = array()) {\r\n\trequire_once \"Zend/Locale/Format.php\";\r\n\r\n\t// If passing in a non-string number, or a value\r\n\t// directly from a DataObject then localise this number\r\n\r\n\tif(is_int($value) || is_float($value) || $data instanceof DataObject) {\r\n\t\t$locale = new Zend_Locale($this->getLocale());\r\n\r\n\t\t$this->value = Zend_Locale_Format::toNumber(\r\n\t\t\t$value,\r\n\t\t\tarray('locale' => $locale)\r\n\t\t);\r\n\t} else {\r\n\t\t$this->value = $this->clean($value);\r\n\t}\r\n\r\n\treturn $this;\r\n}\r\n```\r\n\r\n```\r\npublic function getAttributes() {\r\n\treturn array_merge(parent::getAttributes(), array(\r\n\t\t'type' => 'number',\r\n\t\t'step' => 'any' // allows entering float/decimal numbers like \"1.2\" instead of just integers\r\n\t));\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments/135493202","html_url":"https://github.com/silverstripe/silverstripe-framework/issues/4550#issuecomment-135493202","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4550","id":135493202,"user":{"login":"dhensby","id":563596,"avatar_url":"https://avatars.githubusercontent.com/u/563596?v=3","gravatar_id":"","url":"https://api.github.com/users/dhensby","html_url":"https://github.com/dhensby","followers_url":"https://api.github.com/users/dhensby/followers","following_url":"https://api.github.com/users/dhensby/following{/other_user}","gists_url":"https://api.github.com/users/dhensby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhensby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhensby/subscriptions","organizations_url":"https://api.github.com/users/dhensby/orgs","repos_url":"https://api.github.com/users/dhensby/repos","events_url":"https://api.github.com/users/dhensby/events{/privacy}","received_events_url":"https://api.github.com/users/dhensby/received_events","type":"User","site_admin":false},"created_at":"2015-08-27T17:00:41Z","updated_at":"2015-08-27T17:00:41Z","body":"Which version of SS; @tractorcow did some work on supporting this a while ago now..."}}