{"action":"created","issue":{"url":"https://api.github.com/repos/mjackson/npm-http-server/issues/10","labels_url":"https://api.github.com/repos/mjackson/npm-http-server/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/mjackson/npm-http-server/issues/10/comments","events_url":"https://api.github.com/repos/mjackson/npm-http-server/issues/10/events","html_url":"https://github.com/mjackson/npm-http-server/pull/10","id":118085442,"number":10,"title":"Rtorr webpack build","user":{"login":"rtorr","id":297045,"avatar_url":"https://avatars.githubusercontent.com/u/297045?v=3","gravatar_id":"","url":"https://api.github.com/users/rtorr","html_url":"https://github.com/rtorr","followers_url":"https://api.github.com/users/rtorr/followers","following_url":"https://api.github.com/users/rtorr/following{/other_user}","gists_url":"https://api.github.com/users/rtorr/gists{/gist_id}","starred_url":"https://api.github.com/users/rtorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtorr/subscriptions","organizations_url":"https://api.github.com/users/rtorr/orgs","repos_url":"https://api.github.com/users/rtorr/repos","events_url":"https://api.github.com/users/rtorr/events{/privacy}","received_events_url":"https://api.github.com/users/rtorr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-11-20T17:16:20Z","updated_at":"2015-12-22T17:14:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mjackson/npm-http-server/pulls/10","html_url":"https://github.com/mjackson/npm-http-server/pull/10","diff_url":"https://github.com/mjackson/npm-http-server/pull/10.diff","patch_url":"https://github.com/mjackson/npm-http-server/pull/10.patch"},"body":"Moved this to a pull request for ideas, feedback, and code review.\r\n\r\nIts been literal years since I have worked with express, so there could maybe be a better way to handle things. I didn't have much time after work to implement this, so I know it's crude. Also, we could probably not serve the `packages` directory with express, and do that on the web server level (if there is one). \r\n\r\nSo some notes:\r\n\r\n- npm v2 is much easier to use because it will install peer dependencies.\r\n- I am deleting the `packaged/node_modules` directory after every successful build.\r\n- I could not find a way to dynamically create a node_modules path better than what is implemented, which added some constraints, and I assume some edge cases later on https://twitter.com/richardiii/status/667488434131374080. \r\n- no tests\r\n- there could be potential problems when two or more users are creating a new package. this could be solved with dynamic node_module paths (check if package exists first, then build) and we could remove their node_modules to save space after the build. \r\n- Design\r\n- is it ok that I brought in ejs? I am open to whatever people like.\r\n\r\nTo take a look. Load up my [branch](https://github.com/mjackson/npm-http-server/tree/rtorr-webpack-build), and go to `http://localhost:5000/package/immutable`.\r\n"},"comment":{"url":"https://api.github.com/repos/mjackson/npm-http-server/issues/comments/166677810","html_url":"https://github.com/mjackson/npm-http-server/pull/10#issuecomment-166677810","issue_url":"https://api.github.com/repos/mjackson/npm-http-server/issues/10","id":166677810,"user":{"login":"rtorr","id":297045,"avatar_url":"https://avatars.githubusercontent.com/u/297045?v=3","gravatar_id":"","url":"https://api.github.com/users/rtorr","html_url":"https://github.com/rtorr","followers_url":"https://api.github.com/users/rtorr/followers","following_url":"https://api.github.com/users/rtorr/following{/other_user}","gists_url":"https://api.github.com/users/rtorr/gists{/gist_id}","starred_url":"https://api.github.com/users/rtorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtorr/subscriptions","organizations_url":"https://api.github.com/users/rtorr/orgs","repos_url":"https://api.github.com/users/rtorr/repos","events_url":"https://api.github.com/users/rtorr/events{/privacy}","received_events_url":"https://api.github.com/users/rtorr/received_events","type":"User","site_admin":false},"created_at":"2015-12-22T17:14:35Z","updated_at":"2015-12-22T17:14:35Z","body":"FYI: This pull request is not dead. I hope to work on this over the holiday break. Have some good ideas :tada: "}}