{"action":"created","issue":{"url":"https://api.github.com/repos/exercism/xecmascript/issues/178","labels_url":"https://api.github.com/repos/exercism/xecmascript/issues/178/labels{/name}","comments_url":"https://api.github.com/repos/exercism/xecmascript/issues/178/comments","events_url":"https://api.github.com/repos/exercism/xecmascript/issues/178/events","html_url":"https://github.com/exercism/xecmascript/pull/178","id":123364670,"number":178,"title":"Make it simple how to test the whole song","user":{"login":"rchavarria","id":612688,"avatar_url":"https://avatars.githubusercontent.com/u/612688?v=3","gravatar_id":"","url":"https://api.github.com/users/rchavarria","html_url":"https://github.com/rchavarria","followers_url":"https://api.github.com/users/rchavarria/followers","following_url":"https://api.github.com/users/rchavarria/following{/other_user}","gists_url":"https://api.github.com/users/rchavarria/gists{/gist_id}","starred_url":"https://api.github.com/users/rchavarria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchavarria/subscriptions","organizations_url":"https://api.github.com/users/rchavarria/orgs","repos_url":"https://api.github.com/users/rchavarria/repos","events_url":"https://api.github.com/users/rchavarria/events{/privacy}","received_events_url":"https://api.github.com/users/rchavarria/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-12-21T21:41:47Z","updated_at":"2015-12-25T15:16:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/exercism/xecmascript/pulls/178","html_url":"https://github.com/exercism/xecmascript/pull/178","diff_url":"https://github.com/exercism/xecmascript/pull/178.diff","patch_url":"https://github.com/exercism/xecmascript/pull/178.patch"},"body":"The test is not as complete as the existing one. It doesn't test the complete verses. But it relies on previous tests.\r\n\r\nIt just tests two things:\r\n\r\n1. There are almost 100 verses starting with `XX bottles of beer on the wall`\r\n2. The song consist of `3 * 100` lines, 3 lines each verse, 100 verses\r\n\r\n@matthewmorgan Feel free to discuss this implementation. It's simpler than the existing one, but you may prefer a more complete version than mine. That's ok."},"comment":{"url":"https://api.github.com/repos/exercism/xecmascript/issues/comments/167244698","html_url":"https://github.com/exercism/xecmascript/pull/178#issuecomment-167244698","issue_url":"https://api.github.com/repos/exercism/xecmascript/issues/178","id":167244698,"user":{"login":"rchavarria","id":612688,"avatar_url":"https://avatars.githubusercontent.com/u/612688?v=3","gravatar_id":"","url":"https://api.github.com/users/rchavarria","html_url":"https://github.com/rchavarria","followers_url":"https://api.github.com/users/rchavarria/followers","following_url":"https://api.github.com/users/rchavarria/following{/other_user}","gists_url":"https://api.github.com/users/rchavarria/gists{/gist_id}","starred_url":"https://api.github.com/users/rchavarria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchavarria/subscriptions","organizations_url":"https://api.github.com/users/rchavarria/orgs","repos_url":"https://api.github.com/users/rchavarria/repos","events_url":"https://api.github.com/users/rchavarria/events{/privacy}","received_events_url":"https://api.github.com/users/rchavarria/received_events","type":"User","site_admin":false},"created_at":"2015-12-25T15:16:59Z","updated_at":"2015-12-25T15:16:59Z","body":"It could work on Travis, but exercism users would also need that dependency. We have two options:\r\n\r\n1. Include that dependency on every `package.json` file (we're not able to customize that file for each exercise yet -- see XXX)\r\n2. Include the CryptoJS code in the exercise folder. It will be deployed to users machines, and tests would include it as a module (`import CryptoJS from './crypto.js'`). \r\n\r\nIf CryptoJS has more dependencies, second option could be more and more complicated. I would go for the first one for now."}}