{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/28739384","id":28739384,"diff_hunk":"@@ -1,4 +1,6 @@\n-{ stdenv, fetchurl }:\n+# in geoip-database, you can insert a package defining ${geoip-database}/share/GeoIP\n+# e.g. geolite-legacy\n+{ stdenv, fetchurl, pkgs, geoip-database ? null }:","path":"pkgs/development/libraries/geoip/default.nix","position":4,"original_position":4,"commit_id":"ea5215201a0785dc925416718ed1559baa658433","original_commit_id":"ea5215201a0785dc925416718ed1559baa658433","user":{"login":"nckx","id":364510,"avatar_url":"https://avatars.githubusercontent.com/u/364510?v=3","gravatar_id":"","url":"https://api.github.com/users/nckx","html_url":"https://github.com/nckx","followers_url":"https://api.github.com/users/nckx/followers","following_url":"https://api.github.com/users/nckx/following{/other_user}","gists_url":"https://api.github.com/users/nckx/gists{/gist_id}","starred_url":"https://api.github.com/users/nckx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nckx/subscriptions","organizations_url":"https://api.github.com/users/nckx/orgs","repos_url":"https://api.github.com/users/nckx/repos","events_url":"https://api.github.com/users/nckx/events{/privacy}","received_events_url":"https://api.github.com/users/nckx/received_events","type":"User","site_admin":false},"body":"Nix convention is to use camelCase for this: `geoipDatabase`.","created_at":"2015-04-20T23:43:26Z","updated_at":"2015-04-20T23:43:26Z","html_url":"https://github.com/NixOS/nixpkgs/pull/7401#discussion_r28739384","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7401","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/28739384"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/7401#discussion_r28739384"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7401"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7401","id":33398542,"html_url":"https://github.com/NixOS/nixpkgs/pull/7401","diff_url":"https://github.com/NixOS/nixpkgs/pull/7401.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/7401.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/7401","number":7401,"state":"open","locked":false,"title":"geoip: Install geolite database by default","user":{"login":"bendlas","id":214787,"avatar_url":"https://avatars.githubusercontent.com/u/214787?v=3","gravatar_id":"","url":"https://api.github.com/users/bendlas","html_url":"https://github.com/bendlas","followers_url":"https://api.github.com/users/bendlas/followers","following_url":"https://api.github.com/users/bendlas/following{/other_user}","gists_url":"https://api.github.com/users/bendlas/gists{/gist_id}","starred_url":"https://api.github.com/users/bendlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendlas/subscriptions","organizations_url":"https://api.github.com/users/bendlas/orgs","repos_url":"https://api.github.com/users/bendlas/repos","events_url":"https://api.github.com/users/bendlas/events{/privacy}","received_events_url":"https://api.github.com/users/bendlas/received_events","type":"User","site_admin":false},"body":"This makes the geoiplookup command work without special parameters and\r\nit establishes a directory that is mentioned in the man page.\r\n(/nix/store/*geoip*/share/GeoIP/)\r\n\r\n@7c6f434c","created_at":"2015-04-15T21:30:33Z","updated_at":"2015-04-20T23:43:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e29e749f252c9b84af3d6dc7f5fb3f43114b28ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7401/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7401/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/7401/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/ea5215201a0785dc925416718ed1559baa658433","head":{"label":"bendlas:geoip-database","ref":"geoip-database","sha":"ea5215201a0785dc925416718ed1559baa658433","user":{"login":"bendlas","id":214787,"avatar_url":"https://avatars.githubusercontent.com/u/214787?v=3","gravatar_id":"","url":"https://api.github.com/users/bendlas","html_url":"https://github.com/bendlas","followers_url":"https://api.github.com/users/bendlas/followers","following_url":"https://api.github.com/users/bendlas/following{/other_user}","gists_url":"https://api.github.com/users/bendlas/gists{/gist_id}","starred_url":"https://api.github.com/users/bendlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendlas/subscriptions","organizations_url":"https://api.github.com/users/bendlas/orgs","repos_url":"https://api.github.com/users/bendlas/repos","events_url":"https://api.github.com/users/bendlas/events{/privacy}","received_events_url":"https://api.github.com/users/bendlas/received_events","type":"User","site_admin":false},"repo":{"id":29099913,"name":"nixpkgs","full_name":"bendlas/nixpkgs","owner":{"login":"bendlas","id":214787,"avatar_url":"https://avatars.githubusercontent.com/u/214787?v=3","gravatar_id":"","url":"https://api.github.com/users/bendlas","html_url":"https://github.com/bendlas","followers_url":"https://api.github.com/users/bendlas/followers","following_url":"https://api.github.com/users/bendlas/following{/other_user}","gists_url":"https://api.github.com/users/bendlas/gists{/gist_id}","starred_url":"https://api.github.com/users/bendlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendlas/subscriptions","organizations_url":"https://api.github.com/users/bendlas/orgs","repos_url":"https://api.github.com/users/bendlas/repos","events_url":"https://api.github.com/users/bendlas/events{/privacy}","received_events_url":"https://api.github.com/users/bendlas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bendlas/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/bendlas/nixpkgs","forks_url":"https://api.github.com/repos/bendlas/nixpkgs/forks","keys_url":"https://api.github.com/repos/bendlas/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bendlas/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bendlas/nixpkgs/teams","hooks_url":"https://api.github.com/repos/bendlas/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/bendlas/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/bendlas/nixpkgs/events","assignees_url":"https://api.github.com/repos/bendlas/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/bendlas/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/bendlas/nixpkgs/tags","blobs_url":"https://api.github.com/repos/bendlas/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bendlas/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bendlas/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bendlas/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bendlas/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/bendlas/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/bendlas/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/bendlas/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/bendlas/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/bendlas/nixpkgs/subscription","commits_url":"https://api.github.com/repos/bendlas/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bendlas/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bendlas/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bendlas/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/bendlas/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/bendlas/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bendlas/nixpkgs/merges","archive_url":"https://api.github.com/repos/bendlas/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bendlas/nixpkgs/downloads","issues_url":"https://api.github.com/repos/bendlas/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/bendlas/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/bendlas/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/bendlas/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bendlas/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/bendlas/nixpkgs/releases{/id}","created_at":"2015-01-11T17:41:26Z","updated_at":"2015-03-26T18:13:32Z","pushed_at":"2015-04-20T10:43:53Z","git_url":"git://github.com/bendlas/nixpkgs.git","ssh_url":"git@github.com:bendlas/nixpkgs.git","clone_url":"https://github.com/bendlas/nixpkgs.git","svn_url":"https://github.com/bendlas/nixpkgs","homepage":null,"size":170300,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"2bc813dc5c19fde9a1842293994e2275cec7d6ff","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","created_at":"2012-06-04T02:49:46Z","updated_at":"2015-04-20T23:30:28Z","pushed_at":"2015-04-20T23:30:27Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":358934,"stargazers_count":622,"watchers_count":622,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":766,"mirror_url":null,"open_issues_count":695,"forks":766,"open_issues":695,"watchers":622,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7401"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/7401"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/7401"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/7401/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7401/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7401/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/ea5215201a0785dc925416718ed1559baa658433"}}}}