{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/44228172","id":44228172,"diff_hunk":"@@ -0,0 +1,27 @@\n+/**\n+ * @fileoverview Require `throw new Error()` rather than `throw Error()`\n+ * @author Rich Trott\n+ */\n+'use strict';\n+\n+//------------------------------------------------------------------------------\n+// Rule Definition\n+//------------------------------------------------------------------------------\n+\n+module.exports = function(context) {\n+\n+  return {\n+\n+    'ThrowStatement': function(node) {\n+      if (node.argument.type === 'CallExpression') {\n+        if (node.argument.callee.name === 'Error') {","path":"tools/eslint-rules/new-with-error.js","position":17,"original_position":17,"commit_id":"51dd74d761f25b12295091b39d0a9a71832212d9","original_commit_id":"51dd74d761f25b12295091b39d0a9a71832212d9","user":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"body":"These can be combined into a single `if`.","created_at":"2015-11-08T18:29:58Z","updated_at":"2015-11-08T18:29:58Z","html_url":"https://github.com/nodejs/node/pull/3714#discussion_r44228172","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/3714","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/44228172"},"html":{"href":"https://github.com/nodejs/node/pull/3714#discussion_r44228172"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/3714"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/3714","id":50065632,"html_url":"https://github.com/nodejs/node/pull/3714","diff_url":"https://github.com/nodejs/node/pull/3714.diff","patch_url":"https://github.com/nodejs/node/pull/3714.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/3714","number":3714,"state":"open","locked":false,"title":"tools: enforce `throw new Error()` with lint rule","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"body":"@evanlucas left [a comment on another PR](https://github.com/nodejs/node/pull/3636#discussion_r44224106) pointing out that the convention in the code base is `throw new Error()` over `throw Error().` This PR changes the five instances of `throw Error()` in the code base and enforces it with a linting rule.","created_at":"2015-11-08T17:58:26Z","updated_at":"2015-11-08T18:29:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2136eadfc5b97812136cea196aee82f838aeeb7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/3714/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/3714/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/3714/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/51dd74d761f25b12295091b39d0a9a71832212d9","head":{"label":"Trott:new-error","ref":"new-error","sha":"51dd74d761f25b12295091b39d0a9a71832212d9","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"repo":{"id":35707182,"name":"io.js","full_name":"Trott/io.js","owner":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Trott/io.js","description":"A friendly fork of Node.js with an open governance model","fork":true,"url":"https://api.github.com/repos/Trott/io.js","forks_url":"https://api.github.com/repos/Trott/io.js/forks","keys_url":"https://api.github.com/repos/Trott/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Trott/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Trott/io.js/teams","hooks_url":"https://api.github.com/repos/Trott/io.js/hooks","issue_events_url":"https://api.github.com/repos/Trott/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/Trott/io.js/events","assignees_url":"https://api.github.com/repos/Trott/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/Trott/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/Trott/io.js/tags","blobs_url":"https://api.github.com/repos/Trott/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Trott/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Trott/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Trott/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Trott/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Trott/io.js/languages","stargazers_url":"https://api.github.com/repos/Trott/io.js/stargazers","contributors_url":"https://api.github.com/repos/Trott/io.js/contributors","subscribers_url":"https://api.github.com/repos/Trott/io.js/subscribers","subscription_url":"https://api.github.com/repos/Trott/io.js/subscription","commits_url":"https://api.github.com/repos/Trott/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Trott/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Trott/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Trott/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Trott/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/Trott/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Trott/io.js/merges","archive_url":"https://api.github.com/repos/Trott/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Trott/io.js/downloads","issues_url":"https://api.github.com/repos/Trott/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/Trott/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Trott/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Trott/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Trott/io.js/labels{/name}","releases_url":"https://api.github.com/repos/Trott/io.js/releases{/id}","created_at":"2015-05-16T02:50:59Z","updated_at":"2015-05-16T02:51:03Z","pushed_at":"2015-11-08T17:54:22Z","git_url":"git://github.com/Trott/io.js.git","ssh_url":"git@github.com:Trott/io.js.git","clone_url":"https://github.com/Trott/io.js.git","svn_url":"https://github.com/Trott/io.js","homepage":"https://iojs.org","size":150824,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"bb1bd7639554766a88b8f7aef8891bf8249e613e","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-11-08T17:58:40Z","pushed_at":"2015-11-08T17:58:26Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":385524,"stargazers_count":17141,"watchers_count":17141,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1741,"mirror_url":null,"open_issues_count":565,"forks":1741,"open_issues":565,"watchers":17141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/3714"},"html":{"href":"https://github.com/nodejs/node/pull/3714"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/3714"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/3714/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/3714/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/3714/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/51dd74d761f25b12295091b39d0a9a71832212d9"}}}}