{"action":"created","comment":{"url":"https://api.github.com/repos/zikicm/github-sublime/pulls/comments/30273632","id":30273632,"diff_hunk":"@@ -47,9 +59,7 @@ define(\"content/app/github/wrappers/dom-element-wrapper\", function(require, expo\n \t\t */\n \t\tisInViewport : {\n \t\t\tget : function () {\n-\t\t\t\tvar clientBBox = this.clientBoundingBox;\n-\t\t\t\tvar clientViewport = WindowHelper.getViewportClientBoundingBox();\n-\t\t\t\treturn (clientBBox.intersection(clientViewport) !== null);\n+\t\t\t\treturn (this.visibleClientBoundingBox !== null);","path":"content/app/github/wrappers/dom-element-wrapper.js","position":26,"original_position":26,"commit_id":"7641d574f5ece531f792c8e70f5b476208018049","original_commit_id":"7641d574f5ece531f792c8e70f5b476208018049","user":{"login":"zikicm","id":8972153,"avatar_url":"https://avatars.githubusercontent.com/u/8972153?v=3","gravatar_id":"","url":"https://api.github.com/users/zikicm","html_url":"https://github.com/zikicm","followers_url":"https://api.github.com/users/zikicm/followers","following_url":"https://api.github.com/users/zikicm/following{/other_user}","gists_url":"https://api.github.com/users/zikicm/gists{/gist_id}","starred_url":"https://api.github.com/users/zikicm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikicm/subscriptions","organizations_url":"https://api.github.com/users/zikicm/orgs","repos_url":"https://api.github.com/users/zikicm/repos","events_url":"https://api.github.com/users/zikicm/events{/privacy}","received_events_url":"https://api.github.com/users/zikicm/received_events","type":"User","site_admin":false},"body":"No need for the brackets.","created_at":"2015-05-13T20:41:20Z","updated_at":"2015-05-13T20:41:20Z","html_url":"https://github.com/zikicm/github-sublime/pull/13#discussion_r30273632","pull_request_url":"https://api.github.com/repos/zikicm/github-sublime/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/zikicm/github-sublime/pulls/comments/30273632"},"html":{"href":"https://github.com/zikicm/github-sublime/pull/13#discussion_r30273632"},"pull_request":{"href":"https://api.github.com/repos/zikicm/github-sublime/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/zikicm/github-sublime/pulls/13","id":35299112,"html_url":"https://github.com/zikicm/github-sublime/pull/13","diff_url":"https://github.com/zikicm/github-sublime/pull/13.diff","patch_url":"https://github.com/zikicm/github-sublime/pull/13.patch","issue_url":"https://api.github.com/repos/zikicm/github-sublime/issues/13","number":13,"state":"open","locked":false,"title":"Support for expand buttons and navigate through most visible file DOM element","user":{"login":"comanjoni","id":3792083,"avatar_url":"https://avatars.githubusercontent.com/u/3792083?v=3","gravatar_id":"","url":"https://api.github.com/users/comanjoni","html_url":"https://github.com/comanjoni","followers_url":"https://api.github.com/users/comanjoni/followers","following_url":"https://api.github.com/users/comanjoni/following{/other_user}","gists_url":"https://api.github.com/users/comanjoni/gists{/gist_id}","starred_url":"https://api.github.com/users/comanjoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comanjoni/subscriptions","organizations_url":"https://api.github.com/users/comanjoni/orgs","repos_url":"https://api.github.com/users/comanjoni/repos","events_url":"https://api.github.com/users/comanjoni/events{/privacy}","received_events_url":"https://api.github.com/users/comanjoni/received_events","type":"User","site_admin":false},"body":"@zikicm please take a look\r\n - Line numbers replaced with line ranges so expand buttons can be supported. Now user navigate to expand button if button contains target line in its range.\r\n\r\n- Updated getCurrentFile() method to return most visible file DOM element in viewport.","created_at":"2015-05-13T07:00:43Z","updated_at":"2015-05-13T20:41:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cebd43d677540e2f14fd3c405769610e4f4fe3bb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zikicm/github-sublime/pulls/13/commits","review_comments_url":"https://api.github.com/repos/zikicm/github-sublime/pulls/13/comments","review_comment_url":"https://api.github.com/repos/zikicm/github-sublime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zikicm/github-sublime/issues/13/comments","statuses_url":"https://api.github.com/repos/zikicm/github-sublime/statuses/7641d574f5ece531f792c8e70f5b476208018049","head":{"label":"zikicm:goto-line","ref":"goto-line","sha":"7641d574f5ece531f792c8e70f5b476208018049","user":{"login":"zikicm","id":8972153,"avatar_url":"https://avatars.githubusercontent.com/u/8972153?v=3","gravatar_id":"","url":"https://api.github.com/users/zikicm","html_url":"https://github.com/zikicm","followers_url":"https://api.github.com/users/zikicm/followers","following_url":"https://api.github.com/users/zikicm/following{/other_user}","gists_url":"https://api.github.com/users/zikicm/gists{/gist_id}","starred_url":"https://api.github.com/users/zikicm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikicm/subscriptions","organizations_url":"https://api.github.com/users/zikicm/orgs","repos_url":"https://api.github.com/users/zikicm/repos","events_url":"https://api.github.com/users/zikicm/events{/privacy}","received_events_url":"https://api.github.com/users/zikicm/received_events","type":"User","site_admin":false},"repo":{"id":33692628,"name":"github-sublime","full_name":"zikicm/github-sublime","owner":{"login":"zikicm","id":8972153,"avatar_url":"https://avatars.githubusercontent.com/u/8972153?v=3","gravatar_id":"","url":"https://api.github.com/users/zikicm","html_url":"https://github.com/zikicm","followers_url":"https://api.github.com/users/zikicm/followers","following_url":"https://api.github.com/users/zikicm/following{/other_user}","gists_url":"https://api.github.com/users/zikicm/gists{/gist_id}","starred_url":"https://api.github.com/users/zikicm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikicm/subscriptions","organizations_url":"https://api.github.com/users/zikicm/orgs","repos_url":"https://api.github.com/users/zikicm/repos","events_url":"https://api.github.com/users/zikicm/events{/privacy}","received_events_url":"https://api.github.com/users/zikicm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zikicm/github-sublime","description":"Chrome plug in which adds Sublime most used features to GitHub browsing.","fork":false,"url":"https://api.github.com/repos/zikicm/github-sublime","forks_url":"https://api.github.com/repos/zikicm/github-sublime/forks","keys_url":"https://api.github.com/repos/zikicm/github-sublime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zikicm/github-sublime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zikicm/github-sublime/teams","hooks_url":"https://api.github.com/repos/zikicm/github-sublime/hooks","issue_events_url":"https://api.github.com/repos/zikicm/github-sublime/issues/events{/number}","events_url":"https://api.github.com/repos/zikicm/github-sublime/events","assignees_url":"https://api.github.com/repos/zikicm/github-sublime/assignees{/user}","branches_url":"https://api.github.com/repos/zikicm/github-sublime/branches{/branch}","tags_url":"https://api.github.com/repos/zikicm/github-sublime/tags","blobs_url":"https://api.github.com/repos/zikicm/github-sublime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zikicm/github-sublime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zikicm/github-sublime/git/refs{/sha}","trees_url":"https://api.github.com/repos/zikicm/github-sublime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zikicm/github-sublime/statuses/{sha}","languages_url":"https://api.github.com/repos/zikicm/github-sublime/languages","stargazers_url":"https://api.github.com/repos/zikicm/github-sublime/stargazers","contributors_url":"https://api.github.com/repos/zikicm/github-sublime/contributors","subscribers_url":"https://api.github.com/repos/zikicm/github-sublime/subscribers","subscription_url":"https://api.github.com/repos/zikicm/github-sublime/subscription","commits_url":"https://api.github.com/repos/zikicm/github-sublime/commits{/sha}","git_commits_url":"https://api.github.com/repos/zikicm/github-sublime/git/commits{/sha}","comments_url":"https://api.github.com/repos/zikicm/github-sublime/comments{/number}","issue_comment_url":"https://api.github.com/repos/zikicm/github-sublime/issues/comments{/number}","contents_url":"https://api.github.com/repos/zikicm/github-sublime/contents/{+path}","compare_url":"https://api.github.com/repos/zikicm/github-sublime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zikicm/github-sublime/merges","archive_url":"https://api.github.com/repos/zikicm/github-sublime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zikicm/github-sublime/downloads","issues_url":"https://api.github.com/repos/zikicm/github-sublime/issues{/number}","pulls_url":"https://api.github.com/repos/zikicm/github-sublime/pulls{/number}","milestones_url":"https://api.github.com/repos/zikicm/github-sublime/milestones{/number}","notifications_url":"https://api.github.com/repos/zikicm/github-sublime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zikicm/github-sublime/labels{/name}","releases_url":"https://api.github.com/repos/zikicm/github-sublime/releases{/id}","created_at":"2015-04-09T21:02:01Z","updated_at":"2015-05-08T15:53:18Z","pushed_at":"2015-05-13T07:00:44Z","git_url":"git://github.com/zikicm/github-sublime.git","ssh_url":"git@github.com:zikicm/github-sublime.git","clone_url":"https://github.com/zikicm/github-sublime.git","svn_url":"https://github.com/zikicm/github-sublime","homepage":null,"size":308,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"zikicm:master","ref":"master","sha":"dd857b6f01ff828e9ad3bcf9e1f5650048ed7116","user":{"login":"zikicm","id":8972153,"avatar_url":"https://avatars.githubusercontent.com/u/8972153?v=3","gravatar_id":"","url":"https://api.github.com/users/zikicm","html_url":"https://github.com/zikicm","followers_url":"https://api.github.com/users/zikicm/followers","following_url":"https://api.github.com/users/zikicm/following{/other_user}","gists_url":"https://api.github.com/users/zikicm/gists{/gist_id}","starred_url":"https://api.github.com/users/zikicm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikicm/subscriptions","organizations_url":"https://api.github.com/users/zikicm/orgs","repos_url":"https://api.github.com/users/zikicm/repos","events_url":"https://api.github.com/users/zikicm/events{/privacy}","received_events_url":"https://api.github.com/users/zikicm/received_events","type":"User","site_admin":false},"repo":{"id":33692628,"name":"github-sublime","full_name":"zikicm/github-sublime","owner":{"login":"zikicm","id":8972153,"avatar_url":"https://avatars.githubusercontent.com/u/8972153?v=3","gravatar_id":"","url":"https://api.github.com/users/zikicm","html_url":"https://github.com/zikicm","followers_url":"https://api.github.com/users/zikicm/followers","following_url":"https://api.github.com/users/zikicm/following{/other_user}","gists_url":"https://api.github.com/users/zikicm/gists{/gist_id}","starred_url":"https://api.github.com/users/zikicm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zikicm/subscriptions","organizations_url":"https://api.github.com/users/zikicm/orgs","repos_url":"https://api.github.com/users/zikicm/repos","events_url":"https://api.github.com/users/zikicm/events{/privacy}","received_events_url":"https://api.github.com/users/zikicm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zikicm/github-sublime","description":"Chrome plug in which adds Sublime most used features to GitHub browsing.","fork":false,"url":"https://api.github.com/repos/zikicm/github-sublime","forks_url":"https://api.github.com/repos/zikicm/github-sublime/forks","keys_url":"https://api.github.com/repos/zikicm/github-sublime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zikicm/github-sublime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zikicm/github-sublime/teams","hooks_url":"https://api.github.com/repos/zikicm/github-sublime/hooks","issue_events_url":"https://api.github.com/repos/zikicm/github-sublime/issues/events{/number}","events_url":"https://api.github.com/repos/zikicm/github-sublime/events","assignees_url":"https://api.github.com/repos/zikicm/github-sublime/assignees{/user}","branches_url":"https://api.github.com/repos/zikicm/github-sublime/branches{/branch}","tags_url":"https://api.github.com/repos/zikicm/github-sublime/tags","blobs_url":"https://api.github.com/repos/zikicm/github-sublime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zikicm/github-sublime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zikicm/github-sublime/git/refs{/sha}","trees_url":"https://api.github.com/repos/zikicm/github-sublime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zikicm/github-sublime/statuses/{sha}","languages_url":"https://api.github.com/repos/zikicm/github-sublime/languages","stargazers_url":"https://api.github.com/repos/zikicm/github-sublime/stargazers","contributors_url":"https://api.github.com/repos/zikicm/github-sublime/contributors","subscribers_url":"https://api.github.com/repos/zikicm/github-sublime/subscribers","subscription_url":"https://api.github.com/repos/zikicm/github-sublime/subscription","commits_url":"https://api.github.com/repos/zikicm/github-sublime/commits{/sha}","git_commits_url":"https://api.github.com/repos/zikicm/github-sublime/git/commits{/sha}","comments_url":"https://api.github.com/repos/zikicm/github-sublime/comments{/number}","issue_comment_url":"https://api.github.com/repos/zikicm/github-sublime/issues/comments{/number}","contents_url":"https://api.github.com/repos/zikicm/github-sublime/contents/{+path}","compare_url":"https://api.github.com/repos/zikicm/github-sublime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zikicm/github-sublime/merges","archive_url":"https://api.github.com/repos/zikicm/github-sublime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zikicm/github-sublime/downloads","issues_url":"https://api.github.com/repos/zikicm/github-sublime/issues{/number}","pulls_url":"https://api.github.com/repos/zikicm/github-sublime/pulls{/number}","milestones_url":"https://api.github.com/repos/zikicm/github-sublime/milestones{/number}","notifications_url":"https://api.github.com/repos/zikicm/github-sublime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zikicm/github-sublime/labels{/name}","releases_url":"https://api.github.com/repos/zikicm/github-sublime/releases{/id}","created_at":"2015-04-09T21:02:01Z","updated_at":"2015-05-08T15:53:18Z","pushed_at":"2015-05-13T07:00:44Z","git_url":"git://github.com/zikicm/github-sublime.git","ssh_url":"git@github.com:zikicm/github-sublime.git","clone_url":"https://github.com/zikicm/github-sublime.git","svn_url":"https://github.com/zikicm/github-sublime","homepage":null,"size":308,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zikicm/github-sublime/pulls/13"},"html":{"href":"https://github.com/zikicm/github-sublime/pull/13"},"issue":{"href":"https://api.github.com/repos/zikicm/github-sublime/issues/13"},"comments":{"href":"https://api.github.com/repos/zikicm/github-sublime/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/zikicm/github-sublime/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/zikicm/github-sublime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zikicm/github-sublime/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/zikicm/github-sublime/statuses/7641d574f5ece531f792c8e70f5b476208018049"}}}}