{"action":"created","issue":{"url":"https://api.github.com/repos/johnmyleswhite/bayesian_nonparametrics/issues/3","labels_url":"https://api.github.com/repos/johnmyleswhite/bayesian_nonparametrics/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/johnmyleswhite/bayesian_nonparametrics/issues/3/comments","events_url":"https://api.github.com/repos/johnmyleswhite/bayesian_nonparametrics/issues/3/events","html_url":"https://github.com/johnmyleswhite/bayesian_nonparametrics/issues/3","id":99261379,"number":3,"title":"Should add \"na.rm=TRUE\" to calls to \"min(.)\"","user":{"login":"empirical-bayesian","id":4048647,"avatar_url":"https://avatars.githubusercontent.com/u/4048647?v=3","gravatar_id":"","url":"https://api.github.com/users/empirical-bayesian","html_url":"https://github.com/empirical-bayesian","followers_url":"https://api.github.com/users/empirical-bayesian/followers","following_url":"https://api.github.com/users/empirical-bayesian/following{/other_user}","gists_url":"https://api.github.com/users/empirical-bayesian/gists{/gist_id}","starred_url":"https://api.github.com/users/empirical-bayesian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/empirical-bayesian/subscriptions","organizations_url":"https://api.github.com/users/empirical-bayesian/orgs","repos_url":"https://api.github.com/users/empirical-bayesian/repos","events_url":"https://api.github.com/users/empirical-bayesian/events{/privacy}","received_events_url":"https://api.github.com/users/empirical-bayesian/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-08-05T17:49:52Z","updated_at":"2015-08-05T17:52:52Z","closed_at":"2015-08-05T17:52:52Z","body":"The calls to the \"min(.)\" function in lines 28 and 36 of dp-means.R ought to have an \"na.rm=TRUE\" added. Specifically, they should be, in turn,\r\n\r\n    if (min(distances, na.rm=TRUE) > lambda)\r\n\r\nand\r\n\r\n    assignments[i] <- which(distances == min(distances, na.rm=TRUE))\r\n\r\nThis is because NAs sometimes leak through in `distances`, given its definition in line 21."},"comment":{"url":"https://api.github.com/repos/johnmyleswhite/bayesian_nonparametrics/issues/comments/128090439","html_url":"https://github.com/johnmyleswhite/bayesian_nonparametrics/issues/3#issuecomment-128090439","issue_url":"https://api.github.com/repos/johnmyleswhite/bayesian_nonparametrics/issues/3","id":128090439,"user":{"login":"johnmyleswhite","id":22064,"avatar_url":"https://avatars.githubusercontent.com/u/22064?v=3","gravatar_id":"","url":"https://api.github.com/users/johnmyleswhite","html_url":"https://github.com/johnmyleswhite","followers_url":"https://api.github.com/users/johnmyleswhite/followers","following_url":"https://api.github.com/users/johnmyleswhite/following{/other_user}","gists_url":"https://api.github.com/users/johnmyleswhite/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmyleswhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmyleswhite/subscriptions","organizations_url":"https://api.github.com/users/johnmyleswhite/orgs","repos_url":"https://api.github.com/users/johnmyleswhite/repos","events_url":"https://api.github.com/users/johnmyleswhite/events{/privacy}","received_events_url":"https://api.github.com/users/johnmyleswhite/received_events","type":"User","site_admin":false},"created_at":"2015-08-05T17:52:52Z","updated_at":"2015-08-05T17:52:52Z","body":"Thanks for the suggestion. This is a non-maintained repo."}}