{"action":"closed","number":361,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch-rails/pulls/361","id":32369120,"html_url":"https://github.com/elastic/elasticsearch-rails/pull/361","diff_url":"https://github.com/elastic/elasticsearch-rails/pull/361.diff","patch_url":"https://github.com/elastic/elasticsearch-rails/pull/361.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch-rails/issues/361","number":361,"state":"closed","locked":false,"title":"[MODEL] Add Sequel adapter","user":{"login":"badosu","id":347552,"avatar_url":"https://avatars.githubusercontent.com/u/347552?v=3","gravatar_id":"","url":"https://api.github.com/users/badosu","html_url":"https://github.com/badosu","followers_url":"https://api.github.com/users/badosu/followers","following_url":"https://api.github.com/users/badosu/following{/other_user}","gists_url":"https://api.github.com/users/badosu/gists{/gist_id}","starred_url":"https://api.github.com/users/badosu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badosu/subscriptions","organizations_url":"https://api.github.com/users/badosu/orgs","repos_url":"https://api.github.com/users/badosu/repos","events_url":"https://api.github.com/users/badosu/events{/privacy}","received_events_url":"https://api.github.com/users/badosu/received_events","type":"User","site_admin":false},"body":"I am sending this prematurely to discuss whether this is wanted upstream or not before I continue working on it.\r\n\r\nBasically: I've searched extensively for Sequel integration with ElasticSearch and found none, so I developed a partial adapter for `Sequel::Model`.\r\n\r\nThe following points need to be discussed if this is to be wanted:\r\n\r\n- It must define methods to work with callback hooks, see the [hook docs](http://sequel.jeremyevans.net/rdoc/files/doc/model_hooks_rdoc.html). I made the `Callbacks` module a Sequel plugin, but let me know if the correct place would be elsewhere, e.g. `ext/sequel`.\r\n\r\n- It must call `plugin(:active_model)` at the class instance. Currently this is not performed automatically by this adapter, let me know if this is desired. See the [plugin docs](http://sequel.jeremyevans.net/rdoc-plugins/classes/Sequel/Plugins/ActiveModel.html)\r\n\r\nAs soon as I receive feedback that this could be pulled I'll work on the missing methods and tests.","created_at":"2015-03-31T21:42:59Z","updated_at":"2015-05-21T16:09:24Z","closed_at":"2015-05-21T16:09:24Z","merged_at":null,"merge_commit_sha":"af50ea86b9945fadf481a99a302091f69d3083c4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch-rails/pulls/361/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch-rails/pulls/361/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch-rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch-rails/issues/361/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch-rails/statuses/e0c8018f128c792d6ffa89642cfefae6d4df7e02","head":{"label":"badosu:model-sequel-support","ref":"model-sequel-support","sha":"e0c8018f128c792d6ffa89642cfefae6d4df7e02","user":{"login":"badosu","id":347552,"avatar_url":"https://avatars.githubusercontent.com/u/347552?v=3","gravatar_id":"","url":"https://api.github.com/users/badosu","html_url":"https://github.com/badosu","followers_url":"https://api.github.com/users/badosu/followers","following_url":"https://api.github.com/users/badosu/following{/other_user}","gists_url":"https://api.github.com/users/badosu/gists{/gist_id}","starred_url":"https://api.github.com/users/badosu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badosu/subscriptions","organizations_url":"https://api.github.com/users/badosu/orgs","repos_url":"https://api.github.com/users/badosu/repos","events_url":"https://api.github.com/users/badosu/events{/privacy}","received_events_url":"https://api.github.com/users/badosu/received_events","type":"User","site_admin":false},"repo":{"id":33209257,"name":"elasticsearch-rails","full_name":"badosu/elasticsearch-rails","owner":{"login":"badosu","id":347552,"avatar_url":"https://avatars.githubusercontent.com/u/347552?v=3","gravatar_id":"","url":"https://api.github.com/users/badosu","html_url":"https://github.com/badosu","followers_url":"https://api.github.com/users/badosu/followers","following_url":"https://api.github.com/users/badosu/following{/other_user}","gists_url":"https://api.github.com/users/badosu/gists{/gist_id}","starred_url":"https://api.github.com/users/badosu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badosu/subscriptions","organizations_url":"https://api.github.com/users/badosu/orgs","repos_url":"https://api.github.com/users/badosu/repos","events_url":"https://api.github.com/users/badosu/events{/privacy}","received_events_url":"https://api.github.com/users/badosu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/badosu/elasticsearch-rails","description":"Elasticsearch integrations for ActiveModel/Record and Ruby on Rails","fork":true,"url":"https://api.github.com/repos/badosu/elasticsearch-rails","forks_url":"https://api.github.com/repos/badosu/elasticsearch-rails/forks","keys_url":"https://api.github.com/repos/badosu/elasticsearch-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/badosu/elasticsearch-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/badosu/elasticsearch-rails/teams","hooks_url":"https://api.github.com/repos/badosu/elasticsearch-rails/hooks","issue_events_url":"https://api.github.com/repos/badosu/elasticsearch-rails/issues/events{/number}","events_url":"https://api.github.com/repos/badosu/elasticsearch-rails/events","assignees_url":"https://api.github.com/repos/badosu/elasticsearch-rails/assignees{/user}","branches_url":"https://api.github.com/repos/badosu/elasticsearch-rails/branches{/branch}","tags_url":"https://api.github.com/repos/badosu/elasticsearch-rails/tags","blobs_url":"https://api.github.com/repos/badosu/elasticsearch-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/badosu/elasticsearch-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/badosu/elasticsearch-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/badosu/elasticsearch-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/badosu/elasticsearch-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/badosu/elasticsearch-rails/languages","stargazers_url":"https://api.github.com/repos/badosu/elasticsearch-rails/stargazers","contributors_url":"https://api.github.com/repos/badosu/elasticsearch-rails/contributors","subscribers_url":"https://api.github.com/repos/badosu/elasticsearch-rails/subscribers","subscription_url":"https://api.github.com/repos/badosu/elasticsearch-rails/subscription","commits_url":"https://api.github.com/repos/badosu/elasticsearch-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/badosu/elasticsearch-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/badosu/elasticsearch-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/badosu/elasticsearch-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/badosu/elasticsearch-rails/contents/{+path}","compare_url":"https://api.github.com/repos/badosu/elasticsearch-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/badosu/elasticsearch-rails/merges","archive_url":"https://api.github.com/repos/badosu/elasticsearch-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/badosu/elasticsearch-rails/downloads","issues_url":"https://api.github.com/repos/badosu/elasticsearch-rails/issues{/number}","pulls_url":"https://api.github.com/repos/badosu/elasticsearch-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/badosu/elasticsearch-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/badosu/elasticsearch-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/badosu/elasticsearch-rails/labels{/name}","releases_url":"https://api.github.com/repos/badosu/elasticsearch-rails/releases{/id}","created_at":"2015-03-31T20:52:23Z","updated_at":"2015-03-31T20:52:24Z","pushed_at":"2015-03-31T21:04:20Z","git_url":"git://github.com/badosu/elasticsearch-rails.git","ssh_url":"git@github.com:badosu/elasticsearch-rails.git","clone_url":"https://github.com/badosu/elasticsearch-rails.git","svn_url":"https://github.com/badosu/elasticsearch-rails","homepage":"","size":4807,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"a78f4926a5633e1199c6c0b3e14122982242e959","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":14238949,"name":"elasticsearch-rails","full_name":"elastic/elasticsearch-rails","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch-rails","description":"Elasticsearch integrations for ActiveModel/Record and Ruby on Rails","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch-rails","forks_url":"https://api.github.com/repos/elastic/elasticsearch-rails/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch-rails/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch-rails/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch-rails/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch-rails/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch-rails/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch-rails/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch-rails/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch-rails/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch-rails/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch-rails/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch-rails/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch-rails/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch-rails/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch-rails/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch-rails/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch-rails/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch-rails/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch-rails/releases{/id}","created_at":"2013-11-08T17:00:19Z","updated_at":"2015-05-21T15:19:24Z","pushed_at":"2015-05-21T07:17:23Z","git_url":"git://github.com/elastic/elasticsearch-rails.git","ssh_url":"git@github.com:elastic/elasticsearch-rails.git","clone_url":"https://github.com/elastic/elasticsearch-rails.git","svn_url":"https://github.com/elastic/elasticsearch-rails","homepage":"","size":8915,"stargazers_count":1121,"watchers_count":1121,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":227,"mirror_url":null,"open_issues_count":69,"forks":227,"open_issues":69,"watchers":1121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch-rails/pulls/361"},"html":{"href":"https://github.com/elastic/elasticsearch-rails/pull/361"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch-rails/issues/361"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch-rails/issues/361/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch-rails/pulls/361/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch-rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch-rails/pulls/361/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch-rails/statuses/e0c8018f128c792d6ffa89642cfefae6d4df7e02"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":5,"review_comments":0,"commits":1,"additions":92,"deletions":0,"changed_files":1}}