{"action":"created","issue":{"url":"https://api.github.com/repos/zeromq/netmq/issues/273","labels_url":"https://api.github.com/repos/zeromq/netmq/issues/273/labels{/name}","comments_url":"https://api.github.com/repos/zeromq/netmq/issues/273/comments","events_url":"https://api.github.com/repos/zeromq/netmq/issues/273/events","html_url":"https://github.com/zeromq/netmq/pull/273","id":59392678,"number":273,"title":"Merged latest changes with comments I added, and resolved a few compile-warnings.","user":{"login":"JamesWHurst","id":5532028,"avatar_url":"https://avatars.githubusercontent.com/u/5532028?v=3","gravatar_id":"","url":"https://api.github.com/users/JamesWHurst","html_url":"https://github.com/JamesWHurst","followers_url":"https://api.github.com/users/JamesWHurst/followers","following_url":"https://api.github.com/users/JamesWHurst/following{/other_user}","gists_url":"https://api.github.com/users/JamesWHurst/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesWHurst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesWHurst/subscriptions","organizations_url":"https://api.github.com/users/JamesWHurst/orgs","repos_url":"https://api.github.com/users/JamesWHurst/repos","events_url":"https://api.github.com/users/JamesWHurst/events{/privacy}","received_events_url":"https://api.github.com/users/JamesWHurst/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-03-01T11:33:32Z","updated_at":"2015-03-01T20:59:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zeromq/netmq/pulls/273","html_url":"https://github.com/zeromq/netmq/pull/273","diff_url":"https://github.com/zeromq/netmq/pull/273.diff","patch_url":"https://github.com/zeromq/netmq/pull/273.patch"},"body":"To cut down on the work of merging in my pull-request, I merged in the latest changes as of today, March 1st (rather substantial!).\r\nAlso updated the help-file to reflect the latest code (that gets generated by automatically sucking-in the XML-formatted comments from the source-code using SandCastle)."},"comment":{"url":"https://api.github.com/repos/zeromq/netmq/issues/comments/76630299","html_url":"https://github.com/zeromq/netmq/pull/273#issuecomment-76630299","issue_url":"https://api.github.com/repos/zeromq/netmq/issues/273","id":76630299,"user":{"login":"drewnoakes","id":350947,"avatar_url":"https://avatars.githubusercontent.com/u/350947?v=3","gravatar_id":"","url":"https://api.github.com/users/drewnoakes","html_url":"https://github.com/drewnoakes","followers_url":"https://api.github.com/users/drewnoakes/followers","following_url":"https://api.github.com/users/drewnoakes/following{/other_user}","gists_url":"https://api.github.com/users/drewnoakes/gists{/gist_id}","starred_url":"https://api.github.com/users/drewnoakes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewnoakes/subscriptions","organizations_url":"https://api.github.com/users/drewnoakes/orgs","repos_url":"https://api.github.com/users/drewnoakes/repos","events_url":"https://api.github.com/users/drewnoakes/events{/privacy}","received_events_url":"https://api.github.com/users/drewnoakes/received_events","type":"User","site_admin":false},"created_at":"2015-03-01T20:59:35Z","updated_at":"2015-03-01T20:59:35Z","body":"Just looking into merging this. I can pick the one commit (8462ed2), but I think it undoes some stuff, losing changes when you merged. For example, in Actor.cs. It's also a little hard to see what's going on when members were reordered. And there's quite a bit of indentation broken in v0_1/HandshakeLayer.cs, for example.\r\n\r\nI noticed a few places in your commits where `<see cref=\"Foo\"/>` was replaced with `Foo`. Is there a reason for this? Perhaps something to do with CHM compilation? If not, then it's good to use the cref attribute so that refactorings (such as rename) keep the documentation up to date and correct.\r\n\r\nI am working on picking out the intended changes now and will push them separately if all goes well."}}