{"action":"created","comment":{"url":"https://api.github.com/repos/databricks/spark-csv/pulls/comments/45414633","id":45414633,"diff_hunk":"@@ -26,6 +26,16 @@ package object csv {\n   val defaultCsvFormat =\n     CSVFormat.DEFAULT.withRecordSeparator(System.getProperty(\"line.separator\", \"\\n\"))\n \n+  private[csv] def compresionCodecClass(className: String): Class[_ <: CompressionCodec] = {\n+    className match {\n+    case null => null","path":"src/main/scala/com/databricks/spark/csv/package.scala","position":6,"original_position":6,"commit_id":"0bac3a1f83c32f1af19dcf948239074a8d6f934c","original_commit_id":"0bac3a1f83c32f1af19dcf948239074a8d6f934c","user":{"login":"falaki","id":512364,"avatar_url":"https://avatars.githubusercontent.com/u/512364?v=3","gravatar_id":"","url":"https://api.github.com/users/falaki","html_url":"https://github.com/falaki","followers_url":"https://api.github.com/users/falaki/followers","following_url":"https://api.github.com/users/falaki/following{/other_user}","gists_url":"https://api.github.com/users/falaki/gists{/gist_id}","starred_url":"https://api.github.com/users/falaki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/falaki/subscriptions","organizations_url":"https://api.github.com/users/falaki/orgs","repos_url":"https://api.github.com/users/falaki/repos","events_url":"https://api.github.com/users/falaki/events{/privacy}","received_events_url":"https://api.github.com/users/falaki/received_events","type":"User","site_admin":false},"body":"Nit: indent two spaces.","created_at":"2015-11-19T23:04:31Z","updated_at":"2015-11-19T23:04:31Z","html_url":"https://github.com/databricks/spark-csv/pull/174#discussion_r45414633","pull_request_url":"https://api.github.com/repos/databricks/spark-csv/pulls/174","_links":{"self":{"href":"https://api.github.com/repos/databricks/spark-csv/pulls/comments/45414633"},"html":{"href":"https://github.com/databricks/spark-csv/pull/174#discussion_r45414633"},"pull_request":{"href":"https://api.github.com/repos/databricks/spark-csv/pulls/174"}}},"pull_request":{"url":"https://api.github.com/repos/databricks/spark-csv/pulls/174","id":48629377,"html_url":"https://github.com/databricks/spark-csv/pull/174","diff_url":"https://github.com/databricks/spark-csv/pull/174.diff","patch_url":"https://github.com/databricks/spark-csv/pull/174.patch","issue_url":"https://api.github.com/repos/databricks/spark-csv/issues/174","number":174,"state":"open","locked":false,"title":"Move compressionCodec to a string parameter","user":{"login":"msperlich","id":1402211,"avatar_url":"https://avatars.githubusercontent.com/u/1402211?v=3","gravatar_id":"","url":"https://api.github.com/users/msperlich","html_url":"https://github.com/msperlich","followers_url":"https://api.github.com/users/msperlich/followers","following_url":"https://api.github.com/users/msperlich/following{/other_user}","gists_url":"https://api.github.com/users/msperlich/gists{/gist_id}","starred_url":"https://api.github.com/users/msperlich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msperlich/subscriptions","organizations_url":"https://api.github.com/users/msperlich/orgs","repos_url":"https://api.github.com/users/msperlich/repos","events_url":"https://api.github.com/users/msperlich/events{/privacy}","received_events_url":"https://api.github.com/users/msperlich/received_events","type":"User","site_admin":false},"body":"This change allows Python (and presumably Java) users to use compressed\r\noutput by passing the compressionCodec as a string option, instead of an\r\nargument to a function only visible in the implicit class.\r\n\r\nThis is an API breaking change, so I'm definitely open to other\r\napproaches.\r\n","created_at":"2015-10-23T20:58:35Z","updated_at":"2015-11-19T23:04:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8903fa63fc5df6a65734e16cb83888c4dc564839","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/databricks/spark-csv/pulls/174/commits","review_comments_url":"https://api.github.com/repos/databricks/spark-csv/pulls/174/comments","review_comment_url":"https://api.github.com/repos/databricks/spark-csv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/databricks/spark-csv/issues/174/comments","statuses_url":"https://api.github.com/repos/databricks/spark-csv/statuses/0bac3a1f83c32f1af19dcf948239074a8d6f934c","head":{"label":"msperlich:master","ref":"master","sha":"0bac3a1f83c32f1af19dcf948239074a8d6f934c","user":{"login":"msperlich","id":1402211,"avatar_url":"https://avatars.githubusercontent.com/u/1402211?v=3","gravatar_id":"","url":"https://api.github.com/users/msperlich","html_url":"https://github.com/msperlich","followers_url":"https://api.github.com/users/msperlich/followers","following_url":"https://api.github.com/users/msperlich/following{/other_user}","gists_url":"https://api.github.com/users/msperlich/gists{/gist_id}","starred_url":"https://api.github.com/users/msperlich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msperlich/subscriptions","organizations_url":"https://api.github.com/users/msperlich/orgs","repos_url":"https://api.github.com/users/msperlich/repos","events_url":"https://api.github.com/users/msperlich/events{/privacy}","received_events_url":"https://api.github.com/users/msperlich/received_events","type":"User","site_admin":false},"repo":{"id":44835653,"name":"spark-csv","full_name":"msperlich/spark-csv","owner":{"login":"msperlich","id":1402211,"avatar_url":"https://avatars.githubusercontent.com/u/1402211?v=3","gravatar_id":"","url":"https://api.github.com/users/msperlich","html_url":"https://github.com/msperlich","followers_url":"https://api.github.com/users/msperlich/followers","following_url":"https://api.github.com/users/msperlich/following{/other_user}","gists_url":"https://api.github.com/users/msperlich/gists{/gist_id}","starred_url":"https://api.github.com/users/msperlich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msperlich/subscriptions","organizations_url":"https://api.github.com/users/msperlich/orgs","repos_url":"https://api.github.com/users/msperlich/repos","events_url":"https://api.github.com/users/msperlich/events{/privacy}","received_events_url":"https://api.github.com/users/msperlich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msperlich/spark-csv","description":"CSV data source for Spark SQL and DataFrames","fork":true,"url":"https://api.github.com/repos/msperlich/spark-csv","forks_url":"https://api.github.com/repos/msperlich/spark-csv/forks","keys_url":"https://api.github.com/repos/msperlich/spark-csv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msperlich/spark-csv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msperlich/spark-csv/teams","hooks_url":"https://api.github.com/repos/msperlich/spark-csv/hooks","issue_events_url":"https://api.github.com/repos/msperlich/spark-csv/issues/events{/number}","events_url":"https://api.github.com/repos/msperlich/spark-csv/events","assignees_url":"https://api.github.com/repos/msperlich/spark-csv/assignees{/user}","branches_url":"https://api.github.com/repos/msperlich/spark-csv/branches{/branch}","tags_url":"https://api.github.com/repos/msperlich/spark-csv/tags","blobs_url":"https://api.github.com/repos/msperlich/spark-csv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msperlich/spark-csv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msperlich/spark-csv/git/refs{/sha}","trees_url":"https://api.github.com/repos/msperlich/spark-csv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msperlich/spark-csv/statuses/{sha}","languages_url":"https://api.github.com/repos/msperlich/spark-csv/languages","stargazers_url":"https://api.github.com/repos/msperlich/spark-csv/stargazers","contributors_url":"https://api.github.com/repos/msperlich/spark-csv/contributors","subscribers_url":"https://api.github.com/repos/msperlich/spark-csv/subscribers","subscription_url":"https://api.github.com/repos/msperlich/spark-csv/subscription","commits_url":"https://api.github.com/repos/msperlich/spark-csv/commits{/sha}","git_commits_url":"https://api.github.com/repos/msperlich/spark-csv/git/commits{/sha}","comments_url":"https://api.github.com/repos/msperlich/spark-csv/comments{/number}","issue_comment_url":"https://api.github.com/repos/msperlich/spark-csv/issues/comments{/number}","contents_url":"https://api.github.com/repos/msperlich/spark-csv/contents/{+path}","compare_url":"https://api.github.com/repos/msperlich/spark-csv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msperlich/spark-csv/merges","archive_url":"https://api.github.com/repos/msperlich/spark-csv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msperlich/spark-csv/downloads","issues_url":"https://api.github.com/repos/msperlich/spark-csv/issues{/number}","pulls_url":"https://api.github.com/repos/msperlich/spark-csv/pulls{/number}","milestones_url":"https://api.github.com/repos/msperlich/spark-csv/milestones{/number}","notifications_url":"https://api.github.com/repos/msperlich/spark-csv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msperlich/spark-csv/labels{/name}","releases_url":"https://api.github.com/repos/msperlich/spark-csv/releases{/id}","created_at":"2015-10-23T20:02:54Z","updated_at":"2015-10-23T20:02:54Z","pushed_at":"2015-10-26T19:18:27Z","git_url":"git://github.com/msperlich/spark-csv.git","ssh_url":"git@github.com:msperlich/spark-csv.git","clone_url":"https://github.com/msperlich/spark-csv.git","svn_url":"https://github.com/msperlich/spark-csv","homepage":"http://databricks.com/","size":427,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"databricks:master","ref":"master","sha":"59a9de97c46bb5a7b1c13533f9e475ae36f1ceb5","user":{"login":"databricks","id":4998052,"avatar_url":"https://avatars.githubusercontent.com/u/4998052?v=3","gravatar_id":"","url":"https://api.github.com/users/databricks","html_url":"https://github.com/databricks","followers_url":"https://api.github.com/users/databricks/followers","following_url":"https://api.github.com/users/databricks/following{/other_user}","gists_url":"https://api.github.com/users/databricks/gists{/gist_id}","starred_url":"https://api.github.com/users/databricks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/databricks/subscriptions","organizations_url":"https://api.github.com/users/databricks/orgs","repos_url":"https://api.github.com/users/databricks/repos","events_url":"https://api.github.com/users/databricks/events{/privacy}","received_events_url":"https://api.github.com/users/databricks/received_events","type":"Organization","site_admin":false},"repo":{"id":27461793,"name":"spark-csv","full_name":"databricks/spark-csv","owner":{"login":"databricks","id":4998052,"avatar_url":"https://avatars.githubusercontent.com/u/4998052?v=3","gravatar_id":"","url":"https://api.github.com/users/databricks","html_url":"https://github.com/databricks","followers_url":"https://api.github.com/users/databricks/followers","following_url":"https://api.github.com/users/databricks/following{/other_user}","gists_url":"https://api.github.com/users/databricks/gists{/gist_id}","starred_url":"https://api.github.com/users/databricks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/databricks/subscriptions","organizations_url":"https://api.github.com/users/databricks/orgs","repos_url":"https://api.github.com/users/databricks/repos","events_url":"https://api.github.com/users/databricks/events{/privacy}","received_events_url":"https://api.github.com/users/databricks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/databricks/spark-csv","description":"CSV data source for Spark SQL and DataFrames","fork":false,"url":"https://api.github.com/repos/databricks/spark-csv","forks_url":"https://api.github.com/repos/databricks/spark-csv/forks","keys_url":"https://api.github.com/repos/databricks/spark-csv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/databricks/spark-csv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/databricks/spark-csv/teams","hooks_url":"https://api.github.com/repos/databricks/spark-csv/hooks","issue_events_url":"https://api.github.com/repos/databricks/spark-csv/issues/events{/number}","events_url":"https://api.github.com/repos/databricks/spark-csv/events","assignees_url":"https://api.github.com/repos/databricks/spark-csv/assignees{/user}","branches_url":"https://api.github.com/repos/databricks/spark-csv/branches{/branch}","tags_url":"https://api.github.com/repos/databricks/spark-csv/tags","blobs_url":"https://api.github.com/repos/databricks/spark-csv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/databricks/spark-csv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/databricks/spark-csv/git/refs{/sha}","trees_url":"https://api.github.com/repos/databricks/spark-csv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/databricks/spark-csv/statuses/{sha}","languages_url":"https://api.github.com/repos/databricks/spark-csv/languages","stargazers_url":"https://api.github.com/repos/databricks/spark-csv/stargazers","contributors_url":"https://api.github.com/repos/databricks/spark-csv/contributors","subscribers_url":"https://api.github.com/repos/databricks/spark-csv/subscribers","subscription_url":"https://api.github.com/repos/databricks/spark-csv/subscription","commits_url":"https://api.github.com/repos/databricks/spark-csv/commits{/sha}","git_commits_url":"https://api.github.com/repos/databricks/spark-csv/git/commits{/sha}","comments_url":"https://api.github.com/repos/databricks/spark-csv/comments{/number}","issue_comment_url":"https://api.github.com/repos/databricks/spark-csv/issues/comments{/number}","contents_url":"https://api.github.com/repos/databricks/spark-csv/contents/{+path}","compare_url":"https://api.github.com/repos/databricks/spark-csv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/databricks/spark-csv/merges","archive_url":"https://api.github.com/repos/databricks/spark-csv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/databricks/spark-csv/downloads","issues_url":"https://api.github.com/repos/databricks/spark-csv/issues{/number}","pulls_url":"https://api.github.com/repos/databricks/spark-csv/pulls{/number}","milestones_url":"https://api.github.com/repos/databricks/spark-csv/milestones{/number}","notifications_url":"https://api.github.com/repos/databricks/spark-csv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/databricks/spark-csv/labels{/name}","releases_url":"https://api.github.com/repos/databricks/spark-csv/releases{/id}","created_at":"2014-12-03T00:56:21Z","updated_at":"2015-11-19T16:46:48Z","pushed_at":"2015-11-19T22:44:03Z","git_url":"git://github.com/databricks/spark-csv.git","ssh_url":"git@github.com:databricks/spark-csv.git","clone_url":"https://github.com/databricks/spark-csv.git","svn_url":"https://github.com/databricks/spark-csv","homepage":"http://databricks.com/","size":501,"stargazers_count":260,"watchers_count":260,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":111,"mirror_url":null,"open_issues_count":53,"forks":111,"open_issues":53,"watchers":260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/databricks/spark-csv/pulls/174"},"html":{"href":"https://github.com/databricks/spark-csv/pull/174"},"issue":{"href":"https://api.github.com/repos/databricks/spark-csv/issues/174"},"comments":{"href":"https://api.github.com/repos/databricks/spark-csv/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/databricks/spark-csv/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/databricks/spark-csv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/databricks/spark-csv/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/databricks/spark-csv/statuses/0bac3a1f83c32f1af19dcf948239074a8d6f934c"}}}}