{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/video.js/pulls/comments/37896904","id":37896904,"diff_hunk":"@@ -438,13 +448,19 @@ Flash.onEvent = function(swfID, eventName){\n Flash.onError = function(swfID, err){\n   const tech = Dom.getEl(swfID).tech;\n   const msg = 'FLASH: '+err;\n+  const errorObj = {\n+    message: msg\n+  };\n+\n+  tech.error_ = errorObj;","path":"src/js/tech/flash.js","position":34,"original_position":34,"commit_id":"ff85e1249de721707f626a352ad478e59efc8006","original_commit_id":"ff85e1249de721707f626a352ad478e59efc8006","user":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"body":"Store the error object for usage above.","created_at":"2015-08-25T17:55:37Z","updated_at":"2015-08-25T17:55:37Z","html_url":"https://github.com/videojs/video.js/pull/2515#discussion_r37896904","pull_request_url":"https://api.github.com/repos/videojs/video.js/pulls/2515","_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments/37896904"},"html":{"href":"https://github.com/videojs/video.js/pull/2515#discussion_r37896904"},"pull_request":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2515"}}},"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/2515","id":43316247,"html_url":"https://github.com/videojs/video.js/pull/2515","diff_url":"https://github.com/videojs/video.js/pull/2515.diff","patch_url":"https://github.com/videojs/video.js/pull/2515.patch","issue_url":"https://api.github.com/repos/videojs/video.js/issues/2515","number":2515,"state":"open","locked":false,"title":"handle error getter on flash tech better","user":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"body":"The swf doesn't have [an error getter](https://github.com/videojs/video-js-swf/blob/master/src/VideoJS.as#L213-L299) and seems like all the info we have about the error is available in the `onError` method. So, instead of trying to call `vjs_getProperty` to the swf (which will never work or return a valid value), we'll store the error that we got there and return it in the error getter.\r\n\r\nOne thing I'm not certain off is when to clear out our reference to the error. Seems like when the error getter gets called is a good place to do so because it gets called from the player and player stores its own reference to the error which it clears out as necessary.","created_at":"2015-08-25T17:55:03Z","updated_at":"2015-08-25T17:55:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"134349a66146c3a42d58555e53338afd488471ba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/videojs/video.js/pulls/2515/commits","review_comments_url":"https://api.github.com/repos/videojs/video.js/pulls/2515/comments","review_comment_url":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/2515/comments","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/ff85e1249de721707f626a352ad478e59efc8006","head":{"label":"gkatsev:flash-error-getproperty","ref":"flash-error-getproperty","sha":"ff85e1249de721707f626a352ad478e59efc8006","user":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"repo":{"id":5810290,"name":"video.js","full_name":"gkatsev/video.js","owner":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gkatsev/video.js","description":"Universal video embed.","fork":true,"url":"https://api.github.com/repos/gkatsev/video.js","forks_url":"https://api.github.com/repos/gkatsev/video.js/forks","keys_url":"https://api.github.com/repos/gkatsev/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gkatsev/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gkatsev/video.js/teams","hooks_url":"https://api.github.com/repos/gkatsev/video.js/hooks","issue_events_url":"https://api.github.com/repos/gkatsev/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/gkatsev/video.js/events","assignees_url":"https://api.github.com/repos/gkatsev/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/gkatsev/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/gkatsev/video.js/tags","blobs_url":"https://api.github.com/repos/gkatsev/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gkatsev/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gkatsev/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/gkatsev/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gkatsev/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/gkatsev/video.js/languages","stargazers_url":"https://api.github.com/repos/gkatsev/video.js/stargazers","contributors_url":"https://api.github.com/repos/gkatsev/video.js/contributors","subscribers_url":"https://api.github.com/repos/gkatsev/video.js/subscribers","subscription_url":"https://api.github.com/repos/gkatsev/video.js/subscription","commits_url":"https://api.github.com/repos/gkatsev/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/gkatsev/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/gkatsev/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/gkatsev/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/gkatsev/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/gkatsev/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gkatsev/video.js/merges","archive_url":"https://api.github.com/repos/gkatsev/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gkatsev/video.js/downloads","issues_url":"https://api.github.com/repos/gkatsev/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/gkatsev/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/gkatsev/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/gkatsev/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gkatsev/video.js/labels{/name}","releases_url":"https://api.github.com/repos/gkatsev/video.js/releases{/id}","created_at":"2012-09-14T14:23:52Z","updated_at":"2015-05-01T22:22:54Z","pushed_at":"2015-08-25T17:51:40Z","git_url":"git://github.com/gkatsev/video.js.git","ssh_url":"git@github.com:gkatsev/video.js.git","clone_url":"https://github.com/gkatsev/video.js.git","svn_url":"https://github.com/gkatsev/video.js","homepage":"videojs.com","size":16253,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"e10a2f4b03b7feba67e1f878d491bc50daa3ec36","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":667006,"name":"video.js","full_name":"videojs/video.js","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":false,"url":"https://api.github.com/repos/videojs/video.js","forks_url":"https://api.github.com/repos/videojs/video.js/forks","keys_url":"https://api.github.com/repos/videojs/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/video.js/teams","hooks_url":"https://api.github.com/repos/videojs/video.js/hooks","issue_events_url":"https://api.github.com/repos/videojs/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/video.js/events","assignees_url":"https://api.github.com/repos/videojs/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/video.js/tags","blobs_url":"https://api.github.com/repos/videojs/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/video.js/languages","stargazers_url":"https://api.github.com/repos/videojs/video.js/stargazers","contributors_url":"https://api.github.com/repos/videojs/video.js/contributors","subscribers_url":"https://api.github.com/repos/videojs/video.js/subscribers","subscription_url":"https://api.github.com/repos/videojs/video.js/subscription","commits_url":"https://api.github.com/repos/videojs/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/video.js/merges","archive_url":"https://api.github.com/repos/videojs/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/video.js/downloads","issues_url":"https://api.github.com/repos/videojs/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/video.js/labels{/name}","releases_url":"https://api.github.com/repos/videojs/video.js/releases{/id}","created_at":"2010-05-14T18:45:10Z","updated_at":"2015-08-25T16:21:49Z","pushed_at":"2015-08-25T17:55:03Z","git_url":"git://github.com/videojs/video.js.git","ssh_url":"git@github.com:videojs/video.js.git","clone_url":"https://github.com/videojs/video.js.git","svn_url":"https://github.com/videojs/video.js","homepage":"www.videojs.com","size":61495,"stargazers_count":9929,"watchers_count":9929,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":2857,"mirror_url":null,"open_issues_count":187,"forks":2857,"open_issues":187,"watchers":9929,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2515"},"html":{"href":"https://github.com/videojs/video.js/pull/2515"},"issue":{"href":"https://api.github.com/repos/videojs/video.js/issues/2515"},"comments":{"href":"https://api.github.com/repos/videojs/video.js/issues/2515/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2515/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2515/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/video.js/statuses/ff85e1249de721707f626a352ad478e59efc8006"}}}}