{"action":"created","comment":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/comments/23446289","id":23446289,"diff_hunk":"@@ -546,13 +527,18 @@\n }\n \n #landuse-overlay {\n-  [landuse = 'military'][zoom >= 10]::landuse {\n+  [feature = 'military'][zoom >= 10] {","path":"landcover.mss","position":89,"original_position":89,"commit_id":"0c527d5aa0bcdd0ed85d20993792add3aeb316ce","original_commit_id":"7ef378ec3950edad9e096f1d31048e6b31183e73","user":{"login":"pnorman","id":1190866,"avatar_url":"https://avatars.githubusercontent.com/u/1190866?v=3","gravatar_id":"","url":"https://api.github.com/users/pnorman","html_url":"https://github.com/pnorman","followers_url":"https://api.github.com/users/pnorman/followers","following_url":"https://api.github.com/users/pnorman/following{/other_user}","gists_url":"https://api.github.com/users/pnorman/gists{/gist_id}","starred_url":"https://api.github.com/users/pnorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnorman/subscriptions","organizations_url":"https://api.github.com/users/pnorman/orgs","repos_url":"https://api.github.com/users/pnorman/repos","events_url":"https://api.github.com/users/pnorman/events{/privacy}","received_events_url":"https://api.github.com/users/pnorman/received_events","type":"User","site_admin":false},"body":"I'm wondering if I should name the column `landuse`, I'm just normalizing the two different wood taggings into one rather than a full feature column setup.","created_at":"2015-01-23T12:16:25Z","updated_at":"2015-01-23T12:16:25Z","html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/1242#discussion_r23446289","pull_request_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/1242","_links":{"self":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/comments/23446289"},"html":{"href":"https://github.com/gravitystorm/openstreetmap-carto/pull/1242#discussion_r23446289"},"pull_request":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/1242"}}},"pull_request":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/1242","id":27582318,"html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/1242","diff_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/1242.diff","patch_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/1242.patch","issue_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/1242","number":1242,"state":"open","locked":false,"title":"Use a random symbology for forests","user":{"login":"pnorman","id":1190866,"avatar_url":"https://avatars.githubusercontent.com/u/1190866?v=3","gravatar_id":"","url":"https://api.github.com/users/pnorman","html_url":"https://github.com/pnorman","followers_url":"https://api.github.com/users/pnorman/followers","following_url":"https://api.github.com/users/pnorman/following{/other_user}","gists_url":"https://api.github.com/users/pnorman/gists{/gist_id}","starred_url":"https://api.github.com/users/pnorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnorman/subscriptions","organizations_url":"https://api.github.com/users/pnorman/orgs","repos_url":"https://api.github.com/users/pnorman/repos","events_url":"https://api.github.com/users/pnorman/events{/privacy}","received_events_url":"https://api.github.com/users/pnorman/received_events","type":"User","site_admin":false},"body":"This adds a random symbology for forests, lightens forests, and unifies natural=wood and landuse=forest rendering.\r\n\r\nThe colours for `landuse=forest` and `natural=wood` have been unified and slightly lightened.\r\n\r\n[z10](http://www.openstreetmap.org/#map=10/49.2902/-122.3245)\r\n![image](https://cloud.githubusercontent.com/assets/1190866/5795157/d2ea01a6-9f3d-11e4-92bd-8813a99c9c2d.png)\r\n\r\nAt higher zooms, a randomized symbology has been added, designed to not imply a particular type of forest.\r\n\r\n[z15](http://www.openstreetmap.org/#map=15/49.2138/-122.9021)\r\n![image](https://cloud.githubusercontent.com/assets/1190866/5795210/53a275a2-9f3f-11e4-95fa-5da977296750.png)\r\n\r\n[z16](http://www.openstreetmap.org/#map=16/49.2363/-122.8884)\r\n![image](https://cloud.githubusercontent.com/assets/1190866/5795223/8daa328a-9f3f-11e4-889e-78225c923525.png)\r\n\r\nAs the new symbols are an overlay, they show even if there is another landcover within the forest.\r\n[z15](http://www.openstreetmap.org/#map=15/49.2807/-122.9366)\r\n![image](https://cloud.githubusercontent.com/assets/1190866/5795166/2ed5ca90-9f3e-11e4-8331-939687f53909.png)\r\n\r\nThey are a repeating 512x512 pattern, which is hopefully large enough that the repeating nature of the pattern can't be seen.\r\n\r\n[z16, original not shown](http://www.openstreetmap.org/#map=16/49.2570/-122.8242)\r\n![image](https://cloud.githubusercontent.com/assets/1190866/5795242/29bc3ccc-9f40-11e4-9c53-b5d69206c145.png)\r\n\r\nWith woods and forests no longer being primarily one colour, the name text and halo was reworked\r\n\r\n[z17](http://www.openstreetmap.org/#map=17/49.25220/-122.81239)\r\n![image](https://cloud.githubusercontent.com/assets/1190866/5795227/d7286fe4-9f3f-11e4-97f1-26b6965ab1c1.png)\r\n\r\nUnfortunately I was unable to find a tree symbol that does not imply something about the type of tree, but this does open up the door to using different symbols for different types of forests (#822)\r\n\r\n`landuse=forest` and `natural=wood` now render the same. For some mappers there was a difference between what they meant - unfortunately the difference varied among mappers, making the two different tags effectively the same globally (https://github.com/gravitystorm/openstreetmap-carto/issues/647#issuecomment-52816195) and the distinction between them useless. This was also not captured in the existing cartography.\r\n\r\nFixes #938\r\nFixes forest part of #937\r\nCloses pnorman#6\r\n\r\nThanks to @SK53 for symbol selection and @imagico for the point generation tool.","created_at":"2015-01-19T02:43:11Z","updated_at":"2015-01-23T12:16:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f42388673000c413808637baa8f5e9a49a92a751","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/1242/commits","review_comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/1242/comments","review_comment_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/1242/comments","statuses_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/statuses/0c527d5aa0bcdd0ed85d20993792add3aeb316ce","head":{"label":"pnorman:random_forest","ref":"random_forest","sha":"0c527d5aa0bcdd0ed85d20993792add3aeb316ce","user":{"login":"pnorman","id":1190866,"avatar_url":"https://avatars.githubusercontent.com/u/1190866?v=3","gravatar_id":"","url":"https://api.github.com/users/pnorman","html_url":"https://github.com/pnorman","followers_url":"https://api.github.com/users/pnorman/followers","following_url":"https://api.github.com/users/pnorman/following{/other_user}","gists_url":"https://api.github.com/users/pnorman/gists{/gist_id}","starred_url":"https://api.github.com/users/pnorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnorman/subscriptions","organizations_url":"https://api.github.com/users/pnorman/orgs","repos_url":"https://api.github.com/users/pnorman/repos","events_url":"https://api.github.com/users/pnorman/events{/privacy}","received_events_url":"https://api.github.com/users/pnorman/received_events","type":"User","site_admin":false},"repo":{"id":10091378,"name":"openstreetmap-carto","full_name":"pnorman/openstreetmap-carto","owner":{"login":"pnorman","id":1190866,"avatar_url":"https://avatars.githubusercontent.com/u/1190866?v=3","gravatar_id":"","url":"https://api.github.com/users/pnorman","html_url":"https://github.com/pnorman","followers_url":"https://api.github.com/users/pnorman/followers","following_url":"https://api.github.com/users/pnorman/following{/other_user}","gists_url":"https://api.github.com/users/pnorman/gists{/gist_id}","starred_url":"https://api.github.com/users/pnorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnorman/subscriptions","organizations_url":"https://api.github.com/users/pnorman/orgs","repos_url":"https://api.github.com/users/pnorman/repos","events_url":"https://api.github.com/users/pnorman/events{/privacy}","received_events_url":"https://api.github.com/users/pnorman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pnorman/openstreetmap-carto","description":"A project to re-implement the standard OpenStreetMap mapnik style, in CartoCSS","fork":true,"url":"https://api.github.com/repos/pnorman/openstreetmap-carto","forks_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/forks","keys_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/teams","hooks_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/hooks","issue_events_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/issues/events{/number}","events_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/events","assignees_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/assignees{/user}","branches_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/branches{/branch}","tags_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/tags","blobs_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/git/refs{/sha}","trees_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/statuses/{sha}","languages_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/languages","stargazers_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/stargazers","contributors_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/contributors","subscribers_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/subscribers","subscription_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/subscription","commits_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/commits{/sha}","git_commits_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/git/commits{/sha}","comments_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/comments{/number}","issue_comment_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/issues/comments/{number}","contents_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/contents/{+path}","compare_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/merges","archive_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/downloads","issues_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/issues{/number}","pulls_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/pulls{/number}","milestones_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/milestones{/number}","notifications_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/labels{/name}","releases_url":"https://api.github.com/repos/pnorman/openstreetmap-carto/releases{/id}","created_at":"2013-05-16T01:30:02Z","updated_at":"2015-01-17T12:15:36Z","pushed_at":"2015-01-23T12:15:09Z","git_url":"git://github.com/pnorman/openstreetmap-carto.git","ssh_url":"git@github.com:pnorman/openstreetmap-carto.git","clone_url":"https://github.com/pnorman/openstreetmap-carto.git","svn_url":"https://github.com/pnorman/openstreetmap-carto","homepage":null,"size":2837,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"gravitystorm:master","ref":"master","sha":"eabf222afd9b30c4a41f7dae3db4eaf52aee162b","user":{"login":"gravitystorm","id":360803,"avatar_url":"https://avatars.githubusercontent.com/u/360803?v=3","gravatar_id":"","url":"https://api.github.com/users/gravitystorm","html_url":"https://github.com/gravitystorm","followers_url":"https://api.github.com/users/gravitystorm/followers","following_url":"https://api.github.com/users/gravitystorm/following{/other_user}","gists_url":"https://api.github.com/users/gravitystorm/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitystorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitystorm/subscriptions","organizations_url":"https://api.github.com/users/gravitystorm/orgs","repos_url":"https://api.github.com/users/gravitystorm/repos","events_url":"https://api.github.com/users/gravitystorm/events{/privacy}","received_events_url":"https://api.github.com/users/gravitystorm/received_events","type":"User","site_admin":false},"repo":{"id":6707453,"name":"openstreetmap-carto","full_name":"gravitystorm/openstreetmap-carto","owner":{"login":"gravitystorm","id":360803,"avatar_url":"https://avatars.githubusercontent.com/u/360803?v=3","gravatar_id":"","url":"https://api.github.com/users/gravitystorm","html_url":"https://github.com/gravitystorm","followers_url":"https://api.github.com/users/gravitystorm/followers","following_url":"https://api.github.com/users/gravitystorm/following{/other_user}","gists_url":"https://api.github.com/users/gravitystorm/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitystorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitystorm/subscriptions","organizations_url":"https://api.github.com/users/gravitystorm/orgs","repos_url":"https://api.github.com/users/gravitystorm/repos","events_url":"https://api.github.com/users/gravitystorm/events{/privacy}","received_events_url":"https://api.github.com/users/gravitystorm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gravitystorm/openstreetmap-carto","description":"A project to re-implement the standard OpenStreetMap mapnik style, in CartoCSS","fork":false,"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto","forks_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/forks","keys_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/teams","hooks_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/hooks","issue_events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/events{/number}","events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/events","assignees_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/assignees{/user}","branches_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/branches{/branch}","tags_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/tags","blobs_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/refs{/sha}","trees_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/statuses/{sha}","languages_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/languages","stargazers_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/stargazers","contributors_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/contributors","subscribers_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/subscribers","subscription_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/subscription","commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/commits{/sha}","git_commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/commits{/sha}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/comments{/number}","issue_comment_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/comments/{number}","contents_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/contents/{+path}","compare_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/merges","archive_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/downloads","issues_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues{/number}","pulls_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls{/number}","milestones_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/milestones{/number}","notifications_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/labels{/name}","releases_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/releases{/id}","created_at":"2012-11-15T16:06:16Z","updated_at":"2015-01-20T08:00:05Z","pushed_at":"2015-01-19T20:31:36Z","git_url":"git://github.com/gravitystorm/openstreetmap-carto.git","ssh_url":"git@github.com:gravitystorm/openstreetmap-carto.git","clone_url":"https://github.com/gravitystorm/openstreetmap-carto.git","svn_url":"https://github.com/gravitystorm/openstreetmap-carto","homepage":null,"size":6126,"stargazers_count":258,"watchers_count":258,"language":"CartoCSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":151,"mirror_url":null,"open_issues_count":337,"forks":151,"open_issues":337,"watchers":258,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/1242"},"html":{"href":"https://github.com/gravitystorm/openstreetmap-carto/pull/1242"},"issue":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/1242"},"comments":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/1242/comments"},"review_comments":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/1242/comments"},"review_comment":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/1242/commits"},"statuses":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/statuses/0c527d5aa0bcdd0ed85d20993792add3aeb316ce"}}}}