{"action":"closed","number":263,"pull_request":{"url":"https://api.github.com/repos/ga4gh/server/pulls/263","id":31500413,"html_url":"https://github.com/ga4gh/server/pull/263","diff_url":"https://github.com/ga4gh/server/pull/263.diff","patch_url":"https://github.com/ga4gh/server/pull/263.patch","issue_url":"https://api.github.com/repos/ga4gh/server/issues/263","number":263,"state":"closed","locked":false,"title":"Paging test moved from wormtable to simulated backend.","user":{"login":"macieksmuga","id":6685511,"avatar_url":"https://avatars.githubusercontent.com/u/6685511?v=3","gravatar_id":"","url":"https://api.github.com/users/macieksmuga","html_url":"https://github.com/macieksmuga","followers_url":"https://api.github.com/users/macieksmuga/followers","following_url":"https://api.github.com/users/macieksmuga/following{/other_user}","gists_url":"https://api.github.com/users/macieksmuga/gists{/gist_id}","starred_url":"https://api.github.com/users/macieksmuga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macieksmuga/subscriptions","organizations_url":"https://api.github.com/users/macieksmuga/orgs","repos_url":"https://api.github.com/users/macieksmuga/repos","events_url":"https://api.github.com/users/macieksmuga/events{/privacy}","received_events_url":"https://api.github.com/users/macieksmuga/received_events","type":"User","site_admin":false},"body":"New `TestAbstractBackend` class introduced in `unit/test_backends.py`,\r\ngathers together backend implementation independent logic,\r\n`TestSimulatedBackend` and `TestWormtableBackend` classes inherit from it.\r\n`TestPaging` is a new subclass of `TestSimulatedBackend`. This setup\r\nshould provide a clean migration path out of Wormtable for testing backend.\r\n\r\n For now, I could only pull `TestVariantSets.testPagination()` out of \r\n`TestWormtableBackend`, as `SimulatedBackend` only provides mock objects\r\nfor `VariantSet`s. As `SimulatedBackend` grows, the other tests in `test_backends.py`\r\ncan be pulled out as well.\r\n\r\nI could technically pull out `TestVariantSets.testIds()` now as well, but this doesn't fit\r\nthe new `TestPaging` class's focus on pagination. \r\n\r\nAddresses issue #241","created_at":"2015-03-19T07:24:57Z","updated_at":"2015-03-25T17:45:41Z","closed_at":"2015-03-25T17:45:41Z","merged_at":"2015-03-25T17:45:41Z","merge_commit_sha":"bdec5d6836d236f46581e9971a509552828a0b83","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ga4gh/server/pulls/263/commits","review_comments_url":"https://api.github.com/repos/ga4gh/server/pulls/263/comments","review_comment_url":"https://api.github.com/repos/ga4gh/server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ga4gh/server/issues/263/comments","statuses_url":"https://api.github.com/repos/ga4gh/server/statuses/d82c8058167146c342584eee676741e8e7b0a504","head":{"label":"macieksmuga:test_paging","ref":"test_paging","sha":"d82c8058167146c342584eee676741e8e7b0a504","user":{"login":"macieksmuga","id":6685511,"avatar_url":"https://avatars.githubusercontent.com/u/6685511?v=3","gravatar_id":"","url":"https://api.github.com/users/macieksmuga","html_url":"https://github.com/macieksmuga","followers_url":"https://api.github.com/users/macieksmuga/followers","following_url":"https://api.github.com/users/macieksmuga/following{/other_user}","gists_url":"https://api.github.com/users/macieksmuga/gists{/gist_id}","starred_url":"https://api.github.com/users/macieksmuga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macieksmuga/subscriptions","organizations_url":"https://api.github.com/users/macieksmuga/orgs","repos_url":"https://api.github.com/users/macieksmuga/repos","events_url":"https://api.github.com/users/macieksmuga/events{/privacy}","received_events_url":"https://api.github.com/users/macieksmuga/received_events","type":"User","site_admin":false},"repo":{"id":30611010,"name":"server","full_name":"macieksmuga/server","owner":{"login":"macieksmuga","id":6685511,"avatar_url":"https://avatars.githubusercontent.com/u/6685511?v=3","gravatar_id":"","url":"https://api.github.com/users/macieksmuga","html_url":"https://github.com/macieksmuga","followers_url":"https://api.github.com/users/macieksmuga/followers","following_url":"https://api.github.com/users/macieksmuga/following{/other_user}","gists_url":"https://api.github.com/users/macieksmuga/gists{/gist_id}","starred_url":"https://api.github.com/users/macieksmuga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macieksmuga/subscriptions","organizations_url":"https://api.github.com/users/macieksmuga/orgs","repos_url":"https://api.github.com/users/macieksmuga/repos","events_url":"https://api.github.com/users/macieksmuga/events{/privacy}","received_events_url":"https://api.github.com/users/macieksmuga/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/macieksmuga/server","description":"A reference implementation of the APIs defined in the schemas repository.","fork":true,"url":"https://api.github.com/repos/macieksmuga/server","forks_url":"https://api.github.com/repos/macieksmuga/server/forks","keys_url":"https://api.github.com/repos/macieksmuga/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/macieksmuga/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/macieksmuga/server/teams","hooks_url":"https://api.github.com/repos/macieksmuga/server/hooks","issue_events_url":"https://api.github.com/repos/macieksmuga/server/issues/events{/number}","events_url":"https://api.github.com/repos/macieksmuga/server/events","assignees_url":"https://api.github.com/repos/macieksmuga/server/assignees{/user}","branches_url":"https://api.github.com/repos/macieksmuga/server/branches{/branch}","tags_url":"https://api.github.com/repos/macieksmuga/server/tags","blobs_url":"https://api.github.com/repos/macieksmuga/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/macieksmuga/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/macieksmuga/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/macieksmuga/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/macieksmuga/server/statuses/{sha}","languages_url":"https://api.github.com/repos/macieksmuga/server/languages","stargazers_url":"https://api.github.com/repos/macieksmuga/server/stargazers","contributors_url":"https://api.github.com/repos/macieksmuga/server/contributors","subscribers_url":"https://api.github.com/repos/macieksmuga/server/subscribers","subscription_url":"https://api.github.com/repos/macieksmuga/server/subscription","commits_url":"https://api.github.com/repos/macieksmuga/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/macieksmuga/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/macieksmuga/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/macieksmuga/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/macieksmuga/server/contents/{+path}","compare_url":"https://api.github.com/repos/macieksmuga/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/macieksmuga/server/merges","archive_url":"https://api.github.com/repos/macieksmuga/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/macieksmuga/server/downloads","issues_url":"https://api.github.com/repos/macieksmuga/server/issues{/number}","pulls_url":"https://api.github.com/repos/macieksmuga/server/pulls{/number}","milestones_url":"https://api.github.com/repos/macieksmuga/server/milestones{/number}","notifications_url":"https://api.github.com/repos/macieksmuga/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/macieksmuga/server/labels{/name}","releases_url":"https://api.github.com/repos/macieksmuga/server/releases{/id}","created_at":"2015-02-10T19:44:42Z","updated_at":"2015-03-25T17:08:22Z","pushed_at":"2015-03-25T17:22:32Z","git_url":"git://github.com/macieksmuga/server.git","ssh_url":"git@github.com:macieksmuga/server.git","clone_url":"https://github.com/macieksmuga/server.git","svn_url":"https://github.com/macieksmuga/server","homepage":null,"size":2099,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ga4gh:master","ref":"master","sha":"7394fe7f634410d546e3be116256cb200f1abf65","user":{"login":"ga4gh","id":6921777,"avatar_url":"https://avatars.githubusercontent.com/u/6921777?v=3","gravatar_id":"","url":"https://api.github.com/users/ga4gh","html_url":"https://github.com/ga4gh","followers_url":"https://api.github.com/users/ga4gh/followers","following_url":"https://api.github.com/users/ga4gh/following{/other_user}","gists_url":"https://api.github.com/users/ga4gh/gists{/gist_id}","starred_url":"https://api.github.com/users/ga4gh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ga4gh/subscriptions","organizations_url":"https://api.github.com/users/ga4gh/orgs","repos_url":"https://api.github.com/users/ga4gh/repos","events_url":"https://api.github.com/users/ga4gh/events{/privacy}","received_events_url":"https://api.github.com/users/ga4gh/received_events","type":"Organization","site_admin":false},"repo":{"id":22882621,"name":"server","full_name":"ga4gh/server","owner":{"login":"ga4gh","id":6921777,"avatar_url":"https://avatars.githubusercontent.com/u/6921777?v=3","gravatar_id":"","url":"https://api.github.com/users/ga4gh","html_url":"https://github.com/ga4gh","followers_url":"https://api.github.com/users/ga4gh/followers","following_url":"https://api.github.com/users/ga4gh/following{/other_user}","gists_url":"https://api.github.com/users/ga4gh/gists{/gist_id}","starred_url":"https://api.github.com/users/ga4gh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ga4gh/subscriptions","organizations_url":"https://api.github.com/users/ga4gh/orgs","repos_url":"https://api.github.com/users/ga4gh/repos","events_url":"https://api.github.com/users/ga4gh/events{/privacy}","received_events_url":"https://api.github.com/users/ga4gh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ga4gh/server","description":"A reference implementation of the APIs defined in the schemas repository.","fork":false,"url":"https://api.github.com/repos/ga4gh/server","forks_url":"https://api.github.com/repos/ga4gh/server/forks","keys_url":"https://api.github.com/repos/ga4gh/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ga4gh/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ga4gh/server/teams","hooks_url":"https://api.github.com/repos/ga4gh/server/hooks","issue_events_url":"https://api.github.com/repos/ga4gh/server/issues/events{/number}","events_url":"https://api.github.com/repos/ga4gh/server/events","assignees_url":"https://api.github.com/repos/ga4gh/server/assignees{/user}","branches_url":"https://api.github.com/repos/ga4gh/server/branches{/branch}","tags_url":"https://api.github.com/repos/ga4gh/server/tags","blobs_url":"https://api.github.com/repos/ga4gh/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ga4gh/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ga4gh/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/ga4gh/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ga4gh/server/statuses/{sha}","languages_url":"https://api.github.com/repos/ga4gh/server/languages","stargazers_url":"https://api.github.com/repos/ga4gh/server/stargazers","contributors_url":"https://api.github.com/repos/ga4gh/server/contributors","subscribers_url":"https://api.github.com/repos/ga4gh/server/subscribers","subscription_url":"https://api.github.com/repos/ga4gh/server/subscription","commits_url":"https://api.github.com/repos/ga4gh/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/ga4gh/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/ga4gh/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/ga4gh/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/ga4gh/server/contents/{+path}","compare_url":"https://api.github.com/repos/ga4gh/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ga4gh/server/merges","archive_url":"https://api.github.com/repos/ga4gh/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ga4gh/server/downloads","issues_url":"https://api.github.com/repos/ga4gh/server/issues{/number}","pulls_url":"https://api.github.com/repos/ga4gh/server/pulls{/number}","milestones_url":"https://api.github.com/repos/ga4gh/server/milestones{/number}","notifications_url":"https://api.github.com/repos/ga4gh/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ga4gh/server/labels{/name}","releases_url":"https://api.github.com/repos/ga4gh/server/releases{/id}","created_at":"2014-08-12T15:31:49Z","updated_at":"2015-03-25T17:05:44Z","pushed_at":"2015-03-25T17:45:41Z","git_url":"git://github.com/ga4gh/server.git","ssh_url":"git@github.com:ga4gh/server.git","clone_url":"https://github.com/ga4gh/server.git","svn_url":"https://github.com/ga4gh/server","homepage":null,"size":4471,"stargazers_count":26,"watchers_count":26,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":43,"forks":25,"open_issues":43,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ga4gh/server/pulls/263"},"html":{"href":"https://github.com/ga4gh/server/pull/263"},"issue":{"href":"https://api.github.com/repos/ga4gh/server/issues/263"},"comments":{"href":"https://api.github.com/repos/ga4gh/server/issues/263/comments"},"review_comments":{"href":"https://api.github.com/repos/ga4gh/server/pulls/263/comments"},"review_comment":{"href":"https://api.github.com/repos/ga4gh/server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ga4gh/server/pulls/263/commits"},"statuses":{"href":"https://api.github.com/repos/ga4gh/server/statuses/d82c8058167146c342584eee676741e8e7b0a504"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dcolligan","id":7422120,"avatar_url":"https://avatars.githubusercontent.com/u/7422120?v=3","gravatar_id":"","url":"https://api.github.com/users/dcolligan","html_url":"https://github.com/dcolligan","followers_url":"https://api.github.com/users/dcolligan/followers","following_url":"https://api.github.com/users/dcolligan/following{/other_user}","gists_url":"https://api.github.com/users/dcolligan/gists{/gist_id}","starred_url":"https://api.github.com/users/dcolligan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcolligan/subscriptions","organizations_url":"https://api.github.com/users/dcolligan/orgs","repos_url":"https://api.github.com/users/dcolligan/repos","events_url":"https://api.github.com/users/dcolligan/events{/privacy}","received_events_url":"https://api.github.com/users/dcolligan/received_events","type":"User","site_admin":false},"comments":12,"review_comments":8,"commits":1,"additions":195,"deletions":80,"changed_files":2}}