{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/48479650","id":48479650,"diff_hunk":"@@ -52,7 +52,7 @@ public function __toString()\n         foreach ($this->headers as $name => $values) {\n             $name = implode('-', array_map('ucfirst', explode('-', $name)));\n             foreach ($values as $value) {\n-                $content .= sprintf(\"%-{$max}s %s\\r\\n\", $name.':', $value);\n+                $content .= sprintf(\"%-${max}s %s\\r\\n\", $name.':', $value);","path":"src/Symfony/Component/HttpFoundation/HeaderBag.php","position":5,"original_position":5,"commit_id":"001647476be433fcce00b98653fff6a434dea054","original_commit_id":"001647476be433fcce00b98653fff6a434dea054","user":{"login":"kalessil","id":1577185,"avatar_url":"https://avatars.githubusercontent.com/u/1577185?v=3","gravatar_id":"","url":"https://api.github.com/users/kalessil","html_url":"https://github.com/kalessil","followers_url":"https://api.github.com/users/kalessil/followers","following_url":"https://api.github.com/users/kalessil/following{/other_user}","gists_url":"https://api.github.com/users/kalessil/gists{/gist_id}","starred_url":"https://api.github.com/users/kalessil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalessil/subscriptions","organizations_url":"https://api.github.com/users/kalessil/orgs","repos_url":"https://api.github.com/users/kalessil/repos","events_url":"https://api.github.com/users/kalessil/events{/privacy}","received_events_url":"https://api.github.com/users/kalessil/received_events","type":"User","site_admin":false},"body":"It were 4 more cases with sprintf and inline variables, as ${...} structure. Should I make adjustments to {$...} then?","created_at":"2015-12-28T13:41:04Z","updated_at":"2015-12-28T13:41:04Z","html_url":"https://github.com/symfony/symfony/pull/17085#discussion_r48479650","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/17085","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/48479650"},"html":{"href":"https://github.com/symfony/symfony/pull/17085#discussion_r48479650"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/17085"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/17085","id":54237763,"html_url":"https://github.com/symfony/symfony/pull/17085","diff_url":"https://github.com/symfony/symfony/pull/17085.diff","patch_url":"https://github.com/symfony/symfony/pull/17085.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/17085","number":17085,"state":"open","locked":false,"title":"[2.3] Static Code Analysis for Components","user":{"login":"kalessil","id":1577185,"avatar_url":"https://avatars.githubusercontent.com/u/1577185?v=3","gravatar_id":"","url":"https://api.github.com/users/kalessil","html_url":"https://github.com/kalessil","followers_url":"https://api.github.com/users/kalessil/followers","following_url":"https://api.github.com/users/kalessil/following{/other_user}","gists_url":"https://api.github.com/users/kalessil/gists{/gist_id}","starred_url":"https://api.github.com/users/kalessil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalessil/subscriptions","organizations_url":"https://api.github.com/users/kalessil/orgs","repos_url":"https://api.github.com/users/kalessil/repos","events_url":"https://api.github.com/users/kalessil/events{/privacy}","received_events_url":"https://api.github.com/users/kalessil/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | n/a\r\n| License       | MIT\r\n| Doc PR        | n/a\r\n\r\nStatic Code Analysis with Php Inspections (EA Extended):\r\n    - remaining mkdir race conditions\r\n    - continue miss-usage in switch","created_at":"2015-12-21T09:53:22Z","updated_at":"2015-12-28T13:41:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c6addb35e3c93047959790f2e7ea80a7eebd9c5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/17085/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/17085/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/17085/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/001647476be433fcce00b98653fff6a434dea054","head":{"label":"kalessil:2.3-RC-CM","ref":"2.3-RC-CM","sha":"001647476be433fcce00b98653fff6a434dea054","user":{"login":"kalessil","id":1577185,"avatar_url":"https://avatars.githubusercontent.com/u/1577185?v=3","gravatar_id":"","url":"https://api.github.com/users/kalessil","html_url":"https://github.com/kalessil","followers_url":"https://api.github.com/users/kalessil/followers","following_url":"https://api.github.com/users/kalessil/following{/other_user}","gists_url":"https://api.github.com/users/kalessil/gists{/gist_id}","starred_url":"https://api.github.com/users/kalessil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalessil/subscriptions","organizations_url":"https://api.github.com/users/kalessil/orgs","repos_url":"https://api.github.com/users/kalessil/repos","events_url":"https://api.github.com/users/kalessil/events{/privacy}","received_events_url":"https://api.github.com/users/kalessil/received_events","type":"User","site_admin":false},"repo":{"id":31438589,"name":"symfony","full_name":"kalessil/symfony","owner":{"login":"kalessil","id":1577185,"avatar_url":"https://avatars.githubusercontent.com/u/1577185?v=3","gravatar_id":"","url":"https://api.github.com/users/kalessil","html_url":"https://github.com/kalessil","followers_url":"https://api.github.com/users/kalessil/followers","following_url":"https://api.github.com/users/kalessil/following{/other_user}","gists_url":"https://api.github.com/users/kalessil/gists{/gist_id}","starred_url":"https://api.github.com/users/kalessil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalessil/subscriptions","organizations_url":"https://api.github.com/users/kalessil/orgs","repos_url":"https://api.github.com/users/kalessil/repos","events_url":"https://api.github.com/users/kalessil/events{/privacy}","received_events_url":"https://api.github.com/users/kalessil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kalessil/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/kalessil/symfony","forks_url":"https://api.github.com/repos/kalessil/symfony/forks","keys_url":"https://api.github.com/repos/kalessil/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kalessil/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kalessil/symfony/teams","hooks_url":"https://api.github.com/repos/kalessil/symfony/hooks","issue_events_url":"https://api.github.com/repos/kalessil/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/kalessil/symfony/events","assignees_url":"https://api.github.com/repos/kalessil/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/kalessil/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/kalessil/symfony/tags","blobs_url":"https://api.github.com/repos/kalessil/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kalessil/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kalessil/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/kalessil/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kalessil/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/kalessil/symfony/languages","stargazers_url":"https://api.github.com/repos/kalessil/symfony/stargazers","contributors_url":"https://api.github.com/repos/kalessil/symfony/contributors","subscribers_url":"https://api.github.com/repos/kalessil/symfony/subscribers","subscription_url":"https://api.github.com/repos/kalessil/symfony/subscription","commits_url":"https://api.github.com/repos/kalessil/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/kalessil/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/kalessil/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/kalessil/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/kalessil/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/kalessil/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kalessil/symfony/merges","archive_url":"https://api.github.com/repos/kalessil/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kalessil/symfony/downloads","issues_url":"https://api.github.com/repos/kalessil/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/kalessil/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/kalessil/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/kalessil/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kalessil/symfony/labels{/name}","releases_url":"https://api.github.com/repos/kalessil/symfony/releases{/id}","created_at":"2015-02-27T20:51:56Z","updated_at":"2015-02-27T20:52:11Z","pushed_at":"2015-12-25T19:52:30Z","git_url":"git://github.com/kalessil/symfony.git","ssh_url":"git@github.com:kalessil/symfony.git","clone_url":"https://github.com/kalessil/symfony.git","svn_url":"https://github.com/kalessil/symfony","homepage":"symfony.com","size":58348,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.7"}},"base":{"label":"symfony:2.3","ref":"2.3","sha":"36a514181f3e51d3ab8bdf06c2aaa2fbbb2bf84f","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-12-28T12:55:11Z","pushed_at":"2015-12-28T13:35:15Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":97331,"stargazers_count":11391,"watchers_count":11391,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4498,"mirror_url":null,"open_issues_count":889,"forks":4498,"open_issues":889,"watchers":11391,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/17085"},"html":{"href":"https://github.com/symfony/symfony/pull/17085"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/17085"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/17085/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/17085/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/17085/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/001647476be433fcce00b98653fff6a434dea054"}}}}