{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/37167529","id":37167529,"diff_hunk":"@@ -406,9 +403,7 @@ public void insertOrReplaceRecord(T record) throws IOException {\n \t\t\t\t\t\treturn;\n \t\t\t\t\t}\n \t\t\t\t}\n-\t\t\t\telse {\n-\t\t\t\t\tnumInSegment++;\n-\t\t\t\t}\n+\t\t\t\tnumInSegment++;","path":"flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/CompactingHashTable.java","position":33,"original_position":33,"commit_id":"3bc7a124718e618656079cca8f78bf58b61eb5ec","original_commit_id":"3bc7a124718e618656079cca8f78bf58b61eb5ec","user":{"login":"sachingoel0101","id":8874261,"avatar_url":"https://avatars.githubusercontent.com/u/8874261?v=3","gravatar_id":"","url":"https://api.github.com/users/sachingoel0101","html_url":"https://github.com/sachingoel0101","followers_url":"https://api.github.com/users/sachingoel0101/followers","following_url":"https://api.github.com/users/sachingoel0101/following{/other_user}","gists_url":"https://api.github.com/users/sachingoel0101/gists{/gist_id}","starred_url":"https://api.github.com/users/sachingoel0101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachingoel0101/subscriptions","organizations_url":"https://api.github.com/users/sachingoel0101/orgs","repos_url":"https://api.github.com/users/sachingoel0101/repos","events_url":"https://api.github.com/users/sachingoel0101/events{/privacy}","received_events_url":"https://api.github.com/users/sachingoel0101/received_events","type":"User","site_admin":false},"body":"It's a local variable, so this doesn't matter.","created_at":"2015-08-17T08:37:37Z","updated_at":"2015-08-17T08:37:37Z","html_url":"https://github.com/apache/flink/pull/1029#discussion_r37167529","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/1029","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/37167529"},"html":{"href":"https://github.com/apache/flink/pull/1029#discussion_r37167529"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/1029"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/1029","id":42551781,"html_url":"https://github.com/apache/flink/pull/1029","diff_url":"https://github.com/apache/flink/pull/1029.diff","patch_url":"https://github.com/apache/flink/pull/1029.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/1029","number":1029,"state":"open","locked":false,"title":"[FLINK-2534][RUNTIME]Improve in CompactingHashTable.java","user":{"login":"HuangWHWHW","id":13193847,"avatar_url":"https://avatars.githubusercontent.com/u/13193847?v=3","gravatar_id":"","url":"https://api.github.com/users/HuangWHWHW","html_url":"https://github.com/HuangWHWHW","followers_url":"https://api.github.com/users/HuangWHWHW/followers","following_url":"https://api.github.com/users/HuangWHWHW/following{/other_user}","gists_url":"https://api.github.com/users/HuangWHWHW/gists{/gist_id}","starred_url":"https://api.github.com/users/HuangWHWHW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuangWHWHW/subscriptions","organizations_url":"https://api.github.com/users/HuangWHWHW/orgs","repos_url":"https://api.github.com/users/HuangWHWHW/repos","events_url":"https://api.github.com/users/HuangWHWHW/events{/privacy}","received_events_url":"https://api.github.com/users/HuangWHWHW/received_events","type":"User","site_admin":false},"body":"1. Remove the var currentForwardPointer is unused in the code since this can reduce little memory cost.\r\n2.Take the numInSegment++ out of the if branch and remove the else branch to decrease the loop complexity.\r\n3.Improve the \"while\" to a formula:\r\nnumBuckets += numPartitions - numBuckets % numPartitions;\r\n\r\nOtherwise, I found some places just simply using \"for\" to find a max or min number like the code following:\r\n'private int getMaxPartition() {\r\n\t\tint maxPartition = 0;\r\n\t\tfor(InMemoryPartition<T> p1 : this.partitions) {\r\n\t\t\tif(p1.getBlockCount() > maxPartition) {\r\n\t\t\t\tmaxPartition = p1.getBlockCount();\r\n\t\t\t}\r\n\t\t}\r\n\t\treturn maxPartition;\r\n\t}'\r\nThis does some harm to the performance.\r\nShould we use some algorithm(.i.e RMQ, Segment tree, Heap structure) to take a optimization?\r\n","created_at":"2015-08-17T03:32:45Z","updated_at":"2015-08-17T08:37:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e51dae18d054c038643c9cea5ceec8c518754b8f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/1029/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/1029/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/1029/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/3bc7a124718e618656079cca8f78bf58b61eb5ec","head":{"label":"HuangWHWHW:FLINK-2534","ref":"FLINK-2534","sha":"3bc7a124718e618656079cca8f78bf58b61eb5ec","user":{"login":"HuangWHWHW","id":13193847,"avatar_url":"https://avatars.githubusercontent.com/u/13193847?v=3","gravatar_id":"","url":"https://api.github.com/users/HuangWHWHW","html_url":"https://github.com/HuangWHWHW","followers_url":"https://api.github.com/users/HuangWHWHW/followers","following_url":"https://api.github.com/users/HuangWHWHW/following{/other_user}","gists_url":"https://api.github.com/users/HuangWHWHW/gists{/gist_id}","starred_url":"https://api.github.com/users/HuangWHWHW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuangWHWHW/subscriptions","organizations_url":"https://api.github.com/users/HuangWHWHW/orgs","repos_url":"https://api.github.com/users/HuangWHWHW/repos","events_url":"https://api.github.com/users/HuangWHWHW/events{/privacy}","received_events_url":"https://api.github.com/users/HuangWHWHW/received_events","type":"User","site_admin":false},"repo":{"id":38603893,"name":"flink","full_name":"HuangWHWHW/flink","owner":{"login":"HuangWHWHW","id":13193847,"avatar_url":"https://avatars.githubusercontent.com/u/13193847?v=3","gravatar_id":"","url":"https://api.github.com/users/HuangWHWHW","html_url":"https://github.com/HuangWHWHW","followers_url":"https://api.github.com/users/HuangWHWHW/followers","following_url":"https://api.github.com/users/HuangWHWHW/following{/other_user}","gists_url":"https://api.github.com/users/HuangWHWHW/gists{/gist_id}","starred_url":"https://api.github.com/users/HuangWHWHW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuangWHWHW/subscriptions","organizations_url":"https://api.github.com/users/HuangWHWHW/orgs","repos_url":"https://api.github.com/users/HuangWHWHW/repos","events_url":"https://api.github.com/users/HuangWHWHW/events{/privacy}","received_events_url":"https://api.github.com/users/HuangWHWHW/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HuangWHWHW/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/HuangWHWHW/flink","forks_url":"https://api.github.com/repos/HuangWHWHW/flink/forks","keys_url":"https://api.github.com/repos/HuangWHWHW/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HuangWHWHW/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HuangWHWHW/flink/teams","hooks_url":"https://api.github.com/repos/HuangWHWHW/flink/hooks","issue_events_url":"https://api.github.com/repos/HuangWHWHW/flink/issues/events{/number}","events_url":"https://api.github.com/repos/HuangWHWHW/flink/events","assignees_url":"https://api.github.com/repos/HuangWHWHW/flink/assignees{/user}","branches_url":"https://api.github.com/repos/HuangWHWHW/flink/branches{/branch}","tags_url":"https://api.github.com/repos/HuangWHWHW/flink/tags","blobs_url":"https://api.github.com/repos/HuangWHWHW/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HuangWHWHW/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HuangWHWHW/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/HuangWHWHW/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HuangWHWHW/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/HuangWHWHW/flink/languages","stargazers_url":"https://api.github.com/repos/HuangWHWHW/flink/stargazers","contributors_url":"https://api.github.com/repos/HuangWHWHW/flink/contributors","subscribers_url":"https://api.github.com/repos/HuangWHWHW/flink/subscribers","subscription_url":"https://api.github.com/repos/HuangWHWHW/flink/subscription","commits_url":"https://api.github.com/repos/HuangWHWHW/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/HuangWHWHW/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/HuangWHWHW/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/HuangWHWHW/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/HuangWHWHW/flink/contents/{+path}","compare_url":"https://api.github.com/repos/HuangWHWHW/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HuangWHWHW/flink/merges","archive_url":"https://api.github.com/repos/HuangWHWHW/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HuangWHWHW/flink/downloads","issues_url":"https://api.github.com/repos/HuangWHWHW/flink/issues{/number}","pulls_url":"https://api.github.com/repos/HuangWHWHW/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/HuangWHWHW/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/HuangWHWHW/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HuangWHWHW/flink/labels{/name}","releases_url":"https://api.github.com/repos/HuangWHWHW/flink/releases{/id}","created_at":"2015-07-06T07:25:09Z","updated_at":"2015-07-06T07:25:20Z","pushed_at":"2015-08-17T06:21:35Z","git_url":"git://github.com/HuangWHWHW/flink.git","ssh_url":"git@github.com:HuangWHWHW/flink.git","clone_url":"https://github.com/HuangWHWHW/flink.git","svn_url":"https://github.com/HuangWHWHW/flink","homepage":null,"size":56322,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e4e44bedbfb68770fb2cbd89dedaed892b58274d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","created_at":"2014-06-07T07:00:10Z","updated_at":"2015-08-17T00:46:09Z","pushed_at":"2015-08-17T06:38:35Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":2477824,"stargazers_count":563,"watchers_count":563,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":371,"mirror_url":"git://git.apache.org/incubator-flink.git","open_issues_count":78,"forks":371,"open_issues":78,"watchers":563,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/1029"},"html":{"href":"https://github.com/apache/flink/pull/1029"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/1029"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/1029/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/1029/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/1029/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/3bc7a124718e618656079cca8f78bf58b61eb5ec"}}}}