{"action":"created","issue":{"url":"https://api.github.com/repos/BVLC/caffe/issues/1694","labels_url":"https://api.github.com/repos/BVLC/caffe/issues/1694/labels{/name}","comments_url":"https://api.github.com/repos/BVLC/caffe/issues/1694/comments","events_url":"https://api.github.com/repos/BVLC/caffe/issues/1694/events","html_url":"https://github.com/BVLC/caffe/pull/1694","id":53715367,"number":1694,"title":"Layer type is a string","user":{"login":"jeffdonahue","id":965190,"avatar_url":"https://avatars.githubusercontent.com/u/965190?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffdonahue","html_url":"https://github.com/jeffdonahue","followers_url":"https://api.github.com/users/jeffdonahue/followers","following_url":"https://api.github.com/users/jeffdonahue/following{/other_user}","gists_url":"https://api.github.com/users/jeffdonahue/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffdonahue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffdonahue/subscriptions","organizations_url":"https://api.github.com/users/jeffdonahue/orgs","repos_url":"https://api.github.com/users/jeffdonahue/repos","events_url":"https://api.github.com/users/jeffdonahue/events{/privacy}","received_events_url":"https://api.github.com/users/jeffdonahue/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/BVLC/caffe/labels/in+progress","name":"in progress","color":"5319e7"},{"url":"https://api.github.com/repos/BVLC/caffe/labels/interface","name":"interface","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-01-08T05:10:55Z","updated_at":"2015-01-10T03:50:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BVLC/caffe/pulls/1694","html_url":"https://github.com/BVLC/caffe/pull/1694","diff_url":"https://github.com/BVLC/caffe/pull/1694.diff","patch_url":"https://github.com/BVLC/caffe/pull/1694.patch"},"body":"addresses #1685 (thanks for the reminder @shelhamer)\r\n\r\nMostly works, but I still need to implement automagic upgrading of net prototxts before this is merged.  Which is actually kind of hard, because `type` is currently an `enum` so the parse of an old prototxt will fail due to the lack of quotes around the enum value (which was why I'd suggested using a different name like `class`, but I didn't particularly like the name `class` either).  One possible path that I think would probably work is to change the name of the `layers` field in `NetParameter`, but keep that field to mark the use of a \"V1\" prototxt (with this new one being \"V2\").  I've wanted to do this because it kind of annoys me that it's plural -- `layers` -- so if others agree this could be a good excuse to change the name to `layer`.\r\n\r\nTo do:\r\n\r\n- [ ] Change `layers` field name to `layer` as discussed above\r\n- [ ] Restore `type()` overrides\r\n- [ ] Update upgrade_net_proto_blah tool to also handle V1->V2 updates\r\n- [ ] Unit test(s)\r\n- [ ] Make the type case insensitive"},"comment":{"url":"https://api.github.com/repos/BVLC/caffe/issues/comments/69438617","html_url":"https://github.com/BVLC/caffe/pull/1694#issuecomment-69438617","issue_url":"https://api.github.com/repos/BVLC/caffe/issues/1694","id":69438617,"user":{"login":"jeffdonahue","id":965190,"avatar_url":"https://avatars.githubusercontent.com/u/965190?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffdonahue","html_url":"https://github.com/jeffdonahue","followers_url":"https://api.github.com/users/jeffdonahue/followers","following_url":"https://api.github.com/users/jeffdonahue/following{/other_user}","gists_url":"https://api.github.com/users/jeffdonahue/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffdonahue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffdonahue/subscriptions","organizations_url":"https://api.github.com/users/jeffdonahue/orgs","repos_url":"https://api.github.com/users/jeffdonahue/repos","events_url":"https://api.github.com/users/jeffdonahue/events{/privacy}","received_events_url":"https://api.github.com/users/jeffdonahue/received_events","type":"User","site_admin":false},"created_at":"2015-01-10T03:50:34Z","updated_at":"2015-01-10T03:50:34Z","body":"After some discussion with @longjon I've concluded that I too think case insensitive type strings would be overly user-friendly. Sorry for that brief lapse in judgment!"}}