{"action":"opened","number":5,"pull_request":{"url":"https://api.github.com/repos/mdgriffin/pogo-slider/pulls/5","id":45490401,"html_url":"https://github.com/mdgriffin/pogo-slider/pull/5","diff_url":"https://github.com/mdgriffin/pogo-slider/pull/5.diff","patch_url":"https://github.com/mdgriffin/pogo-slider/pull/5.patch","issue_url":"https://api.github.com/repos/mdgriffin/pogo-slider/issues/5","number":5,"state":"open","locked":false,"title":"fix a height problem when preserveTargetSize","user":{"login":"upupzealot","id":2574689,"avatar_url":"https://avatars.githubusercontent.com/u/2574689?v=3","gravatar_id":"","url":"https://api.github.com/users/upupzealot","html_url":"https://github.com/upupzealot","followers_url":"https://api.github.com/users/upupzealot/followers","following_url":"https://api.github.com/users/upupzealot/following{/other_user}","gists_url":"https://api.github.com/users/upupzealot/gists{/gist_id}","starred_url":"https://api.github.com/users/upupzealot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/upupzealot/subscriptions","organizations_url":"https://api.github.com/users/upupzealot/orgs","repos_url":"https://api.github.com/users/upupzealot/repos","events_url":"https://api.github.com/users/upupzealot/events{/privacy}","received_events_url":"https://api.github.com/users/upupzealot/received_events","type":"User","site_admin":false},"body":"BlocksReveal will calculate the height as\r\nvar numRows = Math.round(self.$element.height() / 100);\r\nbut in this situation we will get a height close to 0, because when\r\npreserveTargetSize is true, we use 'padding-bottom' instead of 'height',\r\nso I use:\r\nvar numRows = Math.round(parseFloat(self.$element.css('padding-bottom')) / 100);\r\ninstead.\r\n\r\nadd the 'background-size' attr to the slice-inners(when preserveTargetSize is true), so the image will not scale to unscaled-size jerky when slide.","created_at":"2015-09-20T05:42:49Z","updated_at":"2015-09-20T05:42:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mdgriffin/pogo-slider/pulls/5/commits","review_comments_url":"https://api.github.com/repos/mdgriffin/pogo-slider/pulls/5/comments","review_comment_url":"https://api.github.com/repos/mdgriffin/pogo-slider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mdgriffin/pogo-slider/issues/5/comments","statuses_url":"https://api.github.com/repos/mdgriffin/pogo-slider/statuses/300be04749ac78754959f8eca9f127661928cf49","head":{"label":"upupzealot:master","ref":"master","sha":"300be04749ac78754959f8eca9f127661928cf49","user":{"login":"upupzealot","id":2574689,"avatar_url":"https://avatars.githubusercontent.com/u/2574689?v=3","gravatar_id":"","url":"https://api.github.com/users/upupzealot","html_url":"https://github.com/upupzealot","followers_url":"https://api.github.com/users/upupzealot/followers","following_url":"https://api.github.com/users/upupzealot/following{/other_user}","gists_url":"https://api.github.com/users/upupzealot/gists{/gist_id}","starred_url":"https://api.github.com/users/upupzealot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/upupzealot/subscriptions","organizations_url":"https://api.github.com/users/upupzealot/orgs","repos_url":"https://api.github.com/users/upupzealot/repos","events_url":"https://api.github.com/users/upupzealot/events{/privacy}","received_events_url":"https://api.github.com/users/upupzealot/received_events","type":"User","site_admin":false},"repo":{"id":42784964,"name":"pogo-slider","full_name":"upupzealot/pogo-slider","owner":{"login":"upupzealot","id":2574689,"avatar_url":"https://avatars.githubusercontent.com/u/2574689?v=3","gravatar_id":"","url":"https://api.github.com/users/upupzealot","html_url":"https://github.com/upupzealot","followers_url":"https://api.github.com/users/upupzealot/followers","following_url":"https://api.github.com/users/upupzealot/following{/other_user}","gists_url":"https://api.github.com/users/upupzealot/gists{/gist_id}","starred_url":"https://api.github.com/users/upupzealot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/upupzealot/subscriptions","organizations_url":"https://api.github.com/users/upupzealot/orgs","repos_url":"https://api.github.com/users/upupzealot/repos","events_url":"https://api.github.com/users/upupzealot/events{/privacy}","received_events_url":"https://api.github.com/users/upupzealot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/upupzealot/pogo-slider","description":"jQuery animated slider plugin","fork":true,"url":"https://api.github.com/repos/upupzealot/pogo-slider","forks_url":"https://api.github.com/repos/upupzealot/pogo-slider/forks","keys_url":"https://api.github.com/repos/upupzealot/pogo-slider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/upupzealot/pogo-slider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/upupzealot/pogo-slider/teams","hooks_url":"https://api.github.com/repos/upupzealot/pogo-slider/hooks","issue_events_url":"https://api.github.com/repos/upupzealot/pogo-slider/issues/events{/number}","events_url":"https://api.github.com/repos/upupzealot/pogo-slider/events","assignees_url":"https://api.github.com/repos/upupzealot/pogo-slider/assignees{/user}","branches_url":"https://api.github.com/repos/upupzealot/pogo-slider/branches{/branch}","tags_url":"https://api.github.com/repos/upupzealot/pogo-slider/tags","blobs_url":"https://api.github.com/repos/upupzealot/pogo-slider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/upupzealot/pogo-slider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/upupzealot/pogo-slider/git/refs{/sha}","trees_url":"https://api.github.com/repos/upupzealot/pogo-slider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/upupzealot/pogo-slider/statuses/{sha}","languages_url":"https://api.github.com/repos/upupzealot/pogo-slider/languages","stargazers_url":"https://api.github.com/repos/upupzealot/pogo-slider/stargazers","contributors_url":"https://api.github.com/repos/upupzealot/pogo-slider/contributors","subscribers_url":"https://api.github.com/repos/upupzealot/pogo-slider/subscribers","subscription_url":"https://api.github.com/repos/upupzealot/pogo-slider/subscription","commits_url":"https://api.github.com/repos/upupzealot/pogo-slider/commits{/sha}","git_commits_url":"https://api.github.com/repos/upupzealot/pogo-slider/git/commits{/sha}","comments_url":"https://api.github.com/repos/upupzealot/pogo-slider/comments{/number}","issue_comment_url":"https://api.github.com/repos/upupzealot/pogo-slider/issues/comments{/number}","contents_url":"https://api.github.com/repos/upupzealot/pogo-slider/contents/{+path}","compare_url":"https://api.github.com/repos/upupzealot/pogo-slider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/upupzealot/pogo-slider/merges","archive_url":"https://api.github.com/repos/upupzealot/pogo-slider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/upupzealot/pogo-slider/downloads","issues_url":"https://api.github.com/repos/upupzealot/pogo-slider/issues{/number}","pulls_url":"https://api.github.com/repos/upupzealot/pogo-slider/pulls{/number}","milestones_url":"https://api.github.com/repos/upupzealot/pogo-slider/milestones{/number}","notifications_url":"https://api.github.com/repos/upupzealot/pogo-slider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/upupzealot/pogo-slider/labels{/name}","releases_url":"https://api.github.com/repos/upupzealot/pogo-slider/releases{/id}","created_at":"2015-09-19T18:34:58Z","updated_at":"2015-09-19T18:34:59Z","pushed_at":"2015-09-20T05:35:53Z","git_url":"git://github.com/upupzealot/pogo-slider.git","ssh_url":"git@github.com:upupzealot/pogo-slider.git","clone_url":"https://github.com/upupzealot/pogo-slider.git","svn_url":"https://github.com/upupzealot/pogo-slider","homepage":null,"size":1293,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mdgriffin:master","ref":"master","sha":"5b2eda0dda0f95069ec59fcfe8ff13277f2cfd3a","user":{"login":"mdgriffin","id":1513110,"avatar_url":"https://avatars.githubusercontent.com/u/1513110?v=3","gravatar_id":"","url":"https://api.github.com/users/mdgriffin","html_url":"https://github.com/mdgriffin","followers_url":"https://api.github.com/users/mdgriffin/followers","following_url":"https://api.github.com/users/mdgriffin/following{/other_user}","gists_url":"https://api.github.com/users/mdgriffin/gists{/gist_id}","starred_url":"https://api.github.com/users/mdgriffin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdgriffin/subscriptions","organizations_url":"https://api.github.com/users/mdgriffin/orgs","repos_url":"https://api.github.com/users/mdgriffin/repos","events_url":"https://api.github.com/users/mdgriffin/events{/privacy}","received_events_url":"https://api.github.com/users/mdgriffin/received_events","type":"User","site_admin":false},"repo":{"id":23547064,"name":"pogo-slider","full_name":"mdgriffin/pogo-slider","owner":{"login":"mdgriffin","id":1513110,"avatar_url":"https://avatars.githubusercontent.com/u/1513110?v=3","gravatar_id":"","url":"https://api.github.com/users/mdgriffin","html_url":"https://github.com/mdgriffin","followers_url":"https://api.github.com/users/mdgriffin/followers","following_url":"https://api.github.com/users/mdgriffin/following{/other_user}","gists_url":"https://api.github.com/users/mdgriffin/gists{/gist_id}","starred_url":"https://api.github.com/users/mdgriffin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdgriffin/subscriptions","organizations_url":"https://api.github.com/users/mdgriffin/orgs","repos_url":"https://api.github.com/users/mdgriffin/repos","events_url":"https://api.github.com/users/mdgriffin/events{/privacy}","received_events_url":"https://api.github.com/users/mdgriffin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdgriffin/pogo-slider","description":"jQuery animated slider plugin","fork":false,"url":"https://api.github.com/repos/mdgriffin/pogo-slider","forks_url":"https://api.github.com/repos/mdgriffin/pogo-slider/forks","keys_url":"https://api.github.com/repos/mdgriffin/pogo-slider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdgriffin/pogo-slider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdgriffin/pogo-slider/teams","hooks_url":"https://api.github.com/repos/mdgriffin/pogo-slider/hooks","issue_events_url":"https://api.github.com/repos/mdgriffin/pogo-slider/issues/events{/number}","events_url":"https://api.github.com/repos/mdgriffin/pogo-slider/events","assignees_url":"https://api.github.com/repos/mdgriffin/pogo-slider/assignees{/user}","branches_url":"https://api.github.com/repos/mdgriffin/pogo-slider/branches{/branch}","tags_url":"https://api.github.com/repos/mdgriffin/pogo-slider/tags","blobs_url":"https://api.github.com/repos/mdgriffin/pogo-slider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdgriffin/pogo-slider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdgriffin/pogo-slider/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdgriffin/pogo-slider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdgriffin/pogo-slider/statuses/{sha}","languages_url":"https://api.github.com/repos/mdgriffin/pogo-slider/languages","stargazers_url":"https://api.github.com/repos/mdgriffin/pogo-slider/stargazers","contributors_url":"https://api.github.com/repos/mdgriffin/pogo-slider/contributors","subscribers_url":"https://api.github.com/repos/mdgriffin/pogo-slider/subscribers","subscription_url":"https://api.github.com/repos/mdgriffin/pogo-slider/subscription","commits_url":"https://api.github.com/repos/mdgriffin/pogo-slider/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdgriffin/pogo-slider/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdgriffin/pogo-slider/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdgriffin/pogo-slider/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdgriffin/pogo-slider/contents/{+path}","compare_url":"https://api.github.com/repos/mdgriffin/pogo-slider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdgriffin/pogo-slider/merges","archive_url":"https://api.github.com/repos/mdgriffin/pogo-slider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdgriffin/pogo-slider/downloads","issues_url":"https://api.github.com/repos/mdgriffin/pogo-slider/issues{/number}","pulls_url":"https://api.github.com/repos/mdgriffin/pogo-slider/pulls{/number}","milestones_url":"https://api.github.com/repos/mdgriffin/pogo-slider/milestones{/number}","notifications_url":"https://api.github.com/repos/mdgriffin/pogo-slider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdgriffin/pogo-slider/labels{/name}","releases_url":"https://api.github.com/repos/mdgriffin/pogo-slider/releases{/id}","created_at":"2014-09-01T15:28:48Z","updated_at":"2015-09-18T08:42:31Z","pushed_at":"2015-04-29T08:56:08Z","git_url":"git://github.com/mdgriffin/pogo-slider.git","ssh_url":"git@github.com:mdgriffin/pogo-slider.git","clone_url":"https://github.com/mdgriffin/pogo-slider.git","svn_url":"https://github.com/mdgriffin/pogo-slider","homepage":null,"size":1348,"stargazers_count":46,"watchers_count":46,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":4,"forks":7,"open_issues":4,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mdgriffin/pogo-slider/pulls/5"},"html":{"href":"https://github.com/mdgriffin/pogo-slider/pull/5"},"issue":{"href":"https://api.github.com/repos/mdgriffin/pogo-slider/issues/5"},"comments":{"href":"https://api.github.com/repos/mdgriffin/pogo-slider/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/mdgriffin/pogo-slider/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/mdgriffin/pogo-slider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mdgriffin/pogo-slider/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/mdgriffin/pogo-slider/statuses/300be04749ac78754959f8eca9f127661928cf49"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":25,"deletions":4,"changed_files":4}}