{"action":"created","issue":{"url":"https://api.github.com/repos/matrix-org/matrix-ios-kit/issues/5","labels_url":"https://api.github.com/repos/matrix-org/matrix-ios-kit/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/matrix-org/matrix-ios-kit/issues/5/comments","events_url":"https://api.github.com/repos/matrix-org/matrix-ios-kit/issues/5/events","html_url":"https://github.com/matrix-org/matrix-ios-kit/pull/5","id":111409488,"number":5,"title":"Allow URL scheme of links to be customized","user":{"login":"illicitonion","id":1131704,"avatar_url":"https://avatars.githubusercontent.com/u/1131704?v=3","gravatar_id":"","url":"https://api.github.com/users/illicitonion","html_url":"https://github.com/illicitonion","followers_url":"https://api.github.com/users/illicitonion/followers","following_url":"https://api.github.com/users/illicitonion/following{/other_user}","gists_url":"https://api.github.com/users/illicitonion/gists{/gist_id}","starred_url":"https://api.github.com/users/illicitonion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illicitonion/subscriptions","organizations_url":"https://api.github.com/users/illicitonion/orgs","repos_url":"https://api.github.com/users/illicitonion/repos","events_url":"https://api.github.com/users/illicitonion/events{/privacy}","received_events_url":"https://api.github.com/users/illicitonion/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"giomfo","id":8969772,"avatar_url":"https://avatars.githubusercontent.com/u/8969772?v=3","gravatar_id":"","url":"https://api.github.com/users/giomfo","html_url":"https://github.com/giomfo","followers_url":"https://api.github.com/users/giomfo/followers","following_url":"https://api.github.com/users/giomfo/following{/other_user}","gists_url":"https://api.github.com/users/giomfo/gists{/gist_id}","starred_url":"https://api.github.com/users/giomfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giomfo/subscriptions","organizations_url":"https://api.github.com/users/giomfo/orgs","repos_url":"https://api.github.com/users/giomfo/repos","events_url":"https://api.github.com/users/giomfo/events{/privacy}","received_events_url":"https://api.github.com/users/giomfo/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-10-14T14:23:35Z","updated_at":"2015-10-14T16:18:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/matrix-org/matrix-ios-kit/pulls/5","html_url":"https://github.com/matrix-org/matrix-ios-kit/pull/5","diff_url":"https://github.com/matrix-org/matrix-ios-kit/pull/5.diff","patch_url":"https://github.com/matrix-org/matrix-ios-kit/pull/5.patch"},"body":"This will allow Chrome to be set to the default link handler in\r\napplications of they want. And probably other browsers too."},"comment":{"url":"https://api.github.com/repos/matrix-org/matrix-ios-kit/issues/comments/148104374","html_url":"https://github.com/matrix-org/matrix-ios-kit/pull/5#issuecomment-148104374","issue_url":"https://api.github.com/repos/matrix-org/matrix-ios-kit/issues/5","id":148104374,"user":{"login":"giomfo","id":8969772,"avatar_url":"https://avatars.githubusercontent.com/u/8969772?v=3","gravatar_id":"","url":"https://api.github.com/users/giomfo","html_url":"https://github.com/giomfo","followers_url":"https://api.github.com/users/giomfo/followers","following_url":"https://api.github.com/users/giomfo/following{/other_user}","gists_url":"https://api.github.com/users/giomfo/gists{/gist_id}","starred_url":"https://api.github.com/users/giomfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giomfo/subscriptions","organizations_url":"https://api.github.com/users/giomfo/orgs","repos_url":"https://api.github.com/users/giomfo/repos","events_url":"https://api.github.com/users/giomfo/events{/privacy}","received_events_url":"https://api.github.com/users/giomfo/received_events","type":"User","site_admin":false},"created_at":"2015-10-14T16:18:29Z","updated_at":"2015-10-14T16:18:29Z","body":"Here are 2 remarks on the current implementation. The second point is a blocking point.\r\n\r\n1/ You have to set the default value for httpLinkScheme and httpsLinkScheme in [MXKAppSettings init] and [MXKAppSettings reset].\r\n\r\n2/  You could not remove the getter of the property 'attributedTextMessage'  in MXKRoomBubbleComponent class. This getter is used to update automatically the text display in chat bubble according to the current event state (We reset on purpose the property 'attributedTextMessage' in 'MXKRoomBubbleCellData' (line 123) on event update.)\r\nFor example, with your implementation outgoing messages are frozen in pending display (light gray), they are not updated whereas they are sent (or failed).\r\nYour code relative to NSLinkAttributeName attribute may be added in the existing  'stringAttributesForEvent' method in MXKEventFormatter.m, but I agree that this is not relevant because this attribute does not depend on the event state. So maybe you should add a new property in MXKRoomBubbleComponent class to compute once and store this attribute value."}}