{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/pulls/comments/26901749","id":26901749,"diff_hunk":"@@ -31,7 +31,7 @@\n             :servertype   => server_type,\n             :storeconfigs => 'puppetdb',\n             :environmentpath => '$confdir/environments',\n-            :basemodulepath => '/etc/puppet/modules:/usr/share/puppet/modules',\n+            :basemodulepath => ['/etc/puppet/modules', '/usr/share/puppet/modules'],","path":"spec/classes/server_spec.rb","position":5,"original_position":5,"commit_id":"5418ed1d456fe66a149da88b3f3301ea08207ad8","original_commit_id":"5418ed1d456fe66a149da88b3f3301ea08207ad8","user":{"login":"igalic","id":497249,"avatar_url":"https://avatars.githubusercontent.com/u/497249?v=3","gravatar_id":"","url":"https://api.github.com/users/igalic","html_url":"https://github.com/igalic","followers_url":"https://api.github.com/users/igalic/followers","following_url":"https://api.github.com/users/igalic/following{/other_user}","gists_url":"https://api.github.com/users/igalic/gists{/gist_id}","starred_url":"https://api.github.com/users/igalic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igalic/subscriptions","organizations_url":"https://api.github.com/users/igalic/orgs","repos_url":"https://api.github.com/users/igalic/repos","events_url":"https://api.github.com/users/igalic/events{/privacy}","received_events_url":"https://api.github.com/users/igalic/received_events","type":"User","site_admin":false},"body":"we're already testing it, yes, https://github.com/puppetlabs-operations/puppet-puppet/blob/master/.travis.yml#L16 but i think it'd be also good to combine future and strict vars.","created_at":"2015-03-22T10:58:35Z","updated_at":"2015-03-22T10:58:35Z","html_url":"https://github.com/puppetlabs-operations/puppet-puppet/pull/195#discussion_r26901749","pull_request_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/pulls/195","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/pulls/comments/26901749"},"html":{"href":"https://github.com/puppetlabs-operations/puppet-puppet/pull/195#discussion_r26901749"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/pulls/195"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/pulls/195","id":31337498,"html_url":"https://github.com/puppetlabs-operations/puppet-puppet/pull/195","diff_url":"https://github.com/puppetlabs-operations/puppet-puppet/pull/195.diff","patch_url":"https://github.com/puppetlabs-operations/puppet-puppet/pull/195.patch","issue_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/issues/195","number":195,"state":"open","locked":false,"title":"Support arrays for basemodulepath","user":{"login":"tampakrap","id":48949,"avatar_url":"https://avatars.githubusercontent.com/u/48949?v=3","gravatar_id":"","url":"https://api.github.com/users/tampakrap","html_url":"https://github.com/tampakrap","followers_url":"https://api.github.com/users/tampakrap/followers","following_url":"https://api.github.com/users/tampakrap/following{/other_user}","gists_url":"https://api.github.com/users/tampakrap/gists{/gist_id}","starred_url":"https://api.github.com/users/tampakrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tampakrap/subscriptions","organizations_url":"https://api.github.com/users/tampakrap/orgs","repos_url":"https://api.github.com/users/tampakrap/repos","events_url":"https://api.github.com/users/tampakrap/events{/privacy}","received_events_url":"https://api.github.com/users/tampakrap/received_events","type":"User","site_admin":false},"body":null,"created_at":"2015-03-17T14:06:16Z","updated_at":"2015-03-22T10:58:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7773af83e7ed21ddd513763439e792204fe274a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/pulls/195/commits","review_comments_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/pulls/195/comments","review_comment_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/issues/195/comments","statuses_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/statuses/5418ed1d456fe66a149da88b3f3301ea08207ad8","head":{"label":"tampakrap:basemodulepath","ref":"basemodulepath","sha":"5418ed1d456fe66a149da88b3f3301ea08207ad8","user":{"login":"tampakrap","id":48949,"avatar_url":"https://avatars.githubusercontent.com/u/48949?v=3","gravatar_id":"","url":"https://api.github.com/users/tampakrap","html_url":"https://github.com/tampakrap","followers_url":"https://api.github.com/users/tampakrap/followers","following_url":"https://api.github.com/users/tampakrap/following{/other_user}","gists_url":"https://api.github.com/users/tampakrap/gists{/gist_id}","starred_url":"https://api.github.com/users/tampakrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tampakrap/subscriptions","organizations_url":"https://api.github.com/users/tampakrap/orgs","repos_url":"https://api.github.com/users/tampakrap/repos","events_url":"https://api.github.com/users/tampakrap/events{/privacy}","received_events_url":"https://api.github.com/users/tampakrap/received_events","type":"User","site_admin":false},"repo":{"id":7696511,"name":"puppet-puppet","full_name":"tampakrap/puppet-puppet","owner":{"login":"tampakrap","id":48949,"avatar_url":"https://avatars.githubusercontent.com/u/48949?v=3","gravatar_id":"","url":"https://api.github.com/users/tampakrap","html_url":"https://github.com/tampakrap","followers_url":"https://api.github.com/users/tampakrap/followers","following_url":"https://api.github.com/users/tampakrap/following{/other_user}","gists_url":"https://api.github.com/users/tampakrap/gists{/gist_id}","starred_url":"https://api.github.com/users/tampakrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tampakrap/subscriptions","organizations_url":"https://api.github.com/users/tampakrap/orgs","repos_url":"https://api.github.com/users/tampakrap/repos","events_url":"https://api.github.com/users/tampakrap/events{/privacy}","received_events_url":"https://api.github.com/users/tampakrap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tampakrap/puppet-puppet","description":"100% free range, organic, pesticide free Puppet module for managing Puppet","fork":true,"url":"https://api.github.com/repos/tampakrap/puppet-puppet","forks_url":"https://api.github.com/repos/tampakrap/puppet-puppet/forks","keys_url":"https://api.github.com/repos/tampakrap/puppet-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tampakrap/puppet-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tampakrap/puppet-puppet/teams","hooks_url":"https://api.github.com/repos/tampakrap/puppet-puppet/hooks","issue_events_url":"https://api.github.com/repos/tampakrap/puppet-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/tampakrap/puppet-puppet/events","assignees_url":"https://api.github.com/repos/tampakrap/puppet-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/tampakrap/puppet-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/tampakrap/puppet-puppet/tags","blobs_url":"https://api.github.com/repos/tampakrap/puppet-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tampakrap/puppet-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tampakrap/puppet-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/tampakrap/puppet-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tampakrap/puppet-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/tampakrap/puppet-puppet/languages","stargazers_url":"https://api.github.com/repos/tampakrap/puppet-puppet/stargazers","contributors_url":"https://api.github.com/repos/tampakrap/puppet-puppet/contributors","subscribers_url":"https://api.github.com/repos/tampakrap/puppet-puppet/subscribers","subscription_url":"https://api.github.com/repos/tampakrap/puppet-puppet/subscription","commits_url":"https://api.github.com/repos/tampakrap/puppet-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/tampakrap/puppet-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/tampakrap/puppet-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/tampakrap/puppet-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/tampakrap/puppet-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/tampakrap/puppet-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tampakrap/puppet-puppet/merges","archive_url":"https://api.github.com/repos/tampakrap/puppet-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tampakrap/puppet-puppet/downloads","issues_url":"https://api.github.com/repos/tampakrap/puppet-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/tampakrap/puppet-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/tampakrap/puppet-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/tampakrap/puppet-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tampakrap/puppet-puppet/labels{/name}","releases_url":"https://api.github.com/repos/tampakrap/puppet-puppet/releases{/id}","created_at":"2013-01-18T23:34:58Z","updated_at":"2013-12-08T21:55:11Z","pushed_at":"2015-03-21T08:31:15Z","git_url":"git://github.com/tampakrap/puppet-puppet.git","ssh_url":"git@github.com:tampakrap/puppet-puppet.git","clone_url":"https://github.com/tampakrap/puppet-puppet.git","svn_url":"https://github.com/tampakrap/puppet-puppet","homepage":null,"size":1056,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs-operations:master","ref":"master","sha":"8bcbd3e611cb2ba4fc7eeaca6806e01ed6f3e594","user":{"login":"puppetlabs-operations","id":2043293,"avatar_url":"https://avatars.githubusercontent.com/u/2043293?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs-operations","html_url":"https://github.com/puppetlabs-operations","followers_url":"https://api.github.com/users/puppetlabs-operations/followers","following_url":"https://api.github.com/users/puppetlabs-operations/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs-operations/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs-operations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs-operations/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs-operations/orgs","repos_url":"https://api.github.com/users/puppetlabs-operations/repos","events_url":"https://api.github.com/users/puppetlabs-operations/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs-operations/received_events","type":"Organization","site_admin":false},"repo":{"id":6056031,"name":"puppet-puppet","full_name":"puppetlabs-operations/puppet-puppet","owner":{"login":"puppetlabs-operations","id":2043293,"avatar_url":"https://avatars.githubusercontent.com/u/2043293?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs-operations","html_url":"https://github.com/puppetlabs-operations","followers_url":"https://api.github.com/users/puppetlabs-operations/followers","following_url":"https://api.github.com/users/puppetlabs-operations/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs-operations/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs-operations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs-operations/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs-operations/orgs","repos_url":"https://api.github.com/users/puppetlabs-operations/repos","events_url":"https://api.github.com/users/puppetlabs-operations/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs-operations/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs-operations/puppet-puppet","description":"100% free range, organic, pesticide free Puppet module for managing Puppet","fork":false,"url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet","forks_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/releases{/id}","created_at":"2012-10-03T05:55:06Z","updated_at":"2015-03-17T16:01:57Z","pushed_at":"2015-03-21T23:06:51Z","git_url":"git://github.com/puppetlabs-operations/puppet-puppet.git","ssh_url":"git@github.com:puppetlabs-operations/puppet-puppet.git","clone_url":"https://github.com/puppetlabs-operations/puppet-puppet.git","svn_url":"https://github.com/puppetlabs-operations/puppet-puppet","homepage":null,"size":2351,"stargazers_count":32,"watchers_count":32,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":20,"forks":29,"open_issues":20,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/pulls/195"},"html":{"href":"https://github.com/puppetlabs-operations/puppet-puppet/pull/195"},"issue":{"href":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/issues/195"},"comments":{"href":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs-operations/puppet-puppet/statuses/5418ed1d456fe66a149da88b3f3301ea08207ad8"}}}}