{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/DemocracyApps/GBE/pulls/5","id":35087538,"html_url":"https://github.com/DemocracyApps/GBE/pull/5","diff_url":"https://github.com/DemocracyApps/GBE/pull/5.diff","patch_url":"https://github.com/DemocracyApps/GBE/pull/5.patch","issue_url":"https://api.github.com/repos/DemocracyApps/GBE/issues/5","number":5,"state":"closed","locked":false,"title":"Client side test","user":{"login":"AndrewSwerlick","id":1028917,"avatar_url":"https://avatars.githubusercontent.com/u/1028917?v=3","gravatar_id":"","url":"https://api.github.com/users/AndrewSwerlick","html_url":"https://github.com/AndrewSwerlick","followers_url":"https://api.github.com/users/AndrewSwerlick/followers","following_url":"https://api.github.com/users/AndrewSwerlick/following{/other_user}","gists_url":"https://api.github.com/users/AndrewSwerlick/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewSwerlick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewSwerlick/subscriptions","organizations_url":"https://api.github.com/users/AndrewSwerlick/orgs","repos_url":"https://api.github.com/users/AndrewSwerlick/repos","events_url":"https://api.github.com/users/AndrewSwerlick/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewSwerlick/received_events","type":"User","site_admin":false},"body":"Add a framework for running client side tests using karma and jasmine. Tests can be started using the command `npm test`. This starts the karma test runner, which keeps an instance of chrome open to run the tests inside of. Tests are automatically re-run whenever karma since a file change.\r\n\r\nTests should be added in subfolders named __tests__ next to the module they are actual testings. (i.e. resoures/js/SimpleCard.js has a test at resoures/js/__tests__/SimpleCard-test.js). \r\n\r\nA sample test for the SimpleCard component is available for review. A couple of key things to note\r\n1. There is a method called \"given\" defined in resources/js/spec_helper.js which allows you to setup lazily evaluated variables for testing. This is useful if all of you tests have the same basic setup with only slight tweaks. You can see it's use in the sample test.\r\n2. The test uses proxyquireify. This is a browserify add on that let's you dynamically load mocks or stubs in your test. In the sample test, we set it up so that any code that loads the CardStore module will get a stub object instead, which will return a predefined card. This way we can avoid having to setup a full blown card store. See https://github.com/thlorenz/proxyquireify for detail.","created_at":"2015-05-10T19:36:08Z","updated_at":"2015-05-12T19:01:35Z","closed_at":"2015-05-12T19:01:35Z","merged_at":"2015-05-12T19:01:35Z","merge_commit_sha":"5f7eb2bad086393ff664256d04ff12f0f3080c33","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DemocracyApps/GBE/pulls/5/commits","review_comments_url":"https://api.github.com/repos/DemocracyApps/GBE/pulls/5/comments","review_comment_url":"https://api.github.com/repos/DemocracyApps/GBE/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DemocracyApps/GBE/issues/5/comments","statuses_url":"https://api.github.com/repos/DemocracyApps/GBE/statuses/c9208349ef95d5161230fb52091170e0bb1493fa","head":{"label":"AndrewSwerlick:client-side-test","ref":"client-side-test","sha":"c9208349ef95d5161230fb52091170e0bb1493fa","user":{"login":"AndrewSwerlick","id":1028917,"avatar_url":"https://avatars.githubusercontent.com/u/1028917?v=3","gravatar_id":"","url":"https://api.github.com/users/AndrewSwerlick","html_url":"https://github.com/AndrewSwerlick","followers_url":"https://api.github.com/users/AndrewSwerlick/followers","following_url":"https://api.github.com/users/AndrewSwerlick/following{/other_user}","gists_url":"https://api.github.com/users/AndrewSwerlick/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewSwerlick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewSwerlick/subscriptions","organizations_url":"https://api.github.com/users/AndrewSwerlick/orgs","repos_url":"https://api.github.com/users/AndrewSwerlick/repos","events_url":"https://api.github.com/users/AndrewSwerlick/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewSwerlick/received_events","type":"User","site_admin":false},"repo":{"id":35377851,"name":"GBE","full_name":"AndrewSwerlick/GBE","owner":{"login":"AndrewSwerlick","id":1028917,"avatar_url":"https://avatars.githubusercontent.com/u/1028917?v=3","gravatar_id":"","url":"https://api.github.com/users/AndrewSwerlick","html_url":"https://github.com/AndrewSwerlick","followers_url":"https://api.github.com/users/AndrewSwerlick/followers","following_url":"https://api.github.com/users/AndrewSwerlick/following{/other_user}","gists_url":"https://api.github.com/users/AndrewSwerlick/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewSwerlick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewSwerlick/subscriptions","organizations_url":"https://api.github.com/users/AndrewSwerlick/orgs","repos_url":"https://api.github.com/users/AndrewSwerlick/repos","events_url":"https://api.github.com/users/AndrewSwerlick/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewSwerlick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AndrewSwerlick/GBE","description":"Government Budget Explorer","fork":true,"url":"https://api.github.com/repos/AndrewSwerlick/GBE","forks_url":"https://api.github.com/repos/AndrewSwerlick/GBE/forks","keys_url":"https://api.github.com/repos/AndrewSwerlick/GBE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndrewSwerlick/GBE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndrewSwerlick/GBE/teams","hooks_url":"https://api.github.com/repos/AndrewSwerlick/GBE/hooks","issue_events_url":"https://api.github.com/repos/AndrewSwerlick/GBE/issues/events{/number}","events_url":"https://api.github.com/repos/AndrewSwerlick/GBE/events","assignees_url":"https://api.github.com/repos/AndrewSwerlick/GBE/assignees{/user}","branches_url":"https://api.github.com/repos/AndrewSwerlick/GBE/branches{/branch}","tags_url":"https://api.github.com/repos/AndrewSwerlick/GBE/tags","blobs_url":"https://api.github.com/repos/AndrewSwerlick/GBE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndrewSwerlick/GBE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndrewSwerlick/GBE/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndrewSwerlick/GBE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndrewSwerlick/GBE/statuses/{sha}","languages_url":"https://api.github.com/repos/AndrewSwerlick/GBE/languages","stargazers_url":"https://api.github.com/repos/AndrewSwerlick/GBE/stargazers","contributors_url":"https://api.github.com/repos/AndrewSwerlick/GBE/contributors","subscribers_url":"https://api.github.com/repos/AndrewSwerlick/GBE/subscribers","subscription_url":"https://api.github.com/repos/AndrewSwerlick/GBE/subscription","commits_url":"https://api.github.com/repos/AndrewSwerlick/GBE/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndrewSwerlick/GBE/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndrewSwerlick/GBE/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndrewSwerlick/GBE/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndrewSwerlick/GBE/contents/{+path}","compare_url":"https://api.github.com/repos/AndrewSwerlick/GBE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndrewSwerlick/GBE/merges","archive_url":"https://api.github.com/repos/AndrewSwerlick/GBE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndrewSwerlick/GBE/downloads","issues_url":"https://api.github.com/repos/AndrewSwerlick/GBE/issues{/number}","pulls_url":"https://api.github.com/repos/AndrewSwerlick/GBE/pulls{/number}","milestones_url":"https://api.github.com/repos/AndrewSwerlick/GBE/milestones{/number}","notifications_url":"https://api.github.com/repos/AndrewSwerlick/GBE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndrewSwerlick/GBE/labels{/name}","releases_url":"https://api.github.com/repos/AndrewSwerlick/GBE/releases{/id}","created_at":"2015-05-10T16:05:11Z","updated_at":"2015-05-10T16:05:14Z","pushed_at":"2015-05-12T02:20:46Z","git_url":"git://github.com/AndrewSwerlick/GBE.git","ssh_url":"git@github.com:AndrewSwerlick/GBE.git","clone_url":"https://github.com/AndrewSwerlick/GBE.git","svn_url":"https://github.com/AndrewSwerlick/GBE","homepage":null,"size":7112,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DemocracyApps:master","ref":"master","sha":"55eaf9194895bb6c790a86a5b4ea9a2e8c4373b0","user":{"login":"DemocracyApps","id":7871092,"avatar_url":"https://avatars.githubusercontent.com/u/7871092?v=3","gravatar_id":"","url":"https://api.github.com/users/DemocracyApps","html_url":"https://github.com/DemocracyApps","followers_url":"https://api.github.com/users/DemocracyApps/followers","following_url":"https://api.github.com/users/DemocracyApps/following{/other_user}","gists_url":"https://api.github.com/users/DemocracyApps/gists{/gist_id}","starred_url":"https://api.github.com/users/DemocracyApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DemocracyApps/subscriptions","organizations_url":"https://api.github.com/users/DemocracyApps/orgs","repos_url":"https://api.github.com/users/DemocracyApps/repos","events_url":"https://api.github.com/users/DemocracyApps/events{/privacy}","received_events_url":"https://api.github.com/users/DemocracyApps/received_events","type":"Organization","site_admin":false},"repo":{"id":30668512,"name":"GBE","full_name":"DemocracyApps/GBE","owner":{"login":"DemocracyApps","id":7871092,"avatar_url":"https://avatars.githubusercontent.com/u/7871092?v=3","gravatar_id":"","url":"https://api.github.com/users/DemocracyApps","html_url":"https://github.com/DemocracyApps","followers_url":"https://api.github.com/users/DemocracyApps/followers","following_url":"https://api.github.com/users/DemocracyApps/following{/other_user}","gists_url":"https://api.github.com/users/DemocracyApps/gists{/gist_id}","starred_url":"https://api.github.com/users/DemocracyApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DemocracyApps/subscriptions","organizations_url":"https://api.github.com/users/DemocracyApps/orgs","repos_url":"https://api.github.com/users/DemocracyApps/repos","events_url":"https://api.github.com/users/DemocracyApps/events{/privacy}","received_events_url":"https://api.github.com/users/DemocracyApps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DemocracyApps/GBE","description":"Government Budget Explorer","fork":false,"url":"https://api.github.com/repos/DemocracyApps/GBE","forks_url":"https://api.github.com/repos/DemocracyApps/GBE/forks","keys_url":"https://api.github.com/repos/DemocracyApps/GBE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DemocracyApps/GBE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DemocracyApps/GBE/teams","hooks_url":"https://api.github.com/repos/DemocracyApps/GBE/hooks","issue_events_url":"https://api.github.com/repos/DemocracyApps/GBE/issues/events{/number}","events_url":"https://api.github.com/repos/DemocracyApps/GBE/events","assignees_url":"https://api.github.com/repos/DemocracyApps/GBE/assignees{/user}","branches_url":"https://api.github.com/repos/DemocracyApps/GBE/branches{/branch}","tags_url":"https://api.github.com/repos/DemocracyApps/GBE/tags","blobs_url":"https://api.github.com/repos/DemocracyApps/GBE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DemocracyApps/GBE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DemocracyApps/GBE/git/refs{/sha}","trees_url":"https://api.github.com/repos/DemocracyApps/GBE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DemocracyApps/GBE/statuses/{sha}","languages_url":"https://api.github.com/repos/DemocracyApps/GBE/languages","stargazers_url":"https://api.github.com/repos/DemocracyApps/GBE/stargazers","contributors_url":"https://api.github.com/repos/DemocracyApps/GBE/contributors","subscribers_url":"https://api.github.com/repos/DemocracyApps/GBE/subscribers","subscription_url":"https://api.github.com/repos/DemocracyApps/GBE/subscription","commits_url":"https://api.github.com/repos/DemocracyApps/GBE/commits{/sha}","git_commits_url":"https://api.github.com/repos/DemocracyApps/GBE/git/commits{/sha}","comments_url":"https://api.github.com/repos/DemocracyApps/GBE/comments{/number}","issue_comment_url":"https://api.github.com/repos/DemocracyApps/GBE/issues/comments{/number}","contents_url":"https://api.github.com/repos/DemocracyApps/GBE/contents/{+path}","compare_url":"https://api.github.com/repos/DemocracyApps/GBE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DemocracyApps/GBE/merges","archive_url":"https://api.github.com/repos/DemocracyApps/GBE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DemocracyApps/GBE/downloads","issues_url":"https://api.github.com/repos/DemocracyApps/GBE/issues{/number}","pulls_url":"https://api.github.com/repos/DemocracyApps/GBE/pulls{/number}","milestones_url":"https://api.github.com/repos/DemocracyApps/GBE/milestones{/number}","notifications_url":"https://api.github.com/repos/DemocracyApps/GBE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DemocracyApps/GBE/labels{/name}","releases_url":"https://api.github.com/repos/DemocracyApps/GBE/releases{/id}","created_at":"2015-02-11T20:37:08Z","updated_at":"2015-05-11T21:33:09Z","pushed_at":"2015-05-12T19:01:35Z","git_url":"git://github.com/DemocracyApps/GBE.git","ssh_url":"git@github.com:DemocracyApps/GBE.git","clone_url":"https://github.com/DemocracyApps/GBE.git","svn_url":"https://github.com/DemocracyApps/GBE","homepage":null,"size":7112,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DemocracyApps/GBE/pulls/5"},"html":{"href":"https://github.com/DemocracyApps/GBE/pull/5"},"issue":{"href":"https://api.github.com/repos/DemocracyApps/GBE/issues/5"},"comments":{"href":"https://api.github.com/repos/DemocracyApps/GBE/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/DemocracyApps/GBE/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/DemocracyApps/GBE/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DemocracyApps/GBE/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/DemocracyApps/GBE/statuses/c9208349ef95d5161230fb52091170e0bb1493fa"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ejaxon","id":6409214,"avatar_url":"https://avatars.githubusercontent.com/u/6409214?v=3","gravatar_id":"","url":"https://api.github.com/users/ejaxon","html_url":"https://github.com/ejaxon","followers_url":"https://api.github.com/users/ejaxon/followers","following_url":"https://api.github.com/users/ejaxon/following{/other_user}","gists_url":"https://api.github.com/users/ejaxon/gists{/gist_id}","starred_url":"https://api.github.com/users/ejaxon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejaxon/subscriptions","organizations_url":"https://api.github.com/users/ejaxon/orgs","repos_url":"https://api.github.com/users/ejaxon/repos","events_url":"https://api.github.com/users/ejaxon/events{/privacy}","received_events_url":"https://api.github.com/users/ejaxon/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":6,"additions":106,"deletions":6,"changed_files":8}}