{"action":"created","issue":{"url":"https://api.github.com/repos/pires/android-obd-reader/issues/70","labels_url":"https://api.github.com/repos/pires/android-obd-reader/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/pires/android-obd-reader/issues/70/comments","events_url":"https://api.github.com/repos/pires/android-obd-reader/issues/70/events","html_url":"https://github.com/pires/android-obd-reader/pull/70","id":61542049,"number":70,"title":"Enabling Upload ","user":{"login":"nomwerp","id":10109262,"avatar_url":"https://avatars.githubusercontent.com/u/10109262?v=3","gravatar_id":"","url":"https://api.github.com/users/nomwerp","html_url":"https://github.com/nomwerp","followers_url":"https://api.github.com/users/nomwerp/followers","following_url":"https://api.github.com/users/nomwerp/following{/other_user}","gists_url":"https://api.github.com/users/nomwerp/gists{/gist_id}","starred_url":"https://api.github.com/users/nomwerp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nomwerp/subscriptions","organizations_url":"https://api.github.com/users/nomwerp/orgs","repos_url":"https://api.github.com/users/nomwerp/repos","events_url":"https://api.github.com/users/nomwerp/events{/privacy}","received_events_url":"https://api.github.com/users/nomwerp/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-03-14T10:12:07Z","updated_at":"2015-03-17T19:06:48Z","closed_at":"2015-03-17T10:26:06Z","pull_request":{"url":"https://api.github.com/repos/pires/android-obd-reader/pulls/70","html_url":"https://github.com/pires/android-obd-reader/pull/70","diff_url":"https://github.com/pires/android-obd-reader/pull/70.diff","patch_url":"https://github.com/pires/android-obd-reader/pull/70.patch"},"body":"* Enable upload preferences\r\n* Set default endpoint to example.com\r\n* Use values from preferences in MainActivity\r\n* Catch and log upload exceptions\r\n* Update readme\r\n\r\nany good reason to leave this disabled?\r\n\r\nnoticed some strange behaviour after changing the default endpoint on my device it was still set to http://www.ral.ucar.edu/~lambi/obd/get_data.php , maybe i'm missing something about the way preferences are updated?"},"comment":{"url":"https://api.github.com/repos/pires/android-obd-reader/issues/comments/82537214","html_url":"https://github.com/pires/android-obd-reader/pull/70#issuecomment-82537214","issue_url":"https://api.github.com/repos/pires/android-obd-reader/issues/70","id":82537214,"user":{"login":"nomwerp","id":10109262,"avatar_url":"https://avatars.githubusercontent.com/u/10109262?v=3","gravatar_id":"","url":"https://api.github.com/users/nomwerp","html_url":"https://github.com/nomwerp","followers_url":"https://api.github.com/users/nomwerp/followers","following_url":"https://api.github.com/users/nomwerp/following{/other_user}","gists_url":"https://api.github.com/users/nomwerp/gists{/gist_id}","starred_url":"https://api.github.com/users/nomwerp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nomwerp/subscriptions","organizations_url":"https://api.github.com/users/nomwerp/orgs","repos_url":"https://api.github.com/users/nomwerp/repos","events_url":"https://api.github.com/users/nomwerp/events{/privacy}","received_events_url":"https://api.github.com/users/nomwerp/received_events","type":"User","site_admin":false},"created_at":"2015-03-17T19:06:48Z","updated_at":"2015-03-17T19:06:48Z","body":"i'm playing around with a simple php server side implementation to add the uploaded data to a database so that's where combing the data helps a lot, i haven't looked into obd-server but didn't want to break anything there.\r\n\r\nanyway due to the asynchronous execution of the queue there is also no guarantee we get a complete set of records for every upload but should be in most cases since only called when queue is empty, maybe it should be switched around so that we first upload before filling queue again..."}}