{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/48091344","id":48091344,"diff_hunk":"@@ -151,7 +163,11 @@ Structure\n * Use parentheses when instantiating classes regardless of the number of\n   arguments the constructor has;\n \n-* Exception message strings should be concatenated using :phpfunction:`sprintf`.\n+* Exception and error message strings should be concatenated using :phpfunction:`sprintf`.\n+\n+* Calls to :phpfunction:`trigger_error` with type `E_USER_DEPRECATED` should be","path":"contributing/code/standards.rst","position":26,"original_position":26,"commit_id":"f23b8d3c15dd3e3884ef556665441762e57ee699","original_commit_id":"f23b8d3c15dd3e3884ef556665441762e57ee699","user":{"login":"xabbuh","id":1957048,"avatar_url":"https://avatars.githubusercontent.com/u/1957048?v=3","gravatar_id":"","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"body":"You need to use double backticks around the constant name.","created_at":"2015-12-19T10:57:24Z","updated_at":"2015-12-19T10:57:24Z","html_url":"https://github.com/symfony/symfony-docs/pull/5840#discussion_r48091344","pull_request_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/5840","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/48091344"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/5840#discussion_r48091344"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/5840"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/5840","id":48766032,"html_url":"https://github.com/symfony/symfony-docs/pull/5840","diff_url":"https://github.com/symfony/symfony-docs/pull/5840.diff","patch_url":"https://github.com/symfony/symfony-docs/pull/5840.patch","issue_url":"https://api.github.com/repos/symfony/symfony-docs/issues/5840","number":5840,"state":"open","locked":false,"title":"[Contributing] [Standards] Add note about `trigger_error()` and deprecation messages","user":{"login":"phansys","id":1231441,"avatar_url":"https://avatars.githubusercontent.com/u/1231441?v=3","gravatar_id":"","url":"https://api.github.com/users/phansys","html_url":"https://github.com/phansys","followers_url":"https://api.github.com/users/phansys/followers","following_url":"https://api.github.com/users/phansys/following{/other_user}","gists_url":"https://api.github.com/users/phansys/gists{/gist_id}","starred_url":"https://api.github.com/users/phansys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phansys/subscriptions","organizations_url":"https://api.github.com/users/phansys/orgs","repos_url":"https://api.github.com/users/phansys/repos","events_url":"https://api.github.com/users/phansys/events{/privacy}","received_events_url":"https://api.github.com/users/phansys/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Doc fix?      | no\r\n| New docs?     | no\r\n| Applies to    | 2.3+\r\n| Fixed tickets |\r\n\r\nAdd note and example on how to trigger proper deprecation messages.\r\nRelated to #5525.","created_at":"2015-10-26T16:53:59Z","updated_at":"2015-12-19T10:57:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fd4735f9b1bb290daceaf3fc2b7f8fa99badf0c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/5840/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/5840/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/issues/5840/comments","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/f23b8d3c15dd3e3884ef556665441762e57ee699","head":{"label":"phansys:cs_deprecations","ref":"cs_deprecations","sha":"f23b8d3c15dd3e3884ef556665441762e57ee699","user":{"login":"phansys","id":1231441,"avatar_url":"https://avatars.githubusercontent.com/u/1231441?v=3","gravatar_id":"","url":"https://api.github.com/users/phansys","html_url":"https://github.com/phansys","followers_url":"https://api.github.com/users/phansys/followers","following_url":"https://api.github.com/users/phansys/following{/other_user}","gists_url":"https://api.github.com/users/phansys/gists{/gist_id}","starred_url":"https://api.github.com/users/phansys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phansys/subscriptions","organizations_url":"https://api.github.com/users/phansys/orgs","repos_url":"https://api.github.com/users/phansys/repos","events_url":"https://api.github.com/users/phansys/events{/privacy}","received_events_url":"https://api.github.com/users/phansys/received_events","type":"User","site_admin":false},"repo":{"id":20787289,"name":"symfony-docs","full_name":"phansys/symfony-docs","owner":{"login":"phansys","id":1231441,"avatar_url":"https://avatars.githubusercontent.com/u/1231441?v=3","gravatar_id":"","url":"https://api.github.com/users/phansys","html_url":"https://github.com/phansys","followers_url":"https://api.github.com/users/phansys/followers","following_url":"https://api.github.com/users/phansys/following{/other_user}","gists_url":"https://api.github.com/users/phansys/gists{/gist_id}","starred_url":"https://api.github.com/users/phansys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phansys/subscriptions","organizations_url":"https://api.github.com/users/phansys/orgs","repos_url":"https://api.github.com/users/phansys/repos","events_url":"https://api.github.com/users/phansys/events{/privacy}","received_events_url":"https://api.github.com/users/phansys/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phansys/symfony-docs","description":"The Symfony2 documentation","fork":true,"url":"https://api.github.com/repos/phansys/symfony-docs","forks_url":"https://api.github.com/repos/phansys/symfony-docs/forks","keys_url":"https://api.github.com/repos/phansys/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phansys/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phansys/symfony-docs/teams","hooks_url":"https://api.github.com/repos/phansys/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/phansys/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/phansys/symfony-docs/events","assignees_url":"https://api.github.com/repos/phansys/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/phansys/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/phansys/symfony-docs/tags","blobs_url":"https://api.github.com/repos/phansys/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phansys/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phansys/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/phansys/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phansys/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/phansys/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/phansys/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/phansys/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/phansys/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/phansys/symfony-docs/subscription","commits_url":"https://api.github.com/repos/phansys/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/phansys/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/phansys/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/phansys/symfony-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/phansys/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/phansys/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phansys/symfony-docs/merges","archive_url":"https://api.github.com/repos/phansys/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phansys/symfony-docs/downloads","issues_url":"https://api.github.com/repos/phansys/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/phansys/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/phansys/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/phansys/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phansys/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/phansys/symfony-docs/releases{/id}","created_at":"2014-06-13T00:32:46Z","updated_at":"2014-06-13T01:06:59Z","pushed_at":"2015-12-18T22:08:07Z","git_url":"git://github.com/phansys/symfony-docs.git","ssh_url":"git@github.com:phansys/symfony-docs.git","clone_url":"https://github.com/phansys/symfony-docs.git","svn_url":"https://github.com/phansys/symfony-docs","homepage":"http://symfony.com/doc/current/","size":31831,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.3","ref":"2.3","sha":"f1a9d44b9a11acbdc4696e96fc54ae92c986f4c5","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":521583,"name":"symfony-docs","full_name":"symfony/symfony-docs","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony-docs","description":"The Symfony documentation","fork":false,"url":"https://api.github.com/repos/symfony/symfony-docs","forks_url":"https://api.github.com/repos/symfony/symfony-docs/forks","keys_url":"https://api.github.com/repos/symfony/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony-docs/teams","hooks_url":"https://api.github.com/repos/symfony/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony-docs/events","assignees_url":"https://api.github.com/repos/symfony/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony-docs/tags","blobs_url":"https://api.github.com/repos/symfony/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony-docs/subscription","commits_url":"https://api.github.com/repos/symfony/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony-docs/merges","archive_url":"https://api.github.com/repos/symfony/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony-docs/downloads","issues_url":"https://api.github.com/repos/symfony/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony-docs/releases{/id}","created_at":"2010-02-17T08:43:51Z","updated_at":"2015-12-18T13:47:47Z","pushed_at":"2015-12-19T10:47:08Z","git_url":"git://github.com/symfony/symfony-docs.git","ssh_url":"git@github.com:symfony/symfony-docs.git","clone_url":"https://github.com/symfony/symfony-docs.git","svn_url":"https://github.com/symfony/symfony-docs","homepage":"http://symfony.com/doc","size":42373,"stargazers_count":1059,"watchers_count":1059,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2170,"mirror_url":null,"open_issues_count":309,"forks":2170,"open_issues":309,"watchers":1059,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/5840"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/5840"},"issue":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/5840"},"comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/5840/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/5840/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/5840/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony-docs/statuses/f23b8d3c15dd3e3884ef556665441762e57ee699"}}}}