{"action":"created","comment":{"url":"https://api.github.com/repos/libevent/libevent/pulls/comments/37886151","id":37886151,"diff_hunk":"@@ -358,7 +358,7 @@ evutil_fast_socket_nonblocking(evutil_socket_t fd)\n int\n evutil_make_listen_socket_reuseable(evutil_socket_t sock)\n {\n-#ifndef _WIN32\n+#ifdef SO_REUSEADDR","path":"evutil.c","position":5,"original_position":5,"commit_id":"0a7b706b5ba63d97f90a796bc2d8c5f5c1431f63","original_commit_id":"0a7b706b5ba63d97f90a796bc2d8c5f5c1431f63","user":{"login":"azat","id":430798,"avatar_url":"https://avatars.githubusercontent.com/u/430798?v=3","gravatar_id":"","url":"https://api.github.com/users/azat","html_url":"https://github.com/azat","followers_url":"https://api.github.com/users/azat/followers","following_url":"https://api.github.com/users/azat/following{/other_user}","gists_url":"https://api.github.com/users/azat/gists{/gist_id}","starred_url":"https://api.github.com/users/azat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azat/subscriptions","organizations_url":"https://api.github.com/users/azat/orgs","repos_url":"https://api.github.com/users/azat/repos","events_url":"https://api.github.com/users/azat/events{/privacy}","received_events_url":"https://api.github.com/users/azat/received_events","type":"User","site_admin":false},"body":"The behavior of this flag on win32 differs from unix, do you mind if I will change this to?\r\n``` #if defined(SO_REUSEADDR) && !defined(_WIN32) ```","created_at":"2015-08-25T16:22:50Z","updated_at":"2015-08-25T16:22:50Z","html_url":"https://github.com/libevent/libevent/pull/275#discussion_r37886151","pull_request_url":"https://api.github.com/repos/libevent/libevent/pulls/275","_links":{"self":{"href":"https://api.github.com/repos/libevent/libevent/pulls/comments/37886151"},"html":{"href":"https://github.com/libevent/libevent/pull/275#discussion_r37886151"},"pull_request":{"href":"https://api.github.com/repos/libevent/libevent/pulls/275"}}},"pull_request":{"url":"https://api.github.com/repos/libevent/libevent/pulls/275","id":43285558,"html_url":"https://github.com/libevent/libevent/pull/275","diff_url":"https://github.com/libevent/libevent/pull/275.diff","patch_url":"https://github.com/libevent/libevent/pull/275.patch","issue_url":"https://api.github.com/repos/libevent/libevent/issues/275","number":275,"state":"open","locked":false,"title":"Test against SO_REUSEADDR instead of _WIN32.","user":{"login":"EdSchouten","id":736085,"avatar_url":"https://avatars.githubusercontent.com/u/736085?v=3","gravatar_id":"","url":"https://api.github.com/users/EdSchouten","html_url":"https://github.com/EdSchouten","followers_url":"https://api.github.com/users/EdSchouten/followers","following_url":"https://api.github.com/users/EdSchouten/following{/other_user}","gists_url":"https://api.github.com/users/EdSchouten/gists{/gist_id}","starred_url":"https://api.github.com/users/EdSchouten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdSchouten/subscriptions","organizations_url":"https://api.github.com/users/EdSchouten/orgs","repos_url":"https://api.github.com/users/EdSchouten/repos","events_url":"https://api.github.com/users/EdSchouten/events{/privacy}","received_events_url":"https://api.github.com/users/EdSchouten/received_events","type":"User","site_admin":false},"body":"This makes the code build on other systems that also don't have\r\nSO_REUSEADDR without requiring special code.","created_at":"2015-08-25T13:30:19Z","updated_at":"2015-08-25T16:22:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15b1f5a00e0773bd91ffb617b9f1bc0c1581f5a0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/libevent/libevent/pulls/275/commits","review_comments_url":"https://api.github.com/repos/libevent/libevent/pulls/275/comments","review_comment_url":"https://api.github.com/repos/libevent/libevent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libevent/libevent/issues/275/comments","statuses_url":"https://api.github.com/repos/libevent/libevent/statuses/0a7b706b5ba63d97f90a796bc2d8c5f5c1431f63","head":{"label":"NuxiNL:so_reuseaddr","ref":"so_reuseaddr","sha":"0a7b706b5ba63d97f90a796bc2d8c5f5c1431f63","user":{"login":"NuxiNL","id":10416187,"avatar_url":"https://avatars.githubusercontent.com/u/10416187?v=3","gravatar_id":"","url":"https://api.github.com/users/NuxiNL","html_url":"https://github.com/NuxiNL","followers_url":"https://api.github.com/users/NuxiNL/followers","following_url":"https://api.github.com/users/NuxiNL/following{/other_user}","gists_url":"https://api.github.com/users/NuxiNL/gists{/gist_id}","starred_url":"https://api.github.com/users/NuxiNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuxiNL/subscriptions","organizations_url":"https://api.github.com/users/NuxiNL/orgs","repos_url":"https://api.github.com/users/NuxiNL/repos","events_url":"https://api.github.com/users/NuxiNL/events{/privacy}","received_events_url":"https://api.github.com/users/NuxiNL/received_events","type":"Organization","site_admin":false},"repo":{"id":41364561,"name":"libevent","full_name":"NuxiNL/libevent","owner":{"login":"NuxiNL","id":10416187,"avatar_url":"https://avatars.githubusercontent.com/u/10416187?v=3","gravatar_id":"","url":"https://api.github.com/users/NuxiNL","html_url":"https://github.com/NuxiNL","followers_url":"https://api.github.com/users/NuxiNL/followers","following_url":"https://api.github.com/users/NuxiNL/following{/other_user}","gists_url":"https://api.github.com/users/NuxiNL/gists{/gist_id}","starred_url":"https://api.github.com/users/NuxiNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuxiNL/subscriptions","organizations_url":"https://api.github.com/users/NuxiNL/orgs","repos_url":"https://api.github.com/users/NuxiNL/repos","events_url":"https://api.github.com/users/NuxiNL/events{/privacy}","received_events_url":"https://api.github.com/users/NuxiNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuxiNL/libevent","description":"A public libevent repository.  The official repository is still at at  git://levent.git.sourceforge.net/gitroot/levent/libevent ","fork":true,"url":"https://api.github.com/repos/NuxiNL/libevent","forks_url":"https://api.github.com/repos/NuxiNL/libevent/forks","keys_url":"https://api.github.com/repos/NuxiNL/libevent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuxiNL/libevent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuxiNL/libevent/teams","hooks_url":"https://api.github.com/repos/NuxiNL/libevent/hooks","issue_events_url":"https://api.github.com/repos/NuxiNL/libevent/issues/events{/number}","events_url":"https://api.github.com/repos/NuxiNL/libevent/events","assignees_url":"https://api.github.com/repos/NuxiNL/libevent/assignees{/user}","branches_url":"https://api.github.com/repos/NuxiNL/libevent/branches{/branch}","tags_url":"https://api.github.com/repos/NuxiNL/libevent/tags","blobs_url":"https://api.github.com/repos/NuxiNL/libevent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuxiNL/libevent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuxiNL/libevent/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuxiNL/libevent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuxiNL/libevent/statuses/{sha}","languages_url":"https://api.github.com/repos/NuxiNL/libevent/languages","stargazers_url":"https://api.github.com/repos/NuxiNL/libevent/stargazers","contributors_url":"https://api.github.com/repos/NuxiNL/libevent/contributors","subscribers_url":"https://api.github.com/repos/NuxiNL/libevent/subscribers","subscription_url":"https://api.github.com/repos/NuxiNL/libevent/subscription","commits_url":"https://api.github.com/repos/NuxiNL/libevent/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuxiNL/libevent/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuxiNL/libevent/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuxiNL/libevent/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuxiNL/libevent/contents/{+path}","compare_url":"https://api.github.com/repos/NuxiNL/libevent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuxiNL/libevent/merges","archive_url":"https://api.github.com/repos/NuxiNL/libevent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuxiNL/libevent/downloads","issues_url":"https://api.github.com/repos/NuxiNL/libevent/issues{/number}","pulls_url":"https://api.github.com/repos/NuxiNL/libevent/pulls{/number}","milestones_url":"https://api.github.com/repos/NuxiNL/libevent/milestones{/number}","notifications_url":"https://api.github.com/repos/NuxiNL/libevent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuxiNL/libevent/labels{/name}","releases_url":"https://api.github.com/repos/NuxiNL/libevent/releases{/id}","created_at":"2015-08-25T13:22:18Z","updated_at":"2015-08-25T13:22:20Z","pushed_at":"2015-08-25T13:33:04Z","git_url":"git://github.com/NuxiNL/libevent.git","ssh_url":"git@github.com:NuxiNL/libevent.git","clone_url":"https://github.com/NuxiNL/libevent.git","svn_url":"https://github.com/NuxiNL/libevent","homepage":"http://libevent.org","size":20362,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libevent:master","ref":"master","sha":"c21229192f9dd1dd40b6c8d26adf7f9502625ede","user":{"login":"libevent","id":833750,"avatar_url":"https://avatars.githubusercontent.com/u/833750?v=3","gravatar_id":"","url":"https://api.github.com/users/libevent","html_url":"https://github.com/libevent","followers_url":"https://api.github.com/users/libevent/followers","following_url":"https://api.github.com/users/libevent/following{/other_user}","gists_url":"https://api.github.com/users/libevent/gists{/gist_id}","starred_url":"https://api.github.com/users/libevent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libevent/subscriptions","organizations_url":"https://api.github.com/users/libevent/orgs","repos_url":"https://api.github.com/users/libevent/repos","events_url":"https://api.github.com/users/libevent/events{/privacy}","received_events_url":"https://api.github.com/users/libevent/received_events","type":"Organization","site_admin":false},"repo":{"id":1856976,"name":"libevent","full_name":"libevent/libevent","owner":{"login":"libevent","id":833750,"avatar_url":"https://avatars.githubusercontent.com/u/833750?v=3","gravatar_id":"","url":"https://api.github.com/users/libevent","html_url":"https://github.com/libevent","followers_url":"https://api.github.com/users/libevent/followers","following_url":"https://api.github.com/users/libevent/following{/other_user}","gists_url":"https://api.github.com/users/libevent/gists{/gist_id}","starred_url":"https://api.github.com/users/libevent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libevent/subscriptions","organizations_url":"https://api.github.com/users/libevent/orgs","repos_url":"https://api.github.com/users/libevent/repos","events_url":"https://api.github.com/users/libevent/events{/privacy}","received_events_url":"https://api.github.com/users/libevent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libevent/libevent","description":"A public libevent repository.  The official repository is still at at  git://levent.git.sourceforge.net/gitroot/levent/libevent ","fork":true,"url":"https://api.github.com/repos/libevent/libevent","forks_url":"https://api.github.com/repos/libevent/libevent/forks","keys_url":"https://api.github.com/repos/libevent/libevent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libevent/libevent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libevent/libevent/teams","hooks_url":"https://api.github.com/repos/libevent/libevent/hooks","issue_events_url":"https://api.github.com/repos/libevent/libevent/issues/events{/number}","events_url":"https://api.github.com/repos/libevent/libevent/events","assignees_url":"https://api.github.com/repos/libevent/libevent/assignees{/user}","branches_url":"https://api.github.com/repos/libevent/libevent/branches{/branch}","tags_url":"https://api.github.com/repos/libevent/libevent/tags","blobs_url":"https://api.github.com/repos/libevent/libevent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libevent/libevent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libevent/libevent/git/refs{/sha}","trees_url":"https://api.github.com/repos/libevent/libevent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libevent/libevent/statuses/{sha}","languages_url":"https://api.github.com/repos/libevent/libevent/languages","stargazers_url":"https://api.github.com/repos/libevent/libevent/stargazers","contributors_url":"https://api.github.com/repos/libevent/libevent/contributors","subscribers_url":"https://api.github.com/repos/libevent/libevent/subscribers","subscription_url":"https://api.github.com/repos/libevent/libevent/subscription","commits_url":"https://api.github.com/repos/libevent/libevent/commits{/sha}","git_commits_url":"https://api.github.com/repos/libevent/libevent/git/commits{/sha}","comments_url":"https://api.github.com/repos/libevent/libevent/comments{/number}","issue_comment_url":"https://api.github.com/repos/libevent/libevent/issues/comments{/number}","contents_url":"https://api.github.com/repos/libevent/libevent/contents/{+path}","compare_url":"https://api.github.com/repos/libevent/libevent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libevent/libevent/merges","archive_url":"https://api.github.com/repos/libevent/libevent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libevent/libevent/downloads","issues_url":"https://api.github.com/repos/libevent/libevent/issues{/number}","pulls_url":"https://api.github.com/repos/libevent/libevent/pulls{/number}","milestones_url":"https://api.github.com/repos/libevent/libevent/milestones{/number}","notifications_url":"https://api.github.com/repos/libevent/libevent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libevent/libevent/labels{/name}","releases_url":"https://api.github.com/repos/libevent/libevent/releases{/id}","created_at":"2011-06-06T21:42:50Z","updated_at":"2015-08-25T08:08:49Z","pushed_at":"2015-08-25T13:33:20Z","git_url":"git://github.com/libevent/libevent.git","ssh_url":"git@github.com:libevent/libevent.git","clone_url":"https://github.com/libevent/libevent.git","svn_url":"https://github.com/libevent/libevent","homepage":"http://libevent.org","size":20362,"stargazers_count":1033,"watchers_count":1033,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":439,"mirror_url":null,"open_issues_count":81,"forks":439,"open_issues":81,"watchers":1033,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libevent/libevent/pulls/275"},"html":{"href":"https://github.com/libevent/libevent/pull/275"},"issue":{"href":"https://api.github.com/repos/libevent/libevent/issues/275"},"comments":{"href":"https://api.github.com/repos/libevent/libevent/issues/275/comments"},"review_comments":{"href":"https://api.github.com/repos/libevent/libevent/pulls/275/comments"},"review_comment":{"href":"https://api.github.com/repos/libevent/libevent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libevent/libevent/pulls/275/commits"},"statuses":{"href":"https://api.github.com/repos/libevent/libevent/statuses/0a7b706b5ba63d97f90a796bc2d8c5f5c1431f63"}}}}