{"action":"opened","number":58,"pull_request":{"url":"https://api.github.com/repos/wifidog/wifidog-gateway/pulls/58","id":30281859,"html_url":"https://github.com/wifidog/wifidog-gateway/pull/58","diff_url":"https://github.com/wifidog/wifidog-gateway/pull/58.diff","patch_url":"https://github.com/wifidog/wifidog-gateway/pull/58.patch","issue_url":"https://api.github.com/repos/wifidog/wifidog-gateway/issues/58","number":58,"state":"open","locked":false,"title":"No more reject and drop in nat table","user":{"login":"florida63","id":4621065,"avatar_url":"https://avatars.githubusercontent.com/u/4621065?v=3","gravatar_id":"","url":"https://api.github.com/users/florida63","html_url":"https://github.com/florida63","followers_url":"https://api.github.com/users/florida63/followers","following_url":"https://api.github.com/users/florida63/following{/other_user}","gists_url":"https://api.github.com/users/florida63/gists{/gist_id}","starred_url":"https://api.github.com/users/florida63/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florida63/subscriptions","organizations_url":"https://api.github.com/users/florida63/orgs","repos_url":"https://api.github.com/users/florida63/repos","events_url":"https://api.github.com/users/florida63/events{/privacy}","received_events_url":"https://api.github.com/users/florida63/received_events","type":"User","site_admin":false},"body":"This patch corrects the error messages related to the use of drop and block in nat table.\r\n\r\nfor example this config generates 2 errors messages (see 1 et 2) \r\n FirewallRuleSet global {\r\n  FirewallRule drop tcp port 25\r\n  FirewallRule block tcp port 30\r\n}\r\n\r\n\r\nerror 1:\r\nThe \"nat\" table is not intended for filtering, the use of DROP is therefore inhibited.\r\n\r\n\r\nTry `iptables -h' or 'iptables --help' for more information.\r\n[3][Thu Feb 26 10:20:08 2015][9860](fw_iptables.c:118) iptables command failed(2): iptables -t nat -A WiFiDog_eth1_Global -d 0.0.0.0/0 -p tcp --dport 25 -j DROP\r\n\r\nerror 2:\r\niptables: Invalid argument. Run `dmesg' for more information.\r\n[3][Thu Feb 26 10:20:08 2015][9860](fw_iptables.c:118) iptables command failed(1): iptables -t nat -A WiFiDog_eth1_Global -d 0.0.0.0/0 -p tcp --dport 30 -j REJECT\r\n\r\nthanks databeille\r\n","created_at":"2015-03-02T13:10:55Z","updated_at":"2015-03-02T13:10:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wifidog/wifidog-gateway/pulls/58/commits","review_comments_url":"https://api.github.com/repos/wifidog/wifidog-gateway/pulls/58/comments","review_comment_url":"https://api.github.com/repos/wifidog/wifidog-gateway/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wifidog/wifidog-gateway/issues/58/comments","statuses_url":"https://api.github.com/repos/wifidog/wifidog-gateway/statuses/ff6162b23ecb94071c2e3d33f4507c1fd4d88818","head":{"label":"florida63:No-more-REJECT-and-DROP-in-NAT-TABLE","ref":"No-more-REJECT-and-DROP-in-NAT-TABLE","sha":"ff6162b23ecb94071c2e3d33f4507c1fd4d88818","user":{"login":"florida63","id":4621065,"avatar_url":"https://avatars.githubusercontent.com/u/4621065?v=3","gravatar_id":"","url":"https://api.github.com/users/florida63","html_url":"https://github.com/florida63","followers_url":"https://api.github.com/users/florida63/followers","following_url":"https://api.github.com/users/florida63/following{/other_user}","gists_url":"https://api.github.com/users/florida63/gists{/gist_id}","starred_url":"https://api.github.com/users/florida63/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florida63/subscriptions","organizations_url":"https://api.github.com/users/florida63/orgs","repos_url":"https://api.github.com/users/florida63/repos","events_url":"https://api.github.com/users/florida63/events{/privacy}","received_events_url":"https://api.github.com/users/florida63/received_events","type":"User","site_admin":false},"repo":{"id":28294346,"name":"wifidog-gateway","full_name":"florida63/wifidog-gateway","owner":{"login":"florida63","id":4621065,"avatar_url":"https://avatars.githubusercontent.com/u/4621065?v=3","gravatar_id":"","url":"https://api.github.com/users/florida63","html_url":"https://github.com/florida63","followers_url":"https://api.github.com/users/florida63/followers","following_url":"https://api.github.com/users/florida63/following{/other_user}","gists_url":"https://api.github.com/users/florida63/gists{/gist_id}","starred_url":"https://api.github.com/users/florida63/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florida63/subscriptions","organizations_url":"https://api.github.com/users/florida63/orgs","repos_url":"https://api.github.com/users/florida63/repos","events_url":"https://api.github.com/users/florida63/events{/privacy}","received_events_url":"https://api.github.com/users/florida63/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/florida63/wifidog-gateway","description":"Repository for the wifidog-gateway captive portal designed for embeeded systems","fork":true,"url":"https://api.github.com/repos/florida63/wifidog-gateway","forks_url":"https://api.github.com/repos/florida63/wifidog-gateway/forks","keys_url":"https://api.github.com/repos/florida63/wifidog-gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/florida63/wifidog-gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/florida63/wifidog-gateway/teams","hooks_url":"https://api.github.com/repos/florida63/wifidog-gateway/hooks","issue_events_url":"https://api.github.com/repos/florida63/wifidog-gateway/issues/events{/number}","events_url":"https://api.github.com/repos/florida63/wifidog-gateway/events","assignees_url":"https://api.github.com/repos/florida63/wifidog-gateway/assignees{/user}","branches_url":"https://api.github.com/repos/florida63/wifidog-gateway/branches{/branch}","tags_url":"https://api.github.com/repos/florida63/wifidog-gateway/tags","blobs_url":"https://api.github.com/repos/florida63/wifidog-gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/florida63/wifidog-gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/florida63/wifidog-gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/florida63/wifidog-gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/florida63/wifidog-gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/florida63/wifidog-gateway/languages","stargazers_url":"https://api.github.com/repos/florida63/wifidog-gateway/stargazers","contributors_url":"https://api.github.com/repos/florida63/wifidog-gateway/contributors","subscribers_url":"https://api.github.com/repos/florida63/wifidog-gateway/subscribers","subscription_url":"https://api.github.com/repos/florida63/wifidog-gateway/subscription","commits_url":"https://api.github.com/repos/florida63/wifidog-gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/florida63/wifidog-gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/florida63/wifidog-gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/florida63/wifidog-gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/florida63/wifidog-gateway/contents/{+path}","compare_url":"https://api.github.com/repos/florida63/wifidog-gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/florida63/wifidog-gateway/merges","archive_url":"https://api.github.com/repos/florida63/wifidog-gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/florida63/wifidog-gateway/downloads","issues_url":"https://api.github.com/repos/florida63/wifidog-gateway/issues{/number}","pulls_url":"https://api.github.com/repos/florida63/wifidog-gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/florida63/wifidog-gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/florida63/wifidog-gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/florida63/wifidog-gateway/labels{/name}","releases_url":"https://api.github.com/repos/florida63/wifidog-gateway/releases{/id}","created_at":"2014-12-21T09:30:59Z","updated_at":"2015-02-16T14:19:03Z","pushed_at":"2015-02-26T13:21:55Z","git_url":"git://github.com/florida63/wifidog-gateway.git","ssh_url":"git@github.com:florida63/wifidog-gateway.git","clone_url":"https://github.com/florida63/wifidog-gateway.git","svn_url":"https://github.com/florida63/wifidog-gateway","homepage":null,"size":1232,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wifidog:master","ref":"master","sha":"039451d4440127e7ed9b0db2cbd4ec295f0e78ba","user":{"login":"wifidog","id":4562596,"avatar_url":"https://avatars.githubusercontent.com/u/4562596?v=3","gravatar_id":"","url":"https://api.github.com/users/wifidog","html_url":"https://github.com/wifidog","followers_url":"https://api.github.com/users/wifidog/followers","following_url":"https://api.github.com/users/wifidog/following{/other_user}","gists_url":"https://api.github.com/users/wifidog/gists{/gist_id}","starred_url":"https://api.github.com/users/wifidog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wifidog/subscriptions","organizations_url":"https://api.github.com/users/wifidog/orgs","repos_url":"https://api.github.com/users/wifidog/repos","events_url":"https://api.github.com/users/wifidog/events{/privacy}","received_events_url":"https://api.github.com/users/wifidog/received_events","type":"Organization","site_admin":false},"repo":{"id":8316778,"name":"wifidog-gateway","full_name":"wifidog/wifidog-gateway","owner":{"login":"wifidog","id":4562596,"avatar_url":"https://avatars.githubusercontent.com/u/4562596?v=3","gravatar_id":"","url":"https://api.github.com/users/wifidog","html_url":"https://github.com/wifidog","followers_url":"https://api.github.com/users/wifidog/followers","following_url":"https://api.github.com/users/wifidog/following{/other_user}","gists_url":"https://api.github.com/users/wifidog/gists{/gist_id}","starred_url":"https://api.github.com/users/wifidog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wifidog/subscriptions","organizations_url":"https://api.github.com/users/wifidog/orgs","repos_url":"https://api.github.com/users/wifidog/repos","events_url":"https://api.github.com/users/wifidog/events{/privacy}","received_events_url":"https://api.github.com/users/wifidog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wifidog/wifidog-gateway","description":"Repository for the wifidog-gateway captive portal designed for embeeded systems","fork":false,"url":"https://api.github.com/repos/wifidog/wifidog-gateway","forks_url":"https://api.github.com/repos/wifidog/wifidog-gateway/forks","keys_url":"https://api.github.com/repos/wifidog/wifidog-gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wifidog/wifidog-gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wifidog/wifidog-gateway/teams","hooks_url":"https://api.github.com/repos/wifidog/wifidog-gateway/hooks","issue_events_url":"https://api.github.com/repos/wifidog/wifidog-gateway/issues/events{/number}","events_url":"https://api.github.com/repos/wifidog/wifidog-gateway/events","assignees_url":"https://api.github.com/repos/wifidog/wifidog-gateway/assignees{/user}","branches_url":"https://api.github.com/repos/wifidog/wifidog-gateway/branches{/branch}","tags_url":"https://api.github.com/repos/wifidog/wifidog-gateway/tags","blobs_url":"https://api.github.com/repos/wifidog/wifidog-gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wifidog/wifidog-gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wifidog/wifidog-gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/wifidog/wifidog-gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wifidog/wifidog-gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/wifidog/wifidog-gateway/languages","stargazers_url":"https://api.github.com/repos/wifidog/wifidog-gateway/stargazers","contributors_url":"https://api.github.com/repos/wifidog/wifidog-gateway/contributors","subscribers_url":"https://api.github.com/repos/wifidog/wifidog-gateway/subscribers","subscription_url":"https://api.github.com/repos/wifidog/wifidog-gateway/subscription","commits_url":"https://api.github.com/repos/wifidog/wifidog-gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/wifidog/wifidog-gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/wifidog/wifidog-gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/wifidog/wifidog-gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/wifidog/wifidog-gateway/contents/{+path}","compare_url":"https://api.github.com/repos/wifidog/wifidog-gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wifidog/wifidog-gateway/merges","archive_url":"https://api.github.com/repos/wifidog/wifidog-gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wifidog/wifidog-gateway/downloads","issues_url":"https://api.github.com/repos/wifidog/wifidog-gateway/issues{/number}","pulls_url":"https://api.github.com/repos/wifidog/wifidog-gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/wifidog/wifidog-gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/wifidog/wifidog-gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wifidog/wifidog-gateway/labels{/name}","releases_url":"https://api.github.com/repos/wifidog/wifidog-gateway/releases{/id}","created_at":"2013-02-20T16:15:11Z","updated_at":"2015-02-27T06:51:11Z","pushed_at":"2015-02-21T11:04:33Z","git_url":"git://github.com/wifidog/wifidog-gateway.git","ssh_url":"git@github.com:wifidog/wifidog-gateway.git","clone_url":"https://github.com/wifidog/wifidog-gateway.git","svn_url":"https://github.com/wifidog/wifidog-gateway","homepage":null,"size":1870,"stargazers_count":115,"watchers_count":115,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":21,"forks":95,"open_issues":21,"watchers":115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wifidog/wifidog-gateway/pulls/58"},"html":{"href":"https://github.com/wifidog/wifidog-gateway/pull/58"},"issue":{"href":"https://api.github.com/repos/wifidog/wifidog-gateway/issues/58"},"comments":{"href":"https://api.github.com/repos/wifidog/wifidog-gateway/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/wifidog/wifidog-gateway/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/wifidog/wifidog-gateway/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wifidog/wifidog-gateway/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/wifidog/wifidog-gateway/statuses/ff6162b23ecb94071c2e3d33f4507c1fd4d88818"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":13,"deletions":3,"changed_files":1}}