{"action":"created","comment":{"url":"https://api.github.com/repos/mbryzek/apidoc/pulls/comments/46647650","id":46647650,"diff_hunk":"@@ -260,7 +272,16 @@\n \t\"deprecation\": {\n \t    \"description\": \"Indicates that this particular element is considered deprecated in the API. See the description for details\",\n \t    \"fields\": [\n-\t\t{ \"name\": \"description\", \"type\": \"string\", \"required\": false }\n+\t\t{ \"name\": \"description\", \"type\": \"string\", \"required\": false },\n+\t\t{ \"name\": \"attributes\", \"type\": \"[attribute]\", \"default\": \"[]\" }\n+\t    ]\n+\t},\n+\n+\t\"attribute\": {\n+\t    \"description\": \"Represents an additional attribute that is attached to one of the objects in apidoc. The main use case is to caprue additional metadata that doesn't necessarily define the API but aids in code generation. Examples would be hints for certain code generators about classes to extend, interfaces to implement, annotations to add, names to assign to certain methods, etc. The specific attributes will be applicable only in the context of the specific code generators usings them.\",\n+\t    \"fields\": [\n+\t\t{ \"name\": \"name\", \"type\": \"string\" },\n+\t\t{ \"name\": \"value\", \"type\": \"object\" }","path":"spec/spec.json","position":134,"original_position":134,"commit_id":"29f3ce6b698639538c1328f96bb672035c2379b8","original_commit_id":"29f3ce6b698639538c1328f96bb672035c2379b8","user":{"login":"Seanstoppable","id":1523955,"avatar_url":"https://avatars.githubusercontent.com/u/1523955?v=3","gravatar_id":"","url":"https://api.github.com/users/Seanstoppable","html_url":"https://github.com/Seanstoppable","followers_url":"https://api.github.com/users/Seanstoppable/followers","following_url":"https://api.github.com/users/Seanstoppable/following{/other_user}","gists_url":"https://api.github.com/users/Seanstoppable/gists{/gist_id}","starred_url":"https://api.github.com/users/Seanstoppable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Seanstoppable/subscriptions","organizations_url":"https://api.github.com/users/Seanstoppable/orgs","repos_url":"https://api.github.com/users/Seanstoppable/repos","events_url":"https://api.github.com/users/Seanstoppable/events{/privacy}","received_events_url":"https://api.github.com/users/Seanstoppable/received_events","type":"User","site_admin":false},"body":"Only see name and value. I believe we should also have a description, as per most other objects. For documentation at least, since JSON does not allow you to do comments.","created_at":"2015-12-04T04:12:48Z","updated_at":"2015-12-04T04:12:48Z","html_url":"https://github.com/mbryzek/apidoc/pull/386#discussion_r46647650","pull_request_url":"https://api.github.com/repos/mbryzek/apidoc/pulls/386","_links":{"self":{"href":"https://api.github.com/repos/mbryzek/apidoc/pulls/comments/46647650"},"html":{"href":"https://github.com/mbryzek/apidoc/pull/386#discussion_r46647650"},"pull_request":{"href":"https://api.github.com/repos/mbryzek/apidoc/pulls/386"}}},"pull_request":{"url":"https://api.github.com/repos/mbryzek/apidoc/pulls/386","id":52624584,"html_url":"https://github.com/mbryzek/apidoc/pull/386","diff_url":"https://github.com/mbryzek/apidoc/pull/386.diff","patch_url":"https://github.com/mbryzek/apidoc/pull/386.patch","issue_url":"https://api.github.com/repos/mbryzek/apidoc/issues/386","number":386,"state":"open","locked":false,"title":"Support for attributes","user":{"login":"mbryzek","id":49875,"avatar_url":"https://avatars.githubusercontent.com/u/49875?v=3","gravatar_id":"","url":"https://api.github.com/users/mbryzek","html_url":"https://github.com/mbryzek","followers_url":"https://api.github.com/users/mbryzek/followers","following_url":"https://api.github.com/users/mbryzek/following{/other_user}","gists_url":"https://api.github.com/users/mbryzek/gists{/gist_id}","starred_url":"https://api.github.com/users/mbryzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbryzek/subscriptions","organizations_url":"https://api.github.com/users/mbryzek/orgs","repos_url":"https://api.github.com/users/mbryzek/repos","events_url":"https://api.github.com/users/mbryzek/events{/privacy}","received_events_url":"https://api.github.com/users/mbryzek/received_events","type":"User","site_admin":false},"body":" - Introduce concept of an attribute as a container to pass\r\n   data directly into code generators\r\n - General idea to support metadata 'hints' that aid code\r\n    generation but do not really define the API\r\n - Attached to all elements - following the design of the\r\n    deprecation object","created_at":"2015-12-04T03:02:56Z","updated_at":"2015-12-04T04:12:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3bbe3fa4cba54d0019faa93e83414b4aeeccb34","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mbryzek/apidoc/pulls/386/commits","review_comments_url":"https://api.github.com/repos/mbryzek/apidoc/pulls/386/comments","review_comment_url":"https://api.github.com/repos/mbryzek/apidoc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mbryzek/apidoc/issues/386/comments","statuses_url":"https://api.github.com/repos/mbryzek/apidoc/statuses/29f3ce6b698639538c1328f96bb672035c2379b8","head":{"label":"mbryzek:attributes","ref":"attributes","sha":"29f3ce6b698639538c1328f96bb672035c2379b8","user":{"login":"mbryzek","id":49875,"avatar_url":"https://avatars.githubusercontent.com/u/49875?v=3","gravatar_id":"","url":"https://api.github.com/users/mbryzek","html_url":"https://github.com/mbryzek","followers_url":"https://api.github.com/users/mbryzek/followers","following_url":"https://api.github.com/users/mbryzek/following{/other_user}","gists_url":"https://api.github.com/users/mbryzek/gists{/gist_id}","starred_url":"https://api.github.com/users/mbryzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbryzek/subscriptions","organizations_url":"https://api.github.com/users/mbryzek/orgs","repos_url":"https://api.github.com/users/mbryzek/repos","events_url":"https://api.github.com/users/mbryzek/events{/privacy}","received_events_url":"https://api.github.com/users/mbryzek/received_events","type":"User","site_admin":false},"repo":{"id":18494160,"name":"apidoc","full_name":"mbryzek/apidoc","owner":{"login":"mbryzek","id":49875,"avatar_url":"https://avatars.githubusercontent.com/u/49875?v=3","gravatar_id":"","url":"https://api.github.com/users/mbryzek","html_url":"https://github.com/mbryzek","followers_url":"https://api.github.com/users/mbryzek/followers","following_url":"https://api.github.com/users/mbryzek/following{/other_user}","gists_url":"https://api.github.com/users/mbryzek/gists{/gist_id}","starred_url":"https://api.github.com/users/mbryzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbryzek/subscriptions","organizations_url":"https://api.github.com/users/mbryzek/orgs","repos_url":"https://api.github.com/users/mbryzek/repos","events_url":"https://api.github.com/users/mbryzek/events{/privacy}","received_events_url":"https://api.github.com/users/mbryzek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbryzek/apidoc","description":"Beautiful documentation for REST services. Simple native client libraries with no dependencies. ","fork":false,"url":"https://api.github.com/repos/mbryzek/apidoc","forks_url":"https://api.github.com/repos/mbryzek/apidoc/forks","keys_url":"https://api.github.com/repos/mbryzek/apidoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbryzek/apidoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbryzek/apidoc/teams","hooks_url":"https://api.github.com/repos/mbryzek/apidoc/hooks","issue_events_url":"https://api.github.com/repos/mbryzek/apidoc/issues/events{/number}","events_url":"https://api.github.com/repos/mbryzek/apidoc/events","assignees_url":"https://api.github.com/repos/mbryzek/apidoc/assignees{/user}","branches_url":"https://api.github.com/repos/mbryzek/apidoc/branches{/branch}","tags_url":"https://api.github.com/repos/mbryzek/apidoc/tags","blobs_url":"https://api.github.com/repos/mbryzek/apidoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbryzek/apidoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbryzek/apidoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbryzek/apidoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbryzek/apidoc/statuses/{sha}","languages_url":"https://api.github.com/repos/mbryzek/apidoc/languages","stargazers_url":"https://api.github.com/repos/mbryzek/apidoc/stargazers","contributors_url":"https://api.github.com/repos/mbryzek/apidoc/contributors","subscribers_url":"https://api.github.com/repos/mbryzek/apidoc/subscribers","subscription_url":"https://api.github.com/repos/mbryzek/apidoc/subscription","commits_url":"https://api.github.com/repos/mbryzek/apidoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbryzek/apidoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbryzek/apidoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbryzek/apidoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbryzek/apidoc/contents/{+path}","compare_url":"https://api.github.com/repos/mbryzek/apidoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbryzek/apidoc/merges","archive_url":"https://api.github.com/repos/mbryzek/apidoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbryzek/apidoc/downloads","issues_url":"https://api.github.com/repos/mbryzek/apidoc/issues{/number}","pulls_url":"https://api.github.com/repos/mbryzek/apidoc/pulls{/number}","milestones_url":"https://api.github.com/repos/mbryzek/apidoc/milestones{/number}","notifications_url":"https://api.github.com/repos/mbryzek/apidoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbryzek/apidoc/labels{/name}","releases_url":"https://api.github.com/repos/mbryzek/apidoc/releases{/id}","created_at":"2014-04-06T16:51:26Z","updated_at":"2015-12-04T03:53:11Z","pushed_at":"2015-12-04T03:02:56Z","git_url":"git://github.com/mbryzek/apidoc.git","ssh_url":"git@github.com:mbryzek/apidoc.git","clone_url":"https://github.com/mbryzek/apidoc.git","svn_url":"https://github.com/mbryzek/apidoc","homepage":"http://www.apidoc.me/doc/","size":8723,"stargazers_count":112,"watchers_count":112,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":34,"forks":29,"open_issues":34,"watchers":112,"default_branch":"master"}},"base":{"label":"mbryzek:master","ref":"master","sha":"158053ce867b456d035aabba4212b2fe82df06d9","user":{"login":"mbryzek","id":49875,"avatar_url":"https://avatars.githubusercontent.com/u/49875?v=3","gravatar_id":"","url":"https://api.github.com/users/mbryzek","html_url":"https://github.com/mbryzek","followers_url":"https://api.github.com/users/mbryzek/followers","following_url":"https://api.github.com/users/mbryzek/following{/other_user}","gists_url":"https://api.github.com/users/mbryzek/gists{/gist_id}","starred_url":"https://api.github.com/users/mbryzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbryzek/subscriptions","organizations_url":"https://api.github.com/users/mbryzek/orgs","repos_url":"https://api.github.com/users/mbryzek/repos","events_url":"https://api.github.com/users/mbryzek/events{/privacy}","received_events_url":"https://api.github.com/users/mbryzek/received_events","type":"User","site_admin":false},"repo":{"id":18494160,"name":"apidoc","full_name":"mbryzek/apidoc","owner":{"login":"mbryzek","id":49875,"avatar_url":"https://avatars.githubusercontent.com/u/49875?v=3","gravatar_id":"","url":"https://api.github.com/users/mbryzek","html_url":"https://github.com/mbryzek","followers_url":"https://api.github.com/users/mbryzek/followers","following_url":"https://api.github.com/users/mbryzek/following{/other_user}","gists_url":"https://api.github.com/users/mbryzek/gists{/gist_id}","starred_url":"https://api.github.com/users/mbryzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbryzek/subscriptions","organizations_url":"https://api.github.com/users/mbryzek/orgs","repos_url":"https://api.github.com/users/mbryzek/repos","events_url":"https://api.github.com/users/mbryzek/events{/privacy}","received_events_url":"https://api.github.com/users/mbryzek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbryzek/apidoc","description":"Beautiful documentation for REST services. Simple native client libraries with no dependencies. ","fork":false,"url":"https://api.github.com/repos/mbryzek/apidoc","forks_url":"https://api.github.com/repos/mbryzek/apidoc/forks","keys_url":"https://api.github.com/repos/mbryzek/apidoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbryzek/apidoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbryzek/apidoc/teams","hooks_url":"https://api.github.com/repos/mbryzek/apidoc/hooks","issue_events_url":"https://api.github.com/repos/mbryzek/apidoc/issues/events{/number}","events_url":"https://api.github.com/repos/mbryzek/apidoc/events","assignees_url":"https://api.github.com/repos/mbryzek/apidoc/assignees{/user}","branches_url":"https://api.github.com/repos/mbryzek/apidoc/branches{/branch}","tags_url":"https://api.github.com/repos/mbryzek/apidoc/tags","blobs_url":"https://api.github.com/repos/mbryzek/apidoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbryzek/apidoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbryzek/apidoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbryzek/apidoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbryzek/apidoc/statuses/{sha}","languages_url":"https://api.github.com/repos/mbryzek/apidoc/languages","stargazers_url":"https://api.github.com/repos/mbryzek/apidoc/stargazers","contributors_url":"https://api.github.com/repos/mbryzek/apidoc/contributors","subscribers_url":"https://api.github.com/repos/mbryzek/apidoc/subscribers","subscription_url":"https://api.github.com/repos/mbryzek/apidoc/subscription","commits_url":"https://api.github.com/repos/mbryzek/apidoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbryzek/apidoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbryzek/apidoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbryzek/apidoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbryzek/apidoc/contents/{+path}","compare_url":"https://api.github.com/repos/mbryzek/apidoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbryzek/apidoc/merges","archive_url":"https://api.github.com/repos/mbryzek/apidoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbryzek/apidoc/downloads","issues_url":"https://api.github.com/repos/mbryzek/apidoc/issues{/number}","pulls_url":"https://api.github.com/repos/mbryzek/apidoc/pulls{/number}","milestones_url":"https://api.github.com/repos/mbryzek/apidoc/milestones{/number}","notifications_url":"https://api.github.com/repos/mbryzek/apidoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbryzek/apidoc/labels{/name}","releases_url":"https://api.github.com/repos/mbryzek/apidoc/releases{/id}","created_at":"2014-04-06T16:51:26Z","updated_at":"2015-12-04T03:53:11Z","pushed_at":"2015-12-04T03:02:56Z","git_url":"git://github.com/mbryzek/apidoc.git","ssh_url":"git@github.com:mbryzek/apidoc.git","clone_url":"https://github.com/mbryzek/apidoc.git","svn_url":"https://github.com/mbryzek/apidoc","homepage":"http://www.apidoc.me/doc/","size":8723,"stargazers_count":112,"watchers_count":112,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":34,"forks":29,"open_issues":34,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mbryzek/apidoc/pulls/386"},"html":{"href":"https://github.com/mbryzek/apidoc/pull/386"},"issue":{"href":"https://api.github.com/repos/mbryzek/apidoc/issues/386"},"comments":{"href":"https://api.github.com/repos/mbryzek/apidoc/issues/386/comments"},"review_comments":{"href":"https://api.github.com/repos/mbryzek/apidoc/pulls/386/comments"},"review_comment":{"href":"https://api.github.com/repos/mbryzek/apidoc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mbryzek/apidoc/pulls/386/commits"},"statuses":{"href":"https://api.github.com/repos/mbryzek/apidoc/statuses/29f3ce6b698639538c1328f96bb672035c2379b8"}}}}