{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/29580505","id":29580505,"diff_hunk":"@@ -0,0 +1,102 @@\n+/*\r\n+ * The MIT License\r\n+ *\r\n+ * Copyright (c) 2015, Daniel Weber\r\n+ *\r\n+ * Permission is hereby granted, free of charge, to any person obtaining a copy\r\n+ * of this software and associated documentation files (the \"Software\"), to deal\r\n+ * in the Software without restriction, including without limitation the rights\r\n+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\r\n+ * copies of the Software, and to permit persons to whom the Software is\r\n+ * furnished to do so, subject to the following conditions:\r\n+ *\r\n+ * The above copyright notice and this permission notice shall be included in\r\n+ * all copies or substantial portions of the Software.\r\n+ *\r\n+ * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\r\n+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\r\n+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\r\n+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\r\n+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\r\n+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\r\n+ * THE SOFTWARE.\r\n+ */\r\n+package hudson.util;\r\n+\r\n+import hudson.ExtensionPoint;\r\n+import hudson.util.ProcessTreeRemoting.IOSProcess;\r\n+\r\n+import java.util.Collections;\r\n+import java.util.List;\r\n+\r\n+import javax.annotation.CheckForNull;\r\n+import javax.annotation.Nonnull;\r\n+\r\n+import jenkins.model.Jenkins;\r\n+\r\n+/**\r\n+ * Allows extensions to veto killing processes. If at least one extension vetoes\r\n+ * the killing of a process, it will not be killed. This can be useful to keep\r\n+ * daemon processes alive. An example is mspdbsrv.exe used by Microsoft\r\n+ * compilers.\r\n+ * \r\n+ * See JENKINS-9104\r\n+ * \r\n+ * @author Daniel Weber <daniel.weber.dev@gmail.com>\r\n+ */\r\n+public abstract class ProcessKillingVeto implements ExtensionPoint {\r\n+\r\n+   /**\r\n+    * Describes the cause for a process killing veto.\r\n+    */\r\n+   public static class VetoCause {\r","path":"core/src/main/java/hudson/util/ProcessKillingVeto.java","position":52,"original_position":52,"commit_id":"8d2c729c7e581dc45b919fa019db4a1bc3e4c7fa","original_commit_id":"8d2c729c7e581dc45b919fa019db4a1bc3e4c7fa","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"Since you are not using this cause for any purpose that I can see, it would be return to just return a `boolean`: kill or do not kill.","created_at":"2015-05-04T12:31:53Z","updated_at":"2015-05-04T12:31:53Z","html_url":"https://github.com/jenkinsci/jenkins/pull/1684#discussion_r29580505","pull_request_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1684","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/29580505"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1684#discussion_r29580505"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1684"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1684","id":34598251,"html_url":"https://github.com/jenkinsci/jenkins/pull/1684","diff_url":"https://github.com/jenkinsci/jenkins/pull/1684.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/1684.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1684","number":1684,"state":"open","locked":false,"title":"[JENKINS-9104] Add extension point that allows extensions to veto killing...","user":{"login":"DanielWeber","id":61663,"avatar_url":"https://avatars.githubusercontent.com/u/61663?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielWeber","html_url":"https://github.com/DanielWeber","followers_url":"https://api.github.com/users/DanielWeber/followers","following_url":"https://api.github.com/users/DanielWeber/following{/other_user}","gists_url":"https://api.github.com/users/DanielWeber/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielWeber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielWeber/subscriptions","organizations_url":"https://api.github.com/users/DanielWeber/orgs","repos_url":"https://api.github.com/users/DanielWeber/repos","events_url":"https://api.github.com/users/DanielWeber/events{/privacy}","received_events_url":"https://api.github.com/users/DanielWeber/received_events","type":"User","site_admin":false},"body":"... of certain processes.\r\n\r\nThis is only a part of a solution for the issue, the rest should be taken care of in plugins.\r\n\r\nThis pull request replaces https://github.com/jenkinsci/jenkins/pull/1562","created_at":"2015-05-03T08:40:00Z","updated_at":"2015-05-04T12:31:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99b6b3f03f4ecc24cfa90218e6a3b097a2724cd9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1684/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1684/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1684/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/8d2c729c7e581dc45b919fa019db4a1bc3e4c7fa","head":{"label":"DanielWeber:JENKINS-9104","ref":"JENKINS-9104","sha":"8d2c729c7e581dc45b919fa019db4a1bc3e4c7fa","user":{"login":"DanielWeber","id":61663,"avatar_url":"https://avatars.githubusercontent.com/u/61663?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielWeber","html_url":"https://github.com/DanielWeber","followers_url":"https://api.github.com/users/DanielWeber/followers","following_url":"https://api.github.com/users/DanielWeber/following{/other_user}","gists_url":"https://api.github.com/users/DanielWeber/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielWeber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielWeber/subscriptions","organizations_url":"https://api.github.com/users/DanielWeber/orgs","repos_url":"https://api.github.com/users/DanielWeber/repos","events_url":"https://api.github.com/users/DanielWeber/events{/privacy}","received_events_url":"https://api.github.com/users/DanielWeber/received_events","type":"User","site_admin":false},"repo":{"id":29321665,"name":"jenkins","full_name":"DanielWeber/jenkins","owner":{"login":"DanielWeber","id":61663,"avatar_url":"https://avatars.githubusercontent.com/u/61663?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielWeber","html_url":"https://github.com/DanielWeber","followers_url":"https://api.github.com/users/DanielWeber/followers","following_url":"https://api.github.com/users/DanielWeber/following{/other_user}","gists_url":"https://api.github.com/users/DanielWeber/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielWeber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielWeber/subscriptions","organizations_url":"https://api.github.com/users/DanielWeber/orgs","repos_url":"https://api.github.com/users/DanielWeber/repos","events_url":"https://api.github.com/users/DanielWeber/events{/privacy}","received_events_url":"https://api.github.com/users/DanielWeber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DanielWeber/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/DanielWeber/jenkins","forks_url":"https://api.github.com/repos/DanielWeber/jenkins/forks","keys_url":"https://api.github.com/repos/DanielWeber/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DanielWeber/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DanielWeber/jenkins/teams","hooks_url":"https://api.github.com/repos/DanielWeber/jenkins/hooks","issue_events_url":"https://api.github.com/repos/DanielWeber/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/DanielWeber/jenkins/events","assignees_url":"https://api.github.com/repos/DanielWeber/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/DanielWeber/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/DanielWeber/jenkins/tags","blobs_url":"https://api.github.com/repos/DanielWeber/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DanielWeber/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DanielWeber/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/DanielWeber/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DanielWeber/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/DanielWeber/jenkins/languages","stargazers_url":"https://api.github.com/repos/DanielWeber/jenkins/stargazers","contributors_url":"https://api.github.com/repos/DanielWeber/jenkins/contributors","subscribers_url":"https://api.github.com/repos/DanielWeber/jenkins/subscribers","subscription_url":"https://api.github.com/repos/DanielWeber/jenkins/subscription","commits_url":"https://api.github.com/repos/DanielWeber/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/DanielWeber/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/DanielWeber/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/DanielWeber/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/DanielWeber/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/DanielWeber/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DanielWeber/jenkins/merges","archive_url":"https://api.github.com/repos/DanielWeber/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DanielWeber/jenkins/downloads","issues_url":"https://api.github.com/repos/DanielWeber/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/DanielWeber/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/DanielWeber/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/DanielWeber/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DanielWeber/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/DanielWeber/jenkins/releases{/id}","created_at":"2015-01-15T22:35:44Z","updated_at":"2015-02-03T22:47:07Z","pushed_at":"2015-05-03T12:03:13Z","git_url":"git://github.com/DanielWeber/jenkins.git","ssh_url":"git@github.com:DanielWeber/jenkins.git","clone_url":"https://github.com/DanielWeber/jenkins.git","svn_url":"https://github.com/DanielWeber/jenkins","homepage":"http://jenkins-ci.org/","size":81641,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"23758d49b087c2c32733c88e1203143bd1f52af2","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","created_at":"2010-11-22T21:21:23Z","updated_at":"2015-05-04T12:27:42Z","pushed_at":"2015-05-04T12:27:41Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"http://jenkins-ci.org/","size":419730,"stargazers_count":4044,"watchers_count":4044,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1806,"mirror_url":null,"open_issues_count":106,"forks":1806,"open_issues":106,"watchers":4044,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1684"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1684"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1684"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1684/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1684/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1684/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/8d2c729c7e581dc45b919fa019db4a1bc3e4c7fa"}}}}