{"action":"created","issue":{"url":"https://api.github.com/repos/angular-ui/bootstrap/issues/4293","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/4293/labels{/name}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/4293/comments","events_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/4293/events","html_url":"https://github.com/angular-ui/bootstrap/pull/4293","id":103604333,"number":4293,"title":"fix(position): improve placing around corners","user":{"login":"ksheedlo","id":1271410,"avatar_url":"https://avatars.githubusercontent.com/u/1271410?v=3","gravatar_id":"","url":"https://api.github.com/users/ksheedlo","html_url":"https://github.com/ksheedlo","followers_url":"https://api.github.com/users/ksheedlo/followers","following_url":"https://api.github.com/users/ksheedlo/following{/other_user}","gists_url":"https://api.github.com/users/ksheedlo/gists{/gist_id}","starred_url":"https://api.github.com/users/ksheedlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksheedlo/subscriptions","organizations_url":"https://api.github.com/users/ksheedlo/orgs","repos_url":"https://api.github.com/users/ksheedlo/repos","events_url":"https://api.github.com/users/ksheedlo/events{/privacy}","received_events_url":"https://api.github.com/users/ksheedlo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular-ui/bootstrap/labels/needs:%20review","name":"needs: review","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/angular-ui/bootstrap/milestones/19","html_url":"https://github.com/angular-ui/bootstrap/milestones/0.14.0%20(Bootstrap%203.3)","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/milestones/19/labels","id":1022385,"number":19,"title":"0.14.0 (Bootstrap 3.3)","description":"Full Bootstrap v3.3.2 compatibility","creator":{"login":"rvanbaalen","id":220637,"avatar_url":"https://avatars.githubusercontent.com/u/220637?v=3","gravatar_id":"","url":"https://api.github.com/users/rvanbaalen","html_url":"https://github.com/rvanbaalen","followers_url":"https://api.github.com/users/rvanbaalen/followers","following_url":"https://api.github.com/users/rvanbaalen/following{/other_user}","gists_url":"https://api.github.com/users/rvanbaalen/gists{/gist_id}","starred_url":"https://api.github.com/users/rvanbaalen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvanbaalen/subscriptions","organizations_url":"https://api.github.com/users/rvanbaalen/orgs","repos_url":"https://api.github.com/users/rvanbaalen/repos","events_url":"https://api.github.com/users/rvanbaalen/events{/privacy}","received_events_url":"https://api.github.com/users/rvanbaalen/received_events","type":"User","site_admin":false},"open_issues":77,"closed_issues":48,"state":"open","created_at":"2015-03-15T21:55:14Z","updated_at":"2015-09-15T23:04:55Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-08-27T22:01:55Z","updated_at":"2015-09-16T00:08:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/4293","html_url":"https://github.com/angular-ui/bootstrap/pull/4293","diff_url":"https://github.com/angular-ui/bootstrap/pull/4293.diff","patch_url":"https://github.com/angular-ui/bootstrap/pull/4293.patch"},"body":"This change improves corner positioning to make it more internally consistent and useful.\r\n\r\nThe current implementation of corner positioning aligns elements in a way that is less useful than it could be. For instance, passing `left` as the second position argument aligns the left edge of the target element with the left edge of the host, while passing `right` aligns the *left edge* of the target with the right edge of the host. This behavior makes it difficult to trigger popovers on a right-aligned control. With this PR, passing `right` as the second position argument will cause the right edge of the target to be aligned with the right edge of the host control; and likewise for top and bottom. Here is the [plunker](http://plnkr.co/edit/6m06t94Boy10Q3LMUYV7?p=preview) with the updated functionality.\r\n\r\nThis change is potentially breaking, but I feel it's worth it in terms of improving the usability of positioned elements in ui-bootstrap."},"comment":{"url":"https://api.github.com/repos/angular-ui/bootstrap/issues/comments/140584828","html_url":"https://github.com/angular-ui/bootstrap/pull/4293#issuecomment-140584828","issue_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/4293","id":140584828,"user":{"login":"wesleycho","id":1703387,"avatar_url":"https://avatars.githubusercontent.com/u/1703387?v=3","gravatar_id":"","url":"https://api.github.com/users/wesleycho","html_url":"https://github.com/wesleycho","followers_url":"https://api.github.com/users/wesleycho/followers","following_url":"https://api.github.com/users/wesleycho/following{/other_user}","gists_url":"https://api.github.com/users/wesleycho/gists{/gist_id}","starred_url":"https://api.github.com/users/wesleycho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesleycho/subscriptions","organizations_url":"https://api.github.com/users/wesleycho/orgs","repos_url":"https://api.github.com/users/wesleycho/repos","events_url":"https://api.github.com/users/wesleycho/events{/privacy}","received_events_url":"https://api.github.com/users/wesleycho/received_events","type":"User","site_admin":false},"created_at":"2015-09-16T00:08:17Z","updated_at":"2015-09-16T00:08:17Z","body":"Thinking about this some more, can you demonstrate this in a Plunker? This may potentially cause issues if the user wants it aligned to the right but the host is not aligned to the right."}}