{"action":"created","issue":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/163","labels_url":"https://api.github.com/repos/catapult-project/catapult/issues/163/labels{/name}","comments_url":"https://api.github.com/repos/catapult-project/catapult/issues/163/comments","events_url":"https://api.github.com/repos/catapult-project/catapult/issues/163/events","html_url":"https://github.com/catapult-project/catapult/issues/163","id":98535003,"number":163,"title":"base.defineProperty does not set oldValue","user":{"login":"catapult-bot","id":13457154,"avatar_url":"https://avatars.githubusercontent.com/u/13457154?v=3","gravatar_id":"","url":"https://api.github.com/users/catapult-bot","html_url":"https://github.com/catapult-bot","followers_url":"https://api.github.com/users/catapult-bot/followers","following_url":"https://api.github.com/users/catapult-bot/following{/other_user}","gists_url":"https://api.github.com/users/catapult-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/catapult-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catapult-bot/subscriptions","organizations_url":"https://api.github.com/users/catapult-bot/orgs","repos_url":"https://api.github.com/users/catapult-bot/repos","events_url":"https://api.github.com/users/catapult-bot/events{/privacy}","received_events_url":"https://api.github.com/users/catapult-bot/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/catapult-project/catapult/labels/P2","name":"P2","color":"fbca04"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-01T12:46:27Z","updated_at":"2015-08-01T12:46:37Z","closed_at":"2015-08-01T12:46:32Z","body":"<a href=\"https://github.com/natduca\"><img src=\"https://avatars.githubusercontent.com/u/412396?v=3\" align=\"left\" width=\"96\" height=\"96\" hspace=\"10\"></img></a> **Issue by [natduca](https://github.com/natduca)**\n_Monday Sep 22, 2014 at 20:03 GMT_\n_Originally opened as https://github.com/google/trace-viewer/issues/163_\n\n----\n\n_From [johnjbar...@chromium.org](https://code.google.com/u/102793569239199088523/) on May 08, 2013 12:10:33_\n\nThis test will fail because oldValue is undefined\r\n\r\n      var ASpan = ui.define('span');\r\n      \r\n      ASpan.prototype = {\r\n        __proto__: HTMLSpanElement.prototype,\r\n        decorate: function() {\r\n          this.boolProp = false;\r\n        }\r\n      };\r\n\r\n      var propName = 'boolProp';\r\n      base.defineProperty(ASpan, propName, base.PropertyKind.BOOL_ATTR);\r\n\r\n      var aSpan = new ASpan();\r\n\r\n      var stateChanges;\r\n      aSpan.addEventListener('boolPropChange', function(event) {\r\n        stateChanges = event.oldValue + ' to ' + event.newValue;\r\n      });\r\n\r\n      aSpan.boolProp = true;\r\n      assertTrue(stateChanges === 'boolPropChange from false to true');\r\n      aSpan.boolProp = false;\r\n      assertTrue(stateChanges === 'boolPropChange from true to false');\n\n_Original issue: http://code.google.com/p/trace-viewer/issues/detail?id=157_\n"},"comment":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/comments/126911434","html_url":"https://github.com/catapult-project/catapult/issues/163#issuecomment-126911434","issue_url":"https://api.github.com/repos/catapult-project/catapult/issues/163","id":126911434,"user":{"login":"catapult-bot","id":13457154,"avatar_url":"https://avatars.githubusercontent.com/u/13457154?v=3","gravatar_id":"","url":"https://api.github.com/users/catapult-bot","html_url":"https://github.com/catapult-bot","followers_url":"https://api.github.com/users/catapult-bot/followers","following_url":"https://api.github.com/users/catapult-bot/following{/other_user}","gists_url":"https://api.github.com/users/catapult-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/catapult-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catapult-bot/subscriptions","organizations_url":"https://api.github.com/users/catapult-bot/orgs","repos_url":"https://api.github.com/users/catapult-bot/repos","events_url":"https://api.github.com/users/catapult-bot/events{/privacy}","received_events_url":"https://api.github.com/users/catapult-bot/received_events","type":"User","site_admin":false},"created_at":"2015-08-01T12:46:37Z","updated_at":"2015-08-01T12:46:37Z","body":"<a href=\"https://github.com/natduca\"><img src=\"https://avatars.githubusercontent.com/u/412396?v=3\" align=\"left\" width=\"48\" height=\"48\" hspace=\"10\"></img></a> **Comment by [natduca](https://github.com/natduca)**\n_Monday Sep 22, 2014 at 20:03 GMT_\n\n----\n\n_From [johnjbar...@chromium.org](https://code.google.com/u/102793569239199088523/) on May 08, 2013 13:55:17_\n\nFixed in https://codereview.appspot.com/9033050/\n\n**Status:** Fixed  \n\n"}}