{"action":"created","comment":{"url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/comments/35701584","id":35701584,"diff_hunk":"@@ -31,6 +31,10 @@\n #include <Zend/zend_hash.h>\n #include <Zend/zend_interfaces.h>\n \n+#if PHP_VERSION_ID >= 50400\n+# include <Zend/zend_string.h>\n+#endif","path":"src/bson.c","position":6,"original_position":6,"commit_id":"ea4836bad3f15704df981108c6f4acbe1bbcee01","original_commit_id":"ea4836bad3f15704df981108c6f4acbe1bbcee01","user":{"login":"bjori","id":72407,"avatar_url":"https://avatars.githubusercontent.com/u/72407?v=3","gravatar_id":"","url":"https://api.github.com/users/bjori","html_url":"https://github.com/bjori","followers_url":"https://api.github.com/users/bjori/followers","following_url":"https://api.github.com/users/bjori/following{/other_user}","gists_url":"https://api.github.com/users/bjori/gists{/gist_id}","starred_url":"https://api.github.com/users/bjori/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjori/subscriptions","organizations_url":"https://api.github.com/users/bjori/orgs","repos_url":"https://api.github.com/users/bjori/repos","events_url":"https://api.github.com/users/bjori/events{/privacy}","received_events_url":"https://api.github.com/users/bjori/received_events","type":"User","site_admin":false},"body":"I feel this should really be in the compat header as a #else condition for the str_efree() ?\r\nOr is that pushing it a bit far?","created_at":"2015-07-28T21:10:24Z","updated_at":"2015-07-28T21:10:24Z","html_url":"https://github.com/10gen-labs/mongo-php-driver-prototype/pull/64#discussion_r35701584","pull_request_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/64","_links":{"self":{"href":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/comments/35701584"},"html":{"href":"https://github.com/10gen-labs/mongo-php-driver-prototype/pull/64#discussion_r35701584"},"pull_request":{"href":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/64","id":40946066,"html_url":"https://github.com/10gen-labs/mongo-php-driver-prototype/pull/64","diff_url":"https://github.com/10gen-labs/mongo-php-driver-prototype/pull/64.diff","patch_url":"https://github.com/10gen-labs/mongo-php-driver-prototype/pull/64.patch","issue_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/issues/64","number":64,"state":"open","locked":false,"title":"BSON serialization spec compliance","user":{"login":"jmikola","id":244663,"avatar_url":"https://avatars.githubusercontent.com/u/244663?v=3","gravatar_id":"","url":"https://api.github.com/users/jmikola","html_url":"https://github.com/jmikola","followers_url":"https://api.github.com/users/jmikola/followers","following_url":"https://api.github.com/users/jmikola/following{/other_user}","gists_url":"https://api.github.com/users/jmikola/gists{/gist_id}","starred_url":"https://api.github.com/users/jmikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmikola/subscriptions","organizations_url":"https://api.github.com/users/jmikola/orgs","repos_url":"https://api.github.com/users/jmikola/repos","events_url":"https://api.github.com/users/jmikola/events{/privacy}","received_events_url":"https://api.github.com/users/jmikola/received_events","type":"User","site_admin":false},"body":" * https://jira.mongodb.org/browse/PHPC-336\r\n * https://jira.mongodb.org/browse/PHPC-329\r\n * https://jira.mongodb.org/browse/PHPC-331\r\n * https://jira.mongodb.org/browse/PHPC-343\r\n * https://jira.mongodb.org/browse/PHPC-344\r\n","created_at":"2015-07-27T20:34:59Z","updated_at":"2015-07-28T21:10:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"146fb43d23a6f8c633a34ad5c4ca19c1d05842dd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/64/commits","review_comments_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/64/comments","review_comment_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/comments{/number}","comments_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/issues/64/comments","statuses_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/statuses/ea4836bad3f15704df981108c6f4acbe1bbcee01","head":{"label":"jmikola:phpc-329","ref":"phpc-329","sha":"ea4836bad3f15704df981108c6f4acbe1bbcee01","user":{"login":"jmikola","id":244663,"avatar_url":"https://avatars.githubusercontent.com/u/244663?v=3","gravatar_id":"","url":"https://api.github.com/users/jmikola","html_url":"https://github.com/jmikola","followers_url":"https://api.github.com/users/jmikola/followers","following_url":"https://api.github.com/users/jmikola/following{/other_user}","gists_url":"https://api.github.com/users/jmikola/gists{/gist_id}","starred_url":"https://api.github.com/users/jmikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmikola/subscriptions","organizations_url":"https://api.github.com/users/jmikola/orgs","repos_url":"https://api.github.com/users/jmikola/repos","events_url":"https://api.github.com/users/jmikola/events{/privacy}","received_events_url":"https://api.github.com/users/jmikola/received_events","type":"User","site_admin":false},"repo":{"id":32424485,"name":"mongo-php-driver-prototype","full_name":"jmikola/mongo-php-driver-prototype","owner":{"login":"jmikola","id":244663,"avatar_url":"https://avatars.githubusercontent.com/u/244663?v=3","gravatar_id":"","url":"https://api.github.com/users/jmikola","html_url":"https://github.com/jmikola","followers_url":"https://api.github.com/users/jmikola/followers","following_url":"https://api.github.com/users/jmikola/following{/other_user}","gists_url":"https://api.github.com/users/jmikola/gists{/gist_id}","starred_url":"https://api.github.com/users/jmikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmikola/subscriptions","organizations_url":"https://api.github.com/users/jmikola/orgs","repos_url":"https://api.github.com/users/jmikola/repos","events_url":"https://api.github.com/users/jmikola/events{/privacy}","received_events_url":"https://api.github.com/users/jmikola/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmikola/mongo-php-driver-prototype","description":"PHP MongoDB - PHongo - new MongoDB driver for PHP","fork":true,"url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype","forks_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/forks","keys_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/teams","hooks_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/hooks","issue_events_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/issues/events{/number}","events_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/events","assignees_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/assignees{/user}","branches_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/branches{/branch}","tags_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/tags","blobs_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/statuses/{sha}","languages_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/languages","stargazers_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/stargazers","contributors_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/contributors","subscribers_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/subscribers","subscription_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/subscription","commits_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/contents/{+path}","compare_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/merges","archive_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/downloads","issues_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/issues{/number}","pulls_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/pulls{/number}","milestones_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/milestones{/number}","notifications_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/labels{/name}","releases_url":"https://api.github.com/repos/jmikola/mongo-php-driver-prototype/releases{/id}","created_at":"2015-03-17T22:38:23Z","updated_at":"2015-05-06T17:35:42Z","pushed_at":"2015-07-28T19:38:16Z","git_url":"git://github.com/jmikola/mongo-php-driver-prototype.git","ssh_url":"git@github.com:jmikola/mongo-php-driver-prototype.git","clone_url":"https://github.com/jmikola/mongo-php-driver-prototype.git","svn_url":"https://github.com/jmikola/mongo-php-driver-prototype","homepage":null,"size":2476,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"10gen-labs:master","ref":"master","sha":"914aabab04bedb132eec6d545699ef74e07b2bf4","user":{"login":"10gen-labs","id":2118794,"avatar_url":"https://avatars.githubusercontent.com/u/2118794?v=3","gravatar_id":"","url":"https://api.github.com/users/10gen-labs","html_url":"https://github.com/10gen-labs","followers_url":"https://api.github.com/users/10gen-labs/followers","following_url":"https://api.github.com/users/10gen-labs/following{/other_user}","gists_url":"https://api.github.com/users/10gen-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/10gen-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/10gen-labs/subscriptions","organizations_url":"https://api.github.com/users/10gen-labs/orgs","repos_url":"https://api.github.com/users/10gen-labs/repos","events_url":"https://api.github.com/users/10gen-labs/events{/privacy}","received_events_url":"https://api.github.com/users/10gen-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":19514152,"name":"mongo-php-driver-prototype","full_name":"10gen-labs/mongo-php-driver-prototype","owner":{"login":"10gen-labs","id":2118794,"avatar_url":"https://avatars.githubusercontent.com/u/2118794?v=3","gravatar_id":"","url":"https://api.github.com/users/10gen-labs","html_url":"https://github.com/10gen-labs","followers_url":"https://api.github.com/users/10gen-labs/followers","following_url":"https://api.github.com/users/10gen-labs/following{/other_user}","gists_url":"https://api.github.com/users/10gen-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/10gen-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/10gen-labs/subscriptions","organizations_url":"https://api.github.com/users/10gen-labs/orgs","repos_url":"https://api.github.com/users/10gen-labs/repos","events_url":"https://api.github.com/users/10gen-labs/events{/privacy}","received_events_url":"https://api.github.com/users/10gen-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/10gen-labs/mongo-php-driver-prototype","description":"MongoDB PHP driver (experimental)","fork":false,"url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype","forks_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/forks","keys_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/teams","hooks_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/hooks","issue_events_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/issues/events{/number}","events_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/events","assignees_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/assignees{/user}","branches_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/branches{/branch}","tags_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/tags","blobs_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/git/refs{/sha}","trees_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/statuses/{sha}","languages_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/languages","stargazers_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/stargazers","contributors_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/contributors","subscribers_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/subscribers","subscription_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/subscription","commits_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/commits{/sha}","git_commits_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/git/commits{/sha}","comments_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/comments{/number}","issue_comment_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/issues/comments{/number}","contents_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/contents/{+path}","compare_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/merges","archive_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/downloads","issues_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/issues{/number}","pulls_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls{/number}","milestones_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/milestones{/number}","notifications_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/labels{/name}","releases_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/releases{/id}","created_at":"2014-05-06T23:18:32Z","updated_at":"2015-07-22T16:48:22Z","pushed_at":"2015-07-28T19:38:17Z","git_url":"git://github.com/10gen-labs/mongo-php-driver-prototype.git","ssh_url":"git@github.com:10gen-labs/mongo-php-driver-prototype.git","clone_url":"https://github.com/10gen-labs/mongo-php-driver-prototype.git","svn_url":"https://github.com/10gen-labs/mongo-php-driver-prototype","homepage":"","size":3943,"stargazers_count":28,"watchers_count":28,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":3,"forks":8,"open_issues":3,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/64"},"html":{"href":"https://github.com/10gen-labs/mongo-php-driver-prototype/pull/64"},"issue":{"href":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/issues/64"},"comments":{"href":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/statuses/ea4836bad3f15704df981108c6f4acbe1bbcee01"}}}}