{"action":"created","comment":{"url":"https://api.github.com/repos/openucx/ucx/pulls/comments/43115545","id":43115545,"diff_hunk":"@@ -405,9 +429,11 @@ uct_ud_mlx5_ep_create_connected(uct_iface_h iface_h,\n     ucs_trace_data(\"TX: CREQ (qp=%x lid=%d)\", if_addr->qp_num, if_addr->lid);\n     uct_ud_mlx5_ep_tx_skb(iface, ep, skb);\n     uct_ud_iface_complete_tx_skb(&iface->super, &ep->super, skb);\n+    uct_ud_leave(&iface->super);\n     return UCS_OK;\n \n err:\n+    uct_ud_leave(&iface->super);","path":"src/uct/ib/ud/accel/ud_mlx5.c","position":121,"original_position":121,"commit_id":"c1745fa8b8cea8ddd5358f35302c95ee520fc505","original_commit_id":"c1745fa8b8cea8ddd5358f35302c95ee520fc505","user":{"login":"yosefe","id":2255631,"avatar_url":"https://avatars.githubusercontent.com/u/2255631?v=3","gravatar_id":"","url":"https://api.github.com/users/yosefe","html_url":"https://github.com/yosefe","followers_url":"https://api.github.com/users/yosefe/followers","following_url":"https://api.github.com/users/yosefe/following{/other_user}","gists_url":"https://api.github.com/users/yosefe/gists{/gist_id}","starred_url":"https://api.github.com/users/yosefe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yosefe/subscriptions","organizations_url":"https://api.github.com/users/yosefe/orgs","repos_url":"https://api.github.com/users/yosefe/repos","events_url":"https://api.github.com/users/yosefe/events{/privacy}","received_events_url":"https://api.github.com/users/yosefe/received_events","type":"User","site_admin":false},"body":"looking at order of enter/create, do we need to reverse order of leave/destroy here? ","created_at":"2015-10-27T12:39:56Z","updated_at":"2015-10-27T12:39:56Z","html_url":"https://github.com/openucx/ucx/pull/464#discussion_r43115545","pull_request_url":"https://api.github.com/repos/openucx/ucx/pulls/464","_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments/43115545"},"html":{"href":"https://github.com/openucx/ucx/pull/464#discussion_r43115545"},"pull_request":{"href":"https://api.github.com/repos/openucx/ucx/pulls/464"}}},"pull_request":{"url":"https://api.github.com/repos/openucx/ucx/pulls/464","id":48758606,"html_url":"https://github.com/openucx/ucx/pull/464","diff_url":"https://github.com/openucx/ucx/pull/464.diff","patch_url":"https://github.com/openucx/ucx/pull/464.patch","issue_url":"https://api.github.com/repos/openucx/ucx/issues/464","number":464,"state":"open","locked":false,"title":"ud async timer, retransmisions and pending queue","user":{"login":"alex-mikheev","id":8735389,"avatar_url":"https://avatars.githubusercontent.com/u/8735389?v=3","gravatar_id":"","url":"https://api.github.com/users/alex-mikheev","html_url":"https://github.com/alex-mikheev","followers_url":"https://api.github.com/users/alex-mikheev/followers","following_url":"https://api.github.com/users/alex-mikheev/following{/other_user}","gists_url":"https://api.github.com/users/alex-mikheev/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-mikheev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-mikheev/subscriptions","organizations_url":"https://api.github.com/users/alex-mikheev/orgs","repos_url":"https://api.github.com/users/alex-mikheev/repos","events_url":"https://api.github.com/users/alex-mikheev/events{/privacy}","received_events_url":"https://api.github.com/users/alex-mikheev/received_events","type":"User","site_admin":false},"body":"@yosefe please take a look","created_at":"2015-10-26T15:59:04Z","updated_at":"2015-10-27T12:39:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c33d347af48d1b556bdc60fb444f27c63e13b693","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openucx/ucx/pulls/464/commits","review_comments_url":"https://api.github.com/repos/openucx/ucx/pulls/464/comments","review_comment_url":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openucx/ucx/issues/464/comments","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/c1745fa8b8cea8ddd5358f35302c95ee520fc505","head":{"label":"alex-mikheev:topic/ud_window","ref":"topic/ud_window","sha":"c1745fa8b8cea8ddd5358f35302c95ee520fc505","user":{"login":"alex-mikheev","id":8735389,"avatar_url":"https://avatars.githubusercontent.com/u/8735389?v=3","gravatar_id":"","url":"https://api.github.com/users/alex-mikheev","html_url":"https://github.com/alex-mikheev","followers_url":"https://api.github.com/users/alex-mikheev/followers","following_url":"https://api.github.com/users/alex-mikheev/following{/other_user}","gists_url":"https://api.github.com/users/alex-mikheev/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-mikheev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-mikheev/subscriptions","organizations_url":"https://api.github.com/users/alex-mikheev/orgs","repos_url":"https://api.github.com/users/alex-mikheev/repos","events_url":"https://api.github.com/users/alex-mikheev/events{/privacy}","received_events_url":"https://api.github.com/users/alex-mikheev/received_events","type":"User","site_admin":false},"repo":{"id":27329497,"name":"ucx","full_name":"alex-mikheev/ucx","owner":{"login":"alex-mikheev","id":8735389,"avatar_url":"https://avatars.githubusercontent.com/u/8735389?v=3","gravatar_id":"","url":"https://api.github.com/users/alex-mikheev","html_url":"https://github.com/alex-mikheev","followers_url":"https://api.github.com/users/alex-mikheev/followers","following_url":"https://api.github.com/users/alex-mikheev/following{/other_user}","gists_url":"https://api.github.com/users/alex-mikheev/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-mikheev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-mikheev/subscriptions","organizations_url":"https://api.github.com/users/alex-mikheev/orgs","repos_url":"https://api.github.com/users/alex-mikheev/repos","events_url":"https://api.github.com/users/alex-mikheev/events{/privacy}","received_events_url":"https://api.github.com/users/alex-mikheev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alex-mikheev/ucx","description":"The UCX","fork":true,"url":"https://api.github.com/repos/alex-mikheev/ucx","forks_url":"https://api.github.com/repos/alex-mikheev/ucx/forks","keys_url":"https://api.github.com/repos/alex-mikheev/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alex-mikheev/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alex-mikheev/ucx/teams","hooks_url":"https://api.github.com/repos/alex-mikheev/ucx/hooks","issue_events_url":"https://api.github.com/repos/alex-mikheev/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/alex-mikheev/ucx/events","assignees_url":"https://api.github.com/repos/alex-mikheev/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/alex-mikheev/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/alex-mikheev/ucx/tags","blobs_url":"https://api.github.com/repos/alex-mikheev/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alex-mikheev/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alex-mikheev/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/alex-mikheev/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alex-mikheev/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/alex-mikheev/ucx/languages","stargazers_url":"https://api.github.com/repos/alex-mikheev/ucx/stargazers","contributors_url":"https://api.github.com/repos/alex-mikheev/ucx/contributors","subscribers_url":"https://api.github.com/repos/alex-mikheev/ucx/subscribers","subscription_url":"https://api.github.com/repos/alex-mikheev/ucx/subscription","commits_url":"https://api.github.com/repos/alex-mikheev/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/alex-mikheev/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/alex-mikheev/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/alex-mikheev/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/alex-mikheev/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/alex-mikheev/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alex-mikheev/ucx/merges","archive_url":"https://api.github.com/repos/alex-mikheev/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alex-mikheev/ucx/downloads","issues_url":"https://api.github.com/repos/alex-mikheev/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/alex-mikheev/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/alex-mikheev/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/alex-mikheev/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alex-mikheev/ucx/labels{/name}","releases_url":"https://api.github.com/repos/alex-mikheev/ucx/releases{/id}","created_at":"2014-11-30T08:32:27Z","updated_at":"2015-07-14T14:20:06Z","pushed_at":"2015-10-27T10:26:37Z","git_url":"git://github.com/alex-mikheev/ucx.git","ssh_url":"git@github.com:alex-mikheev/ucx.git","clone_url":"https://github.com/alex-mikheev/ucx.git","svn_url":"https://github.com/alex-mikheev/ucx","homepage":"","size":2546,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openucx:master","ref":"master","sha":"67949c43b7d7b7eee26d4b968bdb14dfb48708f7","user":{"login":"openucx","id":13118737,"avatar_url":"https://avatars.githubusercontent.com/u/13118737?v=3","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"repo":{"id":25379390,"name":"ucx","full_name":"openucx/ucx","owner":{"login":"openucx","id":13118737,"avatar_url":"https://avatars.githubusercontent.com/u/13118737?v=3","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openucx/ucx","description":"Unified Communication X  (https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":false,"url":"https://api.github.com/repos/openucx/ucx","forks_url":"https://api.github.com/repos/openucx/ucx/forks","keys_url":"https://api.github.com/repos/openucx/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openucx/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openucx/ucx/teams","hooks_url":"https://api.github.com/repos/openucx/ucx/hooks","issue_events_url":"https://api.github.com/repos/openucx/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/openucx/ucx/events","assignees_url":"https://api.github.com/repos/openucx/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/openucx/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/openucx/ucx/tags","blobs_url":"https://api.github.com/repos/openucx/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openucx/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openucx/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/openucx/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/openucx/ucx/languages","stargazers_url":"https://api.github.com/repos/openucx/ucx/stargazers","contributors_url":"https://api.github.com/repos/openucx/ucx/contributors","subscribers_url":"https://api.github.com/repos/openucx/ucx/subscribers","subscription_url":"https://api.github.com/repos/openucx/ucx/subscription","commits_url":"https://api.github.com/repos/openucx/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/openucx/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/openucx/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/openucx/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/openucx/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/openucx/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openucx/ucx/merges","archive_url":"https://api.github.com/repos/openucx/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openucx/ucx/downloads","issues_url":"https://api.github.com/repos/openucx/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/openucx/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/openucx/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/openucx/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openucx/ucx/labels{/name}","releases_url":"https://api.github.com/repos/openucx/ucx/releases{/id}","created_at":"2014-10-17T22:17:24Z","updated_at":"2015-10-22T14:51:27Z","pushed_at":"2015-10-27T10:50:38Z","git_url":"git://github.com/openucx/ucx.git","ssh_url":"git@github.com:openucx/ucx.git","clone_url":"https://github.com/openucx/ucx.git","svn_url":"https://github.com/openucx/ucx","homepage":" http://www.openucx.org","size":7462,"stargazers_count":20,"watchers_count":20,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":43,"forks":13,"open_issues":43,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/464"},"html":{"href":"https://github.com/openucx/ucx/pull/464"},"issue":{"href":"https://api.github.com/repos/openucx/ucx/issues/464"},"comments":{"href":"https://api.github.com/repos/openucx/ucx/issues/464/comments"},"review_comments":{"href":"https://api.github.com/repos/openucx/ucx/pulls/464/comments"},"review_comment":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openucx/ucx/pulls/464/commits"},"statuses":{"href":"https://api.github.com/repos/openucx/ucx/statuses/c1745fa8b8cea8ddd5358f35302c95ee520fc505"}}}}