{"action":"created","comment":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments/44424492","id":44424492,"diff_hunk":"@@ -97,7 +97,7 @@\n         }, false);\n \n         // send request\n-        Galaxy.emit.debug('uploadbox::uploadpost()', 'Posting following data.', cnf);\n+        Galaxy.logger.emit('debug', 'uploadbox::uploadpost()', [ 'Posting following data.', cnf ]);","path":"client/galaxy/scripts/utils/uploadbox.js","position":5,"original_position":5,"commit_id":"c28728a7fcbed1b059621cee7dfe38065061579e","original_commit_id":"c28728a7fcbed1b059621cee7dfe38065061579e","user":{"login":"carlfeberhard","id":5102959,"avatar_url":"https://avatars.githubusercontent.com/u/5102959?v=3","gravatar_id":"","url":"https://api.github.com/users/carlfeberhard","html_url":"https://github.com/carlfeberhard","followers_url":"https://api.github.com/users/carlfeberhard/followers","following_url":"https://api.github.com/users/carlfeberhard/following{/other_user}","gists_url":"https://api.github.com/users/carlfeberhard/gists{/gist_id}","starred_url":"https://api.github.com/users/carlfeberhard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlfeberhard/subscriptions","organizations_url":"https://api.github.com/users/carlfeberhard/orgs","repos_url":"https://api.github.com/users/carlfeberhard/repos","events_url":"https://api.github.com/users/carlfeberhard/events{/privacy}","received_events_url":"https://api.github.com/users/carlfeberhard/received_events","type":"User","site_admin":false},"body":"Well - the whole point was that people wouldn't have to add a namespace on **every** call. I'd rather not have two ways to call the same method because that creates sprawl and becomes hard to change (like perl), but I think you and I use namespaces differently.\r\n\r\nIf you prefer this way and don't want to modularize uploadbox: ok - I don't particularly want to fight about it.","created_at":"2015-11-10T16:04:27Z","updated_at":"2015-11-10T16:04:27Z","html_url":"https://github.com/galaxyproject/galaxy/pull/1042#discussion_r44424492","pull_request_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/1042","_links":{"self":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments/44424492"},"html":{"href":"https://github.com/galaxyproject/galaxy/pull/1042#discussion_r44424492"},"pull_request":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/1042"}}},"pull_request":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/1042","id":50141266,"html_url":"https://github.com/galaxyproject/galaxy/pull/1042","diff_url":"https://github.com/galaxyproject/galaxy/pull/1042.diff","patch_url":"https://github.com/galaxyproject/galaxy/pull/1042.patch","issue_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/1042","number":1042,"state":"open","locked":false,"title":"Client logging: move alternate logging methods into Util","user":{"login":"carlfeberhard","id":5102959,"avatar_url":"https://avatars.githubusercontent.com/u/5102959?v=3","gravatar_id":"","url":"https://api.github.com/users/carlfeberhard","html_url":"https://github.com/carlfeberhard","followers_url":"https://api.github.com/users/carlfeberhard/followers","following_url":"https://api.github.com/users/carlfeberhard/following{/other_user}","gists_url":"https://api.github.com/users/carlfeberhard/gists{/gist_id}","starred_url":"https://api.github.com/users/carlfeberhard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlfeberhard/subscriptions","organizations_url":"https://api.github.com/users/carlfeberhard/orgs","repos_url":"https://api.github.com/users/carlfeberhard/repos","events_url":"https://api.github.com/users/carlfeberhard/events{/privacy}","received_events_url":"https://api.github.com/users/carlfeberhard/received_events","type":"User","site_admin":false},"body":"(Copied from https://github.com/guerler/galaxy/pull/6 - I should have mentioned my PR in the comments on his PR)\r\n\r\n@guerler \r\nI moved the emit object you created in the Galaxy object into your Utils module. This:\r\n* let's you do your own thing as far as namespaces goes without having to use the mixin or addLogging\r\n* removes the second (redundant) emit interface from the Galaxy namespace\r\n\r\nDoes that seem like an OK compromise?","created_at":"2015-11-09T16:10:46Z","updated_at":"2015-11-10T16:04:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afcb803196f50c271d9ff158fe7e8b0d93dc275c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/1042/commits","review_comments_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/1042/comments","review_comment_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/1042/comments","statuses_url":"https://api.github.com/repos/galaxyproject/galaxy/statuses/c28728a7fcbed1b059621cee7dfe38065061579e","head":{"label":"carlfeberhard:guerler-logging","ref":"guerler-logging","sha":"c28728a7fcbed1b059621cee7dfe38065061579e","user":{"login":"carlfeberhard","id":5102959,"avatar_url":"https://avatars.githubusercontent.com/u/5102959?v=3","gravatar_id":"","url":"https://api.github.com/users/carlfeberhard","html_url":"https://github.com/carlfeberhard","followers_url":"https://api.github.com/users/carlfeberhard/followers","following_url":"https://api.github.com/users/carlfeberhard/following{/other_user}","gists_url":"https://api.github.com/users/carlfeberhard/gists{/gist_id}","starred_url":"https://api.github.com/users/carlfeberhard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlfeberhard/subscriptions","organizations_url":"https://api.github.com/users/carlfeberhard/orgs","repos_url":"https://api.github.com/users/carlfeberhard/repos","events_url":"https://api.github.com/users/carlfeberhard/events{/privacy}","received_events_url":"https://api.github.com/users/carlfeberhard/received_events","type":"User","site_admin":false},"repo":{"id":31661203,"name":"galaxy","full_name":"carlfeberhard/galaxy","owner":{"login":"carlfeberhard","id":5102959,"avatar_url":"https://avatars.githubusercontent.com/u/5102959?v=3","gravatar_id":"","url":"https://api.github.com/users/carlfeberhard","html_url":"https://github.com/carlfeberhard","followers_url":"https://api.github.com/users/carlfeberhard/followers","following_url":"https://api.github.com/users/carlfeberhard/following{/other_user}","gists_url":"https://api.github.com/users/carlfeberhard/gists{/gist_id}","starred_url":"https://api.github.com/users/carlfeberhard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlfeberhard/subscriptions","organizations_url":"https://api.github.com/users/carlfeberhard/orgs","repos_url":"https://api.github.com/users/carlfeberhard/repos","events_url":"https://api.github.com/users/carlfeberhard/events{/privacy}","received_events_url":"https://api.github.com/users/carlfeberhard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carlfeberhard/galaxy","description":"Data intensive biology for everyone.","fork":true,"url":"https://api.github.com/repos/carlfeberhard/galaxy","forks_url":"https://api.github.com/repos/carlfeberhard/galaxy/forks","keys_url":"https://api.github.com/repos/carlfeberhard/galaxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carlfeberhard/galaxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carlfeberhard/galaxy/teams","hooks_url":"https://api.github.com/repos/carlfeberhard/galaxy/hooks","issue_events_url":"https://api.github.com/repos/carlfeberhard/galaxy/issues/events{/number}","events_url":"https://api.github.com/repos/carlfeberhard/galaxy/events","assignees_url":"https://api.github.com/repos/carlfeberhard/galaxy/assignees{/user}","branches_url":"https://api.github.com/repos/carlfeberhard/galaxy/branches{/branch}","tags_url":"https://api.github.com/repos/carlfeberhard/galaxy/tags","blobs_url":"https://api.github.com/repos/carlfeberhard/galaxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carlfeberhard/galaxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carlfeberhard/galaxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/carlfeberhard/galaxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carlfeberhard/galaxy/statuses/{sha}","languages_url":"https://api.github.com/repos/carlfeberhard/galaxy/languages","stargazers_url":"https://api.github.com/repos/carlfeberhard/galaxy/stargazers","contributors_url":"https://api.github.com/repos/carlfeberhard/galaxy/contributors","subscribers_url":"https://api.github.com/repos/carlfeberhard/galaxy/subscribers","subscription_url":"https://api.github.com/repos/carlfeberhard/galaxy/subscription","commits_url":"https://api.github.com/repos/carlfeberhard/galaxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/carlfeberhard/galaxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/carlfeberhard/galaxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/carlfeberhard/galaxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/carlfeberhard/galaxy/contents/{+path}","compare_url":"https://api.github.com/repos/carlfeberhard/galaxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carlfeberhard/galaxy/merges","archive_url":"https://api.github.com/repos/carlfeberhard/galaxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carlfeberhard/galaxy/downloads","issues_url":"https://api.github.com/repos/carlfeberhard/galaxy/issues{/number}","pulls_url":"https://api.github.com/repos/carlfeberhard/galaxy/pulls{/number}","milestones_url":"https://api.github.com/repos/carlfeberhard/galaxy/milestones{/number}","notifications_url":"https://api.github.com/repos/carlfeberhard/galaxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carlfeberhard/galaxy/labels{/name}","releases_url":"https://api.github.com/repos/carlfeberhard/galaxy/releases{/id}","created_at":"2015-03-04T14:33:29Z","updated_at":"2015-05-07T13:44:09Z","pushed_at":"2015-11-09T22:06:21Z","git_url":"git://github.com/carlfeberhard/galaxy.git","ssh_url":"git@github.com:carlfeberhard/galaxy.git","clone_url":"https://github.com/carlfeberhard/galaxy.git","svn_url":"https://github.com/carlfeberhard/galaxy","homepage":"http://galaxyproject.org/","size":65445,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"galaxyproject:dev","ref":"dev","sha":"daccea42bdbd545e6ed9d91bd4685036b95410a8","user":{"login":"galaxyproject","id":7937847,"avatar_url":"https://avatars.githubusercontent.com/u/7937847?v=3","gravatar_id":"","url":"https://api.github.com/users/galaxyproject","html_url":"https://github.com/galaxyproject","followers_url":"https://api.github.com/users/galaxyproject/followers","following_url":"https://api.github.com/users/galaxyproject/following{/other_user}","gists_url":"https://api.github.com/users/galaxyproject/gists{/gist_id}","starred_url":"https://api.github.com/users/galaxyproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galaxyproject/subscriptions","organizations_url":"https://api.github.com/users/galaxyproject/orgs","repos_url":"https://api.github.com/users/galaxyproject/repos","events_url":"https://api.github.com/users/galaxyproject/events{/privacy}","received_events_url":"https://api.github.com/users/galaxyproject/received_events","type":"Organization","site_admin":false},"repo":{"id":31211061,"name":"galaxy","full_name":"galaxyproject/galaxy","owner":{"login":"galaxyproject","id":7937847,"avatar_url":"https://avatars.githubusercontent.com/u/7937847?v=3","gravatar_id":"","url":"https://api.github.com/users/galaxyproject","html_url":"https://github.com/galaxyproject","followers_url":"https://api.github.com/users/galaxyproject/followers","following_url":"https://api.github.com/users/galaxyproject/following{/other_user}","gists_url":"https://api.github.com/users/galaxyproject/gists{/gist_id}","starred_url":"https://api.github.com/users/galaxyproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galaxyproject/subscriptions","organizations_url":"https://api.github.com/users/galaxyproject/orgs","repos_url":"https://api.github.com/users/galaxyproject/repos","events_url":"https://api.github.com/users/galaxyproject/events{/privacy}","received_events_url":"https://api.github.com/users/galaxyproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/galaxyproject/galaxy","description":"Data intensive biology for everyone.","fork":false,"url":"https://api.github.com/repos/galaxyproject/galaxy","forks_url":"https://api.github.com/repos/galaxyproject/galaxy/forks","keys_url":"https://api.github.com/repos/galaxyproject/galaxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/galaxyproject/galaxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/galaxyproject/galaxy/teams","hooks_url":"https://api.github.com/repos/galaxyproject/galaxy/hooks","issue_events_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/events{/number}","events_url":"https://api.github.com/repos/galaxyproject/galaxy/events","assignees_url":"https://api.github.com/repos/galaxyproject/galaxy/assignees{/user}","branches_url":"https://api.github.com/repos/galaxyproject/galaxy/branches{/branch}","tags_url":"https://api.github.com/repos/galaxyproject/galaxy/tags","blobs_url":"https://api.github.com/repos/galaxyproject/galaxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/galaxyproject/galaxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/galaxyproject/galaxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/galaxyproject/galaxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/galaxyproject/galaxy/statuses/{sha}","languages_url":"https://api.github.com/repos/galaxyproject/galaxy/languages","stargazers_url":"https://api.github.com/repos/galaxyproject/galaxy/stargazers","contributors_url":"https://api.github.com/repos/galaxyproject/galaxy/contributors","subscribers_url":"https://api.github.com/repos/galaxyproject/galaxy/subscribers","subscription_url":"https://api.github.com/repos/galaxyproject/galaxy/subscription","commits_url":"https://api.github.com/repos/galaxyproject/galaxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/galaxyproject/galaxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/galaxyproject/galaxy/contents/{+path}","compare_url":"https://api.github.com/repos/galaxyproject/galaxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/galaxyproject/galaxy/merges","archive_url":"https://api.github.com/repos/galaxyproject/galaxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/galaxyproject/galaxy/downloads","issues_url":"https://api.github.com/repos/galaxyproject/galaxy/issues{/number}","pulls_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls{/number}","milestones_url":"https://api.github.com/repos/galaxyproject/galaxy/milestones{/number}","notifications_url":"https://api.github.com/repos/galaxyproject/galaxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/galaxyproject/galaxy/labels{/name}","releases_url":"https://api.github.com/repos/galaxyproject/galaxy/releases{/id}","created_at":"2015-02-23T14:18:06Z","updated_at":"2015-11-08T09:52:45Z","pushed_at":"2015-11-10T15:42:03Z","git_url":"git://github.com/galaxyproject/galaxy.git","ssh_url":"git@github.com:galaxyproject/galaxy.git","clone_url":"https://github.com/galaxyproject/galaxy.git","svn_url":"https://github.com/galaxyproject/galaxy","homepage":"https://galaxyproject.org/","size":91388,"stargazers_count":84,"watchers_count":84,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":134,"mirror_url":null,"open_issues_count":156,"forks":134,"open_issues":156,"watchers":84,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/1042"},"html":{"href":"https://github.com/galaxyproject/galaxy/pull/1042"},"issue":{"href":"https://api.github.com/repos/galaxyproject/galaxy/issues/1042"},"comments":{"href":"https://api.github.com/repos/galaxyproject/galaxy/issues/1042/comments"},"review_comments":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/1042/comments"},"review_comment":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/1042/commits"},"statuses":{"href":"https://api.github.com/repos/galaxyproject/galaxy/statuses/c28728a7fcbed1b059621cee7dfe38065061579e"}}}}