{"action":"created","issue":{"url":"https://api.github.com/repos/ibm-js/deliteful/issues/513","labels_url":"https://api.github.com/repos/ibm-js/deliteful/issues/513/labels{/name}","comments_url":"https://api.github.com/repos/ibm-js/deliteful/issues/513/comments","events_url":"https://api.github.com/repos/ibm-js/deliteful/issues/513/events","html_url":"https://github.com/ibm-js/deliteful/pull/513","id":56560255,"number":513,"title":"Made Button a container, solves #290","user":{"login":"tkrugg","id":2982512,"avatar_url":"https://avatars.githubusercontent.com/u/2982512?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrugg","html_url":"https://github.com/tkrugg","followers_url":"https://api.github.com/users/tkrugg/followers","following_url":"https://api.github.com/users/tkrugg/following{/other_user}","gists_url":"https://api.github.com/users/tkrugg/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrugg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrugg/subscriptions","organizations_url":"https://api.github.com/users/tkrugg/orgs","repos_url":"https://api.github.com/users/tkrugg/repos","events_url":"https://api.github.com/users/tkrugg/events{/privacy}","received_events_url":"https://api.github.com/users/tkrugg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2015-02-04T17:35:01Z","updated_at":"2015-09-11T16:16:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ibm-js/deliteful/pulls/513","html_url":"https://github.com/ibm-js/deliteful/pull/513","diff_url":"https://github.com/ibm-js/deliteful/pull/513.diff","patch_url":"https://github.com/ibm-js/deliteful/pull/513.patch"},"body":"- made Button a Container\r\n- removed the part that trims innerText to fill in `label`\r\n- set containerNode before the icon and the label\r\n- I updated the samples (they were setting label using innerText) and added an example with a ProgressIndicator inside a ToggleButton.\r\n- updated doc\r\n\r\n> Quoted from doc: The only string displayed by the button is the one defined by its `label` property.\r\n\r\nI took the liberty of removing this part of the doc, i think it's no longer relevant.\r\n"},"comment":{"url":"https://api.github.com/repos/ibm-js/deliteful/issues/comments/139589397","html_url":"https://github.com/ibm-js/deliteful/pull/513#issuecomment-139589397","issue_url":"https://api.github.com/repos/ibm-js/deliteful/issues/513","id":139589397,"user":{"login":"wkeese","id":69599,"avatar_url":"https://avatars.githubusercontent.com/u/69599?v=3","gravatar_id":"","url":"https://api.github.com/users/wkeese","html_url":"https://github.com/wkeese","followers_url":"https://api.github.com/users/wkeese/followers","following_url":"https://api.github.com/users/wkeese/following{/other_user}","gists_url":"https://api.github.com/users/wkeese/gists{/gist_id}","starred_url":"https://api.github.com/users/wkeese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkeese/subscriptions","organizations_url":"https://api.github.com/users/wkeese/orgs","repos_url":"https://api.github.com/users/wkeese/repos","events_url":"https://api.github.com/users/wkeese/events{/privacy}","received_events_url":"https://api.github.com/users/wkeese/received_events","type":"User","site_admin":false},"created_at":"2015-09-11T16:16:54Z","updated_at":"2015-09-11T16:16:54Z","body":"> I guess I'll come back to my initial point which is why making label such a specific case? We have not other property fo the widget that is filled automatically by its content? \r\n\r\nActually, we have many cases like that:\r\n\r\n* Button and subclasses currently work like that (initial textContent --> `label` property)\r\n* delite/Store subclasses (initial textContent --> `source` property)\r\n* Combobox (initial child `<d-list>` node --> `list` property)\r\n\r\nRegardless, the point of #290 is not to change existing behavior, but to enhance Button to support markup like:\r\n\r\n```xml\r\n<d-button>\r\n   <d-progress-indicator></d-progress-indicator>\r\n   refreshing...\r\n</d-button>\r\n```\r\n\r\nIf there's a consensus to change the existing behavior, we could do that separately."}}