{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/855","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/855/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/855/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/855/events","html_url":"https://github.com/Microsoft/vscode/issues/855","id":119693280,"number":855,"title":"do not try to reconnect on real quit","user":{"login":"weinand","id":1898161,"avatar_url":"https://avatars.githubusercontent.com/u/1898161?v=3","gravatar_id":"","url":"https://api.github.com/users/weinand","html_url":"https://github.com/weinand","followers_url":"https://api.github.com/users/weinand/followers","following_url":"https://api.github.com/users/weinand/following{/other_user}","gists_url":"https://api.github.com/users/weinand/gists{/gist_id}","starred_url":"https://api.github.com/users/weinand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weinand/subscriptions","organizations_url":"https://api.github.com/users/weinand/orgs","repos_url":"https://api.github.com/users/weinand/repos","events_url":"https://api.github.com/users/weinand/events{/privacy}","received_events_url":"https://api.github.com/users/weinand/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Microsoft/vscode/labels/bug","name":"bug","color":"e11d21"},{"url":"https://api.github.com/repos/Microsoft/vscode/labels/debug","name":"debug","color":"c7def8"}],"state":"open","locked":false,"assignee":{"login":"isidorn","id":1926584,"avatar_url":"https://avatars.githubusercontent.com/u/1926584?v=3","gravatar_id":"","url":"https://api.github.com/users/isidorn","html_url":"https://github.com/isidorn","followers_url":"https://api.github.com/users/isidorn/followers","following_url":"https://api.github.com/users/isidorn/following{/other_user}","gists_url":"https://api.github.com/users/isidorn/gists{/gist_id}","starred_url":"https://api.github.com/users/isidorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isidorn/subscriptions","organizations_url":"https://api.github.com/users/isidorn/orgs","repos_url":"https://api.github.com/users/isidorn/repos","events_url":"https://api.github.com/users/isidorn/events{/privacy}","received_events_url":"https://api.github.com/users/isidorn/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/2","html_url":"https://github.com/Microsoft/vscode/milestones/Dec%202015","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/2/labels","id":1354260,"number":2,"title":"Dec 2015","description":"","creator":{"login":"chrisdias","id":1487073,"avatar_url":"https://avatars.githubusercontent.com/u/1487073?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisdias","html_url":"https://github.com/chrisdias","followers_url":"https://api.github.com/users/chrisdias/followers","following_url":"https://api.github.com/users/chrisdias/following{/other_user}","gists_url":"https://api.github.com/users/chrisdias/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdias/subscriptions","organizations_url":"https://api.github.com/users/chrisdias/orgs","repos_url":"https://api.github.com/users/chrisdias/repos","events_url":"https://api.github.com/users/chrisdias/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdias/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":117,"state":"open","created_at":"2015-10-13T23:36:42Z","updated_at":"2015-12-04T09:42:09Z","due_on":"2015-12-18T23:00:00Z","closed_at":null},"comments":2,"created_at":"2015-12-01T11:00:47Z","updated_at":"2015-12-04T10:05:49Z","closed_at":null,"body":"I think we should start to look into a solution to this because we are now adding workarounds for this issue when running unit tests: The issue is that when the unit test is done, I quit the PH with process.exit(). This nicely closes the window but the debugger wants to reconnect right after and fails (not with an error message, but its weird to see the debug viewlet progress spinning for 2 seconds). \r\n\r\nWe also see this when you Cmd+Q the extension host to terminate the session.\r\n\r\nI am open to ideas what to do here, somehow the PH needs to signal back how it was terminated."},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/161927688","html_url":"https://github.com/Microsoft/vscode/issues/855#issuecomment-161927688","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/855","id":161927688,"user":{"login":"egamma","id":172399,"avatar_url":"https://avatars.githubusercontent.com/u/172399?v=3","gravatar_id":"","url":"https://api.github.com/users/egamma","html_url":"https://github.com/egamma","followers_url":"https://api.github.com/users/egamma/followers","following_url":"https://api.github.com/users/egamma/following{/other_user}","gists_url":"https://api.github.com/users/egamma/gists{/gist_id}","starred_url":"https://api.github.com/users/egamma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egamma/subscriptions","organizations_url":"https://api.github.com/users/egamma/orgs","repos_url":"https://api.github.com/users/egamma/repos","events_url":"https://api.github.com/users/egamma/events{/privacy}","received_events_url":"https://api.github.com/users/egamma/received_events","type":"User","site_admin":false},"created_at":"2015-12-04T10:05:49Z","updated_at":"2015-12-04T10:05:49Z","body":"Update from @weinand \r\n\r\nWe have finished the restructuring work on ExtensionHost (EH) debugging and I've verified that it works on OS X, Windows, and Linux.\r\nIt feels snappier and the VS Code debugger no longer waits 5 seconds after the user has closed the EH window. \r\n\r\nThe only remaining issue I've seen so far is that on Windows pressing the red debug Stop button, doesn't close the EH window.\r\nSo you have to close the EH window manually.\r\nThis seems to be a timing issue and I'll investigate right after this mail (It is a Heisenbug that does not occur when trying to  debug the problem...).\r\n"}}