{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/tmpsantos/qmapboxgl/pulls/10","id":40468625,"html_url":"https://github.com/tmpsantos/qmapboxgl/pull/10","diff_url":"https://github.com/tmpsantos/qmapboxgl/pull/10.diff","patch_url":"https://github.com/tmpsantos/qmapboxgl/pull/10.patch","issue_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/issues/10","number":10,"state":"closed","locked":false,"title":"Nudge transitions if not animating","user":{"login":"brunoabinader","id":76133,"avatar_url":"https://avatars.githubusercontent.com/u/76133?v=3","gravatar_id":"","url":"https://api.github.com/users/brunoabinader","html_url":"https://github.com/brunoabinader","followers_url":"https://api.github.com/users/brunoabinader/followers","following_url":"https://api.github.com/users/brunoabinader/following{/other_user}","gists_url":"https://api.github.com/users/brunoabinader/gists{/gist_id}","starred_url":"https://api.github.com/users/brunoabinader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunoabinader/subscriptions","organizations_url":"https://api.github.com/users/brunoabinader/orgs","repos_url":"https://api.github.com/users/brunoabinader/repos","events_url":"https://api.github.com/users/brunoabinader/events{/privacy}","received_events_url":"https://api.github.com/users/brunoabinader/received_events","type":"User","site_admin":false},"body":"With the recent changes on `Map::renderSync()`, we now must call for\r\n`Map::nudgeTransitions()` in order to check if there are any pending\r\ntransitions and/or animations to be completed.\r\n\r\nHowever, if we do this while animating via client-side (i.e. using\r\n`QPropertyAnimation`), there is a perceived performance decrease due to\r\nthe fact that the view can end up being updated twice for each new\r\nlat/lon/zoom value. We check if there is any animation happening at the\r\ncurrent time point before calling `Map::nudgeTransitions()`.\r\n\r\n/cc @tmpsantos ","created_at":"2015-07-21T15:14:49Z","updated_at":"2015-07-21T15:36:45Z","closed_at":"2015-07-21T15:36:45Z","merged_at":null,"merge_commit_sha":"3c0e67d23811fd008c39a0ce8347c4a47f852328","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/pulls/10/commits","review_comments_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/pulls/10/comments","review_comment_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/issues/10/comments","statuses_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/statuses/6182ae63eaa4fea6bad9b82cf423cecc37e1cfbf","head":{"label":"brunoabinader:nudge-transitions-if-not-animating","ref":"nudge-transitions-if-not-animating","sha":"6182ae63eaa4fea6bad9b82cf423cecc37e1cfbf","user":{"login":"brunoabinader","id":76133,"avatar_url":"https://avatars.githubusercontent.com/u/76133?v=3","gravatar_id":"","url":"https://api.github.com/users/brunoabinader","html_url":"https://github.com/brunoabinader","followers_url":"https://api.github.com/users/brunoabinader/followers","following_url":"https://api.github.com/users/brunoabinader/following{/other_user}","gists_url":"https://api.github.com/users/brunoabinader/gists{/gist_id}","starred_url":"https://api.github.com/users/brunoabinader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunoabinader/subscriptions","organizations_url":"https://api.github.com/users/brunoabinader/orgs","repos_url":"https://api.github.com/users/brunoabinader/repos","events_url":"https://api.github.com/users/brunoabinader/events{/privacy}","received_events_url":"https://api.github.com/users/brunoabinader/received_events","type":"User","site_admin":false},"repo":{"id":36803441,"name":"qmapboxgl","full_name":"brunoabinader/qmapboxgl","owner":{"login":"brunoabinader","id":76133,"avatar_url":"https://avatars.githubusercontent.com/u/76133?v=3","gravatar_id":"","url":"https://api.github.com/users/brunoabinader","html_url":"https://github.com/brunoabinader","followers_url":"https://api.github.com/users/brunoabinader/followers","following_url":"https://api.github.com/users/brunoabinader/following{/other_user}","gists_url":"https://api.github.com/users/brunoabinader/gists{/gist_id}","starred_url":"https://api.github.com/users/brunoabinader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunoabinader/subscriptions","organizations_url":"https://api.github.com/users/brunoabinader/orgs","repos_url":"https://api.github.com/users/brunoabinader/repos","events_url":"https://api.github.com/users/brunoabinader/events{/privacy}","received_events_url":"https://api.github.com/users/brunoabinader/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brunoabinader/qmapboxgl","description":"Mapbox GL for Qt","fork":true,"url":"https://api.github.com/repos/brunoabinader/qmapboxgl","forks_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/forks","keys_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/teams","hooks_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/hooks","issue_events_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/issues/events{/number}","events_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/events","assignees_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/assignees{/user}","branches_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/branches{/branch}","tags_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/tags","blobs_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/git/refs{/sha}","trees_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/statuses/{sha}","languages_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/languages","stargazers_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/stargazers","contributors_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/contributors","subscribers_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/subscribers","subscription_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/subscription","commits_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/commits{/sha}","git_commits_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/git/commits{/sha}","comments_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/comments{/number}","issue_comment_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/issues/comments{/number}","contents_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/contents/{+path}","compare_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/merges","archive_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/downloads","issues_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/issues{/number}","pulls_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/pulls{/number}","milestones_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/milestones{/number}","notifications_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/labels{/name}","releases_url":"https://api.github.com/repos/brunoabinader/qmapboxgl/releases{/id}","created_at":"2015-06-03T12:54:55Z","updated_at":"2015-06-03T12:54:56Z","pushed_at":"2015-07-21T15:36:45Z","git_url":"git://github.com/brunoabinader/qmapboxgl.git","ssh_url":"git@github.com:brunoabinader/qmapboxgl.git","clone_url":"https://github.com/brunoabinader/qmapboxgl.git","svn_url":"https://github.com/brunoabinader/qmapboxgl","homepage":null,"size":121,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tmpsantos:master","ref":"master","sha":"6182ae63eaa4fea6bad9b82cf423cecc37e1cfbf","user":{"login":"tmpsantos","id":996307,"avatar_url":"https://avatars.githubusercontent.com/u/996307?v=3","gravatar_id":"","url":"https://api.github.com/users/tmpsantos","html_url":"https://github.com/tmpsantos","followers_url":"https://api.github.com/users/tmpsantos/followers","following_url":"https://api.github.com/users/tmpsantos/following{/other_user}","gists_url":"https://api.github.com/users/tmpsantos/gists{/gist_id}","starred_url":"https://api.github.com/users/tmpsantos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmpsantos/subscriptions","organizations_url":"https://api.github.com/users/tmpsantos/orgs","repos_url":"https://api.github.com/users/tmpsantos/repos","events_url":"https://api.github.com/users/tmpsantos/events{/privacy}","received_events_url":"https://api.github.com/users/tmpsantos/received_events","type":"User","site_admin":false},"repo":{"id":36620088,"name":"qmapboxgl","full_name":"tmpsantos/qmapboxgl","owner":{"login":"tmpsantos","id":996307,"avatar_url":"https://avatars.githubusercontent.com/u/996307?v=3","gravatar_id":"","url":"https://api.github.com/users/tmpsantos","html_url":"https://github.com/tmpsantos","followers_url":"https://api.github.com/users/tmpsantos/followers","following_url":"https://api.github.com/users/tmpsantos/following{/other_user}","gists_url":"https://api.github.com/users/tmpsantos/gists{/gist_id}","starred_url":"https://api.github.com/users/tmpsantos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmpsantos/subscriptions","organizations_url":"https://api.github.com/users/tmpsantos/orgs","repos_url":"https://api.github.com/users/tmpsantos/repos","events_url":"https://api.github.com/users/tmpsantos/events{/privacy}","received_events_url":"https://api.github.com/users/tmpsantos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmpsantos/qmapboxgl","description":"Mapbox GL for Qt","fork":false,"url":"https://api.github.com/repos/tmpsantos/qmapboxgl","forks_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/forks","keys_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/teams","hooks_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/hooks","issue_events_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/issues/events{/number}","events_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/events","assignees_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/assignees{/user}","branches_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/branches{/branch}","tags_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/tags","blobs_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/statuses/{sha}","languages_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/languages","stargazers_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/stargazers","contributors_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/contributors","subscribers_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/subscribers","subscription_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/subscription","commits_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/contents/{+path}","compare_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/merges","archive_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/downloads","issues_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/issues{/number}","pulls_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/pulls{/number}","milestones_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/milestones{/number}","notifications_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/labels{/name}","releases_url":"https://api.github.com/repos/tmpsantos/qmapboxgl/releases{/id}","created_at":"2015-05-31T20:11:46Z","updated_at":"2015-07-14T02:55:13Z","pushed_at":"2015-07-21T15:36:36Z","git_url":"git://github.com/tmpsantos/qmapboxgl.git","ssh_url":"git@github.com:tmpsantos/qmapboxgl.git","clone_url":"https://github.com/tmpsantos/qmapboxgl.git","svn_url":"https://github.com/tmpsantos/qmapboxgl","homepage":null,"size":199,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tmpsantos/qmapboxgl/pulls/10"},"html":{"href":"https://github.com/tmpsantos/qmapboxgl/pull/10"},"issue":{"href":"https://api.github.com/repos/tmpsantos/qmapboxgl/issues/10"},"comments":{"href":"https://api.github.com/repos/tmpsantos/qmapboxgl/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/tmpsantos/qmapboxgl/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/tmpsantos/qmapboxgl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tmpsantos/qmapboxgl/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/tmpsantos/qmapboxgl/statuses/6182ae63eaa4fea6bad9b82cf423cecc37e1cfbf"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":1,"commits":0,"additions":0,"deletions":0,"changed_files":0}}