{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-services/pageshot/pulls/comments/32476735","id":32476735,"diff_hunk":"@@ -21,9 +22,7 @@ exports.setModel = function (data) {\n \n function render() {\n   setGitRevision(model.gitRevision);\n-  let attrs = {\n-    staticLink: staticLink\n-  };\n+  let attrs = { staticLink, ready, signUp, signIn, getProfile, updateProfile };","path":"server/src/clientglue.js","position":17,"original_position":17,"commit_id":"028002723c1c9d13859091340f02fe95a16345f0","original_commit_id":"028002723c1c9d13859091340f02fe95a16345f0","user":{"login":"ianb","id":44390,"avatar_url":"https://avatars.githubusercontent.com/u/44390?v=3","gravatar_id":"","url":"https://api.github.com/users/ianb","html_url":"https://github.com/ianb","followers_url":"https://api.github.com/users/ianb/followers","following_url":"https://api.github.com/users/ianb/following{/other_user}","gists_url":"https://api.github.com/users/ianb/gists{/gist_id}","starred_url":"https://api.github.com/users/ianb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianb/subscriptions","organizations_url":"https://api.github.com/users/ianb/orgs","repos_url":"https://api.github.com/users/ianb/repos","events_url":"https://api.github.com/users/ianb/events{/privacy}","received_events_url":"https://api.github.com/users/ianb/received_events","type":"User","site_admin":false},"body":"I don't think these need to be properties?  staticLink is a special case because it is used on the server and is request-specific.  But the rest are only used on the client and can be called globally.  So frame.js can just include these functions and call them.","created_at":"2015-06-15T22:59:46Z","updated_at":"2015-06-15T22:59:46Z","html_url":"https://github.com/mozilla-services/pageshot/pull/461#discussion_r32476735","pull_request_url":"https://api.github.com/repos/mozilla-services/pageshot/pulls/461","_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/pageshot/pulls/comments/32476735"},"html":{"href":"https://github.com/mozilla-services/pageshot/pull/461#discussion_r32476735"},"pull_request":{"href":"https://api.github.com/repos/mozilla-services/pageshot/pulls/461"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-services/pageshot/pulls/461","id":36944717,"html_url":"https://github.com/mozilla-services/pageshot/pull/461","diff_url":"https://github.com/mozilla-services/pageshot/pull/461.diff","patch_url":"https://github.com/mozilla-services/pageshot/pull/461.patch","issue_url":"https://api.github.com/repos/mozilla-services/pageshot/issues/461","number":461,"state":"open","locked":false,"title":"r?fzzzy ianbicking FxA integration","user":{"login":"kitcambridge","id":243830,"avatar_url":"https://avatars.githubusercontent.com/u/243830?v=3","gravatar_id":"","url":"https://api.github.com/users/kitcambridge","html_url":"https://github.com/kitcambridge","followers_url":"https://api.github.com/users/kitcambridge/followers","following_url":"https://api.github.com/users/kitcambridge/following{/other_user}","gists_url":"https://api.github.com/users/kitcambridge/gists{/gist_id}","starred_url":"https://api.github.com/users/kitcambridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitcambridge/subscriptions","organizations_url":"https://api.github.com/users/kitcambridge/orgs","repos_url":"https://api.github.com/users/kitcambridge/repos","events_url":"https://api.github.com/users/kitcambridge/events{/privacy}","received_events_url":"https://api.github.com/users/kitcambridge/received_events","type":"User","site_admin":false},"body":"Whew, sorry this took so long! This is a first cut at adding FxA integration to PageShot. The \"sign in\" and \"create account\" buttons are wired up, and you can change your nickname. The styling could use some love. I'd love feedback on the React views, and the general approach.\r\n\r\nDev client credentials: `CLIENT_ID=209ee70cb3cdc851 CLIENT_SECRET=efde5874713abf2a8ec9d8af8488fae7c7e0a933dba08208f644fa93b5622dab` (We can check these into the repo; the FxA folks can provide us with real production credentials later).","created_at":"2015-06-04T15:15:36Z","updated_at":"2015-06-15T22:59:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5857643b3d6bdf3e5bc79f40e4ba6c0c4f110f3f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-services/pageshot/pulls/461/commits","review_comments_url":"https://api.github.com/repos/mozilla-services/pageshot/pulls/461/comments","review_comment_url":"https://api.github.com/repos/mozilla-services/pageshot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-services/pageshot/issues/461/comments","statuses_url":"https://api.github.com/repos/mozilla-services/pageshot/statuses/028002723c1c9d13859091340f02fe95a16345f0","head":{"label":"kitcambridge:feature/fxa","ref":"feature/fxa","sha":"028002723c1c9d13859091340f02fe95a16345f0","user":{"login":"kitcambridge","id":243830,"avatar_url":"https://avatars.githubusercontent.com/u/243830?v=3","gravatar_id":"","url":"https://api.github.com/users/kitcambridge","html_url":"https://github.com/kitcambridge","followers_url":"https://api.github.com/users/kitcambridge/followers","following_url":"https://api.github.com/users/kitcambridge/following{/other_user}","gists_url":"https://api.github.com/users/kitcambridge/gists{/gist_id}","starred_url":"https://api.github.com/users/kitcambridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitcambridge/subscriptions","organizations_url":"https://api.github.com/users/kitcambridge/orgs","repos_url":"https://api.github.com/users/kitcambridge/repos","events_url":"https://api.github.com/users/kitcambridge/events{/privacy}","received_events_url":"https://api.github.com/users/kitcambridge/received_events","type":"User","site_admin":false},"repo":{"id":36031464,"name":"pageshot","full_name":"kitcambridge/pageshot","owner":{"login":"kitcambridge","id":243830,"avatar_url":"https://avatars.githubusercontent.com/u/243830?v=3","gravatar_id":"","url":"https://api.github.com/users/kitcambridge","html_url":"https://github.com/kitcambridge","followers_url":"https://api.github.com/users/kitcambridge/followers","following_url":"https://api.github.com/users/kitcambridge/following{/other_user}","gists_url":"https://api.github.com/users/kitcambridge/gists{/gist_id}","starred_url":"https://api.github.com/users/kitcambridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitcambridge/subscriptions","organizations_url":"https://api.github.com/users/kitcambridge/orgs","repos_url":"https://api.github.com/users/kitcambridge/repos","events_url":"https://api.github.com/users/kitcambridge/events{/privacy}","received_events_url":"https://api.github.com/users/kitcambridge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kitcambridge/pageshot","description":"An experiment in creating better shareable versions of content","fork":true,"url":"https://api.github.com/repos/kitcambridge/pageshot","forks_url":"https://api.github.com/repos/kitcambridge/pageshot/forks","keys_url":"https://api.github.com/repos/kitcambridge/pageshot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kitcambridge/pageshot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kitcambridge/pageshot/teams","hooks_url":"https://api.github.com/repos/kitcambridge/pageshot/hooks","issue_events_url":"https://api.github.com/repos/kitcambridge/pageshot/issues/events{/number}","events_url":"https://api.github.com/repos/kitcambridge/pageshot/events","assignees_url":"https://api.github.com/repos/kitcambridge/pageshot/assignees{/user}","branches_url":"https://api.github.com/repos/kitcambridge/pageshot/branches{/branch}","tags_url":"https://api.github.com/repos/kitcambridge/pageshot/tags","blobs_url":"https://api.github.com/repos/kitcambridge/pageshot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kitcambridge/pageshot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kitcambridge/pageshot/git/refs{/sha}","trees_url":"https://api.github.com/repos/kitcambridge/pageshot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kitcambridge/pageshot/statuses/{sha}","languages_url":"https://api.github.com/repos/kitcambridge/pageshot/languages","stargazers_url":"https://api.github.com/repos/kitcambridge/pageshot/stargazers","contributors_url":"https://api.github.com/repos/kitcambridge/pageshot/contributors","subscribers_url":"https://api.github.com/repos/kitcambridge/pageshot/subscribers","subscription_url":"https://api.github.com/repos/kitcambridge/pageshot/subscription","commits_url":"https://api.github.com/repos/kitcambridge/pageshot/commits{/sha}","git_commits_url":"https://api.github.com/repos/kitcambridge/pageshot/git/commits{/sha}","comments_url":"https://api.github.com/repos/kitcambridge/pageshot/comments{/number}","issue_comment_url":"https://api.github.com/repos/kitcambridge/pageshot/issues/comments{/number}","contents_url":"https://api.github.com/repos/kitcambridge/pageshot/contents/{+path}","compare_url":"https://api.github.com/repos/kitcambridge/pageshot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kitcambridge/pageshot/merges","archive_url":"https://api.github.com/repos/kitcambridge/pageshot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kitcambridge/pageshot/downloads","issues_url":"https://api.github.com/repos/kitcambridge/pageshot/issues{/number}","pulls_url":"https://api.github.com/repos/kitcambridge/pageshot/pulls{/number}","milestones_url":"https://api.github.com/repos/kitcambridge/pageshot/milestones{/number}","notifications_url":"https://api.github.com/repos/kitcambridge/pageshot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kitcambridge/pageshot/labels{/name}","releases_url":"https://api.github.com/repos/kitcambridge/pageshot/releases{/id}","created_at":"2015-05-21T18:52:43Z","updated_at":"2015-05-21T18:52:45Z","pushed_at":"2015-06-12T16:55:05Z","git_url":"git://github.com/kitcambridge/pageshot.git","ssh_url":"git@github.com:kitcambridge/pageshot.git","clone_url":"https://github.com/kitcambridge/pageshot.git","svn_url":"https://github.com/kitcambridge/pageshot","homepage":"https://pageshot.dev.mozaws.net","size":1171,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-services:master","ref":"master","sha":"4851bd0182b96c3eeb5f0ca49a6fb11778e7b77c","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":26788257,"name":"pageshot","full_name":"mozilla-services/pageshot","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/pageshot","description":"An experiment in creating better shareable versions of content","fork":false,"url":"https://api.github.com/repos/mozilla-services/pageshot","forks_url":"https://api.github.com/repos/mozilla-services/pageshot/forks","keys_url":"https://api.github.com/repos/mozilla-services/pageshot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/pageshot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/pageshot/teams","hooks_url":"https://api.github.com/repos/mozilla-services/pageshot/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/pageshot/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/pageshot/events","assignees_url":"https://api.github.com/repos/mozilla-services/pageshot/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/pageshot/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/pageshot/tags","blobs_url":"https://api.github.com/repos/mozilla-services/pageshot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/pageshot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/pageshot/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/pageshot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/pageshot/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/pageshot/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/pageshot/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/pageshot/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/pageshot/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/pageshot/subscription","commits_url":"https://api.github.com/repos/mozilla-services/pageshot/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/pageshot/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/pageshot/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/pageshot/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/pageshot/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/pageshot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/pageshot/merges","archive_url":"https://api.github.com/repos/mozilla-services/pageshot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/pageshot/downloads","issues_url":"https://api.github.com/repos/mozilla-services/pageshot/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/pageshot/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/pageshot/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/pageshot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/pageshot/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/pageshot/releases{/id}","created_at":"2014-11-18T02:28:36Z","updated_at":"2015-05-11T18:22:14Z","pushed_at":"2015-06-15T21:57:32Z","git_url":"git://github.com/mozilla-services/pageshot.git","ssh_url":"git@github.com:mozilla-services/pageshot.git","clone_url":"https://github.com/mozilla-services/pageshot.git","svn_url":"https://github.com/mozilla-services/pageshot","homepage":"https://pageshot.dev.mozaws.net","size":2347,"stargazers_count":36,"watchers_count":36,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":150,"forks":6,"open_issues":150,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/pageshot/pulls/461"},"html":{"href":"https://github.com/mozilla-services/pageshot/pull/461"},"issue":{"href":"https://api.github.com/repos/mozilla-services/pageshot/issues/461"},"comments":{"href":"https://api.github.com/repos/mozilla-services/pageshot/issues/461/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-services/pageshot/pulls/461/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-services/pageshot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-services/pageshot/pulls/461/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-services/pageshot/statuses/028002723c1c9d13859091340f02fe95a16345f0"}}}}