{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/48086839","id":48086839,"diff_hunk":"@@ -0,0 +1,24 @@\n+apiVersion: v1\n+kind: Pod\n+metadata:\n+  name: nginx\n+spec:\n+  containers:\n+  - name: nginx\n+    image: nginx\n+    volumeMounts:\n+    - name: test\n+      mountPath: /data\n+    ports:\n+    - containerPort: 80\n+  volumes:\n+  - name: test\n+    flexVolume:\n+      driver: \"kubernetes.io/lvm\"\n+      fsType: \"ext4\"\n+      options:\n+        volumeID: \"vol1\"\n+        size: \"1000m\"\n+        volumegroup: \"kube_vg\"\n+        fsType: \"ext4\"","path":"examples/flexvolume/nginx.yaml","position":22,"original_position":23,"commit_id":"31133808b83a80ba1197816b549b65a764b2a2d0","original_commit_id":"37c9ef8d9f3b87d9206687dcaa153917644567e6","user":{"login":"nelcy","id":9920367,"avatar_url":"https://avatars.githubusercontent.com/u/9920367?v=3","gravatar_id":"","url":"https://api.github.com/users/nelcy","html_url":"https://github.com/nelcy","followers_url":"https://api.github.com/users/nelcy/followers","following_url":"https://api.github.com/users/nelcy/following{/other_user}","gists_url":"https://api.github.com/users/nelcy/gists{/gist_id}","starred_url":"https://api.github.com/users/nelcy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelcy/subscriptions","organizations_url":"https://api.github.com/users/nelcy/orgs","repos_url":"https://api.github.com/users/nelcy/repos","events_url":"https://api.github.com/users/nelcy/events{/privacy}","received_events_url":"https://api.github.com/users/nelcy/received_events","type":"User","site_admin":false},"body":"On second thought, shall we return a status in \"FlexVolumeDriverStatus\", \"mounted=true\". That way we can limit the callout to one call during setup & teardown? \r\nWith multiple calls for filesystems like CIFS/NFS, attach and detach should not do anything, which will be confusing. Let me know what you think.","created_at":"2015-12-19T01:44:10Z","updated_at":"2015-12-19T01:44:10Z","html_url":"https://github.com/kubernetes/kubernetes/pull/13840#discussion_r48086839","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13840","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/48086839"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/13840#discussion_r48086839"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13840"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13840","id":44730808,"html_url":"https://github.com/kubernetes/kubernetes/pull/13840","diff_url":"https://github.com/kubernetes/kubernetes/pull/13840.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/13840.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13840","number":13840,"state":"open","locked":false,"title":"Add support for flex volume.","user":{"login":"nelcy","id":9920367,"avatar_url":"https://avatars.githubusercontent.com/u/9920367?v=3","gravatar_id":"","url":"https://api.github.com/users/nelcy","html_url":"https://github.com/nelcy","followers_url":"https://api.github.com/users/nelcy/followers","following_url":"https://api.github.com/users/nelcy/following{/other_user}","gists_url":"https://api.github.com/users/nelcy/gists{/gist_id}","starred_url":"https://api.github.com/users/nelcy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelcy/subscriptions","organizations_url":"https://api.github.com/users/nelcy/orgs","repos_url":"https://api.github.com/users/nelcy/repos","events_url":"https://api.github.com/users/nelcy/events{/privacy}","received_events_url":"https://api.github.com/users/nelcy/received_events","type":"User","site_admin":false},"body":"This change list adds support for a new type of volume, 'flex volume'.\r\n\r\nThe goal of this change is to enable third-party providers to provide their own executable to setup and teardown volumes in Kubernetes.\r\n\r\nPlugin takes the following parameters:\r\n - Provider: Name of the plugin provider\r\n - Command: Executable to setup or teardown volume\r\n - VolumeID: ID or name of the volume\r\n - FSType: File system type\r\n - Readonly : Mount read-only\r\n - Options: Extra options to pass to the plugin. Options are passed as a json encoded map[string]string\r\n\r\nThe executable command is invoked from kubelet to setup & teardown the volumes.\r\n\r\nSetup Path:\r\nExecutable is invoked with \"setup\", \"volumeID\" and \"json encoded options\" as arguments. Setup returns the block device where the volume is setup, like /dev/mapper/vg-vol1\r\n\r\nTeardown Path:\r\nExecutable is invoked with \"teardown\" and \"block device\" as arguments.\r\n\r\nExample flex volume definition:\r\n{ \r\n    \"provider\": \"blue\",\r\n    \"command\": \"setup.sh\",\r\n    \"volumeID\": \"vol1\",\r\n    \"fsType\": \"ext4\",\r\n    \"options\": {\r\n        \"size\": \"10g\",\r\n        \"replicas\": 3,\r\n        \"qos\": \"high\"\r\n    }\r\n}","created_at":"2015-09-10T23:13:55Z","updated_at":"2015-12-19T01:44:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c093692cea65f6974888afd339aac1c6ad1b9ad","assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/16","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.2-candidate","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/16/labels","id":1278500,"number":16,"title":"v1.2-candidate","description":"Things to consider for next minor release.","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":190,"closed_issues":37,"state":"open","created_at":"2015-08-29T03:54:34Z","updated_at":"2015-12-18T23:40:43Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13840/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13840/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13840/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/31133808b83a80ba1197816b549b65a764b2a2d0","head":{"label":"nelcy:master","ref":"master","sha":"31133808b83a80ba1197816b549b65a764b2a2d0","user":{"login":"nelcy","id":9920367,"avatar_url":"https://avatars.githubusercontent.com/u/9920367?v=3","gravatar_id":"","url":"https://api.github.com/users/nelcy","html_url":"https://github.com/nelcy","followers_url":"https://api.github.com/users/nelcy/followers","following_url":"https://api.github.com/users/nelcy/following{/other_user}","gists_url":"https://api.github.com/users/nelcy/gists{/gist_id}","starred_url":"https://api.github.com/users/nelcy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelcy/subscriptions","organizations_url":"https://api.github.com/users/nelcy/orgs","repos_url":"https://api.github.com/users/nelcy/repos","events_url":"https://api.github.com/users/nelcy/events{/privacy}","received_events_url":"https://api.github.com/users/nelcy/received_events","type":"User","site_admin":false},"repo":{"id":30275239,"name":"kubernetes","full_name":"nelcy/kubernetes","owner":{"login":"nelcy","id":9920367,"avatar_url":"https://avatars.githubusercontent.com/u/9920367?v=3","gravatar_id":"","url":"https://api.github.com/users/nelcy","html_url":"https://github.com/nelcy","followers_url":"https://api.github.com/users/nelcy/followers","following_url":"https://api.github.com/users/nelcy/following{/other_user}","gists_url":"https://api.github.com/users/nelcy/gists{/gist_id}","starred_url":"https://api.github.com/users/nelcy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelcy/subscriptions","organizations_url":"https://api.github.com/users/nelcy/orgs","repos_url":"https://api.github.com/users/nelcy/repos","events_url":"https://api.github.com/users/nelcy/events{/privacy}","received_events_url":"https://api.github.com/users/nelcy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nelcy/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/nelcy/kubernetes","forks_url":"https://api.github.com/repos/nelcy/kubernetes/forks","keys_url":"https://api.github.com/repos/nelcy/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nelcy/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nelcy/kubernetes/teams","hooks_url":"https://api.github.com/repos/nelcy/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/nelcy/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/nelcy/kubernetes/events","assignees_url":"https://api.github.com/repos/nelcy/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/nelcy/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/nelcy/kubernetes/tags","blobs_url":"https://api.github.com/repos/nelcy/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nelcy/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nelcy/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/nelcy/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nelcy/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/nelcy/kubernetes/languages","stargazers_url":"https://api.github.com/repos/nelcy/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/nelcy/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/nelcy/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/nelcy/kubernetes/subscription","commits_url":"https://api.github.com/repos/nelcy/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/nelcy/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/nelcy/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/nelcy/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/nelcy/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/nelcy/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nelcy/kubernetes/merges","archive_url":"https://api.github.com/repos/nelcy/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nelcy/kubernetes/downloads","issues_url":"https://api.github.com/repos/nelcy/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/nelcy/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/nelcy/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/nelcy/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nelcy/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/nelcy/kubernetes/releases{/id}","created_at":"2015-02-04T01:44:45Z","updated_at":"2015-02-04T01:47:52Z","pushed_at":"2015-12-19T00:31:48Z","git_url":"git://github.com/nelcy/kubernetes.git","ssh_url":"git@github.com:nelcy/kubernetes.git","clone_url":"https://github.com/nelcy/kubernetes.git","svn_url":"https://github.com/nelcy/kubernetes","homepage":"http://kubernetes.io","size":138832,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"977854b8de86fba5ec7bae4c0f7adc315d08ffa5","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-12-18T22:18:36Z","pushed_at":"2015-12-19T00:52:52Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":295935,"stargazers_count":11798,"watchers_count":11798,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3241,"mirror_url":null,"open_issues_count":2587,"forks":3241,"open_issues":2587,"watchers":11798,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13840"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/13840"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/13840"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/13840/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13840/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13840/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/31133808b83a80ba1197816b549b65a764b2a2d0"}}}}