{"action":"created","comment":{"url":"https://api.github.com/repos/leongersen/noUiSlider/pulls/comments/39072037","id":39072037,"diff_hunk":"@@ -1,10 +1,15 @@\n # noUiSlider\n \n-noUiSlider is lightweight JavaScript range slider, originally developed to be a jQuery UI alternative. It features cross-browser support, a wide range of options and support for a bunch of touch devices. It has been tested on Android phones, iPhone & iPad, Windows phone and touch-screen laptops and tablets and desktops; All modern browsers and IE9+ are supported. The end result? A lean, extendible and bloat-less plugin that'll just do its job.\n+noUiSlider is lightweight JavaScript range slider, originally developed to be a jQuery UI alternative.","path":"README.md","position":4,"original_position":4,"commit_id":"ad821defa33970f89b57d9a1553ba85c58793ae2","original_commit_id":"ad821defa33970f89b57d9a1553ba85c58793ae2","user":{"login":"vvo","id":123822,"avatar_url":"https://avatars.githubusercontent.com/u/123822?v=3","gravatar_id":"","url":"https://api.github.com/users/vvo","html_url":"https://github.com/vvo","followers_url":"https://api.github.com/users/vvo/followers","following_url":"https://api.github.com/users/vvo/following{/other_user}","gists_url":"https://api.github.com/users/vvo/gists{/gist_id}","starred_url":"https://api.github.com/users/vvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvo/subscriptions","organizations_url":"https://api.github.com/users/vvo/orgs","repos_url":"https://api.github.com/users/vvo/repos","events_url":"https://api.github.com/users/vvo/events{/privacy}","received_events_url":"https://api.github.com/users/vvo/received_events","type":"User","site_admin":false},"body":"Took the opportunity to break some lines to make it more readable this cool paragraph","created_at":"2015-09-09T17:31:11Z","updated_at":"2015-09-09T17:31:11Z","html_url":"https://github.com/leongersen/noUiSlider/pull/513#discussion_r39072037","pull_request_url":"https://api.github.com/repos/leongersen/noUiSlider/pulls/513","_links":{"self":{"href":"https://api.github.com/repos/leongersen/noUiSlider/pulls/comments/39072037"},"html":{"href":"https://github.com/leongersen/noUiSlider/pull/513#discussion_r39072037"},"pull_request":{"href":"https://api.github.com/repos/leongersen/noUiSlider/pulls/513"}}},"pull_request":{"url":"https://api.github.com/repos/leongersen/noUiSlider/pulls/513","id":44578055,"html_url":"https://github.com/leongersen/noUiSlider/pull/513","diff_url":"https://github.com/leongersen/noUiSlider/pull/513.diff","patch_url":"https://github.com/leongersen/noUiSlider/pull/513.patch","issue_url":"https://api.github.com/repos/leongersen/noUiSlider/issues/513","number":513,"state":"open","locked":false,"title":"feat: IE8 compatibility (with a shim)","user":{"login":"vvo","id":123822,"avatar_url":"https://avatars.githubusercontent.com/u/123822?v=3","gravatar_id":"","url":"https://api.github.com/users/vvo","html_url":"https://github.com/vvo","followers_url":"https://api.github.com/users/vvo/followers","following_url":"https://api.github.com/users/vvo/following{/other_user}","gists_url":"https://api.github.com/users/vvo/gists{/gist_id}","starred_url":"https://api.github.com/users/vvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvo/subscriptions","organizations_url":"https://api.github.com/users/vvo/orgs","repos_url":"https://api.github.com/users/vvo/repos","events_url":"https://api.github.com/users/vvo/events{/privacy}","received_events_url":"https://api.github.com/users/vvo/received_events","type":"User","site_admin":false},"body":"This pull request adds IE8 support (still requires a polyfill on the user side).\r\n\r\nSome of your code was already handling some IE8 things (like classList)\r\n\r\nI know you are maybe against this PR (because you removed IE8 support) but it really does not add a\r\nlot of code and I believe some good people will want IE8\r\ncompatibility until it is really deprecated (and we do at https://www.algolia.com/).\r\n\r\nI prefer to try to get this merged rather than do our own fork (at\r\nhttps://github.com/algolia).\r\n\r\nPlease let me know what you think!\r\n\r\nMost of the code was about:\r\n- prefer querySelector instead of getElementsByClassName\r\n- handle mouse event positions for IE8\r\n- warn the users on how to get the full IE8 support\r\n- making the tests pass on IE8 (pass!)\r\n\r\nSee the [readme](https://github.com/leongersen/noUiSlider/blob/ad821defa33970f89b57d9a1553ba85c58793ae2/README.md#browser-support) for notes on how to support IE8.\r\n\r\nAlso added:\r\n- easy `npm run build` command\r\n- easy `npm run dev` command\r\n\r\n## npm run dev\r\n\r\nI struggled a little bit in contributing to the library (good code, no hints on how to run tests). That's no big deal and I am eager to contribute!\r\n\r\nSo I added some stack to easily provide people an `npm run dev` task\r\nthat will:\r\n\r\n- watch src/* and rebuild\r\n- serve tests/slider.html and automatically reload if: a test changes,\r\na build file change\r\n\r\nI am sure you will love it, give it a try!\r\n\r\nI also added:\r\n- blanket as a dependency\r\n- simulant to simulate click events (less code, IE8 compatible)\r\n\r\nThanks for your work and time :)","created_at":"2015-09-09T17:29:40Z","updated_at":"2015-09-09T17:31:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc2c99075c6eb7902232b99f2adeaeabbf72cabf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/leongersen/noUiSlider/pulls/513/commits","review_comments_url":"https://api.github.com/repos/leongersen/noUiSlider/pulls/513/comments","review_comment_url":"https://api.github.com/repos/leongersen/noUiSlider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/leongersen/noUiSlider/issues/513/comments","statuses_url":"https://api.github.com/repos/leongersen/noUiSlider/statuses/ad821defa33970f89b57d9a1553ba85c58793ae2","head":{"label":"algolia:feat/IE8-compatibility","ref":"feat/IE8-compatibility","sha":"ad821defa33970f89b57d9a1553ba85c58793ae2","user":{"login":"algolia","id":2034458,"avatar_url":"https://avatars.githubusercontent.com/u/2034458?v=3","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"repo":{"id":42193125,"name":"noUiSlider","full_name":"algolia/noUiSlider","owner":{"login":"algolia","id":2034458,"avatar_url":"https://avatars.githubusercontent.com/u/2034458?v=3","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/algolia/noUiSlider","description":"noUiSlider is a lightweight JavaScript range slider library. It offers a wide selection of options and settings, and is compatible with a ton of (touch) devices, including those running iOS, Android, Windows 8 and Windows Phone 8.","fork":true,"url":"https://api.github.com/repos/algolia/noUiSlider","forks_url":"https://api.github.com/repos/algolia/noUiSlider/forks","keys_url":"https://api.github.com/repos/algolia/noUiSlider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/algolia/noUiSlider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/algolia/noUiSlider/teams","hooks_url":"https://api.github.com/repos/algolia/noUiSlider/hooks","issue_events_url":"https://api.github.com/repos/algolia/noUiSlider/issues/events{/number}","events_url":"https://api.github.com/repos/algolia/noUiSlider/events","assignees_url":"https://api.github.com/repos/algolia/noUiSlider/assignees{/user}","branches_url":"https://api.github.com/repos/algolia/noUiSlider/branches{/branch}","tags_url":"https://api.github.com/repos/algolia/noUiSlider/tags","blobs_url":"https://api.github.com/repos/algolia/noUiSlider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/algolia/noUiSlider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/algolia/noUiSlider/git/refs{/sha}","trees_url":"https://api.github.com/repos/algolia/noUiSlider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/algolia/noUiSlider/statuses/{sha}","languages_url":"https://api.github.com/repos/algolia/noUiSlider/languages","stargazers_url":"https://api.github.com/repos/algolia/noUiSlider/stargazers","contributors_url":"https://api.github.com/repos/algolia/noUiSlider/contributors","subscribers_url":"https://api.github.com/repos/algolia/noUiSlider/subscribers","subscription_url":"https://api.github.com/repos/algolia/noUiSlider/subscription","commits_url":"https://api.github.com/repos/algolia/noUiSlider/commits{/sha}","git_commits_url":"https://api.github.com/repos/algolia/noUiSlider/git/commits{/sha}","comments_url":"https://api.github.com/repos/algolia/noUiSlider/comments{/number}","issue_comment_url":"https://api.github.com/repos/algolia/noUiSlider/issues/comments{/number}","contents_url":"https://api.github.com/repos/algolia/noUiSlider/contents/{+path}","compare_url":"https://api.github.com/repos/algolia/noUiSlider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/algolia/noUiSlider/merges","archive_url":"https://api.github.com/repos/algolia/noUiSlider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/algolia/noUiSlider/downloads","issues_url":"https://api.github.com/repos/algolia/noUiSlider/issues{/number}","pulls_url":"https://api.github.com/repos/algolia/noUiSlider/pulls{/number}","milestones_url":"https://api.github.com/repos/algolia/noUiSlider/milestones{/number}","notifications_url":"https://api.github.com/repos/algolia/noUiSlider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/algolia/noUiSlider/labels{/name}","releases_url":"https://api.github.com/repos/algolia/noUiSlider/releases{/id}","created_at":"2015-09-09T17:17:53Z","updated_at":"2015-09-09T17:17:53Z","pushed_at":"2015-09-09T17:24:40Z","git_url":"git://github.com/algolia/noUiSlider.git","ssh_url":"git@github.com:algolia/noUiSlider.git","clone_url":"https://github.com/algolia/noUiSlider.git","svn_url":"https://github.com/algolia/noUiSlider","homepage":"http://refreshless.com/nouislider/","size":2505,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"leongersen:master","ref":"master","sha":"a4920afadb0d7aaac7db6f84a4bb22cca6f0e228","user":{"login":"leongersen","id":1206361,"avatar_url":"https://avatars.githubusercontent.com/u/1206361?v=3","gravatar_id":"","url":"https://api.github.com/users/leongersen","html_url":"https://github.com/leongersen","followers_url":"https://api.github.com/users/leongersen/followers","following_url":"https://api.github.com/users/leongersen/following{/other_user}","gists_url":"https://api.github.com/users/leongersen/gists{/gist_id}","starred_url":"https://api.github.com/users/leongersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leongersen/subscriptions","organizations_url":"https://api.github.com/users/leongersen/orgs","repos_url":"https://api.github.com/users/leongersen/repos","events_url":"https://api.github.com/users/leongersen/events{/privacy}","received_events_url":"https://api.github.com/users/leongersen/received_events","type":"User","site_admin":false},"repo":{"id":2808651,"name":"noUiSlider","full_name":"leongersen/noUiSlider","owner":{"login":"leongersen","id":1206361,"avatar_url":"https://avatars.githubusercontent.com/u/1206361?v=3","gravatar_id":"","url":"https://api.github.com/users/leongersen","html_url":"https://github.com/leongersen","followers_url":"https://api.github.com/users/leongersen/followers","following_url":"https://api.github.com/users/leongersen/following{/other_user}","gists_url":"https://api.github.com/users/leongersen/gists{/gist_id}","starred_url":"https://api.github.com/users/leongersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leongersen/subscriptions","organizations_url":"https://api.github.com/users/leongersen/orgs","repos_url":"https://api.github.com/users/leongersen/repos","events_url":"https://api.github.com/users/leongersen/events{/privacy}","received_events_url":"https://api.github.com/users/leongersen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leongersen/noUiSlider","description":"noUiSlider is a lightweight JavaScript range slider library. It offers a wide selection of options and settings, and is compatible with a ton of (touch) devices, including those running iOS, Android, Windows 8 and Windows Phone 8.","fork":false,"url":"https://api.github.com/repos/leongersen/noUiSlider","forks_url":"https://api.github.com/repos/leongersen/noUiSlider/forks","keys_url":"https://api.github.com/repos/leongersen/noUiSlider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leongersen/noUiSlider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leongersen/noUiSlider/teams","hooks_url":"https://api.github.com/repos/leongersen/noUiSlider/hooks","issue_events_url":"https://api.github.com/repos/leongersen/noUiSlider/issues/events{/number}","events_url":"https://api.github.com/repos/leongersen/noUiSlider/events","assignees_url":"https://api.github.com/repos/leongersen/noUiSlider/assignees{/user}","branches_url":"https://api.github.com/repos/leongersen/noUiSlider/branches{/branch}","tags_url":"https://api.github.com/repos/leongersen/noUiSlider/tags","blobs_url":"https://api.github.com/repos/leongersen/noUiSlider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leongersen/noUiSlider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leongersen/noUiSlider/git/refs{/sha}","trees_url":"https://api.github.com/repos/leongersen/noUiSlider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leongersen/noUiSlider/statuses/{sha}","languages_url":"https://api.github.com/repos/leongersen/noUiSlider/languages","stargazers_url":"https://api.github.com/repos/leongersen/noUiSlider/stargazers","contributors_url":"https://api.github.com/repos/leongersen/noUiSlider/contributors","subscribers_url":"https://api.github.com/repos/leongersen/noUiSlider/subscribers","subscription_url":"https://api.github.com/repos/leongersen/noUiSlider/subscription","commits_url":"https://api.github.com/repos/leongersen/noUiSlider/commits{/sha}","git_commits_url":"https://api.github.com/repos/leongersen/noUiSlider/git/commits{/sha}","comments_url":"https://api.github.com/repos/leongersen/noUiSlider/comments{/number}","issue_comment_url":"https://api.github.com/repos/leongersen/noUiSlider/issues/comments{/number}","contents_url":"https://api.github.com/repos/leongersen/noUiSlider/contents/{+path}","compare_url":"https://api.github.com/repos/leongersen/noUiSlider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leongersen/noUiSlider/merges","archive_url":"https://api.github.com/repos/leongersen/noUiSlider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leongersen/noUiSlider/downloads","issues_url":"https://api.github.com/repos/leongersen/noUiSlider/issues{/number}","pulls_url":"https://api.github.com/repos/leongersen/noUiSlider/pulls{/number}","milestones_url":"https://api.github.com/repos/leongersen/noUiSlider/milestones{/number}","notifications_url":"https://api.github.com/repos/leongersen/noUiSlider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leongersen/noUiSlider/labels{/name}","releases_url":"https://api.github.com/repos/leongersen/noUiSlider/releases{/id}","created_at":"2011-11-19T12:38:41Z","updated_at":"2015-09-09T16:31:24Z","pushed_at":"2015-09-09T17:29:40Z","git_url":"git://github.com/leongersen/noUiSlider.git","ssh_url":"git@github.com:leongersen/noUiSlider.git","clone_url":"https://github.com/leongersen/noUiSlider.git","svn_url":"https://github.com/leongersen/noUiSlider","homepage":"http://refreshless.com/nouislider/","size":2505,"stargazers_count":1515,"watchers_count":1515,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":255,"mirror_url":null,"open_issues_count":49,"forks":255,"open_issues":49,"watchers":1515,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/leongersen/noUiSlider/pulls/513"},"html":{"href":"https://github.com/leongersen/noUiSlider/pull/513"},"issue":{"href":"https://api.github.com/repos/leongersen/noUiSlider/issues/513"},"comments":{"href":"https://api.github.com/repos/leongersen/noUiSlider/issues/513/comments"},"review_comments":{"href":"https://api.github.com/repos/leongersen/noUiSlider/pulls/513/comments"},"review_comment":{"href":"https://api.github.com/repos/leongersen/noUiSlider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/leongersen/noUiSlider/pulls/513/commits"},"statuses":{"href":"https://api.github.com/repos/leongersen/noUiSlider/statuses/ad821defa33970f89b57d9a1553ba85c58793ae2"}}}}