{"comment":{"url":"https://api.github.com/repos/karun012/arion/comments/10658275","html_url":"https://github.com/karun012/arion/commit/4e39788ddd44227ca116650095f65e9f9912b8c2#commitcomment-10658275","id":10658275,"user":{"login":"mwotton","id":68482,"avatar_url":"https://avatars.githubusercontent.com/u/68482?v=3","gravatar_id":"","url":"https://api.github.com/users/mwotton","html_url":"https://github.com/mwotton","followers_url":"https://api.github.com/users/mwotton/followers","following_url":"https://api.github.com/users/mwotton/following{/other_user}","gists_url":"https://api.github.com/users/mwotton/gists{/gist_id}","starred_url":"https://api.github.com/users/mwotton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwotton/subscriptions","organizations_url":"https://api.github.com/users/mwotton/orgs","repos_url":"https://api.github.com/users/mwotton/repos","events_url":"https://api.github.com/users/mwotton/events{/privacy}","received_events_url":"https://api.github.com/users/mwotton/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"4e39788ddd44227ca116650095f65e9f9912b8c2","created_at":"2015-04-10T01:45:42Z","updated_at":"2015-04-10T01:45:42Z","body":"i think checking that sources aren't broken is an excellent use case for\narion - arguably, when a file changes and there are no tests for it, you\nshould at least check that it is compilable (while still complaining about\nno tests).\n\nyou should try as far as possible to be honest with Haskell. If you can't\nalways get an X from a Y, writing getX :: Y -> X is just asking for trouble\n- the point is to bubble the possibility of failure up with Maybe or Either\nso your client code can take intelligent action. getX :: Y -> Maybe X is\nmuch better.\n\nOn Fri, Apr 10, 2015 at 8:34 AM Karun <notifications@github.com> wrote:\n\n> Hmmm. That was just a placeholder. I could not decide what to do with\n> broken sources.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/karun012/arion/commit/4e39788ddd44227ca116650095f65e9f9912b8c2#commitcomment-10658200>\n> .\n>\n"}}