{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/25309731","id":25309731,"diff_hunk":"@@ -2428,7 +2428,7 @@ HeightfieldNode* HeightfieldNode::setMaterial(const glm::vec3& translation, cons\n                             }\n                         }\n                     }\n-                    bool nextAlphaY = stackDest->getEntryAlpha(y + 1, voxelHeight);\n+                    int nextAlphaY = stackDest->getEntryAlpha(y + 1, voxelHeight);","path":"libraries/metavoxels/src/Spanner.cpp","position":23,"original_position":23,"commit_id":"ab590440be3f3fa70e99a762579b2d43cc6da19e","original_commit_id":"ab590440be3f3fa70e99a762579b2d43cc6da19e","user":{"login":"AndrewMeadows","id":2186405,"avatar_url":"https://avatars.githubusercontent.com/u/2186405?v=3","gravatar_id":"","url":"https://api.github.com/users/AndrewMeadows","html_url":"https://github.com/AndrewMeadows","followers_url":"https://api.github.com/users/AndrewMeadows/followers","following_url":"https://api.github.com/users/AndrewMeadows/following{/other_user}","gists_url":"https://api.github.com/users/AndrewMeadows/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewMeadows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewMeadows/subscriptions","organizations_url":"https://api.github.com/users/AndrewMeadows/orgs","repos_url":"https://api.github.com/users/AndrewMeadows/repos","events_url":"https://api.github.com/users/AndrewMeadows/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewMeadows/received_events","type":"User","site_admin":false},"body":"Yes, I looked at it too.  I noticed that the nextSetX code higher up (which was new in that commit) was implemented using **int** whereas the Y and Z components appear to be retrofitted code that kept the **bool**.","created_at":"2015-02-25T00:59:41Z","updated_at":"2015-02-25T00:59:41Z","html_url":"https://github.com/highfidelity/hifi/pull/4329#discussion_r25309731","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/4329","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/25309731"},"html":{"href":"https://github.com/highfidelity/hifi/pull/4329#discussion_r25309731"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/4329"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/4329","id":29868175,"html_url":"https://github.com/highfidelity/hifi/pull/4329","diff_url":"https://github.com/highfidelity/hifi/pull/4329.diff","patch_url":"https://github.com/highfidelity/hifi/pull/4329.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/4329","number":4329,"state":"open","locked":false,"title":"Cleaned up warnings on Windows","user":{"login":"Seefo","id":3782201,"avatar_url":"https://avatars.githubusercontent.com/u/3782201?v=3","gravatar_id":"","url":"https://api.github.com/users/Seefo","html_url":"https://github.com/Seefo","followers_url":"https://api.github.com/users/Seefo/followers","following_url":"https://api.github.com/users/Seefo/following{/other_user}","gists_url":"https://api.github.com/users/Seefo/gists{/gist_id}","starred_url":"https://api.github.com/users/Seefo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Seefo/subscriptions","organizations_url":"https://api.github.com/users/Seefo/orgs","repos_url":"https://api.github.com/users/Seefo/repos","events_url":"https://api.github.com/users/Seefo/events{/privacy}","received_events_url":"https://api.github.com/users/Seefo/received_events","type":"User","site_admin":false},"body":"While looking through the code to clean up warnings, I noticed two potential bugs in Spanner.cpp where integers were being casted to a bool for comparison to another integer, it doesn't seem that this was the original intention of the code so I went ahead and changed it to remain as an int for comparison.","created_at":"2015-02-24T03:20:09Z","updated_at":"2015-02-25T00:59:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"310e764b108770639a649b356c5f06162d8e1ffe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/4329/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/4329/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/4329/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/ab590440be3f3fa70e99a762579b2d43cc6da19e","head":{"label":"Seefo:master","ref":"master","sha":"ab590440be3f3fa70e99a762579b2d43cc6da19e","user":{"login":"Seefo","id":3782201,"avatar_url":"https://avatars.githubusercontent.com/u/3782201?v=3","gravatar_id":"","url":"https://api.github.com/users/Seefo","html_url":"https://github.com/Seefo","followers_url":"https://api.github.com/users/Seefo/followers","following_url":"https://api.github.com/users/Seefo/following{/other_user}","gists_url":"https://api.github.com/users/Seefo/gists{/gist_id}","starred_url":"https://api.github.com/users/Seefo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Seefo/subscriptions","organizations_url":"https://api.github.com/users/Seefo/orgs","repos_url":"https://api.github.com/users/Seefo/repos","events_url":"https://api.github.com/users/Seefo/events{/privacy}","received_events_url":"https://api.github.com/users/Seefo/received_events","type":"User","site_admin":false},"repo":{"id":31242552,"name":"hifi","full_name":"Seefo/hifi","owner":{"login":"Seefo","id":3782201,"avatar_url":"https://avatars.githubusercontent.com/u/3782201?v=3","gravatar_id":"","url":"https://api.github.com/users/Seefo","html_url":"https://github.com/Seefo","followers_url":"https://api.github.com/users/Seefo/followers","following_url":"https://api.github.com/users/Seefo/following{/other_user}","gists_url":"https://api.github.com/users/Seefo/gists{/gist_id}","starred_url":"https://api.github.com/users/Seefo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Seefo/subscriptions","organizations_url":"https://api.github.com/users/Seefo/orgs","repos_url":"https://api.github.com/users/Seefo/repos","events_url":"https://api.github.com/users/Seefo/events{/privacy}","received_events_url":"https://api.github.com/users/Seefo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Seefo/hifi","description":"Open, decentralized virtual worlds using sensors to control avatars and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.io/jobs  Documentation at http://docs.highfidelity.io  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/Seefo/hifi","forks_url":"https://api.github.com/repos/Seefo/hifi/forks","keys_url":"https://api.github.com/repos/Seefo/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Seefo/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Seefo/hifi/teams","hooks_url":"https://api.github.com/repos/Seefo/hifi/hooks","issue_events_url":"https://api.github.com/repos/Seefo/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/Seefo/hifi/events","assignees_url":"https://api.github.com/repos/Seefo/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/Seefo/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/Seefo/hifi/tags","blobs_url":"https://api.github.com/repos/Seefo/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Seefo/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Seefo/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/Seefo/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Seefo/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/Seefo/hifi/languages","stargazers_url":"https://api.github.com/repos/Seefo/hifi/stargazers","contributors_url":"https://api.github.com/repos/Seefo/hifi/contributors","subscribers_url":"https://api.github.com/repos/Seefo/hifi/subscribers","subscription_url":"https://api.github.com/repos/Seefo/hifi/subscription","commits_url":"https://api.github.com/repos/Seefo/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/Seefo/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/Seefo/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/Seefo/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/Seefo/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/Seefo/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Seefo/hifi/merges","archive_url":"https://api.github.com/repos/Seefo/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Seefo/hifi/downloads","issues_url":"https://api.github.com/repos/Seefo/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/Seefo/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/Seefo/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/Seefo/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Seefo/hifi/labels{/name}","releases_url":"https://api.github.com/repos/Seefo/hifi/releases{/id}","created_at":"2015-02-24T03:09:36Z","updated_at":"2015-02-24T03:19:04Z","pushed_at":"2015-02-24T03:19:04Z","git_url":"git://github.com/Seefo/hifi.git","ssh_url":"git@github.com:Seefo/hifi.git","clone_url":"https://github.com/Seefo/hifi.git","svn_url":"https://github.com/Seefo/hifi","homepage":"","size":144594,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"af99a5d07b328a03050f49feb364791f59f2bb62","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open, decentralized virtual worlds using sensors to control avatars and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.io/jobs  Documentation at http://docs.highfidelity.io  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","created_at":"2012-08-10T18:26:22Z","updated_at":"2015-02-24T20:32:39Z","pushed_at":"2015-02-24T20:32:37Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":193362,"stargazers_count":235,"watchers_count":235,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":51,"forks":136,"open_issues":51,"watchers":235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/4329"},"html":{"href":"https://github.com/highfidelity/hifi/pull/4329"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/4329"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/4329/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/4329/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/4329/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/ab590440be3f3fa70e99a762579b2d43cc6da19e"}}}}