{"action":"created","comment":{"url":"https://api.github.com/repos/conc-at/clueshed/pulls/comments/23540741","id":23540741,"diff_hunk":"@@ -16,9 +16,11 @@ def show\n   def finish_signup\n     @user = User.find(params[:id])\n \n+    # mehr rails like wäre eine Trennung der Actions nach HTTP-Methode. Die zusätzliche Prüfung im if nach den Parametern ist zumindest ungewöhnlich, weil ja die Validierung einen fehlenden Parameter schon abfangen würde.","path":"app/controllers/users_controller.rb","position":4,"original_position":4,"commit_id":"fea15b544496728d4a9535573759f49002e6cf4e","original_commit_id":"5842b7ba7cf14be0f39fdbadaa8746a86955fd3e","user":{"login":"boennemann","id":908178,"avatar_url":"https://avatars.githubusercontent.com/u/908178?v=3","gravatar_id":"","url":"https://api.github.com/users/boennemann","html_url":"https://github.com/boennemann","followers_url":"https://api.github.com/users/boennemann/followers","following_url":"https://api.github.com/users/boennemann/following{/other_user}","gists_url":"https://api.github.com/users/boennemann/gists{/gist_id}","starred_url":"https://api.github.com/users/boennemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boennemann/subscriptions","organizations_url":"https://api.github.com/users/boennemann/orgs","repos_url":"https://api.github.com/users/boennemann/repos","events_url":"https://api.github.com/users/boennemann/events{/privacy}","received_events_url":"https://api.github.com/users/boennemann/received_events","type":"User","site_admin":false},"body":"Additional parameters are checked here because they're only need for adding multiple oAuth strategies to one account. It's however totally fine to just create a new user with one and the same route.\r\n\r\nI don't see the immediate benefit of using two methods for GET and PATCH here. ","created_at":"2015-01-26T16:07:20Z","updated_at":"2015-01-26T16:07:20Z","html_url":"https://github.com/conc-at/clueshed/pull/21#discussion_r23540741","pull_request_url":"https://api.github.com/repos/conc-at/clueshed/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/conc-at/clueshed/pulls/comments/23540741"},"html":{"href":"https://github.com/conc-at/clueshed/pull/21#discussion_r23540741"},"pull_request":{"href":"https://api.github.com/repos/conc-at/clueshed/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/conc-at/clueshed/pulls/21","id":27993650,"html_url":"https://github.com/conc-at/clueshed/pull/21","diff_url":"https://github.com/conc-at/clueshed/pull/21.diff","patch_url":"https://github.com/conc-at/clueshed/pull/21.patch","issue_url":"https://api.github.com/repos/conc-at/clueshed/issues/21","number":21,"state":"open","locked":false,"title":"Code Review","user":{"login":"boennemann","id":908178,"avatar_url":"https://avatars.githubusercontent.com/u/908178?v=3","gravatar_id":"","url":"https://api.github.com/users/boennemann","html_url":"https://github.com/boennemann","followers_url":"https://api.github.com/users/boennemann/followers","following_url":"https://api.github.com/users/boennemann/following{/other_user}","gists_url":"https://api.github.com/users/boennemann/gists{/gist_id}","starred_url":"https://api.github.com/users/boennemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boennemann/subscriptions","organizations_url":"https://api.github.com/users/boennemann/orgs","repos_url":"https://api.github.com/users/boennemann/repos","events_url":"https://api.github.com/users/boennemann/events{/privacy}","received_events_url":"https://api.github.com/users/boennemann/received_events","type":"User","site_admin":false},"body":"# Do Not Merge\r\n\r\n@davidgruebl I've applied the diff from the review. This PR is for discussion only.\r\nWe can now resolve every comment one by one.","created_at":"2015-01-25T15:53:00Z","updated_at":"2015-01-26T16:07:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b65d4cd3d13140f16e5c6b2a4ae62463acc13417","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/conc-at/clueshed/pulls/21/commits","review_comments_url":"https://api.github.com/repos/conc-at/clueshed/pulls/21/comments","review_comment_url":"https://api.github.com/repos/conc-at/clueshed/pulls/comments/{number}","comments_url":"https://api.github.com/repos/conc-at/clueshed/issues/21/comments","statuses_url":"https://api.github.com/repos/conc-at/clueshed/statuses/fea15b544496728d4a9535573759f49002e6cf4e","head":{"label":"conc-at:code-review","ref":"code-review","sha":"fea15b544496728d4a9535573759f49002e6cf4e","user":{"login":"conc-at","id":8300150,"avatar_url":"https://avatars.githubusercontent.com/u/8300150?v=3","gravatar_id":"","url":"https://api.github.com/users/conc-at","html_url":"https://github.com/conc-at","followers_url":"https://api.github.com/users/conc-at/followers","following_url":"https://api.github.com/users/conc-at/following{/other_user}","gists_url":"https://api.github.com/users/conc-at/gists{/gist_id}","starred_url":"https://api.github.com/users/conc-at/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conc-at/subscriptions","organizations_url":"https://api.github.com/users/conc-at/orgs","repos_url":"https://api.github.com/users/conc-at/repos","events_url":"https://api.github.com/users/conc-at/events{/privacy}","received_events_url":"https://api.github.com/users/conc-at/received_events","type":"Organization","site_admin":false},"repo":{"id":27538669,"name":"clueshed","full_name":"conc-at/clueshed","owner":{"login":"conc-at","id":8300150,"avatar_url":"https://avatars.githubusercontent.com/u/8300150?v=3","gravatar_id":"","url":"https://api.github.com/users/conc-at","html_url":"https://github.com/conc-at","followers_url":"https://api.github.com/users/conc-at/followers","following_url":"https://api.github.com/users/conc-at/following{/other_user}","gists_url":"https://api.github.com/users/conc-at/gists{/gist_id}","starred_url":"https://api.github.com/users/conc-at/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conc-at/subscriptions","organizations_url":"https://api.github.com/users/conc-at/orgs","repos_url":"https://api.github.com/users/conc-at/repos","events_url":"https://api.github.com/users/conc-at/events{/privacy}","received_events_url":"https://api.github.com/users/conc-at/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conc-at/clueshed","description":"\"Interests and Contribs\" for your Barcamp or Lightning-Talk track","fork":false,"url":"https://api.github.com/repos/conc-at/clueshed","forks_url":"https://api.github.com/repos/conc-at/clueshed/forks","keys_url":"https://api.github.com/repos/conc-at/clueshed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conc-at/clueshed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conc-at/clueshed/teams","hooks_url":"https://api.github.com/repos/conc-at/clueshed/hooks","issue_events_url":"https://api.github.com/repos/conc-at/clueshed/issues/events{/number}","events_url":"https://api.github.com/repos/conc-at/clueshed/events","assignees_url":"https://api.github.com/repos/conc-at/clueshed/assignees{/user}","branches_url":"https://api.github.com/repos/conc-at/clueshed/branches{/branch}","tags_url":"https://api.github.com/repos/conc-at/clueshed/tags","blobs_url":"https://api.github.com/repos/conc-at/clueshed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conc-at/clueshed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conc-at/clueshed/git/refs{/sha}","trees_url":"https://api.github.com/repos/conc-at/clueshed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conc-at/clueshed/statuses/{sha}","languages_url":"https://api.github.com/repos/conc-at/clueshed/languages","stargazers_url":"https://api.github.com/repos/conc-at/clueshed/stargazers","contributors_url":"https://api.github.com/repos/conc-at/clueshed/contributors","subscribers_url":"https://api.github.com/repos/conc-at/clueshed/subscribers","subscription_url":"https://api.github.com/repos/conc-at/clueshed/subscription","commits_url":"https://api.github.com/repos/conc-at/clueshed/commits{/sha}","git_commits_url":"https://api.github.com/repos/conc-at/clueshed/git/commits{/sha}","comments_url":"https://api.github.com/repos/conc-at/clueshed/comments{/number}","issue_comment_url":"https://api.github.com/repos/conc-at/clueshed/issues/comments/{number}","contents_url":"https://api.github.com/repos/conc-at/clueshed/contents/{+path}","compare_url":"https://api.github.com/repos/conc-at/clueshed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conc-at/clueshed/merges","archive_url":"https://api.github.com/repos/conc-at/clueshed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conc-at/clueshed/downloads","issues_url":"https://api.github.com/repos/conc-at/clueshed/issues{/number}","pulls_url":"https://api.github.com/repos/conc-at/clueshed/pulls{/number}","milestones_url":"https://api.github.com/repos/conc-at/clueshed/milestones{/number}","notifications_url":"https://api.github.com/repos/conc-at/clueshed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conc-at/clueshed/labels{/name}","releases_url":"https://api.github.com/repos/conc-at/clueshed/releases{/id}","created_at":"2014-12-04T12:06:11Z","updated_at":"2015-01-10T00:21:59Z","pushed_at":"2015-01-26T15:59:09Z","git_url":"git://github.com/conc-at/clueshed.git","ssh_url":"git@github.com:conc-at/clueshed.git","clone_url":"https://github.com/conc-at/clueshed.git","svn_url":"https://github.com/conc-at/clueshed","homepage":"https://clueshed.herokuapp.com/","size":940,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"conc-at:master","ref":"master","sha":"5b64145298fb1a09e16bb9ddef349f653e13aca9","user":{"login":"conc-at","id":8300150,"avatar_url":"https://avatars.githubusercontent.com/u/8300150?v=3","gravatar_id":"","url":"https://api.github.com/users/conc-at","html_url":"https://github.com/conc-at","followers_url":"https://api.github.com/users/conc-at/followers","following_url":"https://api.github.com/users/conc-at/following{/other_user}","gists_url":"https://api.github.com/users/conc-at/gists{/gist_id}","starred_url":"https://api.github.com/users/conc-at/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conc-at/subscriptions","organizations_url":"https://api.github.com/users/conc-at/orgs","repos_url":"https://api.github.com/users/conc-at/repos","events_url":"https://api.github.com/users/conc-at/events{/privacy}","received_events_url":"https://api.github.com/users/conc-at/received_events","type":"Organization","site_admin":false},"repo":{"id":27538669,"name":"clueshed","full_name":"conc-at/clueshed","owner":{"login":"conc-at","id":8300150,"avatar_url":"https://avatars.githubusercontent.com/u/8300150?v=3","gravatar_id":"","url":"https://api.github.com/users/conc-at","html_url":"https://github.com/conc-at","followers_url":"https://api.github.com/users/conc-at/followers","following_url":"https://api.github.com/users/conc-at/following{/other_user}","gists_url":"https://api.github.com/users/conc-at/gists{/gist_id}","starred_url":"https://api.github.com/users/conc-at/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conc-at/subscriptions","organizations_url":"https://api.github.com/users/conc-at/orgs","repos_url":"https://api.github.com/users/conc-at/repos","events_url":"https://api.github.com/users/conc-at/events{/privacy}","received_events_url":"https://api.github.com/users/conc-at/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conc-at/clueshed","description":"\"Interests and Contribs\" for your Barcamp or Lightning-Talk track","fork":false,"url":"https://api.github.com/repos/conc-at/clueshed","forks_url":"https://api.github.com/repos/conc-at/clueshed/forks","keys_url":"https://api.github.com/repos/conc-at/clueshed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conc-at/clueshed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conc-at/clueshed/teams","hooks_url":"https://api.github.com/repos/conc-at/clueshed/hooks","issue_events_url":"https://api.github.com/repos/conc-at/clueshed/issues/events{/number}","events_url":"https://api.github.com/repos/conc-at/clueshed/events","assignees_url":"https://api.github.com/repos/conc-at/clueshed/assignees{/user}","branches_url":"https://api.github.com/repos/conc-at/clueshed/branches{/branch}","tags_url":"https://api.github.com/repos/conc-at/clueshed/tags","blobs_url":"https://api.github.com/repos/conc-at/clueshed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conc-at/clueshed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conc-at/clueshed/git/refs{/sha}","trees_url":"https://api.github.com/repos/conc-at/clueshed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conc-at/clueshed/statuses/{sha}","languages_url":"https://api.github.com/repos/conc-at/clueshed/languages","stargazers_url":"https://api.github.com/repos/conc-at/clueshed/stargazers","contributors_url":"https://api.github.com/repos/conc-at/clueshed/contributors","subscribers_url":"https://api.github.com/repos/conc-at/clueshed/subscribers","subscription_url":"https://api.github.com/repos/conc-at/clueshed/subscription","commits_url":"https://api.github.com/repos/conc-at/clueshed/commits{/sha}","git_commits_url":"https://api.github.com/repos/conc-at/clueshed/git/commits{/sha}","comments_url":"https://api.github.com/repos/conc-at/clueshed/comments{/number}","issue_comment_url":"https://api.github.com/repos/conc-at/clueshed/issues/comments/{number}","contents_url":"https://api.github.com/repos/conc-at/clueshed/contents/{+path}","compare_url":"https://api.github.com/repos/conc-at/clueshed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conc-at/clueshed/merges","archive_url":"https://api.github.com/repos/conc-at/clueshed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conc-at/clueshed/downloads","issues_url":"https://api.github.com/repos/conc-at/clueshed/issues{/number}","pulls_url":"https://api.github.com/repos/conc-at/clueshed/pulls{/number}","milestones_url":"https://api.github.com/repos/conc-at/clueshed/milestones{/number}","notifications_url":"https://api.github.com/repos/conc-at/clueshed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conc-at/clueshed/labels{/name}","releases_url":"https://api.github.com/repos/conc-at/clueshed/releases{/id}","created_at":"2014-12-04T12:06:11Z","updated_at":"2015-01-10T00:21:59Z","pushed_at":"2015-01-26T15:59:09Z","git_url":"git://github.com/conc-at/clueshed.git","ssh_url":"git@github.com:conc-at/clueshed.git","clone_url":"https://github.com/conc-at/clueshed.git","svn_url":"https://github.com/conc-at/clueshed","homepage":"https://clueshed.herokuapp.com/","size":940,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/conc-at/clueshed/pulls/21"},"html":{"href":"https://github.com/conc-at/clueshed/pull/21"},"issue":{"href":"https://api.github.com/repos/conc-at/clueshed/issues/21"},"comments":{"href":"https://api.github.com/repos/conc-at/clueshed/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/conc-at/clueshed/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/conc-at/clueshed/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/conc-at/clueshed/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/conc-at/clueshed/statuses/fea15b544496728d4a9535573759f49002e6cf4e"}}}}