{"action":"closed","number":7983,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/7983","id":44377116,"html_url":"https://github.com/xbmc/xbmc/pull/7983","diff_url":"https://github.com/xbmc/xbmc/pull/7983.diff","patch_url":"https://github.com/xbmc/xbmc/pull/7983.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/7983","number":7983,"state":"closed","locked":false,"title":"settings: fix method signatures of overriden virtual methods","user":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"body":"Thanks to https://github.com/MrMC/mrmc/commit/9cfeda3e86fccb910f6bdca2affd3887acc8ff34 I've looked into all the method signatures of overriden virtual methods in the settings library and fixed one of them. To be able to let the compiler do this work for us in the future I've added the `override` keywoard to all overriden methods I could find.\r\n\r\nFurthermore I've noticed that `CWinSystemX11` derived from `ISettingCallback` but doesn't override any of its virtual methods so I've removed it. Last but not least I've noticed that `CWakeOnAccess` uses the `OnSettingsSaved()` callback of `ISettinsHandler` to \"monitor\" the wake on access setting value which is not reliable. Therefore I've changed it to use `ISettingCallback::OnSettingChanged()` on that specific setting.","created_at":"2015-09-07T19:56:47Z","updated_at":"2015-09-09T05:44:27Z","closed_at":"2015-09-09T05:44:27Z","merged_at":"2015-09-09T05:44:27Z","merge_commit_sha":"bcd6429267f80f5f0b4719cf0ff93ac73a1c30db","assignee":null,"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/69","html_url":"https://github.com/xbmc/xbmc/milestones/Jarvis%2016.0-alpha3","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/69/labels","id":1265879,"number":69,"title":"Jarvis 16.0-alpha3","description":"","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars.githubusercontent.com/u/907436?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":68,"state":"open","created_at":"2015-08-21T07:00:45Z","updated_at":"2015-09-09T05:44:27Z","due_on":"2015-09-29T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7983/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7983/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/7983/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/eb1bae599bf0f2390fc28062fe8ac03ea4c9e857","head":{"label":"Montellese:virtual_override_settings","ref":"virtual_override_settings","sha":"eb1bae599bf0f2390fc28062fe8ac03ea4c9e857","user":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"repo":{"id":1287028,"name":"xbmc","full_name":"Montellese/xbmc","owner":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Montellese/xbmc","description":"Montellese's fork of XBMC ","fork":true,"url":"https://api.github.com/repos/Montellese/xbmc","forks_url":"https://api.github.com/repos/Montellese/xbmc/forks","keys_url":"https://api.github.com/repos/Montellese/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Montellese/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Montellese/xbmc/teams","hooks_url":"https://api.github.com/repos/Montellese/xbmc/hooks","issue_events_url":"https://api.github.com/repos/Montellese/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/Montellese/xbmc/events","assignees_url":"https://api.github.com/repos/Montellese/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/Montellese/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/Montellese/xbmc/tags","blobs_url":"https://api.github.com/repos/Montellese/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Montellese/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Montellese/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Montellese/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Montellese/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/Montellese/xbmc/languages","stargazers_url":"https://api.github.com/repos/Montellese/xbmc/stargazers","contributors_url":"https://api.github.com/repos/Montellese/xbmc/contributors","subscribers_url":"https://api.github.com/repos/Montellese/xbmc/subscribers","subscription_url":"https://api.github.com/repos/Montellese/xbmc/subscription","commits_url":"https://api.github.com/repos/Montellese/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Montellese/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Montellese/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Montellese/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Montellese/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/Montellese/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Montellese/xbmc/merges","archive_url":"https://api.github.com/repos/Montellese/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Montellese/xbmc/downloads","issues_url":"https://api.github.com/repos/Montellese/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/Montellese/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/Montellese/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/Montellese/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Montellese/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/Montellese/xbmc/releases{/id}","created_at":"2011-01-24T08:36:12Z","updated_at":"2015-08-16T15:03:16Z","pushed_at":"2015-09-08T21:53:55Z","git_url":"git://github.com/Montellese/xbmc.git","ssh_url":"git@github.com:Montellese/xbmc.git","clone_url":"https://github.com/Montellese/xbmc.git","svn_url":"https://github.com/Montellese/xbmc","homepage":"http://xbmc.org","size":540047,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":6,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"6adfe0501163de719054437f63d7515e2afa8836","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-09-08T21:41:44Z","pushed_at":"2015-09-09T05:44:27Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1889949,"stargazers_count":4092,"watchers_count":4092,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3008,"mirror_url":null,"open_issues_count":207,"forks":3008,"open_issues":207,"watchers":4092,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7983"},"html":{"href":"https://github.com/xbmc/xbmc/pull/7983"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7983"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7983/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7983/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7983/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/eb1bae599bf0f2390fc28062fe8ac03ea4c9e857"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"commits":3,"additions":199,"deletions":190,"changed_files":46}}