{"action":"created","comment":{"url":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/comments/29793764","id":29793764,"diff_hunk":"@@ -212,8 +212,10 @@ public void setup( final Collection<Plugin> plugins ) {\n             //Sort Activities by Name. A TreeMap supports sorting on insertion by natural ordering of its keys\n             final Map<String, Activity> activities = new TreeMap<String, Activity>( PLUGIN_NAME_COMPARATOR );\n             for ( final Activity item : e.getValue() ) {\n-                activities.put( item.getName(),\n-                                item );\n+                if ( !thereIsAlreadyAPluginWithSameName( item, activities ) ) {","path":"uberfire-runtime-plugins/uberfire-runtime-plugins-client/src/main/java/org/uberfire/ext/plugin/client/widget/navigator/PluginNavList.java","position":6,"original_position":6,"commit_id":"6152578c77761823e297027706bcab38754b28fe","original_commit_id":"6152578c77761823e297027706bcab38754b28fe","user":{"login":"manstis","id":497544,"avatar_url":"https://avatars.githubusercontent.com/u/497544?v=3","gravatar_id":"","url":"https://api.github.com/users/manstis","html_url":"https://github.com/manstis","followers_url":"https://api.github.com/users/manstis/followers","following_url":"https://api.github.com/users/manstis/following{/other_user}","gists_url":"https://api.github.com/users/manstis/gists{/gist_id}","starred_url":"https://api.github.com/users/manstis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manstis/subscriptions","organizations_url":"https://api.github.com/users/manstis/orgs","repos_url":"https://api.github.com/users/manstis/repos","events_url":"https://api.github.com/users/manstis/events{/privacy}","received_events_url":"https://api.github.com/users/manstis/received_events","type":"User","site_admin":false},"body":"...and what do you do if there is a plugin with that name already? Skip it, and then Users complain plugins are \"disappearing\"?\r\n\r\nIMO we either need to prevent plugins from being created with an existing name - although this is going to be close to impossible if Users can create them with either (1) using the UI, (2) using a JSON file in the webapp's folder, (3) using a JSON file committed to the plugins.git repository; or find a solution to support activities with the sane name (but IDK if this is supported by the whole Plugins framework - or whether names need to be unique?).","created_at":"2015-05-06T19:38:44Z","updated_at":"2015-05-06T19:38:44Z","html_url":"https://github.com/uberfire/uberfire-extensions/pull/38#discussion_r29793764","pull_request_url":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/comments/29793764"},"html":{"href":"https://github.com/uberfire/uberfire-extensions/pull/38#discussion_r29793764"},"pull_request":{"href":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/38","id":34848633,"html_url":"https://github.com/uberfire/uberfire-extensions/pull/38","diff_url":"https://github.com/uberfire/uberfire-extensions/pull/38.diff","patch_url":"https://github.com/uberfire/uberfire-extensions/pull/38.patch","issue_url":"https://api.github.com/repos/uberfire/uberfire-extensions/issues/38","number":38,"state":"open","locked":false,"title":"UF-180: Configurable Workbench","user":{"login":"ederign","id":531351,"avatar_url":"https://avatars.githubusercontent.com/u/531351?v=3","gravatar_id":"","url":"https://api.github.com/users/ederign","html_url":"https://github.com/ederign","followers_url":"https://api.github.com/users/ederign/followers","following_url":"https://api.github.com/users/ederign/following{/other_user}","gists_url":"https://api.github.com/users/ederign/gists{/gist_id}","starred_url":"https://api.github.com/users/ederign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ederign/subscriptions","organizations_url":"https://api.github.com/users/ederign/orgs","repos_url":"https://api.github.com/users/ederign/repos","events_url":"https://api.github.com/users/ederign/events{/privacy}","received_events_url":"https://api.github.com/users/ederign/received_events","type":"User","site_admin":false},"body":" - Fixing plugins missing (sometimes) in plugins editor nav list.\r\n\r\nThis happens randomly because in that lists is a screen and plugin with same name (L:215)","created_at":"2015-05-06T19:00:48Z","updated_at":"2015-05-06T19:38:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa35fbea839759dbd7618a5737f7c3b156171ace","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/38/commits","review_comments_url":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/38/comments","review_comment_url":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uberfire/uberfire-extensions/issues/38/comments","statuses_url":"https://api.github.com/repos/uberfire/uberfire-extensions/statuses/6152578c77761823e297027706bcab38754b28fe","head":{"label":"ederign:plugins-nav-list-fix","ref":"plugins-nav-list-fix","sha":"6152578c77761823e297027706bcab38754b28fe","user":{"login":"ederign","id":531351,"avatar_url":"https://avatars.githubusercontent.com/u/531351?v=3","gravatar_id":"","url":"https://api.github.com/users/ederign","html_url":"https://github.com/ederign","followers_url":"https://api.github.com/users/ederign/followers","following_url":"https://api.github.com/users/ederign/following{/other_user}","gists_url":"https://api.github.com/users/ederign/gists{/gist_id}","starred_url":"https://api.github.com/users/ederign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ederign/subscriptions","organizations_url":"https://api.github.com/users/ederign/orgs","repos_url":"https://api.github.com/users/ederign/repos","events_url":"https://api.github.com/users/ederign/events{/privacy}","received_events_url":"https://api.github.com/users/ederign/received_events","type":"User","site_admin":false},"repo":{"id":33491754,"name":"uberfire-extensions","full_name":"ederign/uberfire-extensions","owner":{"login":"ederign","id":531351,"avatar_url":"https://avatars.githubusercontent.com/u/531351?v=3","gravatar_id":"","url":"https://api.github.com/users/ederign","html_url":"https://github.com/ederign","followers_url":"https://api.github.com/users/ederign/followers","following_url":"https://api.github.com/users/ederign/following{/other_user}","gists_url":"https://api.github.com/users/ederign/gists{/gist_id}","starred_url":"https://api.github.com/users/ederign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ederign/subscriptions","organizations_url":"https://api.github.com/users/ederign/orgs","repos_url":"https://api.github.com/users/ederign/repos","events_url":"https://api.github.com/users/ederign/events{/privacy}","received_events_url":"https://api.github.com/users/ederign/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ederign/uberfire-extensions","description":"Generic extensions to the Uberfire framework","fork":true,"url":"https://api.github.com/repos/ederign/uberfire-extensions","forks_url":"https://api.github.com/repos/ederign/uberfire-extensions/forks","keys_url":"https://api.github.com/repos/ederign/uberfire-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ederign/uberfire-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ederign/uberfire-extensions/teams","hooks_url":"https://api.github.com/repos/ederign/uberfire-extensions/hooks","issue_events_url":"https://api.github.com/repos/ederign/uberfire-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/ederign/uberfire-extensions/events","assignees_url":"https://api.github.com/repos/ederign/uberfire-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/ederign/uberfire-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/ederign/uberfire-extensions/tags","blobs_url":"https://api.github.com/repos/ederign/uberfire-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ederign/uberfire-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ederign/uberfire-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/ederign/uberfire-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ederign/uberfire-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/ederign/uberfire-extensions/languages","stargazers_url":"https://api.github.com/repos/ederign/uberfire-extensions/stargazers","contributors_url":"https://api.github.com/repos/ederign/uberfire-extensions/contributors","subscribers_url":"https://api.github.com/repos/ederign/uberfire-extensions/subscribers","subscription_url":"https://api.github.com/repos/ederign/uberfire-extensions/subscription","commits_url":"https://api.github.com/repos/ederign/uberfire-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/ederign/uberfire-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/ederign/uberfire-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/ederign/uberfire-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/ederign/uberfire-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/ederign/uberfire-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ederign/uberfire-extensions/merges","archive_url":"https://api.github.com/repos/ederign/uberfire-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ederign/uberfire-extensions/downloads","issues_url":"https://api.github.com/repos/ederign/uberfire-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/ederign/uberfire-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/ederign/uberfire-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/ederign/uberfire-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ederign/uberfire-extensions/labels{/name}","releases_url":"https://api.github.com/repos/ederign/uberfire-extensions/releases{/id}","created_at":"2015-04-06T16:19:19Z","updated_at":"2015-04-24T18:31:27Z","pushed_at":"2015-05-06T18:58:43Z","git_url":"git://github.com/ederign/uberfire-extensions.git","ssh_url":"git@github.com:ederign/uberfire-extensions.git","clone_url":"https://github.com/ederign/uberfire-extensions.git","svn_url":"https://github.com/ederign/uberfire-extensions","homepage":null,"size":4064,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uberfire:master","ref":"master","sha":"d4801c691b1357e9c5c93fd917ea2eb76bbc8516","user":{"login":"uberfire","id":5167699,"avatar_url":"https://avatars.githubusercontent.com/u/5167699?v=3","gravatar_id":"","url":"https://api.github.com/users/uberfire","html_url":"https://github.com/uberfire","followers_url":"https://api.github.com/users/uberfire/followers","following_url":"https://api.github.com/users/uberfire/following{/other_user}","gists_url":"https://api.github.com/users/uberfire/gists{/gist_id}","starred_url":"https://api.github.com/users/uberfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uberfire/subscriptions","organizations_url":"https://api.github.com/users/uberfire/orgs","repos_url":"https://api.github.com/users/uberfire/repos","events_url":"https://api.github.com/users/uberfire/events{/privacy}","received_events_url":"https://api.github.com/users/uberfire/received_events","type":"Organization","site_admin":false},"repo":{"id":26430285,"name":"uberfire-extensions","full_name":"uberfire/uberfire-extensions","owner":{"login":"uberfire","id":5167699,"avatar_url":"https://avatars.githubusercontent.com/u/5167699?v=3","gravatar_id":"","url":"https://api.github.com/users/uberfire","html_url":"https://github.com/uberfire","followers_url":"https://api.github.com/users/uberfire/followers","following_url":"https://api.github.com/users/uberfire/following{/other_user}","gists_url":"https://api.github.com/users/uberfire/gists{/gist_id}","starred_url":"https://api.github.com/users/uberfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uberfire/subscriptions","organizations_url":"https://api.github.com/users/uberfire/orgs","repos_url":"https://api.github.com/users/uberfire/repos","events_url":"https://api.github.com/users/uberfire/events{/privacy}","received_events_url":"https://api.github.com/users/uberfire/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uberfire/uberfire-extensions","description":"Generic extensions to the Uberfire framework","fork":false,"url":"https://api.github.com/repos/uberfire/uberfire-extensions","forks_url":"https://api.github.com/repos/uberfire/uberfire-extensions/forks","keys_url":"https://api.github.com/repos/uberfire/uberfire-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uberfire/uberfire-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uberfire/uberfire-extensions/teams","hooks_url":"https://api.github.com/repos/uberfire/uberfire-extensions/hooks","issue_events_url":"https://api.github.com/repos/uberfire/uberfire-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/uberfire/uberfire-extensions/events","assignees_url":"https://api.github.com/repos/uberfire/uberfire-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/uberfire/uberfire-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/uberfire/uberfire-extensions/tags","blobs_url":"https://api.github.com/repos/uberfire/uberfire-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uberfire/uberfire-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uberfire/uberfire-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/uberfire/uberfire-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uberfire/uberfire-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/uberfire/uberfire-extensions/languages","stargazers_url":"https://api.github.com/repos/uberfire/uberfire-extensions/stargazers","contributors_url":"https://api.github.com/repos/uberfire/uberfire-extensions/contributors","subscribers_url":"https://api.github.com/repos/uberfire/uberfire-extensions/subscribers","subscription_url":"https://api.github.com/repos/uberfire/uberfire-extensions/subscription","commits_url":"https://api.github.com/repos/uberfire/uberfire-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/uberfire/uberfire-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/uberfire/uberfire-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/uberfire/uberfire-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/uberfire/uberfire-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/uberfire/uberfire-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uberfire/uberfire-extensions/merges","archive_url":"https://api.github.com/repos/uberfire/uberfire-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uberfire/uberfire-extensions/downloads","issues_url":"https://api.github.com/repos/uberfire/uberfire-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/uberfire/uberfire-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/uberfire/uberfire-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uberfire/uberfire-extensions/labels{/name}","releases_url":"https://api.github.com/repos/uberfire/uberfire-extensions/releases{/id}","created_at":"2014-11-10T09:42:01Z","updated_at":"2015-05-06T07:49:26Z","pushed_at":"2015-05-06T19:00:48Z","git_url":"git://github.com/uberfire/uberfire-extensions.git","ssh_url":"git@github.com:uberfire/uberfire-extensions.git","clone_url":"https://github.com/uberfire/uberfire-extensions.git","svn_url":"https://github.com/uberfire/uberfire-extensions","homepage":null,"size":5153,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":5,"forks":16,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/38"},"html":{"href":"https://github.com/uberfire/uberfire-extensions/pull/38"},"issue":{"href":"https://api.github.com/repos/uberfire/uberfire-extensions/issues/38"},"comments":{"href":"https://api.github.com/repos/uberfire/uberfire-extensions/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/uberfire/uberfire-extensions/statuses/6152578c77761823e297027706bcab38754b28fe"}}}}