{"action":"created","issue":{"url":"https://api.github.com/repos/hooklift/node-libvirt/issues/53","labels_url":"https://api.github.com/repos/hooklift/node-libvirt/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/hooklift/node-libvirt/issues/53/comments","events_url":"https://api.github.com/repos/hooklift/node-libvirt/issues/53/events","html_url":"https://github.com/hooklift/node-libvirt/pull/53","id":98441548,"number":53,"title":"Fix build on node 0.12.7","user":{"login":"Rush","id":115926,"avatar_url":"https://avatars.githubusercontent.com/u/115926?v=3","gravatar_id":"","url":"https://api.github.com/users/Rush","html_url":"https://github.com/Rush","followers_url":"https://api.github.com/users/Rush/followers","following_url":"https://api.github.com/users/Rush/following{/other_user}","gists_url":"https://api.github.com/users/Rush/gists{/gist_id}","starred_url":"https://api.github.com/users/Rush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rush/subscriptions","organizations_url":"https://api.github.com/users/Rush/orgs","repos_url":"https://api.github.com/users/Rush/repos","events_url":"https://api.github.com/users/Rush/events{/privacy}","received_events_url":"https://api.github.com/users/Rush/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-07-31T17:56:36Z","updated_at":"2015-08-01T01:47:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hooklift/node-libvirt/pulls/53","html_url":"https://github.com/hooklift/node-libvirt/pull/53","diff_url":"https://github.com/hooklift/node-libvirt/pull/53.diff","patch_url":"https://github.com/hooklift/node-libvirt/pull/53.patch"},"body":"I had errors like:\r\n```\r\n CXX(target) Release/obj.target/libvirt/src/worker.o\r\n  CXX(target) Release/obj.target/libvirt/src/interface.o\r\n  CXX(target) Release/obj.target/libvirt/src/network.o\r\n  CXX(target) Release/obj.target/libvirt/src/network_filter.o\r\n  CXX(target) Release/obj.target/libvirt/src/node_device.o\r\n  CXX(target) Release/obj.target/libvirt/src/secret.o\r\n  CXX(target) Release/obj.target/libvirt/src/storage_pool.o\r\n  CXX(target) Release/obj.target/libvirt/src/storage_volume.o\r\n  CXX(target) Release/obj.target/libvirt/src/domain.o\r\n../src/domain.cc: In static member function ‘static void NodeLibvirt::Domain::SetSchedulerParameters(const v8::FunctionCallbackInfo<v8::Value>&)’:\r\n../src/domain.cc:2002:48: error: call of overloaded ‘NanThrowError(v8::Local<v8::Object>)’ is ambiguous\r\n     NanThrowError(Error::New(virGetLastError()));\r\n                                                ^\r\n../src/domain.cc:2002:48: note: candidates are:\r\nIn file included from ../src/error.h:5:0,\r\n                 from ../src/domain.cc:3:\r\n../node_modules/nan/nan.h:705:21: note: void NanThrowError(v8::Handle<v8::String>)\r\n     NAN_INLINE void NanThrow ## NAME(v8::Handle<v8::String> errmsg) {          \\\r\n                     ^\r\n../node_modules/nan/nan.h:711:3: note: in expansion of macro ‘X’\r\n   X(Error)\r\n   ^\r\n../node_modules/nan/nan.h:719:19: note: void NanThrowError(v8::Handle<v8::Value>)\r\n   NAN_INLINE void NanThrowError(v8::Handle<v8::Value> error) {\r\n                   ^\r\n../src/domain.cc:2017:48: error: call of overloaded ‘NanThrowError(v8::Local<v8::Object>)’ is ambiguous\r\n     NanThrowError(Error::New(virGetLastError()));\r\n                                                ^\r\n../src/domain.cc:2017:48: note: candidates are:\r\nIn file included from ../src/error.h:5:0,\r\n                 from ../src/domain.cc:3:\r\n../node_modules/nan/nan.h:705:21: note: void NanThrowError(v8::Handle<v8::String>)\r\n     NAN_INLINE void NanThrow ## NAME(v8::Handle<v8::String> errmsg) {          \\\r\n                     ^\r\n../node_modules/nan/nan.h:711:3: note: in expansion of macro ‘X’\r\n   X(Error)\r\n   ^\r\n../node_modules/nan/nan.h:719:19: note: void NanThrowError(v8::Handle<v8::Value>)\r\n   NAN_INLINE void NanThrowError(v8::Handle<v8::Value> error) {\r\n                   ^\r\n../src/domain.cc:2054:48: error: call of overloaded ‘NanThrowError(v8::Local<v8::Object>)’ is ambiguous\r\n     NanThrowError(Error::New(virGetLastError()));\r\n                                                ^\r\n../src/domain.cc:2054:48: note: candidates are:\r\nIn file included from ../src/error.h:5:0,\r\n                 from ../src/domain.cc:3:\r\n../node_modules/nan/nan.h:705:21: note: void NanThrowError(v8::Handle<v8::String>)\r\n     NAN_INLINE void NanThrow ## NAME(v8::Handle<v8::String> errmsg) {          \\\r\n                     ^\r\n../node_modules/nan/nan.h:711:3: note: in expansion of macro ‘X’\r\n   X(Error)\r\n   ^\r\n../node_modules/nan/nan.h:719:19: note: void NanThrowError(v8::Handle<v8::Value>)\r\n   NAN_INLINE void NanThrowError(v8::Handle<v8::Value> error) {\r\n                   ^\r\nmake: *** [Release/obj.target/libvirt/src/domain.o] Error 1\r\n```\r\n\r\nThis pull request fixes it."},"comment":{"url":"https://api.github.com/repos/hooklift/node-libvirt/issues/comments/126848606","html_url":"https://github.com/hooklift/node-libvirt/pull/53#issuecomment-126848606","issue_url":"https://api.github.com/repos/hooklift/node-libvirt/issues/53","id":126848606,"user":{"login":"dariusc93","id":3918024,"avatar_url":"https://avatars.githubusercontent.com/u/3918024?v=3","gravatar_id":"","url":"https://api.github.com/users/dariusc93","html_url":"https://github.com/dariusc93","followers_url":"https://api.github.com/users/dariusc93/followers","following_url":"https://api.github.com/users/dariusc93/following{/other_user}","gists_url":"https://api.github.com/users/dariusc93/gists{/gist_id}","starred_url":"https://api.github.com/users/dariusc93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dariusc93/subscriptions","organizations_url":"https://api.github.com/users/dariusc93/orgs","repos_url":"https://api.github.com/users/dariusc93/repos","events_url":"https://api.github.com/users/dariusc93/events{/privacy}","received_events_url":"https://api.github.com/users/dariusc93/received_events","type":"User","site_admin":false},"created_at":"2015-08-01T01:47:50Z","updated_at":"2015-08-01T01:47:50Z","body":"Might explain why broke when it was working just fine last week for me. "}}