{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/sjelin/protractor/pulls/1","id":37672597,"html_url":"https://github.com/sjelin/protractor/pull/1","diff_url":"https://github.com/sjelin/protractor/pull/1.diff","patch_url":"https://github.com/sjelin/protractor/pull/1.patch","issue_url":"https://api.github.com/repos/sjelin/protractor/issues/1","number":1,"state":"closed","locked":false,"title":"feat(plugins): Allow waitForCondition/Promise with ignoreSynchronization","user":{"login":"alfonso-presa","id":8171111,"avatar_url":"https://avatars.githubusercontent.com/u/8171111?v=3","gravatar_id":"","url":"https://api.github.com/users/alfonso-presa","html_url":"https://github.com/alfonso-presa","followers_url":"https://api.github.com/users/alfonso-presa/followers","following_url":"https://api.github.com/users/alfonso-presa/following{/other_user}","gists_url":"https://api.github.com/users/alfonso-presa/gists{/gist_id}","starred_url":"https://api.github.com/users/alfonso-presa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfonso-presa/subscriptions","organizations_url":"https://api.github.com/users/alfonso-presa/orgs","repos_url":"https://api.github.com/users/alfonso-presa/repos","events_url":"https://api.github.com/users/alfonso-presa/events{/privacy}","received_events_url":"https://api.github.com/users/alfonso-presa/received_events","type":"User","site_admin":false},"body":"I've been trying to use the new plugin-api to solve https://github.com/angular/protractor/issues/2246 and it turns out waitForCondition/Promise are not executed when you're not in angular application (as ignoreSynchronization is needed).\r\n\r\nThis PR aims to address this by always running waitFor* on plugins, providing a new waitForStableStatus method.","created_at":"2015-06-15T09:25:19Z","updated_at":"2015-06-15T15:03:44Z","closed_at":"2015-06-15T15:03:44Z","merged_at":null,"merge_commit_sha":"967cd18dfc2200ac3e14a378984d3e697435cf36","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sjelin/protractor/pulls/1/commits","review_comments_url":"https://api.github.com/repos/sjelin/protractor/pulls/1/comments","review_comment_url":"https://api.github.com/repos/sjelin/protractor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sjelin/protractor/issues/1/comments","statuses_url":"https://api.github.com/repos/sjelin/protractor/statuses/8c5972c93f98b1145a56125845715b7a468f14ef","head":{"label":"alfonso-presa:plugin-api","ref":"plugin-api","sha":"8c5972c93f98b1145a56125845715b7a468f14ef","user":{"login":"alfonso-presa","id":8171111,"avatar_url":"https://avatars.githubusercontent.com/u/8171111?v=3","gravatar_id":"","url":"https://api.github.com/users/alfonso-presa","html_url":"https://github.com/alfonso-presa","followers_url":"https://api.github.com/users/alfonso-presa/followers","following_url":"https://api.github.com/users/alfonso-presa/following{/other_user}","gists_url":"https://api.github.com/users/alfonso-presa/gists{/gist_id}","starred_url":"https://api.github.com/users/alfonso-presa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfonso-presa/subscriptions","organizations_url":"https://api.github.com/users/alfonso-presa/orgs","repos_url":"https://api.github.com/users/alfonso-presa/repos","events_url":"https://api.github.com/users/alfonso-presa/events{/privacy}","received_events_url":"https://api.github.com/users/alfonso-presa/received_events","type":"User","site_admin":false},"repo":{"id":37451546,"name":"protractor","full_name":"alfonso-presa/protractor","owner":{"login":"alfonso-presa","id":8171111,"avatar_url":"https://avatars.githubusercontent.com/u/8171111?v=3","gravatar_id":"","url":"https://api.github.com/users/alfonso-presa","html_url":"https://github.com/alfonso-presa","followers_url":"https://api.github.com/users/alfonso-presa/followers","following_url":"https://api.github.com/users/alfonso-presa/following{/other_user}","gists_url":"https://api.github.com/users/alfonso-presa/gists{/gist_id}","starred_url":"https://api.github.com/users/alfonso-presa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfonso-presa/subscriptions","organizations_url":"https://api.github.com/users/alfonso-presa/orgs","repos_url":"https://api.github.com/users/alfonso-presa/repos","events_url":"https://api.github.com/users/alfonso-presa/events{/privacy}","received_events_url":"https://api.github.com/users/alfonso-presa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alfonso-presa/protractor","description":"E2E test framework for Angular apps","fork":true,"url":"https://api.github.com/repos/alfonso-presa/protractor","forks_url":"https://api.github.com/repos/alfonso-presa/protractor/forks","keys_url":"https://api.github.com/repos/alfonso-presa/protractor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alfonso-presa/protractor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alfonso-presa/protractor/teams","hooks_url":"https://api.github.com/repos/alfonso-presa/protractor/hooks","issue_events_url":"https://api.github.com/repos/alfonso-presa/protractor/issues/events{/number}","events_url":"https://api.github.com/repos/alfonso-presa/protractor/events","assignees_url":"https://api.github.com/repos/alfonso-presa/protractor/assignees{/user}","branches_url":"https://api.github.com/repos/alfonso-presa/protractor/branches{/branch}","tags_url":"https://api.github.com/repos/alfonso-presa/protractor/tags","blobs_url":"https://api.github.com/repos/alfonso-presa/protractor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alfonso-presa/protractor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alfonso-presa/protractor/git/refs{/sha}","trees_url":"https://api.github.com/repos/alfonso-presa/protractor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alfonso-presa/protractor/statuses/{sha}","languages_url":"https://api.github.com/repos/alfonso-presa/protractor/languages","stargazers_url":"https://api.github.com/repos/alfonso-presa/protractor/stargazers","contributors_url":"https://api.github.com/repos/alfonso-presa/protractor/contributors","subscribers_url":"https://api.github.com/repos/alfonso-presa/protractor/subscribers","subscription_url":"https://api.github.com/repos/alfonso-presa/protractor/subscription","commits_url":"https://api.github.com/repos/alfonso-presa/protractor/commits{/sha}","git_commits_url":"https://api.github.com/repos/alfonso-presa/protractor/git/commits{/sha}","comments_url":"https://api.github.com/repos/alfonso-presa/protractor/comments{/number}","issue_comment_url":"https://api.github.com/repos/alfonso-presa/protractor/issues/comments{/number}","contents_url":"https://api.github.com/repos/alfonso-presa/protractor/contents/{+path}","compare_url":"https://api.github.com/repos/alfonso-presa/protractor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alfonso-presa/protractor/merges","archive_url":"https://api.github.com/repos/alfonso-presa/protractor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alfonso-presa/protractor/downloads","issues_url":"https://api.github.com/repos/alfonso-presa/protractor/issues{/number}","pulls_url":"https://api.github.com/repos/alfonso-presa/protractor/pulls{/number}","milestones_url":"https://api.github.com/repos/alfonso-presa/protractor/milestones{/number}","notifications_url":"https://api.github.com/repos/alfonso-presa/protractor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alfonso-presa/protractor/labels{/name}","releases_url":"https://api.github.com/repos/alfonso-presa/protractor/releases{/id}","created_at":"2015-06-15T07:59:28Z","updated_at":"2015-06-15T07:59:29Z","pushed_at":"2015-06-15T09:21:09Z","git_url":"git://github.com/alfonso-presa/protractor.git","ssh_url":"git@github.com:alfonso-presa/protractor.git","clone_url":"https://github.com/alfonso-presa/protractor.git","svn_url":"https://github.com/alfonso-presa/protractor","homepage":null,"size":4077,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sjelin:plugin-api","ref":"plugin-api","sha":"5c396e196dfcf9af78dcc9b9ad02513cfaf8ecd9","user":{"login":"sjelin","id":4841675,"avatar_url":"https://avatars.githubusercontent.com/u/4841675?v=3","gravatar_id":"","url":"https://api.github.com/users/sjelin","html_url":"https://github.com/sjelin","followers_url":"https://api.github.com/users/sjelin/followers","following_url":"https://api.github.com/users/sjelin/following{/other_user}","gists_url":"https://api.github.com/users/sjelin/gists{/gist_id}","starred_url":"https://api.github.com/users/sjelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjelin/subscriptions","organizations_url":"https://api.github.com/users/sjelin/orgs","repos_url":"https://api.github.com/users/sjelin/repos","events_url":"https://api.github.com/users/sjelin/events{/privacy}","received_events_url":"https://api.github.com/users/sjelin/received_events","type":"User","site_admin":false},"repo":{"id":25808124,"name":"protractor","full_name":"sjelin/protractor","owner":{"login":"sjelin","id":4841675,"avatar_url":"https://avatars.githubusercontent.com/u/4841675?v=3","gravatar_id":"","url":"https://api.github.com/users/sjelin","html_url":"https://github.com/sjelin","followers_url":"https://api.github.com/users/sjelin/followers","following_url":"https://api.github.com/users/sjelin/following{/other_user}","gists_url":"https://api.github.com/users/sjelin/gists{/gist_id}","starred_url":"https://api.github.com/users/sjelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjelin/subscriptions","organizations_url":"https://api.github.com/users/sjelin/orgs","repos_url":"https://api.github.com/users/sjelin/repos","events_url":"https://api.github.com/users/sjelin/events{/privacy}","received_events_url":"https://api.github.com/users/sjelin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sjelin/protractor","description":"E2E test framework for Angular apps","fork":true,"url":"https://api.github.com/repos/sjelin/protractor","forks_url":"https://api.github.com/repos/sjelin/protractor/forks","keys_url":"https://api.github.com/repos/sjelin/protractor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjelin/protractor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjelin/protractor/teams","hooks_url":"https://api.github.com/repos/sjelin/protractor/hooks","issue_events_url":"https://api.github.com/repos/sjelin/protractor/issues/events{/number}","events_url":"https://api.github.com/repos/sjelin/protractor/events","assignees_url":"https://api.github.com/repos/sjelin/protractor/assignees{/user}","branches_url":"https://api.github.com/repos/sjelin/protractor/branches{/branch}","tags_url":"https://api.github.com/repos/sjelin/protractor/tags","blobs_url":"https://api.github.com/repos/sjelin/protractor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjelin/protractor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjelin/protractor/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjelin/protractor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjelin/protractor/statuses/{sha}","languages_url":"https://api.github.com/repos/sjelin/protractor/languages","stargazers_url":"https://api.github.com/repos/sjelin/protractor/stargazers","contributors_url":"https://api.github.com/repos/sjelin/protractor/contributors","subscribers_url":"https://api.github.com/repos/sjelin/protractor/subscribers","subscription_url":"https://api.github.com/repos/sjelin/protractor/subscription","commits_url":"https://api.github.com/repos/sjelin/protractor/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjelin/protractor/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjelin/protractor/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjelin/protractor/issues/comments{/number}","contents_url":"https://api.github.com/repos/sjelin/protractor/contents/{+path}","compare_url":"https://api.github.com/repos/sjelin/protractor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjelin/protractor/merges","archive_url":"https://api.github.com/repos/sjelin/protractor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjelin/protractor/downloads","issues_url":"https://api.github.com/repos/sjelin/protractor/issues{/number}","pulls_url":"https://api.github.com/repos/sjelin/protractor/pulls{/number}","milestones_url":"https://api.github.com/repos/sjelin/protractor/milestones{/number}","notifications_url":"https://api.github.com/repos/sjelin/protractor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjelin/protractor/labels{/name}","releases_url":"https://api.github.com/repos/sjelin/protractor/releases{/id}","created_at":"2014-10-27T07:39:31Z","updated_at":"2015-03-30T21:15:58Z","pushed_at":"2015-06-15T09:25:20Z","git_url":"git://github.com/sjelin/protractor.git","ssh_url":"git@github.com:sjelin/protractor.git","clone_url":"https://github.com/sjelin/protractor.git","svn_url":"https://github.com/sjelin/protractor","homepage":null,"size":4077,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sjelin/protractor/pulls/1"},"html":{"href":"https://github.com/sjelin/protractor/pull/1"},"issue":{"href":"https://api.github.com/repos/sjelin/protractor/issues/1"},"comments":{"href":"https://api.github.com/repos/sjelin/protractor/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/sjelin/protractor/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/sjelin/protractor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sjelin/protractor/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/sjelin/protractor/statuses/8c5972c93f98b1145a56125845715b7a468f14ef"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":82,"deletions":56,"changed_files":7}}