{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/opendatakit/collect/pulls/4","id":46012005,"html_url":"https://github.com/opendatakit/collect/pull/4","diff_url":"https://github.com/opendatakit/collect/pull/4.diff","patch_url":"https://github.com/opendatakit/collect/pull/4.patch","issue_url":"https://api.github.com/repos/opendatakit/collect/issues/4","number":4,"state":"closed","locked":false,"title":"Added code to protect against NullPointerException in QuestionWidget.","user":{"login":"jkpr","id":3988950,"avatar_url":"https://avatars.githubusercontent.com/u/3988950?v=3","gravatar_id":"","url":"https://api.github.com/users/jkpr","html_url":"https://github.com/jkpr","followers_url":"https://api.github.com/users/jkpr/followers","following_url":"https://api.github.com/users/jkpr/following{/other_user}","gists_url":"https://api.github.com/users/jkpr/gists{/gist_id}","starred_url":"https://api.github.com/users/jkpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkpr/subscriptions","organizations_url":"https://api.github.com/users/jkpr/orgs","repos_url":"https://api.github.com/users/jkpr/repos","events_url":"https://api.github.com/users/jkpr/events{/privacy}","received_events_url":"https://api.github.com/users/jkpr/received_events","type":"User","site_admin":false},"body":"The previous commit  that changed the QuestionWidget class placed code to initialize object member `MediaLayout mediaLayout` in method `addQuestionText`. This method, however is overridden in various widgets, including `LabelWidget`.\r\n\r\nThus later code in the constructor could try to call a method on `null`.\r\n\r\nIn my experience, a question that has appearance::label appearance::list-nolabel produced this runtime error (caught safely in a dialog, but needs fixing).\r\n\r\nP.S. This SO question helped figure out git: http://stackoverflow.com/questions/5256021/send-a-pull-request-on-github-for-only-latest-commit","created_at":"2015-09-25T13:33:08Z","updated_at":"2015-10-27T18:29:47Z","closed_at":"2015-10-27T18:29:47Z","merged_at":null,"merge_commit_sha":"319d95a592afc4e8338667e13a4a7dea203ee56d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opendatakit/collect/pulls/4/commits","review_comments_url":"https://api.github.com/repos/opendatakit/collect/pulls/4/comments","review_comment_url":"https://api.github.com/repos/opendatakit/collect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opendatakit/collect/issues/4/comments","statuses_url":"https://api.github.com/repos/opendatakit/collect/statuses/37f134ac9fd80c0befe0aa7a95bb486a5bb80182","head":{"label":"jkpr:questionWidgetFix2","ref":"questionWidgetFix2","sha":"37f134ac9fd80c0befe0aa7a95bb486a5bb80182","user":{"login":"jkpr","id":3988950,"avatar_url":"https://avatars.githubusercontent.com/u/3988950?v=3","gravatar_id":"","url":"https://api.github.com/users/jkpr","html_url":"https://github.com/jkpr","followers_url":"https://api.github.com/users/jkpr/followers","following_url":"https://api.github.com/users/jkpr/following{/other_user}","gists_url":"https://api.github.com/users/jkpr/gists{/gist_id}","starred_url":"https://api.github.com/users/jkpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkpr/subscriptions","organizations_url":"https://api.github.com/users/jkpr/orgs","repos_url":"https://api.github.com/users/jkpr/repos","events_url":"https://api.github.com/users/jkpr/events{/privacy}","received_events_url":"https://api.github.com/users/jkpr/received_events","type":"User","site_admin":false},"repo":{"id":41040822,"name":"collect-fixed","full_name":"jkpr/collect-fixed","owner":{"login":"jkpr","id":3988950,"avatar_url":"https://avatars.githubusercontent.com/u/3988950?v=3","gravatar_id":"","url":"https://api.github.com/users/jkpr","html_url":"https://github.com/jkpr","followers_url":"https://api.github.com/users/jkpr/followers","following_url":"https://api.github.com/users/jkpr/following{/other_user}","gists_url":"https://api.github.com/users/jkpr/gists{/gist_id}","starred_url":"https://api.github.com/users/jkpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkpr/subscriptions","organizations_url":"https://api.github.com/users/jkpr/orgs","repos_url":"https://api.github.com/users/jkpr/repos","events_url":"https://api.github.com/users/jkpr/events{/privacy}","received_events_url":"https://api.github.com/users/jkpr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jkpr/collect-fixed","description":"Copy of collect with checkin history fixed","fork":true,"url":"https://api.github.com/repos/jkpr/collect-fixed","forks_url":"https://api.github.com/repos/jkpr/collect-fixed/forks","keys_url":"https://api.github.com/repos/jkpr/collect-fixed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jkpr/collect-fixed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jkpr/collect-fixed/teams","hooks_url":"https://api.github.com/repos/jkpr/collect-fixed/hooks","issue_events_url":"https://api.github.com/repos/jkpr/collect-fixed/issues/events{/number}","events_url":"https://api.github.com/repos/jkpr/collect-fixed/events","assignees_url":"https://api.github.com/repos/jkpr/collect-fixed/assignees{/user}","branches_url":"https://api.github.com/repos/jkpr/collect-fixed/branches{/branch}","tags_url":"https://api.github.com/repos/jkpr/collect-fixed/tags","blobs_url":"https://api.github.com/repos/jkpr/collect-fixed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jkpr/collect-fixed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jkpr/collect-fixed/git/refs{/sha}","trees_url":"https://api.github.com/repos/jkpr/collect-fixed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jkpr/collect-fixed/statuses/{sha}","languages_url":"https://api.github.com/repos/jkpr/collect-fixed/languages","stargazers_url":"https://api.github.com/repos/jkpr/collect-fixed/stargazers","contributors_url":"https://api.github.com/repos/jkpr/collect-fixed/contributors","subscribers_url":"https://api.github.com/repos/jkpr/collect-fixed/subscribers","subscription_url":"https://api.github.com/repos/jkpr/collect-fixed/subscription","commits_url":"https://api.github.com/repos/jkpr/collect-fixed/commits{/sha}","git_commits_url":"https://api.github.com/repos/jkpr/collect-fixed/git/commits{/sha}","comments_url":"https://api.github.com/repos/jkpr/collect-fixed/comments{/number}","issue_comment_url":"https://api.github.com/repos/jkpr/collect-fixed/issues/comments{/number}","contents_url":"https://api.github.com/repos/jkpr/collect-fixed/contents/{+path}","compare_url":"https://api.github.com/repos/jkpr/collect-fixed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jkpr/collect-fixed/merges","archive_url":"https://api.github.com/repos/jkpr/collect-fixed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jkpr/collect-fixed/downloads","issues_url":"https://api.github.com/repos/jkpr/collect-fixed/issues{/number}","pulls_url":"https://api.github.com/repos/jkpr/collect-fixed/pulls{/number}","milestones_url":"https://api.github.com/repos/jkpr/collect-fixed/milestones{/number}","notifications_url":"https://api.github.com/repos/jkpr/collect-fixed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jkpr/collect-fixed/labels{/name}","releases_url":"https://api.github.com/repos/jkpr/collect-fixed/releases{/id}","created_at":"2015-08-19T14:54:34Z","updated_at":"2015-08-19T14:54:36Z","pushed_at":"2015-09-25T13:28:07Z","git_url":"git://github.com/jkpr/collect-fixed.git","ssh_url":"git@github.com:jkpr/collect-fixed.git","clone_url":"https://github.com/jkpr/collect-fixed.git","svn_url":"https://github.com/jkpr/collect-fixed","homepage":"https://github.com/opendatakit/opendatakit","size":23799,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opendatakit:master","ref":"master","sha":"833147c110d90ea8ade745c7464215e87d935ec8","user":{"login":"opendatakit","id":6222985,"avatar_url":"https://avatars.githubusercontent.com/u/6222985?v=3","gravatar_id":"","url":"https://api.github.com/users/opendatakit","html_url":"https://github.com/opendatakit","followers_url":"https://api.github.com/users/opendatakit/followers","following_url":"https://api.github.com/users/opendatakit/following{/other_user}","gists_url":"https://api.github.com/users/opendatakit/gists{/gist_id}","starred_url":"https://api.github.com/users/opendatakit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opendatakit/subscriptions","organizations_url":"https://api.github.com/users/opendatakit/orgs","repos_url":"https://api.github.com/users/opendatakit/repos","events_url":"https://api.github.com/users/opendatakit/events{/privacy}","received_events_url":"https://api.github.com/users/opendatakit/received_events","type":"Organization","site_admin":false},"repo":{"id":40213809,"name":"collect","full_name":"opendatakit/collect","owner":{"login":"opendatakit","id":6222985,"avatar_url":"https://avatars.githubusercontent.com/u/6222985?v=3","gravatar_id":"","url":"https://api.github.com/users/opendatakit","html_url":"https://github.com/opendatakit","followers_url":"https://api.github.com/users/opendatakit/followers","following_url":"https://api.github.com/users/opendatakit/following{/other_user}","gists_url":"https://api.github.com/users/opendatakit/gists{/gist_id}","starred_url":"https://api.github.com/users/opendatakit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opendatakit/subscriptions","organizations_url":"https://api.github.com/users/opendatakit/orgs","repos_url":"https://api.github.com/users/opendatakit/repos","events_url":"https://api.github.com/users/opendatakit/events{/privacy}","received_events_url":"https://api.github.com/users/opendatakit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opendatakit/collect","description":"Copy of collect with checkin history fixed","fork":false,"url":"https://api.github.com/repos/opendatakit/collect","forks_url":"https://api.github.com/repos/opendatakit/collect/forks","keys_url":"https://api.github.com/repos/opendatakit/collect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opendatakit/collect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opendatakit/collect/teams","hooks_url":"https://api.github.com/repos/opendatakit/collect/hooks","issue_events_url":"https://api.github.com/repos/opendatakit/collect/issues/events{/number}","events_url":"https://api.github.com/repos/opendatakit/collect/events","assignees_url":"https://api.github.com/repos/opendatakit/collect/assignees{/user}","branches_url":"https://api.github.com/repos/opendatakit/collect/branches{/branch}","tags_url":"https://api.github.com/repos/opendatakit/collect/tags","blobs_url":"https://api.github.com/repos/opendatakit/collect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opendatakit/collect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opendatakit/collect/git/refs{/sha}","trees_url":"https://api.github.com/repos/opendatakit/collect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opendatakit/collect/statuses/{sha}","languages_url":"https://api.github.com/repos/opendatakit/collect/languages","stargazers_url":"https://api.github.com/repos/opendatakit/collect/stargazers","contributors_url":"https://api.github.com/repos/opendatakit/collect/contributors","subscribers_url":"https://api.github.com/repos/opendatakit/collect/subscribers","subscription_url":"https://api.github.com/repos/opendatakit/collect/subscription","commits_url":"https://api.github.com/repos/opendatakit/collect/commits{/sha}","git_commits_url":"https://api.github.com/repos/opendatakit/collect/git/commits{/sha}","comments_url":"https://api.github.com/repos/opendatakit/collect/comments{/number}","issue_comment_url":"https://api.github.com/repos/opendatakit/collect/issues/comments{/number}","contents_url":"https://api.github.com/repos/opendatakit/collect/contents/{+path}","compare_url":"https://api.github.com/repos/opendatakit/collect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opendatakit/collect/merges","archive_url":"https://api.github.com/repos/opendatakit/collect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opendatakit/collect/downloads","issues_url":"https://api.github.com/repos/opendatakit/collect/issues{/number}","pulls_url":"https://api.github.com/repos/opendatakit/collect/pulls{/number}","milestones_url":"https://api.github.com/repos/opendatakit/collect/milestones{/number}","notifications_url":"https://api.github.com/repos/opendatakit/collect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opendatakit/collect/labels{/name}","releases_url":"https://api.github.com/repos/opendatakit/collect/releases{/id}","created_at":"2015-08-04T23:21:33Z","updated_at":"2015-10-07T14:57:08Z","pushed_at":"2015-10-23T09:05:25Z","git_url":"git://github.com/opendatakit/collect.git","ssh_url":"git@github.com:opendatakit/collect.git","clone_url":"https://github.com/opendatakit/collect.git","svn_url":"https://github.com/opendatakit/collect","homepage":"https://github.com/opendatakit/opendatakit","size":28019,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":1,"forks":20,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opendatakit/collect/pulls/4"},"html":{"href":"https://github.com/opendatakit/collect/pull/4"},"issue":{"href":"https://api.github.com/repos/opendatakit/collect/issues/4"},"comments":{"href":"https://api.github.com/repos/opendatakit/collect/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/opendatakit/collect/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/opendatakit/collect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opendatakit/collect/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/opendatakit/collect/statuses/37f134ac9fd80c0befe0aa7a95bb486a5bb80182"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":11,"deletions":5,"changed_files":1}}