{"action":"closed","number":77,"pull_request":{"url":"https://api.github.com/repos/googollee/go-socket.io/pulls/77","id":32683524,"html_url":"https://github.com/googollee/go-socket.io/pull/77","diff_url":"https://github.com/googollee/go-socket.io/pull/77.diff","patch_url":"https://github.com/googollee/go-socket.io/pull/77.patch","issue_url":"https://api.github.com/repos/googollee/go-socket.io/issues/77","number":77,"state":"closed","locked":false,"title":"fixes #48 close the open chanel before waiting for nextReader","user":{"login":"woodsaj","id":8415072,"avatar_url":"https://avatars.githubusercontent.com/u/8415072?v=3","gravatar_id":"","url":"https://api.github.com/users/woodsaj","html_url":"https://github.com/woodsaj","followers_url":"https://api.github.com/users/woodsaj/followers","following_url":"https://api.github.com/users/woodsaj/following{/other_user}","gists_url":"https://api.github.com/users/woodsaj/gists{/gist_id}","starred_url":"https://api.github.com/users/woodsaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woodsaj/subscriptions","organizations_url":"https://api.github.com/users/woodsaj/orgs","repos_url":"https://api.github.com/users/woodsaj/repos","events_url":"https://api.github.com/users/woodsaj/events{/privacy}","received_events_url":"https://api.github.com/users/woodsaj/received_events","type":"User","site_admin":false},"body":"When sending Binary data, the socket.io client strips the binary\r\ndata from the frame and replaces it with a numbered _placeholder.\r\nOnce the placeholder frame is ack'ed the client sends another\r\nframe with the binary data.  Without this fix go-socket.io never\r\nacks the placeholder frame and so waits indefinitely for the data\r\nframe.","created_at":"2015-04-06T14:56:54Z","updated_at":"2015-06-03T15:38:38Z","closed_at":"2015-06-03T15:38:38Z","merged_at":"2015-06-03T15:38:38Z","merge_commit_sha":"f143d119b29aceda5313525c4d9c86c861c2ba4e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/googollee/go-socket.io/pulls/77/commits","review_comments_url":"https://api.github.com/repos/googollee/go-socket.io/pulls/77/comments","review_comment_url":"https://api.github.com/repos/googollee/go-socket.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googollee/go-socket.io/issues/77/comments","statuses_url":"https://api.github.com/repos/googollee/go-socket.io/statuses/2a8532d68ee77d0cce9dcfaf9ec8fb6eb9a7c62e","head":{"label":"woodsaj:binarySupport","ref":"binarySupport","sha":"2a8532d68ee77d0cce9dcfaf9ec8fb6eb9a7c62e","user":{"login":"woodsaj","id":8415072,"avatar_url":"https://avatars.githubusercontent.com/u/8415072?v=3","gravatar_id":"","url":"https://api.github.com/users/woodsaj","html_url":"https://github.com/woodsaj","followers_url":"https://api.github.com/users/woodsaj/followers","following_url":"https://api.github.com/users/woodsaj/following{/other_user}","gists_url":"https://api.github.com/users/woodsaj/gists{/gist_id}","starred_url":"https://api.github.com/users/woodsaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woodsaj/subscriptions","organizations_url":"https://api.github.com/users/woodsaj/orgs","repos_url":"https://api.github.com/users/woodsaj/repos","events_url":"https://api.github.com/users/woodsaj/events{/privacy}","received_events_url":"https://api.github.com/users/woodsaj/received_events","type":"User","site_admin":false},"repo":{"id":33486407,"name":"go-socket.io","full_name":"woodsaj/go-socket.io","owner":{"login":"woodsaj","id":8415072,"avatar_url":"https://avatars.githubusercontent.com/u/8415072?v=3","gravatar_id":"","url":"https://api.github.com/users/woodsaj","html_url":"https://github.com/woodsaj","followers_url":"https://api.github.com/users/woodsaj/followers","following_url":"https://api.github.com/users/woodsaj/following{/other_user}","gists_url":"https://api.github.com/users/woodsaj/gists{/gist_id}","starred_url":"https://api.github.com/users/woodsaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woodsaj/subscriptions","organizations_url":"https://api.github.com/users/woodsaj/orgs","repos_url":"https://api.github.com/users/woodsaj/repos","events_url":"https://api.github.com/users/woodsaj/events{/privacy}","received_events_url":"https://api.github.com/users/woodsaj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/woodsaj/go-socket.io","description":"socket.io library for golang, a realtime application framework.","fork":true,"url":"https://api.github.com/repos/woodsaj/go-socket.io","forks_url":"https://api.github.com/repos/woodsaj/go-socket.io/forks","keys_url":"https://api.github.com/repos/woodsaj/go-socket.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woodsaj/go-socket.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woodsaj/go-socket.io/teams","hooks_url":"https://api.github.com/repos/woodsaj/go-socket.io/hooks","issue_events_url":"https://api.github.com/repos/woodsaj/go-socket.io/issues/events{/number}","events_url":"https://api.github.com/repos/woodsaj/go-socket.io/events","assignees_url":"https://api.github.com/repos/woodsaj/go-socket.io/assignees{/user}","branches_url":"https://api.github.com/repos/woodsaj/go-socket.io/branches{/branch}","tags_url":"https://api.github.com/repos/woodsaj/go-socket.io/tags","blobs_url":"https://api.github.com/repos/woodsaj/go-socket.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woodsaj/go-socket.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woodsaj/go-socket.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/woodsaj/go-socket.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woodsaj/go-socket.io/statuses/{sha}","languages_url":"https://api.github.com/repos/woodsaj/go-socket.io/languages","stargazers_url":"https://api.github.com/repos/woodsaj/go-socket.io/stargazers","contributors_url":"https://api.github.com/repos/woodsaj/go-socket.io/contributors","subscribers_url":"https://api.github.com/repos/woodsaj/go-socket.io/subscribers","subscription_url":"https://api.github.com/repos/woodsaj/go-socket.io/subscription","commits_url":"https://api.github.com/repos/woodsaj/go-socket.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/woodsaj/go-socket.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/woodsaj/go-socket.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/woodsaj/go-socket.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/woodsaj/go-socket.io/contents/{+path}","compare_url":"https://api.github.com/repos/woodsaj/go-socket.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woodsaj/go-socket.io/merges","archive_url":"https://api.github.com/repos/woodsaj/go-socket.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woodsaj/go-socket.io/downloads","issues_url":"https://api.github.com/repos/woodsaj/go-socket.io/issues{/number}","pulls_url":"https://api.github.com/repos/woodsaj/go-socket.io/pulls{/number}","milestones_url":"https://api.github.com/repos/woodsaj/go-socket.io/milestones{/number}","notifications_url":"https://api.github.com/repos/woodsaj/go-socket.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woodsaj/go-socket.io/labels{/name}","releases_url":"https://api.github.com/repos/woodsaj/go-socket.io/releases{/id}","created_at":"2015-04-06T14:33:42Z","updated_at":"2015-04-06T14:33:42Z","pushed_at":"2015-04-06T14:56:08Z","git_url":"git://github.com/woodsaj/go-socket.io.git","ssh_url":"git@github.com:woodsaj/go-socket.io.git","clone_url":"https://github.com/woodsaj/go-socket.io.git","svn_url":"https://github.com/woodsaj/go-socket.io","homepage":"","size":10338,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googollee:master","ref":"master","sha":"31886c5636253259f3c028ee398e780d2b1d1696","user":{"login":"googollee","id":496526,"avatar_url":"https://avatars.githubusercontent.com/u/496526?v=3","gravatar_id":"","url":"https://api.github.com/users/googollee","html_url":"https://github.com/googollee","followers_url":"https://api.github.com/users/googollee/followers","following_url":"https://api.github.com/users/googollee/following{/other_user}","gists_url":"https://api.github.com/users/googollee/gists{/gist_id}","starred_url":"https://api.github.com/users/googollee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googollee/subscriptions","organizations_url":"https://api.github.com/users/googollee/orgs","repos_url":"https://api.github.com/users/googollee/repos","events_url":"https://api.github.com/users/googollee/events{/privacy}","received_events_url":"https://api.github.com/users/googollee/received_events","type":"User","site_admin":false},"repo":{"id":11388110,"name":"go-socket.io","full_name":"googollee/go-socket.io","owner":{"login":"googollee","id":496526,"avatar_url":"https://avatars.githubusercontent.com/u/496526?v=3","gravatar_id":"","url":"https://api.github.com/users/googollee","html_url":"https://github.com/googollee","followers_url":"https://api.github.com/users/googollee/followers","following_url":"https://api.github.com/users/googollee/following{/other_user}","gists_url":"https://api.github.com/users/googollee/gists{/gist_id}","starred_url":"https://api.github.com/users/googollee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googollee/subscriptions","organizations_url":"https://api.github.com/users/googollee/orgs","repos_url":"https://api.github.com/users/googollee/repos","events_url":"https://api.github.com/users/googollee/events{/privacy}","received_events_url":"https://api.github.com/users/googollee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/googollee/go-socket.io","description":"socket.io library for golang, a realtime application framework.","fork":false,"url":"https://api.github.com/repos/googollee/go-socket.io","forks_url":"https://api.github.com/repos/googollee/go-socket.io/forks","keys_url":"https://api.github.com/repos/googollee/go-socket.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googollee/go-socket.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googollee/go-socket.io/teams","hooks_url":"https://api.github.com/repos/googollee/go-socket.io/hooks","issue_events_url":"https://api.github.com/repos/googollee/go-socket.io/issues/events{/number}","events_url":"https://api.github.com/repos/googollee/go-socket.io/events","assignees_url":"https://api.github.com/repos/googollee/go-socket.io/assignees{/user}","branches_url":"https://api.github.com/repos/googollee/go-socket.io/branches{/branch}","tags_url":"https://api.github.com/repos/googollee/go-socket.io/tags","blobs_url":"https://api.github.com/repos/googollee/go-socket.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googollee/go-socket.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googollee/go-socket.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/googollee/go-socket.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googollee/go-socket.io/statuses/{sha}","languages_url":"https://api.github.com/repos/googollee/go-socket.io/languages","stargazers_url":"https://api.github.com/repos/googollee/go-socket.io/stargazers","contributors_url":"https://api.github.com/repos/googollee/go-socket.io/contributors","subscribers_url":"https://api.github.com/repos/googollee/go-socket.io/subscribers","subscription_url":"https://api.github.com/repos/googollee/go-socket.io/subscription","commits_url":"https://api.github.com/repos/googollee/go-socket.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/googollee/go-socket.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/googollee/go-socket.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/googollee/go-socket.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/googollee/go-socket.io/contents/{+path}","compare_url":"https://api.github.com/repos/googollee/go-socket.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googollee/go-socket.io/merges","archive_url":"https://api.github.com/repos/googollee/go-socket.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googollee/go-socket.io/downloads","issues_url":"https://api.github.com/repos/googollee/go-socket.io/issues{/number}","pulls_url":"https://api.github.com/repos/googollee/go-socket.io/pulls{/number}","milestones_url":"https://api.github.com/repos/googollee/go-socket.io/milestones{/number}","notifications_url":"https://api.github.com/repos/googollee/go-socket.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googollee/go-socket.io/labels{/name}","releases_url":"https://api.github.com/repos/googollee/go-socket.io/releases{/id}","created_at":"2013-07-13T13:04:38Z","updated_at":"2015-06-01T14:42:24Z","pushed_at":"2015-06-03T15:38:38Z","git_url":"git://github.com/googollee/go-socket.io.git","ssh_url":"git@github.com:googollee/go-socket.io.git","clone_url":"https://github.com/googollee/go-socket.io.git","svn_url":"https://github.com/googollee/go-socket.io","homepage":"","size":10898,"stargazers_count":672,"watchers_count":672,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"open_issues_count":23,"forks":103,"open_issues":23,"watchers":672,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googollee/go-socket.io/pulls/77"},"html":{"href":"https://github.com/googollee/go-socket.io/pull/77"},"issue":{"href":"https://api.github.com/repos/googollee/go-socket.io/issues/77"},"comments":{"href":"https://api.github.com/repos/googollee/go-socket.io/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/googollee/go-socket.io/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/googollee/go-socket.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googollee/go-socket.io/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/googollee/go-socket.io/statuses/2a8532d68ee77d0cce9dcfaf9ec8fb6eb9a7c62e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"googollee","id":496526,"avatar_url":"https://avatars.githubusercontent.com/u/496526?v=3","gravatar_id":"","url":"https://api.github.com/users/googollee","html_url":"https://github.com/googollee","followers_url":"https://api.github.com/users/googollee/followers","following_url":"https://api.github.com/users/googollee/following{/other_user}","gists_url":"https://api.github.com/users/googollee/gists{/gist_id}","starred_url":"https://api.github.com/users/googollee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googollee/subscriptions","organizations_url":"https://api.github.com/users/googollee/orgs","repos_url":"https://api.github.com/users/googollee/repos","events_url":"https://api.github.com/users/googollee/events{/privacy}","received_events_url":"https://api.github.com/users/googollee/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":0,"changed_files":1}}