{"action":"created","comment":{"url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments/34674258","id":34674258,"diff_hunk":"@@ -0,0 +1,36 @@\n+/**\n+ * Copyright 2015 DuraSpace, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.fcrepo.kernel.exception;\n+\n+/**\n+ * This exception is used for invalid resource identifiers, such as when a resource path has empty segments.\n+ *\n+ * @author awoods\n+ * @since July 14, 2015\n+ */\n+public class InvalidResourceIdentifierException extends RepositoryRuntimeException {","path":"fcrepo-kernel/src/main/java/org/fcrepo/kernel/exception/InvalidResourceIdentifierException.java","position":24,"original_position":24,"commit_id":"a2f9f79d755414d959198cd1b1d192bd4309216a","original_commit_id":"a2f9f79d755414d959198cd1b1d192bd4309216a","user":{"login":"ajs6f","id":110994,"avatar_url":"https://avatars.githubusercontent.com/u/110994?v=3","gravatar_id":"","url":"https://api.github.com/users/ajs6f","html_url":"https://github.com/ajs6f","followers_url":"https://api.github.com/users/ajs6f/followers","following_url":"https://api.github.com/users/ajs6f/following{/other_user}","gists_url":"https://api.github.com/users/ajs6f/gists{/gist_id}","starred_url":"https://api.github.com/users/ajs6f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajs6f/subscriptions","organizations_url":"https://api.github.com/users/ajs6f/orgs","repos_url":"https://api.github.com/users/ajs6f/repos","events_url":"https://api.github.com/users/ajs6f/events{/privacy}","received_events_url":"https://api.github.com/users/ajs6f/received_events","type":"User","site_admin":false},"body":"So this is specifically distinct from when the identifier is valid, but there is no such resource? You might want to add that as a comment. Also, you might want to remark that the notion of validity will depend on the `IdentifierConverter` chain in use.","created_at":"2015-07-15T12:53:50Z","updated_at":"2015-07-15T12:53:50Z","html_url":"https://github.com/fcrepo4/fcrepo4/pull/840#discussion_r34674258","pull_request_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/840","_links":{"self":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments/34674258"},"html":{"href":"https://github.com/fcrepo4/fcrepo4/pull/840#discussion_r34674258"},"pull_request":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/840"}}},"pull_request":{"url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/840","id":39962381,"html_url":"https://github.com/fcrepo4/fcrepo4/pull/840","diff_url":"https://github.com/fcrepo4/fcrepo4/pull/840.diff","patch_url":"https://github.com/fcrepo4/fcrepo4/pull/840.patch","issue_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/840","number":840,"state":"open","locked":false,"title":"Respond with 400 status on request with empty path segments","user":{"login":"awoods","id":149283,"avatar_url":"https://avatars.githubusercontent.com/u/149283?v=3","gravatar_id":"","url":"https://api.github.com/users/awoods","html_url":"https://github.com/awoods","followers_url":"https://api.github.com/users/awoods/followers","following_url":"https://api.github.com/users/awoods/following{/other_user}","gists_url":"https://api.github.com/users/awoods/gists{/gist_id}","starred_url":"https://api.github.com/users/awoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awoods/subscriptions","organizations_url":"https://api.github.com/users/awoods/orgs","repos_url":"https://api.github.com/users/awoods/repos","events_url":"https://api.github.com/users/awoods/events{/privacy}","received_events_url":"https://api.github.com/users/awoods/received_events","type":"User","site_admin":false},"body":"Resolves: https://jira.duraspace.org/browse/FCREPO-1537","created_at":"2015-07-14T21:03:21Z","updated_at":"2015-07-15T12:53:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbd08b4948c9ee2f5e59068f57b40973c7a6755e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/840/commits","review_comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/840/comments","review_comment_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/840/comments","statuses_url":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/a2f9f79d755414d959198cd1b1d192bd4309216a","head":{"label":"awoods:fcrepo-1537","ref":"fcrepo-1537","sha":"a2f9f79d755414d959198cd1b1d192bd4309216a","user":{"login":"awoods","id":149283,"avatar_url":"https://avatars.githubusercontent.com/u/149283?v=3","gravatar_id":"","url":"https://api.github.com/users/awoods","html_url":"https://github.com/awoods","followers_url":"https://api.github.com/users/awoods/followers","following_url":"https://api.github.com/users/awoods/following{/other_user}","gists_url":"https://api.github.com/users/awoods/gists{/gist_id}","starred_url":"https://api.github.com/users/awoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awoods/subscriptions","organizations_url":"https://api.github.com/users/awoods/orgs","repos_url":"https://api.github.com/users/awoods/repos","events_url":"https://api.github.com/users/awoods/events{/privacy}","received_events_url":"https://api.github.com/users/awoods/received_events","type":"User","site_admin":false},"repo":{"id":16359093,"name":"fcrepo4","full_name":"awoods/fcrepo4","owner":{"login":"awoods","id":149283,"avatar_url":"https://avatars.githubusercontent.com/u/149283?v=3","gravatar_id":"","url":"https://api.github.com/users/awoods","html_url":"https://github.com/awoods","followers_url":"https://api.github.com/users/awoods/followers","following_url":"https://api.github.com/users/awoods/following{/other_user}","gists_url":"https://api.github.com/users/awoods/gists{/gist_id}","starred_url":"https://api.github.com/users/awoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awoods/subscriptions","organizations_url":"https://api.github.com/users/awoods/orgs","repos_url":"https://api.github.com/users/awoods/repos","events_url":"https://api.github.com/users/awoods/events{/privacy}","received_events_url":"https://api.github.com/users/awoods/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/awoods/fcrepo4","description":"Fedora 4: \"Changing everything, two weeks at a time\"","fork":true,"url":"https://api.github.com/repos/awoods/fcrepo4","forks_url":"https://api.github.com/repos/awoods/fcrepo4/forks","keys_url":"https://api.github.com/repos/awoods/fcrepo4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awoods/fcrepo4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awoods/fcrepo4/teams","hooks_url":"https://api.github.com/repos/awoods/fcrepo4/hooks","issue_events_url":"https://api.github.com/repos/awoods/fcrepo4/issues/events{/number}","events_url":"https://api.github.com/repos/awoods/fcrepo4/events","assignees_url":"https://api.github.com/repos/awoods/fcrepo4/assignees{/user}","branches_url":"https://api.github.com/repos/awoods/fcrepo4/branches{/branch}","tags_url":"https://api.github.com/repos/awoods/fcrepo4/tags","blobs_url":"https://api.github.com/repos/awoods/fcrepo4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awoods/fcrepo4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awoods/fcrepo4/git/refs{/sha}","trees_url":"https://api.github.com/repos/awoods/fcrepo4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awoods/fcrepo4/statuses/{sha}","languages_url":"https://api.github.com/repos/awoods/fcrepo4/languages","stargazers_url":"https://api.github.com/repos/awoods/fcrepo4/stargazers","contributors_url":"https://api.github.com/repos/awoods/fcrepo4/contributors","subscribers_url":"https://api.github.com/repos/awoods/fcrepo4/subscribers","subscription_url":"https://api.github.com/repos/awoods/fcrepo4/subscription","commits_url":"https://api.github.com/repos/awoods/fcrepo4/commits{/sha}","git_commits_url":"https://api.github.com/repos/awoods/fcrepo4/git/commits{/sha}","comments_url":"https://api.github.com/repos/awoods/fcrepo4/comments{/number}","issue_comment_url":"https://api.github.com/repos/awoods/fcrepo4/issues/comments{/number}","contents_url":"https://api.github.com/repos/awoods/fcrepo4/contents/{+path}","compare_url":"https://api.github.com/repos/awoods/fcrepo4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awoods/fcrepo4/merges","archive_url":"https://api.github.com/repos/awoods/fcrepo4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awoods/fcrepo4/downloads","issues_url":"https://api.github.com/repos/awoods/fcrepo4/issues{/number}","pulls_url":"https://api.github.com/repos/awoods/fcrepo4/pulls{/number}","milestones_url":"https://api.github.com/repos/awoods/fcrepo4/milestones{/number}","notifications_url":"https://api.github.com/repos/awoods/fcrepo4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awoods/fcrepo4/labels{/name}","releases_url":"https://api.github.com/repos/awoods/fcrepo4/releases{/id}","created_at":"2014-01-29T21:07:10Z","updated_at":"2015-04-16T20:30:47Z","pushed_at":"2015-07-14T21:02:15Z","git_url":"git://github.com/awoods/fcrepo4.git","ssh_url":"git@github.com:awoods/fcrepo4.git","clone_url":"https://github.com/awoods/fcrepo4.git","svn_url":"https://github.com/awoods/fcrepo4","homepage":"http://futures.github.com/fcrepo4/","size":44148,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fcrepo4:master","ref":"master","sha":"7141787b9cb139471ba081a42062509be8b24343","user":{"login":"fcrepo4","id":3057565,"avatar_url":"https://avatars.githubusercontent.com/u/3057565?v=3","gravatar_id":"","url":"https://api.github.com/users/fcrepo4","html_url":"https://github.com/fcrepo4","followers_url":"https://api.github.com/users/fcrepo4/followers","following_url":"https://api.github.com/users/fcrepo4/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo4/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo4/subscriptions","organizations_url":"https://api.github.com/users/fcrepo4/orgs","repos_url":"https://api.github.com/users/fcrepo4/repos","events_url":"https://api.github.com/users/fcrepo4/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo4/received_events","type":"Organization","site_admin":false},"repo":{"id":7992797,"name":"fcrepo4","full_name":"fcrepo4/fcrepo4","owner":{"login":"fcrepo4","id":3057565,"avatar_url":"https://avatars.githubusercontent.com/u/3057565?v=3","gravatar_id":"","url":"https://api.github.com/users/fcrepo4","html_url":"https://github.com/fcrepo4","followers_url":"https://api.github.com/users/fcrepo4/followers","following_url":"https://api.github.com/users/fcrepo4/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo4/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo4/subscriptions","organizations_url":"https://api.github.com/users/fcrepo4/orgs","repos_url":"https://api.github.com/users/fcrepo4/repos","events_url":"https://api.github.com/users/fcrepo4/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fcrepo4/fcrepo4","description":"Fedora 4","fork":false,"url":"https://api.github.com/repos/fcrepo4/fcrepo4","forks_url":"https://api.github.com/repos/fcrepo4/fcrepo4/forks","keys_url":"https://api.github.com/repos/fcrepo4/fcrepo4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fcrepo4/fcrepo4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fcrepo4/fcrepo4/teams","hooks_url":"https://api.github.com/repos/fcrepo4/fcrepo4/hooks","issue_events_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/events{/number}","events_url":"https://api.github.com/repos/fcrepo4/fcrepo4/events","assignees_url":"https://api.github.com/repos/fcrepo4/fcrepo4/assignees{/user}","branches_url":"https://api.github.com/repos/fcrepo4/fcrepo4/branches{/branch}","tags_url":"https://api.github.com/repos/fcrepo4/fcrepo4/tags","blobs_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/refs{/sha}","trees_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/{sha}","languages_url":"https://api.github.com/repos/fcrepo4/fcrepo4/languages","stargazers_url":"https://api.github.com/repos/fcrepo4/fcrepo4/stargazers","contributors_url":"https://api.github.com/repos/fcrepo4/fcrepo4/contributors","subscribers_url":"https://api.github.com/repos/fcrepo4/fcrepo4/subscribers","subscription_url":"https://api.github.com/repos/fcrepo4/fcrepo4/subscription","commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/commits{/sha}","git_commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/commits{/sha}","comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/comments{/number}","issue_comment_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/comments{/number}","contents_url":"https://api.github.com/repos/fcrepo4/fcrepo4/contents/{+path}","compare_url":"https://api.github.com/repos/fcrepo4/fcrepo4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fcrepo4/fcrepo4/merges","archive_url":"https://api.github.com/repos/fcrepo4/fcrepo4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fcrepo4/fcrepo4/downloads","issues_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues{/number}","pulls_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls{/number}","milestones_url":"https://api.github.com/repos/fcrepo4/fcrepo4/milestones{/number}","notifications_url":"https://api.github.com/repos/fcrepo4/fcrepo4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fcrepo4/fcrepo4/labels{/name}","releases_url":"https://api.github.com/repos/fcrepo4/fcrepo4/releases{/id}","created_at":"2013-02-03T16:18:55Z","updated_at":"2015-07-12T10:44:06Z","pushed_at":"2015-07-14T21:03:21Z","git_url":"git://github.com/fcrepo4/fcrepo4.git","ssh_url":"git@github.com:fcrepo4/fcrepo4.git","clone_url":"https://github.com/fcrepo4/fcrepo4.git","svn_url":"https://github.com/fcrepo4/fcrepo4","homepage":"http://github.com/fcrepo4/fcrepo4","size":136845,"stargazers_count":51,"watchers_count":51,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":70,"mirror_url":null,"open_issues_count":45,"forks":70,"open_issues":45,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/840"},"html":{"href":"https://github.com/fcrepo4/fcrepo4/pull/840"},"issue":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/840"},"comments":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/840/comments"},"review_comments":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/840/comments"},"review_comment":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/840/commits"},"statuses":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/a2f9f79d755414d959198cd1b1d192bd4309216a"}}}}