{"action":"created","comment":{"url":"https://api.github.com/repos/lift/framework/pulls/comments/38262825","id":38262825,"diff_hunk":"@@ -59,6 +59,11 @@ object ExtractionBugs extends Specification {\n     json.extract[Response] mustEqual Response(List(Map(\"one\" -> 1, \"two\" -> 2)))\n   }\n \n+  \"Extracting List[Option[String]]\" in {","path":"core/json/src/test/scala/net/liftweb/json/ExtractionBugs.scala","position":4,"original_position":4,"commit_id":"9894baf60be18ebdb1c3704b7a2a007549a29c86","original_commit_id":"9894baf60be18ebdb1c3704b7a2a007549a29c86","user":{"login":"farmdawgnation","id":620189,"avatar_url":"https://avatars.githubusercontent.com/u/620189?v=3","gravatar_id":"","url":"https://api.github.com/users/farmdawgnation","html_url":"https://github.com/farmdawgnation","followers_url":"https://api.github.com/users/farmdawgnation/followers","following_url":"https://api.github.com/users/farmdawgnation/following{/other_user}","gists_url":"https://api.github.com/users/farmdawgnation/gists{/gist_id}","starred_url":"https://api.github.com/users/farmdawgnation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farmdawgnation/subscriptions","organizations_url":"https://api.github.com/users/farmdawgnation/orgs","repos_url":"https://api.github.com/users/farmdawgnation/repos","events_url":"https://api.github.com/users/farmdawgnation/events{/privacy}","received_events_url":"https://api.github.com/users/farmdawgnation/received_events","type":"User","site_admin":false},"body":"Ah.","created_at":"2015-08-29T14:58:00Z","updated_at":"2015-08-29T14:58:00Z","html_url":"https://github.com/lift/framework/pull/1717#discussion_r38262825","pull_request_url":"https://api.github.com/repos/lift/framework/pulls/1717","_links":{"self":{"href":"https://api.github.com/repos/lift/framework/pulls/comments/38262825"},"html":{"href":"https://github.com/lift/framework/pull/1717#discussion_r38262825"},"pull_request":{"href":"https://api.github.com/repos/lift/framework/pulls/1717"}}},"pull_request":{"url":"https://api.github.com/repos/lift/framework/pulls/1717","id":43694955,"html_url":"https://github.com/lift/framework/pull/1717","diff_url":"https://github.com/lift/framework/pull/1717.diff","patch_url":"https://github.com/lift/framework/pull/1717.patch","issue_url":"https://api.github.com/repos/lift/framework/issues/1717","number":1717,"state":"open","locked":false,"title":"Special case Option intermediary type in extraction.","user":{"login":"farmdawgnation","id":620189,"avatar_url":"https://avatars.githubusercontent.com/u/620189?v=3","gravatar_id":"","url":"https://api.github.com/users/farmdawgnation","html_url":"https://github.com/farmdawgnation","followers_url":"https://api.github.com/users/farmdawgnation/followers","following_url":"https://api.github.com/users/farmdawgnation/following{/other_user}","gists_url":"https://api.github.com/users/farmdawgnation/gists{/gist_id}","starred_url":"https://api.github.com/users/farmdawgnation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farmdawgnation/subscriptions","organizations_url":"https://api.github.com/users/farmdawgnation/orgs","repos_url":"https://api.github.com/users/farmdawgnation/repos","events_url":"https://api.github.com/users/farmdawgnation/events{/privacy}","received_events_url":"https://api.github.com/users/farmdawgnation/received_events","type":"User","site_admin":false},"body":"This PR resolves a long-standing bug where trying to execute extraction when `Option` was an intermediary type on a `List` would cause fireworks and explosions. So, for example if you tried something like the following:\r\n\r\n```scala\r\nval json = JsonParser.parse(\"\"\"[\"one\", \"two\", null]\"\"\")\r\njson.extract[List[Option[String]]]\r\n```\r\n\r\nYou would get explosions and fireworks because lift-json would try to match up what you've provided to the constructor for `Option`. We now special case `Option` as a type of collection in the generation of the `Meta` ADT, and handle that case when constructing the concrete instance.\r\n\r\nI'm not quite familiar enough with this code to know if this is a kludge or a clever hack. Would love some :eyes: from @jonifreeman (if you have time). Either way, I humbly submit this for review.\r\n\r\ncloses #1071 ","created_at":"2015-08-29T13:57:22Z","updated_at":"2015-08-29T14:58:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d369f2ade4b703d5f7e4e507e82271056805ac0","assignee":null,"milestone":{"url":"https://api.github.com/repos/lift/framework/milestones/65","html_url":"https://github.com/lift/framework/milestones/3.0-M7","labels_url":"https://api.github.com/repos/lift/framework/milestones/65/labels","id":1226309,"number":65,"title":"3.0-M7","description":"","creator":{"login":"Shadowfiend","id":8245,"avatar_url":"https://avatars.githubusercontent.com/u/8245?v=3","gravatar_id":"","url":"https://api.github.com/users/Shadowfiend","html_url":"https://github.com/Shadowfiend","followers_url":"https://api.github.com/users/Shadowfiend/followers","following_url":"https://api.github.com/users/Shadowfiend/following{/other_user}","gists_url":"https://api.github.com/users/Shadowfiend/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadowfiend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadowfiend/subscriptions","organizations_url":"https://api.github.com/users/Shadowfiend/orgs","repos_url":"https://api.github.com/users/Shadowfiend/repos","events_url":"https://api.github.com/users/Shadowfiend/events{/privacy}","received_events_url":"https://api.github.com/users/Shadowfiend/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":5,"state":"open","created_at":"2015-07-26T16:14:15Z","updated_at":"2015-08-29T13:57:30Z","due_on":"2015-09-30T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/lift/framework/pulls/1717/commits","review_comments_url":"https://api.github.com/repos/lift/framework/pulls/1717/comments","review_comment_url":"https://api.github.com/repos/lift/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lift/framework/issues/1717/comments","statuses_url":"https://api.github.com/repos/lift/framework/statuses/9894baf60be18ebdb1c3704b7a2a007549a29c86","head":{"label":"lift:msf_issue_1071","ref":"msf_issue_1071","sha":"9894baf60be18ebdb1c3704b7a2a007549a29c86","user":{"login":"lift","id":317975,"avatar_url":"https://avatars.githubusercontent.com/u/317975?v=3","gravatar_id":"","url":"https://api.github.com/users/lift","html_url":"https://github.com/lift","followers_url":"https://api.github.com/users/lift/followers","following_url":"https://api.github.com/users/lift/following{/other_user}","gists_url":"https://api.github.com/users/lift/gists{/gist_id}","starred_url":"https://api.github.com/users/lift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lift/subscriptions","organizations_url":"https://api.github.com/users/lift/orgs","repos_url":"https://api.github.com/users/lift/repos","events_url":"https://api.github.com/users/lift/events{/privacy}","received_events_url":"https://api.github.com/users/lift/received_events","type":"Organization","site_admin":false},"repo":{"id":1295197,"name":"framework","full_name":"lift/framework","owner":{"login":"lift","id":317975,"avatar_url":"https://avatars.githubusercontent.com/u/317975?v=3","gravatar_id":"","url":"https://api.github.com/users/lift","html_url":"https://github.com/lift","followers_url":"https://api.github.com/users/lift/followers","following_url":"https://api.github.com/users/lift/following{/other_user}","gists_url":"https://api.github.com/users/lift/gists{/gist_id}","starred_url":"https://api.github.com/users/lift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lift/subscriptions","organizations_url":"https://api.github.com/users/lift/orgs","repos_url":"https://api.github.com/users/lift/repos","events_url":"https://api.github.com/users/lift/events{/privacy}","received_events_url":"https://api.github.com/users/lift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lift/framework","description":"Lift Framework","fork":false,"url":"https://api.github.com/repos/lift/framework","forks_url":"https://api.github.com/repos/lift/framework/forks","keys_url":"https://api.github.com/repos/lift/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lift/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lift/framework/teams","hooks_url":"https://api.github.com/repos/lift/framework/hooks","issue_events_url":"https://api.github.com/repos/lift/framework/issues/events{/number}","events_url":"https://api.github.com/repos/lift/framework/events","assignees_url":"https://api.github.com/repos/lift/framework/assignees{/user}","branches_url":"https://api.github.com/repos/lift/framework/branches{/branch}","tags_url":"https://api.github.com/repos/lift/framework/tags","blobs_url":"https://api.github.com/repos/lift/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lift/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lift/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/lift/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lift/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/lift/framework/languages","stargazers_url":"https://api.github.com/repos/lift/framework/stargazers","contributors_url":"https://api.github.com/repos/lift/framework/contributors","subscribers_url":"https://api.github.com/repos/lift/framework/subscribers","subscription_url":"https://api.github.com/repos/lift/framework/subscription","commits_url":"https://api.github.com/repos/lift/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/lift/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/lift/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/lift/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/lift/framework/contents/{+path}","compare_url":"https://api.github.com/repos/lift/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lift/framework/merges","archive_url":"https://api.github.com/repos/lift/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lift/framework/downloads","issues_url":"https://api.github.com/repos/lift/framework/issues{/number}","pulls_url":"https://api.github.com/repos/lift/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/lift/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/lift/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lift/framework/labels{/name}","releases_url":"https://api.github.com/repos/lift/framework/releases{/id}","created_at":"2011-01-26T13:25:28Z","updated_at":"2015-08-29T02:08:36Z","pushed_at":"2015-08-29T13:57:23Z","git_url":"git://github.com/lift/framework.git","ssh_url":"git@github.com:lift/framework.git","clone_url":"https://github.com/lift/framework.git","svn_url":"https://github.com/lift/framework","homepage":"http://liftweb.net","size":29736,"stargazers_count":916,"watchers_count":916,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":216,"mirror_url":null,"open_issues_count":131,"forks":216,"open_issues":131,"watchers":916,"default_branch":"master"}},"base":{"label":"lift:master","ref":"master","sha":"30d8ce614b22d012c1e5bc07c14b767066d1076b","user":{"login":"lift","id":317975,"avatar_url":"https://avatars.githubusercontent.com/u/317975?v=3","gravatar_id":"","url":"https://api.github.com/users/lift","html_url":"https://github.com/lift","followers_url":"https://api.github.com/users/lift/followers","following_url":"https://api.github.com/users/lift/following{/other_user}","gists_url":"https://api.github.com/users/lift/gists{/gist_id}","starred_url":"https://api.github.com/users/lift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lift/subscriptions","organizations_url":"https://api.github.com/users/lift/orgs","repos_url":"https://api.github.com/users/lift/repos","events_url":"https://api.github.com/users/lift/events{/privacy}","received_events_url":"https://api.github.com/users/lift/received_events","type":"Organization","site_admin":false},"repo":{"id":1295197,"name":"framework","full_name":"lift/framework","owner":{"login":"lift","id":317975,"avatar_url":"https://avatars.githubusercontent.com/u/317975?v=3","gravatar_id":"","url":"https://api.github.com/users/lift","html_url":"https://github.com/lift","followers_url":"https://api.github.com/users/lift/followers","following_url":"https://api.github.com/users/lift/following{/other_user}","gists_url":"https://api.github.com/users/lift/gists{/gist_id}","starred_url":"https://api.github.com/users/lift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lift/subscriptions","organizations_url":"https://api.github.com/users/lift/orgs","repos_url":"https://api.github.com/users/lift/repos","events_url":"https://api.github.com/users/lift/events{/privacy}","received_events_url":"https://api.github.com/users/lift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lift/framework","description":"Lift Framework","fork":false,"url":"https://api.github.com/repos/lift/framework","forks_url":"https://api.github.com/repos/lift/framework/forks","keys_url":"https://api.github.com/repos/lift/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lift/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lift/framework/teams","hooks_url":"https://api.github.com/repos/lift/framework/hooks","issue_events_url":"https://api.github.com/repos/lift/framework/issues/events{/number}","events_url":"https://api.github.com/repos/lift/framework/events","assignees_url":"https://api.github.com/repos/lift/framework/assignees{/user}","branches_url":"https://api.github.com/repos/lift/framework/branches{/branch}","tags_url":"https://api.github.com/repos/lift/framework/tags","blobs_url":"https://api.github.com/repos/lift/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lift/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lift/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/lift/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lift/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/lift/framework/languages","stargazers_url":"https://api.github.com/repos/lift/framework/stargazers","contributors_url":"https://api.github.com/repos/lift/framework/contributors","subscribers_url":"https://api.github.com/repos/lift/framework/subscribers","subscription_url":"https://api.github.com/repos/lift/framework/subscription","commits_url":"https://api.github.com/repos/lift/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/lift/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/lift/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/lift/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/lift/framework/contents/{+path}","compare_url":"https://api.github.com/repos/lift/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lift/framework/merges","archive_url":"https://api.github.com/repos/lift/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lift/framework/downloads","issues_url":"https://api.github.com/repos/lift/framework/issues{/number}","pulls_url":"https://api.github.com/repos/lift/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/lift/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/lift/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lift/framework/labels{/name}","releases_url":"https://api.github.com/repos/lift/framework/releases{/id}","created_at":"2011-01-26T13:25:28Z","updated_at":"2015-08-29T02:08:36Z","pushed_at":"2015-08-29T13:57:23Z","git_url":"git://github.com/lift/framework.git","ssh_url":"git@github.com:lift/framework.git","clone_url":"https://github.com/lift/framework.git","svn_url":"https://github.com/lift/framework","homepage":"http://liftweb.net","size":29736,"stargazers_count":916,"watchers_count":916,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":216,"mirror_url":null,"open_issues_count":131,"forks":216,"open_issues":131,"watchers":916,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lift/framework/pulls/1717"},"html":{"href":"https://github.com/lift/framework/pull/1717"},"issue":{"href":"https://api.github.com/repos/lift/framework/issues/1717"},"comments":{"href":"https://api.github.com/repos/lift/framework/issues/1717/comments"},"review_comments":{"href":"https://api.github.com/repos/lift/framework/pulls/1717/comments"},"review_comment":{"href":"https://api.github.com/repos/lift/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lift/framework/pulls/1717/commits"},"statuses":{"href":"https://api.github.com/repos/lift/framework/statuses/9894baf60be18ebdb1c3704b7a2a007549a29c86"}}}}