{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/27192244","id":27192244,"diff_hunk":"@@ -1127,8 +1127,9 @@ module.exports = component.register('gaia-header', {\n   sumButtonWidths: function(buttons) {\n     var defaultWidth = 50;\n     var sum = buttons.reduce((prev, button) => {\n+      var isEmpty = !button.children.length && !button.textContent;","path":"shared/elements/gaia-header/dist/gaia-header.js","position":4,"original_position":4,"commit_id":"2a82ae5145fafa1c82d045e6993717fcd7e26500","original_commit_id":"2a82ae5145fafa1c82d045e6993717fcd7e26500","user":{"login":"janus926","id":1648649,"avatar_url":"https://avatars.githubusercontent.com/u/1648649?v=3","gravatar_id":"","url":"https://api.github.com/users/janus926","html_url":"https://github.com/janus926","followers_url":"https://api.github.com/users/janus926/followers","following_url":"https://api.github.com/users/janus926/following{/other_user}","gists_url":"https://api.github.com/users/janus926/gists{/gist_id}","starred_url":"https://api.github.com/users/janus926/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janus926/subscriptions","organizations_url":"https://api.github.com/users/janus926/orgs","repos_url":"https://api.github.com/users/janus926/repos","events_url":"https://api.github.com/users/janus926/events{/privacy}","received_events_url":"https://api.github.com/users/janus926/received_events","type":"User","site_admin":false},"body":"Is trim() necessary? From MDN, whitespace is considered [1]. But I should make sure it has dataset.icon.\r\n\r\n[1] https://developer.mozilla.org/zh-TW/docs/Web/CSS/:empty","created_at":"2015-03-26T07:17:38Z","updated_at":"2015-03-26T07:17:38Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/29136#discussion_r27192244","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29136","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/27192244"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/29136#discussion_r27192244"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29136"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29136","id":31909142,"html_url":"https://github.com/mozilla-b2g/gaia/pull/29136","diff_url":"https://github.com/mozilla-b2g/gaia/pull/29136.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/29136.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/29136","number":29136,"state":"open","locked":false,"title":"Bug 1147328 - Avoid synchronous reflow from getting contentWidht of empt...","user":{"login":"janus926","id":1648649,"avatar_url":"https://avatars.githubusercontent.com/u/1648649?v=3","gravatar_id":"","url":"https://api.github.com/users/janus926","html_url":"https://github.com/janus926","followers_url":"https://api.github.com/users/janus926/followers","following_url":"https://api.github.com/users/janus926/following{/other_user}","gists_url":"https://api.github.com/users/janus926/gists{/gist_id}","starred_url":"https://api.github.com/users/janus926/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janus926/subscriptions","organizations_url":"https://api.github.com/users/janus926/orgs","repos_url":"https://api.github.com/users/janus926/repos","events_url":"https://api.github.com/users/janus926/events{/privacy}","received_events_url":"https://api.github.com/users/janus926/received_events","type":"User","site_admin":false},"body":"...y button in gaia-header.","created_at":"2015-03-25T10:26:27Z","updated_at":"2015-03-26T07:17:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5f417e3cdc7fdee3ad41f3dea16e5acfc3f546c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29136/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29136/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/29136/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/2a82ae5145fafa1c82d045e6993717fcd7e26500","head":{"label":"janus926:bug-1147328","ref":"bug-1147328","sha":"2a82ae5145fafa1c82d045e6993717fcd7e26500","user":{"login":"janus926","id":1648649,"avatar_url":"https://avatars.githubusercontent.com/u/1648649?v=3","gravatar_id":"","url":"https://api.github.com/users/janus926","html_url":"https://github.com/janus926","followers_url":"https://api.github.com/users/janus926/followers","following_url":"https://api.github.com/users/janus926/following{/other_user}","gists_url":"https://api.github.com/users/janus926/gists{/gist_id}","starred_url":"https://api.github.com/users/janus926/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janus926/subscriptions","organizations_url":"https://api.github.com/users/janus926/orgs","repos_url":"https://api.github.com/users/janus926/repos","events_url":"https://api.github.com/users/janus926/events{/privacy}","received_events_url":"https://api.github.com/users/janus926/received_events","type":"User","site_admin":false},"repo":{"id":18056450,"name":"gaia","full_name":"janus926/gaia","owner":{"login":"janus926","id":1648649,"avatar_url":"https://avatars.githubusercontent.com/u/1648649?v=3","gravatar_id":"","url":"https://api.github.com/users/janus926","html_url":"https://github.com/janus926","followers_url":"https://api.github.com/users/janus926/followers","following_url":"https://api.github.com/users/janus926/following{/other_user}","gists_url":"https://api.github.com/users/janus926/gists{/gist_id}","starred_url":"https://api.github.com/users/janus926/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janus926/subscriptions","organizations_url":"https://api.github.com/users/janus926/orgs","repos_url":"https://api.github.com/users/janus926/repos","events_url":"https://api.github.com/users/janus926/events{/privacy}","received_events_url":"https://api.github.com/users/janus926/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janus926/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","fork":true,"url":"https://api.github.com/repos/janus926/gaia","forks_url":"https://api.github.com/repos/janus926/gaia/forks","keys_url":"https://api.github.com/repos/janus926/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janus926/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janus926/gaia/teams","hooks_url":"https://api.github.com/repos/janus926/gaia/hooks","issue_events_url":"https://api.github.com/repos/janus926/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/janus926/gaia/events","assignees_url":"https://api.github.com/repos/janus926/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/janus926/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/janus926/gaia/tags","blobs_url":"https://api.github.com/repos/janus926/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janus926/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janus926/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/janus926/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janus926/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/janus926/gaia/languages","stargazers_url":"https://api.github.com/repos/janus926/gaia/stargazers","contributors_url":"https://api.github.com/repos/janus926/gaia/contributors","subscribers_url":"https://api.github.com/repos/janus926/gaia/subscribers","subscription_url":"https://api.github.com/repos/janus926/gaia/subscription","commits_url":"https://api.github.com/repos/janus926/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/janus926/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/janus926/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/janus926/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/janus926/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/janus926/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janus926/gaia/merges","archive_url":"https://api.github.com/repos/janus926/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janus926/gaia/downloads","issues_url":"https://api.github.com/repos/janus926/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/janus926/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/janus926/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/janus926/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janus926/gaia/labels{/name}","releases_url":"https://api.github.com/repos/janus926/gaia/releases{/id}","created_at":"2014-03-24T08:47:43Z","updated_at":"2015-03-25T09:54:41Z","pushed_at":"2015-03-25T10:25:46Z","git_url":"git://github.com/janus926/gaia.git","ssh_url":"git@github.com:janus926/gaia.git","clone_url":"https://github.com/janus926/gaia.git","svn_url":"https://github.com/janus926/gaia","homepage":"https://wiki.mozilla.org/B2G","size":893750,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"a8256b632f571b2ed45129213490e14a86e15c7f","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-03-26T07:08:22Z","pushed_at":"2015-03-26T07:08:22Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1470127,"stargazers_count":1898,"watchers_count":1898,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2262,"mirror_url":null,"open_issues_count":938,"forks":2262,"open_issues":938,"watchers":1898,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29136"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/29136"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/29136"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/29136/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29136/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29136/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/2a82ae5145fafa1c82d045e6993717fcd7e26500"}}}}