{"action":"created","issue":{"url":"https://api.github.com/repos/systemd/systemd/issues/1132","labels_url":"https://api.github.com/repos/systemd/systemd/issues/1132/labels{/name}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/1132/comments","events_url":"https://api.github.com/repos/systemd/systemd/issues/1132/events","html_url":"https://github.com/systemd/systemd/issues/1132","id":104632769,"number":1132,"title":"\"make check\" broken since unified cgroup rework if cgroupfs is not mounted","user":{"login":"martinpitt","id":200109,"avatar_url":"https://avatars.githubusercontent.com/u/200109?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpitt","html_url":"https://github.com/martinpitt","followers_url":"https://api.github.com/users/martinpitt/followers","following_url":"https://api.github.com/users/martinpitt/following{/other_user}","gists_url":"https://api.github.com/users/martinpitt/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpitt/subscriptions","organizations_url":"https://api.github.com/users/martinpitt/orgs","repos_url":"https://api.github.com/users/martinpitt/repos","events_url":"https://api.github.com/users/martinpitt/events{/privacy}","received_events_url":"https://api.github.com/users/martinpitt/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/systemd/systemd/labels/cgroups","name":"cgroups","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-03T06:50:40Z","updated_at":"2015-09-03T09:21:23Z","closed_at":null,"body":"Since commit efdb02375beb (\"core: unified cgroup hierarchy support\") I am seeing 4 test case failures during \"make check\", in `test-engine`, `test-path`, `test-sched-prio`, and `test-bus-creds`. They all fail for the same reason:\r\n\r\n```\r\n$ SYSTEMD_LOG_LEVEL=debug ./test-path\r\nCannot determine cgroup we are running in: Exec format error\r\nAssertion 'r >= 0' failed at src/test/test-path.c:47, function setup_test(). Aborting.\r\nAborted (core dumped)\r\n```\r\n\r\nThis negative `r` result comes from `manager_new(MANAGER_USER, true, &tmp);`\r\n\r\nThis only happens in a build chroot, the test programs run fine in my \"real\" system. Once I bind-mount `/sys/fs/cgroup` into the chroot it works again, but introducing this requirement would mean that we have to stop running these tests on package build as our production buildds don't do this. Was introducing this requirement deliberate, or at least unavoidable? If so I'm okay with disabling the tests, but I'd like to ask first."},"comment":{"url":"https://api.github.com/repos/systemd/systemd/issues/comments/137388982","html_url":"https://github.com/systemd/systemd/issues/1132#issuecomment-137388982","issue_url":"https://api.github.com/repos/systemd/systemd/issues/1132","id":137388982,"user":{"login":"poettering","id":2130732,"avatar_url":"https://avatars.githubusercontent.com/u/2130732?v=3","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"created_at":"2015-09-03T09:21:23Z","updated_at":"2015-09-03T09:21:23Z","body":"I'd be willing to add a patch that changes the tests in question to run cg_unified() early, and if that fails exits with the right exit code that causes the tests to be skipped... If cgroupfs is not accessible the tests are not useful anyway... I am surprised this worked earlier though..."}}