{"action":"created","issue":{"url":"https://api.github.com/repos/lauriii/drupalcores/issues/53","labels_url":"https://api.github.com/repos/lauriii/drupalcores/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/lauriii/drupalcores/issues/53/comments","events_url":"https://api.github.com/repos/lauriii/drupalcores/issues/53/events","html_url":"https://github.com/lauriii/drupalcores/pull/53","id":60648608,"number":53,"title":"Improve targeting of reverted commits","user":{"login":"nlisgo","id":383397,"avatar_url":"https://avatars.githubusercontent.com/u/383397?v=3","gravatar_id":"","url":"https://api.github.com/users/nlisgo","html_url":"https://github.com/nlisgo","followers_url":"https://api.github.com/users/nlisgo/followers","following_url":"https://api.github.com/users/nlisgo/following{/other_user}","gists_url":"https://api.github.com/users/nlisgo/gists{/gist_id}","starred_url":"https://api.github.com/users/nlisgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlisgo/subscriptions","organizations_url":"https://api.github.com/users/nlisgo/orgs","repos_url":"https://api.github.com/users/nlisgo/repos","events_url":"https://api.github.com/users/nlisgo/events{/privacy}","received_events_url":"https://api.github.com/users/nlisgo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-11T12:05:49Z","updated_at":"2015-03-20T10:23:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lauriii/drupalcores/pulls/53","html_url":"https://github.com/lauriii/drupalcores/pull/53","diff_url":"https://github.com/lauriii/drupalcores/pull/53.diff","patch_url":"https://github.com/lauriii/drupalcores/pull/53.patch"},"body":"Firstly, this is a great resource that rightly draws attention to the people that are making a significant contribution to the Drupal 8 project. Thanks.\r\n\r\nThis pull request addresses an issue that is causing some people to not be acknowledged as contributors.\r\n\r\nIt is quite common for a commit to be reverted and the d.o issue to remain open and a future patch gets accepted.\r\n\r\nFor instance [#2089397](http://drupal.org/node/2089397)\r\nhttp://cgit.drupalcode.org/drupal/log/?qt=grep&q=%232089397\r\n\r\nOriginal commit: Issue #2089397 by swentel, Wim Leers: Fixed Double 'Quick edit' contextual link. ()\r\nRevert of original commit: Revert \"Issue #2089397 by swentel, Wim Leers: Fixed Double 'Quick edit' contextual link.\"\r\nFollowup commit: Issue #2089397 by jessebeach, swentel, Wim Leers: Fixed Double 'Quick edit' contextual link.\r\n\r\nThe code as it stands ignores the followup commit instead of the original commit. So jessebeach does not receive acknowledgement for this issue.\r\n\r\nAt the time of preparing this pull request this fix will allow the script to acknowledge the efforts of 2726 contributors as opposed to 2718 without the fix. And jessebeach will have registered 151 commits as opposed to 149.\r\n\r\nI have a branch that I have been using on my fork to help me debug around this issue: https://github.com/nlisgo/drupalcores/tree/experimental/improve-targeting-reverts\r\n\r\nIt helped me to compare which commits were being reverted before and after the fix."},"comment":{"url":"https://api.github.com/repos/lauriii/drupalcores/issues/comments/83981598","html_url":"https://github.com/lauriii/drupalcores/pull/53#issuecomment-83981598","issue_url":"https://api.github.com/repos/lauriii/drupalcores/issues/53","id":83981598,"user":{"login":"lewisnyman","id":632390,"avatar_url":"https://avatars.githubusercontent.com/u/632390?v=3","gravatar_id":"","url":"https://api.github.com/users/lewisnyman","html_url":"https://github.com/lewisnyman","followers_url":"https://api.github.com/users/lewisnyman/followers","following_url":"https://api.github.com/users/lewisnyman/following{/other_user}","gists_url":"https://api.github.com/users/lewisnyman/gists{/gist_id}","starred_url":"https://api.github.com/users/lewisnyman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewisnyman/subscriptions","organizations_url":"https://api.github.com/users/lewisnyman/orgs","repos_url":"https://api.github.com/users/lewisnyman/repos","events_url":"https://api.github.com/users/lewisnyman/events{/privacy}","received_events_url":"https://api.github.com/users/lewisnyman/received_events","type":"User","site_admin":false},"created_at":"2015-03-20T10:23:39Z","updated_at":"2015-03-20T10:23:39Z","body":"I've fixed the error in https://github.com/lauriii/drupalcores/commit/0a4d2b499974c89977771602134369ce3cdfc42d - this PR should pass now"}}