{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/puppet-dhcp/pulls/comments/41799535","id":41799535,"diff_hunk":"@@ -57,4 +63,3 @@ subnet <%= @network %> netmask <%= @mask %> {\n   next-server <%= @pxeserver %>;\n <% end -%>\n }\n-","path":"templates/dhcpd.pool.erb","position":27,"original_position":27,"commit_id":"373c376c2438f692e79d59b5bcaa09c474a6269f","original_commit_id":"373c376c2438f692e79d59b5bcaa09c474a6269f","user":{"login":"mmoll","id":1434927,"avatar_url":"https://avatars.githubusercontent.com/u/1434927?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoll","html_url":"https://github.com/mmoll","followers_url":"https://api.github.com/users/mmoll/followers","following_url":"https://api.github.com/users/mmoll/following{/other_user}","gists_url":"https://api.github.com/users/mmoll/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoll/subscriptions","organizations_url":"https://api.github.com/users/mmoll/orgs","repos_url":"https://api.github.com/users/mmoll/repos","events_url":"https://api.github.com/users/mmoll/events{/privacy}","received_events_url":"https://api.github.com/users/mmoll/received_events","type":"User","site_admin":false},"body":"iirc @ekohl is a big fan of an extra line feed at the end of the file","created_at":"2015-10-12T20:48:04Z","updated_at":"2015-10-12T20:48:04Z","html_url":"https://github.com/theforeman/puppet-dhcp/pull/57#discussion_r41799535","pull_request_url":"https://api.github.com/repos/theforeman/puppet-dhcp/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-dhcp/pulls/comments/41799535"},"html":{"href":"https://github.com/theforeman/puppet-dhcp/pull/57#discussion_r41799535"},"pull_request":{"href":"https://api.github.com/repos/theforeman/puppet-dhcp/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/puppet-dhcp/pulls/57","id":47457776,"html_url":"https://github.com/theforeman/puppet-dhcp/pull/57","diff_url":"https://github.com/theforeman/puppet-dhcp/pull/57.diff","patch_url":"https://github.com/theforeman/puppet-dhcp/pull/57.patch","issue_url":"https://api.github.com/repos/theforeman/puppet-dhcp/issues/57","number":57,"state":"open","locked":false,"title":"Add support for the range param being an array","user":{"login":"brandonweeks","id":15869,"avatar_url":"https://avatars.githubusercontent.com/u/15869?v=3","gravatar_id":"","url":"https://api.github.com/users/brandonweeks","html_url":"https://github.com/brandonweeks","followers_url":"https://api.github.com/users/brandonweeks/followers","following_url":"https://api.github.com/users/brandonweeks/following{/other_user}","gists_url":"https://api.github.com/users/brandonweeks/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonweeks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonweeks/subscriptions","organizations_url":"https://api.github.com/users/brandonweeks/orgs","repos_url":"https://api.github.com/users/brandonweeks/repos","events_url":"https://api.github.com/users/brandonweeks/events{/privacy}","received_events_url":"https://api.github.com/users/brandonweeks/received_events","type":"User","site_admin":false},"body":"This allows the range param to be passed either as a string or an array. Having multiple range definitions in a pool is supported by dhcpd. This has the added benefit of being API compatible with puppetlabs-dhcp for the range param.","created_at":"2015-10-12T19:53:57Z","updated_at":"2015-10-12T20:48:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0431ab5be59a7168e63ab43cb80680f2ed82aa51","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/puppet-dhcp/pulls/57/commits","review_comments_url":"https://api.github.com/repos/theforeman/puppet-dhcp/pulls/57/comments","review_comment_url":"https://api.github.com/repos/theforeman/puppet-dhcp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/puppet-dhcp/issues/57/comments","statuses_url":"https://api.github.com/repos/theforeman/puppet-dhcp/statuses/373c376c2438f692e79d59b5bcaa09c474a6269f","head":{"label":"squarit:range_array","ref":"range_array","sha":"373c376c2438f692e79d59b5bcaa09c474a6269f","user":{"login":"squarit","id":8785576,"avatar_url":"https://avatars.githubusercontent.com/u/8785576?v=3","gravatar_id":"","url":"https://api.github.com/users/squarit","html_url":"https://github.com/squarit","followers_url":"https://api.github.com/users/squarit/followers","following_url":"https://api.github.com/users/squarit/following{/other_user}","gists_url":"https://api.github.com/users/squarit/gists{/gist_id}","starred_url":"https://api.github.com/users/squarit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squarit/subscriptions","organizations_url":"https://api.github.com/users/squarit/orgs","repos_url":"https://api.github.com/users/squarit/repos","events_url":"https://api.github.com/users/squarit/events{/privacy}","received_events_url":"https://api.github.com/users/squarit/received_events","type":"Organization","site_admin":false},"repo":{"id":43980313,"name":"puppet-dhcp","full_name":"squarit/puppet-dhcp","owner":{"login":"squarit","id":8785576,"avatar_url":"https://avatars.githubusercontent.com/u/8785576?v=3","gravatar_id":"","url":"https://api.github.com/users/squarit","html_url":"https://github.com/squarit","followers_url":"https://api.github.com/users/squarit/followers","following_url":"https://api.github.com/users/squarit/following{/other_user}","gists_url":"https://api.github.com/users/squarit/gists{/gist_id}","starred_url":"https://api.github.com/users/squarit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squarit/subscriptions","organizations_url":"https://api.github.com/users/squarit/orgs","repos_url":"https://api.github.com/users/squarit/repos","events_url":"https://api.github.com/users/squarit/events{/privacy}","received_events_url":"https://api.github.com/users/squarit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/squarit/puppet-dhcp","description":"DHCP module for Puppet","fork":true,"url":"https://api.github.com/repos/squarit/puppet-dhcp","forks_url":"https://api.github.com/repos/squarit/puppet-dhcp/forks","keys_url":"https://api.github.com/repos/squarit/puppet-dhcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squarit/puppet-dhcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squarit/puppet-dhcp/teams","hooks_url":"https://api.github.com/repos/squarit/puppet-dhcp/hooks","issue_events_url":"https://api.github.com/repos/squarit/puppet-dhcp/issues/events{/number}","events_url":"https://api.github.com/repos/squarit/puppet-dhcp/events","assignees_url":"https://api.github.com/repos/squarit/puppet-dhcp/assignees{/user}","branches_url":"https://api.github.com/repos/squarit/puppet-dhcp/branches{/branch}","tags_url":"https://api.github.com/repos/squarit/puppet-dhcp/tags","blobs_url":"https://api.github.com/repos/squarit/puppet-dhcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squarit/puppet-dhcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squarit/puppet-dhcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/squarit/puppet-dhcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squarit/puppet-dhcp/statuses/{sha}","languages_url":"https://api.github.com/repos/squarit/puppet-dhcp/languages","stargazers_url":"https://api.github.com/repos/squarit/puppet-dhcp/stargazers","contributors_url":"https://api.github.com/repos/squarit/puppet-dhcp/contributors","subscribers_url":"https://api.github.com/repos/squarit/puppet-dhcp/subscribers","subscription_url":"https://api.github.com/repos/squarit/puppet-dhcp/subscription","commits_url":"https://api.github.com/repos/squarit/puppet-dhcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/squarit/puppet-dhcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/squarit/puppet-dhcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/squarit/puppet-dhcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/squarit/puppet-dhcp/contents/{+path}","compare_url":"https://api.github.com/repos/squarit/puppet-dhcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squarit/puppet-dhcp/merges","archive_url":"https://api.github.com/repos/squarit/puppet-dhcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squarit/puppet-dhcp/downloads","issues_url":"https://api.github.com/repos/squarit/puppet-dhcp/issues{/number}","pulls_url":"https://api.github.com/repos/squarit/puppet-dhcp/pulls{/number}","milestones_url":"https://api.github.com/repos/squarit/puppet-dhcp/milestones{/number}","notifications_url":"https://api.github.com/repos/squarit/puppet-dhcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squarit/puppet-dhcp/labels{/name}","releases_url":"https://api.github.com/repos/squarit/puppet-dhcp/releases{/id}","created_at":"2015-10-09T21:10:37Z","updated_at":"2015-10-09T21:10:37Z","pushed_at":"2015-10-12T20:46:47Z","git_url":"git://github.com/squarit/puppet-dhcp.git","ssh_url":"git@github.com:squarit/puppet-dhcp.git","clone_url":"https://github.com/squarit/puppet-dhcp.git","svn_url":"https://github.com/squarit/puppet-dhcp","homepage":"","size":645,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:master","ref":"master","sha":"64234ae5077a19e031f9cbd07981c53edc59555f","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":3885642,"name":"puppet-dhcp","full_name":"theforeman/puppet-dhcp","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/puppet-dhcp","description":"DHCP module for Puppet","fork":false,"url":"https://api.github.com/repos/theforeman/puppet-dhcp","forks_url":"https://api.github.com/repos/theforeman/puppet-dhcp/forks","keys_url":"https://api.github.com/repos/theforeman/puppet-dhcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/puppet-dhcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/puppet-dhcp/teams","hooks_url":"https://api.github.com/repos/theforeman/puppet-dhcp/hooks","issue_events_url":"https://api.github.com/repos/theforeman/puppet-dhcp/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/puppet-dhcp/events","assignees_url":"https://api.github.com/repos/theforeman/puppet-dhcp/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/puppet-dhcp/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/puppet-dhcp/tags","blobs_url":"https://api.github.com/repos/theforeman/puppet-dhcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/puppet-dhcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/puppet-dhcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/puppet-dhcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/puppet-dhcp/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/puppet-dhcp/languages","stargazers_url":"https://api.github.com/repos/theforeman/puppet-dhcp/stargazers","contributors_url":"https://api.github.com/repos/theforeman/puppet-dhcp/contributors","subscribers_url":"https://api.github.com/repos/theforeman/puppet-dhcp/subscribers","subscription_url":"https://api.github.com/repos/theforeman/puppet-dhcp/subscription","commits_url":"https://api.github.com/repos/theforeman/puppet-dhcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/puppet-dhcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/puppet-dhcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/puppet-dhcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/puppet-dhcp/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/puppet-dhcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/puppet-dhcp/merges","archive_url":"https://api.github.com/repos/theforeman/puppet-dhcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/puppet-dhcp/downloads","issues_url":"https://api.github.com/repos/theforeman/puppet-dhcp/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/puppet-dhcp/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/puppet-dhcp/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/puppet-dhcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/puppet-dhcp/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/puppet-dhcp/releases{/id}","created_at":"2012-03-31T13:25:08Z","updated_at":"2015-10-09T21:09:50Z","pushed_at":"2015-10-12T20:46:48Z","git_url":"git://github.com/theforeman/puppet-dhcp.git","ssh_url":"git@github.com:theforeman/puppet-dhcp.git","clone_url":"https://github.com/theforeman/puppet-dhcp.git","svn_url":"https://github.com/theforeman/puppet-dhcp","homepage":"","size":645,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":4,"forks":38,"open_issues":4,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-dhcp/pulls/57"},"html":{"href":"https://github.com/theforeman/puppet-dhcp/pull/57"},"issue":{"href":"https://api.github.com/repos/theforeman/puppet-dhcp/issues/57"},"comments":{"href":"https://api.github.com/repos/theforeman/puppet-dhcp/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/puppet-dhcp/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/puppet-dhcp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/puppet-dhcp/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/puppet-dhcp/statuses/373c376c2438f692e79d59b5bcaa09c474a6269f"}}}}