{"action":"closed","number":229,"pull_request":{"url":"https://api.github.com/repos/topolik/liferay-portal/pulls/229","id":52147503,"html_url":"https://github.com/topolik/liferay-portal/pull/229","diff_url":"https://github.com/topolik/liferay-portal/pull/229.diff","patch_url":"https://github.com/topolik/liferay-portal/pull/229.patch","issue_url":"https://api.github.com/repos/topolik/liferay-portal/issues/229","number":229,"state":"closed","locked":false,"title":"LPS-60139 i","user":{"login":"stian-sigvartsen","id":12467295,"avatar_url":"https://avatars.githubusercontent.com/u/12467295?v=3","gravatar_id":"","url":"https://api.github.com/users/stian-sigvartsen","html_url":"https://github.com/stian-sigvartsen","followers_url":"https://api.github.com/users/stian-sigvartsen/followers","following_url":"https://api.github.com/users/stian-sigvartsen/following{/other_user}","gists_url":"https://api.github.com/users/stian-sigvartsen/gists{/gist_id}","starred_url":"https://api.github.com/users/stian-sigvartsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stian-sigvartsen/subscriptions","organizations_url":"https://api.github.com/users/stian-sigvartsen/orgs","repos_url":"https://api.github.com/users/stian-sigvartsen/repos","events_url":"https://api.github.com/users/stian-sigvartsen/events{/privacy}","received_events_url":"https://api.github.com/users/stian-sigvartsen/received_events","type":"User","site_admin":false},"body":"I was able to keep a lot of the old code from the FacebookConnectAction Struts action, this is now in FacebookConnectRedirectURIServlet.\r\n\r\nFollowing our conversation about how to best integrate error keys from modules into the login portlet, I decided to go with adding a dynamic-include point as you suggested (instead of MVCRenderCommand). I think It is probably a useful extension point for other reasons, like enabling portals to show informative content to their users when logging in.\r\n\r\nThe branch is based on your portal-settings-sso-extraction branch. Once the other Facebook settings work is complete we should rebase it.\r\n\r\nHappy to discuss / change anything :)\r\n\r\nFYI - Once merged, we only need to tweak /navigation/facebook.jsp in order to support Facebook login without a popup. But I'll raise a separate issue for that.","created_at":"2015-11-30T16:40:05Z","updated_at":"2015-11-30T18:23:32Z","closed_at":"2015-11-30T18:23:32Z","merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/topolik/liferay-portal/pulls/229/commits","review_comments_url":"https://api.github.com/repos/topolik/liferay-portal/pulls/229/comments","review_comment_url":"https://api.github.com/repos/topolik/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/topolik/liferay-portal/issues/229/comments","statuses_url":"https://api.github.com/repos/topolik/liferay-portal/statuses/a85b00e7e9023b9bcc42bf9cfedd728fa7957343","head":{"label":"stian-sigvartsen:LPS-60139","ref":"LPS-60139","sha":"a85b00e7e9023b9bcc42bf9cfedd728fa7957343","user":{"login":"stian-sigvartsen","id":12467295,"avatar_url":"https://avatars.githubusercontent.com/u/12467295?v=3","gravatar_id":"","url":"https://api.github.com/users/stian-sigvartsen","html_url":"https://github.com/stian-sigvartsen","followers_url":"https://api.github.com/users/stian-sigvartsen/followers","following_url":"https://api.github.com/users/stian-sigvartsen/following{/other_user}","gists_url":"https://api.github.com/users/stian-sigvartsen/gists{/gist_id}","starred_url":"https://api.github.com/users/stian-sigvartsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stian-sigvartsen/subscriptions","organizations_url":"https://api.github.com/users/stian-sigvartsen/orgs","repos_url":"https://api.github.com/users/stian-sigvartsen/repos","events_url":"https://api.github.com/users/stian-sigvartsen/events{/privacy}","received_events_url":"https://api.github.com/users/stian-sigvartsen/received_events","type":"User","site_admin":false},"repo":{"id":35702967,"name":"liferay-portal","full_name":"stian-sigvartsen/liferay-portal","owner":{"login":"stian-sigvartsen","id":12467295,"avatar_url":"https://avatars.githubusercontent.com/u/12467295?v=3","gravatar_id":"","url":"https://api.github.com/users/stian-sigvartsen","html_url":"https://github.com/stian-sigvartsen","followers_url":"https://api.github.com/users/stian-sigvartsen/followers","following_url":"https://api.github.com/users/stian-sigvartsen/following{/other_user}","gists_url":"https://api.github.com/users/stian-sigvartsen/gists{/gist_id}","starred_url":"https://api.github.com/users/stian-sigvartsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stian-sigvartsen/subscriptions","organizations_url":"https://api.github.com/users/stian-sigvartsen/orgs","repos_url":"https://api.github.com/users/stian-sigvartsen/repos","events_url":"https://api.github.com/users/stian-sigvartsen/events{/privacy}","received_events_url":"https://api.github.com/users/stian-sigvartsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stian-sigvartsen/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal","forks_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/forks","keys_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/teams","hooks_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/events","assignees_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/tags","blobs_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/subscription","commits_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/merges","archive_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/downloads","issues_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/stian-sigvartsen/liferay-portal/releases{/id}","created_at":"2015-05-16T00:16:33Z","updated_at":"2015-05-16T00:17:55Z","pushed_at":"2015-11-30T16:21:07Z","git_url":"git://github.com/stian-sigvartsen/liferay-portal.git","ssh_url":"git@github.com:stian-sigvartsen/liferay-portal.git","clone_url":"https://github.com/stian-sigvartsen/liferay-portal.git","svn_url":"https://github.com/stian-sigvartsen/liferay-portal","homepage":"http://liferay.com","size":5373919,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"topolik:portal-settings-sso-extraction","ref":"portal-settings-sso-extraction","sha":"fe61a738b381499a207ee90515705655da2a9f33","user":{"login":"topolik","id":148147,"avatar_url":"https://avatars.githubusercontent.com/u/148147?v=3","gravatar_id":"","url":"https://api.github.com/users/topolik","html_url":"https://github.com/topolik","followers_url":"https://api.github.com/users/topolik/followers","following_url":"https://api.github.com/users/topolik/following{/other_user}","gists_url":"https://api.github.com/users/topolik/gists{/gist_id}","starred_url":"https://api.github.com/users/topolik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topolik/subscriptions","organizations_url":"https://api.github.com/users/topolik/orgs","repos_url":"https://api.github.com/users/topolik/repos","events_url":"https://api.github.com/users/topolik/events{/privacy}","received_events_url":"https://api.github.com/users/topolik/received_events","type":"User","site_admin":false},"repo":{"id":3853423,"name":"liferay-portal","full_name":"topolik/liferay-portal","owner":{"login":"topolik","id":148147,"avatar_url":"https://avatars.githubusercontent.com/u/148147?v=3","gravatar_id":"","url":"https://api.github.com/users/topolik","html_url":"https://github.com/topolik","followers_url":"https://api.github.com/users/topolik/followers","following_url":"https://api.github.com/users/topolik/following{/other_user}","gists_url":"https://api.github.com/users/topolik/gists{/gist_id}","starred_url":"https://api.github.com/users/topolik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topolik/subscriptions","organizations_url":"https://api.github.com/users/topolik/orgs","repos_url":"https://api.github.com/users/topolik/repos","events_url":"https://api.github.com/users/topolik/events{/privacy}","received_events_url":"https://api.github.com/users/topolik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/topolik/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/topolik/liferay-portal","forks_url":"https://api.github.com/repos/topolik/liferay-portal/forks","keys_url":"https://api.github.com/repos/topolik/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/topolik/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/topolik/liferay-portal/teams","hooks_url":"https://api.github.com/repos/topolik/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/topolik/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/topolik/liferay-portal/events","assignees_url":"https://api.github.com/repos/topolik/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/topolik/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/topolik/liferay-portal/tags","blobs_url":"https://api.github.com/repos/topolik/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/topolik/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/topolik/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/topolik/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/topolik/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/topolik/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/topolik/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/topolik/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/topolik/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/topolik/liferay-portal/subscription","commits_url":"https://api.github.com/repos/topolik/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/topolik/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/topolik/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/topolik/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/topolik/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/topolik/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/topolik/liferay-portal/merges","archive_url":"https://api.github.com/repos/topolik/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/topolik/liferay-portal/downloads","issues_url":"https://api.github.com/repos/topolik/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/topolik/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/topolik/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/topolik/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/topolik/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/topolik/liferay-portal/releases{/id}","created_at":"2012-03-28T09:17:44Z","updated_at":"2015-05-30T15:49:29Z","pushed_at":"2015-11-30T16:40:05Z","git_url":"git://github.com/topolik/liferay-portal.git","ssh_url":"git@github.com:topolik/liferay-portal.git","clone_url":"https://github.com/topolik/liferay-portal.git","svn_url":"https://github.com/topolik/liferay-portal","homepage":"http://liferay.com","size":5341363,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/topolik/liferay-portal/pulls/229"},"html":{"href":"https://github.com/topolik/liferay-portal/pull/229"},"issue":{"href":"https://api.github.com/repos/topolik/liferay-portal/issues/229"},"comments":{"href":"https://api.github.com/repos/topolik/liferay-portal/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/topolik/liferay-portal/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/topolik/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/topolik/liferay-portal/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/topolik/liferay-portal/statuses/a85b00e7e9023b9bcc42bf9cfedd728fa7957343"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":31,"additions":2606,"deletions":846,"changed_files":220}}