{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/git-plugin/issues/356","labels_url":"https://api.github.com/repos/jenkinsci/git-plugin/issues/356/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/git-plugin/issues/356/comments","events_url":"https://api.github.com/repos/jenkinsci/git-plugin/issues/356/events","html_url":"https://github.com/jenkinsci/git-plugin/pull/356","id":111130509,"number":356,"title":"[FIXED JENKINS-30178] Add default parameters defined in the job","user":{"login":"fbelzunc","id":3898648,"avatar_url":"https://avatars.githubusercontent.com/u/3898648?v=3","gravatar_id":"","url":"https://api.github.com/users/fbelzunc","html_url":"https://github.com/fbelzunc","followers_url":"https://api.github.com/users/fbelzunc/followers","following_url":"https://api.github.com/users/fbelzunc/following{/other_user}","gists_url":"https://api.github.com/users/fbelzunc/gists{/gist_id}","starred_url":"https://api.github.com/users/fbelzunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbelzunc/subscriptions","organizations_url":"https://api.github.com/users/fbelzunc/orgs","repos_url":"https://api.github.com/users/fbelzunc/repos","events_url":"https://api.github.com/users/fbelzunc/events{/privacy}","received_events_url":"https://api.github.com/users/fbelzunc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2015-10-13T08:22:39Z","updated_at":"2015-10-21T05:53:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/git-plugin/pulls/356","html_url":"https://github.com/jenkinsci/git-plugin/pull/356","diff_url":"https://github.com/jenkinsci/git-plugin/pull/356.diff","patch_url":"https://github.com/jenkinsci/git-plugin/pull/356.patch"},"body":"Jenkins doesn't set configured environment variables with default values in the \"This build is parameterized\" section on commit notification from SCM using `/git/notifyCommit` request. However it works properly when build is manually triggered with \"Build with parameters\" button.\r\n\r\nhttps://issues.jenkins-ci.org/browse/JENKINS-30178\r\n\r\n@reviewbybees @ndeloof @oleg-nenashev "},"comment":{"url":"https://api.github.com/repos/jenkinsci/git-plugin/issues/comments/149790734","html_url":"https://github.com/jenkinsci/git-plugin/pull/356#issuecomment-149790734","issue_url":"https://api.github.com/repos/jenkinsci/git-plugin/issues/356","id":149790734,"user":{"login":"fbelzunc","id":3898648,"avatar_url":"https://avatars.githubusercontent.com/u/3898648?v=3","gravatar_id":"","url":"https://api.github.com/users/fbelzunc","html_url":"https://github.com/fbelzunc","followers_url":"https://api.github.com/users/fbelzunc/followers","following_url":"https://api.github.com/users/fbelzunc/following{/other_user}","gists_url":"https://api.github.com/users/fbelzunc/gists{/gist_id}","starred_url":"https://api.github.com/users/fbelzunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbelzunc/subscriptions","organizations_url":"https://api.github.com/users/fbelzunc/orgs","repos_url":"https://api.github.com/users/fbelzunc/repos","events_url":"https://api.github.com/users/fbelzunc/events{/privacy}","received_events_url":"https://api.github.com/users/fbelzunc/received_events","type":"User","site_admin":false},"created_at":"2015-10-21T05:53:10Z","updated_at":"2015-10-21T05:53:10Z","body":"@oleg-nenashev @KostyaSha Can you review again, please?\r\n\r\nI have tried to create a test but it looks like is quite complex. For testing this I need to build to see if the correct variables are injected on the build or not.\r\n\r\nFirst, I thought about creating the test directly calling `List<ResponseContributor> onNotifyCommit`, but it looks like in `ResponseContributor` I will not find what we are looking for.\r\n\r\nThen, I thought about creating a similar test to the ones defined in `GitStatusTest`, but the main problem is that when you call `this.gitStatus.doNotifyCommit(requestWithNoParameter, \"a\", \"master\", null);` you need to wait for the build to finish. This seems to be possible with `JenkinsRule`, but `JenkinsRule` is defined in `AbstractGitProject`, so not sure if I should get the `JenkinsRule` from `AbstractGitProject` and call the corresponded function to wait for the build to happen. \r\n\r\n* Any ideas?"}}