{"action":"closed","number":381,"pull_request":{"url":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls/381","id":26638310,"html_url":"https://github.com/JustinTulloss/zeromq.node/pull/381","diff_url":"https://github.com/JustinTulloss/zeromq.node/pull/381.diff","patch_url":"https://github.com/JustinTulloss/zeromq.node/pull/381.patch","issue_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/issues/381","number":381,"state":"closed","locked":false,"title":"[Perf local_lat]Don't close the socket immediately","user":{"login":"maxired","id":1194083,"avatar_url":"https://avatars.githubusercontent.com/u/1194083?v=3","gravatar_id":"","url":"https://api.github.com/users/maxired","html_url":"https://github.com/maxired","followers_url":"https://api.github.com/users/maxired/followers","following_url":"https://api.github.com/users/maxired/following{/other_user}","gists_url":"https://api.github.com/users/maxired/gists{/gist_id}","starred_url":"https://api.github.com/users/maxired/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxired/subscriptions","organizations_url":"https://api.github.com/users/maxired/orgs","repos_url":"https://api.github.com/users/maxired/repos","events_url":"https://api.github.com/users/maxired/events{/privacy}","received_events_url":"https://api.github.com/users/maxired/received_events","type":"User","site_admin":false},"body":"Closing the socket to fast may lead to data to be not send.\r\nSomething similar is done in [remote_thr](https://github.com/JustinTulloss/zeromq.node/blob/master/perf/remote_thr.js#L27L29)","created_at":"2014-12-29T10:11:28Z","updated_at":"2015-01-14T02:36:31Z","closed_at":"2015-01-14T02:36:31Z","merged_at":"2015-01-14T02:36:31Z","merge_commit_sha":"d77e2aaec2592bfadc32e50162e4d2b262385ecd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls/381/commits","review_comments_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls/381/comments","review_comment_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls/comments/{number}","comments_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/issues/381/comments","statuses_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/statuses/68c1770c14b2c127568808f43b4c7c47c8da9c68","head":{"label":"maxired:patch-1","ref":"patch-1","sha":"68c1770c14b2c127568808f43b4c7c47c8da9c68","user":{"login":"maxired","id":1194083,"avatar_url":"https://avatars.githubusercontent.com/u/1194083?v=3","gravatar_id":"","url":"https://api.github.com/users/maxired","html_url":"https://github.com/maxired","followers_url":"https://api.github.com/users/maxired/followers","following_url":"https://api.github.com/users/maxired/following{/other_user}","gists_url":"https://api.github.com/users/maxired/gists{/gist_id}","starred_url":"https://api.github.com/users/maxired/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxired/subscriptions","organizations_url":"https://api.github.com/users/maxired/orgs","repos_url":"https://api.github.com/users/maxired/repos","events_url":"https://api.github.com/users/maxired/events{/privacy}","received_events_url":"https://api.github.com/users/maxired/received_events","type":"User","site_admin":false},"repo":{"id":28587558,"name":"zeromq.node","full_name":"maxired/zeromq.node","owner":{"login":"maxired","id":1194083,"avatar_url":"https://avatars.githubusercontent.com/u/1194083?v=3","gravatar_id":"","url":"https://api.github.com/users/maxired","html_url":"https://github.com/maxired","followers_url":"https://api.github.com/users/maxired/followers","following_url":"https://api.github.com/users/maxired/following{/other_user}","gists_url":"https://api.github.com/users/maxired/gists{/gist_id}","starred_url":"https://api.github.com/users/maxired/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxired/subscriptions","organizations_url":"https://api.github.com/users/maxired/orgs","repos_url":"https://api.github.com/users/maxired/repos","events_url":"https://api.github.com/users/maxired/events{/privacy}","received_events_url":"https://api.github.com/users/maxired/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxired/zeromq.node","description":"Node.js bindings to the zeromq library","fork":true,"url":"https://api.github.com/repos/maxired/zeromq.node","forks_url":"https://api.github.com/repos/maxired/zeromq.node/forks","keys_url":"https://api.github.com/repos/maxired/zeromq.node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxired/zeromq.node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxired/zeromq.node/teams","hooks_url":"https://api.github.com/repos/maxired/zeromq.node/hooks","issue_events_url":"https://api.github.com/repos/maxired/zeromq.node/issues/events{/number}","events_url":"https://api.github.com/repos/maxired/zeromq.node/events","assignees_url":"https://api.github.com/repos/maxired/zeromq.node/assignees{/user}","branches_url":"https://api.github.com/repos/maxired/zeromq.node/branches{/branch}","tags_url":"https://api.github.com/repos/maxired/zeromq.node/tags","blobs_url":"https://api.github.com/repos/maxired/zeromq.node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxired/zeromq.node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxired/zeromq.node/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxired/zeromq.node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxired/zeromq.node/statuses/{sha}","languages_url":"https://api.github.com/repos/maxired/zeromq.node/languages","stargazers_url":"https://api.github.com/repos/maxired/zeromq.node/stargazers","contributors_url":"https://api.github.com/repos/maxired/zeromq.node/contributors","subscribers_url":"https://api.github.com/repos/maxired/zeromq.node/subscribers","subscription_url":"https://api.github.com/repos/maxired/zeromq.node/subscription","commits_url":"https://api.github.com/repos/maxired/zeromq.node/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxired/zeromq.node/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxired/zeromq.node/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxired/zeromq.node/issues/comments/{number}","contents_url":"https://api.github.com/repos/maxired/zeromq.node/contents/{+path}","compare_url":"https://api.github.com/repos/maxired/zeromq.node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxired/zeromq.node/merges","archive_url":"https://api.github.com/repos/maxired/zeromq.node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxired/zeromq.node/downloads","issues_url":"https://api.github.com/repos/maxired/zeromq.node/issues{/number}","pulls_url":"https://api.github.com/repos/maxired/zeromq.node/pulls{/number}","milestones_url":"https://api.github.com/repos/maxired/zeromq.node/milestones{/number}","notifications_url":"https://api.github.com/repos/maxired/zeromq.node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxired/zeromq.node/labels{/name}","releases_url":"https://api.github.com/repos/maxired/zeromq.node/releases{/id}","created_at":"2014-12-29T09:46:57Z","updated_at":"2014-12-29T09:46:58Z","pushed_at":"2015-01-13T15:44:36Z","git_url":"git://github.com/maxired/zeromq.node.git","ssh_url":"git@github.com:maxired/zeromq.node.git","clone_url":"https://github.com/maxired/zeromq.node.git","svn_url":"https://github.com/maxired/zeromq.node","homepage":"","size":1721,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JustinTulloss:master","ref":"master","sha":"c8b90e8af41c5bd9af898c4e1a70b1a82914dc5f","user":{"login":"JustinTulloss","id":23734,"avatar_url":"https://avatars.githubusercontent.com/u/23734?v=3","gravatar_id":"","url":"https://api.github.com/users/JustinTulloss","html_url":"https://github.com/JustinTulloss","followers_url":"https://api.github.com/users/JustinTulloss/followers","following_url":"https://api.github.com/users/JustinTulloss/following{/other_user}","gists_url":"https://api.github.com/users/JustinTulloss/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinTulloss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinTulloss/subscriptions","organizations_url":"https://api.github.com/users/JustinTulloss/orgs","repos_url":"https://api.github.com/users/JustinTulloss/repos","events_url":"https://api.github.com/users/JustinTulloss/events{/privacy}","received_events_url":"https://api.github.com/users/JustinTulloss/received_events","type":"User","site_admin":false},"repo":{"id":595090,"name":"zeromq.node","full_name":"JustinTulloss/zeromq.node","owner":{"login":"JustinTulloss","id":23734,"avatar_url":"https://avatars.githubusercontent.com/u/23734?v=3","gravatar_id":"","url":"https://api.github.com/users/JustinTulloss","html_url":"https://github.com/JustinTulloss","followers_url":"https://api.github.com/users/JustinTulloss/followers","following_url":"https://api.github.com/users/JustinTulloss/following{/other_user}","gists_url":"https://api.github.com/users/JustinTulloss/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinTulloss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinTulloss/subscriptions","organizations_url":"https://api.github.com/users/JustinTulloss/orgs","repos_url":"https://api.github.com/users/JustinTulloss/repos","events_url":"https://api.github.com/users/JustinTulloss/events{/privacy}","received_events_url":"https://api.github.com/users/JustinTulloss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JustinTulloss/zeromq.node","description":"Node.js bindings to the zeromq library","fork":false,"url":"https://api.github.com/repos/JustinTulloss/zeromq.node","forks_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/forks","keys_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/teams","hooks_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/hooks","issue_events_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/issues/events{/number}","events_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/events","assignees_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/assignees{/user}","branches_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/branches{/branch}","tags_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/tags","blobs_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/git/refs{/sha}","trees_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/statuses/{sha}","languages_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/languages","stargazers_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/stargazers","contributors_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/contributors","subscribers_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/subscribers","subscription_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/subscription","commits_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/commits{/sha}","git_commits_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/git/commits{/sha}","comments_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/comments{/number}","issue_comment_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/issues/comments/{number}","contents_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/contents/{+path}","compare_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/merges","archive_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/downloads","issues_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/issues{/number}","pulls_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls{/number}","milestones_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/milestones{/number}","notifications_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/labels{/name}","releases_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/releases{/id}","created_at":"2010-04-05T07:23:15Z","updated_at":"2015-01-13T03:13:32Z","pushed_at":"2015-01-14T02:36:31Z","git_url":"git://github.com/JustinTulloss/zeromq.node.git","ssh_url":"git@github.com:JustinTulloss/zeromq.node.git","clone_url":"https://github.com/JustinTulloss/zeromq.node.git","svn_url":"https://github.com/JustinTulloss/zeromq.node","homepage":"","size":2780,"stargazers_count":1012,"watchers_count":1012,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":191,"mirror_url":null,"open_issues_count":101,"forks":191,"open_issues":101,"watchers":1012,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls/381"},"html":{"href":"https://github.com/JustinTulloss/zeromq.node/pull/381"},"issue":{"href":"https://api.github.com/repos/JustinTulloss/zeromq.node/issues/381"},"comments":{"href":"https://api.github.com/repos/JustinTulloss/zeromq.node/issues/381/comments"},"review_comments":{"href":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls/381/comments"},"review_comment":{"href":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls/381/commits"},"statuses":{"href":"https://api.github.com/repos/JustinTulloss/zeromq.node/statuses/68c1770c14b2c127568808f43b4c7c47c8da9c68"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ronkorving","id":631240,"avatar_url":"https://avatars.githubusercontent.com/u/631240?v=3","gravatar_id":"","url":"https://api.github.com/users/ronkorving","html_url":"https://github.com/ronkorving","followers_url":"https://api.github.com/users/ronkorving/followers","following_url":"https://api.github.com/users/ronkorving/following{/other_user}","gists_url":"https://api.github.com/users/ronkorving/gists{/gist_id}","starred_url":"https://api.github.com/users/ronkorving/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronkorving/subscriptions","organizations_url":"https://api.github.com/users/ronkorving/orgs","repos_url":"https://api.github.com/users/ronkorving/repos","events_url":"https://api.github.com/users/ronkorving/events{/privacy}","received_events_url":"https://api.github.com/users/ronkorving/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":5,"deletions":1,"changed_files":1}}