{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/33702172","id":33702172,"diff_hunk":"@@ -1,46 +1,48 @@\n-(function(Backbone) {\n-    var NotificationModel = Backbone.Model.extend({\n-        defaults: {\n-            /**\n-             * The type of notification to be shown.\n-             * Supported types are \"confirmation\", \"warning\" and \"error\".\n-             */\n-            type: \"confirmation\",\n-            /**\n-             * The title to be shown for the notification. This string should be short so\n-             * that it can be shown on a single line.\n-             */\n-            title: \"\",\n-            /**\n-             * An optional message giving more details for the notification. This string can be as long\n-             * as needed and will wrap.\n-             */\n-            message: \"\",\n-            /**\n-             * An optional array of detail messages to be shown beneath the title and message. This is\n-             * typically used to enumerate a set of warning or error conditions that occurred.\n-             */\n-            details: [],\n-            /**\n-             * The text label to be shown for an action button, or null if there is no associated action.\n-             */\n-            actionText: null,\n-            /**\n-             * The class to be added to the action button. This allows selectors to be written that can\n-             * target the action button directly.\n-             */\n-            actionClass: \"\",\n-            /**\n-             * An optional icon class to be shown before the text on the action button.\n-             */\n-            actionIconClass: \"\",\n-            /**\n-             * An optional callback that will be invoked when the user clicks on the action button.\n-             */\n-            actionCallback: null\n-        }\n+;(function (define) {\n+    'use strict';\n+    define(['backbone'], function(Backbone) {","path":"lms/static/js/models/notification.js","position":44,"original_position":44,"commit_id":"4c56a8a19f98c1251363f39034240cca54c3ddbd","original_commit_id":"4c56a8a19f98c1251363f39034240cca54c3ddbd","user":{"login":"cahrens","id":484484,"avatar_url":"https://avatars.githubusercontent.com/u/484484?v=3","gravatar_id":"","url":"https://api.github.com/users/cahrens","html_url":"https://github.com/cahrens","followers_url":"https://api.github.com/users/cahrens/followers","following_url":"https://api.github.com/users/cahrens/following{/other_user}","gists_url":"https://api.github.com/users/cahrens/gists{/gist_id}","starred_url":"https://api.github.com/users/cahrens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cahrens/subscriptions","organizations_url":"https://api.github.com/users/cahrens/orgs","repos_url":"https://api.github.com/users/cahrens/repos","events_url":"https://api.github.com/users/cahrens/events{/privacy}","received_events_url":"https://api.github.com/users/cahrens/received_events","type":"User","site_admin":false},"body":"I don't think you can convert notification to RequireJS because there are things using it that do not use RequireJS. Plus, it is explicitly loaded in instructor_dashboard_2.html.","created_at":"2015-07-01T17:28:13Z","updated_at":"2015-07-01T17:28:13Z","html_url":"https://github.com/edx/edx-platform/pull/8737#discussion_r33702172","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/8737","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/33702172"},"html":{"href":"https://github.com/edx/edx-platform/pull/8737#discussion_r33702172"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/8737"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/8737","id":38989478,"html_url":"https://github.com/edx/edx-platform/pull/8737","diff_url":"https://github.com/edx/edx-platform/pull/8737.diff","patch_url":"https://github.com/edx/edx-platform/pull/8737.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/8737","number":8737,"state":"open","locked":false,"title":"WIP? Convert cohort JS to use RequireJS.","user":{"login":"dianakhuang","id":2952947,"avatar_url":"https://avatars.githubusercontent.com/u/2952947?v=3","gravatar_id":"","url":"https://api.github.com/users/dianakhuang","html_url":"https://github.com/dianakhuang","followers_url":"https://api.github.com/users/dianakhuang/followers","following_url":"https://api.github.com/users/dianakhuang/following{/other_user}","gists_url":"https://api.github.com/users/dianakhuang/gists{/gist_id}","starred_url":"https://api.github.com/users/dianakhuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dianakhuang/subscriptions","organizations_url":"https://api.github.com/users/dianakhuang/orgs","repos_url":"https://api.github.com/users/dianakhuang/repos","events_url":"https://api.github.com/users/dianakhuang/events{/privacy}","received_events_url":"https://api.github.com/users/dianakhuang/received_events","type":"User","site_admin":false},"body":"@andy-armstrong Here's my branch. Let me know if/when I need to point this PR at a different branch.","created_at":"2015-07-01T14:45:14Z","updated_at":"2015-07-01T17:28:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f30cff02b7251a2473f75048ec5d165190551fe1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/8737/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/8737/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/8737/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/4c56a8a19f98c1251363f39034240cca54c3ddbd","head":{"label":"edx:diana/requirejs-cohorts","ref":"diana/requirejs-cohorts","sha":"4c56a8a19f98c1251363f39034240cca54c3ddbd","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-07-01T16:36:17Z","pushed_at":"2015-07-01T17:24:36Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":2069890,"stargazers_count":2022,"watchers_count":2022,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1157,"mirror_url":null,"open_issues_count":155,"forks":1157,"open_issues":155,"watchers":2022,"default_branch":"master"}},"base":{"label":"edx:andya/lms-requirejs","ref":"andya/lms-requirejs","sha":"0bf6d5131bfc9d41a0a98a82da8086d8e810d944","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-07-01T16:36:17Z","pushed_at":"2015-07-01T17:24:36Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":2069890,"stargazers_count":2022,"watchers_count":2022,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1157,"mirror_url":null,"open_issues_count":155,"forks":1157,"open_issues":155,"watchers":2022,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/8737"},"html":{"href":"https://github.com/edx/edx-platform/pull/8737"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/8737"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/8737/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/8737/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/8737/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/4c56a8a19f98c1251363f39034240cca54c3ddbd"}}}}