{"action":"created","issue":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/9055","labels_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/9055/labels{/name}","comments_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/9055/comments","events_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/9055/events","html_url":"https://github.com/gitlabhq/gitlabhq/pull/9055","id":65184859,"number":9055,"title":"[WIP] Use rails-bootstrap-forms gem for form rendering","user":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":28,"created_at":"2015-03-30T10:44:39Z","updated_at":"2015-04-27T07:34:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/9055","html_url":"https://github.com/gitlabhq/gitlabhq/pull/9055","diff_url":"https://github.com/gitlabhq/gitlabhq/pull/9055.diff","patch_url":"https://github.com/gitlabhq/gitlabhq/pull/9055.patch"},"body":"This PR is related to #8470.\r\n\r\nThe goal is to use `rails-bootstrap-form` gem to simplify form rendering on bootstrap.\r\n\r\nTo do:\r\n\r\n - [x] Install rails-bootstrap-form gem\r\n - [ ] Rewrite all form rendering with bootstrap-form helpers (**admin section only** for the moment, next with another pull requests)\r\n - [ ] Wait for `btn-group` forms management: bootstrap-ruby/rails-bootstrap-forms#132\r\n - [ ] Wait \"HTML help block\" issue answer: https://github.com/bootstrap-ruby/rails-bootstrap-forms/issues/211. Concern those forms:\r\n  * https://github.com/gitlabhq/gitlabhq/blob/master/app/views/admin/applications/_form.html.haml#L17-L21\r\n - [ ] Wait \"Static control without label\" issue answer: https://github.com/bootstrap-ruby/rails-bootstrap-forms/issues/212. Concern those forms:\r\n  * https://github.com/gitlabhq/gitlabhq/blob/master/app/views/admin/broadcast_messages/index.html.haml#L14-L20\r\n - [ ] Wait \"Unwanted space with hide_label option on inline form\" answer: https://github.com/bootstrap-ruby/rails-bootstrap-forms/issues/214. Concern those forms:\r\n  * https://github.com/gitlabhq/gitlabhq/blob/master/app/views/admin/groups/show.html.haml#L61-L67\r\n  * https://github.com/gitlabhq/gitlabhq/blob/master/app/views/admin/users/index.html.haml#L24-L28\r\n - [ ] Wait \"Unwanted hidden input on check_box helper with bootstrap_form_tag\" answer: https://github.com/bootstrap-ruby/rails-bootstrap-forms/issues/215. Concern those forms:\r\n  * https://github.com/gitlabhq/gitlabhq/blob/master/app/views/admin/projects/index.html.haml#L6-L24\r\n - [ ] Wait \"Ability to create radio button without label?\" answer: https://github.com/bootstrap-ruby/rails-bootstrap-forms/issues/161. Concern those forms:\r\n  * https://github.com/gitlabhq/gitlabhq/blob/master/app/views/admin/services/_form.html.haml\r\n - [ ] Fix weird css issue: https://github.com/gitlabhq/gitlabhq/pull/9055#issuecomment-88881347\r\n - [ ] Add some notes on UI best practices documentation [form_for / form_tag / alert_messages / f.primary]\r\n - [ ] All tests should be green\r\n - [ ] Update CHANGELOG file\r\n\r\nPending questions:\r\n \r\n * Should we remove `.form-fieldset` class and add padding by default on `fieldset` element?\r\n * Is the new form error rendering correct?\r\n * Can Rubocop have custom rules detection? Could be useful to have a `form_for` usage detection, isn't it? (make `bootstrap_form_for` required. Use `text_field_without_bootstrap` is necessary)\r\n * Should I use static control field for special subforms? (https://github.com/gitlabhq/gitlabhq/pull/9055#issuecomment-87835413)\r\n  * No, use `form_group` instead.\r\n * OK for using required label css trick? (https://github.com/gitlabhq/gitlabhq/pull/9055#issuecomment-89258863)\r\n\r\nExternals links:\r\n\r\n * https://github.com/bootstrap-ruby/rails-bootstrap-forms\r\n\r\nPlease tell me if I have some other task to do on this subject.\r\n\r\nThanks."},"comment":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/comments/96535040","html_url":"https://github.com/gitlabhq/gitlabhq/pull/9055#issuecomment-96535040","issue_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/9055","id":96535040,"user":{"login":"randx","id":305940,"avatar_url":"https://avatars.githubusercontent.com/u/305940?v=3","gravatar_id":"","url":"https://api.github.com/users/randx","html_url":"https://github.com/randx","followers_url":"https://api.github.com/users/randx/followers","following_url":"https://api.github.com/users/randx/following{/other_user}","gists_url":"https://api.github.com/users/randx/gists{/gist_id}","starred_url":"https://api.github.com/users/randx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randx/subscriptions","organizations_url":"https://api.github.com/users/randx/orgs","repos_url":"https://api.github.com/users/randx/repos","events_url":"https://api.github.com/users/randx/events{/privacy}","received_events_url":"https://api.github.com/users/randx/received_events","type":"User","site_admin":false},"created_at":"2015-04-27T07:34:56Z","updated_at":"2015-04-27T07:34:56Z","body":"So try to fix tests here and prepare it for review before starting new section"}}