{"action":"created","comment":{"url":"https://api.github.com/repos/angular/material/pulls/comments/27140560","id":27140560,"diff_hunk":"@@ -16,63 +17,161 @@ $item-padding-top: 0px !default;\n $item-padding-right: 0px !default;\n $item-padding-left: 0px !default;\n $item-padding-bottom: 0px !default;\n+$list-item-padding-vertical: 0px !default;\n+$list-item-padding-horizontal: $baseline-grid * 2 !default;\n+$list-item-primary-width: $baseline-grid * 7 !default;\n+$list-item-primary-avatar-width: $baseline-grid * 5 !default;\n+$list-item-primary-icon-width: $baseline-grid * 3 !default;\n+$list-item-secondary-left-margin: $baseline-grid * 2 !default;\n+$list-item-text-padding-top: $baseline-grid * 2 !default;\n+$list-item-text-padding-bottom: $baseline-grid * 2.5 !default;\n \n md-list {\n+  display: block;\n   padding: $list-padding-top $list-padding-right $list-padding-bottom $list-padding-left;\n+\n+  .md-subheader {\n+    font-weight: 500;\n+    font-size: 0.875em;\n+  }\n }\n \n md-item {\n-\n+  &.md-no-style,\n+  .md-no-style {\n+    padding: $list-item-padding-vertical $list-item-padding-horizontal;\n+    flex: 1;\n+  }\n+  &.md-with-secondary {\n+    padding-right: $list-item-padding-horizontal;\n+  }\n+  &.md-clickable:hover {\n+    cursor: pointer;\n+  }\n }\n \n-md-item-content {\n+md-item, md-item > .md-no-style {\n   display: flex;\n+  justify-content: flex-start;\n   align-items: center;\n-  flex-direction: row;\n-  box-sizing: border-box;\n \n-  position: relative;\n+  // Layout for controls in primary or secondary divs, or auto-infered first child\n+  & > div.md-primary > md-icon,\n+  & > div.md-secondary > md-icon,\n+  & > md-icon:first-child, \n+  > md-icon.md-secondary {\n+    width: $list-item-primary-icon-width;\n+    margin-top: 12px;\n+    margin-bottom: 12px;\n+    box-sizing: content-box;\n+    &:focus {\n+      padding: 6px;","path":"src/components/list/list.scss","position":75,"original_position":75,"commit_id":"8c225f9065ea4b9061a209fae82d672dca808f90","original_commit_id":"8c225f9065ea4b9061a209fae82d672dca808f90","user":{"login":"rschmukler","id":651740,"avatar_url":"https://avatars.githubusercontent.com/u/651740?v=3","gravatar_id":"","url":"https://api.github.com/users/rschmukler","html_url":"https://github.com/rschmukler","followers_url":"https://api.github.com/users/rschmukler/followers","following_url":"https://api.github.com/users/rschmukler/following{/other_user}","gists_url":"https://api.github.com/users/rschmukler/gists{/gist_id}","starred_url":"https://api.github.com/users/rschmukler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rschmukler/subscriptions","organizations_url":"https://api.github.com/users/rschmukler/orgs","repos_url":"https://api.github.com/users/rschmukler/repos","events_url":"https://api.github.com/users/rschmukler/events{/privacy}","received_events_url":"https://api.github.com/users/rschmukler/received_events","type":"User","site_admin":false},"body":"So that icon buttons look good. If you tab through some of the secondary controls (icons with `ng-click`) you can see how they get applied.","created_at":"2015-03-25T16:51:05Z","updated_at":"2015-03-25T16:51:05Z","html_url":"https://github.com/angular/material/pull/2021#discussion_r27140560","pull_request_url":"https://api.github.com/repos/angular/material/pulls/2021","_links":{"self":{"href":"https://api.github.com/repos/angular/material/pulls/comments/27140560"},"html":{"href":"https://github.com/angular/material/pull/2021#discussion_r27140560"},"pull_request":{"href":"https://api.github.com/repos/angular/material/pulls/2021"}}},"pull_request":{"url":"https://api.github.com/repos/angular/material/pulls/2021","id":31870745,"html_url":"https://github.com/angular/material/pull/2021","diff_url":"https://github.com/angular/material/pull/2021.diff","patch_url":"https://github.com/angular/material/pull/2021.patch","issue_url":"https://api.github.com/repos/angular/material/issues/2021","number":2021,"state":"open","locked":false,"title":"Add List Controls","user":{"login":"rschmukler","id":651740,"avatar_url":"https://avatars.githubusercontent.com/u/651740?v=3","gravatar_id":"","url":"https://api.github.com/users/rschmukler","html_url":"https://github.com/rschmukler","followers_url":"https://api.github.com/users/rschmukler/followers","following_url":"https://api.github.com/users/rschmukler/following{/other_user}","gists_url":"https://api.github.com/users/rschmukler/gists{/gist_id}","starred_url":"https://api.github.com/users/rschmukler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rschmukler/subscriptions","organizations_url":"https://api.github.com/users/rschmukler/orgs","repos_url":"https://api.github.com/users/rschmukler/repos","events_url":"https://api.github.com/users/rschmukler/events{/privacy}","received_events_url":"https://api.github.com/users/rschmukler/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-24T21:15:24Z","updated_at":"2015-03-25T16:51:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ac45aada1584ebb151a74b91498ab95a82e9797","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular/material/pulls/2021/commits","review_comments_url":"https://api.github.com/repos/angular/material/pulls/2021/comments","review_comment_url":"https://api.github.com/repos/angular/material/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/material/issues/2021/comments","statuses_url":"https://api.github.com/repos/angular/material/statuses/8c225f9065ea4b9061a209fae82d672dca808f90","head":{"label":"angular:wip-list-control","ref":"wip-list-control","sha":"8c225f9065ea4b9061a209fae82d672dca808f90","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":21399598,"name":"material","full_name":"angular/material","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/material","description":"Material design for Angular","fork":false,"url":"https://api.github.com/repos/angular/material","forks_url":"https://api.github.com/repos/angular/material/forks","keys_url":"https://api.github.com/repos/angular/material/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/material/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/material/teams","hooks_url":"https://api.github.com/repos/angular/material/hooks","issue_events_url":"https://api.github.com/repos/angular/material/issues/events{/number}","events_url":"https://api.github.com/repos/angular/material/events","assignees_url":"https://api.github.com/repos/angular/material/assignees{/user}","branches_url":"https://api.github.com/repos/angular/material/branches{/branch}","tags_url":"https://api.github.com/repos/angular/material/tags","blobs_url":"https://api.github.com/repos/angular/material/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/material/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/material/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/material/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/material/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/material/languages","stargazers_url":"https://api.github.com/repos/angular/material/stargazers","contributors_url":"https://api.github.com/repos/angular/material/contributors","subscribers_url":"https://api.github.com/repos/angular/material/subscribers","subscription_url":"https://api.github.com/repos/angular/material/subscription","commits_url":"https://api.github.com/repos/angular/material/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/material/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/material/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/material/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/material/contents/{+path}","compare_url":"https://api.github.com/repos/angular/material/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/material/merges","archive_url":"https://api.github.com/repos/angular/material/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/material/downloads","issues_url":"https://api.github.com/repos/angular/material/issues{/number}","pulls_url":"https://api.github.com/repos/angular/material/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/material/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/material/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/material/labels{/name}","releases_url":"https://api.github.com/repos/angular/material/releases{/id}","created_at":"2014-07-01T19:20:06Z","updated_at":"2015-03-25T16:50:57Z","pushed_at":"2015-03-25T16:46:02Z","git_url":"git://github.com/angular/material.git","ssh_url":"git@github.com:angular/material.git","clone_url":"https://github.com/angular/material.git","svn_url":"https://github.com/angular/material","homepage":"https://material.angularjs.org/","size":82462,"stargazers_count":7485,"watchers_count":7485,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1024,"mirror_url":null,"open_issues_count":491,"forks":1024,"open_issues":491,"watchers":7485,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"b682e36a55c37f41cf9004645916cba07b6ef805","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":21399598,"name":"material","full_name":"angular/material","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/material","description":"Material design for Angular","fork":false,"url":"https://api.github.com/repos/angular/material","forks_url":"https://api.github.com/repos/angular/material/forks","keys_url":"https://api.github.com/repos/angular/material/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/material/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/material/teams","hooks_url":"https://api.github.com/repos/angular/material/hooks","issue_events_url":"https://api.github.com/repos/angular/material/issues/events{/number}","events_url":"https://api.github.com/repos/angular/material/events","assignees_url":"https://api.github.com/repos/angular/material/assignees{/user}","branches_url":"https://api.github.com/repos/angular/material/branches{/branch}","tags_url":"https://api.github.com/repos/angular/material/tags","blobs_url":"https://api.github.com/repos/angular/material/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/material/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/material/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/material/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/material/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/material/languages","stargazers_url":"https://api.github.com/repos/angular/material/stargazers","contributors_url":"https://api.github.com/repos/angular/material/contributors","subscribers_url":"https://api.github.com/repos/angular/material/subscribers","subscription_url":"https://api.github.com/repos/angular/material/subscription","commits_url":"https://api.github.com/repos/angular/material/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/material/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/material/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/material/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/material/contents/{+path}","compare_url":"https://api.github.com/repos/angular/material/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/material/merges","archive_url":"https://api.github.com/repos/angular/material/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/material/downloads","issues_url":"https://api.github.com/repos/angular/material/issues{/number}","pulls_url":"https://api.github.com/repos/angular/material/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/material/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/material/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/material/labels{/name}","releases_url":"https://api.github.com/repos/angular/material/releases{/id}","created_at":"2014-07-01T19:20:06Z","updated_at":"2015-03-25T16:50:57Z","pushed_at":"2015-03-25T16:46:02Z","git_url":"git://github.com/angular/material.git","ssh_url":"git@github.com:angular/material.git","clone_url":"https://github.com/angular/material.git","svn_url":"https://github.com/angular/material","homepage":"https://material.angularjs.org/","size":82462,"stargazers_count":7485,"watchers_count":7485,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1024,"mirror_url":null,"open_issues_count":491,"forks":1024,"open_issues":491,"watchers":7485,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/material/pulls/2021"},"html":{"href":"https://github.com/angular/material/pull/2021"},"issue":{"href":"https://api.github.com/repos/angular/material/issues/2021"},"comments":{"href":"https://api.github.com/repos/angular/material/issues/2021/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/material/pulls/2021/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/material/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/material/pulls/2021/commits"},"statuses":{"href":"https://api.github.com/repos/angular/material/statuses/8c225f9065ea4b9061a209fae82d672dca808f90"}}}}