{"action":"created","comment":{"url":"https://api.github.com/repos/bonobos/spree/pulls/comments/35248133","id":35248133,"diff_hunk":"@@ -29,4 +29,12 @@\n   <%= link_to \"(#{Spree.t(:what_is_this)})\", spree.content_path('cvv'), :target => '_blank', \"data-hook\" => \"cvv_link\", :id => \"cvv_link\" %>\n </p>\n \n+<% if @order.bill_address %>\n+  <div style=\"display:none\">","path":"frontend/app/views/spree/checkout/payment/_gateway.html.erb","position":5,"original_position":5,"commit_id":"f4093bec274b00c4b29be90c328ccb1467686dc3","original_commit_id":"f4093bec274b00c4b29be90c328ccb1467686dc3","user":{"login":"jhawthorn","id":131752,"avatar_url":"https://avatars.githubusercontent.com/u/131752?v=3","gravatar_id":"","url":"https://api.github.com/users/jhawthorn","html_url":"https://github.com/jhawthorn","followers_url":"https://api.github.com/users/jhawthorn/followers","following_url":"https://api.github.com/users/jhawthorn/following{/other_user}","gists_url":"https://api.github.com/users/jhawthorn/gists{/gist_id}","starred_url":"https://api.github.com/users/jhawthorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhawthorn/subscriptions","organizations_url":"https://api.github.com/users/jhawthorn/orgs","repos_url":"https://api.github.com/users/jhawthorn/repos","events_url":"https://api.github.com/users/jhawthorn/events{/privacy}","received_events_url":"https://api.github.com/users/jhawthorn/received_events","type":"User","site_admin":false},"body":"I don't think so. I don't know about modern browsers, but it used to be the case that `display: none` fields weren't submitted with forms.\r\n\r\n`<input type=\"hidden\"` would be the right thing to use here, or even better would be handling it in ruby.","created_at":"2015-07-22T18:41:19Z","updated_at":"2015-07-22T18:41:19Z","html_url":"https://github.com/bonobos/spree/pull/430#discussion_r35248133","pull_request_url":"https://api.github.com/repos/bonobos/spree/pulls/430","_links":{"self":{"href":"https://api.github.com/repos/bonobos/spree/pulls/comments/35248133"},"html":{"href":"https://github.com/bonobos/spree/pull/430#discussion_r35248133"},"pull_request":{"href":"https://api.github.com/repos/bonobos/spree/pulls/430"}}},"pull_request":{"url":"https://api.github.com/repos/bonobos/spree/pulls/430","id":40509431,"html_url":"https://github.com/bonobos/spree/pull/430","diff_url":"https://github.com/bonobos/spree/pull/430.diff","patch_url":"https://github.com/bonobos/spree/pull/430.patch","issue_url":"https://api.github.com/repos/bonobos/spree/issues/430","number":430,"state":"open","locked":false,"title":"Add addresses to credit cards","user":{"login":"jordan-brough","id":23050,"avatar_url":"https://avatars.githubusercontent.com/u/23050?v=3","gravatar_id":"","url":"https://api.github.com/users/jordan-brough","html_url":"https://github.com/jordan-brough","followers_url":"https://api.github.com/users/jordan-brough/followers","following_url":"https://api.github.com/users/jordan-brough/following{/other_user}","gists_url":"https://api.github.com/users/jordan-brough/gists{/gist_id}","starred_url":"https://api.github.com/users/jordan-brough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordan-brough/subscriptions","organizations_url":"https://api.github.com/users/jordan-brough/orgs","repos_url":"https://api.github.com/users/jordan-brough/repos","events_url":"https://api.github.com/users/jordan-brough/events{/privacy}","received_events_url":"https://api.github.com/users/jordan-brough/received_events","type":"User","site_admin":false},"body":"Replaces #427.\r\n\r\nThis PR adds a spree_credit_cards.address_id field and updates Frontend and Admin to populate credit card addresses with the order's bill_address by default.\r\n\r\nI need to add some more specs but want to make sure everyone is good w/ this approach first.\r\n\r\nFor stores that would like to go even further and stop using the order.bill_address_id field entirely, the `Spree::Config[:order_bill_address_used]` preference can be set to false which will allow proceeding past the \"Customer Details\" step in the admin and also hide the order.bill_address fields in that step.\r\n\r\nThis includes a migration and a rake task to make a best effort at backfilling credit card address data.\r\n\r\nSee individual commits for details.\r\n\r\ncc @jhawthorn @gvaughn ","created_at":"2015-07-21T21:55:02Z","updated_at":"2015-07-22T18:41:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a0a9ab967c73909757f0c35bc28971dcd3aa640","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bonobos/spree/pulls/430/commits","review_comments_url":"https://api.github.com/repos/bonobos/spree/pulls/430/comments","review_comment_url":"https://api.github.com/repos/bonobos/spree/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bonobos/spree/issues/430/comments","statuses_url":"https://api.github.com/repos/bonobos/spree/statuses/f4093bec274b00c4b29be90c328ccb1467686dc3","head":{"label":"jordan-brough:credit-card-bill-address-v5","ref":"credit-card-bill-address-v5","sha":"f4093bec274b00c4b29be90c328ccb1467686dc3","user":{"login":"jordan-brough","id":23050,"avatar_url":"https://avatars.githubusercontent.com/u/23050?v=3","gravatar_id":"","url":"https://api.github.com/users/jordan-brough","html_url":"https://github.com/jordan-brough","followers_url":"https://api.github.com/users/jordan-brough/followers","following_url":"https://api.github.com/users/jordan-brough/following{/other_user}","gists_url":"https://api.github.com/users/jordan-brough/gists{/gist_id}","starred_url":"https://api.github.com/users/jordan-brough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordan-brough/subscriptions","organizations_url":"https://api.github.com/users/jordan-brough/orgs","repos_url":"https://api.github.com/users/jordan-brough/repos","events_url":"https://api.github.com/users/jordan-brough/events{/privacy}","received_events_url":"https://api.github.com/users/jordan-brough/received_events","type":"User","site_admin":false},"repo":{"id":18685104,"name":"spree","full_name":"jordan-brough/spree","owner":{"login":"jordan-brough","id":23050,"avatar_url":"https://avatars.githubusercontent.com/u/23050?v=3","gravatar_id":"","url":"https://api.github.com/users/jordan-brough","html_url":"https://github.com/jordan-brough","followers_url":"https://api.github.com/users/jordan-brough/followers","following_url":"https://api.github.com/users/jordan-brough/following{/other_user}","gists_url":"https://api.github.com/users/jordan-brough/gists{/gist_id}","starred_url":"https://api.github.com/users/jordan-brough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordan-brough/subscriptions","organizations_url":"https://api.github.com/users/jordan-brough/orgs","repos_url":"https://api.github.com/users/jordan-brough/repos","events_url":"https://api.github.com/users/jordan-brough/events{/privacy}","received_events_url":"https://api.github.com/users/jordan-brough/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jordan-brough/spree","description":"Spree is a complete open source e-commerce solution for Ruby on Rails.","fork":true,"url":"https://api.github.com/repos/jordan-brough/spree","forks_url":"https://api.github.com/repos/jordan-brough/spree/forks","keys_url":"https://api.github.com/repos/jordan-brough/spree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jordan-brough/spree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jordan-brough/spree/teams","hooks_url":"https://api.github.com/repos/jordan-brough/spree/hooks","issue_events_url":"https://api.github.com/repos/jordan-brough/spree/issues/events{/number}","events_url":"https://api.github.com/repos/jordan-brough/spree/events","assignees_url":"https://api.github.com/repos/jordan-brough/spree/assignees{/user}","branches_url":"https://api.github.com/repos/jordan-brough/spree/branches{/branch}","tags_url":"https://api.github.com/repos/jordan-brough/spree/tags","blobs_url":"https://api.github.com/repos/jordan-brough/spree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jordan-brough/spree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jordan-brough/spree/git/refs{/sha}","trees_url":"https://api.github.com/repos/jordan-brough/spree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jordan-brough/spree/statuses/{sha}","languages_url":"https://api.github.com/repos/jordan-brough/spree/languages","stargazers_url":"https://api.github.com/repos/jordan-brough/spree/stargazers","contributors_url":"https://api.github.com/repos/jordan-brough/spree/contributors","subscribers_url":"https://api.github.com/repos/jordan-brough/spree/subscribers","subscription_url":"https://api.github.com/repos/jordan-brough/spree/subscription","commits_url":"https://api.github.com/repos/jordan-brough/spree/commits{/sha}","git_commits_url":"https://api.github.com/repos/jordan-brough/spree/git/commits{/sha}","comments_url":"https://api.github.com/repos/jordan-brough/spree/comments{/number}","issue_comment_url":"https://api.github.com/repos/jordan-brough/spree/issues/comments{/number}","contents_url":"https://api.github.com/repos/jordan-brough/spree/contents/{+path}","compare_url":"https://api.github.com/repos/jordan-brough/spree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jordan-brough/spree/merges","archive_url":"https://api.github.com/repos/jordan-brough/spree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jordan-brough/spree/downloads","issues_url":"https://api.github.com/repos/jordan-brough/spree/issues{/number}","pulls_url":"https://api.github.com/repos/jordan-brough/spree/pulls{/number}","milestones_url":"https://api.github.com/repos/jordan-brough/spree/milestones{/number}","notifications_url":"https://api.github.com/repos/jordan-brough/spree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jordan-brough/spree/labels{/name}","releases_url":"https://api.github.com/repos/jordan-brough/spree/releases{/id}","created_at":"2014-04-11T18:53:35Z","updated_at":"2014-06-18T02:19:13Z","pushed_at":"2015-07-21T21:46:08Z","git_url":"git://github.com/jordan-brough/spree.git","ssh_url":"git@github.com:jordan-brough/spree.git","clone_url":"https://github.com/jordan-brough/spree.git","svn_url":"https://github.com/jordan-brough/spree","homepage":"http://spreecommerce.com","size":73701,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bonobos:2-2-dev","ref":"2-2-dev","sha":"9ad0106c4eeea7326507de4fe51f867f4c8455ae","user":{"login":"bonobos","id":78914,"avatar_url":"https://avatars.githubusercontent.com/u/78914?v=3","gravatar_id":"","url":"https://api.github.com/users/bonobos","html_url":"https://github.com/bonobos","followers_url":"https://api.github.com/users/bonobos/followers","following_url":"https://api.github.com/users/bonobos/following{/other_user}","gists_url":"https://api.github.com/users/bonobos/gists{/gist_id}","starred_url":"https://api.github.com/users/bonobos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonobos/subscriptions","organizations_url":"https://api.github.com/users/bonobos/orgs","repos_url":"https://api.github.com/users/bonobos/repos","events_url":"https://api.github.com/users/bonobos/events{/privacy}","received_events_url":"https://api.github.com/users/bonobos/received_events","type":"Organization","site_admin":false},"repo":{"id":12625383,"name":"spree","full_name":"bonobos/spree","owner":{"login":"bonobos","id":78914,"avatar_url":"https://avatars.githubusercontent.com/u/78914?v=3","gravatar_id":"","url":"https://api.github.com/users/bonobos","html_url":"https://github.com/bonobos","followers_url":"https://api.github.com/users/bonobos/followers","following_url":"https://api.github.com/users/bonobos/following{/other_user}","gists_url":"https://api.github.com/users/bonobos/gists{/gist_id}","starred_url":"https://api.github.com/users/bonobos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonobos/subscriptions","organizations_url":"https://api.github.com/users/bonobos/orgs","repos_url":"https://api.github.com/users/bonobos/repos","events_url":"https://api.github.com/users/bonobos/events{/privacy}","received_events_url":"https://api.github.com/users/bonobos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bonobos/spree","description":"Spree is a complete open source e-commerce solution for Ruby on Rails.","fork":true,"url":"https://api.github.com/repos/bonobos/spree","forks_url":"https://api.github.com/repos/bonobos/spree/forks","keys_url":"https://api.github.com/repos/bonobos/spree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bonobos/spree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bonobos/spree/teams","hooks_url":"https://api.github.com/repos/bonobos/spree/hooks","issue_events_url":"https://api.github.com/repos/bonobos/spree/issues/events{/number}","events_url":"https://api.github.com/repos/bonobos/spree/events","assignees_url":"https://api.github.com/repos/bonobos/spree/assignees{/user}","branches_url":"https://api.github.com/repos/bonobos/spree/branches{/branch}","tags_url":"https://api.github.com/repos/bonobos/spree/tags","blobs_url":"https://api.github.com/repos/bonobos/spree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bonobos/spree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bonobos/spree/git/refs{/sha}","trees_url":"https://api.github.com/repos/bonobos/spree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bonobos/spree/statuses/{sha}","languages_url":"https://api.github.com/repos/bonobos/spree/languages","stargazers_url":"https://api.github.com/repos/bonobos/spree/stargazers","contributors_url":"https://api.github.com/repos/bonobos/spree/contributors","subscribers_url":"https://api.github.com/repos/bonobos/spree/subscribers","subscription_url":"https://api.github.com/repos/bonobos/spree/subscription","commits_url":"https://api.github.com/repos/bonobos/spree/commits{/sha}","git_commits_url":"https://api.github.com/repos/bonobos/spree/git/commits{/sha}","comments_url":"https://api.github.com/repos/bonobos/spree/comments{/number}","issue_comment_url":"https://api.github.com/repos/bonobos/spree/issues/comments{/number}","contents_url":"https://api.github.com/repos/bonobos/spree/contents/{+path}","compare_url":"https://api.github.com/repos/bonobos/spree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bonobos/spree/merges","archive_url":"https://api.github.com/repos/bonobos/spree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bonobos/spree/downloads","issues_url":"https://api.github.com/repos/bonobos/spree/issues{/number}","pulls_url":"https://api.github.com/repos/bonobos/spree/pulls{/number}","milestones_url":"https://api.github.com/repos/bonobos/spree/milestones{/number}","notifications_url":"https://api.github.com/repos/bonobos/spree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bonobos/spree/labels{/name}","releases_url":"https://api.github.com/repos/bonobos/spree/releases{/id}","created_at":"2013-09-05T18:28:25Z","updated_at":"2015-05-07T18:58:45Z","pushed_at":"2015-07-22T16:50:15Z","git_url":"git://github.com/bonobos/spree.git","ssh_url":"git@github.com:bonobos/spree.git","clone_url":"https://github.com/bonobos/spree.git","svn_url":"https://github.com/bonobos/spree","homepage":"http://spreecommerce.com","size":80866,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":1,"default_branch":"2-2-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/bonobos/spree/pulls/430"},"html":{"href":"https://github.com/bonobos/spree/pull/430"},"issue":{"href":"https://api.github.com/repos/bonobos/spree/issues/430"},"comments":{"href":"https://api.github.com/repos/bonobos/spree/issues/430/comments"},"review_comments":{"href":"https://api.github.com/repos/bonobos/spree/pulls/430/comments"},"review_comment":{"href":"https://api.github.com/repos/bonobos/spree/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bonobos/spree/pulls/430/commits"},"statuses":{"href":"https://api.github.com/repos/bonobos/spree/statuses/f4093bec274b00c4b29be90c328ccb1467686dc3"}}}}