{"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/pulls/2","id":47018367,"html_url":"https://github.com/uberVU/eslint-plugin-ubervu/pull/2","diff_url":"https://github.com/uberVU/eslint-plugin-ubervu/pull/2.diff","patch_url":"https://github.com/uberVU/eslint-plugin-ubervu/pull/2.patch","issue_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/issues/2","number":2,"state":"open","locked":false,"title":"Add indent function arguments rule","user":{"login":"flavius-tirnacop-hs","id":13434505,"avatar_url":"https://avatars.githubusercontent.com/u/13434505?v=3","gravatar_id":"","url":"https://api.github.com/users/flavius-tirnacop-hs","html_url":"https://github.com/flavius-tirnacop-hs","followers_url":"https://api.github.com/users/flavius-tirnacop-hs/followers","following_url":"https://api.github.com/users/flavius-tirnacop-hs/following{/other_user}","gists_url":"https://api.github.com/users/flavius-tirnacop-hs/gists{/gist_id}","starred_url":"https://api.github.com/users/flavius-tirnacop-hs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flavius-tirnacop-hs/subscriptions","organizations_url":"https://api.github.com/users/flavius-tirnacop-hs/orgs","repos_url":"https://api.github.com/users/flavius-tirnacop-hs/repos","events_url":"https://api.github.com/users/flavius-tirnacop-hs/events{/privacy}","received_events_url":"https://api.github.com/users/flavius-tirnacop-hs/received_events","type":"User","site_admin":false},"body":"## Need\r\n\r\n```gherkin\r\nAs a developer\r\nI want to have my function arguments properly indented\r\nSo that I can write quality code faster.\r\n```\r\n\r\n## Deliverables\r\n\r\nA new rule called `indent-function-args`  that will check if function arguments are properly indented as follows:\r\n\r\nCase 1 - Indent at 4 spaces\r\n```js\r\nfoobar(arg1,\r\n    arg2);\r\n```\r\nCase 2 - Indent at parenthesis\r\n```js\r\nfoo(arg1,\r\n    arg2);\r\n```\r\nCase 3 - Indent at 4 spaces from previous line indent\r\n```js\r\nvar foo = bar(arg1, arg2,\r\n    arg3, arg4);\r\n```\r\nCase 4 - arg2 is indented at 4 spaces so arg3 should also be indented at 4 spaces. Rule will output error message \"Indent at 4 spaces\"\r\n```js\r\nfoobar(arg1,\r\n    arg2,\r\n      arg3);\r\n```\r\nCase 5 - arg2 is indented at parenthesis so arg3 should also be indented at parenthesis. Rule will output error message \"Indent at parenthesis\"\r\n```js\r\nfoobar(arg1,\r\n       arg2,\r\n    arg3);\r\n```\r\nCase 6 - Multiple arguments per line should not affect the rule behaviour.\r\n```js\r\nfoobar(arg1,\r\n       arg2, arg3,\r\n       arg4,\r\n       arg5);\r\n```\r\nCase 7 - Multiple line arguments should not affect the rule behaviour.\r\n```js\r\nfoo({\r\n  a: 2,\r\n  b: 3\r\n}, arg2);\r\n```\r\n## Solution\r\n\r\n- [ ] The rule will match for `CallExpression` AST nodes and will check indentation for each of their children (attribute nodes).\r\nSample AST node:\r\n```json\r\n\"expression\": {\r\n    \"type\": \"CallExpression\",\r\n    \"callee\": {\r\n        \"type\": \"Identifier\",\r\n        \"name\": \"foobar\"\r\n    },\r\n    \"arguments\": [\r\n        {\r\n            \"type\": \"Identifier\",\r\n            \"name\": \"arg1\"\r\n        },\r\n        {\r\n            \"type\": \"Identifier\",\r\n            \"name\": \"arg2\"\r\n        }\r\n    ]\r\n}\r\n```\r\n- [ ] Write tests to validate implementation (in `test/lib/rules/indent-function-args.js`)","created_at":"2015-10-07T12:03:46Z","updated_at":"2015-10-07T12:03:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68362dc27fe2e657e94c82fd49c072315e2daccb","assignee":{"login":"flavius-tirnacop-hs","id":13434505,"avatar_url":"https://avatars.githubusercontent.com/u/13434505?v=3","gravatar_id":"","url":"https://api.github.com/users/flavius-tirnacop-hs","html_url":"https://github.com/flavius-tirnacop-hs","followers_url":"https://api.github.com/users/flavius-tirnacop-hs/followers","following_url":"https://api.github.com/users/flavius-tirnacop-hs/following{/other_user}","gists_url":"https://api.github.com/users/flavius-tirnacop-hs/gists{/gist_id}","starred_url":"https://api.github.com/users/flavius-tirnacop-hs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flavius-tirnacop-hs/subscriptions","organizations_url":"https://api.github.com/users/flavius-tirnacop-hs/orgs","repos_url":"https://api.github.com/users/flavius-tirnacop-hs/repos","events_url":"https://api.github.com/users/flavius-tirnacop-hs/events{/privacy}","received_events_url":"https://api.github.com/users/flavius-tirnacop-hs/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/pulls/2/commits","review_comments_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/pulls/2/comments","review_comment_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/issues/2/comments","statuses_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/statuses/bfe365e68425201fa96d3dfff709205109b94b94","head":{"label":"uberVU:2-indent-function-arguments","ref":"2-indent-function-arguments","sha":"bfe365e68425201fa96d3dfff709205109b94b94","user":{"login":"uberVU","id":1199831,"avatar_url":"https://avatars.githubusercontent.com/u/1199831?v=3","gravatar_id":"","url":"https://api.github.com/users/uberVU","html_url":"https://github.com/uberVU","followers_url":"https://api.github.com/users/uberVU/followers","following_url":"https://api.github.com/users/uberVU/following{/other_user}","gists_url":"https://api.github.com/users/uberVU/gists{/gist_id}","starred_url":"https://api.github.com/users/uberVU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uberVU/subscriptions","organizations_url":"https://api.github.com/users/uberVU/orgs","repos_url":"https://api.github.com/users/uberVU/repos","events_url":"https://api.github.com/users/uberVU/events{/privacy}","received_events_url":"https://api.github.com/users/uberVU/received_events","type":"Organization","site_admin":false},"repo":{"id":43545518,"name":"eslint-plugin-ubervu","full_name":"uberVU/eslint-plugin-ubervu","owner":{"login":"uberVU","id":1199831,"avatar_url":"https://avatars.githubusercontent.com/u/1199831?v=3","gravatar_id":"","url":"https://api.github.com/users/uberVU","html_url":"https://github.com/uberVU","followers_url":"https://api.github.com/users/uberVU/followers","following_url":"https://api.github.com/users/uberVU/following{/other_user}","gists_url":"https://api.github.com/users/uberVU/gists{/gist_id}","starred_url":"https://api.github.com/users/uberVU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uberVU/subscriptions","organizations_url":"https://api.github.com/users/uberVU/orgs","repos_url":"https://api.github.com/users/uberVU/repos","events_url":"https://api.github.com/users/uberVU/events{/privacy}","received_events_url":"https://api.github.com/users/uberVU/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uberVU/eslint-plugin-ubervu","description":"ESLint rules applicable to the uberVU org","fork":false,"url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu","forks_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/forks","keys_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/teams","hooks_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/hooks","issue_events_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/issues/events{/number}","events_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/events","assignees_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/assignees{/user}","branches_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/branches{/branch}","tags_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/tags","blobs_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/git/refs{/sha}","trees_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/statuses/{sha}","languages_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/languages","stargazers_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/stargazers","contributors_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/contributors","subscribers_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/subscribers","subscription_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/subscription","commits_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/commits{/sha}","git_commits_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/git/commits{/sha}","comments_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/comments{/number}","issue_comment_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/issues/comments{/number}","contents_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/contents/{+path}","compare_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/merges","archive_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/downloads","issues_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/issues{/number}","pulls_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/pulls{/number}","milestones_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/milestones{/number}","notifications_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/labels{/name}","releases_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/releases{/id}","created_at":"2015-10-02T09:41:53Z","updated_at":"2015-10-02T13:31:57Z","pushed_at":"2015-10-07T12:03:47Z","git_url":"git://github.com/uberVU/eslint-plugin-ubervu.git","ssh_url":"git@github.com:uberVU/eslint-plugin-ubervu.git","clone_url":"https://github.com/uberVU/eslint-plugin-ubervu.git","svn_url":"https://github.com/uberVU/eslint-plugin-ubervu","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"uberVU:master","ref":"master","sha":"57927680370f19338c00b173c8d31f909b121703","user":{"login":"uberVU","id":1199831,"avatar_url":"https://avatars.githubusercontent.com/u/1199831?v=3","gravatar_id":"","url":"https://api.github.com/users/uberVU","html_url":"https://github.com/uberVU","followers_url":"https://api.github.com/users/uberVU/followers","following_url":"https://api.github.com/users/uberVU/following{/other_user}","gists_url":"https://api.github.com/users/uberVU/gists{/gist_id}","starred_url":"https://api.github.com/users/uberVU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uberVU/subscriptions","organizations_url":"https://api.github.com/users/uberVU/orgs","repos_url":"https://api.github.com/users/uberVU/repos","events_url":"https://api.github.com/users/uberVU/events{/privacy}","received_events_url":"https://api.github.com/users/uberVU/received_events","type":"Organization","site_admin":false},"repo":{"id":43545518,"name":"eslint-plugin-ubervu","full_name":"uberVU/eslint-plugin-ubervu","owner":{"login":"uberVU","id":1199831,"avatar_url":"https://avatars.githubusercontent.com/u/1199831?v=3","gravatar_id":"","url":"https://api.github.com/users/uberVU","html_url":"https://github.com/uberVU","followers_url":"https://api.github.com/users/uberVU/followers","following_url":"https://api.github.com/users/uberVU/following{/other_user}","gists_url":"https://api.github.com/users/uberVU/gists{/gist_id}","starred_url":"https://api.github.com/users/uberVU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uberVU/subscriptions","organizations_url":"https://api.github.com/users/uberVU/orgs","repos_url":"https://api.github.com/users/uberVU/repos","events_url":"https://api.github.com/users/uberVU/events{/privacy}","received_events_url":"https://api.github.com/users/uberVU/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uberVU/eslint-plugin-ubervu","description":"ESLint rules applicable to the uberVU org","fork":false,"url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu","forks_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/forks","keys_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/teams","hooks_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/hooks","issue_events_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/issues/events{/number}","events_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/events","assignees_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/assignees{/user}","branches_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/branches{/branch}","tags_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/tags","blobs_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/git/refs{/sha}","trees_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/statuses/{sha}","languages_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/languages","stargazers_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/stargazers","contributors_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/contributors","subscribers_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/subscribers","subscription_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/subscription","commits_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/commits{/sha}","git_commits_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/git/commits{/sha}","comments_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/comments{/number}","issue_comment_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/issues/comments{/number}","contents_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/contents/{+path}","compare_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/merges","archive_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/downloads","issues_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/issues{/number}","pulls_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/pulls{/number}","milestones_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/milestones{/number}","notifications_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/labels{/name}","releases_url":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/releases{/id}","created_at":"2015-10-02T09:41:53Z","updated_at":"2015-10-02T13:31:57Z","pushed_at":"2015-10-07T12:03:47Z","git_url":"git://github.com/uberVU/eslint-plugin-ubervu.git","ssh_url":"git@github.com:uberVU/eslint-plugin-ubervu.git","clone_url":"https://github.com/uberVU/eslint-plugin-ubervu.git","svn_url":"https://github.com/uberVU/eslint-plugin-ubervu","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/pulls/2"},"html":{"href":"https://github.com/uberVU/eslint-plugin-ubervu/pull/2"},"issue":{"href":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/issues/2"},"comments":{"href":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/uberVU/eslint-plugin-ubervu/statuses/bfe365e68425201fa96d3dfff709205109b94b94"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":0,"commits":2,"additions":282,"deletions":2,"changed_files":4}}