{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy/pulls/comments/33604890","id":33604890,"diff_hunk":"@@ -732,7 +732,7 @@ class Ellipse2D(Fittable2DModel):\n     y_0 = Parameter()\n     a = Parameter()\n     b = Parameter()\n-    theta = Parameter()\n+    theta = Parameter(default=0)","path":"astropy/modeling/functional_models.py","position":5,"original_position":5,"commit_id":"e5433407af2befef16eda6ebbb79c15f0b64c267","original_commit_id":"e5433407af2befef16eda6ebbb79c15f0b64c267","user":{"login":"embray","id":676149,"avatar_url":"https://avatars.githubusercontent.com/u/676149?v=3","gravatar_id":"","url":"https://api.github.com/users/embray","html_url":"https://github.com/embray","followers_url":"https://api.github.com/users/embray/followers","following_url":"https://api.github.com/users/embray/following{/other_user}","gists_url":"https://api.github.com/users/embray/gists{/gist_id}","starred_url":"https://api.github.com/users/embray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embray/subscriptions","organizations_url":"https://api.github.com/users/embray/orgs","repos_url":"https://api.github.com/users/embray/repos","events_url":"https://api.github.com/users/embray/events{/privacy}","received_events_url":"https://api.github.com/users/embray/received_events","type":"User","site_admin":false},"body":"No, that's an oversight too.","created_at":"2015-06-30T18:13:57Z","updated_at":"2015-06-30T18:13:57Z","html_url":"https://github.com/astropy/astropy/pull/3903#discussion_r33604890","pull_request_url":"https://api.github.com/repos/astropy/astropy/pulls/3903","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments/33604890"},"html":{"href":"https://github.com/astropy/astropy/pull/3903#discussion_r33604890"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy/pulls/3903"}}},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/3903","id":38841368,"html_url":"https://github.com/astropy/astropy/pull/3903","diff_url":"https://github.com/astropy/astropy/pull/3903.diff","patch_url":"https://github.com/astropy/astropy/pull/3903.patch","issue_url":"https://api.github.com/repos/astropy/astropy/issues/3903","number":3903,"state":"open","locked":false,"title":"Add default value for Ellipse2D model theta parameter.","user":{"login":"patti","id":4968596,"avatar_url":"https://avatars.githubusercontent.com/u/4968596?v=3","gravatar_id":"","url":"https://api.github.com/users/patti","html_url":"https://github.com/patti","followers_url":"https://api.github.com/users/patti/followers","following_url":"https://api.github.com/users/patti/following{/other_user}","gists_url":"https://api.github.com/users/patti/gists{/gist_id}","starred_url":"https://api.github.com/users/patti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patti/subscriptions","organizations_url":"https://api.github.com/users/patti/orgs","repos_url":"https://api.github.com/users/patti/repos","events_url":"https://api.github.com/users/patti/events{/privacy}","received_events_url":"https://api.github.com/users/patti/received_events","type":"User","site_admin":false},"body":"The Ellipse2D model parameter `theta` is optional in the docstring but no default is set. I think it makes sense to be optional, so I set `default=0` rather than editing the doc. ","created_at":"2015-06-30T04:22:07Z","updated_at":"2015-06-30T18:13:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3090b06b10cc458f2b580d79316f2c8fbf5ebb1b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/astropy/astropy/pulls/3903/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy/pulls/3903/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/3903/comments","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/e5433407af2befef16eda6ebbb79c15f0b64c267","head":{"label":"patti:ellipse2d-theta-default","ref":"ellipse2d-theta-default","sha":"e5433407af2befef16eda6ebbb79c15f0b64c267","user":{"login":"patti","id":4968596,"avatar_url":"https://avatars.githubusercontent.com/u/4968596?v=3","gravatar_id":"","url":"https://api.github.com/users/patti","html_url":"https://github.com/patti","followers_url":"https://api.github.com/users/patti/followers","following_url":"https://api.github.com/users/patti/following{/other_user}","gists_url":"https://api.github.com/users/patti/gists{/gist_id}","starred_url":"https://api.github.com/users/patti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patti/subscriptions","organizations_url":"https://api.github.com/users/patti/orgs","repos_url":"https://api.github.com/users/patti/repos","events_url":"https://api.github.com/users/patti/events{/privacy}","received_events_url":"https://api.github.com/users/patti/received_events","type":"User","site_admin":false},"repo":{"id":32838725,"name":"astropy","full_name":"patti/astropy","owner":{"login":"patti","id":4968596,"avatar_url":"https://avatars.githubusercontent.com/u/4968596?v=3","gravatar_id":"","url":"https://api.github.com/users/patti","html_url":"https://github.com/patti","followers_url":"https://api.github.com/users/patti/followers","following_url":"https://api.github.com/users/patti/following{/other_user}","gists_url":"https://api.github.com/users/patti/gists{/gist_id}","starred_url":"https://api.github.com/users/patti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patti/subscriptions","organizations_url":"https://api.github.com/users/patti/orgs","repos_url":"https://api.github.com/users/patti/repos","events_url":"https://api.github.com/users/patti/events{/privacy}","received_events_url":"https://api.github.com/users/patti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/patti/astropy","description":"Repository for the Astropy core package","fork":true,"url":"https://api.github.com/repos/patti/astropy","forks_url":"https://api.github.com/repos/patti/astropy/forks","keys_url":"https://api.github.com/repos/patti/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patti/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patti/astropy/teams","hooks_url":"https://api.github.com/repos/patti/astropy/hooks","issue_events_url":"https://api.github.com/repos/patti/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/patti/astropy/events","assignees_url":"https://api.github.com/repos/patti/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/patti/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/patti/astropy/tags","blobs_url":"https://api.github.com/repos/patti/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patti/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patti/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/patti/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patti/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/patti/astropy/languages","stargazers_url":"https://api.github.com/repos/patti/astropy/stargazers","contributors_url":"https://api.github.com/repos/patti/astropy/contributors","subscribers_url":"https://api.github.com/repos/patti/astropy/subscribers","subscription_url":"https://api.github.com/repos/patti/astropy/subscription","commits_url":"https://api.github.com/repos/patti/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/patti/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/patti/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/patti/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/patti/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/patti/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patti/astropy/merges","archive_url":"https://api.github.com/repos/patti/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patti/astropy/downloads","issues_url":"https://api.github.com/repos/patti/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/patti/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/patti/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/patti/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patti/astropy/labels{/name}","releases_url":"https://api.github.com/repos/patti/astropy/releases{/id}","created_at":"2015-03-25T02:49:38Z","updated_at":"2015-03-25T02:49:43Z","pushed_at":"2015-06-30T04:17:23Z","git_url":"git://github.com/patti/astropy.git","ssh_url":"git@github.com:patti/astropy.git","clone_url":"https://github.com/patti/astropy.git","svn_url":"https://github.com/patti/astropy","homepage":"www.astropy.org","size":37218,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"b41d6bf612cd1847c672eb613ae2b4b716055232","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2081289,"name":"astropy","full_name":"astropy/astropy","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astropy","description":"Repository for the Astropy core package","fork":false,"url":"https://api.github.com/repos/astropy/astropy","forks_url":"https://api.github.com/repos/astropy/astropy/forks","keys_url":"https://api.github.com/repos/astropy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy/teams","hooks_url":"https://api.github.com/repos/astropy/astropy/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy/events","assignees_url":"https://api.github.com/repos/astropy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy/tags","blobs_url":"https://api.github.com/repos/astropy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy/subscription","commits_url":"https://api.github.com/repos/astropy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy/merges","archive_url":"https://api.github.com/repos/astropy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy/downloads","issues_url":"https://api.github.com/repos/astropy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy/releases{/id}","created_at":"2011-07-21T01:33:49Z","updated_at":"2015-06-28T19:39:52Z","pushed_at":"2015-06-30T17:43:53Z","git_url":"git://github.com/astropy/astropy.git","ssh_url":"git@github.com:astropy/astropy.git","clone_url":"https://github.com/astropy/astropy.git","svn_url":"https://github.com/astropy/astropy","homepage":"www.astropy.org","size":62217,"stargazers_count":595,"watchers_count":595,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":403,"mirror_url":null,"open_issues_count":559,"forks":403,"open_issues":559,"watchers":595,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/3903"},"html":{"href":"https://github.com/astropy/astropy/pull/3903"},"issue":{"href":"https://api.github.com/repos/astropy/astropy/issues/3903"},"comments":{"href":"https://api.github.com/repos/astropy/astropy/issues/3903/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy/pulls/3903/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy/pulls/3903/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy/statuses/e5433407af2befef16eda6ebbb79c15f0b64c267"}}}}