{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_test/pulls/comments/38862607","id":38862607,"diff_hunk":"@@ -10,6 +10,10 @@ endif\n # be used instead.\n OPTEE_CLIENT_EXPORT ?= ../../../optee_client/out/export\n \n+# If CFG_XTEST_LITE=n : compile full xtest suite (default)\n+# If CFG_XTEST_LITE=y : compile sanity xtest suite\n+CFG_XTEST_LITE ?= n","path":"host/xtest/Makefile","position":6,"original_position":6,"commit_id":"074c497a298d6ea7a4bc20739d45c83401b69419","original_commit_id":"074c497a298d6ea7a4bc20739d45c83401b69419","user":{"login":"jforissier","id":8288195,"avatar_url":"https://avatars.githubusercontent.com/u/8288195?v=3","gravatar_id":"","url":"https://api.github.com/users/jforissier","html_url":"https://github.com/jforissier","followers_url":"https://api.github.com/users/jforissier/followers","following_url":"https://api.github.com/users/jforissier/following{/other_user}","gists_url":"https://api.github.com/users/jforissier/gists{/gist_id}","starred_url":"https://api.github.com/users/jforissier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jforissier/subscriptions","organizations_url":"https://api.github.com/users/jforissier/orgs","repos_url":"https://api.github.com/users/jforissier/repos","events_url":"https://api.github.com/users/jforissier/events{/privacy}","received_events_url":"https://api.github.com/users/jforissier/received_events","type":"User","site_admin":false},"body":"+1 with @jenswi-linaro. IMO compile-time options are inconvenient, so they should not be used unless there is a reason (like reducing file size, or incompatible options...).\r\nIt is just a matter of replacing `#ifndef ... #endif` with `if (...) { ... }`, no?","created_at":"2015-09-07T13:38:17Z","updated_at":"2015-09-07T13:38:17Z","html_url":"https://github.com/OP-TEE/optee_test/pull/26#discussion_r38862607","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_test/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_test/pulls/comments/38862607"},"html":{"href":"https://github.com/OP-TEE/optee_test/pull/26#discussion_r38862607"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_test/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_test/pulls/26","id":44346649,"html_url":"https://github.com/OP-TEE/optee_test/pull/26","diff_url":"https://github.com/OP-TEE/optee_test/pull/26.diff","patch_url":"https://github.com/OP-TEE/optee_test/pull/26.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_test/issues/26","number":26,"state":"open","locked":false,"title":"GP11 : DSA-SHA224 DSA-SHA256 algorithms","user":{"login":"cedric-chaumont-st-dev","id":7803511,"avatar_url":"https://avatars.githubusercontent.com/u/7803511?v=3","gravatar_id":"","url":"https://api.github.com/users/cedric-chaumont-st-dev","html_url":"https://github.com/cedric-chaumont-st-dev","followers_url":"https://api.github.com/users/cedric-chaumont-st-dev/followers","following_url":"https://api.github.com/users/cedric-chaumont-st-dev/following{/other_user}","gists_url":"https://api.github.com/users/cedric-chaumont-st-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/cedric-chaumont-st-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedric-chaumont-st-dev/subscriptions","organizations_url":"https://api.github.com/users/cedric-chaumont-st-dev/orgs","repos_url":"https://api.github.com/users/cedric-chaumont-st-dev/repos","events_url":"https://api.github.com/users/cedric-chaumont-st-dev/events{/privacy}","received_events_url":"https://api.github.com/users/cedric-chaumont-st-dev/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-07T11:37:05Z","updated_at":"2015-09-07T13:38:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a94b78ebae0fd57baa0ea5e059c5e3834441e7a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_test/pulls/26/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_test/pulls/26/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_test/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_test/issues/26/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_test/statuses/074c497a298d6ea7a4bc20739d45c83401b69419","head":{"label":"cedric-chaumont-st-dev:dev/gp11_dsa_algo","ref":"dev/gp11_dsa_algo","sha":"074c497a298d6ea7a4bc20739d45c83401b69419","user":{"login":"cedric-chaumont-st-dev","id":7803511,"avatar_url":"https://avatars.githubusercontent.com/u/7803511?v=3","gravatar_id":"","url":"https://api.github.com/users/cedric-chaumont-st-dev","html_url":"https://github.com/cedric-chaumont-st-dev","followers_url":"https://api.github.com/users/cedric-chaumont-st-dev/followers","following_url":"https://api.github.com/users/cedric-chaumont-st-dev/following{/other_user}","gists_url":"https://api.github.com/users/cedric-chaumont-st-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/cedric-chaumont-st-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedric-chaumont-st-dev/subscriptions","organizations_url":"https://api.github.com/users/cedric-chaumont-st-dev/orgs","repos_url":"https://api.github.com/users/cedric-chaumont-st-dev/repos","events_url":"https://api.github.com/users/cedric-chaumont-st-dev/events{/privacy}","received_events_url":"https://api.github.com/users/cedric-chaumont-st-dev/received_events","type":"User","site_admin":false},"repo":{"id":38753567,"name":"optee_test","full_name":"cedric-chaumont-st-dev/optee_test","owner":{"login":"cedric-chaumont-st-dev","id":7803511,"avatar_url":"https://avatars.githubusercontent.com/u/7803511?v=3","gravatar_id":"","url":"https://api.github.com/users/cedric-chaumont-st-dev","html_url":"https://github.com/cedric-chaumont-st-dev","followers_url":"https://api.github.com/users/cedric-chaumont-st-dev/followers","following_url":"https://api.github.com/users/cedric-chaumont-st-dev/following{/other_user}","gists_url":"https://api.github.com/users/cedric-chaumont-st-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/cedric-chaumont-st-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedric-chaumont-st-dev/subscriptions","organizations_url":"https://api.github.com/users/cedric-chaumont-st-dev/orgs","repos_url":"https://api.github.com/users/cedric-chaumont-st-dev/repos","events_url":"https://api.github.com/users/cedric-chaumont-st-dev/events{/privacy}","received_events_url":"https://api.github.com/users/cedric-chaumont-st-dev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cedric-chaumont-st-dev/optee_test","description":"Test suite","fork":true,"url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test","forks_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/forks","keys_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/teams","hooks_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/hooks","issue_events_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/issues/events{/number}","events_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/events","assignees_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/assignees{/user}","branches_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/branches{/branch}","tags_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/tags","blobs_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/git/refs{/sha}","trees_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/statuses/{sha}","languages_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/languages","stargazers_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/stargazers","contributors_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/contributors","subscribers_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/subscribers","subscription_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/subscription","commits_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/commits{/sha}","git_commits_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/git/commits{/sha}","comments_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/comments{/number}","issue_comment_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/issues/comments{/number}","contents_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/contents/{+path}","compare_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/merges","archive_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/downloads","issues_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/issues{/number}","pulls_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/pulls{/number}","milestones_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/milestones{/number}","notifications_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/labels{/name}","releases_url":"https://api.github.com/repos/cedric-chaumont-st-dev/optee_test/releases{/id}","created_at":"2015-07-08T12:48:45Z","updated_at":"2015-07-08T12:48:46Z","pushed_at":"2015-09-07T11:34:04Z","git_url":"git://github.com/cedric-chaumont-st-dev/optee_test.git","ssh_url":"git@github.com:cedric-chaumont-st-dev/optee_test.git","clone_url":"https://github.com/cedric-chaumont-st-dev/optee_test.git","svn_url":"https://github.com/cedric-chaumont-st-dev/optee_test","homepage":null,"size":2470,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"473d9077749de67d3c64067f0825f2846794ef06","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":38317938,"name":"optee_test","full_name":"OP-TEE/optee_test","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_test","description":"Test suite","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_test","forks_url":"https://api.github.com/repos/OP-TEE/optee_test/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_test/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_test/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_test/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_test/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_test/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_test/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_test/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_test/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_test/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_test/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_test/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_test/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_test/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_test/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_test/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_test/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_test/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_test/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_test/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_test/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_test/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_test/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_test/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_test/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_test/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_test/releases{/id}","created_at":"2015-06-30T15:40:48Z","updated_at":"2015-07-06T23:16:50Z","pushed_at":"2015-09-07T11:37:05Z","git_url":"git://github.com/OP-TEE/optee_test.git","ssh_url":"git@github.com:OP-TEE/optee_test.git","clone_url":"https://github.com/OP-TEE/optee_test.git","svn_url":"https://github.com/OP-TEE/optee_test","homepage":null,"size":2596,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":5,"forks":11,"open_issues":5,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_test/pulls/26"},"html":{"href":"https://github.com/OP-TEE/optee_test/pull/26"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_test/issues/26"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_test/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_test/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_test/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_test/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_test/statuses/074c497a298d6ea7a4bc20739d45c83401b69419"}}}}