{"action":"created","issue":{"url":"https://api.github.com/repos/Cas-B/Group17-BubbleBobble/issues/29","labels_url":"https://api.github.com/repos/Cas-B/Group17-BubbleBobble/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/Cas-B/Group17-BubbleBobble/issues/29/comments","events_url":"https://api.github.com/repos/Cas-B/Group17-BubbleBobble/issues/29/events","html_url":"https://github.com/Cas-B/Group17-BubbleBobble/pull/29","id":107732641,"number":29,"title":"Rob jump through floor","user":{"login":"rjbergTU","id":9843987,"avatar_url":"https://avatars.githubusercontent.com/u/9843987?v=3","gravatar_id":"","url":"https://api.github.com/users/rjbergTU","html_url":"https://github.com/rjbergTU","followers_url":"https://api.github.com/users/rjbergTU/followers","following_url":"https://api.github.com/users/rjbergTU/following{/other_user}","gists_url":"https://api.github.com/users/rjbergTU/gists{/gist_id}","starred_url":"https://api.github.com/users/rjbergTU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjbergTU/subscriptions","organizations_url":"https://api.github.com/users/rjbergTU/orgs","repos_url":"https://api.github.com/users/rjbergTU/repos","events_url":"https://api.github.com/users/rjbergTU/events{/privacy}","received_events_url":"https://api.github.com/users/rjbergTU/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-22T14:59:39Z","updated_at":"2015-09-24T09:49:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Cas-B/Group17-BubbleBobble/pulls/29","html_url":"https://github.com/Cas-B/Group17-BubbleBobble/pull/29","diff_url":"https://github.com/Cas-B/Group17-BubbleBobble/pull/29.diff","patch_url":"https://github.com/Cas-B/Group17-BubbleBobble/pull/29.patch"},"body":"added feature to jump through the floor, added some comments, fixed some checkstyle, and changed some threading behaviour to behave more consistently.\r\n\r\n<feature,logic,documentation,organisation>"},"comment":{"url":"https://api.github.com/repos/Cas-B/Group17-BubbleBobble/issues/comments/142876510","html_url":"https://github.com/Cas-B/Group17-BubbleBobble/pull/29#issuecomment-142876510","issue_url":"https://api.github.com/repos/Cas-B/Group17-BubbleBobble/issues/29","id":142876510,"user":{"login":"Cas-B","id":9740367,"avatar_url":"https://avatars.githubusercontent.com/u/9740367?v=3","gravatar_id":"","url":"https://api.github.com/users/Cas-B","html_url":"https://github.com/Cas-B","followers_url":"https://api.github.com/users/Cas-B/followers","following_url":"https://api.github.com/users/Cas-B/following{/other_user}","gists_url":"https://api.github.com/users/Cas-B/gists{/gist_id}","starred_url":"https://api.github.com/users/Cas-B/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cas-B/subscriptions","organizations_url":"https://api.github.com/users/Cas-B/orgs","repos_url":"https://api.github.com/users/Cas-B/repos","events_url":"https://api.github.com/users/Cas-B/events{/privacy}","received_events_url":"https://api.github.com/users/Cas-B/received_events","type":"User","site_admin":false},"created_at":"2015-09-24T09:49:07Z","updated_at":"2015-09-24T09:49:07Z","body":"I have taken a look at the code and these things came to my attention and should be fixed before merging:\r\n-The GameObject class has no Test File while there is a collideswith method inside that has to be tested.\r\n-Checkstyle is complaining in the Game class about methods that are too long\r\n-Checkstyle is complaining in the Game class about an empty block that should be avoided\r\n-PMD is complaining about an empty block that should be avoided\r\n\r\nAll tests got run, but there were a few warnings that could easily be fixed before merging.\r\nFor now, the rest is fine, but these things should be fixed before continuing merging.\r\n"}}