{"action":"created","comment":{"url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/pulls/comments/48428504","id":48428504,"diff_hunk":"@@ -83,23 +83,36 @@ android {\n \n dependencies {\n     // DO NOT REMOVE BELOW COMMENTED-OUT CODE BEFORE ASKING!\n-    //compile 'com.github.amlcurran.showcaseview:library:5.0.0'\n+    // Please group dependencies for better review like below.\n+    \n+    // Android Support Libraries\n     compile 'com.android.support:appcompat-v7:23.1.1'\n+    \n+    // OpenCSV (comma-separated values) parser library\n+    compile 'au.com.bytecode:opencsv:2.4'\n+    \n+    // Easy to use Root Shell for Android Applications\n+    compile 'com.github.Stericson:RootShell:d708ae1f0a'\n+    \n+    // SLF4J binding for the Android logger\n+    // https://github.com/lp0/slf4j-android\n+    compile 'eu.lp0.slf4j:slf4j-android:1.7.12-0'\n+    compile 'org.slf4j:slf4j-api:1.7.12'\n+    \n+    // Dependency Injection for Android\n     compile 'io.freefair.android-injection:injection:1.0.0-rc2'\n     compile 'io.freefair.android-injection:logging:1.0.0-rc2'\n     compile 'io.freefair.android-injection:okhttp:1.0.0-rc2'\n-    //https://github.com/lp0/slf4j-android\n-    compile 'com.github.Stericson:RootShell:d708ae1f0a'\n-    compile 'org.slf4j:slf4j-api:1.7.12'\n-    compile 'eu.lp0.slf4j:slf4j-android:1.7.12-0'\n-    compile 'au.com.bytecode:opencsv:2.4'\n+    compile 'io.freefair.android-util:logging:1.1.0'\n \n-    //This git hash resolves to version 5.5\n-    compile 'com.github.MKergall.osmbonuspack:OSMBonusPack:2e8bca20f7'\n+    // OSMBonusPack library to interact with OpenStreetMap data\n+    compile 'com.github.MKergall.osmbonuspack:OSMBonusPack:v5.6'\n+    \n+    // Transition library for animated transition effects\n     compile 'com.github.kaichunlin.transition:core:0.9.2'\n-    compile 'io.freefair.android-util:logging:1.1.0'\n-    //debugCompile 'com.squareup.leakcanary:leakcanary-android:1.3.1'","path":"AIMSICD/build.gradle","position":40,"original_position":40,"commit_id":"e17e9775bc495d5143b1717651f538856095e323","original_commit_id":"64b7bd8549c59ce16985a2914904bf3e91f696b8","user":{"login":"larsgrefer","id":6069961,"avatar_url":"https://avatars.githubusercontent.com/u/6069961?v=3","gravatar_id":"","url":"https://api.github.com/users/larsgrefer","html_url":"https://github.com/larsgrefer","followers_url":"https://api.github.com/users/larsgrefer/followers","following_url":"https://api.github.com/users/larsgrefer/following{/other_user}","gists_url":"https://api.github.com/users/larsgrefer/gists{/gist_id}","starred_url":"https://api.github.com/users/larsgrefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsgrefer/subscriptions","organizations_url":"https://api.github.com/users/larsgrefer/orgs","repos_url":"https://api.github.com/users/larsgrefer/repos","events_url":"https://api.github.com/users/larsgrefer/events{/privacy}","received_events_url":"https://api.github.com/users/larsgrefer/received_events","type":"User","site_admin":false},"body":"I'm not not sure if we might need it, but let's keep it away for now.\r\nIm not a fan of commented-out code.\r\nIf we want to use it in future, we can re-add it in future.","created_at":"2015-12-25T01:20:44Z","updated_at":"2015-12-25T01:20:44Z","html_url":"https://github.com/SecUpwN/Android-IMSI-Catcher-Detector/pull/700#discussion_r48428504","pull_request_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/pulls/700","_links":{"self":{"href":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/pulls/comments/48428504"},"html":{"href":"https://github.com/SecUpwN/Android-IMSI-Catcher-Detector/pull/700#discussion_r48428504"},"pull_request":{"href":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/pulls/700"}}},"pull_request":{"url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/pulls/700","id":54569287,"html_url":"https://github.com/SecUpwN/Android-IMSI-Catcher-Detector/pull/700","diff_url":"https://github.com/SecUpwN/Android-IMSI-Catcher-Detector/pull/700.diff","patch_url":"https://github.com/SecUpwN/Android-IMSI-Catcher-Detector/pull/700.patch","issue_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/issues/700","number":700,"state":"open","locked":false,"title":"Grouped dependencies","user":{"login":"SecUpwN","id":6000299,"avatar_url":"https://avatars.githubusercontent.com/u/6000299?v=3","gravatar_id":"","url":"https://api.github.com/users/SecUpwN","html_url":"https://github.com/SecUpwN","followers_url":"https://api.github.com/users/SecUpwN/followers","following_url":"https://api.github.com/users/SecUpwN/following{/other_user}","gists_url":"https://api.github.com/users/SecUpwN/gists{/gist_id}","starred_url":"https://api.github.com/users/SecUpwN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SecUpwN/subscriptions","organizations_url":"https://api.github.com/users/SecUpwN/orgs","repos_url":"https://api.github.com/users/SecUpwN/repos","events_url":"https://api.github.com/users/SecUpwN/events{/privacy}","received_events_url":"https://api.github.com/users/SecUpwN/received_events","type":"User","site_admin":false},"body":"This PR groups our dependencies in `build.gradle` and adds a small description above each group.","created_at":"2015-12-25T00:46:49Z","updated_at":"2015-12-25T01:20:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8f3ce3961a90a70be00aa73088512ee81cfca6b","assignee":{"login":"SecUpwN","id":6000299,"avatar_url":"https://avatars.githubusercontent.com/u/6000299?v=3","gravatar_id":"","url":"https://api.github.com/users/SecUpwN","html_url":"https://github.com/SecUpwN","followers_url":"https://api.github.com/users/SecUpwN/followers","following_url":"https://api.github.com/users/SecUpwN/following{/other_user}","gists_url":"https://api.github.com/users/SecUpwN/gists{/gist_id}","starred_url":"https://api.github.com/users/SecUpwN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SecUpwN/subscriptions","organizations_url":"https://api.github.com/users/SecUpwN/orgs","repos_url":"https://api.github.com/users/SecUpwN/repos","events_url":"https://api.github.com/users/SecUpwN/events{/privacy}","received_events_url":"https://api.github.com/users/SecUpwN/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/pulls/700/commits","review_comments_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/pulls/700/comments","review_comment_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/issues/700/comments","statuses_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/statuses/e17e9775bc495d5143b1717651f538856095e323","head":{"label":"SecUpwN:improve/dependencies","ref":"improve/dependencies","sha":"e17e9775bc495d5143b1717651f538856095e323","user":{"login":"SecUpwN","id":6000299,"avatar_url":"https://avatars.githubusercontent.com/u/6000299?v=3","gravatar_id":"","url":"https://api.github.com/users/SecUpwN","html_url":"https://github.com/SecUpwN","followers_url":"https://api.github.com/users/SecUpwN/followers","following_url":"https://api.github.com/users/SecUpwN/following{/other_user}","gists_url":"https://api.github.com/users/SecUpwN/gists{/gist_id}","starred_url":"https://api.github.com/users/SecUpwN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SecUpwN/subscriptions","organizations_url":"https://api.github.com/users/SecUpwN/orgs","repos_url":"https://api.github.com/users/SecUpwN/repos","events_url":"https://api.github.com/users/SecUpwN/events{/privacy}","received_events_url":"https://api.github.com/users/SecUpwN/received_events","type":"User","site_admin":false},"repo":{"id":14640193,"name":"Android-IMSI-Catcher-Detector","full_name":"SecUpwN/Android-IMSI-Catcher-Detector","owner":{"login":"SecUpwN","id":6000299,"avatar_url":"https://avatars.githubusercontent.com/u/6000299?v=3","gravatar_id":"","url":"https://api.github.com/users/SecUpwN","html_url":"https://github.com/SecUpwN","followers_url":"https://api.github.com/users/SecUpwN/followers","following_url":"https://api.github.com/users/SecUpwN/following{/other_user}","gists_url":"https://api.github.com/users/SecUpwN/gists{/gist_id}","starred_url":"https://api.github.com/users/SecUpwN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SecUpwN/subscriptions","organizations_url":"https://api.github.com/users/SecUpwN/orgs","repos_url":"https://api.github.com/users/SecUpwN/repos","events_url":"https://api.github.com/users/SecUpwN/events{/privacy}","received_events_url":"https://api.github.com/users/SecUpwN/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SecUpwN/Android-IMSI-Catcher-Detector","description":"AIMSICD • Fight IMSI-Catcher, StingRay and silent SMS!","fork":false,"url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector","forks_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/forks","keys_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/teams","hooks_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/hooks","issue_events_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/issues/events{/number}","events_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/events","assignees_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/assignees{/user}","branches_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/branches{/branch}","tags_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/tags","blobs_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/git/refs{/sha}","trees_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/statuses/{sha}","languages_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/languages","stargazers_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/stargazers","contributors_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/contributors","subscribers_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/subscribers","subscription_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/subscription","commits_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/commits{/sha}","git_commits_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/git/commits{/sha}","comments_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/comments{/number}","issue_comment_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/issues/comments{/number}","contents_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/contents/{+path}","compare_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/merges","archive_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/downloads","issues_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/issues{/number}","pulls_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/pulls{/number}","milestones_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/milestones{/number}","notifications_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/labels{/name}","releases_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/releases{/id}","created_at":"2013-11-23T10:04:14Z","updated_at":"2015-12-24T21:30:38Z","pushed_at":"2015-12-25T01:09:22Z","git_url":"git://github.com/SecUpwN/Android-IMSI-Catcher-Detector.git","ssh_url":"git@github.com:SecUpwN/Android-IMSI-Catcher-Detector.git","clone_url":"https://github.com/SecUpwN/Android-IMSI-Catcher-Detector.git","svn_url":"https://github.com/SecUpwN/Android-IMSI-Catcher-Detector","homepage":"https://secupwn.github.io/Android-IMSI-Catcher-Detector/","size":241354,"stargazers_count":1721,"watchers_count":1721,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":304,"mirror_url":null,"open_issues_count":92,"forks":304,"open_issues":92,"watchers":1721,"default_branch":"development"}},"base":{"label":"SecUpwN:development","ref":"development","sha":"590cf6f158a3087f1cee16a7af80dbfc5cfab6fd","user":{"login":"SecUpwN","id":6000299,"avatar_url":"https://avatars.githubusercontent.com/u/6000299?v=3","gravatar_id":"","url":"https://api.github.com/users/SecUpwN","html_url":"https://github.com/SecUpwN","followers_url":"https://api.github.com/users/SecUpwN/followers","following_url":"https://api.github.com/users/SecUpwN/following{/other_user}","gists_url":"https://api.github.com/users/SecUpwN/gists{/gist_id}","starred_url":"https://api.github.com/users/SecUpwN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SecUpwN/subscriptions","organizations_url":"https://api.github.com/users/SecUpwN/orgs","repos_url":"https://api.github.com/users/SecUpwN/repos","events_url":"https://api.github.com/users/SecUpwN/events{/privacy}","received_events_url":"https://api.github.com/users/SecUpwN/received_events","type":"User","site_admin":false},"repo":{"id":14640193,"name":"Android-IMSI-Catcher-Detector","full_name":"SecUpwN/Android-IMSI-Catcher-Detector","owner":{"login":"SecUpwN","id":6000299,"avatar_url":"https://avatars.githubusercontent.com/u/6000299?v=3","gravatar_id":"","url":"https://api.github.com/users/SecUpwN","html_url":"https://github.com/SecUpwN","followers_url":"https://api.github.com/users/SecUpwN/followers","following_url":"https://api.github.com/users/SecUpwN/following{/other_user}","gists_url":"https://api.github.com/users/SecUpwN/gists{/gist_id}","starred_url":"https://api.github.com/users/SecUpwN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SecUpwN/subscriptions","organizations_url":"https://api.github.com/users/SecUpwN/orgs","repos_url":"https://api.github.com/users/SecUpwN/repos","events_url":"https://api.github.com/users/SecUpwN/events{/privacy}","received_events_url":"https://api.github.com/users/SecUpwN/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SecUpwN/Android-IMSI-Catcher-Detector","description":"AIMSICD • Fight IMSI-Catcher, StingRay and silent SMS!","fork":false,"url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector","forks_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/forks","keys_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/teams","hooks_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/hooks","issue_events_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/issues/events{/number}","events_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/events","assignees_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/assignees{/user}","branches_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/branches{/branch}","tags_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/tags","blobs_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/git/refs{/sha}","trees_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/statuses/{sha}","languages_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/languages","stargazers_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/stargazers","contributors_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/contributors","subscribers_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/subscribers","subscription_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/subscription","commits_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/commits{/sha}","git_commits_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/git/commits{/sha}","comments_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/comments{/number}","issue_comment_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/issues/comments{/number}","contents_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/contents/{+path}","compare_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/merges","archive_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/downloads","issues_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/issues{/number}","pulls_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/pulls{/number}","milestones_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/milestones{/number}","notifications_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/labels{/name}","releases_url":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/releases{/id}","created_at":"2013-11-23T10:04:14Z","updated_at":"2015-12-24T21:30:38Z","pushed_at":"2015-12-25T01:09:22Z","git_url":"git://github.com/SecUpwN/Android-IMSI-Catcher-Detector.git","ssh_url":"git@github.com:SecUpwN/Android-IMSI-Catcher-Detector.git","clone_url":"https://github.com/SecUpwN/Android-IMSI-Catcher-Detector.git","svn_url":"https://github.com/SecUpwN/Android-IMSI-Catcher-Detector","homepage":"https://secupwn.github.io/Android-IMSI-Catcher-Detector/","size":241354,"stargazers_count":1721,"watchers_count":1721,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":304,"mirror_url":null,"open_issues_count":92,"forks":304,"open_issues":92,"watchers":1721,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/pulls/700"},"html":{"href":"https://github.com/SecUpwN/Android-IMSI-Catcher-Detector/pull/700"},"issue":{"href":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/issues/700"},"comments":{"href":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/issues/700/comments"},"review_comments":{"href":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/pulls/700/comments"},"review_comment":{"href":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/pulls/700/commits"},"statuses":{"href":"https://api.github.com/repos/SecUpwN/Android-IMSI-Catcher-Detector/statuses/e17e9775bc495d5143b1717651f538856095e323"}}}}