{"action":"created","comment":{"url":"https://api.github.com/repos/simbody/simbody/pulls/comments/27899848","id":27899848,"diff_hunk":"@@ -67,9 +67,17 @@ IF(WIN32)\n   SET(EXAMPLES_INSTALL_BIN examples/bin/)\n   SET(EXAMPLES_INSTALL_SRC examples/src/)\n ELSE()\n-  SET(EXAMPLES_INSTALL_BIN ${CMAKE_INSTALL_FULL_LIBDIR}/simbody/examples/)\n+  SET(EXAMPLES_INSTALL_BIN ${CMAKE_INSTALL_LIBDIR}/simbody/examples/) # if this changes, change the corresponding\n+                                                                      # FULL version in file(RELATIVE_PATH ) command\n   SET(EXAMPLES_INSTALL_SRC ${CMAKE_INSTALL_DOCDIR}/examples/src/)\n-  SET(EXAMPLES_SYMLINK_BIN ${CMAKE_INSTALL_DOCDIR}/examples/)\n+  # Use full paths for the following as it will be used to create a symlink\n+  # The symlink itself will be a relative path, so the package will be relocatable\n+  # Cannot use CMAKE_INSTALL_FULL_DOCDIR as it evaluates to a different value,\n+  # as CMAKE_INSTALL_DOCDIR is changed as a \"normal\" variable, not in CACHE","path":"examples/CMakeLists.txt","position":12,"original_position":12,"commit_id":"7fa84f2a6703642f232e959fdfda345721ba0ba4","original_commit_id":"7fa84f2a6703642f232e959fdfda345721ba0ba4","user":{"login":"sherm1","id":4088016,"avatar_url":"https://avatars.githubusercontent.com/u/4088016?v=3","gravatar_id":"","url":"https://api.github.com/users/sherm1","html_url":"https://github.com/sherm1","followers_url":"https://api.github.com/users/sherm1/followers","following_url":"https://api.github.com/users/sherm1/following{/other_user}","gists_url":"https://api.github.com/users/sherm1/gists{/gist_id}","starred_url":"https://api.github.com/users/sherm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherm1/subscriptions","organizations_url":"https://api.github.com/users/sherm1/orgs","repos_url":"https://api.github.com/users/sherm1/repos","events_url":"https://api.github.com/users/sherm1/events{/privacy}","received_events_url":"https://api.github.com/users/sherm1/received_events","type":"User","site_admin":false},"body":"Hmmm ... this seems awkward. I see that the problem comes from the main CMakeLists file [here](https://github.com/simbody/simbody/blob/master/CMakeLists.txt#L35). I don't think the issue is cache vs. normal; looks like someone changed `CMAKE_INSTALL_DOCDIR` but not `CMAKE_FULL_INSTALL_DOCDIR`. They should match, I think. One fix might be to change them both. Another might be to change the PROJECT name on non-WIN32 platforms from PROJECT(Simbody) to PROJECT(simbody). The latter might have side effects I suppose. I wonder also how we manage to get lower case `simbody` names elsewhere, like in the `lib` and `libexec` directories?","created_at":"2015-04-07T17:26:05Z","updated_at":"2015-04-07T17:26:05Z","html_url":"https://github.com/simbody/simbody/pull/358#discussion_r27899848","pull_request_url":"https://api.github.com/repos/simbody/simbody/pulls/358","_links":{"self":{"href":"https://api.github.com/repos/simbody/simbody/pulls/comments/27899848"},"html":{"href":"https://github.com/simbody/simbody/pull/358#discussion_r27899848"},"pull_request":{"href":"https://api.github.com/repos/simbody/simbody/pulls/358"}}},"pull_request":{"url":"https://api.github.com/repos/simbody/simbody/pulls/358","id":32724146,"html_url":"https://github.com/simbody/simbody/pull/358","diff_url":"https://github.com/simbody/simbody/pull/358.diff","patch_url":"https://github.com/simbody/simbody/pull/358.patch","issue_url":"https://api.github.com/repos/simbody/simbody/issues/358","number":358,"state":"open","locked":false,"title":"Improve creation of symlink from docs to lib installation folder on UNIX systems","user":{"login":"elen4","id":3841320,"avatar_url":"https://avatars.githubusercontent.com/u/3841320?v=3","gravatar_id":"","url":"https://api.github.com/users/elen4","html_url":"https://github.com/elen4","followers_url":"https://api.github.com/users/elen4/followers","following_url":"https://api.github.com/users/elen4/following{/other_user}","gists_url":"https://api.github.com/users/elen4/gists{/gist_id}","starred_url":"https://api.github.com/users/elen4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elen4/subscriptions","organizations_url":"https://api.github.com/users/elen4/orgs","repos_url":"https://api.github.com/users/elen4/repos","events_url":"https://api.github.com/users/elen4/events{/privacy}","received_events_url":"https://api.github.com/users/elen4/received_events","type":"User","site_admin":false},"body":"As mentioned in #356, right now the symbolic link between the examples docs directory and the libexec directory that contains example binaries is wrong when the installation prefix is changes after the first CMake pass. This PR addresses this issue creating the symlink at installation time and without the need for a temporary symlink in the build directory. Also, the symlink is a relative path, in accordance to https://www.debian.org/doc/debian-policy/ch-files.html#s10.5 (please let me know if I am following the wrong policy :confused: )","created_at":"2015-04-07T00:29:15Z","updated_at":"2015-04-07T17:26:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5c5dab354a0676b52d57189d4de1bec868d441c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/simbody/simbody/pulls/358/commits","review_comments_url":"https://api.github.com/repos/simbody/simbody/pulls/358/comments","review_comment_url":"https://api.github.com/repos/simbody/simbody/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simbody/simbody/issues/358/comments","statuses_url":"https://api.github.com/repos/simbody/simbody/statuses/7fa84f2a6703642f232e959fdfda345721ba0ba4","head":{"label":"elen4:symlinkExamples","ref":"symlinkExamples","sha":"7fa84f2a6703642f232e959fdfda345721ba0ba4","user":{"login":"elen4","id":3841320,"avatar_url":"https://avatars.githubusercontent.com/u/3841320?v=3","gravatar_id":"","url":"https://api.github.com/users/elen4","html_url":"https://github.com/elen4","followers_url":"https://api.github.com/users/elen4/followers","following_url":"https://api.github.com/users/elen4/following{/other_user}","gists_url":"https://api.github.com/users/elen4/gists{/gist_id}","starred_url":"https://api.github.com/users/elen4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elen4/subscriptions","organizations_url":"https://api.github.com/users/elen4/orgs","repos_url":"https://api.github.com/users/elen4/repos","events_url":"https://api.github.com/users/elen4/events{/privacy}","received_events_url":"https://api.github.com/users/elen4/received_events","type":"User","site_admin":false},"repo":{"id":17862688,"name":"simbody","full_name":"elen4/simbody","owner":{"login":"elen4","id":3841320,"avatar_url":"https://avatars.githubusercontent.com/u/3841320?v=3","gravatar_id":"","url":"https://api.github.com/users/elen4","html_url":"https://github.com/elen4","followers_url":"https://api.github.com/users/elen4/followers","following_url":"https://api.github.com/users/elen4/following{/other_user}","gists_url":"https://api.github.com/users/elen4/gists{/gist_id}","starred_url":"https://api.github.com/users/elen4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elen4/subscriptions","organizations_url":"https://api.github.com/users/elen4/orgs","repos_url":"https://api.github.com/users/elen4/repos","events_url":"https://api.github.com/users/elen4/events{/privacy}","received_events_url":"https://api.github.com/users/elen4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elen4/simbody","description":"High-performance C++ multibody dynamics/physics library for simulating articulated biomechanical and mechanical systems like vehicles, robots, and the human skeleton.","fork":true,"url":"https://api.github.com/repos/elen4/simbody","forks_url":"https://api.github.com/repos/elen4/simbody/forks","keys_url":"https://api.github.com/repos/elen4/simbody/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elen4/simbody/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elen4/simbody/teams","hooks_url":"https://api.github.com/repos/elen4/simbody/hooks","issue_events_url":"https://api.github.com/repos/elen4/simbody/issues/events{/number}","events_url":"https://api.github.com/repos/elen4/simbody/events","assignees_url":"https://api.github.com/repos/elen4/simbody/assignees{/user}","branches_url":"https://api.github.com/repos/elen4/simbody/branches{/branch}","tags_url":"https://api.github.com/repos/elen4/simbody/tags","blobs_url":"https://api.github.com/repos/elen4/simbody/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elen4/simbody/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elen4/simbody/git/refs{/sha}","trees_url":"https://api.github.com/repos/elen4/simbody/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elen4/simbody/statuses/{sha}","languages_url":"https://api.github.com/repos/elen4/simbody/languages","stargazers_url":"https://api.github.com/repos/elen4/simbody/stargazers","contributors_url":"https://api.github.com/repos/elen4/simbody/contributors","subscribers_url":"https://api.github.com/repos/elen4/simbody/subscribers","subscription_url":"https://api.github.com/repos/elen4/simbody/subscription","commits_url":"https://api.github.com/repos/elen4/simbody/commits{/sha}","git_commits_url":"https://api.github.com/repos/elen4/simbody/git/commits{/sha}","comments_url":"https://api.github.com/repos/elen4/simbody/comments{/number}","issue_comment_url":"https://api.github.com/repos/elen4/simbody/issues/comments{/number}","contents_url":"https://api.github.com/repos/elen4/simbody/contents/{+path}","compare_url":"https://api.github.com/repos/elen4/simbody/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elen4/simbody/merges","archive_url":"https://api.github.com/repos/elen4/simbody/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elen4/simbody/downloads","issues_url":"https://api.github.com/repos/elen4/simbody/issues{/number}","pulls_url":"https://api.github.com/repos/elen4/simbody/pulls{/number}","milestones_url":"https://api.github.com/repos/elen4/simbody/milestones{/number}","notifications_url":"https://api.github.com/repos/elen4/simbody/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elen4/simbody/labels{/name}","releases_url":"https://api.github.com/repos/elen4/simbody/releases{/id}","created_at":"2014-03-18T11:00:55Z","updated_at":"2014-04-09T15:03:16Z","pushed_at":"2015-04-06T22:39:21Z","git_url":"git://github.com/elen4/simbody.git","ssh_url":"git@github.com:elen4/simbody.git","clone_url":"https://github.com/elen4/simbody.git","svn_url":"https://github.com/elen4/simbody","homepage":"https://simtk.org/home/simbody","size":186008,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"simbody:master","ref":"master","sha":"d869c0b7af06a55143ead689e8401a2b1f6b2327","user":{"login":"simbody","id":5199961,"avatar_url":"https://avatars.githubusercontent.com/u/5199961?v=3","gravatar_id":"","url":"https://api.github.com/users/simbody","html_url":"https://github.com/simbody","followers_url":"https://api.github.com/users/simbody/followers","following_url":"https://api.github.com/users/simbody/following{/other_user}","gists_url":"https://api.github.com/users/simbody/gists{/gist_id}","starred_url":"https://api.github.com/users/simbody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simbody/subscriptions","organizations_url":"https://api.github.com/users/simbody/orgs","repos_url":"https://api.github.com/users/simbody/repos","events_url":"https://api.github.com/users/simbody/events{/privacy}","received_events_url":"https://api.github.com/users/simbody/received_events","type":"Organization","site_admin":false},"repo":{"id":12146969,"name":"simbody","full_name":"simbody/simbody","owner":{"login":"simbody","id":5199961,"avatar_url":"https://avatars.githubusercontent.com/u/5199961?v=3","gravatar_id":"","url":"https://api.github.com/users/simbody","html_url":"https://github.com/simbody","followers_url":"https://api.github.com/users/simbody/followers","following_url":"https://api.github.com/users/simbody/following{/other_user}","gists_url":"https://api.github.com/users/simbody/gists{/gist_id}","starred_url":"https://api.github.com/users/simbody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simbody/subscriptions","organizations_url":"https://api.github.com/users/simbody/orgs","repos_url":"https://api.github.com/users/simbody/repos","events_url":"https://api.github.com/users/simbody/events{/privacy}","received_events_url":"https://api.github.com/users/simbody/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simbody/simbody","description":"High-performance C++ multibody dynamics/physics library for simulating articulated biomechanical and mechanical systems like vehicles, robots, and the human skeleton.","fork":false,"url":"https://api.github.com/repos/simbody/simbody","forks_url":"https://api.github.com/repos/simbody/simbody/forks","keys_url":"https://api.github.com/repos/simbody/simbody/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simbody/simbody/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simbody/simbody/teams","hooks_url":"https://api.github.com/repos/simbody/simbody/hooks","issue_events_url":"https://api.github.com/repos/simbody/simbody/issues/events{/number}","events_url":"https://api.github.com/repos/simbody/simbody/events","assignees_url":"https://api.github.com/repos/simbody/simbody/assignees{/user}","branches_url":"https://api.github.com/repos/simbody/simbody/branches{/branch}","tags_url":"https://api.github.com/repos/simbody/simbody/tags","blobs_url":"https://api.github.com/repos/simbody/simbody/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simbody/simbody/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simbody/simbody/git/refs{/sha}","trees_url":"https://api.github.com/repos/simbody/simbody/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simbody/simbody/statuses/{sha}","languages_url":"https://api.github.com/repos/simbody/simbody/languages","stargazers_url":"https://api.github.com/repos/simbody/simbody/stargazers","contributors_url":"https://api.github.com/repos/simbody/simbody/contributors","subscribers_url":"https://api.github.com/repos/simbody/simbody/subscribers","subscription_url":"https://api.github.com/repos/simbody/simbody/subscription","commits_url":"https://api.github.com/repos/simbody/simbody/commits{/sha}","git_commits_url":"https://api.github.com/repos/simbody/simbody/git/commits{/sha}","comments_url":"https://api.github.com/repos/simbody/simbody/comments{/number}","issue_comment_url":"https://api.github.com/repos/simbody/simbody/issues/comments{/number}","contents_url":"https://api.github.com/repos/simbody/simbody/contents/{+path}","compare_url":"https://api.github.com/repos/simbody/simbody/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simbody/simbody/merges","archive_url":"https://api.github.com/repos/simbody/simbody/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simbody/simbody/downloads","issues_url":"https://api.github.com/repos/simbody/simbody/issues{/number}","pulls_url":"https://api.github.com/repos/simbody/simbody/pulls{/number}","milestones_url":"https://api.github.com/repos/simbody/simbody/milestones{/number}","notifications_url":"https://api.github.com/repos/simbody/simbody/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simbody/simbody/labels{/name}","releases_url":"https://api.github.com/repos/simbody/simbody/releases{/id}","created_at":"2013-08-16T00:21:53Z","updated_at":"2015-04-06T16:12:30Z","pushed_at":"2015-04-07T01:50:51Z","git_url":"git://github.com/simbody/simbody.git","ssh_url":"git@github.com:simbody/simbody.git","clone_url":"https://github.com/simbody/simbody.git","svn_url":"https://github.com/simbody/simbody","homepage":"https://simtk.org/home/simbody","size":192150,"stargazers_count":287,"watchers_count":287,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"open_issues_count":66,"forks":128,"open_issues":66,"watchers":287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simbody/simbody/pulls/358"},"html":{"href":"https://github.com/simbody/simbody/pull/358"},"issue":{"href":"https://api.github.com/repos/simbody/simbody/issues/358"},"comments":{"href":"https://api.github.com/repos/simbody/simbody/issues/358/comments"},"review_comments":{"href":"https://api.github.com/repos/simbody/simbody/pulls/358/comments"},"review_comment":{"href":"https://api.github.com/repos/simbody/simbody/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simbody/simbody/pulls/358/commits"},"statuses":{"href":"https://api.github.com/repos/simbody/simbody/statuses/7fa84f2a6703642f232e959fdfda345721ba0ba4"}}}}