{"action":"created","issue":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/30125","labels_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/30125/labels{/name}","comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/30125/comments","events_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/30125/events","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/30125","id":106430746,"number":30125,"title":"master-lps-58466","user":{"login":"brianchiu","id":871745,"avatar_url":"https://avatars.githubusercontent.com/u/871745?v=3","gravatar_id":"","url":"https://api.github.com/users/brianchiu","html_url":"https://github.com/brianchiu","followers_url":"https://api.github.com/users/brianchiu/followers","following_url":"https://api.github.com/users/brianchiu/following{/other_user}","gists_url":"https://api.github.com/users/brianchiu/gists{/gist_id}","starred_url":"https://api.github.com/users/brianchiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianchiu/subscriptions","organizations_url":"https://api.github.com/users/brianchiu/orgs","repos_url":"https://api.github.com/users/brianchiu/repos","events_url":"https://api.github.com/users/brianchiu/events{/privacy}","received_events_url":"https://api.github.com/users/brianchiu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-14T21:20:49Z","updated_at":"2015-09-14T21:36:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/30125","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/30125","diff_url":"https://github.com/brianchandotcom/liferay-portal/pull/30125.diff","patch_url":"https://github.com/brianchandotcom/liferay-portal/pull/30125.patch"},"body":"https://issues.liferay.com/browse/LPS-58466\r\n\r\nFor these commits, Albert is updating the websphere properties.\r\n\r\n- He changed \"portal.war.dir\" to be \"portal.war.name\" because the property represents an actual war file and not a directory\r\n- He created a generic \"app.server.${app.server.type}.portal.war.name\" and put it in with the rest of the generic app server properties in build-common.xml. Let us know if it shouldn't go here.\r\n- He consolidated the portal.war logic for glassfish and websphere because there is duplicate logic there\r\n\r\nThis is a resend of:\r\nhttps://github.com/brianchandotcom/liferay-portal/pull/30116"},"comment":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/comments/140212560","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/30125#issuecomment-140212560","issue_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/30125","id":140212560,"user":{"login":"brianchiu","id":871745,"avatar_url":"https://avatars.githubusercontent.com/u/871745?v=3","gravatar_id":"","url":"https://api.github.com/users/brianchiu","html_url":"https://github.com/brianchiu","followers_url":"https://api.github.com/users/brianchiu/followers","following_url":"https://api.github.com/users/brianchiu/following{/other_user}","gists_url":"https://api.github.com/users/brianchiu/gists{/gist_id}","starred_url":"https://api.github.com/users/brianchiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianchiu/subscriptions","organizations_url":"https://api.github.com/users/brianchiu/orgs","repos_url":"https://api.github.com/users/brianchiu/repos","events_url":"https://api.github.com/users/brianchiu/events{/privacy}","received_events_url":"https://api.github.com/users/brianchiu/received_events","type":"User","site_admin":false},"created_at":"2015-09-14T21:36:44Z","updated_at":"2015-09-14T21:36:44Z","body":"ci:retest"}}