{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/pybars3/pulls/comments/44309176","id":44309176,"diff_hunk":"@@ -43,8 +43,16 @@\n \n class TestAcceptance(TestCase):\n \n-    def assertRender(self, template, context, result, helpers=None, partials=None, **kwargs):\n-        self.assertEqual(result, render(template, context, helpers=helpers, partials=partials, **kwargs))\n+    def assertRender(self, template, context, result, helpers=None, partials=None, error=None, **kwargs):\n+        try:\n+            self.assertEqual(result, render(template, context, helpers=helpers, partials=partials, **kwargs))\n+        except PybarsError, e:\n+            self.assertEqual(e.message, error)\n+            # self.assertTrue(False, \"Was not expecting an error, but had one: {}\".format(e.message))","path":"tests/test_acceptance.py","position":11,"original_position":11,"commit_id":"06d0a4d3591c1df9ef6fa3ca43fa13a66efbbb58","original_commit_id":"06d0a4d3591c1df9ef6fa3ca43fa13a66efbbb58","user":{"login":"isaacdd","id":7524964,"avatar_url":"https://avatars.githubusercontent.com/u/7524964?v=3","gravatar_id":"","url":"https://api.github.com/users/isaacdd","html_url":"https://github.com/isaacdd","followers_url":"https://api.github.com/users/isaacdd/followers","following_url":"https://api.github.com/users/isaacdd/following{/other_user}","gists_url":"https://api.github.com/users/isaacdd/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacdd/subscriptions","organizations_url":"https://api.github.com/users/isaacdd/orgs","repos_url":"https://api.github.com/users/isaacdd/repos","events_url":"https://api.github.com/users/isaacdd/events{/privacy}","received_events_url":"https://api.github.com/users/isaacdd/received_events","type":"User","site_admin":false},"body":"That should get updated.","created_at":"2015-11-09T18:18:45Z","updated_at":"2015-11-09T18:18:45Z","html_url":"https://github.com/DataDog/pybars3/pull/1#discussion_r44309176","pull_request_url":"https://api.github.com/repos/DataDog/pybars3/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/DataDog/pybars3/pulls/comments/44309176"},"html":{"href":"https://github.com/DataDog/pybars3/pull/1#discussion_r44309176"},"pull_request":{"href":"https://api.github.com/repos/DataDog/pybars3/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/DataDog/pybars3/pulls/1","id":50128830,"html_url":"https://github.com/DataDog/pybars3/pull/1","diff_url":"https://github.com/DataDog/pybars3/pull/1.diff","patch_url":"https://github.com/DataDog/pybars3/pull/1.patch","issue_url":"https://api.github.com/repos/DataDog/pybars3/issues/1","number":1,"state":"open","locked":false,"title":"Improve error parsing","user":{"login":"isaacdd","id":7524964,"avatar_url":"https://avatars.githubusercontent.com/u/7524964?v=3","gravatar_id":"","url":"https://api.github.com/users/isaacdd","html_url":"https://github.com/isaacdd","followers_url":"https://api.github.com/users/isaacdd/followers","following_url":"https://api.github.com/users/isaacdd/following{/other_user}","gists_url":"https://api.github.com/users/isaacdd/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacdd/subscriptions","organizations_url":"https://api.github.com/users/isaacdd/orgs","repos_url":"https://api.github.com/users/isaacdd/repos","events_url":"https://api.github.com/users/isaacdd/events{/privacy}","received_events_url":"https://api.github.com/users/isaacdd/received_events","type":"User","site_admin":false},"body":"1. Report an error whenever parse position < source length\r\n2. Do not use underlying OMeta error reason because it is not helpful\r\n3. Extract the word where the parsing error occurred and report it\r\n4. Update a test and add more for error validation","created_at":"2015-11-09T14:33:27Z","updated_at":"2015-11-09T18:18:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d4889779faa029248e68bf585f8292986c02a33","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/pybars3/pulls/1/commits","review_comments_url":"https://api.github.com/repos/DataDog/pybars3/pulls/1/comments","review_comment_url":"https://api.github.com/repos/DataDog/pybars3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/pybars3/issues/1/comments","statuses_url":"https://api.github.com/repos/DataDog/pybars3/statuses/06d0a4d3591c1df9ef6fa3ca43fa13a66efbbb58","head":{"label":"isaacdd:master","ref":"master","sha":"06d0a4d3591c1df9ef6fa3ca43fa13a66efbbb58","user":{"login":"isaacdd","id":7524964,"avatar_url":"https://avatars.githubusercontent.com/u/7524964?v=3","gravatar_id":"","url":"https://api.github.com/users/isaacdd","html_url":"https://github.com/isaacdd","followers_url":"https://api.github.com/users/isaacdd/followers","following_url":"https://api.github.com/users/isaacdd/following{/other_user}","gists_url":"https://api.github.com/users/isaacdd/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacdd/subscriptions","organizations_url":"https://api.github.com/users/isaacdd/orgs","repos_url":"https://api.github.com/users/isaacdd/repos","events_url":"https://api.github.com/users/isaacdd/events{/privacy}","received_events_url":"https://api.github.com/users/isaacdd/received_events","type":"User","site_admin":false},"repo":{"id":45715507,"name":"pybars3","full_name":"isaacdd/pybars3","owner":{"login":"isaacdd","id":7524964,"avatar_url":"https://avatars.githubusercontent.com/u/7524964?v=3","gravatar_id":"","url":"https://api.github.com/users/isaacdd","html_url":"https://github.com/isaacdd","followers_url":"https://api.github.com/users/isaacdd/followers","following_url":"https://api.github.com/users/isaacdd/following{/other_user}","gists_url":"https://api.github.com/users/isaacdd/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacdd/subscriptions","organizations_url":"https://api.github.com/users/isaacdd/orgs","repos_url":"https://api.github.com/users/isaacdd/repos","events_url":"https://api.github.com/users/isaacdd/events{/privacy}","received_events_url":"https://api.github.com/users/isaacdd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isaacdd/pybars3","description":"Handlebars.js template support for Python 3 and 2","fork":true,"url":"https://api.github.com/repos/isaacdd/pybars3","forks_url":"https://api.github.com/repos/isaacdd/pybars3/forks","keys_url":"https://api.github.com/repos/isaacdd/pybars3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isaacdd/pybars3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isaacdd/pybars3/teams","hooks_url":"https://api.github.com/repos/isaacdd/pybars3/hooks","issue_events_url":"https://api.github.com/repos/isaacdd/pybars3/issues/events{/number}","events_url":"https://api.github.com/repos/isaacdd/pybars3/events","assignees_url":"https://api.github.com/repos/isaacdd/pybars3/assignees{/user}","branches_url":"https://api.github.com/repos/isaacdd/pybars3/branches{/branch}","tags_url":"https://api.github.com/repos/isaacdd/pybars3/tags","blobs_url":"https://api.github.com/repos/isaacdd/pybars3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isaacdd/pybars3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isaacdd/pybars3/git/refs{/sha}","trees_url":"https://api.github.com/repos/isaacdd/pybars3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isaacdd/pybars3/statuses/{sha}","languages_url":"https://api.github.com/repos/isaacdd/pybars3/languages","stargazers_url":"https://api.github.com/repos/isaacdd/pybars3/stargazers","contributors_url":"https://api.github.com/repos/isaacdd/pybars3/contributors","subscribers_url":"https://api.github.com/repos/isaacdd/pybars3/subscribers","subscription_url":"https://api.github.com/repos/isaacdd/pybars3/subscription","commits_url":"https://api.github.com/repos/isaacdd/pybars3/commits{/sha}","git_commits_url":"https://api.github.com/repos/isaacdd/pybars3/git/commits{/sha}","comments_url":"https://api.github.com/repos/isaacdd/pybars3/comments{/number}","issue_comment_url":"https://api.github.com/repos/isaacdd/pybars3/issues/comments{/number}","contents_url":"https://api.github.com/repos/isaacdd/pybars3/contents/{+path}","compare_url":"https://api.github.com/repos/isaacdd/pybars3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isaacdd/pybars3/merges","archive_url":"https://api.github.com/repos/isaacdd/pybars3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isaacdd/pybars3/downloads","issues_url":"https://api.github.com/repos/isaacdd/pybars3/issues{/number}","pulls_url":"https://api.github.com/repos/isaacdd/pybars3/pulls{/number}","milestones_url":"https://api.github.com/repos/isaacdd/pybars3/milestones{/number}","notifications_url":"https://api.github.com/repos/isaacdd/pybars3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isaacdd/pybars3/labels{/name}","releases_url":"https://api.github.com/repos/isaacdd/pybars3/releases{/id}","created_at":"2015-11-07T00:23:27Z","updated_at":"2015-11-07T00:23:28Z","pushed_at":"2015-11-08T20:24:47Z","git_url":"git://github.com/isaacdd/pybars3.git","ssh_url":"git@github.com:isaacdd/pybars3.git","clone_url":"https://github.com/isaacdd/pybars3.git","svn_url":"https://github.com/isaacdd/pybars3","homepage":"","size":231,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"2d07d13fc7ffc0b423ff5dcafe4f25a85b1b57b3","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":40975757,"name":"pybars3","full_name":"DataDog/pybars3","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/pybars3","description":"Handlebars.js template support for Python 3 and 2","fork":true,"url":"https://api.github.com/repos/DataDog/pybars3","forks_url":"https://api.github.com/repos/DataDog/pybars3/forks","keys_url":"https://api.github.com/repos/DataDog/pybars3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/pybars3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/pybars3/teams","hooks_url":"https://api.github.com/repos/DataDog/pybars3/hooks","issue_events_url":"https://api.github.com/repos/DataDog/pybars3/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/pybars3/events","assignees_url":"https://api.github.com/repos/DataDog/pybars3/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/pybars3/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/pybars3/tags","blobs_url":"https://api.github.com/repos/DataDog/pybars3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/pybars3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/pybars3/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/pybars3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/pybars3/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/pybars3/languages","stargazers_url":"https://api.github.com/repos/DataDog/pybars3/stargazers","contributors_url":"https://api.github.com/repos/DataDog/pybars3/contributors","subscribers_url":"https://api.github.com/repos/DataDog/pybars3/subscribers","subscription_url":"https://api.github.com/repos/DataDog/pybars3/subscription","commits_url":"https://api.github.com/repos/DataDog/pybars3/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/pybars3/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/pybars3/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/pybars3/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/pybars3/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/pybars3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/pybars3/merges","archive_url":"https://api.github.com/repos/DataDog/pybars3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/pybars3/downloads","issues_url":"https://api.github.com/repos/DataDog/pybars3/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/pybars3/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/pybars3/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/pybars3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/pybars3/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/pybars3/releases{/id}","created_at":"2015-08-18T14:10:08Z","updated_at":"2015-08-18T14:10:08Z","pushed_at":"2015-11-09T14:33:28Z","git_url":"git://github.com/DataDog/pybars3.git","ssh_url":"git@github.com:DataDog/pybars3.git","clone_url":"https://github.com/DataDog/pybars3.git","svn_url":"https://github.com/DataDog/pybars3","homepage":"","size":227,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/pybars3/pulls/1"},"html":{"href":"https://github.com/DataDog/pybars3/pull/1"},"issue":{"href":"https://api.github.com/repos/DataDog/pybars3/issues/1"},"comments":{"href":"https://api.github.com/repos/DataDog/pybars3/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/pybars3/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/pybars3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/pybars3/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/pybars3/statuses/06d0a4d3591c1df9ef6fa3ca43fa13a66efbbb58"}}}}