{"action":"closed","number":52,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-singa/pulls/52","id":42515007,"html_url":"https://github.com/apache/incubator-singa/pull/52","diff_url":"https://github.com/apache/incubator-singa/pull/52.diff","patch_url":"https://github.com/apache/incubator-singa/pull/52.patch","issue_url":"https://api.github.com/repos/apache/incubator-singa/issues/52","number":52,"state":"closed","locked":false,"title":"Refactor Param and implement Driver","user":{"login":"nudles","id":3797447,"avatar_url":"https://avatars.githubusercontent.com/u/3797447?v=3","gravatar_id":"","url":"https://api.github.com/users/nudles","html_url":"https://github.com/nudles","followers_url":"https://api.github.com/users/nudles/followers","following_url":"https://api.github.com/users/nudles/following{/other_user}","gists_url":"https://api.github.com/users/nudles/gists{/gist_id}","starred_url":"https://api.github.com/users/nudles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nudles/subscriptions","organizations_url":"https://api.github.com/users/nudles/orgs","repos_url":"https://api.github.com/users/nudles/repos","events_url":"https://api.github.com/users/nudles/events{/privacy}","received_events_url":"https://api.github.com/users/nudles/received_events","type":"User","site_admin":false},"body":"A Driver class is implemeted, which includes the following functions:\r\n     \r\n  *  Init() to init glogs, gflags (may remove the dependency on flags later); register built-in layers, updaters, etc.; setup folders; init MPI if MPI is used for message passing.\r\n  *  RegisterLayer/Updater/Worker/Param, for registering user defined layers, updaters, etc.\r\n  *  Submit() for submitting the job configuration.\r\n   The main function calls Driver::Init and Dirver::Submit to launch a training job.\r\n\r\nRefactor Param class to clean the code of ParseUpdateMsg and fix the bugs from initializing parameters based on fan in number.  There are many layers using weight matrix, e.g., convolution layer and innerproduct layer. Some initialization methods of the weight matrix are based on the fan-in of the matrix, i.e., the dimension interacts with the other operator. E.g., for v*W, W's fan-in is the number of rows; For v*W^T, W's fan-in is the number of columns. However, the Param::InitValues() method does not know the position (and transposition) of the matrix in the multiplication operation. We have to fix the fan-in dimension. Particularly, we fix it to the second dimension (i.e., number of columns) and assume users use the weight matrix correctly. The current implementation of convolution layer and innerproduct layer have different fan-in dimension, which should be unified to the second dimension. For the convolution layer, its operation is W*v. W's fan-in is already the number of columns. For the innerproduct layer, the current operation is v*W, which should be updated to v*W^T, then the fan-in is the number of columns.\r\n\r\n","created_at":"2015-08-15T06:38:35Z","updated_at":"2015-08-15T08:11:22Z","closed_at":"2015-08-15T08:11:22Z","merged_at":"2015-08-15T08:11:22Z","merge_commit_sha":"b0e56ff7503550dbe92a4db9f942337d592c3fee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-singa/pulls/52/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-singa/pulls/52/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-singa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-singa/issues/52/comments","statuses_url":"https://api.github.com/repos/apache/incubator-singa/statuses/75b2e047313eef36ce04f20d36980f751839b3d8","head":{"label":"nudles:refactor-driver","ref":"refactor-driver","sha":"75b2e047313eef36ce04f20d36980f751839b3d8","user":{"login":"nudles","id":3797447,"avatar_url":"https://avatars.githubusercontent.com/u/3797447?v=3","gravatar_id":"","url":"https://api.github.com/users/nudles","html_url":"https://github.com/nudles","followers_url":"https://api.github.com/users/nudles/followers","following_url":"https://api.github.com/users/nudles/following{/other_user}","gists_url":"https://api.github.com/users/nudles/gists{/gist_id}","starred_url":"https://api.github.com/users/nudles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nudles/subscriptions","organizations_url":"https://api.github.com/users/nudles/orgs","repos_url":"https://api.github.com/users/nudles/repos","events_url":"https://api.github.com/users/nudles/events{/privacy}","received_events_url":"https://api.github.com/users/nudles/received_events","type":"User","site_admin":false},"repo":{"id":34988072,"name":"incubator-singa","full_name":"nudles/incubator-singa","owner":{"login":"nudles","id":3797447,"avatar_url":"https://avatars.githubusercontent.com/u/3797447?v=3","gravatar_id":"","url":"https://api.github.com/users/nudles","html_url":"https://github.com/nudles","followers_url":"https://api.github.com/users/nudles/followers","following_url":"https://api.github.com/users/nudles/following{/other_user}","gists_url":"https://api.github.com/users/nudles/gists{/gist_id}","starred_url":"https://api.github.com/users/nudles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nudles/subscriptions","organizations_url":"https://api.github.com/users/nudles/orgs","repos_url":"https://api.github.com/users/nudles/repos","events_url":"https://api.github.com/users/nudles/events{/privacy}","received_events_url":"https://api.github.com/users/nudles/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nudles/incubator-singa","description":"Mirror of Apache Singa (Incubating)","fork":true,"url":"https://api.github.com/repos/nudles/incubator-singa","forks_url":"https://api.github.com/repos/nudles/incubator-singa/forks","keys_url":"https://api.github.com/repos/nudles/incubator-singa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nudles/incubator-singa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nudles/incubator-singa/teams","hooks_url":"https://api.github.com/repos/nudles/incubator-singa/hooks","issue_events_url":"https://api.github.com/repos/nudles/incubator-singa/issues/events{/number}","events_url":"https://api.github.com/repos/nudles/incubator-singa/events","assignees_url":"https://api.github.com/repos/nudles/incubator-singa/assignees{/user}","branches_url":"https://api.github.com/repos/nudles/incubator-singa/branches{/branch}","tags_url":"https://api.github.com/repos/nudles/incubator-singa/tags","blobs_url":"https://api.github.com/repos/nudles/incubator-singa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nudles/incubator-singa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nudles/incubator-singa/git/refs{/sha}","trees_url":"https://api.github.com/repos/nudles/incubator-singa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nudles/incubator-singa/statuses/{sha}","languages_url":"https://api.github.com/repos/nudles/incubator-singa/languages","stargazers_url":"https://api.github.com/repos/nudles/incubator-singa/stargazers","contributors_url":"https://api.github.com/repos/nudles/incubator-singa/contributors","subscribers_url":"https://api.github.com/repos/nudles/incubator-singa/subscribers","subscription_url":"https://api.github.com/repos/nudles/incubator-singa/subscription","commits_url":"https://api.github.com/repos/nudles/incubator-singa/commits{/sha}","git_commits_url":"https://api.github.com/repos/nudles/incubator-singa/git/commits{/sha}","comments_url":"https://api.github.com/repos/nudles/incubator-singa/comments{/number}","issue_comment_url":"https://api.github.com/repos/nudles/incubator-singa/issues/comments{/number}","contents_url":"https://api.github.com/repos/nudles/incubator-singa/contents/{+path}","compare_url":"https://api.github.com/repos/nudles/incubator-singa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nudles/incubator-singa/merges","archive_url":"https://api.github.com/repos/nudles/incubator-singa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nudles/incubator-singa/downloads","issues_url":"https://api.github.com/repos/nudles/incubator-singa/issues{/number}","pulls_url":"https://api.github.com/repos/nudles/incubator-singa/pulls{/number}","milestones_url":"https://api.github.com/repos/nudles/incubator-singa/milestones{/number}","notifications_url":"https://api.github.com/repos/nudles/incubator-singa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nudles/incubator-singa/labels{/name}","releases_url":"https://api.github.com/repos/nudles/incubator-singa/releases{/id}","created_at":"2015-05-03T14:09:05Z","updated_at":"2015-05-07T11:28:05Z","pushed_at":"2015-08-15T07:06:30Z","git_url":"git://github.com/nudles/incubator-singa.git","ssh_url":"git@github.com:nudles/incubator-singa.git","clone_url":"https://github.com/nudles/incubator-singa.git","svn_url":"https://github.com/nudles/incubator-singa","homepage":null,"size":20800,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d269b67c477c819c107d78690d8163eb06eefdb2","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":33294317,"name":"incubator-singa","full_name":"apache/incubator-singa","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-singa","description":"Mirror of Apache Singa (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-singa","forks_url":"https://api.github.com/repos/apache/incubator-singa/forks","keys_url":"https://api.github.com/repos/apache/incubator-singa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-singa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-singa/teams","hooks_url":"https://api.github.com/repos/apache/incubator-singa/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-singa/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-singa/events","assignees_url":"https://api.github.com/repos/apache/incubator-singa/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-singa/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-singa/tags","blobs_url":"https://api.github.com/repos/apache/incubator-singa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-singa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-singa/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-singa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-singa/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-singa/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-singa/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-singa/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-singa/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-singa/subscription","commits_url":"https://api.github.com/repos/apache/incubator-singa/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-singa/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-singa/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-singa/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-singa/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-singa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-singa/merges","archive_url":"https://api.github.com/repos/apache/incubator-singa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-singa/downloads","issues_url":"https://api.github.com/repos/apache/incubator-singa/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-singa/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-singa/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-singa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-singa/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-singa/releases{/id}","created_at":"2015-04-02T07:00:05Z","updated_at":"2015-07-29T10:10:00Z","pushed_at":"2015-08-15T08:11:22Z","git_url":"git://github.com/apache/incubator-singa.git","ssh_url":"git@github.com:apache/incubator-singa.git","clone_url":"https://github.com/apache/incubator-singa.git","svn_url":"https://github.com/apache/incubator-singa","homepage":null,"size":2440,"stargazers_count":47,"watchers_count":47,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":"git://git.apache.org/incubator-singa.git","open_issues_count":3,"forks":27,"open_issues":3,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-singa/pulls/52"},"html":{"href":"https://github.com/apache/incubator-singa/pull/52"},"issue":{"href":"https://api.github.com/repos/apache/incubator-singa/issues/52"},"comments":{"href":"https://api.github.com/repos/apache/incubator-singa/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-singa/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-singa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-singa/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-singa/statuses/75b2e047313eef36ce04f20d36980f751839b3d8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"asfgit","id":1341245,"avatar_url":"https://avatars.githubusercontent.com/u/1341245?v=3","gravatar_id":"","url":"https://api.github.com/users/asfgit","html_url":"https://github.com/asfgit","followers_url":"https://api.github.com/users/asfgit/followers","following_url":"https://api.github.com/users/asfgit/following{/other_user}","gists_url":"https://api.github.com/users/asfgit/gists{/gist_id}","starred_url":"https://api.github.com/users/asfgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asfgit/subscriptions","organizations_url":"https://api.github.com/users/asfgit/orgs","repos_url":"https://api.github.com/users/asfgit/repos","events_url":"https://api.github.com/users/asfgit/events{/privacy}","received_events_url":"https://api.github.com/users/asfgit/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":5,"additions":347,"deletions":264,"changed_files":17}}