{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/924","labels_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/924/labels{/name}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/924/comments","events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/924/events","html_url":"https://github.com/facebook/AsyncDisplayKit/pull/924","id":120981237,"number":924,"title":"Improve ASMapNode to get ready for 2.0","user":{"login":"aaronschubert0","id":9281756,"avatar_url":"https://avatars.githubusercontent.com/u/9281756?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronschubert0","html_url":"https://github.com/aaronschubert0","followers_url":"https://api.github.com/users/aaronschubert0/followers","following_url":"https://api.github.com/users/aaronschubert0/following{/other_user}","gists_url":"https://api.github.com/users/aaronschubert0/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronschubert0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronschubert0/subscriptions","organizations_url":"https://api.github.com/users/aaronschubert0/orgs","repos_url":"https://api.github.com/users/aaronschubert0/repos","events_url":"https://api.github.com/users/aaronschubert0/events{/privacy}","received_events_url":"https://api.github.com/users/aaronschubert0/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/labels/API%20improvement","name":"API improvement","color":"eb6420"},{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/labels/CLA%20Signed","name":"CLA Signed","color":"bfe5bf"},{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/labels/pr%20-%20needs%20review","name":"pr - needs review","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/milestones/12","html_url":"https://github.com/facebook/AsyncDisplayKit/milestones/1.9.4","labels_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/milestones/12/labels","id":1451117,"number":12,"title":"1.9.4","description":null,"creator":{"login":"appleguy","id":565251,"avatar_url":"https://avatars.githubusercontent.com/u/565251?v=3","gravatar_id":"","url":"https://api.github.com/users/appleguy","html_url":"https://github.com/appleguy","followers_url":"https://api.github.com/users/appleguy/followers","following_url":"https://api.github.com/users/appleguy/following{/other_user}","gists_url":"https://api.github.com/users/appleguy/gists{/gist_id}","starred_url":"https://api.github.com/users/appleguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleguy/subscriptions","organizations_url":"https://api.github.com/users/appleguy/orgs","repos_url":"https://api.github.com/users/appleguy/repos","events_url":"https://api.github.com/users/appleguy/events{/privacy}","received_events_url":"https://api.github.com/users/appleguy/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":1,"state":"open","created_at":"2015-12-09T02:15:07Z","updated_at":"2015-12-11T04:17:45Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-12-08T10:44:09Z","updated_at":"2015-12-11T15:21:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/924","html_url":"https://github.com/facebook/AsyncDisplayKit/pull/924","diff_url":"https://github.com/facebook/AsyncDisplayKit/pull/924.diff","patch_url":"https://github.com/facebook/AsyncDisplayKit/pull/924.patch"},"body":"Hey @appleguy, here are changes based on your latest feedback\r\nNotable changes:\r\n- Changed init method to `-initWithRegion:` instead of `initWithCoordinate:`\r\n- You can now call setLiveMap before ASMapNode has been loaded to start off with a live map view.\r\n- Smaller syntax changes and clean up.\r\n\r\nJust had a thought though, would it be useful for people to be able to change the region after the initialisation of ASMapNode, should we provide a method for this?"},"comment":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/comments/163962057","html_url":"https://github.com/facebook/AsyncDisplayKit/pull/924#issuecomment-163962057","issue_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/924","id":163962057,"user":{"login":"aaronschubert0","id":9281756,"avatar_url":"https://avatars.githubusercontent.com/u/9281756?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronschubert0","html_url":"https://github.com/aaronschubert0","followers_url":"https://api.github.com/users/aaronschubert0/followers","following_url":"https://api.github.com/users/aaronschubert0/following{/other_user}","gists_url":"https://api.github.com/users/aaronschubert0/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronschubert0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronschubert0/subscriptions","organizations_url":"https://api.github.com/users/aaronschubert0/orgs","repos_url":"https://api.github.com/users/aaronschubert0/repos","events_url":"https://api.github.com/users/aaronschubert0/events{/privacy}","received_events_url":"https://api.github.com/users/aaronschubert0/received_events","type":"User","site_admin":false},"created_at":"2015-12-11T15:21:30Z","updated_at":"2015-12-11T15:21:30Z","body":"@appleguy Hmm this is a tricky one. I've been thinking about this for a few days now. I'm not sure how comfortable I would be in having no custom init method that clearly specifies an action. If we did get rid of initWithRegion then we would have to provide a suitable default so that ASMapNode works out of the box. Although [[ASMapNode alloc] init] doesn't produce anything great either at the moment. I'm still 50/50. The layout spec (as well as ASImage/Text/ControlNode etc) conforms to a standard -init and then setting properties so maybe we should actually go this way to keep in line with the framework. Should we provide a default in this case?"}}