{"action":"created","issue":{"url":"https://api.github.com/repos/boxen/puppet-pow/issues/21","labels_url":"https://api.github.com/repos/boxen/puppet-pow/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/boxen/puppet-pow/issues/21/comments","events_url":"https://api.github.com/repos/boxen/puppet-pow/issues/21/events","html_url":"https://github.com/boxen/puppet-pow/pull/21","id":53792211,"number":21,"title":"Fix ext_domains support, refactor domain string manipulation","user":{"login":"jmileham","id":40619,"avatar_url":"https://avatars.githubusercontent.com/u/40619?v=3","gravatar_id":"","url":"https://api.github.com/users/jmileham","html_url":"https://github.com/jmileham","followers_url":"https://api.github.com/users/jmileham/followers","following_url":"https://api.github.com/users/jmileham/following{/other_user}","gists_url":"https://api.github.com/users/jmileham/gists{/gist_id}","starred_url":"https://api.github.com/users/jmileham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmileham/subscriptions","organizations_url":"https://api.github.com/users/jmileham/orgs","repos_url":"https://api.github.com/users/jmileham/repos","events_url":"https://api.github.com/users/jmileham/events{/privacy}","received_events_url":"https://api.github.com/users/jmileham/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-01-08T19:45:41Z","updated_at":"2015-01-08T20:04:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/boxen/puppet-pow/pulls/21","html_url":"https://github.com/boxen/puppet-pow/pull/21","diff_url":"https://github.com/boxen/puppet-pow/pull/21.diff","patch_url":"https://github.com/boxen/puppet-pow/pull/21.patch"},"body":"We discovered that using `domains` to provide xip.io support broke our ability to make requests from other machines on the same network that are also running boxen, because when put in `domains`, `*.xip.io` starts resolving to localhost, even if you type in somebody else's IP.\r\n\r\nBut when we switched it to `ext_domains`, we realized that ext_domains support is broken for the nginx proxy mode.  This patch addresses that, as well as refactoring all of the string manipulation that takes place on domains and ext_domains in the module.\r\n\r\nBecause the strings were handled differently in different places, it turns out that the /etc/resolver files could end up with spaces on the front.\r\n\r\nFor example the following:\r\n\r\n```puppet\r\nclass {'pow':\r\n  domains => 'pow, foo'\r\n}\r\n```\r\n\r\nwould result in a file named `/etc/resolver/ foo`.\r\n\r\nThis appears to have been unnoticed because the resolvers still functioned normally, even with the extra spaces.  Anyway, this PR also addresses that issue and tidies up several templates that were implementing their own string manipulation logic."},"comment":{"url":"https://api.github.com/repos/boxen/puppet-pow/issues/comments/69239955","html_url":"https://github.com/boxen/puppet-pow/pull/21#issuecomment-69239955","issue_url":"https://api.github.com/repos/boxen/puppet-pow/issues/21","id":69239955,"user":{"login":"jmileham","id":40619,"avatar_url":"https://avatars.githubusercontent.com/u/40619?v=3","gravatar_id":"","url":"https://api.github.com/users/jmileham","html_url":"https://github.com/jmileham","followers_url":"https://api.github.com/users/jmileham/followers","following_url":"https://api.github.com/users/jmileham/following{/other_user}","gists_url":"https://api.github.com/users/jmileham/gists{/gist_id}","starred_url":"https://api.github.com/users/jmileham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmileham/subscriptions","organizations_url":"https://api.github.com/users/jmileham/orgs","repos_url":"https://api.github.com/users/jmileham/repos","events_url":"https://api.github.com/users/jmileham/events{/privacy}","received_events_url":"https://api.github.com/users/jmileham/received_events","type":"User","site_admin":false},"created_at":"2015-01-08T20:04:05Z","updated_at":"2015-01-08T20:04:05Z","body":"Reopening.  Hopefully under the API rate limit."}}