{"action":"created","issue":{"url":"https://api.github.com/repos/oppia/oppia/issues/1045","labels_url":"https://api.github.com/repos/oppia/oppia/issues/1045/labels{/name}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/1045/comments","events_url":"https://api.github.com/repos/oppia/oppia/issues/1045/events","html_url":"https://github.com/oppia/oppia/pull/1045","id":112654129,"number":1045,"title":"Adds text-to-speech function to explorations","user":{"login":"edallison","id":12070449,"avatar_url":"https://avatars.githubusercontent.com/u/12070449?v=3","gravatar_id":"","url":"https://api.github.com/users/edallison","html_url":"https://github.com/edallison","followers_url":"https://api.github.com/users/edallison/followers","following_url":"https://api.github.com/users/edallison/following{/other_user}","gists_url":"https://api.github.com/users/edallison/gists{/gist_id}","starred_url":"https://api.github.com/users/edallison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edallison/subscriptions","organizations_url":"https://api.github.com/users/edallison/orgs","repos_url":"https://api.github.com/users/edallison/repos","events_url":"https://api.github.com/users/edallison/events{/privacy}","received_events_url":"https://api.github.com/users/edallison/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/oppia/oppia/labels/IN%20REVIEW%20-%20don't%20merge","name":"IN REVIEW - don't merge","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars.githubusercontent.com/u/10575562?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"milestone":null,"comments":15,"created_at":"2015-10-21T18:46:21Z","updated_at":"2015-10-28T04:54:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/1045","html_url":"https://github.com/oppia/oppia/pull/1045","diff_url":"https://github.com/oppia/oppia/pull/1045.diff","patch_url":"https://github.com/oppia/oppia/pull/1045.patch"},"body":"Any feedback/advice would be greatly appreciated.  "},"comment":{"url":"https://api.github.com/repos/oppia/oppia/issues/comments/151725248","html_url":"https://github.com/oppia/oppia/pull/1045#issuecomment-151725248","issue_url":"https://api.github.com/repos/oppia/oppia/issues/1045","id":151725248,"user":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars.githubusercontent.com/u/10575562?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"created_at":"2015-10-28T04:54:50Z","updated_at":"2015-10-28T04:54:50Z","body":"Hm, a few notes:\r\n\r\n1) If getting your branch back in sync is tricky, one thing you could do is to check out a fresh copy of develop, check out a new branch, manually make the changes on top of that new branch, then create a new PR (and close the old one). That's totally fine, and may indeed in some cases be simpler than handling the merge!\r\n\r\n2) In general, bug reports like this could use more detail. For example, instead of saying that you \"injected the speechService dependency\", it's better to say something like: I changed these lines of this file to these lines instead (copy-pasting the lines explicitly into the bug report or comment). This way, I (or someone else) can exactly reproduce your changes. The current error report's a bit vague, and in fact my first guess on reading it was that you might have added speechService in line 167 but forgot to add it in line 171 -- this is because I didn't have enough detail to know what exactly you did.\r\n\r\n3) Another tip when reporting errors: try not to just say \"it breaks the page\" -- that's hard to debug! Instead, look at the browser console and server logs to try and figure out if there are any errors. In the browser console, the errors are red, and usually give some sort of clue as to what's going on; in the server logs, the errors are prefixed with `ERROR`. Note that the server logs can be found in the terminal where you typed `bash scripts/start.sh`.\r\n\r\n4) Having said all that, I managed to reproduce the issue, and then looked at the browser logs, which seemed to indicate a dependency error. Based on the error message, I think the issue is that, in speechServices, you're referring to a `$scope` dependency, which is available only for controllers but not factories. Taking out that dependency makes it work!"}}