{"action":"created","comment":{"url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/comments/32426289","id":32426289,"diff_hunk":"@@ -10,14 +8,10 @@ extendView['orchestraMediaType'] =\n     previewId = '#previewImage_' + target.data('input')\n     $(inputId).val ''\n     $(previewId).removeAttr 'src'\n-  openMediaModal: (event) ->\n-    event.preventDefault()\n-    @method = if @options.method then @options.method else 'GET'\n-    target = $(event.currentTarget)\n-    modal = $('#' + target.data(\"target\"), @$el)\n-    inputId = target.data(\"input\")\n-    url = target.data(\"url\")\n-    viewClass = appConfigurationView.getConfiguration('media', 'showMediaModal')\n+\n+  openMediaModal: (modal, inputId, url, method, mediaModalView) ->\n+    mediaModalView = mediaModalView or \"showMediaModal\"","path":"MediaAdminBundle/Resources/public/coffee/extendView/orchestraAbstractMediaType.coffee","position":25,"original_position":25,"commit_id":"42b727a82502975dae7e437c96de0497b7273e9a","original_commit_id":"42b727a82502975dae7e437c96de0497b7273e9a","user":{"login":"itkg-ngilain","id":6725138,"avatar_url":"https://avatars.githubusercontent.com/u/6725138?v=3","gravatar_id":"","url":"https://api.github.com/users/itkg-ngilain","html_url":"https://github.com/itkg-ngilain","followers_url":"https://api.github.com/users/itkg-ngilain/followers","following_url":"https://api.github.com/users/itkg-ngilain/following{/other_user}","gists_url":"https://api.github.com/users/itkg-ngilain/gists{/gist_id}","starred_url":"https://api.github.com/users/itkg-ngilain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itkg-ngilain/subscriptions","organizations_url":"https://api.github.com/users/itkg-ngilain/orgs","repos_url":"https://api.github.com/users/itkg-ngilain/repos","events_url":"https://api.github.com/users/itkg-ngilain/events{/privacy}","received_events_url":"https://api.github.com/users/itkg-ngilain/received_events","type":"User","site_admin":false},"body":"Can you use instead the feature of coffee allowing to declare default value in function signature ?\r\nopenMediaModal: (modal, inputId, url, method, mediaModalView = \"showMediaModal\")","created_at":"2015-06-15T14:36:02Z","updated_at":"2015-06-15T14:36:02Z","html_url":"https://github.com/open-orchestra/open-orchestra-cms-bundle/pull/796#discussion_r32426289","pull_request_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/796","_links":{"self":{"href":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/comments/32426289"},"html":{"href":"https://github.com/open-orchestra/open-orchestra-cms-bundle/pull/796#discussion_r32426289"},"pull_request":{"href":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/796"}}},"pull_request":{"url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/796","id":36735454,"html_url":"https://github.com/open-orchestra/open-orchestra-cms-bundle/pull/796","diff_url":"https://github.com/open-orchestra/open-orchestra-cms-bundle/pull/796.diff","patch_url":"https://github.com/open-orchestra/open-orchestra-cms-bundle/pull/796.patch","issue_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/issues/796","number":796,"state":"open","locked":false,"title":"media  modal activation","user":{"login":"itkg-rboessel","id":11752276,"avatar_url":"https://avatars.githubusercontent.com/u/11752276?v=3","gravatar_id":"","url":"https://api.github.com/users/itkg-rboessel","html_url":"https://github.com/itkg-rboessel","followers_url":"https://api.github.com/users/itkg-rboessel/followers","following_url":"https://api.github.com/users/itkg-rboessel/following{/other_user}","gists_url":"https://api.github.com/users/itkg-rboessel/gists{/gist_id}","starred_url":"https://api.github.com/users/itkg-rboessel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itkg-rboessel/subscriptions","organizations_url":"https://api.github.com/users/itkg-rboessel/orgs","repos_url":"https://api.github.com/users/itkg-rboessel/repos","events_url":"https://api.github.com/users/itkg-rboessel/events{/privacy}","received_events_url":"https://api.github.com/users/itkg-rboessel/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-02T14:38:19Z","updated_at":"2015-06-15T14:36:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6f2cc6273739e5300c513ba079d7da9f3ae095b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/796/commits","review_comments_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/796/comments","review_comment_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/issues/796/comments","statuses_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/statuses/42b727a82502975dae7e437c96de0497b7273e9a","head":{"label":"open-orchestra:tinymce_media","ref":"tinymce_media","sha":"42b727a82502975dae7e437c96de0497b7273e9a","user":{"login":"open-orchestra","id":11756116,"avatar_url":"https://avatars.githubusercontent.com/u/11756116?v=3","gravatar_id":"","url":"https://api.github.com/users/open-orchestra","html_url":"https://github.com/open-orchestra","followers_url":"https://api.github.com/users/open-orchestra/followers","following_url":"https://api.github.com/users/open-orchestra/following{/other_user}","gists_url":"https://api.github.com/users/open-orchestra/gists{/gist_id}","starred_url":"https://api.github.com/users/open-orchestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-orchestra/subscriptions","organizations_url":"https://api.github.com/users/open-orchestra/orgs","repos_url":"https://api.github.com/users/open-orchestra/repos","events_url":"https://api.github.com/users/open-orchestra/events{/privacy}","received_events_url":"https://api.github.com/users/open-orchestra/received_events","type":"Organization","site_admin":false},"repo":{"id":21900253,"name":"open-orchestra-cms-bundle","full_name":"open-orchestra/open-orchestra-cms-bundle","owner":{"login":"open-orchestra","id":11756116,"avatar_url":"https://avatars.githubusercontent.com/u/11756116?v=3","gravatar_id":"","url":"https://api.github.com/users/open-orchestra","html_url":"https://github.com/open-orchestra","followers_url":"https://api.github.com/users/open-orchestra/followers","following_url":"https://api.github.com/users/open-orchestra/following{/other_user}","gists_url":"https://api.github.com/users/open-orchestra/gists{/gist_id}","starred_url":"https://api.github.com/users/open-orchestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-orchestra/subscriptions","organizations_url":"https://api.github.com/users/open-orchestra/orgs","repos_url":"https://api.github.com/users/open-orchestra/repos","events_url":"https://api.github.com/users/open-orchestra/events{/privacy}","received_events_url":"https://api.github.com/users/open-orchestra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-orchestra/open-orchestra-cms-bundle","description":"The php orchestra cms bundle","fork":false,"url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle","forks_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/forks","keys_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/teams","hooks_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/hooks","issue_events_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/events","assignees_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/tags","blobs_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/languages","stargazers_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/stargazers","contributors_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/contributors","subscribers_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/subscribers","subscription_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/subscription","commits_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/merges","archive_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/downloads","issues_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/labels{/name}","releases_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/releases{/id}","created_at":"2014-07-16T12:49:27Z","updated_at":"2015-05-07T08:02:31Z","pushed_at":"2015-06-15T14:35:16Z","git_url":"git://github.com/open-orchestra/open-orchestra-cms-bundle.git","ssh_url":"git@github.com:open-orchestra/open-orchestra-cms-bundle.git","clone_url":"https://github.com/open-orchestra/open-orchestra-cms-bundle.git","svn_url":"https://github.com/open-orchestra/open-orchestra-cms-bundle","homepage":null,"size":24101,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"open-orchestra:master","ref":"master","sha":"ee02f216169b9e6694d0ac694991d518244c8e4e","user":{"login":"open-orchestra","id":11756116,"avatar_url":"https://avatars.githubusercontent.com/u/11756116?v=3","gravatar_id":"","url":"https://api.github.com/users/open-orchestra","html_url":"https://github.com/open-orchestra","followers_url":"https://api.github.com/users/open-orchestra/followers","following_url":"https://api.github.com/users/open-orchestra/following{/other_user}","gists_url":"https://api.github.com/users/open-orchestra/gists{/gist_id}","starred_url":"https://api.github.com/users/open-orchestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-orchestra/subscriptions","organizations_url":"https://api.github.com/users/open-orchestra/orgs","repos_url":"https://api.github.com/users/open-orchestra/repos","events_url":"https://api.github.com/users/open-orchestra/events{/privacy}","received_events_url":"https://api.github.com/users/open-orchestra/received_events","type":"Organization","site_admin":false},"repo":{"id":21900253,"name":"open-orchestra-cms-bundle","full_name":"open-orchestra/open-orchestra-cms-bundle","owner":{"login":"open-orchestra","id":11756116,"avatar_url":"https://avatars.githubusercontent.com/u/11756116?v=3","gravatar_id":"","url":"https://api.github.com/users/open-orchestra","html_url":"https://github.com/open-orchestra","followers_url":"https://api.github.com/users/open-orchestra/followers","following_url":"https://api.github.com/users/open-orchestra/following{/other_user}","gists_url":"https://api.github.com/users/open-orchestra/gists{/gist_id}","starred_url":"https://api.github.com/users/open-orchestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-orchestra/subscriptions","organizations_url":"https://api.github.com/users/open-orchestra/orgs","repos_url":"https://api.github.com/users/open-orchestra/repos","events_url":"https://api.github.com/users/open-orchestra/events{/privacy}","received_events_url":"https://api.github.com/users/open-orchestra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-orchestra/open-orchestra-cms-bundle","description":"The php orchestra cms bundle","fork":false,"url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle","forks_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/forks","keys_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/teams","hooks_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/hooks","issue_events_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/events","assignees_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/tags","blobs_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/languages","stargazers_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/stargazers","contributors_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/contributors","subscribers_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/subscribers","subscription_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/subscription","commits_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/merges","archive_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/downloads","issues_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/labels{/name}","releases_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/releases{/id}","created_at":"2014-07-16T12:49:27Z","updated_at":"2015-05-07T08:02:31Z","pushed_at":"2015-06-15T14:35:16Z","git_url":"git://github.com/open-orchestra/open-orchestra-cms-bundle.git","ssh_url":"git@github.com:open-orchestra/open-orchestra-cms-bundle.git","clone_url":"https://github.com/open-orchestra/open-orchestra-cms-bundle.git","svn_url":"https://github.com/open-orchestra/open-orchestra-cms-bundle","homepage":null,"size":24101,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/796"},"html":{"href":"https://github.com/open-orchestra/open-orchestra-cms-bundle/pull/796"},"issue":{"href":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/issues/796"},"comments":{"href":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/issues/796/comments"},"review_comments":{"href":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/796/comments"},"review_comment":{"href":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/796/commits"},"statuses":{"href":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/statuses/42b727a82502975dae7e437c96de0497b7273e9a"}}}}