{"action":"closed","number":713,"pull_request":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/713","id":41965991,"html_url":"https://github.com/OpenMW/openmw/pull/713","diff_url":"https://github.com/OpenMW/openmw/pull/713.diff","patch_url":"https://github.com/OpenMW/openmw/pull/713.patch","issue_url":"https://api.github.com/repos/OpenMW/openmw/issues/713","number":713,"state":"closed","locked":false,"title":"Starting work improve pathfinding","user":{"login":"dteviot","id":5157081,"avatar_url":"https://avatars.githubusercontent.com/u/5157081?v=3","gravatar_id":"","url":"https://api.github.com/users/dteviot","html_url":"https://github.com/dteviot","followers_url":"https://api.github.com/users/dteviot/followers","following_url":"https://api.github.com/users/dteviot/following{/other_user}","gists_url":"https://api.github.com/users/dteviot/gists{/gist_id}","starred_url":"https://api.github.com/users/dteviot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dteviot/subscriptions","organizations_url":"https://api.github.com/users/dteviot/orgs","repos_url":"https://api.github.com/users/dteviot/repos","events_url":"https://api.github.com/users/dteviot/events{/privacy}","received_events_url":"https://api.github.com/users/dteviot/received_events","type":"User","site_admin":false},"body":"@scrawl\r\n\r\nI suspect lines 224-228 are incorrect.\r\nWhen pathgrid returns a single node, it's being discarded and actor walks directly to destination.\r\nNeeds to build a path using the pathgrid node and the destination.\r\n\r\nI also suspect that lines 232-245 may not be needed, \r\naStarSearch() should not return an empty set as we're supplying two different points for a path.\r\nOnly way I can see aStarSearch() could return an empty path is if the path data we've been given is wrong. I have yet to check to see if aStarSearch() handles that case.","created_at":"2015-08-09T06:12:31Z","updated_at":"2015-08-14T08:14:00Z","closed_at":"2015-08-14T08:14:00Z","merged_at":"2015-08-14T08:14:00Z","merge_commit_sha":"efc3f176a411b30d7cb31e14f692cdb93d3be7cb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenMW/openmw/pulls/713/commits","review_comments_url":"https://api.github.com/repos/OpenMW/openmw/pulls/713/comments","review_comment_url":"https://api.github.com/repos/OpenMW/openmw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenMW/openmw/issues/713/comments","statuses_url":"https://api.github.com/repos/OpenMW/openmw/statuses/e42a2478dcae9445d72c48384658c682acc11f42","head":{"label":"dteviot:PathfindingRefactor","ref":"PathfindingRefactor","sha":"e42a2478dcae9445d72c48384658c682acc11f42","user":{"login":"dteviot","id":5157081,"avatar_url":"https://avatars.githubusercontent.com/u/5157081?v=3","gravatar_id":"","url":"https://api.github.com/users/dteviot","html_url":"https://github.com/dteviot","followers_url":"https://api.github.com/users/dteviot/followers","following_url":"https://api.github.com/users/dteviot/following{/other_user}","gists_url":"https://api.github.com/users/dteviot/gists{/gist_id}","starred_url":"https://api.github.com/users/dteviot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dteviot/subscriptions","organizations_url":"https://api.github.com/users/dteviot/orgs","repos_url":"https://api.github.com/users/dteviot/repos","events_url":"https://api.github.com/users/dteviot/events{/privacy}","received_events_url":"https://api.github.com/users/dteviot/received_events","type":"User","site_admin":false},"repo":{"id":27283529,"name":"openmw","full_name":"dteviot/openmw","owner":{"login":"dteviot","id":5157081,"avatar_url":"https://avatars.githubusercontent.com/u/5157081?v=3","gravatar_id":"","url":"https://api.github.com/users/dteviot","html_url":"https://github.com/dteviot","followers_url":"https://api.github.com/users/dteviot/followers","following_url":"https://api.github.com/users/dteviot/following{/other_user}","gists_url":"https://api.github.com/users/dteviot/gists{/gist_id}","starred_url":"https://api.github.com/users/dteviot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dteviot/subscriptions","organizations_url":"https://api.github.com/users/dteviot/orgs","repos_url":"https://api.github.com/users/dteviot/repos","events_url":"https://api.github.com/users/dteviot/events{/privacy}","received_events_url":"https://api.github.com/users/dteviot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dteviot/openmw","description":"OpenMW is an unofficial open source engine reimplementation of the game Morrowind.","fork":true,"url":"https://api.github.com/repos/dteviot/openmw","forks_url":"https://api.github.com/repos/dteviot/openmw/forks","keys_url":"https://api.github.com/repos/dteviot/openmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dteviot/openmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dteviot/openmw/teams","hooks_url":"https://api.github.com/repos/dteviot/openmw/hooks","issue_events_url":"https://api.github.com/repos/dteviot/openmw/issues/events{/number}","events_url":"https://api.github.com/repos/dteviot/openmw/events","assignees_url":"https://api.github.com/repos/dteviot/openmw/assignees{/user}","branches_url":"https://api.github.com/repos/dteviot/openmw/branches{/branch}","tags_url":"https://api.github.com/repos/dteviot/openmw/tags","blobs_url":"https://api.github.com/repos/dteviot/openmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dteviot/openmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dteviot/openmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/dteviot/openmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dteviot/openmw/statuses/{sha}","languages_url":"https://api.github.com/repos/dteviot/openmw/languages","stargazers_url":"https://api.github.com/repos/dteviot/openmw/stargazers","contributors_url":"https://api.github.com/repos/dteviot/openmw/contributors","subscribers_url":"https://api.github.com/repos/dteviot/openmw/subscribers","subscription_url":"https://api.github.com/repos/dteviot/openmw/subscription","commits_url":"https://api.github.com/repos/dteviot/openmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/dteviot/openmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/dteviot/openmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/dteviot/openmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/dteviot/openmw/contents/{+path}","compare_url":"https://api.github.com/repos/dteviot/openmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dteviot/openmw/merges","archive_url":"https://api.github.com/repos/dteviot/openmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dteviot/openmw/downloads","issues_url":"https://api.github.com/repos/dteviot/openmw/issues{/number}","pulls_url":"https://api.github.com/repos/dteviot/openmw/pulls{/number}","milestones_url":"https://api.github.com/repos/dteviot/openmw/milestones{/number}","notifications_url":"https://api.github.com/repos/dteviot/openmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dteviot/openmw/labels{/name}","releases_url":"https://api.github.com/repos/dteviot/openmw/releases{/id}","created_at":"2014-11-28T22:02:05Z","updated_at":"2015-05-03T20:24:28Z","pushed_at":"2015-08-13T09:23:51Z","git_url":"git://github.com/dteviot/openmw.git","ssh_url":"git@github.com:dteviot/openmw.git","clone_url":"https://github.com/dteviot/openmw.git","svn_url":"https://github.com/dteviot/openmw","homepage":"http://www.openmw.org/","size":47421,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenMW:master","ref":"master","sha":"3046795a9c1197ed7fc9766fe78de84e37da1672","user":{"login":"OpenMW","id":6727417,"avatar_url":"https://avatars.githubusercontent.com/u/6727417?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenMW","html_url":"https://github.com/OpenMW","followers_url":"https://api.github.com/users/OpenMW/followers","following_url":"https://api.github.com/users/OpenMW/following{/other_user}","gists_url":"https://api.github.com/users/OpenMW/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMW/subscriptions","organizations_url":"https://api.github.com/users/OpenMW/orgs","repos_url":"https://api.github.com/users/OpenMW/repos","events_url":"https://api.github.com/users/OpenMW/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMW/received_events","type":"Organization","site_admin":false},"repo":{"id":285722,"name":"openmw","full_name":"OpenMW/openmw","owner":{"login":"OpenMW","id":6727417,"avatar_url":"https://avatars.githubusercontent.com/u/6727417?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenMW","html_url":"https://github.com/OpenMW","followers_url":"https://api.github.com/users/OpenMW/followers","following_url":"https://api.github.com/users/OpenMW/following{/other_user}","gists_url":"https://api.github.com/users/OpenMW/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMW/subscriptions","organizations_url":"https://api.github.com/users/OpenMW/orgs","repos_url":"https://api.github.com/users/OpenMW/repos","events_url":"https://api.github.com/users/OpenMW/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMW/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenMW/openmw","description":"OpenMW is an unofficial open source engine reimplementation of the game Morrowind.","fork":false,"url":"https://api.github.com/repos/OpenMW/openmw","forks_url":"https://api.github.com/repos/OpenMW/openmw/forks","keys_url":"https://api.github.com/repos/OpenMW/openmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenMW/openmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenMW/openmw/teams","hooks_url":"https://api.github.com/repos/OpenMW/openmw/hooks","issue_events_url":"https://api.github.com/repos/OpenMW/openmw/issues/events{/number}","events_url":"https://api.github.com/repos/OpenMW/openmw/events","assignees_url":"https://api.github.com/repos/OpenMW/openmw/assignees{/user}","branches_url":"https://api.github.com/repos/OpenMW/openmw/branches{/branch}","tags_url":"https://api.github.com/repos/OpenMW/openmw/tags","blobs_url":"https://api.github.com/repos/OpenMW/openmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenMW/openmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenMW/openmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenMW/openmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenMW/openmw/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenMW/openmw/languages","stargazers_url":"https://api.github.com/repos/OpenMW/openmw/stargazers","contributors_url":"https://api.github.com/repos/OpenMW/openmw/contributors","subscribers_url":"https://api.github.com/repos/OpenMW/openmw/subscribers","subscription_url":"https://api.github.com/repos/OpenMW/openmw/subscription","commits_url":"https://api.github.com/repos/OpenMW/openmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenMW/openmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenMW/openmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenMW/openmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenMW/openmw/contents/{+path}","compare_url":"https://api.github.com/repos/OpenMW/openmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenMW/openmw/merges","archive_url":"https://api.github.com/repos/OpenMW/openmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenMW/openmw/downloads","issues_url":"https://api.github.com/repos/OpenMW/openmw/issues{/number}","pulls_url":"https://api.github.com/repos/OpenMW/openmw/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenMW/openmw/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenMW/openmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenMW/openmw/labels{/name}","releases_url":"https://api.github.com/repos/OpenMW/openmw/releases{/id}","created_at":"2009-08-23T14:46:21Z","updated_at":"2015-08-13T16:51:58Z","pushed_at":"2015-08-14T08:13:59Z","git_url":"git://github.com/OpenMW/openmw.git","ssh_url":"git@github.com:OpenMW/openmw.git","clone_url":"https://github.com/OpenMW/openmw.git","svn_url":"https://github.com/OpenMW/openmw","homepage":"http://www.openmw.org/","size":60333,"stargazers_count":697,"watchers_count":697,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":374,"mirror_url":null,"open_issues_count":8,"forks":374,"open_issues":8,"watchers":697,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/713"},"html":{"href":"https://github.com/OpenMW/openmw/pull/713"},"issue":{"href":"https://api.github.com/repos/OpenMW/openmw/issues/713"},"comments":{"href":"https://api.github.com/repos/OpenMW/openmw/issues/713/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/713/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/713/commits"},"statuses":{"href":"https://api.github.com/repos/OpenMW/openmw/statuses/e42a2478dcae9445d72c48384658c682acc11f42"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"zinnschlag","id":287696,"avatar_url":"https://avatars.githubusercontent.com/u/287696?v=3","gravatar_id":"","url":"https://api.github.com/users/zinnschlag","html_url":"https://github.com/zinnschlag","followers_url":"https://api.github.com/users/zinnschlag/followers","following_url":"https://api.github.com/users/zinnschlag/following{/other_user}","gists_url":"https://api.github.com/users/zinnschlag/gists{/gist_id}","starred_url":"https://api.github.com/users/zinnschlag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zinnschlag/subscriptions","organizations_url":"https://api.github.com/users/zinnschlag/orgs","repos_url":"https://api.github.com/users/zinnschlag/repos","events_url":"https://api.github.com/users/zinnschlag/events{/privacy}","received_events_url":"https://api.github.com/users/zinnschlag/received_events","type":"User","site_admin":false},"comments":3,"review_comments":1,"commits":1,"additions":37,"deletions":43,"changed_files":1}}