{"action":"created","issue":{"url":"https://api.github.com/repos/woothemes/woocommerce/issues/7992","labels_url":"https://api.github.com/repos/woothemes/woocommerce/issues/7992/labels{/name}","comments_url":"https://api.github.com/repos/woothemes/woocommerce/issues/7992/comments","events_url":"https://api.github.com/repos/woothemes/woocommerce/issues/7992/events","html_url":"https://github.com/woothemes/woocommerce/issues/7992","id":69691692,"number":7992,"title":"Allow duplicate SKUs when subscriptions come into play","user":{"login":"majemedia","id":9761464,"avatar_url":"https://avatars.githubusercontent.com/u/9761464?v=3","gravatar_id":"","url":"https://api.github.com/users/majemedia","html_url":"https://github.com/majemedia","followers_url":"https://api.github.com/users/majemedia/followers","following_url":"https://api.github.com/users/majemedia/following{/other_user}","gists_url":"https://api.github.com/users/majemedia/gists{/gist_id}","starred_url":"https://api.github.com/users/majemedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majemedia/subscriptions","organizations_url":"https://api.github.com/users/majemedia/orgs","repos_url":"https://api.github.com/users/majemedia/repos","events_url":"https://api.github.com/users/majemedia/events{/privacy}","received_events_url":"https://api.github.com/users/majemedia/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-20T22:03:00Z","updated_at":"2015-04-23T15:36:04Z","closed_at":"2015-04-23T15:36:04Z","body":"Because simple/variable and subscription based products can't be combined into one product there could potentially be a need to have duplicate SKUs across those two.\r\n\r\n### Example:\r\nA company selling a packaged food product wants to be able sell a one-off purchase of a product and also a subscription to that product.\r\n\r\nUsing the current rules in place the requirement that each SKU be unique between the subscription product and the simple/variable product.\r\n\r\nI understand that in #5712 the decision was made to enforce unique skus across the entire platform. This could be a potential reason to allow for a setting to let WooCommerce in general and even WooCommerce + WooCommerce Subscriptions be even more flexible."},"comment":{"url":"https://api.github.com/repos/woothemes/woocommerce/issues/comments/95627171","html_url":"https://github.com/woothemes/woocommerce/issues/7992#issuecomment-95627171","issue_url":"https://api.github.com/repos/woothemes/woocommerce/issues/7992","id":95627171,"user":{"login":"mikejolley","id":90977,"avatar_url":"https://avatars.githubusercontent.com/u/90977?v=3","gravatar_id":"","url":"https://api.github.com/users/mikejolley","html_url":"https://github.com/mikejolley","followers_url":"https://api.github.com/users/mikejolley/followers","following_url":"https://api.github.com/users/mikejolley/following{/other_user}","gists_url":"https://api.github.com/users/mikejolley/gists{/gist_id}","starred_url":"https://api.github.com/users/mikejolley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikejolley/subscriptions","organizations_url":"https://api.github.com/users/mikejolley/orgs","repos_url":"https://api.github.com/users/mikejolley/repos","events_url":"https://api.github.com/users/mikejolley/events{/privacy}","received_events_url":"https://api.github.com/users/mikejolley/received_events","type":"User","site_admin":false},"created_at":"2015-04-23T15:36:04Z","updated_at":"2015-04-23T15:36:04Z","body":"It was actually decided since day 1, but #5712 was a bug. I agree with this comment: https://github.com/woothemes/woocommerce/issues/5712#issuecomment-46751657\r\n\r\nSKUs need to be unique; making them not so could have consequences, such as no longer being able to determine product ID from SKU. \r\n\r\nI believe you can filter this to prevent the check https://github.com/woothemes/woocommerce/blob/5a765aa4ef24e5706c23af9c867e02ce61dfb952/includes/wc-product-functions.php#L536 but I don't feel we should support in core. You could log this on ideas.woothemes.com if you wanted and if many store owners need it, we can reconsider."}}