{"action":"created","issue":{"url":"https://api.github.com/repos/Samsung/GearVRf/issues/18","labels_url":"https://api.github.com/repos/Samsung/GearVRf/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/Samsung/GearVRf/issues/18/comments","events_url":"https://api.github.com/repos/Samsung/GearVRf/issues/18/events","html_url":"https://github.com/Samsung/GearVRf/pull/18","id":69114461,"number":18,"title":"Support for loading the full hierarchy in a model in case it exists","user":{"login":"soumyajitdeb","id":11627880,"avatar_url":"https://avatars.githubusercontent.com/u/11627880?v=3","gravatar_id":"","url":"https://api.github.com/users/soumyajitdeb","html_url":"https://github.com/soumyajitdeb","followers_url":"https://api.github.com/users/soumyajitdeb/followers","following_url":"https://api.github.com/users/soumyajitdeb/following{/other_user}","gists_url":"https://api.github.com/users/soumyajitdeb/gists{/gist_id}","starred_url":"https://api.github.com/users/soumyajitdeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soumyajitdeb/subscriptions","organizations_url":"https://api.github.com/users/soumyajitdeb/orgs","repos_url":"https://api.github.com/users/soumyajitdeb/repos","events_url":"https://api.github.com/users/soumyajitdeb/events{/privacy}","received_events_url":"https://api.github.com/users/soumyajitdeb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-04-17T10:41:47Z","updated_at":"2015-04-29T16:10:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Samsung/GearVRf/pulls/18","html_url":"https://github.com/Samsung/GearVRf/pull/18","diff_url":"https://github.com/Samsung/GearVRf/pull/18.diff","patch_url":"https://github.com/Samsung/GearVRf/pull/18.patch"},"body":"This patch supports loading the complete hierarchy if present in a model. The major changes that have  taken place are in GVRf/Framework/src/org/gearvrf/GVRAssimpImporter.java and GVRf/Framework/jni/engine/importer/assimp_importer.cpp to allow loading of the entire hierarchy via recursion.\r\n\r\nWe've also added a sample app that loads the public domain \"Crytek Sponza\" model that is available from the Crytek website. The sample app is located in GVRf/Sample/gvrmodelloader. \r\n\r\nPlease let us know if this complies with your coding standards and requirements. Since this is our first contribution, please do pardon us for any inadvertent errors. We welcome constructive criticism. Once this one is checked in, we'll start creating pull requests for other features that we have ready.\r\n\r\nThanks\r\nSoumyajit & Lokesh"},"comment":{"url":"https://api.github.com/repos/Samsung/GearVRf/issues/comments/97483676","html_url":"https://github.com/Samsung/GearVRf/pull/18#issuecomment-97483676","issue_url":"https://api.github.com/repos/Samsung/GearVRf/issues/18","id":97483676,"user":{"login":"PatrickTW","id":11281660,"avatar_url":"https://avatars.githubusercontent.com/u/11281660?v=3","gravatar_id":"","url":"https://api.github.com/users/PatrickTW","html_url":"https://github.com/PatrickTW","followers_url":"https://api.github.com/users/PatrickTW/followers","following_url":"https://api.github.com/users/PatrickTW/following{/other_user}","gists_url":"https://api.github.com/users/PatrickTW/gists{/gist_id}","starred_url":"https://api.github.com/users/PatrickTW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatrickTW/subscriptions","organizations_url":"https://api.github.com/users/PatrickTW/orgs","repos_url":"https://api.github.com/users/PatrickTW/repos","events_url":"https://api.github.com/users/PatrickTW/events{/privacy}","received_events_url":"https://api.github.com/users/PatrickTW/received_events","type":"User","site_admin":false},"created_at":"2015-04-29T16:10:57Z","updated_at":"2015-04-29T16:10:57Z","body":"Lokesh,\r\n\r\nI was asked to review comments for code submittals.\r\nYours are in the A++ category.  The things I mentioned are well within the range of normal communication.\r\nAdhering to those guidelines makes good writing even better.\r\n\r\n\r\nPatrick\r\n\r\nFrom: Lokesh Chandra Basu [mailto:notifications@github.com]\r\nSent: Wednesday, April 29, 2015 1:49 AM\r\nTo: Samsung/GearVRf\r\nCc: Patrick Townsend-Wells\r\nSubject: Re: [GearVRf] Support for loading the full hierarchy in a model in case it exists (#18)\r\n\r\n\r\nThanks @PatrickTW<https://github.com/PatrickTW> for your valuable suggestions . I will be more careful in the future, about the comments. :-)\r\n\r\n—\r\nReply to this email directly or view it on GitHub<https://github.com/Samsung/GearVRf/pull/18#issuecomment-97355121>.\r\n"}}