{"action":"created","comment":{"url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/pulls/comments/28141392","id":28141392,"diff_hunk":"@@ -257,7 +260,7 @@ private JasperPrint createJasperPrint(final String key, final Map parameters, Co\n                 dataSource = Collections.singletonList(StringUtils.EMPTY);\n             }\n \n-            return JasperFillManager.fillReport(report, parameters, new JRBeanCollectionDataSource(dataSource));\n+            return JasperFillManager.fillReport(report, parameters, new TransactionalDataSource(dataSource));","path":"fenixedu-ist-reports/src/main/java/pt/ist/fenix/jasper/reports/JasperReportPrinter.java","position":29,"original_position":29,"commit_id":"2a5f7ca71a73327e45de5dc6a1eb0e3bae694d86","original_commit_id":"2a5f7ca71a73327e45de5dc6a1eb0e3bae694d86","user":{"login":"pedrosan7os","id":1579125,"avatar_url":"https://avatars.githubusercontent.com/u/1579125?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrosan7os","html_url":"https://github.com/pedrosan7os","followers_url":"https://api.github.com/users/pedrosan7os/followers","following_url":"https://api.github.com/users/pedrosan7os/following{/other_user}","gists_url":"https://api.github.com/users/pedrosan7os/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrosan7os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrosan7os/subscriptions","organizations_url":"https://api.github.com/users/pedrosan7os/orgs","repos_url":"https://api.github.com/users/pedrosan7os/repos","events_url":"https://api.github.com/users/pedrosan7os/events{/privacy}","received_events_url":"https://api.github.com/users/pedrosan7os/received_events","type":"User","site_admin":false},"body":"Why the new datasource type? The general practice of processing all the necessary information prior to the source construction is not applicable here? Seems safer than handling FF transaction inside the jasper engine.","created_at":"2015-04-10T12:48:51Z","updated_at":"2015-04-10T12:48:51Z","html_url":"https://github.com/ist-dsi/fenixedu-ist/pull/19#discussion_r28141392","pull_request_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/ist-dsi/fenixedu-ist/pulls/comments/28141392"},"html":{"href":"https://github.com/ist-dsi/fenixedu-ist/pull/19#discussion_r28141392"},"pull_request":{"href":"https://api.github.com/repos/ist-dsi/fenixedu-ist/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/pulls/19","id":32947883,"html_url":"https://github.com/ist-dsi/fenixedu-ist/pull/19","diff_url":"https://github.com/ist-dsi/fenixedu-ist/pull/19.diff","patch_url":"https://github.com/ist-dsi/fenixedu-ist/pull/19.patch","issue_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/issues/19","number":19,"state":"open","locked":false,"title":"AnnualTeacherCreditsDocuments is now a jasper report. FIST-83 #resolve","user":{"login":"SusanaFernandes","id":3941560,"avatar_url":"https://avatars.githubusercontent.com/u/3941560?v=3","gravatar_id":"","url":"https://api.github.com/users/SusanaFernandes","html_url":"https://github.com/SusanaFernandes","followers_url":"https://api.github.com/users/SusanaFernandes/followers","following_url":"https://api.github.com/users/SusanaFernandes/following{/other_user}","gists_url":"https://api.github.com/users/SusanaFernandes/gists{/gist_id}","starred_url":"https://api.github.com/users/SusanaFernandes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SusanaFernandes/subscriptions","organizations_url":"https://api.github.com/users/SusanaFernandes/orgs","repos_url":"https://api.github.com/users/SusanaFernandes/repos","events_url":"https://api.github.com/users/SusanaFernandes/events{/privacy}","received_events_url":"https://api.github.com/users/SusanaFernandes/received_events","type":"User","site_admin":false},"body":"AnnualTeacherCreditsDocuments is now a jasper report. Every time credits are calculated a new AnnualTeacherCreditsDocuments is created and they must be assesible to creditsManager group. Allow to download teacher credits information.","created_at":"2015-04-09T11:42:32Z","updated_at":"2015-04-10T12:48:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e89ec5953f9ed02d6dc5a4113186cc2cd68cf342","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/pulls/19/commits","review_comments_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/pulls/19/comments","review_comment_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/issues/19/comments","statuses_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/statuses/2a5f7ca71a73327e45de5dc6a1eb0e3bae694d86","head":{"label":"SusanaFernandes:teacherCredits/FIST-83","ref":"teacherCredits/FIST-83","sha":"2a5f7ca71a73327e45de5dc6a1eb0e3bae694d86","user":{"login":"SusanaFernandes","id":3941560,"avatar_url":"https://avatars.githubusercontent.com/u/3941560?v=3","gravatar_id":"","url":"https://api.github.com/users/SusanaFernandes","html_url":"https://github.com/SusanaFernandes","followers_url":"https://api.github.com/users/SusanaFernandes/followers","following_url":"https://api.github.com/users/SusanaFernandes/following{/other_user}","gists_url":"https://api.github.com/users/SusanaFernandes/gists{/gist_id}","starred_url":"https://api.github.com/users/SusanaFernandes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SusanaFernandes/subscriptions","organizations_url":"https://api.github.com/users/SusanaFernandes/orgs","repos_url":"https://api.github.com/users/SusanaFernandes/repos","events_url":"https://api.github.com/users/SusanaFernandes/events{/privacy}","received_events_url":"https://api.github.com/users/SusanaFernandes/received_events","type":"User","site_admin":false},"repo":{"id":32737684,"name":"fenixedu-ist","full_name":"SusanaFernandes/fenixedu-ist","owner":{"login":"SusanaFernandes","id":3941560,"avatar_url":"https://avatars.githubusercontent.com/u/3941560?v=3","gravatar_id":"","url":"https://api.github.com/users/SusanaFernandes","html_url":"https://github.com/SusanaFernandes","followers_url":"https://api.github.com/users/SusanaFernandes/followers","following_url":"https://api.github.com/users/SusanaFernandes/following{/other_user}","gists_url":"https://api.github.com/users/SusanaFernandes/gists{/gist_id}","starred_url":"https://api.github.com/users/SusanaFernandes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SusanaFernandes/subscriptions","organizations_url":"https://api.github.com/users/SusanaFernandes/orgs","repos_url":"https://api.github.com/users/SusanaFernandes/repos","events_url":"https://api.github.com/users/SusanaFernandes/events{/privacy}","received_events_url":"https://api.github.com/users/SusanaFernandes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SusanaFernandes/fenixedu-ist","description":"FenixEdu IST Contribution Modules","fork":true,"url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist","forks_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/forks","keys_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/teams","hooks_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/hooks","issue_events_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/issues/events{/number}","events_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/events","assignees_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/assignees{/user}","branches_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/branches{/branch}","tags_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/tags","blobs_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/git/refs{/sha}","trees_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/statuses/{sha}","languages_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/languages","stargazers_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/stargazers","contributors_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/contributors","subscribers_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/subscribers","subscription_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/subscription","commits_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/commits{/sha}","git_commits_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/git/commits{/sha}","comments_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/comments{/number}","issue_comment_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/issues/comments{/number}","contents_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/contents/{+path}","compare_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/merges","archive_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/downloads","issues_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/issues{/number}","pulls_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/pulls{/number}","milestones_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/milestones{/number}","notifications_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/labels{/name}","releases_url":"https://api.github.com/repos/SusanaFernandes/fenixedu-ist/releases{/id}","created_at":"2015-03-23T14:39:09Z","updated_at":"2015-03-23T14:39:14Z","pushed_at":"2015-04-09T16:26:01Z","git_url":"git://github.com/SusanaFernandes/fenixedu-ist.git","ssh_url":"git@github.com:SusanaFernandes/fenixedu-ist.git","clone_url":"https://github.com/SusanaFernandes/fenixedu-ist.git","svn_url":"https://github.com/SusanaFernandes/fenixedu-ist","homepage":null,"size":23481,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ist-dsi:master","ref":"master","sha":"faa65360ccb75dfd025060c9e944e435c51299f7","user":{"login":"ist-dsi","id":3024882,"avatar_url":"https://avatars.githubusercontent.com/u/3024882?v=3","gravatar_id":"","url":"https://api.github.com/users/ist-dsi","html_url":"https://github.com/ist-dsi","followers_url":"https://api.github.com/users/ist-dsi/followers","following_url":"https://api.github.com/users/ist-dsi/following{/other_user}","gists_url":"https://api.github.com/users/ist-dsi/gists{/gist_id}","starred_url":"https://api.github.com/users/ist-dsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ist-dsi/subscriptions","organizations_url":"https://api.github.com/users/ist-dsi/orgs","repos_url":"https://api.github.com/users/ist-dsi/repos","events_url":"https://api.github.com/users/ist-dsi/events{/privacy}","received_events_url":"https://api.github.com/users/ist-dsi/received_events","type":"Organization","site_admin":false},"repo":{"id":32727612,"name":"fenixedu-ist","full_name":"ist-dsi/fenixedu-ist","owner":{"login":"ist-dsi","id":3024882,"avatar_url":"https://avatars.githubusercontent.com/u/3024882?v=3","gravatar_id":"","url":"https://api.github.com/users/ist-dsi","html_url":"https://github.com/ist-dsi","followers_url":"https://api.github.com/users/ist-dsi/followers","following_url":"https://api.github.com/users/ist-dsi/following{/other_user}","gists_url":"https://api.github.com/users/ist-dsi/gists{/gist_id}","starred_url":"https://api.github.com/users/ist-dsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ist-dsi/subscriptions","organizations_url":"https://api.github.com/users/ist-dsi/orgs","repos_url":"https://api.github.com/users/ist-dsi/repos","events_url":"https://api.github.com/users/ist-dsi/events{/privacy}","received_events_url":"https://api.github.com/users/ist-dsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ist-dsi/fenixedu-ist","description":"FenixEdu IST Contribution Modules","fork":false,"url":"https://api.github.com/repos/ist-dsi/fenixedu-ist","forks_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/forks","keys_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/teams","hooks_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/hooks","issue_events_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/issues/events{/number}","events_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/events","assignees_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/assignees{/user}","branches_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/branches{/branch}","tags_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/tags","blobs_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/git/refs{/sha}","trees_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/statuses/{sha}","languages_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/languages","stargazers_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/stargazers","contributors_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/contributors","subscribers_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/subscribers","subscription_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/subscription","commits_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/commits{/sha}","git_commits_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/git/commits{/sha}","comments_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/comments{/number}","issue_comment_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/issues/comments{/number}","contents_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/contents/{+path}","compare_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/merges","archive_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/downloads","issues_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/issues{/number}","pulls_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/pulls{/number}","milestones_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/milestones{/number}","notifications_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/labels{/name}","releases_url":"https://api.github.com/repos/ist-dsi/fenixedu-ist/releases{/id}","created_at":"2015-03-23T11:16:51Z","updated_at":"2015-04-10T09:53:47Z","pushed_at":"2015-04-10T09:53:47Z","git_url":"git://github.com/ist-dsi/fenixedu-ist.git","ssh_url":"git@github.com:ist-dsi/fenixedu-ist.git","clone_url":"https://github.com/ist-dsi/fenixedu-ist.git","svn_url":"https://github.com/ist-dsi/fenixedu-ist","homepage":null,"size":24045,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ist-dsi/fenixedu-ist/pulls/19"},"html":{"href":"https://github.com/ist-dsi/fenixedu-ist/pull/19"},"issue":{"href":"https://api.github.com/repos/ist-dsi/fenixedu-ist/issues/19"},"comments":{"href":"https://api.github.com/repos/ist-dsi/fenixedu-ist/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/ist-dsi/fenixedu-ist/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/ist-dsi/fenixedu-ist/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ist-dsi/fenixedu-ist/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/ist-dsi/fenixedu-ist/statuses/2a5f7ca71a73327e45de5dc6a1eb0e3bae694d86"}}}}