{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/docs/pulls/comments/39133758","id":39133758,"diff_hunk":"@@ -428,6 +428,20 @@ The JSON version of a target group has the following format:\n }\n ```\n \n+Also, the files must contain an array of target groups, not a standalone one. Here is","path":"content/docs/operating/configuration.md","position":4,"original_position":4,"commit_id":"41bdc2278a8bb387eff65f17288f4761aaf037b7","original_commit_id":"41bdc2278a8bb387eff65f17288f4761aaf037b7","user":{"login":"brian-brazil","id":7115638,"avatar_url":"https://avatars.githubusercontent.com/u/7115638?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-brazil","html_url":"https://github.com/brian-brazil","followers_url":"https://api.github.com/users/brian-brazil/followers","following_url":"https://api.github.com/users/brian-brazil/following{/other_user}","gists_url":"https://api.github.com/users/brian-brazil/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-brazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-brazil/subscriptions","organizations_url":"https://api.github.com/users/brian-brazil/orgs","repos_url":"https://api.github.com/users/brian-brazil/repos","events_url":"https://api.github.com/users/brian-brazil/events{/privacy}","received_events_url":"https://api.github.com/users/brian-brazil/received_events","type":"User","site_admin":false},"body":"One example with a list would probably be clearer, see #175 ","created_at":"2015-09-10T07:56:53Z","updated_at":"2015-09-10T07:56:53Z","html_url":"https://github.com/prometheus/docs/pull/210#discussion_r39133758","pull_request_url":"https://api.github.com/repos/prometheus/docs/pulls/210","_links":{"self":{"href":"https://api.github.com/repos/prometheus/docs/pulls/comments/39133758"},"html":{"href":"https://github.com/prometheus/docs/pull/210#discussion_r39133758"},"pull_request":{"href":"https://api.github.com/repos/prometheus/docs/pulls/210"}}},"pull_request":{"url":"https://api.github.com/repos/prometheus/docs/pulls/210","id":44624686,"html_url":"https://github.com/prometheus/docs/pull/210","diff_url":"https://github.com/prometheus/docs/pull/210.diff","patch_url":"https://github.com/prometheus/docs/pull/210.patch","issue_url":"https://api.github.com/repos/prometheus/docs/issues/210","number":210,"state":"open","locked":false,"title":"Better explain file_sd's expected format","user":{"login":"evanphx","id":7,"avatar_url":"https://avatars.githubusercontent.com/u/7?v=3","gravatar_id":"","url":"https://api.github.com/users/evanphx","html_url":"https://github.com/evanphx","followers_url":"https://api.github.com/users/evanphx/followers","following_url":"https://api.github.com/users/evanphx/following{/other_user}","gists_url":"https://api.github.com/users/evanphx/gists{/gist_id}","starred_url":"https://api.github.com/users/evanphx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanphx/subscriptions","organizations_url":"https://api.github.com/users/evanphx/orgs","repos_url":"https://api.github.com/users/evanphx/repos","events_url":"https://api.github.com/users/evanphx/events{/privacy}","received_events_url":"https://api.github.com/users/evanphx/received_events","type":"User","site_admin":false},"body":"Indicate in the docs that the files need to contain an array of target groups, not a standalone one. This was only discoverable by looking at the output of prometheus saying the file was bad.\r\n\r\nI know the docs indicate \"zero or more\" which implies it is an array, but that detail is extremely easy to miss.","created_at":"2015-09-10T03:31:15Z","updated_at":"2015-09-10T07:56:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70d3ecf74916df5bfdf04bd0e598d763dab99dad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/docs/pulls/210/commits","review_comments_url":"https://api.github.com/repos/prometheus/docs/pulls/210/comments","review_comment_url":"https://api.github.com/repos/prometheus/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/docs/issues/210/comments","statuses_url":"https://api.github.com/repos/prometheus/docs/statuses/41bdc2278a8bb387eff65f17288f4761aaf037b7","head":{"label":"evanphx:patch-1","ref":"patch-1","sha":"41bdc2278a8bb387eff65f17288f4761aaf037b7","user":{"login":"evanphx","id":7,"avatar_url":"https://avatars.githubusercontent.com/u/7?v=3","gravatar_id":"","url":"https://api.github.com/users/evanphx","html_url":"https://github.com/evanphx","followers_url":"https://api.github.com/users/evanphx/followers","following_url":"https://api.github.com/users/evanphx/following{/other_user}","gists_url":"https://api.github.com/users/evanphx/gists{/gist_id}","starred_url":"https://api.github.com/users/evanphx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanphx/subscriptions","organizations_url":"https://api.github.com/users/evanphx/orgs","repos_url":"https://api.github.com/users/evanphx/repos","events_url":"https://api.github.com/users/evanphx/events{/privacy}","received_events_url":"https://api.github.com/users/evanphx/received_events","type":"User","site_admin":false},"repo":{"id":42219753,"name":"docs","full_name":"evanphx/docs","owner":{"login":"evanphx","id":7,"avatar_url":"https://avatars.githubusercontent.com/u/7?v=3","gravatar_id":"","url":"https://api.github.com/users/evanphx","html_url":"https://github.com/evanphx","followers_url":"https://api.github.com/users/evanphx/followers","following_url":"https://api.github.com/users/evanphx/following{/other_user}","gists_url":"https://api.github.com/users/evanphx/gists{/gist_id}","starred_url":"https://api.github.com/users/evanphx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanphx/subscriptions","organizations_url":"https://api.github.com/users/evanphx/orgs","repos_url":"https://api.github.com/users/evanphx/repos","events_url":"https://api.github.com/users/evanphx/events{/privacy}","received_events_url":"https://api.github.com/users/evanphx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evanphx/docs","description":"Prometheus documentation: content and static site generator","fork":true,"url":"https://api.github.com/repos/evanphx/docs","forks_url":"https://api.github.com/repos/evanphx/docs/forks","keys_url":"https://api.github.com/repos/evanphx/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evanphx/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evanphx/docs/teams","hooks_url":"https://api.github.com/repos/evanphx/docs/hooks","issue_events_url":"https://api.github.com/repos/evanphx/docs/issues/events{/number}","events_url":"https://api.github.com/repos/evanphx/docs/events","assignees_url":"https://api.github.com/repos/evanphx/docs/assignees{/user}","branches_url":"https://api.github.com/repos/evanphx/docs/branches{/branch}","tags_url":"https://api.github.com/repos/evanphx/docs/tags","blobs_url":"https://api.github.com/repos/evanphx/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evanphx/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evanphx/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/evanphx/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evanphx/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/evanphx/docs/languages","stargazers_url":"https://api.github.com/repos/evanphx/docs/stargazers","contributors_url":"https://api.github.com/repos/evanphx/docs/contributors","subscribers_url":"https://api.github.com/repos/evanphx/docs/subscribers","subscription_url":"https://api.github.com/repos/evanphx/docs/subscription","commits_url":"https://api.github.com/repos/evanphx/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/evanphx/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/evanphx/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/evanphx/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/evanphx/docs/contents/{+path}","compare_url":"https://api.github.com/repos/evanphx/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evanphx/docs/merges","archive_url":"https://api.github.com/repos/evanphx/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evanphx/docs/downloads","issues_url":"https://api.github.com/repos/evanphx/docs/issues{/number}","pulls_url":"https://api.github.com/repos/evanphx/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/evanphx/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/evanphx/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evanphx/docs/labels{/name}","releases_url":"https://api.github.com/repos/evanphx/docs/releases{/id}","created_at":"2015-09-10T03:27:37Z","updated_at":"2015-09-10T03:27:38Z","pushed_at":"2015-09-10T03:31:07Z","git_url":"git://github.com/evanphx/docs.git","ssh_url":"git@github.com:evanphx/docs.git","clone_url":"https://github.com/evanphx/docs.git","svn_url":"https://github.com/evanphx/docs","homepage":"http://prometheus.io","size":3365,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"7c1203beae3e5771aace12174907e81d5de06fbd","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":28233924,"name":"docs","full_name":"prometheus/docs","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/docs","description":"Prometheus documentation: content and static site generator","fork":false,"url":"https://api.github.com/repos/prometheus/docs","forks_url":"https://api.github.com/repos/prometheus/docs/forks","keys_url":"https://api.github.com/repos/prometheus/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/docs/teams","hooks_url":"https://api.github.com/repos/prometheus/docs/hooks","issue_events_url":"https://api.github.com/repos/prometheus/docs/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/docs/events","assignees_url":"https://api.github.com/repos/prometheus/docs/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/docs/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/docs/tags","blobs_url":"https://api.github.com/repos/prometheus/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/docs/languages","stargazers_url":"https://api.github.com/repos/prometheus/docs/stargazers","contributors_url":"https://api.github.com/repos/prometheus/docs/contributors","subscribers_url":"https://api.github.com/repos/prometheus/docs/subscribers","subscription_url":"https://api.github.com/repos/prometheus/docs/subscription","commits_url":"https://api.github.com/repos/prometheus/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/docs/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/docs/merges","archive_url":"https://api.github.com/repos/prometheus/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/docs/downloads","issues_url":"https://api.github.com/repos/prometheus/docs/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/docs/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/docs/releases{/id}","created_at":"2014-12-19T15:06:35Z","updated_at":"2015-05-08T14:09:16Z","pushed_at":"2015-09-10T03:31:15Z","git_url":"git://github.com/prometheus/docs.git","ssh_url":"git@github.com:prometheus/docs.git","clone_url":"https://github.com/prometheus/docs.git","svn_url":"https://github.com/prometheus/docs","homepage":"http://prometheus.io","size":3365,"stargazers_count":6,"watchers_count":6,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":15,"forks":25,"open_issues":15,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/docs/pulls/210"},"html":{"href":"https://github.com/prometheus/docs/pull/210"},"issue":{"href":"https://api.github.com/repos/prometheus/docs/issues/210"},"comments":{"href":"https://api.github.com/repos/prometheus/docs/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/docs/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/docs/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/docs/statuses/41bdc2278a8bb387eff65f17288f4761aaf037b7"}}}}