{"action":"created","comment":{"url":"https://api.github.com/repos/php-http/adapter/pulls/comments/37752008","id":37752008,"diff_hunk":"@@ -0,0 +1,13 @@\n+<?php\n+\n+namespace Http\\Client;\n+\n+/**\n+ * Interface for both HTTP Client type\n+ *\n+ * @author Márk Sági-Kazár mark.sagikazar@gmail.com>\n+ */\n+interface Client extends PsrHttpClient, HttpClient","path":"src/Client.php","position":10,"original_position":10,"commit_id":"688f737f0544a37c3d6f95de561340f9c92eb8c2","original_commit_id":"688f737f0544a37c3d6f95de561340f9c92eb8c2","user":{"login":"hannesvdvreken","id":1410358,"avatar_url":"https://avatars.githubusercontent.com/u/1410358?v=3","gravatar_id":"","url":"https://api.github.com/users/hannesvdvreken","html_url":"https://github.com/hannesvdvreken","followers_url":"https://api.github.com/users/hannesvdvreken/followers","following_url":"https://api.github.com/users/hannesvdvreken/following{/other_user}","gists_url":"https://api.github.com/users/hannesvdvreken/gists{/gist_id}","starred_url":"https://api.github.com/users/hannesvdvreken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannesvdvreken/subscriptions","organizations_url":"https://api.github.com/users/hannesvdvreken/orgs","repos_url":"https://api.github.com/users/hannesvdvreken/repos","events_url":"https://api.github.com/users/hannesvdvreken/events{/privacy}","received_events_url":"https://api.github.com/users/hannesvdvreken/received_events","type":"User","site_admin":false},"body":"> the documentation should state clearly that you should specify PsrHttpClient or HttpClient rather than the combined interface unless you really need both.\r\n\r\nAgreed","created_at":"2015-08-24T13:45:35Z","updated_at":"2015-08-24T13:45:35Z","html_url":"https://github.com/php-http/adapter/pull/40#discussion_r37752008","pull_request_url":"https://api.github.com/repos/php-http/adapter/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/php-http/adapter/pulls/comments/37752008"},"html":{"href":"https://github.com/php-http/adapter/pull/40#discussion_r37752008"},"pull_request":{"href":"https://api.github.com/repos/php-http/adapter/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/php-http/adapter/pulls/40","id":43128686,"html_url":"https://github.com/php-http/adapter/pull/40","diff_url":"https://github.com/php-http/adapter/pull/40.diff","patch_url":"https://github.com/php-http/adapter/pull/40.patch","issue_url":"https://api.github.com/repos/php-http/adapter/issues/40","number":40,"state":"open","locked":false,"title":"Terminology","user":{"login":"sagikazarmark","id":1226384,"avatar_url":"https://avatars.githubusercontent.com/u/1226384?v=3","gravatar_id":"","url":"https://api.github.com/users/sagikazarmark","html_url":"https://github.com/sagikazarmark","followers_url":"https://api.github.com/users/sagikazarmark/followers","following_url":"https://api.github.com/users/sagikazarmark/following{/other_user}","gists_url":"https://api.github.com/users/sagikazarmark/gists{/gist_id}","starred_url":"https://api.github.com/users/sagikazarmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagikazarmark/subscriptions","organizations_url":"https://api.github.com/users/sagikazarmark/orgs","repos_url":"https://api.github.com/users/sagikazarmark/repos","events_url":"https://api.github.com/users/sagikazarmark/events{/privacy}","received_events_url":"https://api.github.com/users/sagikazarmark/received_events","type":"User","site_admin":false},"body":"This PR tries to solve #38\r\n\r\nSome points to discuss:\r\n\r\n- [ ] Exceptions in the package: concrete implementations? Exception naming?\r\n- [ ] Interface names: PsrClient, HttpClient, Client? \r\n\r\nTo do before merging:\r\n\r\n- [ ] Squash commits!!!!!!!","created_at":"2015-08-23T21:14:09Z","updated_at":"2015-08-24T13:45:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f5cc460e4e22cf68a3b4ee8b8b213f53474a3e0","assignee":{"login":"sagikazarmark","id":1226384,"avatar_url":"https://avatars.githubusercontent.com/u/1226384?v=3","gravatar_id":"","url":"https://api.github.com/users/sagikazarmark","html_url":"https://github.com/sagikazarmark","followers_url":"https://api.github.com/users/sagikazarmark/followers","following_url":"https://api.github.com/users/sagikazarmark/following{/other_user}","gists_url":"https://api.github.com/users/sagikazarmark/gists{/gist_id}","starred_url":"https://api.github.com/users/sagikazarmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagikazarmark/subscriptions","organizations_url":"https://api.github.com/users/sagikazarmark/orgs","repos_url":"https://api.github.com/users/sagikazarmark/repos","events_url":"https://api.github.com/users/sagikazarmark/events{/privacy}","received_events_url":"https://api.github.com/users/sagikazarmark/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/php-http/adapter/pulls/40/commits","review_comments_url":"https://api.github.com/repos/php-http/adapter/pulls/40/comments","review_comment_url":"https://api.github.com/repos/php-http/adapter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php-http/adapter/issues/40/comments","statuses_url":"https://api.github.com/repos/php-http/adapter/statuses/688f737f0544a37c3d6f95de561340f9c92eb8c2","head":{"label":"php-http:terminology","ref":"terminology","sha":"688f737f0544a37c3d6f95de561340f9c92eb8c2","user":{"login":"php-http","id":12104859,"avatar_url":"https://avatars.githubusercontent.com/u/12104859?v=3","gravatar_id":"","url":"https://api.github.com/users/php-http","html_url":"https://github.com/php-http","followers_url":"https://api.github.com/users/php-http/followers","following_url":"https://api.github.com/users/php-http/following{/other_user}","gists_url":"https://api.github.com/users/php-http/gists{/gist_id}","starred_url":"https://api.github.com/users/php-http/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-http/subscriptions","organizations_url":"https://api.github.com/users/php-http/orgs","repos_url":"https://api.github.com/users/php-http/repos","events_url":"https://api.github.com/users/php-http/events{/privacy}","received_events_url":"https://api.github.com/users/php-http/received_events","type":"Organization","site_admin":false},"repo":{"id":34574921,"name":"adapter","full_name":"php-http/adapter","owner":{"login":"php-http","id":12104859,"avatar_url":"https://avatars.githubusercontent.com/u/12104859?v=3","gravatar_id":"","url":"https://api.github.com/users/php-http","html_url":"https://github.com/php-http","followers_url":"https://api.github.com/users/php-http/followers","following_url":"https://api.github.com/users/php-http/following{/other_user}","gists_url":"https://api.github.com/users/php-http/gists{/gist_id}","starred_url":"https://api.github.com/users/php-http/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-http/subscriptions","organizations_url":"https://api.github.com/users/php-http/orgs","repos_url":"https://api.github.com/users/php-http/repos","events_url":"https://api.github.com/users/php-http/events{/privacy}","received_events_url":"https://api.github.com/users/php-http/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php-http/adapter","description":"HTTP adapter contract","fork":false,"url":"https://api.github.com/repos/php-http/adapter","forks_url":"https://api.github.com/repos/php-http/adapter/forks","keys_url":"https://api.github.com/repos/php-http/adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php-http/adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php-http/adapter/teams","hooks_url":"https://api.github.com/repos/php-http/adapter/hooks","issue_events_url":"https://api.github.com/repos/php-http/adapter/issues/events{/number}","events_url":"https://api.github.com/repos/php-http/adapter/events","assignees_url":"https://api.github.com/repos/php-http/adapter/assignees{/user}","branches_url":"https://api.github.com/repos/php-http/adapter/branches{/branch}","tags_url":"https://api.github.com/repos/php-http/adapter/tags","blobs_url":"https://api.github.com/repos/php-http/adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php-http/adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php-http/adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/php-http/adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php-http/adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/php-http/adapter/languages","stargazers_url":"https://api.github.com/repos/php-http/adapter/stargazers","contributors_url":"https://api.github.com/repos/php-http/adapter/contributors","subscribers_url":"https://api.github.com/repos/php-http/adapter/subscribers","subscription_url":"https://api.github.com/repos/php-http/adapter/subscription","commits_url":"https://api.github.com/repos/php-http/adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/php-http/adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/php-http/adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/php-http/adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/php-http/adapter/contents/{+path}","compare_url":"https://api.github.com/repos/php-http/adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php-http/adapter/merges","archive_url":"https://api.github.com/repos/php-http/adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php-http/adapter/downloads","issues_url":"https://api.github.com/repos/php-http/adapter/issues{/number}","pulls_url":"https://api.github.com/repos/php-http/adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/php-http/adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/php-http/adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php-http/adapter/labels{/name}","releases_url":"https://api.github.com/repos/php-http/adapter/releases{/id}","created_at":"2015-04-25T15:56:07Z","updated_at":"2015-07-04T17:17:24Z","pushed_at":"2015-08-24T13:05:08Z","git_url":"git://github.com/php-http/adapter.git","ssh_url":"git@github.com:php-http/adapter.git","clone_url":"https://github.com/php-http/adapter.git","svn_url":"https://github.com/php-http/adapter","homepage":"http://php-http.org","size":385,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":8,"forks":2,"open_issues":8,"watchers":4,"default_branch":"master"}},"base":{"label":"php-http:master","ref":"master","sha":"6a9bdadec57ddaa09658e5be9784759be621fed0","user":{"login":"php-http","id":12104859,"avatar_url":"https://avatars.githubusercontent.com/u/12104859?v=3","gravatar_id":"","url":"https://api.github.com/users/php-http","html_url":"https://github.com/php-http","followers_url":"https://api.github.com/users/php-http/followers","following_url":"https://api.github.com/users/php-http/following{/other_user}","gists_url":"https://api.github.com/users/php-http/gists{/gist_id}","starred_url":"https://api.github.com/users/php-http/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-http/subscriptions","organizations_url":"https://api.github.com/users/php-http/orgs","repos_url":"https://api.github.com/users/php-http/repos","events_url":"https://api.github.com/users/php-http/events{/privacy}","received_events_url":"https://api.github.com/users/php-http/received_events","type":"Organization","site_admin":false},"repo":{"id":34574921,"name":"adapter","full_name":"php-http/adapter","owner":{"login":"php-http","id":12104859,"avatar_url":"https://avatars.githubusercontent.com/u/12104859?v=3","gravatar_id":"","url":"https://api.github.com/users/php-http","html_url":"https://github.com/php-http","followers_url":"https://api.github.com/users/php-http/followers","following_url":"https://api.github.com/users/php-http/following{/other_user}","gists_url":"https://api.github.com/users/php-http/gists{/gist_id}","starred_url":"https://api.github.com/users/php-http/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-http/subscriptions","organizations_url":"https://api.github.com/users/php-http/orgs","repos_url":"https://api.github.com/users/php-http/repos","events_url":"https://api.github.com/users/php-http/events{/privacy}","received_events_url":"https://api.github.com/users/php-http/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php-http/adapter","description":"HTTP adapter contract","fork":false,"url":"https://api.github.com/repos/php-http/adapter","forks_url":"https://api.github.com/repos/php-http/adapter/forks","keys_url":"https://api.github.com/repos/php-http/adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php-http/adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php-http/adapter/teams","hooks_url":"https://api.github.com/repos/php-http/adapter/hooks","issue_events_url":"https://api.github.com/repos/php-http/adapter/issues/events{/number}","events_url":"https://api.github.com/repos/php-http/adapter/events","assignees_url":"https://api.github.com/repos/php-http/adapter/assignees{/user}","branches_url":"https://api.github.com/repos/php-http/adapter/branches{/branch}","tags_url":"https://api.github.com/repos/php-http/adapter/tags","blobs_url":"https://api.github.com/repos/php-http/adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php-http/adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php-http/adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/php-http/adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php-http/adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/php-http/adapter/languages","stargazers_url":"https://api.github.com/repos/php-http/adapter/stargazers","contributors_url":"https://api.github.com/repos/php-http/adapter/contributors","subscribers_url":"https://api.github.com/repos/php-http/adapter/subscribers","subscription_url":"https://api.github.com/repos/php-http/adapter/subscription","commits_url":"https://api.github.com/repos/php-http/adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/php-http/adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/php-http/adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/php-http/adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/php-http/adapter/contents/{+path}","compare_url":"https://api.github.com/repos/php-http/adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php-http/adapter/merges","archive_url":"https://api.github.com/repos/php-http/adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php-http/adapter/downloads","issues_url":"https://api.github.com/repos/php-http/adapter/issues{/number}","pulls_url":"https://api.github.com/repos/php-http/adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/php-http/adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/php-http/adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php-http/adapter/labels{/name}","releases_url":"https://api.github.com/repos/php-http/adapter/releases{/id}","created_at":"2015-04-25T15:56:07Z","updated_at":"2015-07-04T17:17:24Z","pushed_at":"2015-08-24T13:05:08Z","git_url":"git://github.com/php-http/adapter.git","ssh_url":"git@github.com:php-http/adapter.git","clone_url":"https://github.com/php-http/adapter.git","svn_url":"https://github.com/php-http/adapter","homepage":"http://php-http.org","size":385,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":8,"forks":2,"open_issues":8,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php-http/adapter/pulls/40"},"html":{"href":"https://github.com/php-http/adapter/pull/40"},"issue":{"href":"https://api.github.com/repos/php-http/adapter/issues/40"},"comments":{"href":"https://api.github.com/repos/php-http/adapter/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/php-http/adapter/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/php-http/adapter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php-http/adapter/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/php-http/adapter/statuses/688f737f0544a37c3d6f95de561340f9c92eb8c2"}}}}