{"action":"opened","number":186,"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/186","id":28102446,"html_url":"https://github.com/OP-TEE/optee_os/pull/186","diff_url":"https://github.com/OP-TEE/optee_os/pull/186.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/186.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/186","number":186,"state":"open","locked":false,"title":"RSA decode in constant time","user":{"login":"pascal-brand-st-dev","id":6542303,"avatar_url":"https://avatars.githubusercontent.com/u/6542303?v=3","gravatar_id":"","url":"https://api.github.com/users/pascal-brand-st-dev","html_url":"https://github.com/pascal-brand-st-dev","followers_url":"https://api.github.com/users/pascal-brand-st-dev/followers","following_url":"https://api.github.com/users/pascal-brand-st-dev/following{/other_user}","gists_url":"https://api.github.com/users/pascal-brand-st-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pascal-brand-st-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascal-brand-st-dev/subscriptions","organizations_url":"https://api.github.com/users/pascal-brand-st-dev/orgs","repos_url":"https://api.github.com/users/pascal-brand-st-dev/repos","events_url":"https://api.github.com/users/pascal-brand-st-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pascal-brand-st-dev/received_events","type":"User","site_admin":false},"body":"This is a cherry-pick of the libtomcrypt pull-request\r\nhttps://github.com/libtom/libtomcrypt/pull/57\r\n\r\nAs pointed by Herve Sibert, verification has been kept non-constant time\r\nin this patch.\r\n\r\nExcerpt from original libtomcrypt pull-request:\r\n  as proposed in RFC 3447 only one error return code is used when there are\r\n  errors while decoding the pkcs#1 format.\r\n  also, all steps are executed and only the \"output\" is skipped if something\r\n  went wrong.\r\n\r\n  Sorry this could break backwards compatibility, since there's no more\r\n  BUFFER_OVERFLOW messaging.\r\n  Former error-handling code could also be affected because now there's only\r\n  OK as return code in cases where \"res\" is also set to '1'.\r\n\r\nSigned-off-by: Pascal Brand <pascal.brand@st.com>","created_at":"2015-01-27T11:49:24Z","updated_at":"2015-01-27T11:49:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/186/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/186/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/{number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/186/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/5a2a12dce2492fe01ea2ef2037b4592d835f4265","head":{"label":"pascal-brand-st-dev:rsa_fixtime","ref":"rsa_fixtime","sha":"5a2a12dce2492fe01ea2ef2037b4592d835f4265","user":{"login":"pascal-brand-st-dev","id":6542303,"avatar_url":"https://avatars.githubusercontent.com/u/6542303?v=3","gravatar_id":"","url":"https://api.github.com/users/pascal-brand-st-dev","html_url":"https://github.com/pascal-brand-st-dev","followers_url":"https://api.github.com/users/pascal-brand-st-dev/followers","following_url":"https://api.github.com/users/pascal-brand-st-dev/following{/other_user}","gists_url":"https://api.github.com/users/pascal-brand-st-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pascal-brand-st-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascal-brand-st-dev/subscriptions","organizations_url":"https://api.github.com/users/pascal-brand-st-dev/orgs","repos_url":"https://api.github.com/users/pascal-brand-st-dev/repos","events_url":"https://api.github.com/users/pascal-brand-st-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pascal-brand-st-dev/received_events","type":"User","site_admin":false},"repo":{"id":20769654,"name":"optee_os","full_name":"pascal-brand-st-dev/optee_os","owner":{"login":"pascal-brand-st-dev","id":6542303,"avatar_url":"https://avatars.githubusercontent.com/u/6542303?v=3","gravatar_id":"","url":"https://api.github.com/users/pascal-brand-st-dev","html_url":"https://github.com/pascal-brand-st-dev","followers_url":"https://api.github.com/users/pascal-brand-st-dev/followers","following_url":"https://api.github.com/users/pascal-brand-st-dev/following{/other_user}","gists_url":"https://api.github.com/users/pascal-brand-st-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pascal-brand-st-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascal-brand-st-dev/subscriptions","organizations_url":"https://api.github.com/users/pascal-brand-st-dev/orgs","repos_url":"https://api.github.com/users/pascal-brand-st-dev/repos","events_url":"https://api.github.com/users/pascal-brand-st-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pascal-brand-st-dev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pascal-brand-st-dev/optee_os","description":"Trusted side of the TEE","fork":true,"url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os","forks_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/forks","keys_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/teams","hooks_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/hooks","issue_events_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/events","assignees_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/tags","blobs_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/languages","stargazers_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/stargazers","contributors_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/contributors","subscribers_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/subscribers","subscription_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/subscription","commits_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/issues/comments/{number}","contents_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/merges","archive_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/downloads","issues_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/releases{/id}","created_at":"2014-06-12T14:09:53Z","updated_at":"2014-12-15T13:46:37Z","pushed_at":"2015-01-27T11:49:06Z","git_url":"git://github.com/pascal-brand-st-dev/optee_os.git","ssh_url":"git@github.com:pascal-brand-st-dev/optee_os.git","clone_url":"https://github.com/pascal-brand-st-dev/optee_os.git","svn_url":"https://github.com/pascal-brand-st-dev/optee_os","homepage":null,"size":2485,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"700c3514109e9d3076407d1007fcf5217f3cc93d","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":20193261,"name":"optee_os","full_name":"OP-TEE/optee_os","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_os","description":"Trusted side of the TEE","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_os","forks_url":"https://api.github.com/repos/OP-TEE/optee_os/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_os/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_os/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_os/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_os/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_os/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_os/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_os/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_os/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_os/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments/{number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_os/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_os/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_os/releases{/id}","created_at":"2014-05-26T17:18:57Z","updated_at":"2015-01-27T09:24:50Z","pushed_at":"2015-01-27T09:24:49Z","git_url":"git://github.com/OP-TEE/optee_os.git","ssh_url":"git@github.com:OP-TEE/optee_os.git","clone_url":"https://github.com/OP-TEE/optee_os.git","svn_url":"https://github.com/OP-TEE/optee_os","homepage":null,"size":6600,"stargazers_count":27,"watchers_count":27,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":10,"forks":29,"open_issues":10,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/186"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/186"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/186"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/186/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/186/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/186/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_os/statuses/5a2a12dce2492fe01ea2ef2037b4592d835f4265"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":123,"deletions":35,"changed_files":6}}