{"action":"closed","number":468,"pull_request":{"url":"https://api.github.com/repos/thephpleague/flysystem/pulls/468","id":33778191,"html_url":"https://github.com/thephpleague/flysystem/pull/468","diff_url":"https://github.com/thephpleague/flysystem/pull/468.diff","patch_url":"https://github.com/thephpleague/flysystem/pull/468.patch","issue_url":"https://api.github.com/repos/thephpleague/flysystem/issues/468","number":468,"state":"closed","locked":false,"title":"Allow prefixes like URI schemes in MountManager","user":{"login":"graste","id":203540,"avatar_url":"https://avatars.githubusercontent.com/u/203540?v=3","gravatar_id":"","url":"https://api.github.com/users/graste","html_url":"https://github.com/graste","followers_url":"https://api.github.com/users/graste/followers","following_url":"https://api.github.com/users/graste/following{/other_user}","gists_url":"https://api.github.com/users/graste/gists{/gist_id}","starred_url":"https://api.github.com/users/graste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graste/subscriptions","organizations_url":"https://api.github.com/users/graste/orgs","repos_url":"https://api.github.com/users/graste/repos","events_url":"https://api.github.com/users/graste/events{/privacy}","received_events_url":"https://api.github.com/users/graste/received_events","type":"User","site_admin":false},"body":"Allow prefixes that are valid schemes according to RFC3986. That is, a prefix must start with a letter followed by any combination of letters, digits, plus (`+`), period (`.`), or hyphen (`-`). This change allows\r\ncase insensitive usage of prefixes as the internal key for the filesystems array is lowercased.\r\n\r\nSee http://tools.ietf.org/html/rfc3986#section-3.1\r\n\r\nThis change is a breaking change as prior to this the mounting of filesystems never checked for valid prefixes and prior to this change all number prefixes like `1` or `1337` were valid.\r\n\r\nThe main reason for me to create this pull-request is to get support for prefixes like `user-assets` or `article-images` in my project's code.\r\n\r\nPS: I tried to adhere to the given coding style. May I suggest adding a contributing document to the project to tell people what to test and check when creating changes, what coding style to adhere to and most importantly against what branches you want to have pull requests created?","created_at":"2015-04-21T16:19:43Z","updated_at":"2015-06-09T14:42:57Z","closed_at":"2015-06-09T14:42:57Z","merged_at":null,"merge_commit_sha":"9d67f2affc172361daabaece313a81d13806ac0f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thephpleague/flysystem/pulls/468/commits","review_comments_url":"https://api.github.com/repos/thephpleague/flysystem/pulls/468/comments","review_comment_url":"https://api.github.com/repos/thephpleague/flysystem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thephpleague/flysystem/issues/468/comments","statuses_url":"https://api.github.com/repos/thephpleague/flysystem/statuses/d02a7331523f0ed82aa65544f0f9acc3b4050638","head":{"label":"graste:master","ref":"master","sha":"d02a7331523f0ed82aa65544f0f9acc3b4050638","user":{"login":"graste","id":203540,"avatar_url":"https://avatars.githubusercontent.com/u/203540?v=3","gravatar_id":"","url":"https://api.github.com/users/graste","html_url":"https://github.com/graste","followers_url":"https://api.github.com/users/graste/followers","following_url":"https://api.github.com/users/graste/following{/other_user}","gists_url":"https://api.github.com/users/graste/gists{/gist_id}","starred_url":"https://api.github.com/users/graste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graste/subscriptions","organizations_url":"https://api.github.com/users/graste/orgs","repos_url":"https://api.github.com/users/graste/repos","events_url":"https://api.github.com/users/graste/events{/privacy}","received_events_url":"https://api.github.com/users/graste/received_events","type":"User","site_admin":false},"repo":{"id":34317929,"name":"flysystem","full_name":"graste/flysystem","owner":{"login":"graste","id":203540,"avatar_url":"https://avatars.githubusercontent.com/u/203540?v=3","gravatar_id":"","url":"https://api.github.com/users/graste","html_url":"https://github.com/graste","followers_url":"https://api.github.com/users/graste/followers","following_url":"https://api.github.com/users/graste/following{/other_user}","gists_url":"https://api.github.com/users/graste/gists{/gist_id}","starred_url":"https://api.github.com/users/graste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graste/subscriptions","organizations_url":"https://api.github.com/users/graste/orgs","repos_url":"https://api.github.com/users/graste/repos","events_url":"https://api.github.com/users/graste/events{/privacy}","received_events_url":"https://api.github.com/users/graste/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/graste/flysystem","description":"Abstraction for local and remote filesystems","fork":true,"url":"https://api.github.com/repos/graste/flysystem","forks_url":"https://api.github.com/repos/graste/flysystem/forks","keys_url":"https://api.github.com/repos/graste/flysystem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graste/flysystem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graste/flysystem/teams","hooks_url":"https://api.github.com/repos/graste/flysystem/hooks","issue_events_url":"https://api.github.com/repos/graste/flysystem/issues/events{/number}","events_url":"https://api.github.com/repos/graste/flysystem/events","assignees_url":"https://api.github.com/repos/graste/flysystem/assignees{/user}","branches_url":"https://api.github.com/repos/graste/flysystem/branches{/branch}","tags_url":"https://api.github.com/repos/graste/flysystem/tags","blobs_url":"https://api.github.com/repos/graste/flysystem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graste/flysystem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graste/flysystem/git/refs{/sha}","trees_url":"https://api.github.com/repos/graste/flysystem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graste/flysystem/statuses/{sha}","languages_url":"https://api.github.com/repos/graste/flysystem/languages","stargazers_url":"https://api.github.com/repos/graste/flysystem/stargazers","contributors_url":"https://api.github.com/repos/graste/flysystem/contributors","subscribers_url":"https://api.github.com/repos/graste/flysystem/subscribers","subscription_url":"https://api.github.com/repos/graste/flysystem/subscription","commits_url":"https://api.github.com/repos/graste/flysystem/commits{/sha}","git_commits_url":"https://api.github.com/repos/graste/flysystem/git/commits{/sha}","comments_url":"https://api.github.com/repos/graste/flysystem/comments{/number}","issue_comment_url":"https://api.github.com/repos/graste/flysystem/issues/comments{/number}","contents_url":"https://api.github.com/repos/graste/flysystem/contents/{+path}","compare_url":"https://api.github.com/repos/graste/flysystem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graste/flysystem/merges","archive_url":"https://api.github.com/repos/graste/flysystem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graste/flysystem/downloads","issues_url":"https://api.github.com/repos/graste/flysystem/issues{/number}","pulls_url":"https://api.github.com/repos/graste/flysystem/pulls{/number}","milestones_url":"https://api.github.com/repos/graste/flysystem/milestones{/number}","notifications_url":"https://api.github.com/repos/graste/flysystem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graste/flysystem/labels{/name}","releases_url":"https://api.github.com/repos/graste/flysystem/releases{/id}","created_at":"2015-04-21T09:38:00Z","updated_at":"2015-04-21T16:15:43Z","pushed_at":"2015-05-19T22:10:40Z","git_url":"git://github.com/graste/flysystem.git","ssh_url":"git@github.com:graste/flysystem.git","clone_url":"https://github.com/graste/flysystem.git","svn_url":"https://github.com/graste/flysystem","homepage":"http://flysystem.thephpleague.com","size":1840,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thephpleague:master","ref":"master","sha":"a1d15d4377f322559c011a2dbfabfc2b710f6cdf","user":{"login":"thephpleague","id":527621,"avatar_url":"https://avatars.githubusercontent.com/u/527621?v=3","gravatar_id":"","url":"https://api.github.com/users/thephpleague","html_url":"https://github.com/thephpleague","followers_url":"https://api.github.com/users/thephpleague/followers","following_url":"https://api.github.com/users/thephpleague/following{/other_user}","gists_url":"https://api.github.com/users/thephpleague/gists{/gist_id}","starred_url":"https://api.github.com/users/thephpleague/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thephpleague/subscriptions","organizations_url":"https://api.github.com/users/thephpleague/orgs","repos_url":"https://api.github.com/users/thephpleague/repos","events_url":"https://api.github.com/users/thephpleague/events{/privacy}","received_events_url":"https://api.github.com/users/thephpleague/received_events","type":"Organization","site_admin":false},"repo":{"id":13899674,"name":"flysystem","full_name":"thephpleague/flysystem","owner":{"login":"thephpleague","id":527621,"avatar_url":"https://avatars.githubusercontent.com/u/527621?v=3","gravatar_id":"","url":"https://api.github.com/users/thephpleague","html_url":"https://github.com/thephpleague","followers_url":"https://api.github.com/users/thephpleague/followers","following_url":"https://api.github.com/users/thephpleague/following{/other_user}","gists_url":"https://api.github.com/users/thephpleague/gists{/gist_id}","starred_url":"https://api.github.com/users/thephpleague/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thephpleague/subscriptions","organizations_url":"https://api.github.com/users/thephpleague/orgs","repos_url":"https://api.github.com/users/thephpleague/repos","events_url":"https://api.github.com/users/thephpleague/events{/privacy}","received_events_url":"https://api.github.com/users/thephpleague/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thephpleague/flysystem","description":"Abstraction for local and remote filesystems","fork":false,"url":"https://api.github.com/repos/thephpleague/flysystem","forks_url":"https://api.github.com/repos/thephpleague/flysystem/forks","keys_url":"https://api.github.com/repos/thephpleague/flysystem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thephpleague/flysystem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thephpleague/flysystem/teams","hooks_url":"https://api.github.com/repos/thephpleague/flysystem/hooks","issue_events_url":"https://api.github.com/repos/thephpleague/flysystem/issues/events{/number}","events_url":"https://api.github.com/repos/thephpleague/flysystem/events","assignees_url":"https://api.github.com/repos/thephpleague/flysystem/assignees{/user}","branches_url":"https://api.github.com/repos/thephpleague/flysystem/branches{/branch}","tags_url":"https://api.github.com/repos/thephpleague/flysystem/tags","blobs_url":"https://api.github.com/repos/thephpleague/flysystem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thephpleague/flysystem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thephpleague/flysystem/git/refs{/sha}","trees_url":"https://api.github.com/repos/thephpleague/flysystem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thephpleague/flysystem/statuses/{sha}","languages_url":"https://api.github.com/repos/thephpleague/flysystem/languages","stargazers_url":"https://api.github.com/repos/thephpleague/flysystem/stargazers","contributors_url":"https://api.github.com/repos/thephpleague/flysystem/contributors","subscribers_url":"https://api.github.com/repos/thephpleague/flysystem/subscribers","subscription_url":"https://api.github.com/repos/thephpleague/flysystem/subscription","commits_url":"https://api.github.com/repos/thephpleague/flysystem/commits{/sha}","git_commits_url":"https://api.github.com/repos/thephpleague/flysystem/git/commits{/sha}","comments_url":"https://api.github.com/repos/thephpleague/flysystem/comments{/number}","issue_comment_url":"https://api.github.com/repos/thephpleague/flysystem/issues/comments{/number}","contents_url":"https://api.github.com/repos/thephpleague/flysystem/contents/{+path}","compare_url":"https://api.github.com/repos/thephpleague/flysystem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thephpleague/flysystem/merges","archive_url":"https://api.github.com/repos/thephpleague/flysystem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thephpleague/flysystem/downloads","issues_url":"https://api.github.com/repos/thephpleague/flysystem/issues{/number}","pulls_url":"https://api.github.com/repos/thephpleague/flysystem/pulls{/number}","milestones_url":"https://api.github.com/repos/thephpleague/flysystem/milestones{/number}","notifications_url":"https://api.github.com/repos/thephpleague/flysystem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thephpleague/flysystem/labels{/name}","releases_url":"https://api.github.com/repos/thephpleague/flysystem/releases{/id}","created_at":"2013-10-27T11:07:22Z","updated_at":"2015-06-09T04:32:26Z","pushed_at":"2015-06-08T21:31:26Z","git_url":"git://github.com/thephpleague/flysystem.git","ssh_url":"git@github.com:thephpleague/flysystem.git","clone_url":"https://github.com/thephpleague/flysystem.git","svn_url":"https://github.com/thephpleague/flysystem","homepage":"http://flysystem.thephpleague.com","size":5855,"stargazers_count":2246,"watchers_count":2246,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":210,"mirror_url":null,"open_issues_count":17,"forks":210,"open_issues":17,"watchers":2246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thephpleague/flysystem/pulls/468"},"html":{"href":"https://github.com/thephpleague/flysystem/pull/468"},"issue":{"href":"https://api.github.com/repos/thephpleague/flysystem/issues/468"},"comments":{"href":"https://api.github.com/repos/thephpleague/flysystem/issues/468/comments"},"review_comments":{"href":"https://api.github.com/repos/thephpleague/flysystem/pulls/468/comments"},"review_comment":{"href":"https://api.github.com/repos/thephpleague/flysystem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thephpleague/flysystem/pulls/468/commits"},"statuses":{"href":"https://api.github.com/repos/thephpleague/flysystem/statuses/d02a7331523f0ed82aa65544f0f9acc3b4050638"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"commits":2,"additions":95,"deletions":4,"changed_files":3}}