{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/17982","labels_url":"https://api.github.com/repos/owncloud/core/issues/17982/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/17982/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/17982/events","html_url":"https://github.com/owncloud/core/pull/17982","id":98137480,"number":17982,"title":"Sanitize class names before registerService/query","user":{"login":"Xenopathic","id":2016878,"avatar_url":"https://avatars.githubusercontent.com/u/2016878?v=3","gravatar_id":"","url":"https://api.github.com/users/Xenopathic","html_url":"https://github.com/Xenopathic","followers_url":"https://api.github.com/users/Xenopathic/followers","following_url":"https://api.github.com/users/Xenopathic/following{/other_user}","gists_url":"https://api.github.com/users/Xenopathic/gists{/gist_id}","starred_url":"https://api.github.com/users/Xenopathic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xenopathic/subscriptions","organizations_url":"https://api.github.com/users/Xenopathic/orgs","repos_url":"https://api.github.com/users/Xenopathic/repos","events_url":"https://api.github.com/users/Xenopathic/events{/privacy}","received_events_url":"https://api.github.com/users/Xenopathic/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/enhancement","name":"enhancement","color":"02e10c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-30T10:37:22Z","updated_at":"2015-07-30T12:09:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/17982","html_url":"https://github.com/owncloud/core/pull/17982","diff_url":"https://github.com/owncloud/core/pull/17982.diff","patch_url":"https://github.com/owncloud/core/pull/17982.patch"},"body":"Leading backslashes are removed, so a `registerService('\\\\OC\\\\Foo')` can still be resolved with `query('OC\\\\Foo')`.\r\n\r\nRationale: sometimes people query services with a leading backslash, while the appframework auto-reflection system queries without the leading backslash (and sometimes, people query like that too). Since both class names are perfectly valid, they should be resolved correctly to the same object. As the appframework has used the form without the backslash all this time, I decided to sanitize all class names to that form.\r\n\r\ncc @rullzer @MorrisJobke @DeepDiver1975 @nickvergessen @LukasReschke "},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/126300507","html_url":"https://github.com/owncloud/core/pull/17982#issuecomment-126300507","issue_url":"https://api.github.com/repos/owncloud/core/issues/17982","id":126300507,"user":{"login":"DeepDiver1975","id":1005065,"avatar_url":"https://avatars.githubusercontent.com/u/1005065?v=3","gravatar_id":"","url":"https://api.github.com/users/DeepDiver1975","html_url":"https://github.com/DeepDiver1975","followers_url":"https://api.github.com/users/DeepDiver1975/followers","following_url":"https://api.github.com/users/DeepDiver1975/following{/other_user}","gists_url":"https://api.github.com/users/DeepDiver1975/gists{/gist_id}","starred_url":"https://api.github.com/users/DeepDiver1975/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeepDiver1975/subscriptions","organizations_url":"https://api.github.com/users/DeepDiver1975/orgs","repos_url":"https://api.github.com/users/DeepDiver1975/repos","events_url":"https://api.github.com/users/DeepDiver1975/events{/privacy}","received_events_url":"https://api.github.com/users/DeepDiver1975/received_events","type":"User","site_admin":false},"created_at":"2015-07-30T12:09:57Z","updated_at":"2015-07-30T12:09:57Z","body":"Please add a unit test to ensure services are properly resolved - THX"}}