{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/8323","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/8323/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/8323/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/8323/events","html_url":"https://github.com/joomla/joomla-cms/pull/8323","id":115688709,"number":8323,"title":"Isis template: no preview for media field due to undefined variable","user":{"login":"mttronc","id":1316539,"avatar_url":"https://avatars.githubusercontent.com/u/1316539?v=3","gravatar_id":"","url":"https://api.github.com/users/mttronc","html_url":"https://github.com/mttronc","followers_url":"https://api.github.com/users/mttronc/followers","following_url":"https://api.github.com/users/mttronc/following{/other_user}","gists_url":"https://api.github.com/users/mttronc/gists{/gist_id}","starred_url":"https://api.github.com/users/mttronc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mttronc/subscriptions","organizations_url":"https://api.github.com/users/mttronc/orgs","repos_url":"https://api.github.com/users/mttronc/repos","events_url":"https://api.github.com/users/mttronc/events{/privacy}","received_events_url":"https://api.github.com/users/mttronc/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/7","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla!%203.5.0","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/7/labels","id":944889,"number":7,"title":"Joomla! 3.5.0","description":"","creator":{"login":"rdeutz","id":467356,"avatar_url":"https://avatars.githubusercontent.com/u/467356?v=3","gravatar_id":"","url":"https://api.github.com/users/rdeutz","html_url":"https://github.com/rdeutz","followers_url":"https://api.github.com/users/rdeutz/followers","following_url":"https://api.github.com/users/rdeutz/following{/other_user}","gists_url":"https://api.github.com/users/rdeutz/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeutz/subscriptions","organizations_url":"https://api.github.com/users/rdeutz/orgs","repos_url":"https://api.github.com/users/rdeutz/repos","events_url":"https://api.github.com/users/rdeutz/events{/privacy}","received_events_url":"https://api.github.com/users/rdeutz/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":325,"state":"open","created_at":"2015-01-21T08:12:44Z","updated_at":"2015-11-09T07:57:11Z","due_on":"2015-12-07T23:00:00Z","closed_at":null},"comments":2,"created_at":"2015-11-07T20:03:27Z","updated_at":"2015-11-09T08:13:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/8323","html_url":"https://github.com/joomla/joomla-cms/pull/8323","diff_url":"https://github.com/joomla/joomla-cms/pull/8323.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/8323.patch"},"body":"If field media has attribute *preview* set to *true*, php complains about *$showPreview* not being declared and hence no preview is being shown.\r\n> Notice: Undefined variable: showPreview in /var/www/joomla/administrator/templates/isis/html/layouts/joomla/form/field/media.php on line 72\r\n\r\nLooks like in the case switch in `administrator/templates/isis/html/layouts/joomla/form/field/media.php` there is a *break* that is not supposed to be there, since leaving *$showPreview* undefined in some cases."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/154993477","html_url":"https://github.com/joomla/joomla-cms/pull/8323#issuecomment-154993477","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/8323","id":154993477,"user":{"login":"yvesh","id":897638,"avatar_url":"https://avatars.githubusercontent.com/u/897638?v=3","gravatar_id":"","url":"https://api.github.com/users/yvesh","html_url":"https://github.com/yvesh","followers_url":"https://api.github.com/users/yvesh/followers","following_url":"https://api.github.com/users/yvesh/following{/other_user}","gists_url":"https://api.github.com/users/yvesh/gists{/gist_id}","starred_url":"https://api.github.com/users/yvesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yvesh/subscriptions","organizations_url":"https://api.github.com/users/yvesh/orgs","repos_url":"https://api.github.com/users/yvesh/repos","events_url":"https://api.github.com/users/yvesh/events{/privacy}","received_events_url":"https://api.github.com/users/yvesh/received_events","type":"User","site_admin":false},"created_at":"2015-11-09T08:13:30Z","updated_at":"2015-11-09T08:13:30Z","body":"I have tested this item :white_check_mark: successfully on 58efabfb8be0d64b4e5f832cf06a65561d22dc6f<br /><br />Works fine. Good work!<hr /><sub>This comment was created with the <a href=\"https://github.com/joomla/jissues\">J!Tracker Application</a> at <a href=\"https://issues.joomla.org/tracker/joomla-cms/8323\">issues.joomla.org/joomla-cms/8323</a>.</sub>"}}