{"action":"created","issue":{"url":"https://api.github.com/repos/Dogfalo/materialize/issues/1687","labels_url":"https://api.github.com/repos/Dogfalo/materialize/issues/1687/labels{/name}","comments_url":"https://api.github.com/repos/Dogfalo/materialize/issues/1687/comments","events_url":"https://api.github.com/repos/Dogfalo/materialize/issues/1687/events","html_url":"https://github.com/Dogfalo/materialize/pull/1687","id":93461305,"number":1687,"title":"Refactor select plugin and add options","user":{"login":"Johann-S","id":1689750,"avatar_url":"https://avatars.githubusercontent.com/u/1689750?v=3","gravatar_id":"","url":"https://api.github.com/users/Johann-S","html_url":"https://github.com/Johann-S","followers_url":"https://api.github.com/users/Johann-S/followers","following_url":"https://api.github.com/users/Johann-S/following{/other_user}","gists_url":"https://api.github.com/users/Johann-S/gists{/gist_id}","starred_url":"https://api.github.com/users/Johann-S/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Johann-S/subscriptions","organizations_url":"https://api.github.com/users/Johann-S/orgs","repos_url":"https://api.github.com/users/Johann-S/repos","events_url":"https://api.github.com/users/Johann-S/events{/privacy}","received_events_url":"https://api.github.com/users/Johann-S/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-07T07:34:30Z","updated_at":"2015-07-16T07:31:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Dogfalo/materialize/pulls/1687","html_url":"https://github.com/Dogfalo/materialize/pull/1687","diff_url":"https://github.com/Dogfalo/materialize/pull/1687.diff","patch_url":"https://github.com/Dogfalo/materialize/pull/1687.patch"},"body":"Hi,\r\n\r\nI know it's a big PR but i think it's valuable.\r\n\r\nThis PR allow to add a maxHeight to the select plugin (https://github.com/Dogfalo/materialize/issues/1638) and maybe other options later.\r\n\r\nBut it fixe too the problem of destroying a select (related to https://github.com/Dogfalo/materialize/issues/1686 and https://github.com/Dogfalo/materialize/issues/1570).\r\n\r\nAnd to finish I think it's better for the code to split each plugins in different file this is why\r\nI create a select.js file."},"comment":{"url":"https://api.github.com/repos/Dogfalo/materialize/issues/comments/121860197","html_url":"https://github.com/Dogfalo/materialize/pull/1687#issuecomment-121860197","issue_url":"https://api.github.com/repos/Dogfalo/materialize/issues/1687","id":121860197,"user":{"login":"Johann-S","id":1689750,"avatar_url":"https://avatars.githubusercontent.com/u/1689750?v=3","gravatar_id":"","url":"https://api.github.com/users/Johann-S","html_url":"https://github.com/Johann-S","followers_url":"https://api.github.com/users/Johann-S/followers","following_url":"https://api.github.com/users/Johann-S/following{/other_user}","gists_url":"https://api.github.com/users/Johann-S/gists{/gist_id}","starred_url":"https://api.github.com/users/Johann-S/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Johann-S/subscriptions","organizations_url":"https://api.github.com/users/Johann-S/orgs","repos_url":"https://api.github.com/users/Johann-S/repos","events_url":"https://api.github.com/users/Johann-S/events{/privacy}","received_events_url":"https://api.github.com/users/Johann-S/received_events","type":"User","site_admin":false},"created_at":"2015-07-16T07:31:58Z","updated_at":"2015-07-16T07:31:58Z","body":"PING @Dogfalo @acburst \r\nAny feedbacks on this PR ?"}}