{"action":"created","comment":{"url":"https://api.github.com/repos/remind101/stacker/pulls/comments/31957922","id":31957922,"diff_hunk":"@@ -142,15 +146,20 @@ def conn(self):\n         return self._conn\n \n     @property\n+    def s3_conn(self):\n+        if not getattr(self, '_s3_conn', None):","path":"stacker/builder.py","position":50,"original_position":50,"commit_id":"74557e8aee1875b275754d7f97abeb35d4698fe6","original_commit_id":"74557e8aee1875b275754d7f97abeb35d4698fe6","user":{"login":"mhahn","id":704593,"avatar_url":"https://avatars.githubusercontent.com/u/704593?v=3","gravatar_id":"","url":"https://api.github.com/users/mhahn","html_url":"https://github.com/mhahn","followers_url":"https://api.github.com/users/mhahn/followers","following_url":"https://api.github.com/users/mhahn/following{/other_user}","gists_url":"https://api.github.com/users/mhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/mhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhahn/subscriptions","organizations_url":"https://api.github.com/users/mhahn/orgs","repos_url":"https://api.github.com/users/mhahn/repos","events_url":"https://api.github.com/users/mhahn/events{/privacy}","received_events_url":"https://api.github.com/users/mhahn/received_events","type":"User","site_admin":false},"body":"switched this to \"hasattr\", the point is that this is a private variable and should only be accessed by the property to cache the connection.","created_at":"2015-06-08T20:49:18Z","updated_at":"2015-06-08T20:49:18Z","html_url":"https://github.com/remind101/stacker/pull/34#discussion_r31957922","pull_request_url":"https://api.github.com/repos/remind101/stacker/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/remind101/stacker/pulls/comments/31957922"},"html":{"href":"https://github.com/remind101/stacker/pull/34#discussion_r31957922"},"pull_request":{"href":"https://api.github.com/repos/remind101/stacker/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/remind101/stacker/pulls/34","id":35871453,"html_url":"https://github.com/remind101/stacker/pull/34","diff_url":"https://github.com/remind101/stacker/pull/34.diff","patch_url":"https://github.com/remind101/stacker/pull/34.patch","issue_url":"https://api.github.com/repos/remind101/stacker/issues/34","number":34,"state":"open","locked":false,"title":"Random fixes and cleanup","user":{"login":"mhahn","id":704593,"avatar_url":"https://avatars.githubusercontent.com/u/704593?v=3","gravatar_id":"","url":"https://api.github.com/users/mhahn","html_url":"https://github.com/mhahn","followers_url":"https://api.github.com/users/mhahn/followers","following_url":"https://api.github.com/users/mhahn/following{/other_user}","gists_url":"https://api.github.com/users/mhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/mhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhahn/subscriptions","organizations_url":"https://api.github.com/users/mhahn/orgs","repos_url":"https://api.github.com/users/mhahn/repos","events_url":"https://api.github.com/users/mhahn/events{/privacy}","received_events_url":"https://api.github.com/users/mhahn/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-20T20:17:14Z","updated_at":"2015-06-08T20:49:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6614fae59648cd884b6266fc1d55d297c8fcd198","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/remind101/stacker/pulls/34/commits","review_comments_url":"https://api.github.com/repos/remind101/stacker/pulls/34/comments","review_comment_url":"https://api.github.com/repos/remind101/stacker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/remind101/stacker/issues/34/comments","statuses_url":"https://api.github.com/repos/remind101/stacker/statuses/74557e8aee1875b275754d7f97abeb35d4698fe6","head":{"label":"mhahn:master","ref":"master","sha":"74557e8aee1875b275754d7f97abeb35d4698fe6","user":{"login":"mhahn","id":704593,"avatar_url":"https://avatars.githubusercontent.com/u/704593?v=3","gravatar_id":"","url":"https://api.github.com/users/mhahn","html_url":"https://github.com/mhahn","followers_url":"https://api.github.com/users/mhahn/followers","following_url":"https://api.github.com/users/mhahn/following{/other_user}","gists_url":"https://api.github.com/users/mhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/mhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhahn/subscriptions","organizations_url":"https://api.github.com/users/mhahn/orgs","repos_url":"https://api.github.com/users/mhahn/repos","events_url":"https://api.github.com/users/mhahn/events{/privacy}","received_events_url":"https://api.github.com/users/mhahn/received_events","type":"User","site_admin":false},"repo":{"id":33085705,"name":"stacker","full_name":"mhahn/stacker","owner":{"login":"mhahn","id":704593,"avatar_url":"https://avatars.githubusercontent.com/u/704593?v=3","gravatar_id":"","url":"https://api.github.com/users/mhahn","html_url":"https://github.com/mhahn","followers_url":"https://api.github.com/users/mhahn/followers","following_url":"https://api.github.com/users/mhahn/following{/other_user}","gists_url":"https://api.github.com/users/mhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/mhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhahn/subscriptions","organizations_url":"https://api.github.com/users/mhahn/orgs","repos_url":"https://api.github.com/users/mhahn/repos","events_url":"https://api.github.com/users/mhahn/events{/privacy}","received_events_url":"https://api.github.com/users/mhahn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhahn/stacker","description":"An opinionated AWS CloudFormation Stack builder.","fork":true,"url":"https://api.github.com/repos/mhahn/stacker","forks_url":"https://api.github.com/repos/mhahn/stacker/forks","keys_url":"https://api.github.com/repos/mhahn/stacker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhahn/stacker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhahn/stacker/teams","hooks_url":"https://api.github.com/repos/mhahn/stacker/hooks","issue_events_url":"https://api.github.com/repos/mhahn/stacker/issues/events{/number}","events_url":"https://api.github.com/repos/mhahn/stacker/events","assignees_url":"https://api.github.com/repos/mhahn/stacker/assignees{/user}","branches_url":"https://api.github.com/repos/mhahn/stacker/branches{/branch}","tags_url":"https://api.github.com/repos/mhahn/stacker/tags","blobs_url":"https://api.github.com/repos/mhahn/stacker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhahn/stacker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhahn/stacker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhahn/stacker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhahn/stacker/statuses/{sha}","languages_url":"https://api.github.com/repos/mhahn/stacker/languages","stargazers_url":"https://api.github.com/repos/mhahn/stacker/stargazers","contributors_url":"https://api.github.com/repos/mhahn/stacker/contributors","subscribers_url":"https://api.github.com/repos/mhahn/stacker/subscribers","subscription_url":"https://api.github.com/repos/mhahn/stacker/subscription","commits_url":"https://api.github.com/repos/mhahn/stacker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhahn/stacker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhahn/stacker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhahn/stacker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhahn/stacker/contents/{+path}","compare_url":"https://api.github.com/repos/mhahn/stacker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhahn/stacker/merges","archive_url":"https://api.github.com/repos/mhahn/stacker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhahn/stacker/downloads","issues_url":"https://api.github.com/repos/mhahn/stacker/issues{/number}","pulls_url":"https://api.github.com/repos/mhahn/stacker/pulls{/number}","milestones_url":"https://api.github.com/repos/mhahn/stacker/milestones{/number}","notifications_url":"https://api.github.com/repos/mhahn/stacker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhahn/stacker/labels{/name}","releases_url":"https://api.github.com/repos/mhahn/stacker/releases{/id}","created_at":"2015-03-29T19:22:00Z","updated_at":"2015-03-29T19:22:00Z","pushed_at":"2015-06-08T19:11:38Z","git_url":"git://github.com/mhahn/stacker.git","ssh_url":"git@github.com:mhahn/stacker.git","clone_url":"https://github.com/mhahn/stacker.git","svn_url":"https://github.com/mhahn/stacker","homepage":null,"size":247,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"remind101:master","ref":"master","sha":"1671a903517026c7a836fc0bbea9aa560b3f10ac","user":{"login":"remind101","id":376343,"avatar_url":"https://avatars.githubusercontent.com/u/376343?v=3","gravatar_id":"","url":"https://api.github.com/users/remind101","html_url":"https://github.com/remind101","followers_url":"https://api.github.com/users/remind101/followers","following_url":"https://api.github.com/users/remind101/following{/other_user}","gists_url":"https://api.github.com/users/remind101/gists{/gist_id}","starred_url":"https://api.github.com/users/remind101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remind101/subscriptions","organizations_url":"https://api.github.com/users/remind101/orgs","repos_url":"https://api.github.com/users/remind101/repos","events_url":"https://api.github.com/users/remind101/events{/privacy}","received_events_url":"https://api.github.com/users/remind101/received_events","type":"Organization","site_admin":false},"repo":{"id":28885080,"name":"stacker","full_name":"remind101/stacker","owner":{"login":"remind101","id":376343,"avatar_url":"https://avatars.githubusercontent.com/u/376343?v=3","gravatar_id":"","url":"https://api.github.com/users/remind101","html_url":"https://github.com/remind101","followers_url":"https://api.github.com/users/remind101/followers","following_url":"https://api.github.com/users/remind101/following{/other_user}","gists_url":"https://api.github.com/users/remind101/gists{/gist_id}","starred_url":"https://api.github.com/users/remind101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remind101/subscriptions","organizations_url":"https://api.github.com/users/remind101/orgs","repos_url":"https://api.github.com/users/remind101/repos","events_url":"https://api.github.com/users/remind101/events{/privacy}","received_events_url":"https://api.github.com/users/remind101/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/remind101/stacker","description":"An opinionated AWS CloudFormation Stack builder.","fork":false,"url":"https://api.github.com/repos/remind101/stacker","forks_url":"https://api.github.com/repos/remind101/stacker/forks","keys_url":"https://api.github.com/repos/remind101/stacker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/remind101/stacker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/remind101/stacker/teams","hooks_url":"https://api.github.com/repos/remind101/stacker/hooks","issue_events_url":"https://api.github.com/repos/remind101/stacker/issues/events{/number}","events_url":"https://api.github.com/repos/remind101/stacker/events","assignees_url":"https://api.github.com/repos/remind101/stacker/assignees{/user}","branches_url":"https://api.github.com/repos/remind101/stacker/branches{/branch}","tags_url":"https://api.github.com/repos/remind101/stacker/tags","blobs_url":"https://api.github.com/repos/remind101/stacker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/remind101/stacker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/remind101/stacker/git/refs{/sha}","trees_url":"https://api.github.com/repos/remind101/stacker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/remind101/stacker/statuses/{sha}","languages_url":"https://api.github.com/repos/remind101/stacker/languages","stargazers_url":"https://api.github.com/repos/remind101/stacker/stargazers","contributors_url":"https://api.github.com/repos/remind101/stacker/contributors","subscribers_url":"https://api.github.com/repos/remind101/stacker/subscribers","subscription_url":"https://api.github.com/repos/remind101/stacker/subscription","commits_url":"https://api.github.com/repos/remind101/stacker/commits{/sha}","git_commits_url":"https://api.github.com/repos/remind101/stacker/git/commits{/sha}","comments_url":"https://api.github.com/repos/remind101/stacker/comments{/number}","issue_comment_url":"https://api.github.com/repos/remind101/stacker/issues/comments{/number}","contents_url":"https://api.github.com/repos/remind101/stacker/contents/{+path}","compare_url":"https://api.github.com/repos/remind101/stacker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/remind101/stacker/merges","archive_url":"https://api.github.com/repos/remind101/stacker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/remind101/stacker/downloads","issues_url":"https://api.github.com/repos/remind101/stacker/issues{/number}","pulls_url":"https://api.github.com/repos/remind101/stacker/pulls{/number}","milestones_url":"https://api.github.com/repos/remind101/stacker/milestones{/number}","notifications_url":"https://api.github.com/repos/remind101/stacker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/remind101/stacker/labels{/name}","releases_url":"https://api.github.com/repos/remind101/stacker/releases{/id}","created_at":"2015-01-06T21:46:05Z","updated_at":"2015-05-23T05:42:28Z","pushed_at":"2015-05-21T00:14:59Z","git_url":"git://github.com/remind101/stacker.git","ssh_url":"git@github.com:remind101/stacker.git","clone_url":"https://github.com/remind101/stacker.git","svn_url":"https://github.com/remind101/stacker","homepage":null,"size":911,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/remind101/stacker/pulls/34"},"html":{"href":"https://github.com/remind101/stacker/pull/34"},"issue":{"href":"https://api.github.com/repos/remind101/stacker/issues/34"},"comments":{"href":"https://api.github.com/repos/remind101/stacker/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/remind101/stacker/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/remind101/stacker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/remind101/stacker/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/remind101/stacker/statuses/74557e8aee1875b275754d7f97abeb35d4698fe6"}}}}