{"action":"created","comment":{"url":"https://api.github.com/repos/dpla/KriKri/pulls/comments/22541518","id":22541518,"diff_hunk":"@@ -1,19 +1,61 @@\n require 'spec_helper'\n \n describe Krikri::Harvester do\n-  it 'is a havester' do\n-    expect(subject).to be_a Krikri::Harvester\n-  end\n+\n+  # Our subject is an instance of a dummy class that mixes in\n+  # Krikri::Harvester.\n+  let(:klass) { Class.new }\n+  subject { klass.include(Krikri::Harvester).new }\n \n   context 'with record_ids implemented' do\n     before do\n-      described_class.send(:define_method, :record_ids) do\n-        [1, 2, 3, 4, 5]\n-      end\n+      expect(subject).to receive(:record_ids).and_return([1, 2, 3, 4, 5])","path":"spec/lib/krikri/harvester_spec.rb","position":18,"original_position":18,"commit_id":"81413559f9abc30cec24e54ce1d4fe6ad2de622b","original_commit_id":"81413559f9abc30cec24e54ce1d4fe6ad2de622b","user":{"login":"markbreedlove","id":5550828,"avatar_url":"https://avatars.githubusercontent.com/u/5550828?v=3","gravatar_id":"","url":"https://api.github.com/users/markbreedlove","html_url":"https://github.com/markbreedlove","followers_url":"https://api.github.com/users/markbreedlove/followers","following_url":"https://api.github.com/users/markbreedlove/following{/other_user}","gists_url":"https://api.github.com/users/markbreedlove/gists{/gist_id}","starred_url":"https://api.github.com/users/markbreedlove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markbreedlove/subscriptions","organizations_url":"https://api.github.com/users/markbreedlove/orgs","repos_url":"https://api.github.com/users/markbreedlove/repos","events_url":"https://api.github.com/users/markbreedlove/events{/privacy}","received_events_url":"https://api.github.com/users/markbreedlove/received_events","type":"User","site_admin":false},"body":"OK, with that in mind, I think it's a good idea to switch to `allow`.","created_at":"2015-01-06T18:42:00Z","updated_at":"2015-01-06T18:42:00Z","html_url":"https://github.com/dpla/KriKri/pull/46#discussion_r22541518","pull_request_url":"https://api.github.com/repos/dpla/KriKri/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/dpla/KriKri/pulls/comments/22541518"},"html":{"href":"https://github.com/dpla/KriKri/pull/46#discussion_r22541518"},"pull_request":{"href":"https://api.github.com/repos/dpla/KriKri/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/dpla/KriKri/pulls/46","id":26890017,"html_url":"https://github.com/dpla/KriKri/pull/46","diff_url":"https://github.com/dpla/KriKri/pull/46.diff","patch_url":"https://github.com/dpla/KriKri/pull/46.patch","issue_url":"https://api.github.com/repos/dpla/KriKri/issues/46","number":46,"state":"open","locked":false,"title":"Add a registry of harvesters","user":{"login":"markbreedlove","id":5550828,"avatar_url":"https://avatars.githubusercontent.com/u/5550828?v=3","gravatar_id":"","url":"https://api.github.com/users/markbreedlove","html_url":"https://github.com/markbreedlove","followers_url":"https://api.github.com/users/markbreedlove/followers","following_url":"https://api.github.com/users/markbreedlove/following{/other_user}","gists_url":"https://api.github.com/users/markbreedlove/gists{/gist_id}","starred_url":"https://api.github.com/users/markbreedlove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markbreedlove/subscriptions","organizations_url":"https://api.github.com/users/markbreedlove/orgs","repos_url":"https://api.github.com/users/markbreedlove/repos","events_url":"https://api.github.com/users/markbreedlove/events{/privacy}","received_events_url":"https://api.github.com/users/markbreedlove/received_events","type":"User","site_admin":false},"body":"Add a registry of harvesters, `Krikri::Harvester::Registry`.   This will be used when we enqueue jobs, or in the eventual user interface, in order to retrieve a harvester class given a token (e.g. get an OAIHarvester class for \"OAI\") or to retrieve a list of available harvester tokens for the purpose building menus.\r\n\r\nA future Event will look up the harvester token from the HarvestSource for a given institution, and call `#enqueue` on the relevant Harvester to put it in the queue.\r\n\r\nComing soon in another PR:  make a harvester report on the options that it will need when instantiated.  This will be necessary in the future for any client that needs to create harvest jobs with the right options for `enqueue`.\r\n","created_at":"2015-01-06T13:58:45Z","updated_at":"2015-01-06T18:42:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a734ddebe901056c0c99c231075d7b256b778ece","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dpla/KriKri/pulls/46/commits","review_comments_url":"https://api.github.com/repos/dpla/KriKri/pulls/46/comments","review_comment_url":"https://api.github.com/repos/dpla/KriKri/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dpla/KriKri/issues/46/comments","statuses_url":"https://api.github.com/repos/dpla/KriKri/statuses/81413559f9abc30cec24e54ce1d4fe6ad2de622b","head":{"label":"dpla:feature/harvester-registry","ref":"feature/harvester-registry","sha":"81413559f9abc30cec24e54ce1d4fe6ad2de622b","user":{"login":"dpla","id":1252916,"avatar_url":"https://avatars.githubusercontent.com/u/1252916?v=3","gravatar_id":"","url":"https://api.github.com/users/dpla","html_url":"https://github.com/dpla","followers_url":"https://api.github.com/users/dpla/followers","following_url":"https://api.github.com/users/dpla/following{/other_user}","gists_url":"https://api.github.com/users/dpla/gists{/gist_id}","starred_url":"https://api.github.com/users/dpla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpla/subscriptions","organizations_url":"https://api.github.com/users/dpla/orgs","repos_url":"https://api.github.com/users/dpla/repos","events_url":"https://api.github.com/users/dpla/events{/privacy}","received_events_url":"https://api.github.com/users/dpla/received_events","type":"Organization","site_admin":false},"repo":{"id":25104780,"name":"KriKri","full_name":"dpla/KriKri","owner":{"login":"dpla","id":1252916,"avatar_url":"https://avatars.githubusercontent.com/u/1252916?v=3","gravatar_id":"","url":"https://api.github.com/users/dpla","html_url":"https://github.com/dpla","followers_url":"https://api.github.com/users/dpla/followers","following_url":"https://api.github.com/users/dpla/following{/other_user}","gists_url":"https://api.github.com/users/dpla/gists{/gist_id}","starred_url":"https://api.github.com/users/dpla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpla/subscriptions","organizations_url":"https://api.github.com/users/dpla/orgs","repos_url":"https://api.github.com/users/dpla/repos","events_url":"https://api.github.com/users/dpla/events{/privacy}","received_events_url":"https://api.github.com/users/dpla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dpla/KriKri","description":"A Rails engine for metadata aggregation, enhancement, and quality control.","fork":false,"url":"https://api.github.com/repos/dpla/KriKri","forks_url":"https://api.github.com/repos/dpla/KriKri/forks","keys_url":"https://api.github.com/repos/dpla/KriKri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpla/KriKri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpla/KriKri/teams","hooks_url":"https://api.github.com/repos/dpla/KriKri/hooks","issue_events_url":"https://api.github.com/repos/dpla/KriKri/issues/events{/number}","events_url":"https://api.github.com/repos/dpla/KriKri/events","assignees_url":"https://api.github.com/repos/dpla/KriKri/assignees{/user}","branches_url":"https://api.github.com/repos/dpla/KriKri/branches{/branch}","tags_url":"https://api.github.com/repos/dpla/KriKri/tags","blobs_url":"https://api.github.com/repos/dpla/KriKri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpla/KriKri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpla/KriKri/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpla/KriKri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpla/KriKri/statuses/{sha}","languages_url":"https://api.github.com/repos/dpla/KriKri/languages","stargazers_url":"https://api.github.com/repos/dpla/KriKri/stargazers","contributors_url":"https://api.github.com/repos/dpla/KriKri/contributors","subscribers_url":"https://api.github.com/repos/dpla/KriKri/subscribers","subscription_url":"https://api.github.com/repos/dpla/KriKri/subscription","commits_url":"https://api.github.com/repos/dpla/KriKri/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpla/KriKri/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpla/KriKri/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpla/KriKri/issues/comments/{number}","contents_url":"https://api.github.com/repos/dpla/KriKri/contents/{+path}","compare_url":"https://api.github.com/repos/dpla/KriKri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpla/KriKri/merges","archive_url":"https://api.github.com/repos/dpla/KriKri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpla/KriKri/downloads","issues_url":"https://api.github.com/repos/dpla/KriKri/issues{/number}","pulls_url":"https://api.github.com/repos/dpla/KriKri/pulls{/number}","milestones_url":"https://api.github.com/repos/dpla/KriKri/milestones{/number}","notifications_url":"https://api.github.com/repos/dpla/KriKri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpla/KriKri/labels{/name}","releases_url":"https://api.github.com/repos/dpla/KriKri/releases{/id}","created_at":"2014-10-12T02:41:01Z","updated_at":"2014-12-24T15:47:59Z","pushed_at":"2015-01-06T03:47:08Z","git_url":"git://github.com/dpla/KriKri.git","ssh_url":"git@github.com:dpla/KriKri.git","clone_url":"https://github.com/dpla/KriKri.git","svn_url":"https://github.com/dpla/KriKri","homepage":null,"size":4116,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":2,"default_branch":"develop"}},"base":{"label":"dpla:develop","ref":"develop","sha":"3c61a6d9240791076cd8f095eec559a7c3d0cae4","user":{"login":"dpla","id":1252916,"avatar_url":"https://avatars.githubusercontent.com/u/1252916?v=3","gravatar_id":"","url":"https://api.github.com/users/dpla","html_url":"https://github.com/dpla","followers_url":"https://api.github.com/users/dpla/followers","following_url":"https://api.github.com/users/dpla/following{/other_user}","gists_url":"https://api.github.com/users/dpla/gists{/gist_id}","starred_url":"https://api.github.com/users/dpla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpla/subscriptions","organizations_url":"https://api.github.com/users/dpla/orgs","repos_url":"https://api.github.com/users/dpla/repos","events_url":"https://api.github.com/users/dpla/events{/privacy}","received_events_url":"https://api.github.com/users/dpla/received_events","type":"Organization","site_admin":false},"repo":{"id":25104780,"name":"KriKri","full_name":"dpla/KriKri","owner":{"login":"dpla","id":1252916,"avatar_url":"https://avatars.githubusercontent.com/u/1252916?v=3","gravatar_id":"","url":"https://api.github.com/users/dpla","html_url":"https://github.com/dpla","followers_url":"https://api.github.com/users/dpla/followers","following_url":"https://api.github.com/users/dpla/following{/other_user}","gists_url":"https://api.github.com/users/dpla/gists{/gist_id}","starred_url":"https://api.github.com/users/dpla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpla/subscriptions","organizations_url":"https://api.github.com/users/dpla/orgs","repos_url":"https://api.github.com/users/dpla/repos","events_url":"https://api.github.com/users/dpla/events{/privacy}","received_events_url":"https://api.github.com/users/dpla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dpla/KriKri","description":"A Rails engine for metadata aggregation, enhancement, and quality control.","fork":false,"url":"https://api.github.com/repos/dpla/KriKri","forks_url":"https://api.github.com/repos/dpla/KriKri/forks","keys_url":"https://api.github.com/repos/dpla/KriKri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpla/KriKri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpla/KriKri/teams","hooks_url":"https://api.github.com/repos/dpla/KriKri/hooks","issue_events_url":"https://api.github.com/repos/dpla/KriKri/issues/events{/number}","events_url":"https://api.github.com/repos/dpla/KriKri/events","assignees_url":"https://api.github.com/repos/dpla/KriKri/assignees{/user}","branches_url":"https://api.github.com/repos/dpla/KriKri/branches{/branch}","tags_url":"https://api.github.com/repos/dpla/KriKri/tags","blobs_url":"https://api.github.com/repos/dpla/KriKri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpla/KriKri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpla/KriKri/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpla/KriKri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpla/KriKri/statuses/{sha}","languages_url":"https://api.github.com/repos/dpla/KriKri/languages","stargazers_url":"https://api.github.com/repos/dpla/KriKri/stargazers","contributors_url":"https://api.github.com/repos/dpla/KriKri/contributors","subscribers_url":"https://api.github.com/repos/dpla/KriKri/subscribers","subscription_url":"https://api.github.com/repos/dpla/KriKri/subscription","commits_url":"https://api.github.com/repos/dpla/KriKri/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpla/KriKri/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpla/KriKri/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpla/KriKri/issues/comments/{number}","contents_url":"https://api.github.com/repos/dpla/KriKri/contents/{+path}","compare_url":"https://api.github.com/repos/dpla/KriKri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpla/KriKri/merges","archive_url":"https://api.github.com/repos/dpla/KriKri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpla/KriKri/downloads","issues_url":"https://api.github.com/repos/dpla/KriKri/issues{/number}","pulls_url":"https://api.github.com/repos/dpla/KriKri/pulls{/number}","milestones_url":"https://api.github.com/repos/dpla/KriKri/milestones{/number}","notifications_url":"https://api.github.com/repos/dpla/KriKri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpla/KriKri/labels{/name}","releases_url":"https://api.github.com/repos/dpla/KriKri/releases{/id}","created_at":"2014-10-12T02:41:01Z","updated_at":"2014-12-24T15:47:59Z","pushed_at":"2015-01-06T03:47:08Z","git_url":"git://github.com/dpla/KriKri.git","ssh_url":"git@github.com:dpla/KriKri.git","clone_url":"https://github.com/dpla/KriKri.git","svn_url":"https://github.com/dpla/KriKri","homepage":null,"size":4116,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/dpla/KriKri/pulls/46"},"html":{"href":"https://github.com/dpla/KriKri/pull/46"},"issue":{"href":"https://api.github.com/repos/dpla/KriKri/issues/46"},"comments":{"href":"https://api.github.com/repos/dpla/KriKri/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/dpla/KriKri/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/dpla/KriKri/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dpla/KriKri/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/dpla/KriKri/statuses/81413559f9abc30cec24e54ce1d4fe6ad2de622b"}}}}