{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments/45792200","id":45792200,"diff_hunk":"@@ -63,9 +66,10 @@\n         Set<SensorSummary> sensors = Sets.newTreeSet(SummaryComparators.nameComparator());\n         Set<EffectorSummary> effectors = Sets.newTreeSet(SummaryComparators.nameComparator());\n \n+        EntitySpec<?> spec = null;\n+\n         try {\n-            @SuppressWarnings({ \"unchecked\", \"rawtypes\" })\n-            EntitySpec<?> spec = (EntitySpec<?>) b.getCatalog().createSpec((CatalogItem) item);\n+            spec = (EntitySpec<?>) b.getCatalog().createSpec((CatalogItem) item);","path":"usage/rest-server/src/main/java/org/apache/brooklyn/rest/transform/CatalogTransformer.java","position":27,"original_position":27,"commit_id":"641247fd94b9aca2964aef9e016aabd8951816b7","original_commit_id":"641247fd94b9aca2964aef9e016aabd8951816b7","user":{"login":"neykov","id":3612111,"avatar_url":"https://avatars.githubusercontent.com/u/3612111?v=3","gravatar_id":"","url":"https://api.github.com/users/neykov","html_url":"https://github.com/neykov","followers_url":"https://api.github.com/users/neykov/followers","following_url":"https://api.github.com/users/neykov/following{/other_user}","gists_url":"https://api.github.com/users/neykov/gists{/gist_id}","starred_url":"https://api.github.com/users/neykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neykov/subscriptions","organizations_url":"https://api.github.com/users/neykov/orgs","repos_url":"https://api.github.com/users/neykov/repos","events_url":"https://api.github.com/users/neykov/events{/privacy}","received_events_url":"https://api.github.com/users/neykov/received_events","type":"User","site_admin":false},"body":"Causes `Type safety: Unchecked invocation createSpec(CatalogItem) of the generic method createSpec(CatalogItem<T,SpecT>) of type BrooklynCatalog` in Eclipse. That's the reason it was like this before.","created_at":"2015-11-24T20:45:32Z","updated_at":"2015-11-24T20:45:32Z","html_url":"https://github.com/apache/incubator-brooklyn/pull/1063#discussion_r45792200","pull_request_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/1063","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments/45792200"},"html":{"href":"https://github.com/apache/incubator-brooklyn/pull/1063#discussion_r45792200"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/1063"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/1063","id":51667423,"html_url":"https://github.com/apache/incubator-brooklyn/pull/1063","diff_url":"https://github.com/apache/incubator-brooklyn/pull/1063.diff","patch_url":"https://github.com/apache/incubator-brooklyn/pull/1063.patch","issue_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/1063","number":1063,"state":"open","locked":false,"title":"Api tags support","user":{"login":"sjcorbett","id":837527,"avatar_url":"https://avatars.githubusercontent.com/u/837527?v=3","gravatar_id":"","url":"https://api.github.com/users/sjcorbett","html_url":"https://github.com/sjcorbett","followers_url":"https://api.github.com/users/sjcorbett/followers","following_url":"https://api.github.com/users/sjcorbett/following{/other_user}","gists_url":"https://api.github.com/users/sjcorbett/gists{/gist_id}","starred_url":"https://api.github.com/users/sjcorbett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjcorbett/subscriptions","organizations_url":"https://api.github.com/users/sjcorbett/orgs","repos_url":"https://api.github.com/users/sjcorbett/repos","events_url":"https://api.github.com/users/sjcorbett/events{/privacy}","received_events_url":"https://api.github.com/users/sjcorbett/received_events","type":"User","site_admin":false},"body":"Supercedes #1039.\r\n\r\n@neykov could you review commit 641247f please?\r\n","created_at":"2015-11-24T14:40:11Z","updated_at":"2015-11-24T20:45:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6331d6759ead165f911e9a0d27aaaf3c9a16e572","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/1063/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/1063/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/1063/comments","statuses_url":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/641247fd94b9aca2964aef9e016aabd8951816b7","head":{"label":"sjcorbett:api-tags-support","ref":"api-tags-support","sha":"641247fd94b9aca2964aef9e016aabd8951816b7","user":{"login":"sjcorbett","id":837527,"avatar_url":"https://avatars.githubusercontent.com/u/837527?v=3","gravatar_id":"","url":"https://api.github.com/users/sjcorbett","html_url":"https://github.com/sjcorbett","followers_url":"https://api.github.com/users/sjcorbett/followers","following_url":"https://api.github.com/users/sjcorbett/following{/other_user}","gists_url":"https://api.github.com/users/sjcorbett/gists{/gist_id}","starred_url":"https://api.github.com/users/sjcorbett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjcorbett/subscriptions","organizations_url":"https://api.github.com/users/sjcorbett/orgs","repos_url":"https://api.github.com/users/sjcorbett/repos","events_url":"https://api.github.com/users/sjcorbett/events{/privacy}","received_events_url":"https://api.github.com/users/sjcorbett/received_events","type":"User","site_admin":false},"repo":{"id":21124900,"name":"incubator-brooklyn","full_name":"sjcorbett/incubator-brooklyn","owner":{"login":"sjcorbett","id":837527,"avatar_url":"https://avatars.githubusercontent.com/u/837527?v=3","gravatar_id":"","url":"https://api.github.com/users/sjcorbett","html_url":"https://github.com/sjcorbett","followers_url":"https://api.github.com/users/sjcorbett/followers","following_url":"https://api.github.com/users/sjcorbett/following{/other_user}","gists_url":"https://api.github.com/users/sjcorbett/gists{/gist_id}","starred_url":"https://api.github.com/users/sjcorbett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjcorbett/subscriptions","organizations_url":"https://api.github.com/users/sjcorbett/orgs","repos_url":"https://api.github.com/users/sjcorbett/repos","events_url":"https://api.github.com/users/sjcorbett/events{/privacy}","received_events_url":"https://api.github.com/users/sjcorbett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sjcorbett/incubator-brooklyn","description":"Mirror of Apache Brooklyn","fork":true,"url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn","forks_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/forks","keys_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/teams","hooks_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/hooks","issue_events_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/issues/events{/number}","events_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/events","assignees_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/assignees{/user}","branches_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/branches{/branch}","tags_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/tags","blobs_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/statuses/{sha}","languages_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/languages","stargazers_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/stargazers","contributors_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/contributors","subscribers_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/subscribers","subscription_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/subscription","commits_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/contents/{+path}","compare_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/merges","archive_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/downloads","issues_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/issues{/number}","pulls_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/pulls{/number}","milestones_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/milestones{/number}","notifications_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/labels{/name}","releases_url":"https://api.github.com/repos/sjcorbett/incubator-brooklyn/releases{/id}","created_at":"2014-06-23T12:08:18Z","updated_at":"2015-03-04T10:33:05Z","pushed_at":"2015-11-24T14:38:29Z","git_url":"git://github.com/sjcorbett/incubator-brooklyn.git","ssh_url":"git@github.com:sjcorbett/incubator-brooklyn.git","clone_url":"https://github.com/sjcorbett/incubator-brooklyn.git","svn_url":"https://github.com/sjcorbett/incubator-brooklyn","homepage":null,"size":255086,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"57129dbacb77c8cf8f3344091f70873350401b8d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":19368221,"name":"incubator-brooklyn","full_name":"apache/incubator-brooklyn","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-brooklyn","description":"Mirror of Apache Brooklyn","fork":false,"url":"https://api.github.com/repos/apache/incubator-brooklyn","forks_url":"https://api.github.com/repos/apache/incubator-brooklyn/forks","keys_url":"https://api.github.com/repos/apache/incubator-brooklyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-brooklyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-brooklyn/teams","hooks_url":"https://api.github.com/repos/apache/incubator-brooklyn/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-brooklyn/events","assignees_url":"https://api.github.com/repos/apache/incubator-brooklyn/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-brooklyn/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-brooklyn/tags","blobs_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-brooklyn/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-brooklyn/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-brooklyn/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-brooklyn/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-brooklyn/subscription","commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-brooklyn/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-brooklyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-brooklyn/merges","archive_url":"https://api.github.com/repos/apache/incubator-brooklyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-brooklyn/downloads","issues_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-brooklyn/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-brooklyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-brooklyn/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-brooklyn/releases{/id}","created_at":"2014-05-02T07:00:07Z","updated_at":"2015-11-23T15:39:16Z","pushed_at":"2015-11-24T20:34:09Z","git_url":"git://github.com/apache/incubator-brooklyn.git","ssh_url":"git@github.com:apache/incubator-brooklyn.git","clone_url":"https://github.com/apache/incubator-brooklyn.git","svn_url":"https://github.com/apache/incubator-brooklyn","homepage":null,"size":256992,"stargazers_count":127,"watchers_count":127,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":97,"mirror_url":"git://git.apache.org/incubator-brooklyn.git","open_issues_count":21,"forks":97,"open_issues":21,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/1063"},"html":{"href":"https://github.com/apache/incubator-brooklyn/pull/1063"},"issue":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/issues/1063"},"comments":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/issues/1063/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/1063/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/1063/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/641247fd94b9aca2964aef9e016aabd8951816b7"}}}}