{"action":"created","comment":{"url":"https://api.github.com/repos/mavlink/mavros/pulls/comments/34554507","id":34554507,"diff_hunk":"@@ -0,0 +1,13 @@\n+<launch>\n+\t<!-- vim: set ft=xml noet : -->\n+\t<!-- Base node launch file-->\n+\t<arg name=\"args\" />\n+\t<arg name=\"mode\" />\n+\t<arg name=\"shape\" />\n+\n+\t<node pkg=\"test_mavros\" type=\"sitl_test_node\" args=\"$(arg args)\" name=\"sitl_test_offboard_ctl\" required=\"true\" clear_params=\"true\" output=\"screen\">\n+\t\t<param name=\"mode\" value=\"$(arg mode)\" />\n+\t\t<param name=\"shape\" value=\"$(arg shape)\" />\n+    </node>","path":"test_mavros/sitl_test/launch/base_node.launch","position":11,"original_position":11,"commit_id":"e0b55a35dd3d40d49c68a1ab20b0ba477557e39a","original_commit_id":"e0b55a35dd3d40d49c68a1ab20b0ba477557e39a","user":{"login":"TSC21","id":5048656,"avatar_url":"https://avatars.githubusercontent.com/u/5048656?v=3","gravatar_id":"","url":"https://api.github.com/users/TSC21","html_url":"https://github.com/TSC21","followers_url":"https://api.github.com/users/TSC21/followers","following_url":"https://api.github.com/users/TSC21/following{/other_user}","gists_url":"https://api.github.com/users/TSC21/gists{/gist_id}","starred_url":"https://api.github.com/users/TSC21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TSC21/subscriptions","organizations_url":"https://api.github.com/users/TSC21/orgs","repos_url":"https://api.github.com/users/TSC21/repos","events_url":"https://api.github.com/users/TSC21/events{/privacy}","received_events_url":"https://api.github.com/users/TSC21/received_events","type":"User","site_admin":false},"body":"Ok have to review that.","created_at":"2015-07-14T10:24:30Z","updated_at":"2015-07-14T10:24:30Z","html_url":"https://github.com/mavlink/mavros/pull/337#discussion_r34554507","pull_request_url":"https://api.github.com/repos/mavlink/mavros/pulls/337","_links":{"self":{"href":"https://api.github.com/repos/mavlink/mavros/pulls/comments/34554507"},"html":{"href":"https://github.com/mavlink/mavros/pull/337#discussion_r34554507"},"pull_request":{"href":"https://api.github.com/repos/mavlink/mavros/pulls/337"}}},"pull_request":{"url":"https://api.github.com/repos/mavlink/mavros/pulls/337","id":39710749,"html_url":"https://github.com/mavlink/mavros/pull/337","diff_url":"https://github.com/mavlink/mavros/pull/337.diff","patch_url":"https://github.com/mavlink/mavros/pull/337.patch","issue_url":"https://api.github.com/repos/mavlink/mavros/issues/337","number":337,"state":"open","locked":false,"title":"SITL tests architecture","user":{"login":"TSC21","id":5048656,"avatar_url":"https://avatars.githubusercontent.com/u/5048656?v=3","gravatar_id":"","url":"https://api.github.com/users/TSC21","html_url":"https://github.com/TSC21","followers_url":"https://api.github.com/users/TSC21/followers","following_url":"https://api.github.com/users/TSC21/following{/other_user}","gists_url":"https://api.github.com/users/TSC21/gists{/gist_id}","starred_url":"https://api.github.com/users/TSC21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TSC21/subscriptions","organizations_url":"https://api.github.com/users/TSC21/orgs","repos_url":"https://api.github.com/users/TSC21/repos","events_url":"https://api.github.com/users/TSC21/events{/privacy}","received_events_url":"https://api.github.com/users/TSC21/received_events","type":"User","site_admin":false},"body":"This is **WIP**, but already usable.\r\n\r\n* Defined test structure: 1. main node `sitl_test_node`, 2. main testing class `TestType`, 3. test classes (as `OffboardPosCtrlSquare`);\r\n* First working test routine `offboard_posctl_square`; Usage: `roslaunch test_mavros iris_empty_world_offboard_posctl_square.launch` \r\n\r\n**NOTE:** Current code only applied to PX4 SITL; not tested with APM SITL.\r\n\r\n**UPDATE:** added a launch file which integrates all the needed nodes (for OFFB POSCTL square shaped path)\r\n\r\n**UPDATE2:** Testing other test routines: Change `shape` parameter on launch file.\r\n\r\n**UPDATE3:** Added velocity setpoint control.\r\n","created_at":"2015-07-10T18:24:46Z","updated_at":"2015-07-14T10:24:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc6ac2735c26f6ecc3a794da333eb175f29cb436","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mavlink/mavros/pulls/337/commits","review_comments_url":"https://api.github.com/repos/mavlink/mavros/pulls/337/comments","review_comment_url":"https://api.github.com/repos/mavlink/mavros/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mavlink/mavros/issues/337/comments","statuses_url":"https://api.github.com/repos/mavlink/mavros/statuses/e0b55a35dd3d40d49c68a1ab20b0ba477557e39a","head":{"label":"TSC21:sitl_tests","ref":"sitl_tests","sha":"e0b55a35dd3d40d49c68a1ab20b0ba477557e39a","user":{"login":"TSC21","id":5048656,"avatar_url":"https://avatars.githubusercontent.com/u/5048656?v=3","gravatar_id":"","url":"https://api.github.com/users/TSC21","html_url":"https://github.com/TSC21","followers_url":"https://api.github.com/users/TSC21/followers","following_url":"https://api.github.com/users/TSC21/following{/other_user}","gists_url":"https://api.github.com/users/TSC21/gists{/gist_id}","starred_url":"https://api.github.com/users/TSC21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TSC21/subscriptions","organizations_url":"https://api.github.com/users/TSC21/orgs","repos_url":"https://api.github.com/users/TSC21/repos","events_url":"https://api.github.com/users/TSC21/events{/privacy}","received_events_url":"https://api.github.com/users/TSC21/received_events","type":"User","site_admin":false},"repo":{"id":22961222,"name":"mavros","full_name":"TSC21/mavros","owner":{"login":"TSC21","id":5048656,"avatar_url":"https://avatars.githubusercontent.com/u/5048656?v=3","gravatar_id":"","url":"https://api.github.com/users/TSC21","html_url":"https://github.com/TSC21","followers_url":"https://api.github.com/users/TSC21/followers","following_url":"https://api.github.com/users/TSC21/following{/other_user}","gists_url":"https://api.github.com/users/TSC21/gists{/gist_id}","starred_url":"https://api.github.com/users/TSC21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TSC21/subscriptions","organizations_url":"https://api.github.com/users/TSC21/orgs","repos_url":"https://api.github.com/users/TSC21/repos","events_url":"https://api.github.com/users/TSC21/events{/privacy}","received_events_url":"https://api.github.com/users/TSC21/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TSC21/mavros","description":"MAVLink to ROS gateway with UDP proxy for Ground Control Station","fork":true,"url":"https://api.github.com/repos/TSC21/mavros","forks_url":"https://api.github.com/repos/TSC21/mavros/forks","keys_url":"https://api.github.com/repos/TSC21/mavros/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TSC21/mavros/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TSC21/mavros/teams","hooks_url":"https://api.github.com/repos/TSC21/mavros/hooks","issue_events_url":"https://api.github.com/repos/TSC21/mavros/issues/events{/number}","events_url":"https://api.github.com/repos/TSC21/mavros/events","assignees_url":"https://api.github.com/repos/TSC21/mavros/assignees{/user}","branches_url":"https://api.github.com/repos/TSC21/mavros/branches{/branch}","tags_url":"https://api.github.com/repos/TSC21/mavros/tags","blobs_url":"https://api.github.com/repos/TSC21/mavros/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TSC21/mavros/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TSC21/mavros/git/refs{/sha}","trees_url":"https://api.github.com/repos/TSC21/mavros/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TSC21/mavros/statuses/{sha}","languages_url":"https://api.github.com/repos/TSC21/mavros/languages","stargazers_url":"https://api.github.com/repos/TSC21/mavros/stargazers","contributors_url":"https://api.github.com/repos/TSC21/mavros/contributors","subscribers_url":"https://api.github.com/repos/TSC21/mavros/subscribers","subscription_url":"https://api.github.com/repos/TSC21/mavros/subscription","commits_url":"https://api.github.com/repos/TSC21/mavros/commits{/sha}","git_commits_url":"https://api.github.com/repos/TSC21/mavros/git/commits{/sha}","comments_url":"https://api.github.com/repos/TSC21/mavros/comments{/number}","issue_comment_url":"https://api.github.com/repos/TSC21/mavros/issues/comments{/number}","contents_url":"https://api.github.com/repos/TSC21/mavros/contents/{+path}","compare_url":"https://api.github.com/repos/TSC21/mavros/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TSC21/mavros/merges","archive_url":"https://api.github.com/repos/TSC21/mavros/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TSC21/mavros/downloads","issues_url":"https://api.github.com/repos/TSC21/mavros/issues{/number}","pulls_url":"https://api.github.com/repos/TSC21/mavros/pulls{/number}","milestones_url":"https://api.github.com/repos/TSC21/mavros/milestones{/number}","notifications_url":"https://api.github.com/repos/TSC21/mavros/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TSC21/mavros/labels{/name}","releases_url":"https://api.github.com/repos/TSC21/mavros/releases{/id}","created_at":"2014-08-14T16:45:10Z","updated_at":"2014-08-14T17:53:12Z","pushed_at":"2015-07-13T17:44:59Z","git_url":"git://github.com/TSC21/mavros.git","ssh_url":"git@github.com:TSC21/mavros.git","clone_url":"https://github.com/TSC21/mavros.git","svn_url":"https://github.com/TSC21/mavros","homepage":null,"size":1715,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mavlink:master","ref":"master","sha":"1223ebc399385afb1e3341c9fc011a464437d9af","user":{"login":"mavlink","id":961247,"avatar_url":"https://avatars.githubusercontent.com/u/961247?v=3","gravatar_id":"","url":"https://api.github.com/users/mavlink","html_url":"https://github.com/mavlink","followers_url":"https://api.github.com/users/mavlink/followers","following_url":"https://api.github.com/users/mavlink/following{/other_user}","gists_url":"https://api.github.com/users/mavlink/gists{/gist_id}","starred_url":"https://api.github.com/users/mavlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavlink/subscriptions","organizations_url":"https://api.github.com/users/mavlink/orgs","repos_url":"https://api.github.com/users/mavlink/repos","events_url":"https://api.github.com/users/mavlink/events{/privacy}","received_events_url":"https://api.github.com/users/mavlink/received_events","type":"Organization","site_admin":false},"repo":{"id":15189073,"name":"mavros","full_name":"mavlink/mavros","owner":{"login":"mavlink","id":961247,"avatar_url":"https://avatars.githubusercontent.com/u/961247?v=3","gravatar_id":"","url":"https://api.github.com/users/mavlink","html_url":"https://github.com/mavlink","followers_url":"https://api.github.com/users/mavlink/followers","following_url":"https://api.github.com/users/mavlink/following{/other_user}","gists_url":"https://api.github.com/users/mavlink/gists{/gist_id}","starred_url":"https://api.github.com/users/mavlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavlink/subscriptions","organizations_url":"https://api.github.com/users/mavlink/orgs","repos_url":"https://api.github.com/users/mavlink/repos","events_url":"https://api.github.com/users/mavlink/events{/privacy}","received_events_url":"https://api.github.com/users/mavlink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mavlink/mavros","description":"MAVLink to ROS gateway with UDP proxy for Ground Control Station","fork":false,"url":"https://api.github.com/repos/mavlink/mavros","forks_url":"https://api.github.com/repos/mavlink/mavros/forks","keys_url":"https://api.github.com/repos/mavlink/mavros/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mavlink/mavros/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mavlink/mavros/teams","hooks_url":"https://api.github.com/repos/mavlink/mavros/hooks","issue_events_url":"https://api.github.com/repos/mavlink/mavros/issues/events{/number}","events_url":"https://api.github.com/repos/mavlink/mavros/events","assignees_url":"https://api.github.com/repos/mavlink/mavros/assignees{/user}","branches_url":"https://api.github.com/repos/mavlink/mavros/branches{/branch}","tags_url":"https://api.github.com/repos/mavlink/mavros/tags","blobs_url":"https://api.github.com/repos/mavlink/mavros/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mavlink/mavros/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mavlink/mavros/git/refs{/sha}","trees_url":"https://api.github.com/repos/mavlink/mavros/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mavlink/mavros/statuses/{sha}","languages_url":"https://api.github.com/repos/mavlink/mavros/languages","stargazers_url":"https://api.github.com/repos/mavlink/mavros/stargazers","contributors_url":"https://api.github.com/repos/mavlink/mavros/contributors","subscribers_url":"https://api.github.com/repos/mavlink/mavros/subscribers","subscription_url":"https://api.github.com/repos/mavlink/mavros/subscription","commits_url":"https://api.github.com/repos/mavlink/mavros/commits{/sha}","git_commits_url":"https://api.github.com/repos/mavlink/mavros/git/commits{/sha}","comments_url":"https://api.github.com/repos/mavlink/mavros/comments{/number}","issue_comment_url":"https://api.github.com/repos/mavlink/mavros/issues/comments{/number}","contents_url":"https://api.github.com/repos/mavlink/mavros/contents/{+path}","compare_url":"https://api.github.com/repos/mavlink/mavros/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mavlink/mavros/merges","archive_url":"https://api.github.com/repos/mavlink/mavros/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mavlink/mavros/downloads","issues_url":"https://api.github.com/repos/mavlink/mavros/issues{/number}","pulls_url":"https://api.github.com/repos/mavlink/mavros/pulls{/number}","milestones_url":"https://api.github.com/repos/mavlink/mavros/milestones{/number}","notifications_url":"https://api.github.com/repos/mavlink/mavros/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mavlink/mavros/labels{/name}","releases_url":"https://api.github.com/repos/mavlink/mavros/releases{/id}","created_at":"2013-12-14T16:58:11Z","updated_at":"2015-07-13T08:09:16Z","pushed_at":"2015-07-13T17:44:59Z","git_url":"git://github.com/mavlink/mavros.git","ssh_url":"git@github.com:mavlink/mavros.git","clone_url":"https://github.com/mavlink/mavros.git","svn_url":"https://github.com/mavlink/mavros","homepage":null,"size":3991,"stargazers_count":33,"watchers_count":33,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":25,"forks":56,"open_issues":25,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mavlink/mavros/pulls/337"},"html":{"href":"https://github.com/mavlink/mavros/pull/337"},"issue":{"href":"https://api.github.com/repos/mavlink/mavros/issues/337"},"comments":{"href":"https://api.github.com/repos/mavlink/mavros/issues/337/comments"},"review_comments":{"href":"https://api.github.com/repos/mavlink/mavros/pulls/337/comments"},"review_comment":{"href":"https://api.github.com/repos/mavlink/mavros/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mavlink/mavros/pulls/337/commits"},"statuses":{"href":"https://api.github.com/repos/mavlink/mavros/statuses/e0b55a35dd3d40d49c68a1ab20b0ba477557e39a"}}}}