{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/42464772","id":42464772,"diff_hunk":"@@ -253,17 +253,33 @@ case object MySQLDialect extends JdbcDialect {\n \n /**\n  * :: DeveloperApi ::\n- * Default DB2 dialect, mapping string/boolean on write to valid DB2 types.\n- * By default string, and boolean gets mapped to db2 invalid types TEXT, and BIT(1).\n+ * Default DB2 dialect, mapping string/boolean/short/byte/decimal on write and\n+ * real/decfloat/xml on read to valid DB2 types. By default string, and boolean\n+ * gets mapped to db2 invalid types TEXT, and BIT(1).\n  */\n @DeveloperApi\n case object DB2Dialect extends JdbcDialect {\n \n   override def canHandle(url: String): Boolean = url.startsWith(\"jdbc:db2\")\n \n+  override def getCatalystType(\n+      sqlType: Int, typeName: String, size: Int, md: MetadataBuilder): Option[DataType] = {\n+    if (sqlType == Types.REAL) {\n+      Option(FloatType)\n+    } else if (sqlType == Types.OTHER && typeName.equals(\"DECFLOAT\")) {\n+      Option(DecimalType(38, 18))\n+    } else if (sqlType == Types.OTHER && typeName.equals(\"XML\")) {\n+      Option(StringType)\n+    } else None\n+  }\n+\n   override def getJDBCType(dt: DataType): Option[JdbcType] = dt match {\n     case StringType => Some(JdbcType(\"CLOB\", java.sql.Types.CLOB))\n     case BooleanType => Some(JdbcType(\"CHAR(1)\", java.sql.Types.CHAR))\n+    case ShortType | ByteType => Some(JdbcType(\"SMALLINT\", java.sql.Types.SMALLINT))\n+    // DB2 maximum precision is 31. If the precision is greater than 31 map to DB2 max.\n+    case (t: DecimalType) if (t.precision > 31) =>\n+      Some(JdbcType(\"DECIMAL(31,2)\", java.sql.Types.DECIMAL))","path":"sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala","position":32,"original_position":32,"commit_id":"ec8e5467099200872092acd845f36133220d105e","original_commit_id":"ec8e5467099200872092acd845f36133220d105e","user":{"login":"rxin","id":323388,"avatar_url":"https://avatars.githubusercontent.com/u/323388?v=3","gravatar_id":"","url":"https://api.github.com/users/rxin","html_url":"https://github.com/rxin","followers_url":"https://api.github.com/users/rxin/followers","following_url":"https://api.github.com/users/rxin/following{/other_user}","gists_url":"https://api.github.com/users/rxin/gists{/gist_id}","starred_url":"https://api.github.com/users/rxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxin/subscriptions","organizations_url":"https://api.github.com/users/rxin/orgs","repos_url":"https://api.github.com/users/rxin/repos","events_url":"https://api.github.com/users/rxin/events{/privacy}","received_events_url":"https://api.github.com/users/rxin/received_events","type":"User","site_admin":false},"body":"i.e. precision lost here?\r\n","created_at":"2015-10-20T07:48:26Z","updated_at":"2015-10-20T07:48:26Z","html_url":"https://github.com/apache/spark/pull/9162#discussion_r42464772","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/9162","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/42464772"},"html":{"href":"https://github.com/apache/spark/pull/9162#discussion_r42464772"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/9162"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/9162","id":48022057,"html_url":"https://github.com/apache/spark/pull/9162","diff_url":"https://github.com/apache/spark/pull/9162.diff","patch_url":"https://github.com/apache/spark/pull/9162.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/9162","number":9162,"state":"open","locked":false,"title":"[SPARK-10655][SQL] Adding additional data type mappings to jdbc DB2dialect.","user":{"login":"sureshthalamati","id":13815184,"avatar_url":"https://avatars.githubusercontent.com/u/13815184?v=3","gravatar_id":"","url":"https://api.github.com/users/sureshthalamati","html_url":"https://github.com/sureshthalamati","followers_url":"https://api.github.com/users/sureshthalamati/followers","following_url":"https://api.github.com/users/sureshthalamati/following{/other_user}","gists_url":"https://api.github.com/users/sureshthalamati/gists{/gist_id}","starred_url":"https://api.github.com/users/sureshthalamati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sureshthalamati/subscriptions","organizations_url":"https://api.github.com/users/sureshthalamati/orgs","repos_url":"https://api.github.com/users/sureshthalamati/repos","events_url":"https://api.github.com/users/sureshthalamati/events{/privacy}","received_events_url":"https://api.github.com/users/sureshthalamati/received_events","type":"User","site_admin":false},"body":"This patch adds DB2 specific data type mappings for decfloat, real, and xml  on read and byte, short, and decimal on write to the to jdbc data source DB2 dialect. Default mapping does not work for these types when reading/writing from DB2 database.","created_at":"2015-10-19T00:12:10Z","updated_at":"2015-10-20T07:48:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d2c8e64807f44ee3b88adc8b497deaeb29a7245","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/9162/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/9162/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/9162/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/ec8e5467099200872092acd845f36133220d105e","head":{"label":"sureshthalamati:db2dialect_enhancements-spark-10655","ref":"db2dialect_enhancements-spark-10655","sha":"ec8e5467099200872092acd845f36133220d105e","user":{"login":"sureshthalamati","id":13815184,"avatar_url":"https://avatars.githubusercontent.com/u/13815184?v=3","gravatar_id":"","url":"https://api.github.com/users/sureshthalamati","html_url":"https://github.com/sureshthalamati","followers_url":"https://api.github.com/users/sureshthalamati/followers","following_url":"https://api.github.com/users/sureshthalamati/following{/other_user}","gists_url":"https://api.github.com/users/sureshthalamati/gists{/gist_id}","starred_url":"https://api.github.com/users/sureshthalamati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sureshthalamati/subscriptions","organizations_url":"https://api.github.com/users/sureshthalamati/orgs","repos_url":"https://api.github.com/users/sureshthalamati/repos","events_url":"https://api.github.com/users/sureshthalamati/events{/privacy}","received_events_url":"https://api.github.com/users/sureshthalamati/received_events","type":"User","site_admin":false},"repo":{"id":40833027,"name":"spark","full_name":"sureshthalamati/spark","owner":{"login":"sureshthalamati","id":13815184,"avatar_url":"https://avatars.githubusercontent.com/u/13815184?v=3","gravatar_id":"","url":"https://api.github.com/users/sureshthalamati","html_url":"https://github.com/sureshthalamati","followers_url":"https://api.github.com/users/sureshthalamati/followers","following_url":"https://api.github.com/users/sureshthalamati/following{/other_user}","gists_url":"https://api.github.com/users/sureshthalamati/gists{/gist_id}","starred_url":"https://api.github.com/users/sureshthalamati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sureshthalamati/subscriptions","organizations_url":"https://api.github.com/users/sureshthalamati/orgs","repos_url":"https://api.github.com/users/sureshthalamati/repos","events_url":"https://api.github.com/users/sureshthalamati/events{/privacy}","received_events_url":"https://api.github.com/users/sureshthalamati/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sureshthalamati/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/sureshthalamati/spark","forks_url":"https://api.github.com/repos/sureshthalamati/spark/forks","keys_url":"https://api.github.com/repos/sureshthalamati/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sureshthalamati/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sureshthalamati/spark/teams","hooks_url":"https://api.github.com/repos/sureshthalamati/spark/hooks","issue_events_url":"https://api.github.com/repos/sureshthalamati/spark/issues/events{/number}","events_url":"https://api.github.com/repos/sureshthalamati/spark/events","assignees_url":"https://api.github.com/repos/sureshthalamati/spark/assignees{/user}","branches_url":"https://api.github.com/repos/sureshthalamati/spark/branches{/branch}","tags_url":"https://api.github.com/repos/sureshthalamati/spark/tags","blobs_url":"https://api.github.com/repos/sureshthalamati/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sureshthalamati/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sureshthalamati/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/sureshthalamati/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sureshthalamati/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/sureshthalamati/spark/languages","stargazers_url":"https://api.github.com/repos/sureshthalamati/spark/stargazers","contributors_url":"https://api.github.com/repos/sureshthalamati/spark/contributors","subscribers_url":"https://api.github.com/repos/sureshthalamati/spark/subscribers","subscription_url":"https://api.github.com/repos/sureshthalamati/spark/subscription","commits_url":"https://api.github.com/repos/sureshthalamati/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/sureshthalamati/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/sureshthalamati/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/sureshthalamati/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/sureshthalamati/spark/contents/{+path}","compare_url":"https://api.github.com/repos/sureshthalamati/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sureshthalamati/spark/merges","archive_url":"https://api.github.com/repos/sureshthalamati/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sureshthalamati/spark/downloads","issues_url":"https://api.github.com/repos/sureshthalamati/spark/issues{/number}","pulls_url":"https://api.github.com/repos/sureshthalamati/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/sureshthalamati/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/sureshthalamati/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sureshthalamati/spark/labels{/name}","releases_url":"https://api.github.com/repos/sureshthalamati/spark/releases{/id}","created_at":"2015-08-16T18:32:24Z","updated_at":"2015-08-16T18:32:46Z","pushed_at":"2015-10-18T23:57:46Z","git_url":"git://github.com/sureshthalamati/spark.git","ssh_url":"git@github.com:sureshthalamati/spark.git","clone_url":"https://github.com/sureshthalamati/spark.git","svn_url":"https://github.com/sureshthalamati/spark","homepage":null,"size":126710,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"94c8fef296e5cdac9a93ed34acc079e51839caa7","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-10-20T05:33:40Z","pushed_at":"2015-10-20T07:45:57Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1638968,"stargazers_count":5808,"watchers_count":5808,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5414,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":318,"forks":5414,"open_issues":318,"watchers":5808,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/9162"},"html":{"href":"https://github.com/apache/spark/pull/9162"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/9162"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/9162/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/9162/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/9162/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/ec8e5467099200872092acd845f36133220d105e"}}}}