{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/28305599","id":28305599,"diff_hunk":"@@ -0,0 +1,49 @@\n+//\n+// Copyright (c) Microsoft. All rights reserved.\n+// Licensed under the MIT license. See LICENSE file in the project root for full license information.\n+//\n+\n+/*++\n+\n+Module Name:\n+\n+    pal_corefxnet.h\n+\n+Abstract:\n+\n+    Header file for functions meant to be consumed by the CoreFX Net libraries.\n+\n+--*/\n+\n+#include \"pal.h\"\n+\n+#ifndef __PAL_COREFX_NET_H__\n+#define __PAL_COREFX_NET_H__\n+\n+#ifdef  __cplusplus\n+extern \"C\" {\n+#endif\n+\n+#define COREFX_NET_SUCCESS 0x00000000\n+#define COREFX_NET_INVALID_PARAM 0xc000000d\n+\n+  \n+  struct PalIPAddress {\n+    UCHAR isIPV4;\n+    INT port;\n+    UINT scopeId;\n+    UCHAR bytes[16];\n+  };\n+\n+  PALIMPORT\n+  INT\n+  PalGetIPAddresses(const CHAR* hostName, // host name","path":"src/pal/inc/pal_corefxnet.h","position":40,"original_position":40,"commit_id":"5baca0c8572bdf3226c43ec076fa7758dc84241c","original_commit_id":"5baca0c8572bdf3226c43ec076fa7758dc84241c","user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"The naming convention used for other CoreFX helpers is to have just a simple name, without any pal prefix. We should be consistent.","created_at":"2015-04-14T07:31:44Z","updated_at":"2015-04-14T07:31:44Z","html_url":"https://github.com/dotnet/coreclr/pull/692#discussion_r28305599","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/692","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/28305599"},"html":{"href":"https://github.com/dotnet/coreclr/pull/692#discussion_r28305599"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/692"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/692","id":33141612,"html_url":"https://github.com/dotnet/coreclr/pull/692","diff_url":"https://github.com/dotnet/coreclr/pull/692.diff","patch_url":"https://github.com/dotnet/coreclr/pull/692.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/692","number":692,"state":"open","locked":false,"title":"marshaller-friendly PAL wrappers on  networking API","user":{"login":"kapilash","id":113322,"avatar_url":"https://avatars.githubusercontent.com/u/113322?v=3","gravatar_id":"","url":"https://api.github.com/users/kapilash","html_url":"https://github.com/kapilash","followers_url":"https://api.github.com/users/kapilash/followers","following_url":"https://api.github.com/users/kapilash/following{/other_user}","gists_url":"https://api.github.com/users/kapilash/gists{/gist_id}","starred_url":"https://api.github.com/users/kapilash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapilash/subscriptions","organizations_url":"https://api.github.com/users/kapilash/orgs","repos_url":"https://api.github.com/users/kapilash/repos","events_url":"https://api.github.com/users/kapilash/events{/privacy}","received_events_url":"https://api.github.com/users/kapilash/received_events","type":"User","site_admin":false},"body":"A wrapper on top of getaddrinfo that is needed for networking API. getaddrinfo is a generic API and deals with complex datastructures that are not very Marshaller friendly.\r\nThis checkin introduces the needed wrapper on top of that function. Also included is the test thereof.","created_at":"2015-04-13T07:43:35Z","updated_at":"2015-04-14T07:31:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d26704eeef4a77d6f0dc504356cdbb95afdc3c5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/692/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/692/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/692/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/5baca0c8572bdf3226c43ec076fa7758dc84241c","head":{"label":"kapilash:palnet","ref":"palnet","sha":"5baca0c8572bdf3226c43ec076fa7758dc84241c","user":{"login":"kapilash","id":113322,"avatar_url":"https://avatars.githubusercontent.com/u/113322?v=3","gravatar_id":"","url":"https://api.github.com/users/kapilash","html_url":"https://github.com/kapilash","followers_url":"https://api.github.com/users/kapilash/followers","following_url":"https://api.github.com/users/kapilash/following{/other_user}","gists_url":"https://api.github.com/users/kapilash/gists{/gist_id}","starred_url":"https://api.github.com/users/kapilash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapilash/subscriptions","organizations_url":"https://api.github.com/users/kapilash/orgs","repos_url":"https://api.github.com/users/kapilash/repos","events_url":"https://api.github.com/users/kapilash/events{/privacy}","received_events_url":"https://api.github.com/users/kapilash/received_events","type":"User","site_admin":false},"repo":{"id":32931521,"name":"coreclr","full_name":"kapilash/coreclr","owner":{"login":"kapilash","id":113322,"avatar_url":"https://avatars.githubusercontent.com/u/113322?v=3","gravatar_id":"","url":"https://api.github.com/users/kapilash","html_url":"https://github.com/kapilash","followers_url":"https://api.github.com/users/kapilash/followers","following_url":"https://api.github.com/users/kapilash/following{/other_user}","gists_url":"https://api.github.com/users/kapilash/gists{/gist_id}","starred_url":"https://api.github.com/users/kapilash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapilash/subscriptions","organizations_url":"https://api.github.com/users/kapilash/orgs","repos_url":"https://api.github.com/users/kapilash/repos","events_url":"https://api.github.com/users/kapilash/events{/privacy}","received_events_url":"https://api.github.com/users/kapilash/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kapilash/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/kapilash/coreclr","forks_url":"https://api.github.com/repos/kapilash/coreclr/forks","keys_url":"https://api.github.com/repos/kapilash/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kapilash/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kapilash/coreclr/teams","hooks_url":"https://api.github.com/repos/kapilash/coreclr/hooks","issue_events_url":"https://api.github.com/repos/kapilash/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/kapilash/coreclr/events","assignees_url":"https://api.github.com/repos/kapilash/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/kapilash/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/kapilash/coreclr/tags","blobs_url":"https://api.github.com/repos/kapilash/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kapilash/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kapilash/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/kapilash/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kapilash/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/kapilash/coreclr/languages","stargazers_url":"https://api.github.com/repos/kapilash/coreclr/stargazers","contributors_url":"https://api.github.com/repos/kapilash/coreclr/contributors","subscribers_url":"https://api.github.com/repos/kapilash/coreclr/subscribers","subscription_url":"https://api.github.com/repos/kapilash/coreclr/subscription","commits_url":"https://api.github.com/repos/kapilash/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/kapilash/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/kapilash/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/kapilash/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/kapilash/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/kapilash/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kapilash/coreclr/merges","archive_url":"https://api.github.com/repos/kapilash/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kapilash/coreclr/downloads","issues_url":"https://api.github.com/repos/kapilash/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/kapilash/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/kapilash/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/kapilash/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kapilash/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/kapilash/coreclr/releases{/id}","created_at":"2015-03-26T14:16:33Z","updated_at":"2015-04-12T15:25:46Z","pushed_at":"2015-04-13T07:17:15Z","git_url":"git://github.com/kapilash/coreclr.git","ssh_url":"git@github.com:kapilash/coreclr.git","clone_url":"https://github.com/kapilash/coreclr.git","svn_url":"https://github.com/kapilash/coreclr","homepage":"","size":27601,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"7f461ea9a8caa24f291da8eb66c4c722c466b81d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","created_at":"2015-01-30T22:10:02Z","updated_at":"2015-04-14T07:29:57Z","pushed_at":"2015-04-14T07:29:57Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"","size":36474,"stargazers_count":4143,"watchers_count":4143,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":752,"mirror_url":null,"open_issues_count":98,"forks":752,"open_issues":98,"watchers":4143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/692"},"html":{"href":"https://github.com/dotnet/coreclr/pull/692"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/692"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/692/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/692/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/692/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/5baca0c8572bdf3226c43ec076fa7758dc84241c"}}}}