{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/ripple-lib/pulls/comments/37042965","id":37042965,"diff_hunk":"@@ -62,8 +62,9 @@ function parseOutcome(tx: Object): ?Object {\n     fee: utils.common.dropsToXrp(tx.Fee),\n     balanceChanges: balanceChanges,\n     orderbookChanges: orderbookChanges,\n-    ledgerVersion: tx.ledger_index,\n-    indexInLedger: tx.meta.TransactionIndex\n+    ledgerVersion: typeof tx.ledger_index === 'number' ? tx.ledger_index : 0,","path":"src/api/ledger/parse/utils.js","position":null,"original_position":6,"commit_id":"1887b58d1b75d50d02f9c01bc617bc8cc4a3ade3","original_commit_id":"6ac1c021c4cf06eed0e3f52b5b498562cf6d1773","user":{"login":"sublimator","id":525211,"avatar_url":"https://avatars.githubusercontent.com/u/525211?v=3","gravatar_id":"","url":"https://api.github.com/users/sublimator","html_url":"https://github.com/sublimator","followers_url":"https://api.github.com/users/sublimator/followers","following_url":"https://api.github.com/users/sublimator/following{/other_user}","gists_url":"https://api.github.com/users/sublimator/gists{/gist_id}","starred_url":"https://api.github.com/users/sublimator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sublimator/subscriptions","organizations_url":"https://api.github.com/users/sublimator/orgs","repos_url":"https://api.github.com/users/sublimator/repos","events_url":"https://api.github.com/users/sublimator/events{/privacy}","received_events_url":"https://api.github.com/users/sublimator/received_events","type":"User","site_admin":false},"body":"I've only seen 'ledger_index' as a string in the ledger header (i.e.\n'ledger' cmd responses) but there might be others\n\n@rec is looking at making it consistently a number\n","created_at":"2015-08-14T01:16:00Z","updated_at":"2015-08-14T01:16:00Z","html_url":"https://github.com/ripple/ripple-lib/pull/496#discussion_r37042965","pull_request_url":"https://api.github.com/repos/ripple/ripple-lib/pulls/496","_links":{"self":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/comments/37042965"},"html":{"href":"https://github.com/ripple/ripple-lib/pull/496#discussion_r37042965"},"pull_request":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/496"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/ripple-lib/pulls/496","id":42088919,"html_url":"https://github.com/ripple/ripple-lib/pull/496","diff_url":"https://github.com/ripple/ripple-lib/pull/496.diff","patch_url":"https://github.com/ripple/ripple-lib/pull/496.patch","issue_url":"https://api.github.com/repos/ripple/ripple-lib/issues/496","number":496,"state":"open","locked":false,"title":"annotate api functions with types","user":{"login":"darkdarkdragon","id":2035357,"avatar_url":"https://avatars.githubusercontent.com/u/2035357?v=3","gravatar_id":"","url":"https://api.github.com/users/darkdarkdragon","html_url":"https://github.com/darkdarkdragon","followers_url":"https://api.github.com/users/darkdarkdragon/followers","following_url":"https://api.github.com/users/darkdarkdragon/following{/other_user}","gists_url":"https://api.github.com/users/darkdarkdragon/gists{/gist_id}","starred_url":"https://api.github.com/users/darkdarkdragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkdarkdragon/subscriptions","organizations_url":"https://api.github.com/users/darkdarkdragon/orgs","repos_url":"https://api.github.com/users/darkdarkdragon/repos","events_url":"https://api.github.com/users/darkdarkdragon/events{/privacy}","received_events_url":"https://api.github.com/users/darkdarkdragon/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-11T03:14:00Z","updated_at":"2015-08-14T01:16:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c77c91734f8b87a9f3a702867d4ce3d4a7a9f788","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ripple/ripple-lib/pulls/496/commits","review_comments_url":"https://api.github.com/repos/ripple/ripple-lib/pulls/496/comments","review_comment_url":"https://api.github.com/repos/ripple/ripple-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/ripple-lib/issues/496/comments","statuses_url":"https://api.github.com/repos/ripple/ripple-lib/statuses/1887b58d1b75d50d02f9c01bc617bc8cc4a3ade3","head":{"label":"darkdarkdragon:develop-RLJS-444-01","ref":"develop-RLJS-444-01","sha":"1887b58d1b75d50d02f9c01bc617bc8cc4a3ade3","user":{"login":"darkdarkdragon","id":2035357,"avatar_url":"https://avatars.githubusercontent.com/u/2035357?v=3","gravatar_id":"","url":"https://api.github.com/users/darkdarkdragon","html_url":"https://github.com/darkdarkdragon","followers_url":"https://api.github.com/users/darkdarkdragon/followers","following_url":"https://api.github.com/users/darkdarkdragon/following{/other_user}","gists_url":"https://api.github.com/users/darkdarkdragon/gists{/gist_id}","starred_url":"https://api.github.com/users/darkdarkdragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkdarkdragon/subscriptions","organizations_url":"https://api.github.com/users/darkdarkdragon/orgs","repos_url":"https://api.github.com/users/darkdarkdragon/repos","events_url":"https://api.github.com/users/darkdarkdragon/events{/privacy}","received_events_url":"https://api.github.com/users/darkdarkdragon/received_events","type":"User","site_admin":false},"repo":{"id":29372989,"name":"ripple-lib","full_name":"darkdarkdragon/ripple-lib","owner":{"login":"darkdarkdragon","id":2035357,"avatar_url":"https://avatars.githubusercontent.com/u/2035357?v=3","gravatar_id":"","url":"https://api.github.com/users/darkdarkdragon","html_url":"https://github.com/darkdarkdragon","followers_url":"https://api.github.com/users/darkdarkdragon/followers","following_url":"https://api.github.com/users/darkdarkdragon/following{/other_user}","gists_url":"https://api.github.com/users/darkdarkdragon/gists{/gist_id}","starred_url":"https://api.github.com/users/darkdarkdragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkdarkdragon/subscriptions","organizations_url":"https://api.github.com/users/darkdarkdragon/orgs","repos_url":"https://api.github.com/users/darkdarkdragon/repos","events_url":"https://api.github.com/users/darkdarkdragon/events{/privacy}","received_events_url":"https://api.github.com/users/darkdarkdragon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darkdarkdragon/ripple-lib","description":"A JavaScript API for interacting with Ripple in Node.js and the browser","fork":true,"url":"https://api.github.com/repos/darkdarkdragon/ripple-lib","forks_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/forks","keys_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/teams","hooks_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/hooks","issue_events_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/issues/events{/number}","events_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/events","assignees_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/assignees{/user}","branches_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/branches{/branch}","tags_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/tags","blobs_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/languages","stargazers_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/stargazers","contributors_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/contributors","subscribers_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/subscribers","subscription_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/subscription","commits_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/contents/{+path}","compare_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/merges","archive_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/downloads","issues_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/issues{/number}","pulls_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/labels{/name}","releases_url":"https://api.github.com/repos/darkdarkdragon/ripple-lib/releases{/id}","created_at":"2015-01-16T23:42:55Z","updated_at":"2015-04-23T21:59:17Z","pushed_at":"2015-08-13T21:30:08Z","git_url":"git://github.com/darkdarkdragon/ripple-lib.git","ssh_url":"git@github.com:darkdarkdragon/ripple-lib.git","clone_url":"https://github.com/darkdarkdragon/ripple-lib.git","svn_url":"https://github.com/darkdarkdragon/ripple-lib","homepage":"","size":12203,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"8c431b4ec3d1738ab54c846cabea5f28f0eaf875","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":9681561,"name":"ripple-lib","full_name":"ripple/ripple-lib","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/ripple-lib","description":"A JavaScript API for interacting with Ripple in Node.js and the browser","fork":false,"url":"https://api.github.com/repos/ripple/ripple-lib","forks_url":"https://api.github.com/repos/ripple/ripple-lib/forks","keys_url":"https://api.github.com/repos/ripple/ripple-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/ripple-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/ripple-lib/teams","hooks_url":"https://api.github.com/repos/ripple/ripple-lib/hooks","issue_events_url":"https://api.github.com/repos/ripple/ripple-lib/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/ripple-lib/events","assignees_url":"https://api.github.com/repos/ripple/ripple-lib/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/ripple-lib/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/ripple-lib/tags","blobs_url":"https://api.github.com/repos/ripple/ripple-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/ripple-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/ripple-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/ripple-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/ripple-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/ripple-lib/languages","stargazers_url":"https://api.github.com/repos/ripple/ripple-lib/stargazers","contributors_url":"https://api.github.com/repos/ripple/ripple-lib/contributors","subscribers_url":"https://api.github.com/repos/ripple/ripple-lib/subscribers","subscription_url":"https://api.github.com/repos/ripple/ripple-lib/subscription","commits_url":"https://api.github.com/repos/ripple/ripple-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/ripple-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/ripple-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/ripple-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/ripple-lib/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/ripple-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/ripple-lib/merges","archive_url":"https://api.github.com/repos/ripple/ripple-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/ripple-lib/downloads","issues_url":"https://api.github.com/repos/ripple/ripple-lib/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/ripple-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/ripple-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/ripple-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/ripple-lib/labels{/name}","releases_url":"https://api.github.com/repos/ripple/ripple-lib/releases{/id}","created_at":"2013-04-25T21:17:19Z","updated_at":"2015-08-12T06:19:37Z","pushed_at":"2015-08-13T23:33:12Z","git_url":"git://github.com/ripple/ripple-lib.git","ssh_url":"git@github.com:ripple/ripple-lib.git","clone_url":"https://github.com/ripple/ripple-lib.git","svn_url":"https://github.com/ripple/ripple-lib","homepage":"","size":18820,"stargazers_count":419,"watchers_count":419,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":147,"mirror_url":null,"open_issues_count":20,"forks":147,"open_issues":20,"watchers":419,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/496"},"html":{"href":"https://github.com/ripple/ripple-lib/pull/496"},"issue":{"href":"https://api.github.com/repos/ripple/ripple-lib/issues/496"},"comments":{"href":"https://api.github.com/repos/ripple/ripple-lib/issues/496/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/496/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/496/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/ripple-lib/statuses/1887b58d1b75d50d02f9c01bc617bc8cc4a3ade3"}}}}