{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments/24104969","id":24104969,"diff_hunk":"@@ -71,6 +71,37 @@ module private PrintUtilities =\n         | (x:: rest) -> [ resultFunction x (layoutFunction x -- leftL (match rest.Length with 1 -> FSComp.SR.nicePrintOtherOverloads1() | n -> FSComp.SR.nicePrintOtherOverloadsN(n))) ] \n         | _ -> []\n \n+    /// Layout a reference to a type \n+    let layoutTyconRefImpl isAttribute (denv: DisplayEnv) (tcref:TyconRef) = \n+        let demangled = \n+            let name =\n+                if denv.includeStaticParametersInTypeNames then \n+                    tcref.DisplayNameWithStaticParameters \n+                elif tcref.DisplayName = tcref.DisplayNameWithStaticParameters then\n+                    tcref.DisplayName // has no static params\n+                else\n+                    tcref.DisplayName+\"<...>\" // shorten\n+            if isAttribute then \n+                defaultArg (String.tryDropSuffix name \"Attribute\") name \n+            else name\n+        let tyconTextL = wordL demangled\n+        if denv.shortTypeNames then \n+            tyconTextL\n+        else\n+            let path = demangledPathOfCompPath tcref.CompilationPath\n+            let path =","path":"src/fsharp/NicePrint.fs","position":22,"original_position":22,"commit_id":"adb4fa29eb335b24780c0f311db127ff12882ec1","original_commit_id":"a8972fe06e181077f1dcfa572b8164b567ac25b8","user":{"login":"dsyme","id":7204669,"avatar_url":"https://avatars.githubusercontent.com/u/7204669?v=3","gravatar_id":"","url":"https://api.github.com/users/dsyme","html_url":"https://github.com/dsyme","followers_url":"https://api.github.com/users/dsyme/followers","following_url":"https://api.github.com/users/dsyme/following{/other_user}","gists_url":"https://api.github.com/users/dsyme/gists{/gist_id}","starred_url":"https://api.github.com/users/dsyme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsyme/subscriptions","organizations_url":"https://api.github.com/users/dsyme/orgs","repos_url":"https://api.github.com/users/dsyme/repos","events_url":"https://api.github.com/users/dsyme/events{/privacy}","received_events_url":"https://api.github.com/users/dsyme/received_events","type":"User","site_admin":false},"body":"Yes, that's fine.  FWIW there is plenty of shadowing in the compiler in any case","created_at":"2015-02-04T18:13:46Z","updated_at":"2015-02-04T18:13:46Z","html_url":"https://github.com/Microsoft/visualfsharp/pull/192#discussion_r24104969","pull_request_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/192","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments/24104969"},"html":{"href":"https://github.com/Microsoft/visualfsharp/pull/192#discussion_r24104969"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/192"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/192","id":28423110,"html_url":"https://github.com/Microsoft/visualfsharp/pull/192","diff_url":"https://github.com/Microsoft/visualfsharp/pull/192.diff","patch_url":"https://github.com/Microsoft/visualfsharp/pull/192.patch","issue_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/192","number":192,"state":"open","locked":false,"title":"Print ParamArray attribute instead of 'params'","user":{"login":"dungpa","id":941060,"avatar_url":"https://avatars.githubusercontent.com/u/941060?v=3","gravatar_id":"","url":"https://api.github.com/users/dungpa","html_url":"https://github.com/dungpa","followers_url":"https://api.github.com/users/dungpa/followers","following_url":"https://api.github.com/users/dungpa/following{/other_user}","gists_url":"https://api.github.com/users/dungpa/gists{/gist_id}","starred_url":"https://api.github.com/users/dungpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dungpa/subscriptions","organizations_url":"https://api.github.com/users/dungpa/orgs","repos_url":"https://api.github.com/users/dungpa/repos","events_url":"https://api.github.com/users/dungpa/events{/privacy}","received_events_url":"https://api.github.com/users/dungpa/received_events","type":"User","site_admin":false},"body":"Fixed #109.\r\n\r\nPrint `System.ParamArray` attribute to ensure that generated signature is valid F# code.\r\n\r\nA few questions:\r\n\r\n - Is there any better approach than using `attrib_ParamArrayAttribute`? The attribute doesn't seem to be present in symbol metadata (there is only `isParamArray` flag in most cases).\r\n - Should intellisense be updated to use `ParamArray` attribute for consistency?","created_at":"2015-01-31T23:34:10Z","updated_at":"2015-02-04T18:13:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23edaf14a7ce0af6e4074b885599f9ea2e1161c5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/192/commits","review_comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/192/comments","review_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/192/comments","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/adb4fa29eb335b24780c0f311db127ff12882ec1","head":{"label":"dungpa:signature-printing","ref":"signature-printing","sha":"adb4fa29eb335b24780c0f311db127ff12882ec1","user":{"login":"dungpa","id":941060,"avatar_url":"https://avatars.githubusercontent.com/u/941060?v=3","gravatar_id":"","url":"https://api.github.com/users/dungpa","html_url":"https://github.com/dungpa","followers_url":"https://api.github.com/users/dungpa/followers","following_url":"https://api.github.com/users/dungpa/following{/other_user}","gists_url":"https://api.github.com/users/dungpa/gists{/gist_id}","starred_url":"https://api.github.com/users/dungpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dungpa/subscriptions","organizations_url":"https://api.github.com/users/dungpa/orgs","repos_url":"https://api.github.com/users/dungpa/repos","events_url":"https://api.github.com/users/dungpa/events{/privacy}","received_events_url":"https://api.github.com/users/dungpa/received_events","type":"User","site_admin":false},"repo":{"id":29215748,"name":"visualfsharp","full_name":"dungpa/visualfsharp","owner":{"login":"dungpa","id":941060,"avatar_url":"https://avatars.githubusercontent.com/u/941060?v=3","gravatar_id":"","url":"https://api.github.com/users/dungpa","html_url":"https://github.com/dungpa","followers_url":"https://api.github.com/users/dungpa/followers","following_url":"https://api.github.com/users/dungpa/following{/other_user}","gists_url":"https://api.github.com/users/dungpa/gists{/gist_id}","starred_url":"https://api.github.com/users/dungpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dungpa/subscriptions","organizations_url":"https://api.github.com/users/dungpa/orgs","repos_url":"https://api.github.com/users/dungpa/repos","events_url":"https://api.github.com/users/dungpa/events{/privacy}","received_events_url":"https://api.github.com/users/dungpa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dungpa/visualfsharp","description":"The Visual F# compiler and tools","fork":true,"url":"https://api.github.com/repos/dungpa/visualfsharp","forks_url":"https://api.github.com/repos/dungpa/visualfsharp/forks","keys_url":"https://api.github.com/repos/dungpa/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dungpa/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dungpa/visualfsharp/teams","hooks_url":"https://api.github.com/repos/dungpa/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/dungpa/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/dungpa/visualfsharp/events","assignees_url":"https://api.github.com/repos/dungpa/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/dungpa/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/dungpa/visualfsharp/tags","blobs_url":"https://api.github.com/repos/dungpa/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dungpa/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dungpa/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/dungpa/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dungpa/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/dungpa/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/dungpa/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/dungpa/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/dungpa/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/dungpa/visualfsharp/subscription","commits_url":"https://api.github.com/repos/dungpa/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/dungpa/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/dungpa/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/dungpa/visualfsharp/issues/comments/{number}","contents_url":"https://api.github.com/repos/dungpa/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/dungpa/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dungpa/visualfsharp/merges","archive_url":"https://api.github.com/repos/dungpa/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dungpa/visualfsharp/downloads","issues_url":"https://api.github.com/repos/dungpa/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/dungpa/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/dungpa/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/dungpa/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dungpa/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/dungpa/visualfsharp/releases{/id}","created_at":"2015-01-13T22:56:24Z","updated_at":"2015-01-31T23:42:51Z","pushed_at":"2015-02-04T12:53:53Z","git_url":"git://github.com/dungpa/visualfsharp.git","ssh_url":"git@github.com:dungpa/visualfsharp.git","clone_url":"https://github.com/dungpa/visualfsharp.git","svn_url":"https://github.com/dungpa/visualfsharp","homepage":null,"size":48059,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"fsharp4"}},"base":{"label":"Microsoft:fsharp4","ref":"fsharp4","sha":"1f7f85a97fa3696216203580577a242852966c97","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":29048891,"name":"visualfsharp","full_name":"Microsoft/visualfsharp","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/visualfsharp","description":"The Visual F# compiler and tools","fork":false,"url":"https://api.github.com/repos/Microsoft/visualfsharp","forks_url":"https://api.github.com/repos/Microsoft/visualfsharp/forks","keys_url":"https://api.github.com/repos/Microsoft/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/visualfsharp/teams","hooks_url":"https://api.github.com/repos/Microsoft/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/visualfsharp/events","assignees_url":"https://api.github.com/repos/Microsoft/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/tags","blobs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/Microsoft/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscription","commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/comments/{number}","contents_url":"https://api.github.com/repos/Microsoft/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/visualfsharp/merges","archive_url":"https://api.github.com/repos/Microsoft/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/visualfsharp/downloads","issues_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/visualfsharp/releases{/id}","created_at":"2015-01-10T05:58:43Z","updated_at":"2015-02-04T18:13:28Z","pushed_at":"2015-02-03T19:33:24Z","git_url":"git://github.com/Microsoft/visualfsharp.git","ssh_url":"git@github.com:Microsoft/visualfsharp.git","clone_url":"https://github.com/Microsoft/visualfsharp.git","svn_url":"https://github.com/Microsoft/visualfsharp","homepage":null,"size":50760,"stargazers_count":271,"watchers_count":271,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":116,"forks":40,"open_issues":116,"watchers":271,"default_branch":"fsharp4"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/192"},"html":{"href":"https://github.com/Microsoft/visualfsharp/pull/192"},"issue":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/192"},"comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/192/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/192/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/192/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/adb4fa29eb335b24780c0f311db127ff12882ec1"}}}}