{"action":"created","comment":{"url":"https://api.github.com/repos/thomas-p-wilson/jtwig/pulls/comments/27636736","id":27636736,"diff_hunk":"@@ -207,13 +223,13 @@ public static boolean isNumeric(Object obj) {\n     public static boolean areLooselyEqual(Object a, Object b) {\n         // Using the same behaviour for Jtwig as we retrieve in twig\n         if (a == null) {\n-            return b == null || (isBoolean(b) && !toBoolean(b));\n+            return b == null || isEmptyString(b) || (isBoolean(b) && !toBoolean(b));\n         }\n         if (b == null) {\n-            return isBoolean(a) && !toBoolean(a);\n+            return isEmptyString(a) || isBoolean(a) && !toBoolean(a);\n         }\n         if (isBoolean(a) || isBoolean(b)) {\n-            return toBoolean(a) == toBoolean(b);\n+            return Objects.equals(toBoolean(a), toBoolean(b));","path":"jtwig-core/src/main/java/org/jtwig/util/TypeUtil.java","position":43,"original_position":43,"commit_id":"6d09bcce58f602f390712b47ae175e42a8dc5b81","original_commit_id":"6d09bcce58f602f390712b47ae175e42a8dc5b81","user":{"login":"stefanmeissner","id":1850247,"avatar_url":"https://avatars.githubusercontent.com/u/1850247?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanmeissner","html_url":"https://github.com/stefanmeissner","followers_url":"https://api.github.com/users/stefanmeissner/followers","following_url":"https://api.github.com/users/stefanmeissner/following{/other_user}","gists_url":"https://api.github.com/users/stefanmeissner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanmeissner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanmeissner/subscriptions","organizations_url":"https://api.github.com/users/stefanmeissner/orgs","repos_url":"https://api.github.com/users/stefanmeissner/repos","events_url":"https://api.github.com/users/stefanmeissner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanmeissner/received_events","type":"User","site_admin":false},"body":"I guess there are several other things to change. I'll let FindBugs have a run or maybe you know some other tools to check for clean code.","created_at":"2015-04-02T07:22:15Z","updated_at":"2015-04-02T07:22:15Z","html_url":"https://github.com/thomas-p-wilson/jtwig/pull/1#discussion_r27636736","pull_request_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/thomas-p-wilson/jtwig/pulls/comments/27636736"},"html":{"href":"https://github.com/thomas-p-wilson/jtwig/pull/1#discussion_r27636736"},"pull_request":{"href":"https://api.github.com/repos/thomas-p-wilson/jtwig/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/thomas-p-wilson/jtwig/pulls/1","id":32397884,"html_url":"https://github.com/thomas-p-wilson/jtwig/pull/1","diff_url":"https://github.com/thomas-p-wilson/jtwig/pull/1.diff","patch_url":"https://github.com/thomas-p-wilson/jtwig/pull/1.patch","issue_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/issues/1","number":1,"state":"open","locked":false,"title":"Pr 289","user":{"login":"stefanmeissner","id":1850247,"avatar_url":"https://avatars.githubusercontent.com/u/1850247?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanmeissner","html_url":"https://github.com/stefanmeissner","followers_url":"https://api.github.com/users/stefanmeissner/followers","following_url":"https://api.github.com/users/stefanmeissner/following{/other_user}","gists_url":"https://api.github.com/users/stefanmeissner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanmeissner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanmeissner/subscriptions","organizations_url":"https://api.github.com/users/stefanmeissner/orgs","repos_url":"https://api.github.com/users/stefanmeissner/repos","events_url":"https://api.github.com/users/stefanmeissner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanmeissner/received_events","type":"User","site_admin":false},"body":"Please have a look if this is sufficient.\r\n\r\nDon't merge my artifact id's. I changed them for testing only.","created_at":"2015-04-01T08:23:32Z","updated_at":"2015-04-02T07:22:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a8dc3a86d587fc50b85b8a2b0d2ae8bc1bd75da","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/pulls/1/commits","review_comments_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/pulls/1/comments","review_comment_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/issues/1/comments","statuses_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/statuses/6d09bcce58f602f390712b47ae175e42a8dc5b81","head":{"label":"stefanmeissner:PR-289","ref":"PR-289","sha":"6d09bcce58f602f390712b47ae175e42a8dc5b81","user":{"login":"stefanmeissner","id":1850247,"avatar_url":"https://avatars.githubusercontent.com/u/1850247?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanmeissner","html_url":"https://github.com/stefanmeissner","followers_url":"https://api.github.com/users/stefanmeissner/followers","following_url":"https://api.github.com/users/stefanmeissner/following{/other_user}","gists_url":"https://api.github.com/users/stefanmeissner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanmeissner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanmeissner/subscriptions","organizations_url":"https://api.github.com/users/stefanmeissner/orgs","repos_url":"https://api.github.com/users/stefanmeissner/repos","events_url":"https://api.github.com/users/stefanmeissner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanmeissner/received_events","type":"User","site_admin":false},"repo":{"id":30093326,"name":"jtwig","full_name":"stefanmeissner/jtwig","owner":{"login":"stefanmeissner","id":1850247,"avatar_url":"https://avatars.githubusercontent.com/u/1850247?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanmeissner","html_url":"https://github.com/stefanmeissner","followers_url":"https://api.github.com/users/stefanmeissner/followers","following_url":"https://api.github.com/users/stefanmeissner/following{/other_user}","gists_url":"https://api.github.com/users/stefanmeissner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanmeissner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanmeissner/subscriptions","organizations_url":"https://api.github.com/users/stefanmeissner/orgs","repos_url":"https://api.github.com/users/stefanmeissner/repos","events_url":"https://api.github.com/users/stefanmeissner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanmeissner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefanmeissner/jtwig","description":"Java modern template engine","fork":true,"url":"https://api.github.com/repos/stefanmeissner/jtwig","forks_url":"https://api.github.com/repos/stefanmeissner/jtwig/forks","keys_url":"https://api.github.com/repos/stefanmeissner/jtwig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefanmeissner/jtwig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefanmeissner/jtwig/teams","hooks_url":"https://api.github.com/repos/stefanmeissner/jtwig/hooks","issue_events_url":"https://api.github.com/repos/stefanmeissner/jtwig/issues/events{/number}","events_url":"https://api.github.com/repos/stefanmeissner/jtwig/events","assignees_url":"https://api.github.com/repos/stefanmeissner/jtwig/assignees{/user}","branches_url":"https://api.github.com/repos/stefanmeissner/jtwig/branches{/branch}","tags_url":"https://api.github.com/repos/stefanmeissner/jtwig/tags","blobs_url":"https://api.github.com/repos/stefanmeissner/jtwig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefanmeissner/jtwig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefanmeissner/jtwig/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefanmeissner/jtwig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefanmeissner/jtwig/statuses/{sha}","languages_url":"https://api.github.com/repos/stefanmeissner/jtwig/languages","stargazers_url":"https://api.github.com/repos/stefanmeissner/jtwig/stargazers","contributors_url":"https://api.github.com/repos/stefanmeissner/jtwig/contributors","subscribers_url":"https://api.github.com/repos/stefanmeissner/jtwig/subscribers","subscription_url":"https://api.github.com/repos/stefanmeissner/jtwig/subscription","commits_url":"https://api.github.com/repos/stefanmeissner/jtwig/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefanmeissner/jtwig/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefanmeissner/jtwig/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefanmeissner/jtwig/issues/comments{/number}","contents_url":"https://api.github.com/repos/stefanmeissner/jtwig/contents/{+path}","compare_url":"https://api.github.com/repos/stefanmeissner/jtwig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefanmeissner/jtwig/merges","archive_url":"https://api.github.com/repos/stefanmeissner/jtwig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefanmeissner/jtwig/downloads","issues_url":"https://api.github.com/repos/stefanmeissner/jtwig/issues{/number}","pulls_url":"https://api.github.com/repos/stefanmeissner/jtwig/pulls{/number}","milestones_url":"https://api.github.com/repos/stefanmeissner/jtwig/milestones{/number}","notifications_url":"https://api.github.com/repos/stefanmeissner/jtwig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefanmeissner/jtwig/labels{/name}","releases_url":"https://api.github.com/repos/stefanmeissner/jtwig/releases{/id}","created_at":"2015-01-30T22:21:43Z","updated_at":"2015-03-24T09:09:54Z","pushed_at":"2015-04-01T08:13:57Z","git_url":"git://github.com/stefanmeissner/jtwig.git","ssh_url":"git@github.com:stefanmeissner/jtwig.git","clone_url":"https://github.com/stefanmeissner/jtwig.git","svn_url":"https://github.com/stefanmeissner/jtwig","homepage":"http://jtwig.org/","size":1933,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thomas-p-wilson:feature-extensions","ref":"feature-extensions","sha":"4b7565d1cd888cce9752a37c7b1ad7b5c05004bd","user":{"login":"thomas-p-wilson","id":597691,"avatar_url":"https://avatars.githubusercontent.com/u/597691?v=3","gravatar_id":"","url":"https://api.github.com/users/thomas-p-wilson","html_url":"https://github.com/thomas-p-wilson","followers_url":"https://api.github.com/users/thomas-p-wilson/followers","following_url":"https://api.github.com/users/thomas-p-wilson/following{/other_user}","gists_url":"https://api.github.com/users/thomas-p-wilson/gists{/gist_id}","starred_url":"https://api.github.com/users/thomas-p-wilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomas-p-wilson/subscriptions","organizations_url":"https://api.github.com/users/thomas-p-wilson/orgs","repos_url":"https://api.github.com/users/thomas-p-wilson/repos","events_url":"https://api.github.com/users/thomas-p-wilson/events{/privacy}","received_events_url":"https://api.github.com/users/thomas-p-wilson/received_events","type":"User","site_admin":false},"repo":{"id":23671731,"name":"jtwig","full_name":"thomas-p-wilson/jtwig","owner":{"login":"thomas-p-wilson","id":597691,"avatar_url":"https://avatars.githubusercontent.com/u/597691?v=3","gravatar_id":"","url":"https://api.github.com/users/thomas-p-wilson","html_url":"https://github.com/thomas-p-wilson","followers_url":"https://api.github.com/users/thomas-p-wilson/followers","following_url":"https://api.github.com/users/thomas-p-wilson/following{/other_user}","gists_url":"https://api.github.com/users/thomas-p-wilson/gists{/gist_id}","starred_url":"https://api.github.com/users/thomas-p-wilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomas-p-wilson/subscriptions","organizations_url":"https://api.github.com/users/thomas-p-wilson/orgs","repos_url":"https://api.github.com/users/thomas-p-wilson/repos","events_url":"https://api.github.com/users/thomas-p-wilson/events{/privacy}","received_events_url":"https://api.github.com/users/thomas-p-wilson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thomas-p-wilson/jtwig","description":"Java modern template engine","fork":true,"url":"https://api.github.com/repos/thomas-p-wilson/jtwig","forks_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/forks","keys_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/teams","hooks_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/hooks","issue_events_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/issues/events{/number}","events_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/events","assignees_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/assignees{/user}","branches_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/branches{/branch}","tags_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/tags","blobs_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/statuses/{sha}","languages_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/languages","stargazers_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/stargazers","contributors_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/contributors","subscribers_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/subscribers","subscription_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/subscription","commits_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/issues/comments{/number}","contents_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/contents/{+path}","compare_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/merges","archive_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/downloads","issues_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/issues{/number}","pulls_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/pulls{/number}","milestones_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/milestones{/number}","notifications_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/labels{/name}","releases_url":"https://api.github.com/repos/thomas-p-wilson/jtwig/releases{/id}","created_at":"2014-09-04T17:14:02Z","updated_at":"2015-03-06T14:33:40Z","pushed_at":"2015-04-01T08:23:34Z","git_url":"git://github.com/thomas-p-wilson/jtwig.git","ssh_url":"git@github.com:thomas-p-wilson/jtwig.git","clone_url":"https://github.com/thomas-p-wilson/jtwig.git","svn_url":"https://github.com/thomas-p-wilson/jtwig","homepage":"http://jtwig.org/","size":2575,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thomas-p-wilson/jtwig/pulls/1"},"html":{"href":"https://github.com/thomas-p-wilson/jtwig/pull/1"},"issue":{"href":"https://api.github.com/repos/thomas-p-wilson/jtwig/issues/1"},"comments":{"href":"https://api.github.com/repos/thomas-p-wilson/jtwig/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/thomas-p-wilson/jtwig/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/thomas-p-wilson/jtwig/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thomas-p-wilson/jtwig/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/thomas-p-wilson/jtwig/statuses/6d09bcce58f602f390712b47ae175e42a8dc5b81"}}}}