{"action":"created","comment":{"url":"https://api.github.com/repos/crewapp/crewapp/pulls/comments/28196283","id":28196283,"diff_hunk":"@@ -12,18 +12,33 @@ var orm = new Sequelize(dbconfig.database, dbconfig.username, dbconfig.password,\n \n var Messages = orm.define('messages', {\n   message: Sequelize.TEXT,\n-  name: Sequelize.STRING\n+  name: Sequelize.STRING,\n+  groupID: Sequelize.STRING\n });\n \n var Users = orm.define('users', {\n-  name: Sequelize.STRING\n+  name: Sequelize.STRING,\n+  password: Sequelize.STRING,\n+  groupID: Sequelize.STRING\n+});\n+\n+var Groups = orm.define('groups', {\n+  groupID: Sequelize.STRING","path":"server/database/config.js","position":17,"original_position":17,"commit_id":"0cab937c46fdb923e443b7372371ce60088e9c1a","original_commit_id":"0cab937c46fdb923e443b7372371ce60088e9c1a","user":{"login":"rkho","id":4451985,"avatar_url":"https://avatars.githubusercontent.com/u/4451985?v=3","gravatar_id":"","url":"https://api.github.com/users/rkho","html_url":"https://github.com/rkho","followers_url":"https://api.github.com/users/rkho/followers","following_url":"https://api.github.com/users/rkho/following{/other_user}","gists_url":"https://api.github.com/users/rkho/gists{/gist_id}","starred_url":"https://api.github.com/users/rkho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkho/subscriptions","organizations_url":"https://api.github.com/users/rkho/orgs","repos_url":"https://api.github.com/users/rkho/repos","events_url":"https://api.github.com/users/rkho/events{/privacy}","received_events_url":"https://api.github.com/users/rkho/received_events","type":"User","site_admin":false},"body":"I don't like how groupID is a string, which implies it should be the name of the group, yet ID is used as a primary key for other tables as a number to reference other things. This is weird to me.","created_at":"2015-04-11T16:29:32Z","updated_at":"2015-04-11T16:29:32Z","html_url":"https://github.com/crewapp/crewapp/pull/84#discussion_r28196283","pull_request_url":"https://api.github.com/repos/crewapp/crewapp/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/crewapp/crewapp/pulls/comments/28196283"},"html":{"href":"https://github.com/crewapp/crewapp/pull/84#discussion_r28196283"},"pull_request":{"href":"https://api.github.com/repos/crewapp/crewapp/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/crewapp/crewapp/pulls/84","id":33104671,"html_url":"https://github.com/crewapp/crewapp/pull/84","diff_url":"https://github.com/crewapp/crewapp/pull/84.diff","patch_url":"https://github.com/crewapp/crewapp/pull/84.patch","issue_url":"https://api.github.com/repos/crewapp/crewapp/issues/84","number":84,"state":"open","locked":false,"title":"closes #81: db and config for groups/auth","user":{"login":"koziscool","id":1393010,"avatar_url":"https://avatars.githubusercontent.com/u/1393010?v=3","gravatar_id":"","url":"https://api.github.com/users/koziscool","html_url":"https://github.com/koziscool","followers_url":"https://api.github.com/users/koziscool/followers","following_url":"https://api.github.com/users/koziscool/following{/other_user}","gists_url":"https://api.github.com/users/koziscool/gists{/gist_id}","starred_url":"https://api.github.com/users/koziscool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koziscool/subscriptions","organizations_url":"https://api.github.com/users/koziscool/orgs","repos_url":"https://api.github.com/users/koziscool/repos","events_url":"https://api.github.com/users/koziscool/events{/privacy}","received_events_url":"https://api.github.com/users/koziscool/received_events","type":"User","site_admin":false},"body":"\r\nRoutes.js code is still commented out.  Still needs to check for auth in routes.  Has bcrypt functionality for new user and login in /api/addnewuser and /api/login.\r\n\r\nNew Groups table in schema.  idGroups column added for Users and Messages.\r\n","created_at":"2015-04-11T15:14:33Z","updated_at":"2015-04-11T16:29:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c5ac816c1f1f8c6a2ea30110a79fce4cee968fb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crewapp/crewapp/pulls/84/commits","review_comments_url":"https://api.github.com/repos/crewapp/crewapp/pulls/84/comments","review_comment_url":"https://api.github.com/repos/crewapp/crewapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crewapp/crewapp/issues/84/comments","statuses_url":"https://api.github.com/repos/crewapp/crewapp/statuses/0cab937c46fdb923e443b7372371ce60088e9c1a","head":{"label":"koziscool:crewapp/crewapp#81","ref":"crewapp/crewapp#81","sha":"0cab937c46fdb923e443b7372371ce60088e9c1a","user":{"login":"koziscool","id":1393010,"avatar_url":"https://avatars.githubusercontent.com/u/1393010?v=3","gravatar_id":"","url":"https://api.github.com/users/koziscool","html_url":"https://github.com/koziscool","followers_url":"https://api.github.com/users/koziscool/followers","following_url":"https://api.github.com/users/koziscool/following{/other_user}","gists_url":"https://api.github.com/users/koziscool/gists{/gist_id}","starred_url":"https://api.github.com/users/koziscool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koziscool/subscriptions","organizations_url":"https://api.github.com/users/koziscool/orgs","repos_url":"https://api.github.com/users/koziscool/repos","events_url":"https://api.github.com/users/koziscool/events{/privacy}","received_events_url":"https://api.github.com/users/koziscool/received_events","type":"User","site_admin":false},"repo":{"id":33391637,"name":"crewapp","full_name":"koziscool/crewapp","owner":{"login":"koziscool","id":1393010,"avatar_url":"https://avatars.githubusercontent.com/u/1393010?v=3","gravatar_id":"","url":"https://api.github.com/users/koziscool","html_url":"https://github.com/koziscool","followers_url":"https://api.github.com/users/koziscool/followers","following_url":"https://api.github.com/users/koziscool/following{/other_user}","gists_url":"https://api.github.com/users/koziscool/gists{/gist_id}","starred_url":"https://api.github.com/users/koziscool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koziscool/subscriptions","organizations_url":"https://api.github.com/users/koziscool/orgs","repos_url":"https://api.github.com/users/koziscool/repos","events_url":"https://api.github.com/users/koziscool/events{/privacy}","received_events_url":"https://api.github.com/users/koziscool/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/koziscool/crewapp","description":"The crew chooses you!","fork":true,"url":"https://api.github.com/repos/koziscool/crewapp","forks_url":"https://api.github.com/repos/koziscool/crewapp/forks","keys_url":"https://api.github.com/repos/koziscool/crewapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koziscool/crewapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koziscool/crewapp/teams","hooks_url":"https://api.github.com/repos/koziscool/crewapp/hooks","issue_events_url":"https://api.github.com/repos/koziscool/crewapp/issues/events{/number}","events_url":"https://api.github.com/repos/koziscool/crewapp/events","assignees_url":"https://api.github.com/repos/koziscool/crewapp/assignees{/user}","branches_url":"https://api.github.com/repos/koziscool/crewapp/branches{/branch}","tags_url":"https://api.github.com/repos/koziscool/crewapp/tags","blobs_url":"https://api.github.com/repos/koziscool/crewapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koziscool/crewapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koziscool/crewapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/koziscool/crewapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koziscool/crewapp/statuses/{sha}","languages_url":"https://api.github.com/repos/koziscool/crewapp/languages","stargazers_url":"https://api.github.com/repos/koziscool/crewapp/stargazers","contributors_url":"https://api.github.com/repos/koziscool/crewapp/contributors","subscribers_url":"https://api.github.com/repos/koziscool/crewapp/subscribers","subscription_url":"https://api.github.com/repos/koziscool/crewapp/subscription","commits_url":"https://api.github.com/repos/koziscool/crewapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/koziscool/crewapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/koziscool/crewapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/koziscool/crewapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/koziscool/crewapp/contents/{+path}","compare_url":"https://api.github.com/repos/koziscool/crewapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koziscool/crewapp/merges","archive_url":"https://api.github.com/repos/koziscool/crewapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koziscool/crewapp/downloads","issues_url":"https://api.github.com/repos/koziscool/crewapp/issues{/number}","pulls_url":"https://api.github.com/repos/koziscool/crewapp/pulls{/number}","milestones_url":"https://api.github.com/repos/koziscool/crewapp/milestones{/number}","notifications_url":"https://api.github.com/repos/koziscool/crewapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koziscool/crewapp/labels{/name}","releases_url":"https://api.github.com/repos/koziscool/crewapp/releases{/id}","created_at":"2015-04-04T02:31:23Z","updated_at":"2015-04-10T22:40:10Z","pushed_at":"2015-04-11T15:11:47Z","git_url":"git://github.com/koziscool/crewapp.git","ssh_url":"git@github.com:koziscool/crewapp.git","clone_url":"https://github.com/koziscool/crewapp.git","svn_url":"https://github.com/koziscool/crewapp","homepage":null,"size":248,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crewapp:master","ref":"master","sha":"e885308e318edcf5ffd4b437c5f87fb4f463a0b6","user":{"login":"crewapp","id":11762284,"avatar_url":"https://avatars.githubusercontent.com/u/11762284?v=3","gravatar_id":"","url":"https://api.github.com/users/crewapp","html_url":"https://github.com/crewapp","followers_url":"https://api.github.com/users/crewapp/followers","following_url":"https://api.github.com/users/crewapp/following{/other_user}","gists_url":"https://api.github.com/users/crewapp/gists{/gist_id}","starred_url":"https://api.github.com/users/crewapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crewapp/subscriptions","organizations_url":"https://api.github.com/users/crewapp/orgs","repos_url":"https://api.github.com/users/crewapp/repos","events_url":"https://api.github.com/users/crewapp/events{/privacy}","received_events_url":"https://api.github.com/users/crewapp/received_events","type":"Organization","site_admin":false},"repo":{"id":33387866,"name":"crewapp","full_name":"crewapp/crewapp","owner":{"login":"crewapp","id":11762284,"avatar_url":"https://avatars.githubusercontent.com/u/11762284?v=3","gravatar_id":"","url":"https://api.github.com/users/crewapp","html_url":"https://github.com/crewapp","followers_url":"https://api.github.com/users/crewapp/followers","following_url":"https://api.github.com/users/crewapp/following{/other_user}","gists_url":"https://api.github.com/users/crewapp/gists{/gist_id}","starred_url":"https://api.github.com/users/crewapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crewapp/subscriptions","organizations_url":"https://api.github.com/users/crewapp/orgs","repos_url":"https://api.github.com/users/crewapp/repos","events_url":"https://api.github.com/users/crewapp/events{/privacy}","received_events_url":"https://api.github.com/users/crewapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crewapp/crewapp","description":"The crew chooses you!","fork":false,"url":"https://api.github.com/repos/crewapp/crewapp","forks_url":"https://api.github.com/repos/crewapp/crewapp/forks","keys_url":"https://api.github.com/repos/crewapp/crewapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crewapp/crewapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crewapp/crewapp/teams","hooks_url":"https://api.github.com/repos/crewapp/crewapp/hooks","issue_events_url":"https://api.github.com/repos/crewapp/crewapp/issues/events{/number}","events_url":"https://api.github.com/repos/crewapp/crewapp/events","assignees_url":"https://api.github.com/repos/crewapp/crewapp/assignees{/user}","branches_url":"https://api.github.com/repos/crewapp/crewapp/branches{/branch}","tags_url":"https://api.github.com/repos/crewapp/crewapp/tags","blobs_url":"https://api.github.com/repos/crewapp/crewapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crewapp/crewapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crewapp/crewapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/crewapp/crewapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crewapp/crewapp/statuses/{sha}","languages_url":"https://api.github.com/repos/crewapp/crewapp/languages","stargazers_url":"https://api.github.com/repos/crewapp/crewapp/stargazers","contributors_url":"https://api.github.com/repos/crewapp/crewapp/contributors","subscribers_url":"https://api.github.com/repos/crewapp/crewapp/subscribers","subscription_url":"https://api.github.com/repos/crewapp/crewapp/subscription","commits_url":"https://api.github.com/repos/crewapp/crewapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/crewapp/crewapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/crewapp/crewapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/crewapp/crewapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/crewapp/crewapp/contents/{+path}","compare_url":"https://api.github.com/repos/crewapp/crewapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crewapp/crewapp/merges","archive_url":"https://api.github.com/repos/crewapp/crewapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crewapp/crewapp/downloads","issues_url":"https://api.github.com/repos/crewapp/crewapp/issues{/number}","pulls_url":"https://api.github.com/repos/crewapp/crewapp/pulls{/number}","milestones_url":"https://api.github.com/repos/crewapp/crewapp/milestones{/number}","notifications_url":"https://api.github.com/repos/crewapp/crewapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crewapp/crewapp/labels{/name}","releases_url":"https://api.github.com/repos/crewapp/crewapp/releases{/id}","created_at":"2015-04-03T23:41:53Z","updated_at":"2015-04-10T22:37:38Z","pushed_at":"2015-04-11T16:29:10Z","git_url":"git://github.com/crewapp/crewapp.git","ssh_url":"git@github.com:crewapp/crewapp.git","clone_url":"https://github.com/crewapp/crewapp.git","svn_url":"https://github.com/crewapp/crewapp","homepage":"http://trycrewapp.com","size":608,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":14,"forks":4,"open_issues":14,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crewapp/crewapp/pulls/84"},"html":{"href":"https://github.com/crewapp/crewapp/pull/84"},"issue":{"href":"https://api.github.com/repos/crewapp/crewapp/issues/84"},"comments":{"href":"https://api.github.com/repos/crewapp/crewapp/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/crewapp/crewapp/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/crewapp/crewapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crewapp/crewapp/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/crewapp/crewapp/statuses/0cab937c46fdb923e443b7372371ce60088e9c1a"}}}}