{"action":"created","issue":{"url":"https://api.github.com/repos/premake/premake-core/issues/36","labels_url":"https://api.github.com/repos/premake/premake-core/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/premake/premake-core/issues/36/comments","events_url":"https://api.github.com/repos/premake/premake-core/issues/36/events","html_url":"https://github.com/premake/premake-core/pull/36","id":67609654,"number":36,"title":"Added aliases for explicit architectures","user":{"login":"TurkeyMan","id":1146706,"avatar_url":"https://avatars.githubusercontent.com/u/1146706?v=3","gravatar_id":"","url":"https://api.github.com/users/TurkeyMan","html_url":"https://github.com/TurkeyMan","followers_url":"https://api.github.com/users/TurkeyMan/followers","following_url":"https://api.github.com/users/TurkeyMan/following{/other_user}","gists_url":"https://api.github.com/users/TurkeyMan/gists{/gist_id}","starred_url":"https://api.github.com/users/TurkeyMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TurkeyMan/subscriptions","organizations_url":"https://api.github.com/users/TurkeyMan/orgs","repos_url":"https://api.github.com/users/TurkeyMan/repos","events_url":"https://api.github.com/users/TurkeyMan/events{/privacy}","received_events_url":"https://api.github.com/users/TurkeyMan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-04-10T14:35:44Z","updated_at":"2015-04-13T16:49:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/premake/premake-core/pulls/36","html_url":"https://github.com/premake/premake-core/pull/36","diff_url":"https://github.com/premake/premake-core/pull/36.diff","patch_url":"https://github.com/premake/premake-core/pull/36.patch"},"body":"The 'architecture' api has always bothered me; none of the entries are actually architectures... and it's often necessary to select architectures explicitly.\r\n\r\n@starkos I see you were going for something a little bit abstract, associating with the x86 toolchains '-m32'/'-m64' compile args. That's kind reasonable for x86, but doesn't make sense for anything else.\r\n\r\nObviously, we can't remove those entries, but I think we need to add explicit architectures alongside those abstract entries. Many of my modules introduce various explicit architectures, but I think explicit x86 variants should be defined in core.\r\n\r\nI've always felt that x32 and x64 create confusion since they look like they may specify an explicit architecture ('x' implies x86 line of processors), but they're only meant to specify -m32/-m64. I think for premake5, we should rename those 2 entries to m32 and m64, which is what they are. I have created aliases for x32->m32 and x64->m64, which I think should be deprecated.\r\n\r\nI then added x86 and x86_64; the proper names for those explicit architectures.\r\n\r\nI'm not actually sure m32/m64 should exist, but they are certainly long-standing legacy, so I think it's better to keep them, and the rename makes their conceptual meaning more clear and avoid confusion with absolute architecture identifiers.\r\n\r\nThen finally, I've painstakingly made everything work...\r\n\r\nPlease tell me this seems correct to you, I spent a lot of time on this ;)"},"comment":{"url":"https://api.github.com/repos/premake/premake-core/issues/comments/92422778","html_url":"https://github.com/premake/premake-core/pull/36#issuecomment-92422778","issue_url":"https://api.github.com/repos/premake/premake-core/issues/36","id":92422778,"user":{"login":"starkos","id":249247,"avatar_url":"https://avatars.githubusercontent.com/u/249247?v=3","gravatar_id":"","url":"https://api.github.com/users/starkos","html_url":"https://github.com/starkos","followers_url":"https://api.github.com/users/starkos/followers","following_url":"https://api.github.com/users/starkos/following{/other_user}","gists_url":"https://api.github.com/users/starkos/gists{/gist_id}","starred_url":"https://api.github.com/users/starkos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starkos/subscriptions","organizations_url":"https://api.github.com/users/starkos/orgs","repos_url":"https://api.github.com/users/starkos/repos","events_url":"https://api.github.com/users/starkos/events{/privacy}","received_events_url":"https://api.github.com/users/starkos/received_events","type":"User","site_admin":false},"created_at":"2015-04-13T16:49:01Z","updated_at":"2015-04-13T16:49:01Z","body":"Looks good. Merging…"}}