{"action":"created","comment":{"url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/comments/45769699","id":45769699,"diff_hunk":"@@ -84,7 +84,9 @@\n              .xLabel('')\n              .yLabel('')\n              .on('trackingmove', function(crosshairData) {\n-                 dispatch.crosshairChange(crosshairData[0].datum);\n+                 if (crosshairData.length > 0) {","path":"src/assets/js/chart/primary.js","position":5,"original_position":5,"commit_id":"3027c2187bc5b7ceb3a322b3a92c90e809cc2d98","original_commit_id":"3027c2187bc5b7ceb3a322b3a92c90e809cc2d98","user":{"login":"jleft","id":2017615,"avatar_url":"https://avatars.githubusercontent.com/u/2017615?v=3","gravatar_id":"","url":"https://api.github.com/users/jleft","html_url":"https://github.com/jleft","followers_url":"https://api.github.com/users/jleft/followers","following_url":"https://api.github.com/users/jleft/following{/other_user}","gists_url":"https://api.github.com/users/jleft/gists{/gist_id}","starred_url":"https://api.github.com/users/jleft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jleft/subscriptions","organizations_url":"https://api.github.com/users/jleft/orgs","repos_url":"https://api.github.com/users/jleft/repos","events_url":"https://api.github.com/users/jleft/events{/privacy}","received_events_url":"https://api.github.com/users/jleft/received_events","type":"User","site_admin":false},"body":"I'd be tempted to let app.js handle this; we could simplify primary to just:\r\n\r\n```js\r\n.on('trackingmove', dispatch.crosshairChange)\r\n.on('trackingend', dispatch.crosshairChange);\r\n```\r\n\r\nAnd update app.js to check if we have data or not, something like this:\r\n\r\n```js\r\nfunction onCrosshairChange(data) {\r\n    var dataPoint = data.length ? data[0].datum : null;\r\n    legendModel.data = dataPoint;\r\n    render();\r\n}\r\n```","created_at":"2015-11-24T17:49:27Z","updated_at":"2015-11-24T17:49:27Z","html_url":"https://github.com/ScottLogic/d3fc-showcase/pull/428#discussion_r45769699","pull_request_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/428","_links":{"self":{"href":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/comments/45769699"},"html":{"href":"https://github.com/ScottLogic/d3fc-showcase/pull/428#discussion_r45769699"},"pull_request":{"href":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/428"}}},"pull_request":{"url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/428","id":51667654,"html_url":"https://github.com/ScottLogic/d3fc-showcase/pull/428","diff_url":"https://github.com/ScottLogic/d3fc-showcase/pull/428.diff","patch_url":"https://github.com/ScottLogic/d3fc-showcase/pull/428.patch","issue_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/issues/428","number":428,"state":"open","locked":false,"title":"Small fixes for IE and FF","user":{"login":"Afredon","id":14907010,"avatar_url":"https://avatars.githubusercontent.com/u/14907010?v=3","gravatar_id":"","url":"https://api.github.com/users/Afredon","html_url":"https://github.com/Afredon","followers_url":"https://api.github.com/users/Afredon/followers","following_url":"https://api.github.com/users/Afredon/following{/other_user}","gists_url":"https://api.github.com/users/Afredon/gists{/gist_id}","starred_url":"https://api.github.com/users/Afredon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Afredon/subscriptions","organizations_url":"https://api.github.com/users/Afredon/orgs","repos_url":"https://api.github.com/users/Afredon/repos","events_url":"https://api.github.com/users/Afredon/events{/privacy}","received_events_url":"https://api.github.com/users/Afredon/received_events","type":"User","site_admin":false},"body":"Fixes #422 and an issue with the navbar vertical bars width in Firefox","created_at":"2015-11-24T14:41:51Z","updated_at":"2015-11-24T17:49:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6de2867f40face8dee903d1055dd0aa5aa59955","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/428/commits","review_comments_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/428/comments","review_comment_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/issues/428/comments","statuses_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/statuses/3027c2187bc5b7ceb3a322b3a92c90e809cc2d98","head":{"label":"Afredon:IEBugs","ref":"IEBugs","sha":"3027c2187bc5b7ceb3a322b3a92c90e809cc2d98","user":{"login":"Afredon","id":14907010,"avatar_url":"https://avatars.githubusercontent.com/u/14907010?v=3","gravatar_id":"","url":"https://api.github.com/users/Afredon","html_url":"https://github.com/Afredon","followers_url":"https://api.github.com/users/Afredon/followers","following_url":"https://api.github.com/users/Afredon/following{/other_user}","gists_url":"https://api.github.com/users/Afredon/gists{/gist_id}","starred_url":"https://api.github.com/users/Afredon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Afredon/subscriptions","organizations_url":"https://api.github.com/users/Afredon/orgs","repos_url":"https://api.github.com/users/Afredon/repos","events_url":"https://api.github.com/users/Afredon/events{/privacy}","received_events_url":"https://api.github.com/users/Afredon/received_events","type":"User","site_admin":false},"repo":{"id":43433082,"name":"d3fc-showcase","full_name":"Afredon/d3fc-showcase","owner":{"login":"Afredon","id":14907010,"avatar_url":"https://avatars.githubusercontent.com/u/14907010?v=3","gravatar_id":"","url":"https://api.github.com/users/Afredon","html_url":"https://github.com/Afredon","followers_url":"https://api.github.com/users/Afredon/followers","following_url":"https://api.github.com/users/Afredon/following{/other_user}","gists_url":"https://api.github.com/users/Afredon/gists{/gist_id}","starred_url":"https://api.github.com/users/Afredon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Afredon/subscriptions","organizations_url":"https://api.github.com/users/Afredon/orgs","repos_url":"https://api.github.com/users/Afredon/repos","events_url":"https://api.github.com/users/Afredon/events{/privacy}","received_events_url":"https://api.github.com/users/Afredon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Afredon/d3fc-showcase","description":"A cross-platform financial charting application to showcase the functionality of d3fc components.","fork":true,"url":"https://api.github.com/repos/Afredon/d3fc-showcase","forks_url":"https://api.github.com/repos/Afredon/d3fc-showcase/forks","keys_url":"https://api.github.com/repos/Afredon/d3fc-showcase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Afredon/d3fc-showcase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Afredon/d3fc-showcase/teams","hooks_url":"https://api.github.com/repos/Afredon/d3fc-showcase/hooks","issue_events_url":"https://api.github.com/repos/Afredon/d3fc-showcase/issues/events{/number}","events_url":"https://api.github.com/repos/Afredon/d3fc-showcase/events","assignees_url":"https://api.github.com/repos/Afredon/d3fc-showcase/assignees{/user}","branches_url":"https://api.github.com/repos/Afredon/d3fc-showcase/branches{/branch}","tags_url":"https://api.github.com/repos/Afredon/d3fc-showcase/tags","blobs_url":"https://api.github.com/repos/Afredon/d3fc-showcase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Afredon/d3fc-showcase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Afredon/d3fc-showcase/git/refs{/sha}","trees_url":"https://api.github.com/repos/Afredon/d3fc-showcase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Afredon/d3fc-showcase/statuses/{sha}","languages_url":"https://api.github.com/repos/Afredon/d3fc-showcase/languages","stargazers_url":"https://api.github.com/repos/Afredon/d3fc-showcase/stargazers","contributors_url":"https://api.github.com/repos/Afredon/d3fc-showcase/contributors","subscribers_url":"https://api.github.com/repos/Afredon/d3fc-showcase/subscribers","subscription_url":"https://api.github.com/repos/Afredon/d3fc-showcase/subscription","commits_url":"https://api.github.com/repos/Afredon/d3fc-showcase/commits{/sha}","git_commits_url":"https://api.github.com/repos/Afredon/d3fc-showcase/git/commits{/sha}","comments_url":"https://api.github.com/repos/Afredon/d3fc-showcase/comments{/number}","issue_comment_url":"https://api.github.com/repos/Afredon/d3fc-showcase/issues/comments{/number}","contents_url":"https://api.github.com/repos/Afredon/d3fc-showcase/contents/{+path}","compare_url":"https://api.github.com/repos/Afredon/d3fc-showcase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Afredon/d3fc-showcase/merges","archive_url":"https://api.github.com/repos/Afredon/d3fc-showcase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Afredon/d3fc-showcase/downloads","issues_url":"https://api.github.com/repos/Afredon/d3fc-showcase/issues{/number}","pulls_url":"https://api.github.com/repos/Afredon/d3fc-showcase/pulls{/number}","milestones_url":"https://api.github.com/repos/Afredon/d3fc-showcase/milestones{/number}","notifications_url":"https://api.github.com/repos/Afredon/d3fc-showcase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Afredon/d3fc-showcase/labels{/name}","releases_url":"https://api.github.com/repos/Afredon/d3fc-showcase/releases{/id}","created_at":"2015-09-30T13:00:03Z","updated_at":"2015-10-19T10:42:17Z","pushed_at":"2015-11-24T17:23:39Z","git_url":"git://github.com/Afredon/d3fc-showcase.git","ssh_url":"git@github.com:Afredon/d3fc-showcase.git","clone_url":"https://github.com/Afredon/d3fc-showcase.git","svn_url":"https://github.com/Afredon/d3fc-showcase","homepage":"http://scottlogic.github.io/d3fc-showcase/","size":867,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"gh-pages"}},"base":{"label":"ScottLogic:develop","ref":"develop","sha":"50b3e52fb01b15f3300db3a92980b34461add2cb","user":{"login":"ScottLogic","id":2046037,"avatar_url":"https://avatars.githubusercontent.com/u/2046037?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottLogic","html_url":"https://github.com/ScottLogic","followers_url":"https://api.github.com/users/ScottLogic/followers","following_url":"https://api.github.com/users/ScottLogic/following{/other_user}","gists_url":"https://api.github.com/users/ScottLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottLogic/subscriptions","organizations_url":"https://api.github.com/users/ScottLogic/orgs","repos_url":"https://api.github.com/users/ScottLogic/repos","events_url":"https://api.github.com/users/ScottLogic/events{/privacy}","received_events_url":"https://api.github.com/users/ScottLogic/received_events","type":"Organization","site_admin":false},"repo":{"id":39064095,"name":"d3fc-showcase","full_name":"ScottLogic/d3fc-showcase","owner":{"login":"ScottLogic","id":2046037,"avatar_url":"https://avatars.githubusercontent.com/u/2046037?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottLogic","html_url":"https://github.com/ScottLogic","followers_url":"https://api.github.com/users/ScottLogic/followers","following_url":"https://api.github.com/users/ScottLogic/following{/other_user}","gists_url":"https://api.github.com/users/ScottLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottLogic/subscriptions","organizations_url":"https://api.github.com/users/ScottLogic/orgs","repos_url":"https://api.github.com/users/ScottLogic/repos","events_url":"https://api.github.com/users/ScottLogic/events{/privacy}","received_events_url":"https://api.github.com/users/ScottLogic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ScottLogic/d3fc-showcase","description":"A cross-platform financial charting application to showcase the functionality of d3fc components.","fork":false,"url":"https://api.github.com/repos/ScottLogic/d3fc-showcase","forks_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/forks","keys_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/teams","hooks_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/hooks","issue_events_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/issues/events{/number}","events_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/events","assignees_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/assignees{/user}","branches_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/branches{/branch}","tags_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/tags","blobs_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/statuses/{sha}","languages_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/languages","stargazers_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/stargazers","contributors_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/contributors","subscribers_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/subscribers","subscription_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/subscription","commits_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/issues/comments{/number}","contents_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/contents/{+path}","compare_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/merges","archive_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/downloads","issues_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/issues{/number}","pulls_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls{/number}","milestones_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/milestones{/number}","notifications_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/labels{/name}","releases_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/releases{/id}","created_at":"2015-07-14T08:47:46Z","updated_at":"2015-11-23T12:24:35Z","pushed_at":"2015-11-24T17:23:39Z","git_url":"git://github.com/ScottLogic/d3fc-showcase.git","ssh_url":"git@github.com:ScottLogic/d3fc-showcase.git","clone_url":"https://github.com/ScottLogic/d3fc-showcase.git","svn_url":"https://github.com/ScottLogic/d3fc-showcase","homepage":"http://scottlogic.github.io/d3fc-showcase/","size":1359,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":68,"forks":8,"open_issues":68,"watchers":9,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/428"},"html":{"href":"https://github.com/ScottLogic/d3fc-showcase/pull/428"},"issue":{"href":"https://api.github.com/repos/ScottLogic/d3fc-showcase/issues/428"},"comments":{"href":"https://api.github.com/repos/ScottLogic/d3fc-showcase/issues/428/comments"},"review_comments":{"href":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/428/comments"},"review_comment":{"href":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/428/commits"},"statuses":{"href":"https://api.github.com/repos/ScottLogic/d3fc-showcase/statuses/3027c2187bc5b7ceb3a322b3a92c90e809cc2d98"}}}}