{"action":"created","comment":{"url":"https://api.github.com/repos/apavlenko/vmf/pulls/comments/47901755","id":47901755,"diff_hunk":"@@ -64,6 +75,24 @@ class VMF_EXPORT IReader\n         std::vector<std::shared_ptr<MetadataInternal>>& metadata ) = 0;\n \n     virtual bool parseVideoSegments(const std::string& text, std::vector<std::shared_ptr<MetadataStream::VideoSegment> >& segments) = 0;\n+\n+protected:","path":"modules/vmfcore/include/vmf/ireader.hpp","position":24,"original_position":24,"commit_id":"8fc6338561242d98c03f417e5ea3f66ff61f2ba1","original_commit_id":"ba52790e76c2cc3769a25c03e6df656954263dce","user":{"login":"savuor","id":10323511,"avatar_url":"https://avatars.githubusercontent.com/u/10323511?v=3","gravatar_id":"","url":"https://api.github.com/users/savuor","html_url":"https://github.com/savuor","followers_url":"https://api.github.com/users/savuor/followers","following_url":"https://api.github.com/users/savuor/following{/other_user}","gists_url":"https://api.github.com/users/savuor/gists{/gist_id}","starred_url":"https://api.github.com/users/savuor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/savuor/subscriptions","organizations_url":"https://api.github.com/users/savuor/orgs","repos_url":"https://api.github.com/users/savuor/repos","events_url":"https://api.github.com/users/savuor/events{/privacy}","received_events_url":"https://api.github.com/users/savuor/received_events","type":"User","site_admin":false},"body":"Now understood\r\nAll impl. details moved to Reader/Writer Base classes","created_at":"2015-12-17T12:52:00Z","updated_at":"2015-12-17T12:52:00Z","html_url":"https://github.com/apavlenko/vmf/pull/10#discussion_r47901755","pull_request_url":"https://api.github.com/repos/apavlenko/vmf/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/apavlenko/vmf/pulls/comments/47901755"},"html":{"href":"https://github.com/apavlenko/vmf/pull/10#discussion_r47901755"},"pull_request":{"href":"https://api.github.com/repos/apavlenko/vmf/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/apavlenko/vmf/pulls/10","id":53553948,"html_url":"https://github.com/apavlenko/vmf/pull/10","diff_url":"https://github.com/apavlenko/vmf/pull/10.diff","patch_url":"https://github.com/apavlenko/vmf/pull/10.patch","issue_url":"https://api.github.com/repos/apavlenko/vmf/issues/10","number":10,"state":"open","locked":false,"title":"[WIP] Compression prototype","user":{"login":"apavlenko","id":2344952,"avatar_url":"https://avatars.githubusercontent.com/u/2344952?v=3","gravatar_id":"","url":"https://api.github.com/users/apavlenko","html_url":"https://github.com/apavlenko","followers_url":"https://api.github.com/users/apavlenko/followers","following_url":"https://api.github.com/users/apavlenko/following{/other_user}","gists_url":"https://api.github.com/users/apavlenko/gists{/gist_id}","starred_url":"https://api.github.com/users/apavlenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apavlenko/subscriptions","organizations_url":"https://api.github.com/users/apavlenko/orgs","repos_url":"https://api.github.com/users/apavlenko/repos","events_url":"https://api.github.com/users/apavlenko/events{/privacy}","received_events_url":"https://api.github.com/users/apavlenko/received_events","type":"User","site_admin":false},"body":"Prototype for #2 ","created_at":"2015-12-14T11:39:21Z","updated_at":"2015-12-17T12:52:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fa2629a54bcabecb91dea61094f248fe6b14ebf","assignee":{"login":"apavlenko","id":2344952,"avatar_url":"https://avatars.githubusercontent.com/u/2344952?v=3","gravatar_id":"","url":"https://api.github.com/users/apavlenko","html_url":"https://github.com/apavlenko","followers_url":"https://api.github.com/users/apavlenko/followers","following_url":"https://api.github.com/users/apavlenko/following{/other_user}","gists_url":"https://api.github.com/users/apavlenko/gists{/gist_id}","starred_url":"https://api.github.com/users/apavlenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apavlenko/subscriptions","organizations_url":"https://api.github.com/users/apavlenko/orgs","repos_url":"https://api.github.com/users/apavlenko/repos","events_url":"https://api.github.com/users/apavlenko/events{/privacy}","received_events_url":"https://api.github.com/users/apavlenko/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/apavlenko/vmf/milestones/1","html_url":"https://github.com/apavlenko/vmf/milestones/3.0-pre","labels_url":"https://api.github.com/repos/apavlenko/vmf/milestones/1/labels","id":1434986,"number":1,"title":"3.0-pre","description":"VMF 3.0 pre-release","creator":{"login":"apavlenko","id":2344952,"avatar_url":"https://avatars.githubusercontent.com/u/2344952?v=3","gravatar_id":"","url":"https://api.github.com/users/apavlenko","html_url":"https://github.com/apavlenko","followers_url":"https://api.github.com/users/apavlenko/followers","following_url":"https://api.github.com/users/apavlenko/following{/other_user}","gists_url":"https://api.github.com/users/apavlenko/gists{/gist_id}","starred_url":"https://api.github.com/users/apavlenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apavlenko/subscriptions","organizations_url":"https://api.github.com/users/apavlenko/orgs","repos_url":"https://api.github.com/users/apavlenko/repos","events_url":"https://api.github.com/users/apavlenko/events{/privacy}","received_events_url":"https://api.github.com/users/apavlenko/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":3,"state":"open","created_at":"2015-11-30T11:08:42Z","updated_at":"2015-12-17T12:14:22Z","due_on":"2016-03-31T21:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apavlenko/vmf/pulls/10/commits","review_comments_url":"https://api.github.com/repos/apavlenko/vmf/pulls/10/comments","review_comment_url":"https://api.github.com/repos/apavlenko/vmf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apavlenko/vmf/issues/10/comments","statuses_url":"https://api.github.com/repos/apavlenko/vmf/statuses/8fc6338561242d98c03f417e5ea3f66ff61f2ba1","head":{"label":"apavlenko:rv/compression_prototype","ref":"rv/compression_prototype","sha":"8fc6338561242d98c03f417e5ea3f66ff61f2ba1","user":{"login":"apavlenko","id":2344952,"avatar_url":"https://avatars.githubusercontent.com/u/2344952?v=3","gravatar_id":"","url":"https://api.github.com/users/apavlenko","html_url":"https://github.com/apavlenko","followers_url":"https://api.github.com/users/apavlenko/followers","following_url":"https://api.github.com/users/apavlenko/following{/other_user}","gists_url":"https://api.github.com/users/apavlenko/gists{/gist_id}","starred_url":"https://api.github.com/users/apavlenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apavlenko/subscriptions","organizations_url":"https://api.github.com/users/apavlenko/orgs","repos_url":"https://api.github.com/users/apavlenko/repos","events_url":"https://api.github.com/users/apavlenko/events{/privacy}","received_events_url":"https://api.github.com/users/apavlenko/received_events","type":"User","site_admin":false},"repo":{"id":47108203,"name":"vmf","full_name":"apavlenko/vmf","owner":{"login":"apavlenko","id":2344952,"avatar_url":"https://avatars.githubusercontent.com/u/2344952?v=3","gravatar_id":"","url":"https://api.github.com/users/apavlenko","html_url":"https://github.com/apavlenko","followers_url":"https://api.github.com/users/apavlenko/followers","following_url":"https://api.github.com/users/apavlenko/following{/other_user}","gists_url":"https://api.github.com/users/apavlenko/gists{/gist_id}","starred_url":"https://api.github.com/users/apavlenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apavlenko/subscriptions","organizations_url":"https://api.github.com/users/apavlenko/orgs","repos_url":"https://api.github.com/users/apavlenko/repos","events_url":"https://api.github.com/users/apavlenko/events{/privacy}","received_events_url":"https://api.github.com/users/apavlenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apavlenko/vmf","description":"","fork":true,"url":"https://api.github.com/repos/apavlenko/vmf","forks_url":"https://api.github.com/repos/apavlenko/vmf/forks","keys_url":"https://api.github.com/repos/apavlenko/vmf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apavlenko/vmf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apavlenko/vmf/teams","hooks_url":"https://api.github.com/repos/apavlenko/vmf/hooks","issue_events_url":"https://api.github.com/repos/apavlenko/vmf/issues/events{/number}","events_url":"https://api.github.com/repos/apavlenko/vmf/events","assignees_url":"https://api.github.com/repos/apavlenko/vmf/assignees{/user}","branches_url":"https://api.github.com/repos/apavlenko/vmf/branches{/branch}","tags_url":"https://api.github.com/repos/apavlenko/vmf/tags","blobs_url":"https://api.github.com/repos/apavlenko/vmf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apavlenko/vmf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apavlenko/vmf/git/refs{/sha}","trees_url":"https://api.github.com/repos/apavlenko/vmf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apavlenko/vmf/statuses/{sha}","languages_url":"https://api.github.com/repos/apavlenko/vmf/languages","stargazers_url":"https://api.github.com/repos/apavlenko/vmf/stargazers","contributors_url":"https://api.github.com/repos/apavlenko/vmf/contributors","subscribers_url":"https://api.github.com/repos/apavlenko/vmf/subscribers","subscription_url":"https://api.github.com/repos/apavlenko/vmf/subscription","commits_url":"https://api.github.com/repos/apavlenko/vmf/commits{/sha}","git_commits_url":"https://api.github.com/repos/apavlenko/vmf/git/commits{/sha}","comments_url":"https://api.github.com/repos/apavlenko/vmf/comments{/number}","issue_comment_url":"https://api.github.com/repos/apavlenko/vmf/issues/comments{/number}","contents_url":"https://api.github.com/repos/apavlenko/vmf/contents/{+path}","compare_url":"https://api.github.com/repos/apavlenko/vmf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apavlenko/vmf/merges","archive_url":"https://api.github.com/repos/apavlenko/vmf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apavlenko/vmf/downloads","issues_url":"https://api.github.com/repos/apavlenko/vmf/issues{/number}","pulls_url":"https://api.github.com/repos/apavlenko/vmf/pulls{/number}","milestones_url":"https://api.github.com/repos/apavlenko/vmf/milestones{/number}","notifications_url":"https://api.github.com/repos/apavlenko/vmf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apavlenko/vmf/labels{/name}","releases_url":"https://api.github.com/repos/apavlenko/vmf/releases{/id}","created_at":"2015-11-30T09:26:33Z","updated_at":"2015-11-30T09:27:33Z","pushed_at":"2015-12-17T11:56:09Z","git_url":"git://github.com/apavlenko/vmf.git","ssh_url":"git@github.com:apavlenko/vmf.git","clone_url":"https://github.com/apavlenko/vmf.git","svn_url":"https://github.com/apavlenko/vmf","homepage":"http://01org.github.io/vmf/","size":30357,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":0,"default_branch":"vmf-3.0"}},"base":{"label":"apavlenko:vmf-3.0","ref":"vmf-3.0","sha":"367a0c3ca7e7f007e35ff606346c85842a0d3e9b","user":{"login":"apavlenko","id":2344952,"avatar_url":"https://avatars.githubusercontent.com/u/2344952?v=3","gravatar_id":"","url":"https://api.github.com/users/apavlenko","html_url":"https://github.com/apavlenko","followers_url":"https://api.github.com/users/apavlenko/followers","following_url":"https://api.github.com/users/apavlenko/following{/other_user}","gists_url":"https://api.github.com/users/apavlenko/gists{/gist_id}","starred_url":"https://api.github.com/users/apavlenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apavlenko/subscriptions","organizations_url":"https://api.github.com/users/apavlenko/orgs","repos_url":"https://api.github.com/users/apavlenko/repos","events_url":"https://api.github.com/users/apavlenko/events{/privacy}","received_events_url":"https://api.github.com/users/apavlenko/received_events","type":"User","site_admin":false},"repo":{"id":47108203,"name":"vmf","full_name":"apavlenko/vmf","owner":{"login":"apavlenko","id":2344952,"avatar_url":"https://avatars.githubusercontent.com/u/2344952?v=3","gravatar_id":"","url":"https://api.github.com/users/apavlenko","html_url":"https://github.com/apavlenko","followers_url":"https://api.github.com/users/apavlenko/followers","following_url":"https://api.github.com/users/apavlenko/following{/other_user}","gists_url":"https://api.github.com/users/apavlenko/gists{/gist_id}","starred_url":"https://api.github.com/users/apavlenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apavlenko/subscriptions","organizations_url":"https://api.github.com/users/apavlenko/orgs","repos_url":"https://api.github.com/users/apavlenko/repos","events_url":"https://api.github.com/users/apavlenko/events{/privacy}","received_events_url":"https://api.github.com/users/apavlenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apavlenko/vmf","description":"","fork":true,"url":"https://api.github.com/repos/apavlenko/vmf","forks_url":"https://api.github.com/repos/apavlenko/vmf/forks","keys_url":"https://api.github.com/repos/apavlenko/vmf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apavlenko/vmf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apavlenko/vmf/teams","hooks_url":"https://api.github.com/repos/apavlenko/vmf/hooks","issue_events_url":"https://api.github.com/repos/apavlenko/vmf/issues/events{/number}","events_url":"https://api.github.com/repos/apavlenko/vmf/events","assignees_url":"https://api.github.com/repos/apavlenko/vmf/assignees{/user}","branches_url":"https://api.github.com/repos/apavlenko/vmf/branches{/branch}","tags_url":"https://api.github.com/repos/apavlenko/vmf/tags","blobs_url":"https://api.github.com/repos/apavlenko/vmf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apavlenko/vmf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apavlenko/vmf/git/refs{/sha}","trees_url":"https://api.github.com/repos/apavlenko/vmf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apavlenko/vmf/statuses/{sha}","languages_url":"https://api.github.com/repos/apavlenko/vmf/languages","stargazers_url":"https://api.github.com/repos/apavlenko/vmf/stargazers","contributors_url":"https://api.github.com/repos/apavlenko/vmf/contributors","subscribers_url":"https://api.github.com/repos/apavlenko/vmf/subscribers","subscription_url":"https://api.github.com/repos/apavlenko/vmf/subscription","commits_url":"https://api.github.com/repos/apavlenko/vmf/commits{/sha}","git_commits_url":"https://api.github.com/repos/apavlenko/vmf/git/commits{/sha}","comments_url":"https://api.github.com/repos/apavlenko/vmf/comments{/number}","issue_comment_url":"https://api.github.com/repos/apavlenko/vmf/issues/comments{/number}","contents_url":"https://api.github.com/repos/apavlenko/vmf/contents/{+path}","compare_url":"https://api.github.com/repos/apavlenko/vmf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apavlenko/vmf/merges","archive_url":"https://api.github.com/repos/apavlenko/vmf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apavlenko/vmf/downloads","issues_url":"https://api.github.com/repos/apavlenko/vmf/issues{/number}","pulls_url":"https://api.github.com/repos/apavlenko/vmf/pulls{/number}","milestones_url":"https://api.github.com/repos/apavlenko/vmf/milestones{/number}","notifications_url":"https://api.github.com/repos/apavlenko/vmf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apavlenko/vmf/labels{/name}","releases_url":"https://api.github.com/repos/apavlenko/vmf/releases{/id}","created_at":"2015-11-30T09:26:33Z","updated_at":"2015-11-30T09:27:33Z","pushed_at":"2015-12-17T11:56:09Z","git_url":"git://github.com/apavlenko/vmf.git","ssh_url":"git@github.com:apavlenko/vmf.git","clone_url":"https://github.com/apavlenko/vmf.git","svn_url":"https://github.com/apavlenko/vmf","homepage":"http://01org.github.io/vmf/","size":30357,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":0,"default_branch":"vmf-3.0"}},"_links":{"self":{"href":"https://api.github.com/repos/apavlenko/vmf/pulls/10"},"html":{"href":"https://github.com/apavlenko/vmf/pull/10"},"issue":{"href":"https://api.github.com/repos/apavlenko/vmf/issues/10"},"comments":{"href":"https://api.github.com/repos/apavlenko/vmf/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/apavlenko/vmf/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/apavlenko/vmf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apavlenko/vmf/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/apavlenko/vmf/statuses/8fc6338561242d98c03f417e5ea3f66ff61f2ba1"}}}}