{"action":"created","comment":{"url":"https://api.github.com/repos/uber/tchannel-java/pulls/comments/40003047","id":40003047,"diff_hunk":"@@ -38,17 +35,13 @@ public SetValueHandlerDefault(Map<String, String> keyValueStore) {\n         this.keyValueStore = keyValueStore;\n     }\n \n-    @Override\n-    public Response<KeyValue.setValue_result> handle(Request<KeyValue.setValue_args> request) {\n+    public KeyValue.setValue_result handleImpl(KeyValue.setValue_args setValueArgs) {","path":"tchannel-example/src/main/java/com/uber/tchannel/thrift/SetValueHandlerDefault.java","position":24,"original_position":24,"commit_id":"f7a06e90e295db54cce1da6ce137a59e79a6439c","original_commit_id":"f7a06e90e295db54cce1da6ce137a59e79a6439c","user":{"login":"truncs","id":157234,"avatar_url":"https://avatars.githubusercontent.com/u/157234?v=3","gravatar_id":"","url":"https://api.github.com/users/truncs","html_url":"https://github.com/truncs","followers_url":"https://api.github.com/users/truncs/followers","following_url":"https://api.github.com/users/truncs/following{/other_user}","gists_url":"https://api.github.com/users/truncs/gists{/gist_id}","starred_url":"https://api.github.com/users/truncs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/truncs/subscriptions","organizations_url":"https://api.github.com/users/truncs/orgs","repos_url":"https://api.github.com/users/truncs/repos","events_url":"https://api.github.com/users/truncs/events{/privacy}","received_events_url":"https://api.github.com/users/truncs/received_events","type":"User","site_admin":false},"body":"Yes, I have had some thoughts about it and I was planning to wrap it with Request and Response but then I found it strange that the handlers should know about transport headers or ttl. On top of that they have their own application headers. But yeah lets braintstorm on that.","created_at":"2015-09-21T17:57:47Z","updated_at":"2015-09-21T17:57:47Z","html_url":"https://github.com/uber/tchannel-java/pull/74#discussion_r40003047","pull_request_url":"https://api.github.com/repos/uber/tchannel-java/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel-java/pulls/comments/40003047"},"html":{"href":"https://github.com/uber/tchannel-java/pull/74#discussion_r40003047"},"pull_request":{"href":"https://api.github.com/repos/uber/tchannel-java/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/uber/tchannel-java/pulls/74","id":45513002,"html_url":"https://github.com/uber/tchannel-java/pull/74","diff_url":"https://github.com/uber/tchannel-java/pull/74.diff","patch_url":"https://github.com/uber/tchannel-java/pull/74.patch","issue_url":"https://api.github.com/repos/uber/tchannel-java/issues/74","number":74,"state":"open","locked":false,"title":"change the tchannel API","user":{"login":"truncs","id":157234,"avatar_url":"https://avatars.githubusercontent.com/u/157234?v=3","gravatar_id":"","url":"https://api.github.com/users/truncs","html_url":"https://github.com/truncs","followers_url":"https://api.github.com/users/truncs/followers","following_url":"https://api.github.com/users/truncs/following{/other_user}","gists_url":"https://api.github.com/users/truncs/gists{/gist_id}","starred_url":"https://api.github.com/users/truncs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/truncs/subscriptions","organizations_url":"https://api.github.com/users/truncs/orgs","repos_url":"https://api.github.com/users/truncs/repos","events_url":"https://api.github.com/users/truncs/events{/privacy}","received_events_url":"https://api.github.com/users/truncs/received_events","type":"User","site_admin":false},"body":"This is an insanely huge diff, sorry about that. But this changes the call side and the server side APIs. \r\n\r\n## Things to look for\r\n - call side APIs now have ListenableFuture APIs\r\n - Its possible to send raw messages now, yay ! \r\n - Seperates the RequestHandler into Handlers for each argscheme, they have a abstract handleImpl function\r\n - Serialization, Deserialization logic is completely remove from the network stack\r\n - The abstraction might be a little flawed since handleImpl takes the POJO instead of Request<POJO>\r\n - The same applies while returning handleImpl which returns a POJO instead of Response<POJO>\r\n\r\n## Performance\r\n\r\n### Current master\r\n```\r\nBenchmark                                    (sleepTime)   Mode  Cnt      Score      Error  Units\r\nPingPongServerBenchmark.benchmark                      0  thrpt   10  26464.659 ± 7548.703  ops/s\r\nPingPongServerBenchmark.benchmark:actualQPS            0  thrpt   10   9097.727 ± 2541.936  ops/s\r\nPingPongServerBenchmark.benchmark                      1  thrpt   10  35650.153 ± 9012.003  ops/s\r\nPingPongServerBenchmark.benchmark:actualQPS            1  thrpt   10    776.964 ±  171.012  ops/s\r\nPingPongServerBenchmark.benchmark                     10  thrpt   10  34589.161 ± 4960.052  ops/s\r\nPingPongServerBenchmark.benchmark:actualQPS           10  thrpt   10     87.028 ±    4.808  ops/s\r\n```\r\n\r\n### as-executor branch\r\n```\r\nBenchmark                                    (sleepTime)   Mode  Cnt      Score       Error  Units\r\nPingPongServerBenchmark.benchmark                      0  thrpt   10  27938.489 ±  6079.643  ops/s\r\nPingPongServerBenchmark.benchmark:actualQPS            0  thrpt   10  14699.715 ±  4896.936  ops/s\r\nPingPongServerBenchmark.benchmark                      1  thrpt   10  24217.306 ±  9774.461  ops/s\r\nPingPongServerBenchmark.benchmark:actualQPS            1  thrpt   10   5836.646 ±  2358.858  ops/s\r\nPingPongServerBenchmark.benchmark                     10  thrpt   10  26417.658 ± 12571.757  ops/s\r\nPingPongServerBenchmark.benchmark:actualQPS           10  thrpt   10    614.101 ±   289.005  ops/s\r\n```\r\n\r\n### This branch\r\n```\r\nBenchmark                                    (sleepTime)   Mode  Cnt      Score      Error  Units\r\nPingPongServerBenchmark.benchmark                      0  thrpt   10  22155.933 ± 3621.052  ops/s\r\nPingPongServerBenchmark.benchmark:actualQPS            0  thrpt   10  13143.591 ± 4300.413  ops/s\r\nPingPongServerBenchmark.benchmark                      1  thrpt   10  21657.944 ± 5312.693  ops/s\r\nPingPongServerBenchmark.benchmark:actualQPS            1  thrpt   10   6125.045 ± 1269.689  ops/s\r\nPingPongServerBenchmark.benchmark                     10  thrpt   10  18847.220 ± 8568.649  ops/s\r\nPingPongServerBenchmark.benchmark:actualQPS           10  thrpt   10    649.056 ±  300.511  ops/s\r\n```","created_at":"2015-09-21T04:04:13Z","updated_at":"2015-09-21T17:57:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4893ac50d659da74e715f241fa8de84fee0e9bbd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/tchannel-java/pulls/74/commits","review_comments_url":"https://api.github.com/repos/uber/tchannel-java/pulls/74/comments","review_comment_url":"https://api.github.com/repos/uber/tchannel-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/tchannel-java/issues/74/comments","statuses_url":"https://api.github.com/repos/uber/tchannel-java/statuses/f7a06e90e295db54cce1da6ce137a59e79a6439c","head":{"label":"uber:as-refactor","ref":"as-refactor","sha":"f7a06e90e295db54cce1da6ce137a59e79a6439c","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":39764417,"name":"tchannel-java","full_name":"uber/tchannel-java","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel-java","description":"A Java implementation of the TChannel protocol.","fork":false,"url":"https://api.github.com/repos/uber/tchannel-java","forks_url":"https://api.github.com/repos/uber/tchannel-java/forks","keys_url":"https://api.github.com/repos/uber/tchannel-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel-java/teams","hooks_url":"https://api.github.com/repos/uber/tchannel-java/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel-java/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel-java/events","assignees_url":"https://api.github.com/repos/uber/tchannel-java/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel-java/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel-java/tags","blobs_url":"https://api.github.com/repos/uber/tchannel-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel-java/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel-java/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel-java/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel-java/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel-java/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel-java/subscription","commits_url":"https://api.github.com/repos/uber/tchannel-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel-java/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel-java/merges","archive_url":"https://api.github.com/repos/uber/tchannel-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel-java/downloads","issues_url":"https://api.github.com/repos/uber/tchannel-java/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel-java/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel-java/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel-java/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel-java/releases{/id}","created_at":"2015-07-27T08:49:33Z","updated_at":"2015-09-16T22:32:14Z","pushed_at":"2015-09-21T17:35:24Z","git_url":"git://github.com/uber/tchannel-java.git","ssh_url":"git@github.com:uber/tchannel-java.git","clone_url":"https://github.com/uber/tchannel-java.git","svn_url":"https://github.com/uber/tchannel-java","homepage":"","size":1112,"stargazers_count":25,"watchers_count":25,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":21,"forks":8,"open_issues":21,"watchers":25,"default_branch":"master"}},"base":{"label":"uber:as-executor","ref":"as-executor","sha":"ac37ac48748560f95dcb8d8ec1d7b52f663d7997","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":39764417,"name":"tchannel-java","full_name":"uber/tchannel-java","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel-java","description":"A Java implementation of the TChannel protocol.","fork":false,"url":"https://api.github.com/repos/uber/tchannel-java","forks_url":"https://api.github.com/repos/uber/tchannel-java/forks","keys_url":"https://api.github.com/repos/uber/tchannel-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel-java/teams","hooks_url":"https://api.github.com/repos/uber/tchannel-java/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel-java/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel-java/events","assignees_url":"https://api.github.com/repos/uber/tchannel-java/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel-java/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel-java/tags","blobs_url":"https://api.github.com/repos/uber/tchannel-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel-java/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel-java/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel-java/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel-java/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel-java/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel-java/subscription","commits_url":"https://api.github.com/repos/uber/tchannel-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel-java/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel-java/merges","archive_url":"https://api.github.com/repos/uber/tchannel-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel-java/downloads","issues_url":"https://api.github.com/repos/uber/tchannel-java/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel-java/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel-java/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel-java/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel-java/releases{/id}","created_at":"2015-07-27T08:49:33Z","updated_at":"2015-09-16T22:32:14Z","pushed_at":"2015-09-21T17:35:24Z","git_url":"git://github.com/uber/tchannel-java.git","ssh_url":"git@github.com:uber/tchannel-java.git","clone_url":"https://github.com/uber/tchannel-java.git","svn_url":"https://github.com/uber/tchannel-java","homepage":"","size":1112,"stargazers_count":25,"watchers_count":25,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":21,"forks":8,"open_issues":21,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel-java/pulls/74"},"html":{"href":"https://github.com/uber/tchannel-java/pull/74"},"issue":{"href":"https://api.github.com/repos/uber/tchannel-java/issues/74"},"comments":{"href":"https://api.github.com/repos/uber/tchannel-java/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/tchannel-java/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/tchannel-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/tchannel-java/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/uber/tchannel-java/statuses/f7a06e90e295db54cce1da6ce137a59e79a6439c"}}}}