{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/comments/44078662","id":44078662,"diff_hunk":"@@ -8,10 +8,12 @@ app:\n   {{.Data.app_ports}}\n   {{.Data.app_volumes}}\n   environment:\n-    GOOGLE_CLIENT_ID: {{.Data.env_client_id}}\n-    AGORA_URL_ROOT: {{.Data.env_agora_url}}\n-    RAWLS_URL_ROOT: {{.Data.env_rawls_url}}\n-    THURLOE_URL_ROOT: {{.Data.env_thurloe_url}}\n+    - GOOGLE_CLIENT_ID={{.Data.env_client_id}}\n+    - AGORA_URL_ROOT={{.Data.env_agora_url}}\n+    - RAWLS_URL_ROOT={{.Data.env_rawls_url}}\n+    - THURLOE_URL_ROOT={{.Data.env_thurloe_url}}\n+    - FIRECLOUD_URL_ROOT={{.Data.env_firecloud_url}}\n+    - GOOGLE_SECRET_JSON={{.Data.env_google_json}}","path":"src/main/config/docker-compose.yaml.ctmpl","position":13,"original_position":13,"commit_id":"ae80cd23540ed23703a7e8b8edd72ba258e6cffd","original_commit_id":"ae80cd23540ed23703a7e8b8edd72ba258e6cffd","user":{"login":"davidangb","id":6041577,"avatar_url":"https://avatars.githubusercontent.com/u/6041577?v=3","gravatar_id":"","url":"https://api.github.com/users/davidangb","html_url":"https://github.com/davidangb","followers_url":"https://api.github.com/users/davidangb/followers","following_url":"https://api.github.com/users/davidangb/following{/other_user}","gists_url":"https://api.github.com/users/davidangb/gists{/gist_id}","starred_url":"https://api.github.com/users/davidangb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidangb/subscriptions","organizations_url":"https://api.github.com/users/davidangb/orgs","repos_url":"https://api.github.com/users/davidangb/repos","events_url":"https://api.github.com/users/davidangb/events{/privacy}","received_events_url":"https://api.github.com/users/davidangb/received_events","type":"User","site_admin":false},"body":"I needed to switch to this yaml syntax to support storing json in the value for GOOGLE_SECRET_JSON. (I think. I couldn't get it to work in the other format. Whatevs.)","created_at":"2015-11-05T22:23:14Z","updated_at":"2015-11-05T22:23:14Z","html_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/144#discussion_r44078662","pull_request_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/144","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/comments/44078662"},"html":{"href":"https://github.com/broadinstitute/firecloud-orchestration/pull/144#discussion_r44078662"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/144","id":49609972,"html_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/144","diff_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/144.diff","patch_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/144.patch","issue_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/144","number":144,"state":"open","locked":false,"title":"DSDEEPB-1723: OAuth implementation in orchestration","user":{"login":"davidangb","id":6041577,"avatar_url":"https://avatars.githubusercontent.com/u/6041577?v=3","gravatar_id":"","url":"https://api.github.com/users/davidangb","html_url":"https://github.com/davidangb","followers_url":"https://api.github.com/users/davidangb/followers","following_url":"https://api.github.com/users/davidangb/following{/other_user}","gists_url":"https://api.github.com/users/davidangb/gists{/gist_id}","starred_url":"https://api.github.com/users/davidangb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidangb/subscriptions","organizations_url":"https://api.github.com/users/davidangb/orgs","repos_url":"https://api.github.com/users/davidangb/repos","events_url":"https://api.github.com/users/davidangb/events{/privacy}","received_events_url":"https://api.github.com/users/davidangb/received_events","type":"User","site_admin":false},"body":"ready-for-review implementation of OAuth in orchestration layer.\r\n\r\nYou will need to set up new env vars for this:\r\n* FIRECLOUD_URL_ROOT: what's the base url for the UI? (https://firecloud.dsde-dev.broadinstitute.org or https://local.broadinstitute.org). We need this to cleanly redirect the browser.\r\n* GOOGLE_SECRET_JSON: the json, as downloaded from Google Developers Console, representing the client id/secret in use.\r\n\r\nThese are set up for the dev environment, but will need to be configured in staging/alpha/etc before this code goes out there.\r\n\r\nYou'll also need to make sure your credentials as set up in Google have the FIRECLOUD_URL_ROOT as an allowed origin, and have FIRECLOUD_URL_ROOT/service/oauth2callback as an authorized redirect URI.\r\n\r\nTo test, go to https://local.broadinstitute.org/service/login?path=foo in your browser to start the OAuth process. Your browser will be redirected a few times and you should end up at https://local.broadinstitute.org/?token={yourtokenhere}#foo.\r\n\r\n","created_at":"2015-11-03T20:50:48Z","updated_at":"2015-11-05T22:23:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f003c37cfe21b153c3d9c6ddf46df42514551a5d","assignee":{"login":"dmohs","id":1545444,"avatar_url":"https://avatars.githubusercontent.com/u/1545444?v=3","gravatar_id":"","url":"https://api.github.com/users/dmohs","html_url":"https://github.com/dmohs","followers_url":"https://api.github.com/users/dmohs/followers","following_url":"https://api.github.com/users/dmohs/following{/other_user}","gists_url":"https://api.github.com/users/dmohs/gists{/gist_id}","starred_url":"https://api.github.com/users/dmohs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmohs/subscriptions","organizations_url":"https://api.github.com/users/dmohs/orgs","repos_url":"https://api.github.com/users/dmohs/repos","events_url":"https://api.github.com/users/dmohs/events{/privacy}","received_events_url":"https://api.github.com/users/dmohs/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/144/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/144/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/144/comments","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/statuses/ae80cd23540ed23703a7e8b8edd72ba258e6cffd","head":{"label":"broadinstitute:da_oauthRefreshToken","ref":"da_oauthRefreshToken","sha":"ae80cd23540ed23703a7e8b8edd72ba258e6cffd","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":37272599,"name":"firecloud-orchestration","full_name":"broadinstitute/firecloud-orchestration","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/firecloud-orchestration","description":"","fork":false,"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration","forks_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/forks","keys_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/teams","hooks_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/events","assignees_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/tags","blobs_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/subscription","commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/merges","archive_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/downloads","issues_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/releases{/id}","created_at":"2015-06-11T16:26:34Z","updated_at":"2015-10-29T17:56:42Z","pushed_at":"2015-11-05T22:21:02Z","git_url":"git://github.com/broadinstitute/firecloud-orchestration.git","ssh_url":"git@github.com:broadinstitute/firecloud-orchestration.git","clone_url":"https://github.com/broadinstitute/firecloud-orchestration.git","svn_url":"https://github.com/broadinstitute/firecloud-orchestration","homepage":null,"size":2449,"stargazers_count":4,"watchers_count":4,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":4,"default_branch":"develop"}},"base":{"label":"broadinstitute:develop","ref":"develop","sha":"0b90c3ad8d621c505bae399e496871ae5a154fe3","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":37272599,"name":"firecloud-orchestration","full_name":"broadinstitute/firecloud-orchestration","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/firecloud-orchestration","description":"","fork":false,"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration","forks_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/forks","keys_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/teams","hooks_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/events","assignees_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/tags","blobs_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/subscription","commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/merges","archive_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/downloads","issues_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/releases{/id}","created_at":"2015-06-11T16:26:34Z","updated_at":"2015-10-29T17:56:42Z","pushed_at":"2015-11-05T22:21:02Z","git_url":"git://github.com/broadinstitute/firecloud-orchestration.git","ssh_url":"git@github.com:broadinstitute/firecloud-orchestration.git","clone_url":"https://github.com/broadinstitute/firecloud-orchestration.git","svn_url":"https://github.com/broadinstitute/firecloud-orchestration","homepage":null,"size":2449,"stargazers_count":4,"watchers_count":4,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/144"},"html":{"href":"https://github.com/broadinstitute/firecloud-orchestration/pull/144"},"issue":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/144"},"comments":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/statuses/ae80cd23540ed23703a7e8b8edd72ba258e6cffd"}}}}