{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/46009130","id":46009130,"diff_hunk":"@@ -0,0 +1,126 @@\n+/*\n+ * Copyright (c) 2008-2015, Hazelcast, Inc. All Rights Reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package com.hazelcast.query.impl.predicates;\n+\n+import com.hazelcast.internal.serialization.DataSerializerHook;\n+import com.hazelcast.internal.serialization.impl.ArrayDataSerializableFactory;\n+import com.hazelcast.internal.serialization.impl.FactoryIdHelper;\n+import com.hazelcast.nio.serialization.DataSerializableFactory;\n+import com.hazelcast.nio.serialization.IdentifiedDataSerializable;\n+import com.hazelcast.query.SqlPredicate;\n+import com.hazelcast.util.ConstructorFunction;\n+\n+import static com.hazelcast.internal.serialization.impl.FactoryIdHelper.PREDICATE_DS_FACTORY;\n+import static com.hazelcast.internal.serialization.impl.FactoryIdHelper.PREDICATE_DS_FACTORY_ID;\n+\n+public class PredicateDataSerializerHook\n+        implements DataSerializerHook {","path":"hazelcast/src/main/java/com/hazelcast/query/impl/predicates/PredicateDataSerializerHook.java","position":31,"original_position":31,"commit_id":"d3391348d32d23f71b6d78c3d671d3cc5f8b7a17","original_commit_id":"4d08bf7f5ccab005d91587e8e0a3331bdcbe81eb","user":{"login":"ihsandemir","id":7543261,"avatar_url":"https://avatars.githubusercontent.com/u/7543261?v=3","gravatar_id":"","url":"https://api.github.com/users/ihsandemir","html_url":"https://github.com/ihsandemir","followers_url":"https://api.github.com/users/ihsandemir/followers","following_url":"https://api.github.com/users/ihsandemir/following{/other_user}","gists_url":"https://api.github.com/users/ihsandemir/gists{/gist_id}","starred_url":"https://api.github.com/users/ihsandemir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihsandemir/subscriptions","organizations_url":"https://api.github.com/users/ihsandemir/orgs","repos_url":"https://api.github.com/users/ihsandemir/repos","events_url":"https://api.github.com/users/ihsandemir/events{/privacy}","received_events_url":"https://api.github.com/users/ihsandemir/received_events","type":"User","site_admin":false},"body":"Ok, it is added.","created_at":"2015-11-26T22:36:57Z","updated_at":"2015-11-26T22:36:57Z","html_url":"https://github.com/hazelcast/hazelcast/pull/6883#discussion_r46009130","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6883","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/46009130"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/6883#discussion_r46009130"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6883"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6883","id":51910716,"html_url":"https://github.com/hazelcast/hazelcast/pull/6883","diff_url":"https://github.com/hazelcast/hazelcast/pull/6883.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/6883.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/6883","number":6883,"state":"open","locked":false,"title":"Changed predicate implementations to implement IdentifiedDataSerializable","user":{"login":"ihsandemir","id":7543261,"avatar_url":"https://avatars.githubusercontent.com/u/7543261?v=3","gravatar_id":"","url":"https://api.github.com/users/ihsandemir","html_url":"https://github.com/ihsandemir","followers_url":"https://api.github.com/users/ihsandemir/followers","following_url":"https://api.github.com/users/ihsandemir/following{/other_user}","gists_url":"https://api.github.com/users/ihsandemir/gists{/gist_id}","starred_url":"https://api.github.com/users/ihsandemir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihsandemir/subscriptions","organizations_url":"https://api.github.com/users/ihsandemir/orgs","repos_url":"https://api.github.com/users/ihsandemir/repos","events_url":"https://api.github.com/users/ihsandemir/events{/privacy}","received_events_url":"https://api.github.com/users/ihsandemir/received_events","type":"User","site_admin":false},"body":"Changed the predicate implementations to implement IdentifiedDataSerializable rather than DataSerializable. The change is needed for non-java clients to work without class name information.","created_at":"2015-11-26T13:10:36Z","updated_at":"2015-11-26T22:36:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c0339746b81f0795b5e7f979e9b17568e593999","assignee":{"login":"ihsandemir","id":7543261,"avatar_url":"https://avatars.githubusercontent.com/u/7543261?v=3","gravatar_id":"","url":"https://api.github.com/users/ihsandemir","html_url":"https://github.com/ihsandemir","followers_url":"https://api.github.com/users/ihsandemir/followers","following_url":"https://api.github.com/users/ihsandemir/following{/other_user}","gists_url":"https://api.github.com/users/ihsandemir/gists{/gist_id}","starred_url":"https://api.github.com/users/ihsandemir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihsandemir/subscriptions","organizations_url":"https://api.github.com/users/ihsandemir/orgs","repos_url":"https://api.github.com/users/ihsandemir/repos","events_url":"https://api.github.com/users/ihsandemir/events{/privacy}","received_events_url":"https://api.github.com/users/ihsandemir/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/61","html_url":"https://github.com/hazelcast/hazelcast/milestones/3.6","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/61/labels","id":982584,"number":61,"title":"3.6","description":"","creator":{"login":"enesakar","id":234086,"avatar_url":"https://avatars.githubusercontent.com/u/234086?v=3","gravatar_id":"","url":"https://api.github.com/users/enesakar","html_url":"https://github.com/enesakar","followers_url":"https://api.github.com/users/enesakar/followers","following_url":"https://api.github.com/users/enesakar/following{/other_user}","gists_url":"https://api.github.com/users/enesakar/gists{/gist_id}","starred_url":"https://api.github.com/users/enesakar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enesakar/subscriptions","organizations_url":"https://api.github.com/users/enesakar/orgs","repos_url":"https://api.github.com/users/enesakar/repos","events_url":"https://api.github.com/users/enesakar/events{/privacy}","received_events_url":"https://api.github.com/users/enesakar/received_events","type":"User","site_admin":false},"open_issues":103,"closed_issues":913,"state":"open","created_at":"2015-02-17T09:27:09Z","updated_at":"2015-11-26T22:14:55Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6883/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6883/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/6883/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/d3391348d32d23f71b6d78c3d671d3cc5f8b7a17","head":{"label":"ihsandemir:PredicateIdentifiedDataSerializableChange","ref":"PredicateIdentifiedDataSerializableChange","sha":"d3391348d32d23f71b6d78c3d671d3cc5f8b7a17","user":{"login":"ihsandemir","id":7543261,"avatar_url":"https://avatars.githubusercontent.com/u/7543261?v=3","gravatar_id":"","url":"https://api.github.com/users/ihsandemir","html_url":"https://github.com/ihsandemir","followers_url":"https://api.github.com/users/ihsandemir/followers","following_url":"https://api.github.com/users/ihsandemir/following{/other_user}","gists_url":"https://api.github.com/users/ihsandemir/gists{/gist_id}","starred_url":"https://api.github.com/users/ihsandemir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihsandemir/subscriptions","organizations_url":"https://api.github.com/users/ihsandemir/orgs","repos_url":"https://api.github.com/users/ihsandemir/repos","events_url":"https://api.github.com/users/ihsandemir/events{/privacy}","received_events_url":"https://api.github.com/users/ihsandemir/received_events","type":"User","site_admin":false},"repo":{"id":37186359,"name":"hazelcast","full_name":"ihsandemir/hazelcast","owner":{"login":"ihsandemir","id":7543261,"avatar_url":"https://avatars.githubusercontent.com/u/7543261?v=3","gravatar_id":"","url":"https://api.github.com/users/ihsandemir","html_url":"https://github.com/ihsandemir","followers_url":"https://api.github.com/users/ihsandemir/followers","following_url":"https://api.github.com/users/ihsandemir/following{/other_user}","gists_url":"https://api.github.com/users/ihsandemir/gists{/gist_id}","starred_url":"https://api.github.com/users/ihsandemir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihsandemir/subscriptions","organizations_url":"https://api.github.com/users/ihsandemir/orgs","repos_url":"https://api.github.com/users/ihsandemir/repos","events_url":"https://api.github.com/users/ihsandemir/events{/privacy}","received_events_url":"https://api.github.com/users/ihsandemir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ihsandemir/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/ihsandemir/hazelcast","forks_url":"https://api.github.com/repos/ihsandemir/hazelcast/forks","keys_url":"https://api.github.com/repos/ihsandemir/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ihsandemir/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ihsandemir/hazelcast/teams","hooks_url":"https://api.github.com/repos/ihsandemir/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/ihsandemir/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/ihsandemir/hazelcast/events","assignees_url":"https://api.github.com/repos/ihsandemir/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/ihsandemir/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/ihsandemir/hazelcast/tags","blobs_url":"https://api.github.com/repos/ihsandemir/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ihsandemir/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ihsandemir/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/ihsandemir/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ihsandemir/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/ihsandemir/hazelcast/languages","stargazers_url":"https://api.github.com/repos/ihsandemir/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/ihsandemir/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/ihsandemir/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/ihsandemir/hazelcast/subscription","commits_url":"https://api.github.com/repos/ihsandemir/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/ihsandemir/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/ihsandemir/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/ihsandemir/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/ihsandemir/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/ihsandemir/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ihsandemir/hazelcast/merges","archive_url":"https://api.github.com/repos/ihsandemir/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ihsandemir/hazelcast/downloads","issues_url":"https://api.github.com/repos/ihsandemir/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/ihsandemir/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/ihsandemir/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/ihsandemir/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ihsandemir/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/ihsandemir/hazelcast/releases{/id}","created_at":"2015-06-10T08:58:34Z","updated_at":"2015-06-10T08:58:48Z","pushed_at":"2015-11-26T20:04:15Z","git_url":"git://github.com/ihsandemir/hazelcast.git","ssh_url":"git@github.com:ihsandemir/hazelcast.git","clone_url":"https://github.com/ihsandemir/hazelcast.git","svn_url":"https://github.com/ihsandemir/hazelcast","homepage":"www.hazelcast.com","size":80042,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"58439dcfa60165cca74369e88a0bdef376125c08","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","created_at":"2012-03-21T12:25:18Z","updated_at":"2015-11-26T08:00:47Z","pushed_at":"2015-11-26T22:14:55Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":93039,"stargazers_count":1324,"watchers_count":1324,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":642,"mirror_url":null,"open_issues_count":522,"forks":642,"open_issues":522,"watchers":1324,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6883"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/6883"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/6883"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/6883/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6883/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6883/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/d3391348d32d23f71b6d78c3d671d3cc5f8b7a17"}}}}