{"action":"created","comment":{"url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/comments/29318790","id":29318790,"diff_hunk":"@@ -0,0 +1,141 @@\n+/*\n+ * SonarQube Java\n+ * Copyright (C) 2012 SonarSource\n+ * dev@sonar.codehaus.org\n+ *\n+ * This program is free software; you can redistribute it and/or\n+ * modify it under the terms of the GNU Lesser General Public\n+ * License as published by the Free Software Foundation; either\n+ * version 3 of the License, or (at your option) any later version.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU\n+ * Lesser General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU Lesser General Public\n+ * License along with this program; if not, write to the Free Software\n+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02\n+ */\n+package org.sonar.java.checks;\n+\n+import com.google.common.collect.ImmutableList;\n+import com.google.common.collect.Iterables;\n+import org.sonar.api.server.rule.RulesDefinition;\n+import org.sonar.check.Priority;\n+import org.sonar.check.Rule;\n+import org.sonar.java.checks.methods.MethodInvocationMatcher;\n+import org.sonar.java.checks.methods.TypeCriteria;\n+import org.sonar.plugins.java.api.semantic.Symbol;\n+import org.sonar.plugins.java.api.tree.BaseTreeVisitor;\n+import org.sonar.plugins.java.api.tree.ExpressionTree;\n+import org.sonar.plugins.java.api.tree.ForEachStatement;\n+import org.sonar.plugins.java.api.tree.IdentifierTree;\n+import org.sonar.plugins.java.api.tree.MemberSelectExpressionTree;\n+import org.sonar.plugins.java.api.tree.MethodInvocationTree;\n+import org.sonar.plugins.java.api.tree.Tree;\n+import org.sonar.plugins.java.api.tree.Tree.Kind;\n+import org.sonar.squidbridge.annotations.ActivatedByDefault;\n+import org.sonar.squidbridge.annotations.SqaleConstantRemediation;\n+import org.sonar.squidbridge.annotations.SqaleSubCharacteristic;\n+\n+import javax.annotation.CheckForNull;\n+\n+import java.util.List;\n+\n+@Rule(\n+  key = \"S2864\",\n+  name = \"\\\"entrySet()\\\" should be iterated when both the key and value are needed\",\n+  tags = {\"performance\"},\n+  priority = Priority.MAJOR)\n+@ActivatedByDefault\n+@SqaleSubCharacteristic(RulesDefinition.SubCharacteristics.CPU_EFFICIENCY)\n+@SqaleConstantRemediation(\"5min\")\n+public class KeySetInsteadOfEntrySetCheck extends SubscriptionBaseVisitor {\n+\n+  private static final MethodInvocationMatcher MAP_GET_METHOD = MethodInvocationMatcher.create()\n+    .typeDefinition(TypeCriteria.subtypeOf(\"java.util.Map\"))\n+    .name(\"get\")\n+    .addParameter(\"java.lang.Object\");\n+\n+  private static final MethodInvocationMatcher MAP_KEYSET_METHOD = MethodInvocationMatcher.create()\n+    .typeDefinition(TypeCriteria.subtypeOf(\"java.util.Map\"))\n+    .name(\"keySet\");\n+\n+  @Override\n+  public List<Kind> nodesToVisit() {\n+    return ImmutableList.of(Tree.Kind.FOR_EACH_STATEMENT);\n+  }\n+\n+  @Override\n+  public void visitNode(Tree tree) {\n+    if (hasSemantic()) {\n+      ForEachStatement forEachTree = (ForEachStatement) tree;\n+      ExpressionTree expressionTree = forEachTree.expression();\n+      if (expressionTree.is(Tree.Kind.METHOD_INVOCATION)) {\n+        MethodInvocationTree methodTree = (MethodInvocationTree) expressionTree;\n+        Symbol mapSymbol = getMapSymbol(methodTree);\n+        if (mapSymbol != null && MAP_KEYSET_METHOD.matches(methodTree)) {\n+          new GetUsageVisitor().isCallingGetWithSymbol(forEachTree, forEachTree.variable().symbol(), mapSymbol);\n+        }\n+      }\n+    }\n+  }\n+\n+  @CheckForNull\n+  private Symbol getMapSymbol(MethodInvocationTree tree) {\n+    ExpressionTree expressionTree = tree.methodSelect();\n+    // direct invocation: symbol is implicitly this\n+    if (expressionTree.is(Tree.Kind.IDENTIFIER)) {\n+      return tree.symbol().owner();\n+    }\n+    expressionTree = ((MemberSelectExpressionTree) expressionTree).expression();\n+    if (expressionTree.is(Tree.Kind.IDENTIFIER)) {\n+      return ((IdentifierTree) expressionTree).symbol();\n+    } else {\n+      return isFieldAccessedUsingSuperOrThis(expressionTree);\n+    }\n+  }\n+\n+  @CheckForNull\n+  private Symbol isFieldAccessedUsingSuperOrThis(ExpressionTree expressionTree) {\n+    if (expressionTree.is(Tree.Kind.MEMBER_SELECT)) {\n+      MemberSelectExpressionTree memberSelectTree = ((MemberSelectExpressionTree) expressionTree);","path":"java-checks/src/main/java/org/sonar/java/checks/KeySetInsteadOfEntrySetCheck.java","position":103,"original_position":103,"commit_id":"71a6464e828abfae114b0d3e3e293257c3366fec","original_commit_id":"71a6464e828abfae114b0d3e3e293257c3366fec","user":{"login":"SonarTech","id":1842438,"avatar_url":"https://avatars.githubusercontent.com/u/1842438?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarTech","html_url":"https://github.com/SonarTech","followers_url":"https://api.github.com/users/SonarTech/followers","following_url":"https://api.github.com/users/SonarTech/following{/other_user}","gists_url":"https://api.github.com/users/SonarTech/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarTech/subscriptions","organizations_url":"https://api.github.com/users/SonarTech/orgs","repos_url":"https://api.github.com/users/SonarTech/repos","events_url":"https://api.github.com/users/SonarTech/events{/privacy}","received_events_url":"https://api.github.com/users/SonarTech/received_events","type":"User","site_admin":false},"body":":new: ![MAJOR](https://raw.githubusercontent.com/henryju/image-hosting/master/major.png)Remove those useless parentheses.[![...](https://raw.githubusercontent.com/henryju/image-hosting/master/more.png)](http://nemo.sonarqube.org/coding_rules#rule_key=squid%3AUselessParenthesesCheck)\n","created_at":"2015-04-29T08:46:35Z","updated_at":"2015-04-29T08:46:35Z","html_url":"https://github.com/SonarSource/sonar-java/pull/182#discussion_r29318790","pull_request_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/182","_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/comments/29318790"},"html":{"href":"https://github.com/SonarSource/sonar-java/pull/182#discussion_r29318790"},"pull_request":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/182"}}},"pull_request":{"url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/182","id":34342709,"html_url":"https://github.com/SonarSource/sonar-java/pull/182","diff_url":"https://github.com/SonarSource/sonar-java/pull/182.diff","patch_url":"https://github.com/SonarSource/sonar-java/pull/182.patch","issue_url":"https://api.github.com/repos/SonarSource/sonar-java/issues/182","number":182,"state":"open","locked":false,"title":"SONARJAVA-1041 RSPEC-2864 \"entrySet()\" should be iterated when both the key and value are needed","user":{"login":"merciesa","id":8008916,"avatar_url":"https://avatars.githubusercontent.com/u/8008916?v=3","gravatar_id":"","url":"https://api.github.com/users/merciesa","html_url":"https://github.com/merciesa","followers_url":"https://api.github.com/users/merciesa/followers","following_url":"https://api.github.com/users/merciesa/following{/other_user}","gists_url":"https://api.github.com/users/merciesa/gists{/gist_id}","starred_url":"https://api.github.com/users/merciesa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merciesa/subscriptions","organizations_url":"https://api.github.com/users/merciesa/orgs","repos_url":"https://api.github.com/users/merciesa/repos","events_url":"https://api.github.com/users/merciesa/events{/privacy}","received_events_url":"https://api.github.com/users/merciesa/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-04-29T08:42:03Z","updated_at":"2015-04-29T08:46:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4941fa58bed1260f208db0aa3d58ead901ea213","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/182/commits","review_comments_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/182/comments","review_comment_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SonarSource/sonar-java/issues/182/comments","statuses_url":"https://api.github.com/repos/SonarSource/sonar-java/statuses/71a6464e828abfae114b0d3e3e293257c3366fec","head":{"label":"merciesa:SONARJAVA-1041","ref":"SONARJAVA-1041","sha":"71a6464e828abfae114b0d3e3e293257c3366fec","user":{"login":"merciesa","id":8008916,"avatar_url":"https://avatars.githubusercontent.com/u/8008916?v=3","gravatar_id":"","url":"https://api.github.com/users/merciesa","html_url":"https://github.com/merciesa","followers_url":"https://api.github.com/users/merciesa/followers","following_url":"https://api.github.com/users/merciesa/following{/other_user}","gists_url":"https://api.github.com/users/merciesa/gists{/gist_id}","starred_url":"https://api.github.com/users/merciesa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merciesa/subscriptions","organizations_url":"https://api.github.com/users/merciesa/orgs","repos_url":"https://api.github.com/users/merciesa/repos","events_url":"https://api.github.com/users/merciesa/events{/privacy}","received_events_url":"https://api.github.com/users/merciesa/received_events","type":"User","site_admin":false},"repo":{"id":31966358,"name":"sonar-java","full_name":"merciesa/sonar-java","owner":{"login":"merciesa","id":8008916,"avatar_url":"https://avatars.githubusercontent.com/u/8008916?v=3","gravatar_id":"","url":"https://api.github.com/users/merciesa","html_url":"https://github.com/merciesa","followers_url":"https://api.github.com/users/merciesa/followers","following_url":"https://api.github.com/users/merciesa/following{/other_user}","gists_url":"https://api.github.com/users/merciesa/gists{/gist_id}","starred_url":"https://api.github.com/users/merciesa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merciesa/subscriptions","organizations_url":"https://api.github.com/users/merciesa/orgs","repos_url":"https://api.github.com/users/merciesa/repos","events_url":"https://api.github.com/users/merciesa/events{/privacy}","received_events_url":"https://api.github.com/users/merciesa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/merciesa/sonar-java","description":"","fork":true,"url":"https://api.github.com/repos/merciesa/sonar-java","forks_url":"https://api.github.com/repos/merciesa/sonar-java/forks","keys_url":"https://api.github.com/repos/merciesa/sonar-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/merciesa/sonar-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/merciesa/sonar-java/teams","hooks_url":"https://api.github.com/repos/merciesa/sonar-java/hooks","issue_events_url":"https://api.github.com/repos/merciesa/sonar-java/issues/events{/number}","events_url":"https://api.github.com/repos/merciesa/sonar-java/events","assignees_url":"https://api.github.com/repos/merciesa/sonar-java/assignees{/user}","branches_url":"https://api.github.com/repos/merciesa/sonar-java/branches{/branch}","tags_url":"https://api.github.com/repos/merciesa/sonar-java/tags","blobs_url":"https://api.github.com/repos/merciesa/sonar-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/merciesa/sonar-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/merciesa/sonar-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/merciesa/sonar-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/merciesa/sonar-java/statuses/{sha}","languages_url":"https://api.github.com/repos/merciesa/sonar-java/languages","stargazers_url":"https://api.github.com/repos/merciesa/sonar-java/stargazers","contributors_url":"https://api.github.com/repos/merciesa/sonar-java/contributors","subscribers_url":"https://api.github.com/repos/merciesa/sonar-java/subscribers","subscription_url":"https://api.github.com/repos/merciesa/sonar-java/subscription","commits_url":"https://api.github.com/repos/merciesa/sonar-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/merciesa/sonar-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/merciesa/sonar-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/merciesa/sonar-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/merciesa/sonar-java/contents/{+path}","compare_url":"https://api.github.com/repos/merciesa/sonar-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/merciesa/sonar-java/merges","archive_url":"https://api.github.com/repos/merciesa/sonar-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/merciesa/sonar-java/downloads","issues_url":"https://api.github.com/repos/merciesa/sonar-java/issues{/number}","pulls_url":"https://api.github.com/repos/merciesa/sonar-java/pulls{/number}","milestones_url":"https://api.github.com/repos/merciesa/sonar-java/milestones{/number}","notifications_url":"https://api.github.com/repos/merciesa/sonar-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/merciesa/sonar-java/labels{/name}","releases_url":"https://api.github.com/repos/merciesa/sonar-java/releases{/id}","created_at":"2015-03-10T15:51:38Z","updated_at":"2015-03-10T15:51:41Z","pushed_at":"2015-04-29T08:41:27Z","git_url":"git://github.com/merciesa/sonar-java.git","ssh_url":"git@github.com:merciesa/sonar-java.git","clone_url":"https://github.com/merciesa/sonar-java.git","svn_url":"https://github.com/merciesa/sonar-java","homepage":"","size":11185,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SonarSource:master","ref":"master","sha":"b73b74c1654a8f582724721424cbb133af2763ff","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":5674787,"name":"sonar-java","full_name":"SonarSource/sonar-java","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonar-java","description":"","fork":false,"url":"https://api.github.com/repos/SonarSource/sonar-java","forks_url":"https://api.github.com/repos/SonarSource/sonar-java/forks","keys_url":"https://api.github.com/repos/SonarSource/sonar-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonar-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonar-java/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonar-java/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonar-java/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonar-java/events","assignees_url":"https://api.github.com/repos/SonarSource/sonar-java/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonar-java/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonar-java/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonar-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonar-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonar-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonar-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonar-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonar-java/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonar-java/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonar-java/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonar-java/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonar-java/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonar-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonar-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonar-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonar-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonar-java/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonar-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonar-java/merges","archive_url":"https://api.github.com/repos/SonarSource/sonar-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonar-java/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonar-java/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonar-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonar-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonar-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonar-java/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonar-java/releases{/id}","created_at":"2012-09-04T15:53:13Z","updated_at":"2015-04-28T13:28:26Z","pushed_at":"2015-04-29T08:42:03Z","git_url":"git://github.com/SonarSource/sonar-java.git","ssh_url":"git@github.com:SonarSource/sonar-java.git","clone_url":"https://github.com/SonarSource/sonar-java.git","svn_url":"https://github.com/SonarSource/sonar-java","homepage":"","size":30956,"stargazers_count":40,"watchers_count":40,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":74,"mirror_url":null,"open_issues_count":6,"forks":74,"open_issues":6,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/182"},"html":{"href":"https://github.com/SonarSource/sonar-java/pull/182"},"issue":{"href":"https://api.github.com/repos/SonarSource/sonar-java/issues/182"},"comments":{"href":"https://api.github.com/repos/SonarSource/sonar-java/issues/182/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/182/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SonarSource/sonar-java/pulls/182/commits"},"statuses":{"href":"https://api.github.com/repos/SonarSource/sonar-java/statuses/71a6464e828abfae114b0d3e3e293257c3366fec"}}}}