{"action":"created","issue":{"url":"https://api.github.com/repos/mangui/flashls/issues/334","labels_url":"https://api.github.com/repos/mangui/flashls/issues/334/labels{/name}","comments_url":"https://api.github.com/repos/mangui/flashls/issues/334/comments","events_url":"https://api.github.com/repos/mangui/flashls/issues/334/events","html_url":"https://github.com/mangui/flashls/pull/334","id":94411416,"number":334,"title":"adding cleaned up SEI frame-type 6 logic for 608/708 captions","user":{"login":"jlacivita","id":250303,"avatar_url":"https://avatars.githubusercontent.com/u/250303?v=3","gravatar_id":"","url":"https://api.github.com/users/jlacivita","html_url":"https://github.com/jlacivita","followers_url":"https://api.github.com/users/jlacivita/followers","following_url":"https://api.github.com/users/jlacivita/following{/other_user}","gists_url":"https://api.github.com/users/jlacivita/gists{/gist_id}","starred_url":"https://api.github.com/users/jlacivita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlacivita/subscriptions","organizations_url":"https://api.github.com/users/jlacivita/orgs","repos_url":"https://api.github.com/users/jlacivita/repos","events_url":"https://api.github.com/users/jlacivita/events{/privacy}","received_events_url":"https://api.github.com/users/jlacivita/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-07-10T23:16:02Z","updated_at":"2015-07-21T00:05:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mangui/flashls/pulls/334","html_url":"https://github.com/mangui/flashls/pull/334","diff_url":"https://github.com/mangui/flashls/pull/334.diff","patch_url":"https://github.com/mangui/flashls/pull/334.patch"},"body":"So here's a summary of what i've done:\r\n\r\n1) detect frame type of 6 in TSDemuxer\r\n2) when frame type is 6, confirm it's actually 608 captions\r\n3) if so then extract the bytes typically sent in OSMF onCaptionInfo calls (it's not the entire frame data)\r\n4) create an onCaptionInfo message (the defacto OSMF standard for 608 captions) with a payload that matches de-facto object { \"type\": \"708\", \"data\": bytes}\r\n5) spit out a bunch of console messages to compare what I'm expecting to what OSMFCCLib displays\r\n\r\ncurrently i'm getting almost recognizable english out of both 4 & 5, but characters (and commands) are dropped for some reason.\r\n\r\nI'm fairly convinced that there's some problem with the NAL Unit parsing, upstream, because I'm seeing characters dropped/corrupted in both my debug log messages, as well as in the events dispatched to OSMFCCLib.\r\n\r\nOSMFCCLib is just a tool to make sure we're parsing the packets properly. Once it works, we can discuss writing our own view or not, and cleaning up the delivery method to be something other than onCaptionInfo (maybe that logic simply belongs in the OSMF wrapper to flashls)."},"comment":{"url":"https://api.github.com/repos/mangui/flashls/issues/comments/123100847","html_url":"https://github.com/mangui/flashls/pull/334#issuecomment-123100847","issue_url":"https://api.github.com/repos/mangui/flashls/issues/334","id":123100847,"user":{"login":"jlacivita","id":250303,"avatar_url":"https://avatars.githubusercontent.com/u/250303?v=3","gravatar_id":"","url":"https://api.github.com/users/jlacivita","html_url":"https://github.com/jlacivita","followers_url":"https://api.github.com/users/jlacivita/followers","following_url":"https://api.github.com/users/jlacivita/following{/other_user}","gists_url":"https://api.github.com/users/jlacivita/gists{/gist_id}","starred_url":"https://api.github.com/users/jlacivita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlacivita/subscriptions","organizations_url":"https://api.github.com/users/jlacivita/orgs","repos_url":"https://api.github.com/users/jlacivita/repos","events_url":"https://api.github.com/users/jlacivita/events{/privacy}","received_events_url":"https://api.github.com/users/jlacivita/received_events","type":"User","site_admin":false},"created_at":"2015-07-21T00:05:08Z","updated_at":"2015-07-21T00:05:08Z","body":"Okay, i've get debug output inside of HLSNetStream that shows appendTags is being called with the FLVTags in the wrong order sometimes (even though they're inserted via parsing in the correct order). Furthermore, it's not always the same tag that is out-of-order, so that rules out any problems with the OSMFCCLib getting mixed up.\r\n\r\nSomething between TSDemuxer and HLSNetStream is mixing up the FLVTag order for METADATA tags (and maybe others)."}}