{"action":"created","comment":{"url":"https://api.github.com/repos/cisso/field_collection/pulls/comments/27301757","id":27301757,"diff_hunk":"@@ -1221,13 +1402,11 @@ function field_collection_field_widget_embed_validate($element, &$form_state, $c\n     foreach ($element['#field_collection_required_elements'] as &$elements) {\n \n       // Copied from _form_validate().\n-      // #1676206: Modified to support options widget.\n       if (isset($elements['#needs_validation'])) {\n         $is_empty_multiple = (!count($elements['#value']));\n         $is_empty_string = (is_string($elements['#value']) && drupal_strlen(trim($elements['#value'])) == 0);\n         $is_empty_value = ($elements['#value'] === 0);\n-        $is_empty_option = (isset($elements['#options']['_none']) && $elements['#value'] == '_none');\n-        if ($is_empty_multiple || $is_empty_string || $is_empty_value || $is_empty_option) {\n+        if ($is_empty_multiple || $is_empty_string || $is_empty_value) {","path":"field_collection.module","position":451,"original_position":451,"commit_id":"482a252b0922b5286ca6f78b56b088f4990f4f05","original_commit_id":"482a252b0922b5286ca6f78b56b088f4990f4f05","user":{"login":"cisso","id":322014,"avatar_url":"https://avatars.githubusercontent.com/u/322014?v=3","gravatar_id":"","url":"https://api.github.com/users/cisso","html_url":"https://github.com/cisso","followers_url":"https://api.github.com/users/cisso/followers","following_url":"https://api.github.com/users/cisso/following{/other_user}","gists_url":"https://api.github.com/users/cisso/gists{/gist_id}","starred_url":"https://api.github.com/users/cisso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisso/subscriptions","organizations_url":"https://api.github.com/users/cisso/orgs","repos_url":"https://api.github.com/users/cisso/repos","events_url":"https://api.github.com/users/cisso/events{/privacy}","received_events_url":"https://api.github.com/users/cisso/received_events","type":"User","site_admin":false},"body":"Note: Patch misses a change from https://www.drupal.org/node/1676206.","created_at":"2015-03-27T15:10:40Z","updated_at":"2015-03-27T15:10:40Z","html_url":"https://github.com/cisso/field_collection/pull/1#discussion_r27301757","pull_request_url":"https://api.github.com/repos/cisso/field_collection/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/cisso/field_collection/pulls/comments/27301757"},"html":{"href":"https://github.com/cisso/field_collection/pull/1#discussion_r27301757"},"pull_request":{"href":"https://api.github.com/repos/cisso/field_collection/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/cisso/field_collection/pulls/1","id":32069234,"html_url":"https://github.com/cisso/field_collection/pull/1","diff_url":"https://github.com/cisso/field_collection/pull/1.diff","patch_url":"https://github.com/cisso/field_collection/pull/1.patch","issue_url":"https://api.github.com/repos/cisso/field_collection/issues/1","number":1,"state":"open","locked":false,"title":"Patch/1344672 359","user":{"login":"cisso","id":322014,"avatar_url":"https://avatars.githubusercontent.com/u/322014?v=3","gravatar_id":"","url":"https://api.github.com/users/cisso","html_url":"https://github.com/cisso","followers_url":"https://api.github.com/users/cisso/followers","following_url":"https://api.github.com/users/cisso/following{/other_user}","gists_url":"https://api.github.com/users/cisso/gists{/gist_id}","starred_url":"https://api.github.com/users/cisso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisso/subscriptions","organizations_url":"https://api.github.com/users/cisso/orgs","repos_url":"https://api.github.com/users/cisso/repos","events_url":"https://api.github.com/users/cisso/events{/privacy}","received_events_url":"https://api.github.com/users/cisso/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-26T22:49:37Z","updated_at":"2015-03-27T15:10:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cisso/field_collection/pulls/1/commits","review_comments_url":"https://api.github.com/repos/cisso/field_collection/pulls/1/comments","review_comment_url":"https://api.github.com/repos/cisso/field_collection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisso/field_collection/issues/1/comments","statuses_url":"https://api.github.com/repos/cisso/field_collection/statuses/482a252b0922b5286ca6f78b56b088f4990f4f05","head":{"label":"cisso:patch/1344672-359","ref":"patch/1344672-359","sha":"482a252b0922b5286ca6f78b56b088f4990f4f05","user":{"login":"cisso","id":322014,"avatar_url":"https://avatars.githubusercontent.com/u/322014?v=3","gravatar_id":"","url":"https://api.github.com/users/cisso","html_url":"https://github.com/cisso","followers_url":"https://api.github.com/users/cisso/followers","following_url":"https://api.github.com/users/cisso/following{/other_user}","gists_url":"https://api.github.com/users/cisso/gists{/gist_id}","starred_url":"https://api.github.com/users/cisso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisso/subscriptions","organizations_url":"https://api.github.com/users/cisso/orgs","repos_url":"https://api.github.com/users/cisso/repos","events_url":"https://api.github.com/users/cisso/events{/privacy}","received_events_url":"https://api.github.com/users/cisso/received_events","type":"User","site_admin":false},"repo":{"id":32950050,"name":"field_collection","full_name":"cisso/field_collection","owner":{"login":"cisso","id":322014,"avatar_url":"https://avatars.githubusercontent.com/u/322014?v=3","gravatar_id":"","url":"https://api.github.com/users/cisso","html_url":"https://github.com/cisso","followers_url":"https://api.github.com/users/cisso/followers","following_url":"https://api.github.com/users/cisso/following{/other_user}","gists_url":"https://api.github.com/users/cisso/gists{/gist_id}","starred_url":"https://api.github.com/users/cisso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisso/subscriptions","organizations_url":"https://api.github.com/users/cisso/orgs","repos_url":"https://api.github.com/users/cisso/repos","events_url":"https://api.github.com/users/cisso/events{/privacy}","received_events_url":"https://api.github.com/users/cisso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cisso/field_collection","description":"Field collection patches","fork":false,"url":"https://api.github.com/repos/cisso/field_collection","forks_url":"https://api.github.com/repos/cisso/field_collection/forks","keys_url":"https://api.github.com/repos/cisso/field_collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisso/field_collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisso/field_collection/teams","hooks_url":"https://api.github.com/repos/cisso/field_collection/hooks","issue_events_url":"https://api.github.com/repos/cisso/field_collection/issues/events{/number}","events_url":"https://api.github.com/repos/cisso/field_collection/events","assignees_url":"https://api.github.com/repos/cisso/field_collection/assignees{/user}","branches_url":"https://api.github.com/repos/cisso/field_collection/branches{/branch}","tags_url":"https://api.github.com/repos/cisso/field_collection/tags","blobs_url":"https://api.github.com/repos/cisso/field_collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisso/field_collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisso/field_collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisso/field_collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisso/field_collection/statuses/{sha}","languages_url":"https://api.github.com/repos/cisso/field_collection/languages","stargazers_url":"https://api.github.com/repos/cisso/field_collection/stargazers","contributors_url":"https://api.github.com/repos/cisso/field_collection/contributors","subscribers_url":"https://api.github.com/repos/cisso/field_collection/subscribers","subscription_url":"https://api.github.com/repos/cisso/field_collection/subscription","commits_url":"https://api.github.com/repos/cisso/field_collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisso/field_collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisso/field_collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisso/field_collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisso/field_collection/contents/{+path}","compare_url":"https://api.github.com/repos/cisso/field_collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisso/field_collection/merges","archive_url":"https://api.github.com/repos/cisso/field_collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisso/field_collection/downloads","issues_url":"https://api.github.com/repos/cisso/field_collection/issues{/number}","pulls_url":"https://api.github.com/repos/cisso/field_collection/pulls{/number}","milestones_url":"https://api.github.com/repos/cisso/field_collection/milestones{/number}","notifications_url":"https://api.github.com/repos/cisso/field_collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisso/field_collection/labels{/name}","releases_url":"https://api.github.com/repos/cisso/field_collection/releases{/id}","created_at":"2015-03-26T20:25:31Z","updated_at":"2015-03-27T09:10:47Z","pushed_at":"2015-03-26T22:50:23Z","git_url":"git://github.com/cisso/field_collection.git","ssh_url":"git@github.com:cisso/field_collection.git","clone_url":"https://github.com/cisso/field_collection.git","svn_url":"https://github.com/cisso/field_collection","homepage":"https://www.drupal.org/project/field_collection","size":0,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"7.x-1.x"}},"base":{"label":"cisso:7.x-1.x","ref":"7.x-1.x","sha":"c0a44258b9c0fa60fe385581c4c126d6ec46e67c","user":{"login":"cisso","id":322014,"avatar_url":"https://avatars.githubusercontent.com/u/322014?v=3","gravatar_id":"","url":"https://api.github.com/users/cisso","html_url":"https://github.com/cisso","followers_url":"https://api.github.com/users/cisso/followers","following_url":"https://api.github.com/users/cisso/following{/other_user}","gists_url":"https://api.github.com/users/cisso/gists{/gist_id}","starred_url":"https://api.github.com/users/cisso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisso/subscriptions","organizations_url":"https://api.github.com/users/cisso/orgs","repos_url":"https://api.github.com/users/cisso/repos","events_url":"https://api.github.com/users/cisso/events{/privacy}","received_events_url":"https://api.github.com/users/cisso/received_events","type":"User","site_admin":false},"repo":{"id":32950050,"name":"field_collection","full_name":"cisso/field_collection","owner":{"login":"cisso","id":322014,"avatar_url":"https://avatars.githubusercontent.com/u/322014?v=3","gravatar_id":"","url":"https://api.github.com/users/cisso","html_url":"https://github.com/cisso","followers_url":"https://api.github.com/users/cisso/followers","following_url":"https://api.github.com/users/cisso/following{/other_user}","gists_url":"https://api.github.com/users/cisso/gists{/gist_id}","starred_url":"https://api.github.com/users/cisso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisso/subscriptions","organizations_url":"https://api.github.com/users/cisso/orgs","repos_url":"https://api.github.com/users/cisso/repos","events_url":"https://api.github.com/users/cisso/events{/privacy}","received_events_url":"https://api.github.com/users/cisso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cisso/field_collection","description":"Field collection patches","fork":false,"url":"https://api.github.com/repos/cisso/field_collection","forks_url":"https://api.github.com/repos/cisso/field_collection/forks","keys_url":"https://api.github.com/repos/cisso/field_collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisso/field_collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisso/field_collection/teams","hooks_url":"https://api.github.com/repos/cisso/field_collection/hooks","issue_events_url":"https://api.github.com/repos/cisso/field_collection/issues/events{/number}","events_url":"https://api.github.com/repos/cisso/field_collection/events","assignees_url":"https://api.github.com/repos/cisso/field_collection/assignees{/user}","branches_url":"https://api.github.com/repos/cisso/field_collection/branches{/branch}","tags_url":"https://api.github.com/repos/cisso/field_collection/tags","blobs_url":"https://api.github.com/repos/cisso/field_collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisso/field_collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisso/field_collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisso/field_collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisso/field_collection/statuses/{sha}","languages_url":"https://api.github.com/repos/cisso/field_collection/languages","stargazers_url":"https://api.github.com/repos/cisso/field_collection/stargazers","contributors_url":"https://api.github.com/repos/cisso/field_collection/contributors","subscribers_url":"https://api.github.com/repos/cisso/field_collection/subscribers","subscription_url":"https://api.github.com/repos/cisso/field_collection/subscription","commits_url":"https://api.github.com/repos/cisso/field_collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisso/field_collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisso/field_collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisso/field_collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisso/field_collection/contents/{+path}","compare_url":"https://api.github.com/repos/cisso/field_collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisso/field_collection/merges","archive_url":"https://api.github.com/repos/cisso/field_collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisso/field_collection/downloads","issues_url":"https://api.github.com/repos/cisso/field_collection/issues{/number}","pulls_url":"https://api.github.com/repos/cisso/field_collection/pulls{/number}","milestones_url":"https://api.github.com/repos/cisso/field_collection/milestones{/number}","notifications_url":"https://api.github.com/repos/cisso/field_collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisso/field_collection/labels{/name}","releases_url":"https://api.github.com/repos/cisso/field_collection/releases{/id}","created_at":"2015-03-26T20:25:31Z","updated_at":"2015-03-27T09:10:47Z","pushed_at":"2015-03-26T22:50:23Z","git_url":"git://github.com/cisso/field_collection.git","ssh_url":"git@github.com:cisso/field_collection.git","clone_url":"https://github.com/cisso/field_collection.git","svn_url":"https://github.com/cisso/field_collection","homepage":"https://www.drupal.org/project/field_collection","size":0,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"7.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/cisso/field_collection/pulls/1"},"html":{"href":"https://github.com/cisso/field_collection/pull/1"},"issue":{"href":"https://api.github.com/repos/cisso/field_collection/issues/1"},"comments":{"href":"https://api.github.com/repos/cisso/field_collection/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/cisso/field_collection/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/cisso/field_collection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisso/field_collection/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/cisso/field_collection/statuses/482a252b0922b5286ca6f78b56b088f4990f4f05"}}}}