{"action":"created","issue":{"url":"https://api.github.com/repos/ezhulenev/scala-openbook/issues/7","labels_url":"https://api.github.com/repos/ezhulenev/scala-openbook/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/ezhulenev/scala-openbook/issues/7/comments","events_url":"https://api.github.com/repos/ezhulenev/scala-openbook/issues/7/events","html_url":"https://github.com/ezhulenev/scala-openbook/issues/7","id":54504399,"number":7,"title":"Delta vs. Full state updates","user":{"login":"vincentk","id":99766,"avatar_url":"https://avatars.githubusercontent.com/u/99766?v=3","gravatar_id":"","url":"https://api.github.com/users/vincentk","html_url":"https://github.com/vincentk","followers_url":"https://api.github.com/users/vincentk/followers","following_url":"https://api.github.com/users/vincentk/following{/other_user}","gists_url":"https://api.github.com/users/vincentk/gists{/gist_id}","starred_url":"https://api.github.com/users/vincentk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincentk/subscriptions","organizations_url":"https://api.github.com/users/vincentk/orgs","repos_url":"https://api.github.com/users/vincentk/repos","events_url":"https://api.github.com/users/vincentk/events{/privacy}","received_events_url":"https://api.github.com/users/vincentk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-01-15T21:08:10Z","updated_at":"2015-01-15T21:23:46Z","closed_at":"2015-01-15T21:23:46Z","body":"Currently looking at the logic in `OrderBook.update`. It would seem to me that you assume that the order message describes a full state. E.g. also consider the `OrderBookSpec`. Volumes get replaced, not added. I do not think this is the correct way to handle things. I.e. in `OrderBookSpec`, I would expect that this line:\r\n```\r\nassert(orderBooks.next().buy.get(order2.priceNumerator).get == order2.volume)\r\n```\r\nwould need to be replaced by\r\n```\r\nassert(orderBooks.next().buy.get(order2.priceNumerator).get == order2.volume + order1.volume)\r\n```\r\ngiven that the test order messages are flagged with `MsgType.DeltaUpdate`."},"comment":{"url":"https://api.github.com/repos/ezhulenev/scala-openbook/issues/comments/70164420","html_url":"https://github.com/ezhulenev/scala-openbook/issues/7#issuecomment-70164420","issue_url":"https://api.github.com/repos/ezhulenev/scala-openbook/issues/7","id":70164420,"user":{"login":"vincentk","id":99766,"avatar_url":"https://avatars.githubusercontent.com/u/99766?v=3","gravatar_id":"","url":"https://api.github.com/users/vincentk","html_url":"https://github.com/vincentk","followers_url":"https://api.github.com/users/vincentk/followers","following_url":"https://api.github.com/users/vincentk/following{/other_user}","gists_url":"https://api.github.com/users/vincentk/gists{/gist_id}","starred_url":"https://api.github.com/users/vincentk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincentk/subscriptions","organizations_url":"https://api.github.com/users/vincentk/orgs","repos_url":"https://api.github.com/users/vincentk/repos","events_url":"https://api.github.com/users/vincentk/events{/privacy}","received_events_url":"https://api.github.com/users/vincentk/received_events","type":"User","site_admin":false},"created_at":"2015-01-15T21:23:46Z","updated_at":"2015-01-15T21:23:46Z","body":"Ah, indeed. Presumably, one would need to have to look at `ChgQty`, if one wanted to look at the volume difference for delta messages. Many thanks for the clarification."}}