{"action":"created","issue":{"url":"https://api.github.com/repos/symfony/symfony/issues/16785","labels_url":"https://api.github.com/repos/symfony/symfony/issues/16785/labels{/name}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/16785/comments","events_url":"https://api.github.com/repos/symfony/symfony/issues/16785/events","html_url":"https://github.com/symfony/symfony/pull/16785","id":119729498,"number":16785,"title":"[WIP] [Routing] Performance improvement on UrlMatcher","user":{"login":"xavierleune","id":2320425,"avatar_url":"https://avatars.githubusercontent.com/u/2320425?v=3","gravatar_id":"","url":"https://api.github.com/users/xavierleune","html_url":"https://github.com/xavierleune","followers_url":"https://api.github.com/users/xavierleune/followers","following_url":"https://api.github.com/users/xavierleune/following{/other_user}","gists_url":"https://api.github.com/users/xavierleune/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierleune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierleune/subscriptions","organizations_url":"https://api.github.com/users/xavierleune/orgs","repos_url":"https://api.github.com/users/xavierleune/repos","events_url":"https://api.github.com/users/xavierleune/events{/privacy}","received_events_url":"https://api.github.com/users/xavierleune/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-01T14:37:42Z","updated_at":"2015-12-01T15:00:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/16785","html_url":"https://github.com/symfony/symfony/pull/16785","diff_url":"https://github.com/symfony/symfony/pull/16785.diff","patch_url":"https://github.com/symfony/symfony/pull/16785.patch"},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | no\r\n| Fixed tickets | ¤\r\n| License       | MIT\r\n| Doc PR        | ¤\r\n\r\nHi there,\r\n\r\nThis is a performance improvement on the UrlMatcher generated by PhpMatcherDumper. Actually this code is more a working POC - tests does not pass and the worst case is a little bit slower, but in my own benchmark, I got some major improvements:\r\n![image](https://cloud.githubusercontent.com/assets/2320425/11503392/ac62016c-9840-11e5-80fc-f954a396a12f.png)\r\n(first test with the original dumped class, second test with the optimized dumped class).\r\n\r\nThe main principle is to separate static matching and dynamic matching.\r\nThe dynamic matching have been optimized a lot, thanks to this blog post from nikic : [Fast request routing using regular expressions](http://nikic.github.io/2014/02/18/Fast-request-routing-using-regular-expressions)\r\n\r\nPlease give me some feedback, this is a Work In Progress and the worst case can probably be optimized again."},"comment":{"url":"https://api.github.com/repos/symfony/symfony/issues/comments/160991341","html_url":"https://github.com/symfony/symfony/pull/16785#issuecomment-160991341","issue_url":"https://api.github.com/repos/symfony/symfony/issues/16785","id":160991341,"user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"created_at":"2015-12-01T15:00:23Z","updated_at":"2015-12-01T15:00:23Z","body":"Please update the description with a description of the new architecture, to make it easy to understand the changes"}}