{"action":"created","issue":{"url":"https://api.github.com/repos/docker/compose/issues/1158","labels_url":"https://api.github.com/repos/docker/compose/issues/1158/labels{/name}","comments_url":"https://api.github.com/repos/docker/compose/issues/1158/comments","events_url":"https://api.github.com/repos/docker/compose/issues/1158/events","html_url":"https://github.com/docker/compose/pull/1158","id":63784155,"number":1158,"title":"Add extra_hosts to yml configuration --add-hosts","user":{"login":"chernjie","id":275729,"avatar_url":"https://avatars.githubusercontent.com/u/275729?v=3","gravatar_id":"","url":"https://api.github.com/users/chernjie","html_url":"https://github.com/chernjie","followers_url":"https://api.github.com/users/chernjie/followers","following_url":"https://api.github.com/users/chernjie/following{/other_user}","gists_url":"https://api.github.com/users/chernjie/gists{/gist_id}","starred_url":"https://api.github.com/users/chernjie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chernjie/subscriptions","organizations_url":"https://api.github.com/users/chernjie/orgs","repos_url":"https://api.github.com/users/chernjie/repos","events_url":"https://api.github.com/users/chernjie/events{/privacy}","received_events_url":"https://api.github.com/users/chernjie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-03-23T17:31:24Z","updated_at":"2015-04-06T23:50:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/compose/pulls/1158","html_url":"https://github.com/docker/compose/pull/1158","diff_url":"https://github.com/docker/compose/pull/1158.diff","patch_url":"https://github.com/docker/compose/pull/1158.patch"},"body":"Add extra_hosts to yml configuration\r\n\r\nFollowup from:\r\n- #597\r\n- #754 \r\n- #848 \r\n- #958 \r\n\r\n### Example:\r\n```yml\r\nextra_hosts:\r\n - docker: 162.242.195.82\r\n - fig: 50.31.209.229\r\n```\r\n\r\nSigned-off-by: CJ <lim@chernjie.com>"},"comment":{"url":"https://api.github.com/repos/docker/compose/issues/comments/90289388","html_url":"https://github.com/docker/compose/pull/1158#issuecomment-90289388","issue_url":"https://api.github.com/repos/docker/compose/issues/1158","id":90289388,"user":{"login":"tdesvenain","id":342007,"avatar_url":"https://avatars.githubusercontent.com/u/342007?v=3","gravatar_id":"","url":"https://api.github.com/users/tdesvenain","html_url":"https://github.com/tdesvenain","followers_url":"https://api.github.com/users/tdesvenain/followers","following_url":"https://api.github.com/users/tdesvenain/following{/other_user}","gists_url":"https://api.github.com/users/tdesvenain/gists{/gist_id}","starred_url":"https://api.github.com/users/tdesvenain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdesvenain/subscriptions","organizations_url":"https://api.github.com/users/tdesvenain/orgs","repos_url":"https://api.github.com/users/tdesvenain/repos","events_url":"https://api.github.com/users/tdesvenain/events{/privacy}","received_events_url":"https://api.github.com/users/tdesvenain/received_events","type":"User","site_admin":false},"created_at":"2015-04-06T23:50:54Z","updated_at":"2015-04-06T23:50:54Z","body":"After having further reflexion about it, i think my commits could be\nreverted as they introduce too much inconsistency against other declarations\n\n2015-04-04 19:01 GMT+02:00 Thomas Desvenain <thomas.desvenain@gmail.com>:\n\n> Hi,\n> I'm afraid that many people who use to work with yaml will make the same\n> mistake,\n> In my humble opinion if we use the ':' character in docker-compose syntax,\n> we'd better use it the common way in yaml, as key/value separator.\n> On the top of that, we actually describe a mapping (host/ip), so\n> dictionary seems more accurate than string.\n>\n> But actually if this introduces inconsistency, i'm ok with removing this.\n> There,\n> - we have to validate the format to alert user (before my commit we just\n> got an exception that looked like an issue)\n> - I agree that we should at least quote the whole string in documentation\n>\n> 2015-04-04 16:26 GMT+02:00 chernjie <notifications@github.com>:\n>\n>> @aanand <https://github.com/aanand> updated the examples\n>>\n>> --\n>> Reply to this email directly or view it on GitHub\n>> <https://github.com/docker/compose/pull/1158#issuecomment-89586085>.\n>>\n>\n>\n>\n> --\n> Thomas Desvenain\n>\n> Téléphone : 09 51 37 35 18\n>\n\n\n\n-- \nThomas Desvenain\n\nTéléphone : 09 51 37 35 18\n"}}