{"action":"created","comment":{"url":"https://api.github.com/repos/otland/forgottenserver/pulls/comments/28651264","id":28651264,"diff_hunk":"@@ -825,7 +825,7 @@ bool Player::canWalkthrough(const Creature* creature) const\n \t}\n \n \tconst Player* player = creature->getPlayer();\n-\tif (!player) {\n+\tif (!player || g_config.getBoolean(ConfigManager::ALLOW_WALKTHROUGH)) {\n \t\treturn false;","path":"src/player.cpp","position":6,"original_position":6,"commit_id":"275f39c3faa61e59383915288de85cc90d9aca06","original_commit_id":"275f39c3faa61e59383915288de85cc90d9aca06","user":{"login":"gugahoa","id":1438470,"avatar_url":"https://avatars.githubusercontent.com/u/1438470?v=3","gravatar_id":"","url":"https://api.github.com/users/gugahoa","html_url":"https://github.com/gugahoa","followers_url":"https://api.github.com/users/gugahoa/followers","following_url":"https://api.github.com/users/gugahoa/following{/other_user}","gists_url":"https://api.github.com/users/gugahoa/gists{/gist_id}","starred_url":"https://api.github.com/users/gugahoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gugahoa/subscriptions","organizations_url":"https://api.github.com/users/gugahoa/orgs","repos_url":"https://api.github.com/users/gugahoa/repos","events_url":"https://api.github.com/users/gugahoa/events{/privacy}","received_events_url":"https://api.github.com/users/gugahoa/received_events","type":"User","site_admin":false},"body":"Shouldn't be !g_config.getBoolean(ConfigManager::ALLOW_WALKTHROUGH)?","created_at":"2015-04-19T09:34:29Z","updated_at":"2015-04-19T09:34:29Z","html_url":"https://github.com/otland/forgottenserver/pull/1301#discussion_r28651264","pull_request_url":"https://api.github.com/repos/otland/forgottenserver/pulls/1301","_links":{"self":{"href":"https://api.github.com/repos/otland/forgottenserver/pulls/comments/28651264"},"html":{"href":"https://github.com/otland/forgottenserver/pull/1301#discussion_r28651264"},"pull_request":{"href":"https://api.github.com/repos/otland/forgottenserver/pulls/1301"}}},"pull_request":{"url":"https://api.github.com/repos/otland/forgottenserver/pulls/1301","id":33614579,"html_url":"https://github.com/otland/forgottenserver/pull/1301","diff_url":"https://github.com/otland/forgottenserver/pull/1301.diff","patch_url":"https://github.com/otland/forgottenserver/pull/1301.patch","issue_url":"https://api.github.com/repos/otland/forgottenserver/issues/1301","number":1301,"state":"open","locked":false,"title":"Make player walkthrough optional","user":{"login":"ranisalt","id":1993083,"avatar_url":"https://avatars.githubusercontent.com/u/1993083?v=3","gravatar_id":"","url":"https://api.github.com/users/ranisalt","html_url":"https://github.com/ranisalt","followers_url":"https://api.github.com/users/ranisalt/followers","following_url":"https://api.github.com/users/ranisalt/following{/other_user}","gists_url":"https://api.github.com/users/ranisalt/gists{/gist_id}","starred_url":"https://api.github.com/users/ranisalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranisalt/subscriptions","organizations_url":"https://api.github.com/users/ranisalt/orgs","repos_url":"https://api.github.com/users/ranisalt/repos","events_url":"https://api.github.com/users/ranisalt/events{/privacy}","received_events_url":"https://api.github.com/users/ranisalt/received_events","type":"User","site_admin":false},"body":"I have just stumbled across this limitation, that the walkthrough could be optionally enabled at config.lua, and done the patch :)","created_at":"2015-04-19T06:49:37Z","updated_at":"2015-04-19T09:34:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c69a1187eeea4d91bbc3c2aed4ad15b636976a7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/otland/forgottenserver/pulls/1301/commits","review_comments_url":"https://api.github.com/repos/otland/forgottenserver/pulls/1301/comments","review_comment_url":"https://api.github.com/repos/otland/forgottenserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/otland/forgottenserver/issues/1301/comments","statuses_url":"https://api.github.com/repos/otland/forgottenserver/statuses/275f39c3faa61e59383915288de85cc90d9aca06","head":{"label":"ranisalt:walkthrough-optional","ref":"walkthrough-optional","sha":"275f39c3faa61e59383915288de85cc90d9aca06","user":{"login":"ranisalt","id":1993083,"avatar_url":"https://avatars.githubusercontent.com/u/1993083?v=3","gravatar_id":"","url":"https://api.github.com/users/ranisalt","html_url":"https://github.com/ranisalt","followers_url":"https://api.github.com/users/ranisalt/followers","following_url":"https://api.github.com/users/ranisalt/following{/other_user}","gists_url":"https://api.github.com/users/ranisalt/gists{/gist_id}","starred_url":"https://api.github.com/users/ranisalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranisalt/subscriptions","organizations_url":"https://api.github.com/users/ranisalt/orgs","repos_url":"https://api.github.com/users/ranisalt/repos","events_url":"https://api.github.com/users/ranisalt/events{/privacy}","received_events_url":"https://api.github.com/users/ranisalt/received_events","type":"User","site_admin":false},"repo":{"id":34152469,"name":"forgottenserver","full_name":"ranisalt/forgottenserver","owner":{"login":"ranisalt","id":1993083,"avatar_url":"https://avatars.githubusercontent.com/u/1993083?v=3","gravatar_id":"","url":"https://api.github.com/users/ranisalt","html_url":"https://github.com/ranisalt","followers_url":"https://api.github.com/users/ranisalt/followers","following_url":"https://api.github.com/users/ranisalt/following{/other_user}","gists_url":"https://api.github.com/users/ranisalt/gists{/gist_id}","starred_url":"https://api.github.com/users/ranisalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranisalt/subscriptions","organizations_url":"https://api.github.com/users/ranisalt/orgs","repos_url":"https://api.github.com/users/ranisalt/repos","events_url":"https://api.github.com/users/ranisalt/events{/privacy}","received_events_url":"https://api.github.com/users/ranisalt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ranisalt/forgottenserver","description":"A free and open-source MMORPG server emulator written in C++","fork":true,"url":"https://api.github.com/repos/ranisalt/forgottenserver","forks_url":"https://api.github.com/repos/ranisalt/forgottenserver/forks","keys_url":"https://api.github.com/repos/ranisalt/forgottenserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ranisalt/forgottenserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ranisalt/forgottenserver/teams","hooks_url":"https://api.github.com/repos/ranisalt/forgottenserver/hooks","issue_events_url":"https://api.github.com/repos/ranisalt/forgottenserver/issues/events{/number}","events_url":"https://api.github.com/repos/ranisalt/forgottenserver/events","assignees_url":"https://api.github.com/repos/ranisalt/forgottenserver/assignees{/user}","branches_url":"https://api.github.com/repos/ranisalt/forgottenserver/branches{/branch}","tags_url":"https://api.github.com/repos/ranisalt/forgottenserver/tags","blobs_url":"https://api.github.com/repos/ranisalt/forgottenserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ranisalt/forgottenserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ranisalt/forgottenserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/ranisalt/forgottenserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ranisalt/forgottenserver/statuses/{sha}","languages_url":"https://api.github.com/repos/ranisalt/forgottenserver/languages","stargazers_url":"https://api.github.com/repos/ranisalt/forgottenserver/stargazers","contributors_url":"https://api.github.com/repos/ranisalt/forgottenserver/contributors","subscribers_url":"https://api.github.com/repos/ranisalt/forgottenserver/subscribers","subscription_url":"https://api.github.com/repos/ranisalt/forgottenserver/subscription","commits_url":"https://api.github.com/repos/ranisalt/forgottenserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/ranisalt/forgottenserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/ranisalt/forgottenserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/ranisalt/forgottenserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/ranisalt/forgottenserver/contents/{+path}","compare_url":"https://api.github.com/repos/ranisalt/forgottenserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ranisalt/forgottenserver/merges","archive_url":"https://api.github.com/repos/ranisalt/forgottenserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ranisalt/forgottenserver/downloads","issues_url":"https://api.github.com/repos/ranisalt/forgottenserver/issues{/number}","pulls_url":"https://api.github.com/repos/ranisalt/forgottenserver/pulls{/number}","milestones_url":"https://api.github.com/repos/ranisalt/forgottenserver/milestones{/number}","notifications_url":"https://api.github.com/repos/ranisalt/forgottenserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ranisalt/forgottenserver/labels{/name}","releases_url":"https://api.github.com/repos/ranisalt/forgottenserver/releases{/id}","created_at":"2015-04-18T04:34:37Z","updated_at":"2015-04-18T04:34:41Z","pushed_at":"2015-04-19T06:47:36Z","git_url":"git://github.com/ranisalt/forgottenserver.git","ssh_url":"git@github.com:ranisalt/forgottenserver.git","clone_url":"https://github.com/ranisalt/forgottenserver.git","svn_url":"https://github.com/ranisalt/forgottenserver","homepage":"","size":21879,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"otland:master","ref":"master","sha":"3a0a7189c966141286d882c57f45526a8bb67606","user":{"login":"otland","id":4956302,"avatar_url":"https://avatars.githubusercontent.com/u/4956302?v=3","gravatar_id":"","url":"https://api.github.com/users/otland","html_url":"https://github.com/otland","followers_url":"https://api.github.com/users/otland/followers","following_url":"https://api.github.com/users/otland/following{/other_user}","gists_url":"https://api.github.com/users/otland/gists{/gist_id}","starred_url":"https://api.github.com/users/otland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otland/subscriptions","organizations_url":"https://api.github.com/users/otland/orgs","repos_url":"https://api.github.com/users/otland/repos","events_url":"https://api.github.com/users/otland/events{/privacy}","received_events_url":"https://api.github.com/users/otland/received_events","type":"Organization","site_admin":false},"repo":{"id":11081909,"name":"forgottenserver","full_name":"otland/forgottenserver","owner":{"login":"otland","id":4956302,"avatar_url":"https://avatars.githubusercontent.com/u/4956302?v=3","gravatar_id":"","url":"https://api.github.com/users/otland","html_url":"https://github.com/otland","followers_url":"https://api.github.com/users/otland/followers","following_url":"https://api.github.com/users/otland/following{/other_user}","gists_url":"https://api.github.com/users/otland/gists{/gist_id}","starred_url":"https://api.github.com/users/otland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otland/subscriptions","organizations_url":"https://api.github.com/users/otland/orgs","repos_url":"https://api.github.com/users/otland/repos","events_url":"https://api.github.com/users/otland/events{/privacy}","received_events_url":"https://api.github.com/users/otland/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/otland/forgottenserver","description":"A free and open-source MMORPG server emulator written in C++","fork":false,"url":"https://api.github.com/repos/otland/forgottenserver","forks_url":"https://api.github.com/repos/otland/forgottenserver/forks","keys_url":"https://api.github.com/repos/otland/forgottenserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otland/forgottenserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otland/forgottenserver/teams","hooks_url":"https://api.github.com/repos/otland/forgottenserver/hooks","issue_events_url":"https://api.github.com/repos/otland/forgottenserver/issues/events{/number}","events_url":"https://api.github.com/repos/otland/forgottenserver/events","assignees_url":"https://api.github.com/repos/otland/forgottenserver/assignees{/user}","branches_url":"https://api.github.com/repos/otland/forgottenserver/branches{/branch}","tags_url":"https://api.github.com/repos/otland/forgottenserver/tags","blobs_url":"https://api.github.com/repos/otland/forgottenserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otland/forgottenserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otland/forgottenserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/otland/forgottenserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otland/forgottenserver/statuses/{sha}","languages_url":"https://api.github.com/repos/otland/forgottenserver/languages","stargazers_url":"https://api.github.com/repos/otland/forgottenserver/stargazers","contributors_url":"https://api.github.com/repos/otland/forgottenserver/contributors","subscribers_url":"https://api.github.com/repos/otland/forgottenserver/subscribers","subscription_url":"https://api.github.com/repos/otland/forgottenserver/subscription","commits_url":"https://api.github.com/repos/otland/forgottenserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/otland/forgottenserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/otland/forgottenserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/otland/forgottenserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/otland/forgottenserver/contents/{+path}","compare_url":"https://api.github.com/repos/otland/forgottenserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otland/forgottenserver/merges","archive_url":"https://api.github.com/repos/otland/forgottenserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otland/forgottenserver/downloads","issues_url":"https://api.github.com/repos/otland/forgottenserver/issues{/number}","pulls_url":"https://api.github.com/repos/otland/forgottenserver/pulls{/number}","milestones_url":"https://api.github.com/repos/otland/forgottenserver/milestones{/number}","notifications_url":"https://api.github.com/repos/otland/forgottenserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otland/forgottenserver/labels{/name}","releases_url":"https://api.github.com/repos/otland/forgottenserver/releases{/id}","created_at":"2013-07-01T01:57:06Z","updated_at":"2015-04-18T22:33:30Z","pushed_at":"2015-04-19T06:49:37Z","git_url":"git://github.com/otland/forgottenserver.git","ssh_url":"git@github.com:otland/forgottenserver.git","clone_url":"https://github.com/otland/forgottenserver.git","svn_url":"https://github.com/otland/forgottenserver","homepage":"","size":21879,"stargazers_count":231,"watchers_count":231,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":257,"mirror_url":null,"open_issues_count":60,"forks":257,"open_issues":60,"watchers":231,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/otland/forgottenserver/pulls/1301"},"html":{"href":"https://github.com/otland/forgottenserver/pull/1301"},"issue":{"href":"https://api.github.com/repos/otland/forgottenserver/issues/1301"},"comments":{"href":"https://api.github.com/repos/otland/forgottenserver/issues/1301/comments"},"review_comments":{"href":"https://api.github.com/repos/otland/forgottenserver/pulls/1301/comments"},"review_comment":{"href":"https://api.github.com/repos/otland/forgottenserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/otland/forgottenserver/pulls/1301/commits"},"statuses":{"href":"https://api.github.com/repos/otland/forgottenserver/statuses/275f39c3faa61e59383915288de85cc90d9aca06"}}}}