{"action":"opened","number":1332,"pull_request":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1332","id":52765196,"html_url":"https://github.com/RPCS3/rpcs3/pull/1332","diff_url":"https://github.com/RPCS3/rpcs3/pull/1332.diff","patch_url":"https://github.com/RPCS3/rpcs3/pull/1332.patch","issue_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1332","number":1332,"state":"open","locked":false,"title":"Move llvm tests to VS unit testing framework","user":{"login":"vlj","id":6413475,"avatar_url":"https://avatars.githubusercontent.com/u/6413475?v=3","gravatar_id":"","url":"https://api.github.com/users/vlj","html_url":"https://github.com/vlj","followers_url":"https://api.github.com/users/vlj/followers","following_url":"https://api.github.com/users/vlj/following{/other_user}","gists_url":"https://api.github.com/users/vlj/gists{/gist_id}","starred_url":"https://api.github.com/users/vlj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlj/subscriptions","organizations_url":"https://api.github.com/users/vlj/orgs","repos_url":"https://api.github.com/users/vlj/repos","events_url":"https://api.github.com/users/vlj/events{/privacy}","received_events_url":"https://api.github.com/users/vlj/received_events","type":"User","site_admin":false},"body":"In master llvm tests are located in PPULLVMRecompilerTests.cpp and need to update a manual define to be enabled. When enabled they are run in Compiler constructor and they might interfere with the inner working of rpcs3 since they sometimes write/read to memory. In summary they are quite impracticable.\r\n\r\nThis PR solves this by moving all the testing in rpcs3-tests project introduced some commits ago.\r\nThese 555 tests are now standalone unit tests Inside VS unit testing Framework. They can be run independently or by group if needed. I think they can even be run Inside appveyor if necessary.\r\n\r\nThere are 2 drawbacks atm :\r\n* These tests are obviously Windows specific. I don't think it will be hard to have a non Windows implementation, the Framework only uses 2 macro TEST_CLASS() and TEST_METHOD and an Assert::IsEqual function. Besides if PPULLVM works in Windows there is no reason it doesn't on linux...\r\n* I encounter a pop up \"Warning: IEEE mode not enabled\" when running them which makes the tests requires manual input at the moment. In addition all the FP tests are failing too.","created_at":"2015-12-05T21:26:58Z","updated_at":"2015-12-05T21:26:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1332/commits","review_comments_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1332/comments","review_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1332/comments","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/bb011e5bf19fb393ed2448145c224800f10b5c07","head":{"label":"vlj:llvm-tests","ref":"llvm-tests","sha":"bb011e5bf19fb393ed2448145c224800f10b5c07","user":{"login":"vlj","id":6413475,"avatar_url":"https://avatars.githubusercontent.com/u/6413475?v=3","gravatar_id":"","url":"https://api.github.com/users/vlj","html_url":"https://github.com/vlj","followers_url":"https://api.github.com/users/vlj/followers","following_url":"https://api.github.com/users/vlj/following{/other_user}","gists_url":"https://api.github.com/users/vlj/gists{/gist_id}","starred_url":"https://api.github.com/users/vlj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlj/subscriptions","organizations_url":"https://api.github.com/users/vlj/orgs","repos_url":"https://api.github.com/users/vlj/repos","events_url":"https://api.github.com/users/vlj/events{/privacy}","received_events_url":"https://api.github.com/users/vlj/received_events","type":"User","site_admin":false},"repo":{"id":35342587,"name":"rpcs3","full_name":"vlj/rpcs3","owner":{"login":"vlj","id":6413475,"avatar_url":"https://avatars.githubusercontent.com/u/6413475?v=3","gravatar_id":"","url":"https://api.github.com/users/vlj","html_url":"https://github.com/vlj","followers_url":"https://api.github.com/users/vlj/followers","following_url":"https://api.github.com/users/vlj/following{/other_user}","gists_url":"https://api.github.com/users/vlj/gists{/gist_id}","starred_url":"https://api.github.com/users/vlj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlj/subscriptions","organizations_url":"https://api.github.com/users/vlj/orgs","repos_url":"https://api.github.com/users/vlj/repos","events_url":"https://api.github.com/users/vlj/events{/privacy}","received_events_url":"https://api.github.com/users/vlj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vlj/rpcs3","description":"PS3 emulator/debugger","fork":true,"url":"https://api.github.com/repos/vlj/rpcs3","forks_url":"https://api.github.com/repos/vlj/rpcs3/forks","keys_url":"https://api.github.com/repos/vlj/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vlj/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vlj/rpcs3/teams","hooks_url":"https://api.github.com/repos/vlj/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/vlj/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/vlj/rpcs3/events","assignees_url":"https://api.github.com/repos/vlj/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/vlj/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/vlj/rpcs3/tags","blobs_url":"https://api.github.com/repos/vlj/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vlj/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vlj/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/vlj/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vlj/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/vlj/rpcs3/languages","stargazers_url":"https://api.github.com/repos/vlj/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/vlj/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/vlj/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/vlj/rpcs3/subscription","commits_url":"https://api.github.com/repos/vlj/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/vlj/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/vlj/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/vlj/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/vlj/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/vlj/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vlj/rpcs3/merges","archive_url":"https://api.github.com/repos/vlj/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vlj/rpcs3/downloads","issues_url":"https://api.github.com/repos/vlj/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/vlj/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/vlj/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/vlj/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vlj/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/vlj/rpcs3/releases{/id}","created_at":"2015-05-09T19:43:56Z","updated_at":"2015-11-05T06:51:14Z","pushed_at":"2015-12-05T21:17:57Z","git_url":"git://github.com/vlj/rpcs3.git","ssh_url":"git@github.com:vlj/rpcs3.git","clone_url":"https://github.com/vlj/rpcs3.git","svn_url":"https://github.com/vlj/rpcs3","homepage":null,"size":31287,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"RPCS3:master","ref":"master","sha":"0d6297fef0985198fde87baa772f309087572305","user":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars.githubusercontent.com/u/8070735?v=3","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"repo":{"id":6520784,"name":"rpcs3","full_name":"RPCS3/rpcs3","owner":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars.githubusercontent.com/u/8070735?v=3","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RPCS3/rpcs3","description":"PS3 emulator/debugger","fork":false,"url":"https://api.github.com/repos/RPCS3/rpcs3","forks_url":"https://api.github.com/repos/RPCS3/rpcs3/forks","keys_url":"https://api.github.com/repos/RPCS3/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RPCS3/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RPCS3/rpcs3/teams","hooks_url":"https://api.github.com/repos/RPCS3/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/RPCS3/rpcs3/events","assignees_url":"https://api.github.com/repos/RPCS3/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/RPCS3/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/RPCS3/rpcs3/tags","blobs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RPCS3/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/RPCS3/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/RPCS3/rpcs3/languages","stargazers_url":"https://api.github.com/repos/RPCS3/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/RPCS3/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/RPCS3/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/RPCS3/rpcs3/subscription","commits_url":"https://api.github.com/repos/RPCS3/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/RPCS3/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/RPCS3/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/RPCS3/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RPCS3/rpcs3/merges","archive_url":"https://api.github.com/repos/RPCS3/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RPCS3/rpcs3/downloads","issues_url":"https://api.github.com/repos/RPCS3/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/RPCS3/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/RPCS3/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RPCS3/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/RPCS3/rpcs3/releases{/id}","created_at":"2012-11-03T15:16:18Z","updated_at":"2015-12-03T08:09:32Z","pushed_at":"2015-12-05T20:18:15Z","git_url":"git://github.com/RPCS3/rpcs3.git","ssh_url":"git@github.com:RPCS3/rpcs3.git","clone_url":"https://github.com/RPCS3/rpcs3.git","svn_url":"https://github.com/RPCS3/rpcs3","homepage":null,"size":72116,"stargazers_count":1703,"watchers_count":1703,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":332,"mirror_url":null,"open_issues_count":44,"forks":332,"open_issues":44,"watchers":1703,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1332"},"html":{"href":"https://github.com/RPCS3/rpcs3/pull/1332"},"issue":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/1332"},"comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/1332/comments"},"review_comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1332/comments"},"review_comment":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1332/commits"},"statuses":{"href":"https://api.github.com/repos/RPCS3/rpcs3/statuses/bb011e5bf19fb393ed2448145c224800f10b5c07"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":1171,"deletions":1219,"changed_files":11}}