{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/smart-answers/issues/1949","labels_url":"https://api.github.com/repos/alphagov/smart-answers/issues/1949/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/smart-answers/issues/1949/comments","events_url":"https://api.github.com/repos/alphagov/smart-answers/issues/1949/events","html_url":"https://github.com/alphagov/smart-answers/pull/1949","id":107005479,"number":1949,"title":"Fix panopticon integration","user":{"login":"tadast","id":218239,"avatar_url":"https://avatars.githubusercontent.com/u/218239?v=3","gravatar_id":"","url":"https://api.github.com/users/tadast","html_url":"https://github.com/tadast","followers_url":"https://api.github.com/users/tadast/followers","following_url":"https://api.github.com/users/tadast/following{/other_user}","gists_url":"https://api.github.com/users/tadast/gists{/gist_id}","starred_url":"https://api.github.com/users/tadast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tadast/subscriptions","organizations_url":"https://api.github.com/users/tadast/orgs","repos_url":"https://api.github.com/users/tadast/repos","events_url":"https://api.github.com/users/tadast/events{/privacy}","received_events_url":"https://api.github.com/users/tadast/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-17T15:04:58Z","updated_at":"2015-09-21T09:28:51Z","closed_at":"2015-09-17T15:16:44Z","pull_request":{"url":"https://api.github.com/repos/alphagov/smart-answers/pulls/1949","html_url":"https://github.com/alphagov/smart-answers/pull/1949","diff_url":"https://github.com/alphagov/smart-answers/pull/1949.diff","patch_url":"https://github.com/alphagov/smart-answers/pull/1949.patch"},"body":"As of 57493beeda38f35e3a9763bd3761ab3779f305fc Smart Answer titles and meta\r\ndescriptions are no longer stored in YAML files, however when flows are\r\nregistered with panopticon it is trying to look up those values in YAML\r\nand falls back to humanised titles (that still have dashes in them) and empty\r\nmeta descriptions.\r\n\r\nThis change uses the new mechanism to fetch titles and meta descriptions from\r\nERB files. The fallback code for missing title has been removed, because\r\nStartNodePresenter inherits NodePresenter#title that has this fallback\r\nimplemented.\r\n\r\nI've noticed that there are more code that relies on titles and bodies being in YAML, but it's less important  e.g. [here](https://github.com/alphagov/smart-answers/blob/05f855cb21edd96637a25b89c4238f2fd3f9aef1/lib/graph_presenter.rb#L98), [here]( https://github.com/alphagov/smart-answers/blob/05f855cb21edd96637a25b89c4238f2fd3f9aef1/test/fixtures/graph_presenter_test/graph.yml#L7)\r\n\r\n/cc @floehopper @alext "},"comment":{"url":"https://api.github.com/repos/alphagov/smart-answers/issues/comments/141923698","html_url":"https://github.com/alphagov/smart-answers/pull/1949#issuecomment-141923698","issue_url":"https://api.github.com/repos/alphagov/smart-answers/issues/1949","id":141923698,"user":{"login":"floehopper","id":3169,"avatar_url":"https://avatars.githubusercontent.com/u/3169?v=3","gravatar_id":"","url":"https://api.github.com/users/floehopper","html_url":"https://github.com/floehopper","followers_url":"https://api.github.com/users/floehopper/followers","following_url":"https://api.github.com/users/floehopper/following{/other_user}","gists_url":"https://api.github.com/users/floehopper/gists{/gist_id}","starred_url":"https://api.github.com/users/floehopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floehopper/subscriptions","organizations_url":"https://api.github.com/users/floehopper/orgs","repos_url":"https://api.github.com/users/floehopper/repos","events_url":"https://api.github.com/users/floehopper/events{/privacy}","received_events_url":"https://api.github.com/users/floehopper/received_events","type":"User","site_admin":false},"created_at":"2015-09-21T09:28:51Z","updated_at":"2015-09-21T09:28:51Z","body":"@tadast: I'm going to have a look at fixing the remaining places which suffer from this problem."}}