{"action":"created","comment":{"url":"https://api.github.com/repos/weaveworks/weave/pulls/comments/32439341","id":32439341,"diff_hunk":"@@ -547,16 +547,20 @@ http_call() {\n         \"$1 container is not present. Have you launched it?\" \\\n         \"$1 container is not running.\" \\\n         || return 1\n+    HTTP_CALL_CONTAINER=$1\n     shift 1\n-    http_call_ip $CONTAINER_IP \"$@\"\n+    if ! http_call_ip $CONTAINER_IP \"$@\" ; then\n+        echo \"Call to $HTTP_CALL_CONTAINER failed.\" >&2\n+        return 1\n+    fi\n }\n \n call_weave() {\n-    http_call $CONTAINER_NAME $HTTP_PORT \"$@\"\n+    http_call $CONTAINER_NAME $HTTP_PORT \"$@\" --show-error","path":"weave","position":15,"original_position":15,"commit_id":"f8b683ba30a067997485173c4e4dba2b4c8ee81e","original_commit_id":"f8b683ba30a067997485173c4e4dba2b4c8ee81e","user":{"login":"rade","id":109109,"avatar_url":"https://avatars.githubusercontent.com/u/109109?v=3","gravatar_id":"","url":"https://api.github.com/users/rade","html_url":"https://github.com/rade","followers_url":"https://api.github.com/users/rade/followers","following_url":"https://api.github.com/users/rade/following{/other_user}","gists_url":"https://api.github.com/users/rade/gists{/gist_id}","starred_url":"https://api.github.com/users/rade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rade/subscriptions","organizations_url":"https://api.github.com/users/rade/orgs","repos_url":"https://api.github.com/users/rade/repos","events_url":"https://api.github.com/users/rade/events{/privacy}","received_events_url":"https://api.github.com/users/rade/received_events","type":"User","site_admin":false},"body":"Let's just change the `curl` to use `-S` insead of `-s`. Any place that doesn't want the error output can `2>/dev/null` it.","created_at":"2015-06-15T16:31:54Z","updated_at":"2015-06-15T16:31:54Z","html_url":"https://github.com/weaveworks/weave/pull/918#discussion_r32439341","pull_request_url":"https://api.github.com/repos/weaveworks/weave/pulls/918","_links":{"self":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/comments/32439341"},"html":{"href":"https://github.com/weaveworks/weave/pull/918#discussion_r32439341"},"pull_request":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/918"}}},"pull_request":{"url":"https://api.github.com/repos/weaveworks/weave/pulls/918","id":37695530,"html_url":"https://github.com/weaveworks/weave/pull/918","diff_url":"https://github.com/weaveworks/weave/pull/918.diff","patch_url":"https://github.com/weaveworks/weave/pull/918.patch","issue_url":"https://api.github.com/repos/weaveworks/weave/issues/918","number":918,"state":"open","locked":false,"title":"Output error message if http call to weave or weavedns fails","user":{"login":"bboreham","id":8125524,"avatar_url":"https://avatars.githubusercontent.com/u/8125524?v=3","gravatar_id":"","url":"https://api.github.com/users/bboreham","html_url":"https://github.com/bboreham","followers_url":"https://api.github.com/users/bboreham/followers","following_url":"https://api.github.com/users/bboreham/following{/other_user}","gists_url":"https://api.github.com/users/bboreham/gists{/gist_id}","starred_url":"https://api.github.com/users/bboreham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboreham/subscriptions","organizations_url":"https://api.github.com/users/bboreham/orgs","repos_url":"https://api.github.com/users/bboreham/repos","events_url":"https://api.github.com/users/bboreham/events{/privacy}","received_events_url":"https://api.github.com/users/bboreham/received_events","type":"User","site_admin":false},"body":"Fixes #916\r\n\r\nWill print an error message if any of the calls to `weave` or `weavedns` fails after we've decided the container was running.\r\n\r\nI've added `--show-error` to the curl options, so we get some explanation too.  In the example of #916, we now get:\r\n\r\n````\r\ncurl: (52) Empty reply from server\r\nCall to weave failed.\r\n````\r\n","created_at":"2015-06-15T14:14:28Z","updated_at":"2015-06-15T16:31:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b112594700346be4bb6052d3a2a7ce09a6f4214","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/weaveworks/weave/pulls/918/commits","review_comments_url":"https://api.github.com/repos/weaveworks/weave/pulls/918/comments","review_comment_url":"https://api.github.com/repos/weaveworks/weave/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weaveworks/weave/issues/918/comments","statuses_url":"https://api.github.com/repos/weaveworks/weave/statuses/f8b683ba30a067997485173c4e4dba2b4c8ee81e","head":{"label":"bboreham:916-check-call-weave","ref":"916-check-call-weave","sha":"f8b683ba30a067997485173c4e4dba2b4c8ee81e","user":{"login":"bboreham","id":8125524,"avatar_url":"https://avatars.githubusercontent.com/u/8125524?v=3","gravatar_id":"","url":"https://api.github.com/users/bboreham","html_url":"https://github.com/bboreham","followers_url":"https://api.github.com/users/bboreham/followers","following_url":"https://api.github.com/users/bboreham/following{/other_user}","gists_url":"https://api.github.com/users/bboreham/gists{/gist_id}","starred_url":"https://api.github.com/users/bboreham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboreham/subscriptions","organizations_url":"https://api.github.com/users/bboreham/orgs","repos_url":"https://api.github.com/users/bboreham/repos","events_url":"https://api.github.com/users/bboreham/events{/privacy}","received_events_url":"https://api.github.com/users/bboreham/received_events","type":"User","site_admin":false},"repo":{"id":23360369,"name":"weave","full_name":"bboreham/weave","owner":{"login":"bboreham","id":8125524,"avatar_url":"https://avatars.githubusercontent.com/u/8125524?v=3","gravatar_id":"","url":"https://api.github.com/users/bboreham","html_url":"https://github.com/bboreham","followers_url":"https://api.github.com/users/bboreham/followers","following_url":"https://api.github.com/users/bboreham/following{/other_user}","gists_url":"https://api.github.com/users/bboreham/gists{/gist_id}","starred_url":"https://api.github.com/users/bboreham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboreham/subscriptions","organizations_url":"https://api.github.com/users/bboreham/orgs","repos_url":"https://api.github.com/users/bboreham/repos","events_url":"https://api.github.com/users/bboreham/events{/privacy}","received_events_url":"https://api.github.com/users/bboreham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bboreham/weave","description":"The Docker Network","fork":true,"url":"https://api.github.com/repos/bboreham/weave","forks_url":"https://api.github.com/repos/bboreham/weave/forks","keys_url":"https://api.github.com/repos/bboreham/weave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bboreham/weave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bboreham/weave/teams","hooks_url":"https://api.github.com/repos/bboreham/weave/hooks","issue_events_url":"https://api.github.com/repos/bboreham/weave/issues/events{/number}","events_url":"https://api.github.com/repos/bboreham/weave/events","assignees_url":"https://api.github.com/repos/bboreham/weave/assignees{/user}","branches_url":"https://api.github.com/repos/bboreham/weave/branches{/branch}","tags_url":"https://api.github.com/repos/bboreham/weave/tags","blobs_url":"https://api.github.com/repos/bboreham/weave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bboreham/weave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bboreham/weave/git/refs{/sha}","trees_url":"https://api.github.com/repos/bboreham/weave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bboreham/weave/statuses/{sha}","languages_url":"https://api.github.com/repos/bboreham/weave/languages","stargazers_url":"https://api.github.com/repos/bboreham/weave/stargazers","contributors_url":"https://api.github.com/repos/bboreham/weave/contributors","subscribers_url":"https://api.github.com/repos/bboreham/weave/subscribers","subscription_url":"https://api.github.com/repos/bboreham/weave/subscription","commits_url":"https://api.github.com/repos/bboreham/weave/commits{/sha}","git_commits_url":"https://api.github.com/repos/bboreham/weave/git/commits{/sha}","comments_url":"https://api.github.com/repos/bboreham/weave/comments{/number}","issue_comment_url":"https://api.github.com/repos/bboreham/weave/issues/comments{/number}","contents_url":"https://api.github.com/repos/bboreham/weave/contents/{+path}","compare_url":"https://api.github.com/repos/bboreham/weave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bboreham/weave/merges","archive_url":"https://api.github.com/repos/bboreham/weave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bboreham/weave/downloads","issues_url":"https://api.github.com/repos/bboreham/weave/issues{/number}","pulls_url":"https://api.github.com/repos/bboreham/weave/pulls{/number}","milestones_url":"https://api.github.com/repos/bboreham/weave/milestones{/number}","notifications_url":"https://api.github.com/repos/bboreham/weave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bboreham/weave/labels{/name}","releases_url":"https://api.github.com/repos/bboreham/weave/releases{/id}","created_at":"2014-08-26T17:24:12Z","updated_at":"2015-04-17T10:04:44Z","pushed_at":"2015-06-15T15:53:18Z","git_url":"git://github.com/bboreham/weave.git","ssh_url":"git@github.com:bboreham/weave.git","clone_url":"https://github.com/bboreham/weave.git","svn_url":"https://github.com/bboreham/weave","homepage":"","size":8245,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"weaveworks:master","ref":"master","sha":"9284366a3d58ac1df1eaf2ae89af4daeca5741f0","user":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":23059575,"name":"weave","full_name":"weaveworks/weave","owner":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weaveworks/weave","description":"Weaving containers into applications","fork":false,"url":"https://api.github.com/repos/weaveworks/weave","forks_url":"https://api.github.com/repos/weaveworks/weave/forks","keys_url":"https://api.github.com/repos/weaveworks/weave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/weave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/weave/teams","hooks_url":"https://api.github.com/repos/weaveworks/weave/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/weave/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/weave/events","assignees_url":"https://api.github.com/repos/weaveworks/weave/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/weave/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/weave/tags","blobs_url":"https://api.github.com/repos/weaveworks/weave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/weave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/weave/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/weave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/weave/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/weave/languages","stargazers_url":"https://api.github.com/repos/weaveworks/weave/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/weave/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/weave/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/weave/subscription","commits_url":"https://api.github.com/repos/weaveworks/weave/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/weave/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/weave/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/weave/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/weave/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/weave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/weave/merges","archive_url":"https://api.github.com/repos/weaveworks/weave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/weave/downloads","issues_url":"https://api.github.com/repos/weaveworks/weave/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/weave/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/weave/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/weave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/weave/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/weave/releases{/id}","created_at":"2014-08-18T05:19:07Z","updated_at":"2015-06-15T15:34:12Z","pushed_at":"2015-06-15T16:19:53Z","git_url":"git://github.com/weaveworks/weave.git","ssh_url":"git@github.com:weaveworks/weave.git","clone_url":"https://github.com/weaveworks/weave.git","svn_url":"https://github.com/weaveworks/weave","homepage":"http://weave.works","size":11038,"stargazers_count":3430,"watchers_count":3430,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":195,"mirror_url":null,"open_issues_count":132,"forks":195,"open_issues":132,"watchers":3430,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/918"},"html":{"href":"https://github.com/weaveworks/weave/pull/918"},"issue":{"href":"https://api.github.com/repos/weaveworks/weave/issues/918"},"comments":{"href":"https://api.github.com/repos/weaveworks/weave/issues/918/comments"},"review_comments":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/918/comments"},"review_comment":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/918/commits"},"statuses":{"href":"https://api.github.com/repos/weaveworks/weave/statuses/f8b683ba30a067997485173c4e4dba2b4c8ee81e"}}}}