{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Razor/pulls/comments/25564487","id":25564487,"diff_hunk":"@@ -59,50 +30,64 @@ public static TheoryData TagHelperDescriptorFlowTestData\n                     {\n                         \"SingleTagHelper\",\n                         \"SingleTagHelper\",\n-                        PAndInputTagHelperDescriptors,\n-                        PAndInputTagHelperDescriptors,\n+                        DefaultPAndInputTagHelperDescriptors,\n+                        DefaultPAndInputTagHelperDescriptors,\n                         false\n                     },\n                     {\n                         \"SingleTagHelper\",\n                         \"SingleTagHelper.DesignTime\",\n-                        PAndInputTagHelperDescriptors,\n-                        PAndInputTagHelperDescriptors,\n+                        DefaultPAndInputTagHelperDescriptors,\n+                        DefaultPAndInputTagHelperDescriptors,\n                         true\n                     },\n                     {\n                         \"BasicTagHelpers\",\n                         \"BasicTagHelpers\",\n-                        PAndInputTagHelperDescriptors,\n-                        PAndInputTagHelperDescriptors,\n+                        DefaultPAndInputTagHelperDescriptors,\n+                        DefaultPAndInputTagHelperDescriptors,\n                         false\n                     },\n                     {\n                         \"BasicTagHelpers\",\n                         \"BasicTagHelpers.DesignTime\",\n-                        PAndInputTagHelperDescriptors,\n-                        PAndInputTagHelperDescriptors,\n+                        DefaultPAndInputTagHelperDescriptors,\n+                        DefaultPAndInputTagHelperDescriptors,\n                         true\n                     },\n                     {\n                         \"BasicTagHelpers.RemoveTagHelper\",\n                         \"BasicTagHelpers.RemoveTagHelper\",\n-                        PAndInputTagHelperDescriptors,\n+                        DefaultPAndInputTagHelperDescriptors,\n                         Enumerable.Empty<TagHelperDescriptor>(),\n                         false\n                     },\n                     {\n+                        \"BasicTagHelpers.Prefixed\",\n+                        \"BasicTagHelpers.Prefixed\",\n+                        BuildPAndInputTagHelperDescriptors(prefix: \"th:\"),\n+                        BuildPAndInputTagHelperDescriptors(prefix: \"th:\"),","path":"test/Microsoft.AspNet.Razor.Test/Generator/CSharpTagHelperRenderingTest.cs","position":89,"original_position":89,"commit_id":"99f25f7327fd1e4fc2d7cc83a73174125db6d418","original_commit_id":"99f25f7327fd1e4fc2d7cc83a73174125db6d418","user":{"login":"dougbu","id":6431421,"avatar_url":"https://avatars.githubusercontent.com/u/6431421?v=3","gravatar_id":"","url":"https://api.github.com/users/dougbu","html_url":"https://github.com/dougbu","followers_url":"https://api.github.com/users/dougbu/followers","following_url":"https://api.github.com/users/dougbu/following{/other_user}","gists_url":"https://api.github.com/users/dougbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dougbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougbu/subscriptions","organizations_url":"https://api.github.com/users/dougbu/orgs","repos_url":"https://api.github.com/users/dougbu/repos","events_url":"https://api.github.com/users/dougbu/events{/privacy}","received_events_url":"https://api.github.com/users/dougbu/received_events","type":"User","site_admin":false},"body":"- vary the valid prefixes in these more end-to-end tests as well\r\n- nit: create a property containing the descriptors with this prefix.  (could do that using a deep copy of `DefaultPAndInputTagHelperDescriptors` instead of churning that code.)","created_at":"2015-03-01T06:13:22Z","updated_at":"2015-03-01T06:13:22Z","html_url":"https://github.com/aspnet/Razor/pull/313#discussion_r25564487","pull_request_url":"https://api.github.com/repos/aspnet/Razor/pulls/313","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/comments/25564487"},"html":{"href":"https://github.com/aspnet/Razor/pull/313#discussion_r25564487"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/313"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Razor/pulls/313","id":29959773,"html_url":"https://github.com/aspnet/Razor/pull/313","diff_url":"https://github.com/aspnet/Razor/pull/313.diff","patch_url":"https://github.com/aspnet/Razor/pull/313.patch","issue_url":"https://api.github.com/repos/aspnet/Razor/issues/313","number":313,"state":"open","locked":false,"title":"Add tagHelperPrefix directive.","user":{"login":"NTaylorMullen","id":2008729,"avatar_url":"https://avatars.githubusercontent.com/u/2008729?v=3","gravatar_id":"","url":"https://api.github.com/users/NTaylorMullen","html_url":"https://github.com/NTaylorMullen","followers_url":"https://api.github.com/users/NTaylorMullen/followers","following_url":"https://api.github.com/users/NTaylorMullen/following{/other_user}","gists_url":"https://api.github.com/users/NTaylorMullen/gists{/gist_id}","starred_url":"https://api.github.com/users/NTaylorMullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NTaylorMullen/subscriptions","organizations_url":"https://api.github.com/users/NTaylorMullen/orgs","repos_url":"https://api.github.com/users/NTaylorMullen/repos","events_url":"https://api.github.com/users/NTaylorMullen/events{/privacy}","received_events_url":"https://api.github.com/users/NTaylorMullen/received_events","type":"User","site_admin":false},"body":"Took the approach of attaching the prefix to `TagHelperDescriptor`s to enable tooling to separate `Prefix`s from `TagName`s in the document. Ran design by @rynowak.\r\n\r\n*Change notes:*\r\n\r\n- Updated TagHelperDescriptor to have a Prefix property. This enables new tooling scenarios such as refactoring prefixes or even giving them their own classification.\r\n- Added invalid prefix cases '@', '!' and whitespace.\r\n- Added TagHelperPrefix chunks, codegenerator, parsing logic to flow the directive through the Razor pipeline.\r\n Added parsing, sub-rewriting, rewriting and code generation tests for runtime/designtime.\r\n- Fixed existing tests to utilize new class structures.\r\n- Expanded block types to enable easy testing of prefixed TagHelpers.\r\n\r\n#309\r\n\r\n/cc @dougbu ","created_at":"2015-02-25T04:05:45Z","updated_at":"2015-03-01T06:13:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3c096bbda84e9ee734eddd556c25d9f199f4c72","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Razor/pulls/313/commits","review_comments_url":"https://api.github.com/repos/aspnet/Razor/pulls/313/comments","review_comment_url":"https://api.github.com/repos/aspnet/Razor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Razor/issues/313/comments","statuses_url":"https://api.github.com/repos/aspnet/Razor/statuses/99f25f7327fd1e4fc2d7cc83a73174125db6d418","head":{"label":"aspnet:thoptin.309","ref":"thoptin.309","sha":"99f25f7327fd1e4fc2d7cc83a73174125db6d418","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15835991,"name":"Razor","full_name":"aspnet/Razor","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Razor","description":"Parser and code generator for CSHTML files used in view pages for MVC web apps.","fork":false,"url":"https://api.github.com/repos/aspnet/Razor","forks_url":"https://api.github.com/repos/aspnet/Razor/forks","keys_url":"https://api.github.com/repos/aspnet/Razor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Razor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Razor/teams","hooks_url":"https://api.github.com/repos/aspnet/Razor/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Razor/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Razor/events","assignees_url":"https://api.github.com/repos/aspnet/Razor/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Razor/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Razor/tags","blobs_url":"https://api.github.com/repos/aspnet/Razor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Razor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Razor/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Razor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Razor/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Razor/languages","stargazers_url":"https://api.github.com/repos/aspnet/Razor/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Razor/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Razor/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Razor/subscription","commits_url":"https://api.github.com/repos/aspnet/Razor/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Razor/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Razor/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Razor/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Razor/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Razor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Razor/merges","archive_url":"https://api.github.com/repos/aspnet/Razor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Razor/downloads","issues_url":"https://api.github.com/repos/aspnet/Razor/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Razor/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Razor/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Razor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Razor/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Razor/releases{/id}","created_at":"2014-01-12T03:52:46Z","updated_at":"2015-02-27T22:22:04Z","pushed_at":"2015-02-28T01:18:30Z","git_url":"git://github.com/aspnet/Razor.git","ssh_url":"git@github.com:aspnet/Razor.git","clone_url":"https://github.com/aspnet/Razor.git","svn_url":"https://github.com/aspnet/Razor","homepage":"","size":7086,"stargazers_count":298,"watchers_count":298,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":78,"forks":67,"open_issues":78,"watchers":298,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"677df32160dab9754d6ef6155932dd54f3170fe9","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15835991,"name":"Razor","full_name":"aspnet/Razor","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Razor","description":"Parser and code generator for CSHTML files used in view pages for MVC web apps.","fork":false,"url":"https://api.github.com/repos/aspnet/Razor","forks_url":"https://api.github.com/repos/aspnet/Razor/forks","keys_url":"https://api.github.com/repos/aspnet/Razor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Razor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Razor/teams","hooks_url":"https://api.github.com/repos/aspnet/Razor/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Razor/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Razor/events","assignees_url":"https://api.github.com/repos/aspnet/Razor/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Razor/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Razor/tags","blobs_url":"https://api.github.com/repos/aspnet/Razor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Razor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Razor/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Razor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Razor/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Razor/languages","stargazers_url":"https://api.github.com/repos/aspnet/Razor/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Razor/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Razor/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Razor/subscription","commits_url":"https://api.github.com/repos/aspnet/Razor/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Razor/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Razor/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Razor/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Razor/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Razor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Razor/merges","archive_url":"https://api.github.com/repos/aspnet/Razor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Razor/downloads","issues_url":"https://api.github.com/repos/aspnet/Razor/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Razor/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Razor/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Razor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Razor/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Razor/releases{/id}","created_at":"2014-01-12T03:52:46Z","updated_at":"2015-02-27T22:22:04Z","pushed_at":"2015-02-28T01:18:30Z","git_url":"git://github.com/aspnet/Razor.git","ssh_url":"git@github.com:aspnet/Razor.git","clone_url":"https://github.com/aspnet/Razor.git","svn_url":"https://github.com/aspnet/Razor","homepage":"","size":7086,"stargazers_count":298,"watchers_count":298,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":78,"forks":67,"open_issues":78,"watchers":298,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/313"},"html":{"href":"https://github.com/aspnet/Razor/pull/313"},"issue":{"href":"https://api.github.com/repos/aspnet/Razor/issues/313"},"comments":{"href":"https://api.github.com/repos/aspnet/Razor/issues/313/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/313/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/313/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Razor/statuses/99f25f7327fd1e4fc2d7cc83a73174125db6d418"}}}}