{"action":"opened","number":3217,"pull_request":{"url":"https://api.github.com/repos/emberjs/data/pulls/3217","id":37054170,"html_url":"https://github.com/emberjs/data/pull/3217","diff_url":"https://github.com/emberjs/data/pull/3217.diff","patch_url":"https://github.com/emberjs/data/pull/3217.patch","issue_url":"https://api.github.com/repos/emberjs/data/issues/3217","number":3217,"state":"open","locked":false,"title":"Remove the 'container' property from model instances","user":{"login":"slindberg","id":421506,"avatar_url":"https://avatars.githubusercontent.com/u/421506?v=3","gravatar_id":"","url":"https://api.github.com/users/slindberg","html_url":"https://github.com/slindberg","followers_url":"https://api.github.com/users/slindberg/followers","following_url":"https://api.github.com/users/slindberg/following{/other_user}","gists_url":"https://api.github.com/users/slindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/slindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slindberg/subscriptions","organizations_url":"https://api.github.com/users/slindberg/orgs","repos_url":"https://api.github.com/users/slindberg/repos","events_url":"https://api.github.com/users/slindberg/events{/privacy}","received_events_url":"https://api.github.com/users/slindberg/received_events","type":"User","site_admin":false},"body":"From the commit:\r\n\r\n> Models have always been created/managed by a store instance, and\r\n> support for multiple stores makes accessing the container from a model\r\n> inconsistent (and potentially dangerous), given that all adapter/serializer\r\n> instances are looked up through a store's ContainerInstanceCache.\r\n\r\nI think this makes sense, but I don't know if removing the `container` property from `DS.Model` instances would be considered a breaking change. If so, I can create a deprecated property accessor. @igorT, @fivetanley thoughts?","created_at":"2015-06-05T17:50:02Z","updated_at":"2015-06-05T17:50:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/data/pulls/3217/commits","review_comments_url":"https://api.github.com/repos/emberjs/data/pulls/3217/comments","review_comment_url":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/data/issues/3217/comments","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/461b9da3c3a8a50944ed03d29cd4c70b1ac78b25","head":{"label":"slindberg:remove-model-container-reference","ref":"remove-model-container-reference","sha":"461b9da3c3a8a50944ed03d29cd4c70b1ac78b25","user":{"login":"slindberg","id":421506,"avatar_url":"https://avatars.githubusercontent.com/u/421506?v=3","gravatar_id":"","url":"https://api.github.com/users/slindberg","html_url":"https://github.com/slindberg","followers_url":"https://api.github.com/users/slindberg/followers","following_url":"https://api.github.com/users/slindberg/following{/other_user}","gists_url":"https://api.github.com/users/slindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/slindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slindberg/subscriptions","organizations_url":"https://api.github.com/users/slindberg/orgs","repos_url":"https://api.github.com/users/slindberg/repos","events_url":"https://api.github.com/users/slindberg/events{/privacy}","received_events_url":"https://api.github.com/users/slindberg/received_events","type":"User","site_admin":false},"repo":{"id":16357271,"name":"data","full_name":"slindberg/data","owner":{"login":"slindberg","id":421506,"avatar_url":"https://avatars.githubusercontent.com/u/421506?v=3","gravatar_id":"","url":"https://api.github.com/users/slindberg","html_url":"https://github.com/slindberg","followers_url":"https://api.github.com/users/slindberg/followers","following_url":"https://api.github.com/users/slindberg/following{/other_user}","gists_url":"https://api.github.com/users/slindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/slindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slindberg/subscriptions","organizations_url":"https://api.github.com/users/slindberg/orgs","repos_url":"https://api.github.com/users/slindberg/repos","events_url":"https://api.github.com/users/slindberg/events{/privacy}","received_events_url":"https://api.github.com/users/slindberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slindberg/data","description":"A data persistence library for Ember.js.","fork":true,"url":"https://api.github.com/repos/slindberg/data","forks_url":"https://api.github.com/repos/slindberg/data/forks","keys_url":"https://api.github.com/repos/slindberg/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slindberg/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slindberg/data/teams","hooks_url":"https://api.github.com/repos/slindberg/data/hooks","issue_events_url":"https://api.github.com/repos/slindberg/data/issues/events{/number}","events_url":"https://api.github.com/repos/slindberg/data/events","assignees_url":"https://api.github.com/repos/slindberg/data/assignees{/user}","branches_url":"https://api.github.com/repos/slindberg/data/branches{/branch}","tags_url":"https://api.github.com/repos/slindberg/data/tags","blobs_url":"https://api.github.com/repos/slindberg/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slindberg/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slindberg/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/slindberg/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slindberg/data/statuses/{sha}","languages_url":"https://api.github.com/repos/slindberg/data/languages","stargazers_url":"https://api.github.com/repos/slindberg/data/stargazers","contributors_url":"https://api.github.com/repos/slindberg/data/contributors","subscribers_url":"https://api.github.com/repos/slindberg/data/subscribers","subscription_url":"https://api.github.com/repos/slindberg/data/subscription","commits_url":"https://api.github.com/repos/slindberg/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/slindberg/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/slindberg/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/slindberg/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/slindberg/data/contents/{+path}","compare_url":"https://api.github.com/repos/slindberg/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slindberg/data/merges","archive_url":"https://api.github.com/repos/slindberg/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slindberg/data/downloads","issues_url":"https://api.github.com/repos/slindberg/data/issues{/number}","pulls_url":"https://api.github.com/repos/slindberg/data/pulls{/number}","milestones_url":"https://api.github.com/repos/slindberg/data/milestones{/number}","notifications_url":"https://api.github.com/repos/slindberg/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slindberg/data/labels{/name}","releases_url":"https://api.github.com/repos/slindberg/data/releases{/id}","created_at":"2014-01-29T20:13:42Z","updated_at":"2014-01-29T23:19:47Z","pushed_at":"2015-06-05T17:48:13Z","git_url":"git://github.com/slindberg/data.git","ssh_url":"git@github.com:slindberg/data.git","clone_url":"https://github.com/slindberg/data.git","svn_url":"https://github.com/slindberg/data","homepage":"","size":7448,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"8b69971e4cd11c0cd223a01233a8793fbb60a643","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":3016562,"name":"data","full_name":"emberjs/data","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/data","description":"A data persistence library for Ember.js.","fork":false,"url":"https://api.github.com/repos/emberjs/data","forks_url":"https://api.github.com/repos/emberjs/data/forks","keys_url":"https://api.github.com/repos/emberjs/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/data/teams","hooks_url":"https://api.github.com/repos/emberjs/data/hooks","issue_events_url":"https://api.github.com/repos/emberjs/data/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/data/events","assignees_url":"https://api.github.com/repos/emberjs/data/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/data/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/data/tags","blobs_url":"https://api.github.com/repos/emberjs/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/data/languages","stargazers_url":"https://api.github.com/repos/emberjs/data/stargazers","contributors_url":"https://api.github.com/repos/emberjs/data/contributors","subscribers_url":"https://api.github.com/repos/emberjs/data/subscribers","subscription_url":"https://api.github.com/repos/emberjs/data/subscription","commits_url":"https://api.github.com/repos/emberjs/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/data/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/data/merges","archive_url":"https://api.github.com/repos/emberjs/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/data/downloads","issues_url":"https://api.github.com/repos/emberjs/data/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/data/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/data/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/data/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/data/releases{/id}","created_at":"2011-12-20T01:50:40Z","updated_at":"2015-06-05T04:39:34Z","pushed_at":"2015-06-05T15:31:28Z","git_url":"git://github.com/emberjs/data.git","ssh_url":"git@github.com:emberjs/data.git","clone_url":"https://github.com/emberjs/data.git","svn_url":"https://github.com/emberjs/data","homepage":"","size":26681,"stargazers_count":2381,"watchers_count":2381,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":917,"mirror_url":null,"open_issues_count":217,"forks":917,"open_issues":217,"watchers":2381,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/3217"},"html":{"href":"https://github.com/emberjs/data/pull/3217"},"issue":{"href":"https://api.github.com/repos/emberjs/data/issues/3217"},"comments":{"href":"https://api.github.com/repos/emberjs/data/issues/3217/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/data/pulls/3217/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/data/pulls/3217/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/data/statuses/461b9da3c3a8a50944ed03d29cd4c70b1ac78b25"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":10,"changed_files":3}}