{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5357","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5357/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5357/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5357/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/5357","id":110236874,"number":5357,"title":"[WIP]: BUG fix standardization in center_data for linear models","user":{"login":"giorgiop","id":2871319,"avatar_url":"https://avatars.githubusercontent.com/u/2871319?v=3","gravatar_id":"","url":"https://api.github.com/users/giorgiop","html_url":"https://github.com/giorgiop","followers_url":"https://api.github.com/users/giorgiop/followers","following_url":"https://api.github.com/users/giorgiop/following{/other_user}","gists_url":"https://api.github.com/users/giorgiop/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgiop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgiop/subscriptions","organizations_url":"https://api.github.com/users/giorgiop/orgs","repos_url":"https://api.github.com/users/giorgiop/repos","events_url":"https://api.github.com/users/giorgiop/events{/privacy}","received_events_url":"https://api.github.com/users/giorgiop/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2015-10-07T14:24:59Z","updated_at":"2015-10-14T20:23:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5357","html_url":"https://github.com/scikit-learn/scikit-learn/pull/5357","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/5357.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/5357.patch"},"body":"Fixes #2601.\r\n\r\nTO DO:\r\n- [x] deprecate `normalize` (signature and property) and introduce `standardize` behaviour\r\n- [x] fix tests in `linear_model/test_base.py` + deprecation test\r\n- [ ] introduce the same behaviour for every class calling `center_data` internally + related tests\r\n- [ ] change `center_data` behaviour w.r.t. `fit_intercept`. Currently, [input data is not touched](https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/linear_model/base.py#L119) if we not are fitting the intercept.\r\n- [ ] make sense of [this old test](https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/linear_model/tests/test_base.py#L63) on `sample_weights` with unused variables (a)"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/148184435","html_url":"https://github.com/scikit-learn/scikit-learn/pull/5357#issuecomment-148184435","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5357","id":148184435,"user":{"login":"agramfort","id":161052,"avatar_url":"https://avatars.githubusercontent.com/u/161052?v=3","gravatar_id":"","url":"https://api.github.com/users/agramfort","html_url":"https://github.com/agramfort","followers_url":"https://api.github.com/users/agramfort/followers","following_url":"https://api.github.com/users/agramfort/following{/other_user}","gists_url":"https://api.github.com/users/agramfort/gists{/gist_id}","starred_url":"https://api.github.com/users/agramfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agramfort/subscriptions","organizations_url":"https://api.github.com/users/agramfort/orgs","repos_url":"https://api.github.com/users/agramfort/repos","events_url":"https://api.github.com/users/agramfort/events{/privacy}","received_events_url":"https://api.github.com/users/agramfort/received_events","type":"User","site_admin":false},"created_at":"2015-10-14T20:23:37Z","updated_at":"2015-10-14T20:23:37Z","body":"ok\n\nso we keep the fact that if fit_intercept=False normalize=True has no\neffect?\n"}}