{"action":"created","issue":{"url":"https://api.github.com/repos/redpen-cc/redpen/issues/514","labels_url":"https://api.github.com/repos/redpen-cc/redpen/issues/514/labels{/name}","comments_url":"https://api.github.com/repos/redpen-cc/redpen/issues/514/comments","events_url":"https://api.github.com/repos/redpen-cc/redpen/issues/514/events","html_url":"https://github.com/redpen-cc/redpen/pull/514","id":117819985,"number":514,"title":"Replace AsciiDoctor/AsciiDoctorJ parser with simpler lightweight AsciiDoc parser","user":{"login":"gerryhocks","id":1311758,"avatar_url":"https://avatars.githubusercontent.com/u/1311758?v=3","gravatar_id":"","url":"https://api.github.com/users/gerryhocks","html_url":"https://github.com/gerryhocks","followers_url":"https://api.github.com/users/gerryhocks/followers","following_url":"https://api.github.com/users/gerryhocks/following{/other_user}","gists_url":"https://api.github.com/users/gerryhocks/gists{/gist_id}","starred_url":"https://api.github.com/users/gerryhocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerryhocks/subscriptions","organizations_url":"https://api.github.com/users/gerryhocks/orgs","repos_url":"https://api.github.com/users/gerryhocks/repos","events_url":"https://api.github.com/users/gerryhocks/events{/privacy}","received_events_url":"https://api.github.com/users/gerryhocks/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"takahi-i","id":339436,"avatar_url":"https://avatars.githubusercontent.com/u/339436?v=3","gravatar_id":"","url":"https://api.github.com/users/takahi-i","html_url":"https://github.com/takahi-i","followers_url":"https://api.github.com/users/takahi-i/followers","following_url":"https://api.github.com/users/takahi-i/following{/other_user}","gists_url":"https://api.github.com/users/takahi-i/gists{/gist_id}","starred_url":"https://api.github.com/users/takahi-i/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takahi-i/subscriptions","organizations_url":"https://api.github.com/users/takahi-i/orgs","repos_url":"https://api.github.com/users/takahi-i/repos","events_url":"https://api.github.com/users/takahi-i/events{/privacy}","received_events_url":"https://api.github.com/users/takahi-i/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-11-19T14:05:10Z","updated_at":"2015-11-20T04:21:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/redpen-cc/redpen/pulls/514","html_url":"https://github.com/redpen-cc/redpen/pull/514","diff_url":"https://github.com/redpen-cc/redpen/pull/514.diff","patch_url":"https://github.com/redpen-cc/redpen/pull/514.patch"},"body":"This change replaces the existing AsciiDoc parser with a simpler AsciiDoc parser with no external dependencies.\r\n\r\nThis new parser generates a model of the source document which retains each character's original position, then proceeds to 'erase' the elements of the model that are recognized as AsciiDoc markup. The remaining characters are then converted into a RedPen document model.\r\n\r\nThe pom has been updated to remove asciidoctor/asciidoctorj and jruby related dependencies.\r\n"},"comment":{"url":"https://api.github.com/repos/redpen-cc/redpen/issues/comments/158275300","html_url":"https://github.com/redpen-cc/redpen/pull/514#issuecomment-158275300","issue_url":"https://api.github.com/repos/redpen-cc/redpen/issues/514","id":158275300,"user":{"login":"takahi-i","id":339436,"avatar_url":"https://avatars.githubusercontent.com/u/339436?v=3","gravatar_id":"","url":"https://api.github.com/users/takahi-i","html_url":"https://github.com/takahi-i","followers_url":"https://api.github.com/users/takahi-i/followers","following_url":"https://api.github.com/users/takahi-i/following{/other_user}","gists_url":"https://api.github.com/users/takahi-i/gists{/gist_id}","starred_url":"https://api.github.com/users/takahi-i/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takahi-i/subscriptions","organizations_url":"https://api.github.com/users/takahi-i/orgs","repos_url":"https://api.github.com/users/takahi-i/repos","events_url":"https://api.github.com/users/takahi-i/events{/privacy}","received_events_url":"https://api.github.com/users/takahi-i/received_events","type":"User","site_admin":false},"created_at":"2015-11-20T04:21:32Z","updated_at":"2015-11-20T04:21:32Z","body":"It works almost expected. The followings are the topics to improve.\r\n\r\n1. **not to add sentences in comments** this parser extract sentences in comments (// BLAH BLAH)\r\n2.  **not to add sentences in tables** this parser looks extract sentences in tables. For example this parser extract the following table as one sentence.\r\n\r\n```\r\n|===\r\n|Hex | RGB | CMYK\r\n| ffffff または #ffffff | [255,255,255] | [0, 0, 0, 0] または [0, 0, 0, 0%]\r\n|===\r\n```\r\n\r\nAnd it would be great for you to add enough tests internal long methods such as convertToSentences, convertModel, Line constructor. eraseEnclosure etc. The tests are needed for me to understand and maintain the codes. \r\n"}}