{"action":"created","issue":{"url":"https://api.github.com/repos/vooooo/RottenTomatoes/issues/1","labels_url":"https://api.github.com/repos/vooooo/RottenTomatoes/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/vooooo/RottenTomatoes/issues/1/comments","events_url":"https://api.github.com/repos/vooooo/RottenTomatoes/issues/1/events","html_url":"https://github.com/vooooo/RottenTomatoes/issues/1","id":107432291,"number":1,"title":"[Intro to iOS] Codepath RottenTomatoes Project - Week 1","user":{"login":"vooooo","id":4175362,"avatar_url":"https://avatars.githubusercontent.com/u/4175362?v=3","gravatar_id":"","url":"https://api.github.com/users/vooooo","html_url":"https://github.com/vooooo","followers_url":"https://api.github.com/users/vooooo/followers","following_url":"https://api.github.com/users/vooooo/following{/other_user}","gists_url":"https://api.github.com/users/vooooo/gists{/gist_id}","starred_url":"https://api.github.com/users/vooooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vooooo/subscriptions","organizations_url":"https://api.github.com/users/vooooo/orgs","repos_url":"https://api.github.com/users/vooooo/repos","events_url":"https://api.github.com/users/vooooo/events{/privacy}","received_events_url":"https://api.github.com/users/vooooo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-21T02:09:55Z","updated_at":"2015-09-26T23:47:06Z","closed_at":null,"body":"My Rotten Tomatoes app is complete, please review.  /cc @codepath\r\n\r\n/cc @thecodepath"},"comment":{"url":"https://api.github.com/repos/vooooo/RottenTomatoes/issues/comments/143505845","html_url":"https://github.com/vooooo/RottenTomatoes/issues/1#issuecomment-143505845","issue_url":"https://api.github.com/repos/vooooo/RottenTomatoes/issues/1","id":143505845,"user":{"login":"codepathreview","id":7917093,"avatar_url":"https://avatars.githubusercontent.com/u/7917093?v=3","gravatar_id":"","url":"https://api.github.com/users/codepathreview","html_url":"https://github.com/codepathreview","followers_url":"https://api.github.com/users/codepathreview/followers","following_url":"https://api.github.com/users/codepathreview/following{/other_user}","gists_url":"https://api.github.com/users/codepathreview/gists{/gist_id}","starred_url":"https://api.github.com/users/codepathreview/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codepathreview/subscriptions","organizations_url":"https://api.github.com/users/codepathreview/orgs","repos_url":"https://api.github.com/users/codepathreview/repos","events_url":"https://api.github.com/users/codepathreview/events{/privacy}","received_events_url":"https://api.github.com/users/codepathreview/received_events","type":"User","site_admin":false},"created_at":"2015-09-26T23:47:06Z","updated_at":"2015-09-26T23:47:06Z","body":":+1: nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. For each point in the homework feedback checklist, I'll either confirm that you're on the right track with the implementation, or I'll provide some feedback:\r\n\r\n* use a .gitignore file. In particular when you work together with a team, this will prevent merge conflicts for files that you should not share anyway.\r\n* Nice code styling. Check out these Swift style guides:\r\n   - [Ray Wenderlich Swift Style Guide](https://github.com/raywenderlich/swift-style-guide)\r\n   - [Github Swift Style Guide](https://github.com/github/swift-style-guide)\r\n* You should always try to minimize the number of properties and methods that are public or internal (access is internal by default). Make the access private if the property or function doesn't need to be accessed outside the class.\r\n* In future homework, we will cover how to implement models that can deserialize from an NSDictionary. SwiftyJSON is a useful project for making it easier to deserialize the JSON response.\r\n* Your custom Movie cell should have a property called `movie`. In the custom setter of `movie`, you should configure the various labels and images. This decouples your custom cells from the table view controllers.\r\n* Nice work loading the images asynchronously.\r\n* Nice work setting up the proper modes for the images so that they are not stretched.\r\n* Nice work implementing the error message on network failure.\r\n\r\n\r\nIn general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.\r\n\r\n-- dirk"}}