{"action":"created","issue":{"url":"https://api.github.com/repos/magit/magit/issues/2293","labels_url":"https://api.github.com/repos/magit/magit/issues/2293/labels{/name}","comments_url":"https://api.github.com/repos/magit/magit/issues/2293/comments","events_url":"https://api.github.com/repos/magit/magit/issues/2293/events","html_url":"https://github.com/magit/magit/pull/2293","id":108334891,"number":2293,"title":"Underline using :align-to","user":{"login":"tarsius","id":25046,"avatar_url":"https://avatars.githubusercontent.com/u/25046?v=3","gravatar_id":"","url":"https://api.github.com/users/tarsius","html_url":"https://github.com/tarsius","followers_url":"https://api.github.com/users/tarsius/followers","following_url":"https://api.github.com/users/tarsius/following{/other_user}","gists_url":"https://api.github.com/users/tarsius/gists{/gist_id}","starred_url":"https://api.github.com/users/tarsius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarsius/subscriptions","organizations_url":"https://api.github.com/users/tarsius/orgs","repos_url":"https://api.github.com/users/tarsius/repos","events_url":"https://api.github.com/users/tarsius/events{/privacy}","received_events_url":"https://api.github.com/users/tarsius/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/magit/magit/milestones/14","html_url":"https://github.com/magit/magit/milestones/later","labels_url":"https://api.github.com/repos/magit/magit/milestones/14/labels","id":437355,"number":14,"title":"later","description":"\"later\" does not necessarily mean \"after all the release milestones that currently exist. It might for some issues, but not all. It does however mean \"not in the very next release\" or at least \"*I* won't do it in time for the very next release\".\r\n\r\nOr in other words \"later\" means exactly what it means: \"not now but later\".","creator":{"login":"tarsius","id":25046,"avatar_url":"https://avatars.githubusercontent.com/u/25046?v=3","gravatar_id":"","url":"https://api.github.com/users/tarsius","html_url":"https://github.com/tarsius","followers_url":"https://api.github.com/users/tarsius/followers","following_url":"https://api.github.com/users/tarsius/following{/other_user}","gists_url":"https://api.github.com/users/tarsius/gists{/gist_id}","starred_url":"https://api.github.com/users/tarsius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarsius/subscriptions","organizations_url":"https://api.github.com/users/tarsius/orgs","repos_url":"https://api.github.com/users/tarsius/repos","events_url":"https://api.github.com/users/tarsius/events{/privacy}","received_events_url":"https://api.github.com/users/tarsius/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":12,"state":"open","created_at":"2013-09-26T02:30:07Z","updated_at":"2015-10-17T16:35:50Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2015-09-25T14:15:04Z","updated_at":"2015-10-18T15:09:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/magit/magit/pulls/2293","html_url":"https://github.com/magit/magit/pull/2293","diff_url":"https://github.com/magit/magit/pull/2293.diff","patch_url":"https://github.com/magit/magit/pull/2293.patch"},"body":"Open pr so that we have a place to talk about it. Edit: for previous discussions see #2094.\r\n\r\nIf Eli says one should not use newlines in overlays then we should try to follow his advise but unfortunately I have run into several issues with his approach too, which are just as much beyond our control as the issue with the old newline-approach, which I fixed for us. We might end up having to ask him for workarounds to be able to follow his advice.\r\n\r\nSince the current approach works and I want to get a release out, I see no reason to rush this. But I would like to work with Eli to address the issues that are coming up here - they have bothered me in different contexts before.\r\n\r\nThere also were two issues with you implementation which I addressed in v2. When both the overline and the underline overlays were on the same line, then the underlining did not work. And you didn't account for pixel-wise resizing of windows."},"comment":{"url":"https://api.github.com/repos/magit/magit/issues/comments/149023914","html_url":"https://github.com/magit/magit/pull/2293#issuecomment-149023914","issue_url":"https://api.github.com/repos/magit/magit/issues/2293","id":149023914,"user":{"login":"tarsius","id":25046,"avatar_url":"https://avatars.githubusercontent.com/u/25046?v=3","gravatar_id":"","url":"https://api.github.com/users/tarsius","html_url":"https://github.com/tarsius","followers_url":"https://api.github.com/users/tarsius/followers","following_url":"https://api.github.com/users/tarsius/following{/other_user}","gists_url":"https://api.github.com/users/tarsius/gists{/gist_id}","starred_url":"https://api.github.com/users/tarsius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarsius/subscriptions","organizations_url":"https://api.github.com/users/tarsius/orgs","repos_url":"https://api.github.com/users/tarsius/repos","events_url":"https://api.github.com/users/tarsius/events{/privacy}","received_events_url":"https://api.github.com/users/tarsius/received_events","type":"User","site_admin":false},"created_at":"2015-10-18T15:09:30Z","updated_at":"2015-10-18T15:09:30Z","body":"I lean toward let's keep what is working now until it starts breaking. We should however have a patch ready for when it does start breaking."}}