{"action":"created","comment":{"url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/comments/40675631","id":40675631,"diff_hunk":"@@ -212,6 +213,12 @@ define(['underscore', 'oae.api.admin', 'oae.api.authentication', 'oae.api.config\n          * @param  {Function}       callback            Invoked when the accept invitation request is complete\n          */\n         var acceptInvitation = function(callback) {\n+            // We cannot accept an invitation as the anonymous user. Let the\n+            // signup page handle it\n+            if (oae.data.me.anon) {","path":"shared/oae/api/oae.api.js","position":35,"original_position":35,"commit_id":"136c5131e6583245ccc420917c092588115df8c7","original_commit_id":"136c5131e6583245ccc420917c092588115df8c7","user":{"login":"mrvisser","id":102265,"avatar_url":"https://avatars.githubusercontent.com/u/102265?v=3","gravatar_id":"","url":"https://api.github.com/users/mrvisser","html_url":"https://github.com/mrvisser","followers_url":"https://api.github.com/users/mrvisser/followers","following_url":"https://api.github.com/users/mrvisser/following{/other_user}","gists_url":"https://api.github.com/users/mrvisser/gists{/gist_id}","starred_url":"https://api.github.com/users/mrvisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrvisser/subscriptions","organizations_url":"https://api.github.com/users/mrvisser/orgs","repos_url":"https://api.github.com/users/mrvisser/repos","events_url":"https://api.github.com/users/mrvisser/events{/privacy}","received_events_url":"https://api.github.com/users/mrvisser/received_events","type":"User","site_admin":false},"body":"Incoming invitations are sent to the `/signup` page, which handles this specially. There should be no case to be on `/`, for example, and be anonymous with invitation data in the query string.","created_at":"2015-09-29T14:11:29Z","updated_at":"2015-09-29T14:11:29Z","html_url":"https://github.com/oaeproject/3akai-ux/pull/4075#discussion_r40675631","pull_request_url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4075","_links":{"self":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/comments/40675631"},"html":{"href":"https://github.com/oaeproject/3akai-ux/pull/4075#discussion_r40675631"},"pull_request":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4075"}}},"pull_request":{"url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4075","id":46276638,"html_url":"https://github.com/oaeproject/3akai-ux/pull/4075","diff_url":"https://github.com/oaeproject/3akai-ux/pull/4075.diff","patch_url":"https://github.com/oaeproject/3akai-ux/pull/4075.patch","issue_url":"https://api.github.com/repos/oaeproject/3akai-ux/issues/4075","number":4075,"state":"open","locked":false,"title":"Cannot confirm email unless you are already signed in","user":{"login":"mrvisser","id":102265,"avatar_url":"https://avatars.githubusercontent.com/u/102265?v=3","gravatar_id":"","url":"https://api.github.com/users/mrvisser","html_url":"https://github.com/mrvisser","followers_url":"https://api.github.com/users/mrvisser/followers","following_url":"https://api.github.com/users/mrvisser/following{/other_user}","gists_url":"https://api.github.com/users/mrvisser/gists{/gist_id}","starred_url":"https://api.github.com/users/mrvisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrvisser/subscriptions","organizations_url":"https://api.github.com/users/mrvisser/orgs","repos_url":"https://api.github.com/users/mrvisser/repos","events_url":"https://api.github.com/users/mrvisser/events{/privacy}","received_events_url":"https://api.github.com/users/mrvisser/received_events","type":"User","site_admin":false},"body":"When the user is not already signed in to the OAE and they click on the \"Verify my email\" button in the email verification email, they are not presented the signin option when they arrive at the OAE, and there is no longer any redirect url to accept the verification.\r\n\r\nPreviously, redirecting to `/me` would cause a redirect to `/` with a `?url=` parameter for redirect. We should try and do something similar on the `/` page, however it will be a bit trickier because we need to reliably determine when to redirect. If we just send directly to `/?url=...`, then that might not have the desired effect when the user is already signed in.","created_at":"2015-09-29T13:29:55Z","updated_at":"2015-09-29T14:11:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fc15429a96e4f8082fcf5bc40c3f1b75f78645f","assignee":{"login":"mrvisser","id":102265,"avatar_url":"https://avatars.githubusercontent.com/u/102265?v=3","gravatar_id":"","url":"https://api.github.com/users/mrvisser","html_url":"https://github.com/mrvisser","followers_url":"https://api.github.com/users/mrvisser/followers","following_url":"https://api.github.com/users/mrvisser/following{/other_user}","gists_url":"https://api.github.com/users/mrvisser/gists{/gist_id}","starred_url":"https://api.github.com/users/mrvisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrvisser/subscriptions","organizations_url":"https://api.github.com/users/mrvisser/orgs","repos_url":"https://api.github.com/users/mrvisser/repos","events_url":"https://api.github.com/users/mrvisser/events{/privacy}","received_events_url":"https://api.github.com/users/mrvisser/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4075/commits","review_comments_url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4075/comments","review_comment_url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oaeproject/3akai-ux/issues/4075/comments","statuses_url":"https://api.github.com/repos/oaeproject/3akai-ux/statuses/136c5131e6583245ccc420917c092588115df8c7","head":{"label":"mrvisser:issue-4075","ref":"issue-4075","sha":"136c5131e6583245ccc420917c092588115df8c7","user":{"login":"mrvisser","id":102265,"avatar_url":"https://avatars.githubusercontent.com/u/102265?v=3","gravatar_id":"","url":"https://api.github.com/users/mrvisser","html_url":"https://github.com/mrvisser","followers_url":"https://api.github.com/users/mrvisser/followers","following_url":"https://api.github.com/users/mrvisser/following{/other_user}","gists_url":"https://api.github.com/users/mrvisser/gists{/gist_id}","starred_url":"https://api.github.com/users/mrvisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrvisser/subscriptions","organizations_url":"https://api.github.com/users/mrvisser/orgs","repos_url":"https://api.github.com/users/mrvisser/repos","events_url":"https://api.github.com/users/mrvisser/events{/privacy}","received_events_url":"https://api.github.com/users/mrvisser/received_events","type":"User","site_admin":false},"repo":{"id":3808076,"name":"3akai-ux","full_name":"mrvisser/3akai-ux","owner":{"login":"mrvisser","id":102265,"avatar_url":"https://avatars.githubusercontent.com/u/102265?v=3","gravatar_id":"","url":"https://api.github.com/users/mrvisser","html_url":"https://github.com/mrvisser","followers_url":"https://api.github.com/users/mrvisser/followers","following_url":"https://api.github.com/users/mrvisser/following{/other_user}","gists_url":"https://api.github.com/users/mrvisser/gists{/gist_id}","starred_url":"https://api.github.com/users/mrvisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrvisser/subscriptions","organizations_url":"https://api.github.com/users/mrvisser/orgs","repos_url":"https://api.github.com/users/mrvisser/repos","events_url":"https://api.github.com/users/mrvisser/events{/privacy}","received_events_url":"https://api.github.com/users/mrvisser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrvisser/3akai-ux","description":"Front-end development for Sakai 3","fork":true,"url":"https://api.github.com/repos/mrvisser/3akai-ux","forks_url":"https://api.github.com/repos/mrvisser/3akai-ux/forks","keys_url":"https://api.github.com/repos/mrvisser/3akai-ux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrvisser/3akai-ux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrvisser/3akai-ux/teams","hooks_url":"https://api.github.com/repos/mrvisser/3akai-ux/hooks","issue_events_url":"https://api.github.com/repos/mrvisser/3akai-ux/issues/events{/number}","events_url":"https://api.github.com/repos/mrvisser/3akai-ux/events","assignees_url":"https://api.github.com/repos/mrvisser/3akai-ux/assignees{/user}","branches_url":"https://api.github.com/repos/mrvisser/3akai-ux/branches{/branch}","tags_url":"https://api.github.com/repos/mrvisser/3akai-ux/tags","blobs_url":"https://api.github.com/repos/mrvisser/3akai-ux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrvisser/3akai-ux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrvisser/3akai-ux/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrvisser/3akai-ux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrvisser/3akai-ux/statuses/{sha}","languages_url":"https://api.github.com/repos/mrvisser/3akai-ux/languages","stargazers_url":"https://api.github.com/repos/mrvisser/3akai-ux/stargazers","contributors_url":"https://api.github.com/repos/mrvisser/3akai-ux/contributors","subscribers_url":"https://api.github.com/repos/mrvisser/3akai-ux/subscribers","subscription_url":"https://api.github.com/repos/mrvisser/3akai-ux/subscription","commits_url":"https://api.github.com/repos/mrvisser/3akai-ux/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrvisser/3akai-ux/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrvisser/3akai-ux/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrvisser/3akai-ux/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrvisser/3akai-ux/contents/{+path}","compare_url":"https://api.github.com/repos/mrvisser/3akai-ux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrvisser/3akai-ux/merges","archive_url":"https://api.github.com/repos/mrvisser/3akai-ux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrvisser/3akai-ux/downloads","issues_url":"https://api.github.com/repos/mrvisser/3akai-ux/issues{/number}","pulls_url":"https://api.github.com/repos/mrvisser/3akai-ux/pulls{/number}","milestones_url":"https://api.github.com/repos/mrvisser/3akai-ux/milestones{/number}","notifications_url":"https://api.github.com/repos/mrvisser/3akai-ux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrvisser/3akai-ux/labels{/name}","releases_url":"https://api.github.com/repos/mrvisser/3akai-ux/releases{/id}","created_at":"2012-03-23T12:28:27Z","updated_at":"2015-05-13T12:36:09Z","pushed_at":"2015-09-29T13:29:49Z","git_url":"git://github.com/mrvisser/3akai-ux.git","ssh_url":"git@github.com:mrvisser/3akai-ux.git","clone_url":"https://github.com/mrvisser/3akai-ux.git","svn_url":"https://github.com/mrvisser/3akai-ux","homepage":"3akai.sakaiproject.org/dev","size":133147,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"oaeproject:master","ref":"master","sha":"3f0a44cee1563fbd76627bb23c3526bdc9068c42","user":{"login":"oaeproject","id":4659912,"avatar_url":"https://avatars.githubusercontent.com/u/4659912?v=3","gravatar_id":"","url":"https://api.github.com/users/oaeproject","html_url":"https://github.com/oaeproject","followers_url":"https://api.github.com/users/oaeproject/followers","following_url":"https://api.github.com/users/oaeproject/following{/other_user}","gists_url":"https://api.github.com/users/oaeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/oaeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oaeproject/subscriptions","organizations_url":"https://api.github.com/users/oaeproject/orgs","repos_url":"https://api.github.com/users/oaeproject/repos","events_url":"https://api.github.com/users/oaeproject/events{/privacy}","received_events_url":"https://api.github.com/users/oaeproject/received_events","type":"Organization","site_admin":false},"repo":{"id":761723,"name":"3akai-ux","full_name":"oaeproject/3akai-ux","owner":{"login":"oaeproject","id":4659912,"avatar_url":"https://avatars.githubusercontent.com/u/4659912?v=3","gravatar_id":"","url":"https://api.github.com/users/oaeproject","html_url":"https://github.com/oaeproject","followers_url":"https://api.github.com/users/oaeproject/followers","following_url":"https://api.github.com/users/oaeproject/following{/other_user}","gists_url":"https://api.github.com/users/oaeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/oaeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oaeproject/subscriptions","organizations_url":"https://api.github.com/users/oaeproject/orgs","repos_url":"https://api.github.com/users/oaeproject/repos","events_url":"https://api.github.com/users/oaeproject/events{/privacy}","received_events_url":"https://api.github.com/users/oaeproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oaeproject/3akai-ux","description":"Open Academic Environment (OAE) Front-End","fork":false,"url":"https://api.github.com/repos/oaeproject/3akai-ux","forks_url":"https://api.github.com/repos/oaeproject/3akai-ux/forks","keys_url":"https://api.github.com/repos/oaeproject/3akai-ux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oaeproject/3akai-ux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oaeproject/3akai-ux/teams","hooks_url":"https://api.github.com/repos/oaeproject/3akai-ux/hooks","issue_events_url":"https://api.github.com/repos/oaeproject/3akai-ux/issues/events{/number}","events_url":"https://api.github.com/repos/oaeproject/3akai-ux/events","assignees_url":"https://api.github.com/repos/oaeproject/3akai-ux/assignees{/user}","branches_url":"https://api.github.com/repos/oaeproject/3akai-ux/branches{/branch}","tags_url":"https://api.github.com/repos/oaeproject/3akai-ux/tags","blobs_url":"https://api.github.com/repos/oaeproject/3akai-ux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oaeproject/3akai-ux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oaeproject/3akai-ux/git/refs{/sha}","trees_url":"https://api.github.com/repos/oaeproject/3akai-ux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oaeproject/3akai-ux/statuses/{sha}","languages_url":"https://api.github.com/repos/oaeproject/3akai-ux/languages","stargazers_url":"https://api.github.com/repos/oaeproject/3akai-ux/stargazers","contributors_url":"https://api.github.com/repos/oaeproject/3akai-ux/contributors","subscribers_url":"https://api.github.com/repos/oaeproject/3akai-ux/subscribers","subscription_url":"https://api.github.com/repos/oaeproject/3akai-ux/subscription","commits_url":"https://api.github.com/repos/oaeproject/3akai-ux/commits{/sha}","git_commits_url":"https://api.github.com/repos/oaeproject/3akai-ux/git/commits{/sha}","comments_url":"https://api.github.com/repos/oaeproject/3akai-ux/comments{/number}","issue_comment_url":"https://api.github.com/repos/oaeproject/3akai-ux/issues/comments{/number}","contents_url":"https://api.github.com/repos/oaeproject/3akai-ux/contents/{+path}","compare_url":"https://api.github.com/repos/oaeproject/3akai-ux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oaeproject/3akai-ux/merges","archive_url":"https://api.github.com/repos/oaeproject/3akai-ux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oaeproject/3akai-ux/downloads","issues_url":"https://api.github.com/repos/oaeproject/3akai-ux/issues{/number}","pulls_url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls{/number}","milestones_url":"https://api.github.com/repos/oaeproject/3akai-ux/milestones{/number}","notifications_url":"https://api.github.com/repos/oaeproject/3akai-ux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oaeproject/3akai-ux/labels{/name}","releases_url":"https://api.github.com/repos/oaeproject/3akai-ux/releases{/id}","created_at":"2010-07-07T12:48:50Z","updated_at":"2015-09-08T04:00:40Z","pushed_at":"2015-09-29T13:29:56Z","git_url":"git://github.com/oaeproject/3akai-ux.git","ssh_url":"git@github.com:oaeproject/3akai-ux.git","clone_url":"https://github.com/oaeproject/3akai-ux.git","svn_url":"https://github.com/oaeproject/3akai-ux","homepage":"http://www.oaeproject.org","size":174056,"stargazers_count":128,"watchers_count":128,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":223,"mirror_url":null,"open_issues_count":65,"forks":223,"open_issues":65,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4075"},"html":{"href":"https://github.com/oaeproject/3akai-ux/pull/4075"},"issue":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/issues/4075"},"comments":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/issues/4075/comments"},"review_comments":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4075/comments"},"review_comment":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4075/commits"},"statuses":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/statuses/136c5131e6583245ccc420917c092588115df8c7"}}}}