{"action":"created","issue":{"url":"https://api.github.com/repos/acemod/ACE3/issues/2141","labels_url":"https://api.github.com/repos/acemod/ACE3/issues/2141/labels{/name}","comments_url":"https://api.github.com/repos/acemod/ACE3/issues/2141/comments","events_url":"https://api.github.com/repos/acemod/ACE3/issues/2141/events","html_url":"https://github.com/acemod/ACE3/pull/2141","id":100827956,"number":2141,"title":"Adding vehicle refueling","user":{"login":"GitHawk","id":1816059,"avatar_url":"https://avatars.githubusercontent.com/u/1816059?v=3","gravatar_id":"","url":"https://api.github.com/users/GitHawk","html_url":"https://github.com/GitHawk","followers_url":"https://api.github.com/users/GitHawk/followers","following_url":"https://api.github.com/users/GitHawk/following{/other_user}","gists_url":"https://api.github.com/users/GitHawk/gists{/gist_id}","starred_url":"https://api.github.com/users/GitHawk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GitHawk/subscriptions","organizations_url":"https://api.github.com/users/GitHawk/orgs","repos_url":"https://api.github.com/users/GitHawk/repos","events_url":"https://api.github.com/users/GitHawk/events{/privacy}","received_events_url":"https://api.github.com/users/GitHawk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/acemod/ACE3/labels/feature%20request","name":"feature request","color":"0052cc"},{"url":"https://api.github.com/repos/acemod/ACE3/labels/WIP","name":"WIP","color":"fad8c7"}],"state":"open","locked":false,"assignee":{"login":"Glowbal","id":5007509,"avatar_url":"https://avatars.githubusercontent.com/u/5007509?v=3","gravatar_id":"","url":"https://api.github.com/users/Glowbal","html_url":"https://github.com/Glowbal","followers_url":"https://api.github.com/users/Glowbal/followers","following_url":"https://api.github.com/users/Glowbal/following{/other_user}","gists_url":"https://api.github.com/users/Glowbal/gists{/gist_id}","starred_url":"https://api.github.com/users/Glowbal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Glowbal/subscriptions","organizations_url":"https://api.github.com/users/Glowbal/orgs","repos_url":"https://api.github.com/users/Glowbal/repos","events_url":"https://api.github.com/users/Glowbal/events{/privacy}","received_events_url":"https://api.github.com/users/Glowbal/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/acemod/ACE3/milestones/6","html_url":"https://github.com/acemod/ACE3/milestones/3.3.0","labels_url":"https://api.github.com/repos/acemod/ACE3/milestones/6/labels","id":1120680,"number":6,"title":"3.3.0","description":"","creator":{"login":"bux578","id":1235520,"avatar_url":"https://avatars.githubusercontent.com/u/1235520?v=3","gravatar_id":"","url":"https://api.github.com/users/bux578","html_url":"https://github.com/bux578","followers_url":"https://api.github.com/users/bux578/followers","following_url":"https://api.github.com/users/bux578/following{/other_user}","gists_url":"https://api.github.com/users/bux578/gists{/gist_id}","starred_url":"https://api.github.com/users/bux578/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bux578/subscriptions","organizations_url":"https://api.github.com/users/bux578/orgs","repos_url":"https://api.github.com/users/bux578/repos","events_url":"https://api.github.com/users/bux578/events{/privacy}","received_events_url":"https://api.github.com/users/bux578/received_events","type":"User","site_admin":false},"open_issues":121,"closed_issues":91,"state":"open","created_at":"2015-05-20T10:38:55Z","updated_at":"2015-08-13T22:15:09Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2015-08-13T17:45:02Z","updated_at":"2015-08-14T01:58:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/acemod/ACE3/pulls/2141","html_url":"https://github.com/acemod/ACE3/pull/2141","diff_url":"https://github.com/acemod/ACE3/pull/2141.diff","patch_url":"https://github.com/acemod/ACE3/pull/2141.patch"},"body":"As discussed with @Glowbal on slack, a PR for including vehicle refueling into ACE.\r\n\r\nNEED TO FIX\r\n- [x] Module Init doesn't work, getting no global vars yet\r\n- [ ] ace_interact should add interactions to \"All\" so we can always extend\r\n- [ ] ace_vehicles messes with fuel capacity instead of fuelconsumption - why? Messes up my tank volumes\r\n- [ ] ace_interact_menu sometimes does not render the menu at the correct distance\r\n\r\nNEED TO DO\r\n- [ ] Let someone make a custom fuel nozzle 3D model\r\n- [ ] Let someone make an ace module icon\r\n- [ ] Add ace hint on fueling progress, when in proximity to fuel truck\r\n- [x] Dropping and picking up nozzle\r\n- [x] Add pfh to prevent player from walking to far with nozzle\r\n- [ ] Add pickup and drop animations\r\n- [ ] Fuel canisters\r\n- [x] MP testing\r\n- [ ] Stationary object testing\r\n...\r\n\r\nDONE\r\n- [x] SP testing\r\n- [x] Core coding"},"comment":{"url":"https://api.github.com/repos/acemod/ACE3/issues/comments/130918974","html_url":"https://github.com/acemod/ACE3/pull/2141#issuecomment-130918974","issue_url":"https://api.github.com/repos/acemod/ACE3/issues/2141","id":130918974,"user":{"login":"jonpas","id":7935003,"avatar_url":"https://avatars.githubusercontent.com/u/7935003?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpas","html_url":"https://github.com/jonpas","followers_url":"https://api.github.com/users/jonpas/followers","following_url":"https://api.github.com/users/jonpas/following{/other_user}","gists_url":"https://api.github.com/users/jonpas/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpas/subscriptions","organizations_url":"https://api.github.com/users/jonpas/orgs","repos_url":"https://api.github.com/users/jonpas/repos","events_url":"https://api.github.com/users/jonpas/events{/privacy}","received_events_url":"https://api.github.com/users/jonpas/received_events","type":"User","site_admin":false},"created_at":"2015-08-14T01:58:32Z","updated_at":"2015-08-14T01:58:32Z","body":"> Sometimes it overwrites other actions (e.g. the attach action).\r\n\r\nYou need to make sure you inherit the actions correctly when **not** adding to one of the **top-level** classes (`CAManBase`, `Car`, `Tank`, `Helicopter`, `Plane`, `Ship_F`, `StaticWeapon` ...). You can checkout an example [here](https://github.com/acemod/ACE3/blob/dfec850aa87dc01ce4c69ec318c6ff245428e7b9/addons/logistics_uavbattery/CfgVehicles.hpp).\r\n\r\n> No, I takes their range as a base and leaves consumption as it is. I would change consumption to get a certain range out of vanilla volume.\r\nE.g. Vanilla Merkava has ~1300 Liters and with a range of 600 km thats over 2L/km and not 0.165 as assumed by ace_vehicle.\r\nBut maybe consumption is broken and changing volume is the only way to affect range?\r\n\r\nFuel factor found [here](https://github.com/acemod/ACE3/blob/dfec850aa87dc01ce4c69ec318c6ff245428e7b9/addons/vehicles/script_component.hpp#L14) gets multiplied in the config (eg. [here](https://github.com/acemod/ACE3/blob/dfec850aa87dc01ce4c69ec318c6ff245428e7b9/addons/vehicles/CfgVehicles.hpp#L101)), is this still wrong? If that's the case, we should ask @KoffeinFlummi and @commy2 as they are maintainers of that `vehicles` component or fill out a separate issue which can be looked at.\r\n\r\n> Here are some screenshots (hint with distance in top right corner):\r\n\r\nInteresting, looks like a bug to me, could you fill in a separate issue for it with whatever information you can provide (since you've clearly spent most time in it)?\r\n\r\n> Also the base interact point is sometimes rendered at 10m, and all sub points as well, even if they have a lower distance specified in config. Only workaround is to add a range calculation to the condition function.\r\n\r\nSame as above, another interesting bug probably deserving it's own issue. :banana: "}}