{"action":"closed","number":10099,"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/10099","id":42125583,"html_url":"https://github.com/guardian/frontend/pull/10099","diff_url":"https://github.com/guardian/frontend/pull/10099.diff","patch_url":"https://github.com/guardian/frontend/pull/10099.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/10099","number":10099,"state":"closed","locked":false,"title":"Mobile version with only two ads","user":{"login":"uplne","id":2579465,"avatar_url":"https://avatars.githubusercontent.com/u/2579465?v=3","gravatar_id":"","url":"https://api.github.com/users/uplne","html_url":"https://github.com/uplne","followers_url":"https://api.github.com/users/uplne/followers","following_url":"https://api.github.com/users/uplne/following{/other_user}","gists_url":"https://api.github.com/users/uplne/gists{/gist_id}","starred_url":"https://api.github.com/users/uplne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uplne/subscriptions","organizations_url":"https://api.github.com/users/uplne/orgs","repos_url":"https://api.github.com/users/uplne/repos","events_url":"https://api.github.com/users/uplne/events{/privacy}","received_events_url":"https://api.github.com/users/uplne/received_events","type":"User","site_admin":false},"body":"On mobile show max 2 ads. That means we show most popular MPU only when there is only one inline MPU.\r\n\r\nI also did some cleaning in the DFP. We don't really need rendered and displayed as it was needed when we didn't have lazy loading (validator was complaining about it already).\r\n\r\nWe have a few ads which needs to load instantly. I moved those checks to own method.\r\n\r\nIn the next PR I will remove viewability switch and remove displayAds for good. So we will be only lazy loading.\r\n\r\nCC @Calanthe @kelvin-chappell @jbreckmckye ","created_at":"2015-08-11T12:58:07Z","updated_at":"2015-08-12T08:16:02Z","closed_at":"2015-08-12T08:16:02Z","merged_at":"2015-08-12T08:16:02Z","merge_commit_sha":"e74294d88be530682c8165def5e91f123e454d0b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/10099/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/10099/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/10099/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/cdb8aaad4001acb56ac35792aec046cdf62ce36b","head":{"label":"guardian:mobile-only-two-ads","ref":"mobile-only-two-ads","sha":"cdb8aaad4001acb56ac35792aec046cdf62ce36b","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2015-08-12T00:00:15Z","pushed_at":"2015-08-12T08:16:02Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":498212,"stargazers_count":2865,"watchers_count":2865,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"open_issues_count":64,"forks":273,"open_issues":64,"watchers":2865,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"ec864d04b38472d515deff0e29f51ebb2309eed3","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2015-08-12T00:00:15Z","pushed_at":"2015-08-12T08:16:02Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":498212,"stargazers_count":2865,"watchers_count":2865,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"open_issues_count":64,"forks":273,"open_issues":64,"watchers":2865,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/10099"},"html":{"href":"https://github.com/guardian/frontend/pull/10099"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/10099"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/10099/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/10099/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/10099/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/cdb8aaad4001acb56ac35792aec046cdf62ce36b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"uplne","id":2579465,"avatar_url":"https://avatars.githubusercontent.com/u/2579465?v=3","gravatar_id":"","url":"https://api.github.com/users/uplne","html_url":"https://github.com/uplne","followers_url":"https://api.github.com/users/uplne/followers","following_url":"https://api.github.com/users/uplne/following{/other_user}","gists_url":"https://api.github.com/users/uplne/gists{/gist_id}","starred_url":"https://api.github.com/users/uplne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uplne/subscriptions","organizations_url":"https://api.github.com/users/uplne/orgs","repos_url":"https://api.github.com/users/uplne/repos","events_url":"https://api.github.com/users/uplne/events{/privacy}","received_events_url":"https://api.github.com/users/uplne/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":8,"additions":56,"deletions":38,"changed_files":4}}