{"action":"created","issue":{"url":"https://api.github.com/repos/AndreaCensi/csm/issues/13","labels_url":"https://api.github.com/repos/AndreaCensi/csm/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/AndreaCensi/csm/issues/13/comments","events_url":"https://api.github.com/repos/AndreaCensi/csm/issues/13/events","html_url":"https://github.com/AndreaCensi/csm/pull/13","id":114514860,"number":13,"title":"add patches from laser_scan_mather and fixed some of CMakeLists.txt","user":{"login":"k-okada","id":493276,"avatar_url":"https://avatars.githubusercontent.com/u/493276?v=3","gravatar_id":"","url":"https://api.github.com/users/k-okada","html_url":"https://github.com/k-okada","followers_url":"https://api.github.com/users/k-okada/followers","following_url":"https://api.github.com/users/k-okada/following{/other_user}","gists_url":"https://api.github.com/users/k-okada/gists{/gist_id}","starred_url":"https://api.github.com/users/k-okada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-okada/subscriptions","organizations_url":"https://api.github.com/users/k-okada/orgs","repos_url":"https://api.github.com/users/k-okada/repos","events_url":"https://api.github.com/users/k-okada/events{/privacy}","received_events_url":"https://api.github.com/users/k-okada/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-11-02T02:57:57Z","updated_at":"2015-11-03T11:00:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AndreaCensi/csm/pulls/13","html_url":"https://github.com/AndreaCensi/csm/pull/13","diff_url":"https://github.com/AndreaCensi/csm/pull/13.diff","patch_url":"https://github.com/AndreaCensi/csm/pull/13.patch"},"body":"-  add cm_icp_xy from  https://github.com/ccny-ros-pkg/scan_tools/tree/indigo/laser_scan_matcher/csm/patches\r\n-  sm/CMakeLists.txt add -fPIC (relocation R_X86_64_32 against '.rodata' can  not be used when making a shared object; recompile with -fPIC)\r\n- sm/CMakeLists.txt use TARGETS instaed of PROGRAMS, this fails if you compile on different directory \r\n- package.xml : add libgsl to run_depend see https://github.com/AndreaCensi/csm/blob/master/sm/pkg-config/csm.pc.in#L7"},"comment":{"url":"https://api.github.com/repos/AndreaCensi/csm/issues/comments/153314989","html_url":"https://github.com/AndreaCensi/csm/pull/13#issuecomment-153314989","issue_url":"https://api.github.com/repos/AndreaCensi/csm/issues/13","id":153314989,"user":{"login":"k-okada","id":493276,"avatar_url":"https://avatars.githubusercontent.com/u/493276?v=3","gravatar_id":"","url":"https://api.github.com/users/k-okada","html_url":"https://github.com/k-okada","followers_url":"https://api.github.com/users/k-okada/followers","following_url":"https://api.github.com/users/k-okada/following{/other_user}","gists_url":"https://api.github.com/users/k-okada/gists{/gist_id}","starred_url":"https://api.github.com/users/k-okada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-okada/subscriptions","organizations_url":"https://api.github.com/users/k-okada/orgs","repos_url":"https://api.github.com/users/k-okada/repos","events_url":"https://api.github.com/users/k-okada/events{/privacy}","received_events_url":"https://api.github.com/users/k-okada/received_events","type":"User","site_admin":false},"created_at":"2015-11-03T11:00:20Z","updated_at":"2015-11-03T11:00:20Z","body":"I may overlooked something so do not confident on this, but my conclusion at this moment is;\r\n\r\n- current ros package uses 56919d39f69d1d91c4a909750ff8516c42b3f0e9\r\n- that is in master branch, one commit before https://github.com/AndreaCensi/csm/commit/7659c7e742073067ed3c6eabe411d976be121df0\r\n- so using csm_eigen is not correct, use master instead\r\n\r\n\r\n![screenshot from 2015-11-03 19 56 25](https://cloud.githubusercontent.com/assets/493276/10906476/2fa6e67e-8265-11e5-938d-8a59a2b209ae.png)\r\n![screenshot from 2015-11-03 19 56 29](https://cloud.githubusercontent.com/assets/493276/10906477/326f35d2-8265-11e5-94f7-9c6cfee30c1b.png)\r\n![screenshot from 2015-11-03 19 56 31](https://cloud.githubusercontent.com/assets/493276/10906484/36fd4bc0-8265-11e5-9312-950c4274a515.png)"}}