{"action":"closed","number":15185,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/15185","id":39130977,"html_url":"https://github.com/symfony/symfony/pull/15185","diff_url":"https://github.com/symfony/symfony/pull/15185.diff","patch_url":"https://github.com/symfony/symfony/pull/15185.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/15185","number":15185,"state":"closed","locked":false,"title":"Implement resettable containers","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | small one\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #13448\r\n| License       | MIT\r\n| Doc PR        | n/a\r\n\r\nThis allows to release remove references to all services during shutdown, giving much more chances to destruct services and the container through refcounting rather than waiting GC, as it will break cycles between the container and container-aware services.\r\n\r\nThere is a small BC break for a very edge case: if someone keeps a reference to the container and then shutdowns the kernel, the container would now be cleared and so would not work as intended anymore. But I don't think it is a supported use case. If you shutdown the kernel, the container of this kernel is released by the kernel and should not be used anymore IMO.\r\nThus, shutting down the kernel generally does not happen except during tests on teardown.\r\n\r\nI'm not sure a doc PR is needed here: users of the fullstack framework should never use this feature (the kernel is using it for them). What do you think @weaverryan ?","created_at":"2015-07-02T22:13:11Z","updated_at":"2015-07-23T02:06:37Z","closed_at":"2015-07-23T02:06:37Z","merged_at":"2015-07-23T02:06:37Z","merge_commit_sha":"2f934c52d9d3915ce9ca906bf09d3466eef1e102","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/15185/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/15185/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/15185/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/445774592920ecd9a1e752f3c447507f11193805","head":{"label":"stof:clearable_container","ref":"clearable_container","sha":"445774592920ecd9a1e752f3c447507f11193805","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"repo":{"id":1399043,"name":"symfony","full_name":"stof/symfony","owner":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stof/symfony","description":"The Symfony2 PHP framework (PHP 5.3 only -- not yet stable) -- documentation for master is at http://docs.symfony-reloaded.org/master/","fork":true,"url":"https://api.github.com/repos/stof/symfony","forks_url":"https://api.github.com/repos/stof/symfony/forks","keys_url":"https://api.github.com/repos/stof/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stof/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stof/symfony/teams","hooks_url":"https://api.github.com/repos/stof/symfony/hooks","issue_events_url":"https://api.github.com/repos/stof/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/stof/symfony/events","assignees_url":"https://api.github.com/repos/stof/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/stof/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/stof/symfony/tags","blobs_url":"https://api.github.com/repos/stof/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stof/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stof/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/stof/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stof/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/stof/symfony/languages","stargazers_url":"https://api.github.com/repos/stof/symfony/stargazers","contributors_url":"https://api.github.com/repos/stof/symfony/contributors","subscribers_url":"https://api.github.com/repos/stof/symfony/subscribers","subscription_url":"https://api.github.com/repos/stof/symfony/subscription","commits_url":"https://api.github.com/repos/stof/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/stof/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/stof/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/stof/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/stof/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/stof/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stof/symfony/merges","archive_url":"https://api.github.com/repos/stof/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stof/symfony/downloads","issues_url":"https://api.github.com/repos/stof/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/stof/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/stof/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/stof/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stof/symfony/labels{/name}","releases_url":"https://api.github.com/repos/stof/symfony/releases{/id}","created_at":"2011-02-22T19:38:18Z","updated_at":"2015-03-22T15:37:35Z","pushed_at":"2015-07-22T08:09:34Z","git_url":"git://github.com/stof/symfony.git","ssh_url":"git@github.com:stof/symfony.git","clone_url":"https://github.com/stof/symfony.git","svn_url":"https://github.com/stof/symfony","homepage":"http://www.symfony-reloaded.org/","size":58181,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"symfony:2.8","ref":"2.8","sha":"5626d73992cf7fabe4e7be5f2c07cee34dab6e81","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-07-22T19:21:44Z","pushed_at":"2015-07-23T02:06:27Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":1197512,"stargazers_count":10509,"watchers_count":10509,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4170,"mirror_url":null,"open_issues_count":899,"forks":4170,"open_issues":899,"watchers":10509,"default_branch":"2.8"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15185"},"html":{"href":"https://github.com/symfony/symfony/pull/15185"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/15185"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/15185/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15185/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15185/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/445774592920ecd9a1e752f3c447507f11193805"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=3","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"comments":20,"review_comments":12,"commits":1,"additions":94,"deletions":1,"changed_files":5}}