{"action":"created","comment":{"url":"https://api.github.com/repos/cms-analysis/flashgg/pulls/comments/27608646","id":27608646,"diff_hunk":"@@ -85,7 +88,7 @@ namespace flashgg {\n \n     bool hasEnergyAtStep(std::string key) const;\n     float const energyAtStep(std::string key) const;\n-    float const sigEOverE() const { return sigEOverE_; };\n+    float const sigEOverE() const { return (getCorrectedEnergyError(regression_type) / energy()); } // Regression + error now in reco and base object","path":"DataFormats/interface/Photon.h","position":29,"original_position":29,"commit_id":"20084aa8268f15b6870e792437b123f8b59f84b4","original_commit_id":"20084aa8268f15b6870e792437b123f8b59f84b4","user":{"login":"musella","id":638761,"avatar_url":"https://avatars.githubusercontent.com/u/638761?v=3","gravatar_id":"","url":"https://api.github.com/users/musella","html_url":"https://github.com/musella","followers_url":"https://api.github.com/users/musella/followers","following_url":"https://api.github.com/users/musella/following{/other_user}","gists_url":"https://api.github.com/users/musella/gists{/gist_id}","starred_url":"https://api.github.com/users/musella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musella/subscriptions","organizations_url":"https://api.github.com/users/musella/orgs","repos_url":"https://api.github.com/users/musella/repos","events_url":"https://api.github.com/users/musella/events{/privacy}","received_events_url":"https://api.github.com/users/musella/received_events","type":"User","site_admin":false},"body":"Isn't there a sigmaEoverE variable already stored in reco?\r\n\r\nComputing sigmaEoverE as sigmaE/E has the problem that the denominator changes upon application of energy scale corrections/smearing.\r\n\r\nIf the relative resolution is not available, I would repalce energy() with the appropriate energyAtStep() call.\r\n","created_at":"2015-04-01T20:34:51Z","updated_at":"2015-04-01T20:34:51Z","html_url":"https://github.com/cms-analysis/flashgg/pull/205#discussion_r27608646","pull_request_url":"https://api.github.com/repos/cms-analysis/flashgg/pulls/205","_links":{"self":{"href":"https://api.github.com/repos/cms-analysis/flashgg/pulls/comments/27608646"},"html":{"href":"https://github.com/cms-analysis/flashgg/pull/205#discussion_r27608646"},"pull_request":{"href":"https://api.github.com/repos/cms-analysis/flashgg/pulls/205"}}},"pull_request":{"url":"https://api.github.com/repos/cms-analysis/flashgg/pulls/205","id":32401729,"html_url":"https://github.com/cms-analysis/flashgg/pull/205","diff_url":"https://github.com/cms-analysis/flashgg/pull/205.diff","patch_url":"https://github.com/cms-analysis/flashgg/pull/205.patch","issue_url":"https://api.github.com/repos/cms-analysis/flashgg/issues/205","number":205,"state":"open","locked":false,"title":"get sigEOverE from regression in reco (default energy already regressed)","user":{"login":"sethzenz","id":1654834,"avatar_url":"https://avatars.githubusercontent.com/u/1654834?v=3","gravatar_id":"","url":"https://api.github.com/users/sethzenz","html_url":"https://github.com/sethzenz","followers_url":"https://api.github.com/users/sethzenz/followers","following_url":"https://api.github.com/users/sethzenz/following{/other_user}","gists_url":"https://api.github.com/users/sethzenz/gists{/gist_id}","starred_url":"https://api.github.com/users/sethzenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethzenz/subscriptions","organizations_url":"https://api.github.com/users/sethzenz/orgs","repos_url":"https://api.github.com/users/sethzenz/repos","events_url":"https://api.github.com/users/sethzenz/events{/privacy}","received_events_url":"https://api.github.com/users/sethzenz/received_events","type":"User","site_admin":false},"body":"Regression and regression errors are defined in reco and the code is now setup to use them.  Note that the following are equal by definition (for fg a `flashgg::Photon`):\r\n\r\n`fg.energy() == fg.getCorrectedEnergy(flashgg::Photon::regression_type)` [set in reco]\r\n`fg.sigEOverE() == fg.getCorrectedEnergyError(flashgg::Photon::regression_type)/fg.energy()` [flashgg]","created_at":"2015-04-01T09:21:41Z","updated_at":"2015-04-01T20:34:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7410986d039b07335cbbc02e38359d27d0ca0b29","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cms-analysis/flashgg/pulls/205/commits","review_comments_url":"https://api.github.com/repos/cms-analysis/flashgg/pulls/205/comments","review_comment_url":"https://api.github.com/repos/cms-analysis/flashgg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-analysis/flashgg/issues/205/comments","statuses_url":"https://api.github.com/repos/cms-analysis/flashgg/statuses/20084aa8268f15b6870e792437b123f8b59f84b4","head":{"label":"sethzenz:topic-use-reco-regression","ref":"topic-use-reco-regression","sha":"20084aa8268f15b6870e792437b123f8b59f84b4","user":{"login":"sethzenz","id":1654834,"avatar_url":"https://avatars.githubusercontent.com/u/1654834?v=3","gravatar_id":"","url":"https://api.github.com/users/sethzenz","html_url":"https://github.com/sethzenz","followers_url":"https://api.github.com/users/sethzenz/followers","following_url":"https://api.github.com/users/sethzenz/following{/other_user}","gists_url":"https://api.github.com/users/sethzenz/gists{/gist_id}","starred_url":"https://api.github.com/users/sethzenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethzenz/subscriptions","organizations_url":"https://api.github.com/users/sethzenz/orgs","repos_url":"https://api.github.com/users/sethzenz/repos","events_url":"https://api.github.com/users/sethzenz/events{/privacy}","received_events_url":"https://api.github.com/users/sethzenz/received_events","type":"User","site_admin":false},"repo":{"id":20297276,"name":"flashgg","full_name":"sethzenz/flashgg","owner":{"login":"sethzenz","id":1654834,"avatar_url":"https://avatars.githubusercontent.com/u/1654834?v=3","gravatar_id":"","url":"https://api.github.com/users/sethzenz","html_url":"https://github.com/sethzenz","followers_url":"https://api.github.com/users/sethzenz/followers","following_url":"https://api.github.com/users/sethzenz/following{/other_user}","gists_url":"https://api.github.com/users/sethzenz/gists{/gist_id}","starred_url":"https://api.github.com/users/sethzenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethzenz/subscriptions","organizations_url":"https://api.github.com/users/sethzenz/orgs","repos_url":"https://api.github.com/users/sethzenz/repos","events_url":"https://api.github.com/users/sethzenz/events{/privacy}","received_events_url":"https://api.github.com/users/sethzenz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sethzenz/flashgg","description":"","fork":true,"url":"https://api.github.com/repos/sethzenz/flashgg","forks_url":"https://api.github.com/repos/sethzenz/flashgg/forks","keys_url":"https://api.github.com/repos/sethzenz/flashgg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sethzenz/flashgg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sethzenz/flashgg/teams","hooks_url":"https://api.github.com/repos/sethzenz/flashgg/hooks","issue_events_url":"https://api.github.com/repos/sethzenz/flashgg/issues/events{/number}","events_url":"https://api.github.com/repos/sethzenz/flashgg/events","assignees_url":"https://api.github.com/repos/sethzenz/flashgg/assignees{/user}","branches_url":"https://api.github.com/repos/sethzenz/flashgg/branches{/branch}","tags_url":"https://api.github.com/repos/sethzenz/flashgg/tags","blobs_url":"https://api.github.com/repos/sethzenz/flashgg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sethzenz/flashgg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sethzenz/flashgg/git/refs{/sha}","trees_url":"https://api.github.com/repos/sethzenz/flashgg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sethzenz/flashgg/statuses/{sha}","languages_url":"https://api.github.com/repos/sethzenz/flashgg/languages","stargazers_url":"https://api.github.com/repos/sethzenz/flashgg/stargazers","contributors_url":"https://api.github.com/repos/sethzenz/flashgg/contributors","subscribers_url":"https://api.github.com/repos/sethzenz/flashgg/subscribers","subscription_url":"https://api.github.com/repos/sethzenz/flashgg/subscription","commits_url":"https://api.github.com/repos/sethzenz/flashgg/commits{/sha}","git_commits_url":"https://api.github.com/repos/sethzenz/flashgg/git/commits{/sha}","comments_url":"https://api.github.com/repos/sethzenz/flashgg/comments{/number}","issue_comment_url":"https://api.github.com/repos/sethzenz/flashgg/issues/comments{/number}","contents_url":"https://api.github.com/repos/sethzenz/flashgg/contents/{+path}","compare_url":"https://api.github.com/repos/sethzenz/flashgg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sethzenz/flashgg/merges","archive_url":"https://api.github.com/repos/sethzenz/flashgg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sethzenz/flashgg/downloads","issues_url":"https://api.github.com/repos/sethzenz/flashgg/issues{/number}","pulls_url":"https://api.github.com/repos/sethzenz/flashgg/pulls{/number}","milestones_url":"https://api.github.com/repos/sethzenz/flashgg/milestones{/number}","notifications_url":"https://api.github.com/repos/sethzenz/flashgg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sethzenz/flashgg/labels{/name}","releases_url":"https://api.github.com/repos/sethzenz/flashgg/releases{/id}","created_at":"2014-05-29T14:52:23Z","updated_at":"2015-04-01T08:14:17Z","pushed_at":"2015-04-01T09:19:33Z","git_url":"git://github.com/sethzenz/flashgg.git","ssh_url":"git@github.com:sethzenz/flashgg.git","clone_url":"https://github.com/sethzenz/flashgg.git","svn_url":"https://github.com/sethzenz/flashgg","homepage":null,"size":23390,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cms-analysis:master","ref":"master","sha":"e8d9dc3303c7b84d76ddf1f76a668edb150f9afc","user":{"login":"cms-analysis","id":4680210,"avatar_url":"https://avatars.githubusercontent.com/u/4680210?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-analysis","html_url":"https://github.com/cms-analysis","followers_url":"https://api.github.com/users/cms-analysis/followers","following_url":"https://api.github.com/users/cms-analysis/following{/other_user}","gists_url":"https://api.github.com/users/cms-analysis/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-analysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-analysis/subscriptions","organizations_url":"https://api.github.com/users/cms-analysis/orgs","repos_url":"https://api.github.com/users/cms-analysis/repos","events_url":"https://api.github.com/users/cms-analysis/events{/privacy}","received_events_url":"https://api.github.com/users/cms-analysis/received_events","type":"Organization","site_admin":false},"repo":{"id":20220358,"name":"flashgg","full_name":"cms-analysis/flashgg","owner":{"login":"cms-analysis","id":4680210,"avatar_url":"https://avatars.githubusercontent.com/u/4680210?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-analysis","html_url":"https://github.com/cms-analysis","followers_url":"https://api.github.com/users/cms-analysis/followers","following_url":"https://api.github.com/users/cms-analysis/following{/other_user}","gists_url":"https://api.github.com/users/cms-analysis/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-analysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-analysis/subscriptions","organizations_url":"https://api.github.com/users/cms-analysis/orgs","repos_url":"https://api.github.com/users/cms-analysis/repos","events_url":"https://api.github.com/users/cms-analysis/events{/privacy}","received_events_url":"https://api.github.com/users/cms-analysis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-analysis/flashgg","description":"","fork":false,"url":"https://api.github.com/repos/cms-analysis/flashgg","forks_url":"https://api.github.com/repos/cms-analysis/flashgg/forks","keys_url":"https://api.github.com/repos/cms-analysis/flashgg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-analysis/flashgg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-analysis/flashgg/teams","hooks_url":"https://api.github.com/repos/cms-analysis/flashgg/hooks","issue_events_url":"https://api.github.com/repos/cms-analysis/flashgg/issues/events{/number}","events_url":"https://api.github.com/repos/cms-analysis/flashgg/events","assignees_url":"https://api.github.com/repos/cms-analysis/flashgg/assignees{/user}","branches_url":"https://api.github.com/repos/cms-analysis/flashgg/branches{/branch}","tags_url":"https://api.github.com/repos/cms-analysis/flashgg/tags","blobs_url":"https://api.github.com/repos/cms-analysis/flashgg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-analysis/flashgg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-analysis/flashgg/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-analysis/flashgg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-analysis/flashgg/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-analysis/flashgg/languages","stargazers_url":"https://api.github.com/repos/cms-analysis/flashgg/stargazers","contributors_url":"https://api.github.com/repos/cms-analysis/flashgg/contributors","subscribers_url":"https://api.github.com/repos/cms-analysis/flashgg/subscribers","subscription_url":"https://api.github.com/repos/cms-analysis/flashgg/subscription","commits_url":"https://api.github.com/repos/cms-analysis/flashgg/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-analysis/flashgg/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-analysis/flashgg/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-analysis/flashgg/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-analysis/flashgg/contents/{+path}","compare_url":"https://api.github.com/repos/cms-analysis/flashgg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-analysis/flashgg/merges","archive_url":"https://api.github.com/repos/cms-analysis/flashgg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-analysis/flashgg/downloads","issues_url":"https://api.github.com/repos/cms-analysis/flashgg/issues{/number}","pulls_url":"https://api.github.com/repos/cms-analysis/flashgg/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-analysis/flashgg/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-analysis/flashgg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-analysis/flashgg/labels{/name}","releases_url":"https://api.github.com/repos/cms-analysis/flashgg/releases{/id}","created_at":"2014-05-27T13:10:32Z","updated_at":"2015-03-31T09:27:38Z","pushed_at":"2015-04-01T09:21:41Z","git_url":"git://github.com/cms-analysis/flashgg.git","ssh_url":"git@github.com:cms-analysis/flashgg.git","clone_url":"https://github.com/cms-analysis/flashgg.git","svn_url":"https://github.com/cms-analysis/flashgg","homepage":"","size":23623,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":16,"forks":32,"open_issues":16,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-analysis/flashgg/pulls/205"},"html":{"href":"https://github.com/cms-analysis/flashgg/pull/205"},"issue":{"href":"https://api.github.com/repos/cms-analysis/flashgg/issues/205"},"comments":{"href":"https://api.github.com/repos/cms-analysis/flashgg/issues/205/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-analysis/flashgg/pulls/205/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-analysis/flashgg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-analysis/flashgg/pulls/205/commits"},"statuses":{"href":"https://api.github.com/repos/cms-analysis/flashgg/statuses/20084aa8268f15b6870e792437b123f8b59f84b4"}}}}