{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/comments/29298491","id":29298491,"diff_hunk":"@@ -19,6 +18,13 @@ const verify = require('../browserid');\n const CODE = 'code';\n const TOKEN = 'token';\n \n+const UNTRUSTED_CLIENT_SCOPES = [\n+  'profile:uid',\n+  'profile:email',\n+  'profile:avatar',","path":"lib/routes/authorization.js","position":15,"original_position":15,"commit_id":"d6ffb524e4b546c872811693fee8d702617a8d91","original_commit_id":"d6ffb524e4b546c872811693fee8d702617a8d91","user":{"login":"rfk","id":34695,"avatar_url":"https://avatars.githubusercontent.com/u/34695?v=3","gravatar_id":"","url":"https://api.github.com/users/rfk","html_url":"https://github.com/rfk","followers_url":"https://api.github.com/users/rfk/followers","following_url":"https://api.github.com/users/rfk/following{/other_user}","gists_url":"https://api.github.com/users/rfk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfk/subscriptions","organizations_url":"https://api.github.com/users/rfk/orgs","repos_url":"https://api.github.com/users/rfk/repos","events_url":"https://api.github.com/users/rfk/events{/privacy}","received_events_url":"https://api.github.com/users/rfk/received_events","type":"User","site_admin":false},"body":"I think `display_name` is fine; @ryanfeeley thoughts?","created_at":"2015-04-28T23:19:40Z","updated_at":"2015-04-28T23:19:40Z","html_url":"https://github.com/mozilla/fxa-oauth-server/pull/248#discussion_r29298491","pull_request_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/248","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/comments/29298491"},"html":{"href":"https://github.com/mozilla/fxa-oauth-server/pull/248#discussion_r29298491"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/248"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/248","id":34317182,"html_url":"https://github.com/mozilla/fxa-oauth-server/pull/248","diff_url":"https://github.com/mozilla/fxa-oauth-server/pull/248.diff","patch_url":"https://github.com/mozilla/fxa-oauth-server/pull/248.patch","issue_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/248","number":248,"state":"open","locked":false,"title":"feat(untrusted-clients): restrict scopes that untrusted clients can request","user":{"login":"zaach","id":3903,"avatar_url":"https://avatars.githubusercontent.com/u/3903?v=3","gravatar_id":"","url":"https://api.github.com/users/zaach","html_url":"https://github.com/zaach","followers_url":"https://api.github.com/users/zaach/followers","following_url":"https://api.github.com/users/zaach/following{/other_user}","gists_url":"https://api.github.com/users/zaach/gists{/gist_id}","starred_url":"https://api.github.com/users/zaach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaach/subscriptions","organizations_url":"https://api.github.com/users/zaach/orgs","repos_url":"https://api.github.com/users/zaach/repos","events_url":"https://api.github.com/users/zaach/events{/privacy}","received_events_url":"https://api.github.com/users/zaach/received_events","type":"User","site_admin":false},"body":"@rfk r?\r\n\r\nFixes #243.","created_at":"2015-04-28T22:15:10Z","updated_at":"2015-04-28T23:19:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e028a38c7623c9d99c7e3ed1cf7253facac8a036","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/248/commits","review_comments_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/248/comments","review_comment_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/248/comments","statuses_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/statuses/d6ffb524e4b546c872811693fee8d702617a8d91","head":{"label":"mozilla:issue-243-restricted-scopes","ref":"issue-243-restricted-scopes","sha":"d6ffb524e4b546c872811693fee8d702617a8d91","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16819795,"name":"fxa-oauth-server","full_name":"mozilla/fxa-oauth-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-oauth-server","description":"OAuth server for Firefox Accounts","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-oauth-server","forks_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/releases{/id}","created_at":"2014-02-13T22:41:50Z","updated_at":"2015-04-27T21:11:24Z","pushed_at":"2015-04-28T22:23:21Z","git_url":"git://github.com/mozilla/fxa-oauth-server.git","ssh_url":"git@github.com:mozilla/fxa-oauth-server.git","clone_url":"https://github.com/mozilla/fxa-oauth-server.git","svn_url":"https://github.com/mozilla/fxa-oauth-server","homepage":"","size":3135,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":39,"forks":10,"open_issues":39,"watchers":13,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"4d5748bac4e4b06872b53aadf4e261969da3735f","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16819795,"name":"fxa-oauth-server","full_name":"mozilla/fxa-oauth-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-oauth-server","description":"OAuth server for Firefox Accounts","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-oauth-server","forks_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/releases{/id}","created_at":"2014-02-13T22:41:50Z","updated_at":"2015-04-27T21:11:24Z","pushed_at":"2015-04-28T22:23:21Z","git_url":"git://github.com/mozilla/fxa-oauth-server.git","ssh_url":"git@github.com:mozilla/fxa-oauth-server.git","clone_url":"https://github.com/mozilla/fxa-oauth-server.git","svn_url":"https://github.com/mozilla/fxa-oauth-server","homepage":"","size":3135,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":39,"forks":10,"open_issues":39,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/248"},"html":{"href":"https://github.com/mozilla/fxa-oauth-server/pull/248"},"issue":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/248"},"comments":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/248/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/248/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/248/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-server/statuses/d6ffb524e4b546c872811693fee8d702617a8d91"}}}}