{"action":"created","issue":{"url":"https://api.github.com/repos/bryanjos/joken/issues/79","labels_url":"https://api.github.com/repos/bryanjos/joken/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/bryanjos/joken/issues/79/comments","events_url":"https://api.github.com/repos/bryanjos/joken/issues/79/events","html_url":"https://github.com/bryanjos/joken/issues/79","id":104284469,"number":79,"title":"Use string keys by default in new API","user":{"login":"bryanjos","id":1257573,"avatar_url":"https://avatars.githubusercontent.com/u/1257573?v=3","gravatar_id":"","url":"https://api.github.com/users/bryanjos","html_url":"https://github.com/bryanjos","followers_url":"https://api.github.com/users/bryanjos/followers","following_url":"https://api.github.com/users/bryanjos/following{/other_user}","gists_url":"https://api.github.com/users/bryanjos/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanjos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanjos/subscriptions","organizations_url":"https://api.github.com/users/bryanjos/orgs","repos_url":"https://api.github.com/users/bryanjos/repos","events_url":"https://api.github.com/users/bryanjos/events{/privacy}","received_events_url":"https://api.github.com/users/bryanjos/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bryanjos/joken/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-09-01T14:52:19Z","updated_at":"2015-09-01T17:49:31Z","closed_at":null,"body":"I asked about what's the best practice for string keys vs atom keys and the response I got was \"string keys for user input, atom keys for everything else\". I also know that Guardian, which currently uses this library, uses string keys as well. Right now, the default token uses atoms for the claims and validations and the verify function turns the strings into atoms after JSON decoding.\r\n\r\nI think we should use strings for keys by default and only use atoms when the user adds a claim or validation using one, a struct is used, and in the case of verify when a struct is given or an option to use atoms is given.\r\n\r\n@cs-victor-nascimento what do you think?\r\n@hassox maybe you would like to chime in as well?"},"comment":{"url":"https://api.github.com/repos/bryanjos/joken/issues/comments/136810512","html_url":"https://github.com/bryanjos/joken/issues/79#issuecomment-136810512","issue_url":"https://api.github.com/repos/bryanjos/joken/issues/79","id":136810512,"user":{"login":"cs-victor-nascimento","id":7049728,"avatar_url":"https://avatars.githubusercontent.com/u/7049728?v=3","gravatar_id":"","url":"https://api.github.com/users/cs-victor-nascimento","html_url":"https://github.com/cs-victor-nascimento","followers_url":"https://api.github.com/users/cs-victor-nascimento/followers","following_url":"https://api.github.com/users/cs-victor-nascimento/following{/other_user}","gists_url":"https://api.github.com/users/cs-victor-nascimento/gists{/gist_id}","starred_url":"https://api.github.com/users/cs-victor-nascimento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cs-victor-nascimento/subscriptions","organizations_url":"https://api.github.com/users/cs-victor-nascimento/orgs","repos_url":"https://api.github.com/users/cs-victor-nascimento/repos","events_url":"https://api.github.com/users/cs-victor-nascimento/events{/privacy}","received_events_url":"https://api.github.com/users/cs-victor-nascimento/received_events","type":"User","site_admin":false},"created_at":"2015-09-01T17:49:30Z","updated_at":"2015-09-01T17:49:30Z","body":"I agree with you. It is best to go a safe route here.\n\nOn Tue, Sep 1, 2015 at 2:31 PM, Bryan Joseph <notifications@github.com>\nwrote:\n\n> I think using binary keys as a default will be better. I much prefer atoms\n> myself honestly, but I know there are some concerns about using them. I can\n> put together a PR for this today if I get a chance.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/bryanjos/joken/issues/79#issuecomment-136805338>.\n>\n\n\n\n-- \nVictor Oliveira Nascimento\n*Concrete* *Solutions*\nSenior Analyst/Developer\nvictor.nascimento@concretesolutions.com.br\nhttp://www.concretesolutions.com.br\nMobile: +55 11 9 8923-8061\n\n\n\nRio de Janeiro                                     São Paulo\nRua São José 90, sala 2121                 Rua Flórida 1670, Sala 22\nCep: 20010-020                                   Cep: 04565-001\nCentro - Rio de Janeiro - Brasil             Brooklin - São Paulo – Brasil\nPhone : +55 21 2240-2030                   Phone: +55 11 4119 0449\n"}}