{"action":"opened","issue":{"url":"https://api.github.com/repos/ajaxorg/ace/issues/2433","labels_url":"https://api.github.com/repos/ajaxorg/ace/issues/2433/labels{/name}","comments_url":"https://api.github.com/repos/ajaxorg/ace/issues/2433/comments","events_url":"https://api.github.com/repos/ajaxorg/ace/issues/2433/events","html_url":"https://github.com/ajaxorg/ace/issues/2433","id":65703477,"number":2433,"title":"invalid file generated by dryice build when given a browserified file","user":{"login":"chmontgomery","id":232356,"avatar_url":"https://avatars.githubusercontent.com/u/232356?v=3","gravatar_id":"","url":"https://api.github.com/users/chmontgomery","html_url":"https://github.com/chmontgomery","followers_url":"https://api.github.com/users/chmontgomery/followers","following_url":"https://api.github.com/users/chmontgomery/following{/other_user}","gists_url":"https://api.github.com/users/chmontgomery/gists{/gist_id}","starred_url":"https://api.github.com/users/chmontgomery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chmontgomery/subscriptions","organizations_url":"https://api.github.com/users/chmontgomery/orgs","repos_url":"https://api.github.com/users/chmontgomery/repos","events_url":"https://api.github.com/users/chmontgomery/events{/privacy}","received_events_url":"https://api.github.com/users/chmontgomery/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-04-01T14:45:38Z","updated_at":"2015-04-01T14:45:38Z","closed_at":null,"body":"I'm attempting to add a new worker js file, in this case for gherkin.\r\n\r\nSpecifically, I ran browserify against this set of files: https://github.com/cucumber/gherkin3/tree/master/javascript/lib/gherkin\r\n\r\nThen, I took the browserify bundle, put it under `\\lib\\ace\\mode\\gherkin\\` and ran the ace build like so: `node ./Makefile.dryice.js full --target ../ace-builds`. After doing so, the build finishes with no errors and outputs invalid `worker-gherkin.js` files.  For example, `src-noconflict/worker-gherkin.js` has the following invalid lines: `function ace.define(name, deps, m) {`. When I try to load it in the browser, I get these failures:\r\n![screen shot 2015-04-01 at 8 57 05 am](https://cloud.githubusercontent.com/assets/232356/6942954/8a735a02-d850-11e4-9ee9-4fbf50cfdd76.png)\r\n\r\n`src/worker-gherkin.js` does not load in the browser either. It throws the following errors:\r\n![screen shot 2015-04-01 at 8 55 48 am](https://cloud.githubusercontent.com/assets/232356/6942972/9f47df2a-d850-11e4-9e11-c91ed5b4a845.png)\r\n\r\nIs this simply a limitation with dryice or how you've implemented it? I noticed the other worker files (csslint, json_parse, jshint, etc) are pre-wrapped with amd syntax. Is this an expectation? The strange thing is, if I wrap my browserified bundle with amd it still doesn't work. The only way I was able to get dryice to build my files properly was to have them as their original src files, wrapped with amd syntax, as seen in this PR: https://github.com/ajaxorg/ace/pull/2429.\r\n\r\nAt the end of the day, I would prefer to provide a browserify bundle instead of the loose src files.\r\n\r\n"}}