{"action":"closed","number":2322,"pull_request":{"url":"https://api.github.com/repos/socketio/socket.io/pulls/2322","id":51528616,"html_url":"https://github.com/socketio/socket.io/pull/2322","diff_url":"https://github.com/socketio/socket.io/pull/2322.diff","patch_url":"https://github.com/socketio/socket.io/pull/2322.patch","issue_url":"https://api.github.com/repos/socketio/socket.io/issues/2322","number":2322,"state":"closed","locked":false,"title":"Add hasOwnProperty checks","user":{"login":"darrachequesne","id":13031701,"avatar_url":"https://avatars.githubusercontent.com/u/13031701?v=3","gravatar_id":"","url":"https://api.github.com/users/darrachequesne","html_url":"https://github.com/darrachequesne","followers_url":"https://api.github.com/users/darrachequesne/followers","following_url":"https://api.github.com/users/darrachequesne/following{/other_user}","gists_url":"https://api.github.com/users/darrachequesne/gists{/gist_id}","starred_url":"https://api.github.com/users/darrachequesne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrachequesne/subscriptions","organizations_url":"https://api.github.com/users/darrachequesne/orgs","repos_url":"https://api.github.com/users/darrachequesne/repos","events_url":"https://api.github.com/users/darrachequesne/events{/privacy}","received_events_url":"https://api.github.com/users/darrachequesne/received_events","type":"User","site_admin":false},"body":"Please excuse me for this poorly-written PR: https://github.com/socketio/socket.io/pull/2239\r\n\r\nI added a test, but it will currently fail due to:\r\n- https://github.com/socketio/engine.io/pull/367\r\n- https://github.com/socketio/socket.io-client/pull/913\r\n\r\nPlease tell me if something is missing.","created_at":"2015-11-23T14:22:41Z","updated_at":"2015-11-23T17:19:35Z","closed_at":"2015-11-23T17:19:35Z","merged_at":"2015-11-23T17:19:35Z","merge_commit_sha":"dba86132aa9a2f28fe11eb3424b7fc672cea8d2c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/socketio/socket.io/pulls/2322/commits","review_comments_url":"https://api.github.com/repos/socketio/socket.io/pulls/2322/comments","review_comment_url":"https://api.github.com/repos/socketio/socket.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/socketio/socket.io/issues/2322/comments","statuses_url":"https://api.github.com/repos/socketio/socket.io/statuses/09f446eca09171448c75130caa9a61ef0217e5e4","head":{"label":"darrachequesne:issue-2199-clean","ref":"issue-2199-clean","sha":"09f446eca09171448c75130caa9a61ef0217e5e4","user":{"login":"darrachequesne","id":13031701,"avatar_url":"https://avatars.githubusercontent.com/u/13031701?v=3","gravatar_id":"","url":"https://api.github.com/users/darrachequesne","html_url":"https://github.com/darrachequesne","followers_url":"https://api.github.com/users/darrachequesne/followers","following_url":"https://api.github.com/users/darrachequesne/following{/other_user}","gists_url":"https://api.github.com/users/darrachequesne/gists{/gist_id}","starred_url":"https://api.github.com/users/darrachequesne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrachequesne/subscriptions","organizations_url":"https://api.github.com/users/darrachequesne/orgs","repos_url":"https://api.github.com/users/darrachequesne/repos","events_url":"https://api.github.com/users/darrachequesne/events{/privacy}","received_events_url":"https://api.github.com/users/darrachequesne/received_events","type":"User","site_admin":false},"repo":{"id":42330883,"name":"socket.io","full_name":"darrachequesne/socket.io","owner":{"login":"darrachequesne","id":13031701,"avatar_url":"https://avatars.githubusercontent.com/u/13031701?v=3","gravatar_id":"","url":"https://api.github.com/users/darrachequesne","html_url":"https://github.com/darrachequesne","followers_url":"https://api.github.com/users/darrachequesne/followers","following_url":"https://api.github.com/users/darrachequesne/following{/other_user}","gists_url":"https://api.github.com/users/darrachequesne/gists{/gist_id}","starred_url":"https://api.github.com/users/darrachequesne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrachequesne/subscriptions","organizations_url":"https://api.github.com/users/darrachequesne/orgs","repos_url":"https://api.github.com/users/darrachequesne/repos","events_url":"https://api.github.com/users/darrachequesne/events{/privacy}","received_events_url":"https://api.github.com/users/darrachequesne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darrachequesne/socket.io","description":"Realtime application framework (Node.JS server)","fork":true,"url":"https://api.github.com/repos/darrachequesne/socket.io","forks_url":"https://api.github.com/repos/darrachequesne/socket.io/forks","keys_url":"https://api.github.com/repos/darrachequesne/socket.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darrachequesne/socket.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darrachequesne/socket.io/teams","hooks_url":"https://api.github.com/repos/darrachequesne/socket.io/hooks","issue_events_url":"https://api.github.com/repos/darrachequesne/socket.io/issues/events{/number}","events_url":"https://api.github.com/repos/darrachequesne/socket.io/events","assignees_url":"https://api.github.com/repos/darrachequesne/socket.io/assignees{/user}","branches_url":"https://api.github.com/repos/darrachequesne/socket.io/branches{/branch}","tags_url":"https://api.github.com/repos/darrachequesne/socket.io/tags","blobs_url":"https://api.github.com/repos/darrachequesne/socket.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darrachequesne/socket.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darrachequesne/socket.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/darrachequesne/socket.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darrachequesne/socket.io/statuses/{sha}","languages_url":"https://api.github.com/repos/darrachequesne/socket.io/languages","stargazers_url":"https://api.github.com/repos/darrachequesne/socket.io/stargazers","contributors_url":"https://api.github.com/repos/darrachequesne/socket.io/contributors","subscribers_url":"https://api.github.com/repos/darrachequesne/socket.io/subscribers","subscription_url":"https://api.github.com/repos/darrachequesne/socket.io/subscription","commits_url":"https://api.github.com/repos/darrachequesne/socket.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/darrachequesne/socket.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/darrachequesne/socket.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/darrachequesne/socket.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/darrachequesne/socket.io/contents/{+path}","compare_url":"https://api.github.com/repos/darrachequesne/socket.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darrachequesne/socket.io/merges","archive_url":"https://api.github.com/repos/darrachequesne/socket.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darrachequesne/socket.io/downloads","issues_url":"https://api.github.com/repos/darrachequesne/socket.io/issues{/number}","pulls_url":"https://api.github.com/repos/darrachequesne/socket.io/pulls{/number}","milestones_url":"https://api.github.com/repos/darrachequesne/socket.io/milestones{/number}","notifications_url":"https://api.github.com/repos/darrachequesne/socket.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darrachequesne/socket.io/labels{/name}","releases_url":"https://api.github.com/repos/darrachequesne/socket.io/releases{/id}","created_at":"2015-09-11T20:34:29Z","updated_at":"2015-09-11T20:34:32Z","pushed_at":"2015-11-23T14:13:06Z","git_url":"git://github.com/darrachequesne/socket.io.git","ssh_url":"git@github.com:darrachequesne/socket.io.git","clone_url":"https://github.com/darrachequesne/socket.io.git","svn_url":"https://github.com/darrachequesne/socket.io","homepage":"http://socket.io","size":12089,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"socketio:master","ref":"master","sha":"aecf3bf71c5690ae8cf7e92bf1884ea39ed88657","user":{"login":"socketio","id":10566080,"avatar_url":"https://avatars.githubusercontent.com/u/10566080?v=3","gravatar_id":"","url":"https://api.github.com/users/socketio","html_url":"https://github.com/socketio","followers_url":"https://api.github.com/users/socketio/followers","following_url":"https://api.github.com/users/socketio/following{/other_user}","gists_url":"https://api.github.com/users/socketio/gists{/gist_id}","starred_url":"https://api.github.com/users/socketio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socketio/subscriptions","organizations_url":"https://api.github.com/users/socketio/orgs","repos_url":"https://api.github.com/users/socketio/repos","events_url":"https://api.github.com/users/socketio/events{/privacy}","received_events_url":"https://api.github.com/users/socketio/received_events","type":"Organization","site_admin":false},"repo":{"id":557980,"name":"socket.io","full_name":"socketio/socket.io","owner":{"login":"socketio","id":10566080,"avatar_url":"https://avatars.githubusercontent.com/u/10566080?v=3","gravatar_id":"","url":"https://api.github.com/users/socketio","html_url":"https://github.com/socketio","followers_url":"https://api.github.com/users/socketio/followers","following_url":"https://api.github.com/users/socketio/following{/other_user}","gists_url":"https://api.github.com/users/socketio/gists{/gist_id}","starred_url":"https://api.github.com/users/socketio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socketio/subscriptions","organizations_url":"https://api.github.com/users/socketio/orgs","repos_url":"https://api.github.com/users/socketio/repos","events_url":"https://api.github.com/users/socketio/events{/privacy}","received_events_url":"https://api.github.com/users/socketio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socketio/socket.io","description":"Realtime application framework (Node.JS server)","fork":false,"url":"https://api.github.com/repos/socketio/socket.io","forks_url":"https://api.github.com/repos/socketio/socket.io/forks","keys_url":"https://api.github.com/repos/socketio/socket.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socketio/socket.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socketio/socket.io/teams","hooks_url":"https://api.github.com/repos/socketio/socket.io/hooks","issue_events_url":"https://api.github.com/repos/socketio/socket.io/issues/events{/number}","events_url":"https://api.github.com/repos/socketio/socket.io/events","assignees_url":"https://api.github.com/repos/socketio/socket.io/assignees{/user}","branches_url":"https://api.github.com/repos/socketio/socket.io/branches{/branch}","tags_url":"https://api.github.com/repos/socketio/socket.io/tags","blobs_url":"https://api.github.com/repos/socketio/socket.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socketio/socket.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socketio/socket.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/socketio/socket.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socketio/socket.io/statuses/{sha}","languages_url":"https://api.github.com/repos/socketio/socket.io/languages","stargazers_url":"https://api.github.com/repos/socketio/socket.io/stargazers","contributors_url":"https://api.github.com/repos/socketio/socket.io/contributors","subscribers_url":"https://api.github.com/repos/socketio/socket.io/subscribers","subscription_url":"https://api.github.com/repos/socketio/socket.io/subscription","commits_url":"https://api.github.com/repos/socketio/socket.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/socketio/socket.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/socketio/socket.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/socketio/socket.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/socketio/socket.io/contents/{+path}","compare_url":"https://api.github.com/repos/socketio/socket.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socketio/socket.io/merges","archive_url":"https://api.github.com/repos/socketio/socket.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socketio/socket.io/downloads","issues_url":"https://api.github.com/repos/socketio/socket.io/issues{/number}","pulls_url":"https://api.github.com/repos/socketio/socket.io/pulls{/number}","milestones_url":"https://api.github.com/repos/socketio/socket.io/milestones{/number}","notifications_url":"https://api.github.com/repos/socketio/socket.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socketio/socket.io/labels{/name}","releases_url":"https://api.github.com/repos/socketio/socket.io/releases{/id}","created_at":"2010-03-11T18:24:48Z","updated_at":"2015-11-23T17:03:30Z","pushed_at":"2015-11-23T17:19:35Z","git_url":"git://github.com/socketio/socket.io.git","ssh_url":"git@github.com:socketio/socket.io.git","clone_url":"https://github.com/socketio/socket.io.git","svn_url":"https://github.com/socketio/socket.io","homepage":"http://socket.io","size":14188,"stargazers_count":21108,"watchers_count":21108,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4038,"mirror_url":null,"open_issues_count":308,"forks":4038,"open_issues":308,"watchers":21108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/socketio/socket.io/pulls/2322"},"html":{"href":"https://github.com/socketio/socket.io/pull/2322"},"issue":{"href":"https://api.github.com/repos/socketio/socket.io/issues/2322"},"comments":{"href":"https://api.github.com/repos/socketio/socket.io/issues/2322/comments"},"review_comments":{"href":"https://api.github.com/repos/socketio/socket.io/pulls/2322/comments"},"review_comment":{"href":"https://api.github.com/repos/socketio/socket.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/socketio/socket.io/pulls/2322/commits"},"statuses":{"href":"https://api.github.com/repos/socketio/socket.io/statuses/09f446eca09171448c75130caa9a61ef0217e5e4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rauchg","id":13041,"avatar_url":"https://avatars.githubusercontent.com/u/13041?v=3","gravatar_id":"","url":"https://api.github.com/users/rauchg","html_url":"https://github.com/rauchg","followers_url":"https://api.github.com/users/rauchg/followers","following_url":"https://api.github.com/users/rauchg/following{/other_user}","gists_url":"https://api.github.com/users/rauchg/gists{/gist_id}","starred_url":"https://api.github.com/users/rauchg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rauchg/subscriptions","organizations_url":"https://api.github.com/users/rauchg/orgs","repos_url":"https://api.github.com/users/rauchg/repos","events_url":"https://api.github.com/users/rauchg/events{/privacy}","received_events_url":"https://api.github.com/users/rauchg/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":32,"deletions":8,"changed_files":5}}