{"action":"closed","number":1124,"pull_request":{"url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/1124","id":41418728,"html_url":"https://github.com/DaftMonk/generator-angular-fullstack/pull/1124","diff_url":"https://github.com/DaftMonk/generator-angular-fullstack/pull/1124.diff","patch_url":"https://github.com/DaftMonk/generator-angular-fullstack/pull/1124.patch","issue_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues/1124","number":1124,"state":"closed","locked":false,"title":"app.coffee is missing preventDefault(); auth.service changePassword() chore","user":{"login":"dciccale","id":539546,"avatar_url":"https://avatars.githubusercontent.com/u/539546?v=3","gravatar_id":"","url":"https://api.github.com/users/dciccale","html_url":"https://github.com/dciccale","followers_url":"https://api.github.com/users/dciccale/followers","following_url":"https://api.github.com/users/dciccale/following{/other_user}","gists_url":"https://api.github.com/users/dciccale/gists{/gist_id}","starred_url":"https://api.github.com/users/dciccale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dciccale/subscriptions","organizations_url":"https://api.github.com/users/dciccale/orgs","repos_url":"https://api.github.com/users/dciccale/repos","events_url":"https://api.github.com/users/dciccale/events{/privacy}","received_events_url":"https://api.github.com/users/dciccale/received_events","type":"User","site_admin":false},"body":"in `app.js` there is an `event.preventDefault()` which wasn't present in the `coffee` version. I've added it.\r\n\r\nhttps://github.com/DaftMonk/generator-angular-fullstack/blob/canary/app/templates/client/app/app(js).js#L52\r\n\r\nthe `auth.service#changePassword` method, shouldn't return anything on success, since the API is ending the request without any response as you can see.\r\n\r\nhttps://github.com/DaftMonk/generator-angular-fullstack/blob/canary/app/templates/server/api/user(auth)/user.controller.js#L131","created_at":"2015-08-02T14:35:04Z","updated_at":"2015-08-07T20:26:16Z","closed_at":"2015-08-07T20:26:16Z","merged_at":"2015-08-07T20:26:16Z","merge_commit_sha":"3698665eaff3c088cc1e9352e013c5daf045e431","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/1124/commits","review_comments_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/1124/comments","review_comment_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues/1124/comments","statuses_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/statuses/d7fc0a80abda86c0cdca0de9e7748bb81e1b92ff","head":{"label":"dciccale:canary","ref":"canary","sha":"d7fc0a80abda86c0cdca0de9e7748bb81e1b92ff","user":{"login":"dciccale","id":539546,"avatar_url":"https://avatars.githubusercontent.com/u/539546?v=3","gravatar_id":"","url":"https://api.github.com/users/dciccale","html_url":"https://github.com/dciccale","followers_url":"https://api.github.com/users/dciccale/followers","following_url":"https://api.github.com/users/dciccale/following{/other_user}","gists_url":"https://api.github.com/users/dciccale/gists{/gist_id}","starred_url":"https://api.github.com/users/dciccale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dciccale/subscriptions","organizations_url":"https://api.github.com/users/dciccale/orgs","repos_url":"https://api.github.com/users/dciccale/repos","events_url":"https://api.github.com/users/dciccale/events{/privacy}","received_events_url":"https://api.github.com/users/dciccale/received_events","type":"User","site_admin":false},"repo":{"id":33504999,"name":"generator-angular-fullstack","full_name":"dciccale/generator-angular-fullstack","owner":{"login":"dciccale","id":539546,"avatar_url":"https://avatars.githubusercontent.com/u/539546?v=3","gravatar_id":"","url":"https://api.github.com/users/dciccale","html_url":"https://github.com/dciccale","followers_url":"https://api.github.com/users/dciccale/followers","following_url":"https://api.github.com/users/dciccale/following{/other_user}","gists_url":"https://api.github.com/users/dciccale/gists{/gist_id}","starred_url":"https://api.github.com/users/dciccale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dciccale/subscriptions","organizations_url":"https://api.github.com/users/dciccale/orgs","repos_url":"https://api.github.com/users/dciccale/repos","events_url":"https://api.github.com/users/dciccale/events{/privacy}","received_events_url":"https://api.github.com/users/dciccale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dciccale/generator-angular-fullstack","description":"Yeoman generator for AngularJS with an Express server","fork":true,"url":"https://api.github.com/repos/dciccale/generator-angular-fullstack","forks_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/forks","keys_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/teams","hooks_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/hooks","issue_events_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/issues/events{/number}","events_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/events","assignees_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/assignees{/user}","branches_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/branches{/branch}","tags_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/tags","blobs_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/statuses/{sha}","languages_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/languages","stargazers_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/stargazers","contributors_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/contributors","subscribers_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/subscribers","subscription_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/subscription","commits_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/contents/{+path}","compare_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/merges","archive_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/downloads","issues_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/issues{/number}","pulls_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/pulls{/number}","milestones_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/milestones{/number}","notifications_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/labels{/name}","releases_url":"https://api.github.com/repos/dciccale/generator-angular-fullstack/releases{/id}","created_at":"2015-04-06T20:47:00Z","updated_at":"2015-05-07T08:10:32Z","pushed_at":"2015-08-07T08:16:53Z","git_url":"git://github.com/dciccale/generator-angular-fullstack.git","ssh_url":"git@github.com:dciccale/generator-angular-fullstack.git","clone_url":"https://github.com/dciccale/generator-angular-fullstack.git","svn_url":"https://github.com/dciccale/generator-angular-fullstack","homepage":"http://yeoman.io","size":5569,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"DaftMonk:canary","ref":"canary","sha":"8342a31de0ef56a00ba0746e99881163252ae16c","user":{"login":"DaftMonk","id":2505273,"avatar_url":"https://avatars.githubusercontent.com/u/2505273?v=3","gravatar_id":"","url":"https://api.github.com/users/DaftMonk","html_url":"https://github.com/DaftMonk","followers_url":"https://api.github.com/users/DaftMonk/followers","following_url":"https://api.github.com/users/DaftMonk/following{/other_user}","gists_url":"https://api.github.com/users/DaftMonk/gists{/gist_id}","starred_url":"https://api.github.com/users/DaftMonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaftMonk/subscriptions","organizations_url":"https://api.github.com/users/DaftMonk/orgs","repos_url":"https://api.github.com/users/DaftMonk/repos","events_url":"https://api.github.com/users/DaftMonk/events{/privacy}","received_events_url":"https://api.github.com/users/DaftMonk/received_events","type":"User","site_admin":false},"repo":{"id":13911118,"name":"generator-angular-fullstack","full_name":"DaftMonk/generator-angular-fullstack","owner":{"login":"DaftMonk","id":2505273,"avatar_url":"https://avatars.githubusercontent.com/u/2505273?v=3","gravatar_id":"","url":"https://api.github.com/users/DaftMonk","html_url":"https://github.com/DaftMonk","followers_url":"https://api.github.com/users/DaftMonk/followers","following_url":"https://api.github.com/users/DaftMonk/following{/other_user}","gists_url":"https://api.github.com/users/DaftMonk/gists{/gist_id}","starred_url":"https://api.github.com/users/DaftMonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaftMonk/subscriptions","organizations_url":"https://api.github.com/users/DaftMonk/orgs","repos_url":"https://api.github.com/users/DaftMonk/repos","events_url":"https://api.github.com/users/DaftMonk/events{/privacy}","received_events_url":"https://api.github.com/users/DaftMonk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DaftMonk/generator-angular-fullstack","description":"Yeoman generator for AngularJS with an Express server","fork":true,"url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack","forks_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/forks","keys_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/teams","hooks_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/hooks","issue_events_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues/events{/number}","events_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/events","assignees_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/assignees{/user}","branches_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/branches{/branch}","tags_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/tags","blobs_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/statuses/{sha}","languages_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/languages","stargazers_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/stargazers","contributors_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/contributors","subscribers_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/subscribers","subscription_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/subscription","commits_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/contents/{+path}","compare_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/merges","archive_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/downloads","issues_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues{/number}","pulls_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls{/number}","milestones_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/milestones{/number}","notifications_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/labels{/name}","releases_url":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/releases{/id}","created_at":"2013-10-27T21:56:18Z","updated_at":"2015-08-07T14:51:38Z","pushed_at":"2015-08-07T20:26:17Z","git_url":"git://github.com/DaftMonk/generator-angular-fullstack.git","ssh_url":"git@github.com:DaftMonk/generator-angular-fullstack.git","clone_url":"https://github.com/DaftMonk/generator-angular-fullstack.git","svn_url":"https://github.com/DaftMonk/generator-angular-fullstack","homepage":"http://yeoman.io","size":13591,"stargazers_count":3636,"watchers_count":3636,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":691,"mirror_url":null,"open_issues_count":191,"forks":691,"open_issues":191,"watchers":3636,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/1124"},"html":{"href":"https://github.com/DaftMonk/generator-angular-fullstack/pull/1124"},"issue":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues/1124"},"comments":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/issues/1124/comments"},"review_comments":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/1124/comments"},"review_comment":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/pulls/1124/commits"},"statuses":{"href":"https://api.github.com/repos/DaftMonk/generator-angular-fullstack/statuses/d7fc0a80abda86c0cdca0de9e7748bb81e1b92ff"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kingcody","id":2544108,"avatar_url":"https://avatars.githubusercontent.com/u/2544108?v=3","gravatar_id":"","url":"https://api.github.com/users/kingcody","html_url":"https://github.com/kingcody","followers_url":"https://api.github.com/users/kingcody/followers","following_url":"https://api.github.com/users/kingcody/following{/other_user}","gists_url":"https://api.github.com/users/kingcody/gists{/gist_id}","starred_url":"https://api.github.com/users/kingcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingcody/subscriptions","organizations_url":"https://api.github.com/users/kingcody/orgs","repos_url":"https://api.github.com/users/kingcody/repos","events_url":"https://api.github.com/users/kingcody/events{/privacy}","received_events_url":"https://api.github.com/users/kingcody/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"commits":3,"additions":6,"deletions":5,"changed_files":4}}