{"action":"created","issue":{"url":"https://api.github.com/repos/mcavage/node-ssh-agent/issues/5","labels_url":"https://api.github.com/repos/mcavage/node-ssh-agent/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/mcavage/node-ssh-agent/issues/5/comments","events_url":"https://api.github.com/repos/mcavage/node-ssh-agent/issues/5/events","html_url":"https://github.com/mcavage/node-ssh-agent/pull/5","id":58285671,"number":5,"title":"fix possible undefined timeout","user":{"login":"bahamas10","id":1205722,"avatar_url":"https://avatars.githubusercontent.com/u/1205722?v=3","gravatar_id":"","url":"https://api.github.com/users/bahamas10","html_url":"https://github.com/bahamas10","followers_url":"https://api.github.com/users/bahamas10/followers","following_url":"https://api.github.com/users/bahamas10/following{/other_user}","gists_url":"https://api.github.com/users/bahamas10/gists{/gist_id}","starred_url":"https://api.github.com/users/bahamas10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bahamas10/subscriptions","organizations_url":"https://api.github.com/users/bahamas10/orgs","repos_url":"https://api.github.com/users/bahamas10/repos","events_url":"https://api.github.com/users/bahamas10/events{/privacy}","received_events_url":"https://api.github.com/users/bahamas10/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-02-19T23:13:05Z","updated_at":"2015-02-20T17:29:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mcavage/node-ssh-agent/pulls/5","html_url":"https://github.com/mcavage/node-ssh-agent/pull/5","diff_url":"https://github.com/mcavage/node-ssh-agent/pull/5.diff","patch_url":"https://github.com/mcavage/node-ssh-agent/pull/5.patch"},"body":"as is, if `options` is not supplied, `this.timeout` will be `undefined` which can cause an error to be throw when `socket.setTimeout` is called with `undefined`.\r\n\r\nfrom `node-manta`\r\n\r\n```\r\nTypeError: msecs must be a number\r\n    at Object.exports.enroll (timers.js:156:11)\r\n    at Socket.setTimeout (net.js:329:12)\r\n    at SSHAgentClient._request (/Users/dave/dev/node-manta/node_modules/ssh-agent/lib/ssh_agent_client.js:300:10)\r\n    at SSHAgentClient.requestIdentities (/Users/dave/dev/node-manta/node_modules/ssh-agent/lib/ssh_agent_client.js:186:15)\r\n    at sshAgentGetKey (/Users/dave/dev/node-manta/lib/auth.js:216:12)\r\n    at Object.checkAgentForKey [as func] (/Users/dave/dev/node-manta/lib/auth.js:450:17)\r\n    at /Users/dave/dev/node-manta/node_modules/vasync/lib/vasync.js:191:20\r\n    at process._tickCallback (node.js:355:11)\r\n    at Function.Module.runMain (module.js:503:11)\r\n    at startup (node.js:129:16)\r\n```"},"comment":{"url":"https://api.github.com/repos/mcavage/node-ssh-agent/issues/comments/75281835","html_url":"https://github.com/mcavage/node-ssh-agent/pull/5#issuecomment-75281835","issue_url":"https://api.github.com/repos/mcavage/node-ssh-agent/issues/5","id":75281835,"user":{"login":"trentm","id":46866,"avatar_url":"https://avatars.githubusercontent.com/u/46866?v=3","gravatar_id":"","url":"https://api.github.com/users/trentm","html_url":"https://github.com/trentm","followers_url":"https://api.github.com/users/trentm/followers","following_url":"https://api.github.com/users/trentm/following{/other_user}","gists_url":"https://api.github.com/users/trentm/gists{/gist_id}","starred_url":"https://api.github.com/users/trentm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trentm/subscriptions","organizations_url":"https://api.github.com/users/trentm/orgs","repos_url":"https://api.github.com/users/trentm/repos","events_url":"https://api.github.com/users/trentm/events{/privacy}","received_events_url":"https://api.github.com/users/trentm/received_events","type":"User","site_admin":false},"created_at":"2015-02-20T17:29:24Z","updated_at":"2015-02-20T17:29:24Z","body":"@pfmooney Do you have creds to commit here? You have creds for the npm registry for ssh-agent."}}