{"action":"created","comment":{"url":"https://api.github.com/repos/tl-its-umich-edu/canvas/pulls/comments/47800042","id":47800042,"diff_hunk":"@@ -523,14 +525,18 @@ def read_argv\n \n \t\t\tesbToken=refreshESBToken()\n \n-\t\t\t# update MPathway with Canvas urls\n-\t\t\tupdateError = update_MPathway_with_Canvas_url(esbToken, outputDirectory)\n+\t\t\tif (!esbToken.nil?)\n+\t\t\t\t# update MPathway with Canvas urls\n+\t\t\t\tupdateError = update_MPathway_with_Canvas_url(esbToken, outputDirectory)","path":"SIS_import/sis_set_url.rb","position":24,"original_position":24,"commit_id":"6e40fc3eebb9d952a7667eaa0bf7657b044babd0","original_commit_id":"6e40fc3eebb9d952a7667eaa0bf7657b044babd0","user":{"login":"dlhaines","id":74063,"avatar_url":"https://avatars.githubusercontent.com/u/74063?v=3","gravatar_id":"","url":"https://api.github.com/users/dlhaines","html_url":"https://github.com/dlhaines","followers_url":"https://api.github.com/users/dlhaines/followers","following_url":"https://api.github.com/users/dlhaines/following{/other_user}","gists_url":"https://api.github.com/users/dlhaines/gists{/gist_id}","starred_url":"https://api.github.com/users/dlhaines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlhaines/subscriptions","organizations_url":"https://api.github.com/users/dlhaines/orgs","repos_url":"https://api.github.com/users/dlhaines/repos","events_url":"https://api.github.com/users/dlhaines/events{/privacy}","received_events_url":"https://api.github.com/users/dlhaines/received_events","type":"User","site_admin":false},"body":"Maybe call this possibleUpdateError? Or updateErrorMsg?  Otherwise one might wonder why the method will always return an updateError.","created_at":"2015-12-16T16:42:35Z","updated_at":"2015-12-16T16:42:35Z","html_url":"https://github.com/tl-its-umich-edu/canvas/pull/78#discussion_r47800042","pull_request_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/tl-its-umich-edu/canvas/pulls/comments/47800042"},"html":{"href":"https://github.com/tl-its-umich-edu/canvas/pull/78#discussion_r47800042"},"pull_request":{"href":"https://api.github.com/repos/tl-its-umich-edu/canvas/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/tl-its-umich-edu/canvas/pulls/78","id":53857793,"html_url":"https://github.com/tl-its-umich-edu/canvas/pull/78","diff_url":"https://github.com/tl-its-umich-edu/canvas/pull/78.diff","patch_url":"https://github.com/tl-its-umich-edu/canvas/pull/78.patch","issue_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/issues/78","number":78,"state":"open","locked":false,"title":"TLUNIZIN-883 dealing with possible null value from Canvas API return","user":{"login":"zqian","id":359944,"avatar_url":"https://avatars.githubusercontent.com/u/359944?v=3","gravatar_id":"","url":"https://api.github.com/users/zqian","html_url":"https://github.com/zqian","followers_url":"https://api.github.com/users/zqian/followers","following_url":"https://api.github.com/users/zqian/following{/other_user}","gists_url":"https://api.github.com/users/zqian/gists{/gist_id}","starred_url":"https://api.github.com/users/zqian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zqian/subscriptions","organizations_url":"https://api.github.com/users/zqian/orgs","repos_url":"https://api.github.com/users/zqian/repos","events_url":"https://api.github.com/users/zqian/events{/privacy}","received_events_url":"https://api.github.com/users/zqian/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-16T15:44:19Z","updated_at":"2015-12-16T16:42:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf7769c9ca1e0d9761cd90f2115f6a9774b136c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/pulls/78/commits","review_comments_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/pulls/78/comments","review_comment_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/issues/78/comments","statuses_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/statuses/6e40fc3eebb9d952a7667eaa0bf7657b044babd0","head":{"label":"zqian:TLUNIZIN-883","ref":"TLUNIZIN-883","sha":"6e40fc3eebb9d952a7667eaa0bf7657b044babd0","user":{"login":"zqian","id":359944,"avatar_url":"https://avatars.githubusercontent.com/u/359944?v=3","gravatar_id":"","url":"https://api.github.com/users/zqian","html_url":"https://github.com/zqian","followers_url":"https://api.github.com/users/zqian/followers","following_url":"https://api.github.com/users/zqian/following{/other_user}","gists_url":"https://api.github.com/users/zqian/gists{/gist_id}","starred_url":"https://api.github.com/users/zqian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zqian/subscriptions","organizations_url":"https://api.github.com/users/zqian/orgs","repos_url":"https://api.github.com/users/zqian/repos","events_url":"https://api.github.com/users/zqian/events{/privacy}","received_events_url":"https://api.github.com/users/zqian/received_events","type":"User","site_admin":false},"repo":{"id":36455049,"name":"canvas","full_name":"zqian/canvas","owner":{"login":"zqian","id":359944,"avatar_url":"https://avatars.githubusercontent.com/u/359944?v=3","gravatar_id":"","url":"https://api.github.com/users/zqian","html_url":"https://github.com/zqian","followers_url":"https://api.github.com/users/zqian/followers","following_url":"https://api.github.com/users/zqian/following{/other_user}","gists_url":"https://api.github.com/users/zqian/gists{/gist_id}","starred_url":"https://api.github.com/users/zqian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zqian/subscriptions","organizations_url":"https://api.github.com/users/zqian/orgs","repos_url":"https://api.github.com/users/zqian/repos","events_url":"https://api.github.com/users/zqian/events{/privacy}","received_events_url":"https://api.github.com/users/zqian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zqian/canvas","description":"Integration scripts between ITS TL and Instructure Canvas","fork":true,"url":"https://api.github.com/repos/zqian/canvas","forks_url":"https://api.github.com/repos/zqian/canvas/forks","keys_url":"https://api.github.com/repos/zqian/canvas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zqian/canvas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zqian/canvas/teams","hooks_url":"https://api.github.com/repos/zqian/canvas/hooks","issue_events_url":"https://api.github.com/repos/zqian/canvas/issues/events{/number}","events_url":"https://api.github.com/repos/zqian/canvas/events","assignees_url":"https://api.github.com/repos/zqian/canvas/assignees{/user}","branches_url":"https://api.github.com/repos/zqian/canvas/branches{/branch}","tags_url":"https://api.github.com/repos/zqian/canvas/tags","blobs_url":"https://api.github.com/repos/zqian/canvas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zqian/canvas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zqian/canvas/git/refs{/sha}","trees_url":"https://api.github.com/repos/zqian/canvas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zqian/canvas/statuses/{sha}","languages_url":"https://api.github.com/repos/zqian/canvas/languages","stargazers_url":"https://api.github.com/repos/zqian/canvas/stargazers","contributors_url":"https://api.github.com/repos/zqian/canvas/contributors","subscribers_url":"https://api.github.com/repos/zqian/canvas/subscribers","subscription_url":"https://api.github.com/repos/zqian/canvas/subscription","commits_url":"https://api.github.com/repos/zqian/canvas/commits{/sha}","git_commits_url":"https://api.github.com/repos/zqian/canvas/git/commits{/sha}","comments_url":"https://api.github.com/repos/zqian/canvas/comments{/number}","issue_comment_url":"https://api.github.com/repos/zqian/canvas/issues/comments{/number}","contents_url":"https://api.github.com/repos/zqian/canvas/contents/{+path}","compare_url":"https://api.github.com/repos/zqian/canvas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zqian/canvas/merges","archive_url":"https://api.github.com/repos/zqian/canvas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zqian/canvas/downloads","issues_url":"https://api.github.com/repos/zqian/canvas/issues{/number}","pulls_url":"https://api.github.com/repos/zqian/canvas/pulls{/number}","milestones_url":"https://api.github.com/repos/zqian/canvas/milestones{/number}","notifications_url":"https://api.github.com/repos/zqian/canvas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zqian/canvas/labels{/name}","releases_url":"https://api.github.com/repos/zqian/canvas/releases{/id}","created_at":"2015-05-28T17:35:59Z","updated_at":"2015-05-28T17:36:00Z","pushed_at":"2015-12-16T15:43:52Z","git_url":"git://github.com/zqian/canvas.git","ssh_url":"git@github.com:zqian/canvas.git","clone_url":"https://github.com/zqian/canvas.git","svn_url":"https://github.com/zqian/canvas","homepage":"","size":901,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tl-its-umich-edu:master","ref":"master","sha":"51fa4b54c16161568722bcde55d4748f4d644feb","user":{"login":"tl-its-umich-edu","id":8292960,"avatar_url":"https://avatars.githubusercontent.com/u/8292960?v=3","gravatar_id":"","url":"https://api.github.com/users/tl-its-umich-edu","html_url":"https://github.com/tl-its-umich-edu","followers_url":"https://api.github.com/users/tl-its-umich-edu/followers","following_url":"https://api.github.com/users/tl-its-umich-edu/following{/other_user}","gists_url":"https://api.github.com/users/tl-its-umich-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/tl-its-umich-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tl-its-umich-edu/subscriptions","organizations_url":"https://api.github.com/users/tl-its-umich-edu/orgs","repos_url":"https://api.github.com/users/tl-its-umich-edu/repos","events_url":"https://api.github.com/users/tl-its-umich-edu/events{/privacy}","received_events_url":"https://api.github.com/users/tl-its-umich-edu/received_events","type":"Organization","site_admin":false},"repo":{"id":22355901,"name":"canvas","full_name":"tl-its-umich-edu/canvas","owner":{"login":"tl-its-umich-edu","id":8292960,"avatar_url":"https://avatars.githubusercontent.com/u/8292960?v=3","gravatar_id":"","url":"https://api.github.com/users/tl-its-umich-edu","html_url":"https://github.com/tl-its-umich-edu","followers_url":"https://api.github.com/users/tl-its-umich-edu/followers","following_url":"https://api.github.com/users/tl-its-umich-edu/following{/other_user}","gists_url":"https://api.github.com/users/tl-its-umich-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/tl-its-umich-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tl-its-umich-edu/subscriptions","organizations_url":"https://api.github.com/users/tl-its-umich-edu/orgs","repos_url":"https://api.github.com/users/tl-its-umich-edu/repos","events_url":"https://api.github.com/users/tl-its-umich-edu/events{/privacy}","received_events_url":"https://api.github.com/users/tl-its-umich-edu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tl-its-umich-edu/canvas","description":"Integration scripts between ITS TL and Instructure Canvas","fork":false,"url":"https://api.github.com/repos/tl-its-umich-edu/canvas","forks_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/forks","keys_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/teams","hooks_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/hooks","issue_events_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/issues/events{/number}","events_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/events","assignees_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/assignees{/user}","branches_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/branches{/branch}","tags_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/tags","blobs_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/git/refs{/sha}","trees_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/statuses/{sha}","languages_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/languages","stargazers_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/stargazers","contributors_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/contributors","subscribers_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/subscribers","subscription_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/subscription","commits_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/commits{/sha}","git_commits_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/git/commits{/sha}","comments_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/comments{/number}","issue_comment_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/issues/comments{/number}","contents_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/contents/{+path}","compare_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/merges","archive_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/downloads","issues_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/issues{/number}","pulls_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/pulls{/number}","milestones_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/milestones{/number}","notifications_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/labels{/name}","releases_url":"https://api.github.com/repos/tl-its-umich-edu/canvas/releases{/id}","created_at":"2014-07-28T19:59:20Z","updated_at":"2015-05-08T19:12:03Z","pushed_at":"2015-12-16T15:44:19Z","git_url":"git://github.com/tl-its-umich-edu/canvas.git","ssh_url":"git@github.com:tl-its-umich-edu/canvas.git","clone_url":"https://github.com/tl-its-umich-edu/canvas.git","svn_url":"https://github.com/tl-its-umich-edu/canvas","homepage":"","size":1927,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tl-its-umich-edu/canvas/pulls/78"},"html":{"href":"https://github.com/tl-its-umich-edu/canvas/pull/78"},"issue":{"href":"https://api.github.com/repos/tl-its-umich-edu/canvas/issues/78"},"comments":{"href":"https://api.github.com/repos/tl-its-umich-edu/canvas/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/tl-its-umich-edu/canvas/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/tl-its-umich-edu/canvas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tl-its-umich-edu/canvas/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/tl-its-umich-edu/canvas/statuses/6e40fc3eebb9d952a7667eaa0bf7657b044babd0"}}}}