{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/38605357","id":38605357,"diff_hunk":"@@ -500,7 +500,7 @@ func (c *AppConfig) buildPipelines(components app.ComponentReferences, environme\n \t\t\t\tif ref.Input().Uses.IsDockerBuild() {\n \t\t\t\t\texposed, ok := ref.Input().Uses.Info().Dockerfile.GetDirective(\"EXPOSE\")\n \t\t\t\t\tif ok {\n-\t\t\t\t\t\tif input.Info == nil {\n+\t\t\t\t\t\tif input.Info.Config == nil {","path":"pkg/generate/app/cmd/newapp.go","position":5,"original_position":5,"commit_id":"827b44641dc2eab0a08f330158ea9b39cf04954c","original_commit_id":"827b44641dc2eab0a08f330158ea9b39cf04954c","user":{"login":"nak3","id":2138339,"avatar_url":"https://avatars.githubusercontent.com/u/2138339?v=3","gravatar_id":"","url":"https://api.github.com/users/nak3","html_url":"https://github.com/nak3","followers_url":"https://api.github.com/users/nak3/followers","following_url":"https://api.github.com/users/nak3/following{/other_user}","gists_url":"https://api.github.com/users/nak3/gists{/gist_id}","starred_url":"https://api.github.com/users/nak3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nak3/subscriptions","organizations_url":"https://api.github.com/users/nak3/orgs","repos_url":"https://api.github.com/users/nak3/repos","events_url":"https://api.github.com/users/nak3/events{/privacy}","received_events_url":"https://api.github.com/users/nak3/received_events","type":"User","site_admin":false},"body":"Yes, I think I should do `input.Info` nil check.","created_at":"2015-09-03T01:29:37Z","updated_at":"2015-09-03T01:29:37Z","html_url":"https://github.com/openshift/origin/pull/4471#discussion_r38605357","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/4471","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/38605357"},"html":{"href":"https://github.com/openshift/origin/pull/4471#discussion_r38605357"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/4471"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/4471","id":44004905,"html_url":"https://github.com/openshift/origin/pull/4471","diff_url":"https://github.com/openshift/origin/pull/4471.diff","patch_url":"https://github.com/openshift/origin/pull/4471.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/4471","number":4471,"state":"open","locked":false,"title":"Fix nil check in buildPipelines for input.Info","user":{"login":"nak3","id":2138339,"avatar_url":"https://avatars.githubusercontent.com/u/2138339?v=3","gravatar_id":"","url":"https://api.github.com/users/nak3","html_url":"https://github.com/nak3","followers_url":"https://api.github.com/users/nak3/followers","following_url":"https://api.github.com/users/nak3/following{/other_user}","gists_url":"https://api.github.com/users/nak3/gists{/gist_id}","starred_url":"https://api.github.com/users/nak3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nak3/subscriptions","organizations_url":"https://api.github.com/users/nak3/orgs","repos_url":"https://api.github.com/users/nak3/repos","events_url":"https://api.github.com/users/nak3/events{/privacy}","received_events_url":"https://api.github.com/users/nak3/received_events","type":"User","site_admin":false},"body":"Fix for https://github.com/openshift/origin/issues/4186","created_at":"2015-09-02T15:21:08Z","updated_at":"2015-09-03T01:29:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4fca89e462ec96c2e65129796dcc29d900766f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/4471/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/4471/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/4471/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/827b44641dc2eab0a08f330158ea9b39cf04954c","head":{"label":"nak3:fix-4186","ref":"fix-4186","sha":"827b44641dc2eab0a08f330158ea9b39cf04954c","user":{"login":"nak3","id":2138339,"avatar_url":"https://avatars.githubusercontent.com/u/2138339?v=3","gravatar_id":"","url":"https://api.github.com/users/nak3","html_url":"https://github.com/nak3","followers_url":"https://api.github.com/users/nak3/followers","following_url":"https://api.github.com/users/nak3/following{/other_user}","gists_url":"https://api.github.com/users/nak3/gists{/gist_id}","starred_url":"https://api.github.com/users/nak3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nak3/subscriptions","organizations_url":"https://api.github.com/users/nak3/orgs","repos_url":"https://api.github.com/users/nak3/repos","events_url":"https://api.github.com/users/nak3/events{/privacy}","received_events_url":"https://api.github.com/users/nak3/received_events","type":"User","site_admin":false},"repo":{"id":38147886,"name":"origin","full_name":"nak3/origin","owner":{"login":"nak3","id":2138339,"avatar_url":"https://avatars.githubusercontent.com/u/2138339?v=3","gravatar_id":"","url":"https://api.github.com/users/nak3","html_url":"https://github.com/nak3","followers_url":"https://api.github.com/users/nak3/followers","following_url":"https://api.github.com/users/nak3/following{/other_user}","gists_url":"https://api.github.com/users/nak3/gists{/gist_id}","starred_url":"https://api.github.com/users/nak3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nak3/subscriptions","organizations_url":"https://api.github.com/users/nak3/orgs","repos_url":"https://api.github.com/users/nak3/repos","events_url":"https://api.github.com/users/nak3/events{/privacy}","received_events_url":"https://api.github.com/users/nak3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nak3/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/nak3/origin","forks_url":"https://api.github.com/repos/nak3/origin/forks","keys_url":"https://api.github.com/repos/nak3/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nak3/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nak3/origin/teams","hooks_url":"https://api.github.com/repos/nak3/origin/hooks","issue_events_url":"https://api.github.com/repos/nak3/origin/issues/events{/number}","events_url":"https://api.github.com/repos/nak3/origin/events","assignees_url":"https://api.github.com/repos/nak3/origin/assignees{/user}","branches_url":"https://api.github.com/repos/nak3/origin/branches{/branch}","tags_url":"https://api.github.com/repos/nak3/origin/tags","blobs_url":"https://api.github.com/repos/nak3/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nak3/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nak3/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/nak3/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nak3/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/nak3/origin/languages","stargazers_url":"https://api.github.com/repos/nak3/origin/stargazers","contributors_url":"https://api.github.com/repos/nak3/origin/contributors","subscribers_url":"https://api.github.com/repos/nak3/origin/subscribers","subscription_url":"https://api.github.com/repos/nak3/origin/subscription","commits_url":"https://api.github.com/repos/nak3/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/nak3/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/nak3/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/nak3/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/nak3/origin/contents/{+path}","compare_url":"https://api.github.com/repos/nak3/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nak3/origin/merges","archive_url":"https://api.github.com/repos/nak3/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nak3/origin/downloads","issues_url":"https://api.github.com/repos/nak3/origin/issues{/number}","pulls_url":"https://api.github.com/repos/nak3/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/nak3/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/nak3/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nak3/origin/labels{/name}","releases_url":"https://api.github.com/repos/nak3/origin/releases{/id}","created_at":"2015-06-27T05:14:04Z","updated_at":"2015-06-27T05:14:08Z","pushed_at":"2015-09-02T15:20:48Z","git_url":"git://github.com/nak3/origin.git","ssh_url":"git@github.com:nak3/origin.git","clone_url":"https://github.com/nak3/origin.git","svn_url":"https://github.com/nak3/origin","homepage":"http://www.openshift.org","size":133610,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"5b4c8ed9dadbd1adc4ae9758e38690a43d6214c0","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-09-03T00:34:20Z","pushed_at":"2015-09-03T01:24:48Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":225375,"stargazers_count":660,"watchers_count":660,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":378,"mirror_url":null,"open_issues_count":560,"forks":378,"open_issues":560,"watchers":660,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/4471"},"html":{"href":"https://github.com/openshift/origin/pull/4471"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/4471"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/4471/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/4471/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/4471/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/827b44641dc2eab0a08f330158ea9b39cf04954c"}}}}