{"action":"created","issue":{"url":"https://api.github.com/repos/laurentpetit/ccw/issues/756","labels_url":"https://api.github.com/repos/laurentpetit/ccw/issues/756/labels{/name}","comments_url":"https://api.github.com/repos/laurentpetit/ccw/issues/756/comments","events_url":"https://api.github.com/repos/laurentpetit/ccw/issues/756/events","html_url":"https://github.com/laurentpetit/ccw/pull/756","id":72252306,"number":756,"title":"Hovers step1 reviewed + atom fix","user":{"login":"arichiardi","id":1724788,"avatar_url":"https://avatars.githubusercontent.com/u/1724788?v=3","gravatar_id":"","url":"https://api.github.com/users/arichiardi","html_url":"https://github.com/arichiardi","followers_url":"https://api.github.com/users/arichiardi/followers","following_url":"https://api.github.com/users/arichiardi/following{/other_user}","gists_url":"https://api.github.com/users/arichiardi/gists{/gist_id}","starred_url":"https://api.github.com/users/arichiardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arichiardi/subscriptions","organizations_url":"https://api.github.com/users/arichiardi/orgs","repos_url":"https://api.github.com/users/arichiardi/repos","events_url":"https://api.github.com/users/arichiardi/events{/privacy}","received_events_url":"https://api.github.com/users/arichiardi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-04-30T18:59:54Z","updated_at":"2015-05-07T15:38:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/laurentpetit/ccw/pulls/756","html_url":"https://github.com/laurentpetit/ccw/pull/756","diff_url":"https://github.com/laurentpetit/ccw/pull/756.diff","patch_url":"https://github.com/laurentpetit/ccw/pull/756.patch"},"body":"Hello Laurent,\r\nthis is the part already reviewed, rebased.\r\n\r\nToday I have (hopefully) implemented the state/atom part correctly and, if you have time, I'd like you to have a look at it: I basically have encapsulated my state in a single atom called ```State```.\r\nFrom there I fixed some other parts that I had already done and were part of my ```color-refactoring``` branch.\r\n\r\nI am still not happy with some part of it. I would like to still push some commit in the next couple of days. Not perfect yet.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/laurentpetit/ccw/issues/comments/99914161","html_url":"https://github.com/laurentpetit/ccw/pull/756#issuecomment-99914161","issue_url":"https://api.github.com/repos/laurentpetit/ccw/issues/756","id":99914161,"user":{"login":"laurentpetit","id":98286,"avatar_url":"https://avatars.githubusercontent.com/u/98286?v=3","gravatar_id":"","url":"https://api.github.com/users/laurentpetit","html_url":"https://github.com/laurentpetit","followers_url":"https://api.github.com/users/laurentpetit/followers","following_url":"https://api.github.com/users/laurentpetit/following{/other_user}","gists_url":"https://api.github.com/users/laurentpetit/gists{/gist_id}","starred_url":"https://api.github.com/users/laurentpetit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurentpetit/subscriptions","organizations_url":"https://api.github.com/users/laurentpetit/orgs","repos_url":"https://api.github.com/users/laurentpetit/repos","events_url":"https://api.github.com/users/laurentpetit/events{/privacy}","received_events_url":"https://api.github.com/users/laurentpetit/received_events","type":"User","site_admin":false},"created_at":"2015-05-07T15:38:52Z","updated_at":"2015-05-07T15:38:52Z","body":"I know what is a little bit surprising : when arriving to the Hovers\nPreference Page, if there is at least one hover (and there will be 100% of\nthe cases) in the list, then the first one should be selected, so that the\n\"detail\" view is not empty and the user (me) can understand the link\nbetween the 2.\nElse, The user is left with the feeling that there's a bug in the UI :\nthere is a blank input text floating in the middle of the page.\n\nAnother remark: it seems like there's a regression in the \"namespace\nbrowser\" : if you hover over a public definition of a var, e.g.\n`clojure.core/map`, then one can see `nbsp` and `<pre>` and `</pre>`\nprinted on the first lines near arglist definition\n\n2015-05-07 16:19 GMT+02:00 Andrea Richiardi <notifications@github.com>:\n\n> Boom, when you sent \"Yes\" over the network I pushed my change :)\n> It looks way better actually. I'd leave it like that unless you have other\n> improvements.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/laurentpetit/ccw/pull/756#issuecomment-99883320>.\n>\n\n\n\n-- \nLaurent Petit\n"}}