{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17601","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17601/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17601/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17601/events","html_url":"https://github.com/kubernetes/kubernetes/pull/17601","id":118150627,"number":17601,"title":"MINION->NODE shell/docs variables replacement for #1111","user":{"login":"eosrei","id":195061,"avatar_url":"https://avatars.githubusercontent.com/u/195061?v=3","gravatar_id":"","url":"https://api.github.com/users/eosrei","html_url":"https://github.com/eosrei","followers_url":"https://api.github.com/users/eosrei/followers","following_url":"https://api.github.com/users/eosrei/following{/other_user}","gists_url":"https://api.github.com/users/eosrei/gists{/gist_id}","starred_url":"https://api.github.com/users/eosrei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eosrei/subscriptions","organizations_url":"https://api.github.com/users/eosrei/orgs","repos_url":"https://api.github.com/users/eosrei/repos","events_url":"https://api.github.com/users/eosrei/events{/privacy}","received_events_url":"https://api.github.com/users/eosrei/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-ok-to-merge","name":"needs-ok-to-merge","color":"ededed"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500"}],"state":"open","locked":false,"assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"milestone":null,"comments":23,"created_at":"2015-11-20T23:42:40Z","updated_at":"2015-11-25T04:34:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17601","html_url":"https://github.com/kubernetes/kubernetes/pull/17601","diff_url":"https://github.com/kubernetes/kubernetes/pull/17601.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/17601.patch"},"body":"Mass rename of all instances of `MINION` to `NODE` for #1111. This covers shell variables and documentation. It does not cover comments or other details, because the change is large enough already.\r\n\r\nThere are 48 variables containing the characters `MINION`.\r\n```\r\n$ grep -oh \"[A-Z_]*MINION[A-Z_]*\" * -R | sort | uniq | wc\r\n     48      48     851\r\n```\r\nI don't know if it's reasonable to break this commit into multiple PRs, since all 143 instances of `NUM_MINIONS` and 62 instances `MINION_NAMES` should (must?) all change at the same time. I can break into multiple commits if needed.\r\n\r\nLet me know if you have any thoughts about a different way to approach.\r\n\r\n*This was pulled out of #17024 to simplify that PR.*"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/159489333","html_url":"https://github.com/kubernetes/kubernetes/pull/17601#issuecomment-159489333","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17601","id":159489333,"user":{"login":"eosrei","id":195061,"avatar_url":"https://avatars.githubusercontent.com/u/195061?v=3","gravatar_id":"","url":"https://api.github.com/users/eosrei","html_url":"https://github.com/eosrei","followers_url":"https://api.github.com/users/eosrei/followers","following_url":"https://api.github.com/users/eosrei/following{/other_user}","gists_url":"https://api.github.com/users/eosrei/gists{/gist_id}","starred_url":"https://api.github.com/users/eosrei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eosrei/subscriptions","organizations_url":"https://api.github.com/users/eosrei/orgs","repos_url":"https://api.github.com/users/eosrei/repos","events_url":"https://api.github.com/users/eosrei/events{/privacy}","received_events_url":"https://api.github.com/users/eosrei/received_events","type":"User","site_admin":false},"created_at":"2015-11-25T04:34:15Z","updated_at":"2015-11-25T04:34:15Z","body":"PR needed rebase. #17428 changed the following files:\r\n\r\n* cluster/gce/config-default.sh\r\n* cluster/gce/config-test.sh\r\n\r\nChanged commit diff: https://github.com/kubernetes/kubernetes/commit/3a5d2509addf393eda48ef45618903e051cd9b75#diff-57380bb03c3598646d5a3cb66518fa0b\r\n\r\nNeeds `lgtm` and `ok-to-merge` please."}}