{"action":"created","comment":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments/28125667","id":28125667,"diff_hunk":"@@ -19,7 +19,7 @@ SOURCES += \\\n     $$PWD/qtorrentfilter.cpp \\\n     $$PWD/abstractwebapplication.cpp\n \n-# QJson JSON parser/serializer for using with Qt4\n-lessThan(QT_MAJOR_VERSION, 5): include(qjson/qjson.pri)\n+# QJson JSON parser/serializer for using with Qt < 5.5\n+lessThan(QT_MAJOR_VERSION, 5) | lessThan(QT_MINOR_VERSION, 5): include(qjson/qjson.pri)","path":"src/webui/webui.pri","position":null,"original_position":7,"commit_id":"459c8e311001f08fff5f0841506d39b498f4e583","original_commit_id":"7dcd4ea9e5ec521efd49ab76d2691859ae4f321d","user":{"login":"pmzqla","id":6256149,"avatar_url":"https://avatars.githubusercontent.com/u/6256149?v=3","gravatar_id":"","url":"https://api.github.com/users/pmzqla","html_url":"https://github.com/pmzqla","followers_url":"https://api.github.com/users/pmzqla/followers","following_url":"https://api.github.com/users/pmzqla/following{/other_user}","gists_url":"https://api.github.com/users/pmzqla/gists{/gist_id}","starred_url":"https://api.github.com/users/pmzqla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmzqla/subscriptions","organizations_url":"https://api.github.com/users/pmzqla/orgs","repos_url":"https://api.github.com/users/pmzqla/repos","events_url":"https://api.github.com/users/pmzqla/events{/privacy}","received_events_url":"https://api.github.com/users/pmzqla/received_events","type":"User","site_admin":false},"body":"With an AND it fails in some cases, with an OR it fails wit Qt > 6. I modified the code to work in any case, even if Qt6 does not exist yet.","created_at":"2015-04-10T07:03:25Z","updated_at":"2015-04-10T07:03:25Z","html_url":"https://github.com/qbittorrent/qBittorrent/pull/2850#discussion_r28125667","pull_request_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/2850","_links":{"self":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments/28125667"},"html":{"href":"https://github.com/qbittorrent/qBittorrent/pull/2850#discussion_r28125667"},"pull_request":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/2850"}}},"pull_request":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/2850","id":32952541,"html_url":"https://github.com/qbittorrent/qBittorrent/pull/2850","diff_url":"https://github.com/qbittorrent/qBittorrent/pull/2850.diff","patch_url":"https://github.com/qbittorrent/qBittorrent/pull/2850.patch","issue_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/2850","number":2850,"state":"open","locked":false,"title":"WebUI: Use QJson JSON parser/serializer if Qt < 5.5","user":{"login":"pmzqla","id":6256149,"avatar_url":"https://avatars.githubusercontent.com/u/6256149?v=3","gravatar_id":"","url":"https://api.github.com/users/pmzqla","html_url":"https://github.com/pmzqla","followers_url":"https://api.github.com/users/pmzqla/followers","following_url":"https://api.github.com/users/pmzqla/following{/other_user}","gists_url":"https://api.github.com/users/pmzqla/gists{/gist_id}","starred_url":"https://api.github.com/users/pmzqla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmzqla/subscriptions","organizations_url":"https://api.github.com/users/pmzqla/orgs","repos_url":"https://api.github.com/users/pmzqla/repos","events_url":"https://api.github.com/users/pmzqla/events{/privacy}","received_events_url":"https://api.github.com/users/pmzqla/received_events","type":"User","site_admin":false},"body":"QJsonDocument::fromVariant() supports QVariantHash since Qt 5.5, so\r\nuse the old QJson JSON parser/serializer since QVariantHash is used\r\nto generate the list of torrents.\r\n\r\nCloses #2849.","created_at":"2015-04-09T12:53:51Z","updated_at":"2015-04-10T07:03:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5a50355c94d8f21ea774cab46f3b52b7855d5b9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/2850/commits","review_comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/2850/comments","review_comment_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/2850/comments","statuses_url":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/459c8e311001f08fff5f0841506d39b498f4e583","head":{"label":"pmzqla:qjson","ref":"qjson","sha":"459c8e311001f08fff5f0841506d39b498f4e583","user":{"login":"pmzqla","id":6256149,"avatar_url":"https://avatars.githubusercontent.com/u/6256149?v=3","gravatar_id":"","url":"https://api.github.com/users/pmzqla","html_url":"https://github.com/pmzqla","followers_url":"https://api.github.com/users/pmzqla/followers","following_url":"https://api.github.com/users/pmzqla/following{/other_user}","gists_url":"https://api.github.com/users/pmzqla/gists{/gist_id}","starred_url":"https://api.github.com/users/pmzqla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmzqla/subscriptions","organizations_url":"https://api.github.com/users/pmzqla/orgs","repos_url":"https://api.github.com/users/pmzqla/repos","events_url":"https://api.github.com/users/pmzqla/events{/privacy}","received_events_url":"https://api.github.com/users/pmzqla/received_events","type":"User","site_admin":false},"repo":{"id":25167360,"name":"qBittorrent","full_name":"pmzqla/qBittorrent","owner":{"login":"pmzqla","id":6256149,"avatar_url":"https://avatars.githubusercontent.com/u/6256149?v=3","gravatar_id":"","url":"https://api.github.com/users/pmzqla","html_url":"https://github.com/pmzqla","followers_url":"https://api.github.com/users/pmzqla/followers","following_url":"https://api.github.com/users/pmzqla/following{/other_user}","gists_url":"https://api.github.com/users/pmzqla/gists{/gist_id}","starred_url":"https://api.github.com/users/pmzqla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmzqla/subscriptions","organizations_url":"https://api.github.com/users/pmzqla/orgs","repos_url":"https://api.github.com/users/pmzqla/repos","events_url":"https://api.github.com/users/pmzqla/events{/privacy}","received_events_url":"https://api.github.com/users/pmzqla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmzqla/qBittorrent","description":"qBittorrent BitTorrent client","fork":true,"url":"https://api.github.com/repos/pmzqla/qBittorrent","forks_url":"https://api.github.com/repos/pmzqla/qBittorrent/forks","keys_url":"https://api.github.com/repos/pmzqla/qBittorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmzqla/qBittorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmzqla/qBittorrent/teams","hooks_url":"https://api.github.com/repos/pmzqla/qBittorrent/hooks","issue_events_url":"https://api.github.com/repos/pmzqla/qBittorrent/issues/events{/number}","events_url":"https://api.github.com/repos/pmzqla/qBittorrent/events","assignees_url":"https://api.github.com/repos/pmzqla/qBittorrent/assignees{/user}","branches_url":"https://api.github.com/repos/pmzqla/qBittorrent/branches{/branch}","tags_url":"https://api.github.com/repos/pmzqla/qBittorrent/tags","blobs_url":"https://api.github.com/repos/pmzqla/qBittorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmzqla/qBittorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmzqla/qBittorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmzqla/qBittorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmzqla/qBittorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/pmzqla/qBittorrent/languages","stargazers_url":"https://api.github.com/repos/pmzqla/qBittorrent/stargazers","contributors_url":"https://api.github.com/repos/pmzqla/qBittorrent/contributors","subscribers_url":"https://api.github.com/repos/pmzqla/qBittorrent/subscribers","subscription_url":"https://api.github.com/repos/pmzqla/qBittorrent/subscription","commits_url":"https://api.github.com/repos/pmzqla/qBittorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmzqla/qBittorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmzqla/qBittorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmzqla/qBittorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmzqla/qBittorrent/contents/{+path}","compare_url":"https://api.github.com/repos/pmzqla/qBittorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmzqla/qBittorrent/merges","archive_url":"https://api.github.com/repos/pmzqla/qBittorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmzqla/qBittorrent/downloads","issues_url":"https://api.github.com/repos/pmzqla/qBittorrent/issues{/number}","pulls_url":"https://api.github.com/repos/pmzqla/qBittorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/pmzqla/qBittorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/pmzqla/qBittorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmzqla/qBittorrent/labels{/name}","releases_url":"https://api.github.com/repos/pmzqla/qBittorrent/releases{/id}","created_at":"2014-10-13T16:37:15Z","updated_at":"2014-10-13T16:47:58Z","pushed_at":"2015-04-10T06:59:57Z","git_url":"git://github.com/pmzqla/qBittorrent.git","ssh_url":"git@github.com:pmzqla/qBittorrent.git","clone_url":"https://github.com/pmzqla/qBittorrent.git","svn_url":"https://github.com/pmzqla/qBittorrent","homepage":"http://www.qbittorrent.org","size":104375,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qbittorrent:master","ref":"master","sha":"7af4928b18f77d35bd7bc5da62d284ad2d64eaba","user":{"login":"qbittorrent","id":2131270,"avatar_url":"https://avatars.githubusercontent.com/u/2131270?v=3","gravatar_id":"","url":"https://api.github.com/users/qbittorrent","html_url":"https://github.com/qbittorrent","followers_url":"https://api.github.com/users/qbittorrent/followers","following_url":"https://api.github.com/users/qbittorrent/following{/other_user}","gists_url":"https://api.github.com/users/qbittorrent/gists{/gist_id}","starred_url":"https://api.github.com/users/qbittorrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qbittorrent/subscriptions","organizations_url":"https://api.github.com/users/qbittorrent/orgs","repos_url":"https://api.github.com/users/qbittorrent/repos","events_url":"https://api.github.com/users/qbittorrent/events{/privacy}","received_events_url":"https://api.github.com/users/qbittorrent/received_events","type":"Organization","site_admin":false},"repo":{"id":3351871,"name":"qBittorrent","full_name":"qbittorrent/qBittorrent","owner":{"login":"qbittorrent","id":2131270,"avatar_url":"https://avatars.githubusercontent.com/u/2131270?v=3","gravatar_id":"","url":"https://api.github.com/users/qbittorrent","html_url":"https://github.com/qbittorrent","followers_url":"https://api.github.com/users/qbittorrent/followers","following_url":"https://api.github.com/users/qbittorrent/following{/other_user}","gists_url":"https://api.github.com/users/qbittorrent/gists{/gist_id}","starred_url":"https://api.github.com/users/qbittorrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qbittorrent/subscriptions","organizations_url":"https://api.github.com/users/qbittorrent/orgs","repos_url":"https://api.github.com/users/qbittorrent/repos","events_url":"https://api.github.com/users/qbittorrent/events{/privacy}","received_events_url":"https://api.github.com/users/qbittorrent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qbittorrent/qBittorrent","description":"qBittorrent BitTorrent client","fork":false,"url":"https://api.github.com/repos/qbittorrent/qBittorrent","forks_url":"https://api.github.com/repos/qbittorrent/qBittorrent/forks","keys_url":"https://api.github.com/repos/qbittorrent/qBittorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qbittorrent/qBittorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qbittorrent/qBittorrent/teams","hooks_url":"https://api.github.com/repos/qbittorrent/qBittorrent/hooks","issue_events_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/events{/number}","events_url":"https://api.github.com/repos/qbittorrent/qBittorrent/events","assignees_url":"https://api.github.com/repos/qbittorrent/qBittorrent/assignees{/user}","branches_url":"https://api.github.com/repos/qbittorrent/qBittorrent/branches{/branch}","tags_url":"https://api.github.com/repos/qbittorrent/qBittorrent/tags","blobs_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/qbittorrent/qBittorrent/languages","stargazers_url":"https://api.github.com/repos/qbittorrent/qBittorrent/stargazers","contributors_url":"https://api.github.com/repos/qbittorrent/qBittorrent/contributors","subscribers_url":"https://api.github.com/repos/qbittorrent/qBittorrent/subscribers","subscription_url":"https://api.github.com/repos/qbittorrent/qBittorrent/subscription","commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/qbittorrent/qBittorrent/contents/{+path}","compare_url":"https://api.github.com/repos/qbittorrent/qBittorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qbittorrent/qBittorrent/merges","archive_url":"https://api.github.com/repos/qbittorrent/qBittorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qbittorrent/qBittorrent/downloads","issues_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues{/number}","pulls_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/qbittorrent/qBittorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/qbittorrent/qBittorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qbittorrent/qBittorrent/labels{/name}","releases_url":"https://api.github.com/repos/qbittorrent/qBittorrent/releases{/id}","created_at":"2012-02-04T09:37:46Z","updated_at":"2015-04-09T03:23:55Z","pushed_at":"2015-04-10T06:59:58Z","git_url":"git://github.com/qbittorrent/qBittorrent.git","ssh_url":"git@github.com:qbittorrent/qBittorrent.git","clone_url":"https://github.com/qbittorrent/qBittorrent.git","svn_url":"https://github.com/qbittorrent/qBittorrent","homepage":"http://www.qbittorrent.org","size":116789,"stargazers_count":834,"watchers_count":834,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":266,"mirror_url":null,"open_issues_count":919,"forks":266,"open_issues":919,"watchers":834,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/2850"},"html":{"href":"https://github.com/qbittorrent/qBittorrent/pull/2850"},"issue":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/2850"},"comments":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/2850/comments"},"review_comments":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/2850/comments"},"review_comment":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/2850/commits"},"statuses":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/459c8e311001f08fff5f0841506d39b498f4e583"}}}}