{"action":"closed","number":15558,"pull_request":{"url":"https://api.github.com/repos/twbs/bootstrap/pulls/15558","id":27301748,"html_url":"https://github.com/twbs/bootstrap/pull/15558","diff_url":"https://github.com/twbs/bootstrap/pull/15558.diff","patch_url":"https://github.com/twbs/bootstrap/pull/15558.patch","issue_url":"https://api.github.com/repos/twbs/bootstrap/issues/15558","number":15558,"state":"closed","locked":false,"title":"Use strict mode in jQuery version check module. Closes #15535","user":{"login":"peterblazejewicz","id":14539,"avatar_url":"https://avatars.githubusercontent.com/u/14539?v=3","gravatar_id":"","url":"https://api.github.com/users/peterblazejewicz","html_url":"https://github.com/peterblazejewicz","followers_url":"https://api.github.com/users/peterblazejewicz/followers","following_url":"https://api.github.com/users/peterblazejewicz/following{/other_user}","gists_url":"https://api.github.com/users/peterblazejewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/peterblazejewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterblazejewicz/subscriptions","organizations_url":"https://api.github.com/users/peterblazejewicz/orgs","repos_url":"https://api.github.com/users/peterblazejewicz/repos","events_url":"https://api.github.com/users/peterblazejewicz/events{/privacy}","received_events_url":"https://api.github.com/users/peterblazejewicz/received_events","type":"User","site_admin":false},"body":"This PR adds strict mode declaration missing in jQuery version check module which is inserted at runtime via Grunt tasks to distribution source code. Missing `use strict` missed JSHint code checks as it is part of content not covered by JSHint tests.\r\n\r\nAfter build the non-minified distribution file will look like:\r\n```diff\r\ndiff --git a/dist/js/bootstrap.js b/dist/js/bootstrap.js\r\nindex 42e92bf..ab0ae1e 100644\r\n--- a/dist/js/bootstrap.js\r\n+++ b/dist/js/bootstrap.js\r\n@@ -9,6 +9,7 @@ if (typeof jQuery === 'undefined') {\r\n }\r\n \r\n +function ($) {\r\n+  'use strict';\r\n   var version = $.fn.jquery.split(' ')[0].split('.')\r\n   if ((version[0] < 2 && version[1] < 9) || (version[0] == 1 && version[1] == 9 && version[2] < 1)) {\r\n     throw new Error('Bootstrap\\'s JavaScript requires jQuery version 1.9.1 or higher')\r\n```\r\nand version check module will look like:\r\n```JavaScript\r\n+function ($) {\r\n  'use strict';\r\n  var version = $.fn.jquery.split(' ')[0].split('.')\r\n  if ((version[0] < 2 && version[1] < 9) || (version[0] == 1 && version[1] == 9 && version[2] < 1)) {\r\n    throw new Error('Bootstrap\\'s JavaScript requires jQuery version 1.9.1 or higher')\r\n  }\r\n}(jQuery);\r\n```\r\nThanks!","created_at":"2015-01-13T20:26:30Z","updated_at":"2015-01-13T20:40:50Z","closed_at":"2015-01-13T20:40:50Z","merged_at":null,"merge_commit_sha":"137aaee910ee9c364e1ff86b2d0e09e1c9f95628","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twbs/bootstrap/pulls/15558/commits","review_comments_url":"https://api.github.com/repos/twbs/bootstrap/pulls/15558/comments","review_comment_url":"https://api.github.com/repos/twbs/bootstrap/pulls/comments/{number}","comments_url":"https://api.github.com/repos/twbs/bootstrap/issues/15558/comments","statuses_url":"https://api.github.com/repos/twbs/bootstrap/statuses/6122a57dbbbd5dcac12e0e19c6d56f63a5a933b1","head":{"label":"peterblazejewicz:fix/strict-mode-config-bridge","ref":"fix/strict-mode-config-bridge","sha":"6122a57dbbbd5dcac12e0e19c6d56f63a5a933b1","user":{"login":"peterblazejewicz","id":14539,"avatar_url":"https://avatars.githubusercontent.com/u/14539?v=3","gravatar_id":"","url":"https://api.github.com/users/peterblazejewicz","html_url":"https://github.com/peterblazejewicz","followers_url":"https://api.github.com/users/peterblazejewicz/followers","following_url":"https://api.github.com/users/peterblazejewicz/following{/other_user}","gists_url":"https://api.github.com/users/peterblazejewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/peterblazejewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterblazejewicz/subscriptions","organizations_url":"https://api.github.com/users/peterblazejewicz/orgs","repos_url":"https://api.github.com/users/peterblazejewicz/repos","events_url":"https://api.github.com/users/peterblazejewicz/events{/privacy}","received_events_url":"https://api.github.com/users/peterblazejewicz/received_events","type":"User","site_admin":false},"repo":{"id":27196245,"name":"bootstrap","full_name":"peterblazejewicz/bootstrap","owner":{"login":"peterblazejewicz","id":14539,"avatar_url":"https://avatars.githubusercontent.com/u/14539?v=3","gravatar_id":"","url":"https://api.github.com/users/peterblazejewicz","html_url":"https://github.com/peterblazejewicz","followers_url":"https://api.github.com/users/peterblazejewicz/followers","following_url":"https://api.github.com/users/peterblazejewicz/following{/other_user}","gists_url":"https://api.github.com/users/peterblazejewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/peterblazejewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterblazejewicz/subscriptions","organizations_url":"https://api.github.com/users/peterblazejewicz/orgs","repos_url":"https://api.github.com/users/peterblazejewicz/repos","events_url":"https://api.github.com/users/peterblazejewicz/events{/privacy}","received_events_url":"https://api.github.com/users/peterblazejewicz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peterblazejewicz/bootstrap","description":"The most popular HTML, CSS, and JavaScript framework for developing responsive, mobile first projects on the web.","fork":true,"url":"https://api.github.com/repos/peterblazejewicz/bootstrap","forks_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/forks","keys_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/teams","hooks_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/events","assignees_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/tags","blobs_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/languages","stargazers_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/subscription","commits_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/issues/comments/{number}","contents_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/merges","archive_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/downloads","issues_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/peterblazejewicz/bootstrap/releases{/id}","created_at":"2014-11-26T21:07:57Z","updated_at":"2015-01-13T19:59:08Z","pushed_at":"2015-01-13T20:21:28Z","git_url":"git://github.com/peterblazejewicz/bootstrap.git","ssh_url":"git@github.com:peterblazejewicz/bootstrap.git","clone_url":"https://github.com/peterblazejewicz/bootstrap.git","svn_url":"https://github.com/peterblazejewicz/bootstrap","homepage":"http://getbootstrap.com","size":73656,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twbs:master","ref":"master","sha":"0dc83955903eafb6589447c2025d05d841f09d57","user":{"login":"twbs","id":2918581,"avatar_url":"https://avatars.githubusercontent.com/u/2918581?v=3","gravatar_id":"","url":"https://api.github.com/users/twbs","html_url":"https://github.com/twbs","followers_url":"https://api.github.com/users/twbs/followers","following_url":"https://api.github.com/users/twbs/following{/other_user}","gists_url":"https://api.github.com/users/twbs/gists{/gist_id}","starred_url":"https://api.github.com/users/twbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twbs/subscriptions","organizations_url":"https://api.github.com/users/twbs/orgs","repos_url":"https://api.github.com/users/twbs/repos","events_url":"https://api.github.com/users/twbs/events{/privacy}","received_events_url":"https://api.github.com/users/twbs/received_events","type":"Organization","site_admin":false},"repo":{"id":2126244,"name":"bootstrap","full_name":"twbs/bootstrap","owner":{"login":"twbs","id":2918581,"avatar_url":"https://avatars.githubusercontent.com/u/2918581?v=3","gravatar_id":"","url":"https://api.github.com/users/twbs","html_url":"https://github.com/twbs","followers_url":"https://api.github.com/users/twbs/followers","following_url":"https://api.github.com/users/twbs/following{/other_user}","gists_url":"https://api.github.com/users/twbs/gists{/gist_id}","starred_url":"https://api.github.com/users/twbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twbs/subscriptions","organizations_url":"https://api.github.com/users/twbs/orgs","repos_url":"https://api.github.com/users/twbs/repos","events_url":"https://api.github.com/users/twbs/events{/privacy}","received_events_url":"https://api.github.com/users/twbs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twbs/bootstrap","description":"The most popular HTML, CSS, and JavaScript framework for developing responsive, mobile first projects on the web.","fork":false,"url":"https://api.github.com/repos/twbs/bootstrap","forks_url":"https://api.github.com/repos/twbs/bootstrap/forks","keys_url":"https://api.github.com/repos/twbs/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twbs/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twbs/bootstrap/teams","hooks_url":"https://api.github.com/repos/twbs/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/twbs/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/twbs/bootstrap/events","assignees_url":"https://api.github.com/repos/twbs/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/twbs/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/twbs/bootstrap/tags","blobs_url":"https://api.github.com/repos/twbs/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twbs/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twbs/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/twbs/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twbs/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/twbs/bootstrap/languages","stargazers_url":"https://api.github.com/repos/twbs/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/twbs/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/twbs/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/twbs/bootstrap/subscription","commits_url":"https://api.github.com/repos/twbs/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/twbs/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/twbs/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/twbs/bootstrap/issues/comments/{number}","contents_url":"https://api.github.com/repos/twbs/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/twbs/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twbs/bootstrap/merges","archive_url":"https://api.github.com/repos/twbs/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twbs/bootstrap/downloads","issues_url":"https://api.github.com/repos/twbs/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/twbs/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/twbs/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/twbs/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twbs/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/twbs/bootstrap/releases{/id}","created_at":"2011-07-29T21:19:00Z","updated_at":"2015-01-13T20:31:27Z","pushed_at":"2015-01-13T20:31:26Z","git_url":"git://github.com/twbs/bootstrap.git","ssh_url":"git@github.com:twbs/bootstrap.git","clone_url":"https://github.com/twbs/bootstrap.git","svn_url":"https://github.com/twbs/bootstrap","homepage":"http://getbootstrap.com","size":152681,"stargazers_count":76504,"watchers_count":76504,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":29235,"mirror_url":null,"open_issues_count":136,"forks":29235,"open_issues":136,"watchers":76504,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twbs/bootstrap/pulls/15558"},"html":{"href":"https://github.com/twbs/bootstrap/pull/15558"},"issue":{"href":"https://api.github.com/repos/twbs/bootstrap/issues/15558"},"comments":{"href":"https://api.github.com/repos/twbs/bootstrap/issues/15558/comments"},"review_comments":{"href":"https://api.github.com/repos/twbs/bootstrap/pulls/15558/comments"},"review_comment":{"href":"https://api.github.com/repos/twbs/bootstrap/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/twbs/bootstrap/pulls/15558/commits"},"statuses":{"href":"https://api.github.com/repos/twbs/bootstrap/statuses/6122a57dbbbd5dcac12e0e19c6d56f63a5a933b1"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}