{"action":"created","comment":{"url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/pulls/comments/43718332","id":43718332,"diff_hunk":"@@ -588,6 +588,214 @@ service Repos {\n \trpc ListCommitters(ReposListCommittersOp) returns (CommitterList);\n }\n \n+// StorageError represents an error when interacting with the Storage service.\n+message StorageError {\n+\t// Code represents the type of error for programatic handling.\n+\tenum Code {\n+\t\t// None is the error code used when programatic handling of the error is not\n+\t\t// advised. It can be assumed that the operation failed, and that a human\n+\t\t// readable message is also provided.\n+\t\tNone = 0;\n+\n+\t\t// EOF is the error returned by Read when no more input is available.\n+\t\t// Functions should return EOF only to signal a graceful end of input. If\n+\t\t// the EOF occurs unexpectedly in a structured data stream, the appropriate\n+\t\t// error is either UNEXPECTED_EOF or some other error message giving more\n+\t\t// detail.\n+\t\tEOF = 1;\n+\n+\t\t// NotExist is the error used when attempting to read/write to an object\n+\t\t// that does not exist.\n+\t\tNotExist = 2;\n+\n+\t\t// Permission is the error used when permission to access the given file is\n+\t\t// not granted to you.\n+\t\tPermission = 3;\n+\t}\n+\n+\t// code is the error code. If no error code is specified then programatic\n+\t// handling of the error is not advised. The user should be informed of the\n+\t// error message instead.\n+\tCode code = 1;\n+\n+\t// message is the human-readable error message.\n+\tstring message = 2;\n+}\n+\n+// StorageName is a storage object's name.\n+message StorageName {\n+\t// AppName is the name of the application whose data you are trying to\n+\t// read/write, applications may read and write to eachothers data assuming\n+\t// the admin has not restricted such access.\n+\tstring app_name = 1;\n+\n+\t// If specified storage is considered local to the given repository. Otherwise\n+\t// it is considered \"global\" (i.e. shared across all repositories).\n+\tstring repo = 2;","path":"sourcegraph/sourcegraph.proto","position":47,"original_position":47,"commit_id":"3c92b9e96030f3755ca604e7ea535fb16ac4a031","original_commit_id":"3c92b9e96030f3755ca604e7ea535fb16ac4a031","user":{"login":"shurcooL","id":1924134,"avatar_url":"https://avatars.githubusercontent.com/u/1924134?v=3","gravatar_id":"","url":"https://api.github.com/users/shurcooL","html_url":"https://github.com/shurcooL","followers_url":"https://api.github.com/users/shurcooL/followers","following_url":"https://api.github.com/users/shurcooL/following{/other_user}","gists_url":"https://api.github.com/users/shurcooL/gists{/gist_id}","starred_url":"https://api.github.com/users/shurcooL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shurcooL/subscriptions","organizations_url":"https://api.github.com/users/shurcooL/orgs","repos_url":"https://api.github.com/users/shurcooL/repos","events_url":"https://api.github.com/users/shurcooL/events{/privacy}","received_events_url":"https://api.github.com/users/shurcooL/received_events","type":"User","site_admin":false},"body":"`Repo ...`.\r\n\r\nI don't know how strongly we should enforce these, but the rest of this repo follows this catchable-with-`golint` style.","created_at":"2015-11-03T05:54:42Z","updated_at":"2015-11-03T05:54:42Z","html_url":"https://github.com/sourcegraph/go-sourcegraph/pull/75#discussion_r43718332","pull_request_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/pulls/75","_links":{"self":{"href":"https://api.github.com/repos/sourcegraph/go-sourcegraph/pulls/comments/43718332"},"html":{"href":"https://github.com/sourcegraph/go-sourcegraph/pull/75#discussion_r43718332"},"pull_request":{"href":"https://api.github.com/repos/sourcegraph/go-sourcegraph/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/pulls/75","id":47713360,"html_url":"https://github.com/sourcegraph/go-sourcegraph/pull/75","diff_url":"https://github.com/sourcegraph/go-sourcegraph/pull/75.diff","patch_url":"https://github.com/sourcegraph/go-sourcegraph/pull/75.patch","issue_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/issues/75","number":75,"state":"open","locked":false,"title":"Generic storage","user":{"login":"slimsag","id":3173176,"avatar_url":"https://avatars.githubusercontent.com/u/3173176?v=3","gravatar_id":"","url":"https://api.github.com/users/slimsag","html_url":"https://github.com/slimsag","followers_url":"https://api.github.com/users/slimsag/followers","following_url":"https://api.github.com/users/slimsag/following{/other_user}","gists_url":"https://api.github.com/users/slimsag/gists{/gist_id}","starred_url":"https://api.github.com/users/slimsag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimsag/subscriptions","organizations_url":"https://api.github.com/users/slimsag/orgs","repos_url":"https://api.github.com/users/slimsag/repos","events_url":"https://api.github.com/users/slimsag/events{/privacy}","received_events_url":"https://api.github.com/users/slimsag/received_events","type":"User","site_admin":false},"body":"This change provides a generic storage API, more details in the core repo CS.","created_at":"2015-10-14T20:52:52Z","updated_at":"2015-11-03T05:54:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd8ee8594633eb91406f9967348ae6e561802977","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/pulls/75/commits","review_comments_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/pulls/75/comments","review_comment_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/issues/75/comments","statuses_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/statuses/3c92b9e96030f3755ca604e7ea535fb16ac4a031","head":{"label":"sourcegraph:generic-storage","ref":"generic-storage","sha":"3c92b9e96030f3755ca604e7ea535fb16ac4a031","user":{"login":"sourcegraph","id":3979584,"avatar_url":"https://avatars.githubusercontent.com/u/3979584?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"repo":{"id":22002113,"name":"go-sourcegraph","full_name":"sourcegraph/go-sourcegraph","owner":{"login":"sourcegraph","id":3979584,"avatar_url":"https://avatars.githubusercontent.com/u/3979584?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sourcegraph/go-sourcegraph","description":"","fork":false,"url":"https://api.github.com/repos/sourcegraph/go-sourcegraph","forks_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/forks","keys_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/teams","hooks_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/hooks","issue_events_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/issues/events{/number}","events_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/events","assignees_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/assignees{/user}","branches_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/branches{/branch}","tags_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/tags","blobs_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/languages","stargazers_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/stargazers","contributors_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/contributors","subscribers_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/subscribers","subscription_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/subscription","commits_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/contents/{+path}","compare_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/merges","archive_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/downloads","issues_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/issues{/number}","pulls_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/labels{/name}","releases_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/releases{/id}","created_at":"2014-07-19T04:43:05Z","updated_at":"2015-10-23T14:58:08Z","pushed_at":"2015-11-02T20:35:59Z","git_url":"git://github.com/sourcegraph/go-sourcegraph.git","ssh_url":"git@github.com:sourcegraph/go-sourcegraph.git","clone_url":"https://github.com/sourcegraph/go-sourcegraph.git","svn_url":"https://github.com/sourcegraph/go-sourcegraph","homepage":"https://sourcegraph.com/sourcegraph/go-sourcegraph","size":3405,"stargazers_count":30,"watchers_count":30,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":6,"forks":6,"open_issues":6,"watchers":30,"default_branch":"master"}},"base":{"label":"sourcegraph:master","ref":"master","sha":"d3895fe463b2ea38b001489a71ad01c14719bfed","user":{"login":"sourcegraph","id":3979584,"avatar_url":"https://avatars.githubusercontent.com/u/3979584?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"repo":{"id":22002113,"name":"go-sourcegraph","full_name":"sourcegraph/go-sourcegraph","owner":{"login":"sourcegraph","id":3979584,"avatar_url":"https://avatars.githubusercontent.com/u/3979584?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sourcegraph/go-sourcegraph","description":"","fork":false,"url":"https://api.github.com/repos/sourcegraph/go-sourcegraph","forks_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/forks","keys_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/teams","hooks_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/hooks","issue_events_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/issues/events{/number}","events_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/events","assignees_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/assignees{/user}","branches_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/branches{/branch}","tags_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/tags","blobs_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/languages","stargazers_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/stargazers","contributors_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/contributors","subscribers_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/subscribers","subscription_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/subscription","commits_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/contents/{+path}","compare_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/merges","archive_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/downloads","issues_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/issues{/number}","pulls_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/labels{/name}","releases_url":"https://api.github.com/repos/sourcegraph/go-sourcegraph/releases{/id}","created_at":"2014-07-19T04:43:05Z","updated_at":"2015-10-23T14:58:08Z","pushed_at":"2015-11-02T20:35:59Z","git_url":"git://github.com/sourcegraph/go-sourcegraph.git","ssh_url":"git@github.com:sourcegraph/go-sourcegraph.git","clone_url":"https://github.com/sourcegraph/go-sourcegraph.git","svn_url":"https://github.com/sourcegraph/go-sourcegraph","homepage":"https://sourcegraph.com/sourcegraph/go-sourcegraph","size":3405,"stargazers_count":30,"watchers_count":30,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":6,"forks":6,"open_issues":6,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sourcegraph/go-sourcegraph/pulls/75"},"html":{"href":"https://github.com/sourcegraph/go-sourcegraph/pull/75"},"issue":{"href":"https://api.github.com/repos/sourcegraph/go-sourcegraph/issues/75"},"comments":{"href":"https://api.github.com/repos/sourcegraph/go-sourcegraph/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/sourcegraph/go-sourcegraph/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/sourcegraph/go-sourcegraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sourcegraph/go-sourcegraph/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/sourcegraph/go-sourcegraph/statuses/3c92b9e96030f3755ca604e7ea535fb16ac4a031"}}}}