{"action":"created","issue":{"url":"https://api.github.com/repos/NYULibraries/ichabod/issues/199","labels_url":"https://api.github.com/repos/NYULibraries/ichabod/issues/199/labels{/name}","comments_url":"https://api.github.com/repos/NYULibraries/ichabod/issues/199/comments","events_url":"https://api.github.com/repos/NYULibraries/ichabod/issues/199/events","html_url":"https://github.com/NYULibraries/ichabod/pull/199","id":121063654,"number":199,"title":"Feature/add wojnarowicz - (need feedback)","user":{"login":"eshadatta","id":1337128,"avatar_url":"https://avatars.githubusercontent.com/u/1337128?v=3","gravatar_id":"","url":"https://api.github.com/users/eshadatta","html_url":"https://github.com/eshadatta","followers_url":"https://api.github.com/users/eshadatta/followers","following_url":"https://api.github.com/users/eshadatta/following{/other_user}","gists_url":"https://api.github.com/users/eshadatta/gists{/gist_id}","starred_url":"https://api.github.com/users/eshadatta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eshadatta/subscriptions","organizations_url":"https://api.github.com/users/eshadatta/orgs","repos_url":"https://api.github.com/users/eshadatta/repos","events_url":"https://api.github.com/users/eshadatta/events{/privacy}","received_events_url":"https://api.github.com/users/eshadatta/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-12-08T17:58:26Z","updated_at":"2015-12-11T19:12:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NYULibraries/ichabod/pulls/199","html_url":"https://github.com/NYULibraries/ichabod/pull/199","diff_url":"https://github.com/NYULibraries/ichabod/pull/199.diff","patch_url":"https://github.com/NYULibraries/ichabod/pull/199.patch"},"body":"@jgpawletko , @NYULibraries/hydra ,\r\n\r\nThis pull request finishes the David Wojnarowicz [story](https://www.pivotaltracker.com/n/projects/1025368/stories/99084376) in pivotal tracker.  I have  questions about this.\r\n\r\n1. I couldn't send proper url parameters to the finding aids bridge [portal](https://specialcollections.library.nyu.edu/search). It wasn't encoding it correctly. So, I have a rather ugly hack [here](https://github.com/NYULibraries/ichabod/compare/feature/add_wojnarowicz?expand=1#diff-91efdd0940d8aedd7c2e88b98671026eR9). If I tried to send it through the params argument using Faraday, it never encoded it the way the portal could translate it. It would be f = arg1 & f = arg2 rather than the way I have put it in that file.\r\n2. I've put in constants in the [fab reader](https://github.com/NYULibraries/ichabod/compare/feature/add_wojnarowicz?expand=1#diff-44ab4052d2a371cb4090731c746dba90R12) instead of passing it through the model since any other collection using the fabreader would be using the same values. I thought of putting these in configula and referencing them as ENV variables instead of putting them deep in the reader but then it would fail in travis. Please let me know if you have any thoughts on this.\r\n\r\nEDIT: Adding to say that for point 1, this could change later once we talk to Barnaby about how to tweak the FAB to have it also work as an api. But it's an ugly hack for now.\r\n\r\nPlease let me know if you have any other feedback as well. Thanks."},"comment":{"url":"https://api.github.com/repos/NYULibraries/ichabod/issues/comments/164022892","html_url":"https://github.com/NYULibraries/ichabod/pull/199#issuecomment-164022892","issue_url":"https://api.github.com/repos/NYULibraries/ichabod/issues/199","id":164022892,"user":{"login":"eshadatta","id":1337128,"avatar_url":"https://avatars.githubusercontent.com/u/1337128?v=3","gravatar_id":"","url":"https://api.github.com/users/eshadatta","html_url":"https://github.com/eshadatta","followers_url":"https://api.github.com/users/eshadatta/followers","following_url":"https://api.github.com/users/eshadatta/following{/other_user}","gists_url":"https://api.github.com/users/eshadatta/gists{/gist_id}","starred_url":"https://api.github.com/users/eshadatta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eshadatta/subscriptions","organizations_url":"https://api.github.com/users/eshadatta/orgs","repos_url":"https://api.github.com/users/eshadatta/repos","events_url":"https://api.github.com/users/eshadatta/events{/privacy}","received_events_url":"https://api.github.com/users/eshadatta/received_events","type":"User","site_admin":false},"created_at":"2015-12-11T19:12:24Z","updated_at":"2015-12-11T19:12:24Z","body":"@da70 , awesomesauce! Thanks! @jgpawletko, thanks for continuing to look into this. "}}