{"action":"closed","number":170,"pull_request":{"url":"https://api.github.com/repos/zettajs/zetta/pulls/170","id":32547001,"html_url":"https://github.com/zettajs/zetta/pull/170","diff_url":"https://github.com/zettajs/zetta/pull/170.diff","patch_url":"https://github.com/zettajs/zetta/pull/170.patch","issue_url":"https://api.github.com/repos/zettajs/zetta/issues/170","number":170,"state":"closed","locked":false,"title":"Fix peer event subscriptions","user":{"login":"AdamMagaluk","id":823985,"avatar_url":"https://avatars.githubusercontent.com/u/823985?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamMagaluk","html_url":"https://github.com/AdamMagaluk","followers_url":"https://api.github.com/users/AdamMagaluk/followers","following_url":"https://api.github.com/users/AdamMagaluk/following{/other_user}","gists_url":"https://api.github.com/users/AdamMagaluk/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamMagaluk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamMagaluk/subscriptions","organizations_url":"https://api.github.com/users/AdamMagaluk/orgs","repos_url":"https://api.github.com/users/AdamMagaluk/repos","events_url":"https://api.github.com/users/AdamMagaluk/events{/privacy}","received_events_url":"https://api.github.com/users/AdamMagaluk/received_events","type":"User","site_admin":false},"body":"There is a bug in the peer connection where if a peer_socket emits an `error` or `end` event multiple times per one `connected` event it causes an issue with http_server managing the connected peers.\r\n\r\nOnly way i was able to get the peer_socket to emit multiple `error` events was to have a peer connect to my laptop then disconnect the wifi. There will be an `error` event emitted from the ping timer code that says its connection timed out. But there is another event being thrown from somewhere else.","created_at":"2015-04-02T20:26:40Z","updated_at":"2015-04-07T18:20:43Z","closed_at":"2015-04-07T18:20:43Z","merged_at":"2015-04-07T18:20:43Z","merge_commit_sha":"c231f2eaa325f0bf30e9652bbf41b837e7e82383","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zettajs/zetta/pulls/170/commits","review_comments_url":"https://api.github.com/repos/zettajs/zetta/pulls/170/comments","review_comment_url":"https://api.github.com/repos/zettajs/zetta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zettajs/zetta/issues/170/comments","statuses_url":"https://api.github.com/repos/zettajs/zetta/statuses/a29104890410abefc8f8507520f915f1809e9356","head":{"label":"zettajs:fix-peer-event-subscriptions","ref":"fix-peer-event-subscriptions","sha":"a29104890410abefc8f8507520f915f1809e9356","user":{"login":"zettajs","id":7231880,"avatar_url":"https://avatars.githubusercontent.com/u/7231880?v=3","gravatar_id":"","url":"https://api.github.com/users/zettajs","html_url":"https://github.com/zettajs","followers_url":"https://api.github.com/users/zettajs/followers","following_url":"https://api.github.com/users/zettajs/following{/other_user}","gists_url":"https://api.github.com/users/zettajs/gists{/gist_id}","starred_url":"https://api.github.com/users/zettajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zettajs/subscriptions","organizations_url":"https://api.github.com/users/zettajs/orgs","repos_url":"https://api.github.com/users/zettajs/repos","events_url":"https://api.github.com/users/zettajs/events{/privacy}","received_events_url":"https://api.github.com/users/zettajs/received_events","type":"Organization","site_admin":false},"repo":{"id":18918709,"name":"zetta","full_name":"zettajs/zetta","owner":{"login":"zettajs","id":7231880,"avatar_url":"https://avatars.githubusercontent.com/u/7231880?v=3","gravatar_id":"","url":"https://api.github.com/users/zettajs","html_url":"https://github.com/zettajs","followers_url":"https://api.github.com/users/zettajs/followers","following_url":"https://api.github.com/users/zettajs/following{/other_user}","gists_url":"https://api.github.com/users/zettajs/gists{/gist_id}","starred_url":"https://api.github.com/users/zettajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zettajs/subscriptions","organizations_url":"https://api.github.com/users/zettajs/orgs","repos_url":"https://api.github.com/users/zettajs/repos","events_url":"https://api.github.com/users/zettajs/events{/privacy}","received_events_url":"https://api.github.com/users/zettajs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zettajs/zetta","description":"An API-first, open source software platform for the Internet of Things. ","fork":false,"url":"https://api.github.com/repos/zettajs/zetta","forks_url":"https://api.github.com/repos/zettajs/zetta/forks","keys_url":"https://api.github.com/repos/zettajs/zetta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zettajs/zetta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zettajs/zetta/teams","hooks_url":"https://api.github.com/repos/zettajs/zetta/hooks","issue_events_url":"https://api.github.com/repos/zettajs/zetta/issues/events{/number}","events_url":"https://api.github.com/repos/zettajs/zetta/events","assignees_url":"https://api.github.com/repos/zettajs/zetta/assignees{/user}","branches_url":"https://api.github.com/repos/zettajs/zetta/branches{/branch}","tags_url":"https://api.github.com/repos/zettajs/zetta/tags","blobs_url":"https://api.github.com/repos/zettajs/zetta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zettajs/zetta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zettajs/zetta/git/refs{/sha}","trees_url":"https://api.github.com/repos/zettajs/zetta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zettajs/zetta/statuses/{sha}","languages_url":"https://api.github.com/repos/zettajs/zetta/languages","stargazers_url":"https://api.github.com/repos/zettajs/zetta/stargazers","contributors_url":"https://api.github.com/repos/zettajs/zetta/contributors","subscribers_url":"https://api.github.com/repos/zettajs/zetta/subscribers","subscription_url":"https://api.github.com/repos/zettajs/zetta/subscription","commits_url":"https://api.github.com/repos/zettajs/zetta/commits{/sha}","git_commits_url":"https://api.github.com/repos/zettajs/zetta/git/commits{/sha}","comments_url":"https://api.github.com/repos/zettajs/zetta/comments{/number}","issue_comment_url":"https://api.github.com/repos/zettajs/zetta/issues/comments{/number}","contents_url":"https://api.github.com/repos/zettajs/zetta/contents/{+path}","compare_url":"https://api.github.com/repos/zettajs/zetta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zettajs/zetta/merges","archive_url":"https://api.github.com/repos/zettajs/zetta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zettajs/zetta/downloads","issues_url":"https://api.github.com/repos/zettajs/zetta/issues{/number}","pulls_url":"https://api.github.com/repos/zettajs/zetta/pulls{/number}","milestones_url":"https://api.github.com/repos/zettajs/zetta/milestones{/number}","notifications_url":"https://api.github.com/repos/zettajs/zetta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zettajs/zetta/labels{/name}","releases_url":"https://api.github.com/repos/zettajs/zetta/releases{/id}","created_at":"2014-04-18T16:34:08Z","updated_at":"2015-04-07T06:26:55Z","pushed_at":"2015-04-07T18:20:42Z","git_url":"git://github.com/zettajs/zetta.git","ssh_url":"git@github.com:zettajs/zetta.git","clone_url":"https://github.com/zettajs/zetta.git","svn_url":"https://github.com/zettajs/zetta","homepage":"http://zettajs.org","size":2867,"stargazers_count":79,"watchers_count":79,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":28,"forks":15,"open_issues":28,"watchers":79,"default_branch":"master"}},"base":{"label":"zettajs:master","ref":"master","sha":"6c842642683b29e0ef38433ad77991137ff96c0a","user":{"login":"zettajs","id":7231880,"avatar_url":"https://avatars.githubusercontent.com/u/7231880?v=3","gravatar_id":"","url":"https://api.github.com/users/zettajs","html_url":"https://github.com/zettajs","followers_url":"https://api.github.com/users/zettajs/followers","following_url":"https://api.github.com/users/zettajs/following{/other_user}","gists_url":"https://api.github.com/users/zettajs/gists{/gist_id}","starred_url":"https://api.github.com/users/zettajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zettajs/subscriptions","organizations_url":"https://api.github.com/users/zettajs/orgs","repos_url":"https://api.github.com/users/zettajs/repos","events_url":"https://api.github.com/users/zettajs/events{/privacy}","received_events_url":"https://api.github.com/users/zettajs/received_events","type":"Organization","site_admin":false},"repo":{"id":18918709,"name":"zetta","full_name":"zettajs/zetta","owner":{"login":"zettajs","id":7231880,"avatar_url":"https://avatars.githubusercontent.com/u/7231880?v=3","gravatar_id":"","url":"https://api.github.com/users/zettajs","html_url":"https://github.com/zettajs","followers_url":"https://api.github.com/users/zettajs/followers","following_url":"https://api.github.com/users/zettajs/following{/other_user}","gists_url":"https://api.github.com/users/zettajs/gists{/gist_id}","starred_url":"https://api.github.com/users/zettajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zettajs/subscriptions","organizations_url":"https://api.github.com/users/zettajs/orgs","repos_url":"https://api.github.com/users/zettajs/repos","events_url":"https://api.github.com/users/zettajs/events{/privacy}","received_events_url":"https://api.github.com/users/zettajs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zettajs/zetta","description":"An API-first, open source software platform for the Internet of Things. ","fork":false,"url":"https://api.github.com/repos/zettajs/zetta","forks_url":"https://api.github.com/repos/zettajs/zetta/forks","keys_url":"https://api.github.com/repos/zettajs/zetta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zettajs/zetta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zettajs/zetta/teams","hooks_url":"https://api.github.com/repos/zettajs/zetta/hooks","issue_events_url":"https://api.github.com/repos/zettajs/zetta/issues/events{/number}","events_url":"https://api.github.com/repos/zettajs/zetta/events","assignees_url":"https://api.github.com/repos/zettajs/zetta/assignees{/user}","branches_url":"https://api.github.com/repos/zettajs/zetta/branches{/branch}","tags_url":"https://api.github.com/repos/zettajs/zetta/tags","blobs_url":"https://api.github.com/repos/zettajs/zetta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zettajs/zetta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zettajs/zetta/git/refs{/sha}","trees_url":"https://api.github.com/repos/zettajs/zetta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zettajs/zetta/statuses/{sha}","languages_url":"https://api.github.com/repos/zettajs/zetta/languages","stargazers_url":"https://api.github.com/repos/zettajs/zetta/stargazers","contributors_url":"https://api.github.com/repos/zettajs/zetta/contributors","subscribers_url":"https://api.github.com/repos/zettajs/zetta/subscribers","subscription_url":"https://api.github.com/repos/zettajs/zetta/subscription","commits_url":"https://api.github.com/repos/zettajs/zetta/commits{/sha}","git_commits_url":"https://api.github.com/repos/zettajs/zetta/git/commits{/sha}","comments_url":"https://api.github.com/repos/zettajs/zetta/comments{/number}","issue_comment_url":"https://api.github.com/repos/zettajs/zetta/issues/comments{/number}","contents_url":"https://api.github.com/repos/zettajs/zetta/contents/{+path}","compare_url":"https://api.github.com/repos/zettajs/zetta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zettajs/zetta/merges","archive_url":"https://api.github.com/repos/zettajs/zetta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zettajs/zetta/downloads","issues_url":"https://api.github.com/repos/zettajs/zetta/issues{/number}","pulls_url":"https://api.github.com/repos/zettajs/zetta/pulls{/number}","milestones_url":"https://api.github.com/repos/zettajs/zetta/milestones{/number}","notifications_url":"https://api.github.com/repos/zettajs/zetta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zettajs/zetta/labels{/name}","releases_url":"https://api.github.com/repos/zettajs/zetta/releases{/id}","created_at":"2014-04-18T16:34:08Z","updated_at":"2015-04-07T06:26:55Z","pushed_at":"2015-04-07T18:20:42Z","git_url":"git://github.com/zettajs/zetta.git","ssh_url":"git@github.com:zettajs/zetta.git","clone_url":"https://github.com/zettajs/zetta.git","svn_url":"https://github.com/zettajs/zetta","homepage":"http://zettajs.org","size":2867,"stargazers_count":79,"watchers_count":79,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":28,"forks":15,"open_issues":28,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zettajs/zetta/pulls/170"},"html":{"href":"https://github.com/zettajs/zetta/pull/170"},"issue":{"href":"https://api.github.com/repos/zettajs/zetta/issues/170"},"comments":{"href":"https://api.github.com/repos/zettajs/zetta/issues/170/comments"},"review_comments":{"href":"https://api.github.com/repos/zettajs/zetta/pulls/170/comments"},"review_comment":{"href":"https://api.github.com/repos/zettajs/zetta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zettajs/zetta/pulls/170/commits"},"statuses":{"href":"https://api.github.com/repos/zettajs/zetta/statuses/a29104890410abefc8f8507520f915f1809e9356"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kevinswiber","id":78582,"avatar_url":"https://avatars.githubusercontent.com/u/78582?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinswiber","html_url":"https://github.com/kevinswiber","followers_url":"https://api.github.com/users/kevinswiber/followers","following_url":"https://api.github.com/users/kevinswiber/following{/other_user}","gists_url":"https://api.github.com/users/kevinswiber/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinswiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinswiber/subscriptions","organizations_url":"https://api.github.com/users/kevinswiber/orgs","repos_url":"https://api.github.com/users/kevinswiber/repos","events_url":"https://api.github.com/users/kevinswiber/events{/privacy}","received_events_url":"https://api.github.com/users/kevinswiber/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":65,"deletions":9,"changed_files":2}}