{"action":"created","comment":{"url":"https://api.github.com/repos/TauLabs/TauLabs/pulls/comments/40458599","id":40458599,"diff_hunk":"@@ -1090,9 +1093,9 @@ static void altitude_hold_desired(ManualControlCommandData * cmd, bool flightMod\n \t\tif (cmd->Throttle > DEADBAND_HIGH) {\n \t\t\tclimb_rate = expo3((cmd->Throttle - DEADBAND_HIGH) / (1.0f - DEADBAND_HIGH), altitude_hold_expo) *\n \t\t                         altitude_hold_maxclimbrate;\n-\t\t} else if (cmd->Throttle < DEADBAND_LOW && altitude_hold_maxclimbrate > MIN_CLIMB_RATE) {\n+\t\t} else if (cmd->Throttle < DEADBAND_LOW && altitude_hold_maxdescentrate > MIN_CLIMB_RATE) {\n \t\t\tclimb_rate = ((cmd->Throttle < 0) ? DEADBAND_LOW : DEADBAND_LOW - cmd->Throttle) / DEADBAND_LOW;","path":"flight/Modules/ManualControl/transmitter_control.c","position":21,"original_position":21,"commit_id":"cbff3faab93894fd754789e809c2cb13c8170acf","original_commit_id":"cbff3faab93894fd754789e809c2cb13c8170acf","user":{"login":"mlyle","id":90903,"avatar_url":"https://avatars.githubusercontent.com/u/90903?v=3","gravatar_id":"","url":"https://api.github.com/users/mlyle","html_url":"https://github.com/mlyle","followers_url":"https://api.github.com/users/mlyle/followers","following_url":"https://api.github.com/users/mlyle/following{/other_user}","gists_url":"https://api.github.com/users/mlyle/gists{/gist_id}","starred_url":"https://api.github.com/users/mlyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlyle/subscriptions","organizations_url":"https://api.github.com/users/mlyle/orgs","repos_url":"https://api.github.com/users/mlyle/repos","events_url":"https://api.github.com/users/mlyle/events{/privacy}","received_events_url":"https://api.github.com/users/mlyle/received_events","type":"User","site_admin":false},"body":"I missed the parens.  I'm really getting dumb from reading code and gonna stop.","created_at":"2015-09-25T18:08:21Z","updated_at":"2015-09-25T18:08:21Z","html_url":"https://github.com/TauLabs/TauLabs/pull/1965#discussion_r40458599","pull_request_url":"https://api.github.com/repos/TauLabs/TauLabs/pulls/1965","_links":{"self":{"href":"https://api.github.com/repos/TauLabs/TauLabs/pulls/comments/40458599"},"html":{"href":"https://github.com/TauLabs/TauLabs/pull/1965#discussion_r40458599"},"pull_request":{"href":"https://api.github.com/repos/TauLabs/TauLabs/pulls/1965"}}},"pull_request":{"url":"https://api.github.com/repos/TauLabs/TauLabs/pulls/1965","id":46009311,"html_url":"https://github.com/TauLabs/TauLabs/pull/1965","diff_url":"https://github.com/TauLabs/TauLabs/pull/1965.diff","patch_url":"https://github.com/TauLabs/TauLabs/pull/1965.patch","issue_url":"https://api.github.com/repos/TauLabs/TauLabs/issues/1965","number":1965,"state":"open","locked":false,"title":"AltitudeHold: Add support for a separate maximum descent rate","user":{"login":"kubark42","id":1118185,"avatar_url":"https://avatars.githubusercontent.com/u/1118185?v=3","gravatar_id":"","url":"https://api.github.com/users/kubark42","html_url":"https://github.com/kubark42","followers_url":"https://api.github.com/users/kubark42/followers","following_url":"https://api.github.com/users/kubark42/following{/other_user}","gists_url":"https://api.github.com/users/kubark42/gists{/gist_id}","starred_url":"https://api.github.com/users/kubark42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubark42/subscriptions","organizations_url":"https://api.github.com/users/kubark42/orgs","repos_url":"https://api.github.com/users/kubark42/repos","events_url":"https://api.github.com/users/kubark42/events{/privacy}","received_events_url":"https://api.github.com/users/kubark42/received_events","type":"User","site_admin":false},"body":"Previously, maximum climb and descent rates were saved in the same setting. This leads to problems where the maximum climb rate can safely be far higher than the maximum descent rate. This PR simply separates the two and sets a reasonably safe rate for maximum descent.\r\n\r\nTested and confirmed to work.","created_at":"2015-09-25T13:03:57Z","updated_at":"2015-09-25T18:08:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2456fc0189bdb8d19a4ce832459bdfbcd2267e4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TauLabs/TauLabs/pulls/1965/commits","review_comments_url":"https://api.github.com/repos/TauLabs/TauLabs/pulls/1965/comments","review_comment_url":"https://api.github.com/repos/TauLabs/TauLabs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TauLabs/TauLabs/issues/1965/comments","statuses_url":"https://api.github.com/repos/TauLabs/TauLabs/statuses/cbff3faab93894fd754789e809c2cb13c8170acf","head":{"label":"cyphyworks:altitude_hold_descent_rate","ref":"altitude_hold_descent_rate","sha":"cbff3faab93894fd754789e809c2cb13c8170acf","user":{"login":"cyphyworks","id":12955453,"avatar_url":"https://avatars.githubusercontent.com/u/12955453?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphyworks","html_url":"https://github.com/cyphyworks","followers_url":"https://api.github.com/users/cyphyworks/followers","following_url":"https://api.github.com/users/cyphyworks/following{/other_user}","gists_url":"https://api.github.com/users/cyphyworks/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphyworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphyworks/subscriptions","organizations_url":"https://api.github.com/users/cyphyworks/orgs","repos_url":"https://api.github.com/users/cyphyworks/repos","events_url":"https://api.github.com/users/cyphyworks/events{/privacy}","received_events_url":"https://api.github.com/users/cyphyworks/received_events","type":"Organization","site_admin":false},"repo":{"id":41383980,"name":"TauLabs","full_name":"cyphyworks/TauLabs","owner":{"login":"cyphyworks","id":12955453,"avatar_url":"https://avatars.githubusercontent.com/u/12955453?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphyworks","html_url":"https://github.com/cyphyworks","followers_url":"https://api.github.com/users/cyphyworks/followers","following_url":"https://api.github.com/users/cyphyworks/following{/other_user}","gists_url":"https://api.github.com/users/cyphyworks/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphyworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphyworks/subscriptions","organizations_url":"https://api.github.com/users/cyphyworks/orgs","repos_url":"https://api.github.com/users/cyphyworks/repos","events_url":"https://api.github.com/users/cyphyworks/events{/privacy}","received_events_url":"https://api.github.com/users/cyphyworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyphyworks/TauLabs","description":"","fork":true,"url":"https://api.github.com/repos/cyphyworks/TauLabs","forks_url":"https://api.github.com/repos/cyphyworks/TauLabs/forks","keys_url":"https://api.github.com/repos/cyphyworks/TauLabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyphyworks/TauLabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyphyworks/TauLabs/teams","hooks_url":"https://api.github.com/repos/cyphyworks/TauLabs/hooks","issue_events_url":"https://api.github.com/repos/cyphyworks/TauLabs/issues/events{/number}","events_url":"https://api.github.com/repos/cyphyworks/TauLabs/events","assignees_url":"https://api.github.com/repos/cyphyworks/TauLabs/assignees{/user}","branches_url":"https://api.github.com/repos/cyphyworks/TauLabs/branches{/branch}","tags_url":"https://api.github.com/repos/cyphyworks/TauLabs/tags","blobs_url":"https://api.github.com/repos/cyphyworks/TauLabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyphyworks/TauLabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyphyworks/TauLabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyphyworks/TauLabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyphyworks/TauLabs/statuses/{sha}","languages_url":"https://api.github.com/repos/cyphyworks/TauLabs/languages","stargazers_url":"https://api.github.com/repos/cyphyworks/TauLabs/stargazers","contributors_url":"https://api.github.com/repos/cyphyworks/TauLabs/contributors","subscribers_url":"https://api.github.com/repos/cyphyworks/TauLabs/subscribers","subscription_url":"https://api.github.com/repos/cyphyworks/TauLabs/subscription","commits_url":"https://api.github.com/repos/cyphyworks/TauLabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyphyworks/TauLabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyphyworks/TauLabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyphyworks/TauLabs/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyphyworks/TauLabs/contents/{+path}","compare_url":"https://api.github.com/repos/cyphyworks/TauLabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyphyworks/TauLabs/merges","archive_url":"https://api.github.com/repos/cyphyworks/TauLabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyphyworks/TauLabs/downloads","issues_url":"https://api.github.com/repos/cyphyworks/TauLabs/issues{/number}","pulls_url":"https://api.github.com/repos/cyphyworks/TauLabs/pulls{/number}","milestones_url":"https://api.github.com/repos/cyphyworks/TauLabs/milestones{/number}","notifications_url":"https://api.github.com/repos/cyphyworks/TauLabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyphyworks/TauLabs/labels{/name}","releases_url":"https://api.github.com/repos/cyphyworks/TauLabs/releases{/id}","created_at":"2015-08-25T19:37:29Z","updated_at":"2015-08-25T20:03:35Z","pushed_at":"2015-09-25T16:03:39Z","git_url":"git://github.com/cyphyworks/TauLabs.git","ssh_url":"git@github.com:cyphyworks/TauLabs.git","clone_url":"https://github.com/cyphyworks/TauLabs.git","svn_url":"https://github.com/cyphyworks/TauLabs","homepage":"taulabs.org","size":207178,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TauLabs:next","ref":"next","sha":"01fa565e3baefe2ea505fadb42c1c23a0ba46a20","user":{"login":"TauLabs","id":3201381,"avatar_url":"https://avatars.githubusercontent.com/u/3201381?v=3","gravatar_id":"","url":"https://api.github.com/users/TauLabs","html_url":"https://github.com/TauLabs","followers_url":"https://api.github.com/users/TauLabs/followers","following_url":"https://api.github.com/users/TauLabs/following{/other_user}","gists_url":"https://api.github.com/users/TauLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/TauLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TauLabs/subscriptions","organizations_url":"https://api.github.com/users/TauLabs/orgs","repos_url":"https://api.github.com/users/TauLabs/repos","events_url":"https://api.github.com/users/TauLabs/events{/privacy}","received_events_url":"https://api.github.com/users/TauLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":6589168,"name":"TauLabs","full_name":"TauLabs/TauLabs","owner":{"login":"TauLabs","id":3201381,"avatar_url":"https://avatars.githubusercontent.com/u/3201381?v=3","gravatar_id":"","url":"https://api.github.com/users/TauLabs","html_url":"https://github.com/TauLabs","followers_url":"https://api.github.com/users/TauLabs/followers","following_url":"https://api.github.com/users/TauLabs/following{/other_user}","gists_url":"https://api.github.com/users/TauLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/TauLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TauLabs/subscriptions","organizations_url":"https://api.github.com/users/TauLabs/orgs","repos_url":"https://api.github.com/users/TauLabs/repos","events_url":"https://api.github.com/users/TauLabs/events{/privacy}","received_events_url":"https://api.github.com/users/TauLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TauLabs/TauLabs","description":"","fork":false,"url":"https://api.github.com/repos/TauLabs/TauLabs","forks_url":"https://api.github.com/repos/TauLabs/TauLabs/forks","keys_url":"https://api.github.com/repos/TauLabs/TauLabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TauLabs/TauLabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TauLabs/TauLabs/teams","hooks_url":"https://api.github.com/repos/TauLabs/TauLabs/hooks","issue_events_url":"https://api.github.com/repos/TauLabs/TauLabs/issues/events{/number}","events_url":"https://api.github.com/repos/TauLabs/TauLabs/events","assignees_url":"https://api.github.com/repos/TauLabs/TauLabs/assignees{/user}","branches_url":"https://api.github.com/repos/TauLabs/TauLabs/branches{/branch}","tags_url":"https://api.github.com/repos/TauLabs/TauLabs/tags","blobs_url":"https://api.github.com/repos/TauLabs/TauLabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TauLabs/TauLabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TauLabs/TauLabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/TauLabs/TauLabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TauLabs/TauLabs/statuses/{sha}","languages_url":"https://api.github.com/repos/TauLabs/TauLabs/languages","stargazers_url":"https://api.github.com/repos/TauLabs/TauLabs/stargazers","contributors_url":"https://api.github.com/repos/TauLabs/TauLabs/contributors","subscribers_url":"https://api.github.com/repos/TauLabs/TauLabs/subscribers","subscription_url":"https://api.github.com/repos/TauLabs/TauLabs/subscription","commits_url":"https://api.github.com/repos/TauLabs/TauLabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/TauLabs/TauLabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/TauLabs/TauLabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/TauLabs/TauLabs/issues/comments{/number}","contents_url":"https://api.github.com/repos/TauLabs/TauLabs/contents/{+path}","compare_url":"https://api.github.com/repos/TauLabs/TauLabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TauLabs/TauLabs/merges","archive_url":"https://api.github.com/repos/TauLabs/TauLabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TauLabs/TauLabs/downloads","issues_url":"https://api.github.com/repos/TauLabs/TauLabs/issues{/number}","pulls_url":"https://api.github.com/repos/TauLabs/TauLabs/pulls{/number}","milestones_url":"https://api.github.com/repos/TauLabs/TauLabs/milestones{/number}","notifications_url":"https://api.github.com/repos/TauLabs/TauLabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TauLabs/TauLabs/labels{/name}","releases_url":"https://api.github.com/repos/TauLabs/TauLabs/releases{/id}","created_at":"2012-11-08T01:01:18Z","updated_at":"2015-09-23T00:14:21Z","pushed_at":"2015-09-25T17:47:59Z","git_url":"git://github.com/TauLabs/TauLabs.git","ssh_url":"git@github.com:TauLabs/TauLabs.git","clone_url":"https://github.com/TauLabs/TauLabs.git","svn_url":"https://github.com/TauLabs/TauLabs","homepage":"taulabs.org","size":331316,"stargazers_count":269,"watchers_count":269,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":311,"mirror_url":null,"open_issues_count":259,"forks":311,"open_issues":259,"watchers":269,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/TauLabs/TauLabs/pulls/1965"},"html":{"href":"https://github.com/TauLabs/TauLabs/pull/1965"},"issue":{"href":"https://api.github.com/repos/TauLabs/TauLabs/issues/1965"},"comments":{"href":"https://api.github.com/repos/TauLabs/TauLabs/issues/1965/comments"},"review_comments":{"href":"https://api.github.com/repos/TauLabs/TauLabs/pulls/1965/comments"},"review_comment":{"href":"https://api.github.com/repos/TauLabs/TauLabs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TauLabs/TauLabs/pulls/1965/commits"},"statuses":{"href":"https://api.github.com/repos/TauLabs/TauLabs/statuses/cbff3faab93894fd754789e809c2cb13c8170acf"}}}}