{"action":"created","comment":{"url":"https://api.github.com/repos/bokeh/bokeh/pulls/comments/42416408","id":42416408,"diff_hunk":"@@ -269,24 +232,20 @@ def df_from_json(data, **kwargs):\n                 return json_normalize(v)\n \n \n-def nested_dict_iter(nested):\n-    for key, value in iteritems(nested):\n-        if isinstance(value, dict):\n-            for inner_key, inner_value in nested_dict_iter(value):\n-                yield inner_key, inner_value\n-        elif isinstance(value, list):\n-            for item in value:\n-                for k, v in nested_dict_iter(item):\n-                    yield k, v\n-        else:\n-            yield key, value\n-\n-\n def get_index(data):\n-    return pd.Series(data.index.values)\n+    \"\"\"A generic function to return the index from values.\n+\n+    Should be used to abstract away from specific types of data.","path":"bokeh/charts/utils.py","position":160,"original_position":160,"commit_id":"c2f9560f7ba5286c7bb24c90ce1b14c5b3c58a6c","original_commit_id":"c2f9560f7ba5286c7bb24c90ce1b14c5b3c58a6c","user":{"login":"fpliger","id":1084690,"avatar_url":"https://avatars.githubusercontent.com/u/1084690?v=3","gravatar_id":"","url":"https://api.github.com/users/fpliger","html_url":"https://github.com/fpliger","followers_url":"https://api.github.com/users/fpliger/followers","following_url":"https://api.github.com/users/fpliger/following{/other_user}","gists_url":"https://api.github.com/users/fpliger/gists{/gist_id}","starred_url":"https://api.github.com/users/fpliger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpliger/subscriptions","organizations_url":"https://api.github.com/users/fpliger/orgs","repos_url":"https://api.github.com/users/fpliger/repos","events_url":"https://api.github.com/users/fpliger/events{/privacy}","received_events_url":"https://api.github.com/users/fpliger/received_events","type":"User","site_admin":false},"body":"We could add something about what are the supported input types (`data`)","created_at":"2015-10-19T19:44:01Z","updated_at":"2015-10-19T19:44:01Z","html_url":"https://github.com/bokeh/bokeh/pull/2986#discussion_r42416408","pull_request_url":"https://api.github.com/repos/bokeh/bokeh/pulls/2986","_links":{"self":{"href":"https://api.github.com/repos/bokeh/bokeh/pulls/comments/42416408"},"html":{"href":"https://github.com/bokeh/bokeh/pull/2986#discussion_r42416408"},"pull_request":{"href":"https://api.github.com/repos/bokeh/bokeh/pulls/2986"}}},"pull_request":{"url":"https://api.github.com/repos/bokeh/bokeh/pulls/2986","id":47591460,"html_url":"https://github.com/bokeh/bokeh/pull/2986","diff_url":"https://github.com/bokeh/bokeh/pull/2986.diff","patch_url":"https://github.com/bokeh/bokeh/pull/2986.patch","issue_url":"https://api.github.com/repos/bokeh/bokeh/issues/2986","number":2986,"state":"open","locked":false,"title":"Documentation and examples for the new charts interface","user":{"login":"rothnic","id":452052,"avatar_url":"https://avatars.githubusercontent.com/u/452052?v=3","gravatar_id":"","url":"https://api.github.com/users/rothnic","html_url":"https://github.com/rothnic","followers_url":"https://api.github.com/users/rothnic/followers","following_url":"https://api.github.com/users/rothnic/following{/other_user}","gists_url":"https://api.github.com/users/rothnic/gists{/gist_id}","starred_url":"https://api.github.com/users/rothnic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rothnic/subscriptions","organizations_url":"https://api.github.com/users/rothnic/orgs","repos_url":"https://api.github.com/users/rothnic/repos","events_url":"https://api.github.com/users/rothnic/events{/privacy}","received_events_url":"https://api.github.com/users/rothnic/received_events","type":"User","site_admin":false},"body":"The intent of this pr is to address the missing documentation and examples that are broken, or are still using the legacy charts, and can be converted over. This will clean things up a bit and make sure all the base functionality is there before I implement the remaining charts.\r\n\r\nOnly modifications to charts are those that must exist to fix or implement the examples.\r\n\r\nThis will close issue #2975.","created_at":"2015-10-13T21:32:21Z","updated_at":"2015-10-19T19:44:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31868f26a947c780dcdc9bf292d76fbb3f0367ff","assignee":{"login":"rothnic","id":452052,"avatar_url":"https://avatars.githubusercontent.com/u/452052?v=3","gravatar_id":"","url":"https://api.github.com/users/rothnic","html_url":"https://github.com/rothnic","followers_url":"https://api.github.com/users/rothnic/followers","following_url":"https://api.github.com/users/rothnic/following{/other_user}","gists_url":"https://api.github.com/users/rothnic/gists{/gist_id}","starred_url":"https://api.github.com/users/rothnic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rothnic/subscriptions","organizations_url":"https://api.github.com/users/rothnic/orgs","repos_url":"https://api.github.com/users/rothnic/repos","events_url":"https://api.github.com/users/rothnic/events{/privacy}","received_events_url":"https://api.github.com/users/rothnic/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/bokeh/bokeh/pulls/2986/commits","review_comments_url":"https://api.github.com/repos/bokeh/bokeh/pulls/2986/comments","review_comment_url":"https://api.github.com/repos/bokeh/bokeh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bokeh/bokeh/issues/2986/comments","statuses_url":"https://api.github.com/repos/bokeh/bokeh/statuses/c2f9560f7ba5286c7bb24c90ce1b14c5b3c58a6c","head":{"label":"bokeh:feature/new-charts-docs","ref":"feature/new-charts-docs","sha":"c2f9560f7ba5286c7bb24c90ce1b14c5b3c58a6c","user":{"login":"bokeh","id":8440965,"avatar_url":"https://avatars.githubusercontent.com/u/8440965?v=3","gravatar_id":"","url":"https://api.github.com/users/bokeh","html_url":"https://github.com/bokeh","followers_url":"https://api.github.com/users/bokeh/followers","following_url":"https://api.github.com/users/bokeh/following{/other_user}","gists_url":"https://api.github.com/users/bokeh/gists{/gist_id}","starred_url":"https://api.github.com/users/bokeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bokeh/subscriptions","organizations_url":"https://api.github.com/users/bokeh/orgs","repos_url":"https://api.github.com/users/bokeh/repos","events_url":"https://api.github.com/users/bokeh/events{/privacy}","received_events_url":"https://api.github.com/users/bokeh/received_events","type":"Organization","site_admin":false},"repo":{"id":3834332,"name":"bokeh","full_name":"bokeh/bokeh","owner":{"login":"bokeh","id":8440965,"avatar_url":"https://avatars.githubusercontent.com/u/8440965?v=3","gravatar_id":"","url":"https://api.github.com/users/bokeh","html_url":"https://github.com/bokeh","followers_url":"https://api.github.com/users/bokeh/followers","following_url":"https://api.github.com/users/bokeh/following{/other_user}","gists_url":"https://api.github.com/users/bokeh/gists{/gist_id}","starred_url":"https://api.github.com/users/bokeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bokeh/subscriptions","organizations_url":"https://api.github.com/users/bokeh/orgs","repos_url":"https://api.github.com/users/bokeh/repos","events_url":"https://api.github.com/users/bokeh/events{/privacy}","received_events_url":"https://api.github.com/users/bokeh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bokeh/bokeh","description":"Interactive Web Plotting for Python","fork":false,"url":"https://api.github.com/repos/bokeh/bokeh","forks_url":"https://api.github.com/repos/bokeh/bokeh/forks","keys_url":"https://api.github.com/repos/bokeh/bokeh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bokeh/bokeh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bokeh/bokeh/teams","hooks_url":"https://api.github.com/repos/bokeh/bokeh/hooks","issue_events_url":"https://api.github.com/repos/bokeh/bokeh/issues/events{/number}","events_url":"https://api.github.com/repos/bokeh/bokeh/events","assignees_url":"https://api.github.com/repos/bokeh/bokeh/assignees{/user}","branches_url":"https://api.github.com/repos/bokeh/bokeh/branches{/branch}","tags_url":"https://api.github.com/repos/bokeh/bokeh/tags","blobs_url":"https://api.github.com/repos/bokeh/bokeh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bokeh/bokeh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bokeh/bokeh/git/refs{/sha}","trees_url":"https://api.github.com/repos/bokeh/bokeh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bokeh/bokeh/statuses/{sha}","languages_url":"https://api.github.com/repos/bokeh/bokeh/languages","stargazers_url":"https://api.github.com/repos/bokeh/bokeh/stargazers","contributors_url":"https://api.github.com/repos/bokeh/bokeh/contributors","subscribers_url":"https://api.github.com/repos/bokeh/bokeh/subscribers","subscription_url":"https://api.github.com/repos/bokeh/bokeh/subscription","commits_url":"https://api.github.com/repos/bokeh/bokeh/commits{/sha}","git_commits_url":"https://api.github.com/repos/bokeh/bokeh/git/commits{/sha}","comments_url":"https://api.github.com/repos/bokeh/bokeh/comments{/number}","issue_comment_url":"https://api.github.com/repos/bokeh/bokeh/issues/comments{/number}","contents_url":"https://api.github.com/repos/bokeh/bokeh/contents/{+path}","compare_url":"https://api.github.com/repos/bokeh/bokeh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bokeh/bokeh/merges","archive_url":"https://api.github.com/repos/bokeh/bokeh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bokeh/bokeh/downloads","issues_url":"https://api.github.com/repos/bokeh/bokeh/issues{/number}","pulls_url":"https://api.github.com/repos/bokeh/bokeh/pulls{/number}","milestones_url":"https://api.github.com/repos/bokeh/bokeh/milestones{/number}","notifications_url":"https://api.github.com/repos/bokeh/bokeh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bokeh/bokeh/labels{/name}","releases_url":"https://api.github.com/repos/bokeh/bokeh/releases{/id}","created_at":"2012-03-26T15:40:01Z","updated_at":"2015-10-19T14:02:04Z","pushed_at":"2015-10-19T18:50:26Z","git_url":"git://github.com/bokeh/bokeh.git","ssh_url":"git@github.com:bokeh/bokeh.git","clone_url":"https://github.com/bokeh/bokeh.git","svn_url":"https://github.com/bokeh/bokeh","homepage":"http://bokeh.pydata.org/en/latest/","size":169809,"stargazers_count":3338,"watchers_count":3338,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":615,"mirror_url":null,"open_issues_count":553,"forks":615,"open_issues":553,"watchers":3338,"default_branch":"master"}},"base":{"label":"bokeh:master","ref":"master","sha":"92fe8a15cf6d234b4fbadb9b5fe832e86ecf24cc","user":{"login":"bokeh","id":8440965,"avatar_url":"https://avatars.githubusercontent.com/u/8440965?v=3","gravatar_id":"","url":"https://api.github.com/users/bokeh","html_url":"https://github.com/bokeh","followers_url":"https://api.github.com/users/bokeh/followers","following_url":"https://api.github.com/users/bokeh/following{/other_user}","gists_url":"https://api.github.com/users/bokeh/gists{/gist_id}","starred_url":"https://api.github.com/users/bokeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bokeh/subscriptions","organizations_url":"https://api.github.com/users/bokeh/orgs","repos_url":"https://api.github.com/users/bokeh/repos","events_url":"https://api.github.com/users/bokeh/events{/privacy}","received_events_url":"https://api.github.com/users/bokeh/received_events","type":"Organization","site_admin":false},"repo":{"id":3834332,"name":"bokeh","full_name":"bokeh/bokeh","owner":{"login":"bokeh","id":8440965,"avatar_url":"https://avatars.githubusercontent.com/u/8440965?v=3","gravatar_id":"","url":"https://api.github.com/users/bokeh","html_url":"https://github.com/bokeh","followers_url":"https://api.github.com/users/bokeh/followers","following_url":"https://api.github.com/users/bokeh/following{/other_user}","gists_url":"https://api.github.com/users/bokeh/gists{/gist_id}","starred_url":"https://api.github.com/users/bokeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bokeh/subscriptions","organizations_url":"https://api.github.com/users/bokeh/orgs","repos_url":"https://api.github.com/users/bokeh/repos","events_url":"https://api.github.com/users/bokeh/events{/privacy}","received_events_url":"https://api.github.com/users/bokeh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bokeh/bokeh","description":"Interactive Web Plotting for Python","fork":false,"url":"https://api.github.com/repos/bokeh/bokeh","forks_url":"https://api.github.com/repos/bokeh/bokeh/forks","keys_url":"https://api.github.com/repos/bokeh/bokeh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bokeh/bokeh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bokeh/bokeh/teams","hooks_url":"https://api.github.com/repos/bokeh/bokeh/hooks","issue_events_url":"https://api.github.com/repos/bokeh/bokeh/issues/events{/number}","events_url":"https://api.github.com/repos/bokeh/bokeh/events","assignees_url":"https://api.github.com/repos/bokeh/bokeh/assignees{/user}","branches_url":"https://api.github.com/repos/bokeh/bokeh/branches{/branch}","tags_url":"https://api.github.com/repos/bokeh/bokeh/tags","blobs_url":"https://api.github.com/repos/bokeh/bokeh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bokeh/bokeh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bokeh/bokeh/git/refs{/sha}","trees_url":"https://api.github.com/repos/bokeh/bokeh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bokeh/bokeh/statuses/{sha}","languages_url":"https://api.github.com/repos/bokeh/bokeh/languages","stargazers_url":"https://api.github.com/repos/bokeh/bokeh/stargazers","contributors_url":"https://api.github.com/repos/bokeh/bokeh/contributors","subscribers_url":"https://api.github.com/repos/bokeh/bokeh/subscribers","subscription_url":"https://api.github.com/repos/bokeh/bokeh/subscription","commits_url":"https://api.github.com/repos/bokeh/bokeh/commits{/sha}","git_commits_url":"https://api.github.com/repos/bokeh/bokeh/git/commits{/sha}","comments_url":"https://api.github.com/repos/bokeh/bokeh/comments{/number}","issue_comment_url":"https://api.github.com/repos/bokeh/bokeh/issues/comments{/number}","contents_url":"https://api.github.com/repos/bokeh/bokeh/contents/{+path}","compare_url":"https://api.github.com/repos/bokeh/bokeh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bokeh/bokeh/merges","archive_url":"https://api.github.com/repos/bokeh/bokeh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bokeh/bokeh/downloads","issues_url":"https://api.github.com/repos/bokeh/bokeh/issues{/number}","pulls_url":"https://api.github.com/repos/bokeh/bokeh/pulls{/number}","milestones_url":"https://api.github.com/repos/bokeh/bokeh/milestones{/number}","notifications_url":"https://api.github.com/repos/bokeh/bokeh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bokeh/bokeh/labels{/name}","releases_url":"https://api.github.com/repos/bokeh/bokeh/releases{/id}","created_at":"2012-03-26T15:40:01Z","updated_at":"2015-10-19T14:02:04Z","pushed_at":"2015-10-19T18:50:26Z","git_url":"git://github.com/bokeh/bokeh.git","ssh_url":"git@github.com:bokeh/bokeh.git","clone_url":"https://github.com/bokeh/bokeh.git","svn_url":"https://github.com/bokeh/bokeh","homepage":"http://bokeh.pydata.org/en/latest/","size":169809,"stargazers_count":3338,"watchers_count":3338,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":615,"mirror_url":null,"open_issues_count":553,"forks":615,"open_issues":553,"watchers":3338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bokeh/bokeh/pulls/2986"},"html":{"href":"https://github.com/bokeh/bokeh/pull/2986"},"issue":{"href":"https://api.github.com/repos/bokeh/bokeh/issues/2986"},"comments":{"href":"https://api.github.com/repos/bokeh/bokeh/issues/2986/comments"},"review_comments":{"href":"https://api.github.com/repos/bokeh/bokeh/pulls/2986/comments"},"review_comment":{"href":"https://api.github.com/repos/bokeh/bokeh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bokeh/bokeh/pulls/2986/commits"},"statuses":{"href":"https://api.github.com/repos/bokeh/bokeh/statuses/c2f9560f7ba5286c7bb24c90ce1b14c5b3c58a6c"}}}}