{"action":"created","issue":{"url":"https://api.github.com/repos/dimagi/touchforms/issues/139","labels_url":"https://api.github.com/repos/dimagi/touchforms/issues/139/labels{/name}","comments_url":"https://api.github.com/repos/dimagi/touchforms/issues/139/comments","events_url":"https://api.github.com/repos/dimagi/touchforms/issues/139/events","html_url":"https://github.com/dimagi/touchforms/pull/139","id":89955077,"number":139,"title":"WIP refactor to knockout","user":{"login":"benrudolph","id":918514,"avatar_url":"https://avatars.githubusercontent.com/u/918514?v=3","gravatar_id":"","url":"https://api.github.com/users/benrudolph","html_url":"https://github.com/benrudolph","followers_url":"https://api.github.com/users/benrudolph/followers","following_url":"https://api.github.com/users/benrudolph/following{/other_user}","gists_url":"https://api.github.com/users/benrudolph/gists{/gist_id}","starred_url":"https://api.github.com/users/benrudolph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benrudolph/subscriptions","organizations_url":"https://api.github.com/users/benrudolph/orgs","repos_url":"https://api.github.com/users/benrudolph/repos","events_url":"https://api.github.com/users/benrudolph/events{/privacy}","received_events_url":"https://api.github.com/users/benrudolph/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-21T20:16:29Z","updated_at":"2015-06-21T20:19:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dimagi/touchforms/pulls/139","html_url":"https://github.com/dimagi/touchforms/pull/139","diff_url":"https://github.com/dimagi/touchforms/pull/139.diff","patch_url":"https://github.com/dimagi/touchforms/pull/139.patch"},"body":"@czue was inspired this weekend to refactor the javascript to use knockout. i finally feel like i know this code well enough to do so without introducing too many bugs. obviously going to have to go through extensive QA, but this is mostly working. just need to get a few more Entry types ironed out. this is by no means completely how i'd like to have the code, but at least close enough to the point where we can make changes and we'll know if we break something. this also reduce like 50% of the code if you cut out tests and documentation. i'll comment on some of the design decisions throughout to make it more clear. there's also loads of things that i'm pretty sure aren't ever used, that i deleted.  fyi, @dannyroberts may be interested"},"comment":{"url":"https://api.github.com/repos/dimagi/touchforms/issues/comments/113951472","html_url":"https://github.com/dimagi/touchforms/pull/139#issuecomment-113951472","issue_url":"https://api.github.com/repos/dimagi/touchforms/issues/139","id":113951472,"user":{"login":"benrudolph","id":918514,"avatar_url":"https://avatars.githubusercontent.com/u/918514?v=3","gravatar_id":"","url":"https://api.github.com/users/benrudolph","html_url":"https://github.com/benrudolph","followers_url":"https://api.github.com/users/benrudolph/followers","following_url":"https://api.github.com/users/benrudolph/following{/other_user}","gists_url":"https://api.github.com/users/benrudolph/gists{/gist_id}","starred_url":"https://api.github.com/users/benrudolph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benrudolph/subscriptions","organizations_url":"https://api.github.com/users/benrudolph/orgs","repos_url":"https://api.github.com/users/benrudolph/repos","events_url":"https://api.github.com/users/benrudolph/events{/privacy}","received_events_url":"https://api.github.com/users/benrudolph/received_events","type":"User","site_admin":false},"created_at":"2015-06-21T20:19:32Z","updated_at":"2015-06-21T20:19:32Z","body":"oh yea, i ran `JsBeautify` on the files to fix the horrible spacing/tabbing. definitely going to be a ton of dimagimon errors to fix. since i think almost every line was touched"}}