{"action":"closed","number":452,"pull_request":{"url":"https://api.github.com/repos/reactor/reactor/pulls/452","id":31597369,"html_url":"https://github.com/reactor/reactor/pull/452","diff_url":"https://github.com/reactor/reactor/pull/452.diff","patch_url":"https://github.com/reactor/reactor/pull/452.patch","issue_url":"https://api.github.com/repos/reactor/reactor/issues/452","number":452,"state":"closed","locked":false,"title":"Issue 451 - Stream.partition(int) creates more partitions than requested","user":{"login":"lukejackson","id":69290,"avatar_url":"https://avatars.githubusercontent.com/u/69290?v=3","gravatar_id":"","url":"https://api.github.com/users/lukejackson","html_url":"https://github.com/lukejackson","followers_url":"https://api.github.com/users/lukejackson/followers","following_url":"https://api.github.com/users/lukejackson/following{/other_user}","gists_url":"https://api.github.com/users/lukejackson/gists{/gist_id}","starred_url":"https://api.github.com/users/lukejackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukejackson/subscriptions","organizations_url":"https://api.github.com/users/lukejackson/orgs","repos_url":"https://api.github.com/users/lukejackson/repos","events_url":"https://api.github.com/users/lukejackson/events{/privacy}","received_events_url":"https://api.github.com/users/lukejackson/received_events","type":"User","site_admin":false},"body":"This fix prevents negative hashCodes resulting in negative partition numbers (see https://github.com/reactor/reactor/issues/451)\r\n\r\nAt the same time, when writing the test, I found it impossible to count the partitions because when the input stream completed, the stream of partitioned streams did not complete. I've made a change to fix this, but not being familiar with this code, it needs review.","created_at":"2015-03-20T09:04:06Z","updated_at":"2015-03-20T11:42:18Z","closed_at":"2015-03-20T11:42:18Z","merged_at":"2015-03-20T11:42:18Z","merge_commit_sha":"7a56f153d1aee8620811e4856bc4d9b492132c58","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/reactor/reactor/pulls/452/commits","review_comments_url":"https://api.github.com/repos/reactor/reactor/pulls/452/comments","review_comment_url":"https://api.github.com/repos/reactor/reactor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactor/reactor/issues/452/comments","statuses_url":"https://api.github.com/repos/reactor/reactor/statuses/d6f597af48329a7b9375c8fb554e65101b68baa2","head":{"label":"lukejackson:issue-451","ref":"issue-451","sha":"d6f597af48329a7b9375c8fb554e65101b68baa2","user":{"login":"lukejackson","id":69290,"avatar_url":"https://avatars.githubusercontent.com/u/69290?v=3","gravatar_id":"","url":"https://api.github.com/users/lukejackson","html_url":"https://github.com/lukejackson","followers_url":"https://api.github.com/users/lukejackson/followers","following_url":"https://api.github.com/users/lukejackson/following{/other_user}","gists_url":"https://api.github.com/users/lukejackson/gists{/gist_id}","starred_url":"https://api.github.com/users/lukejackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukejackson/subscriptions","organizations_url":"https://api.github.com/users/lukejackson/orgs","repos_url":"https://api.github.com/users/lukejackson/repos","events_url":"https://api.github.com/users/lukejackson/events{/privacy}","received_events_url":"https://api.github.com/users/lukejackson/received_events","type":"User","site_admin":false},"repo":{"id":32382838,"name":"reactor","full_name":"lukejackson/reactor","owner":{"login":"lukejackson","id":69290,"avatar_url":"https://avatars.githubusercontent.com/u/69290?v=3","gravatar_id":"","url":"https://api.github.com/users/lukejackson","html_url":"https://github.com/lukejackson","followers_url":"https://api.github.com/users/lukejackson/followers","following_url":"https://api.github.com/users/lukejackson/following{/other_user}","gists_url":"https://api.github.com/users/lukejackson/gists{/gist_id}","starred_url":"https://api.github.com/users/lukejackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukejackson/subscriptions","organizations_url":"https://api.github.com/users/lukejackson/orgs","repos_url":"https://api.github.com/users/lukejackson/repos","events_url":"https://api.github.com/users/lukejackson/events{/privacy}","received_events_url":"https://api.github.com/users/lukejackson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukejackson/reactor","description":"Reactor is a foundational library for building reactive fast-data applications on the JVM.","fork":true,"url":"https://api.github.com/repos/lukejackson/reactor","forks_url":"https://api.github.com/repos/lukejackson/reactor/forks","keys_url":"https://api.github.com/repos/lukejackson/reactor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukejackson/reactor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukejackson/reactor/teams","hooks_url":"https://api.github.com/repos/lukejackson/reactor/hooks","issue_events_url":"https://api.github.com/repos/lukejackson/reactor/issues/events{/number}","events_url":"https://api.github.com/repos/lukejackson/reactor/events","assignees_url":"https://api.github.com/repos/lukejackson/reactor/assignees{/user}","branches_url":"https://api.github.com/repos/lukejackson/reactor/branches{/branch}","tags_url":"https://api.github.com/repos/lukejackson/reactor/tags","blobs_url":"https://api.github.com/repos/lukejackson/reactor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukejackson/reactor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukejackson/reactor/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukejackson/reactor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukejackson/reactor/statuses/{sha}","languages_url":"https://api.github.com/repos/lukejackson/reactor/languages","stargazers_url":"https://api.github.com/repos/lukejackson/reactor/stargazers","contributors_url":"https://api.github.com/repos/lukejackson/reactor/contributors","subscribers_url":"https://api.github.com/repos/lukejackson/reactor/subscribers","subscription_url":"https://api.github.com/repos/lukejackson/reactor/subscription","commits_url":"https://api.github.com/repos/lukejackson/reactor/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukejackson/reactor/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukejackson/reactor/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukejackson/reactor/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukejackson/reactor/contents/{+path}","compare_url":"https://api.github.com/repos/lukejackson/reactor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukejackson/reactor/merges","archive_url":"https://api.github.com/repos/lukejackson/reactor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukejackson/reactor/downloads","issues_url":"https://api.github.com/repos/lukejackson/reactor/issues{/number}","pulls_url":"https://api.github.com/repos/lukejackson/reactor/pulls{/number}","milestones_url":"https://api.github.com/repos/lukejackson/reactor/milestones{/number}","notifications_url":"https://api.github.com/repos/lukejackson/reactor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukejackson/reactor/labels{/name}","releases_url":"https://api.github.com/repos/lukejackson/reactor/releases{/id}","created_at":"2015-03-17T09:13:46Z","updated_at":"2015-03-17T09:13:47Z","pushed_at":"2015-03-20T09:00:15Z","git_url":"git://github.com/lukejackson/reactor.git","ssh_url":"git@github.com:lukejackson/reactor.git","clone_url":"https://github.com/lukejackson/reactor.git","svn_url":"https://github.com/lukejackson/reactor","homepage":"http://projectreactor.io/","size":7650,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reactor:master","ref":"master","sha":"bb65981f70b8edc2b42d6d918433f4fcd3fa6d27","user":{"login":"reactor","id":4201559,"avatar_url":"https://avatars.githubusercontent.com/u/4201559?v=3","gravatar_id":"","url":"https://api.github.com/users/reactor","html_url":"https://github.com/reactor","followers_url":"https://api.github.com/users/reactor/followers","following_url":"https://api.github.com/users/reactor/following{/other_user}","gists_url":"https://api.github.com/users/reactor/gists{/gist_id}","starred_url":"https://api.github.com/users/reactor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactor/subscriptions","organizations_url":"https://api.github.com/users/reactor/orgs","repos_url":"https://api.github.com/users/reactor/repos","events_url":"https://api.github.com/users/reactor/events{/privacy}","received_events_url":"https://api.github.com/users/reactor/received_events","type":"Organization","site_admin":false},"repo":{"id":9609018,"name":"reactor","full_name":"reactor/reactor","owner":{"login":"reactor","id":4201559,"avatar_url":"https://avatars.githubusercontent.com/u/4201559?v=3","gravatar_id":"","url":"https://api.github.com/users/reactor","html_url":"https://github.com/reactor","followers_url":"https://api.github.com/users/reactor/followers","following_url":"https://api.github.com/users/reactor/following{/other_user}","gists_url":"https://api.github.com/users/reactor/gists{/gist_id}","starred_url":"https://api.github.com/users/reactor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactor/subscriptions","organizations_url":"https://api.github.com/users/reactor/orgs","repos_url":"https://api.github.com/users/reactor/repos","events_url":"https://api.github.com/users/reactor/events{/privacy}","received_events_url":"https://api.github.com/users/reactor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactor/reactor","description":"Reactor is a foundational library for building reactive fast-data applications on the JVM.","fork":false,"url":"https://api.github.com/repos/reactor/reactor","forks_url":"https://api.github.com/repos/reactor/reactor/forks","keys_url":"https://api.github.com/repos/reactor/reactor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactor/reactor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactor/reactor/teams","hooks_url":"https://api.github.com/repos/reactor/reactor/hooks","issue_events_url":"https://api.github.com/repos/reactor/reactor/issues/events{/number}","events_url":"https://api.github.com/repos/reactor/reactor/events","assignees_url":"https://api.github.com/repos/reactor/reactor/assignees{/user}","branches_url":"https://api.github.com/repos/reactor/reactor/branches{/branch}","tags_url":"https://api.github.com/repos/reactor/reactor/tags","blobs_url":"https://api.github.com/repos/reactor/reactor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactor/reactor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactor/reactor/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactor/reactor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactor/reactor/statuses/{sha}","languages_url":"https://api.github.com/repos/reactor/reactor/languages","stargazers_url":"https://api.github.com/repos/reactor/reactor/stargazers","contributors_url":"https://api.github.com/repos/reactor/reactor/contributors","subscribers_url":"https://api.github.com/repos/reactor/reactor/subscribers","subscription_url":"https://api.github.com/repos/reactor/reactor/subscription","commits_url":"https://api.github.com/repos/reactor/reactor/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactor/reactor/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactor/reactor/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactor/reactor/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactor/reactor/contents/{+path}","compare_url":"https://api.github.com/repos/reactor/reactor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactor/reactor/merges","archive_url":"https://api.github.com/repos/reactor/reactor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactor/reactor/downloads","issues_url":"https://api.github.com/repos/reactor/reactor/issues{/number}","pulls_url":"https://api.github.com/repos/reactor/reactor/pulls{/number}","milestones_url":"https://api.github.com/repos/reactor/reactor/milestones{/number}","notifications_url":"https://api.github.com/repos/reactor/reactor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactor/reactor/labels{/name}","releases_url":"https://api.github.com/repos/reactor/reactor/releases{/id}","created_at":"2013-04-22T21:10:05Z","updated_at":"2015-03-20T06:36:07Z","pushed_at":"2015-03-20T11:42:18Z","git_url":"git://github.com/reactor/reactor.git","ssh_url":"git@github.com:reactor/reactor.git","clone_url":"https://github.com/reactor/reactor.git","svn_url":"https://github.com/reactor/reactor","homepage":"http://projectreactor.io/","size":15169,"stargazers_count":1421,"watchers_count":1421,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":264,"mirror_url":null,"open_issues_count":98,"forks":264,"open_issues":98,"watchers":1421,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactor/reactor/pulls/452"},"html":{"href":"https://github.com/reactor/reactor/pull/452"},"issue":{"href":"https://api.github.com/repos/reactor/reactor/issues/452"},"comments":{"href":"https://api.github.com/repos/reactor/reactor/issues/452/comments"},"review_comments":{"href":"https://api.github.com/repos/reactor/reactor/pulls/452/comments"},"review_comment":{"href":"https://api.github.com/repos/reactor/reactor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactor/reactor/pulls/452/commits"},"statuses":{"href":"https://api.github.com/repos/reactor/reactor/statuses/d6f597af48329a7b9375c8fb554e65101b68baa2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"smaldini","id":76718,"avatar_url":"https://avatars.githubusercontent.com/u/76718?v=3","gravatar_id":"","url":"https://api.github.com/users/smaldini","html_url":"https://github.com/smaldini","followers_url":"https://api.github.com/users/smaldini/followers","following_url":"https://api.github.com/users/smaldini/following{/other_user}","gists_url":"https://api.github.com/users/smaldini/gists{/gist_id}","starred_url":"https://api.github.com/users/smaldini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smaldini/subscriptions","organizations_url":"https://api.github.com/users/smaldini/orgs","repos_url":"https://api.github.com/users/smaldini/repos","events_url":"https://api.github.com/users/smaldini/events{/privacy}","received_events_url":"https://api.github.com/users/smaldini/received_events","type":"User","site_admin":false},"comments":0,"review_comments":4,"commits":2,"additions":52,"deletions":57,"changed_files":3}}