{"action":"created","issue":{"url":"https://api.github.com/repos/kogmbh/WebODF/issues/862","labels_url":"https://api.github.com/repos/kogmbh/WebODF/issues/862/labels{/name}","comments_url":"https://api.github.com/repos/kogmbh/WebODF/issues/862/comments","events_url":"https://api.github.com/repos/kogmbh/WebODF/issues/862/events","html_url":"https://github.com/kogmbh/WebODF/pull/862","id":55625173,"number":862,"title":"Block browser translation service from translating content (wodo-only)","user":{"login":"kossebau","id":4068037,"avatar_url":"https://avatars.githubusercontent.com/u/4068037?v=3","gravatar_id":"","url":"https://api.github.com/users/kossebau","html_url":"https://github.com/kossebau","followers_url":"https://api.github.com/users/kossebau/followers","following_url":"https://api.github.com/users/kossebau/following{/other_user}","gists_url":"https://api.github.com/users/kossebau/gists{/gist_id}","starred_url":"https://api.github.com/users/kossebau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kossebau/subscriptions","organizations_url":"https://api.github.com/users/kossebau/orgs","repos_url":"https://api.github.com/users/kossebau/repos","events_url":"https://api.github.com/users/kossebau/events{/privacy}","received_events_url":"https://api.github.com/users/kossebau/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-01-27T14:37:50Z","updated_at":"2015-01-27T23:12:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kogmbh/WebODF/pulls/862","html_url":"https://github.com/kogmbh/WebODF/pull/862","diff_url":"https://github.com/kogmbh/WebODF/pull/862.diff","patch_url":"https://github.com/kogmbh/WebODF/pull/862.patch"},"body":"As reported in #796, browser translation services mess up the step caches.\r\n\r\nThe initial proposal was to just tell the user to properly tag the webpage. But then we could just set the proper flags ourselves.\r\n\r\nDecided to protect from translation just\r\n* the canvas with the actual document \r\n* the UI elements with ids of fonts and paragraph styles, as rendered into HTML\r\n\r\nThe rest of the editor UI might be handy to get translated as well, if a user willingly decides to let the browser translate it.\r\nThe content of `<input>` elements does not get translated from what I tested with chromium, that would also be strange. So this patch does not also tag those where document content is displayed/edited in the UI (e.g. with the hyperlinks).\r\n\r\nNot sure how the protection of the canvas could be solved in general, as there is no unique entry point for an editor-only canvas. And for display-only a WebODF-deploying dev might want to allow translation of the document content. Or does that mess too much with the ODF structure?\r\n\r\nThis is at least a first fix that should go in for 0.5.5 IMHO. Can be still improved later."},"comment":{"url":"https://api.github.com/repos/kogmbh/WebODF/issues/comments/71748802","html_url":"https://github.com/kogmbh/WebODF/pull/862#issuecomment-71748802","issue_url":"https://api.github.com/repos/kogmbh/WebODF/issues/862","id":71748802,"user":{"login":"adityab","id":591038,"avatar_url":"https://avatars.githubusercontent.com/u/591038?v=3","gravatar_id":"","url":"https://api.github.com/users/adityab","html_url":"https://github.com/adityab","followers_url":"https://api.github.com/users/adityab/followers","following_url":"https://api.github.com/users/adityab/following{/other_user}","gists_url":"https://api.github.com/users/adityab/gists{/gist_id}","starred_url":"https://api.github.com/users/adityab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityab/subscriptions","organizations_url":"https://api.github.com/users/adityab/orgs","repos_url":"https://api.github.com/users/adityab/repos","events_url":"https://api.github.com/users/adityab/events{/privacy}","received_events_url":"https://api.github.com/users/adityab/received_events","type":"User","site_admin":false},"created_at":"2015-01-27T23:12:40Z","updated_at":"2015-01-27T23:12:40Z","body":"Looks good to me. Ship it!"}}