{"action":"created","issue":{"url":"https://api.github.com/repos/ef4/liquid-fire/issues/233","labels_url":"https://api.github.com/repos/ef4/liquid-fire/issues/233/labels{/name}","comments_url":"https://api.github.com/repos/ef4/liquid-fire/issues/233/comments","events_url":"https://api.github.com/repos/ef4/liquid-fire/issues/233/events","html_url":"https://github.com/ef4/liquid-fire/issues/233","id":66285304,"number":233,"title":"Error in explode.js","user":{"login":"albertodotcom","id":2559136,"avatar_url":"https://avatars.githubusercontent.com/u/2559136?v=3","gravatar_id":"","url":"https://api.github.com/users/albertodotcom","html_url":"https://github.com/albertodotcom","followers_url":"https://api.github.com/users/albertodotcom/followers","following_url":"https://api.github.com/users/albertodotcom/following{/other_user}","gists_url":"https://api.github.com/users/albertodotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/albertodotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertodotcom/subscriptions","organizations_url":"https://api.github.com/users/albertodotcom/orgs","repos_url":"https://api.github.com/users/albertodotcom/repos","events_url":"https://api.github.com/users/albertodotcom/events{/privacy}","received_events_url":"https://api.github.com/users/albertodotcom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-04T07:12:39Z","updated_at":"2015-04-04T08:47:22Z","closed_at":null,"body":"While testing this amazing library I found an issue with explode and [matchBy] (https://github.com/ef4/liquid-fire/blob/master/app/transitions/explode.js#L127)\r\n\r\nIn my templates I've added a data attribute `data-post-title`.\r\nAnd my `transitions.js` looks like this\r\n```javascript\r\n  this.transition(\r\n    this.fromRoute('posts'),\r\n    this.toRoute('post'),\r\n    this.use('explode', {\r\n      matchBy: 'data-post-title',\r\n      use: 'flyTo'\r\n    }, {\r\n      use: 'toLeft'\r\n    }),\r\n    this.reverse('toRight')\r\n  );\r\n```\r\n\r\nThis setup triggers `Syntax error, unrecognized expression: [data-post-title=]`\r\n\r\nI would like to contribute and submit a PR to fix it.\r\nI also think that it could be helpful being able to use `classes` and `ids` in addition to `data-attributes`."},"comment":{"url":"https://api.github.com/repos/ef4/liquid-fire/issues/comments/89529971","html_url":"https://github.com/ef4/liquid-fire/issues/233#issuecomment-89529971","issue_url":"https://api.github.com/repos/ef4/liquid-fire/issues/233","id":89529971,"user":{"login":"ef4","id":319282,"avatar_url":"https://avatars.githubusercontent.com/u/319282?v=3","gravatar_id":"","url":"https://api.github.com/users/ef4","html_url":"https://github.com/ef4","followers_url":"https://api.github.com/users/ef4/followers","following_url":"https://api.github.com/users/ef4/following{/other_user}","gists_url":"https://api.github.com/users/ef4/gists{/gist_id}","starred_url":"https://api.github.com/users/ef4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ef4/subscriptions","organizations_url":"https://api.github.com/users/ef4/orgs","repos_url":"https://api.github.com/users/ef4/repos","events_url":"https://api.github.com/users/ef4/events{/privacy}","received_events_url":"https://api.github.com/users/ef4/received_events","type":"User","site_admin":false},"created_at":"2015-04-04T08:47:21Z","updated_at":"2015-04-04T08:47:21Z","body":"Thanks, please do. It looks like we're probably not doing the right thing if we find an element in the old view that has the attribute present but null.\r\n\r\nI agree that `matchBy: 'class'` and `matchBy: 'id'` would be good. \r\n\r\nWe should probably make them work in combination with `pick/pickOld/pickNew` so that you can use `pick` (or `pickOld` and `pickNew`) to limit the set of stuff that matchBy will search through.\r\n\r\nSo `pick: '.post', matchBy: 'id'` would first find everything with class=\"post\" in both the old and new views, and then try to pair them up by ids.\r\n\r\nI just pushed a docs update that explains how all of these work as of now: http://ef4.github.io/liquid-fire/#/transitions/explode"}}