{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/41891943","id":41891943,"diff_hunk":"@@ -57,30 +57,31 @@\n \n (deftest database-configuration\n   (testing \"database\"\n-    (testing \"validate-db-settings\"\n-      (let [cfg {:database {:classname \"foo\" :subprotocol \"bar\" :subname \"baz\"}}]\n-        (is (= cfg (validate-db-settings cfg))))\n-      (is (thrown+-with-msg? [:type ::conf/cli-error]\n-                             #\"database configuration is now required.* classname = .* subprotocol = .* subname = .*\"\n-                             (validate-db-settings {})))\n-      (let [settings [:classname :subprotocol :subname]]\n-        (doseq [x settings]\n-          (let [other-settings (remove #(= % x) settings)\n-                cfg-rx (re-pattern\n-                        (apply str \"database configuration is now required.*\"\n-                               (map #(str \" \" (name %) \" = .*\")\n-                                    other-settings)))]\n-            ;; Make sure the message contains settings for all but x.\n-            (is (thrown+-with-msg? [:type ::conf/cli-error]\n-                                   cfg-rx\n-                                   (validate-db-settings {x \"foo\"})))\n-            ;; Make sure the message doesn't contain a setting for x.\n-            (is (try+\n-                 (validate-db-settings {:database {x \"foo\"}})\n-                 true\n-                 (catch [:type ::conf/cli-error] {:keys [message]}\n-                   (not (re-find (re-pattern (str \" \" (name x) \" = \"))\n-                                 message)))))))))\n+    (let [cfg {:database {:classname \"org.postgresql.Driver\"","path":"test/puppetlabs/puppetdb/config_test.clj","position":28,"original_position":28,"commit_id":"4b3fd4e7544b4204cfabeed8762cf68eb4f92411","original_commit_id":"4b3fd4e7544b4204cfabeed8762cf68eb4f92411","user":{"login":"ajroetker","id":3198124,"avatar_url":"https://avatars.githubusercontent.com/u/3198124?v=3","gravatar_id":"","url":"https://api.github.com/users/ajroetker","html_url":"https://github.com/ajroetker","followers_url":"https://api.github.com/users/ajroetker/followers","following_url":"https://api.github.com/users/ajroetker/following{/other_user}","gists_url":"https://api.github.com/users/ajroetker/gists{/gist_id}","starred_url":"https://api.github.com/users/ajroetker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajroetker/subscriptions","organizations_url":"https://api.github.com/users/ajroetker/orgs","repos_url":"https://api.github.com/users/ajroetker/repos","events_url":"https://api.github.com/users/ajroetker/events{/privacy}","received_events_url":"https://api.github.com/users/ajroetker/received_events","type":"User","site_admin":false},"body":"Could we also add some tests for the HSQLDB case just, would be helpful just to know what we expect to happen?","created_at":"2015-10-13T16:42:18Z","updated_at":"2015-10-13T16:42:18Z","html_url":"https://github.com/puppetlabs/puppetdb/pull/1659#discussion_r41891943","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1659","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/41891943"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1659#discussion_r41891943"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1659"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1659","id":46205866,"html_url":"https://github.com/puppetlabs/puppetdb/pull/1659","diff_url":"https://github.com/puppetlabs/puppetdb/pull/1659.diff","patch_url":"https://github.com/puppetlabs/puppetdb/pull/1659.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1659","number":1659,"state":"open","locked":false,"title":"(PDB-1996) Remove HSQLDB support","user":{"login":"rbrw","id":10120698,"avatar_url":"https://avatars.githubusercontent.com/u/10120698?v=3","gravatar_id":"","url":"https://api.github.com/users/rbrw","html_url":"https://github.com/rbrw","followers_url":"https://api.github.com/users/rbrw/followers","following_url":"https://api.github.com/users/rbrw/following{/other_user}","gists_url":"https://api.github.com/users/rbrw/gists{/gist_id}","starred_url":"https://api.github.com/users/rbrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbrw/subscriptions","organizations_url":"https://api.github.com/users/rbrw/orgs","repos_url":"https://api.github.com/users/rbrw/repos","events_url":"https://api.github.com/users/rbrw/events{/privacy}","received_events_url":"https://api.github.com/users/rbrw/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-28T20:45:41Z","updated_at":"2015-10-13T16:42:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba1ea7edb0bdf1e3cba5e6bdff41bf03d2e2ae01","assignee":null,"milestone":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/milestones/11","html_url":"https://github.com/puppetlabs/puppetdb/milestones/4.0.0%20(master)","labels_url":"https://api.github.com/repos/puppetlabs/puppetdb/milestones/11/labels","id":1341713,"number":11,"title":"4.0.0 (master)","description":"","creator":{"login":"kbarber","id":80595,"avatar_url":"https://avatars.githubusercontent.com/u/80595?v=3","gravatar_id":"","url":"https://api.github.com/users/kbarber","html_url":"https://github.com/kbarber","followers_url":"https://api.github.com/users/kbarber/followers","following_url":"https://api.github.com/users/kbarber/following{/other_user}","gists_url":"https://api.github.com/users/kbarber/gists{/gist_id}","starred_url":"https://api.github.com/users/kbarber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbarber/subscriptions","organizations_url":"https://api.github.com/users/kbarber/orgs","repos_url":"https://api.github.com/users/kbarber/repos","events_url":"https://api.github.com/users/kbarber/events{/privacy}","received_events_url":"https://api.github.com/users/kbarber/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":8,"state":"open","created_at":"2015-10-07T01:07:44Z","updated_at":"2015-10-13T15:14:36Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1659/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1659/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1659/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/4b3fd4e7544b4204cfabeed8762cf68eb4f92411","head":{"label":"rbrw:ticket/master/pdb-1996-purge-hsqldb","ref":"ticket/master/pdb-1996-purge-hsqldb","sha":"4b3fd4e7544b4204cfabeed8762cf68eb4f92411","user":{"login":"rbrw","id":10120698,"avatar_url":"https://avatars.githubusercontent.com/u/10120698?v=3","gravatar_id":"","url":"https://api.github.com/users/rbrw","html_url":"https://github.com/rbrw","followers_url":"https://api.github.com/users/rbrw/followers","following_url":"https://api.github.com/users/rbrw/following{/other_user}","gists_url":"https://api.github.com/users/rbrw/gists{/gist_id}","starred_url":"https://api.github.com/users/rbrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbrw/subscriptions","organizations_url":"https://api.github.com/users/rbrw/orgs","repos_url":"https://api.github.com/users/rbrw/repos","events_url":"https://api.github.com/users/rbrw/events{/privacy}","received_events_url":"https://api.github.com/users/rbrw/received_events","type":"User","site_admin":false},"repo":{"id":27739513,"name":"puppetdb","full_name":"rbrw/puppetdb","owner":{"login":"rbrw","id":10120698,"avatar_url":"https://avatars.githubusercontent.com/u/10120698?v=3","gravatar_id":"","url":"https://api.github.com/users/rbrw","html_url":"https://github.com/rbrw","followers_url":"https://api.github.com/users/rbrw/followers","following_url":"https://api.github.com/users/rbrw/following{/other_user}","gists_url":"https://api.github.com/users/rbrw/gists{/gist_id}","starred_url":"https://api.github.com/users/rbrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbrw/subscriptions","organizations_url":"https://api.github.com/users/rbrw/orgs","repos_url":"https://api.github.com/users/rbrw/repos","events_url":"https://api.github.com/users/rbrw/events{/privacy}","received_events_url":"https://api.github.com/users/rbrw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rbrw/puppetdb","description":"Centralized Puppet Storage","fork":true,"url":"https://api.github.com/repos/rbrw/puppetdb","forks_url":"https://api.github.com/repos/rbrw/puppetdb/forks","keys_url":"https://api.github.com/repos/rbrw/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rbrw/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rbrw/puppetdb/teams","hooks_url":"https://api.github.com/repos/rbrw/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/rbrw/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/rbrw/puppetdb/events","assignees_url":"https://api.github.com/repos/rbrw/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/rbrw/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/rbrw/puppetdb/tags","blobs_url":"https://api.github.com/repos/rbrw/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rbrw/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rbrw/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/rbrw/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rbrw/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/rbrw/puppetdb/languages","stargazers_url":"https://api.github.com/repos/rbrw/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/rbrw/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/rbrw/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/rbrw/puppetdb/subscription","commits_url":"https://api.github.com/repos/rbrw/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/rbrw/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/rbrw/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/rbrw/puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/rbrw/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/rbrw/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rbrw/puppetdb/merges","archive_url":"https://api.github.com/repos/rbrw/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rbrw/puppetdb/downloads","issues_url":"https://api.github.com/repos/rbrw/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/rbrw/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/rbrw/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/rbrw/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rbrw/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/rbrw/puppetdb/releases{/id}","created_at":"2014-12-08T23:03:46Z","updated_at":"2014-12-08T23:03:47Z","pushed_at":"2015-10-12T18:35:38Z","git_url":"git://github.com/rbrw/puppetdb.git","ssh_url":"git@github.com:rbrw/puppetdb.git","clone_url":"https://github.com/rbrw/puppetdb.git","svn_url":"https://github.com/rbrw/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":15282,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"ee52b9195f48d838f40997b3e8613e00d8eced95","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2193032,"name":"puppetdb","full_name":"puppetlabs/puppetdb","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetdb","description":"Centralized Puppet Storage","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetdb","forks_url":"https://api.github.com/repos/puppetlabs/puppetdb/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetdb/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetdb/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetdb/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetdb/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetdb/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetdb/releases{/id}","created_at":"2011-08-11T18:54:46Z","updated_at":"2015-10-09T03:29:13Z","pushed_at":"2015-10-13T16:22:23Z","git_url":"git://github.com/puppetlabs/puppetdb.git","ssh_url":"git@github.com:puppetlabs/puppetdb.git","clone_url":"https://github.com/puppetlabs/puppetdb.git","svn_url":"https://github.com/puppetlabs/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":23448,"stargazers_count":173,"watchers_count":173,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":138,"mirror_url":null,"open_issues_count":9,"forks":138,"open_issues":9,"watchers":173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1659"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1659"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1659"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1659/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1659/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1659/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/4b3fd4e7544b4204cfabeed8762cf68eb4f92411"}}}}