{"action":"created","comment":{"url":"https://api.github.com/repos/weaveworks/weave/pulls/comments/32006788","id":32006788,"diff_hunk":"@@ -575,9 +576,18 @@ wait_for_status_ip() {\n     done\n }\n \n-wait_for_status() {\n-    container_ip $1 \"$1 container has died.\" \"$1 container has died.\" || return 1\n-    wait_for_status_ip $1 $CONTAINER_IP $2\n+# Wait until container $1 outputs a line containing $2 in its log\n+wait_for_log() {\n+    fifo=/tmp/tmpfifo.$$\n+    mkfifo $fifo || exit 1\n+    docker logs -f $1 2>/dev/null >$fifo &","path":"weave","position":28,"original_position":28,"commit_id":"989be4a79cb9bb89344c5ecb57d9697eeb7f5ffc","original_commit_id":"989be4a79cb9bb89344c5ecb57d9697eeb7f5ffc","user":{"login":"rade","id":109109,"avatar_url":"https://avatars.githubusercontent.com/u/109109?v=3","gravatar_id":"","url":"https://api.github.com/users/rade","html_url":"https://github.com/rade","followers_url":"https://api.github.com/users/rade/followers","following_url":"https://api.github.com/users/rade/following{/other_user}","gists_url":"https://api.github.com/users/rade/gists{/gist_id}","starred_url":"https://api.github.com/users/rade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rade/subscriptions","organizations_url":"https://api.github.com/users/rade/orgs","repos_url":"https://api.github.com/users/rade/repos","events_url":"https://api.github.com/users/rade/events{/privacy}","received_events_url":"https://api.github.com/users/rade/received_events","type":"User","site_admin":false},"body":"I thought you were talking about the proxy container.\r\n\r\nBut this reminds me, we need to test this with `weave --local`.","created_at":"2015-06-09T12:24:12Z","updated_at":"2015-06-09T12:24:12Z","html_url":"https://github.com/weaveworks/weave/pull/878#discussion_r32006788","pull_request_url":"https://api.github.com/repos/weaveworks/weave/pulls/878","_links":{"self":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/comments/32006788"},"html":{"href":"https://github.com/weaveworks/weave/pull/878#discussion_r32006788"},"pull_request":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/878"}}},"pull_request":{"url":"https://api.github.com/repos/weaveworks/weave/pulls/878","id":37192886,"html_url":"https://github.com/weaveworks/weave/pull/878","diff_url":"https://github.com/weaveworks/weave/pull/878.diff","patch_url":"https://github.com/weaveworks/weave/pull/878.patch","issue_url":"https://api.github.com/repos/weaveworks/weave/issues/878","number":878,"state":"open","locked":false,"title":"remove most of proxy status","user":{"login":"rade","id":109109,"avatar_url":"https://avatars.githubusercontent.com/u/109109?v=3","gravatar_id":"","url":"https://api.github.com/users/rade","html_url":"https://github.com/rade","followers_url":"https://api.github.com/users/rade/followers","following_url":"https://api.github.com/users/rade/following{/other_user}","gists_url":"https://api.github.com/users/rade/gists{/gist_id}","starred_url":"https://api.github.com/users/rade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rade/subscriptions","organizations_url":"https://api.github.com/users/rade/orgs","repos_url":"https://api.github.com/users/rade/repos","events_url":"https://api.github.com/users/rade/events{/privacy}","received_events_url":"https://api.github.com/users/rade/received_events","type":"User","site_admin":false},"body":"There are two problems with obtaining the proxy status via the normal\r\nproxy endpoint...\r\n\r\n1. when TLS is enabled, this requires using TLS at the client end\r\n\r\n2. the status URL is mixed in with the docker remote API, which is\r\nrather unclean\r\n\r\nThere is limited value to having some status output from the proxy,\r\nsince all the output is constant.\r\n\r\nSo instead we log the version and command line args.\r\n\r\nWe still want a way to wait for the proxy to start up, and log a nice\r\nerror if it dies. We do this by polling the docker logs for a startup\r\nmessage.\r\n\r\nFixes #877. Fixes #876.\r\n\r\nUndoes #756, #800, #854.","created_at":"2015-06-08T20:33:19Z","updated_at":"2015-06-09T12:24:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56df7d65d35a3fd49542ec4bccb0ec21dbd59d3a","assignee":{"login":"paulbellamy","id":250199,"avatar_url":"https://avatars.githubusercontent.com/u/250199?v=3","gravatar_id":"","url":"https://api.github.com/users/paulbellamy","html_url":"https://github.com/paulbellamy","followers_url":"https://api.github.com/users/paulbellamy/followers","following_url":"https://api.github.com/users/paulbellamy/following{/other_user}","gists_url":"https://api.github.com/users/paulbellamy/gists{/gist_id}","starred_url":"https://api.github.com/users/paulbellamy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulbellamy/subscriptions","organizations_url":"https://api.github.com/users/paulbellamy/orgs","repos_url":"https://api.github.com/users/paulbellamy/repos","events_url":"https://api.github.com/users/paulbellamy/events{/privacy}","received_events_url":"https://api.github.com/users/paulbellamy/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/weaveworks/weave/pulls/878/commits","review_comments_url":"https://api.github.com/repos/weaveworks/weave/pulls/878/comments","review_comment_url":"https://api.github.com/repos/weaveworks/weave/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weaveworks/weave/issues/878/comments","statuses_url":"https://api.github.com/repos/weaveworks/weave/statuses/989be4a79cb9bb89344c5ecb57d9697eeb7f5ffc","head":{"label":"rade:877_remove_proxy_status","ref":"877_remove_proxy_status","sha":"989be4a79cb9bb89344c5ecb57d9697eeb7f5ffc","user":{"login":"rade","id":109109,"avatar_url":"https://avatars.githubusercontent.com/u/109109?v=3","gravatar_id":"","url":"https://api.github.com/users/rade","html_url":"https://github.com/rade","followers_url":"https://api.github.com/users/rade/followers","following_url":"https://api.github.com/users/rade/following{/other_user}","gists_url":"https://api.github.com/users/rade/gists{/gist_id}","starred_url":"https://api.github.com/users/rade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rade/subscriptions","organizations_url":"https://api.github.com/users/rade/orgs","repos_url":"https://api.github.com/users/rade/repos","events_url":"https://api.github.com/users/rade/events{/privacy}","received_events_url":"https://api.github.com/users/rade/received_events","type":"User","site_admin":false},"repo":{"id":25579630,"name":"weave","full_name":"rade/weave","owner":{"login":"rade","id":109109,"avatar_url":"https://avatars.githubusercontent.com/u/109109?v=3","gravatar_id":"","url":"https://api.github.com/users/rade","html_url":"https://github.com/rade","followers_url":"https://api.github.com/users/rade/followers","following_url":"https://api.github.com/users/rade/following{/other_user}","gists_url":"https://api.github.com/users/rade/gists{/gist_id}","starred_url":"https://api.github.com/users/rade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rade/subscriptions","organizations_url":"https://api.github.com/users/rade/orgs","repos_url":"https://api.github.com/users/rade/repos","events_url":"https://api.github.com/users/rade/events{/privacy}","received_events_url":"https://api.github.com/users/rade/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rade/weave","description":"The Docker Network","fork":true,"url":"https://api.github.com/repos/rade/weave","forks_url":"https://api.github.com/repos/rade/weave/forks","keys_url":"https://api.github.com/repos/rade/weave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rade/weave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rade/weave/teams","hooks_url":"https://api.github.com/repos/rade/weave/hooks","issue_events_url":"https://api.github.com/repos/rade/weave/issues/events{/number}","events_url":"https://api.github.com/repos/rade/weave/events","assignees_url":"https://api.github.com/repos/rade/weave/assignees{/user}","branches_url":"https://api.github.com/repos/rade/weave/branches{/branch}","tags_url":"https://api.github.com/repos/rade/weave/tags","blobs_url":"https://api.github.com/repos/rade/weave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rade/weave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rade/weave/git/refs{/sha}","trees_url":"https://api.github.com/repos/rade/weave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rade/weave/statuses/{sha}","languages_url":"https://api.github.com/repos/rade/weave/languages","stargazers_url":"https://api.github.com/repos/rade/weave/stargazers","contributors_url":"https://api.github.com/repos/rade/weave/contributors","subscribers_url":"https://api.github.com/repos/rade/weave/subscribers","subscription_url":"https://api.github.com/repos/rade/weave/subscription","commits_url":"https://api.github.com/repos/rade/weave/commits{/sha}","git_commits_url":"https://api.github.com/repos/rade/weave/git/commits{/sha}","comments_url":"https://api.github.com/repos/rade/weave/comments{/number}","issue_comment_url":"https://api.github.com/repos/rade/weave/issues/comments{/number}","contents_url":"https://api.github.com/repos/rade/weave/contents/{+path}","compare_url":"https://api.github.com/repos/rade/weave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rade/weave/merges","archive_url":"https://api.github.com/repos/rade/weave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rade/weave/downloads","issues_url":"https://api.github.com/repos/rade/weave/issues{/number}","pulls_url":"https://api.github.com/repos/rade/weave/pulls{/number}","milestones_url":"https://api.github.com/repos/rade/weave/milestones{/number}","notifications_url":"https://api.github.com/repos/rade/weave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rade/weave/labels{/name}","releases_url":"https://api.github.com/repos/rade/weave/releases{/id}","created_at":"2014-10-22T12:14:21Z","updated_at":"2015-05-05T15:00:53Z","pushed_at":"2015-06-09T10:43:05Z","git_url":"git://github.com/rade/weave.git","ssh_url":"git@github.com:rade/weave.git","clone_url":"https://github.com/rade/weave.git","svn_url":"https://github.com/rade/weave","homepage":"","size":5067,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"weaveworks:master","ref":"master","sha":"2d701972211129ed6246d9d7b523a20dfb805e2d","user":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":23059575,"name":"weave","full_name":"weaveworks/weave","owner":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weaveworks/weave","description":"The Docker Network","fork":false,"url":"https://api.github.com/repos/weaveworks/weave","forks_url":"https://api.github.com/repos/weaveworks/weave/forks","keys_url":"https://api.github.com/repos/weaveworks/weave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/weave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/weave/teams","hooks_url":"https://api.github.com/repos/weaveworks/weave/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/weave/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/weave/events","assignees_url":"https://api.github.com/repos/weaveworks/weave/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/weave/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/weave/tags","blobs_url":"https://api.github.com/repos/weaveworks/weave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/weave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/weave/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/weave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/weave/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/weave/languages","stargazers_url":"https://api.github.com/repos/weaveworks/weave/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/weave/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/weave/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/weave/subscription","commits_url":"https://api.github.com/repos/weaveworks/weave/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/weave/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/weave/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/weave/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/weave/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/weave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/weave/merges","archive_url":"https://api.github.com/repos/weaveworks/weave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/weave/downloads","issues_url":"https://api.github.com/repos/weaveworks/weave/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/weave/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/weave/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/weave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/weave/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/weave/releases{/id}","created_at":"2014-08-18T05:19:07Z","updated_at":"2015-06-08T22:11:03Z","pushed_at":"2015-06-09T11:44:31Z","git_url":"git://github.com/weaveworks/weave.git","ssh_url":"git@github.com:weaveworks/weave.git","clone_url":"https://github.com/weaveworks/weave.git","svn_url":"https://github.com/weaveworks/weave","homepage":"http://weave.works","size":10698,"stargazers_count":3408,"watchers_count":3408,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":191,"mirror_url":null,"open_issues_count":140,"forks":191,"open_issues":140,"watchers":3408,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/878"},"html":{"href":"https://github.com/weaveworks/weave/pull/878"},"issue":{"href":"https://api.github.com/repos/weaveworks/weave/issues/878"},"comments":{"href":"https://api.github.com/repos/weaveworks/weave/issues/878/comments"},"review_comments":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/878/comments"},"review_comment":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/878/commits"},"statuses":{"href":"https://api.github.com/repos/weaveworks/weave/statuses/989be4a79cb9bb89344c5ecb57d9697eeb7f5ffc"}}}}