{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/29461900","id":29461900,"diff_hunk":"@@ -799,6 +799,13 @@ type PodSpec struct {\n \t// Required: there must be at least one container in a pod.\n \tContainers    []Container   `json:\"containers\"`\n \tRestartPolicy RestartPolicy `json:\"restartPolicy,omitempty\"`\n+\t// Optional duration in seconds the pod needs to terminate gracefully. May be decreased in delete request.\n+\t// Value must be non-negative integer. The value zero indicates delete immediately.\n+\t// If this value is nil, the default grace period will be used instead.\n+\t// The grace period is the duration in seconds after the processes running in the pod are sent\n+\t// a termination signal and the time when the processes are forcibly halted with a kill signal).","path":"pkg/api/types.go","position":8,"original_position":8,"commit_id":"11a2dc496fef202470058e439a4983d592cfffba","original_commit_id":"11a2dc496fef202470058e439a4983d592cfffba","user":{"login":"davidopp","id":8264113,"avatar_url":"https://avatars.githubusercontent.com/u/8264113?v=3","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false},"body":"closing ) with no opening (\r\n(same in the other files)\r\n","created_at":"2015-04-30T19:29:09Z","updated_at":"2015-04-30T19:29:09Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7432#discussion_r29461900","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7432","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/29461900"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7432#discussion_r29461900"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7432"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7432","id":34264690,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7432","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7432.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7432.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/7432","number":7432,"state":"closed","locked":false,"title":"Added TerminationGracePeriod field to PodSpec and grace-period flag to kubectl stop","user":{"login":"piosz","id":10819974,"avatar_url":"https://avatars.githubusercontent.com/u/10819974?v=3","gravatar_id":"","url":"https://api.github.com/users/piosz","html_url":"https://github.com/piosz","followers_url":"https://api.github.com/users/piosz/followers","following_url":"https://api.github.com/users/piosz/following{/other_user}","gists_url":"https://api.github.com/users/piosz/gists{/gist_id}","starred_url":"https://api.github.com/users/piosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piosz/subscriptions","organizations_url":"https://api.github.com/users/piosz/orgs","repos_url":"https://api.github.com/users/piosz/repos","events_url":"https://api.github.com/users/piosz/events{/privacy}","received_events_url":"https://api.github.com/users/piosz/received_events","type":"User","site_admin":false},"body":"Those are changes which touch users required by Termination Notice\r\n\r\nAddresses #6804","created_at":"2015-04-28T13:10:44Z","updated_at":"2015-04-30T19:29:09Z","closed_at":"2015-04-30T17:55:52Z","merged_at":"2015-04-30T17:55:51Z","merge_commit_sha":"4351b2838d5b8ab7e5118497ace4927e0ea58076","assignee":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7432/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7432/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/7432/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/11a2dc496fef202470058e439a4983d592cfffba","head":{"label":"piosz:termination_notice","ref":"termination_notice","sha":"11a2dc496fef202470058e439a4983d592cfffba","user":{"login":"piosz","id":10819974,"avatar_url":"https://avatars.githubusercontent.com/u/10819974?v=3","gravatar_id":"","url":"https://api.github.com/users/piosz","html_url":"https://github.com/piosz","followers_url":"https://api.github.com/users/piosz/followers","following_url":"https://api.github.com/users/piosz/following{/other_user}","gists_url":"https://api.github.com/users/piosz/gists{/gist_id}","starred_url":"https://api.github.com/users/piosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piosz/subscriptions","organizations_url":"https://api.github.com/users/piosz/orgs","repos_url":"https://api.github.com/users/piosz/repos","events_url":"https://api.github.com/users/piosz/events{/privacy}","received_events_url":"https://api.github.com/users/piosz/received_events","type":"User","site_admin":false},"repo":{"id":30922782,"name":"kubernetes","full_name":"piosz/kubernetes","owner":{"login":"piosz","id":10819974,"avatar_url":"https://avatars.githubusercontent.com/u/10819974?v=3","gravatar_id":"","url":"https://api.github.com/users/piosz","html_url":"https://github.com/piosz","followers_url":"https://api.github.com/users/piosz/followers","following_url":"https://api.github.com/users/piosz/following{/other_user}","gists_url":"https://api.github.com/users/piosz/gists{/gist_id}","starred_url":"https://api.github.com/users/piosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piosz/subscriptions","organizations_url":"https://api.github.com/users/piosz/orgs","repos_url":"https://api.github.com/users/piosz/repos","events_url":"https://api.github.com/users/piosz/events{/privacy}","received_events_url":"https://api.github.com/users/piosz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/piosz/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/piosz/kubernetes","forks_url":"https://api.github.com/repos/piosz/kubernetes/forks","keys_url":"https://api.github.com/repos/piosz/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/piosz/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/piosz/kubernetes/teams","hooks_url":"https://api.github.com/repos/piosz/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/piosz/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/piosz/kubernetes/events","assignees_url":"https://api.github.com/repos/piosz/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/piosz/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/piosz/kubernetes/tags","blobs_url":"https://api.github.com/repos/piosz/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/piosz/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/piosz/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/piosz/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/piosz/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/piosz/kubernetes/languages","stargazers_url":"https://api.github.com/repos/piosz/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/piosz/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/piosz/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/piosz/kubernetes/subscription","commits_url":"https://api.github.com/repos/piosz/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/piosz/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/piosz/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/piosz/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/piosz/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/piosz/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/piosz/kubernetes/merges","archive_url":"https://api.github.com/repos/piosz/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/piosz/kubernetes/downloads","issues_url":"https://api.github.com/repos/piosz/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/piosz/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/piosz/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/piosz/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/piosz/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/piosz/kubernetes/releases{/id}","created_at":"2015-02-17T15:23:02Z","updated_at":"2015-04-30T15:56:49Z","pushed_at":"2015-04-30T16:00:57Z","git_url":"git://github.com/piosz/kubernetes.git","ssh_url":"git@github.com:piosz/kubernetes.git","clone_url":"https://github.com/piosz/kubernetes.git","svn_url":"https://github.com/piosz/kubernetes","homepage":"http://kubernetes.io","size":49995,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"dd976a27fb360bf8df2c8e76cb1fe5d4f69e8fba","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-04-30T19:21:54Z","pushed_at":"2015-04-30T19:21:54Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":212904,"stargazers_count":7421,"watchers_count":7421,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1488,"mirror_url":null,"open_issues_count":984,"forks":1488,"open_issues":984,"watchers":7421,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7432"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7432"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/7432"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/7432/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7432/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7432/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/11a2dc496fef202470058e439a4983d592cfffba"}}}}