{"push_id":889246212,"size":2,"distinct_size":2,"ref":"refs/heads/MDL-52250-master","head":"a895405e42090fbf92fc124b3a6d350100f59197","before":"8e294cd3fd7a33f06e5d6aa0697135e248c9dbf1","commits":[{"sha":"2638eabfc25c044fa5e11e3d68a50e3303e10844","author":{"email":"2591e5f46f28d303f9dc027d475a5c60d8dea17a@moodle.com","name":"Dan Poltawski"},"message":"MDL-52250 npm: remove uglify-js dependency/bump grunt-contrib-uglify\n\nA) Remove direct dependency on uglify-js:\n\nThis dependency was added in MDL-50277, but it isn't quite correct, the\nway npm installs dependencies means that grunt-contrib-uglify *could* use\n'our' version if its satisifed. But does not *always* and especially does\nnot if the grunt-contrib-uglify requirement is higher than ours.\n\nLong story short, in many cases this means that this is used:\n node_modules/grunt-contrib-uglify/node_modules/uglify-js\nBut this is not:\n  node_modules/uglify-js\n\nIn MDL-50277 we thought we were making the version sticky, but in\nreality we were just fixing previous problems by updating\ngrunt-contrib-uglify to a version which fixed a bug:\n\n https://github.com/gruntjs/grunt-contrib-uglify/issues/313\n\nIt seems the better solution will come with using npm shrinkwrap to lock\ndown depdencies.\n\nB) Bump grunt-contrib-uglify to 0.11.0\n\nThis moves us to uglify-js ~2.6.0","distinct":true,"url":"https://api.github.com/repos/danpoltawski/moodle/commits/2638eabfc25c044fa5e11e3d68a50e3303e10844"},{"sha":"a895405e42090fbf92fc124b3a6d350100f59197","author":{"email":"2591e5f46f28d303f9dc027d475a5c60d8dea17a@moodle.com","name":"Dan Poltawski"},"message":"MDL-52250 npm: shrinkwrap to lock down dependencies\n\nWe've tried various approaches to lock down our dependencies and they\nhave been flawed because dependencies in our included packages may not\nbe locked down and previous attempts to do that have not been correct.\n\nWith npm shrinkwrap we lock down versions so that any npm install will\nalways install the exact same versions for all developers - see:\nhttps://docs.npmjs.com/cli/shrinkwrap\n\n(This is a lot like composer.lock for those more fluent with composer)","distinct":true,"url":"https://api.github.com/repos/danpoltawski/moodle/commits/a895405e42090fbf92fc124b3a6d350100f59197"}]}