{"comment":{"url":"https://api.github.com/repos/abhidixit/ceph/comments/10723445","html_url":"https://github.com/abhidixit/ceph/commit/f80f9b0c2d30cd6c6014debc23ee55095e06c2df#commitcomment-10723445","id":10723445,"user":{"login":"yehudasa","id":1036377,"avatar_url":"https://avatars.githubusercontent.com/u/1036377?v=3","gravatar_id":"","url":"https://api.github.com/users/yehudasa","html_url":"https://github.com/yehudasa","followers_url":"https://api.github.com/users/yehudasa/followers","following_url":"https://api.github.com/users/yehudasa/following{/other_user}","gists_url":"https://api.github.com/users/yehudasa/gists{/gist_id}","starred_url":"https://api.github.com/users/yehudasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yehudasa/subscriptions","organizations_url":"https://api.github.com/users/yehudasa/orgs","repos_url":"https://api.github.com/users/yehudasa/repos","events_url":"https://api.github.com/users/yehudasa/events{/privacy}","received_events_url":"https://api.github.com/users/yehudasa/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"f80f9b0c2d30cd6c6014debc23ee55095e06c2df","created_at":"2015-04-14T20:27:07Z","updated_at":"2015-04-14T20:27:07Z","body":"@abhidixit missing Signed-off-by tag for the commit. Also, I don't see why we need to have different request ids for S3 and Swift, should just use the swift one for both. Also, instead of calculating the request id here like this, should do it on initialization, and put it on the req_state structure."}}