{"action":"opened","number":174,"pull_request":{"url":"https://api.github.com/repos/facebook/folly/pulls/174","id":32679523,"html_url":"https://github.com/facebook/folly/pull/174","diff_url":"https://github.com/facebook/folly/pull/174.diff","patch_url":"https://github.com/facebook/folly/pull/174.patch","issue_url":"https://api.github.com/repos/facebook/folly/issues/174","number":174,"state":"open","locked":false,"title":"Funtions can be noexcept","user":{"login":"cppfool","id":10673506,"avatar_url":"https://avatars.githubusercontent.com/u/10673506?v=3","gravatar_id":"","url":"https://api.github.com/users/cppfool","html_url":"https://github.com/cppfool","followers_url":"https://api.github.com/users/cppfool/followers","following_url":"https://api.github.com/users/cppfool/following{/other_user}","gists_url":"https://api.github.com/users/cppfool/gists{/gist_id}","starred_url":"https://api.github.com/users/cppfool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cppfool/subscriptions","organizations_url":"https://api.github.com/users/cppfool/orgs","repos_url":"https://api.github.com/users/cppfool/repos","events_url":"https://api.github.com/users/cppfool/events{/privacy}","received_events_url":"https://api.github.com/users/cppfool/received_events","type":"User","site_admin":false},"body":"The following funtions don't call anything which isn't noexcept.\r\n\r\nSo we can safely mark them noexcept, which compiler might like.\r\n\r\nIntT ThreadCachedInt::readFast() const;\r\n\r\nIntT ThreadCachedInt::readFastAndReset();\r\n\r\nvoid ThreadCachedInt::setCacheSize(uint32_t);\r\n\r\nuint32_t ThreadCachedInt::getCacheSize() const; \r\n\r\nTest Plan:\r\n\r\nAll folly/tests, make check for 37 tests, passed.","created_at":"2015-04-06T13:49:57Z","updated_at":"2015-04-06T13:49:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/folly/pulls/174/commits","review_comments_url":"https://api.github.com/repos/facebook/folly/pulls/174/comments","review_comment_url":"https://api.github.com/repos/facebook/folly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/folly/issues/174/comments","statuses_url":"https://api.github.com/repos/facebook/folly/statuses/5a882e927dde81ef34bafb5b7c2d1e4da9ed318d","head":{"label":"cppfool:ThreadCachedInt3","ref":"ThreadCachedInt3","sha":"5a882e927dde81ef34bafb5b7c2d1e4da9ed318d","user":{"login":"cppfool","id":10673506,"avatar_url":"https://avatars.githubusercontent.com/u/10673506?v=3","gravatar_id":"","url":"https://api.github.com/users/cppfool","html_url":"https://github.com/cppfool","followers_url":"https://api.github.com/users/cppfool/followers","following_url":"https://api.github.com/users/cppfool/following{/other_user}","gists_url":"https://api.github.com/users/cppfool/gists{/gist_id}","starred_url":"https://api.github.com/users/cppfool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cppfool/subscriptions","organizations_url":"https://api.github.com/users/cppfool/orgs","repos_url":"https://api.github.com/users/cppfool/repos","events_url":"https://api.github.com/users/cppfool/events{/privacy}","received_events_url":"https://api.github.com/users/cppfool/received_events","type":"User","site_admin":false},"repo":{"id":30639859,"name":"folly","full_name":"cppfool/folly","owner":{"login":"cppfool","id":10673506,"avatar_url":"https://avatars.githubusercontent.com/u/10673506?v=3","gravatar_id":"","url":"https://api.github.com/users/cppfool","html_url":"https://github.com/cppfool","followers_url":"https://api.github.com/users/cppfool/followers","following_url":"https://api.github.com/users/cppfool/following{/other_user}","gists_url":"https://api.github.com/users/cppfool/gists{/gist_id}","starred_url":"https://api.github.com/users/cppfool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cppfool/subscriptions","organizations_url":"https://api.github.com/users/cppfool/orgs","repos_url":"https://api.github.com/users/cppfool/repos","events_url":"https://api.github.com/users/cppfool/events{/privacy}","received_events_url":"https://api.github.com/users/cppfool/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cppfool/folly","description":"An open-source C++ library developed and used at Facebook.","fork":true,"url":"https://api.github.com/repos/cppfool/folly","forks_url":"https://api.github.com/repos/cppfool/folly/forks","keys_url":"https://api.github.com/repos/cppfool/folly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cppfool/folly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cppfool/folly/teams","hooks_url":"https://api.github.com/repos/cppfool/folly/hooks","issue_events_url":"https://api.github.com/repos/cppfool/folly/issues/events{/number}","events_url":"https://api.github.com/repos/cppfool/folly/events","assignees_url":"https://api.github.com/repos/cppfool/folly/assignees{/user}","branches_url":"https://api.github.com/repos/cppfool/folly/branches{/branch}","tags_url":"https://api.github.com/repos/cppfool/folly/tags","blobs_url":"https://api.github.com/repos/cppfool/folly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cppfool/folly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cppfool/folly/git/refs{/sha}","trees_url":"https://api.github.com/repos/cppfool/folly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cppfool/folly/statuses/{sha}","languages_url":"https://api.github.com/repos/cppfool/folly/languages","stargazers_url":"https://api.github.com/repos/cppfool/folly/stargazers","contributors_url":"https://api.github.com/repos/cppfool/folly/contributors","subscribers_url":"https://api.github.com/repos/cppfool/folly/subscribers","subscription_url":"https://api.github.com/repos/cppfool/folly/subscription","commits_url":"https://api.github.com/repos/cppfool/folly/commits{/sha}","git_commits_url":"https://api.github.com/repos/cppfool/folly/git/commits{/sha}","comments_url":"https://api.github.com/repos/cppfool/folly/comments{/number}","issue_comment_url":"https://api.github.com/repos/cppfool/folly/issues/comments{/number}","contents_url":"https://api.github.com/repos/cppfool/folly/contents/{+path}","compare_url":"https://api.github.com/repos/cppfool/folly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cppfool/folly/merges","archive_url":"https://api.github.com/repos/cppfool/folly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cppfool/folly/downloads","issues_url":"https://api.github.com/repos/cppfool/folly/issues{/number}","pulls_url":"https://api.github.com/repos/cppfool/folly/pulls{/number}","milestones_url":"https://api.github.com/repos/cppfool/folly/milestones{/number}","notifications_url":"https://api.github.com/repos/cppfool/folly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cppfool/folly/labels{/name}","releases_url":"https://api.github.com/repos/cppfool/folly/releases{/id}","created_at":"2015-02-11T09:15:37Z","updated_at":"2015-03-08T09:33:23Z","pushed_at":"2015-04-06T13:47:44Z","git_url":"git://github.com/cppfool/folly.git","ssh_url":"git@github.com:cppfool/folly.git","clone_url":"https://github.com/cppfool/folly.git","svn_url":"https://github.com/cppfool/folly","homepage":"https://groups.google.com/forum/?fromgroups#!forum/facebook-folly","size":5897,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"7c9f26357a1a2852ea11b051e1e0402dcfbce861","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":4524181,"name":"folly","full_name":"facebook/folly","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/folly","description":"An open-source C++ library developed and used at Facebook.","fork":false,"url":"https://api.github.com/repos/facebook/folly","forks_url":"https://api.github.com/repos/facebook/folly/forks","keys_url":"https://api.github.com/repos/facebook/folly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/folly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/folly/teams","hooks_url":"https://api.github.com/repos/facebook/folly/hooks","issue_events_url":"https://api.github.com/repos/facebook/folly/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/folly/events","assignees_url":"https://api.github.com/repos/facebook/folly/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/folly/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/folly/tags","blobs_url":"https://api.github.com/repos/facebook/folly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/folly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/folly/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/folly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/folly/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/folly/languages","stargazers_url":"https://api.github.com/repos/facebook/folly/stargazers","contributors_url":"https://api.github.com/repos/facebook/folly/contributors","subscribers_url":"https://api.github.com/repos/facebook/folly/subscribers","subscription_url":"https://api.github.com/repos/facebook/folly/subscription","commits_url":"https://api.github.com/repos/facebook/folly/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/folly/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/folly/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/folly/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/folly/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/folly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/folly/merges","archive_url":"https://api.github.com/repos/facebook/folly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/folly/downloads","issues_url":"https://api.github.com/repos/facebook/folly/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/folly/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/folly/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/folly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/folly/labels{/name}","releases_url":"https://api.github.com/repos/facebook/folly/releases{/id}","created_at":"2012-06-01T20:49:04Z","updated_at":"2015-04-06T10:35:08Z","pushed_at":"2015-04-05T13:18:21Z","git_url":"git://github.com/facebook/folly.git","ssh_url":"git@github.com:facebook/folly.git","clone_url":"https://github.com/facebook/folly.git","svn_url":"https://github.com/facebook/folly","homepage":"https://groups.google.com/forum/?fromgroups#!forum/facebook-folly","size":7998,"stargazers_count":4523,"watchers_count":4523,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":958,"mirror_url":null,"open_issues_count":77,"forks":958,"open_issues":77,"watchers":4523,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/folly/pulls/174"},"html":{"href":"https://github.com/facebook/folly/pull/174"},"issue":{"href":"https://api.github.com/repos/facebook/folly/issues/174"},"comments":{"href":"https://api.github.com/repos/facebook/folly/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/folly/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/folly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/folly/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/folly/statuses/5a882e927dde81ef34bafb5b7c2d1e4da9ed318d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":4,"changed_files":1}}