{"action":"created","issue":{"url":"https://api.github.com/repos/bgamari/libbeagledaq/issues/2","labels_url":"https://api.github.com/repos/bgamari/libbeagledaq/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/bgamari/libbeagledaq/issues/2/comments","events_url":"https://api.github.com/repos/bgamari/libbeagledaq/issues/2/events","html_url":"https://github.com/bgamari/libbeagledaq/pull/2","id":73829870,"number":2,"title":"Python interface to beagle-daq using pyspi-dev. Initial commit.","user":{"login":"krrk","id":4636304,"avatar_url":"https://avatars.githubusercontent.com/u/4636304?v=3","gravatar_id":"","url":"https://api.github.com/users/krrk","html_url":"https://github.com/krrk","followers_url":"https://api.github.com/users/krrk/followers","following_url":"https://api.github.com/users/krrk/following{/other_user}","gists_url":"https://api.github.com/users/krrk/gists{/gist_id}","starred_url":"https://api.github.com/users/krrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krrk/subscriptions","organizations_url":"https://api.github.com/users/krrk/orgs","repos_url":"https://api.github.com/users/krrk/repos","events_url":"https://api.github.com/users/krrk/events{/privacy}","received_events_url":"https://api.github.com/users/krrk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-07T04:04:09Z","updated_at":"2015-05-07T04:33:33Z","closed_at":"2015-05-07T04:33:28Z","pull_request":{"url":"https://api.github.com/repos/bgamari/libbeagledaq/pulls/2","html_url":"https://github.com/bgamari/libbeagledaq/pull/2","diff_url":"https://github.com/bgamari/libbeagledaq/pull/2.diff","patch_url":"https://github.com/bgamari/libbeagledaq/pull/2.patch"},"body":"Here is a port of the C++ interface using py-spidev. This was much easier for me to implement than to wrap the C++ interface which had subclass declarations. The subclass declarations made it impossible to wrap using SWIG (at its current version) and it was non-trivial for me in Cython or other approaches. At lease this python interface is much more readable and approachable. It is also nearly as fast! About 70% the speed for read from ADCs and about 85% as fast for writing to the DACs. That is about 3200 ADC samples/sec and 4900 DAC samples/sec."},"comment":{"url":"https://api.github.com/repos/bgamari/libbeagledaq/issues/comments/99710072","html_url":"https://github.com/bgamari/libbeagledaq/pull/2#issuecomment-99710072","issue_url":"https://api.github.com/repos/bgamari/libbeagledaq/issues/2","id":99710072,"user":{"login":"bgamari","id":1010174,"avatar_url":"https://avatars.githubusercontent.com/u/1010174?v=3","gravatar_id":"","url":"https://api.github.com/users/bgamari","html_url":"https://github.com/bgamari","followers_url":"https://api.github.com/users/bgamari/followers","following_url":"https://api.github.com/users/bgamari/following{/other_user}","gists_url":"https://api.github.com/users/bgamari/gists{/gist_id}","starred_url":"https://api.github.com/users/bgamari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgamari/subscriptions","organizations_url":"https://api.github.com/users/bgamari/orgs","repos_url":"https://api.github.com/users/bgamari/repos","events_url":"https://api.github.com/users/bgamari/events{/privacy}","received_events_url":"https://api.github.com/users/bgamari/received_events","type":"User","site_admin":false},"created_at":"2015-05-07T04:33:33Z","updated_at":"2015-05-07T04:33:33Z","body":"Brilliant! Looks good to me. Arguably it might make sense to either place this in a separate repo or move the C++ bindings and the Python bindings into separate subdirectories of this repo. Regardless, I'm not picky enough to make a big deal of it at the moment. Merged.\r\n\r\nIn other news, you should now have commit rights."}}