{"action":"opened","number":7154,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/7154","id":35586189,"html_url":"https://github.com/xbmc/xbmc/pull/7154","diff_url":"https://github.com/xbmc/xbmc/pull/7154.diff","patch_url":"https://github.com/xbmc/xbmc/pull/7154.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/7154","number":7154,"state":"open","locked":false,"title":"CLocalizeStrings: unify fallback language handling (fixes skin strings loading)","user":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"body":"As mentioned by @stefansaraev since the language update of all system addons (including Confluence) loading the fallback translation strings from the English translation doesn't work anymore because it looks for `English` instead of `resource.language.en_gb`.\r\n\r\nThis unifies the handling of the default language and in the process fixes above issue. When loading skin strings it now first tries to load them in the language selected in Kodi's settings and in the English language from `resource.language.en_gb` and if that doesn't exist it even falls back to `English`.","created_at":"2015-05-17T12:15:59Z","updated_at":"2015-05-17T12:15:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7154/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7154/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/7154/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/92cdbab8f3a2428d4964c552b40699ac555dc9eb","head":{"label":"Montellese:fix_skin_language_fallback","ref":"fix_skin_language_fallback","sha":"92cdbab8f3a2428d4964c552b40699ac555dc9eb","user":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"repo":{"id":1287028,"name":"xbmc","full_name":"Montellese/xbmc","owner":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Montellese/xbmc","description":"Montellese's fork of XBMC ","fork":true,"url":"https://api.github.com/repos/Montellese/xbmc","forks_url":"https://api.github.com/repos/Montellese/xbmc/forks","keys_url":"https://api.github.com/repos/Montellese/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Montellese/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Montellese/xbmc/teams","hooks_url":"https://api.github.com/repos/Montellese/xbmc/hooks","issue_events_url":"https://api.github.com/repos/Montellese/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/Montellese/xbmc/events","assignees_url":"https://api.github.com/repos/Montellese/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/Montellese/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/Montellese/xbmc/tags","blobs_url":"https://api.github.com/repos/Montellese/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Montellese/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Montellese/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Montellese/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Montellese/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/Montellese/xbmc/languages","stargazers_url":"https://api.github.com/repos/Montellese/xbmc/stargazers","contributors_url":"https://api.github.com/repos/Montellese/xbmc/contributors","subscribers_url":"https://api.github.com/repos/Montellese/xbmc/subscribers","subscription_url":"https://api.github.com/repos/Montellese/xbmc/subscription","commits_url":"https://api.github.com/repos/Montellese/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Montellese/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Montellese/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Montellese/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Montellese/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/Montellese/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Montellese/xbmc/merges","archive_url":"https://api.github.com/repos/Montellese/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Montellese/xbmc/downloads","issues_url":"https://api.github.com/repos/Montellese/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/Montellese/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/Montellese/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/Montellese/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Montellese/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/Montellese/xbmc/releases{/id}","created_at":"2011-01-24T08:36:12Z","updated_at":"2015-05-14T15:50:32Z","pushed_at":"2015-05-17T12:13:05Z","git_url":"git://github.com/Montellese/xbmc.git","ssh_url":"git@github.com:Montellese/xbmc.git","clone_url":"https://github.com/Montellese/xbmc.git","svn_url":"https://github.com/Montellese/xbmc","homepage":"http://xbmc.org","size":513091,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":5,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"77d100cc93d97d58cbf0f83a7bfa83bf919d3f2c","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-05-17T05:43:20Z","pushed_at":"2015-05-17T11:25:01Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1869644,"stargazers_count":3901,"watchers_count":3901,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2842,"mirror_url":null,"open_issues_count":237,"forks":2842,"open_issues":237,"watchers":3901,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7154"},"html":{"href":"https://github.com/xbmc/xbmc/pull/7154"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7154"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7154/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7154/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7154/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/92cdbab8f3a2428d4964c552b40699ac555dc9eb"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":10,"changed_files":3}}