{"action":"created","issue":{"url":"https://api.github.com/repos/hapijs/vision/issues/33","labels_url":"https://api.github.com/repos/hapijs/vision/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/hapijs/vision/issues/33/comments","events_url":"https://api.github.com/repos/hapijs/vision/issues/33/events","html_url":"https://github.com/hapijs/vision/pull/33","id":94508236,"number":33,"title":"Make compilation errors available to extensions.","user":{"login":"jagoda","id":655686,"avatar_url":"https://avatars.githubusercontent.com/u/655686?v=3","gravatar_id":"","url":"https://api.github.com/users/jagoda","html_url":"https://github.com/jagoda","followers_url":"https://api.github.com/users/jagoda/followers","following_url":"https://api.github.com/users/jagoda/following{/other_user}","gists_url":"https://api.github.com/users/jagoda/gists{/gist_id}","starred_url":"https://api.github.com/users/jagoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagoda/subscriptions","organizations_url":"https://api.github.com/users/jagoda/orgs","repos_url":"https://api.github.com/users/jagoda/repos","events_url":"https://api.github.com/users/jagoda/events{/privacy}","received_events_url":"https://api.github.com/users/jagoda/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hapijs/vision/labels/bug","name":"bug","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/hapijs/vision/milestones/8","html_url":"https://github.com/hapijs/vision/milestones/2.0.2","labels_url":"https://api.github.com/repos/hapijs/vision/milestones/8/labels","id":1174254,"number":8,"title":"2.0.2","description":"","creator":{"login":"hueniverse","id":56631,"avatar_url":"https://avatars.githubusercontent.com/u/56631?v=3","gravatar_id":"","url":"https://api.github.com/users/hueniverse","html_url":"https://github.com/hueniverse","followers_url":"https://api.github.com/users/hueniverse/followers","following_url":"https://api.github.com/users/hueniverse/following{/other_user}","gists_url":"https://api.github.com/users/hueniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/hueniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hueniverse/subscriptions","organizations_url":"https://api.github.com/users/hueniverse/orgs","repos_url":"https://api.github.com/users/hueniverse/repos","events_url":"https://api.github.com/users/hueniverse/events{/privacy}","received_events_url":"https://api.github.com/users/hueniverse/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":3,"state":"open","created_at":"2015-06-21T22:50:53Z","updated_at":"2015-07-11T21:18:17Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2015-07-11T21:18:17Z","updated_at":"2015-07-20T13:18:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hapijs/vision/pulls/33","html_url":"https://github.com/hapijs/vision/pull/33","diff_url":"https://github.com/hapijs/vision/pull/33.diff","patch_url":"https://github.com/hapijs/vision/pull/33.patch"},"body":"Currently neither template compilation nor rendering occur until\r\nafter the 'onPreResponse' event. This means that extensions have\r\nno way to intercept template related errors. This change moves the\r\ncompilation step to an earlier point in the request lifecycle so\r\nthat compilation errors are made available to the 'onPostHandler'\r\nand 'onPreResponse' extension points. Rendering still happens\r\nafter 'onPreResponse' so that the context object can be modified\r\nby extensions all the way up through the 'onPreResponse' event.\r\n\r\nFixes #10."},"comment":{"url":"https://api.github.com/repos/hapijs/vision/issues/comments/122880139","html_url":"https://github.com/hapijs/vision/pull/33#issuecomment-122880139","issue_url":"https://api.github.com/repos/hapijs/vision/issues/33","id":122880139,"user":{"login":"arb","id":1591483,"avatar_url":"https://avatars.githubusercontent.com/u/1591483?v=3","gravatar_id":"","url":"https://api.github.com/users/arb","html_url":"https://github.com/arb","followers_url":"https://api.github.com/users/arb/followers","following_url":"https://api.github.com/users/arb/following{/other_user}","gists_url":"https://api.github.com/users/arb/gists{/gist_id}","starred_url":"https://api.github.com/users/arb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arb/subscriptions","organizations_url":"https://api.github.com/users/arb/orgs","repos_url":"https://api.github.com/users/arb/repos","events_url":"https://api.github.com/users/arb/events{/privacy}","received_events_url":"https://api.github.com/users/arb/received_events","type":"User","site_admin":false},"created_at":"2015-07-20T13:18:20Z","updated_at":"2015-07-20T13:18:20Z","body":"Looking at the scope of this change, I think you should bump the major version to minimize any potential issues. While the rewrite is to fix what we're calling a bug, this is a lot of code moving around. All the unit tests may pass, but we don't know how this plugin is being used \"out there\".\r\n\r\nAs far as actual implementation goes, I'm not familiar enough with this plugin to speak intelligently about it."}}