{"action":"opened","number":2417,"pull_request":{"url":"https://api.github.com/repos/eslint/eslint/pulls/2417","id":34552094,"html_url":"https://github.com/eslint/eslint/pull/2417","diff_url":"https://github.com/eslint/eslint/pull/2417.diff","patch_url":"https://github.com/eslint/eslint/pull/2417.patch","issue_url":"https://api.github.com/repos/eslint/eslint/issues/2417","number":2417,"state":"open","locked":false,"title":"Rule 'no-unused-expressions': recurse over ternary and logical expressions","user":{"login":"ev0rtex","id":1640672,"avatar_url":"https://avatars.githubusercontent.com/u/1640672?v=3","gravatar_id":"","url":"https://api.github.com/users/ev0rtex","html_url":"https://github.com/ev0rtex","followers_url":"https://api.github.com/users/ev0rtex/followers","following_url":"https://api.github.com/users/ev0rtex/following{/other_user}","gists_url":"https://api.github.com/users/ev0rtex/gists{/gist_id}","starred_url":"https://api.github.com/users/ev0rtex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ev0rtex/subscriptions","organizations_url":"https://api.github.com/users/ev0rtex/orgs","repos_url":"https://api.github.com/users/ev0rtex/repos","events_url":"https://api.github.com/users/ev0rtex/events{/privacy}","received_events_url":"https://api.github.com/users/ev0rtex/received_events","type":"User","site_admin":false},"body":"I ran into an issue where I was getting an error from the `no-unused-expressions` rule when I had the following logic which *should* be a valid expression in this case:\r\n```\r\nfs.accessSync(cfgName) || (confFile = cfgName);\r\n```\r\nI realized the issue was that the rule didn't take logical expressions into account when testing like this. I fixed the issue here by breaking out the expression validation logic and recursing ternary and logical expressions. I added some test cases and it all seems to work well.","created_at":"2015-05-01T17:30:30Z","updated_at":"2015-05-01T17:30:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eslint/eslint/pulls/2417/commits","review_comments_url":"https://api.github.com/repos/eslint/eslint/pulls/2417/comments","review_comment_url":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/2417/comments","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/69768f6fe978af88a41e1602f54854b9d3d00445","head":{"label":"ev0rtex:fix-expression-rule-logic","ref":"fix-expression-rule-logic","sha":"69768f6fe978af88a41e1602f54854b9d3d00445","user":{"login":"ev0rtex","id":1640672,"avatar_url":"https://avatars.githubusercontent.com/u/1640672?v=3","gravatar_id":"","url":"https://api.github.com/users/ev0rtex","html_url":"https://github.com/ev0rtex","followers_url":"https://api.github.com/users/ev0rtex/followers","following_url":"https://api.github.com/users/ev0rtex/following{/other_user}","gists_url":"https://api.github.com/users/ev0rtex/gists{/gist_id}","starred_url":"https://api.github.com/users/ev0rtex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ev0rtex/subscriptions","organizations_url":"https://api.github.com/users/ev0rtex/orgs","repos_url":"https://api.github.com/users/ev0rtex/repos","events_url":"https://api.github.com/users/ev0rtex/events{/privacy}","received_events_url":"https://api.github.com/users/ev0rtex/received_events","type":"User","site_admin":false},"repo":{"id":34913341,"name":"eslint","full_name":"ev0rtex/eslint","owner":{"login":"ev0rtex","id":1640672,"avatar_url":"https://avatars.githubusercontent.com/u/1640672?v=3","gravatar_id":"","url":"https://api.github.com/users/ev0rtex","html_url":"https://github.com/ev0rtex","followers_url":"https://api.github.com/users/ev0rtex/followers","following_url":"https://api.github.com/users/ev0rtex/following{/other_user}","gists_url":"https://api.github.com/users/ev0rtex/gists{/gist_id}","starred_url":"https://api.github.com/users/ev0rtex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ev0rtex/subscriptions","organizations_url":"https://api.github.com/users/ev0rtex/orgs","repos_url":"https://api.github.com/users/ev0rtex/repos","events_url":"https://api.github.com/users/ev0rtex/events{/privacy}","received_events_url":"https://api.github.com/users/ev0rtex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ev0rtex/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":true,"url":"https://api.github.com/repos/ev0rtex/eslint","forks_url":"https://api.github.com/repos/ev0rtex/eslint/forks","keys_url":"https://api.github.com/repos/ev0rtex/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ev0rtex/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ev0rtex/eslint/teams","hooks_url":"https://api.github.com/repos/ev0rtex/eslint/hooks","issue_events_url":"https://api.github.com/repos/ev0rtex/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/ev0rtex/eslint/events","assignees_url":"https://api.github.com/repos/ev0rtex/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/ev0rtex/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/ev0rtex/eslint/tags","blobs_url":"https://api.github.com/repos/ev0rtex/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ev0rtex/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ev0rtex/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/ev0rtex/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ev0rtex/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/ev0rtex/eslint/languages","stargazers_url":"https://api.github.com/repos/ev0rtex/eslint/stargazers","contributors_url":"https://api.github.com/repos/ev0rtex/eslint/contributors","subscribers_url":"https://api.github.com/repos/ev0rtex/eslint/subscribers","subscription_url":"https://api.github.com/repos/ev0rtex/eslint/subscription","commits_url":"https://api.github.com/repos/ev0rtex/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/ev0rtex/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/ev0rtex/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/ev0rtex/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/ev0rtex/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/ev0rtex/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ev0rtex/eslint/merges","archive_url":"https://api.github.com/repos/ev0rtex/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ev0rtex/eslint/downloads","issues_url":"https://api.github.com/repos/ev0rtex/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/ev0rtex/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/ev0rtex/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/ev0rtex/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ev0rtex/eslint/labels{/name}","releases_url":"https://api.github.com/repos/ev0rtex/eslint/releases{/id}","created_at":"2015-05-01T17:01:43Z","updated_at":"2015-05-01T17:21:39Z","pushed_at":"2015-05-01T17:22:10Z","git_url":"git://github.com/ev0rtex/eslint.git","ssh_url":"git@github.com:ev0rtex/eslint.git","clone_url":"https://github.com/ev0rtex/eslint.git","svn_url":"https://github.com/ev0rtex/eslint","homepage":"http://eslint.org","size":16526,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eslint:master","ref":"master","sha":"925f1be6d9bc5c5b36f80ed4f5c9865d1d524750","user":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"repo":{"id":11061773,"name":"eslint","full_name":"eslint/eslint","owner":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eslint/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":false,"url":"https://api.github.com/repos/eslint/eslint","forks_url":"https://api.github.com/repos/eslint/eslint/forks","keys_url":"https://api.github.com/repos/eslint/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eslint/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eslint/eslint/teams","hooks_url":"https://api.github.com/repos/eslint/eslint/hooks","issue_events_url":"https://api.github.com/repos/eslint/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/eslint/eslint/events","assignees_url":"https://api.github.com/repos/eslint/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/eslint/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/eslint/eslint/tags","blobs_url":"https://api.github.com/repos/eslint/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eslint/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eslint/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/eslint/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/eslint/eslint/languages","stargazers_url":"https://api.github.com/repos/eslint/eslint/stargazers","contributors_url":"https://api.github.com/repos/eslint/eslint/contributors","subscribers_url":"https://api.github.com/repos/eslint/eslint/subscribers","subscription_url":"https://api.github.com/repos/eslint/eslint/subscription","commits_url":"https://api.github.com/repos/eslint/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/eslint/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/eslint/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/eslint/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/eslint/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/eslint/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eslint/eslint/merges","archive_url":"https://api.github.com/repos/eslint/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eslint/eslint/downloads","issues_url":"https://api.github.com/repos/eslint/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/eslint/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/eslint/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/eslint/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eslint/eslint/labels{/name}","releases_url":"https://api.github.com/repos/eslint/eslint/releases{/id}","created_at":"2013-06-29T23:59:48Z","updated_at":"2015-05-01T16:17:43Z","pushed_at":"2015-05-01T16:17:43Z","git_url":"git://github.com/eslint/eslint.git","ssh_url":"git@github.com:eslint/eslint.git","clone_url":"https://github.com/eslint/eslint.git","svn_url":"https://github.com/eslint/eslint","homepage":"http://eslint.org","size":16526,"stargazers_count":2074,"watchers_count":2074,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":371,"mirror_url":null,"open_issues_count":147,"forks":371,"open_issues":147,"watchers":2074,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/2417"},"html":{"href":"https://github.com/eslint/eslint/pull/2417"},"issue":{"href":"https://api.github.com/repos/eslint/eslint/issues/2417"},"comments":{"href":"https://api.github.com/repos/eslint/eslint/issues/2417/comments"},"review_comments":{"href":"https://api.github.com/repos/eslint/eslint/pulls/2417/comments"},"review_comment":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eslint/eslint/pulls/2417/commits"},"statuses":{"href":"https://api.github.com/repos/eslint/eslint/statuses/69768f6fe978af88a41e1602f54854b9d3d00445"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":27,"deletions":9,"changed_files":2}}